[Qemu-devel] [PATCH 4/7] pseries: Add support for new KVM hash table control call

2012-09-10 Thread David Gibson
From: Ben Herrenschmidt This adds support for then new "reset htab" ioctl which allows qemu to properly cleanup the MMU hash table when the guest is reset. With the corresponding kernel support, reset of a guest now works properly. This also paves the way for indicating a different size hash tab

[Qemu-devel] [PATCH 2/7] pseries: Fix and cleanup CPU initialization and reset

2012-09-10 Thread David Gibson
The current pseries machine init function iterates over the CPUs at several points, doing various bits of initialization. This is messy; these can and should be merged into a single iteration doing all the necessary per cpu initialization. Worse, some of these initializations were setting up stat

[Qemu-devel] [PATCH 7/7] pseries: Fix XICS reset

2012-09-10 Thread David Gibson
The XICS interrupt controller used on the pseries machine currently has no reset handler. We can get away with this under some circumstances, but it's not correct, and can cause failures if the XICS happens to be in the wrong state at the time of reset. This patch adds a hook to properly reset th

[Qemu-devel] [Bug 1037675] Re: Guest Kernel Panic if using "-cpu host" in qemu-kvm 1.1.1

2012-09-10 Thread Michael Tokarev
Correcting myself (comment #2): > And forth, gentoo is very well known for breaking qemu-kvm by their "hardened" patches. Disable the hardening and retry. I mean the (host) KERNEL hardering, not qemu-kvm userspace hardering there. Sorry for any potential confusion. -- You received this bug not

Re: [Qemu-devel] [Bug 1047999] Re: error building process in sdlaudio.o

2012-09-10 Thread Stefan Hajnoczi
On Sat, Sep 8, 2012 at 10:09 PM, Oleg Bobuh wrote: > ** Description changed: Is this qemu.git/master? > ./configure --enable-sdl --enable-virtfs --enable-vnc --enable-cocoa > --enable-mixemu --enable-brlapi --enable-vnc-tls --enable-vnc-sasl > --enable-vnc-jpeg --enable-vnc-png --enable-cu

[Qemu-devel] [PATCH 5/7] pseries: Clear TCE and signal state when resetting PAPR VIO devices

2012-09-10 Thread David Gibson
When we reset the system, the reset method for VIO bus devices resets the state of their request queue (if present) as it should. However it was not resetting the state of their TCE table (DMA translation) if present. It was also not resetting the state of the per-device signal mask set with H_VI

[Qemu-devel] [PATCH 3/7] pseries: Use new method to correct reset sequence

2012-09-10 Thread David Gibson
A number of things need to occur during reset of the PAPR paravirtualized platform in a specific order. For example, the hash table needs to be cleared before the CPUs are reset, so that they initialize their register state correctly, and the CPUs need to have their main reset called before we set

[Qemu-devel] [PATCH 1/7] ppc: Make kvm_arch_put_registers() put *all* the registers

2012-09-10 Thread David Gibson
At least when invoked with high enough 'level' arguments, kvm_arch_put_registers() is supposed to copy essentially all the cpu state as encoded in qemu's internal structures into the kvm state. Currently the ppc version does not do this - it never calls KVM_SET_SREGS, for example, and therefore ne

[Qemu-devel] [PATCH] rtl8139: implement 8139cp link status

2012-09-10 Thread Amos Kong
From: Jason Wang Add a link status chang callback and change the link status bit in BMSR & MSR accordingly. Tested in Linux/Windows guests. Signed-off-by: Jason Wang Signed-off-by: Amos Kong --- hw/rtl8139.c | 23 +-- 1 files changed, 21 insertions(+), 2 deletions(-) di

Re: [Qemu-devel] [PATCH 1/6] libqblock APIs

2012-09-10 Thread Wenchao Xia
> Il 04/09/2012 05:15, Wenchao Xia ha scritto: Can you use GError instead? read through the GError doc, GError is defined as following: struct GError { GQuark domain; gint code; gchar *message; }; I am worried about the message member, I guess program would b

Re: [Qemu-devel] [PATCH] rtl8139: implement 8139cp link status

2012-09-10 Thread Jason Wang
On 09/10/2012 03:59 PM, Amos Kong wrote: From: Jason Wang Add a link status chang callback and change the link status bit in BMSR & MSR accordingly. Tested in Linux/Windows guests. Signed-off-by: Jason Wang Signed-off-by: Amos Kong --- hw/rtl8139.c | 23 +-- 1 files ch

Re: [Qemu-devel] [PATCH 3/6] libqblock error handling

2012-09-10 Thread Wenchao Xia
about the error number defines, I think using union instead of macro will cause additional trouble: int64_t qb_read() In this case return is type int64_t, and it may return the error number, so using unions for error number would not provide much help. Other issues you mentioned have been fi

Re: [Qemu-devel] [PATCH 2/6] libqblock public type defines

2012-09-10 Thread Wenchao Xia
changed to const, thanks. On Tue, Sep 4, 2012 at 7:38 AM, Paolo Bonzini wrote: Il 04/09/2012 09:19, Wenchao Xia ha scritto: +struct QBlockOption_prot_file { QBlockOptionProtFile +char *filename; 'const' There is a problem, this member would be used in information retrieving, s

Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions

2012-09-10 Thread Wenchao Xia
Using unit byte now, thanks. Am 04.09.2012 15:49, schrieb Paolo Bonzini: Il 04/09/2012 13:38, Eric Blake ha scritto: Since qemu does not support it now, yes, you can ignore it for now. But please make sure that you aren't hard-coding it into the API - that is, make sure that the API can somed

[Qemu-devel] [PATCH V2 0/6] libqblock, qemu block layer library

2012-09-10 Thread Wenchao Xia
This patch introduce libqblock API, make libqblock.la and make check-libqblock could build this library. Functionalities: 1 create a new image. 2 sync access of an image. 3 basic image information retrieving such as backing file. 4 detect if a sector is allocated in an image. Supported Format

[Qemu-devel] [PATCH V2 3/6] libqblock error handling

2012-09-10 Thread Wenchao Xia
This patch contains error handling APIs, which user could call them to get error details. Signed-off-by: Wenchao Xia --- libqblock/libqblock-error.c | 60 +++ libqblock/libqblock-error.h | 50 +++ 2 files changed, 110

[Qemu-devel] [PATCH V2 5/6] libqblock building system

2012-09-10 Thread Wenchao Xia
Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones used in qemu, second and third are non PIC and PIC ones in ./libqblock. GCC

[Qemu-devel] [PATCH V2 1/6] libqblock API design

2012-09-10 Thread Wenchao Xia
This patch contains the major APIs in the library. Important APIs: 1 QBroker. These structure was used to retrieve errors, every thread must create one first, later maybe thread related staff could be added into it. 2 QBlockState. It stands for an block image object. 3 QBlockStaticInfo. It

[Qemu-devel] [PATCH V2 2/6] libqblock type and structure defines

2012-09-10 Thread Wenchao Xia
This patch contains type and defines used in APIs, one file for public usage by user, one for libqblock internal usage. Signed-off-by: Wenchao Xia --- libqblock/libqblock-internal.h | 50 libqblock/libqblock-types.h| 251 2 files changed

[Qemu-devel] [PATCH V2 4/6] libqblock export some qemu block function

2012-09-10 Thread Wenchao Xia
Export some qemu qblock functions for libqblock. Signed-off-by: Wenchao Xia --- block.c |2 +- block.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 470bdcc..8b312f8 100644 --- a/block.c +++ b/block.c @@ -196,7 +196,7 @@ static void bdrv_i

[Qemu-devel] [PATCH V2 6/6] libqblock test example

2012-09-10 Thread Wenchao Xia
Created a new directory in tests, and added a simple test case in it. In this example, user first create two qcow2 images, and then get the backing file relationship information of them. Then does write and read sync IO on them. Signed-off-by: Wenchao Xia --- tests/Makefile |

Re: [Qemu-devel] [PATCH] qxl: Ignore set_client_capabilities pre/post migrate

2012-09-10 Thread Gerd Hoffmann
On 09/07/12 21:48, Hans de Goede wrote: > The recent introduction of set_client_capabilities has broken > (seamless) migration by trying to call qxl_send_events pre (seamless > incoming) and post (*) migration, triggering the following assert: > qxl_send_events: Assertion `qemu_spice_display_is_run

Re: [Qemu-devel] [PATCH v5 5/6] i8259: fix so that dropping IRQ level always clears the interrupt request

2012-09-10 Thread Avi Kivity
On 09/10/2012 04:27 AM, Matthew Ogilvie wrote: > Intel's definition of "edge triggered" means: "asserted with a > low-to-high transition at the time an interrupt is registered and > then kept high until the interrupt is served via one of the > EOI mechanisms or goes away unhandled." > > So the onl

Re: [Qemu-devel] Linux KVM, Windows 7 guest choppy sound

2012-09-10 Thread Jan Kiszka
On 2012-09-09 16:50, Avi Kivity wrote: > On 09/08/2012 01:53 PM, Jan Kiszka wrote: >> On 2012-09-07 18:09, Erik Lotspeich wrote: >>> Hi, >>> >>> I apologize if this isn't the right venue for this message, but this >>> mailing list seems a bit more active than qemu-discuss. >>> >>> Background: >>> I

Re: [Qemu-devel] [PATCH v5 5/6] i8259: fix so that dropping IRQ level always clears the interrupt request

2012-09-10 Thread Jan Kiszka
On 2012-09-10 10:56, Avi Kivity wrote: > On 09/10/2012 04:27 AM, Matthew Ogilvie wrote: >> Intel's definition of "edge triggered" means: "asserted with a >> low-to-high transition at the time an interrupt is registered and >> then kept high until the interrupt is served via one of the >> EOI mechan

Re: [Qemu-devel] Linux KVM, Windows 7 guest choppy sound

2012-09-10 Thread Avi Kivity
On 09/10/2012 12:06 PM, Jan Kiszka wrote: >>> Known issue, likely unfixable in QEMU due to hard-coded constraints of >>> the driver Windows uses (too small playback buffers). >> >> Would using real-time priority for the guest improve things? >> >> Of course that can be dangerous if the guest dec

Re: [Qemu-devel] [PATCH v5 5/6] i8259: fix so that dropping IRQ level always clears the interrupt request

2012-09-10 Thread Avi Kivity
On 09/10/2012 12:09 PM, Jan Kiszka wrote: > On 2012-09-10 10:56, Avi Kivity wrote: >> On 09/10/2012 04:27 AM, Matthew Ogilvie wrote: >>> Intel's definition of "edge triggered" means: "asserted with a >>> low-to-high transition at the time an interrupt is registered and >>> then kept high until the

Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu

2012-09-10 Thread Jan Kiszka
On 2012-09-09 17:45, Avi Kivity wrote: > On 09/07/2012 11:50 AM, Jan Kiszka wrote: >> >>> +} else { >>> +cpu_physical_memory_rw(run->mmio.phys_addr, >>> + run->mmio.data, >>> + run->mmio.len, >>>

Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment

2012-09-10 Thread Jan Kiszka
On 2012-09-09 16:13, Avi Kivity wrote: > On 09/06/2012 11:44 AM, Jan Kiszka wrote: >> On 2012-08-30 20:30, Jan Kiszka wrote: >>> This adds PCI device assignment for i386 targets using the classic KVM >>> interfaces. This version is 100% identical to what is being maintained >>> in qemu-kvm for seve

Re: [Qemu-devel] [PATCH uq/master] kvm: Clean up irqfd API

2012-09-10 Thread Jan Kiszka
On 2012-09-09 16:01, Avi Kivity wrote: > On 08/20/2012 11:55 AM, Jan Kiszka wrote: >> No need to expose the fd-based interface, everyone will already be fine >> with the more handy EventNotifier variant. Rename the latter to clarify >> that we are still talking about irqfds here. > > Thanks, appli

Re: [Qemu-devel] [PATCH v5 5/6] i8259: fix so that dropping IRQ level always clears the interrupt request

2012-09-10 Thread Jan Kiszka
On 2012-09-10 11:18, Avi Kivity wrote: > On 09/10/2012 12:09 PM, Jan Kiszka wrote: >> On 2012-09-10 10:56, Avi Kivity wrote: >>> On 09/10/2012 04:27 AM, Matthew Ogilvie wrote: Intel's definition of "edge triggered" means: "asserted with a low-to-high transition at the time an interrupt is

Re: [Qemu-devel] [PATCH 1/7] target-i386: Fold -cpu ?cpuid, ?model output into -cpu help, drop ?dump

2012-09-10 Thread Igor Mammedov
On Wed, 5 Sep 2012 17:41:07 -0300 Eduardo Habkost wrote: > From: Peter Maydell > > Commit c8057f95 (accidentally) disabled the ability to pass > option strings starting with '?' to the target-specific > cpu_list function, so the target-i386 specific "-cpu ?dump", > "-cpu ?cpuid" and "-cpu ?mod

Re: [Qemu-devel] [PATCH 2/7] Drop cpu_list_id macro

2012-09-10 Thread Igor Mammedov
On Wed, 5 Sep 2012 17:41:08 -0300 Eduardo Habkost wrote: > From: Peter Maydell > > Since the only user of the extended cpu_list_id() format > was the x86 ?model/?dump/?cpuid output, we can drop it > completely. > > Signed-off-by: Peter Maydell > Signed-off-by: Eduardo Habkost > Reviewed-by:

Re: [Qemu-devel] [PATCH 3/7] i386: add missing CPUID_* constants

2012-09-10 Thread Igor Mammedov
On Wed, 5 Sep 2012 17:41:09 -0300 Eduardo Habkost wrote: > Those constants will be used by new CPU model definitions. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.h | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/target-i386/cpu.h b/target-i386/

[Qemu-devel] [Bug 1037675] Re: Guest Kernel Panic if using "-cpu host" in qemu-kvm 1.1.1

2012-09-10 Thread Till Schäfer
thx for the patience, i am currently very busy, therefore this took a bit longer than it was planed: - using a non hardened kernel (gentoo-sources-3.3.8) does not resolve the issue therefore i need to use the serial console, which is somewhat new to me. i will do this as soon as i find some time

[Qemu-devel] [Bug 1037675] Re: Guest Kernel Panic if using "-cpu host" in qemu-kvm 1.1.1

2012-09-10 Thread Till Schäfer
** Attachment added: "guest output of kernel panic (serial console output)" https://bugs.launchpad.net/qemu/+bug/1037675/+attachment/3305265/+files/serial_out.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launch

[Qemu-devel] [Bug 1037675] Re: Guest Kernel Panic if using "-cpu host" in qemu-kvm 1.1.1

2012-09-10 Thread Till Schäfer
ok getting the serial console to work was not that hard. here is the relevant serial output of the failing guest (full output is attached as file): [0.010706] mce: CPU supports 10 MCE banks [0.011279] ACPI: Core revision 20110623 [0.014769] ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1

Re: [Qemu-devel] [PATCH V9 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-10 Thread Julien Grall
On 09/09/2012 03:22 PM, Avi Kivity wrote: On 09/04/2012 06:13 PM, Julien Grall wrote: This patch replaces all register_ioport* with the new memory API. It permits to use the new Memory stuff like listener. @@ -200,8 +212,11 @@ static void pm_io_space_update(PIIX4PMState *s)

[Qemu-devel] [PATCH 1/2] ehci: Fix interrupts stopping when Interrupt Threshold Control is 8

2012-09-10 Thread Hans de Goede
If Interrupt Threshold Control is 8 or a multiple of 8, then s->usbsts_frindex can become exactly 0x4000, at which point (s->usbsts_frindex > s->frindex) will never become true, as s->usbsts_frindex will not be lowered / reset in this case. This patch fixes this. Signed-off-by: Hans de Goede ---

[Qemu-devel] [PATCH 0/2] ehci: Misc fixes

2012-09-10 Thread Hans de Goede
Here is a better version of the "ehci: Don't process too much frames in 1 timer tick" patch, replacing the one from my last pull-req, as well as a small bugfix for an issue I noticed while working on this. Thanks & Regards, Hans

[Qemu-devel] [PATCH 2/2] ehci: Don't process too much frames in 1 timer tick (v2)

2012-09-10 Thread Hans de Goede
The Linux ehci isoc scheduling code fills the entire schedule ahead of time minus 80 frames. If we make a large jump in where we are in the schedule, ie 40 frames, then the scheduler all of a sudden will only have 40 frames left to work in, causing it to fail packet submissions with error -27 (-EFB

Re: [Qemu-devel] [Bug 1037675] Re: Guest Kernel Panic if using "-cpu host" in qemu-kvm 1.1.1

2012-09-10 Thread Gleb Natapov
On Mon, Sep 10, 2012 at 10:23:26AM -, Till Schäfer wrote: > [0.027998] Process swapper/0 (pid: 1, threadinfo 88000f8b8000, task > 88000f8b) > [0.027998] Stack: > [0.027998] 81b1b550 88000f8b9ef0 > 81aa4989 > [0.027998] 000

Re: [Qemu-devel] [PATCH V9 4/8] hw/acpi_piix4.c: replace register_ioport*

2012-09-10 Thread Avi Kivity
On 09/10/2012 01:37 PM, Julien Grall wrote: > On 09/09/2012 03:22 PM, Avi Kivity wrote: >> On 09/04/2012 06:13 PM, Julien Grall wrote: >> >>> This patch replaces all register_ioport* with the new memory API. It >>> permits >>> to use the new Memory stuff like listener. >>> >>> >> >>> @@

Re: [Qemu-devel] [PATCH] Don't require encryption password for 'qemu-img info' command

2012-09-10 Thread Kevin Wolf
Am 04.09.2012 16:23, schrieb Kevin Wolf: > Am 31.08.2012 19:30, schrieb Eric Blake: >> On 08/31/2012 10:26 AM, Daniel P. Berrange wrote: >>> From: "Daniel P. Berrange" >>> >>> The encryption password is only required if I/O is going to be >>> performed on a disk image. The 'qemu-img info' command

[Qemu-devel] qemu-kvm log

2012-09-10 Thread Liu, Jinsong
Hi, I'm recently debugging a qemu-kvm issue. I add some print code like 'fprintf(stderr, ...)', however I fail to see any info at stdio. Anyone can tell me where is qemu-kvm logfile, or, what I need do to record my fprintf info? Thanks, Jinsong

Re: [Qemu-devel] [PATCH] Don't require encryption password for 'qemu-img info' command

2012-09-10 Thread Daniel P. Berrange
On Mon, Sep 10, 2012 at 12:44:52PM +0200, Kevin Wolf wrote: > Am 04.09.2012 16:23, schrieb Kevin Wolf: > > Am 31.08.2012 19:30, schrieb Eric Blake: > >> On 08/31/2012 10:26 AM, Daniel P. Berrange wrote: > >>> From: "Daniel P. Berrange" > >>> > >>> The encryption password is only required if I/O is

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Peter Lieven
On 09/06/12 16:58, Avi Kivity wrote: On 08/22/2012 06:06 PM, Peter Lieven wrote: Hi, has anyone ever tested to run memtest with -cpu host flag passed to qemu-kvm? For me it resets when probing the chipset. With -cpu qemu64 it works just fine. Maybe this is specific to memtest, but it might be

[Qemu-devel] [PATCH v2] Don't require encryption password for 'qemu-img info' command

2012-09-10 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The encryption password is only required if I/O is going to be performed on a disk image. The 'qemu-img info' command merely reports metadata, so it should not ask for a decryption password Signed-off-by: Daniel P. Berrange --- qemu-img.c | 21 +++--

[Qemu-devel] [PATCH v2] Add ability to force enable/disable of tools build

2012-09-10 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The qemu-img, qemu-nbd and qemu-io tools are built conditionally based on whether any softmmu target is enabled. These are useful self-contained tools which can be used in many other scenarios. Add new --enable-tools/--disable-tools args to configure to allow the user t

[Qemu-devel] [PATCH v2] Add ability to disable build of all targets

2012-09-10 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Allow passing of '--target-list=' to configure to request that all targets are to be disabled. This allows for doing a very fast tools-only build of things like qemu-img, qemu-io, qemu-nbd. Signed-off-by: Daniel P. Berrange --- configure | 13 - 1 file ch

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Paolo Bonzini
Il 10/09/2012 13:06, Peter Lieven ha scritto: > > qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_entry: vcpu 0 > qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_exit: reason MSR_READ rip > 0x11478 info 0 0 > qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_msr: msr_read 194 = 0x0 (#GP) > qemu-kvm-1.0.1-510

[Qemu-devel] [PATCH 1/2] tcg/optimize: fix end of basic bloc detection

2012-09-10 Thread Aurelien Jarno
Commit e31b0a7c050711884ad570fe73df806520953618 fixed copy propagation on 32-bit host by restricting the copy between different types. This was the wrong fix. The real problem is that the all temps states should be reset at the end of a basic bloc. This was done by adding such operations in the sw

[Qemu-devel] [PATCH 2/2] Revert "TCG: fix copy propagation"

2012-09-10 Thread Aurelien Jarno
Given the copy propagation breakage on 32-bit hosts has been fixed commit e31b0a7c050711884ad570fe73df806520953618 can be reverted. Cc: Blue Swirl Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 15 ++- tcg/tcg.h |5 - 2 files changed, 6 insertions(+), 14 deletions

[Qemu-devel] [PULL 00/12] s390 patch queue 2012-09-10

2012-09-10 Thread Alexander Graf
Hi Blue / Aurelien, This is my current patch queue for s390. Please pull. It contains: - tcg fix for s390 hosts - convert s390 target to be areg0 free Alex The following changes since commit 0c267217ca9985e6d118ec8368bebd382db7a099: Jan Kiszka (1): musicpal: Fix flash mapping

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Peter Lieven
On 09/10/12 13:29, Paolo Bonzini wrote: Il 10/09/2012 13:06, Peter Lieven ha scritto: qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_entry: vcpu 0 qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_exit: reason MSR_READ rip 0x11478 info 0 0 qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_msr: msr_read 194

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Peter Lieven
On 09/10/12 13:29, Paolo Bonzini wrote: Il 10/09/2012 13:06, Peter Lieven ha scritto: qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_entry: vcpu 0 qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_exit: reason MSR_READ rip 0x11478 info 0 0 qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_msr: msr_read 194

[Qemu-devel] [PATCH 11/12] target-s390x: switch to AREG0 free mode

2012-09-10 Thread Alexander Graf
From: Blue Swirl Add an explicit CPUState parameter instead of relying on AREG0. Remove temporary wrappers and switch to AREG0 free mode. Signed-off-by: Blue Swirl [agraf: fix conflicts] Signed-off-by: Alexander Graf --- configure |2 +- target-s390x/Makefile.objs |2

[Qemu-devel] [PATCH] tcg/i386: allow constants in load/store ops

2012-09-10 Thread Aurelien Jarno
On x86, it is possible to move a constant value to memory. Add code to handle a constant argument to load/store ops. Signed-off-by: Aurelien Jarno --- tcg/i386/tcg-target.c | 50 - 1 file changed, 37 insertions(+), 13 deletions(-) diff --git a/t

[Qemu-devel] [PATCH 03/12] target-s390x: split condition code helpers

2012-09-10 Thread Alexander Graf
From: Blue Swirl Move condition code helpers to cc_helper.c. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf --- target-s390x/Makefile.objs |3 +- target-s390x/cc_helper.c | 551 target-s390x/cpu.h |3 + target-s390x/op_h

[Qemu-devel] [PATCH 02/12] target-s390x: split FPU ops

2012-09-10 Thread Alexander Graf
From: Blue Swirl Move floating point instructions to fpu_helper.c. While exporting some condition code helpers, avoid duplicate identifier conflict with translate.c. Remove unused set_cc_nz_f64() in translate.c. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf --- target-s390x/Makefi

Re: [Qemu-devel] [PATCH] tcg/s390: fix ld/st with CONFIG_TCG_PASS_AREG0

2012-09-10 Thread Alexander Graf
On 08.09.2012, at 15:45, Aurelien Jarno wrote: > The load/store slow path has been broken in e141ab52d: > - We need to move 4 registers for store functions and 3 registers for > load functions and not the reverse. > - According to the s390x calling convention the arguments of a function > shoul

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Avi Kivity
On 09/10/2012 02:29 PM, Paolo Bonzini wrote: > Il 10/09/2012 13:06, Peter Lieven ha scritto: >> >> qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_entry: vcpu 0 >> qemu-kvm-1.0.1-5107 [007] 410771.148000: kvm_exit: reason MSR_READ rip >> 0x11478 info 0 0 >> qemu-kvm-1.0.1-5107 [007] 410771.148000: kv

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Paolo Bonzini
Il 10/09/2012 13:52, Peter Lieven ha scritto: >> dd if=/dev/cpu/0/msr skip=$((0x194)) bs=8 count=1 | xxd >> dd if=/dev/cpu/0/msr skip=$((0xCE)) bs=8 count=1 | xxd > it only works without the skip. but the msr device returns all zeroes. Hmm, the strange API of the MSR device doesn't work well with

[Qemu-devel] [PATCH 06/12] target-s390x: rename op_helper.c to misc_helper.c

2012-09-10 Thread Alexander Graf
From: Blue Swirl Now op_helper.c contains miscellaneous helpers, rename it to misc_helper.c. Signed-off-by: Blue Swirl [agraf: fix conflict] Signed-off-by: Alexander Graf --- target-s390x/Makefile.objs |6 +++--- target-s390x/cpu.h |2 +- targ

Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C

2012-09-10 Thread Igor Mammedov
On Wed, 5 Sep 2012 17:41:10 -0300 Eduardo Habkost wrote: > Those models are maintained by QEMU and may require compatibility code > to be added when making some changes. Keeping the data in the C source > code should make it simpler to handle those details. > > Signed-off-by: Eduardo Habkost >

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Gleb Natapov
On Mon, Sep 10, 2012 at 02:15:49PM +0200, Paolo Bonzini wrote: > Il 10/09/2012 13:52, Peter Lieven ha scritto: > >> dd if=/dev/cpu/0/msr skip=$((0x194)) bs=8 count=1 | xxd > >> dd if=/dev/cpu/0/msr skip=$((0xCE)) bs=8 count=1 | xxd > > it only works without the skip. but the msr device returns all

[Qemu-devel] KVM call agenda for Tuesday, September 11th

2012-09-10 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C

2012-09-10 Thread Igor Mammedov
On Mon, 10 Sep 2012 14:18:38 +0200 Igor Mammedov wrote: > On Wed, 5 Sep 2012 17:41:10 -0300 > Eduardo Habkost wrote: > > > Those models are maintained by QEMU and may require compatibility code > > to be added when making some changes. Keeping the data in the C source > > code should make it s

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Avi Kivity
On 09/10/2012 03:29 PM, Peter Lieven wrote: > On 09/10/12 14:21, Gleb Natapov wrote: >> On Mon, Sep 10, 2012 at 02:15:49PM +0200, Paolo Bonzini wrote: >>> Il 10/09/2012 13:52, Peter Lieven ha scritto: > dd if=/dev/cpu/0/msr skip=$((0x194)) bs=8 count=1 | xxd > dd if=/dev/cpu/0/msr skip=$((0

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Peter Lieven
On 09/10/12 14:32, Avi Kivity wrote: On 09/10/2012 03:29 PM, Peter Lieven wrote: On 09/10/12 14:21, Gleb Natapov wrote: On Mon, Sep 10, 2012 at 02:15:49PM +0200, Paolo Bonzini wrote: Il 10/09/2012 13:52, Peter Lieven ha scritto: dd if=/dev/cpu/0/msr skip=$((0x194)) bs=8 count=1 | xxd dd if=/d

[Qemu-devel] [PATCH 10/12] target-s390x: avoid AREG0 for misc helpers

2012-09-10 Thread Alexander Graf
From: Blue Swirl Make misc helpers take a parameter for CPUState instead of relying on global env. Signed-off-by: Blue Swirl [agraf: fix conflict] Signed-off-by: Alexander Graf --- target-s390x/Makefile.objs |1 - target-s390x/helper.h | 26 ++-- target-s390x/mem_he

[Qemu-devel] [PATCH v2 0/3] Rework copy propagation

2012-09-10 Thread Aurelien Jarno
This is the second attempt to rework the copy propagation and restore it to its original state. In the first version, optimization was possible around set_label, causing a TCG crash in some cases. The first patch of this new series fix that. The two others are unchanged. Aurelien Jarno (3): tcg

[Qemu-devel] [PATCH v2 1/3] tcg: mark set_label with TCG_OPF_BB_END flag

2012-09-10 Thread Aurelien Jarno
set_label is effectively the end of a basic bloc, as no optimization can be made accross it. It was treated as such in the liveness analysis code, but as a special case. Mark it with TCG_OPF_BB_END flag so that this information can be used by other parts of the TCG code, and remove the special cas

[Qemu-devel] [PATCH v2 3/3] revert "TCG: fix copy propagation"

2012-09-10 Thread Aurelien Jarno
Given the copy propagation breakage on 32-bit hosts has been fixed commit e31b0a7c050711884ad570fe73df806520953618 can be reverted. Cc: Blue Swirl Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 15 ++- tcg/tcg.h |5 - 2 files changed, 6 insertions(+), 14 deletions

[Qemu-devel] [PATCH v2 2/3] tcg/optimize: fix end of basic bloc detection

2012-09-10 Thread Aurelien Jarno
Commit e31b0a7c050711884ad570fe73df806520953618 fixed copy propagation on 32-bit host by restricting the copy between different types. This was the wrong fix. The real problem is that the all temps states should be reset at the end of a basic bloc. This was done by adding such operations in the sw

Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment

2012-09-10 Thread Avi Kivity
On 09/10/2012 12:26 PM, Jan Kiszka wrote: >> >> Is patch 4 the only one that is at v3, and the rest are to be taken from >> the original posting? > > That is correct. Thanks, applied to uq/master, will push shortly. -- error compiling committee.c: too many arguments to function

[Qemu-devel] [PATCH 09/12] target-s390x: avoid AREG0 for condition code helpers

2012-09-10 Thread Alexander Graf
From: Blue Swirl Make condition code helpers take a parameter for CPUState instead of relying on global env. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf --- target-s390x/Makefile.objs |1 - target-s390x/cc_helper.c | 11 +-- target-s390x/helper.h | 10 +-

[Qemu-devel] [PATCH 12/12] tcg/s390: fix ld/st with CONFIG_TCG_PASS_AREG0

2012-09-10 Thread Alexander Graf
From: Aurelien Jarno The load/store slow path has been broken in e141ab52d: - We need to move 4 registers for store functions and 3 registers for load functions and not the reverse. - According to the s390x calling convention the arguments of a function should be zero extended. This means tha

Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C

2012-09-10 Thread Igor Mammedov
On Mon, 10 Sep 2012 14:31:49 +0200 Igor Mammedov wrote: > On Mon, 10 Sep 2012 14:18:38 +0200 > Igor Mammedov wrote: > > > On Wed, 5 Sep 2012 17:41:10 -0300 > > Eduardo Habkost wrote: > > > > > Those models are maintained by QEMU and may require compatibility code > > > to be added when makin

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-10 Thread Peter Lieven
On 09/10/12 14:21, Gleb Natapov wrote: On Mon, Sep 10, 2012 at 02:15:49PM +0200, Paolo Bonzini wrote: Il 10/09/2012 13:52, Peter Lieven ha scritto: dd if=/dev/cpu/0/msr skip=$((0x194)) bs=8 count=1 | xxd dd if=/dev/cpu/0/msr skip=$((0xCE)) bs=8 count=1 | xxd it only works without the skip. but

[Qemu-devel] [PATCH 08/12] target-s390x: avoid AREG0 for integer helpers

2012-09-10 Thread Alexander Graf
From: Blue Swirl Make integer helpers take a parameter for CPUState instead of relying on global env. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf --- target-s390x/Makefile.objs |1 - target-s390x/helper.h | 10 +- target-s390x/int_helper.c | 12 ++--

Re: [Qemu-devel] [PATCH v5 5/6] i8259: fix so that dropping IRQ level always clears the interrupt request

2012-09-10 Thread Maciej W. Rozycki
On Mon, 10 Sep 2012, Avi Kivity wrote: > >>> So the only difference between edge triggered and level triggered > >>> is in the leading edge, with no difference in the trailing edge. > >> > >> Hard to believe. So an edge while cpu interrupts are disabled is ignored? Please note that x86 CPU's I

[Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-09-10 Thread Alberto Garcia
On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: > We are currently in Hard Freeze, new devices will not get accepted > before the release, and our review may focus on bug fixes. QEMU 1.2 has been released, so here's the new ping. Patches here: http://patchwork.ozlabs.org/patch/1

Re: [Qemu-devel] [PULL 00/12] s390 patch queue 2012-09-10

2012-09-10 Thread Aurelien Jarno
On Mon, Sep 10, 2012 at 01:40:45PM +0200, Alexander Graf wrote: > Hi Blue / Aurelien, > > This is my current patch queue for s390. Please pull. > > It contains: > > - tcg fix for s390 hosts > - convert s390 target to be areg0 free > > Alex > > > The following changes since commit 0c26721

[Qemu-devel] [PATCH 07/12] target-s390x: avoid AREG0 for FPU helpers

2012-09-10 Thread Alexander Graf
From: Blue Swirl Make FPU helpers take a parameter for CPUState instead of relying on global env. Introduce temporary wrappers for FPU load and store ops. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf --- target-s390x/Makefile.objs |1 - target-s390x/cc_helper.c |4 +- ta

Re: [Qemu-devel] [PATCH] hw/wm8750: Fix potential buffer overflow

2012-09-10 Thread Aurelien Jarno
On Mon, Sep 03, 2012 at 10:56:00PM +0200, Stefan Weil wrote: > Report from smatch: > > hw/wm8750.c:369 wm8750_tx(12) error: buffer overflow 's->i2c_data' 2 <= 2 > > It looks like the preprocessor statements were simply misplaced. > > Replace also __FUNCTION__ by __func__ to please checkpatch.pl.

Re: [Qemu-devel] [PATCH] target-arm: Fix potential buffer overflow

2012-09-10 Thread Aurelien Jarno
On Tue, Sep 04, 2012 at 07:35:57AM +0200, Stefan Weil wrote: > Report from smatch: > > target-arm/helper.c:651 arm946_prbs_read(6) error: > buffer overflow 'env->cp15.c6_region' 8 <= 8 > target-arm/helper.c:661 arm946_prbs_write(6) error: > buffer overflow 'env->cp15.c6_region' 8 <= 8 > > c7_re

[Qemu-devel] [PATCH 04/12] target-s390x: split integer helpers

2012-09-10 Thread Alexander Graf
From: Blue Swirl Move integer helpers to int_helper.c. Signed-off-by: Blue Swirl Signed-off-by: Alexander Graf --- target-s390x/Makefile.objs |3 +- target-s390x/int_helper.c | 201 target-s390x/op_helper.c | 170 --

Re: [Qemu-devel] [PATCH] hw/mcf5206: Fix buffer overflow for MBAR read / write

2012-09-10 Thread Aurelien Jarno
On Tue, Sep 04, 2012 at 07:37:39PM +0200, Stefan Weil wrote: > Report from smatch: > > mcf5206.c:384 m5206_mbar_readb(7) error: buffer overflow 'm5206_mbar_width' > 128 <= 128 > mcf5206.c:403 m5206_mbar_readw(8) error: buffer overflow 'm5206_mbar_width' > 128 <= 128 > mcf5206.c:427 m5206_mbar_re

Re: [Qemu-devel] [PULL 00/19]: QMP queue

2012-09-10 Thread Aurelien Jarno
On Wed, Sep 05, 2012 at 03:58:27PM -0300, Luiz Capitulino wrote: > Let's get the ball rolling for QMP in 1.3 :) > > This pull request contains the send-key command conversion, screendump qapi > conversion and a few fixes. > > The changes (since f45ddd14209a4d1b95a4096d50a561b7f6270118) are availa

Re: [Qemu-devel] [PATCH 14/22] target-i386: use visit_type_hz to parse tsc_freq property value

2012-09-10 Thread Andreas Färber
Am 07.09.2012 22:55, schrieb Igor Mammedov: > Signed-off-by: Igor Mammedov Thanks, Reviewed-by: Andreas Färber > v2: > * use visit_type_freq() which replaced visit_type_hz() Change Logs are usually requested to go in the cover letter or below --- so it does not go into git history. Andreas

Re: [Qemu-devel] [PATCH 2/2] cpu_physical_memory_write_rom() needs to do TB invalidates

2012-09-10 Thread Andreas Färber
Am 10.09.2012 04:30, schrieb David Gibson: > cpu_physical_memory_write_rom(), despite the name, can also be used to > write images into RAM - and will often be used that way if the machine > uses load_image_targphys() into RAM addresses. > > However, cpu_physical_memory_write_rom(), unlike cpu_phy

Re: [Qemu-devel] [PULL 00/14] spice patch queue

2012-09-10 Thread Aurelien Jarno
On Thu, Sep 06, 2012 at 09:21:26AM +0200, Gerd Hoffmann wrote: > Hi, > > Here comes the spice patch queue with a bunch of fresh patches for 1.3. > A new qmp event is there, to fix spice client migration races, and a > bunch of patches needed to make use of the new goodies the upcoming > spice-se

Re: [Qemu-devel] qemu-kvm log

2012-09-10 Thread Avi Kivity
On 09/10/2012 01:44 PM, Liu, Jinsong wrote: > Hi, > > I'm recently debugging a qemu-kvm issue. I add some print code like > 'fprintf(stderr, ...)', however I fail to see any info at stdio. Anyone can > tell me where is qemu-kvm logfile, or, what I need do to record my fprintf > info? If you'r

Re: [Qemu-devel] [PATCH 0/2] ehci: Misc fixes

2012-09-10 Thread Gerd Hoffmann
On 09/10/12 12:44, Hans de Goede wrote: > Here is a better version of the "ehci: Don't process too much frames in 1 > timer tick" patch, replacing the one from my last pull-req, as well as a > small bugfix for an issue I noticed while working on this. > > Thanks & Regards, > > Hans Patches added

Re: [Qemu-devel] [PULL 00/54] usb patch queue

2012-09-10 Thread Gerd Hoffmann
Hi, > | hw/usb/hcd-xhci.c: In function ‘xhci_fire_ctl_transfer’: > | hw/usb/hcd-xhci.c:1508:14: error: variable ‘wLength’ set but not used > [-Werror=unused-but-set-variable] Pushed updated branch usb.63 (same as usb.62 + one incremental fix). cheers, Gerd

Re: [Qemu-devel] [PATCH] tcg/i386: allow constants in load/store ops

2012-09-10 Thread Richard Henderson
On Mon, 2012-09-10 at 13:56 +0200, Aurelien Jarno wrote: > On x86, it is possible to move a constant value to memory. Add code to > handle a constant argument to load/store ops. > > Signed-off-by: Aurelien Jarno While useful, you'll find that most constants that want storing to memory are not g

Re: [Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C

2012-09-10 Thread Igor Mammedov
On Wed, 5 Sep 2012 17:41:10 -0300 Eduardo Habkost wrote: > Those models are maintained by QEMU and may require compatibility code > to be added when making some changes. Keeping the data in the C source > code should make it simpler to handle those details. > > Signed-off-by: Eduardo Habkost >

Re: [Qemu-devel] [PULL 00/54] usb patch queue

2012-09-10 Thread Aurelien Jarno
On Thu, Sep 06, 2012 at 09:12:01AM +0200, Gerd Hoffmann wrote: > Hi, > > Here comes the usb patch queue with a bunch of new goodies accumulated > while qemu was in freeze for the 1.2 release: > > * ehci gets more tracepoints & improvements in the queuing code and >minor bugfixes (the impor

Re: [Qemu-devel] [PATCH 2/7] pseries: Fix and cleanup CPU initialization and reset

2012-09-10 Thread Andreas Färber
Am 10.09.2012 08:38, schrieb David Gibson: > The current pseries machine init function iterates over the CPUs at several > points, doing various bits of initialization. This is messy; these can > and should be merged into a single iteration doing all the necessary per > cpu initialization. Worse,

  1   2   >