Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-20 Thread Michael S. Tsirkin
@@ -526,16 +592,19 @@ int inet_connect(const char *str, Error **errp) return sock; } - -int inet_nonblocking_connect(const char *str, bool *in_progress, - Error **errp) +int inet_nonblocking_connect(const char *str, ConnectHandler *callback, +

[Qemu-devel] buildbot failure in qemu on block_mingw32

2012-09-20 Thread qemu
The Buildbot has detected a new failure on builder block_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/329 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason:

[Qemu-devel] buildbot failure in qemu on block_openbsd_4.9

2012-09-20 Thread qemu
The Buildbot has detected a new failure on builder block_openbsd_4.9 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_openbsd_4.9/builds/329 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_openbsd49 Build

Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-09-20 Thread Gerd Hoffmann
Hi, +if (surface) { +pixman_image_unref(surface); } +surface = pixman_from_displaystate(ds); Am I reading this right? Are you creating a new pixman surface in every call to fbdev_update? No. The whole block doing this is wrapped into if

Re: [Qemu-devel] [PATCH v2] add a boot parameter to set reboot timeout

2012-09-20 Thread Gleb Natapov
On Thu, Sep 20, 2012 at 11:15:26AM +0800, Amos Kong wrote: On 07/09/12 11:11, Amos Kong wrote: Added an option to let qemu transfer a configuration file to bios, etc/boot-fail-wait, which could be specified by command -boot reboot-timeout=T T have a max value of 0x, unit is ms.

Re: [Qemu-devel] [PATCH v7 2/5] sockets: Change inet_parse() to accept address specification without port

2012-09-20 Thread Bharata B Rao
On Tue, Sep 18, 2012 at 04:08:43PM +0200, Kevin Wolf wrote: Am 18.09.2012 15:31, schrieb Paolo Bonzini: Il 18/09/2012 15:22, Kevin Wolf ha scritto: Am 17.09.2012 17:23, schrieb Bharata B Rao: sockets: Change inet_parse() to accept address specification without port From: Bharata B Rao

[Qemu-devel] buildbot failure in qemu on block_i386_debian_6_0

2012-09-20 Thread qemu
The Buildbot has detected a new failure on builder block_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_i386_debian_6_0/builds/394 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build

[Qemu-devel] buildbot failure in qemu on block_x86_64_debian_6_0

2012-09-20 Thread qemu
The Buildbot has detected a new failure on builder block_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_x86_64_debian_6_0/builds/394 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

Re: [Qemu-devel] [PATCH v7 5/5] block: Support GlusterFS as a QEMU block backend.

2012-09-20 Thread Bharata B Rao
On Tue, Sep 18, 2012 at 04:01:58PM +0200, Kevin Wolf wrote: + +#define GLUSTER_TRANSPORT_DEFAULTgluster:// +#define GLUSTER_TRANSPORT_DEFAULT_SZ strlen(GLUSTER_TRANSPORT_DEFAULT) +#define GLUSTER_TRANSPORT_TCPgluster+tcp:// +#define GLUSTER_TRANSPORT_TCP_SZ

Re: [Qemu-devel] [PATCH] qxl/update_area_io: cleanup invalid parameters handling

2012-09-20 Thread Gerd Hoffmann
On 09/19/12 15:41, Michael Tokarev wrote: This cleans up two additions of almost the same code in commits 511b13e2c9 and ccc2960d654. While at it, make error paths consistent (always use 'break' instead of 'return'). Other way around: should be 'return' not 'break'. cheers, Gerd

Re: [Qemu-devel] [PATCH] qxl/update_area_io: cleanup invalid parameters handling

2012-09-20 Thread Michael Tokarev
On 20.09.2012 10:41, Gerd Hoffmann wrote: On 09/19/12 15:41, Michael Tokarev wrote: This cleans up two additions of almost the same code in commits 511b13e2c9 and ccc2960d654. While at it, make error paths consistent (always use 'break' instead of 'return'). Other way around: should be

Re: [Qemu-devel] [PATCH] qxl/update_area_io: cleanup invalid parameters handling

2012-09-20 Thread Gerd Hoffmann
On 09/20/12 08:43, Michael Tokarev wrote: For now it is irrelevant actually, since right after the switch we already have return, so break is now the same as return. For future it might not be the case. Oh, right. Patch added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v7 2/5] sockets: Change inet_parse() to accept address specification without port

2012-09-20 Thread Kevin Wolf
Am 20.09.2012 08:30, schrieb Bharata B Rao: On Tue, Sep 18, 2012 at 04:08:43PM +0200, Kevin Wolf wrote: Am 18.09.2012 15:31, schrieb Paolo Bonzini: Il 18/09/2012 15:22, Kevin Wolf ha scritto: Am 17.09.2012 17:23, schrieb Bharata B Rao: sockets: Change inet_parse() to accept address

Re: [Qemu-devel] [RFC PATCH 10/16] qcow2: Delay the COW

2012-09-20 Thread Kevin Wolf
Am 19.09.2012 20:47, schrieb Blue Swirl: On Tue, Sep 18, 2012 at 11:40 AM, Kevin Wolf kw...@redhat.com wrote: Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 29 + block/qcow2.c | 31 ---

Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-20 Thread Abel Gordon
GaoYi gaoyi...@gmail.com wrote on 20/09/2012 08:42:51 AM:    The CPU isolation in Hitachi patches is just to improve the real time performance of GUEST. The core of it, direct IRQ delivery, is very similar to that of ELI.     For the ELI patches,     (1) Since EOI part of ELI is already

Re: [Qemu-devel] Any plan to support armv8 emulation

2012-09-20 Thread Wei-Ren Chen
Hi, On Thu, Sep 20, 2012 at 11:42:18AM +0800, Michael.Kang wrote: Is there any developers who have plan to support armv8 emulation? Or have some initial roadmap for support of armv8? I know there is already armv8 patch merged into linux kernel. Never hear of such plan so far. Would you

[Qemu-devel] [0/2] Bugfixes for ppc KVM

2012-09-20 Thread David Gibson
Hi Alex, This series contains two bugfixes for KVM on POWER. 1/2 is a very serious bug where the privilege check for hypercalls will be based on an outdated MSR value. The second has a rather smaller impact; we will do the wrong thing resetting the hash table for certain kernel versions. Both

[Qemu-devel] [PATCH 2/2] target-ppc: KVM: Fix some kernel version edge cases for kvmppc_reset_htab()

2012-09-20 Thread David Gibson
The kvmppc_reset_htab() function invokes the KVM_PPC_ALLOCATE_HTAB vm ioctl to request KVM to allocate and reset a hash page table for the guest - it returns the size of hash table allocated, or 0 to indicate that qemu needs to allocate the hash table itself. In practice qemu needs to allocate

[Qemu-devel] [PATCH 1/2] pseries: Synchronize qemu and KVM state on hypercalls

2012-09-20 Thread David Gibson
Currently the KVM exit path for PAPR hypercalls does not synchronize the qemu cpu state with the KVM state. Mostly this works, because the actual hypercall arguments and return values are explicitly passed through the kvm_run structure. However, the hypercall path includes a privilege check, to

Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-20 Thread Jan Kiszka
On 2012-09-20 08:58, Abel Gordon wrote: GaoYi gaoyi...@gmail.com wrote on 20/09/2012 08:42:51 AM: The CPU isolation in Hitachi patches is just to improve the real time performance of GUEST. The core of it, direct IRQ delivery, is very similar to that of ELI. For the ELI patches,

Re: [Qemu-devel] [PATCH] Added more entries to the LEON processor configuration register

2012-09-20 Thread Ronald Hecht
On 09/19/2012 08:56 PM, Blue Swirl wrote: --- a/target-sparc/translate.c +++ b/target-sparc/translate.c @@ -2590,13 +2590,9 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) microSPARC II */ /* Read Asr17 */

Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-20 Thread Gleb Natapov
On Thu, Sep 20, 2012 at 09:14:31AM +0200, Jan Kiszka wrote: On 2012-09-20 08:58, Abel Gordon wrote: GaoYi gaoyi...@gmail.com wrote on 20/09/2012 08:42:51 AM: The CPU isolation in Hitachi patches is just to improve the real time performance of GUEST. The core of it, direct IRQ

Re: [Qemu-devel] [PATCH v2 7/7] s390/kvm: In-kernel channel subsystem support.

2012-09-20 Thread Christian Borntraeger
On 19/09/12 16:47, Alexander Graf wrote: On 04.09.2012, at 17:13, Cornelia Huck wrote: Handle most support for channel I/O instructions in the kernel itself. Only asynchronous functions (such as the start function) need to be handled by userspace. Phew. This is a lot of code for

Re: [Qemu-devel] [PATCH RFC] hw/grlib: SMP support added to LEON interrupt controller

2012-09-20 Thread Ronald Hecht
On 09/19/2012 09:19 PM, Blue Swirl wrote: On Wed, Sep 19, 2012 at 3:30 PM, Ronald Hechtronald.he...@gmx.de wrote: This patch adds SMP support to the LEON SPARC interrupt controller. I don't like that CPU status (halted/not halted) is accessed directly from the interrupt controller. How can

Re: [Qemu-devel] [PATCH 1/2] pseries: Synchronize qemu and KVM state on hypercalls

2012-09-20 Thread Alexander Graf
On 20.09.2012, at 09:08, David Gibson wrote: Currently the KVM exit path for PAPR hypercalls does not synchronize the qemu cpu state with the KVM state. Mostly this works, because the actual hypercall arguments and return values are explicitly passed through the kvm_run structure. However,

Re: [Qemu-devel] [PATCH v2 3/5] s390: Add new channel I/O based virtio transport.

2012-09-20 Thread Jens Freimann
On Wed, Sep 19, 2012 at 06:12:55PM +0200, Alexander Graf wrote: Just a really quick glimpse. This patch is huge :). On 04.09.2012, at 17:13, Cornelia Huck wrote: Add a new virtio transport that uses channel commands to perform virtio operations. Add a new machine type s390-ccw that

Re: [Qemu-devel] [PATCH 1/2] pseries: Synchronize qemu and KVM state on hypercalls

2012-09-20 Thread Jan Kiszka
On 2012-09-20 09:08, David Gibson wrote: Currently the KVM exit path for PAPR hypercalls does not synchronize the qemu cpu state with the KVM state. Mostly this works, because the actual hypercall arguments and return values are explicitly passed through the kvm_run structure. However, the

Re: [Qemu-devel] [PATCH 3/5] QAPI: Introduce memchar-write QMP command

2012-09-20 Thread Lei Li
On 09/20/2012 02:05 AM, Luiz Capitulino wrote: On Wed, 12 Sep 2012 19:57:24 +0800 Lei Li li...@linux.vnet.ibm.com wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- hmp-commands.hx | 23 ++ hmp.c| 19 +++ hmp.h|1 +

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-20 Thread liu ping fan
On Wed, Sep 19, 2012 at 5:23 PM, Avi Kivity a...@redhat.com wrote: On 09/19/2012 12:19 PM, liu ping fan wrote: On Wed, Sep 19, 2012 at 5:14 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 19/09/2012 11:11, liu ping fan ha scritto: Why not? devA will drop its local lock, devX will retake the

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-20 Thread liu ping fan
On Wed, Sep 19, 2012 at 5:05 PM, Avi Kivity a...@redhat.com wrote: On 09/19/2012 11:36 AM, liu ping fan wrote: It basically means you can't hold contents of device state in local variables. You need to read everything again from the device. That includes things like DMA enable bits. I

Re: [Qemu-devel] [PATCH v7 5/5] block: Support GlusterFS as a QEMU block backend.

2012-09-20 Thread Paolo Bonzini
Il 20/09/2012 08:41, Bharata B Rao ha scritto: Would look a bit nicer with strstart() form cutils.c instead of strncmp(). strstart() works with const char pointers, but I have char pointers here which I need to modify. You can pass a char* to a function that accepts const char*. In your

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-20 Thread Paolo Bonzini
Il 20/09/2012 09:51, liu ping fan ha scritto: Sorry, donot catching your meaning. Does not coarse-fine mean LOCK(coarse)--LOCK(fine); .. UNLOCK(fine)--UNLOCK(coarse) ? Yes. Valid: lock(coarse) lock(fine) But it is conflict with localLock(fine) -- bigLock(coarse) which is

Re: [Qemu-devel] [PATCH 06/12] qapi: add socket address types

2012-09-20 Thread Paolo Bonzini
Il 19/09/2012 19:20, Eric Blake ha scritto: +{ 'type': 'IPSocketAddress', + 'data': { +'host': 'str', +'port': 'str', +'*to': 'uint16', Why is 'port' a string, but 'to' a uint16? Shouldn't they both be uint16? port can be a service name. Paolo

Re: [Qemu-devel] [PATCH 14/12] qmp: add NBD server commands

2012-09-20 Thread Paolo Bonzini
Il 19/09/2012 19:48, Eric Blake ha scritto: Do we need a way to unregister a single device, rather than having to stop the NBD server to unregister all devices? Possibly, but it can be added later. Paolo

Re: [Qemu-devel] [PATCH 01/12] monitor: use monitor_handle_fd_param for non-Error-friendly users of named fds

2012-09-20 Thread Paolo Bonzini
Il 19/09/2012 22:42, Luiz Capitulino ha scritto: On Wed, 19 Sep 2012 16:31:04 +0200 Paolo Bonzini pbonz...@redhat.com wrote: monitor_handle_fd_param and monitor_get_fd are mostly the same, except that monitor_handle_fd_param does error reporting wrong. Use it in all other places that do it

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-20 Thread liu ping fan
On Thu, Sep 20, 2012 at 3:54 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 20/09/2012 09:51, liu ping fan ha scritto: Sorry, donot catching your meaning. Does not coarse-fine mean LOCK(coarse)--LOCK(fine); .. UNLOCK(fine)--UNLOCK(coarse) ? Yes. Valid: lock(coarse) lock(fine)

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-20 Thread liu ping fan
On Wed, Sep 19, 2012 at 5:34 PM, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-09-19 11:00, liu ping fan wrote: On Wed, Sep 19, 2012 at 4:06 PM, Avi Kivity a...@redhat.com wrote: On 09/19/2012 06:02 AM, liu ping fan wrote: Currently, cpu_physical_memory_rw() can be used directly or

Re: [Qemu-devel] [PATCH v7 5/5] block: Support GlusterFS as a QEMU block backend.

2012-09-20 Thread Paolo Bonzini
Il 20/09/2012 09:53, Paolo Bonzini ha scritto: Would look a bit nicer with strstart() form cutils.c instead of strncmp(). strstart() works with const char pointers, but I have char pointers here which I need to modify. You can pass a char* to a function that accepts const char*. In your

Re: [Qemu-devel] [PATCH] block: Set cdrom device read only flag

2012-09-20 Thread Kevin Wolf
Am 13.08.2012 09:54, schrieb Kevin Wolf: Am 12.08.2012 04:48, schrieb Kevin Shanahan: So qmp_change_blockdev uses bdrv_is_read_only() to check whether to try and open the backing file read only, which uses the -read_only member of struct BlockDriverState to decide whether to pass the

[Qemu-devel] [PATCH 1/1] kvmclock: fix guest stop notification

2012-09-20 Thread Amit Shah
Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop notification, but it did it in a way that the stop notification would never reach the kernel. The kvm_vm_state_changed() function gets a value of 0 for the 'running' parameter when the VM is stopped, making all the code added

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-20 Thread Paolo Bonzini
Il 20/09/2012 10:09, liu ping fan ha scritto: No, MMIO dispatch has to discard the fine-grained lock before acquiring the big lock. This will cause the device state broken, and expose device under changing risk. We do it all the time with asynchronous I/O. It's just an invariant that

Re: [Qemu-devel] [PATCH] pflash: Avoid warnings from coverity

2012-09-20 Thread Peter Maydell
On 19 September 2012 21:51, Stefan Weil s...@weilnetz.de wrote: Am 19.09.2012 18:45, schrieb Peter Maydell: ...shouldn't we be propagating the write error up to the guest? It feels like this change is just silencing the coverity error without actually fixing the underlying problem. As far as

Re: [Qemu-devel] Any plan to support armv8 emulation

2012-09-20 Thread Peter Maydell
On 20 September 2012 04:42, Michael.Kang blackfin.k...@gmail.com wrote: Is there any developers who have plan to support armv8 emulation? Or have some initial roadmap for support of armv8? I know there is already armv8 patch merged into linux kernel. Some people have expressed interest.

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-20 Thread Orit Wasserman
On 09/20/2012 09:03 AM, Michael S. Tsirkin wrote: @@ -526,16 +592,19 @@ int inet_connect(const char *str, Error **errp) return sock; } - -int inet_nonblocking_connect(const char *str, bool *in_progress, - Error **errp) +int inet_nonblocking_connect(const

Re: [Qemu-devel] [PATCH 2/2] target-ppc: KVM: Fix some kernel version edge cases for kvmppc_reset_htab()

2012-09-20 Thread Alexander Graf
On 20.09.2012, at 09:08, David Gibson wrote: The kvmppc_reset_htab() function invokes the KVM_PPC_ALLOCATE_HTAB vm ioctl to request KVM to allocate and reset a hash page table for the guest - it returns the size of hash table allocated, or 0 to indicate that qemu needs to allocate the hash

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-20 Thread Avi Kivity
On 09/20/2012 10:51 AM, liu ping fan wrote: On Wed, Sep 19, 2012 at 5:23 PM, Avi Kivity a...@redhat.com wrote: On 09/19/2012 12:19 PM, liu ping fan wrote: On Wed, Sep 19, 2012 at 5:14 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 19/09/2012 11:11, liu ping fan ha scritto: Why not? devA

Re: [Qemu-devel] [PATCH v7 5/5] block: Support GlusterFS as a QEMU block backend.

2012-09-20 Thread Bharata B Rao
On Thu, Sep 20, 2012 at 10:20:33AM +0200, Paolo Bonzini wrote: Il 20/09/2012 09:53, Paolo Bonzini ha scritto: Would look a bit nicer with strstart() form cutils.c instead of strncmp(). strstart() works with const char pointers, but I have char pointers here which I need to modify.

Re: [Qemu-devel] [PATCH v7 5/5] block: Support GlusterFS as a QEMU block backend.

2012-09-20 Thread Paolo Bonzini
Il 20/09/2012 11:12, Bharata B Rao ha scritto: Perhaps it would be cleaner to make qemu_gluster_parseuri and parse_gluster_spec accept a const char *. You can replace strtok_r + g_strdup with strspn/strcspn followed by g_strndup. I feel the current approach of using the combination of

Re: [Qemu-devel] [PATCH V3 10/11] vcpu: introduce lockmap

2012-09-20 Thread Avi Kivity
On 09/20/2012 10:51 AM, liu ping fan wrote: On Wed, Sep 19, 2012 at 5:05 PM, Avi Kivity a...@redhat.com wrote: On 09/19/2012 11:36 AM, liu ping fan wrote: It basically means you can't hold contents of device state in local variables. You need to read everything again from the device. That

Re: [Qemu-devel] [PATCH RFC] remove QEMUOptionParameter

2012-09-20 Thread Markus Armbruster
Dong Xu Wang wdon...@linux.vnet.ibm.com writes: Markus, I am working with v2 and have some questions based your comments. Your replies are very hard to read, because whatever you use to send them wraps quoted lines. Please fix that. On Fri, Sep 7, 2012 at 4:42 PM, Markus Armbruster

Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-20 Thread Avi Kivity
On 09/20/2012 10:19 AM, Gleb Natapov wrote: Again: If you think the feature is non-invasive, send patches against the kernel and QEMU. And explain why it is better than what modern HW provides. If it's non-invasive (and easily maintainable), it doesn't have to be better. -- error

Re: [Qemu-devel] Will the ELI incorporated in theKVM?

2012-09-20 Thread Gleb Natapov
On Thu, Sep 20, 2012 at 12:18:11PM +0300, Avi Kivity wrote: On 09/20/2012 10:19 AM, Gleb Natapov wrote: Again: If you think the feature is non-invasive, send patches against the kernel and QEMU. And explain why it is better than what modern HW provides. If it's non-invasive (and

Re: [Qemu-devel] [PATCH] ppc405_uc: Fix buffer overflow

2012-09-20 Thread Alexander Graf
On 31.08.2012, at 22:21, Stefan Weil wrote: Report from smatch: ppc405_uc.c:209 dcr_read_pob(12) error: buffer overflow 'pob-besr' 2 = 2 ppc405_uc.c:232 dcr_write_pob(12) error: buffer overflow 'pob-besr' 2 = 2 The old code reads and writes besr[POB0_BESR1 - POB0_BESR0] or besr[2] which

Re: [Qemu-devel] [PATCH v7 5/5] block: Support GlusterFS as a QEMU block backend.

2012-09-20 Thread Kevin Wolf
Am 20.09.2012 11:12, schrieb Bharata B Rao: On Thu, Sep 20, 2012 at 10:20:33AM +0200, Paolo Bonzini wrote: Il 20/09/2012 09:53, Paolo Bonzini ha scritto: Would look a bit nicer with strstart() form cutils.c instead of strncmp(). strstart() works with const char pointers, but I have char

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-20 Thread Michael S. Tsirkin
On Thu, Sep 20, 2012 at 11:57:37AM +0300, Orit Wasserman wrote: On 09/20/2012 09:03 AM, Michael S. Tsirkin wrote: @@ -526,16 +592,19 @@ int inet_connect(const char *str, Error **errp) return sock; } - -int inet_nonblocking_connect(const char *str, bool *in_progress, -

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-20 Thread Orit Wasserman
On 09/20/2012 12:37 PM, Michael S. Tsirkin wrote: On Thu, Sep 20, 2012 at 11:57:37AM +0300, Orit Wasserman wrote: On 09/20/2012 09:03 AM, Michael S. Tsirkin wrote: @@ -526,16 +592,19 @@ int inet_connect(const char *str, Error **errp) return sock; } - -int

[Qemu-devel] [PATCH V3 4/5] exec, memory: Call to xen_modified_memory.

2012-09-20 Thread Anthony PERARD
This patch add some calls to xen_modified_memory to notify Xen about dirtybits during migration. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- exec.c | 1 + memory.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/exec.c b/exec.c index 209ac1c..844a73c 100644 --- a/exec.c

[Qemu-devel] [PATCH V3 5/5] xen: Set the vram dirty when an error occur.

2012-09-20 Thread Anthony PERARD
If the call to xc_hvm_track_dirty_vram() fails, then we set dirtybit on all the video ram. This case happens during migration, but we don't need a special case for live migration with patch. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- xen-all.c | 3 ++- 1 file changed, 2

[Qemu-devel] [PATCH V3 2/5] xen: Introduce xen_modified_memory.

2012-09-20 Thread Anthony PERARD
This function is to be used during live migration. Every write access to the guest memory should call this funcion so the Xen tools knows which pages are dirty. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- hw/xen.h | 1 + xen-all.c | 21 + xen-stub.c | 4

[Qemu-devel] [PATCH V3 0/5] Xen, introducing dirty log for migration.

2012-09-20 Thread Anthony PERARD
Hi, This patch set will fix live migration under Xen. For this I introduce a new QMP command to switch global-dirty log and few calls (in exec.c and memory.c) to xen set_dirty function. Change since v2: - renamed set_dirty_helper to invalidate_and_set_dirty. - in the last patch, set vram as

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-20 Thread Orit Wasserman
On 09/19/2012 11:31 AM, Amos Kong wrote: On 14/09/12 02:58, Orit Wasserman wrote: getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not

Re: [Qemu-devel] [PATCH v3 1/3] Refactor inet_connect_opts function

2012-09-20 Thread Orit Wasserman
On 09/19/2012 11:33 AM, Amos Kong wrote: On 14/09/12 02:58, Orit Wasserman wrote: From: Michael S. Tsirkin m...@redhat.com refactor address resolution code to fix nonblocking connect remove getnameinfo call Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Amos Kong

Re: [Qemu-devel] [PATCH v3 1/3] Refactor inet_connect_opts function

2012-09-20 Thread Orit Wasserman
On 09/20/2012 05:33 AM, Amos Kong wrote: On 19/09/12 16:33, Amos Kong wrote: On 14/09/12 02:58, Orit Wasserman wrote: From: Michael S. Tsirkin m...@redhat.com refactor address resolution code to fix nonblocking connect remove getnameinfo call Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] [PATCH V3 3/5] exec: Introduce helper to set dirty flags.

2012-09-20 Thread Avi Kivity
On 09/20/2012 02:12 PM, Anthony PERARD wrote: This new helper/hook is used in the next patch to add an extra call in a single place. Reviewed-by: Avi Kivity a...@redhat.com -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH v3 03/19] block: Framework for reopening files safely

2012-09-20 Thread Kevin Wolf
Am 18.09.2012 20:53, schrieb Jeff Cody: This is based on Supriya Kannery's bdrv_reopen() patch series. This provides a transactional method to reopen multiple images files safely. Image files are queue for reopen via bdrv_reopen_queue(), and the reopen occurs when bdrv_reopen_multiple()

[Qemu-devel] [PATCH V3 3/5] exec: Introduce helper to set dirty flags.

2012-09-20 Thread Anthony PERARD
This new helper/hook is used in the next patch to add an extra call in a single place. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- exec.c | 52 +--- 1 file changed, 17 insertions(+), 35 deletions(-) diff --git a/exec.c b/exec.c

Re: [Qemu-devel] directory hierarchy

2012-09-20 Thread Avi Kivity
On 09/19/2012 10:57 PM, Blue Swirl wrote: On Wed, Sep 19, 2012 at 12:54 PM, Avi Kivity a...@redhat.com wrote: On 09/14/2012 10:51 PM, Blue Swirl wrote: exec: These files need cleanup so that TCG code gets into tcg/. Maybe also TB and CPUTLB handling. Some of that could be done by adding a

Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-09-20 Thread Stefano Stabellini
On Thu, 20 Sep 2012, Gerd Hoffmann wrote: Pixman or non-pixman, I still think that this could benefit from implementing a DisplayAllocator interface: it would avoid a memcpy whenever there is no need for scaling and pixel conversions. There is one more issue I didn't mention yet: The

[Qemu-devel] [PATCH V3 1/5] QMP, Introduce xen-set-global-dirty-log command.

2012-09-20 Thread Anthony PERARD
This command is used during a migration of a guest under Xen. It calls memory_global_dirty_log_start or memory_global_dirty_log_stop according to the argument pass to the command. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Reviewed-by: Luiz Capitulino lcapitul...@redhat.com ---

Re: [Qemu-devel] [PATCH 0/3] Intruduce qemu-ga-client

2012-09-20 Thread Ryota Ozaki
Hi Michael On Thu, Sep 20, 2012 at 1:40 PM, Michael Tokarev m...@tls.msk.ru wrote: On 20.09.2012 00:20, Luiz Capitulino wrote: On Fri, 14 Sep 2012 21:44:19 +0900 Ryota Ozaki ozaki.ry...@gmail.com wrote: This patch series adds qemu-ga-client that is a command line script to use guest agent

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-09-20 Thread Alexander Graf
On 25.08.2012, at 11:52, Blue Swirl wrote: On Fri, Aug 24, 2012 at 11:01 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 24 August 2012 19:43, Andreas Färber afaer...@suse.de wrote: Depends on what you mean with disable? Adding an #error would hurt our arm build just like earlier the

Re: [Qemu-devel] [PATCH v2] register reset handler to write image into memory

2012-09-20 Thread Alexander Graf
On 23.08.2012, at 13:38, Andreas Färber wrote: Hi, Am 23.08.2012 11:45, schrieb Yin Olivia-R63875: Dear All, I can't find MAINTAINER of hw/loader.c. Who can help review and apply this patch? This patch is not a small bugfix so it won't be applied during the v1.2 Hard Freeze. You

Re: [Qemu-devel] [PATCH] s390: use sync regs for register transfer

2012-09-20 Thread Alexander Graf
On 22.08.2012, at 13:54, Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com Newer kernels provide the guest registers in kvm_run. Lets use those if available. This avoids ioctls on cpu_synchronize_state making intercepts faster. In addition, we have now the prefix

Re: [Qemu-devel] [PATCH V3 2/5] xen: Introduce xen_modified_memory.

2012-09-20 Thread Stefano Stabellini
On Thu, 20 Sep 2012, Anthony PERARD wrote: This function is to be used during live migration. Every write access to the guest memory should call this funcion so the Xen tools knows which pages are dirty. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- hw/xen.h | 1 +

[Qemu-devel] [PATCH] linux-user: fix statfs

2012-09-20 Thread Alexander Graf
The statfs syscall should always memset(0) its full struct extent before writing to it. Newer versions of the syscall use one of the reserved fields for flags, which would otherwise get stale values from uncleaned memory. This fixes libarchive for me, which got confused about the return value of

Re: [Qemu-devel] [PATCH V3 5/5] xen: Set the vram dirty when an error occur.

2012-09-20 Thread Stefano Stabellini
On Thu, 20 Sep 2012, Anthony PERARD wrote: If the call to xc_hvm_track_dirty_vram() fails, then we set dirtybit on all the video ram. This case happens during migration, but we don't need a special case for live migration with patch. Just as a reference, what is this special case for live

Re: [Qemu-devel] [PATCH RFC] remove QEMUOptionParameter

2012-09-20 Thread Luiz Capitulino
On Thu, 20 Sep 2012 11:10:02 +0800 Dong Xu Wang wdon...@linux.vnet.ibm.com wrote: Luiz, I think I need to use your 1-3 patchs in your series. http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html Sure, that's what I expected you'd do. Note that Markus made some comments there

Re: [Qemu-devel] [PATCH v3 1/3] Refactor inet_connect_opts function

2012-09-20 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: On 19/09/12 16:33, Amos Kong wrote: On 14/09/12 02:58, Orit Wasserman wrote: From: Michael S. Tsirkin m...@redhat.com refactor address resolution code to fix nonblocking connect remove getnameinfo call Signed-off-by: Michael S. Tsirkin m...@redhat.com

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] pseries: Synchronize qemu and KVM state on hypercalls

2012-09-20 Thread David Gibson
On Thu, Sep 20, 2012 at 09:39:56AM +0200, Jan Kiszka wrote: On 2012-09-20 09:08, David Gibson wrote: Currently the KVM exit path for PAPR hypercalls does not synchronize the qemu cpu state with the KVM state. Mostly this works, because the actual hypercall arguments and return values are

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] pseries: Synchronize qemu and KVM state on hypercalls

2012-09-20 Thread David Gibson
On Thu, Sep 20, 2012 at 09:38:58AM +0200, Alexander Graf wrote: On 20.09.2012, at 09:08, David Gibson wrote: Currently the KVM exit path for PAPR hypercalls does not synchronize the qemu cpu state with the KVM state. Mostly this works, because the actual hypercall arguments and return

Re: [Qemu-devel] [PATCH v3 2/3] Separate inet_connect into inet_connect (blocking) and inet_nonblocking_connect

2012-09-20 Thread Markus Armbruster
Orit Wasserman owass...@redhat.com writes: No need to add non blocking parameters to the blocking inet_connect add block parameter for inet_connect_opts instead of using QemuOpt block. I believe option block in qemu-sockets.c's dummy_opts is now unused, and should be dropped. It was added in

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] pseries: Synchronize qemu and KVM state on hypercalls

2012-09-20 Thread Alexander Graf
On 20.09.2012, at 13:53, David Gibson wrote: On Thu, Sep 20, 2012 at 09:38:58AM +0200, Alexander Graf wrote: On 20.09.2012, at 09:08, David Gibson wrote: Currently the KVM exit path for PAPR hypercalls does not synchronize the qemu cpu state with the KVM state. Mostly this works,

Re: [Qemu-devel] [PATCH 1/1] kvmclock: fix guest stop notification

2012-09-20 Thread Marcelo Tosatti
On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop notification, but it did it in a way that the stop notification would never reach the kernel. The kvm_vm_state_changed() function gets a value of 0 for the 'running'

Re: [Qemu-devel] [PATCH 1/1] kvmclock: fix guest stop notification

2012-09-20 Thread Marcelo Tosatti
Amit, should please use uq/master in the subject to help the person who is merging patches. On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop notification, but it did it in a way that the stop notification would

Re: [Qemu-devel] [PATCH] s390: use sync regs for register transfer

2012-09-20 Thread Christian Borntraeger
[...] --- a/target-s390x/kvm.c +++ b/target-s390x/kvm.c @@ -88,50 +88,77 @@ void kvm_arch_reset_vcpu(CPUS390XState *env) /* FIXME: add code to reset vcpu. */ } +/* we want to have the prefix, the GPRS, the ACRS and the CRS up to date */ +#define QEMU_NEEDED_REGS (KVM_SYNC_PREFIX |

Re: [Qemu-devel] [PATCH v3 03/19] block: Framework for reopening files safely

2012-09-20 Thread Jeff Cody
On 09/20/2012 07:24 AM, Kevin Wolf wrote: Am 18.09.2012 20:53, schrieb Jeff Cody: This is based on Supriya Kannery's bdrv_reopen() patch series. This provides a transactional method to reopen multiple images files safely. Image files are queue for reopen via bdrv_reopen_queue(), and the

[Qemu-devel] [PATCH] virtio-blk: add default value to serial attribute

2012-09-20 Thread Dave Young
From: Dave Young dyo...@redhat.com For virtio block device, if user does not specify the serial attribute, There will be not serial availabe, this is not convinient for identify the disk. Doing something similar to ide disks, add a VD? default serial number if user does not specify it.

[Qemu-devel] [PATCH] memory: rename 'exec-obsolete.h'

2012-09-20 Thread Avi Kivity
exec-obsolete.h used to hold pre-memory-API functions that were used from device code prior to the transition to the memory API. Now that the transition is complete, the name no longer describes the file. The functions still need to be merged better into the memory core, but there's no danger of

Re: [Qemu-devel] [PATCH v3 04/19] block: move aio initialization into a helper function

2012-09-20 Thread Kevin Wolf
Am 18.09.2012 20:53, schrieb Jeff Cody: Move AIO initialization for raw-posix block driver into a helper function. In addition to just code motion, the aio_ctx pointer is checked for NULL, prior to calling laio_init(), to make sure laio_init() is only run once. Signed-off-by: Jeff Cody

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-20 Thread Markus Armbruster
Orit Wasserman owass...@redhat.com writes: getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not actually working. To fix this make

Re: [Qemu-devel] [PATCH 01/12] monitor: use monitor_handle_fd_param for non-Error-friendly users of named fds

2012-09-20 Thread Luiz Capitulino
On Thu, 20 Sep 2012 10:09:54 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 19/09/2012 22:42, Luiz Capitulino ha scritto: On Wed, 19 Sep 2012 16:31:04 +0200 Paolo Bonzini pbonz...@redhat.com wrote: monitor_handle_fd_param and monitor_get_fd are mostly the same, except that

Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-09-20 Thread Gerd Hoffmann
Hi, It might be a good idea to get rid of DisplayAllocator altogether. After some digging in the source code: Yes, I think so. Look, we have *two* concepts for avoiding memcpy: The first is the DisplayAllocator. Only implemented by SDL, which is scheduled to be downgraded by anthonys gtk

Re: [Qemu-devel] [PATCH v3 0/3] nonblocking connect address handling cleanup

2012-09-20 Thread Markus Armbruster
Orit Wasserman owass...@redhat.com writes: Changes from v2: - remove the use of getnameinfo - remove errp for inet_connect_addr - remove QemuOpt block - fix errors in wait_for_connect - pass ConnectState as a parameter to allow concurrent connect ops

Re: [Qemu-devel] [PATCH 2/9] tcg/optimizer: check types in copy propagation

2012-09-20 Thread Richard Henderson
On 09/19/2012 10:54 PM, Aurelien Jarno wrote: | mov_i32 r1,tmp6 | movi_i64 tmp8,$0x20 | shr_i64 tmp7,r1,tmp8 Here, tmp7 is replaced by r1. However r1 only contains the 32-bit low part of tmp7, thus returning 0. Ok. Thanks for getting that on the record. r~

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-20 Thread Richard Henderson
On 09/19/2012 05:29 PM, Max Filippov wrote: Not all tcg backends can handle that. *No* tcg backends can handle that. If we fix the bug wherein i386 clobbers the goto_tb target during re-translation you'll see the crash there too. And we were just talking about enhancing --enable-debug-tcg to

[Qemu-devel] [PATCH 0/6] Reduce compaction scanning and lock contention

2012-09-20 Thread Mel Gorman
Hi Richard, This series is following up from your mail at http://www.spinics.net/lists/kvm/msg80080.html . I am pleased the lock contention is now reduced but acknowledge that the scanning rates are stupidly high. Fortunately, I am reasonably confident I know what is going wrong. If all goes

Re: [Qemu-devel] [PATCH 03/12] qapi: do not protect enum values from namespace pollution

2012-09-20 Thread Luiz Capitulino
On Wed, 19 Sep 2012 16:31:06 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Enum values are always preceded by the uppercase name of the enum, so they do not conflict with reserved words. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Cherry-picked into qmp branch, thanks. ---

Re: [Qemu-devel] [PATCH 04/12] qapi: add unix to the set of reserved words

2012-09-20 Thread Luiz Capitulino
On Wed, 19 Sep 2012 16:31:07 +0200 Paolo Bonzini pbonz...@redhat.com wrote: It is #defined to 1. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Cherry-picked into qmp branch, thanks. --- scripts/qapi.py | 4 +++- 1 file modificato, 3 inserzioni(+). 1 rimozione(-) diff --git

Re: [Qemu-devel] [PATCH v3 09/19] block: raw-posix image file reopen

2012-09-20 Thread Kevin Wolf
Am 18.09.2012 20:53, schrieb Jeff Cody: This is derived from the Supriya Kannery's reopen patches. This contains the raw-posix driver changes for the bdrv_reopen_* functions. All changes are staged into a temporary scratch buffer during the prepare() stage, and copied over to the live

Re: [Qemu-devel] [PATCH v3 14/19] block: vmdk image file reopen

2012-09-20 Thread Kevin Wolf
Am 18.09.2012 20:53, schrieb Jeff Cody: This patch supports reopen for VMDK image files. VMDK extents are added to the existing reopen queue, so that the transactional model of reopen is maintained with multiple image files. Signed-off-by: Jeff Cody jc...@redhat.com --- block/vmdk.c | 35

  1   2   3   >