Re: [Qemu-devel] [PATCH 2/2] hw/armv7m_nvic: Add global variable for SysTick external reference clock

2012-10-11 Thread Andre Beckus
On Wed, 2012-10-10 at 13:03 +0100, Peter Maydell wrote: > On 9 October 2012 23:29, Andre Beckus wrote: > > Adds a new external reference clock scale variable to complement the > > existing > > system_clock_scale variable. Previously, the value was hardcoded to 1000 > > when calculating the SysTi

Re: [Qemu-devel] [PATCH 1/2] hw/armv7m_nvic: Implement byte read/write for NVIC SCB_SHPRx registers

2012-10-11 Thread Andre Beckus
On Wed, 2012-10-10 at 12:32 +0100, Peter Maydell wrote: > On 9 October 2012 23:29, Andre Beckus wrote: > > Adds nvic_writeb and nvic_readb functions. > > > > Implements byte read/write for the NVIC SCB_SHPRx (System Handler > > Priority Registers). Currently, only double word access is implemente

Re: [Qemu-devel] [PATCH 4/5] s390: sclp signal quiesce support

2012-10-11 Thread Christian Borntraeger
On 12/10/12 02:36, Alexander Graf wrote: > > On 02.10.2012, at 09:33, Jens Freimann wrote: > >> From: Heinz Graalfs >> >> This implements the sclp signal quiesce event via the SCLP Event >> Facility. >> This allows to gracefully shutdown a guest by using system_powerdown >> notifiers. It creates

Re: [Qemu-devel] [PATCH] Add nvram to default boot device list

2012-10-11 Thread Chris Wright
* Alexander Graf (ag...@suse.de) wrote: > On 12.10.2012, at 02:28, David Gibson wrote: > > On Fri, Oct 12, 2012 at 02:03:00AM +0200, Alexander Graf wrote: > >> On 12.10.2012, at 00:59, David Gibson wrote: > >>> On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote: > This patch adds nvram s

Re: [Qemu-devel] [RFC v1 3/7] memory: iommu support

2012-10-11 Thread Benjamin Herrenschmidt
On Thu, 2012-10-11 at 15:57 +0200, Avi Kivity wrote: > >> Map/unmap is supported via address_space_map(), which calls > >> ->translate(). I don't see how a lower-level map/unmap helps, > unless > >> the hardware supplies such a function. > > > > Yep, it's just the map/unmap callbacks that are not

Re: [Qemu-devel] [RFC v1 3/7] memory: iommu support

2012-10-11 Thread Benjamin Herrenschmidt
On Thu, 2012-10-11 at 15:42 +0200, Paolo Bonzini wrote: > Il 11/10/2012 15:26, Avi Kivity ha scritto: > > +struct MemoryRegionIOMMUOps { > > +/* Returns a TLB entry that contains a given address. */ > > +IOMMUTLBEntry (*translate)(MemoryRegion *iommu, target_phys_addr_t > > addr, > > +

Re: [Qemu-devel] [RFC v1 0/7] IOMMU support

2012-10-11 Thread Benjamin Herrenschmidt
On Thu, 2012-10-11 at 15:26 +0200, Avi Kivity wrote: > These patches add IOMMU support to the memory core. IOMMUs can be added > anywhere in > the memory hierarchy, and may be arranged in series. I haven't had a chance to review in details yet, but one thing I noticed is that you basically have a

Re: [Qemu-devel] Using PCI config space to indicate config location

2012-10-11 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Thu, Oct 11, 2012 at 11:48:22AM +1030, Rusty Russell wrote: >> "Michael S. Tsirkin" writes: >> > On Mon, Oct 08, 2012 at 12:51:25PM +1030, Rusty Russell wrote: >> >> Note before anyone gets confused; we were talking about using the PCI >> >> config space to indic

[Qemu-devel] [PATCH v2 5/5] sun4u: Pass SPARCCPU to cpu_set_ivec_irq()

2012-10-11 Thread Andreas Färber
Needed for moving halted field to CPUState. Signed-off-by: Andreas Färber --- hw/sun4u.c |7 +++ 1 Datei geändert, 3 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index 0453522..940db33 100644 --- a/hw/sun4u.c +++ b/hw/sun4u.c @@ -321,7 +321,8 @@ stati

[Qemu-devel] [PATCH v2 4/5] sun4u: Pass SPARCCPU to cpu_kick_irq()

2012-10-11 Thread Andreas Färber
Needed for changing qemu_cpu_kick() argument type to CPUState. Signed-off-by: Andreas Färber --- hw/sun4u.c | 10 ++ 1 Datei geändert, 6 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index 4cea102..0453522 100644 --- a/hw/sun4u.c +++ b/hw/sun4u.c @@

[Qemu-devel] [PATCH v2 2/5] sun4m: Pass SPARCCPU to cpu_kick_irq()

2012-10-11 Thread Andreas Färber
Needed for changing qemu_cpu_kick() argument type to CPUState. Signed-off-by: Andreas Färber --- hw/sun4m.c |6 -- 1 Datei geändert, 4 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/hw/sun4m.c b/hw/sun4m.c index c1ee8bd..a04b485 100644 --- a/hw/sun4m.c +++ b/hw/sun4m.c @@ -253

[Qemu-devel] [PATCH v2 0/5] target-sparc: Preparations for CPUState part 4b series

2012-10-11 Thread Andreas Färber
Hello Blue, These patches from my QOM CPUState part 4 series still apply to master. In whatever way we solve the TLB flushing (needed for CPU VMState), we'll need these. Can you please ack/apply? As a reminder, SPARCCPU and CPUState are the same pointer, whereas CPUSPARCState has been embedded in

[Qemu-devel] [PATCH v2 3/5] sun4u: Pass SPARCCPU to {, s, hs}tick_irq() and cpu_timer_create()

2012-10-11 Thread Andreas Färber
Needed for changing cpu_kick_irq() argument type to SPARCCPU. Signed-off-by: Andreas Färber --- hw/sun4u.c | 19 +++ 1 Datei geändert, 11 Zeilen hinzugefügt(+), 8 Zeilen entfernt(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index 137a7c6..4cea102 100644 --- a/hw/sun4u.c +++ b/hw/su

[Qemu-devel] [PATCH v2 1/5] sun4m: Pass SPARCCPU to cpu_set_irq()

2012-10-11 Thread Andreas Färber
Needed for changing cpu_kick_irq() argument type to SPARCCPU. Signed-off-by: Andreas Färber --- hw/sun4m.c |5 +++-- 1 Datei geändert, 3 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/hw/sun4m.c b/hw/sun4m.c index c98cd5e..c1ee8bd 100644 --- a/hw/sun4m.c +++ b/hw/sun4m.c @@ -262,7

[Qemu-devel] [PATCH qom-cpu v2 2/7] apic: Store X86CPU in APICCommonState

2012-10-11 Thread Andreas Färber
Prepares for using a link<> property to connect APIC with CPU and for changing the CPU APIs to CPUState. Resolve Coding Style warnings by moving the closing parenthesis of foreach_apic() macro to next line. Signed-off-by: Andreas Färber Cc: Igor Mammedov --- hw/apic.c | 38 +

[Qemu-devel] [PATCH qom-cpu v2 5/7] cpus: Pass CPUState to qemu_cpu_kick_thread()

2012-10-11 Thread Andreas Färber
CPUArchState is no longer needed there. Signed-off-by: Andreas Färber --- cpus.c |9 - 1 Datei geändert, 4 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) diff --git a/cpus.c b/cpus.c index 849ea8a..54b765e 100644 --- a/cpus.c +++ b/cpus.c @@ -844,9 +844,8 @@ static void *qemu_tcg_cpu_t

[Qemu-devel] [PATCH qom-cpu v2 6/7] cpu: Move created field to CPUState

2012-10-11 Thread Andreas Färber
Change its type to bool. Signed-off-by: Andreas Färber --- cpu-defs.h |1 - cpus.c | 13 +++-- include/qemu/cpu.h |2 ++ 3 Dateien geändert, 9 Zeilen hinzugefügt(+), 7 Zeilen entfernt(-) diff --git a/cpu-defs.h b/cpu-defs.h index 4018b88..ae95158 100644 ---

[Qemu-devel] [PATCH qom-cpu v2 4/7] cpus: Pass CPUState to qemu_cpu_is_self()

2012-10-11 Thread Andreas Färber
Change return type to bool, move to include/qemu/cpu.h and add documentation. Signed-off-by: Andreas Färber --- cpus.c | 10 -- exec.c |3 ++- hw/apic.c |6 -- include/qemu/cpu.h | 10 ++ kvm-all.c |4 +++- qemu-common

[Qemu-devel] [PATCH qom-cpu v2 7/7] cpu: Move stop field to CPUState

2012-10-11 Thread Andreas Färber
Change its type to bool. Signed-off-by: Andreas Färber --- cpu-defs.h |1 - cpus.c | 27 ++- include/qemu/cpu.h |2 ++ 3 Dateien geändert, 20 Zeilen hinzugefügt(+), 10 Zeilen entfernt(-) diff --git a/cpu-defs.h b/cpu-defs.h index ae95158..c9

[Qemu-devel] [PATCH qom-cpu v2 0/7] QOM CPUState, part 4a: CPU_COMMON, continued

2012-10-11 Thread Andreas Färber
Hello, Based on Igor's APIC initialization refactoring, this series picks up the next batch from my CPUState part 4 series. It applies on top of my qom-cpu queue and does not depend on the target-specific preparation series just posted. Still not having X86CPU subclasses, there's no perfect solut

[Qemu-devel] [PATCH qom-cpu v2 3/7] target-i386: Pass X86CPU to cpu_x86_load_seg_cache_sipi()

2012-10-11 Thread Andreas Färber
Simplifies the call in apic_sipi() again and needed for moving halted field to CPUState. Signed-off-by: Andreas Färber --- hw/apic.c |2 +- target-i386/cpu.h |4 +++- 2 Dateien geändert, 4 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/hw/apic.c b/hw/apic.c index f1f80

[Qemu-devel] [PATCH qom-cpu v2 1/7] target-i386: Inline APIC cpu_env property setting

2012-10-11 Thread Andreas Färber
This prepares for changing the variable type from void*. Signed-off-by: Andreas Färber Cc: Igor Mammedov --- hw/apic_common.c |1 - target-i386/cpu.c |5 - 2 Dateien geändert, 4 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/hw/apic_common.c b/hw/apic_common.c index 371f

Re: [Qemu-devel] [PATCH 4/5] s390: sclp signal quiesce support

2012-10-11 Thread Alexander Graf
On 02.10.2012, at 09:33, Jens Freimann wrote: > From: Heinz Graalfs > > This implements the sclp signal quiesce event via the SCLP Event > Facility. > This allows to gracefully shutdown a guest by using system_powerdown > notifiers. It creates a service interrupt that will trigger a > Read Even

Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t

2012-10-11 Thread David Gibson
On Thu, Oct 11, 2012 at 04:07:24PM +0100, Peter Maydell wrote: > On 11 October 2012 02:57, David Gibson wrote: > > Actually, turns out I had another use of these helpers. That was to > > store the real page address from the ppcmeb_tlb_t structure. That > > structure is used to represent TLB entr

Re: [Qemu-devel] [PATCH] Add nvram to default boot device list

2012-10-11 Thread Alexander Graf
On 12.10.2012, at 02:28, David Gibson wrote: > On Fri, Oct 12, 2012 at 02:03:00AM +0200, Alexander Graf wrote: >> >> On 12.10.2012, at 00:59, David Gibson wrote: >> >>> On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote: This patch adds nvram specified boot device into qemu default >

Re: [Qemu-devel] [PATCH] Add nvram to default boot device list

2012-10-11 Thread David Gibson
On Fri, Oct 12, 2012 at 02:03:00AM +0200, Alexander Graf wrote: > > On 12.10.2012, at 00:59, David Gibson wrote: > > > On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote: > >> This patch adds nvram specified boot device into qemu default > >> boot_devices list. This helps firmware to boot f

Re: [Qemu-devel] [PATCH] Add nvram to default boot device list

2012-10-11 Thread Alexander Graf
On 12.10.2012, at 00:59, David Gibson wrote: > On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote: >> This patch adds nvram specified boot device into qemu default >> boot_devices list. This helps firmware to boot from nvram specified >> boot device if no -boot option is specified. > > I r

Re: [Qemu-devel] [PATCH] Add nvram to default boot device list

2012-10-11 Thread David Gibson
On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote: > This patch adds nvram specified boot device into qemu default > boot_devices list. This helps firmware to boot from nvram specified > boot device if no -boot option is specified. I really don't think this is a good idea, it extends an alr

[Qemu-devel] [PATCH v2 3/5] target-mips: Pass MIPSCPU to mips_vpe_is_wfi()

2012-10-11 Thread Andreas Färber
Needed for moving halted field to CPUState. The variable name "c" is retained for MIPSCPU to leave "cpu" for CPUState. Also change return type to bool while at it. Signed-off-by: Andreas Färber --- target-mips/op_helper.c | 12 1 Datei geändert, 8 Zeilen hinzugefügt(+), 4 Zeilen

[Qemu-devel] [PATCH v2 4/5] target-mips: Pass MIPSCPU to mips_tc_sleep()

2012-10-11 Thread Andreas Färber
Needed for changing mips_vpe_sleep() argument type to MIPSCPU. Signed-off-by: Andreas Färber --- target-mips/op_helper.c |8 +--- 1 Datei geändert, 5 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index 9770741..5710dd0 100644

[Qemu-devel] [PATCH v2 5/5] target-mips: Pass MIPSCPU to mips_vpe_sleep()

2012-10-11 Thread Andreas Färber
Needed for moving halted field to CPUState. Signed-off-by: Andreas Färber --- target-mips/op_helper.c | 10 +++--- 1 Datei geändert, 7 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index 5710dd0..05b7730 100644 --- a/target-mips

[Qemu-devel] [PATCH v2 0/5] target-mips: Preparations for CPUState part 4b series

2012-10-11 Thread Andreas Färber
Hello Aurélien, This series picks up some preparatory patches for QOM CPUState refactoring, originally posted in May. They still applied cleanly, but I optimized them a bit and expanded the explanations. In short it is about MIPSCPU vs. CPUMIPSState; more fields will be moved from CPU_COMMON macr

[Qemu-devel] [PATCH v2 1/5] target-mips: Clean up other_cpu in helper_{d, e}vpe()

2012-10-11 Thread Andreas Färber
Free the variable name "other_cpu" for later use for MIPSCPU. Fix off-by-one indentation while at it. Signed-off-by: Andreas Färber --- target-mips/op_helper.c | 28 ++-- 1 Datei geändert, 14 Zeilen hinzugefügt(+), 14 Zeilen entfernt(-) diff --git a/target-mips/op_hel

[Qemu-devel] [PATCH v2 2/5] target-mips: Pass MIPSCPU to mips_tc_wake()

2012-10-11 Thread Andreas Färber
Needed for changing mips_vpe_is_wfi() argument type to MIPSCPU. Signed-off-by: Andreas Färber --- target-mips/op_helper.c | 11 --- 1 Datei geändert, 8 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index 1051c44..e721a4d 100

Re: [Qemu-devel] [PATCH v6 03/16] target-i386: Add cpu object access routines for Hypervisor level.

2012-10-11 Thread Don Slutz
On 10/10/12 11:40, Andreas Färber wrote: Am 10.10.2012 17:22, schrieb Don Slutz: On 10/09/12 15:13, Don Slutz wrote: On 10/09/12 12:25, Marcelo Tosatti wrote: On Mon, Sep 24, 2012 at 10:32:05AM -0400, Don Slutz wrote: +static void x86_cpuid_set_hv_level(Object *obj, Visitor *v, void *opaque,

[Qemu-devel] [RFC 3/7] block: bdrv_img_create(): move param printing to qemu-img

2012-10-11 Thread Luiz Capitulino
bdrv_img_create() is being used by the transaction QMP command and therefore shouldn't print directly to the user. Move the param printing to qemu-img instead. Has the side effect of only printing it when the bdrv_img_create() call succeeds, otherwise we can print errors before the action being ta

[Qemu-devel] [RFC 7/7] block: bdrv_img_create(): drop unused code

2012-10-11 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- block.c | 41 ++--- block.h | 8 2 files changed, 10 insertions(+), 39 deletions(-) diff --git a/block.c b/block.c index 3f4bec0..79e33a0 100644 --- a/block.c +++ b/block.c @@ -4292,10 +4292,10 @@ bdrv_acct_done(Blo

[Qemu-devel] [RFC 1/7] error: add error_set_errno and error_setg_errno

2012-10-11 Thread Luiz Capitulino
From: Paolo Bonzini These functions help maintaining homogeneous formatting of error messages that include strerror values. Acked-by: Luiz Capitulino Signed-off-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- error.c | 28 error.h | 9 + 2 files cha

[Qemu-devel] [RFC 6/7] qmp: qmp_transaction(): pass Error object to bdrv_img_create()

2012-10-11 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- blockdev.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index 01be90f..af02480 100644 --- a/blockdev.c +++ b/blockdev.c @@ -701,6 +701,7 @@ void qmp_transaction(BlockdevActionList *dev_list, Error **e

[Qemu-devel] [RFC 5/7] qemu-img: img_create(): use Error object

2012-10-11 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qemu-img.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 99b8ad1..18885c6 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -302,6 +302,7 @@ static int img_create(int argc, char **argv) const char *

[Qemu-devel] [RFC 4/7] block: bdrv_img_create(): add Error ** argument

2012-10-11 Thread Luiz Capitulino
This commit adds an Error ** argument to bdrv_img_create() and set it appropriately on error. Callers of bdrv_img_create() pass NULL for the new argument and still rely on bdrv_img_create()'s return value. Next commits will change callers to use the Error object instead. Signed-off-by: Luiz Capit

[Qemu-devel] [RFC 2/7] block: bdrv_img_create(): add param_ret argument

2012-10-11 Thread Luiz Capitulino
If set returns a copy of the parameter list used by the block driver to create the image. Signed-off-by: Luiz Capitulino --- block.c| 7 ++- block.h| 3 ++- blockdev.c | 2 +- qemu-img.c | 2 +- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index e

[Qemu-devel] [RFC 0/7] block: bdrv_img_create(): propagate errors

2012-10-11 Thread Luiz Capitulino
I'm calling this an RFC because I did it on hurry and it's almost untested, but I wanted to drop it for early review while I'm out for a public holiday :) This should improve qmp_transaction() error messages on bdrv_img_create() failure quite a bit. Also, the "formatting" message is not printed to

Re: [Qemu-devel] [PATCH] arm_gic: Rename gic_state to GICState

2012-10-11 Thread Andreas Färber
Am 10.10.2012 19:49, schrieb Peter Maydell: > Rename the gic_state struct to match QEMU's coding style conventions > for structure names, since the impending KVM-for-ARM patches will > create another subclass of it. This patch was created using: > sed -i 's/gic_state/GICState/g' hw/arm_gic.c hw/a

Re: [Qemu-devel] [PULL v3 00/23] Integrate DMA into the memory API

2012-10-11 Thread Anthony Liguori
Avi Kivity writes: > Most of the work on the memory API focused on memory access targets - the > memory regions > and how they are composed into an address space. This patchset tackles the > initator > side of the question - how to originate accesses. > > The AddressSpace object, is exported t

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-11 Thread Michael S. Tsirkin
On Thu, Oct 11, 2012 at 11:34:08AM -0400, Jason Baron wrote: > On Thu, Oct 11, 2012 at 04:46:56PM +0200, Michael S. Tsirkin wrote: > > On Thu, Oct 11, 2012 at 10:21:22AM -0400, Jason Baron wrote: > > > On Thu, Oct 11, 2012 at 12:57:06PM +0200, Michael S. Tsirkin wrote: > > > > On Mon, Oct 08, 2012

Re: [Qemu-devel] [PATCH v5] Align PCI capabilities in pci_find_space

2012-10-11 Thread Andreas Färber
Am 11.10.2012 21:50, schrieb Matt Renzelmann: > Hi, > > I just wanted to ping the status of this patch: > http://patchwork.ozlabs.org/patch/188032/ > > This version is different from v4 only in that it adds braces as recommended > by > Blue Swirl. PCI patches should cc the PCI maintainer, cf. M

[Qemu-devel] [PATCH 4/6] linux-user: Rewrite __get_user/__put_user with __builtin_choose_expr

2012-10-11 Thread Richard Henderson
The previous formuation with multiple assignments to __typeof(*hptr) falls down when hptr is qualified const. E.g. with const struct S *p, p->f is also qualified const. With this formulation, there's no assignment to any local variable. Signed-off-by: Richard Henderson --- linux-user/qemu.h |

Re: [Qemu-devel] [PATCH v5] Align PCI capabilities in pci_find_space

2012-10-11 Thread Matt Renzelmann
Hi, I just wanted to ping the status of this patch: http://patchwork.ozlabs.org/patch/188032/ This version is different from v4 only in that it adds braces as recommended by Blue Swirl. Thanks and regards, Matt > -Original Message- > From: qemu-devel-bounces+mjr=cs.wisc@nongnu.org

Re: [Qemu-devel] [PATCH 4/6] linux-user: Rewrite __get_user/__put_user with __builtin_choose_expr

2012-10-11 Thread Richard Henderson
On 10/11/2012 12:22 PM, Richard Henderson wrote: > The previous formuation with multiple assignments to __typeof(*hptr) falls > down when hptr is qualified const. E.g. with const struct S *p, p->f is > also qualified const. > > With this formulation, there's no assignment to any local variable. >

[Qemu-devel] qemu-i386 user mode on ARM

2012-10-11 Thread Reuben K. Caron
Qemu Dev's, I have been reading through many mail archives about the issues with threading in qemu-i386 user mode. I am writing now because here at One Laptop per Child we have a deployment looking to run simple Windows x86 executables using WINE on our new ARM platform. We are interested to

[Qemu-devel] [PATCH v3 0/6] linux-user improvements

2012-10-11 Thread Richard Henderson
Changes v2-v3: * Add patch 4, rewriting __get_user. Patch 5 triggers warnings about "assignment of read-only variable" without it. * Rebase vs master, which includes the cpu_alpha_init fix. Patch set available at git://repo.or.cz/qemu/rth.git axp-next r~ Richard Henderson (6): li

Re: [Qemu-devel] [PATCH 2/6] linux-user: Implement gethostname

2012-10-11 Thread Peter Maydell
On 11 October 2012 20:22, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PATCH 5/6] alpha-linux-user: Fix sigaction

2012-10-11 Thread Richard Henderson
Unconditional bswap replaced by __get_user/__put_user. Signed-off-by: Richard Henderson --- linux-user/signal.c | 22 -- linux-user/syscall_defs.h | 2 +- 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 15

[Qemu-devel] [PATCH 2/6] linux-user: Implement gethostname

2012-10-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/syscall.c | 13 + 1 file changed, 13 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 8708b31..462d11b 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -8864,6 +8864,19 @@ abi_long do_syscall(v

Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used

2012-10-11 Thread Alex Williamson
On Thu, 2012-10-11 at 17:48 +0200, Avi Kivity wrote: > On 10/11/2012 05:34 PM, Michael S. Tsirkin wrote: > > On Thu, Oct 11, 2012 at 04:35:23PM +0200, Avi Kivity wrote: > >> On 10/11/2012 04:35 PM, Michael S. Tsirkin wrote: > >> > >> >> No, qemu should configure virtio devices to bypass the iommu,

[Qemu-devel] [PATCH 1/6] linux-user: Perform more checks on iovec lists

2012-10-11 Thread Richard Henderson
Validate count between 0 and IOV_MAX. Limit total length of operation in the same way the kernel does. Signed-off-by: Richard Henderson --- linux-user/syscall.c | 162 --- 1 file changed, 102 insertions(+), 60 deletions(-) diff --git a/linux-user

[Qemu-devel] [Bug 921208] Re: win7/x64 installer hangs on startup with 0x0000005d.

2012-10-11 Thread Valerio Angelini
have you tried with "-cpu kvm64,+nx" ? The additional parameter enables the No eXecute (NX) bit. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/921208 Title: win7/x64 installer hangs on startup wit

[Qemu-devel] [PATCH 6/6] linux-user: Fix siginfo handling

2012-10-11 Thread Richard Henderson
Compare signal numbers in the proper domain. Convert all of the fields for SIGIO and SIGCHLD. Signed-off-by: Richard Henderson --- linux-user/qemu.h| 3 +++ linux-user/signal.c | 59 +++- linux-user/syscall.c | 2 +- 3 files changed, 44 inse

[Qemu-devel] [PATCH 3/6] alpha-linux-user: Fix sigaltstack structure definition

2012-10-11 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/alpha/target_signal.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/linux-user/alpha/target_signal.h b/linux-user/alpha/target_signal.h index 94f15f6..d3822da 100644 --- a/linux-user/alpha/target_signal.h +++ b/linux-use

[Qemu-devel] [Bug 921208] Re: win7/x64 installer hangs on startup with 0x0000005d.

2012-10-11 Thread Clemens Kolbitsch
We have been discussing this issue on the QEMU mailing list. It is of CPU definition, but none of the current configurations allow QEMU to boot Windows7 64bit WITHOUT KVM. The issue behind it is that the TCG (code generator) might not fully support all CPU bits required by Win7. There is a patch t

Re: [Qemu-devel] [libvirt] [PATCH v2 3/3] qemu-config: Add new -add-fd command line option

2012-10-11 Thread Corey Bryant
On 10/11/2012 12:04 PM, Eric Blake wrote: On 10/10/2012 04:31 PM, Eric Blake wrote: Another missing validation check is for duplicate use. With the monitor command, you ALWAYS have a unique fd (thanks to SCM_RIGHTS). But with the command line, I can type 'qemu -add-fd fd=4,set=1 -add-fd fd=

Re: [Qemu-devel] [PATCH v2 3/3] qemu-config: Add new -add-fd command line option

2012-10-11 Thread Corey Bryant
On 10/11/2012 11:55 AM, Eric Blake wrote: On 10/11/2012 08:45 AM, Corey Bryant wrote: Another missing validation check is for duplicate use. With the monitor command, you ALWAYS have a unique fd (thanks to SCM_RIGHTS). But with the command line, I can type 'qemu -add-fd fd=4,set=1 -add-fd f

[Qemu-devel] slower live-migration with XBZRLE

2012-10-11 Thread Vasilis Liaskovitis
Hi, I am testing XBZRLE compression with qemu-1.2 for live migration of large VM and/or memory-intensive workloads. I have a 4GB guest that runs the memory r/w load generator from the original patchset, see docs/xbzrle.txt or http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg01207.html I ha

Re: [Qemu-devel] [libvirt] [PATCH v2 3/3] qemu-config: Add new -add-fd command line option

2012-10-11 Thread Eric Blake
On 10/11/2012 10:04 AM, Eric Blake wrote: > Another idea: a hybrid approach - the _first_ -add-fd 4 directly adds 4 > to the set, all other -add-fd 4 end up adding dup(4) instead (well, > fcntl(F_DUPFD_CLOEXEC), but you get the picture). That is, do the > duplicate scanning, and if there is no dup

Re: [Qemu-devel] [libvirt] [PATCH v2 3/3] qemu-config: Add new -add-fd command line option

2012-10-11 Thread Eric Blake
On 10/10/2012 04:31 PM, Eric Blake wrote: > Another missing validation check is for duplicate use. With the monitor > command, you ALWAYS have a unique fd (thanks to SCM_RIGHTS). But with > the command line, I can type 'qemu -add-fd fd=4,set=1 -add-fd > fd=4,set=2'. Oops - I've now corrupted yo

Re: [Qemu-devel] [PATCH v2 3/3] qemu-config: Add new -add-fd command line option

2012-10-11 Thread Eric Blake
On 10/11/2012 08:45 AM, Corey Bryant wrote: >> Another missing validation check is for duplicate use. With the monitor >> command, you ALWAYS have a unique fd (thanks to SCM_RIGHTS). But with >> the command line, I can type 'qemu -add-fd fd=4,set=1 -add-fd >> fd=4,set=2'. Oops - I've now corrup

Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used

2012-10-11 Thread Avi Kivity
On 10/11/2012 05:34 PM, Michael S. Tsirkin wrote: > On Thu, Oct 11, 2012 at 04:35:23PM +0200, Avi Kivity wrote: >> On 10/11/2012 04:35 PM, Michael S. Tsirkin wrote: >> >> >> No, qemu should configure virtio devices to bypass the iommu, even if it >> >> is on. >> > >> > Okay so there will be some

Re: [Qemu-devel] [PATCH 12/30] QAPI: add command for live block commit, 'block-commit'

2012-10-11 Thread Eric Blake
On 09/28/2012 11:56 AM, Kevin Wolf wrote: > From: Jeff Cody > > The command for live block commit is added, which has the following > arguments: > > +/* default top_bs is the active layer */ > +top_bs = bs; > + > +if (top) { > +if (strcmp(bs->filename, top) != 0) { > +

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-11 Thread Jason Baron
On Thu, Oct 11, 2012 at 04:54:53PM +0200, Paolo Bonzini wrote: > Il 11/10/2012 16:46, Michael S. Tsirkin ha scritto: > > Yes. Reason I ask is because q35 is adding bridges by default now. > > Would it be possible to only add them if requested on command line by user > > instead? > > Can you just u

Re: [Qemu-devel] [feature request] qemu-bridge-helper

2012-10-11 Thread Corey Bryant
On 10/10/2012 11:05 AM, Mario De Chenno wrote: It could be possible to add a sort of "ifname=" option to the qemu-bridge-helper program, so qemu could give a recognizable name to the tap interface the helper creates? Thanks all, Mairo De Chenno I don't see why not. If ifname is not specified

Re: [Qemu-devel] [PATCH 2/2] block: in commit, determine base image from the top image

2012-10-11 Thread Eric Blake
On 10/09/2012 11:56 PM, Jeff Cody wrote: > This simplifies some code and error checking, and also fixes a bug. > > bdrv_find_backing_image() should only be passed absolute filenames, > or filenames relative to the chain. In the QMP message handler for > block commit, when looking up the base do s

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-11 Thread Jason Baron
On Thu, Oct 11, 2012 at 04:46:56PM +0200, Michael S. Tsirkin wrote: > On Thu, Oct 11, 2012 at 10:21:22AM -0400, Jason Baron wrote: > > On Thu, Oct 11, 2012 at 12:57:06PM +0200, Michael S. Tsirkin wrote: > > > On Mon, Oct 08, 2012 at 11:30:39PM -0400, Jason Baron wrote: > > > > From: Jason Baron >

Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used

2012-10-11 Thread Michael S. Tsirkin
On Thu, Oct 11, 2012 at 04:35:23PM +0200, Avi Kivity wrote: > On 10/11/2012 04:35 PM, Michael S. Tsirkin wrote: > > >> No, qemu should configure virtio devices to bypass the iommu, even if it > >> is on. > > > > Okay so there will be some API that virtio devices should call > > to achieve this? >

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-11 Thread Paolo Bonzini
Il 11/10/2012 16:46, Michael S. Tsirkin ha scritto: > Yes. Reason I ask is because q35 is adding bridges by default now. > Would it be possible to only add them if requested on command line by user > instead? Can you just use shpc or pcie hotplug on those bridges? > I realize some guests expect d

Re: [Qemu-devel] [PATCH v2 2/3] monitor: Enable adding an inherited fd to an fd set

2012-10-11 Thread Corey Bryant
On 10/11/2012 07:25 AM, Kevin Wolf wrote: Am 10.10.2012 16:20, schrieb Corey Bryant: qmp_add_fd() gets an fd that was received over a socket with SCM_RIGHTS and adds it to an fd set. This patch adds support that will enable adding an fd that was inherited on the command line to an fd set. Th

Re: [Qemu-devel] [PATCH 4/7] savevm: Add VMSTATE_ helpers for target_phys_addr_t

2012-10-11 Thread Peter Maydell
On 11 October 2012 02:57, David Gibson wrote: > Actually, turns out I had another use of these helpers. That was to > store the real page address from the ppcmeb_tlb_t structure. That > structure is used to represent TLB entries on a number of different > embedded chips, which don't all have the

Re: [Qemu-devel] [PATCH v2 3/3] qemu-config: Add new -add-fd command line option

2012-10-11 Thread Corey Bryant
On 10/10/2012 06:31 PM, Eric Blake wrote: On 10/10/2012 08:20 AM, Corey Bryant wrote: This option can be used for passing file descriptors on the command line. It mirrors the existing add-fd QMP command which allows an fd to be passed to QEMU via SCM_RIGHTS and added to an fd set. This can b

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-11 Thread Michael S. Tsirkin
On Thu, Oct 11, 2012 at 10:21:22AM -0400, Jason Baron wrote: > On Thu, Oct 11, 2012 at 12:57:06PM +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 08, 2012 at 11:30:39PM -0400, Jason Baron wrote: > > > From: Jason Baron > > > > > > Add piix style acpi hotplug to q35. > > > > > > Signed-off-by: J

Re: [Qemu-devel] [RFC v1 3/7] memory: iommu support

2012-10-11 Thread Avi Kivity
On 10/11/2012 03:26 PM, Avi Kivity wrote: > Add a new memory region type that translates addresses it is given, > then forwards them to a target address space. This is similar to > an alias, except that the mapping is more flexible than a linear > translation and trucation, and also less efficient

Re: [Qemu-devel] [PATCH v2 16/21] q35: smbus: Remove PCI_STATUS_SIG_SYSTEM_ERROR and PCI_STATUS_DETECTED_PARITY from w1cmask

2012-10-11 Thread Michael S. Tsirkin
On Mon, Oct 08, 2012 at 11:30:36PM -0400, Jason Baron wrote: > From: Jan Kiszka > > Both bits are added to the write-1-to-clear mask by default. As the > smbus device does not allow writes at all, we have to remove it from > that mask, also to avoid triggering a runtime assertion. > > Signed-off

Re: [Qemu-devel] [PATCH v2 18/21] q35: Fix irr initialization for slots 25..31

2012-10-11 Thread Michael S. Tsirkin
On Mon, Oct 08, 2012 at 11:30:37PM -0400, Jason Baron wrote: > From: Isaku Yamahata > > This was totally off: The CC registers are 16 bit (stored as little > endian), their offsets run in reverse order, and D26IR as well as D25IR > have 4 bytes offset to their successors. > > Reported-by: Jan Ki

Re: [Qemu-devel] [PATCH v2 1/3] monitor: Allow add-fd to any specified fd set

2012-10-11 Thread Corey Bryant
On 10/10/2012 05:49 PM, Eric Blake wrote: On 10/10/2012 08:20 AM, Corey Bryant wrote: The first call to add an fd to an fd set was previously not allowed to choose the fd set ID. The ID was generated as the first available and ensuing calls could add more fds by specifying the fd set ID. Thi

Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used

2012-10-11 Thread Avi Kivity
On 10/11/2012 04:35 PM, Michael S. Tsirkin wrote: >> No, qemu should configure virtio devices to bypass the iommu, even if it >> is on. > > Okay so there will be some API that virtio devices should call > to achieve this? The iommu should probably call pci_device_bypasses_iommu() to check for su

Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used

2012-10-11 Thread Michael S. Tsirkin
On Thu, Oct 11, 2012 at 03:44:10PM +0200, Avi Kivity wrote: > On 10/11/2012 03:44 PM, Michael S. Tsirkin wrote: > > On Thu, Oct 11, 2012 at 03:34:54PM +0200, Avi Kivity wrote: > >> On 10/11/2012 03:31 PM, Michael S. Tsirkin wrote: > >> > On Thu, Oct 11, 2012 at 03:27:03PM +0200, Avi Kivity wrote: >

Re: [Qemu-devel] [PATCH v2 2/3] monitor: Enable adding an inherited fd to an fd set

2012-10-11 Thread Corey Bryant
On 10/10/2012 06:01 PM, Eric Blake wrote: On 10/10/2012 08:20 AM, Corey Bryant wrote: qmp_add_fd() gets an fd that was received over a socket with SCM_RIGHTS and adds it to an fd set. This patch adds support that will enable adding an fd that was inherited on the command line to an fd set. T

Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug.

2012-10-11 Thread Jason Baron
On Thu, Oct 11, 2012 at 12:57:06PM +0200, Michael S. Tsirkin wrote: > On Mon, Oct 08, 2012 at 11:30:39PM -0400, Jason Baron wrote: > > From: Jason Baron > > > > Add piix style acpi hotplug to q35. > > > > Signed-off-by: Jason Baron > > Something I don't understand here: this only handles hotpl

[Qemu-devel] [RFC v1 6/7] vfio: abort if an emulated iommu is used

2012-10-11 Thread Avi Kivity
vfio doesn't support guest iommus yet, indicate it to the user by gently depositing a core on their disk. Signed-off-by: Avi Kivity --- hw/vfio_pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index e9399a1..f935d00 100644 --- a/hw/vfio_pci.c +++ b/hw/vfi

Re: [Qemu-devel] [PATCH 0/6] Misc PCI cleanups

2012-10-11 Thread Alex Williamson
On Thu, 2012-10-11 at 15:49 +0200, Michael S. Tsirkin wrote: > On Thu, Oct 11, 2012 at 07:38:54AM -0600, Alex Williamson wrote: > > On Thu, 2012-10-11 at 12:37 +0200, Michael S. Tsirkin wrote: > > > On Wed, Oct 10, 2012 at 01:31:52PM -0600, Alex Williamson wrote: > > > > On Tue, 2012-10-09 at 09:09

Re: [Qemu-devel] [PATCH 0/6] Misc PCI cleanups

2012-10-11 Thread Michael S. Tsirkin
On Mon, Oct 08, 2012 at 05:54:58PM -0600, Alex Williamson wrote: > On Tue, 2012-10-09 at 00:44 +0200, Michael S. Tsirkin wrote: > > On Mon, Oct 08, 2012 at 04:09:48PM -0600, Alex Williamson wrote: > > > On Mon, 2012-10-08 at 23:50 +0200, Michael S. Tsirkin wrote: > > > > On Mon, Oct 08, 2012 at 03:

Re: [Qemu-devel] [RFC v1 3/7] memory: iommu support

2012-10-11 Thread Avi Kivity
On 10/11/2012 03:54 PM, Paolo Bonzini wrote: > Il 11/10/2012 15:45, Avi Kivity ha scritto: >> +struct MemoryRegionIOMMUOps { >> +/* Returns a TLB entry that contains a given address. */ >> +IOMMUTLBEntry (*translate)(MemoryRegion *iommu, target_phys_addr_t >> addr,

Re: [Qemu-devel] [RFC v1 4/7] pci: switch iommu to using the memory API

2012-10-11 Thread Avi Kivity
On 10/11/2012 03:53 PM, Paolo Bonzini wrote: > Il 11/10/2012 15:27, Avi Kivity ha scritto: >> -static int spapr_tce_translate(DMAContext *dma, >> - dma_addr_t addr, >> - target_phys_addr_t *paddr, >> - target_

Re: [Qemu-devel] [RFC v1 3/7] memory: iommu support

2012-10-11 Thread Paolo Bonzini
Il 11/10/2012 15:45, Avi Kivity ha scritto: >>> >> +struct MemoryRegionIOMMUOps { >>> >> +/* Returns a TLB entry that contains a given address. */ >>> >> +IOMMUTLBEntry (*translate)(MemoryRegion *iommu, target_phys_addr_t >>> >> addr, >>> >> + bool is_write);

Re: [Qemu-devel] [RFC v1 4/7] pci: switch iommu to using the memory API

2012-10-11 Thread Paolo Bonzini
Il 11/10/2012 15:27, Avi Kivity ha scritto: > -static int spapr_tce_translate(DMAContext *dma, > - dma_addr_t addr, > - target_phys_addr_t *paddr, > - target_phys_addr_t *len, > -

[Qemu-devel] [RFC v1 3/7] memory: iommu support

2012-10-11 Thread Avi Kivity
Add a new memory region type that translates addresses it is given, then forwards them to a target address space. This is similar to an alias, except that the mapping is more flexible than a linear translation and trucation, and also less efficient since the translation happens at runtime. The im

Re: [Qemu-devel] [PATCH 1/3] linux-user: implement FS_IOC_GETFLAGS ioctl

2012-10-11 Thread Alexander Graf
On 11.10.2012, at 15:36, Riku Voipio wrote: > Hi Alexander, > > On 21 August 2012 16:47, Peter Maydell wrote: >>> +#define TARGET_FS_IOC_GETFLAGS TARGET_IORU('f', 1) >> >> This and the SETFLAGS one in the next patch fail the consistency >> check that an x86_64-on-x86_64 linux-user binary perfo

Re: [Qemu-devel] [PATCH 0/6] Misc PCI cleanups

2012-10-11 Thread Michael S. Tsirkin
On Thu, Oct 11, 2012 at 07:38:54AM -0600, Alex Williamson wrote: > On Thu, 2012-10-11 at 12:37 +0200, Michael S. Tsirkin wrote: > > On Wed, Oct 10, 2012 at 01:31:52PM -0600, Alex Williamson wrote: > > > On Tue, 2012-10-09 at 09:09 +0200, Jan Kiszka wrote: > > > > On 2012-10-08 23:11, Alex Williamso

[Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used

2012-10-11 Thread Avi Kivity
vhost doesn't support guest iommus yet, indicate it to the user by gently depositing a core on their disk. Signed-off-by: Avi Kivity --- hw/vhost.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vhost.c b/hw/vhost.c index 0b4ac3f..cd5d9f5 100644 --- a/hw/vhost.c +++ b/hw/vhost.c @@ -45

Re: [Qemu-devel] [RFC v1 3/7] memory: iommu support

2012-10-11 Thread Avi Kivity
On 10/11/2012 03:42 PM, Paolo Bonzini wrote: > Il 11/10/2012 15:26, Avi Kivity ha scritto: >> +struct MemoryRegionIOMMUOps { >> +/* Returns a TLB entry that contains a given address. */ >> +IOMMUTLBEntry (*translate)(MemoryRegion *iommu, target_phys_addr_t addr, >> +

Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used

2012-10-11 Thread Avi Kivity
On 10/11/2012 03:44 PM, Michael S. Tsirkin wrote: > On Thu, Oct 11, 2012 at 03:34:54PM +0200, Avi Kivity wrote: >> On 10/11/2012 03:31 PM, Michael S. Tsirkin wrote: >> > On Thu, Oct 11, 2012 at 03:27:03PM +0200, Avi Kivity wrote: >> >> vhost doesn't support guest iommus yet, indicate it to the user

  1   2   >