Re: [Qemu-devel] [PATCH 0/3] vga: add mmio bar

2012-10-15 Thread Gerd Hoffmann
Hi, Patches don't apply, please rebase: Applying: vga: add mmio bar to standard vga error: patch failed: hw/pc_piix.c:371 error: hw/pc_piix.c: patch does not apply error: patch failed: hw/vga-pci.c:47 error: hw/vga-pci.c: patch does not apply Patch failed at 0001 vga: add mmio bar to

[Qemu-devel] [PATCH v2 0/4] vga: add mmio bar

2012-10-15 Thread Gerd Hoffmann
Hi, This patch series adds a mmio bar to the standard vga. It also drops a file into docs/specs/ describing the mmio bar and the other properties of the qemu standard vga and does a little cleanup by removing CONFIG_BOCHS_VBE. v2: - rebase to latest master and resolve conflicts. - add patch

[Qemu-devel] [PATCH v2 3/4] vga: add specs for standard vga

2012-10-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/specs/standard-vga.txt | 64 +++ hw/vga-isa.c|2 + hw/vga-pci.c|2 + 3 files changed, 68 insertions(+), 0 deletions(-) create mode 100644

[Qemu-devel] [PATCH v2 4/4] vga: remove CONFIG_BOCHS_VBE

2012-10-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/vga.c | 34 +- hw/vga_int.h | 28 +++- 2 files changed, 12 insertions(+), 50 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index 053f89d..679cabc 100644 --- a/hw/vga.c +++

[Qemu-devel] [PATCH v2 1/4] vga: fix indention

2012-10-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/vga-pci.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/vga-pci.c b/hw/vga-pci.c index 996d47f..5f55f36 100644 --- a/hw/vga-pci.c +++ b/hw/vga-pci.c @@ -48,25 +48,25 @@ static const

[Qemu-devel] [PATCH v2 2/4] vga: add mmio bar to standard vga

2012-10-15 Thread Gerd Hoffmann
This patch adds a mmio bar to the qemu standard vga which allows to access the standard vga registers and bochs dispi interface registers via mmio. Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/pc_piix.c |4 ++ hw/vga-pci.c | 108

Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support.

2012-10-15 Thread Lei Li
On 10/12/2012 08:39 PM, Gerd Hoffmann wrote: This patch adds chardev_add and chardev_del monitor commands. chardev_del is pretty straight forward, it just takes an id argument and zaps the chardev specified. chardev_add is more tricky as there are tons of arguments for the different backends.

Re: [Qemu-devel] Silent filesystem/qcow2 corruptions with qemu-kvm-1.0 and 1.1.1

2012-10-15 Thread Stefan Hajnoczi
On Fri, Oct 12, 2012 at 10:53:29AM +0200, Tiziano Müller wrote: Am Freitag, den 12.10.2012, 10:33 +0200 schrieb Stefan Hajnoczi: On Thu, Oct 11, 2012 at 03:33:23PM +0200, Tiziano Müller wrote: Checking the image using `qemu-img check` then gives something like this: ERROR

Re: [Qemu-devel] Any alternative to kqemu ?

2012-10-15 Thread Paolo Bonzini
Il 14/10/2012 12:52, Timothy Madden ha scritto: Hello Is kqemu deprecated ? It is simply not supported anymore. Is there an alternative to it ? No. `qemu-system-i386 -net nic ...` keeps saying upon invocation that vlan0 is not connected to host network. My `vconfig add eth1` command

[Qemu-devel] [PATCH v3 0/9] serial device hotplug patch series.

2012-10-15 Thread Gerd Hoffmann
This patch series tackles serial device hotplug. The first four patches have been on the list before, they implement pci-serial devices featuring a hot-pluggable 16550 uart and got some minor tweaks only. The next two patches update the usb-serial device. It will only show up in the guest when

[Qemu-devel] [PATCH v3 7/9] chardev: add error reporting for qemu_chr_new_from_opts

2012-10-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c | 24 +++- qemu-char.h |3 ++- vl.c|7 ++- 3 files changed, 23 insertions(+), 11 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b082bae..e2e1da8 100644 --- a/qemu-char.c +++

[Qemu-devel] [PATCH v3 8/9] chardev: fix QemuOpts lifecycle

2012-10-15 Thread Gerd Hoffmann
qemu_chr_new_from_opts handles QemuOpts release now, so callers don't have to worry. It will either be saved in CharDriverState, then released in qemu_chr_delete, or in the error case released instantly. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c | 15 ++-

[Qemu-devel] [PATCH v3 4/9] serial: add 2x + 4x pci variant

2012-10-15 Thread Gerd Hoffmann
Add multiport serial card implementation, with two variants, one featuring two and one featuring four ports. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/qemupciserial.inf |2 + hw/serial-pci.c| 157 2 files changed, 159

Re: [Qemu-devel] [PATCH v4 00/26] Add infrastructure for QIDL-based device serialization

2012-10-15 Thread Paolo Bonzini
Il 12/10/2012 23:10, Michael Roth ha scritto: These patches add infrastructure and unit tests for QIDL, which provides a serialization framework for QEMU device structures by generating visitor routines for device structs based on simple field annotations. Examples of how this is done are

Re: [Qemu-devel] [PATCH v4 24/26] qidl: add QAPI-based code generator

2012-10-15 Thread Paolo Bonzini
Il 12/10/2012 23:11, Michael Roth ha scritto: +elif field['type'].startswith('enum '): +typename = 'int' Note that there is support for enum properties in qdev. Please consider adding it, though it can be done as a follow-up. I'm going to play a bit with the series and

[Qemu-devel] [PATCH v3 5/9] usb-serial: don't magically zap chardev on umplug

2012-10-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-serial.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index 69b6e48..43214cd 100644 --- a/hw/usb/dev-serial.c +++ b/hw/usb/dev-serial.c @@ -421,7 +421,7 @@ static

Re: [Qemu-devel] Problems using netdev_del+netdev_add w/o corresponding device_del+device_add

2012-10-15 Thread Stefan Hajnoczi
On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote: Here is the sequence sent to disconnect only the host side, then reconnect it with a new tap device. (although the fd is the same, this is because the old tap device had already been closed, so the number is just being used - the

[Qemu-devel] [PATCH v3 9/9] chardev: add hotplug support.

2012-10-15 Thread Gerd Hoffmann
This patch adds chardev_add and chardev_del monitor commands. They work simliar to the netdev_{add,del} commands. The hmp version of chardev_add accepts like the -chardev command line option does. The qmp version expects the arguments being passed as named parameters. chardev_del just takes an

[Qemu-devel] [PATCH v3 1/9] serial: split serial.c

2012-10-15 Thread Gerd Hoffmann
Split serial.c into serial.c, serial.h and serial-isa.c. While being at creating a serial.h header file move the serial prototypes from pc.h to the new serial.h. The latter leads to s/pc.h/serial.h/ in tons of boards which just want the serial bits from pc.h Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] Any alternative to kqemu ?

2012-10-15 Thread Stefan Hajnoczi
On Sun, Oct 14, 2012 at 01:52:54PM +0300, Timothy Madden wrote: `qemu-system-i386 -net nic ...` keeps saying upon invocation that vlan0 is not connected to host network. My `vconfig add eth1` command completed successfully, and I can `ifconfig eth1.0`, although I see no IP address on the new

[Qemu-devel] [PATCH v3 2/9] serial: add pci variant

2012-10-15 Thread Gerd Hoffmann
So we get a hot-pluggable 16550 uart. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- default-configs/pci.mak |2 + hw/Makefile.objs|1 + hw/pci_ids.h|1 + hw/serial-pci.c | 115 +++ hw/serial.c |

Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used

2012-10-15 Thread liu ping fan
On Thu, Oct 11, 2012 at 11:48 PM, Avi Kivity a...@redhat.com wrote: On 10/11/2012 05:34 PM, Michael S. Tsirkin wrote: On Thu, Oct 11, 2012 at 04:35:23PM +0200, Avi Kivity wrote: On 10/11/2012 04:35 PM, Michael S. Tsirkin wrote: No, qemu should configure virtio devices to bypass the iommu,

[Qemu-devel] [PATCH v3 6/9] usb-serial: only expose device in guest when the chardev is open

2012-10-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-serial.c | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index 43214cd..a466f99 100644 --- a/hw/usb/dev-serial.c +++ b/hw/usb/dev-serial.c @@ -427,6

[Qemu-devel] [PATCH v3 3/9] serial: add windows inf file for the pci card to docs

2012-10-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/qemupciserial.inf | 107 1 files changed, 107 insertions(+), 0 deletions(-) create mode 100644 docs/qemupciserial.inf diff --git a/docs/qemupciserial.inf b/docs/qemupciserial.inf new file

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Test qemu-img operation on zero size image

2012-10-15 Thread Kevin Wolf
Am 12.10.2012 18:57, schrieb Paolo Bonzini: FWIW, this will require renaming the mirror test to 042 :( Since I have multiple patches touching the file while you have just one, any chance you can hold up this series for a week or so? So is 042 still free? Then I'd just change this patch to use

Re: [Qemu-devel] [PATCH v3 22/22] qidl: unit tests and build infrastructure

2012-10-15 Thread Kevin Wolf
Am 12.10.2012 23:39, schrieb Michael Roth: On Fri, Oct 05, 2012 at 10:24:30AM +0200, Paolo Bonzini wrote: Il 04/10/2012 19:33, Michael Roth ha scritto: + +%.qidl.c: %.c $(SRC_PATH)/qidl.h $(addprefix $(SRC_PATH)/scripts/,lexer.py qidl.py qidl_parser.py qapi.py qapi_visit.py) + $(call rm

Re: [Qemu-devel] [Bug 1066055] [NEW] Network performance regression with vde_switch

2012-10-15 Thread Stefan Hajnoczi
On Fri, Oct 12, 2012 at 05:34:23PM -, Edivaldo de Araujo Pereira wrote: I've noticed a significant network performance regression when using vde_switch, starting about one week ago (10/05/2012); before that date, I used to get about 1.5 Gbits host to guest, but now I can only get about 320

Re: [Qemu-devel] qemu-img: document 'info --backing-chain

2012-10-15 Thread Stefan Hajnoczi
On Sun, Oct 14, 2012 at 11:00:55AM +0530, Kashyap Chamarthy wrote: From a6233277e17338f571dda27cd9192d764f824b18 Mon Sep 17 00:00:00 2001 From: Kashyap Chamarthy kashyap...@gmail.com Date: Sun, 14 Oct 2012 09:51:18 +0530 Subject: [PATCH v2] qemu-img: document 'info --backing-chain'

Re: [Qemu-devel] fixing qemu-0.1X endless loop in qcow2_alloc_cluster_offset

2012-10-15 Thread Kevin Wolf
Am 12.10.2012 17:52, schrieb Andreas Färber: Am 12.06.2012 15:44, schrieb Kevin Wolf: Am 12.06.2012 15:33, schrieb Andreas Färber: Am 14.05.2012 14:20, schrieb Kevin Wolf: Am 13.05.2012 10:03, schrieb Zhouyi Zhou: hi all sometimes, qemu/kvm-0.1x will hang in endless loop in

Re: [Qemu-devel] [libvirt] Problems using netdev_del+netdev_add w/o corresponding device_del+device_add

2012-10-15 Thread Daniel P. Berrange
On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote: On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote: Here is the sequence sent to disconnect only the host side, then reconnect it with a new tap device. (although the fd is the same, this is because the old tap device

Re: [Qemu-devel] Silent filesystem/qcow2 corruptions with qemu-kvm-1.0 and 1.1.1

2012-10-15 Thread Tiziano Müller
Am Montag, den 15.10.2012, 09:48 +0200 schrieb Stefan Hajnoczi: Okay, that's consistent with the other symptoms you've reported. It's not clear whether the corruption arises inside qcow2 or if something else is causing corruption and qcow2/xfs get upset. That is the next step to debugging

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Test qemu-img operation on zero size image

2012-10-15 Thread Paolo Bonzini
Am 12.10.2012 18:57, schrieb Paolo Bonzini: FWIW, this will require renaming the mirror test to 042 :( Since I have multiple patches touching the file while you have just one, any chance you can hold up this series for a week or so? So is 042 still free? Then I'd just change this

[Qemu-devel] [PATCH 2/8] console: add unregister_displaychangelistener

2012-10-15 Thread Gerd Hoffmann
Also change the way the gui_timer is initialized: each time a displaychangelistener is registered or unregistered we'll check whenever we need a timer (due to dpy_refresh callback being present) and if so setup a timer, otherwise zap it. This way the gui timer works correctly with

[Qemu-devel] [PATCH 6/8] console: init displaychangelisteners on register

2012-10-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.h |3 +++ vl.c |1 - 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/console.h b/console.h index 9d008b2..bd56f3c 100644 --- a/console.h +++ b/console.h @@ -241,6 +241,9 @@ static inline void

[Qemu-devel] [PATCH 3/8] console: move set_mouse + cursor_define callbacks

2012-10-15 Thread Gerd Hoffmann
When adding DisplayChangeListeners the set_mouse and cursor_define callbacks have been left in DisplayState for some reason. Fix it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c |2 +- console.h | 39 +++ hw/jazz_led.c

[Qemu-devel] [PATCH 8/8] console: remove dpy_gfx_fill

2012-10-15 Thread Gerd Hoffmann
Unused code. 'nuff said. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.h | 13 - ui/sdl.c |7 --- 2 files changed, 0 insertions(+), 20 deletions(-) diff --git a/console.h b/console.h index bd56f3c..78e842f 100644 --- a/console.h +++ b/console.h @@ -161,8

[Qemu-devel] [PATCH 5/8] console: untangle gfx txt updates

2012-10-15 Thread Gerd Hoffmann
Stop abusing displaysurface fields for text mode displays. (bpp = 0, width = cols, height = lines). Add flags to displaystate indicating whenever text mode display (curses) or gfx mode displays (sdl, vnc, ...) are present. Add separate displaychangelistener callbacks for text / gfx mode resize

Re: [Qemu-devel] [PATCH v4 26/26] qidl: unit tests and build infrastructure

2012-10-15 Thread Paolo Bonzini
Il 12/10/2012 23:11, Michael Roth ha scritto: +%.qidl.c: %.c $(SRC_PATH)/qidl.h $(addprefix $(SRC_PATH)/scripts/,lexer.py qidl.py qidl_parser.py qapi.py qapi_visit.py) The rule here is wrong, because %.qidl.c is never produced by the commands. The output is in the qidl-generated subdirectory,

[Qemu-devel] [PATCH 1/8] console: QLIST-ify display change listeners.

2012-10-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.h | 72 +++ hw/xenfb.c |2 +- vl.c |9 ++- 3 files changed, 42 insertions(+), 41 deletions(-) diff --git a/console.h b/console.h index f990684..646ad4b 100644

[Qemu-devel] [PATCH 4/8] console: s/TextConsole/QemuConsole/

2012-10-15 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c | 72 qemu-common.h |3 +- 2 files changed, 37 insertions(+), 38 deletions(-) diff --git a/console.c b/console.c index 260a029..b53dc1b 100644 --- a/console.c +++

[Qemu-devel] KVM call agenda for 2012-10-16

2012-10-15 Thread Juan Quintela
Hi Please send in any agenda topics you are interested in. Later, Juan.

[Qemu-devel] [PATCH 0/8] console cleanups

2012-10-15 Thread Gerd Hoffmann
Hi, First step in making qemu use pixman: A bunch of console subsystem cleanups. cheers, Gerd The following changes since commit 8b4a3df8081f3e6f1061ed5cbb303ad623ade66b: Fix popcnt in long mode (2012-10-14 14:55:09 +0400) are available in the git repository at:

[Qemu-devel] [PATCH 7/8] vga: fix text mode updating

2012-10-15 Thread Gerd Hoffmann
With both text (curses) and graphics (vnc/sdl/spice/...) display active vga text mode emulation fails to update both correctly. Depending on whenever vga_update_text() or vga_draw_text() happens to be called first only the text display or only the graphics display will see display resolution

Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used

2012-10-15 Thread Avi Kivity
On 10/11/2012 09:38 PM, Alex Williamson wrote: On Thu, 2012-10-11 at 17:48 +0200, Avi Kivity wrote: On 10/11/2012 05:34 PM, Michael S. Tsirkin wrote: On Thu, Oct 11, 2012 at 04:35:23PM +0200, Avi Kivity wrote: On 10/11/2012 04:35 PM, Michael S. Tsirkin wrote: No, qemu should configure

Re: [Qemu-devel] [RFC v1 4/7] pci: switch iommu to using the memory API

2012-10-15 Thread Avi Kivity
On 10/13/2012 11:13 AM, Blue Swirl wrote: struct PCIBus { BusState qbus; -PCIDMAContextFunc dma_context_fn; -void *dma_context_opaque; +PCIIOMMUFunc iommu_fn; +PCIIOMMUDestructorFunc iommu_dtor_fn; +void *iommu_opaque; Maybe the opaque could be avoided (in later

Re: [Qemu-devel] [RFC v1 7/7] vhost: abort if an emulated iommu is used

2012-10-15 Thread Avi Kivity
On 10/15/2012 10:44 AM, liu ping fan wrote: On Thu, Oct 11, 2012 at 11:48 PM, Avi Kivity a...@redhat.com wrote: On 10/11/2012 05:34 PM, Michael S. Tsirkin wrote: On Thu, Oct 11, 2012 at 04:35:23PM +0200, Avi Kivity wrote: On 10/11/2012 04:35 PM, Michael S. Tsirkin wrote: No, qemu should

[Qemu-devel] RFC: usb input pipelining / speedup patchset v2

2012-10-15 Thread Hans de Goede
Here is v2 of my usb input pipelining and speedup patchset + some assorted fixes, taking into account all the remarks from the discussion surrounding v1, Please review! Note this is still RFC status as I would like to run some more tests before this going upstream. Thanks Regards, Hans

[Qemu-devel] [PATCH 07/22] ehci: Detect going in circles when filling the queue

2012-10-15 Thread Hans de Goede
For ctrl endpoints Windows (atleast Win7) creates circular td lists, so far these were not a problem because we would stop filling the queue if altnext was set. Since further patches in this patchset remove the altnext check this does become a problem and we need detection for going in circles.

[Qemu-devel] [PATCH 05/22] ehci: Improve latency of interrupt delivery and async schedule scanning

2012-10-15 Thread Hans de Goede
While doing various performance tests of reading from USB mass storage devices I noticed the following:: 1) When an async handled packet completes, we don't immediately report an interrupt to the guest, instead we wait for the frame-timer to run and report it from there 2) If 1) has been

[Qemu-devel] [PATCH 09/22] usb: Rename __usb_packet_complete to usb_packet_complete_one

2012-10-15 Thread Hans de Goede
And make it available for use outside of core.c Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb.h | 1 + hw/usb/core.c | 8 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/usb.h b/hw/usb.h index 48c8926..01dd423 100644 --- a/hw/usb.h +++ b/hw/usb.h @@

[Qemu-devel] [PATCH 11/22] usb: Move clearing of queue on halt to the core

2012-10-15 Thread Hans de Goede
hcds which queue up more then one packet at once (uhci, ehci and xhci), must clear the queue after an error which has caused the queue to halt. Currently this is handled as a special case inside the hcd code, this patch instead adds an USB_RET_REMOVE_FROM_QUEUE packet result code, teaches the 3

[Qemu-devel] [PATCH 14/22] usb: Add packet combining functions

2012-10-15 Thread Hans de Goede
Currently we only do pipelining for output endpoints, since to properly support short-not-ok semantics we can only have one outstanding input packet. Since the ehci and uhci controllers have a limited per td packet size guests will split large input transfers to into multiple packets, and since we

[Qemu-devel] [PATCH 18/22] usb-redir: Add support for input pipelining

2012-10-15 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/redirect.c | 67 ++- 1 file changed, 57 insertions(+), 10 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 030522e..f715281 100644 --- a/hw/usb/redirect.c +++

[Qemu-devel] [PATCH 20/22] usb-redir: Use reject rather the disconnect on bad ep info

2012-10-15 Thread Hans de Goede
So that the client gets a notification about us disconnecting the device. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/redirect.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 9e88779..26f501a 100644 ---

[Qemu-devel] [PATCH 13/22] usb: Add an int_req flag to USBPacket

2012-10-15 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb.h | 3 ++- hw/usb/core.c | 3 ++- hw/usb/hcd-ehci.c | 6 -- hw/usb/hcd-musb.c | 2 +- hw/usb/hcd-ohci.c | 7 +-- hw/usb/hcd-uhci.c | 3 ++- hw/usb/hcd-xhci.c | 13 +++-- 7 files changed, 27

[Qemu-devel] [PATCH 06/22] ehci: Speed up the timer of raising int from the async schedule

2012-10-15 Thread Hans de Goede
Often the guest will queue up new packets in response to a packet, in the async schedule with its IOC flag set, completing. By speeding up the frame-timer, we notice these new packets earlier. This increases the speed (MB/s) of a Linux guest reading from a USB mass storage device by a factor of

Re: [Qemu-devel] [RFC v1 0/7] IOMMU support

2012-10-15 Thread Avi Kivity
On 10/12/2012 04:36 AM, Benjamin Herrenschmidt wrote: On Thu, 2012-10-11 at 15:26 +0200, Avi Kivity wrote: These patches add IOMMU support to the memory core. IOMMUs can be added anywhere in the memory hierarchy, and may be arranged in series. I haven't had a chance to review in details

[Qemu-devel] [PATCH 17/22] usb-redir: Add support for 32 bits bulk packet length

2012-10-15 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- configure | 2 +- hw/usb/redirect.c | 7 ++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 248b871..036c38a 100755 --- a/configure +++ b/configure @@ -2768,7 +2768,7 @@ fi # check for

[Qemu-devel] [PATCH 08/22] xhci: Add a xhci_ep_nuke_one_xfer helper function

2012-10-15 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/hcd-xhci.c | 49 ++--- 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index e0ca690..0d90578 100644 --- a/hw/usb/hcd-xhci.c +++

[Qemu-devel] [PATCH 10/22] usb: Add USB_RET_ADD_TO_QUEUE packet result code

2012-10-15 Thread Hans de Goede
This can be used by usb-device code which wishes to process an entire endpoint queue at once, to do this the usb-device code returns USB_RET_ADD_TO_QUEUE from its handle_data class method and defines a flush_ep_queue class method to call when the hcd is done queuing up packets. Signed-off-by:

[Qemu-devel] [PATCH 12/22] usb: Move short-not-ok handling to the core

2012-10-15 Thread Hans de Goede
After a short-not-ok packet ending short, we should not advance the queue. Move enforcing this to the core, rather then handling it in the hcd code. This may result in the queue now actually containing multiple input packets (which would not happen before), and this requires special handling in

[Qemu-devel] [PATCH 21/22] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller

2012-10-15 Thread Hans de Goede
From: Jan Kiszka jan.kis...@siemens.com This follows the logic of host-linux: If a 2.0 device has no ISO endpoint and no interrupt endpoint with a packet size 64, we can attach it also to an 1.1 host controller. In case the redir server does not report endpoint sizes, play safe and remove the

Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support.

2012-10-15 Thread Andreas Färber
Am 15.10.2012 08:51, schrieb Lei Li: On 10/12/2012 08:39 PM, Gerd Hoffmann wrote: +void qmp_chardev_del(const char *id, Error **errp) +{ +CharDriverState *chr; + +chr = qemu_chr_find(id); +if (NULL == chr) { +error_setg(errp, Chardev '%s' not found\n, id); Maybe this

Re: [Qemu-devel] Silent filesystem/qcow2 corruptions with qemu-kvm-1.0 and 1.1.1

2012-10-15 Thread Kevin Wolf
Am 12.10.2012 10:53, schrieb Tiziano Müller: Am Freitag, den 12.10.2012, 10:33 +0200 schrieb Stefan Hajnoczi: On Thu, Oct 11, 2012 at 03:33:23PM +0200, Tiziano Müller wrote: Checking the image using `qemu-img check` then gives something like this: ERROR OFLAG_COPIED: offset=3bc3

[Qemu-devel] [PATCH 01/22] uhci: Properly unmap packets on cancel / invalid pid

2012-10-15 Thread Hans de Goede
Packets with an invalid pid, or which were cancelled have usb_packet_map() called on them on init, but not usb_packet_unmap() before being freed. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/hcd-uhci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/usb/hcd-uhci.c

[Qemu-devel] [PATCH 03/22] ehci: Get rid of packet tbytes field

2012-10-15 Thread Hans de Goede
This field is used in some places to track the tbytes field of the token, but in other places the field is used directly, use it directly everywhere for consistency. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/hcd-ehci.c | 20 +--- 1 file changed, 9 insertions(+),

[Qemu-devel] [PATCH 02/22] uhci: Move checks to continue queuing to uhci_fill_queue()

2012-10-15 Thread Hans de Goede
Rather then having a special check to start queuing after the first packet, and then another check for the other packets in uhci_fill_queue(), simply check the previous packet beforehand in uhci_fill_queue() Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/hcd-uhci.c | 10 +++---

[Qemu-devel] [PATCH 19/22] usb-redir: Add an usbredir_setup_usb_eps() helper function

2012-10-15 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/redirect.c | 45 ++--- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index f715281..9e88779 100644 --- a/hw/usb/redirect.c +++

[Qemu-devel] [PATCH 22/22] usb-redir: Allow redirecting super speed devices to high speed controllers

2012-10-15 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/redirect.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 63b7010..ae815b9 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -1097,7

Re: [Qemu-devel] [PATCH 06/22] ehci: Speed up the timer of raising int from the async schedule

2012-10-15 Thread Gerd Hoffmann
On 10/15/12 12:38, Hans de Goede wrote: Often the guest will queue up new packets in response to a packet, in the async schedule with its IOC flag set, completing. By speeding up the frame-timer, we notice these new packets earlier. This increases the speed (MB/s) of a Linux guest reading from

[Qemu-devel] [PATCH 15/22] combined-packet: Add a workaround for Linux usbfs + live migration

2012-10-15 Thread Hans de Goede
Older versions (anything but the latest) of Linux usbfs + libusb(x), will submit larger (bulk) transfers split into multiple 16k submissions, which means that rather then all tds getting linked into the queue in one atomic operarion they get linked in a bunch at a time, which could cause problems

[Qemu-devel] [PATCH 04/22] ehci: Set int flag on a short input packet

2012-10-15 Thread Hans de Goede
According to 4.15.1.2 an interrupt must be raised when a short packet is received. If we don't do this it may take a significant time for the guest to notice a short trasnfer has completed, since only the last td will have its IOC flag set, and a short transfer may complete in an earlier packet.

[Qemu-devel] [PATCH 16/22] usb-redir: When a packet contains data on a stall, ignore the stall

2012-10-15 Thread Hans de Goede
It is possbile for bulk packets to transfer some of the data and to then stall. ATM our usb core allows us to return either data, or an error, not both. For now return the data rather then the stall when this happens, counting on further packets to detect the stall. In the future we should fix the

[Qemu-devel] Connecting virtio-9p-pci to a remote 9p server

2012-10-15 Thread Chris Webb
We're planning to implement shared filesystems for guests on our virtualized hosting platform, stored on a central fileserver separate from the hosts. Whilst we can mount the shares on each host and then use qemu's 9p passthrough/proxy support to access the mountpoint, going via the host kernel

Re: [Qemu-devel] Silent filesystem/qcow2 corruptions with qemu-kvm-1.0 and 1.1.1

2012-10-15 Thread Tiziano Müller
Am Montag, den 15.10.2012, 13:11 +0200 schrieb Kevin Wolf: Am 12.10.2012 10:53, schrieb Tiziano Müller: Am Freitag, den 12.10.2012, 10:33 +0200 schrieb Stefan Hajnoczi: On Thu, Oct 11, 2012 at 03:33:23PM +0200, Tiziano Müller wrote: Checking the image using `qemu-img check` then gives

Re: [Qemu-devel] [PATCH v5] target-i386: initialize APIC at CPU level

2012-10-15 Thread Igor Mammedov
On Sun, 14 Oct 2012 06:09:56 +0200 Andreas Färber afaer...@suse.de wrote: Am 13.10.2012 22:35, schrieb Igor Mammedov: (L)APIC is a part of cpu [1] so move APIC initialization inside of x86_cpu object. Since cpu_model and override flags currently specify whether APIC should be created or

[Qemu-devel] [PATCH v2 0/3] qemu-img: Add --backing-chain option to info command

2012-10-15 Thread Stefan Hajnoczi
This series adds the --backing-chain option for enumerating the backing file chain. Given the topmost image it will print qemu-img info information for each image file in the chain. Special care needs to be taken when image files form an infinite loop. This is very unusual, most like due to

[Qemu-devel] [PATCH v2 1/3] qemu-img: Add --backing-chain option to info command

2012-10-15 Thread Stefan Hajnoczi
The qemu-img info --backing-chain option enumerates the backing file chain. For example, for base.qcow2 - snap1.qcow2 - snap2.qcow2 the output becomes: $ qemu-img info --backing-chain snap2.qcow2 image: snap2.qcow2 file format: qcow2 virtual size: 100M (104857600 bytes) disk size: 196K

[Qemu-devel] [PATCH v2 3/3] qemu-iotests: Add 041 backing file chain infinite loop test

2012-10-15 Thread Stefan Hajnoczi
This new test verifies that qemu-img info --backing-chain safely aborts when an image file has a backing file infinite loop. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/041 | 90 tests/qemu-iotests/041.out | 81

[Qemu-devel] [PATCH v2 2/3] qemu-img: Detect backing file chain infinite loops

2012-10-15 Thread Stefan Hajnoczi
A malicious or corruption image can contain an infinite loop of backing files. The qemu-img info --backing-chain command must not hang when such files are encountered. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qemu-img.c | 17 + 1 file changed, 17 insertions(+)

[Qemu-devel] delvm does not reduce the qcow2 file size

2012-10-15 Thread Kuniyasu Suzaki
Hello, delvm is a command to delete a snapshot image in a qcow2 file. However it does not reduce the qcow2 file size. Is there any method to reduce the qcow2 file size when I delete a snapshot image? should I convert the qcow2 file? -- suzaki

[Qemu-devel] [PATCH] hw/qxl: guest bug on primary create with stride %4 != 0

2012-10-15 Thread Alon Levy
Due to usage of pixman for rendering on all spice surfaces we have pixman's requirement that the stride be word aligned. A guest not honoring that can crash spice and qemu with it due to failure to create a surface (in spice-server). Avoid this early on in primary surface creation and offscreen

Re: [Qemu-devel] [PATCH v5] target-i386: initialize APIC at CPU level

2012-10-15 Thread Andreas Färber
Am 15.10.2012 13:54, schrieb Igor Mammedov: On Sun, 14 Oct 2012 06:09:56 +0200 Andreas Färber afaer...@suse.de wrote: Am 13.10.2012 22:35, schrieb Igor Mammedov: (L)APIC is a part of cpu [1] so move APIC initialization inside of x86_cpu object. Since cpu_model and override flags currently

Re: [Qemu-devel] [PATCH 06/22] ehci: Speed up the timer of raising int from the async schedule

2012-10-15 Thread Hans de Goede
Hi, On 10/15/2012 01:17 PM, Gerd Hoffmann wrote: On 10/15/12 12:38, Hans de Goede wrote: Often the guest will queue up new packets in response to a packet, in the async schedule with its IOC flag set, completing. By speeding up the frame-timer, we notice these new packets earlier. This

Re: [Qemu-devel] [PATCH v5] target-i386: initialize APIC at CPU level

2012-10-15 Thread Igor Mammedov
On Mon, 15 Oct 2012 14:58:40 +0200 Andreas Färber afaer...@suse.de wrote: Am 15.10.2012 13:54, schrieb Igor Mammedov: On Sun, 14 Oct 2012 06:09:56 +0200 Andreas Färber afaer...@suse.de wrote: Am 13.10.2012 22:35, schrieb Igor Mammedov: (L)APIC is a part of cpu [1] so move APIC

Re: [Qemu-devel] [PATCH v4 24/26] qidl: add QAPI-based code generator

2012-10-15 Thread Paolo Bonzini
Il 15/10/2012 10:12, Paolo Bonzini ha scritto: Il 12/10/2012 23:11, Michael Roth ha scritto: +elif field['type'].startswith('enum '): +typename = 'int' Note that there is support for enum properties in qdev. Please consider adding it, though it can be done as a

Re: [Qemu-devel] [PULL v3 00/23] Integrate DMA into the memory API

2012-10-15 Thread Avi Kivity
On 10/11/2012 11:01 PM, Anthony Liguori wrote: This conflicts with a recent pull from Stefano in xen-all.c. The difference doesn't look that awful but since I don't have a xen test setup, I'm not confident in resolving it myself. Can you rebase and fixup? Rebased tree in the same place:

Re: [Qemu-devel] delvm does not reduce the qcow2 file size

2012-10-15 Thread Paolo Bonzini
Il 15/10/2012 11:33, Kuniyasu Suzaki ha scritto: Hello, delvm is a command to delete a snapshot image in a qcow2 file. However it does not reduce the qcow2 file size. Note that the file will not grow when new allocations are performed in the future. QEMU should also convert the unused

Re: [Qemu-devel] [PATCH v3 21/22] qidl: qidl.h, definitions for qidl annotations

2012-10-15 Thread Paolo Bonzini
Il 05/10/2012 18:47, Michael Roth ha scritto: On Fri, Oct 05, 2012 at 05:53:09PM +0200, Paolo Bonzini wrote: Il 05/10/2012 17:41, Michael Roth ha scritto: On Fri, Oct 05, 2012 at 05:07:46PM +0200, Paolo Bonzini wrote: Il 04/10/2012 19:33, Michael Roth ha scritto: Signed-off-by: Michael Roth

Re: [Qemu-devel] [PATCH v10 00/14] QEMU MIPS ASE DSP support

2012-10-15 Thread Andreas Färber
Am 15.10.2012 12:35, schrieb Jia Liu: ping~~ Aurelien Any more comment except the TODO one? I briefly looked through 01-12 and nothing caught my eye. Since you'll be resending anyway, could you rethink the subjects? There's no directory target-mips-ase-dsp, just target-mips. Maybe

Re: [Qemu-devel] [PATCH v3 1/9] serial: split serial.c

2012-10-15 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Split serial.c into serial.c, serial.h and serial-isa.c. While being at creating a serial.h header file move the serial prototypes from pc.h to the new serial.h. The latter leads to s/pc.h/serial.h/ in tons of boards which just want the serial bits

Re: [Qemu-devel] [PATCH 2/8] console: add unregister_displaychangelistener

2012-10-15 Thread Andreas Färber
Am 15.10.2012 11:51, schrieb Gerd Hoffmann: Also change the way the gui_timer is initialized: each time a displaychangelistener is registered or unregistered we'll check whenever we need a timer (due to dpy_refresh callback being present) whether and if so setup a timer, otherwise zap it.

Re: [Qemu-devel] [PATCH v3 4/9] serial: add 2x + 4x pci variant

2012-10-15 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Add multiport serial card implementation, with two variants, one featuring two and one featuring four ports. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/qemupciserial.inf |2 + hw/serial-pci.c| 157

Re: [Qemu-devel] [PATCH v3 9/9] chardev: add hotplug support.

2012-10-15 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: This patch adds chardev_add and chardev_del monitor commands. They work simliar to the netdev_{add,del} commands. The hmp version of chardev_add accepts like the -chardev command line option does. The qmp version expects the arguments being passed as

Re: [Qemu-devel] delvm does not reduce the qcow2 file size

2012-10-15 Thread Kevin Wolf
Am 15.10.2012 15:25, schrieb Paolo Bonzini: Il 15/10/2012 11:33, Kuniyasu Suzaki ha scritto: Hello, delvm is a command to delete a snapshot image in a qcow2 file. However it does not reduce the qcow2 file size. Note that the file will not grow when new allocations are performed in the

Re: [Qemu-devel] Connecting virtio-9p-pci to a remote 9p server

2012-10-15 Thread Troy Benjegerdes
On Mon, Oct 15, 2012 at 12:36:08PM +0100, Chris Webb wrote: We're planning to implement shared filesystems for guests on our virtualized hosting platform, stored on a central fileserver separate from the hosts. Whilst we can mount the shares on each host and then use qemu's 9p

Re: [Qemu-devel] fixing qemu-0.1X endless loop in qcow2_alloc_cluster_offset

2012-10-15 Thread Andreas Färber
Am 15.10.2012 11:13, schrieb Kevin Wolf: Am 12.10.2012 17:52, schrieb Andreas Färber: Am 12.06.2012 15:44, schrieb Kevin Wolf: Am 12.06.2012 15:33, schrieb Andreas Färber: Am 14.05.2012 14:20, schrieb Kevin Wolf: Am 13.05.2012 10:03, schrieb Zhouyi Zhou: sometimes, qemu/kvm-0.1x will hang

Re: [Qemu-devel] fixing qemu-0.1X endless loop in qcow2_alloc_cluster_offset

2012-10-15 Thread Kevin Wolf
Am 15.10.2012 16:28, schrieb Andreas Färber: What I'm suggesting (not even compile tested!) is: Signed-off-by: Kevin Wolf kw...@redhat.com diff --git a/block/qcow2.c b/block/qcow2.c index 48e1b95..d665675 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -388,10 +388,7 @@ typedef struct

Re: [Qemu-devel] [PATCH v3 22/22] qidl: unit tests and build infrastructure

2012-10-15 Thread Michael Roth
On Mon, Oct 15, 2012 at 10:52:37AM +0200, Kevin Wolf wrote: Am 12.10.2012 23:39, schrieb Michael Roth: On Fri, Oct 05, 2012 at 10:24:30AM +0200, Paolo Bonzini wrote: Il 04/10/2012 19:33, Michael Roth ha scritto: + +%.qidl.c: %.c $(SRC_PATH)/qidl.h $(addprefix

Re: [Qemu-devel] [libvirt] Problems using netdev_del+netdev_add w/o corresponding device_del+device_add

2012-10-15 Thread Laine Stump
On 10/15/2012 05:25 AM, Daniel P. Berrange wrote: On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote: On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote: Here is the sequence sent to disconnect only the host side, then reconnect it with a new tap device. (although the fd

  1   2   >