[Qemu-devel] [PATCH v2 6/7] TCG: Use gen_opparam_buf from context instead of global variable.

2012-10-22 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- tcg/tcg.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index c4e663b..f332463 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -298,7 +298,7 @@ void tcg_func_start(TCGContext *s) #endif s->gen_opc_ptr =

Re: [Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver

2012-10-22 Thread Lei Li
On 10/23/2012 02:14 AM, Luiz Capitulino wrote: On Mon, 22 Oct 2012 00:47:57 +0800 Lei Li wrote: Signed-off-by: Lei Li This patch should be squashed in the next one. More comments below. --- qemu-char.c | 72 +++ 1 files changed,

Re: [Qemu-devel] [PATCH 3/5] QAPI: Introduce memchar-write QMP command

2012-10-22 Thread Lei Li
On 10/23/2012 02:37 AM, Luiz Capitulino wrote: On Mon, 22 Oct 2012 00:47:59 +0800 Lei Li wrote: Signed-off-by: Lei Li --- hmp-commands.hx | 22 + hmp.c| 19 +++ hmp.h|1 + qapi-schema.json | 69 +++

[Qemu-devel] [PATCH v2 5/7] TCG: Use gen_opc_buf from context instead of global variable.

2012-10-22 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- target-alpha/translate.c |6 ++-- target-arm/translate.c|6 ++-- target-cris/translate.c |9 +++--- target-i386/translate.c |6 ++-- target-lm32/translate.c |9 +++--- target-m68k/translate.c |6 ++--

[Qemu-devel] [PATCH v2 4/7] TCG: Use gen_opparam_ptr from context instead of global variable.

2012-10-22 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- gen-icount.h |2 +- tcg/tcg-op.h | 254 +- tcg/tcg.c| 36 - 3 files changed, 146 insertions(+), 146 deletions(-) diff --git a/gen-icount.h b/gen-icount.h index 430cb44..be0bd7e 100644 --

[Qemu-devel] [PATCH v2 3/7] TCG: Use gen_opc_ptr from context instead of global variable.

2012-10-22 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- target-alpha/translate.c |8 ++--- target-arm/translate.c|8 ++--- target-cris/translate.c | 10 +++--- target-i386/translate.c |8 ++--- target-lm32/translate.c | 10 +++--- target-m68k/translate.c |8 ++-

[Qemu-devel] [PATCH v2 1/7] tcg/tcg.h: Duplicate global TCG variables in TCGContext

2012-10-22 Thread Evgeny Voevodin
From: Evgeny Signed-off-by: Evgeny Signed-off-by: Evgeny Voevodin --- tcg/tcg.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/tcg/tcg.h b/tcg/tcg.h index 45e94f5..43b4317 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -422,6 +422,12 @@ struct TCGContext { int temps_in_use;

[Qemu-devel] [PATCH v2 7/7] TCG: Remove unused global variables

2012-10-22 Thread Evgeny Voevodin
From: Evgeny Signed-off-by: Evgeny Voevodin --- tcg/tcg.c |4 tcg/tcg.h |4 translate-all.c |3 --- 3 files changed, 11 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index f332463..53bf109 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -96,10 +96,6 @@ const size_

Re: [Qemu-devel] [patch v4 08/16] QemuThread: make QemuThread as tls to store extra info

2012-10-22 Thread liu ping fan
On Tue, Oct 23, 2012 at 1:13 AM, Peter Maydell wrote: > On 22 October 2012 10:30, Jan Kiszka wrote: >> Can't we enhance qemu-tls.h to work via pthread_setspecific in case >> __thread is not working and use that abstraction (DECLARE/DEFINE_TLS) >> directly? > > Agreed. (There were prototype patche

[Qemu-devel] [PATCHv2 4/4] Warning messages on net devices hotplug

2012-10-22 Thread Eduardo Otubo
With the inclusion of the new "double whitelist" seccomp filter, Qemu won't be able to execve() in runtime, thus, no hotplug net devices allowed. v2: * Error messages moved to the backend function, net_init_tap(), recommended by Paolo Bonzini * Documentation added to QMP and HMP commands

[Qemu-devel] [PATCHv2 2/4] Setting "-sandbox on" as deafult

2012-10-22 Thread Eduardo Otubo
Now the seccomp filter will be set to "on" even if no argument "-sandbox" is given. v2: nothing new Signed-off-by: Eduardo Otubo --- configure | 2 +- vl.c | 38 +++--- 2 files changed, 28 insertions(+), 12 deletions(-) diff --git a/configure b/configure i

[Qemu-devel] [PATCHv2 3/4] Support for "double whitelist" filters

2012-10-22 Thread Eduardo Otubo
This patch includes a second whitelist right before the main loop. It's a smaller and more restricted whitelist, excluding execve() among many others. v2: * ctx changed to main_loop_ctx * seccomp_on now inside ifdef * open syscall added to the main_loop whitelist Signed-off-by: Eduardo Ot

[Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-10-22 Thread Eduardo Otubo
According to the bug 855162[0] - there's the need of adding new syscalls to the whitelist whenn using Qemu with Libvirt. [0] - https://bugzilla.redhat.com/show_bug.cgi?id=855162 v2: Adding new syscalls to the list: readlink, rt_sigpending, and rt_sigtimedwait Reported-by: Paul Moore Signed

Re: [Qemu-devel] [patch v4 10/16] memory: introduce lock ops for MemoryRegionOps

2012-10-22 Thread liu ping fan
On Mon, Oct 22, 2012 at 6:30 PM, Avi Kivity wrote: > On 10/22/2012 11:23 AM, Liu Ping Fan wrote: >> This can help memory core to use mr's fine lock to mmio dispatch. >> >> diff --git a/memory.c b/memory.c >> index d528d1f..86d5623 100644 >> --- a/memory.c >> +++ b/memory.c >> @@ -1505,13 +1505,27

Re: [Qemu-devel] [patch v4 13/16] e1000: add busy flag to anti broken device state

2012-10-22 Thread liu ping fan
On Mon, Oct 22, 2012 at 6:40 PM, Avi Kivity wrote: > On 10/22/2012 11:23 AM, Liu Ping Fan wrote: >> The broken device state is caused by releasing local lock before acquiring >> big lock. To fix this issue, we have two choice: >> 1.use busy flag to protect the state >> The drawback is that w

Re: [Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver

2012-10-22 Thread Lei Li
On 10/22/2012 10:08 PM, Eric Blake wrote: On 10/21/2012 10:47 AM, Lei Li wrote: Signed-off-by: Lei Li --- qemu-char.c | 72 +++ 1 files changed, 72 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b082bae..b

Re: [Qemu-devel] [PATCH v3 13/26] ich9: Add the lpc chip

2012-10-22 Thread Isaku Yamahata
On Mon, Oct 22, 2012 at 01:27:43PM +0200, Michael S. Tsirkin wrote: > > diff --git a/hw/lpc_ich9.c b/hw/lpc_ich9.c > > new file mode 100644 > > index 000..d9fd9de > > --- /dev/null > > +++ b/hw/lpc_ich9.c > > @@ -0,0 +1,523 @@ > > +/* > > + * Copyright (c) 2006 Fabrice Bellard > > + * > > + * P

Re: [Qemu-devel] [PATCH] cadence_uart: enable tx/rx on reset

2012-10-22 Thread Peter Crosthwaite
On Tue, Oct 23, 2012 at 12:20 AM, Josh Cartwright wrote: > Change the cadence_uart such that tx/rx is enabled on reset. Assuming > both are enabled makes debugging early Linux kernel bootup a little bit > easier. > > Signed-off-by: Josh Cartwright > --- > > I've used this patch mostly for my own

Re: [Qemu-devel] [PATCH 1/6] qdev: rework device properties.

2012-10-22 Thread Isaku Yamahata
On Wed, Oct 17, 2012 at 05:14:14PM -0300, Eduardo Habkost wrote: > On Wed, Jul 15, 2009 at 01:43:31PM +0200, Gerd Hoffmann wrote: > [...] > > diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c > > new file mode 100644 > > index 000..8b0d0ff > > --- /dev/null > > +++ b/hw/qdev-properties.c

[Qemu-devel] FW: 'qemu-nbd' explicite flush to disk

2012-10-22 Thread Mark Trumpold
Hello Paolo, Before anyone expends any cycles on my last message, I have new information. Today I was able to eliminate the file corruption issue by doing a 'blockdev --flushbufs' prior to taking a snapshot. I haven't done extensive testing yet, but it seems the issue if gone at this point. So

Re: [Qemu-devel] [PATCH 16/37] target-i386: set kvm CPUID default feature values using static properties

2012-10-22 Thread Don Slutz
On 10/22/12 11:03, Igor Mammedov wrote: Replace setting default supported kvm features in cpu_x86_find_by_name() by default values in corresponding static properties. - Compile in kvm CPUID features only if CONFIG_KVM is defined. - Make "f-kvm_steal_tm" and "f-kvmclock_stable" CPUID features vis

Re: [Qemu-devel] [PATCH 08/37] target-i386: define static properties for cpuid features

2012-10-22 Thread Don Slutz
On 10/22/12 11:02, Igor Mammedov wrote: - static properties names of CPUID features are changed to have "f-" prefix, so that it would be easy to distinguish them from other properties. - use X86CPU as a type to count of offset correctly, because env field isn't starting at CPUstate b

[Qemu-devel] [PATCH] tests/tcg: fix a few warnings

2012-10-22 Thread Catalin Patulea
Signed-off-by: Catalin Patulea --- This leaves a few of these: warning: ignoring return value of 'write', declared with attribute warn_unused_result How interesting is it to fix these? (Perhaps by asserting that the full write completed?) tests/tcg/hello-i386.c |3 ++- tests/tcg/test-i38

Re: [Qemu-devel] [PATCH 3/3] tcg-alpha: New TCG target.

2012-10-22 Thread Richard Henderson
On 2012-10-23 07:39, Aurelien Jarno wrote: >> +alpha) >> + QEMU_CFLAGS="-msmall-data $QEMU_CFLAGS" >> + LDFLAGS="-Wl,--warn-multiple-gp $LDFLAGS" >> + host_guest_base="yes" >> + ;; > > The host_guest_base part should now be removed, but it's due to me >

Re: [Qemu-devel] [PATCH] Revert "target-sparc: Make cpu_dst local to OP=2 insns"

2012-10-22 Thread Aurelien Jarno
On Mon, Oct 22, 2012 at 12:25:23AM +0200, Aurelien Jarno wrote: > On Mon, Oct 22, 2012 at 07:29:19AM +1000, Richard Henderson wrote: > > Given my experience above, I wonder what you're testing differently? I'm > > trying the > > stock standard debian 6.0.6 (current?) distribution media images. T

[Qemu-devel] [PULL] virtio,pci infrastructure

2012-10-22 Thread Michael S. Tsirkin
The following changes since commit f354b1a1ee7a1c72d51b42808724a2b10eec315f: fix CONFIG_QEMU_HELPERDIR generation again (2012-10-22 00:33:56 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony for you to fetch changes up to ddd0

Re: [Qemu-devel] [PATCH 2/3] tcg-alpha: Don't use a custom linker script.

2012-10-22 Thread Aurelien Jarno
On Sat, Sep 29, 2012 at 11:10:38AM -0700, Richard Henderson wrote: > The default placement of the binary at 6G is fine. > > Signed-off-by: Richard Henderson > --- > alpha.ld | 127 > --- > 1 file changed, 127 deletions(-) > delete mod

Re: [Qemu-devel] [PATCH 1/3] tcg-alpha: Fix type mismatch errors in cpu_signal_handler.

2012-10-22 Thread Aurelien Jarno
On Sat, Sep 29, 2012 at 11:10:37AM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > user-exec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/user-exec.c b/user-exec.c > index ef9b172..1635e4a 100644 > --- a/user-exec.c > +++ b/user-exec.c

[Qemu-devel] [PATCH v2] qemu-timer: Check for usable fields for SIGEV_THREAD_ID

2012-10-22 Thread Richard Henderson
Older glibc (RHEL 5.x, Debian 5.x) does not have the _sigev_un._tid member in its structure definition, while the accompanying kernel headers do define SIGEV_THREAD_ID. We need configure to check for both before using it. Signed-off-by: Richard Henderson --- configure| 22 ++

Re: [Qemu-devel] [PATCH v2] tcg-i386: Use %gs prefixes for x86_64 GUEST_BASE

2012-10-22 Thread Richard Henderson
On 2012-10-22 15:59, Aurelien Jarno wrote: > Yes, this is a know fact that this libc function doesn't have a > prototype (for instance in the manpage), that said it exists and at > least on x32 it's actually a wrapper doing things. > > That's why I think it's better to use it than doing the syscal

Re: [Qemu-devel] [PATCH] hw/arm_boot.c: bump initrd address (again) to accommodate large kernels

2012-10-22 Thread Cole Robinson
On 10/07/2012 06:36 PM, Peter Maydell wrote: > On 7 October 2012 23:27, Cole Robinson wrote: >> From: Paul Whalen >> >> Fedora ARM is generating kernels that exceed the hardcoded size limits: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=862766 >> >> Bump the load address, as was previously d

Re: [Qemu-devel] [PATCH v3 17/26] Add i21154 bridge chip.

2012-10-22 Thread Jason Baron
On Mon, Oct 22, 2012 at 04:03:05PM +0200, Michael S. Tsirkin wrote: > On Fri, Oct 19, 2012 at 04:43:37PM -0400, Jason Baron wrote: > > From: Jason Baron > > > > This adds support for the DECchip 21154 PCI bridge. > > > > Signed-off-by: Isaku Yamahata > > Signed-off-by: Jason Baron > > --- > >

[Qemu-devel] [PATCHv4] qemu: enable PV EOI for qemu 1.3

2012-10-22 Thread Michael S. Tsirkin
Enable KVM PV EOI by default. You can still disable it with -kvm_pv_eoi cpu flag. To avoid breaking cross-version migration, enable only for qemu 1.3 (or in the future, newer) machine type. Note: There don't seem to be any security-related downsides to this patch because all this does is tell gues

Re: [Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD server

2012-10-22 Thread Anthony Liguori
Paolo Bonzini writes: > Anthony, > > The following changes since commit b6348f29d033d5a8a26f633d2ee94362595f32a4: > > target-arm/translate: Fix RRX operands (2012-10-17 19:56:46 +0200) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git nbd-next > > for you to fe

Re: [Qemu-devel] [PULL v4 0/7] serial device hotplug patch series.

2012-10-22 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > > Next round of the serial device hotplug series. Left out chardev > patches due to confligting in-flight patches and ongoing discussions, > carrying only pci-serial and usb-serial bits. > > Adressed Anthonys comments: Added license to serial.h and moved > docume

Re: [Qemu-devel] [PULL v4 00/41] Migration cleanups, refactorings, stats, and more

2012-10-22 Thread Anthony Liguori
Juan Quintela writes: > Hi > > v4: 20121017: > - fix linux-user compilation (Anthony found it) > > Anthony, please pull. > Pulled. Thanks. Regards, Anthony Liguori > Thanks, Juan. > > The following changes since commit 6f4d6b09088ee161ff4be0e4db4e4c0962c79070: > > target-mips: Pass MIPSCPU

Re: [Qemu-devel] [PULL v3 00/23] Integrate DMA into the memory API

2012-10-22 Thread Anthony Liguori
Peter Maydell writes: > On 22 October 2012 10:35, Avi Kivity wrote: >> On 10/15/2012 03:16 PM, Avi Kivity wrote: >>> Rebased tree in the same place: >>> >>> git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/dma >>> >> >> Anthony, or Blue, can you pull please? The neighbours are starti

[Qemu-devel] Resource reporting for VGA cards

2012-10-22 Thread Hervé Poussineau
Hello, I'm trying to add support for a S3 PCI VGA card to QEMU. It currently works on some non-x86 systems. However, on x86, it seems that the card is correctly detected, but there is no display at all; I think it is due to bad framebuffer address detection. There is some resource differences

Re: [Qemu-devel] [PATCH v2 5/6] xilinx_zynq: add pl353

2012-10-22 Thread Peter Maydell
On 22 October 2012 08:19, Peter Crosthwaite wrote: > +/* pl353 */ > +dev = qdev_create(NULL, "arm.pl35x"); > +/* FIXME: handle this somewhere central */ > +object_property_add_child(container_get(qdev_get_machine(), > "/unattached"), > + "pl353", OBJEC

Re: [Qemu-devel] [PATCH 5/5] HMP: Introduce console command

2012-10-22 Thread Luiz Capitulino
On Mon, 22 Oct 2012 00:48:01 +0800 Lei Li wrote: > Signed-off-by: Lei Li > --- > hmp-commands.hx | 23 +++ > hmp.c | 53 + > hmp.h |1 + > monitor.c | 15 +++ > monitor.h

Re: [Qemu-devel] [PATCH v3 17/26] Add i21154 bridge chip.

2012-10-22 Thread Andreas Färber
Am 22.10.2012 18:17, schrieb Michael S. Tsirkin: > On Mon, Oct 22, 2012 at 03:26:24PM +0200, Andreas Färber wrote: >> Am 19.10.2012 22:43, schrieb Jason Baron: >>> create mode 100644 hw/i21154.c >>> create mode 100644 hw/i21154.h >> >> Why is this creating a new file and not reusing dec_pci.c? We

Re: [Qemu-devel] [PATCH v2 4/6] hw: Model of Primecell pl35x mem controller

2012-10-22 Thread Peter Crosthwaite
On Tue, Oct 23, 2012 at 2:12 AM, Peter Maydell wrote: > On 22 October 2012 08:19, Peter Crosthwaite > wrote: >> Initial device model for the pl35x series of memory controllers. The SRAM >> interface is just implemented as a passthrough using memory regions. NAND >> interfaces are modelled. >> >>

Re: [Qemu-devel] [PATCH 4/5] QAPI: Introduce memchar-read QMP command

2012-10-22 Thread Luiz Capitulino
On Mon, 22 Oct 2012 00:48:00 +0800 Lei Li wrote: > Signed-off-by: Lei Li > --- > hmp-commands.hx | 25 + > hmp.c| 17 + > hmp.h|1 + > qapi-schema.json | 27 +++ > qemu-char.c | 52

Re: [Qemu-devel] [PATCH 3/5] QAPI: Introduce memchar-write QMP command

2012-10-22 Thread Luiz Capitulino
On Mon, 22 Oct 2012 00:47:59 +0800 Lei Li wrote: > Signed-off-by: Lei Li > --- > hmp-commands.hx | 22 + > hmp.c| 19 +++ > hmp.h|1 + > qapi-schema.json | 69 > ++ > qemu-char.c

Re: [Qemu-devel] [PATCH 2/5] Expose CirMemCharDriver via command line

2012-10-22 Thread Luiz Capitulino
On Mon, 22 Oct 2012 00:47:58 +0800 Lei Li wrote: > Signed-off-by: Lei Li > --- > qemu-char.c | 36 > qemu-config.c |3 +++ > qemu-options.hx | 10 ++ > 3 files changed, 49 insertions(+), 0 deletions(-) > > diff --git a/qemu-char.c b/qe

Re: [Qemu-devel] [PATCH v3 17/26] Add i21154 bridge chip.

2012-10-22 Thread Jason Baron
On Mon, Oct 22, 2012 at 06:17:30PM +0200, Michael S. Tsirkin wrote: > On Mon, Oct 22, 2012 at 03:26:24PM +0200, Andreas Färber wrote: > > Am 19.10.2012 22:43, schrieb Jason Baron: > > > From: Jason Baron > > > > > > This adds support for the DECchip 21154 PCI bridge. > > > > > > Signed-off-by: I

Re: [Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver

2012-10-22 Thread Luiz Capitulino
On Mon, 22 Oct 2012 00:47:57 +0800 Lei Li wrote: > Signed-off-by: Lei Li This patch should be squashed in the next one. More comments below. > --- > qemu-char.c | 72 > +++ > 1 files changed, 72 insertions(+), 0 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v3 02/26] blockdev: Introduce IF_AHCI

2012-10-22 Thread Jason Baron
On Mon, Oct 22, 2012 at 01:40:21PM +0200, Kevin Wolf wrote: > >> From: Jason Baron > >> > >> Introduce IF_AHCI so that q35 can differentiate between ide and ahci disks. > >> This allows q35 to specify its default disk type. It also allows q35 to > >> differentiate between ahci and ide disks, such

Re: [Qemu-devel] [PATCH v3 01/26] blockdev: Introduce a default machine blockdev interface field, QEMUMachine->mach_if

2012-10-22 Thread Jason Baron
On Mon, Oct 22, 2012 at 01:26:29PM +0200, Kevin Wolf wrote: > Am 22.10.2012 12:47, schrieb Michael S. Tsirkin: > > On Fri, Oct 19, 2012 at 04:43:26PM -0400, Jason Baron wrote: > >> From: Jason Baron > >> > >> The current QEMUMachine definition has a 'use_scsi' field to indicate if a > >> machine t

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2012-10-22 Thread Justin Shafer
The app I am testing does run on qemu-i386 compiled for x86.. and the host is x86. The screen shot I posted in the last post is what happens when you run qemu and wine on arm instead of qemu and wine on x86. -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode on ARMv5 host fails (bash: fork: Invalid argument)

2012-10-22 Thread Justin Shafer
Does this have anything to do with Memory Mapping? I have a feeling it does I notice the mmap_min_addr setting for arm is 4096 For x86 its 65536 http://www.onsitedentalsystems.com/error.jpg -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

Re: [Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for _WIN32

2012-10-22 Thread Corey Bryant
On 10/22/2012 12:16 PM, Luiz Capitulino wrote: On Mon, 22 Oct 2012 09:53:44 -0400 Corey Bryant wrote: Signed-off-by: Corey Bryant --- vl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vl.c b/vl.c index 200d849..94c667d 100644 --- a/vl.c +++ b/vl.c @@ -812,11 +812,13 @@ static i

Re: [Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for _WIN32

2012-10-22 Thread Corey Bryant
On 10/22/2012 12:28 PM, Stefan Weil wrote: Am 22.10.2012 15:53, schrieb Corey Bryant: Signed-off-by: Corey Bryant --- vl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vl.c b/vl.c index 200d849..94c667d 100644 --- a/vl.c +++ b/vl.c @@ -812,11 +812,13 @@ static int parse_add_fd(Qemu

Re: [Qemu-devel] [patch v4 08/16] QemuThread: make QemuThread as tls to store extra info

2012-10-22 Thread Peter Maydell
On 22 October 2012 10:30, Jan Kiszka wrote: > Can't we enhance qemu-tls.h to work via pthread_setspecific in case > __thread is not working and use that abstraction (DECLARE/DEFINE_TLS) > directly? Agreed. (There were prototype patches floating around for Win32 at least). The only reason qemu-tls

[Qemu-devel] [PATCH 2/3] nbd: Explicitly disconnect and fail inflight I/O requests on error, then reconnect next I/O request.

2012-10-22 Thread nick
The previous behaviour when an NBD connection broke was to fail just the broken I/O request and (sometimes) never unlock send_mutex. Now we explicitly call nbd_teardown_connection and fail all NBD requests in the "inflight" state - this allows werror/rerror settings to be applied to those reque

[Qemu-devel] [PATCH 30/37] target-i386: convert "model" to static property

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- - in addition use error_setg() instead of error_set() --- target-i386/cpu.c | 83 ++- 1 file changed, 45 insertions(+), 38 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 69c179a..308dc4c

[Qemu-devel] [patch v4 13/16] e1000: add busy flag to anti broken device state

2012-10-22 Thread Liu Ping Fan
The broken device state is caused by releasing local lock before acquiring big lock. To fix this issue, we have two choice: 1.use busy flag to protect the state The drawback is that we will introduce independent busy flag for each independent device's logic unit. 2.reload the device's s

[Qemu-devel] [PATCH 16/37] target-i386: set kvm CPUID default feature values using static properties

2012-10-22 Thread Igor Mammedov
Replace setting default supported kvm features in cpu_x86_find_by_name() by default values in corresponding static properties. - Compile in kvm CPUID features only if CONFIG_KVM is defined. - Make "f-kvm_steal_tm" and "f-kvmclock_stable" CPUID features visible as properties. Signed-off-by: Igor

[Qemu-devel] [PATCH 02/37] target-i386: cpu_x86_register(): report error from property setter

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- v2: - replace "if (error_is_set(&error))" with "if (error)" --- target-i386/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index ab2d462..2d01705 100644 --- a/targ

[Qemu-devel] [PATCH 1/3] nbd: Only try to send flush/discard commands if connected to the NBD server

2012-10-22 Thread nick
This is unlikely to come up now, but is a necessary prerequisite for reconnection behaviour. Signed-off-by: Nick Thomas --- block/nbd.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 2bce47b..9536408 100644 --- a/block/nbd.

[Qemu-devel] [PATCH 33/37] qdev: QDEV_PROP_FOREACH and QDEV_CLASS_FOREACH

2012-10-22 Thread Igor Mammedov
helpers to iterate over device static properties to allow to simplify code a little. Signed-off-by: Igor Mammedov --- hw/qdev-properties.h | 9 + qom/qdev-core.c | 10 -- qom/qdev-properties.c | 29 +++-- 3 files changed, 20 insertions(+), 28 delet

[Qemu-devel] [PATCH 35/37] target-i386: use static properties in check_features_against_host() to print CPUID feature names

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: * use separate for() for every feature word --- target-i386/cpu.c | 72 +-- 1 file changed, 43 insertions(+), 29 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 59809f8..89ef2a7 10064

[Qemu-devel] [PATCH 11/37] target-i386: introduce vendor-override static property

2012-10-22 Thread Igor Mammedov
currently 'cpuid_vendor_override' can be set only via cmd line cpu_model string. But setting it in 'vendor' property prevents using 'vendor' property on its own without setting cpuid_vendor_override. So fix/remove enabling cpuid_vendor_override from "vendor" property setter. It's up-to cpu_model s

[Qemu-devel] [PATCH 18/37] target-i386: add stubs for hyperv_(vapic_recommended|relaxed_timing_enabled|get_spinlock_retries)()

2012-10-22 Thread Igor Mammedov
It's needed for converting hv_* features into properties and to avoid build breakage when qemu is built with --disable-kvm option. Signed-off-by: Igor Mammedov Reported-by: Eduardo Habkost --- target-i386/hyperv.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/targ

[Qemu-devel] [patch v4 06/16] memory: document ref, unref interface

2012-10-22 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan --- docs/memory.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/docs/memory.txt b/docs/memory.txt index 5bbee8e..3f88812 100644 --- a/docs/memory.txt +++ b/docs/memory.txt @@ -170,3 +170,8 @@ various constraints can be supplied to contr

[Qemu-devel] [PATCH 28/37] target-i386: convert "model-id" to static property

2012-10-22 Thread Igor Mammedov
check "if (model_id == NULL)" looks to unnecessary now, since all builtin model-ids are not NULL and user shouldn't be able to set it NULL (cpumodel string parsing code takes care of it, if feature is specified as "model-id=" on command line, its parsing will result in an empty string as value).

[Qemu-devel] [patch v4 12/16] e1000: apply fine lock on e1000

2012-10-22 Thread Liu Ping Fan
Use local lock to protect e1000. When calling the system function, dropping the fine lock before acquiring the big lock. This will introduce broken device state, which need extra effort to fix. Signed-off-by: Liu Ping Fan --- hw/e1000.c | 24 +++- 1 files changed, 23 insert

[Qemu-devel] [patch v4 11/16] vcpu: push mmio dispatcher out of big lock

2012-10-22 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan --- kvm-all.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index b3fa597..3d7ae18 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1562,12 +1562,15 @@ int kvm_cpu_exec(CPUArchState *env) break; case KV

Re: [Qemu-devel] [PATCH 0/2] qom: detect attempts to add a property that already exists

2012-10-22 Thread Luiz Capitulino
On Mon, 22 Oct 2012 17:26:10 +0100 Peter Maydell wrote: > On 22 October 2012 16:35, Luiz Capitulino wrote: > > Peter Maydell wrote: > > > >> The aim of this patch series is to make QEMU exit with a helpful > >> error message for bugs where multiple properties of the same name > >> are accidenta

[Qemu-devel] [PATCH 26/37] target-i386: convert "vendor" property to static property

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- * use error_setg() instead of error_set() * checkpatch doesn't like 'foo[i ]' used in original setter/getter, make it happy. --- target-i386/cpu.c | 102 +++--- 1 file changed, 59 insertions(+), 43 deletions(-

[Qemu-devel] [patch v4 14/16] qdev: introduce stopping state

2012-10-22 Thread Liu Ping Fan
Add this state to tell the device is disappearing, and not to append new requirement to it any longer. Signed-off-by: Liu Ping Fan --- hw/qdev.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index aeae29e..32f08bc 100644 --- a/hw/qdev.h +++ b/hw/q

[Qemu-devel] [PATCH 07/37] target-i386: use visit_type_hz to parse tsc_freq property value

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Andreas Färber --- v2: * use visit_type_freq() which replaced visit_type_hz() --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 227e51c..63ea74b 100644 --- a/target-i38

[Qemu-devel] [patch v4 04/16] pci: remove pci device from mem view when unplug

2012-10-22 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan --- hw/acpi_piix4.c |2 +- hw/pci.c| 13 - hw/pci.h|1 + 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index c56220b..a78b0e3 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@

[Qemu-devel] [PATCH 31/37] target-i386: convert "family" to static property

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- - in addition use error_setg() instead of error_set() --- target-i386/cpu.c | 96 +-- 1 file changed, 51 insertions(+), 45 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 308dc4c..c804965

[Qemu-devel] [patch v4 07/16] memory: make mmio dispatch able to be out of biglock

2012-10-22 Thread Liu Ping Fan
Without biglock, we try to protect the mr by increase refcnt. If we can inc refcnt, go backward and resort to biglock. Another point is memory radix-tree can be flushed by another thread, so we should get the copy of terminal mr to survive from such issue. Signed-off-by: Liu Ping Fan --- exec.c

[Qemu-devel] [PATCH 03/37] target-i386: if x86_cpu_realize() failed report error and do cleanup

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Acked-by: Andreas Färber --- v2: - replaced "if (error_is_set(&error))" with "if (error)" --- target-i386/helper.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 2ee7c6d..81e0f31 1006

[Qemu-devel] [PATCH 17/37] target-i386: make 'f-kvmclock' compatible with legacy behaviour

2012-10-22 Thread Igor Mammedov
It'll keep legacy behavior of kvmclock CPUID feature, which is toggles on KVM_FEATURE_CLOCKSOURCE and KVM_FEATURE_CLOCKSOURCE2 CPUID feature bits. Rename feature corresponding to KVM_FEATURE_CLOCKSOURCE to f-kvmclock1 to free f-kvmclock for use of legacy feature. Signed-off-by: Igor Mammedov ---

[Qemu-devel] [PATCH 12/37] target-i386: convert "xlevel" to static property

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- - convert to static property --- target-i386/cpu.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index fa974e7..c9d8dbc 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -21

Re: [Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for _WIN32

2012-10-22 Thread Stefan Weil
Am 22.10.2012 15:53, schrieb Corey Bryant: Signed-off-by: Corey Bryant --- vl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vl.c b/vl.c index 200d849..94c667d 100644 --- a/vl.c +++ b/vl.c @@ -812,11 +812,13 @@ static int parse_add_fd(QemuOpts *opts, void *opaque) return -1;

[Qemu-devel] [PATCH 29/37] target-i386: convert "stepping" to static property

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- - in addition use error_setg() instead of error_set() --- target-i386/cpu.c | 85 ++- 1 file changed, 46 insertions(+), 39 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 6cbdde1..69c179a

Re: [Qemu-devel] [PATCH 0/2] qom: detect attempts to add a property that already exists

2012-10-22 Thread Peter Maydell
On 22 October 2012 16:35, Luiz Capitulino wrote: > Peter Maydell wrote: > >> The aim of this patch series is to make QEMU exit with a helpful >> error message for bugs where multiple properties of the same name >> are accidentally added to a QOM object. > > Does this happen only at build-time or

[Qemu-devel] [PATCH 36/37] target-i386: use static properties to list CPUID features

2012-10-22 Thread Igor Mammedov
convert x86_cpu_list() to use QDEV_FIND_PROP_FROM_BIT() for getting CPUID feature name. In addition since x86_cpu_list() was the last user of *feature_name arrays, clean them up. Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 106 +++--- 1 fi

[Qemu-devel] [PATCH 32/37] target-i386: use static properties for setting cpuid features

2012-10-22 Thread Igor Mammedov
- def->kvm_features was used only for setting hadcoded defaults, with defaults set by static props, we do not need it anymore, ignore it in cpudef_2_x86_cpu(). - take in account CPUID_EXT_HYPERVISOR feature set by static property default value; Signed-off-by: Igor Mammedov --- * fix

[Qemu-devel] [patch v4 15/16] e1000: introduce unmap() to fix unplug issue

2012-10-22 Thread Liu Ping Fan
When device uninit(), we should ensure that it is not used by any subsystem. We can acheive this by two solution: 1.sync on big lock in uninit() function This is more easy, but it require that big lock can be recusive, because uninit() can be called by iothread or mmio-dispatch. 2.intro

[Qemu-devel] [patch v4 05/16] memory: introduce ref, unref interface for MemoryRegionOps

2012-10-22 Thread Liu Ping Fan
This pair of interface help to decide when dispatching, whether we can pin mr without big lock or not. Signed-off-by: Liu Ping Fan --- memory.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/memory.h b/memory.h index bd1bbae..9039411 100644 --- a/memory.h +++ b/memory

[Qemu-devel] [PATCH 10/37] target-i386: parse cpu_model string into set of stringified properties

2012-10-22 Thread Igor Mammedov
cpu_model string does represent features in following format: ([+-]feat)|(feat=foo)|(feat) which makes it impossible directly use property infrastructure to set features on CPU. This patch introduces parser that splits CPU name from cpu_model and converts legacy features string into canonized set

[Qemu-devel] [PATCH 21/37] target-i386: convert 'hv_relaxed' to static property

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 29 + 1 file changed, 29 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 122e01a..029f28c 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -181,6 +181,34 @@ PropertyInfo qdev_prop_spi

[Qemu-devel] [PATCH 37/37] target-i386: cleanup cpu_x86_find_by_name(), only fill x86_def_t in it

2012-10-22 Thread Igor Mammedov
Do in cpu_x86_find_by_name() only what name implies. i.e. leave only cpudef search and copy/fill passed in x86_def_t structure. and move out of it cpu_model parsing and CPU initializing into cpu_x86_register(). Plus add hints to where blocks should go when cpu_x86_register() is disbanded. Signed-

Re: [Qemu-devel] [PATCH v2 6/6] pflash_cfi01: Fix debug mode printfery

2012-10-22 Thread Peter Maydell
On 22 October 2012 08:19, Peter Crosthwaite wrote: > This DPRINTF was throwing a warning due to a missing cast. > > Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell If you stick this earlier in the series with the other pflash patches they can easily be applied even if we're still a

[Qemu-devel] [PATCH 05/37] target-i386: move out CPU features initialization in separate func

2012-10-22 Thread Igor Mammedov
later it could be used in cpu_x86_find_by_name() to init CPU from found cpu_def Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- v2: - rebased on top of "i386: cpu: remove duplicate feature names" http://www.mail-archive.com/qemu-devel@nongnu.org/msg129458.html --- target-

Re: [Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for _WIN32

2012-10-22 Thread Luiz Capitulino
On Mon, 22 Oct 2012 09:53:44 -0400 Corey Bryant wrote: > > Signed-off-by: Corey Bryant > --- > vl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/vl.c b/vl.c > index 200d849..94c667d 100644 > --- a/vl.c > +++ b/vl.c > @@ -812,11 +812,13 @@ static int parse_add_fd(QemuOpts *opts,

Re: [Qemu-devel] [PATCH v3 17/26] Add i21154 bridge chip.

2012-10-22 Thread Michael S. Tsirkin
On Mon, Oct 22, 2012 at 03:26:24PM +0200, Andreas Färber wrote: > Am 19.10.2012 22:43, schrieb Jason Baron: > > From: Jason Baron > > > > This adds support for the DECchip 21154 PCI bridge. > > > > Signed-off-by: Isaku Yamahata > > Signed-off-by: Jason Baron > > --- > > hw/Makefile.objs |

[Qemu-devel] [PATCH 0/3] NBD reconnection behaviour

2012-10-22 Thread nick
Hi all, This patchset is about making the NBD backend more useful. Currently, when the NBD server disconnects, the block device in the guest becomes unusable with no option to recover except to restart the QEMU process. These patches introduce a reconnect timer that fires every five seconds until

Re: [Qemu-devel] [PATCH v2 4/6] hw: Model of Primecell pl35x mem controller

2012-10-22 Thread Peter Maydell
On 22 October 2012 08:19, Peter Crosthwaite wrote: > Initial device model for the pl35x series of memory controllers. The SRAM > interface is just implemented as a passthrough using memory regions. NAND > interfaces are modelled. > > Signed-off-by: Peter Crosthwaite > --- > changed since v1: > us

[Qemu-devel] [PATCH 19/37] qdev: add DEFINE_ABSTRACT_PROP() helper

2012-10-22 Thread Igor Mammedov
It will be used for declaring a static property with a custom setter/getter. Signed-off-by: Igor Mammedov --- hw/qdev-properties.h | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/qdev-properties.h b/hw/qdev-properties.h index b2f7142..41358fa 100644 --- a/hw/qdev-properties.h +++ b/h

[Qemu-devel] [PATCH 22/37] target-i386: convert 'hv_vapic' to static property

2012-10-22 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 29 + 1 file changed, 29 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 029f28c..44cbf9c 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -209,6 +209,34 @@ PropertyInfo qdev_prop_hv_

[Qemu-devel] [PATCH 01/37] target-i386: return Error from cpu_x86_find_by_name()

2012-10-22 Thread Igor Mammedov
it will allow to use property setters there later. Signed-off-by: Igor Mammedov Reviewed-by: Don Slutz Reviewed-by: Eduardo Habkost -- v2: - style change, add braces (requested by Blue Swirl) - removed unused error_is_set(errp) in properties set loop v3: - removed unnecessary whites

Re: [Qemu-devel] [PATCH v2 1/2] qmp: handle stop/cont in INMIGRATE state

2012-10-22 Thread Luiz Capitulino
On Fri, 19 Oct 2012 16:45:23 +0200 Paolo Bonzini wrote: > Right now, stop followed by an incoming migration will let the > virtual machine start. cont before an incoming migration instead > will fail. > > This is bad because the actual behavior is not predictable; it is > racy with respect to t

Re: [Qemu-devel] [PULL 00/29] qemu-sockets error propagation + NBD server

2012-10-22 Thread Markus Armbruster
Paolo Bonzini writes: > Anthony, > > The following changes since commit b6348f29d033d5a8a26f633d2ee94362595f32a4: > > target-arm/translate: Fix RRX operands (2012-10-17 19:56:46 +0200) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git nbd-next > > for you to fe

[Qemu-devel] [PATCH 34/37] qdev: introduce QDEV_FIND_PROP_FROM_BIT and qdev_prop_find_bit()

2012-10-22 Thread Igor Mammedov
it allows to find bit static property corresponding to a specific bit in specified field. Signed-off-by: Igor Mammedov --- * it will be used by next commit to print cpuid feature names for unavailable feature bits. --- hw/qdev-properties.h | 8 qom/qdev-properties.c | 15 +++

  1   2   3   >