Re: [Qemu-devel] buildbot failure in qemu on default_mingw32

2012-11-02 Thread Stefan Hajnoczi
On Sat, Nov 3, 2012 at 2:11 AM, wrote: > The Buildbot has detected a new failure on builder default_mingw32 while > building qemu. > Full details are available at: > http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/424 Hi Daniel, The DNS for qemu.org is down. Anthony Liguori

[Qemu-devel] [PATCH] Add realtime option

2012-11-02 Thread Satoru Moriya
We have some plans to migrate old enterprise/control systems which require low latency (msec order) to kvm virtualized environment. In order to satisfy the requirements, this patch adds realtime option to qemu: -realtime maxprio=,policy= This option change the scheduling policy and priority to r

[Qemu-devel] buildbot failure in qemu on default_mingw32

2012-11-02 Thread qemu
The Buildbot has detected a new failure on builder default_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/424 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason:

Re: [Qemu-devel] [PATCHv2 3/4] Support for "double whitelist" filters

2012-11-02 Thread Paul Moore
On Friday, November 02, 2012 06:00:29 PM Corey Bryant wrote: > On 11/02/2012 05:29 PM, Paul Moore wrote: > > On Tuesday, October 23, 2012 03:55:31 AM Eduardo Otubo wrote: > >> This patch includes a second whitelist right before the main loop. It's > >> a smaller and more restricted whitelist, exclu

Re: [Qemu-devel] [PATCHv2 3/4] Support for "double whitelist" filters

2012-11-02 Thread Anthony Liguori
Paul Moore writes: > On Tuesday, October 23, 2012 03:55:31 AM Eduardo Otubo wrote: >> This patch includes a second whitelist right before the main loop. It's >> a smaller and more restricted whitelist, excluding execve() among many >> others. >> >> v2: * ctx changed to main_loop_ctx >> * sec

Re: [Qemu-devel] [PATCHv2 3/4] Support for "double whitelist" filters

2012-11-02 Thread Corey Bryant
On 11/02/2012 05:29 PM, Paul Moore wrote: On Tuesday, October 23, 2012 03:55:31 AM Eduardo Otubo wrote: This patch includes a second whitelist right before the main loop. It's a smaller and more restricted whitelist, excluding execve() among many others. v2: * ctx changed to main_loop_ctx

Re: [Qemu-devel] [PATCHv2 3/4] Support for "double whitelist" filters

2012-11-02 Thread Paul Moore
On Tuesday, October 23, 2012 03:55:31 AM Eduardo Otubo wrote: > This patch includes a second whitelist right before the main loop. It's > a smaller and more restricted whitelist, excluding execve() among many > others. > > v2: * ctx changed to main_loop_ctx > * seccomp_on now inside ifdef >

Re: [Qemu-devel] [PATCH v2] pc_sysfw: Always use alias for ISA BIOS region

2012-11-02 Thread Jordan Justen
I tested that flash device still works and the alias works with the flash device. I *did not* test vm state save/restore/migration. Reviewed-by: Jordan Justen On Fri, Nov 2, 2012 at 11:55 AM, Jan Kiszka wrote: > This is no technical reason (anymore) for copying the ISA BIOS from the > original

[Qemu-devel] [PATCH] build: pthread_atfork() needs include of pthread.h

2012-11-02 Thread Anthony Liguori
Cc: Paolo Bonzini Signed-off-by: Anthony Liguori --- qemu-timer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qemu-timer.c b/qemu-timer.c index 7b2217a..8d9cf38 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -30,6 +30,9 @@ #include "hw/hw.h" #include "qemu-timer.h" +#ifdef CONFIG

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-02 Thread Stefan Hajnoczi
On Fri, Nov 2, 2012 at 3:48 PM, Michael S. Tsirkin wrote: > On Fri, Nov 02, 2012 at 11:18:18AM +0100, Stefan Hajnoczi wrote: >> On Thu, Nov 1, 2012 at 5:07 PM, Michael S. Tsirkin wrote: >> > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced >> > a regression in virtio-net performance bec

Re: [Qemu-devel] [PATCH] raw-posix: inline paio_ioctl into hdev_aio_ioctl

2012-11-02 Thread Stefan Hajnoczi
On Fri, Nov 2, 2012 at 4:14 PM, Paolo Bonzini wrote: > clang now warns about an unused function: > CCblock/raw-posix.o > block/raw-posix.c:707:26: warning: unused function paio_ioctl > [-Wunused-function] > static BlockDriverAIOCB *paio_ioctl(BlockDriverState *bs, int fd, >

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Anthony Liguori
Peter Maydell writes: > Commit a93a4a2 changed the names of some fields in DisplayChangeListener > and broke compilation of the cocoa UI. Update to the new names. > > Signed-off-by: Peter Maydell Applied. Thanks. Regards, Anthony Liguori > --- > ui/cocoa.m | 4 ++-- > 1 file changed, 2 inse

Re: [Qemu-devel] [PULL buildfix] QOM CPUState patch queue 2012-11-02

2012-11-02 Thread Anthony Liguori
Andreas Färber writes: > Hello, > > Here's a build fix for {i386,x86_64}-linux-user. Please pull. Pulled. Thanks. Regards, Anthony Liguori > > Regards, > Andreas > > > The following changes since commit 4ba79505f43bd0ace35c3fe42197eb02e7e0478e: > > Merge remote-tracking branch 'kraxel/pixma

Re: [Qemu-devel] [PULL 00/12] Incoming migration coroutine

2012-11-02 Thread Anthony Liguori
Paolo Bonzini writes: > Anthony, > > The following changes since commit 4ba79505f43bd0ace35c3fe42197eb02e7e0478e: > > Merge remote-tracking branch 'kraxel/pixman.v3' into staging (2012-11-01 > 11:14:39 -0500) > > are available in the git repository at: Pulled. Thanks. Regards, Anthony Liguo

Re: [Qemu-devel] [PATCH] xenfb: fix build breakage caused by console cleanup series

2012-11-02 Thread Anthony Liguori
Gerd Hoffmann writes: > Console cleanup series renamed dpy_resize and dpy_update all over the > tree, but hw/xenfb.c was forgotten. Update it too so it builds again. > > Reported-by: Jan Kiszka > Signed-off-by: Gerd Hoffmann Applied. Thanks. Regards, Anthony Liguori > --- > hw/xenfb.c |

[Qemu-devel] qemu.org DNS status

2012-11-02 Thread anthony
Hi, I wanted to update everyone on the qemu.org DNS status. This morning it was reported that the two nameservers that qemu.org is configured to use are down. I do not have access to the DNS records for qemu.org as they are graciously donated by a third party. I've contacted the owner of the r

[Qemu-devel] [PATCH 05/12] migration: clean up server sockets and handlers before invoking process_incoming_migration

2012-11-02 Thread Paolo Bonzini
A first step towards making a common "suffix" for all migration protocols, and moving it to process_incoming_migration. Reviewed-by: Orit Wasserman Signed-off-by: Paolo Bonzini --- migration-exec.c | 2 +- migration-fd.c | 2 +- migration-tcp.c | 7 +++ migration-unix.c | 7 +++ 4 fi

[Qemu-devel] [PATCH 09/12] migration: close socket QEMUFile from socket_close

2012-11-02 Thread Paolo Bonzini
The common suffix now is process_incoming_migration+qemu_fclose. Reviewed-by: Orit Wasserman Signed-off-by: Paolo Bonzini --- migration-tcp.c | 2 ++ migration-unix.c | 2 ++ savevm.c | 1 + 3 file modificati, 5 inserzioni(+) diff --git a/migration-tcp.c b/migration-tcp.c index bb27ce

[Qemu-devel] [PATCH 10/12] migration: move qemu_fclose to process_incoming_migration

2012-11-02 Thread Paolo Bonzini
The common suffix is now just process_incoming_migration. Reviewed-by: Orit Wasserman Signed-off-by: Paolo Bonzini --- migration-exec.c | 1 - migration-fd.c | 1 - migration-tcp.c | 1 - migration-unix.c | 1 - migration.c | 6 +- 5 file modificati, 5 inserzioni(+), 5 rimozioni(-)

[Qemu-devel] [PATCH v2] pc_sysfw: Always use alias for ISA BIOS region

2012-11-02 Thread Jan Kiszka
This is no technical reason (anymore) for copying the ISA BIOS from the original region. Instead, refactor pc_isa_bios_init to serve both pflash and old-style BIOS setup. Unfortunately, the previous RAM-backed version created an additional vmstate section, content-wise redundant to the BIOS, but w

[Qemu-devel] [PATCH 12/12] migration: move process_incoming_migration to a coroutine

2012-11-02 Thread Paolo Bonzini
The final part of incoming migration, which now consists of process_incoming_migration for all protocols, is thus made non-blocking. Reviewed-by: Orit Wasserman Signed-off-by: Paolo Bonzini --- migration.c | 21 - 1 file modificato, 20 inserzioni(+). 1 rimozione(-) diff --g

[Qemu-devel] [PATCH 03/12] migration: add qemu_get_fd

2012-11-02 Thread Paolo Bonzini
Reviewed-by: Orit Wasserman Signed-off-by: Paolo Bonzini --- buffered_file.c | 8 qemu-file.h | 6 ++ savevm.c| 27 +++ 3 file modificati, 41 inserzioni(+) diff --git a/buffered_file.c b/buffered_file.c index a5c0b12..bd0f61d 100644 --- a/buffe

[Qemu-devel] [PATCH 11/12] migration: handle EAGAIN while reading QEMUFile

2012-11-02 Thread Paolo Bonzini
This will never happen right now (the assertion would fail). The next patch will set the socket or pipe in non-blocking mode, thus enabling this part of the code. Coroutines can just stop whenever they want with qemu_coroutine_yield. As soon as select tells the main loop that the migration stream

[Qemu-devel] [PATCH 01/12] migration: unify stdio-based QEMUFile operations

2012-11-02 Thread Paolo Bonzini
Now that qemu_fseek does not exist anymore, there is no reason to do an fseek before fread/fwrite when operating on an stdio file. Thus, unify the get/put_buffer callbacks used by qemu_fopen with those used for pipes. Reviewed-by: Orit Wasserman Signed-off-by: Paolo Bonzini --- savevm.c | 19 ++

[Qemu-devel] [PATCH 07/12] migration: use closesocket, not close

2012-11-02 Thread Paolo Bonzini
Windows requires this. Migration does not quite work under Windows but let's be uniform across QEMU. Reviewed-by: Orit Wasserman Signed-off-by: Paolo Bonzini --- migration-tcp.c | 6 +++--- 1 file modificato, 3 inserzioni(+), 3 rimozioni(-) diff --git a/migration-tcp.c b/migration-tcp.c index

[Qemu-devel] [PATCH 04/12] migration: replace qemu_stdio_fd with qemu_get_fd

2012-11-02 Thread Paolo Bonzini
Reviewed-by: Orit Wasserman Signed-off-by: Paolo Bonzini --- migration-exec.c | 4 ++-- migration-fd.c | 2 +- qemu-file.h | 1 - savevm.c | 11 --- 4 file modificati, 3 inserzioni(+), 15 rimozioni(-) diff --git a/migration-exec.c b/migration-exec.c index 519af57..452b

[Qemu-devel] [PATCH 2/2] x86/cpu: add new Opteron CPU model

2012-11-02 Thread Boris Ostrovsky
From: Andre Przywara Add a new base CPU model called Opteron_G5 to model the latest Opteron CPUs. This increases the model value and model numbers and adds TBM, F16C and FMA over the latest G4 model. Signed-off-by: Andre Przywara Signed-off-by: Boris Ostrovsky --- target-i386/cpu.c | 32 +++

[Qemu-devel] [PATCH 1/2] x86/cpu: name new CPUID bits

2012-11-02 Thread Boris Ostrovsky
From: Andre Przywara Update QEMU's knowledge of CPUID bit names. This allows to enable/disable those new features on QEMU's command line when using KVM and prepares future feature enablement in QEMU. This adds F16C, RDRAND, LWP, TBM, TopoExt, PerfCtr_Core, PerfCtr_NB, FSGSBASE, BMI1, AVX2, BMI2,

[Qemu-devel] [PATCH 0/2] Add support for new Opteron CPU model

2012-11-02 Thread Boris Ostrovsky
From: Andre Przywara Two patches to provide support for new Opteron processors. The first patch was submitted earlier (http://lists.nongnu.org/archive/html/qemu-devel/2012-10/msg03058.html) and may have already been applied. Andre Przywara (2): x86/cpu: name new CPUID bits x86/cpu: add new

[Qemu-devel] [PATCH 02/12] migration: consolidate QEMUFile methods in a single QEMUFileOps struct

2012-11-02 Thread Paolo Bonzini
Reviewed-by: Orit Wasserman Signed-off-by: Paolo Bonzini --- buffered_file.c | 13 --- qemu-file.h | 16 + savevm.c| 108 +++- 3 file modificati, 79 inserzioni(+), 58 rimozioni(-) diff --git a/buffered_file.c b/buffer

Re: [Qemu-devel] Fwd: buildbot failure in qemu on openbsd-default

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 17:22, Anthony Liguori ha scritto: > > I think this one is you Paolo... Yup, 5-patch series already on the list and smoke-tested by Peter on Mac OS X (which has the same problem). Paolo

[Qemu-devel] [PATCH 08/12] migration: xxx_close will only be called once

2012-11-02 Thread Paolo Bonzini
No need to test s->fd again, it is tested in the caller. Reviewed-by: Orit Wasserman Signed-off-by: Paolo Bonzini --- migration-exec.c | 14 ++ migration-fd.c | 33 +++-- migration-tcp.c | 7 ++- migration-unix.c | 7 ++- 4 file modificati, 2

[Qemu-devel] [PATCH 06/12] migration: use migrate_fd_close in migrate_fd_cleanup

2012-11-02 Thread Paolo Bonzini
migrate_fd_cleanup will usually close the file descriptor via buffered_file_close's call to migrate_fd_close. However, in the case of s->file == NULL it is "inlining" migrate_fd_close (almost: there is a direct close() instead of using s->close(s)). To fix the inconsistency and clean up the code,

[Qemu-devel] [PULL 00/12] Incoming migration coroutine

2012-11-02 Thread Paolo Bonzini
Anthony, The following changes since commit 4ba79505f43bd0ace35c3fe42197eb02e7e0478e: Merge remote-tracking branch 'kraxel/pixman.v3' into staging (2012-11-01 11:14:39 -0500) are available in the git repository at: git://github.com/bonzini/qemu.git migr-coroutine for you to fetch changes

[Qemu-devel] [PATCH] target-i386: cpu: fix --disable-kvm compilation

2012-11-02 Thread Andreas Färber
From: Eduardo Habkost This fixes the following: target-i386/cpu.o: In function `kvm_cpu_fill_host': target-i386/cpu.c:783: undefined reference to `kvm_state' I didn't notice the problem before because GCC was optimizing the entire kvm_cpu_fill_host() function out (because all calls are condi

[Qemu-devel] [PULL buildfix] QOM CPUState patch queue 2012-11-02

2012-11-02 Thread Andreas Färber
Hello, Here's a build fix for {i386,x86_64}-linux-user. Please pull. Regards, Andreas The following changes since commit 4ba79505f43bd0ace35c3fe42197eb02e7e0478e: Merge remote-tracking branch 'kraxel/pixman.v3' into staging (2012-11-01 11:14:39 -0500) are available in the git repository at

Re: [Qemu-devel] [PATCH] target-i386: cpu: fix --disable-kvm compilation

2012-11-02 Thread Andreas Färber
Am 02.11.2012 17:25, schrieb Eduardo Habkost: > This fixes the following: > target-i386/cpu.o: In function `kvm_cpu_fill_host': > target-i386/cpu.c:783: undefined reference to `kvm_state' > > I didn't notice the problem before because GCC was optimizing the entire > kvm_cpu_fill_host() functio

Re: [Qemu-devel] [PULL 00/22] console cleanups & pixman rendering

2012-11-02 Thread Andreas Färber
Am 02.11.2012 17:14, schrieb Andreas Färber: > Am 01.11.2012 20:33, schrieb Anthony Liguori: >> Gerd Hoffmann writes: >> >>> Hi, >>> >>> Sitting on these too long already. Series has been on the list a while >>> back, only splitted into two parts (separate "console cleanups" series >>> carrying

[Qemu-devel] [PATCH] target-i386: cpu: fix --disable-kvm compilation

2012-11-02 Thread Eduardo Habkost
This fixes the following: target-i386/cpu.o: In function `kvm_cpu_fill_host': target-i386/cpu.c:783: undefined reference to `kvm_state' I didn't notice the problem before because GCC was optimizing the entire kvm_cpu_fill_host() function out (because all calls are conditional on kvm_enabled())

Re: [Qemu-devel] Fwd: buildbot failure in qemu on openbsd-default

2012-11-02 Thread Anthony Liguori
I think this one is you Paolo... Regards, ANthony Liguori Gerd Hoffmann writes: > Original Message > Subject: buildbot failure in qemu on openbsd-default > Date: Thu, 01 Nov 2012 21:12:01 +0100 > From: build...@spunk.home.kraxel.org > To: kraxel...@gmail.com > > The Buildbot

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Anthony Liguori
Andreas Färber writes: > Hi, > > Am 02.11.2012 16:41, schrieb Gerd Hoffmann: >>> (I have a philosophical preference for compile fixes being applied >>> directly and quickly to master but my opinion on that matter is >>> not particularly significant :-)) >> >> /me too. Build fixes should go in o

Re: [Qemu-devel] [PULL 00/22] console cleanups & pixman rendering

2012-11-02 Thread Andreas Färber
Am 01.11.2012 20:33, schrieb Anthony Liguori: > Gerd Hoffmann writes: > >> Hi, >> >> Sitting on these too long already. Series has been on the list a while >> back, only splitted into two parts (separate "console cleanups" series >> carrying patches 1-8). Patch 11 was updated according to Pao

Re: [Qemu-devel] [PATCH 27/28] target-i386: kvm_cpu_fill_host: use GET_SUPPORTED_CPUID

2012-11-02 Thread Eduardo Habkost
On Fri, Nov 02, 2012 at 04:34:00PM +0100, Andreas Färber wrote: > Am 31.10.2012 10:40, schrieb Marcelo Tosatti: > > From: Eduardo Habkost > > > > Change the kvm_cpu_fill_host() function to use > > kvm_arch_get_supported_cpuid() instead of running the CPUID instruction > > directly, when checking

[Qemu-devel] [PATCH] block: vpc initialize the uuid footer field

2012-11-02 Thread Charles Arnold
block/vpc: Initialize the uuid field in the footer with a generated uuid. Signed-off-by: Charles Arnold diff --git a/block/vpc.c b/block/vpc.c index b6bf52f..f14c6ae 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -26,6 +26,9 @@ #include "block_int.h" #include "module.h" #include "migration.h"

Re: [Qemu-devel] [PATCH 27/28] target-i386: kvm_cpu_fill_host: use GET_SUPPORTED_CPUID

2012-11-02 Thread Andreas Färber
Am 02.11.2012 16:34, schrieb Andreas Färber: > Am 31.10.2012 10:40, schrieb Marcelo Tosatti: >> From: Eduardo Habkost >> >> Change the kvm_cpu_fill_host() function to use >> kvm_arch_get_supported_cpuid() instead of running the CPUID instruction >> directly, when checking for supported CPUID featu

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Andreas Färber
Hi, Am 02.11.2012 16:41, schrieb Gerd Hoffmann: >> (I have a philosophical preference for compile fixes being applied >> directly and quickly to master but my opinion on that matter is >> not particularly significant :-)) > > /me too. Build fixes should go in on the fast track. First because a

Re: [Qemu-devel] [PATCH] xenfb: fix build breakage caused by console cleanup series

2012-11-02 Thread Andreas Färber
Am 02.11.2012 08:44, schrieb Gerd Hoffmann: > Console cleanup series renamed dpy_resize and dpy_update all over the > tree, but hw/xenfb.c was forgotten. Update it too so it builds again. > > Reported-by: Jan Kiszka > Signed-off-by: Gerd Hoffmann Acked-by: Andreas Färber Andreas -- SUSE LI

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Gerd Hoffmann
Hi, > (I have a philosophical preference for compile fixes being applied > directly and quickly to master but my opinion on that matter is > not particularly significant :-)) /me too. Build fixes should go in on the fast track. First because a broken build is annonying. Second because buildb

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Eric Blake
On 11/02/2012 09:18 AM, Kuniyasu Suzaki wrote: >> 1. Make the original image read-only accessible over NFS. >> 2. Modify QEMU to create two external snapshot files when the VM is >> paused for migration (during your fork operation): >> >> /host-a/original.qcow2 >> /host-a/new.qcow2 (backing file: /

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Eric Blake
On 11/02/2012 09:00 AM, Kuniyasu Suzaki wrote: >> You are not the first to request this - libvirt would also like the >> ability to have read-only access into the contents of an internal >> snapshot while the rest of qemu continues to write into the image. > > Do you mean that libvirt can change t

Re: [Qemu-devel] [PATCH 27/28] target-i386: kvm_cpu_fill_host: use GET_SUPPORTED_CPUID

2012-11-02 Thread Andreas Färber
Am 31.10.2012 10:40, schrieb Marcelo Tosatti: > From: Eduardo Habkost > > Change the kvm_cpu_fill_host() function to use > kvm_arch_get_supported_cpuid() instead of running the CPUID instruction > directly, when checking for supported CPUID features. > > This should solve two problems at the sam

Re: [Qemu-devel] buildbot failure in qemu on xen41

2012-11-02 Thread Anthony PERARD
On Fri, Nov 2, 2012 at 7:08 AM, Stefan Hajnoczi wrote: > Anthony, your buildslave is missing a package: Thanks. > ERROR: pixman not present. Your options: > (1) Prefered: Install the pixman devel package (any recent > distro should have packages as Xorg needs pixman too). Done. > (2)

[Qemu-devel] Fwd: buildbot failure in qemu on openbsd-default

2012-11-02 Thread Gerd Hoffmann
Original Message Subject: buildbot failure in qemu on openbsd-default Date: Thu, 01 Nov 2012 21:12:01 +0100 From: build...@spunk.home.kraxel.org To: kraxel...@gmail.com The Buildbot has detected a failed build on builder openbsd-default while building qemu. Full details are ava

Re: [Qemu-devel] [PATCH v3 27/35] postcopy/outgoing: implement forward/backword prefault

2012-11-02 Thread Eric Blake
On 11/01/2012 11:24 PM, Isaku Yamahata wrote: >>> +++ b/qapi-schema.json >>> @@ -2095,7 +2095,8 @@ >>> ## >>> { 'command': 'migrate', >>>'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'bool' >>> , >>> - '*postcopy': 'bool', '*nobg': 'bool'} } >>> + '*po

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Paolo Bonzini
Il 02/11/2012 16:17, Gerd Hoffmann ha scritto: > On 11/02/12 16:13, Paolo Bonzini wrote: >>> >> Hi, >>> >> >>> I think deferring IRQ events to the point when the complete vmstate >>> is loaded is the cleaner and more robust approach. >>> >> >>> >> Agree. Just schedule a bh in post_load.

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Peter Maydell
On 2 November 2012 16:04, Andreas Färber wrote: > Am 02.11.2012 15:54, schrieb Peter Maydell: >> Commit a93a4a2 changed the names of some fields in DisplayChangeListener >> and broke compilation of the cocoa UI. Update to the new names. >> >> Signed-off-by: Peter Maydell > > Reviewed-by: Andreas

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Kuniyasu Suzaki
Hello Stefan, From: Stefan Hajnoczi Subject: Re: [Qemu-devel] live migration which includes previos snapshot Date: Fri, 2 Nov 2012 11:30:25 +0100 > If you are forking the VM so that there will be two VMs running > simultaneously, then a single qcow2 file cannot be used. > > Here are two approa

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Gerd Hoffmann
On 11/02/12 16:13, Paolo Bonzini wrote: >> Hi, >> >>> I think deferring IRQ events to the point when the complete vmstate >>> is >>> loaded is the cleaner and more robust approach. >> >> Agree. Just schedule a bh in post_load. >> See also a229c0535bd336efaec786dd6e352a54e0a8187d > > No, it cannot

[Qemu-devel] [PATCH] raw-posix: inline paio_ioctl into hdev_aio_ioctl

2012-11-02 Thread Paolo Bonzini
clang now warns about an unused function: CCblock/raw-posix.o block/raw-posix.c:707:26: warning: unused function paio_ioctl [-Wunused-function] static BlockDriverAIOCB *paio_ioctl(BlockDriverState *bs, int fd, ^ 1 warning generated. because the only use of paio_ioctl

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Paolo Bonzini
> Hi, > > > I think deferring IRQ events to the point when the complete vmstate > > is > > loaded is the cleaner and more robust approach. > > Agree. Just schedule a bh in post_load. > See also a229c0535bd336efaec786dd6e352a54e0a8187d No, it cannot a bh. Right now incoming migration is blockin

[Qemu-devel] [PATCH v2 4/5] vl: unify calls to init_timer_alarm

2012-11-02 Thread Paolo Bonzini
init_timer_alarm was being called twice. This is not needed. Signed-off-by: Paolo Bonzini --- main-loop.c | 5 - vl.c| 5 - 2 file modificati, 4 inserzioni(+), 6 rimozioni(-) diff --git a/main-loop.c b/main-loop.c index e43c7c8..234a313 100644 --- a/main-loop.c +++ b/main-loop.

Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

2012-11-02 Thread Peter Maydell
On 2 November 2012 15:43, Paolo Bonzini wrote: > Three fixes: 1) Darwin does not support weak aliases, use weak > references instead. 2) Darwin, NetBSD and OpenBSD do not have > sem_timedwait, implement counting semaphores with a mutex and > cv there. 3) Daemonize was broken, fixes are in patche

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Gerd Hoffmann
Hi, > I think deferring IRQ events to the point when the complete vmstate is > loaded is the cleaner and more robust approach. Agree. Just schedule a bh in post_load. See also a229c0535bd336efaec786dd6e352a54e0a8187d cheers, Gerd

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Andreas Färber
Am 02.11.2012 15:54, schrieb Peter Maydell: > Commit a93a4a2 changed the names of some fields in DisplayChangeListener > and broke compilation of the cocoa UI. Update to the new names. > > Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber Peter, you didn't cc me - through whose queue is

Re: [Qemu-devel] live migration which includes previos snapshot

2012-11-02 Thread Kuniyasu Suzaki
Hello Eric, From: Eric Blake Subject: Re: [Qemu-devel] live migration which includes previos snapshot Date: Fri, 02 Nov 2012 07:12:21 -0600 > On 11/02/2012 04:30 AM, Stefan Hajnoczi wrote: > > > II. If you want to use internal snapshots in a single qcow2 file, you > > will need to modify QEMU

Re: [Qemu-devel] [PATCH v2 35/39] raw: merge posix-aio-compat.c into block/raw-posix.c

2012-11-02 Thread Peter Maydell
On 31 October 2012 16:30, Paolo Bonzini wrote: > Making the qemu_paiocb specific to raw devices will let us access members > of the BDRVRawState arbitrarily. > > Signed-off-by: Paolo Bonzini clang now warns about an unused function: CCblock/raw-posix.o block/raw-posix.c:707:26: warning: un

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Corey Bryant
On 11/02/2012 10:38 AM, Paul Moore wrote: On Friday, November 02, 2012 10:10:02 AM Paul Moore wrote: On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: On 11/01/2012 05:43 PM, Paul Moore wrote: On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: According to the bug 8551

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Jan Kiszka
On 2012-11-02 15:53, Paolo Bonzini wrote: > Il 30/10/2012 19:21, Jan Kiszka ha scritto: Aren't we still dependent on the order of processing? If the APIC is restored after the device, won't we get the same problem? >>> >>> Strictly speaking yes, but CPUs and APICs are always the first de

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Gerd Hoffmann
On 11/02/12 15:54, Peter Maydell wrote: > Commit a93a4a2 changed the names of some fields in DisplayChangeListener > and broke compilation of the cocoa UI. Update to the new names. > > Signed-off-by: Peter Maydell Acked-by: Gerd Hoffmann cheers, Gerd

[Qemu-devel] [PATCH v2 5/5] vl: delay thread initialization after daemonization

2012-11-02 Thread Paolo Bonzini
Commit ac4119c (chardev: Use timer instead of bottom-half to postpone open event, 2012-10-12) moved the alarm timer initialization to an earlier point but failed to consider that it depends on qemu_init_main_loop. Later, commit 1c53786 (vl: init main loop earlier, 2012-10-30) fixed this, but left

[Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

2012-11-02 Thread Peter Maydell
Commit a93a4a2 changed the names of some fields in DisplayChangeListener and broke compilation of the cocoa UI. Update to the new names. Signed-off-by: Peter Maydell --- ui/cocoa.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 2383646..87d2

Re: [Qemu-devel] [PATCH 3/3] apic: always update the in-kernel status after loading

2012-11-02 Thread Paolo Bonzini
Il 30/10/2012 19:21, Jan Kiszka ha scritto: > > > Aren't we still dependent on the order of processing? If the APIC is > > > restored after the device, won't we get the same problem? > > > > Strictly speaking yes, but CPUs and APICs are always the first devices > > to be saved. > Hmm, thinking ab

Re: [Qemu-devel] [PATCH v2 3/3] aio: rename AIOPool to AIOCBInfo

2012-11-02 Thread Paolo Bonzini
Il 31/10/2012 16:34, Stefan Hajnoczi ha scritto: > Now that AIOPool no longer keeps a freelist, it isn't really a "pool" > anymore. Rename it to AIOCBInfo and make it const since it no longer > needs to be modified. > > Signed-off-by: Stefan Hajnoczi > --- > block.c | 22 +++--

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Corey Bryant
On 11/02/2012 10:46 AM, Paul Moore wrote: On Friday, November 02, 2012 10:43:41 AM Corey Bryant wrote: On 11/02/2012 10:38 AM, Paul Moore wrote: On Friday, November 02, 2012 10:10:02 AM Paul Moore wrote: On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: On 11/01/2012 05:43 PM, Pa

Re: [Qemu-devel] [PATCH v2 2/3] aio: use g_slice_alloc() for AIOCB pooling

2012-11-02 Thread Paolo Bonzini
Il 31/10/2012 16:34, Stefan Hajnoczi ha scritto: > AIO control blocks are frequently acquired and released because each aio > request involves at least one AIOCB. Therefore, we pool them to avoid > heap allocation overhead. > > The problem with the freelist approach in AIOPool is thread-safety.

Re: [Qemu-devel] [PATCH v2 1/3] aio: switch aiocb_size type int -> size_t

2012-11-02 Thread Paolo Bonzini
Il 31/10/2012 16:34, Stefan Hajnoczi ha scritto: > Using appropriate types for variables is a good thing :). All users > simply do sizeof(MyType) and the value is passed to a memory allocator, > it should be size_t. > > Signed-off-by: Stefan Hajnoczi > --- > qemu-aio.h | 2 +- > 1 file changed,

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Paul Moore
On Friday, November 02, 2012 10:43:41 AM Corey Bryant wrote: > On 11/02/2012 10:38 AM, Paul Moore wrote: > > On Friday, November 02, 2012 10:10:02 AM Paul Moore wrote: > >> On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: > >>> On 11/01/2012 05:43 PM, Paul Moore wrote: > On Tuesday

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-02 Thread Michael S. Tsirkin
On Fri, Nov 02, 2012 at 11:18:18AM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 1, 2012 at 5:07 PM, Michael S. Tsirkin wrote: > > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced > > a regression in virtio-net performance because it looks > > into the ring aggressively while we really onl

Re: [Qemu-devel] [PATCH 05/22] console: untangle gfx & txt updates

2012-11-02 Thread Peter Maydell
On 2 November 2012 08:20, Jan Kiszka wrote: > On 2012-11-01 14:04, Gerd Hoffmann wrote: >> Stop abusing displaysurface fields for text mode displays. >> (bpp = 0, width = cols, height = lines). >> >> Add flags to displaystate indicating whenever text mode display >> (curses) or gfx mode displays (

[Qemu-devel] [PATCH v2 3/5] qemu-timer: reinitialize timers after fork

2012-11-02 Thread Paolo Bonzini
Timers are not inherited by the child of a fork(2), so just use pthread_atfork to reinstate them after daemonize. Signed-off-by: Paolo Bonzini --- qemu-timer.c | 14 ++ 1 file modificato, 14 inserzioni(+) diff --git a/qemu-timer.c b/qemu-timer.c index f3426c9..7b2217a 100644 --- a/q

[Qemu-devel] [PATCH v2 2/5] semaphore: implement fallback counting semaphores with mutex+condvar

2012-11-02 Thread Paolo Bonzini
OpenBSD and Darwin do not have sem_timedwait. Implement a fallback for them. Signed-off-by: Paolo Bonzini --- v1->v2: extract compute_abs_deadline and use it qemu-thread-posix.c | 92 +++-- qemu-thread-posix.h | 6 2 file modificati

[Qemu-devel] [PATCH v2 1/5] compiler: support Darwin weak references

2012-11-02 Thread Paolo Bonzini
Weakrefs only tell you if the symbol was defined elsewhere, so you need a further check at runtime to pick the default definition when needed. This could be automated by the compiler, but it does not do it. Signed-off-by: Paolo Bonzini --- v1->v2: add unused attribute compiler.h |

[Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

2012-11-02 Thread Paolo Bonzini
Three fixes: 1) Darwin does not support weak aliases, use weak references instead. 2) Darwin, NetBSD and OpenBSD do not have sem_timedwait, implement counting semaphores with a mutex and cv there. 3) Daemonize was broken, fixes are in patches 3-5. Paolo Bonzini (5): compiler: support Darwin we

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Paul Moore
On Friday, November 02, 2012 10:10:02 AM Paul Moore wrote: > On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: > > On 11/01/2012 05:43 PM, Paul Moore wrote: > > > On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: > > >> According to the bug 855162[0] - there's the need of add

Re: [Qemu-devel] RBD trim / unmap support?

2012-11-02 Thread Stefan Priebe - Profihost AG
Hello qemu list, i cc you as i'm not sure where the problem is. When i use scsi-hd with discard_granularity the discard works fine on target size but the client print these - immediatly after sending discard / trim commands with mkfs.btrfs. [ 75.076895] sd 2:0:0:4: [sdc] [ 75.078353] Resu

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Paul Moore
On Friday, November 02, 2012 12:29:37 AM Eduardo Otubo wrote: > On Thu, Nov 01, 2012 at 05:43:03PM -0400, Paul Moore wrote: > > On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: > > > According to the bug 855162[0] - there's the need of adding new syscalls > > > to the whitelist whenn u

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Paul Moore
On Friday, November 02, 2012 09:48:55 AM Corey Bryant wrote: > On 11/01/2012 05:43 PM, Paul Moore wrote: > > On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: > >> According to the bug 855162[0] - there's the need of adding new syscalls > >> to the whitelist whenn using Qemu with Libvir

[Qemu-devel] First 9 + 1/2 years of QEMU dev history animated

2012-11-02 Thread Daniel P. Berrange
While I was generating an animation of libvirt dev history[1] using gource, I also took the time to generate one showing the first 9+1/2 years of QEMU's dev history. https://www.youtube.com/watch?v=IujBYP7cw8E I see QEMU has its 10th birthday coming up early next year on Feb 18, 2013, assuming

Re: [Qemu-devel] [PATCH 2/5] semaphore: implement fallback counting semaphores with mutex+condvar

2012-11-02 Thread Peter Maydell
On 2 November 2012 14:14, Paolo Bonzini wrote: > +#if defined(__OpenBSD__) || defined(__APPLE__) || defined(__NetBSD__) > +struct timespec ts; > +clock_gettime(CLOCK_REALTIME, &ts); qemu-thread-posix.c:198:5: warning: implicit declaration of function 'clock_gettime' is invalid in C99

Re: [Qemu-devel] [PATCHv2 1/4] Adding new syscalls (bugzilla 855162)

2012-11-02 Thread Corey Bryant
On 11/01/2012 05:43 PM, Paul Moore wrote: On Tuesday, October 23, 2012 03:55:29 AM Eduardo Otubo wrote: According to the bug 855162[0] - there's the need of adding new syscalls to the whitelist whenn using Qemu with Libvirt. [0] - https://bugzilla.redhat.com/show_bug.cgi?id=855162 v2: Adding

Re: [Qemu-devel] [PATCH 1/5] compiler: support Darwin weak references

2012-11-02 Thread Peter Maydell
On 2 November 2012 14:14, Paolo Bonzini wrote: > Weakrefs only tell you if the symbol was defined elsewhere, so you > need a further check at runtime to pick the default definition > when needed. > > This could be automated by the compiler, but it does not do it. clang doesn't error out anymore,

Re: [Qemu-devel] buildbot failure in qemu on default_i386_macosx

2012-11-02 Thread Corey Bryant
On 11/02/2012 03:17 AM, Stefan Hajnoczi wrote: Corey, any ideas here? My guess for the majority of these is that monitor.o is not being linked with osdep.o for MacOSX. Is this a nightly build that would have been successful earlier in the week? Also do you know if (and perhaps how) I ca

Re: [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors

2012-11-02 Thread Luiz Capitulino
On Fri, 02 Nov 2012 14:40:03 +0100 Kevin Wolf wrote: > Am 02.11.2012 14:25, schrieb Luiz Capitulino: > > On Fri, 19 Oct 2012 11:27:59 -0300 > > Luiz Capitulino wrote: > > > >> By adding error propagation to bdrv_img_create() we improve error reporting > >> in qmp_transaction() and simplify qemu

Re: [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors

2012-11-02 Thread Kevin Wolf
Am 02.11.2012 14:25, schrieb Luiz Capitulino: > On Fri, 19 Oct 2012 11:27:59 -0300 > Luiz Capitulino wrote: > >> By adding error propagation to bdrv_img_create() we improve error reporting >> in qmp_transaction() and simplify qemu-img.c:img_create() a bit. >> >> Please, check individual patches f

Re: [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate errors

2012-11-02 Thread Luiz Capitulino
On Fri, 19 Oct 2012 11:27:59 -0300 Luiz Capitulino wrote: > By adding error propagation to bdrv_img_create() we improve error reporting > in qmp_transaction() and simplify qemu-img.c:img_create() a bit. > > Please, check individual patches for details. Kevin, is this in your review queue?

Re: [Qemu-devel] [PATCH v2] tests: allow qemu-iotests to be run against nbd backend

2012-11-02 Thread Kevin Wolf
Am 02.11.2012 13:41, schrieb Paolo Bonzini: > Il 02/11/2012 11:28, n...@bytemark.co.uk ha scritto: >> @@ -197,12 +198,14 @@ testlist options >> IMGPROTO=rbd >> xpand=false >> ;; >> - >> -sheepdog) >> IMGPROTO=sheepdog >> xpand=false >> ;; >

Re: [Qemu-devel] [PATCH] add bochs dispi interface framebuffer driver

2012-11-02 Thread Gerd Hoffmann
>> Only with bochsfb or with vesafb (+ fbdev xorg driver) too? > > vt-switching with vesafb/X11 works fine on a grml 64-bit image. However, xorg > uses vesa driver in this case, not fbdev (fbdev / fbdevhw xorg modules are > initially loaded but then unloaded). X11 uses 1280x768 and vesafb uses >

[Qemu-devel] [PATCH 3/5] qemu-timer: reinitialize timers after fork

2012-11-02 Thread Paolo Bonzini
Timers are not inherited by the child of a fork(2), so just use pthread_atfork to reinstate them after daemonize. Signed-off-by: Paolo Bonzini --- qemu-timer.c | 15 ++- 1 file modificato, 14 inserzioni(+). 1 rimozione(-) diff --git a/qemu-timer.c b/qemu-timer.c index f3426c9..1d876

[Qemu-devel] [PATCH 5/5] vl: delay thread initialization after daemonization

2012-11-02 Thread Paolo Bonzini
Commit ac4119c (chardev: Use timer instead of bottom-half to postpone open event, 2012-10-12) moved the alarm timer initialization to an earlier point but failed to consider that it depends on qemu_init_main_loop. Later, commit 1c53786 (vl: init main loop earlier, 2012-10-30) fixed this, but left

[Qemu-devel] [PATCH 2/5] semaphore: implement fallback counting semaphores with mutex+condvar

2012-11-02 Thread Paolo Bonzini
OpenBSD and Darwin do not have sem_timedwait. Implement a fallback for them. Signed-off-by: Paolo Bonzini --- qemu-thread-posix.c | 74 + qemu-thread-posix.h | 6 + 2 file modificati, 80 inserzioni(+) diff --git a/qemu-thread-posix.c b/q

  1   2   >