Re: [Qemu-devel] [PATCH 0/4] Fix qemu_aio_flush callers

2012-11-13 Thread Kevin Wolf
Am 13.11.2012 18:39, schrieb Paolo Bonzini: > Il 13/11/2012 16:51, Kevin Wolf ha scritto: >> This series has two patches that fixes current qemu_aio_flush() callers, >> which >> should call bdrv_drain_all() instead. The other two patches are for changing >> the coroutine request cancellation to wa

[Qemu-devel] [PATCH] usb: Fix (another) bug in usb_packet_map() for IOMMU handling

2012-11-13 Thread David Gibson
Elements in qemu SGLists can cross IOMMU page boundaries. So, in commit 39c138c8420f51a7da7b35233a8d7400a0b589ac "usb: Fix usb_packet_map() in the presence of IOMMUs", I changed usb_packet_map() to split up each SGList element on IOMMU page boundaries and each resulting piece of qemu's memory spac

[Qemu-devel] [RFC] libqblock OOM issue

2012-11-13 Thread Wenchao Xia
Hello,Paolo and Stefanha In order to resolve OOM issue, I am trying wrap all APIs using sunrpc, need some suggestion before coding. There are some different way to implement, not sure which would be better: 1 keep client as thin as possible, client stores opaque pointer used in server side,

Re: [Qemu-devel] Migration ToDo list

2012-11-13 Thread Isaku Yamahata
On Wed, Nov 14, 2012 at 03:20:08AM +0100, Paolo Bonzini wrote: > Il 14/11/2012 03:14, Isaku Yamahata ha scritto: > >> > Identifying ballooned zero pages is useful, because those cause the > >> > clear_page calls in the kernel even in a guest that has been running for > >> > a while. > >> > > >> >

Re: [Qemu-devel] Migration To-do list

2012-11-13 Thread Isaku Yamahata
On Tue, Nov 13, 2012 at 05:46:13PM +, Hudzia, Benoit wrote: > Hi, > > One concept we have been playing around in the context of and hybrid and > post copy and might make sense if you are orienting your effort toward RDMA / > Post copy is to move most of the logic in the destination side. >

Re: [Qemu-devel] Migration ToDo list

2012-11-13 Thread Paolo Bonzini
Il 14/11/2012 03:14, Isaku Yamahata ha scritto: >> > Identifying ballooned zero pages is useful, because those cause the >> > clear_page calls in the kernel even in a guest that has been running for >> > a while. >> > >> > But a generic solution doesn't really matter, because is_dup_page and >> >

Re: [Qemu-devel] Migration ToDo list

2012-11-13 Thread Isaku Yamahata
On Tue, Nov 13, 2012 at 06:16:30PM +0100, Paolo Bonzini wrote: > Il 13/11/2012 18:09, Orit Wasserman ha scritto: > >> > > >>> >> b) do scatter/gather of the pages? > > I would prefer to postpone changing the protocol and start with using iov > > (writev) > > for sending the pages (still sending

Re: [Qemu-devel] [PATCH 04/24] move qemu_irq typedef out of cpu-common.h

2012-11-13 Thread Andreas Färber
Am 09.11.2012 15:56, schrieb Eduardo Habkost: > From: Igor Mammedov > > it's necessary for making CPU child of DEVICE without > causing circular header deps. > > Signed-off-by: Igor Mammedov > [ehabkost: re-added the typedef to hw/irq.h after rebasing] > Signed-off-by: Eduardo Habkost Acked-b

Re: [Qemu-devel] Virtio refactoring.

2012-11-13 Thread Andreas Färber
Am 13.11.2012 16:32, schrieb Cornelia Huck: > On Tue, 13 Nov 2012 15:27:57 +0100 > KONRAD Frédéric wrote: >> * Introduce a new VirtioBus ( same way as scsi-bus.c ), with >> VirtIODevice >>interface : >> -> callback to completely abstract the VirtioDevice from >> VirtioPCI.

Re: [Qemu-devel] [RFC PATCH v3 0/5] s390: Host support for channel I/O.

2012-11-13 Thread Marcelo Tosatti
On Wed, Oct 31, 2012 at 05:24:33PM +0100, Cornelia Huck wrote: > Hi, > > here's the latest incarnation of my host patches to support channel > I/O on s390. > > Most patches have only seen minor fixes, but patch 5 is completely > different since the kvm <-> user space interface has been reworked.

[Qemu-devel] [PATCH 2/3] vfio-pci: Add KVM INTx acceleration

2012-11-13 Thread Alex Williamson
This makes use of the new level irqfd support enabling bypass of qemu userspace both on INTx injection and unmask. This significantly boosts the performance of devices making use of legacy interrupts (ex. ~60% better netperf TCP_RR scores for an e1000e assigned to a Linux guest and booted with pci

[Qemu-devel] [PATCH 1/3] linux-headers: Update to 3.7-rc5

2012-11-13 Thread Alex Williamson
update-linux-headers.sh script run against Linux tag v3.7-rc5 Signed-off-by: Alex Williamson --- linux-headers/asm-powerpc/kvm_para.h |6 +++--- linux-headers/asm-s390/kvm_para.h|8 +--- linux-headers/asm-x86/kvm.h | 17 + linux-headers/linux/kvm.h

[Qemu-devel] [PATCH 3/3] vfio-pci: Use common msi_get_message

2012-11-13 Thread Alex Williamson
We can get rid of our local version now that a helper exists. Signed-off-by: Alex Williamson --- hw/vfio_pci.c | 24 +--- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index 4e9c2dd..7c27834 100644 --- a/hw/vfio_pci.c +++ b/hw/v

[Qemu-devel] [PULL 0/3] vfio-pci for 1.3-rc0

2012-11-13 Thread Alex Williamson
Hi Anthony, Please pull the tag below. I posted the linux-headers update separately on Oct-15; since it hasn't been applied and should be non-controversial, I include it again here. Thanks, Alex The following changes since commit f5022a135e4309a54d433c69b2a056756b2d0d6b: aio: fix aio_ctx_pr

Re: [Qemu-devel] Migration To-do list

2012-11-13 Thread Hudzia, Benoit
Hi, One concept we have been playing around in the context of and hybrid and post copy and might make sense if you are orienting your effort toward RDMA / Post copy is to move most of the logic in the destination side. This is one thing you might want to consider as it can solve some of the

Re: [Qemu-devel] [PATCH 5/6] pixman: build internal version early

2012-11-13 Thread Johnson, Eric
It's OK to add. Signed-off-by: Eric Johnson I wasn't sure how to submit a patch to an unsubmitted patch. I haven't had a chance to review the patch submission doc to see if that is covered. It would still be useful info. I intend to recreate and supply my local sed replacement of $(BUILD_DI

Re: [Qemu-devel] [PATCH 5/6] pixman: build internal version early

2012-11-13 Thread Peter Maydell
On 13 November 2012 08:42, Gerd Hoffmann wrote: > Patch by Eric Johnson. > > Signed-off-by: Gerd Hoffmann Does this need a Signed-off-by: from Eric? It's a pretty trivial patch but I guess it would be nice... thanks -- PMM > --- > configure |7 --- > 1 files changed, 4 insertions(+),

Re: [Qemu-devel] [PATCH 4/6] pixman: add pass cflags, add -fPIC

2012-11-13 Thread Peter Maydell
On 13 November 2012 08:42, Gerd Hoffmann wrote: > Pass on CFLAGS to the pixman configure script. > Add -fPIC to the cflags, needed to make the final link succeed. In Subject, s/add pass/pass/. -- PMM

Re: [Qemu-devel] [PATCH 3/6] pixman: disable gtk

2012-11-13 Thread Peter Maydell
On 13 November 2012 08:42, Gerd Hoffmann wrote: > gtk isn only needed to build test cases. Since we're going to get a v2 of this patch set, you could correct the typo here: s/isn/is/. > Disable it to simplify the build. > > Signed-off-by: Gerd Hoffmann > --- > Makefile |2 +- > 1 files cha

Re: [Qemu-devel] Virtio refactoring.

2012-11-13 Thread Cornelia Huck
On Tue, 13 Nov 2012 17:31:40 +0100 KONRAD Frédéric wrote: > On 13/11/2012 16:32, Cornelia Huck wrote: > > On Tue, 13 Nov 2012 15:27:57 +0100 > > KONRAD Frédéric wrote: > > > >> To fix this, an idea is to use a new qbus named VirtioBus to link > >> virtio-pci > >> or virtio-mmio with all the vir

Re: [Qemu-devel] [PULL 0/6] pixman build fixes

2012-11-13 Thread Stefan Weil
Am 13.11.2012 18:31, schrieb Peter Maydell: On 13 November 2012 08:42, Gerd Hoffmann wrote: This patch series fixes the build issues with the internal pixman submodule. It also adds licensing info to the qemu-pixman.[ch] files. These look OK (and I've tested that we can crosscompile using int

Re: [Qemu-devel] [PATCH 1/6] pixman: add output dir to include path

2012-11-13 Thread Stefan Weil
Am 13.11.2012 09:42, schrieb Gerd Hoffmann: Needed to make sure the (generated) pixman-version.h file is found. Based on a patch from Blue Swirl. Signed-off-by: Gerd Hoffmann --- configure |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure ind

Re: [Qemu-devel] [PATCH 2/6] pixman: pass tools to configure

2012-11-13 Thread Stefan Weil
Am 13.11.2012 09:42, schrieb Gerd Hoffmann: Complete the set of compiler tool names in config-host.mak, pass them to pixman configure to make sure cross builds work. Based on a patch from Blue Swirl. Signed-off-by: Gerd Hoffmann --- Makefile |2 +- configure |4 2 files change

Re: [Qemu-devel] [PATCH 0/4] Fix qemu_aio_flush callers

2012-11-13 Thread Paolo Bonzini
Il 13/11/2012 16:51, Kevin Wolf ha scritto: > This series has two patches that fixes current qemu_aio_flush() callers, which > should call bdrv_drain_all() instead. The other two patches are for changing > the coroutine request cancellation to waiting for a single request (Paolo > didn't want to ch

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Dietmar Maurer
> > You can also reproduce the problem with RHEL6.2 as guest But it seems > > RHEL 6.3 fixed it. > > RHEL6.2 on ubuntu host? I only tested with RHEL6.3 kernel on host.

Re: [Qemu-devel] [PULL 0/6] pixman build fixes

2012-11-13 Thread Peter Maydell
On 13 November 2012 08:42, Gerd Hoffmann wrote: > This patch series fixes the build issues with the internal pixman > submodule. It also adds licensing info to the qemu-pixman.[ch] files. These look OK (and I've tested that we can crosscompile using internal pixman in a separate builddirectory).

Re: [Qemu-devel] q35, usb-ehci1, and Mac OS X boot problems

2012-11-13 Thread Gabriel L. Somlo
On Tue, Nov 13, 2012 at 05:31:42PM +0100, Gerd Hoffmann wrote: > The last lines of the log are more useful, which is more than 650 > lines like this: > > usb_ehci_opreg_read 4.767 addr=0x2c str=FRINDEX val=0x0 > > So macos seems to expect the frame index updating, and probably frame > list ro

Re: [Qemu-devel] Migration ToDo list

2012-11-13 Thread Paolo Bonzini
Il 13/11/2012 18:09, Orit Wasserman ha scritto: >> > >>> >> b) do scatter/gather of the pages? > I would prefer to postpone changing the protocol and start with using iov > (writev) > for sending the pages (still sending header and than the page). Later we can > move to scatter/gather I'm not

[Qemu-devel] [Bug 1078305] [NEW] source IP address of broadcast packets gets rewritten when using NAT

2012-11-13 Thread Pallinger Péter
Public bug reported: If I send a broadcast message like this to the limited broadcast address: echo a | nc -bu 255.255.255.255 5000 then the resulting packet looks like this on the sender side: 14:36:17.997662 02:00:c0:a8:7a:fb (oui Unknown) > Broadcast, ethertype IPv4 (0x0800), length

[Qemu-devel] [Bug 1078305] Re: source IP address of broadcast packets gets rewritten when using NAT

2012-11-13 Thread Pallinger Péter
A possible workaround is: local_bcast_addr=192.168.122.255 # here you should rather detect this than specify it iptables -A PREROUTING -d 255.255.255.255 -p udp -j DNAT --to-destination $local_bcast_addr iptables -A PREROUTING -d 255.255.255.255 -p tcp -j DNAT --to-destination $local_bcast_add

Re: [Qemu-devel] Migration ToDo list

2012-11-13 Thread Orit Wasserman
On 11/13/2012 06:28 PM, Paolo Bonzini wrote: > Il 13/11/2012 17:18, Juan Quintela ha scritto: >> Migration Thread >> * Plan is integrate it as one of first thing in December (me) > > Please make sure to take a look at the latest reviews I sent. > >> * Remove copies with buffered file (me) > > I

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Michael S. Tsirkin
On Tue, Nov 13, 2012 at 05:03:20PM +, Dietmar Maurer wrote: > > Tried with upstream qemu on rhel kernel and that's even a bit faster. > > So it's ubuntu kernel. vanilla 2.6.32 didn't have vhost at all so maybe > > their > > vhost backport is broken insome way. > > You can also reproduce the p

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Dietmar Maurer
> Tried with upstream qemu on rhel kernel and that's even a bit faster. > So it's ubuntu kernel. vanilla 2.6.32 didn't have vhost at all so maybe their > vhost backport is broken insome way. You can also reproduce the problem with RHEL6.2 as guest But it seems RHEL 6.3 fixed it. There seem to be

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Michael S. Tsirkin
On Tue, Nov 13, 2012 at 05:27:17PM +0100, Peter Lieven wrote: > > Am 13.11.2012 um 17:26 schrieb Michael S. Tsirkin: > > > On Tue, Nov 13, 2012 at 05:21:50PM +0100, Peter Lieven wrote: > >> On 13.11.2012 17:22, Michael S. Tsirkin wrote: > >>> On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Dietmar Maurer
> the bug seems to be only relevant when vhost-net is used. > > Dietmar, see you implications with normal virtio? no, only with vhost=on

Re: [Qemu-devel] Migration ToDo list

2012-11-13 Thread Orit Wasserman
On 11/13/2012 06:48 PM, Chegu Vinod wrote: > On 11/13/2012 8:18 AM, Juan Quintela wrote: >> Hi >> >> If you have anything else to put, please add. >> >> Migration Thread >> * Plan is integrate it as one of first thing in December (me) >> * Remove copies with buffered file (me) >> >> Bitmap Optimiza

Re: [Qemu-devel] [PATCH 06/24] move I/O-related definitions from qemu-common.h to a new header (qemu-stdio.h)

2012-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2012 at 05:43:42PM +0100, Igor Mammedov wrote: > On Tue, 13 Nov 2012 13:52:16 -0200 > Eduardo Habkost wrote: > > > On Tue, Nov 13, 2012 at 04:30:17PM +0100, Igor Mammedov wrote: > > > On Fri, 9 Nov 2012 12:56:34 -0200 > > > Eduardo Habkost wrote: > > > > > > > This will help re

Re: [Qemu-devel] Migration ToDo list

2012-11-13 Thread Chegu Vinod
On 11/13/2012 8:18 AM, Juan Quintela wrote: Hi If you have anything else to put, please add. Migration Thread * Plan is integrate it as one of first thing in December (me) * Remove copies with buffered file (me) Bitmap Optimization * Finish moving to individual bitmaps for migration/vga/code *

Re: [Qemu-devel] [PATCH 06/24] move I/O-related definitions from qemu-common.h to a new header (qemu-stdio.h)

2012-11-13 Thread Igor Mammedov
On Tue, 13 Nov 2012 13:52:16 -0200 Eduardo Habkost wrote: > On Tue, Nov 13, 2012 at 04:30:17PM +0100, Igor Mammedov wrote: > > On Fri, 9 Nov 2012 12:56:34 -0200 > > Eduardo Habkost wrote: > > > > > This will help reduce the qemu-common.h dependency hell. > > > > > > Signed-off-by: Eduardo Hab

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Michael S. Tsirkin
On Tue, Nov 13, 2012 at 05:35:55PM +0100, Peter Lieven wrote: > > Am 13.11.2012 um 17:33 schrieb Michael S. Tsirkin: > > > On Tue, Nov 13, 2012 at 06:22:56PM +0200, Michael S. Tsirkin wrote: > >> On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven wrote: > >>> > >>> On 09.11.2012 19:03, Peter

Re: [Qemu-devel] Migration ToDo list

2012-11-13 Thread Orit Wasserman
On 11/13/2012 06:18 PM, Juan Quintela wrote: > > Hi > > If you have anything else to put, please add. > > Migration Thread > * Plan is integrate it as one of first thing in December (me) > * Remove copies with buffered file (me) > > Bitmap Optimization > * Finish moving to individual bitmaps fo

Re: [Qemu-devel] qemu and transparent huge pages

2012-11-13 Thread Michael Tokarev
On 13.11.2012 18:30, Aurelien Jarno wrote: > Isn't ad0b5321f1f797274603ebbe20108b0750baee94 enough? Oh. It has been applied. I expected it will be ignored just like my patch has been. No, it is not enough: that patch alone does nothing for the alignment on at least x86, which is necessary for h

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Peter Lieven
Am 13.11.2012 um 17:33 schrieb Michael S. Tsirkin: > On Tue, Nov 13, 2012 at 06:22:56PM +0200, Michael S. Tsirkin wrote: >> On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven wrote: >>> >>> On 09.11.2012 19:03, Peter Lieven wrote: Remark: If i disable interrupts on CPU1-3 for virti

Re: [Qemu-devel] [Bug 1075252] Re: qemu-img cannot read VMDK4 file

2012-11-13 Thread Robert Hubbard
Hi Stefan, Will post later this week/end based on your requirements. Regards. Rob. On Thu, Nov 8, 2012 at 12:15 AM, Stefan Hajnoczi <1075...@bugs.launchpad.net > wrote: > On Tue, Nov 6, 2012 at 11:38 PM, Robert Hubbard > wrote: > > Duplicate - Same issue related to header/footer - When does th

Re: [Qemu-devel] q35, usb-ehci1, and Mac OS X boot problems

2012-11-13 Thread Gerd Hoffmann
On 11/13/12 16:48, Gabriel L. Somlo wrote: > Gerd, > > On Tue, Nov 13, 2012 at 09:48:10AM +0100, Gerd Hoffmann wrote: >>> below is what I got running the "-usb -device usb-kbd -device usb-mouse" >>> command line with EHCI_DEBUG set to 1. >> >> This isn't what I ment. See docs/tracing.txt for how

Re: [Qemu-devel] Virtio refactoring.

2012-11-13 Thread KONRAD Frédéric
On 13/11/2012 16:32, Cornelia Huck wrote: On Tue, 13 Nov 2012 15:27:57 +0100 KONRAD Frédéric wrote: To fix this, an idea is to use a new qbus named VirtioBus to link virtio-pci or virtio-mmio with all the virtio backend ( VirtioDevice ). So "virtio-pci" and "virtio-mmio" will have a VirtioBus.

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Michael S. Tsirkin
On Tue, Nov 13, 2012 at 06:22:56PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven wrote: > > > > On 09.11.2012 19:03, Peter Lieven wrote: > > >Remark: > > >If i disable interrupts on CPU1-3 for virtio the performance is ok again. > > > > > >Now we need so

Re: [Qemu-devel] Migration ToDo list

2012-11-13 Thread Paolo Bonzini
Il 13/11/2012 17:18, Juan Quintela ha scritto: > Migration Thread > * Plan is integrate it as one of first thing in December (me) Please make sure to take a look at the latest reviews I sent. > * Remove copies with buffered file (me) I also have some prototype of this. > RDMA > * Send RDMA/tcp/

[Qemu-devel] [RFC PATCH 1/4] block: Improve bdrv_aio_co_cancel_em

2012-11-13 Thread Kevin Wolf
Instead of waiting for all requests to complete, wait just for the specific request that should be cancelled. Signed-off-by: Kevin Wolf --- block.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 626d6c2..a2a060d 100644 --- a/bl

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Peter Lieven
Am 13.11.2012 um 17:26 schrieb Michael S. Tsirkin: > On Tue, Nov 13, 2012 at 05:21:50PM +0100, Peter Lieven wrote: >> On 13.11.2012 17:22, Michael S. Tsirkin wrote: >>> On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven wrote: On 09.11.2012 19:03, Peter Lieven wrote: > Remark: >

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Michael S. Tsirkin
On Tue, Nov 13, 2012 at 05:21:50PM +0100, Peter Lieven wrote: > On 13.11.2012 17:22, Michael S. Tsirkin wrote: > >On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven wrote: > >>On 09.11.2012 19:03, Peter Lieven wrote: > >>>Remark: > >>>If i disable interrupts on CPU1-3 for virtio the performance

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Peter Lieven
On 13.11.2012 17:22, Michael S. Tsirkin wrote: On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven wrote: On 09.11.2012 19:03, Peter Lieven wrote: Remark: If i disable interrupts on CPU1-3 for virtio the performance is ok again. Now we need someone with deeper knowledge of the in-kernel irq

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Michael S. Tsirkin
On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven wrote: > > On 09.11.2012 19:03, Peter Lieven wrote: > >Remark: > >If i disable interrupts on CPU1-3 for virtio the performance is ok again. > > > >Now we need someone with deeper knowledge of the in-kernel irqchip and the > >virtio/vhost drive

[Qemu-devel] Migration ToDo list

2012-11-13 Thread Juan Quintela
Hi If you have anything else to put, please add. Migration Thread * Plan is integrate it as one of first thing in December (me) * Remove copies with buffered file (me) Bitmap Optimization * Finish moving to individual bitmaps for migration/vga/code * Make sure we don't copy things around * Shar

Re: [Qemu-devel] [PATCH 06/24] move I/O-related definitions from qemu-common.h to a new header (qemu-stdio.h)

2012-11-13 Thread Igor Mammedov
On Fri, 9 Nov 2012 12:56:34 -0200 Eduardo Habkost wrote: > This will help reduce the qemu-common.h dependency hell. > > Signed-off-by: Eduardo Habkost > -- > Changes v1 -> v2: > - move qemu_open() & qemu_close() to qemu-stdio.h, too > --- > qemu-common.h | 59 ++--

[Qemu-devel] [RFC PATCH 4/4] aio: Get rid of qemu_aio_flush()

2012-11-13 Thread Kevin Wolf
The remaining callers are simply bugs and should be using bdrv_drain_all() in the first place. Signed-off-by: Kevin Wolf --- async.c|5 - block/commit.c |2 +- block/mirror.c |2 +- block/stream.c |2 +- main-loop.c|5 - qemu-aio.h |9 ++--- 6

[Qemu-devel] [PATCH 3/4] qemu-io: Use bdrv_drain_all instead of qemu_aio_flush

2012-11-13 Thread Kevin Wolf
This is harmless as of today because I/O throttling is not used in qemu-io, however as soon as .bdrv_drain handlers will be introduced, qemu-io must be sure to call bdrv_drain_all(). Signed-off-by: Kevin Wolf --- qemu-io.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a

[Qemu-devel] [PATCH 2/4] megasas: Use bdrv_drain_all instead of qemu_aio_flush

2012-11-13 Thread Kevin Wolf
Calling qemu_aio_flush() directly can hang when combined with I/O throttling. Signed-off-by: Kevin Wolf --- hw/megasas.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/megasas.c b/hw/megasas.c index 7a2036e..d332d41 100644 --- a/hw/megasas.c +++ b/hw/megasas.c @@ -1

[Qemu-devel] [PATCH 0/4] Fix qemu_aio_flush callers

2012-11-13 Thread Kevin Wolf
This series has two patches that fixes current qemu_aio_flush() callers, which should call bdrv_drain_all() instead. The other two patches are for changing the coroutine request cancellation to waiting for a single request (Paolo didn't want to change this to bdrv_drain_all()) and removing qemu_aio

Re: [Qemu-devel] [PATCH 06/24] move I/O-related definitions from qemu-common.h to a new header (qemu-stdio.h)

2012-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2012 at 04:30:17PM +0100, Igor Mammedov wrote: > On Fri, 9 Nov 2012 12:56:34 -0200 > Eduardo Habkost wrote: > > > This will help reduce the qemu-common.h dependency hell. > > > > Signed-off-by: Eduardo Habkost > > -- > > Changes v1 -> v2: > > - move qemu_open() & qemu_close()

Re: [Qemu-devel] q35, usb-ehci1, and Mac OS X boot problems

2012-11-13 Thread Gabriel L. Somlo
Gerd, On Tue, Nov 13, 2012 at 09:48:10AM +0100, Gerd Hoffmann wrote: > > below is what I got running the "-usb -device usb-kbd -device usb-mouse" > > command line with EHCI_DEBUG set to 1. > > This isn't what I ment. See docs/tracing.txt for how tracepoint work. > Wildcards (i.e. 'ehci_*') work

Re: [Qemu-devel] [PATCH] KVM: MMU: lazily drop large spte

2012-11-13 Thread Takuya Yoshikawa
Ccing live migration developers who should be interested in this work, On Mon, 12 Nov 2012 21:10:32 -0200 Marcelo Tosatti wrote: > On Mon, Nov 05, 2012 at 05:59:26PM +0800, Xiao Guangrong wrote: > > Do not drop large spte until it can be insteaded by small pages so that > > the guest can happliy

Re: [Qemu-devel] Virtio refactoring.

2012-11-13 Thread Cornelia Huck
On Tue, 13 Nov 2012 15:27:57 +0100 KONRAD Frédéric wrote: > To fix this, an idea is to use a new qbus named VirtioBus to link virtio-pci > or virtio-mmio with all the virtio backend ( VirtioDevice ). So > "virtio-pci" and > "virtio-mmio" will have a VirtioBus. Just to spell this out: We'd go f

Re: [Qemu-devel] [PATCH] dma: Define dma_context_memory and use in sysbus-ohci

2012-11-13 Thread Paolo Bonzini
Il 13/11/2012 16:21, Gerd Hoffmann ha scritto: >>> >> Ping! Can we have a ruling on what the right fix for this is so >>> >> we can fix these segfaults before 1.3 release, please? >> > >> > I think this patch is already in Gerd's queue. > It isn't. It used to be in the usb queue, but after the de

Re: [Qemu-devel] [PATCH] dma: Define dma_context_memory and use in sysbus-ohci

2012-11-13 Thread Gerd Hoffmann
Hi, >> Ping! Can we have a ruling on what the right fix for this is so >> we can fix these segfaults before 1.3 release, please? > > I think this patch is already in Gerd's queue. It isn't. It used to be in the usb queue, but after the debate how to fix this property restarted I've dropped it

Re: [Qemu-devel] KVM call agenda for 2012-11-12

2012-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2012 at 03:29:37PM +0100, Andreas Färber wrote: > Am 13.11.2012 13:29, schrieb Eduardo Habkost: > > On Mon, Nov 12, 2012 at 01:58:38PM +0100, Juan Quintela wrote: > >> > >> Please send in any agenda topics you are interested in. > > > > - Clarify 1.3 plans for CPU: > > From my sub

Re: [Qemu-devel] [PATCH] dma: Define dma_context_memory and use in sysbus-ohci

2012-11-13 Thread Paolo Bonzini
Il 13/11/2012 12:44, Peter Maydell ha scritto: >>> >> As soon as Avi's iommu patches go in, in fact, dma->as will just be as. >>> >> Even if as == NULL were to be outlawed and you'd be forced to write >>> >> get_address_space_memory(), taking the pain to create dummy DMAContexts >>> >> now is just

Re: [Qemu-devel] KVM call agenda for 2012-11-12

2012-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2012 at 03:48:55PM +0100, Juan Quintela wrote: > Anthony Liguori wrote: > > Marcelo Tosatti writes: > > > >> On Mon, Nov 12, 2012 at 01:58:38PM +0100, Juan Quintela wrote: > >>> > >>> Hi > >>> > >>> Please send in any agenda topics you are interested in. > >>> > >>> Later, Juan

Re: [Qemu-devel] KVM call agenda for 2012-11-12

2012-11-13 Thread Juan Quintela
Anthony Liguori wrote: > Marcelo Tosatti writes: > >> On Mon, Nov 12, 2012 at 01:58:38PM +0100, Juan Quintela wrote: >>> >>> Hi >>> >>> Please send in any agenda topics you are interested in. >>> >>> Later, Juan. >> >> It would be good to have a status report on qemu-kvm compatibility >> (the

Re: [Qemu-devel] qemu and transparent huge pages

2012-11-13 Thread Aurelien Jarno
Isn't ad0b5321f1f797274603ebbe20108b0750baee94 enough? On Mon, Nov 12, 2012 at 07:18:49PM +0400, Michael Tokarev wrote: > Ping^2 ? > > Thanks, > > /mjt > > 16.09.2012 15:19, Michael Tokarev wrote: > > So, is the patch okay? > > > > Thanks, > > > > /mjt > > > > On 15.08.2012 19:03, Michael To

Re: [Qemu-devel] KVM call agenda for 2012-11-12

2012-11-13 Thread Andreas Färber
Am 13.11.2012 13:29, schrieb Eduardo Habkost: > On Mon, Nov 12, 2012 at 01:58:38PM +0100, Juan Quintela wrote: >> >> Please send in any agenda topics you are interested in. > > - Clarify 1.3 plans for CPU: >From my submaintainer POV: > DeviceState CPU, I was specifically tasked with the qdev sp

[Qemu-devel] Virtio refactoring.

2012-11-13 Thread KONRAD Frédéric
Hi, Just to be sure that we are all understanding the same thing about the virtio refactoring. The old patch-set ( git://git.greensocs.com/qemu_virtio.git virtio ) I sent was not good because : * It use a custom transport property ( e.g : transport=virtio-mmio.0 ) for selecting a transpor

Re: [Qemu-devel] KVM call agenda for 2012-11-12

2012-11-13 Thread Anthony Liguori
Marcelo Tosatti writes: > On Mon, Nov 12, 2012 at 01:58:38PM +0100, Juan Quintela wrote: >> >> Hi >> >> Please send in any agenda topics you are interested in. >> >> Later, Juan. > > It would be good to have a status report on qemu-kvm compatibility > (the remaining TODO items are with Anthony

[Qemu-devel] [PATCH 2/2] block: Avoid second open for format probing

2012-11-13 Thread Kevin Wolf
This fixes problems that are caused by the additional open/close cycle of the existing format probing, for example related to qemu-nbd without -t option or file descriptor passing. Signed-off-by: Kevin Wolf --- block.c | 58 +++--- 1 files ch

[Qemu-devel] [PATCH 1/2] block: Factor out bdrv_open_flags

2012-11-13 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block.c | 35 +-- 1 files changed, 21 insertions(+), 14 deletions(-) diff --git a/block.c b/block.c index 854ebd6..a55b06c 100644 --- a/block.c +++ b/block.c @@ -634,6 +634,26 @@ void bdrv_disable_copy_on_read(BlockDriverState *bs)

[Qemu-devel] [PATCH 0/2] block: Avoid second open for format probing

2012-11-13 Thread Kevin Wolf
Kevin Wolf (2): block: Factor out bdrv_open_flags block: Avoid second open for format probing block.c | 93 +++--- 1 files changed, 52 insertions(+), 41 deletions(-) -- 1.7.6.5

Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

2012-11-13 Thread Stefan Hajnoczi
On Tue, Nov 13, 2012 at 01:27:57PM +0100, Kevin Wolf wrote: > Am 10.11.2012 10:59, schrieb Gerhard Wiesinger: > > On 10.11.2012 09:55, Paolo Bonzini wrote: > >> Il 10/11/2012 09:30, Gerhard Wiesinger ha scritto: > > 2.) Added debug code to block.c and to block/vmdk.c to verify > > correctne

Re: [Qemu-devel] [PATCH] block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

2012-11-13 Thread Kevin Wolf
Am 10.11.2012 09:22, schrieb Gerhard Wiesinger: > Fixed a MAJOR BUG in VMDK files on file boundaries on reads > and ALSO ON WRITES WHICH MIGHT CORRUPT THE IMAGE AND DATA!! > > Triggered for example with the following VMDK file (partly listed): > # Extent description > RW 4193792 FLAT "XP-W1-f0

Re: [Qemu-devel] KVM call agenda for 2012-11-12

2012-11-13 Thread Zhi Yong Wu
HI, I'm got confused by the date in this topic. On Mon, Nov 12, 2012 at 8:58 PM, Juan Quintela wrote: > > Hi > > Please send in any agenda topics you are interested in. > > Later, Juan. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majord...@

Re: [Qemu-devel] KVM call agenda for 2012-11-12

2012-11-13 Thread Eduardo Habkost
On Mon, Nov 12, 2012 at 01:58:38PM +0100, Juan Quintela wrote: > > Hi > > Please send in any agenda topics you are interested in. - Clarify 1.3 plans for CPU: DeviceState CPU, x86 CPU classes, x86 CPU properties (we still want to get any of this included, or all will have to wait for 1.4?) -

Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION

2012-11-13 Thread Kevin Wolf
Am 10.11.2012 10:59, schrieb Gerhard Wiesinger: > On 10.11.2012 09:55, Paolo Bonzini wrote: >> Il 10/11/2012 09:30, Gerhard Wiesinger ha scritto: > 2.) Added debug code to block.c and to block/vmdk.c to verify > correctness Same here. Also, please use the tracing infrastructure---a lo

Re: [Qemu-devel] [PATCH v2 01/14] target-arm: Add QOM subclasses for each ARM cpu implementation

2012-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2012 at 12:17:00PM +, Peter Maydell wrote: > On 13 November 2012 11:51, Andreas Färber wrote: > > Am 12.11.2012 23:33, schrieb Eduardo Habkost: > >> In that case, "cpu-any" wouldn't work, either. What about > >> "-cpu-"? > > > > Fine with me. However, keep in mind the previous

Re: [Qemu-devel] [PATCH v2 01/14] target-arm: Add QOM subclasses for each ARM cpu implementation

2012-11-13 Thread Eduardo Habkost
On Tue, Nov 13, 2012 at 12:51:43PM +0100, Andreas Färber wrote: > Am 12.11.2012 23:33, schrieb Eduardo Habkost: > > On Mon, Nov 12, 2012 at 10:18:29PM +, Peter Maydell wrote: > >> On 12 November 2012 22:16, Eduardo Habkost wrote: > >>> On Sat, Apr 14, 2012 at 05:42:10PM +0100, Peter Maydell wr

Re: [Qemu-devel] [PATCHv2] tap: reset vnet header size on open

2012-11-13 Thread Stefan Hajnoczi
On Tue, Nov 13, 2012 at 12:23:23PM +0200, Michael S. Tsirkin wrote: > For tap, we currently assume the vnet header size is 10 > (the default value) but that might not be the case > if tap is persistent and has been used by qemu previously. > To fix, set host header size in tap device on open. > >

Re: [Qemu-devel] [PATCH v2 01/14] target-arm: Add QOM subclasses for each ARM cpu implementation

2012-11-13 Thread Peter Maydell
On 13 November 2012 11:51, Andreas Färber wrote: > Am 12.11.2012 23:33, schrieb Eduardo Habkost: >> In that case, "cpu-any" wouldn't work, either. What about >> "-cpu-"? > > Fine with me. However, keep in mind the previous approach was used for > command line compatibility: I would like to continu

[Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one

2012-11-13 Thread Christian Borntraeger
From: Heinz Graalfs The global variable 'ram_size' is hidden by the local variable declaration in s390_init() Signed-off-by: Heinz Graalfs Signed-off-by: Christian Borntraeger --- hw/s390-virtio.c |1 - 1 file changed, 1 deletion(-) diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c index

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Peter Lieven
On 09.11.2012 19:03, Peter Lieven wrote: Remark: If i disable interrupts on CPU1-3 for virtio the performance is ok again. Now we need someone with deeper knowledge of the in-kernel irqchip and the virtio/vhost driver development to say if this is a regression in qemu-kvm or a problem with the

Re: [Qemu-devel] [PATCH v2 01/14] target-arm: Add QOM subclasses for each ARM cpu implementation

2012-11-13 Thread Andreas Färber
Am 12.11.2012 23:33, schrieb Eduardo Habkost: > On Mon, Nov 12, 2012 at 10:18:29PM +, Peter Maydell wrote: >> On 12 November 2012 22:16, Eduardo Habkost wrote: >>> On Sat, Apr 14, 2012 at 05:42:10PM +0100, Peter Maydell wrote: +static const ARMCPUInfo arm_cpus[] = { >>> [...] +{

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-13 Thread Peter Lieven
On 09.11.2012 19:03, Peter Lieven wrote: Remark: If i disable interrupts on CPU1-3 for virtio the performance is ok again. Now we need someone with deeper knowledge of the in-kernel irqchip and the virtio/vhost driver development to say if this is a regression in qemu-kvm or a problem with the

Re: [Qemu-devel] [PATCH] dma: Define dma_context_memory and use in sysbus-ohci

2012-11-13 Thread Peter Maydell
On 26 October 2012 17:00, Peter Maydell wrote: > On 26 October 2012 14:09, Paolo Bonzini wrote: >> As soon as Avi's iommu patches go in, in fact, dma->as will just be as. >> Even if as == NULL were to be outlawed and you'd be forced to write >> get_address_space_memory(), taking the pain to creat

Re: [Qemu-devel] DOS boot problem with LSI 53C895A SCSI controller and LSI option ROM

2012-11-13 Thread Paolo Bonzini
Il 12/11/2012 21:53, Gerhard Wiesinger ha scritto: > On 12.11.2012 09:26, Paolo Bonzini wrote: >> Il 10/11/2012 22:39, Gerhard Wiesinger ha scritto: >>> Hello, >>> >>> I bisected down a DOS boot problem with LSI 53C895A SCSI controller and >>> LSI option ROM to the following commit: >>> e93176d55f1

Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-11-13 Thread Stefano Stabellini
On Tue, 13 Nov 2012, Paolo Bonzini wrote: > Il 12/11/2012 20:12, Charles Arnold ha scritto: > > Ping? > > > > Any thoughts on whether this is acceptable? > > I would like to know what is done by other platforms. Stefano, any idea > about XenServer? > I am not sure, but maybe Thanos, that is wo

Re: [Qemu-devel] [PATCH] block: vpc support for ~2 TB disks

2012-11-13 Thread Paolo Bonzini
Il 12/11/2012 20:12, Charles Arnold ha scritto: > Ping? > > Any thoughts on whether this is acceptable? I would like to know what is done by other platforms. Stefano, any idea about XenServer? Paolo > - Charles > On 10/30/2012 at 08:59 PM, in message <50a0e561.5b74.009...@suse.com>, >>>

Re: [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field

2012-11-13 Thread Paolo Bonzini
Il 12/11/2012 20:17, Charles Arnold ha scritto: > Ping? > > Is this ok? > > - Charles > On 11/2/2012 at 09:54 AM, in message <50a0e829.5b74.009...@suse.com>, Charles > Arnold wrote: >> block/vpc: Initialize the uuid field in the footer with a generated uuid. >> >> Signed-off-by: Char

[Qemu-devel] [Bug 1077838] Re: qemu-nbd -r -c taints device for subsequent usage, even after -d

2012-11-13 Thread Paolo Bonzini
** Changed in: qemu Status: New => In Progress ** Changed in: qemu Assignee: (unassigned) => Paolo Bonzini (bonzini) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1077838 Title: qemu-n

[Qemu-devel] [PATCHv2] tap: reset vnet header size on open

2012-11-13 Thread Michael S. Tsirkin
For tap, we currently assume the vnet header size is 10 (the default value) but that might not be the case if tap is persistent and has been used by qemu previously. To fix, set host header size in tap device on open. Signed-off-by: Michael S. Tsirkin --- This fixes the issue reported by Alexand

Re: [Qemu-devel] [PULL 1.3 0/7] NBD updates for 2012-11-12

2012-11-13 Thread Paolo Bonzini
Il 12/11/2012 15:22, Paolo Bonzini ha scritto: > Anthony, > > The following changes since commit 3c5645fab3c4b65d0cffbe1aaafc787e4be63d0f: > > tcg: properly check that op's output needs to be synced to memory > (2012-11-11 16:06:46 +0100) > > are available in the git repository at: > > git

[Qemu-devel] [PATCH] nbd: fixes to read-only handling

2012-11-13 Thread Paolo Bonzini
We do not need BLKROSET if the kernel supports setting flags. Also, always do BLKROSET even for a read-write export, otherwise the read-only state remains "sticky" after the invocation of "qemu-nbd -r". Signed-off-by: Paolo Bonzini --- nbd.c | 25 - 1 file modificato, 12

Re: [Qemu-devel] [PATCH v6 1/8] atomic: introduce atomic operations

2012-11-13 Thread Paolo Bonzini
> > Il 05/11/2012 06:38, Liu Ping Fan ha scritto: > > > From: Liu Ping Fan > > > > > > If out of global lock, we will be challenged by SMP in low level, > > > so need atomic ops. > > > > > > This file is a wrapper of GCC atomic builtin. > > > > I still object to this. > > > > I know it enforces ty

Re: [Qemu-devel] [PATCH 2/3] s390: Virtual channel subsystem support.

2012-11-13 Thread Cornelia Huck
On Mon, 12 Nov 2012 23:17:55 -0200 Marcelo Tosatti wrote: > Hi Cornelia, > > On Wed, Oct 31, 2012 at 05:24:47PM +0100, Cornelia Huck wrote: > > Provide a mechanism for qemu to provide fully virtual subchannels to > > the guest. In the KVM case, this relies on the kernel's css support > > for I/O

  1   2   >