Re: [Qemu-devel] net: RFC New Socket-Based, Switched Network Backend (QDES)

2012-11-27 Thread Mike Lovell
On 11/27/2012 07:24 AM, Anthony Liguori wrote: Stefan Hajnoczi writes: The part I'm wondering about with VXLAN multicast is whether all QEMU processes on the host need to receive on the same well-known UDP port. Not sure if that's possible with the sockets API. Perhaps this is a dumb questi

Re: [Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 19:17, Stefan Weil ha scritto: > A real problem could arise from compilers which don't support -fno-gcse. It was introduced in GCC 3.0. > As this option is not checked for compatibility in configure, such > compilers would no longer work with unmodified QEMU sources. clang > obviou

Re: [Qemu-devel] net: RFC New Socket-Based, Switched Network Backend (QDES)

2012-11-27 Thread Mike Lovell
On 11/27/2012 05:42 AM, Stefan Hajnoczi wrote: On Mon, Nov 26, 2012 at 6:19 PM, Mike Lovell wrote: i think it does still make sense to implement it in QEMU. there isn't a problem with multiple processes using the same multicast address. the net_socket_mcast_create function in socket.c already s

[Qemu-devel] [PATCH]target-i386:cpu_x86_init():do clean up work

2012-11-27 Thread liguang
1.remove unused variable env 2.remove redundant error handling Signed-off-by: liguang --- target-i386/helper.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index bf206cf..5686130 100644 --- a/target-i386/help

Re: [Qemu-devel] [PATCH 05/17] target-i386: cpu_x86_init(): move error handling to end of function

2012-11-27 Thread li guang
在 2012-11-12一的 19:38 -0200,Eduardo Habkost写道: > Doing error handling on a single place will make it easier to make sure > memory is freed, and that error information is properly printed or > returned to the caller. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 13 - >

Re: [Qemu-devel] [PATCH 02/17] target-i386: move cpu_x86_init() to cpu.c

2012-11-27 Thread li guang
在 2012-11-12一的 19:38 -0200,Eduardo Habkost写道: > Eventually all of the CPU init code will probably become just a simple > object_new() call, with some arch-independent function that handles the > CPU model string parsing. But right now we need to reorder and split > many of the steps invoved in the

Re: [Qemu-devel] [Qemu-ppc] [0/2] pseries: Rework PCI code for handling multiple PHBs

2012-11-27 Thread David Gibson
On Tue, Nov 27, 2012 at 02:36:57PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 27, 2012 at 05:07:31PM +1100, David Gibson wrote: > > Hi Michael, Alex, > > > > This patch represents a compromise I hope will be acceptable after the > > long thread discussing handling of multiple PCI host bridges

[Qemu-devel] main-loop.c: About Select handling

2012-11-27 Thread Furukawa, Eiji
About a source of qemu-1.2.0/main-loop.c The select handling of os_host_main_loop_wait function I do not seem to do Exit by interrupts such as SIGUSR1 Will not it be necessary to make modifications? Before LineNumber:308 ret = select(nfds + 1, &rfds, &wfds, &xfds, tvarg); After(Example) do

Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt among VMs

2012-11-27 Thread liu ping fan
On Wed, Nov 28, 2012 at 5:48 AM, Cam Macdonell wrote: > On Sat, Nov 24, 2012 at 8:51 PM, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> Using irqfd, so we can avoid switch between kernel and user when >> VMs interrupts each other. > > Nice work. Due to a hardware failure, there will be a small

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] pseries: Properly handle allocation of multiple PCI host bridges

2012-11-27 Thread David Gibson
Alex, If mst should happen to ack this in the next little while, please don't merge it. I've spotted a couple of little bugs with it. On Tue, Nov 27, 2012 at 05:07:33PM +1100, David Gibson wrote: > From: Alexey Kardashevskiy > > Multiple - even many - PCI host bridges (i.e. PCI domains) are v

Re: [Qemu-devel] [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support

2012-11-27 Thread Amos Kong
On Wed, Nov 28, 2012 at 10:29 AM, Auld, Will wrote: > Thanks Marcelo, > > I'll address these items. > > >- Please rebase against queue branch on kvm.git. > > I am not sure how to do this. The repository I have been working against > is: > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/l

Re: [Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option

2012-11-27 Thread Wenchao Xia
于 2012-11-28 10:01, 陳韋任 (Wei-Ren Chen) 写道: On Tue, Nov 27, 2012 at 05:21:03PM +0100, Paolo Bonzini wrote: Some versions of GCC require insane (>2GB) amounts of memory to compile translate.o. As a countermeasure, disable the culprit optimization pass. This should fix the buildbot failure for def

Re: [Qemu-devel] [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support

2012-11-27 Thread Auld, Will
Thanks Marcelo, I'll address these items. >- Please rebase against queue branch on kvm.git. I am not sure how to do this. The repository I have been working against is: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git I assume that I need to change this in some way but I am no

Re: [Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option

2012-11-27 Thread Wei-Ren Chen
On Tue, Nov 27, 2012 at 05:21:03PM +0100, Paolo Bonzini wrote: > Some versions of GCC require insane (>2GB) amounts of memory to compile > translate.o. As a countermeasure, disable the culprit optimization pass. > This should fix the buildbot failure for default_x86_64_fedora16. > Anyway is a good

Re: [Qemu-devel] [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support

2012-11-27 Thread Marcelo Tosatti
Hi Will, On Tue, Nov 27, 2012 at 11:09:00AM -0800, Will Auld wrote: > CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported > > Basic design is to emulate the MSR by allowing reads and writes to a guest > vcpu specific location to store the value of the emulated MSR while adding > t

Re: [Qemu-devel] [PATCH] Resend - Added x86/tsc_adjust.c to test the ia32_tsc_adjust funtionality.

2012-11-27 Thread Marcelo Tosatti
Will, 1. Please check CPUID before using ADJUST_TSC MSR, exit test successfully if CPUID bit disabled. 2. Please test the implementation of ADJUST_TSC MSR (functional test). vmexit.flat test can be used for performance of MSR emulation. Example tsc1 = rdtsc(); wrmsr(IA32_TSC_AD

Re: [Qemu-devel] [RFC PATCH 0/4] MSI affinity for assigned devices

2012-11-27 Thread Alex Williamson
On Wed, 2012-11-28 at 00:08 +0100, Jan Kiszka wrote: > On 2012-11-27 23:00, Alex Williamson wrote: > > This is post-1.3 material, so I'll just post it as an RFC for now. > > > > MSI routing updates aren't currently handled by pci-assign or > > vfio-pci (when using KVM acceleration), which means th

Re: [Qemu-devel] [RFC PATCH 0/4] MSI affinity for assigned devices

2012-11-27 Thread Jan Kiszka
On 2012-11-27 23:00, Alex Williamson wrote: > This is post-1.3 material, so I'll just post it as an RFC for now. > > MSI routing updates aren't currently handled by pci-assign or > vfio-pci (when using KVM acceleration), which means that trying to > set interrupt SMP affinity in the guest has no e

Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-27 Thread Josh Durgin
On 11/22/2012 02:00 AM, Stefan Priebe wrote: This one fixes a race which qemu had also in iscsi block driver between cancellation and io completition. qemu_rbd_aio_cancel was not synchronously waiting for the end of the command. To archieve this it introduces a new status flag which uses -EINPR

[Qemu-devel] [RFC PATCH 1/4] kvm: Stub kvm_irqchip_update_msi_route

2012-11-27 Thread Alex Williamson
Its friends are already stubbed out, add this one too so vfio can call it without wrapping it in #ifdefs. Signed-off-by: Alex Williamson --- kvm-all.c |5 + kvm-stub.c |5 + 2 files changed, 10 insertions(+) diff --git a/kvm-all.c b/kvm-all.c index 3bc3347..93e9f0e 100644 --- a

Re: [Qemu-devel] MIPS exception number limits?

2012-11-27 Thread Johnson, Eric
> -Original Message- > From: Richard Henderson [mailto:rth7...@gmail.com] On Behalf Of Richard > Henderson > Sent: Tuesday, November 27, 2012 1:19 PM > To: Johnson, Eric > Cc: "陳韋任 (Wei-Ren Chen)"; qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] MIPS exception number limits? > > On 11/26

[Qemu-devel] [RFC PATCH 0/4] MSI affinity for assigned devices

2012-11-27 Thread Alex Williamson
This is post-1.3 material, so I'll just post it as an RFC for now. MSI routing updates aren't currently handled by pci-assign or vfio-pci (when using KVM acceleration), which means that trying to set interrupt SMP affinity in the guest has no effect unless MSI is completely disabled and re-enabled

[Qemu-devel] [RFC PATCH 4/4] pci-assign: Add MSI affinity support

2012-11-27 Thread Alex Williamson
Track the last MSIMessage programmed so we can determine when it has changed and update the routing to the guest. We track MSI-X for consistency, but we don't do anything with it here. Signed-off-by: Alex Williamson --- hw/kvm/pci-assign.c | 29 + 1 file changed, 2

Re: [Qemu-devel] MIPS exception number limits?

2012-11-27 Thread Peter Maydell
On 27 November 2012 21:18, Richard Henderson wrote: > On 11/26/2012 09:25 PM, Johnson, Eric wrote: >> So basically the SC and SCD instructions for user-mode QEMU are implemented >> with a "dummy" exception. Since it is not a real exception, it is not >> reported in the QEMU log file as an excep

[Qemu-devel] [RFC PATCH 3/4] pci-assign: Refactor MSI virq array

2012-11-27 Thread Alex Williamson
Convert the msi_virq array into a struct array so we can easily add a place to track the MSIMessage for each vector. Signed-off-by: Alex Williamson --- hw/kvm/pci-assign.c | 51 ++- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/

[Qemu-devel] [RFC PATCH 2/4] vfio-pci: Add support for MSI affinity

2012-11-27 Thread Alex Williamson
When MSI is accelerated through KVM the vectors are only programmed when the guest first enables MSI support. Subsequent writes to the vector address or data fields are ignored. Unfortunately that means we're ignore updates done to adjust SMP affinity of the vectors. MSI SMP affinity already work

Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt among VMs

2012-11-27 Thread Cam Macdonell
On Sat, Nov 24, 2012 at 8:51 PM, Liu Ping Fan wrote: > From: Liu Ping Fan > > Using irqfd, so we can avoid switch between kernel and user when > VMs interrupts each other. Nice work. Due to a hardware failure, there will be a small delay in me being able to test this. I'll follow up as soon as

Re: [Qemu-devel] [PATCH] qapi: fix qapi_dealloc_type_size parameter type

2012-11-27 Thread Stefan Weil
Am 27.11.2012 21:54, schrieb mdroth: On Tue, Nov 27, 2012 at 01:11:25PM -0700, Bruce Rogers wrote: The second parameter to qapi_dealloc_type_size should be a uint64_t *, not a size_t *. This was causing our 32 bit x86 build to fail, since warnings are treated as errors. Signed-off-by: Bruce Rog

Re: [Qemu-devel] MIPS exception number limits?

2012-11-27 Thread Richard Henderson
On 11/26/2012 09:25 PM, Johnson, Eric wrote: > So basically the SC and SCD instructions for user-mode QEMU are implemented > with a "dummy" exception. Since it is not a real exception, it is not > reported in the QEMU log file as an exception. I'm not certain that's a helpful distinction to mak

Re: [Qemu-devel] [PATCH] qapi: fix qapi_dealloc_type_size parameter type

2012-11-27 Thread mdroth
On Tue, Nov 27, 2012 at 01:11:25PM -0700, Bruce Rogers wrote: > The second parameter to qapi_dealloc_type_size should be a uint64_t *, > not a size_t *. This was causing our 32 bit x86 build to fail, since > warnings are treated as errors. > > Signed-off-by: Bruce Rogers Doh, I should've caught

Re: [Qemu-devel] [PATCH V10 2/8] hw/apm.c: replace register_ioport*

2012-11-27 Thread Jason Baron
On Tue, Nov 27, 2012 at 01:10:16AM +0100, Andreas Färber wrote: > Am 19.09.2012 13:50, schrieb Julien Grall: > > This patch replaces all register_ioport* by a MemorySection. > > It permits to use the new Memory stuff like listener. > > > > Moreover, the PCI is added as an argument for apm_init, so

[Qemu-devel] [PATCH] qapi: fix qapi_dealloc_type_size parameter type

2012-11-27 Thread Bruce Rogers
The second parameter to qapi_dealloc_type_size should be a uint64_t *, not a size_t *. This was causing our 32 bit x86 build to fail, since warnings are treated as errors. Signed-off-by: Bruce Rogers --- qapi/qapi-dealloc-visitor.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) dif

[Qemu-devel] [RFC PATCH v3 1/2] virtio-bus : Introduce virtio-bus

2012-11-27 Thread fred . konrad
From: KONRAD Frederic This patch create VirtioBus which is abstract, we can create virtio-x-bus which extends this virtio-bus. The virtio-x-bus need to implement all the methods from the VirtioBusClass. Signed-off-by: KONRAD Frederic --- hw/virtio-bus.c | 118

[Qemu-devel] [RFC PATCH v3 2/2] qbus : add a maximum device.

2012-11-27 Thread fred . konrad
From: KONRAD Frederic Only one device can be connected to virtio-bus. This patch add a field max_dev which is : * the maximum amount of devices connected on the bus ( when * max_dev!=0 ). * have no effect ( when max_dev=0 ). The function qbus_find_recursive is modified : * to ret

[Qemu-devel] [RFC PATCH v3 0/2] Introduce virtio-bus.

2012-11-27 Thread fred . konrad
From: KONRAD Frederic As said on IRC, I send only VirtioBus as old implementation of VirtioPCI is not longer making sense after the changes on VirtioBus. As anthony said, the better way to do this refactoring is : * Introducing a virtio-bus which extends bus-state. * Implementing a vir

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-27 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrote: >> Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced >> a regression in virtio-net performance because it looks >> into the ring aggressively while we really only care >> about a single pac

[Qemu-devel] [PATCH for-1.3] vfio-pci: Fix KVM disabled path

2012-11-27 Thread Alex Williamson
kvm_check_extension() explodes when KVM isn't enabled so we need to first test whether KVM is enabled. Use kvm_irqchip_in_kernel() for this since it matches the test we do before using this result. Signed-off-by: Alex Williamson --- hw/vfio_pci.c |3 ++- 1 file changed, 2 insertions(+), 1 d

[Qemu-devel] [PATCH V5 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support

2012-11-27 Thread Will Auld
CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported Basic design is to emulate the MSR by allowing reads and writes to a guest vcpu specific location to store the value of the emulated MSR while adding the value to the vmcs tsc_offset. In this way the IA32_TSC_ADJUST value will be i

Re: [Qemu-devel] [PATCHv3 2/5] seccomp: setting "-sandbox on" as deafult

2012-11-27 Thread Corey Bryant
On 11/27/2012 02:01 PM, Anthony Liguori wrote: Eduardo Otubo writes: Now the seccomp filter will be set to "on" even if no argument "-sandbox" is given. v3: * Introduced seccomp_states enum and new functions named seccomp_set_state() and seccomp_get_state() (pbonz...@redhat.com

[Qemu-devel] [PATCH V5 1/2] Add code to track call origin for msr assignment.

2012-11-27 Thread Will Auld
In order to track who initiated the call (host or guest) to modify an msr value I have changed function call parameters along the call path. The specific change is to add a struct pointer parameter that points to (index, data, caller) information rather than having this information passed as indivi

[Qemu-devel] [PATCH V5 0/2] Enable guest use of TSC_ADJUST functionality

2012-11-27 Thread Will Auld
With this version (V5) I have gone back the the V3 implementation of emulator_set_msr() but changing the bool to false. Will Auld (2): Add code to track call origin for msr assignment. Enabling IA32_TSC_ADJUST for KVM guest VM support arch/x86/include/asm/cpufeature.h | 1 + arch/x86/inc

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: replay guest open on destination

2012-11-27 Thread Anthony Liguori
Amit Shah writes: > On (Sun) 25 Nov 2012 [15:39:14], Alon Levy wrote: >> When migrating a host with with a spice agent running the mouse becomes >> non operational after the migration due to the agent state being >> inconsistent between the guest and the client if the client is using >> semi-seam

Re: [Qemu-devel] [PATCHv3 2/5] seccomp: setting "-sandbox on" as deafult

2012-11-27 Thread Anthony Liguori
Eduardo Otubo writes: > Now the seccomp filter will be set to "on" even if no argument > "-sandbox" is given. > > v3: * Introduced seccomp_states enum and new functions named > seccomp_set_state() and seccomp_get_state() > (pbonz...@redhat.com). > * Merged seccomp_start() and insta

[Qemu-devel] [PATCH v2] cocoa: Fix VBE function Set Display Start

2012-11-27 Thread Henry Harrington
Register a dpy_gfx_setdata callback so that the Cocoa code is notified whenever the screen start address changes. Commit 1d3323d has a similar fix for the VNC UI. Signed-off-by: Henry Harrington --- ui/cocoa.m | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff

Re: [Qemu-devel] [PATCH] cocoa: Fix VBE function Set Display Start

2012-11-27 Thread Henry Harrington
On Tue, Nov 27, 2012 at 5:03 AM, Andreas Färber wrote: > Am 21.11.2012 20:08, schrieb Henry Harrington: > Apart from the style issues above (you can use scripts/checkpatch.pl to > verify) this looks okay. Unfortunately I am not getting pixman built on > OSX so am still unable to test... Thanks, I

Re: [Qemu-devel] [PATCH V4 1/2] Add code to track call origin for msr assignment.

2012-11-27 Thread Gleb Natapov
On Tue, Nov 27, 2012 at 06:19:21PM +, Auld, Will wrote: > Gleb, > > This last change to emulator_set_msr() was wrong as you point out. I will > change it back to what it was in V3 with the exception of fixing the bool > that Marcelo pointed out. > > However, the change of: > > struct kvm_

Re: [Qemu-devel] [PATCH V4 1/2] Add code to track call origin for msr assignment.

2012-11-27 Thread Auld, Will
Gleb, This last change to emulator_set_msr() was wrong as you point out. I will change it back to what it was in V3 with the exception of fixing the bool that Marcelo pointed out. However, the change of: struct kvm_x86_ops {... int (*set_msr)(struct kvm_vcpu *vcpu, struct msr_data *ms

Re: [Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option

2012-11-27 Thread Stefan Weil
Am 27.11.2012 17:30, schrieb Paolo Bonzini: Il 27/11/2012 17:24, Alexander Graf ha scritto: +# Workaround for http://gcc.gnu.org/PR55489. Happens with -fPIE/-fPIC +# and large functions that use global variables. The bug is in all +# releases of GCC, but it became particularly acute in 4.7.x.

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Markus Armbruster
Avi Kivity writes: > On 11/27/2012 10:34 AM, Paolo Bonzini wrote: >> Some versions of GCC require insane (>2GB) amounts of memory >> to compile translate.o. As a countermeasure, compile it >> with -O1. This should fix the buildbot failure for >> default_x86_64_fedora16. >> >> Signed-off-by: Pa

Re: [Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 17:24, Alexander Graf ha scritto: >> >> +# Workaround for http://gcc.gnu.org/PR55489. Happens with -fPIE/-fPIC >> +# and large functions that use global variables. The bug is in all >> +# releases of GCC, but it became particularly acute in 4.7.x. We >> +# should be able to delete

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] Make default boot order machine specific

2012-11-27 Thread Avik Sil
On 11/23/2012 10:22 PM, Alexander Graf wrote: > > On 05.11.2012, at 12:34, Avik Sil wrote: > >> On 10/26/2012 05:15 PM, Alexander Graf wrote: >>> >>> On 25.10.2012, at 22:57, Alexander Graf wrote: >>> On 25.10.2012, at 22:50, Peter Maydell wrote: > On 25 October 2012 21:18, An

Re: [Qemu-devel] [PATCH v2] s390: clear registers, psw and prefix at vcpu reset

2012-11-27 Thread Alexander Graf
On 11/27/2012 06:13 PM, Jens Freimann wrote: On Tue, Nov 27, 2012 at 10:37:25AM +0100, Alexander Graf wrote: On 27.11.2012, at 09:33, Jens Freimann wrote: When resetting vcpus on s390/kvm we have to clear registers, psw and prefix as described in the z/Architecture PoP, otherwise a reboot wo

Re: [Qemu-devel] [PATCH v2] s390: clear registers, psw and prefix at vcpu reset

2012-11-27 Thread Jens Freimann
On Tue, Nov 27, 2012 at 10:37:25AM +0100, Alexander Graf wrote: > > > On 27.11.2012, at 09:33, Jens Freimann wrote: > > > When resetting vcpus on s390/kvm we have to clear registers, psw > > and prefix as described in the z/Architecture PoP, otherwise a > > reboot won't work. IPL PSW and prefix

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 17:49, Markus Armbruster ha scritto: >>> +%/translate.o: CFLAGS := $(patsubst -O2,-O1,$(CFLAGS)) >>> + >> >> This may change some string argument in CFLAGS, for example an argument >> to -I. >> >> How about: >> >> CFLAGS_opt = -O2 >> CFLAGS += $(CFLAGS_opt) >> ... >> %/transla

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-27 Thread Edivaldo de Araujo Pereira
Dear friends, Please excuse-me for not reporting earlier... I confirm that the patch by Michael really fixes the problem I've reported. The regression has gone away when I used it, so I think it is good to be applied. Thanks, Edivaldo de Araújo Pereira --- Em ter, 27/11/12, Michael S. Tsirk

Re: [Qemu-devel] [PATCHv3 1/5] seccomp: adding new syscalls (bugzilla 855162)

2012-11-27 Thread Paul Moore
On Tuesday, November 27, 2012 11:11:32 AM Corey Bryant wrote: > Thanks for the additional details. They were very useful. I was able > to reproduce this when I manually built spice release 0.10.1, but not > with the Fedora 0.10.1 package. One difference I noticed is that the > Fedora version was

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Andreas Färber
Am 27.11.2012 14:49, schrieb 陳韋任 (Wei-Ren Chen): > On Tue, Nov 27, 2012 at 02:45:07PM +0100, Gerd Hoffmann wrote: >> On 11/27/12 14:24, Peter Maydell wrote: >>> On 27 November 2012 08:34, Paolo Bonzini wrote: Some versions of GCC require insane (>2GB) amounts of memory to compile transla

Re: [Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option

2012-11-27 Thread Alexander Graf
On 11/27/2012 05:21 PM, Paolo Bonzini wrote: Some versions of GCC require insane (>2GB) amounts of memory to compile translate.o. As a countermeasure, disable the culprit optimization pass. This should fix the buildbot failure for default_x86_64_fedora16. Anyway is a good thing to do because peo

Re: [Qemu-devel] [PATCH] virtio: limit avail bytes lookahead

2012-11-27 Thread Michael S. Tsirkin
On Thu, Nov 01, 2012 at 06:07:21PM +0200, Michael S. Tsirkin wrote: > Commit 0d8d7690850eb0cf2b2b60933cf47669a6b6f18f introduced > a regression in virtio-net performance because it looks > into the ring aggressively while we really only care > about a single packet worth of buffers. > To fix, add p

[Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option

2012-11-27 Thread Paolo Bonzini
Some versions of GCC require insane (>2GB) amounts of memory to compile translate.o. As a countermeasure, disable the culprit optimization pass. This should fix the buildbot failure for default_x86_64_fedora16. Anyway is a good thing to do because people will try to compile 1.3 with less than 2GB

Re: [Qemu-devel] [PATCHv3 1/5] seccomp: adding new syscalls (bugzilla 855162)

2012-11-27 Thread Corey Bryant
On 11/26/2012 04:48 PM, Paul Moore wrote: On Monday, November 26, 2012 03:41:00 PM Paul Moore wrote: On Monday, November 26, 2012 02:59:21 PM Corey Bryant wrote: On 11/26/2012 12:08 PM, Paul Moore wrote: On Monday, November 26, 2012 11:41:06 AM Corey Bryant wrote: On 11/21/2012 10:24 AM, Paul

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 16:53, Avi Kivity ha scritto: > This may change some string argument in CFLAGS, for example an argument > to -I. > > How about: > > CFLAGS_opt = -O2 > CFLAGS += $(CFLAGS_opt) > ... > %/translate.o: CFLAGS_opt = -O1 Not possible because CFLAGS comes from configure, but anywa

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Avi Kivity
On 11/27/2012 10:34 AM, Paolo Bonzini wrote: > Some versions of GCC require insane (>2GB) amounts of memory > to compile translate.o. As a countermeasure, compile it > with -O1. This should fix the buildbot failure for > default_x86_64_fedora16. > > Signed-off-by: Paolo Bonzini > --- > Makefil

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 14:49, 陳韋任 (Wei-Ren Chen) ha scritto: >> > It isn't that simple. It's Fedora 17 with gcc 4.7.2 which runs oom >> > while compiling translate.c > Even apply Peter's suggestion? Do all gcc 4.7.2 on various platform > have the same problem, or it only happen on Fedora 17. All. It is

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: replay guest open on destination

2012-11-27 Thread Amit Shah
On (Tue) 27 Nov 2012 [15:10:06], Markus Armbruster wrote: > Amit Shah writes: > > Adding Gerd and Markus as I think they were involved in the discussion > > last time as well. > > Got a pointer to the old thread? https://lists.nongnu.org/archive/html/qemu-devel/2011-07/msg02986.html I didn't g

Re: [Qemu-devel] net: RFC New Socket-Based, Switched Network Backend (QDES)

2012-11-27 Thread Anthony Liguori
Stefan Hajnoczi writes: > On Mon, Nov 26, 2012 at 6:19 PM, Mike Lovell wrote: >> i think it does still make sense to implement it in QEMU. there isn't a >> problem with multiple processes using the same multicast address. the >> net_socket_mcast_create function in socket.c already sets the >> IP

Re: [Qemu-devel] KVM call agenda for 2012-11-27

2012-11-27 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda topics you are interested in. As there are no topic's call is cancelled. Have a nice day, Juan.

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 14:46, Peter Maydell ha scritto: > On 27 November 2012 13:45, Gerd Hoffmann wrote: >> On 11/27/12 14:24, Peter Maydell wrote: >>> This is a well known bug in old gcc (ie fixed in 4.5, 4.6 and >>> trunk a year ago). Use a newer gcc, or a 64 bit build system >>> with a reasonable amoun

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: replay guest open on destination

2012-11-27 Thread Markus Armbruster
Amit Shah writes: > On (Sun) 25 Nov 2012 [15:39:14], Alon Levy wrote: >> When migrating a host with with a spice agent running the mouse becomes >> non operational after the migration due to the agent state being >> inconsistent between the guest and the client if the client is using >> semi-seam

[Qemu-devel] [PATCH 09/10] qemu-ga: bios_supports_mode(): improve error reporting

2012-11-27 Thread Luiz Capitulino
Most errors are QERR_UNDEFINED_ERROR today. Signed-off-by: Luiz Capitulino --- qga/commands-posix.c | 46 +++--- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index c399f02..5a7e308 100644 --- a

[Qemu-devel] [PATCH 06/10] qemu-ga: qmp_guest_fsfreeze_*(): get rid of sprintf() + error_set()

2012-11-27 Thread Luiz Capitulino
Convert them to error_setg_errno(). Signed-off-by: Luiz Capitulino --- qga/commands-posix.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 59bb32d..9325433 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix

[Qemu-devel] [PATCH 05/10] qemu-ga: build_fs_mount_list(): take an Error argument

2012-11-27 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qga/commands-posix.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index b3a3f26..59bb32d 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -371,7 +3

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Wei-Ren Chen
On Tue, Nov 27, 2012 at 02:45:07PM +0100, Gerd Hoffmann wrote: > On 11/27/12 14:24, Peter Maydell wrote: > > On 27 November 2012 08:34, Paolo Bonzini wrote: > >> Some versions of GCC require insane (>2GB) amounts of memory > >> to compile translate.o. As a countermeasure, compile it > >> with -O1

[Qemu-devel] [PATCH 03/10] qemu-ga: qmp_guest_file_*: improve error reporting

2012-11-27 Thread Luiz Capitulino
Use error_setg_errno() when possible with an improved error description. Signed-off-by: Luiz Capitulino --- qga/commands-posix.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index c284083..92fc550 100644 -

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Peter Maydell
On 27 November 2012 13:45, Gerd Hoffmann wrote: > On 11/27/12 14:24, Peter Maydell wrote: >> This is a well known bug in old gcc (ie fixed in 4.5, 4.6 and >> trunk a year ago). Use a newer gcc, or a 64 bit build system >> with a reasonable amount of RAM, or as a workaround apply some >> suitable c

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Gerd Hoffmann
On 11/27/12 14:24, Peter Maydell wrote: > On 27 November 2012 08:34, Paolo Bonzini wrote: >> Some versions of GCC require insane (>2GB) amounts of memory >> to compile translate.o. As a countermeasure, compile it >> with -O1. This should fix the buildbot failure for >> default_x86_64_fedora16. >

[Qemu-devel] [PATCH 01/10] qemu-ga: guest_file_handle_find(): take an Error argument

2012-11-27 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qga/commands-posix.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 726930a..a2216f2 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -111,7 +111,7 @@ stati

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Peter Maydell
On 27 November 2012 08:34, Paolo Bonzini wrote: > Some versions of GCC require insane (>2GB) amounts of memory > to compile translate.o. As a countermeasure, compile it > with -O1. This should fix the buildbot failure for > default_x86_64_fedora16. This is a well known bug in old gcc (ie fixed

[Qemu-devel] [PATCH 07/10] qemu-ga: qmp_guest_fstrim(): get rid of sprintf() + error_set()

2012-11-27 Thread Luiz Capitulino
Convert them to error_setg_errno(). Signed-off-by: Luiz Capitulino --- qga/commands-posix.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 9325433..72ef8ba 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix

Re: [Qemu-devel] [PATCH] usb: fail usbdevice_create() when there is no USB bus

2012-11-27 Thread Gerd Hoffmann
On 11/25/12 16:49, Stefan Hajnoczi wrote: > Report an error instead of segfaulting when attaching a USB device to a > machine with no USB busses: > > $ qemu-system-arm -machine vexpress-a9 \ > -sd Fedora-17-armhfp-vexpress-mmcblk0.img \ > -kernel vmlinuz-3.4.2-3.fc17.armv7hl \ >

[Qemu-devel] [PATCH 10/10] qemu-ga: guest_suspend(): improve error reporting

2012-11-27 Thread Luiz Capitulino
Most errors are QERR_UNDEFINED_ERROR today. Signed-off-by: Luiz Capitulino --- qga/commands-posix.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 5a7e308..ce058b5 100644 --- a/qga/commands-pos

[Qemu-devel] [PATCH 08/10] qemu-ga: qmp_guest_network_get_interfaces(): get rid of snprintf() + error_set()

2012-11-27 Thread Luiz Capitulino
Convert them to error_setg_errno(). Signed-off-by: Luiz Capitulino --- qga/commands-posix.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 72ef8ba..c399f02 100644 --- a/qga/commands-posix.c +++

[Qemu-devel] [PATCH 02/10] qemu-ga: qmp_guest_file_close(): fix fclose() error check

2012-11-27 Thread Luiz Capitulino
fclose() returns EOF on error. Signed-off-by: Luiz Capitulino --- qga/commands-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index a2216f2..c284083 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -170,7 +17

[Qemu-devel] [PATCH 04/10] qemu-ga: qmp_guest_shutdown(): improve error reporting

2012-11-27 Thread Luiz Capitulino
Most errors are QERR_UNDEFINED_ERROR. Also, adds ga_wait_child() as a future commit will use it too. Signed-off-by: Luiz Capitulino --- qga/commands-posix.c | 48 ++-- 1 file changed, 38 insertions(+), 10 deletions(-) diff --git a/qga/commands-posix.c

[Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4)

2012-11-27 Thread Luiz Capitulino
This series revamps qemu-ga error messages by: - Propagating errors down to functions that generate errors - Fixing UndefinedErrors - Getting rid of sprint() + error_set() - Other small fixes Only the POSIX port is covered in this series, win32 is left to another day. Luiz Capitulino (10):

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: replay guest open on destination

2012-11-27 Thread Amit Shah
On (Sun) 25 Nov 2012 [15:39:14], Alon Levy wrote: > When migrating a host with with a spice agent running the mouse becomes > non operational after the migration due to the agent state being > inconsistent between the guest and the client if the client is using > semi-seamless or switch host migrat

Re: [Qemu-devel] net: RFC New Socket-Based, Switched Network Backend (QDES)

2012-11-27 Thread Stefan Hajnoczi
On Mon, Nov 26, 2012 at 6:19 PM, Mike Lovell wrote: > i think it does still make sense to implement it in QEMU. there isn't a > problem with multiple processes using the same multicast address. the > net_socket_mcast_create function in socket.c already sets the > IP_MULTICAST_LOOP option which mak

Re: [Qemu-devel] [0/2] pseries: Rework PCI code for handling multiple PHBs

2012-11-27 Thread Michael S. Tsirkin
On Tue, Nov 27, 2012 at 05:07:31PM +1100, David Gibson wrote: > Hi Michael, Alex, > > This patch represents a compromise I hope will be acceptable after the > long thread discussing handling of multiple PCI host bridges on the > pseries machine. Patch 1/1 is just a preliminary enforcing uniquenes

[Qemu-devel] [PATCH] pixman: require 0.18.4 or newer

2012-11-27 Thread Gerd Hoffmann
When older versions are found the internal pixman version is prefered. Signed-off-by: Gerd Hoffmann --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 780b19a..1a3458f 100755 --- a/configure +++ b/configure @@ -2103,7 +2103,7 @@

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Gerd Hoffmann
Hi, > Note that there is probably one or two GCC options that can be > fine-tuned to avoid the explosion instead of just -O1 vs. -O2. If you > have an affected machine (F18) you can help by compiling translate.c > with -O2 -ftime-report. I planned to do this today, but I first need to > instal

Re: [Qemu-devel] [PATCH] coroutine-sigaltstack.c: Use stack_t, not struct sigaltstack

2012-11-27 Thread Kevin Wolf
Am 12.11.2012 13:57, schrieb Stefan Hajnoczi: > On Sat, Nov 10, 2012 at 10:47 PM, Peter Maydell > wrote: >> Use the POSIX-specified stack_t type as the argument to sigaltstack() >> rather than the legacy struct sigaltstack. This allows us to compile >> on MacOSX with --with-coroutine=sigaltstack.

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-27 Thread Dietmar Maurer
> Just want to confirm something to understand it better: > you are backing up the block image not including VM memory state right? I > am considering a way to do live Savevm including memory and device state, > so wonder if you already had a solution for it. Yes, I have already code for that.

[Qemu-devel] [PATCH v2 14/18] apci: switch piix4 gpe to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/acpi_piix4.c | 24 ++-- 1 files changed, 18 insertions(+), 6 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index b1d5bf3..c1a58d3 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -57,6 +57,7 @@ struct pci_status { type

[Qemu-devel] [PATCH v2 18/18] acpi: drop debug port

2012-11-27 Thread Gerd Hoffmann
I'm pretty sure this isn't needed any more. I think this predates the switch to seabios, and the seabios DSDT table has a DBUG() aml macro which writes stuff to the seabios debug port (0x402). Signed-off-by: Gerd Hoffmann --- hw/acpi_piix4.c |9 - 1 files changed, 0 insertions(+), 9

[Qemu-devel] [PATCH v2 08/18] acpi: cleanup vt82c686 memory region

2012-11-27 Thread Gerd Hoffmann
Nothing left to do, everything handled by subregions, we can zap the reaw/write handlers now. Signed-off-by: Gerd Hoffmann --- hw/vt82c686.c | 61 + 1 files changed, 1 insertions(+), 60 deletions(-) diff --git a/hw/vt82c686.c b/hw/vt82c6

[Qemu-devel] [PATCH v2 00/18] acpi: switch to memory api

2012-11-27 Thread Gerd Hoffmann
Hi, While wading through the qemu acpi and seabios aml code I've figured the qemu acpi codebase is *way* too messy. So this patch series switches the apci code to the memory api. That alone cleans up quite a bit and makes the code in hw/acpi.c more self-contained. As bonus everything shows up

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-27 Thread Dietmar Maurer
> >>> The only solution I came up with is to add before/after hooks in the > >>> block job. I agree with the criticism, but I think it's general > >>> enough and at the same time easy enough to implement. Ok, here is another try - do you think that is better? Note: This code is not tested - I ju

[Qemu-devel] [PATCH v2 10/18] apci: switch ich9 smi to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/acpi_ich9.c | 46 -- hw/acpi_ich9.h |1 + 2 files changed, 37 insertions(+), 10 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index 5fc160a..0ed17da 100644 --- a/hw/acpi_ich9.c +++ b/hw/acpi_ich9.c

[Qemu-devel] [PATCH v2 03/18] apci: switch vt82c686 to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/vt82c686.c | 37 +++-- 1 files changed, 27 insertions(+), 10 deletions(-) diff --git a/hw/vt82c686.c b/hw/vt82c686.c index 5d7c00c..3fc6063 100644 --- a/hw/vt82c686.c +++ b/hw/vt82c686.c @@ -24,6 +24,7 @@ #include "pm_smbus.h

[Qemu-devel] [PATCH v2 16/18] apci: switch piix4 pci hotplug to memory api

2012-11-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/acpi_piix4.c | 37 + 1 files changed, 29 insertions(+), 8 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index d2ba56e..263338a 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -42,6 +42,9 @@ #define G

  1   2   >