Il 21/12/2012 01:27, Anthony Liguori ha scritto:
Juan Quintela quint...@redhat.com writes:
Hi
Changes for yesterday:
- Paolo Acked the series
- Rebaso on top of today git (only conflicts were due to header re-shuffle)
Please pull.
[20121219]
This is my queue for
On 12/20/12 17:19, Scott Wood wrote:
On 12/20/2012 12:59:05 AM, Gerd Hoffmann wrote:
Hi,
Why do you need this? Any tools not picked up correctly if you don't
set the PATH? Which ones?
If I don't set the PATH for configure then I get this:
ERROR: powerpc-linux-gnu-gcc either does
To fix building error:
CCnet/vde.o
net/vde.c: In function ‘vde_cleanup’:
net/vde.c:65:5: error: implicit declaration of function ‘qemu_set_fd_handler’
[-Werror=implicit-function-declaration]
net/vde.c:65:5: error: nested extern declaration of ‘qemu_set_fd_handler’
[-Werror=nested-externs]
Hi,
pty looks like another non-trivial challenge. How does libvirt gather
the pty device today? IIRC there is some stderr parsing? Or was it
info chardev? With QMP we probably want switch to a more sane model
here ...
Yes, these days we use info chardev, or query-chardev as
On Fri, Dec 21, 2012 at 10:01:46AM +0100, Gerd Hoffmann wrote:
Hi,
pty looks like another non-trivial challenge. How does libvirt gather
the pty device today? IIRC there is some stderr parsing? Or was it
info chardev? With QMP we probably want switch to a more sane model
here ...
Hi list,
I'm trying to pass hyper-v feature, with -cpu qemu64,+hv_relaxed (qemu 1.3)
but I got an
CPU feature hv_relaxed not found
Does this require an specific host kernel or host cpu feature support ?
Regards,
Alexandre Derumier
On Fri, Dec 21, 2012 at 9:56 AM, Gerd Hoffmann kra...@redhat.com wrote:
I mean with --cross-prefix specifying the absolute location (so you
don't have to mess with PATH), why does that not work?
He actually wrote already previously: The name is thrown into
config.sub, which obviously is
On 12/20/12 14:02, Gerd Hoffmann wrote:
Hi,
/me wades through the socket code (unix+tcp) right now, which needs some
refactoring to make it fly.
Sneak preview attached. Goes on top of the series.
Compile tested only so far.
Now that it comes to testing: how does the union look (in
Il 21/12/2012 12:45, Gerd Hoffmann ha scritto:
On 12/20/12 14:02, Gerd Hoffmann wrote:
Hi,
/me wades through the socket code (unix+tcp) right now, which needs some
refactoring to make it fly.
Sneak preview attached. Goes on top of the series.
Compile tested only so far.
Now that it
On Thu, Dec 20, 2012 at 03:15:38PM -0700, Alex Williamson wrote:
On Thu, 2012-12-20 at 18:38 +0200, Michael S. Tsirkin wrote:
On Thu, Dec 20, 2012 at 09:05:50AM -0700, Alex Williamson wrote:
When a guest enables MSIX on a device we evaluate the MSIX vector
table, typically find no
On 12/21/12 12:53, Paolo Bonzini wrote:
Il 21/12/2012 12:45, Gerd Hoffmann ha scritto:
On 12/20/12 14:02, Gerd Hoffmann wrote:
Hi,
/me wades through the socket code (unix+tcp) right now, which needs some
refactoring to make it fly.
Sneak preview attached. Goes on top of the series.
On Thu, Dec 20, 2012 at 03:12:46PM -0700, Alex Williamson wrote:
On Thu, 2012-12-20 at 18:36 +0200, Michael S. Tsirkin wrote:
On Thu, Dec 20, 2012 at 09:06:41AM -0700, Alex Williamson wrote:
Guests typically enable MSI-X with all of the vectors in the MSI-X
vector table masked. Only when
Juan Quintela quint...@redhat.com wrote:
Anthony Liguori anth...@codemonkey.ws wrote:
Juan Quintela quint...@redhat.com writes:
Hi
Changes for yesterday:
- Paolo Acked the series
- Rebaso on top of today git (only conflicts were due to header re-shuffle)
Please pull.
[20121219]
This
Il 21/12/2012 02:39, Juan Quintela ha scritto:
I can't bisect tonight but can attempt to tomorrow. How has this been
tested?
I have tested with tcp, load/not-load with guests form 4GB to 16GB RAM.
Will test tomorrow with your test case. I didn't tested exec:, though.
I'm a little
Il 21/12/2012 13:17, Gerd Hoffmann ha scritto:
{ 'type': 'ChardevDummy', 'data': { } }
{ 'union': 'ChardevBackend', 'data': { 'file' : 'ChardevFile',
'port' : 'ChardevPort',
'socket' : 'ChardevSocket',
Nowadays only basic information is reported. However, with the
current implementation much more can be exposed to users. like
broadcast/destination address (the former in case of standard
ethernet device, the latter in case of PPP interface), if the
interface is up, of type loopback, in promisc
Hi,
yum repository with fresh qemu firmware builds is available now:
http://www.kraxel.org/repos/
Provides rpms with seabios, tianocore (efi), coreboot and ipxe binaries.
enjoy,
Gerd
PS: /me will disappear into xmas season shortly, so any issues will
have to wait 'til next year.
Paolo Bonzini pbonz...@redhat.com wrote:
Il 21/12/2012 02:39, Juan Quintela ha scritto:
I can't bisect tonight but can attempt to tomorrow. How has this been
tested?
I have tested with tcp, load/not-load with guests form 4GB to 16GB RAM.
Will test tomorrow with your test case. I didn't
Juan Quintela quint...@redhat.com writes:
Juan Quintela quint...@redhat.com wrote:
Anthony Liguori anth...@codemonkey.ws wrote:
Juan Quintela quint...@redhat.com writes:
Hi
Changes for yesterday:
- Paolo Acked the series
- Rebaso on top of today git (only conflicts were due to header
Paolo Bonzini pbonz...@redhat.com writes:
Il 21/12/2012 02:39, Juan Quintela ha scritto:
I can't bisect tonight but can attempt to tomorrow. How has this been
tested?
I have tested with tcp, load/not-load with guests form 4GB to 16GB RAM.
Will test tomorrow with your test case. I didn't
Il 21/12/2012 14:39, Anthony Liguori ha scritto:
Do you think this would cause the behavior I've seen? Not clear to me.
No idea, the first two hunks however are locking fixes, who knows what
they might cause.
Paolo
On Fri, Dec 21, 2012 at 01:56:56AM +0100, Igor Mammedov wrote:
[...]
All above said, I am not strongly against your approach, but I believe
we could try to make the feature string parsing code generic and
reusable (with target-specific properties or callbacks), instead of
having to write a
Lluís Vilanova vilan...@ac.upc.edu writes:
This interface decouples event obtention from interaction.
Are you sure obtention is a word? :)
Events can be obtained through three different methods:
* identifier
* name
* simple wildcard pattern
From: Jason J. Herne jjhe...@us.ibm.com
It makes sense to rename these to KVM_REGSYNC in order to use them for
specifying a register level parameter for both kvm_arch_put_registers
and kvm_arch_get_registers.
Signed-off-by: Jason J. Herne jjhe...@us.ibm.com
Reviewed-by: Christian Borntraeger
From: Jason J. Herne jjhe...@us.ibm.com
Modify kvm_arch_get_registers interface such that it expects a register level
parameter. Also modify the only caller of kvm_arch_get_registers such that it
passes an appropriate level. The idea here is that, for all currently
existing calls we want to do
Note: This is rework for the patch set previously submitted:
s390/migration: Provide a cpu save for initial life migration work
http://lists.nongnu.org/archive/html/qemu-devel/2012-11/msg02203.html
Rework the method used to synchronize CPU registers between Qemu
KVM. This patch set extends
From: Jason J. Herne jjhe...@us.ibm.com
do_kvm_cpu_synchronize_state is called via run_on_cpu, so we can only pass
a single argument. Create SyncStateArgs struct for this purpose and add
register level data member to it.
Signed-off-by: Jason J. Herne jjhe...@us.ibm.com
Reviewed-by: Christian
From: Jason J. Herne jjhe...@us.ibm.com
Some S390 code paths do not need to synchronize the full register state.
This patch changes those paths to only synchronize the runtime register set.
Signed-off-by: Jason J. Herne jjhe...@us.ibm.com
Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com
From: Jason J. Herne jjhe...@us.ibm.com
kvm_cpu_synchronize_state is updated to take/propagate the register level
parameter. All callers are modified to specify the runtime state.
Signed-off-by: Jason J. Herne jjhe...@us.ibm.com
Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com
---
From: Jason J. Herne jjhe...@us.ibm.com
cpu_synchronize_state is updated to take/propagate the register level
parameter. All callers are modified to specify the runtime state.
Signed-off-by: Jason J. Herne jjhe...@us.ibm.com
Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com
---
cpus.c
Wenchao Xia xiaw...@linux.vnet.ibm.com writes:
This patch change all info call back function to take
additional QDict * parameter, which allow those command
take parameter.
[...]
diff --git a/monitor.c b/monitor.c
index c0e32d6..797680f 100644
--- a/monitor.c
+++ b/monitor.c
@@ -123,7
From: Jason J. Herne jjhe...@us.ibm.com
Modify syncing algorithm in do_kvm_cpu_synchronize_state to avoid
overwriting previously synced register data by calling
do_kvm_cpu_synchronize_state twice.
The problem occurs if the following sequence of events occurs:
1. kvm_arch_get_registers(env,
Wenchao Xia xiaw...@linux.vnet.ibm.com writes:
This patch add an option to show snapshots on a single block
device, so some snapshot do not exist on other block device
could be shown.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
monitor.c |6 +++---
savevm.c | 55
Anthony Liguori anth...@codemonkey.ws writes:
Juan Quintela quint...@redhat.com writes:
Hi
Changes for yesterday:
- Paolo Acked the series
- Rebaso on top of today git (only conflicts were due to header re-shuffle)
Please pull.
[20121219]
This is my queue for migration-thread and
Hi,
... and can't see what is wrong there ...
Me neither, but this quick test seems to work here:
Test works for me too.
Bug turned out to be elsewhere: args_type in qmp-commands.hx not set
correctly ...
cheers,
Gerd
Il 21/12/2012 01:27, Anthony Liguori ha scritto:
#!/bin/sh
gzip -d -c lidb.ssmall.img.gz | \
~/build/qemu/x86_64-softmmu/qemu-system-x86_64 -cdrom \
~/isos/OCDC-lucid-Test-Drive-20110523_140333.iso -enable-kvm -m 2G \
-incoming exec:dd
With lidb.ssmall.img.gz being generated
Hi all
If I already have an emulator, all instructions have been carried out.
In order to reuse these codes on the other simulation platforms, as Simics,
QEMU, SystemC. So, I want to
skip over QEMU's TCG(guest binary--IR--host binary). Just let QEMU
controll the cpu's execution and the cpu
Luiz Capitulino lcapitul...@redhat.com writes:
On Wed, 19 Dec 2012 18:17:09 +0800
Wenchao Xia xiaw...@linux.vnet.ibm.com wrote:
This patch enable sub info command handler getting meaningful
parameter.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
hmp-commands.hx |2 +-
On Fri, 2012-12-21 at 14:21 +0200, Michael S. Tsirkin wrote:
On Thu, Dec 20, 2012 at 03:12:46PM -0700, Alex Williamson wrote:
On Thu, 2012-12-20 at 18:36 +0200, Michael S. Tsirkin wrote:
On Thu, Dec 20, 2012 at 09:06:41AM -0700, Alex Williamson wrote:
Guests typically enable MSI-X with
On Fri, 2012-12-21 at 14:17 +0200, Michael S. Tsirkin wrote:
On Thu, Dec 20, 2012 at 03:15:38PM -0700, Alex Williamson wrote:
On Thu, 2012-12-20 at 18:38 +0200, Michael S. Tsirkin wrote:
On Thu, Dec 20, 2012 at 09:05:50AM -0700, Alex Williamson wrote:
When a guest enables MSIX on a
Here is a light version of the source reorganization I proposed last
September. While working on it I noticed that a useful part to start
from was the utility routines, because this helps identifying missing
unit tests and modularity problems. Also, this file are relatively
rarely changed.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
libcacard/Makefile |2 +-
rules.mak |3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index c26aac6..9fa109f 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/iscsi.c | 27 ++
blockdev.c | 118
fsdev/Makefile.objs|1 +
fsdev/qemu-fsdev-dummy.c |7 -
fsdev/qemu-fsdev-opts.c| 85 ++
fsdev/qemu-fsdev.c |8 -
This prepares the creation of libqemuutil.a in the next patch.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile|4 ++--
Makefile.objs | 10 +-
Makefile.target |4 ++--
tests/Makefile |2 +-
4 files changed, 10 insertions(+), 10 deletions(-)
diff
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile.objs | 12 ++--
libcacard/Makefile |6 +++---
util/Makefile.objs | 10 ++
acl.c = util/acl.c
We will grow the list of files in the next patches, but libcacard
should remain slim.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
libcacard/Makefile |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index
There is no reason for it to be in block-obj-y, in particular.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile |2 +-
Makefile.objs |3 +--
rules.mak |4 ++--
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile
index
The directory descent mechanism, and a less-flat tree both helped
in making some *-obj-y definitions very short. Many of these
often end up in universal-obj-y, and used to be separate only
because of libuser (which is now part of history...).
Consolidate these variables in a single one.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile |2 +-
Makefile.objs |9 ++---
qapi/Makefile.objs |8
tests/Makefile |3 +--
4 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/Makefile b/Makefile
index a1e9fe0..06b3ad5
From: Lluís Vilanova vilan...@ac.upc.edu
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
.gitignore |8 ++--
Makefile| 15 +---
Makefile.objs | 57
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile |2 +-
Makefile.objs | 17 +++--
qobject/Makefile.objs |3 +++
json-lexer.c = qobject/json-lexer.c |0
json-parser.c =
Mention the directory in which the .stp file is being generated.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile.target |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile.target b/Makefile.target
index 9cbe6fe..2c28f54 100644
--- a/Makefile.target
Just fold it into block-obj-y.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile.objs | 29 +
1 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/Makefile.objs b/Makefile.objs
index 60da50e..9713538 100644
--- a/Makefile.objs
+++
This patch moves the complication of using libtool to the generic
rules.mak file.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
configure |8 +++-
libcacard/Makefile | 11 +++
rules.mak | 10 --
3 files changed, 22 insertions(+), 7
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile |2 +-
Makefile.objs |3 +-
exec.c |2 +-
qemu-tool.c| 115
qemu-user.c| 37 --
Do not fail at build time, instead just disable the library if libtool
is not present.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile |2 ++
configure |3 ++-
libcacard/Makefile |8
rules.mak |6 +-
4 files changed, 5
Use a static library to eliminate repetition in the linking rules.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile| 17 +
Makefile.objs |1 -
Makefile.target |8
tests/Makefile | 17 -
4 files changed, 21
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile.objs |8
rules.mak |9 +
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/Makefile.objs b/Makefile.objs
index 346bf9d..7858c4e 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -169,14 +169,6
From: Alon Levy al...@redhat.com
Before patch:
$ make libcacard.la
$ nm ./libcacard/.libs/libcacard.so.0.0.0 | grep U | \
egrep -v (g_)|(GLIBC)|(SECMOD)|(PK11)|(CERT)|(NSS)|(PORT)|(PR)
U error_set
Signed-off-by: Alon Levy al...@redhat.com
Signed-off-by: Paolo Bonzini
There is no reason why for example qemu-ga should include all the
definitions for the QEMU monitor. However, there are a few
that are needed (qapi_free_SocketAddress, qapi_free_InetSocketAddress,
ErrorClass_lookup). These should be moved to a separate core
.json schema that goes into
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile | 35 +--
configure |9 +
libcacard/Makefile | 33 +
3 files changed, 19 insertions(+), 58 deletions(-)
diff --git a/Makefile
Split them between libqemuutil.a and, for those used by qemu-img/io/nbd,
block-obj-y.
Static libraries ensure that binaries such as qemu-ga do not include
unused modules.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile | 10 +++---
Makefile.objs | 39
Do not export internal QEMU symbols.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
libcacard/Makefile |3 +-
libcacard/libcacard.syms | 77 ++
2 files changed, 79 insertions(+), 1 deletions(-)
create mode 100644
The passthru smartcard does not have the shared library dependency, build
it unconditionally.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
configure| 67 ++---
hw/Makefile.objs |2 +-
hw/usb/Makefile.objs |2 +-
3
There is no reason for vscclient to duplicate the code. rules.mak
takes care of invoking libtool to do the link.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
libcacard/Makefile |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/libcacard/Makefile
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Makefile| 14 +++---
Makefile.objs | 10 ++
Makefile.target |1 -
libcacard/Makefile |3 ++-
tests/Makefile |8
trace/Makefile.objs | 10 +-
6 files changed, 20
Juan Quintela quint...@redhat.com wrote:
Anthony Liguori anth...@codemonkey.ws wrote:
Juan Quintela quint...@redhat.com writes:
Hi
Changes for yesterday:
- Paolo Acked the series
- Rebaso on top of today git (only conflicts were due to header re-shuffle)
Please pull.
[20121219]
This
Rename variables to follow the conventions of the rest of the build
systems.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
libcacard/Makefile | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index a526eae..ddab5d8
This lets the libcacard Makefile use more rules.mak magic.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
libcacard/Makefile |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index ddab5d8..7fc6a06 100644
---
Wenchao Xia xiaw...@linux.vnet.ibm.com wrote:
This patch moves bdrv_snapshotfind from savevm.c to block.c and export
it, also added bdrv_deappend in block.c.
I think this patch can be splitted in two:
- new bdv_deappend
- move bdrv_snapshot_find
On 12/21/2012 07:49 AM, Markus Armbruster wrote:
+static const mon_cmd_t *monitor_parse_command(Monitor *mon,
+ const char *cmdline,
+ const mon_cmd_t *table,
+
On 12/12/2012 06:46 AM, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
blockdev.c | 55 +++
blockdev.h | 1 +
hmp-commands.hx | 39 ++
hmp.c| 27
Wenchao Xia xiaw...@linux.vnet.ibm.com wrote:
resent the mail to mail-list.
---
Hi, Paolo and Juan
Currently savevm needs pause vm, and I am working on that make it
lively. Considering the flexibility I'd like to split out the
functions apart as following:
1)
On 12/21/2012 05:59 AM, Michal Privoznik wrote:
Nowadays only basic information is reported. However, with the
current implementation much more can be exposed to users. like
broadcast/destination address (the former in case of standard
ethernet device, the latter in case of PPP interface), if
Wenchao Xia xiaw...@linux.vnet.ibm.com wrote:
This patch is the implemention of transaction based snapshot
internal API. Internal snapshot for specified block device
is added, which can be used as part of functionality in one way
to live full back up vm seperating internal block snapshot and
On 12/16/2012 11:25 PM, Wenchao Xia wrote:
This patch added API to take snapshots in unified style for
both internal or external type. The core structure is based
on transaction, for that there is a qmp interface need to support
, qmp_transaction, so all operations are packed as requests.
Wenchao Xia xiaw...@linux.vnet.ibm.com wrote:
+
+typedef struct SNTime {
+uint32_t date_sec; /* UTC date of the snapshot */
+uint32_t date_nsec;
This two fields are just struct timespec, does it makes sense to use it?
+uint64_t vm_clock_nsec; /* VM clock relative to boot */
+}
On 12/21/2012 04:56:05 AM, Robert Schiele wrote:
On Fri, Dec 21, 2012 at 9:56 AM, Gerd Hoffmann kra...@redhat.com
wrote:
I mean with --cross-prefix specifying the absolute location (so you
don't have to mess with PATH), why does that not work?
He actually wrote already previously: The name
Markus Armbruster writes:
Lluís Vilanova vilan...@ac.upc.edu writes:
This interface decouples event obtention from interaction.
Are you sure obtention is a word? :)
Looks like a spanglish word escaped from my keyboard XD
I'll wait for other comments before sending a new version.
Thanks,
Hi
Changes for last version:
- inlined paolo fixes, attached here (they were very small, and only change
error cases locking)
- I tested with autotest and see no problems
Please pull.
Thanks, Juan.
diff --git a/arch_init.c b/arch_init.c
index 86f8544..ea75441 100644
--- a/arch_init.c
+++
Paolo Bonzini writes:
[...]
Finally, patches 25 to 27 affect tracing, which is also moved to
libqemuutil.a. Patch 25 is Lluis's already posted patch to introduce
trace/Makefile.objs.
I just skimmed through the patches, but is there a clean way to have files
included only in binaries that
Changelog
v1 - v2
- add RFC tag again
- change semantics as follows
- set event threads' priority to maxprio
- set vcpu threads' priority to maxprio - 1
- isolate all the posix stuff and put them into os_prioritize() in
os-posix.c/qemu-os-win32.h to avoid breaking win32 build
-
Hi,
Am 21.12.2012 11:47, schrieb Alexandre DERUMIER:
I'm trying to pass hyper-v feature, with -cpu qemu64,+hv_relaxed (qemu 1.3)
but I got an
CPU feature hv_relaxed not found
Does this require an specific host kernel or host cpu feature support ?
I believe it's -cpu
Am 20.12.2012 12:29, schrieb Paolo Bonzini:
xen-all needs to access CharDeviceState's filename field, so
it needs to include char/char.h.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Tested-by: Andreas Färber afaer...@suse.de
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409
This will stop things from breaking once it's properly treated as a
level-triggered interrupt. Note that it's the MPIC's MSI cascade
interrupts that are level-triggered; the individual MSIs are
edge-triggered.
Signed-off-by: Scott Wood scottw...@freescale.com
---
hw/openpic.c |1 +
1 file
Other priorities are signed, so avoid comparisons between
signed and unsigned.
Signed-off-by: Scott Wood scottw...@freescale.com
---
hw/openpic.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/openpic.c b/hw/openpic.c
index 94a7807..9d22e9c 100644
---
Signed-off-by: Scott Wood scottw...@freescale.com
---
hw/openpic.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/openpic.c b/hw/openpic.c
index 9d22e9c..268f312 100644
--- a/hw/openpic.c
+++ b/hw/openpic.c
@@ -194,6 +194,7 @@ typedef struct IRQ_src_t {
bool
The base openpic specification doesn't provide abbreviated register
names, so it's somewhat understandable that the QEMU code made up
its own, except that most of the names that QEMU used didn't correspond
to the terminology used by any implementation I could find.
In some cases, like PCTP, the
Critical interrupts on FSL MPIC are not supposed to pay
attention to priority, IACK, EOI, etc. On the currently modeled
version it's not supposed to pay attention to the mask bit either.
Also reorganize to make it easier to implement newer FSL MPIC models,
which encode interrupt level
Search the queue more efficiently by first looking for a non-zero word,
and then using the common bit-searching function to find the bit within
the word. It would be even nicer if bitops_ffsl() could be hooked up
to the compiler intrinsic so that bit-searching instructions could be
used, but
Previously the code relied on the queue's next field getting
set to -1 sometime between an update to the bitmap, and the next
call to IRQ_get_next. Sometimes this happened after the update.
Sometimes it happened before the check. Sometimes it didn't happen
at all.
Signed-off-by: Scott Wood
Here's another patch of cleanups and fixes, dealing with critical
interrupts, interrupt deassertion, task priority, and other issues.
Scott Wood (15):
openpic: fix debug prints
openpic: lower interrupt when reading the MSI register
openpic: fix sense and priority bits
ppc/booke: fix
Previously, the sense and priority bits were masked off when writing
to IVPR, and all interrupts were treated as edge-triggered (despite
the existence of code for handling level-triggered interrupts).
Polarity is implemented only as storage. We don't simulate the
bad effects that you'd get on
Juan Quintela quint...@redhat.com writes:
Hi
Changes for yesterday:
- Paolo Acked the series
- Rebaso on top of today git (only conflicts were due to header re-shuffle)
Please pull.
Pulled. Thanks.
Regards,
Anthony Liguori
[20121219]
This is my queue for migration-thread and
Besides making the code cleaner, we will need a separate way to access
IACK in order to implement EPR (external proxy) interrupt delivery.
Signed-off-by: Scott Wood scottw...@freescale.com
---
hw/openpic.c | 95 --
1 file changed, 53
Besides the private implementation being redundant, namespace collisions
prevented the use of other things in bitops.h.
Serialization does get a bit more awkward, unfortunately, since the
standard bitmap operations are unsigned long rather than uint32_t,
though in exchange we will get faster
This reverts commit a9bd83f4c65de0058659ede009fa1a241f379edd.
This counting approach is not robust against setting a bit that
was already set, or clearing a bit that was already clear. Perhaps
that is considered a bug, but besides the lack of any documentation
for that restriction, it's a pretty
The two checks with abort() guard against potential QEMU-internal
problems, but the EOI check stops the guest from causing updates to queue
position -1 and other havoc if it writes EOI with no interrupt in
service.
Signed-off-by: Scott Wood scottw...@freescale.com
---
hw/openpic.c | 15
Properly implement level-triggered interrupts by withdrawing an
interrupt from the raised queue if the interrupt source de-asserts.
Also withdraw from the raised queue if the interrupt becomes masked.
When CTPR is written, check whether we need to raise or lower the
interrupt output.
Fix various format errors when debug prints are enabled. Also
cause error checking to happen even when debug prints are not
enabled, and consistently use 0x for hex output.
Signed-off-by: Scott Wood scottw...@freescale.com
---
hw/openpic.c | 40
1 file
100 matches
Mail list logo
