[Qemu-devel] [PULL 1/5] HMP: add QDict to info callback handler

2013-01-17 Thread Luiz Capitulino
From: Wenchao Xia xiaw...@linux.vnet.ibm.com This patch change all info call back function to take additional QDict * parameter, which allow those command take parameter. Now it is set to NULL at default case. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Signed-off-by: Luiz Capitulino

[Qemu-devel] [PATCH v3 1/2] move virtnet_send_command() above virtnet_set_mac_address()

2013-01-17 Thread akong
From: Amos Kong ak...@redhat.com We will send vq command to set mac address in virtnet_set_mac_address() a little fix of coding style Signed-off-by: Amos Kong ak...@redhat.com --- drivers/net/virtio_net.c | 89 1 file changed, 44 insertions(+),

[Qemu-devel] [PATCH 1/5] target-i386: print deprecated warning if xlevel 0x80000000

2013-01-17 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 333745b..ce914da 100644 --- a/target-i386/cpu.c +++

[Qemu-devel] [PATCH qom-cpu 0/5] x86 CPU cleanup, part 4

2013-01-17 Thread Igor Mammedov
It's rebase of remnants of [PATCH qom-cpu 00/17] x86 CPU cleanup, part 3 [1] taking in account comments of reviewers. This series is several cleanups, moved out from CPU properties series, since they do not really depend on CPU properties re-factoring and could simplify CPU subclasses work as

[Qemu-devel] [PATCH 3/5] target-i386: remove vendor_override field from CPUX86State

2013-01-17 Thread Igor Mammedov
commit 8935499831312 makes cpuid return to guest host's vendor value instead of built-in one by default if kvm_enabled() == true and allows to override this behavior if 'vendor' is specified on -cpu command line. But every time guest calls cpuid to get 'vendor' value, host's value is read again

[Qemu-devel] [PATCH 5/5] target-i386: remove setting tsc-frequency from x86_def_t

2013-01-17 Thread Igor Mammedov
Setting tsc-frequency from x86_def_t is NOP because default tsc_khz in x86_def_t is 0 and CPUX86State.tsc_khz is also initialized to 0 by default. So there is not need to set ovewrite tsc_khz with default 0 because field was already initialized to 0. custom tsc-frequency setting is not affected

[Qemu-devel] [PATCH 4/5] target-i386: set custom features/properties without intermediate x86_def_t

2013-01-17 Thread Igor Mammedov
Move custom features parsing after built-in cpu_model defaults are set and set custom features directly on CPU instance. That allows to make clear distinction between built-in cpu model defaults that eventually should go into clas_init() and extra property setting which is done after defaults are

Re: [Qemu-devel] [PULL 00/13] thread queue

2013-01-17 Thread Anthony Liguori
Juan Quintela quint...@redhat.com writes: This is the intersect of the paolo me patches for migration thread, Changes from 2 days ago: - spelling check from Eric - put the commit that patch refered from (Eric) - drop the buffered rename at paolo request. Please, pull. If these were just

[Qemu-devel] [PATCH 06/13] migration: fix off-by-one in buffered_rate_limit

2013-01-17 Thread Juan Quintela
From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Reviewed-by: Eric Blake ebl...@redhat.com --- migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration.c

[Qemu-devel] [PULL 5/5] HMP: add sub command table to info

2013-01-17 Thread Luiz Capitulino
From: Wenchao Xia xiaw...@linux.vnet.ibm.com Now info command takes a table of sub info commands, and changed do_info() to do_info_help() to do help funtion only. Note that now info unknown-topic returns error instead of list of info topics. Signed-off-by: Wenchao Xia

[Qemu-devel] [PULL 4/5] HMP: move define of mon_cmds

2013-01-17 Thread Luiz Capitulino
From: Wenchao Xia xiaw...@linux.vnet.ibm.com Because mon_cmds may use info_cmds, so adjust the declare sequence of them. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c | 12 ++-- 1 file changed, 6

[Qemu-devel] [PULL 3/5] HMP: add infrastructure for sub command

2013-01-17 Thread Luiz Capitulino
From: Wenchao Xia xiaw...@linux.vnet.ibm.com This patch make parsing of hmp command aware of that it may have sub command. Also discard simple encapsulation function monitor_find_command(). For case @command , space after @command is filtered out. Signed-off-by: Wenchao Xia

Re: [Qemu-devel] [PATCH 2/5] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2013-01-17 Thread Eduardo Habkost
On Thu, Jan 17, 2013 at 04:16:31PM +0100, Igor Mammedov wrote: Vendor property setter takes string as vendor value but cpudefs use uint32_t vendor[123] fields to define vendor value. It makes it difficult to unify and use property setter for values from cpudefs. Simplify code by using vendor

[Qemu-devel] kvm_virtio_pci_irqfd_release: Assertion `ret == 0' failed

2013-01-17 Thread Luiz Capitulino
Hi Michael, To trigger this I just: 1. Boot the VM, command-line: # ./qemu -drive file=disks/test.img,if=virtio,cache=none,aio=native \ -enable-kvm -m 1G -monitor stdio \ -netdev type=tap,vhost=on,id=guest0,script=qemu-ifup-switch \ -device

Re: [Qemu-devel] [PATCH 3/5] target-i386: remove vendor_override field from CPUX86State

2013-01-17 Thread Eduardo Habkost
On Thu, Jan 17, 2013 at 04:16:32PM +0100, Igor Mammedov wrote: commit 8935499831312 makes cpuid return to guest host's vendor value instead of built-in one by default if kvm_enabled() == true and allows to override this behavior if 'vendor' is specified on -cpu command line. But every time

[Qemu-devel] [PATCH 2/5] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2013-01-17 Thread Igor Mammedov
Vendor property setter takes string as vendor value but cpudefs use uint32_t vendor[123] fields to define vendor value. It makes it difficult to unify and use property setter for values from cpudefs. Simplify code by using vendor property setter, vendor[123] fields are converted into vendor[13]

[Qemu-devel] [PATCH v3 2/2] virtio-net: introduce a new control to set macaddr

2013-01-17 Thread akong
From: Amos Kong ak...@redhat.com Currently we write MAC address to pci config space byte by byte, this means that we have an intermediate step where mac is wrong. This patch introduced a new control command to set MAC address, it's atomic. VIRTIO_NET_F_CTRL_MAC_ADDR is a new feature bit for

[Qemu-devel] [PULL 00/13] thread queue

2013-01-17 Thread Juan Quintela
This is the intersect of the paolo me patches for migration thread, Changes from 2 days ago: - spelling check from Eric - put the commit that patch refered from (Eric) - drop the buffered rename at paolo request. Please, pull. Thanks, Juan. The following changes since commit

Re: [Qemu-devel] [RFC V1 10/14] qapi: Add support for deduplication infos in qapi-schema.json.

2013-01-17 Thread Eric Blake
On 01/17/2013 05:15 AM, Benoît Canet wrote: +# @running: True if deduplication is running Internally QCOW2 deduplication state switch between STOPPED, STARTING, RUNNING and STOPPING. Should the running field be a status field reflecting all theses states in a string for

Re: [Qemu-devel] [RFC V1 12/14] qcow2: Add qcow2_dedup_update_metrics to compute dedup RAM usage.

2013-01-17 Thread Eric Blake
On 01/17/2013 04:11 AM, Benoît Canet wrote: Le Wednesday 16 Jan 2013 à 13:10:12 (-0700), Eric Blake a écrit : On 01/16/2013 09:25 AM, Benoît Canet wrote: --- block/qcow2-dedup.c | 13 + block/qcow2.h |1 + 2 files changed, 14 insertions(+) diff --git

Re: [Qemu-devel] kvm_virtio_pci_irqfd_release: Assertion `ret == 0' failed

2013-01-17 Thread Michael S. Tsirkin
On Thu, Jan 17, 2013 at 01:28:48PM -0200, Luiz Capitulino wrote: Hi Michael, To trigger this I just: Yes you need virtio-pci: fix irqfd cleanup argument order -- MST

[Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-17 Thread Stefan Hajnoczi
The viostor virtio-blk driver for Windows does not use the VIRTIO_CONFIG_S_DRIVER bit. It only sets the VIRTIO_CONFIG_S_DRIVER_OK bit. The viostor driver refreshes the virtio-pci status byte sometimes while the guest is running. We misinterpret 0x4 (VIRTIO_CONFIG_S_DRIVER_OK) as an indication

[Qemu-devel] [RFC V6 03/11] quorum: Add quorum_open() and quorum_close().

2013-01-17 Thread Benoît Canet
Valid quorum resources look like quorum:threshold/total:path/to/image_1: ... :path/to/image_total ':' is used as a separator '\' is the escaping character for filename containing ':' '\' escape itself ',' must be escaped with ',' On the command line for quorum files img:test.raw, img2,raw and

[Qemu-devel] [RFC V6 06/11] quorum: Add quorum_aio_readv.

2013-01-17 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index cb95eab..98052eb 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -192,15 +192,24

[Qemu-devel] [RFC V6 04/11] quorum: Add quorum_aio_writev and its dependencies.

2013-01-17 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 113 1 file changed, 113 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index c7ecffd..cb95eab 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -171,6

[Qemu-devel] [RFC V6 08/11] quorum: Add quorum_getlength().

2013-01-17 Thread Benoît Canet
Check that every bs file return the same length. If not return -EIO to disable the quorum and avoid length discrepancy. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 20 1 file changed, 20 insertions(+) diff --git a/block/quorum.c b/block/quorum.c

[Qemu-devel] [RFC V6 05/11] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2013-01-17 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/blkverify.c | 108 + include/qemu-common.h |2 + iov.c | 103 ++ 3 files changed, 107 insertions(+), 106 deletions(-)

[Qemu-devel] [RFC V6 10/11] quorum: Add quorum_co_is_allocated.

2013-01-17 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 32 1 file changed, 32 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index bd478ab..4bea906 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -621,6 +621,37 @@ static void

[Qemu-devel] [RFC V6 07/11] quorum: Add quorum mechanism.

2013-01-17 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 278 +++- 1 file changed, 277 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 98052eb..2b4 100644 --- a/block/quorum.c +++ b/block/quorum.c

Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-17 Thread Michael S. Tsirkin
On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote: The viostor virtio-blk driver for Windows does not use the VIRTIO_CONFIG_S_DRIVER bit. It only sets the VIRTIO_CONFIG_S_DRIVER_OK bit. The viostor driver refreshes the virtio-pci status byte sometimes while the guest is

Re: [Qemu-devel] [PATCH] fix unbounded qemu NetQueue

2013-01-17 Thread Luigi Rizzo
On Thu, Jan 17, 2013 at 2:21 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jan 17, 2013 at 07:07:11AM +0100, Luigi Rizzo wrote: The comment at the beginning of net/queue.c says that packets that cannot be sent by qemu_net_queue_send() should not be enqueued unless a callback is

[Qemu-devel] [PATCH v3 0/2] make mac programming for virtio net more robust

2013-01-17 Thread akong
From: Amos Kong ak...@redhat.com Currenly mac is programmed byte by byte. This means that we have an intermediate step where mac is wrong. Second patch introduced a new vq control command to set mac address, it's atomic. V2: check return of sending command, delay eth_mac_addr() V3: restore

[Qemu-devel] [RFC V6 00/11] Quorum block filter.

2013-01-17 Thread Benoît Canet
Hello I am resuming the work on the quorum patchset. This patchset create a block driver implementing a quorum using total qemu disk images. Writes are mirrored on the $total files. For the reading part the $total files are read at the same time and a vote is done to determine if a qiov version

Re: [Qemu-devel] kvm_virtio_pci_irqfd_release: Assertion `ret == 0' failed

2013-01-17 Thread Luiz Capitulino
On Thu, 17 Jan 2013 17:50:09 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jan 17, 2013 at 01:28:48PM -0200, Luiz Capitulino wrote: Hi Michael, To trigger this I just: Yes you need virtio-pci: fix irqfd cleanup argument order Oh, ok, so it's already known. I assume the fix

Re: [Qemu-devel] [PATCH 2/4] Makefile: clean timestamp generation rule

2013-01-17 Thread Stefan Hajnoczi
On Tue, Jan 15, 2013 at 06:57:37PM +0200, Michael S. Tsirkin wrote: create timestamp by rule without sideeffects. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- trace/Makefile.objs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [RFC V6 09/11] quorum: Add quorum_invalidate_cache().

2013-01-17 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 261e9b6..bd478ab 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -611,6 +611,16 @@ static int64_t

[Qemu-devel] [PATCH] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-17 Thread Peter Maydell
Remove an unnecessary mutual inclusion loop between qemu-pixman.h and console.h, since the former was only including the latter for 'PixelFormat*', which can be provided by typedefs.h. This requires a minor adjustment to qemu-pixman.c, which was relying on the implicit inclusion of console.h for

[Qemu-devel] [RFC V6 11/11] quorum: Add quorum_co_flush().

2013-01-17 Thread Benoît Canet
Makes a vote to select error if any. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 4bea906..dba2918 100644 --- a/block/quorum.c +++ b/block/quorum.c @@

Re: [Qemu-devel] [PATCH 04/12] Update linux headers.

2013-01-17 Thread Cornelia Huck
On Thu, 17 Jan 2013 15:05:46 + Peter Maydell peter.mayd...@linaro.org wrote: On 17 January 2013 14:23, Cornelia Huck cornelia.h...@de.ibm.com wrote: Base is kvm-next as of 2013/01/16. --- a/linux-headers/asm-powerpc/kvm_para.h +++ b/linux-headers/asm-powerpc/kvm_para.h @@ -78,7

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-17 Thread Michael S. Tsirkin
On Fri, Sep 07, 2012 at 06:48:14AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support for the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc.

Re: [Qemu-devel] [PATCH for-1.4] qom: Extend documentation on QOM method concepts

2013-01-17 Thread Eduardo Habkost
On Thu, Jan 17, 2013 at 08:31:50AM +0100, Andreas Färber wrote: Add a documentation section Methods and discuss among others how to handle overriding virtual methods. Clarify DeviceClass::realize documentation and refer to the above. Signed-off-by: Andreas Färber afaer...@suse.de ---

Re: [Qemu-devel] [PATCH 22/43] tcg/arm: fix TLB access in qemu-ld/st ops

2013-01-17 Thread Peter Maydell
On 3 December 2012 22:08, Michael Roth mdr...@linux.vnet.ibm.com wrote: +assert(tlb_offset ~0xf == 0); This doesn't compile if configured with --enable-debug: In file included from /home/petmay01/git/qemu/tcg/tcg.c:174:0: /home/petmay01/git/qemu/tcg/arm/tcg-target.c: In function

Re: [Qemu-devel] [PATCH 04/12] Update linux headers.

2013-01-17 Thread Alexander Graf
On 17.01.2013, at 17:20, Cornelia Huck wrote: On Thu, 17 Jan 2013 15:05:46 + Peter Maydell peter.mayd...@linaro.org wrote: On 17 January 2013 14:23, Cornelia Huck cornelia.h...@de.ibm.com wrote: Base is kvm-next as of 2013/01/16. --- a/linux-headers/asm-powerpc/kvm_para.h +++

Re: [Qemu-devel] [PATCH] dataplane: support viostor virtio-pci status bit setting

2013-01-17 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 05:59:17PM +0200, Michael S. Tsirkin wrote: On Thu, Jan 17, 2013 at 04:46:54PM +0100, Stefan Hajnoczi wrote: The viostor virtio-blk driver for Windows does not use the VIRTIO_CONFIG_S_DRIVER bit. It only sets the VIRTIO_CONFIG_S_DRIVER_OK bit. The viostor

Re: [Qemu-devel] [PATCH] Add option to slow down qemu

2013-01-17 Thread Wolfgang Mauerer
On 11/01/13 20:58, Stefan Weil wrote: Am 11.01.2013 14:40, schrieb Wolfgang Mauerer: For slow targets and fast hosts, the emulation may be faster than the actual hardware, which can be undesirable for various reasons. Add a run-time option to slow down the emulation by sleeping in the CPU

[Qemu-devel] [[PATCH v2]] Add option to slow qemu down

2013-01-17 Thread Wolfgang Mauerer
For slow targets and fast hosts, the emulation may be faster than the actual hardware, which can be undesirable for various reasons. Add a run-time option to slow down the emulation by sleeping in the CPU emulation. Signed-off-by: Wolfgang Mauerer wolfgang.maue...@siemens.com --- cpus.c

Re: [Qemu-devel] [PATCH 4/5] target-i386: set custom features/properties without intermediate x86_def_t

2013-01-17 Thread Eduardo Habkost
On Thu, Jan 17, 2013 at 04:16:33PM +0100, Igor Mammedov wrote: Move custom features parsing after built-in cpu_model defaults are set and set custom features directly on CPU instance. That allows to make clear distinction between built-in cpu model defaults that eventually should go into

[Qemu-devel] [Bug 1091115] Re: qemu-1.3.0 crashes when installing windows xp

2013-01-17 Thread Sven
Same as Bug 1096712 I reported -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1091115 Title: qemu-1.3.0 crashes when installing windows xp Status in QEMU: New Bug description: These are the

Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions

2013-01-17 Thread Laszlo Ersek
On 01/16/13 19:28, Eduardo Habkost wrote: +static void test_parse_uint_negative(void) +{ +unsigned long long i = 999; +char f = 'X'; +char *endptr = f; +const char *str = \t -321; +int r; + +r = parse_uint(str, i, endptr, 0); + +g_assert_cmpint(r, ==,

Re: [Qemu-devel] [RFC 00/12] target-i386: Fix APIC-ID-based topology (v4)

2013-01-17 Thread Eduardo Habkost
On Wed, Jan 09, 2013 at 04:53:40PM -0200, Eduardo Habkost wrote: This series uses a much simpler approach than the previous versions: - The APIC ID calculation code is now inside cpu.c - It doesn't require touching the PC CPU creation code at all - It simply uses a static variable to

Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions

2013-01-17 Thread Eduardo Habkost
On Thu, Jan 17, 2013 at 07:29:17PM +0100, Laszlo Ersek wrote: On 01/16/13 19:28, Eduardo Habkost wrote: +static void test_parse_uint_negative(void) +{ +unsigned long long i = 999; +char f = 'X'; +char *endptr = f; +const char *str = \t -321; +int r; + +

Re: [Qemu-devel] [PATCH for-1.4] qom: Extend documentation on QOM method concepts

2013-01-17 Thread Anthony Liguori
Eduardo Habkost ehabk...@redhat.com writes: On Thu, Jan 17, 2013 at 08:31:50AM +0100, Andreas Färber wrote: + * Alternatively, object_class_by_name() can be used to obtain the class and + * its non-overridden methods for a specific type. This would correspond to + * |[ MyClass::method(...) ]|

[Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions

2013-01-17 Thread Eduardo Habkost
There are lots of duplicate parsing code using strto*() in QEMU, and most of that code is broken in one way or another. Even the visitors code have duplicate integer parsing code[1]. This introduces functions to help parsing unsigned int values: parse_uint() and parse_uint_full(). Parsing

[Qemu-devel] [Bug 1091115] Re: windowsXP install in qemu-system-i386 1.3.0 ends with a BSOD 0x7E in acpi.sys

2013-01-17 Thread Michael Tokarev
** Summary changed: - qemu-1.3.0 crashes when installing windows xp + windowsXP install in qemu-system-i386 1.3.0 ends with a BSOD 0x7E in acpi.sys -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions

2013-01-17 Thread Laszlo Ersek
On 01/17/13 20:06, Eduardo Habkost wrote: Changes v4: - Return -EINVAL in case a minus sign is found - Make endptr point to beginning of string in case -EINVAL is returned (like the strtoull() behavior) Reviewed-by: Laszlo Ersek ler...@redhat.com

[Qemu-devel] [Bug 1091115] Re: windowsXP install in qemu-system-i386 1.3.0 ends with a BSOD 0x7E in acpi.sys

2013-01-17 Thread Michael Tokarev
It is most likely the seabios bits missing in 1.3.0, namely this change: http://git.qemu.org/?p=seabios.git;a=commitdiff;h=f64a472a481784231fbf8541825501df411b11d1 You may try this bios file: http://git.qemu.org/?p=qemu.git;a=blob;f=pc- bios/bios.bin;h=3910875311ceaed814f902e9e4e7e29cdf340fc6

Re: [Qemu-devel] ChangeLog for 1.4

2013-01-17 Thread Luiz Capitulino
On Tue, 15 Jan 2013 17:45:10 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Hi, I've been somewhat busy with other things during the early 1.3 cycle so I have no idea what changes went in. I created a stub at http://wiki.qemu.org/ChangeLog/1.4, please fill it in. You're CCed if you sent

[Qemu-devel] [Bug 1096712] Re: qemu 1.3.0: Windows XP doesn't boot with BSOD STOP 7E in acpi.sys

2013-01-17 Thread Michael Tokarev
*** This bug is a duplicate of bug 1091115 *** https://bugs.launchpad.net/bugs/1091115 ** This bug has been marked a duplicate of bug 1091115 qemu-1.3.0 crashes when installing windows xp -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions

2013-01-17 Thread Eric Blake
On 01/17/2013 12:06 PM, Eduardo Habkost wrote: There are lots of duplicate parsing code using strto*() in QEMU, and most of that code is broken in one way or another. Even the visitors code have duplicate integer parsing code[1]. This introduces functions to help parsing unsigned int values:

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

2013-01-17 Thread Anthony Liguori
Vadim Evard v.e.ev...@gmail.com writes: Signed-off-by: Vadim Evard v.e.ev...@gmail.com Please post this as a top-level patch. (no in-reply-to) Regards, Anthony Liguori --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index

[Qemu-devel] [PATCH for-1.4] tcg/target-arm: Add missing parens to assertions

2013-01-17 Thread Peter Maydell
Silence a (legitimate) complaint about missing parentheses: tcg/arm/tcg-target.c: In function ‘tcg_out_qemu_ld’: tcg/arm/tcg-target.c:1148:5: error: suggest parentheses around comparison in operand of ‘’ [-Werror=parentheses] tcg/arm/tcg-target.c: In function ‘tcg_out_qemu_st’:

Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions

2013-01-17 Thread Blue Swirl
On Mon, Jan 14, 2013 at 9:09 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Sat, Jan 12, 2013 at 10:46:18AM +, Blue Swirl wrote: On Thu, Jan 10, 2013 at 12:43 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Jan 09, 2013 at 08:43:51PM +, Blue Swirl wrote: On Tue, Jan 8, 2013

Re: [Qemu-devel] [[PATCH v2]] Add option to slow qemu down

2013-01-17 Thread Stefan Weil
Hello Wolfgang, please see comment below. Am 17.01.2013 18:10, schrieb Wolfgang Mauerer: For slow targets and fast hosts, the emulation may be faster than the actual hardware, which can be undesirable for various reasons. Add a run-time option to slow down the emulation by sleeping in the CPU

Re: [Qemu-devel] [PATCH] reading files from qcow2-formated image disk for windows system

2013-01-17 Thread Blue Swirl
On Mon, Jan 14, 2013 at 9:13 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Sat, Jan 12, 2013 at 12:00:45PM +, Blue Swirl wrote: On Fri, Jan 11, 2013 at 7:27 AM, 马磊 aware@gmail.com wrote: On Fri, Jan 11, 2013 at 2:28 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On

Re: [Qemu-devel] Go along with glib's basic type typedef silliness? (was: [PATCH 01/10] qom: Make object_resolve_path_component() path argument const)

2013-01-17 Thread Blue Swirl
On Mon, Jan 14, 2013 at 7:01 PM, Markus Armbruster arm...@redhat.com wrote: [Thread hijack, dropping cc: qemu-trivial, qemu-ppc] Andreas Färber afaer...@suse.de writes: Am 14.01.2013 13:19, schrieb Markus Armbruster: Andreas Färber afaer...@suse.de writes: [...] diff --git a/qom/object.c

Re: [Qemu-devel] [PATCH] tests: adjust gcov variables for directory movement

2013-01-17 Thread Blue Swirl
On Tue, Jan 15, 2013 at 8:49 AM, Paolo Bonzini pbonz...@redhat.com wrote: I had missed the introduction of the gcov-files-* variables. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Blue, can you look at introducing a common variable for the

[Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format

2013-01-17 Thread Stefan Weil
These patches improve the error report if the file format was specified explicitly (example: -drive file=myfile,format=qcow2) and the given format does not match the real format. They fix those bugs: https://bugzilla.redhat.com/show_bug.cgi?id=556482 https://bugs.launchpad.net/qemu/+bug/1090600

Re: [Qemu-devel] [PATCH] util: Fix compilation of envlist.c for MinGW

2013-01-17 Thread Blue Swirl
On Wed, Jan 16, 2013 at 6:04 PM, Stefan Weil s...@weilnetz.de wrote: MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h. We must also fix the include statements in util/envlist.c to include that file. We currently don't need an implementation of strtok_r because the code is

[Qemu-devel] [PATCH v2 3/5] block/vdi: Improve debug output for signature

2013-01-17 Thread Stefan Weil
The signature is a 32 bit value and needs up to 8 hex digits for printing. Signed-off-by: Stefan Weil s...@weilnetz.de --- block/vdi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vdi.c b/block/vdi.c index 021abaa..0e1ed61 100644 --- a/block/vdi.c +++

[Qemu-devel] [PATCH v2 5/5] block/vdi: Check for bad signature

2013-01-17 Thread Stefan Weil
vdi_open did not check for a bad signature. This check was only in vdi_probe. Signed-off-by: Stefan Weil s...@weilnetz.de --- block/vdi.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/block/vdi.c b/block/vdi.c index 8b768bf..257a592 100644 --- a/block/vdi.c +++

[Qemu-devel] [PATCH v2 4/5] block/vdi: Improved return values from vdi_open

2013-01-17 Thread Stefan Weil
vdi_open returned -1 in case of any error, but it should return an error code (negative value of errno or -EMEDIUMTYPE). Signed-off-by: Stefan Weil s...@weilnetz.de --- block/vdi.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/block/vdi.c b/block/vdi.c

Re: [Qemu-devel] [PATCH 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename()

2013-01-17 Thread Blue Swirl
On Wed, Jan 16, 2013 at 4:06 PM, Markus Armbruster arm...@redhat.com wrote: Eric Blake ebl...@redhat.com writes: On 01/16/2013 07:36 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster arm...@redhat.com --- qemu-log.c | 13 + 1 file changed, 9 insertions(+), 4

Re: [Qemu-devel] [PATCH] util: Fix compilation of envlist.c for MinGW

2013-01-17 Thread Stefan Weil
Am 17.01.2013 21:45, schrieb Blue Swirl: On Wed, Jan 16, 2013 at 6:04 PM, Stefan Weils...@weilnetz.de wrote: MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h. We must also fix the include statements in util/envlist.c to include that file. We currently don't need an

[Qemu-devel] [PATCH for-1.4 01/12] kvm: Add fake KVM_FEATURE_CLOCKSOURCE_STABLE_BIT for builds withou KVM

2013-01-17 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Cc: k...@vger.kernel.org Cc: Michael S. Tsirkin m...@redhat.com Cc: Gleb Natapov g...@redhat.com Cc: Marcelo Tosatti mtosa...@redhat.com --- include/sysemu/kvm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/sysemu/kvm.h

[Qemu-devel] [PATCH for-1.4 00/12] target-i386: Fix APIC-ID-based topology (v4)

2013-01-17 Thread Eduardo Habkost
I am hoping to get this bug fixed in 1.4. I didn't get much feedback on the RFC I sent last week, though. Igor argued that APIC ID should be set by the board and not by the CPU itself, but I am not doing that because: - I want to keep the bug fix simple and isolated as we are past soft freeze -

[Qemu-devel] [PATCH for-1.4 11/12] target-i386: Topology APIC ID utility functions

2013-01-17 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Changes v1 - v2: - Support 32-bit APIC IDs (in case x2APIC is going to be used) - Coding style changes - Use TARGET_I386_TOPOLOGY_H instead of __QEMU_X86_TOPOLOGY_H__ - Rename topo_make_apic_id() to topo_apicid_for_cpu() - Rename

[Qemu-devel] [PATCH v2 1/5] block: Add special error code for wrong format

2013-01-17 Thread Stefan Weil
The block drivers need a special error code for wrong format. From the available error codes EMEDIUMTYPE fits best. It is not available on all platforms, so a definition in qemu-common.h and a specific error report are needed. Signed-off-by: Stefan Weil s...@weilnetz.de --- blockdev.c

Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions

2013-01-17 Thread Blue Swirl
On Thu, Jan 17, 2013 at 7:06 PM, Eduardo Habkost ehabk...@redhat.com wrote: There are lots of duplicate parsing code using strto*() in QEMU, and most of that code is broken in one way or another. Even the visitors code have duplicate integer parsing code[1]. This introduces functions to help

[Qemu-devel] [PATCH for-1.4 07/12] target-i386/cpu: Introduce apic_id_for_cpu() function

2013-01-17 Thread Eduardo Habkost
This function will be used by both the CPU initialization code and the fw_cfg table initialization code. Later this function will be updated to generate APIC IDs according to the CPU topology. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 17 -

[Qemu-devel] [PATCH for-1.4 03/12] pc: Reverse pc_init_pci() compatibility logic

2013-01-17 Thread Eduardo Habkost
Currently, the pc-1.4 machine init function enables PV EOI and then calls the pc-1.2 machine init function. The problem with this approach is that now we can't enable any additional compatibility code inside the pc-1.2 init function because it would end up enabling the compatibility behavior on

[Qemu-devel] [PATCH for-1.4 08/12] cpus.h: Make constant smp_cores/smp_threads available on *-user

2013-01-17 Thread Eduardo Habkost
The code that calculates the APIC ID will use smp_cores/smp_threads, so just define them as 1 on *-user to avoid #ifdefs in the code. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- include/sysemu/cpus.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/sysemu/cpus.h

Re: [Qemu-devel] [PATCH] util: Fix compilation of envlist.c for MinGW

2013-01-17 Thread Blue Swirl
On Thu, Jan 17, 2013 at 8:54 PM, Stefan Weil s...@weilnetz.de wrote: Am 17.01.2013 21:45, schrieb Blue Swirl: On Wed, Jan 16, 2013 at 6:04 PM, Stefan Weils...@weilnetz.de wrote: MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h. We must also fix the include statements in

[Qemu-devel] [PATCH v2 2/5] block: Use error code EMEDIUMTYPE for wrong format in some block drivers

2013-01-17 Thread Stefan Weil
This improves error reports for bochs, cow, qcow, qcow2, qed and vmdk when a file with the wrong format is selected. Signed-off-by: Stefan Weil s...@weilnetz.de --- block/bochs.c |2 +- block/cow.c |2 +- block/qcow.c |2 +- block/qcow2.c |2 +- block/qed.c |2 +-

[Qemu-devel] [PATCH for-1.4 06/12] fw_cfg: Remove FW_CFG_MAX_CPUS from fw_cfg_init()

2013-01-17 Thread Eduardo Habkost
PC will not use max_cpus for that field, so move it outside the common code so it can use a different value on PC. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- hw/fw_cfg.c | 1 - hw/pc.c | 2 +- hw/ppc_newworld.c | 1 + hw/ppc_oldworld.c | 1 + hw/sun4m.c| 3 +++

[Qemu-devel] [PATCH for-1.4 10/12] tests: Support target-specific unit tests

2013-01-17 Thread Eduardo Habkost
To make unit tests that depend on target-specific files, use check-unit-arch-y and test-obj-arch-y. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- tests/Makefile | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index

Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format

2013-01-17 Thread Eric Blake
On 01/17/2013 01:45 PM, Stefan Weil wrote: These patches improve the error report if the file format was specified explicitly (example: -drive file=myfile,format=qcow2) and the given format does not match the real format. They fix those bugs:

[Qemu-devel] [PATCH for-1.4 12/12] pc: Generate APIC IDs according to CPU topology

2013-01-17 Thread Eduardo Habkost
This keeps compatibility on machine-types pc-1.2 and older, and prints a warning in case the requested configuration won't get the correct topology. I couldn't think of a better way to warn about broken topology when in compat mode other than using error_report(). The warning message will be

[Qemu-devel] [PATCH for-1.4 09/12] pc: Set fw_cfg data based on APIC ID calculation

2013-01-17 Thread Eduardo Habkost
This changes FW_CFG_MAX_CPUS and FW_CFG_NUMA to use apic_id_for_cpu(), so the NUMA table can be based on the APIC IDs, instead of CPU index (SeaBIOS knows nothing about CPU indexes, just APIC IDs). Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Changes v2: - Get PC object as argument -

Re: [Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2013-01-17 Thread Nicholas A. Bellinger
Hi MST Co, On Thu, 2013-01-17 at 18:43 +0200, Michael S. Tsirkin wrote: On Fri, Sep 07, 2012 at 06:48:14AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hello Anthony Co, This is the fourth installment to add host virtualized target support for

[Qemu-devel] [PATCH for-1.4 04/12] kvm: Create kvm_arch_vcpu_id() function

2013-01-17 Thread Eduardo Habkost
This will allow each architecture to define how the VCPU ID is set on the KVM_CREATE_VCPU ioctl call. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- Cc: k...@vger.kernel.org Cc: Michael S. Tsirkin m...@redhat.com Cc: Gleb Natapov g...@redhat.com Cc: Marcelo Tosatti mtosa...@redhat.com

Re: [Qemu-devel] [PATCH 3/4] rules/mak: make clean should blow away timestamp files

2013-01-17 Thread Michael S. Tsirkin
On Thu, Jan 17, 2013 at 11:28:46AM +0100, Stefan Hajnoczi wrote: On Tue, Jan 15, 2013 at 06:57:34PM +0200, Michael S. Tsirkin wrote: Using a global pattern makes it easier to clean out old generated files. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- rules.mak | 5 +

[Qemu-devel] [PATCH for-1.4 05/12] target-i386: kvm: Set vcpu_id to APIC ID instead of CPU index

2013-01-17 Thread Eduardo Habkost
The CPU ID in KVM is supposed to be the APIC ID, so change the KVM_CREATE_VCPU call to match it. The current behavior didn't break anything yet because today the APIC ID is assumed to be equal to the CPU index, but this won't be true in the future. Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH for-1.4 02/12] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-17 Thread Eduardo Habkost
This is a cleanup that tries to solve two small issues: - We don't need a separate kvm_pv_eoi_features variable just to keep a constant calculated at compile-time, and this style would require adding a separate variable (that's declared twice because of the CONFIG_KVM ifdef) for each

Re: [Qemu-devel] [PATCH V4 04/13] block: add snapshot info query function bdrv_query_snapshot_infolist()

2013-01-17 Thread Eric Blake
On 01/17/2013 12:40 AM, Wenchao Xia wrote: This patch add function bdrv_query_snapshot_infolist(), which will return snapshot info of an image in qmp object format. The implementation code are mostly copied from qemu-img.c with modification to fit more for qmp based block layer API. To

Re: [Qemu-devel] [RFC V6 03/11] quorum: Add quorum_open() and quorum_close().

2013-01-17 Thread Eric Blake
On 01/17/2013 08:51 AM, Benoît Canet wrote: Valid quorum resources look like quorum:threshold/total:path/to/image_1: ... :path/to/image_total ':' is used as a separator '\' is the escaping character for filename containing ':' '\' escape itself ',' must be escaped with ',' On the

Re: [Qemu-devel] [RFC V6 07/11] quorum: Add quorum mechanism.

2013-01-17 Thread Eric Blake
On 01/17/2013 08:51 AM, Benoît Canet wrote: Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 278 +++- 1 file changed, 277 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index

Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format

2013-01-17 Thread Stefan Weil
Am 17.01.2013 22:28, schrieb Eric Blake: On 01/17/2013 01:45 PM, Stefan Weil wrote: These patches improve the error report if the file format was specified explicitly (example: -drive file=myfile,format=qcow2) and the given format does not match the real format. They fix those bugs:

Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions

2013-01-17 Thread Eduardo Habkost
On Thu, Jan 17, 2013 at 05:06:50PM -0200, Eduardo Habkost wrote: There are lots of duplicate parsing code using strto*() in QEMU, and most of that code is broken in one way or another. Even the visitors code have duplicate integer parsing code[1]. This introduces functions to help parsing

[Qemu-devel] [RFC V6 02/11] quorum: Create BDRVQuorumState and BlkDriver and do init.

2013-01-17 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index ce094a1..1f12438 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,13 @@ #include block/block_int.h

[Qemu-devel] [RFC V6 01/11] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2013-01-17 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/Makefile.objs |1 + block/quorum.c | 45 + 2 files changed, 46 insertions(+) create mode 100644 block/quorum.c diff --git a/block/Makefile.objs b/block/Makefile.objs index

<    1   2   3   >