Re: [Qemu-devel] [RFC][PATCH]Add timestamp to error message

2013-02-01 Thread Markus Armbruster
Seiji Aguchi writes: >> > Are gmtime() + strftime() unsuitable for some reason? >> >> They are not async-signal safe, so they are not usable in between a >> fork() and exec*(). Libvirt avoids them because it DOES log >> information including timestamps in between fork/exec (and prior to >> writ

Re: [Qemu-devel] [RFC][PATCH]Add timestamp to error message

2013-02-01 Thread Markus Armbruster
Seiji Aguchi writes: > [Issue] > When we offer a customer support service and a problem happens > in a customer's system, we try to understand the problem by > comparing what the customer reports with message logs of the > customer's system. > > In this case, we often need to know when the pro

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.4.0-rc0 is now available

2013-02-01 Thread Stefan Hajnoczi
On Sat, Feb 2, 2013 at 2:29 AM, Anthony Liguori wrote: > The release plan for the 1.4 release is available at: > > http://wiki.qemu.org/Planning/1.3 Correct link: http://wiki.qemu.org/Planning/1.4 Stefan

Re: [Qemu-devel] patch to fix EXC_BAD_ACCESS on Mac OS X

2013-02-01 Thread Christopher Friedt
Hi Peter, On Fri, Feb 1, 2013 at 1:01 PM, Peter Maydell wrote: > OSX generally works for me, with some caveats: > * current master doesn't compile because of a recent patch >related to ffsl; this should be fixed soon I hope. I'll have to check out master again. Currently I'm using 1.3.0, bu

[Qemu-devel] [ANNOUNCE] We are now in hard-freeze for the 1.4 release

2013-02-01 Thread Anthony Liguori
>From this point on, we're in bug-fix only mode. The 1.5 tree will open for general development on February 16th. Happy bug hunting! Regards, Anthony Liguori

[Qemu-devel] [ANNOUNCE] QEMU 1.4.0-rc0 is now available

2013-02-01 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 1.4 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.4.0-rc0.tar.bz2 You can help improve

[Qemu-devel] [PATCH qom-cpu-next v3 3/4] target-i386: Slim conversion to X86CPU subclasses

2013-02-01 Thread Andreas Färber
Move x86_def_t definition to header and embed into X86CPUClass. Register types per built-in model definition. Move version initialization from x86_cpudef_setup() to class_init. Inline cpu_x86_register() into the X86CPU initfn. Since instance_init cannot reports errors, drop error handling. Repla

[Qemu-devel] [PATCH qom-cpu-next v3 2/4] target-i386: Split command line parsing out of cpu_x86_register()

2013-02-01 Thread Andreas Färber
In order to instantiate a CPU subtype we will need to know which type, so move the cpu_model splitting into cpu_x86_init(). Parameters need to be set on the X86CPU instance, so move cpu_x86_parse_featurestr() into cpu_x86_init() as well. This leaves cpu_x86_register() operating on the model name

[Qemu-devel] [PATCH qom-cpu-next v3 1/4] target-i386: Move cpu_x86_init()

2013-02-01 Thread Andreas Färber
Consolidate CPU functions in cpu.c. Allows to make cpu_x86_register() static. No functional changes. Signed-off-by: Andreas Färber --- target-i386/cpu.c| 26 +- target-i386/cpu.h|1 - target-i386/helper.c | 24 3 Dateien geändert,

[Qemu-devel] [PATCH qom-cpu-next v3 4/4] Remove cpudef_setup() hooks

2013-02-01 Thread Andreas Färber
QOM (and KVM) infrastructure have obsoleted x86_cpudef_setup(). Drop the conditional callers that are now unused. Signed-off-by: Andreas Färber --- arch_init.c|7 --- bsd-user/main.c|3 --- include/sysemu/arch_init.h |1 - linux-user/main.c |

[Qemu-devel] [PATCH qom-cpu-next v3 0/4] target-i386: X86CPU subclasses

2013-02-01 Thread Andreas Färber
Hello, Long announced, here it is after the freeze: My 3rd attempt at CPU subclasses. v3 is closer to v1 again, slimmed down not to touch x86_def_t much. It was noticed that in theory a QOM class enumeration could lead to the host CPU class_init running before kvm_init(). My proposal is to make t

[Qemu-devel] [PATCH 1/2] tap: unbreak -netdev tap,fd=X

2013-02-01 Thread Anthony Liguori
The multiqueue patch series broke -netdev tap,fd=X which manifests as libvirt not being able to start a guest. This was because it passed NULL for the netdev name which results in an anonymous netdev device regardless of what the user specified. Cc: Jason Wang Cc: Bruce Rogers Reported-by: Bruc

Re: [Qemu-devel] libvirt fails to start guest with latest code checkins

2013-02-01 Thread Anthony Liguori
Bruce Rogers writes: > >>> On 2/1/2013 at 03:16 PM, Anthony Liguori wrote: >> Bruce Rogers writes: >> >>> I get the following error message starting a linux guest via >>> libvirt with the latest qemu git head: >>> >>> brogers2:/ # virsh start sles11 >>> error: Failed to start domain sles1

Re: [Qemu-devel] libvirt fails to start guest with latest code checkins

2013-02-01 Thread Anthony Liguori
Laszlo Ersek writes: > On 02/01/13 23:41, Bruce Rogers wrote: > >> Here is the invocation by libvirt, as recorded in >> /var/log/libvirt/qemu/: >> 2013-02-01 21:35:45.597+: starting up >> LC_ALL=C >> PATH=/sbin:/usr/sbin:/usr/local/sbin:/root/bin:/usr/local/bin:/usr/bin: >> /bin:/usr/bin/X11

Re: [Qemu-devel] [PATCH 1/2] tap: unbreak -netdev tap,fd=X

2013-02-01 Thread Anthony Liguori
Please ignore the 1/2 in the subject... a bit past beer time and I got a little sloppy sending this patch. Regards, Anthony Liguori Anthony Liguori writes: > The multiqueue patch series broke -netdev tap,fd=X which manifests > as libvirt not being able to start a guest. This was because it

[Qemu-devel] [PATCH] Update version for 1.4.0-rc0

2013-02-01 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VERSION b/VERSION index 52356d3..619d9ea 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.3.50 +1.3.90 -- 1.8.0

Re: [Qemu-devel] libvirt fails to start guest with latest code checkins

2013-02-01 Thread Bruce Rogers
>>> On 2/1/2013 at 05:03 PM, Laszlo Ersek wrote: > On 02/01/13 23:41, Bruce Rogers wrote: > >> Here is the invocation by libvirt, as recorded in >/var/log/libvirt/qemu/: >> 2013-02-01 21:35:45.597+: starting up >> LC_ALL=C >> PATH=/sbin:/usr/sbin:/usr/local/sbin:/root/bin:/usr/local/bin:/u

Re: [Qemu-devel] libvirt fails to start guest with latest code checkins

2013-02-01 Thread Laszlo Ersek
On 02/01/13 23:41, Bruce Rogers wrote: > Here is the invocation by libvirt, as recorded in > /var/log/libvirt/qemu/: > 2013-02-01 21:35:45.597+: starting up > LC_ALL=C > PATH=/sbin:/usr/sbin:/usr/local/sbin:/root/bin:/usr/local/bin:/usr/bin: > /bin:/usr/bin/X11:/usr/X11R6/bin:/usr/games:/usr/

Re: [Qemu-devel] [PATCH v3] bitops: unify bitops_ffsl with the one in host-utils.h, call it bitops_ctzl

2013-02-01 Thread Eric Blake
On 02/01/2013 03:03 PM, Paolo Bonzini wrote: > We had two copies of a ffs function for longs with subtly different > semantics and, for the one in bitops.h, a confusing name: the result > was off-by-one compared to the library function ffsl. > > Unify the functions into one, and solve the name pro

Re: [Qemu-devel] [RFC][PATCH]Add timestamp to error message

2013-02-01 Thread Eric Blake
On 02/01/2013 11:28 AM, Laszlo Ersek wrote: > Hello Seiji-san, > > On 02/01/13 15:53, Seiji Aguchi wrote: > >> A logic calculating a time is copied from libvirt, src/util/virtime.c. > >> +static void error_print_timestamp(void) > > Are gmtime() + strftime() unsuitable for some reason? They are

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-02-01 Thread Paolo Bonzini
Il 31/01/2013 12:25, Michael S. Tsirkin ha scritto: > On Thu, Jan 31, 2013 at 10:13:11AM +0200, Gal Hammer wrote: >> Hi, >> >> How many msi-x vectors should be allocated for the virtio-serial device? >> >> I'm asking this as it seems that a proposed patch >> (http://lists.gnu.org/archive/html/qemu-

[Qemu-devel] [PATCH v3] bitops: unify bitops_ffsl with the one in host-utils.h, call it bitops_ctzl

2013-02-01 Thread Paolo Bonzini
We had two copies of a ffs function for longs with subtly different semantics and, for the one in bitops.h, a confusing name: the result was off-by-one compared to the library function ffsl. Unify the functions into one, and solve the name problem by calling the 0-based functions "bitops_ctzl" and

Re: [Qemu-devel] [PATCH V4 RESEND 15/22] tap: multiqueue support

2013-02-01 Thread Eric Blake
On 02/01/2013 12:39 AM, Jason Wang wrote: > Recently, linux support multiqueue tap which could let userspace call > TUNSETIFF > for a signle device many times to create multiple file descriptors as s/signle/single/ > independent queues. User could also enable/disabe a specific queue through s/d

Re: [Qemu-devel] [RFC][PATCH]Add timestamp to error message

2013-02-01 Thread Seiji Aguchi
> > Are gmtime() + strftime() unsuitable for some reason? > > They are not async-signal safe, so they are not usable in between a > fork() and exec*(). Libvirt avoids them because it DOES log information > including timestamps in between fork/exec (and prior to > writing libvirt's virtime.c, we

Re: [Qemu-devel] libvirt fails to start guest with latest code checkins

2013-02-01 Thread Bruce Rogers
>>> On 2/1/2013 at 03:16 PM, Anthony Liguori wrote: > Bruce Rogers writes: > >> I get the following error message starting a linux guest via >> libvirt with the latest qemu git head: >> >> brogers2:/ # virsh start sles11 >> error: Failed to start domain sles11 >> error: internal error proc

[Qemu-devel] [PATCH] configure: Fix build with XFree

2013-02-01 Thread Richard Henderson
The build is broken on ppc64-linux, possibly only with new binutils: ld: hw/lm32/../milkymist-tmu2.o: undefined reference to symbol 'XFree' ld: note: 'XFree' is defined in DSO /lib64/libX11.so.6 so try \ adding it to the linker command line So let's follow the linker's advice. Signed-off-by: R

[Qemu-devel] [PATCH v2] bswap: Fix width of swap in leul_to_cpu

2013-02-01 Thread Richard Henderson
The misnamed HOST_LONG_BITS is really HOST_POINTER_BITS. Here we're explicitly using an unsigned long, rather than uintptr_t, so it is more correct to select the swap size via ULONG_MAX. Signed-off-by: Richard Henderson --- include/qemu/bswap.h | 12 ++-- 1 file changed, 10 insertions(+

Re: [Qemu-devel] libvirt fails to start guest with latest code checkins

2013-02-01 Thread Anthony Liguori
Bruce Rogers writes: > I get the following error message starting a linux guest via > libvirt with the latest qemu git head: > > brogers2:/ # virsh start sles11 > error: Failed to start domain sles11 > error: internal error process exited while connecting to monitor: WARNING: > failed to fin

[Qemu-devel] [Bug 725991] Re: cpu-exec.c:766: handle_cpu_signal: Assertion failed.

2013-02-01 Thread LocutusOfBorg
*** This bug is a duplicate of bug 1019438 *** https://bugs.launchpad.net/bugs/1019438 ** This bug has been marked a duplicate of bug 1019438 cannot build xorg-xserver inside an armhf pbuilder chroot -- You received this bug notification because you are a member of qemu- devel-ml, which i

[Qemu-devel] [PATCH 6/7] block/vpc: Remove workaround for geometry calculation

2013-02-01 Thread Stefan Weil
QEMU now gets the correct size for VHD images, so this workaround is no longer needed. Signed-off-by: Stefan Weil --- block/vpc.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 799b1c9..e8968c2 100644 --- a/block/vpc.c +++ b/bl

[Qemu-devel] [PATCH 3/7] block/vpc: Replace HEADER_SIZE by FOOTER_SIZE

2013-02-01 Thread Stefan Weil
HEADER_SIZE is the size of the footer (the last sector of the VHD image), so its correct name is FOOTER_SIZE. For the same reason, we have a footer checksum instead of a header checksum. Signed-off-by: Stefan Weil --- block/vpc.c | 32 1 file changed, 16 inser

[Qemu-devel] [PATCH 5/7] block/vpc: Fix size calculation

2013-02-01 Thread Stefan Weil
The size calculated from the CHS values is not the real image (disk) size, but usually a smaller value (this is caused by rounding effects). Only older operating systems use CHS. Such guests won't be able to use the whole disk. This patch fixes https://bugs.launchpad.net/qemu/+bug/1105670/. Sign

[Qemu-devel] [PATCH 2/7] block/vpc: Add link to available VHD documentation

2013-02-01 Thread Stefan Weil
Signed-off-by: Stefan Weil --- block/vpc.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/block/vpc.c b/block/vpc.c index 1c55c21..4565723 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -21,6 +21,9 @@ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, *

[Qemu-devel] block/vpc: Code cleanup and bug fix

2013-02-01 Thread Stefan Weil
Bug 1105670 triggered this patch series. I have currently problems running qemu-iotest. Maybe someone else can test my code with it. Regards Stefan Weil [PATCH 1/7] block/vpc: Fix most coding style warnings and errors [PATCH 2/7] block/vpc: Add link to available VHD documentation [PATCH 3/7] blo

[Qemu-devel] [PATCH 1/7] block/vpc: Fix most coding style warnings and errors

2013-02-01 Thread Stefan Weil
Only C99 comments remain unfixed. Signed-off-by: Stefan Weil --- block/vpc.c | 94 +-- 1 file changed, 52 insertions(+), 42 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 7948609..1c55c21 100644 --- a/block/vpc.c +++ b/block/v

[Qemu-devel] [PATCH 7/7] block/vpc: Use macros for magic constants

2013-02-01 Thread Stefan Weil
BDRV_SECTOR_SIZE is replaced by VHD_SECTOR_SIZE when the sector size is VHD specific. Signed-off-by: Stefan Weil --- block/vpc.c | 59 ++- 1 file changed, 34 insertions(+), 25 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index e89

[Qemu-devel] [PATCH 4/7] block/vpc: Improve vpc_open (optimisation and error handling)

2013-02-01 Thread Stefan Weil
* Always read the footer at the end of the image. The footer exists for all kinds of VHD images, so there is no need to read its copy at the start of dynamic VHD images. * Return error codes from bdrv_pread like in other block drivers. * Return -EMEDIUMTYPE for wrong medium (missing signature

Re: [Qemu-devel] [PATCH 3/4] make usb devices configurable

2013-02-01 Thread Paolo Bonzini
Il 01/02/2013 13:00, Gerd Hoffmann ha scritto: > - smardcard: ccid-card-emulated depends on that one *and* > CONFIG_SMARTCARD_NSS. I don't think we have an elegant > way to handle that. RfC Makefile hack follows as separate > patch. Yes, your 4/4 is how it is done in other places.

[Qemu-devel] libvirt fails to start guest with latest code checkins

2013-02-01 Thread Bruce Rogers
I get the following error message starting a linux guest via libvirt with the latest qemu git head: brogers2:/ # virsh start sles11 error: Failed to start domain sles11 error: internal error process exited while connecting to monitor: WARNING: failed to find acpi-dsdt.aml qemu-kvm: -device

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-01 Thread Anthony Liguori
Michael Tokarev writes: > 02.02.2013 00:36, Anthony Liguori wrote: >> Michael Tokarev writes: >> >>> 02.02.2013 00:18, Michael Tokarev wrote: Just a heads-up for now, no real diagnostics or anything like that. Current git master (a9c87c586ba9ee290792a98dc126b2861b7f8b03), when boo

Re: [Qemu-devel] [QEMU]Installed qemu-img and qemu/qemu-img have different size

2013-02-01 Thread Brian Jackson
On Fri, 1 Feb 2013 22:04:02 +0800 harryxiyou wrote: > Hi all, > > I did following operations to install QEMU to my PC. > > 1. git clone git://git.qemu.org/qemu.git > 2. cd qemu > 3, git reset --hard v1.3.0 > 4, ./configure > 5, make > 6, sudo make install > > After step 6, i did following jobs

Re: [Qemu-devel] [PATCH for-1.4 0/8] -numa option parsing fixes (v3)

2013-02-01 Thread Anthony Liguori
Eduardo Habkost writes: > Ping? > > If this is not 1.4 material, it's no problem to me. I just wanted to > know if this is being ignored because it's too late for 1.4, or because > it was lost in some black hole. I would apply this but this thread is a PITA to sort through. You should do full r

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-01 Thread Michael Tokarev
02.02.2013 00:36, Anthony Liguori wrote: Michael Tokarev writes: 02.02.2013 00:18, Michael Tokarev wrote: Just a heads-up for now, no real diagnostics or anything like that. Current git master (a9c87c586ba9ee290792a98dc126b2861b7f8b03), when booted a windows guest, results in no virtio-net i

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-01 Thread Anthony Liguori
Michael Tokarev writes: > 02.02.2013 00:18, Michael Tokarev пишет: >> Just a heads-up for now, no real diagnostics or anything like that. >> >> Current git master (a9c87c586ba9ee290792a98dc126b2861b7f8b03), when booted >> a windows guest, results in no virtio-net inside. Neither winXP nor Win7,

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-01 Thread Michael Tokarev
02.02.2013 00:18, Michael Tokarev пишет: Just a heads-up for now, no real diagnostics or anything like that. Current git master (a9c87c586ba9ee290792a98dc126b2861b7f8b03), when booted a windows guest, results in no virtio-net inside. Neither winXP nor Win7, neither older nor latest (22 Jan 2013

Re: [Qemu-devel] [RFC][PATCH]Add timestamp to error message

2013-02-01 Thread Seiji Aguchi
Hi Laszlo, Thank you for reviewing my patch! I will update my patch in accordance with your comment, using gmtime() + strftime() and gettimeofday(). Seiji

Re: [Qemu-devel] [PATCH] xen: fix build problem introduced from per-queue peers

2013-02-01 Thread Andreas Färber
Am 01.02.2013 20:03, schrieb Anthony Liguori: > Reported-by Andreas Färber > Signed-off-by: Anthony Liguori Tested-by: Andreas Färber Andreas > --- > hw/xen_nic.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/xen_nic.c b/hw/xen_nic.c > index 4be077d..34961c2 100644 > --- a/hw

[Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-01 Thread Michael Tokarev
Just a heads-up for now, no real diagnostics or anything like that. Current git master (a9c87c586ba9ee290792a98dc126b2861b7f8b03), when booted a windows guest, results in no virtio-net inside. Neither winXP nor Win7, neither older nor latest (22 Jan 2013) virtio-net drivers works. Windows displ

Re: [Qemu-devel] [Bug 1105670] [NEW] Converting vpc image to raw results in an image that is smaller than it should be.

2013-02-01 Thread Jeff Cody
On Fri, Feb 01, 2013 at 07:04:36PM +0100, Stefan Weil wrote: > Am 01.02.2013 18:48, schrieb Jeff Cody: > > On Wed, Jan 30, 2013 at 10:24:44AM +0100, Stefan Hajnoczi wrote: > >> On Sat, Jan 26, 2013 at 03:21:27AM -, Peter Rehley wrote: > >>> Public bug reported: > >> CCed Stefan Weil and Jeff Co

Re: [Qemu-devel] [PATCH V20 7/8] Introduce --enable-tpm-passthrough configure option

2013-02-01 Thread Corey Bryant
On 01/18/2013 11:02 AM, Stefan Berger wrote: Introduce --enable-tpm-passthrough configure option. Signed-off-by: Stefan Berger --- configure | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 73fc146..f54d40e 100755 --- a/config

Re: [Qemu-devel] [PATCH V20 2/8] Add TPM (frontend) hardware interface (TPM TIS) to QEMU

2013-02-01 Thread Corey Bryant
On 01/18/2013 11:02 AM, Stefan Berger wrote: This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to QEMU. The code is largely based on the previous implementation for Xen but has been significantly extended to meet the standard's requirements, such as the support fo

Re: [Qemu-devel] [PATCH V20 5/8] Add a TPM Passthrough backend driver implementation

2013-02-01 Thread Corey Bryant
On 01/18/2013 11:02 AM, Stefan Berger wrote: From Andreas Niederl's original posting with adaptations where necessary: This patch is based of off version 9 of Stefan Berger's patch series "QEMU Trusted Platform Module (TPM) integration" and adds a new backend driver for it. This patch add

[Qemu-devel] [PATCH] xen: fix build problem introduced from per-queue peers

2013-02-01 Thread Anthony Liguori
Reported-by Andreas Färber Signed-off-by: Anthony Liguori --- hw/xen_nic.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/xen_nic.c b/hw/xen_nic.c index 4be077d..34961c2 100644 --- a/hw/xen_nic.c +++ b/hw/xen_nic.c @@ -326,8 +326,6 @@ static int net_init(struct XenDevice *xendev)

Re: [Qemu-devel] [RFC][PATCH]Add timestamp to error message

2013-02-01 Thread Laszlo Ersek
Hello Seiji-san, On 02/01/13 15:53, Seiji Aguchi wrote: > A logic calculating a time is copied from libvirt, src/util/virtime.c. > +static void error_print_timestamp(void) Are gmtime() + strftime() unsuitable for some reason? Also, since the timestamp is ultimately printed with millisecond res

Re: [Qemu-devel] [Bug 1105670] [NEW] Converting vpc image to raw results in an image that is smaller than it should be.

2013-02-01 Thread Stefan Weil
Am 01.02.2013 18:48, schrieb Jeff Cody: > On Wed, Jan 30, 2013 at 10:24:44AM +0100, Stefan Hajnoczi wrote: >> On Sat, Jan 26, 2013 at 03:21:27AM -, Peter Rehley wrote: >>> Public bug reported: >> CCed Stefan Weil and Jeff Cody who may be thoughts on this bug. >> >> If you would like to contribu

Re: [Qemu-devel] patch to fix EXC_BAD_ACCESS on Mac OS X

2013-02-01 Thread Peter Maydell
On 1 February 2013 12:14, Christopher Friedt wrote: > I've been digging through a bunch of runtime errors in OS X. One of > them was an EXC_BAD_ACCESS (segfault) caused by some code in > main-loop.c that accessed uninitialized stack variables. Please see > the attached patch. The problem still exi

[Qemu-devel] [PATCH 3/7] qdev_prop_parse(): report errors via Error

2013-02-01 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- hw/qdev-properties.h |4 +++- hw/qdev-monitor.c| 26 +- hw/qdev-properties.c | 12 3 files changed, 32 insertions(+), 10 deletions(-) diff --git a/hw/qdev-properties.h b/hw/qdev-properties.h index ddcf774..e33f31b

Re: [Qemu-devel] [PATCH V4 RESEND 05/22] net: intorduce qemu_del_nic()

2013-02-01 Thread Eric Blake
On 02/01/2013 12:39 AM, Jason Wang wrote: s/intorduce/introduce/ in the subject > To support multiqueue nic, this patch separate the nic destructor from s/separate/separates/ > qemu_del_net_client() to a new helper qemu_del_nic() since the mapping > bettween s/bettween/between/ > NiCState an

[Qemu-devel] [RFC][PATCH]Add timestamp to error message

2013-02-01 Thread Seiji Aguchi
[Issue] When we offer a customer support service and a problem happens in a customer's system, we try to understand the problem by comparing what the customer reports with message logs of the customer's system. In this case, we often need to know when the problem happens. But, currently, there

Re: [Qemu-devel] patch to fix EXC_BAD_ACCESS on Mac OS X

2013-02-01 Thread Christopher Friedt
Actually, disabling assertions, qemu appears to enter an infinite loop where the above assertion fails. Boo. On Fri, Feb 1, 2013 at 7:14 AM, Christopher Friedt wrote: > Hi folks, > > I've been digging through a bunch of runtime errors in OS X. One of > them was an EXC_BAD_ACCESS (segfault) caused

[Qemu-devel] patch to fix EXC_BAD_ACCESS on Mac OS X

2013-02-01 Thread Christopher Friedt
Hi folks, I've been digging through a bunch of runtime errors in OS X. One of them was an EXC_BAD_ACCESS (segfault) caused by some code in main-loop.c that accessed uninitialized stack variables. Please see the attached patch. The problem still exists in the master branch of the git repository. I

Re: [Qemu-devel] [Bug 1105670] [NEW] Converting vpc image to raw results in an image that is smaller than it should be.

2013-02-01 Thread Jeff Cody
On Wed, Jan 30, 2013 at 10:24:44AM +0100, Stefan Hajnoczi wrote: > On Sat, Jan 26, 2013 at 03:21:27AM -, Peter Rehley wrote: > > Public bug reported: > > CCed Stefan Weil and Jeff Cody who may be thoughts on this bug. > > If you would like to contribute your patch, please see > http://wiki.qe

[Qemu-devel] [PATCH 6/7] qbus_find(): report errors via Error

2013-02-01 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- hw/qdev-monitor.c | 29 +++-- 1 files changed, 15 insertions(+), 14 deletions(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index 83540fc..0c01b04 100644 --- a/hw/qdev-monitor.c +++ b/hw/qdev-monitor.c @@ -324,7 +324,7 @@ static

[Qemu-devel] [PATCH 4/7] qbus_find_recursive(): reorganize

2013-02-01 Thread Laszlo Ersek
Eliminate the "match" variable, and move the remaining locals to the narrowest possible scope. Signed-off-by: Laszlo Ersek --- hw/qdev-monitor.c | 35 --- 1 files changed, 16 insertions(+), 19 deletions(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c inde

[Qemu-devel] [PATCH 5/7] qbus_find_recursive(): terminate search by name in case of fatal error

2013-02-01 Thread Laszlo Ersek
Use an Error to communicate the "stop the search" message. Signed-off-by: Laszlo Ersek --- hw/qdev-monitor.c | 24 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index 284dafa..83540fc 100644 --- a/hw/qdev-monitor.

[Qemu-devel] [PATCH 1/7] remove some trailing whitespace

2013-02-01 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- hw/qdev-monitor.c |2 +- vl.c |8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index 4e2a92b..3ec9e49 100644 --- a/hw/qdev-monitor.c +++ b/hw/qdev-monitor.c @@ -490,7 +490,7 @@ D

[Qemu-devel] [PATCH 2/7] do_device_add(): look up "device" opts list with qemu_find_opts_err()

2013-02-01 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- hw/qdev-monitor.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index 3ec9e49..32be5a2 100644 --- a/hw/qdev-monitor.c +++ b/hw/qdev-monitor.c @@ -590,14 +590,17 @@ void do_info_qdm(Monitor *mon

[Qemu-devel] [PATCH 7/7] qdev_device_add(): report errors with Error

2013-02-01 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- hw/qdev-monitor.h |3 ++- hw/qdev-monitor.c | 29 +++-- vl.c |9 +++-- 3 files changed, 24 insertions(+), 17 deletions(-) diff --git a/hw/qdev-monitor.h b/hw/qdev-monitor.h index 9ec4850..3760bf5 100644 --- a/hw/

[Qemu-devel] [PATCH 0/7] propagate Errors to do_device_add()

2013-02-01 Thread Laszlo Ersek
This series is the first in converting do_device_add() to qapi. The following call chains have been modified: do_device_add -> qemu_find_opts -> error_report do_device_add -> qdev_device_add -> qerror_report do_device_add -> qdev_device_add -> qbus_find -> qbus_find_recursive -> qerror_rep

Re: [Qemu-devel] QEMU buildbot maintenance state

2013-02-01 Thread Christian Berendt
I merged the two pending pull requests and added the configurations of the qemu-kvm and kvm buildbots to the GitHub repository. The daily cronjob on the buildbot system is now active and the configuration provided on GitHub will now be used. The open change requests will be processed tomorrow

Re: [Qemu-devel] [PATCH V20 4/8] Build the TPM frontend code

2013-02-01 Thread Corey Bryant
On 01/18/2013 11:02 AM, Stefan Berger wrote: Build the TPM frontend code that has been added so far. Signed-off-by: Stefan Berger --- Makefile.objs| 1 + configure| 11 +++ hw/Makefile.objs | 3 +++ 3 files changed, 15 insertions(+) diff --git a/Makefile.objs b/Mak

Re: [Qemu-devel] [PATCH V20 3/8] Add a debug register

2013-02-01 Thread Corey Bryant
On 01/18/2013 11:02 AM, Stefan Berger wrote: This patch uses the possibility to add a vendor-specific register and adds a debug register useful for dumping the TIS's internal state. This register is only active in a debug build (#define DEBUG_TIS). Signed-off-by: Stefan Berger --- hw/tpm_ti

Re: [Qemu-devel] RFC migration of zero pages

2013-02-01 Thread Paolo Bonzini
Il 31/01/2013 10:48, Gleb Natapov ha scritto: >> Also I notice that the bottle neck in migrating unmapped pages is the >> detection of those pages >> because we map the pages in order to check them, for a large guest this is >> very expensive as mapping a page >> results in a page fault in the ho

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 5/5] send memory over RDMA as blocks are iterated

2013-02-01 Thread Michael R. hines
Excellent, thank you. On 02/01/2013 05:01 AM, Orit Wasserman wrote: On 01/31/2013 09:10 PM, Michael R. hines wrote: Sorry, I didn't go into enough detail about the problem I'm having in the loop: The loop that's not breaking is inside qemu_loadvm_state(), not ram_save_block(). I understand n

Re: [Qemu-devel] [PATCH qom-cpu-next 6/6] cpu: Add CPUArchState pointer to CPUState

2013-02-01 Thread Richard Henderson
On 02/01/2013 04:38 AM, Andreas Färber wrote: The target-specific ENV_GET_CPU() macros have allowed us to navigate from CPUArchState to CPUState. The reverse direction was not supported. Avoid introducing CPU_GET_ENV() macros by initializing an untyped pointer that is initialized in derived insta

[Qemu-devel] [buildbot patch 4/6] use --disable-debug-info

2013-02-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qemu-master.cfg |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qemu-master.cfg b/qemu-master.cfg index dc5a7a8..2502ced 100644 --- a/qemu-master.cfg +++ b/qemu-master.cfg @@ -696,9 +696,11 @@ def create_build_factory(repourl, branch="

[Qemu-devel] [buildbot patch 3/6] fix out-of-tree build

2013-02-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qemu-master.cfg |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qemu-master.cfg b/qemu-master.cfg index 4c45f23..dc5a7a8 100644 --- a/qemu-master.cfg +++ b/qemu-master.cfg @@ -690,11 +690,13 @@ def create_build_factory(repourl, branch="HE

[Qemu-devel] [buildbot patch 2/6] make tests configurable

2013-02-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qemu-master.cfg | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/qemu-master.cfg b/qemu-master.cfg index 2f793c1..4c45f23 100644 --- a/qemu-master.cfg +++ b/qemu-master.cfg @@ -683,7 +683,7 @@ from buildbot.steps.shell import Confi

[Qemu-devel] [PATCH 10/13] dmg: Use g_free instead of free

2013-02-01 Thread Stefan Hajnoczi
From: Kevin Wolf The buffers are allocated with g_(re)alloc, so use g_free to free them. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/dmg.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/block/dmg.c b/block/dmg.c index 53be25d..6d8

Re: [Qemu-devel] [PATCH for-1.4] Revert "e1000: no need auto-negotiation if link was down"

2013-02-01 Thread Amos Kong
On Fri, Feb 01, 2013 at 08:29:48AM -0600, mdroth wrote: > On Fri, Feb 01, 2013 at 03:20:59PM +0800, Amos Kong wrote: > > On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: > > > This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. > > > > > > I'm not sure what issue the origina

[Qemu-devel] [PATCH v2 4/9] slirp: switch to GPollFD

2013-02-01 Thread Stefan Hajnoczi
Slirp uses rfds/wfds/xfds more extensively than other QEMU components. The rarely-used out-of-band TCP data feature is used. That means we need the full table of select(2) to g_poll(3) events: rfds -> G_IO_IN | G_IO_HUP | G_IO_ERR wfds -> G_IO_OUT | G_IO_ERR xfds -> G_IO_PRI I came up wit

Re: [Qemu-devel] [PATCH for-1.4] Revert "e1000: no need auto-negotiation if link was down"

2013-02-01 Thread Amos Kong
On Fri, Feb 01, 2013 at 08:49:00AM -0600, mdroth wrote: > On Fri, Feb 01, 2013 at 03:53:22PM +0800, Amos Kong wrote: > > On Fri, Feb 01, 2013 at 03:20:59PM +0800, Amos Kong wrote: > > > On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: > > > > This reverts commit 84dd2120247a7d25ff1bb33

[Qemu-devel] [buildbot patch 0/6] buildbot update

2013-02-01 Thread Gerd Hoffmann
Hi, Goes on top of stefans update. Untested. Shoveling over some goodies from my local buildbot config. https://github.com/kraxel/buildbot/tree/kraxel (will create a pull req in a moment) One question on the buildslave config (which isn't in the tree for security reasons): Do you have max_b

[Qemu-devel] [buildbot patch 1/6] add linebreaks to make create_build_factory more readable

2013-02-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qemu-master.cfg | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/qemu-master.cfg b/qemu-master.cfg index 03db6ee..2f793c1 100644 --- a/qemu-master.cfg +++ b/qemu-master.cfg @@ -681,17 +681,29 @@ from buildbot.steps.sh

[Qemu-devel] [PATCH 11/13] parallels: Fix bdrv_open() error handling

2013-02-01 Thread Stefan Hajnoczi
From: Kevin Wolf Return -errno instead of -1 on errors. Hey, no memory leak to fix here while we're touching it! Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/parallels.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/block/pa

Re: [Qemu-devel] [PATCH 4/7 v2] KVM regsync: Add register bitmap parameter to do_kvm_cpu_synchronize_state

2013-02-01 Thread Jason J. Herne
On 01/24/2013 07:40 AM, Alexander Graf wrote: I think for now the best choice for get_regs() would be to ignore the FULL/RESET bits and always keep the syncing as it happens today under the RUNTIME umbrella only. So all of get_regs() only checks for RUNTIME. Whenever get_xxx() happens, a bit g

[Qemu-devel] [PATCH 06/13] bochs: Fix bdrv_open() error handling

2013-02-01 Thread Stefan Hajnoczi
From: Kevin Wolf Return -errno instead of -1 on errors. While touching the code, fix a memory leak. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/bochs.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/block/bochs.c b/block/boch

[Qemu-devel] [buildbot patch 5/6] save config.log

2013-02-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qemu-master.cfg |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qemu-master.cfg b/qemu-master.cfg index 2502ced..04d26bf 100644 --- a/qemu-master.cfg +++ b/qemu-master.cfg @@ -699,7 +699,9 @@ def create_build_factory(repourl, branch="HEAD

[Qemu-devel] [PATCH 01/13] qemu-iotests: Add regression test for b7ab0fea

2013-02-01 Thread Stefan Hajnoczi
From: Kevin Wolf It turned out that the change in b7ab0fea was actually a real qcow2 corruption fix. This is a reproducer for the bug. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/047 | 75 ++ tests/qemu-iotest

[Qemu-devel] [buildbot patch 6/6] add log tail to failure reports

2013-02-01 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- qemu-master.cfg | 27 +++ 1 file changed, 27 insertions(+) diff --git a/qemu-master.cfg b/qemu-master.cfg index 04d26bf..b54ceb4 100644 --- a/qemu-master.cfg +++ b/qemu-master.cfg @@ -45,6 +45,32 @@ emailAddressesNotify = ["gol...@b1-sys

[Qemu-devel] [PATCH 13/13] block/raw-posix: Build fix for O_ASYNC

2013-02-01 Thread Stefan Hajnoczi
From: Andreas Färber Commit eeb6b45d48800e96f67ef2a5c80332557fd45ddb (block: raw-posix image file reopen) broke the build on OpenIndiana. illumos has no O_ASYNC. Exclude it from flags to be compared and instead assert that it is not set where defined. Cf. e61ab1da7e98357da47c54d8f893b9bd6ff2f7f

[Qemu-devel] [PATCH 04/13] vmdk: Allow selecting SCSI adapter in image creation

2013-02-01 Thread Stefan Hajnoczi
From: Othmar Pasteka Introduce a new option "adapter_type" when converting to vmdk images. It can be one of the following: ide (default), buslogic, lsilogic or legacyESX (according to the vmdk spec from vmware). In case of a non-ide adapter, heads is set to 255 instead of the 16. The latter is u

Re: [Qemu-devel] [PATCH V20 1/8] Support for TPM command line options

2013-02-01 Thread Corey Bryant
Thanks for the fixes since the last version. I have a few comments below. Apologies for not catching some of these the first time through. On 01/18/2013 11:02 AM, Stefan Berger wrote: This patch adds support for TPM command line options. The command line options supported here are ./qemu-...

[Qemu-devel] [PATCH 03/13] block: Adds mirroring tests for resized images

2013-02-01 Thread Stefan Hajnoczi
From: Vishvananda Ishaya This test verifies two mirroring issues are fixed with resized images: * sync='top' creates an image that is the proper size * sync='full' doesn't cause an assertion failure and crash qemu Reviewed-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- tests/qemu-iot

Re: [Qemu-devel] [PATCH 2/4] fix scripts/make_device_config.sh

2013-02-01 Thread Gerd Hoffmann
On 02/01/13 14:38, Andreas Färber wrote: > Am 01.02.2013 13:00, schrieb Gerd Hoffmann: >> Make it handle multiple include statements in a file. >> >> Signed-off-by: Gerd Hoffmann >> --- >> scripts/make_device_config.sh |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a

Re: [Qemu-devel] [PATCH] configure: Undefine _FORTIFY_SOURCE prior using it

2013-02-01 Thread Michal Privoznik
On 01.02.2013 10:54, Andreas Färber wrote: > Am 31.01.2013 11:15, schrieb Michal Privoznik: >> Currently, we are enforcing the _FORTIFY_SOURCE=2 without any >> previous detection if the macro has been already defined, e.g. >> by environment, or is just enabled by compiler by default. >> >> Signed-o

[Qemu-devel] [PATCH 02/13] block: Fix is_allocated_above with resized files

2013-02-01 Thread Stefan Hajnoczi
From: Vishvananda Ishaya In an image chain, if the base image is smaller than the current image, we need to make sure to use the current images count of unallocated blocks once we get to the end of the base image. Without this change the code will return 0 blocks when it gets to the end of the ba

Re: [Qemu-devel] [PULL 0/4] generic linux-user patches

2013-02-01 Thread Peter Maydell
On 1 February 2013 15:05, Anthony Liguori wrote: > Laurent Vivier writes: >> Please pull this linux-user patches queue into master. >> >> All these patches have already been sent and reviewed on the mailing list. > Did you use git-request-pull to generate this? Perhaps your mailer > munged all

[Qemu-devel] [PATCH 07/13] cloop: Fix bdrv_open() error handling

2013-02-01 Thread Stefan Hajnoczi
From: Kevin Wolf Return -errno instead of -1 on errors. While touching the code, fix a memory leak. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/cloop.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/block/cloop.c b/bl

[Qemu-devel] [PATCH for 1.5] virtio: make virtio device's structures public.

2013-02-01 Thread fred . konrad
From: KONRAD Frederic These structures must be made public to avoid two memory allocations for refactored virtio devices. Signed-off-by: KONRAD Frederic --- hw/virtio-balloon.c| 15 --- hw/virtio-balloon.h| 14 ++ hw/virtio-blk.c| 16 hw

  1   2   >