Re: [Qemu-devel] kvm segfaulting

2013-02-12 Thread Stefan Priebe - Profihost AG
Hi Paolo, sadly no luck. A VM crashed again. [ ~]# addr2line -e /usr/lib/debug/usr/bin/kvm -f 24040c virtio_scsi_command_complete hw/virtio-scsi.c:429 Same point like last time: static void virtio_scsi_command_complete(SCSIRequest *r, uint32_t status, siz

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.4] net: Avoid NULL function pointer dereference on cleanup

2013-02-12 Thread Alexander Graf
Am 13.02.2013 um 00:13 schrieb David Gibson : > On Tue, Feb 12, 2013 at 11:16:06PM +0100, Andreas Färber wrote: >> The pSeries machine and some other devices don't supply a cleanup >> callback. Revert part of 1ceef9f27359cbe92ef124bf74de6f792e71f6fb that >> started calling it unconditionally. >

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Implements h_read hcall

2013-02-12 Thread David Gibson
On Tue, Feb 12, 2013 at 11:07:10PM +0100, Alexander Graf wrote: > > On 07.02.2013, at 12:28, Erlon Cruz wrote: > > > From: Erlon Cruz > > > > This h_call is useful for DLPAR in future amongst other things. Given an > > index > > it fetches the corresponding PTE stored in the htab. > > > > Sig

[Qemu-devel] [PATCH] Fix guest OS hangs on boot when 64bit PCI BAR present

2013-02-12 Thread Alexey Korolev
At the moment may_overlap flag of MemoryRegion structure is ignored by the address range assignment process. This may lead to guest OS hangs if critical qemu resources are overlapped by PCI BARs. For example ivshmem 64bit PCI BAR may overlap kvm-apic-msi under certain conditions. This patch adds a

[Qemu-devel] [BUG] Guest OS hangs on boot when 64bit BAR present (kvm-apic -msi resource conflict)

2013-02-12 Thread Alexey Korolev
Sometime ago I reported an issue about guest OS hang when 64bit BAR present. http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg03189.html http://lists.gnu.org/archive/html/qemu-devel/2012-12/msg00413.html Some more investigation has been done, so in this post I'll try to explain why it happ

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.4] net: Avoid NULL function pointer dereference on cleanup

2013-02-12 Thread David Gibson
On Tue, Feb 12, 2013 at 11:16:06PM +0100, Andreas Färber wrote: > The pSeries machine and some other devices don't supply a cleanup > callback. Revert part of 1ceef9f27359cbe92ef124bf74de6f792e71f6fb that > started calling it unconditionally. Note that Alex Graf has now accepted a patch from me wh

Re: [Qemu-devel] [PATCH V18 08/10] libqblock: libqblock API implement

2013-02-12 Thread Wenchao Xia
On Sat, Feb 9, 2013 at 7:42 AM, Wenchao Xia wrote: This patch contains implemention for APIs. Basically it is a layer above qemu block general layer now. qb_image_new() will try do init for this library. Signed-off-by: Wenchao Xia --- libqblock/libqblock-error.c | 49 +++ libqbloc

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Remove vestigial PowerPC 620 support (v2)

2013-02-12 Thread David Gibson
On Tue, Feb 12, 2013 at 11:18:06PM +0100, Alexander Graf wrote: > > On 12.02.2013, at 23:16, Alexander Graf wrote: > > > > > On 12.02.2013, at 11:23, Andreas Färber wrote: > > > >> Am 12.02.2013 03:16, schrieb David Gibson: > >>> The PowerPC 620 was the very first 64-bit PowerPC implementation,

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor commands and setup RDMA capabilities

2013-02-12 Thread Michael R Hines
Acknowledged. /* * Michael R. Hines * http://researcher.ibm.com/person/us-mrhines */ From: Eric Blake To: "Michael R. Hines" , Cc: qemu-devel@nongnu.org, Anthony Liguori/Austin/IBM@IBMUS, Bulent Abali/Watson/IBM@IBMUS, Michael R Hines/Watson/IBM@IBMUS, Gokul B Kandiraju/Watson/IBM@IBMUS

Re: [Qemu-devel] [PATCH for-1.4] libi2c-omap: Fix endianness dependency

2013-02-12 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4 0/2] trace: fix trace/simple.c compiler warnings

2013-02-12 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4 0/2] block-migration: fix pending() and iterate() return values

2013-02-12 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] qemu-log: Remove qemu_log_try_set_file() and its users

2013-02-12 Thread Michael Walle
Peter Maydell schrieb: >Remove the function qemu_log_try_set_file() and its users (which >are all in TCG code generation functions for various targets). >This function was added to abstract out code which was originally >written as "if (!logfile) logfile = stderr;" in order that BUG: >case co

Re: [Qemu-devel] [PATCH v1 2/2] configure/Make: Build libfdt from submodule DTC

2013-02-12 Thread Peter Crosthwaite
Hi Alex, On Wed, Feb 13, 2013 at 7:55 AM, Alexander Graf wrote: > > On 07.02.2013, at 07:08, Peter Crosthwaite wrote: > >> Configure to use the DTC submodule to build libfdt when no system libfdt >> is found. Prompt to install the DTC submodule if --enable-fdt is set but >> no DTC can be found. >

Re: [Qemu-devel] [PATCH RFC v2 0/5] qtest: tmp105-test BE fix for 1.4 and MMIO support

2013-02-12 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4] migration: restrict scope of incoming fd read handler

2013-02-12 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Anthony Liguori
mdroth writes: > On Tue, Feb 12, 2013 at 05:56:00PM +0100, Markus Armbruster wrote: >> Gerd Hoffmann writes: >> >> > Hi, >> > >> >> But why nested discriminators? >> >> >> >> regular files: type=file >> >> serial : type=port, data.type=serial >> >> parallel : type=port,

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4 RESEND v2 0/2] qtest: tmp105-test BE fix for 1.4

2013-02-12 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.4] libqtest: Fix documentation copy&paste errors

2013-02-12 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] pseries: Add cleanup hook for PAPR virtual LAN device

2013-02-12 Thread Andreas Färber
Am 11.02.2013 05:59, schrieb David Gibson: > Currently the spapr-vlan device does not supply a cleanup call for its > NetClientInfo structure. With current qemu versions, that leads to a SEGV > on exit, when net_cleanup() attempts to call the cleanup handlers on all > net clients. > > Signed-off-

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Gerd Hoffmann
Hi, > But why nested discriminators? > > regular files: type=file > serial : type=port, data.type=serial > parallel : type=port, data.type=parallel > > Simpler, and closer to existing -chardev: > > regular files: type=file > serial : type=serial > paral

[Qemu-devel] [PULL 1.4 0/3] s390 patch queue 2013-02-12

2013-02-12 Thread Alexander Graf
Hi Blue / Aurelien, This is my current fix queue for s390 on 1.4. Please pull. Alex The following changes since commit 03ec2f83087de34924489eeae0ea6fe7785cc050: Kuo-Jung Su (1): hw/m25p80.c: add WRSR(0x01) support are available in the git repository at: git://repo.or.cz/qemu/agra

[Qemu-devel] [PATCH 3/3] s390: Fix handling of iscs.

2013-02-12 Thread Alexander Graf
From: Cornelia Huck There are two ways to express an interruption subclass: - As a bitmask, as used in cr6. - As a number, as used in the I/O interruption word. Unfortunately, we have treated to I/O interruption word as if it contained the bitmask as well, which went unnoticed so far as - (queue

[Qemu-devel] [PATCH 2/3] s390: Keep I/O interrupts enabled for all iscs.

2013-02-12 Thread Alexander Graf
From: Cornelia Huck do_io_interrupt() would stop scanning further iscs if it found an I/O interrupt it could inject. This might cause the pending interrupt indication for I/O interrupts to be reset although there might be queued I/O interrupts for subsequent iscs. Fix this by reordering the logi

[Qemu-devel] [PATCH 1/3] s390/sclpconsole: prevent char layer callback during initialization

2013-02-12 Thread Alexander Graf
From: Christian Borntraeger Starting a qemu with an sclp console and pressing a key very early can result in "qemu-system-s390x: hw/s390x/sclpconsole.c:60: receive_from_chr_layer: Assertion `scon->iov' failed." Lets make sure that the init process is finished, since the iov is allocated after CH

Re: [Qemu-devel] [PATCH] pseries: Implements h_read hcall

2013-02-12 Thread Alexander Graf
On 07.02.2013, at 12:28, Erlon Cruz wrote: > From: Erlon Cruz > > This h_call is useful for DLPAR in future amongst other things. Given an index > it fetches the corresponding PTE stored in the htab. > > Signed-off-by: Erlon Cruz > --- > hw/spapr_hcall.c | 58 +++

Re: [Qemu-devel] [PATCH v1 1/2] dtc: add submodule

2013-02-12 Thread Alexander Graf
On 07.02.2013, at 07:08, Peter Crosthwaite wrote: > Add dtc submodule as a fallback for old distros. > Picking version 1.3.0. as this is the most recently tagged stable version. > > Signed-off-by: Peter Crosthwaite > --- > .gitmodules |3 +++ > dtc |1 + > 2 files changed, 4 inser

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Remove vestigial PowerPC 620 support (v2)

2013-02-12 Thread Alexander Graf
On 12.02.2013, at 23:16, Alexander Graf wrote: > > On 12.02.2013, at 11:23, Andreas Färber wrote: > >> Am 12.02.2013 03:16, schrieb David Gibson: >>> The PowerPC 620 was the very first 64-bit PowerPC implementation, but >>> hardly anyone ever actually used the chips. qemu notionally supports t

Re: [Qemu-devel] [PATCH] target-ppc: Remove vestigial PowerPC 620 support (v2)

2013-02-12 Thread Alexander Graf
On 12.02.2013, at 11:23, Andreas Färber wrote: > Am 12.02.2013 03:16, schrieb David Gibson: >> The PowerPC 620 was the very first 64-bit PowerPC implementation, but >> hardly anyone ever actually used the chips. qemu notionally supports the >> 620, but since we don't actually have code to implem

[Qemu-devel] [PATCH for-1.4] net: Avoid NULL function pointer dereference on cleanup

2013-02-12 Thread Andreas Färber
The pSeries machine and some other devices don't supply a cleanup callback. Revert part of 1ceef9f27359cbe92ef124bf74de6f792e71f6fb that started calling it unconditionally. Cc: Jason Wang Signed-off-by: Andreas Färber --- net/net.c |4 +++- 1 Datei geändert, 3 Zeilen hinzugefügt(+), 1 Zeile

[Qemu-devel] [Bug 1062220] Re: qemu-system-arm crashed with SIGABRT in cpu_abort()

2013-02-12 Thread Serge Hallyn
Marking incomplete pending more information about the origin of u-boot.bin per comment #8. ** Changed in: qemu (Ubuntu) Status: Confirmed => Incomplete ** Changed in: qemu-linaro (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a membe

Re: [Qemu-devel] [PATCH for-1.4] target-ppc: Fix "G2leGP3" PVR

2013-02-12 Thread Alexander Graf
On 11.02.2013, at 21:54, Andreas Färber wrote: > Unlike derived PVR constants mapped to CPU_POWERPC_G2LEgp3, the > "G2leGP3" model definition itself used the CPU_POWERPC_G2LEgp1 PVR. > > Fixing this will allow to alias CPU_POWERPC_G2LEgp3-using types to > "G2leGP3". > > Cc: qemu-sta...@nongnu.o

Re: [Qemu-devel] [PATCH for-1.4?] target-ppc: Fix CPU_POWERPC_MPC8547E

2013-02-12 Thread Alexander Graf
On 11.02.2013, at 21:53, Andreas Färber wrote: > It was defined to ..._MPC8545E_v21 rather than ..._MPC8547E_v21. > Due to both resolving to CPU_POWERPC_e500v2_v21 this did not show. > > Fixing this nontheless helps with QOM'ifying CPU aliases. > > Signed-off-by: Andreas Färber Thanks, applie

Re: [Qemu-devel] [PATCH] pseries: Add cleanup hook for PAPR virtual LAN device

2013-02-12 Thread Alexander Graf
On 11.02.2013, at 05:59, David Gibson wrote: > Currently the spapr-vlan device does not supply a cleanup call for its > NetClientInfo structure. With current qemu versions, that leads to a SEGV > on exit, when net_cleanup() attempts to call the cleanup handlers on all > net clients. > > Signed-

Re: [Qemu-devel] uhci: cancel delay for unregistered queues

2013-02-12 Thread Hans de Goede
Hi, On 02/12/2013 05:46 PM, Gerd Hoffmann wrote: On 02/12/13 15:38, Jan Kiszka wrote: Hi, was just debugging a memory corruption of my USB driver inside QEMU - and so far only there: I have a queue registered with the UHCI controller on an input endpoint that continuously generates data. At s

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> Now let's take another step back: a character device is just a file. >> Why can't we use plain ChardevFile for it? > > It's not. A Unix character device is a special file. > First, the file backend allows input and output being different files, > and the input

Re: [Qemu-devel] [PATCH v1 2/2] configure/Make: Build libfdt from submodule DTC

2013-02-12 Thread Alexander Graf
On 07.02.2013, at 07:08, Peter Crosthwaite wrote: > Configure to use the DTC submodule to build libfdt when no system libfdt > is found. Prompt to install the DTC submodule if --enable-fdt is set but > no DTC can be found. > > DTC has no out-of-tree build capability, so the configure will symlin

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread mdroth
On Tue, Feb 12, 2013 at 05:56:00PM +0100, Markus Armbruster wrote: > Gerd Hoffmann writes: > > > Hi, > > > >> But why nested discriminators? > >> > >> regular files: type=file > >> serial : type=port, data.type=serial > >> parallel : type=port, data.type=parallel > >> >

Re: [Qemu-devel] [PATCH 0/2] small fixes for s390x

2013-02-12 Thread Alexander Graf
On 05.02.2013, at 09:53, Christian Borntraeger wrote: > Alex, > > The following changes since commit 1143df5c72fd1f88b4b2b0774d11bf0ba6eb44d6: > > target-s390x: Pass S390CPU to s390_{add, del}_running_cpu() (2013-02-01 > 01:58:50 +0100) > > are available in the git repository at: > > g...@

Re: [Qemu-devel] [PATCH V4 RESEND 09/22] net: multiqueue support

2013-02-12 Thread Andreas Färber
Am 01.02.2013 08:39, schrieb Jason Wang: > diff --git a/net/net.c b/net/net.c > index 98a1934..9806862 100644 > --- a/net/net.c > +++ b/net/net.c [...] > @@ -271,9 +287,7 @@ static void qemu_cleanup_net_client(NetClientState *nc) > { > QTAILQ_REMOVE(&net_clients, nc, next); > > -if (nc-

Re: [Qemu-devel] [PATCH V4 RESEND 09/22] net: multiqueue support

2013-02-12 Thread Alexander Graf
On 01.02.2013, at 08:39, Jason Wang wrote: > This patch adds basic multiqueue support for qemu. The idea is simple, an > array > of NetClientStates were introduced in NICState, parse_netdev() were extended > to > find and match all NetClientStates belongs to the backend and place their > pointe

Re: [Qemu-devel] [PATCH for-1.4 stable] block/curl: disable extra protocols to prevent CVE-2013-0249

2013-02-12 Thread Andreas Färber
Am 08.02.2013 08:49, schrieb Stefan Hajnoczi: > There is a buffer overflow in libcurl POP3/SMTP/IMAP. The workaround is > simple: disable extra protocols so that they cannot be exploited. Full > details here: > > http://curl.haxx.se/docs/adv_20130206.html > > QEMU only cares about HTTP, HTTPS

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor commands and setup RDMA capabilities

2013-02-12 Thread Markus Armbruster
Eric Blake writes: > On 02/11/2013 08:06 PM, Michael R. Hines wrote: > > [no need to top-post on a technical list] > >> None of the other migration QMP commands use dashes. > > Then how do you explain 'query-migrate', 'migrate-set-capabilities', > 'query-migrate-capabilities', 'migrate-set-cache-

Re: [Qemu-devel] [PATCH] qemu-log: default to stderr for logging output

2013-02-12 Thread Peter Maydell
On 12 February 2013 18:16, Andreas Färber wrote: > Am 12.02.2013 18:58, schrieb Peter Maydell: >> Debug output will only appear on stderr if you asked for it by >> passing -d something. > I was thinking of default options, so if nothing gets printed by default > that's okay with me. Yep. If we e

Re: [Qemu-devel] [PATCH] qemu-log: default to stderr for logging output

2013-02-12 Thread Andreas Färber
Am 12.02.2013 18:58, schrieb Peter Maydell: > On 12 February 2013 17:50, Andreas Färber wrote: >> Am 12.02.2013 18:33, schrieb Peter Maydell: >>> Stefan suggested that qemu_log should default to stderr, and I >>> agree that it makes more sense than a random file in /tmp/. >>> As noted in the commi

Re: [Qemu-devel] [PATCH V3 2/2] virtio-block: support auto-sensing of block sizes

2013-02-12 Thread Christian Borntraeger
On 08/02/13 15:52, Einar Lueck wrote: > Virtio-blk does not impose fixed block sizes for access to > backing devices. This patch introduces support for auto > lookup of the block sizes of the backing block device. This > automatic lookup needs to be enabled explicitly. Users may > do this by specif

Re: [Qemu-devel] [PATCH] qemu-log: default to stderr for logging output

2013-02-12 Thread Peter Maydell
On 12 February 2013 17:50, Andreas Färber wrote: > Am 12.02.2013 18:33, schrieb Peter Maydell: >> Stefan suggested that qemu_log should default to stderr, and I >> agree that it makes more sense than a random file in /tmp/. >> As noted in the commit message, this is technically an incompatible >>

Re: [Qemu-devel] [PATCH] qemu-log: default to stderr for logging output

2013-02-12 Thread Alexander Graf
Am 12.02.2013 um 18:50 schrieb Andreas Färber : > Am 12.02.2013 18:33, schrieb Peter Maydell: >> Switch the default for qemu_log logging output from "/tmp/qemu.log" >> to stderr. This is an incompatible change in some sense, but logging >> is mostly used for debugging purposes so it shouldn't af

Re: [Qemu-devel] [PATCH] qemu-log: default to stderr for logging output

2013-02-12 Thread Andreas Färber
Am 12.02.2013 18:33, schrieb Peter Maydell: > Switch the default for qemu_log logging output from "/tmp/qemu.log" > to stderr. This is an incompatible change in some sense, but logging > is mostly used for debugging purposes so it shouldn't affect production > use. The previous behaviour can be obt

Re: [Qemu-devel] [PATCH] qemu-log: Remove qemu_log_try_set_file() and its users

2013-02-12 Thread Andreas Färber
Am 12.02.2013 17:13, schrieb Peter Maydell: > Remove the function qemu_log_try_set_file() and its users (which > are all in TCG code generation functions for various targets). > This function was added to abstract out code which was originally > written as "if (!logfile) logfile = stderr;" in order

[Qemu-devel] [PATCH] qemu-log: default to stderr for logging output

2013-02-12 Thread Peter Maydell
Switch the default for qemu_log logging output from "/tmp/qemu.log" to stderr. This is an incompatible change in some sense, but logging is mostly used for debugging purposes so it shouldn't affect production use. The previous behaviour can be obtained by adding "-D /tmp/qemu.log" to the command li

[Qemu-devel] [PATCH V2 for-1.5] virtio: make virtio device's structures public.

2013-02-12 Thread fred . konrad
From: KONRAD Frederic These structures must be made public to avoid two memory allocations for refactored virtio devices. Changes V2 <- V1: * Move the dataplane include into the header (virtio-blk). Signed-off-by: KONRAD Frederic --- hw/virtio-balloon.c| 15 --- hw/virtio-

[Qemu-devel] [Bug 1110531] Re: regression booting pxa kernels

2013-02-12 Thread Peter Maydell
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1110531 Title: regression booting pxa kernels Status in QEMU: Fix Committed Bug description

[Qemu-devel] [Bug 986241] Re: Misspelling of env parameter in deregister_dtl() [hw/spapr_hcall.c]

2013-02-12 Thread Oskar Wallgren
Fixed upstream as of this patch: http://git.qemu.org/?p=qemu-stable-1.2.git;a=commitdiff;h=73f7821baca8ec063ace277539bedeb286663965;hp=7fb0bd3473dfb2bb1768072ebbfa5771e8c8af4a -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bu

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor commands and setup RDMA capabilities

2013-02-12 Thread Eric Blake
On 02/11/2013 08:06 PM, Michael R. Hines wrote: [no need to top-post on a technical list] > None of the other migration QMP commands use dashes. Then how do you explain 'query-migrate', 'migrate-set-capabilities', 'query-migrate-capabilities', 'migrate-set-cache-size', 'query-migrate-cache-size'

Re: [Qemu-devel] [PATCH v2] bswap: Fix width of swap in leul_to_cpu

2013-02-12 Thread Richard Henderson
On 2013-02-12 04:33, Jay Foad wrote: The comment's wrong, isn't it? The reason we're not using HOST_LONG_BITS is because it's the wrong thing, not because of any include loops. Err, well, yes. But there *was* an include loop when we were using that symbol. Feel free to push a comment fix thr

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-12 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> But why nested discriminators? >> >> regular files: type=file >> serial : type=port, data.type=serial >> parallel : type=port, data.type=parallel >> >> Simpler, and closer to existing -chardev: >> >> regular files: type=file >> s

Re: [Qemu-devel] [RFC ppc-next 39/39] target-ppc: Convert CPU definitions

2013-02-12 Thread Andreas Färber
Am 12.02.2013 11:13, schrieb Andreas Färber: > Turn the array of model definitions into a set of self-registering QOM > types with their own class_init. Unique identifiers are obtained from > the combination of PVR, SVR and family identifiers; this requires all > alias #defines to be removed from t

Re: [Qemu-devel] uhci: cancel delay for unregistered queues

2013-02-12 Thread Gerd Hoffmann
On 02/12/13 15:38, Jan Kiszka wrote: > Hi, > > was just debugging a memory corruption of my USB driver inside QEMU - > and so far only there: > > I have a queue registered with the UHCI controller on an input endpoint > that continuously generates data. At some point my driver decides to > stop r

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-12 Thread Markus Armbruster
Stefan Weil writes: > Hi Jeff, > > the scenario which you describe here is not one which I'd call > "realistic". Why should a user create a VHD image with VPC [...] Maybe, but why run a risk for 1.4? Let's delay your fix to 1.5. Gives us plenty of time to hash out the issues.

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-12 Thread Stefan Weil
Am 12.02.2013 16:18, schrieb Jeff Cody: > On Tue, Feb 12, 2013 at 03:47:38PM +0100, Stefan Weil wrote: >> Am 11.02.2013 22:20, schrieb Jeff Cody: >>> On Mon, Feb 11, 2013 at 03:14:36PM -0600, Anthony Liguori wrote: Paolo Bonzini writes: > Il 11/02/2013 21:13, Anthony Liguori ha scrit

[Qemu-devel] [PATCH] qemu-log: Remove qemu_log_try_set_file() and its users

2013-02-12 Thread Peter Maydell
Remove the function qemu_log_try_set_file() and its users (which are all in TCG code generation functions for various targets). This function was added to abstract out code which was originally written as "if (!logfile) logfile = stderr;" in order that BUG: case code which did an unguarded "fprintf

Re: [Qemu-devel] [PATCH v2] bswap: Fix width of swap in leul_to_cpu

2013-02-12 Thread Andreas Färber
Am 12.02.2013 13:33, schrieb Jay Foad: >> +#if ULONG_MAX == UINT32_MAX >> +return le_bswap(v, 32); >> +#elif ULONG_MAX == UINT64_MAX >> +return le_bswap(v, 64); >> +#else >> +# error Unknown sizeof long >> +#endif > > Is there any reason this can't be simplified to something like: > >

Re: [Qemu-devel] [PATCH V3 2/2] virtio-block: support auto-sensing of block sizes

2013-02-12 Thread Stefan Hajnoczi
On Fri, Feb 08, 2013 at 03:52:35PM +0100, Einar Lueck wrote: > @@ -22,6 +25,26 @@ void blkconf_serial(BlockConf *conf, char **serial) > } > } > > +void blkconf_blocksizes(BlockConf *conf) > +{ > +int block_size; > + > +if (!conf->physical_block_size) { > +if (bdrv_ioctl(conf

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-12 Thread Anthony Liguori
Kevin Wolf writes: > Am 11.02.2013 22:14, schrieb Anthony Liguori: >> Paolo Bonzini writes: >> >>> Il 11/02/2013 21:13, Anthony Liguori ha scritto: Applied. Thanks. Regards, Anthony Liguori >>> >>> I guess this was a mistake, please revert. >> >> No, it wasn't. The p

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-12 Thread Jeff Cody
On Tue, Feb 12, 2013 at 03:47:38PM +0100, Stefan Weil wrote: > Am 11.02.2013 22:20, schrieb Jeff Cody: > > On Mon, Feb 11, 2013 at 03:14:36PM -0600, Anthony Liguori wrote: > >> Paolo Bonzini writes: > >> > >>> Il 11/02/2013 21:13, Anthony Liguori ha scritto: > Applied. Thanks. > >

Re: [Qemu-devel] [PATCH for-1.4 1/2] trace: use glib atomic int types

2013-02-12 Thread Markus Armbruster
Stefan Hajnoczi writes: > Juan reported that RHEL 6.4 hosts give compiler warnings because we use > unsigned int while glib prototypes use volatile gint in trace/simple.c. > > trace/simple.c:223: error: pointer targets in passing argument 1 of > 'g_atomic_int_compare_and_exchange' differ in si

Re: [Qemu-devel] KVM call agenda for 2013-02-12

2013-02-12 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda topics you are interested in. As there is no topics, call gets canceled. Happy hacking, Juan.

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-12 Thread Stefan Weil
Am 12.02.2013 12:24, schrieb Stefan Hajnoczi: > On Tue, Feb 12, 2013 at 10:12:59AM +0100, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> Il 12/02/2013 09:42, Kevin Wolf ha scritto: >> No, it wasn't. The patch was reviewed and tested. What's the problem. >> It's proposed for 1.4

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-12 Thread Stefan Weil
Am 11.02.2013 22:20, schrieb Jeff Cody: > On Mon, Feb 11, 2013 at 03:14:36PM -0600, Anthony Liguori wrote: >> Paolo Bonzini writes: >> >>> Il 11/02/2013 21:13, Anthony Liguori ha scritto: Applied. Thanks. Regards, Anthony Liguori >>> I guess this was a mistake, please rev

Re: [Qemu-devel] [PATCH 3/5] target-i386: Slim conversion to X86CPU subclasses

2013-02-12 Thread Eduardo Habkost
On Mon, Feb 11, 2013 at 02:52:49AM +0100, Igor Mammedov wrote: > On Fri, 8 Feb 2013 16:13:02 -0200 > Eduardo Habkost wrote: > > > On Fri, Feb 08, 2013 at 05:54:50PM +0100, Andreas Färber wrote: > > > Am 08.02.2013 15:52, schrieb Eduardo Habkost: > > > > On Fri, Feb 08, 2013 at 01:58:42PM +0100, I

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-12 Thread Stefan Weil
Am 12.02.2013 09:42, schrieb Kevin Wolf: > It makes qemu use the wrong size for VHD images created by Virtual PC > that used to work with qemu. This is a regression that can result in > images appearing corrupted in Virtual PC, and we need very good > justification to apply such a patch. > > At the

[Qemu-devel] uhci: cancel delay for unregistered queues

2013-02-12 Thread Jan Kiszka
Hi, was just debugging a memory corruption of my USB driver inside QEMU - and so far only there: I have a queue registered with the UHCI controller on an input endpoint that continuously generates data. At some point my driver decides to stop reading and removes the QH (with a lot of TDs attached

Re: [Qemu-devel] kvm segfaulting

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 14:46, Stefan Priebe - Profihost AG ha scritto: > Hi, > > thanks - i applied the patch to the latest master. I hope that this will > solve my issue. Will this one get integrated in 1.4 final? No, only 1.4.1 and 1.5 unfortunately. Let's give it a week for you to test it. Paolo

Re: [Qemu-devel] [PATCH for-1.4 0/2] block-migration: fix pending() and iterate() return values

2013-02-12 Thread Juan Quintela
Stefan Hajnoczi wrote: > This series finally ensures that we never complete block migration before the > entire disk image has been transferred. > > Juan explained to me on IRC yesterday what the .save_live_pending() and > .save_live_iterate() are supposed to return. I had misunderstood them when

Re: [Qemu-devel] [PATCH v10 0/4] Add subcommand compare for qemu-img

2013-02-12 Thread Stefan Hajnoczi
On Tue, Feb 12, 2013 at 08:00:21AM +0100, Miroslav Rezanina wrote: > This is 10th version of patch adding compare subcommand that > compares two images. Compare has following criteria: > - only data part is compared > - unallocated sectors are not read > to be zeroed/unallocated to compare rest

Re: [Qemu-devel] kvm segfaulting

2013-02-12 Thread Stefan Priebe - Profihost AG
Hi, thanks - i applied the patch to the latest master. I hope that this will solve my issue. Will this one get integrated in 1.4 final? Greets, Stefan Am 11.02.2013 15:42, schrieb Paolo Bonzini: > Il 11/02/2013 15:18, Stefan Priebe - Profihost AG ha scritto: Some trace that a request was ac

Re: [Qemu-devel] [PATCH v3 0/5] qcow2: add fragmentation and compression info support

2013-02-12 Thread Stefan Hajnoczi
On Thu, Feb 07, 2013 at 05:15:00PM +0100, Stefan Hajnoczi wrote: > Applies on kevin/block-next (2700d627e4d73bb2aacb832a93ffac8fec78b1fd). > > This series adds fragmentation info support to qcow2 and then adds compression > info. Previously only QED supported fragmentation info. Note that > frag

[Qemu-devel] [PATCH for-1.4 2/2] trace: deal with deprecated glib thread functions

2013-02-12 Thread Stefan Hajnoczi
g_thread_create() was deprecated in favor of g_thread_new() and g_cond_new() was deprecated in favor of GCond initialization. If the host has glib 2.31 or newer, avoid using the deprecated functions. This patch solves compiler warnings that are generated when glib's deprecated functions are used.

[Qemu-devel] [PATCH for-1.4 1/2] trace: use glib atomic int types

2013-02-12 Thread Stefan Hajnoczi
Juan reported that RHEL 6.4 hosts give compiler warnings because we use unsigned int while glib prototypes use volatile gint in trace/simple.c. trace/simple.c:223: error: pointer targets in passing argument 1 of 'g_atomic_int_compare_and_exchange' differ in signedness These variables are only

[Qemu-devel] [PATCH for-1.4 0/2] trace: fix trace/simple.c compiler warnings

2013-02-12 Thread Stefan Hajnoczi
I hope these patches can still be merged for QEMU 1.4. They allow ./configure --enable-trace-backend=simple compilation to succeed without compiler warnings. The 'simple' backend was using deprecated g_thread_create() and g_cond_new() functions. A signed/unsigned pointer mismatch when using the

[Qemu-devel] Advice on some configuration parameters

2013-02-12 Thread Fabio Fantoni
I'm making patches to enable some qemu upstream features in xen that are missing in libxl. I'm trying to do it just by giving arguments to qemu, and I want them to be dynamic (e.g. without physical addresses if possible) and concise. I'm confused about usb configuration. Looking at what virt-m

Re: [Qemu-devel] [PATCH v3 0/5] qcow2: add fragmentation and compression info support

2013-02-12 Thread Kevin Wolf
Am 07.02.2013 17:15, schrieb Stefan Hajnoczi: > Applies on kevin/block-next (2700d627e4d73bb2aacb832a93ffac8fec78b1fd). > > This series adds fragmentation info support to qcow2 and then adds compression > info. Previously only QED supported fragmentation info. Note that > fragmentation info only

[Qemu-devel] [PATCH 2/2] Revert "block/vpc: Fix size calculation"

2013-02-12 Thread Stefan Hajnoczi
This reverts commit f880defbb06708d30a38ce9f2667067626acdd38. Jeff Cody's testing revealed that the interpretation of size differs even between VirtualPC and HyperV. Revert this so there is time to consider the impact of any backwards incompatible behavior this change creates. Signed-off-by: Ste

[Qemu-devel] [PATCH 1/2] block/raw-posix: detect readonly Linux block devices using BLKROGET

2013-02-12 Thread Stefan Hajnoczi
Linux block devices can be set read-only with "blockdev --setro ". The same thing can be done for LVM volumes using "lvchange --permission r ". This read-only setting is independent of device node permissions. Therefore the device can still be opened O_RDWR but actual writes will fail. This res

[Qemu-devel] [PULL for-1.4 0/2] Block patches

2013-02-12 Thread Stefan Hajnoczi
Revert the vpc size fix which breaks compatibility with VirtualPC. Also error out on startup when a read-only block device is configured as a read-write -drive. This makes Linux read-only block devices behave like read-only regular files, and the error is reported immediately on startup instead o

Re: [Qemu-devel] [PATCH v2] bswap: Fix width of swap in leul_to_cpu

2013-02-12 Thread Jay Foad
> @@ -458,7 +458,15 @@ static inline void cpu_to_32wu(uint32_t *p, uint32_t v) > > static inline unsigned long leul_to_cpu(unsigned long v) > { > -return le_bswap(v, HOST_LONG_BITS); > +/* In order to break an include loop between here and > + qemu-common.h, don't rely on HOST_LONG_

[Qemu-devel] [PATCH ppc-next 13/39] target-ppc: Extract 7448 alias

2013-02-12 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-ppc/translate_init.c |5 ++--- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index c0c7579..edd6ee0 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/tran

Re: [Qemu-devel] [PATCH for-1.4 0/2] block-migration: fix pending() and iterate() return values

2013-02-12 Thread Paolo Bonzini
Il 12/02/2013 10:37, Stefan Hajnoczi ha scritto: > This series finally ensures that we never complete block migration before the > entire disk image has been transferred. > > Juan explained to me on IRC yesterday what the .save_live_pending() and > .save_live_iterate() are supposed to return. I h

Re: [Qemu-devel] [PATCH v10 3/4] This patch adds new qemu-img subcommand that compares content of two disk images.

2013-02-12 Thread Miroslav Rezanina
- Original Message - > From: "Kevin Wolf" > To: "Miroslav Rezanina" > Cc: qemu-devel@nongnu.org, pbonz...@redhat.com, stefa...@redhat.com, > ebl...@redhat.com > Sent: Tuesday, February 12, 2013 10:36:07 AM > Subject: Re: [PATCH v10 3/4] This patch adds new qemu-img subcommand that > com

[Qemu-devel] [PATCH ppc-next 30/39] target-ppc: Extract MPC82xx aliases to *_HiP4

2013-02-12 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-ppc/translate_init.c | 24 ++-- 1 Datei geändert, 6 Zeilen hinzugefügt(+), 18 Zeilen entfernt(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index ea512bd..42e1f2d 100644 --- a/target-ppc/translate_init.c +

[Qemu-devel] [PATCH ppc-next 03/39] target-ppc: Make -cpu "ppc" an alias to "ppc32"

2013-02-12 Thread Andreas Färber
Drop the #if 0'ed alternative to make it "ppc64" for TARGET_PPC64. If we ever want to change it, we can more easily do so now. Signed-off-by: Andreas Färber --- target-ppc/translate_init.c | 30 ++ 1 Datei geändert, 2 Zeilen hinzugefügt(+), 28 Zeilen entfernt(-) di

[Qemu-devel] [PATCH ppc-next 23/39] target-ppc: Extract MPC85xx aliases

2013-02-12 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-ppc/translate_init.c | 119 +-- 1 Datei geändert, 34 Zeilen hinzugefügt(+), 85 Zeilen entfernt(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 8434e9e..a2f1030 100644 --- a/target-pp

[Qemu-devel] [PATCH ppc-next 21/39] target-ppc: Extract 603r alias

2013-02-12 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-ppc/translate_init.c |5 ++--- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index c1619a4..3bbce1b 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/tran

[Qemu-devel] [PATCH ppc-next 05/39] target-ppc: Extract MGT823/MPC8xx as aliases

2013-02-12 Thread Andreas Färber
They used different PVRs but were defined to MPC8xx. Signed-off-by: Andreas Färber --- target-ppc/translate_init.c | 107 +-- 1 Datei geändert, 31 Zeilen hinzugefügt(+), 76 Zeilen entfernt(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translat

[Qemu-devel] [PATCH ppc-next 27/39] target-ppc: Extract e200 alias

2013-02-12 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-ppc/translate_init.c |5 ++--- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index cf4f286..929ecba 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/tran

[Qemu-devel] [PATCH ppc-next 29/39] target-ppc: Extract MPC8247/MPC8248/MPC8270-80 aliases

2013-02-12 Thread Andreas Färber
This depends on the fix for "G2leGP3" PVR. Signed-off-by: Andreas Färber --- target-ppc/translate_init.c | 33 - 1 Datei geändert, 12 Zeilen hinzugefügt(+), 21 Zeilen entfernt(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index ca421

[Qemu-devel] [PATCH] Revert "block/vpc: Fix size calculation"

2013-02-12 Thread Stefan Hajnoczi
This reverts commit f880defbb06708d30a38ce9f2667067626acdd38. Jeff Cody's testing revealed that the interpretation of size differs even between VirtualPC and HyperV. Revert this so there is time to consider the impact of any backwards incompatible behavior this change creates. Signed-off-by: Ste

[Qemu-devel] [PATCH ppc-next 22/39] target-ppc: Extract 601/601v aliases

2013-02-12 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-ppc/translate_init.c | 10 -- 1 Datei geändert, 4 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 3bbce1b..8434e9e 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc

  1   2   >