Re: [Qemu-devel] [PATCH for-1.4 v3 3/6] error: Strip trailing '\n' from error string arguments (again)

2013-02-19 Thread Markus Armbruster
Alex Williamson writes: > On Fri, 2013-02-08 at 21:22 +0100, Markus Armbruster wrote: >> Commit 6daf194d and be62a2eb got rid of a bunch, but they keep coming >> back. Tracked down with this Coccinelle semantic patch: >> >> @r@ >> expression err, eno, cls, fmt; >> position p; >>

Re: [Qemu-devel] using -net dump with tap networking

2013-02-19 Thread Stefan Hajnoczi
On Tue, Feb 19, 2013 at 12:37:28PM +1100, Alexey Kardashevskiy wrote: > On 14/02/13 21:26, Stefan Hajnoczi wrote: > > Now I want to enable network dump. With the old "-net" syntax I could do > that with "-net dump" but I cannot with the new syntax, tried many > variants, none works. Wh

Re: [Qemu-devel] [PATCH 10/19] char: add gio watch fn for tcp backends

2013-02-19 Thread Amit Shah
On (Mon) 18 Feb 2013 [15:48:07], Anthony Liguori wrote: > From: Amit Shah > > Signed-off-by: Amit Shah > --- > qemu-char.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/qemu-char.c b/qemu-char.c > index e59e580..160bcea 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -246

Re: [Qemu-devel] [PATCH 7/9] gtk: add translation support (v4)

2013-02-19 Thread Stefan Hajnoczi
On Mon, Feb 18, 2013 at 05:57:03PM -0600, Anthony Liguori wrote: > This includes a de_DE translation from Kevin Wolf and an it translation from > Paolo Bonzini. > > Cc: Paolo Bonzini > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Anthony Liguori > --- > v1 -> v4 > - Don't use '|| exi

Re: [Qemu-devel] [PATCH 00/19] chardev flow control

2013-02-19 Thread Hans de Goede
Hi, On 02/18/2013 10:47 PM, Anthony Liguori wrote: This series implements an idea from Paolo to introduce flow control in the char layer by converting all char backends to use GIOChannels internally. Then we can just use the existing IO watch support in glib to implement flow control. This is

Re: [Qemu-devel] [PATCH v9 1/3] iov: Factor out hexdumper

2013-02-19 Thread Gerd Hoffmann
Hi, > I ran git blame on it and its actually Gerds code. Gerd you want > co-authorship and the (c) of this hexdump.c? Yes. And don't break iov_hexdump() behavior please. I suggest to just iov_to_buf() into a temporary buffer, then pass that to a single hexdump call. When calling hexdump for

Re: [Qemu-devel] Patch queue for qemu-1.1.3 stable release

2013-02-19 Thread Paolo Bonzini
Il 19/02/2013 06:25, Michael Tokarev ha scritto: > Hello. > > Since there's no interest in 1.1 series - neither from users nor > from the official qemu maintainers, I'm cancelling this series. > > Thanks all. I don't follow. Paolo

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 4/6] initialize RDMA options when QEMU first runs on command-line

2013-02-19 Thread Paolo Bonzini
Il 19/02/2013 07:00, Michael R. Hines ha scritto: > Yes, this is done at migration time (see functions "rdma_client_init" > and "rdma_server_prepare()") > > To explain the host and port: > > The separate host and port are used by the library "librdmacm". This > library performs a network translat

Re: [Qemu-devel] [RFC PATCH 1/4] qemu: add castagnoli crc32c checksum algorithm

2013-02-19 Thread Stefan Hajnoczi
On Mon, Feb 18, 2013 at 06:03:29PM -0500, Jeff Cody wrote: > This adds the Castagnoli CRC32C algorithm, using the 0x11EDC6F41 > polynomial. > > This is extracted from the linux kernel cryptographic crc32.c module. > > The algorithm is based on: > > Castagnoli93: Guy Castagnoli and Stefan Braeuer

Re: [Qemu-devel] [PATCH 8/9] gtk: make default UI (v3)

2013-02-19 Thread Andreas Färber
Am 19.02.2013 00:57, schrieb Anthony Liguori: > A user can still enable SDL with '-sdl' or '-display sdl' but start making the > default display GTK by default. > > I'd also like to deprecate the SDL display and remove it in a few releases. > > Signed-off-by: Anthony Liguori > --- > v1 -> v3: >

Re: [Qemu-devel] using -net dump with tap networking

2013-02-19 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Tue, Feb 19, 2013 at 12:37:28PM +1100, Alexey Kardashevskiy wrote: >> On 14/02/13 21:26, Stefan Hajnoczi wrote: >> >> Now I want to enable network dump. With the old "-net" syntax I could do >> that with "-net dump" but I cannot with the new syntax, tried man

Re: [Qemu-devel] [RFC PATCH 2/4] block: vhdx header for the QEMU support of VHDX images

2013-02-19 Thread Stefan Hajnoczi
On Mon, Feb 18, 2013 at 06:03:30PM -0500, Jeff Cody wrote: > +/* the guid is a 16 byte unique ID - the definition for this used by > + * Microsoft is not just 16 bytes though - it is a structure that is defined, > + * so we need to follow it here so that endianness does not trip us up */ > + > +typ

Re: [Qemu-devel] [PATCH 7/9] gtk: add translation support (v4)

2013-02-19 Thread Paolo Bonzini
Il 19/02/2013 00:57, Anthony Liguori ha scritto: > This includes a de_DE translation from Kevin Wolf and an it translation from > Paolo Bonzini. > > Cc: Paolo Bonzini > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Anthony Liguori > --- > v1 -> v4 > - Don't use '|| exit 1' with sub-in

[Qemu-devel] [Bug 1129957] Re: Performance issue running quest image on qemu compiled for Win32 platform

2013-02-19 Thread Jacob Kroon
** Attachment added: "qemu-perf-wine.txt" https://bugs.launchpad.net/qemu/+bug/1129957/+attachment/3536183/+files/qemu-perf-wine.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1129957 Title:

[Qemu-devel] [Bug 1129957] [NEW] Performance issue running quest image on qemu compiled for Win32 platform

2013-02-19 Thread Jacob Kroon
Public bug reported: I'm seeing performance issues when booting a guest image on qemu 1.4.0 compiled for the Win32 platform. The same image boots a lot faster on the same computer running qemu/linux on Fedora via VmWare, and even running the Win32 exectuable via Wine performs better than runnin

[Qemu-devel] [Bug 1129957] Re: Performance issue running quest image on qemu compiled for Win32 platform

2013-02-19 Thread Jacob Kroon
** Attachment added: "qemu-perf-win32.txt" https://bugs.launchpad.net/qemu/+bug/1129957/+attachment/3536182/+files/qemu-perf-win32.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1129957 Title:

Re: [Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-19 Thread Stefan Hajnoczi
On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote: > This is preliminary and beta support for the VHDX image format, > as specified in: >"VHDX Format Specification v0.95", published 4/12/2012 > https://www.microsoft.com/en-us/download/details.aspx?id=29681 > > This RFC patch has th

[Qemu-devel] [Bug 1128935] Re: MIPS r4k TLB modified exception generated for TLB entries not visible to the TLBP instruction

2013-02-19 Thread Jakub Jermar
** Also affects: helenos Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1128935 Title: MIPS r4k TLB modified exception generated for TLB entries not visib

[Qemu-devel] [Bug 1129571] [NEW] libreoffice armhf FTBFS

2013-02-19 Thread Alex Chiang
Public bug reported: We have been experiencing FTBFS of LibreOffice 3.5.7, 12.04, armhf in the launchpad buildds. We believe this is likely due to an error in qemu. While we do not have a small test case yet, we do have a build log (attaching here). The relevant snippet from the build log is: 3

Re: [Qemu-devel] [PATCH 3/9] ui: add basic GTK gui (v4)

2013-02-19 Thread Paolo Bonzini
Il 19/02/2013 10:07, Gerd Hoffmann ha scritto: >> > +if (s->surface) { >> > +cairo_surface_destroy(s->surface); >> > +} > Isn't cairo backed by pixman under the hood? Yes, but there is no API to construct a cairo surface from a pixman image. Paolo > I suspect you should be able t

[Qemu-devel] Problems about "live backup vm" patch, which is issued by Wenchao Xia.

2013-02-19 Thread Liu Ji
Hello Wenchao Xia, I am very interested in your "live backup vm" patch of qemu, which have been sent to qemu-devel mail-list in "8 Dec 2012". http://lists.gnu.org/archive/html/qemu-devel/2012-12/msg00800.html I have test your patch in qemu-1.3.1, but I have two problems: 1) After I exec the "migr

Re: [Qemu-devel] [PATCH for-1.4 v2 4/6] qemu-option: Disable two helpful messages that got broken recently

2013-02-19 Thread Markus Armbruster
Laszlo Ersek writes: > On 02/15/13 01:20, Laszlo Ersek wrote: >> On 02/14/13 17:36, Luiz Capitulino wrote: >>> On Thu, 14 Feb 2013 14:31:50 +0100 >>> Markus Armbruster wrote: > chardev-add: the schema defines an object type for each backend (ChardevFile, ChardevSocket, ...), and collec

[Qemu-devel] [Bug 1129571] Re: libreoffice armhf FTBFS

2013-02-19 Thread Alex Chiang
** Attachment added: "buildlog_ubuntu-precise-armhf.libreoffice_1%3A3.5.7-0ubuntu4allston1test2_FAILEDTOBUILD.txt.gz" https://bugs.launchpad.net/qemu/+bug/1129571/+attachment/3535507/+files/buildlog_ubuntu-precise-armhf.libreoffice_1%253A3.5.7-0ubuntu4allston1test2_FAILEDTOBUILD.txt.gz -- Yo

Re: [Qemu-devel] [PATCH 7/9] gtk: add translation support (v4)

2013-02-19 Thread Paolo Bonzini
Il 19/02/2013 09:30, Stefan Hajnoczi ha scritto: >> > >> > - Zoom to Fit >> > - Grab on Hover >> > >> > Kevin/Stefan/et al, could you provide translations for these? > I don't use localized software so I'm not sure what the standard terms > for "Zoom to Fit" or "Grab on Hover" are, sorry. Kevin?

Re: [Qemu-devel] [PATCH for-1.4 v2 4/6] qemu-option: Disable two helpful messages that got broken recently

2013-02-19 Thread Markus Armbruster
Laszlo Ersek writes: > Hi, > > sorry for the late answer. I can only address the netdev_add / > opts-visitor stuff now. > > On 02/14/13 17:36, Luiz Capitulino wrote: >> On Thu, 14 Feb 2013 14:31:50 +0100 >> Markus Armbruster wrote: >>> Luiz Capitulino writes: On Thu, 14 Feb 2013 10:45:22 +

[Qemu-devel] [Bug 1128935] [NEW] MIPS r4k TLB modified exception generated for TLB entries not visible to the TLBP instruction

2013-02-19 Thread Jakub Jermar
Public bug reported: I occasionally see that the TLBP instruction fails to find the corresponding TLB entry in the TLB Modified exception handler. This behavior is unexpected, because the invocation of the TLB Modified exception suggests there indeed is such an entry in the TLB and only requires

[Qemu-devel] [Bug 1129957] Re: Performance issue running quest image on qemu compiled for Win32 platform

2013-02-19 Thread Jacob Kroon
For linux, the build is done by the native Fedora 18 gcc, 4.7.2 For Win32, the build is done by Fedora 18's mingw compiler, 4.7.2 Configuration for Win32 (from config.log): # Configured with: './configure' '--disable-guest-agent' '--disable-vnc' '--disable-werror' '--extra-cflags=-pg' '--extra-ld

Re: [Qemu-devel] [PATCH v1 2/6] a9mpcore: localised temporary init-only variables

2013-02-19 Thread Andreas Färber
Am 19.02.2013 01:39, schrieb Peter Crosthwaite: > On Tue, Feb 19, 2013 at 4:12 AM, Peter Maydell > wrote: >> On 8 February 2013 04:03, Peter Crosthwaite >> wrote: >>> The DeviceState *mptimer var in a9mp_priv_state was only used by the init >>> function and had no reason for persistence. Made a

[Qemu-devel] [Bug 1128935] Re: MIPS r4k "TLB modified exception" generated for TLB entries that are not visible to the TLBP instruction

2013-02-19 Thread Jakub Jermar
** Summary changed: - MIPS r4k TLB modified exception generated for TLB entries not visible to the TLBP instruction + MIPS r4k "TLB modified exception" generated for TLB entries that are not visible to the TLBP instruction -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [PATCH 3/9] ui: add basic GTK gui (v4)

2013-02-19 Thread Gerd Hoffmann
Hi, On 02/19/13 00:56, Anthony Liguori wrote: > +static void gd_resize(DisplayState *ds) > +{ > +GtkDisplayState *s = ds->opaque; > +cairo_format_t kind; > +int stride; > + > +DPRINTF("resize(width=%d, height=%d)\n", > +ds_get_width(ds), ds_get_height(ds)); > + > +

Re: [Qemu-devel] [PATCH v2 2/2] qom/object.c: Allow itf cast with num_itfs = 0

2013-02-19 Thread Paolo Bonzini
Il 19/02/2013 05:02, Peter Crosthwaite ha scritto: > num_interfaces only tells you how many interfaces the concrete child class has > (as defined in the TypeInfo). This means if you have a child class which > defines > no interfaces of its own, but its parent has interfaces you cannot cast to > t

Re: [Qemu-devel] [PATCH V2] get_tmp_filename: add explicit error message

2013-02-19 Thread Fabien Chouteau
On 02/18/2013 05:37 PM, Markus Armbruster wrote: > I agree with you that the existing error reporting is too unspecific in > many cases, and I applaud your attempt to do something about it, but I'm > afraid this patch creates as many problems as it solves. Details below. > > > In my review of v1,

Re: [Qemu-devel] [PATCH v1 0/6] Cleanup of ARM MPCore

2013-02-19 Thread Peter Maydell
On 19 February 2013 00:52, Peter Crosthwaite wrote: > On Tue, Feb 19, 2013 at 4:53 AM, Peter Maydell > wrote: >> On 8 February 2013 04:03, Peter Crosthwaite >> wrote: >> Generally I like these patches, but I'm curious about what your use >> case is where you don't just create an entire a9mpcore

[Qemu-devel] [PATCH 1/2] coroutine: move pooling to common code

2013-02-19 Thread Paolo Bonzini
The coroutine pool code is duplicated between the ucontext and sigaltstack backends, and absent from the win32 backend. But the code can be shared easily by moving it to qemu-coroutine.c. Signed-off-by: Paolo Bonzini --- coroutine-sigaltstack.c | 43 +--

[Qemu-devel] [PATCH 2/2] coroutine: trim down nesting level in perf_nesting test

2013-02-19 Thread Paolo Bonzini
2 nested coroutines require 20 GB of virtual address space. Only nest 1000 of them so that the test (only enabled with "-m perf" on the command line) runs on 32-bit machines too. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- tests/test-coroutine.c | 2 +- 1 file changed, 1 inse

Re: [Qemu-devel] [PATCH RFT v3 2/5] usb/hcd-ehci: Split off instance_init from realize

2013-02-19 Thread Gerd Hoffmann
On 02/17/13 17:48, Andreas Färber wrote: > This makes the mem MemoryRegion available to derived instance_inits. Breaks usb bus naming, it's always "usb-bus.0" instead if being derived from the device id. Easy reproducer: qemu -readconfig docs/ich9-ehci-uhci.cfg cheers, Gerd

[Qemu-devel] [Bug 1129571] Re: libreoffice armhf FTBFS

2013-02-19 Thread Peter Maydell
Well, the first step would be to provide a reasonably tractable set of reproduce instructions (at minimum, something like "do this to set up a chroot, then in the chroot run this command and watch it SIGILL".) Also checking it still repros on 1.4.0 (just released) would be nice (though I don't thin

[Qemu-devel] [PATCH v3 5/6] add regression tests for backup

2013-02-19 Thread Dietmar Maurer
Simple regression tests using vma-reader and vma-writer. Note: the call to g_thread_init() solves problems with g_slice_alloc() - without that call we get arbitrary crashes. Signed-off-by: Dietmar Maurer --- tests/Makefile | 11 +- tests/backup-test.c | 517

[Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-19 Thread David Woodhouse
As discussed at length already, one potential 'workaround' for KVM brokenness in old kernels (<3.9) with old CPUs (without 'unrestricted guest' support), is to properly reset the PAM registers in the chipset. I say 'workaround' but this would be a proper fix in its own right, and as a side-effect

[Qemu-devel] [PATCH v3 1/6] RFC: Efficient VM backup for qemu

2013-02-19 Thread Dietmar Maurer
This series provides a way to efficiently backup VMs. * Backup to a single archive file * Backup contain all data to restore VM (full backup) * Do not depend on storage type or image format * Avoid use of temporary storage * store sparse images efficiently The file docs/backup-rfc.txt contains mo

Re: [Qemu-devel] [SeaBIOS] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-19 Thread David Woodhouse
On Mon, 2013-02-18 at 23:08 +, David Woodhouse wrote: > Laszlo has hooked up the RCR on the PIIX3 already, so something like > this ought to make it reset the PAM setup *only* if reset via that... > +static void i440fx_reset(DeviceState *ds) > +{ > +PCIDevice *dev = DO_UPCAST(PCIDevice, qd

Re: [Qemu-devel] [PATCH V2] get_tmp_filename: add explicit error message

2013-02-19 Thread Markus Armbruster
Fabien Chouteau writes: > On 02/18/2013 05:37 PM, Markus Armbruster wrote: >> I agree with you that the existing error reporting is too unspecific in >> many cases, and I applaud your attempt to do something about it, but I'm >> afraid this patch creates as many problems as it solves. Details be

[Qemu-devel] [PATCH v3 3/6] add backup related monitor commands

2013-02-19 Thread Dietmar Maurer
We use a generic BackupDriver struct to encapsulate all archive format related function. Another option would be to simply dump to the output fh (pipe), and an external binary saves the data. That way we could move the whole archive format related code out of qemu. Signed-off-by: Dietmar Maurer

[Qemu-devel] [PATCH v3 6/6] add vm state to backups

2013-02-19 Thread Dietmar Maurer
Signed-off-by: Dietmar Maurer --- blockdev.c | 196 +- hmp.c|3 +- qapi-schema.json |6 +- 3 files changed, 200 insertions(+), 5 deletions(-) diff --git a/blockdev.c b/blockdev.c index 50e150d..2f99d08 100644 --- a/b

[Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver

2013-02-19 Thread Dietmar Maurer
Function backup_job_create() creates a block job to backup a block device. The coroutine is started with backup_job_start(). We call backup_do_cow() for each write during backup. That function reads the original data and pass it to backup_dump_cb(). The tracked_request infrastructure is used to s

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-19 Thread Paolo Bonzini
Il 19/02/2013 12:40, David Woodhouse ha scritto: > As discussed at length already, one potential 'workaround' for KVM > brokenness in old kernels (<3.9) with old CPUs (without 'unrestricted > guest' support), is to properly reset the PAM registers in the chipset. > > I say 'workaround' but this wo

Re: [Qemu-devel] [PATCH 20/41] migration: run pending/iterate callbacks out of big lock

2013-02-19 Thread Orit Wasserman
On 02/15/2013 07:46 PM, Paolo Bonzini wrote: > This makes it possible to do blocking writes directly to the socket, > with no buffer in the middle. For RAM, only the migration_bitmap_sync() > call needs the iothread lock. For block migration, it is needed by > the block layer (including bdrv_drai

[Qemu-devel] [PATCH 1/3] Improve grlib-apbuart

2013-02-19 Thread Fabien Chouteau
From: Ronald Hecht From: Ronald Hecht Signed-off-by: Fabien Chouteau --- hw/grlib_apbuart.c | 52 +--- 1 file changed, 37 insertions(+), 15 deletions(-) diff --git a/hw/grlib_apbuart.c b/hw/grlib_apbuart.c index 760bed0..ba1685a 100644 --- a/

Re: [Qemu-devel] [PATCH qom-cpu v2 3/8] cpu: Register VMStateDescription through CPUState

2013-02-19 Thread Eduardo Habkost
On Mon, Feb 18, 2013 at 09:02:55PM +0100, Andreas Färber wrote: > Am 18.02.2013 20:57, schrieb Eduardo Habkost: > > On Mon, Feb 18, 2013 at 08:42:28PM +0100, Andreas Färber wrote: > >> In comparison to DeviceClass::vmsd, CPU VMState is split in two, > >> "cpu_common" and "cpu", and uses cpu_index a

Re: [Qemu-devel] [PATCH v3] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set

2013-02-19 Thread Paolo Bonzini
Il 24/01/2013 10:31, Laszlo Ersek ha scritto: > From : > > Traditional PCI config space access is achieved by writing a 32 bit > value to io port 0xcf8 to identify the bus, device, function and config > register. Port 0xcfc then contains the register in

Re: [Qemu-devel] [PATCH v1 2/6] a9mpcore: localised temporary init-only variables

2013-02-19 Thread Peter Maydell
On 19 February 2013 12:43, Peter Crosthwaite wrote: > On Tue, Feb 19, 2013 at 7:56 PM, Andreas Färber wrote: >> The main point of concern being QMP. QOM realize has the purpose of >> decoupling device creation from device modification and emulation start. >> Thus devices may not be created in ini

Re: [Qemu-devel] [PATCH 20/41] migration: run pending/iterate callbacks out of big lock

2013-02-19 Thread Orit Wasserman
On 02/19/2013 02:43 PM, Paolo Bonzini wrote: > Il 19/02/2013 13:34, Orit Wasserman ha scritto: >> Looks good but locking is complicated .. > > You mean as a fact of life :) or this locking in particular? both :) > > Paolo > >> Reviewed-by: Orit Wasserman >> >> >

Re: [Qemu-devel] [RFC PATCH 2/4] block: vhdx header for the QEMU support of VHDX images

2013-02-19 Thread Jeff Cody
On Tue, Feb 19, 2013 at 10:02:51AM +0100, Stefan Hajnoczi wrote: > On Mon, Feb 18, 2013 at 06:03:30PM -0500, Jeff Cody wrote: > > +/* the guid is a 16 byte unique ID - the definition for this used by > > + * Microsoft is not just 16 bytes though - it is a structure that is > > defined, > > + * so

Re: [Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-19 Thread Jeff Cody
On Tue, Feb 19, 2013 at 10:20:40AM +0100, Stefan Hajnoczi wrote: > On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote: > > This is preliminary and beta support for the VHDX image format, > > as specified in: > >"VHDX Format Specification v0.95", published 4/12/2012 > > https://www.mi

Re: [Qemu-devel] [PATCH 1/3] Improve grlib-apbuart

2013-02-19 Thread Andreas Färber
Am 19.02.2013 12:45, schrieb Fabien Chouteau: > From: Ronald Hecht > > From: Ronald Hecht > > Signed-off-by: Fabien Chouteau Duplicate From header and no proper commit message. The patch is doing too many things at once: Renaming gptimer ->apbuart should go into its own patch for instance and

Re: [Qemu-devel] [PATCH v3 15/20] arm: add Faraday FTMAC110 10/100Mbps ethernet support

2013-02-19 Thread Stefan Hajnoczi
On Tue, Feb 19, 2013 at 09:43:27AM +0800, Kuo-Jung Su wrote: > 2013/2/19 Kuo-Jung Su : > > 2013/2/18 Stefan Hajnoczi : > >> On Mon, Feb 18, 2013 at 05:44:38PM +0800, Kuo-Jung Su wrote: > >>> 2013/2/18 Stefan Hajnoczi : > >>> > On Wed, Feb 06, 2013 at 05:45:19PM +0800, Kuo-Jung Su wrote: > >>> >> Fr

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-19 Thread Andreas Färber
Am 19.02.2013 12:40, schrieb David Woodhouse: > As discussed at length already, one potential 'workaround' for KVM > brokenness in old kernels (<3.9) with old CPUs (without 'unrestricted > guest' support), is to properly reset the PAM registers in the chipset. > > I say 'workaround' but this would

Re: [Qemu-devel] [PATCH 21/41] migration: run setup callbacks out of big lock

2013-02-19 Thread Orit Wasserman
On 02/15/2013 07:46 PM, Paolo Bonzini wrote: > Only the migration_bitmap_sync() call needs the iothread lock. > > Signed-off-by: Paolo Bonzini > --- > arch_init.c | 10 ++ > block-migration.c |2 ++ > include/migration/vmstate.h |2 +- > migration.c

Re: [Qemu-devel] [PATCH v3] vmstate: Make vmstate_register() static inline

2013-02-19 Thread Eduardo Habkost
On Mon, Feb 18, 2013 at 09:47:15PM +0100, Andreas Färber wrote: > This avoids adding a duplicate stub for CONFIG_USER_ONLY. > > Suggested-by: Eduardo Habkost > Signed-off-by: Andreas Färber Reviewed-by: Eduardo Habkost > --- > include/migration/vmstate.h | 12 ++-- > savevm.c

Re: [Qemu-devel] using -net dump with tap networking

2013-02-19 Thread Stefan Hajnoczi
On Tue, Feb 19, 2013 at 09:53:07AM +0100, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Tue, Feb 19, 2013 at 12:37:28PM +1100, Alexey Kardashevskiy wrote: > >> On 14/02/13 21:26, Stefan Hajnoczi wrote: > >> > >> Now I want to enable network dump. With the old "-net" syntax I co

Re: [Qemu-devel] using -net dump with tap networking

2013-02-19 Thread Laszlo Ersek
On 02/19/13 09:53, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> On Tue, Feb 19, 2013 at 12:37:28PM +1100, Alexey Kardashevskiy wrote: >>> On 14/02/13 21:26, Stefan Hajnoczi wrote: >>> >>> Now I want to enable network dump. With the old "-net" syntax I could do >>> that with "-n

Re: [Qemu-devel] [RFC PATCH 2/4] block: vhdx header for the QEMU support of VHDX images

2013-02-19 Thread Stefan Hajnoczi
On Tue, Feb 19, 2013 at 08:11:48AM -0500, Jeff Cody wrote: > On Tue, Feb 19, 2013 at 10:02:51AM +0100, Stefan Hajnoczi wrote: > > On Mon, Feb 18, 2013 at 06:03:30PM -0500, Jeff Cody wrote: > > > +/* Individual region table entry. There may be a maximum of 2047 of > > > these > > > + * > > > + *

Re: [Qemu-devel] [PATCH 10/19] char: add gio watch fn for tcp backends

2013-02-19 Thread Anthony Liguori
Amit Shah writes: > On (Mon) 18 Feb 2013 [15:48:07], Anthony Liguori wrote: >> From: Amit Shah >> >> Signed-off-by: Amit Shah >> --- >> qemu-char.c | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/qemu-char.c b/qemu-char.c >> index e59e580..160bcea 100644 >> --- a/qemu-char

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-19 Thread David Woodhouse
On Tue, 2013-02-19 at 14:38 +0100, Andreas Färber wrote: > So far QEMU does not distinguish between reset types. Therefore I think > it is a bad idea to place QEMU_RESET_HARD in hw/cuda.c without reviewing > per case whether that is actually a hard or soft reset. > > Better and much less intrusive

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-19 Thread David Woodhouse
On Tue, 2013-02-19 at 12:04 +, Peter Maydell wrote: > I'm dubious about this. At the moment we have one set of reset > semantics, which is "this works as if you yanked the power to > the machine and plugged it back in again". Except when it doesn't. Such as the PAM registers on the i440FX, whi

Re: [Qemu-devel] [PATCH 7/9] gtk: add translation support (v4)

2013-02-19 Thread Kevin Wolf
On Tue, Feb 19, 2013 at 09:30:41AM +0100, Stefan Hajnoczi wrote: > On Mon, Feb 18, 2013 at 05:57:03PM -0600, Anthony Liguori wrote: > > 'de_DE' is only missing: > > > > - Zoom to Fit - Auf Fenstergröße skalieren > > - Grab on Hover - Tastatur automatisch einfangen > > Kevin/Stefan/et al, could

Re: [Qemu-devel] [PATCH 6/9] gtk: add support for screen scaling and full screen (v3)

2013-02-19 Thread Kevin Wolf
On Mon, Feb 18, 2013 at 05:57:02PM -0600, Anthony Liguori wrote: > Basic menu items to enter full screen mode and zoom in/out. Unlike SDL, we > don't allow arbitrary scaling based on window resizing. The current behavior > with SDL causes a lot of problems for me. > > Sometimes I accidentally re

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-19 Thread Peter Maydell
On 19 February 2013 13:58, David Woodhouse wrote: > On Tue, 2013-02-19 at 12:04 +, Peter Maydell wrote: >> I'm dubious about this. At the moment we have one set of reset >> semantics, which is "this works as if you yanked the power to >> the machine and plugged it back in again". > > Except wh

Re: [Qemu-devel] KVM call agenda for 2013-02-19

2013-02-19 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please send in any agenda topics you are interested in. There are no topic, so happy hacking. Later, Juan.

Re: [Qemu-devel] [PATCH 10/19] char: add gio watch fn for tcp backends

2013-02-19 Thread Amit Shah
On (Tue) 19 Feb 2013 [07:55:36], Anthony Liguori wrote: > Amit Shah writes: > > > On (Mon) 18 Feb 2013 [15:48:07], Anthony Liguori wrote: > >> From: Amit Shah > >> > >> Signed-off-by: Amit Shah > >> --- > >> qemu-char.c | 7 +++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a

[Qemu-devel] [PATCH] qemu-ga: fix confusing GAChannelMethod comparison

2013-02-19 Thread Stefan Hajnoczi
In commit 7868e26e5930f49ca942311885776b938dcf3b77 ("qemu-ga: add initial win32 support") support was added for qemu-ga on Windows using virtio-serial. Other channel methods (ISA serial and UNIX domain socket) are not supported on Windows. Signed-off-by: Stefan Hajnoczi --- qga/channel-win32.c

Re: [Qemu-devel] [RFC PATCH 4/4] block: add vhdx to Makefile.obj for compile

2013-02-19 Thread Kevin Wolf
On Mon, Feb 18, 2013 at 06:03:32PM -0500, Jeff Cody wrote: > > Signed-off-by: Jeff Cody > --- > block/Makefile.objs | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/Makefile.objs b/block/Makefile.objs > index c067f38..a819577 100644 > --- a/block/Makefile.objs > +++ b/block/Makefi

Re: [Qemu-devel] [PATCH 3/9] ui: add basic GTK gui (v4)

2013-02-19 Thread Kevin Wolf
On Mon, Feb 18, 2013 at 05:56:59PM -0600, Anthony Liguori wrote: > This is minimalistic and just contains the basic widget infrastructure. The > GUI > consists of a menu and a GtkNotebook. To start with, the notebook has its > tabs > hidden which provides a UI that looks very similar to SDL wit

Re: [Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-19 Thread Kevin Wolf
On Tue, Feb 19, 2013 at 08:26:35AM -0500, Jeff Cody wrote: > On Tue, Feb 19, 2013 at 10:20:40AM +0100, Stefan Hajnoczi wrote: > > On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote: > > > +#include "qemu/crc32c.h" > > > +#include "block/vhdx.h" > > > + > > > +#define vhdx_nop(x) do { (void)(

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-19 Thread David Woodhouse
On Tue, 2013-02-19 at 13:31 +0100, Paolo Bonzini wrote: > So you can make the hard reset line a qemu_irq (output in PIIX, input in > i440FX) using qdev_init_gpio_in/out. The input side in the i440FX then > can reset the PAM registers while the output side can pulse it before > calling qemu_system_

Re: [Qemu-devel] [PATCH RFC] memory: drop _overlap variant

2013-02-19 Thread Michael S. Tsirkin
On Thu, Feb 14, 2013 at 08:23:04PM +0200, Avi Kivity wrote: > On Thu, Feb 14, 2013 at 8:12 PM, Michael S. Tsirkin wrote: > >> > >> Is there an actual real problem that needs fixing? > > > > Yes. Guests sometimes cause device BARs to temporary overlap > > the APIC range during BAR sizing. It works

Re: [Qemu-devel] [PATCH 7/9] gtk: add translation support (v4)

2013-02-19 Thread Stefano Stabellini
On Tue, 19 Feb 2013, Paolo Bonzini wrote: > Il 19/02/2013 00:57, Anthony Liguori ha scritto: > > This includes a de_DE translation from Kevin Wolf and an it translation from > > Paolo Bonzini. > > > > Cc: Paolo Bonzini > > Cc: Kevin Wolf > > Cc: Stefan Hajnoczi > > Signed-off-by: Anthony Liguor

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-19 Thread Paolo Bonzini
Il 19/02/2013 15:40, David Woodhouse ha scritto: > On Tue, 2013-02-19 at 13:31 +0100, Paolo Bonzini wrote: >> So you can make the hard reset line a qemu_irq (output in PIIX, input in >> i440FX) using qdev_init_gpio_in/out. The input side in the i440FX then >> can reset the PAM registers while the

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-19 Thread David Woodhouse
On Tue, 2013-02-19 at 14:08 +, Peter Maydell wrote: > On 19 February 2013 13:58, David Woodhouse wrote: > > On Tue, 2013-02-19 at 12:04 +, Peter Maydell wrote: > >> I'm dubious about this. At the moment we have one set of reset > >> semantics, which is "this works as if you yanked the powe

Re: [Qemu-devel] [PATCH 1/3] Improve grlib-apbuart

2013-02-19 Thread Fabien Chouteau
On 02/19/2013 02:26 PM, Andreas Färber wrote: > Am 19.02.2013 12:45, schrieb Fabien Chouteau: >> From: Ronald Hecht >> >> From: Ronald Hecht >> >> Signed-off-by: Fabien Chouteau > > Duplicate From header and no proper commit message. > The patch is doing too many things at once: Renaming gptime

Re: [Qemu-devel] [PATCH v3] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set

2013-02-19 Thread Paolo Bonzini
Il 19/02/2013 15:57, Laszlo Ersek ha scritto: >> > >> > You can find it in the ICH9 spec on page 486 >> > (http://www.intel.com/content/dam/doc/datasheet/io-controller-hub-9-datasheet.pdf). > (Thanks for the link. Interestingly, "wget" got "403 Forbidden". I > googled the filename and then found i

Re: [Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-19 Thread Jeff Cody
On Tue, Feb 19, 2013 at 03:30:10PM +0100, Kevin Wolf wrote: > On Tue, Feb 19, 2013 at 08:26:35AM -0500, Jeff Cody wrote: > > On Tue, Feb 19, 2013 at 10:20:40AM +0100, Stefan Hajnoczi wrote: > > > On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote: > > > > +#include "qemu/crc32c.h" > > > > +#

Re: [Qemu-devel] [PATCH v3] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set

2013-02-19 Thread Michael S. Tsirkin
On Tue, Feb 19, 2013 at 03:57:19PM +0100, Laszlo Ersek wrote: > On 02/19/13 13:46, Paolo Bonzini wrote: > > Il 24/01/2013 10:31, Laszlo Ersek ha scritto: > >> From : > >> > >> Traditional PCI config space access is achieved by writing a 32 bit > >> value t

Re: [Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-19 Thread Kevin Wolf
On Tue, Feb 19, 2013 at 10:04:07AM -0500, Jeff Cody wrote: > On Tue, Feb 19, 2013 at 03:30:10PM +0100, Kevin Wolf wrote: > > The whole point of packed structs is to enable the unaligned data > > access, so yes, you're right with that. But in my opinion declaring the > > struct packed and letting th

Re: [Qemu-devel] [RFC PATCH 3/4] block: VHDX block driver support

2013-02-19 Thread Jeff Cody
On Tue, Feb 19, 2013 at 03:57:53PM +0100, Kevin Wolf wrote: > On Mon, Feb 18, 2013 at 06:03:31PM -0500, Jeff Cody wrote: > > This is preliminary and beta support for the VHDX image format, > > as specified in: > >"VHDX Format Specification v0.95", published 4/12/2012 > > https://www.microso

Re: [Qemu-devel] [PATCH 22/41] migration: yay, buffering is gone

2013-02-19 Thread Orit Wasserman
On 02/15/2013 07:46 PM, Paolo Bonzini wrote: > Buffering was needed because blocking writes could take a long time > and starve other threads seeking to grab the big QEMU mutex. > > Now that all writes (except within _complete callbacks) are done > outside the big QEMU mutex, we do not need buffer

[Qemu-devel] [PATCH for-1.4] pc: tag apic as overlap region

2013-02-19 Thread Michael S. Tsirkin
apic overlaps PCI space. On real hardware it has higher priority, emulate this correctly. This should addresses the following issue: > Subject: Re: [BUG] Guest OS hangs on boot when 64bit BAR present > (kvm-apic-msi resource conflict) > Sometime ago I reported an issue about guest OS hang when 6

Re: [Qemu-devel] [PATCH 23/41] Rename buffered_ to migration_

2013-02-19 Thread Orit Wasserman
On 02/15/2013 07:46 PM, Paolo Bonzini wrote: > From: Juan Quintela > > This is consistent once that we have moved everything to migration.c > > Signed-off-by: Juan Quintela > --- > migration.c | 32 > 1 files changed, 16 insertions(+), 16 deletions(-) > > di

Re: [Qemu-devel] [PATCH v1 2/6] a9mpcore: localised temporary init-only variables

2013-02-19 Thread Peter Crosthwaite
Hi Andreas, On Tue, Feb 19, 2013 at 7:56 PM, Andreas Färber wrote: > Am 19.02.2013 01:39, schrieb Peter Crosthwaite: >> On Tue, Feb 19, 2013 at 4:12 AM, Peter Maydell >> wrote: >>> On 8 February 2013 04:03, Peter Crosthwaite >>> wrote: The DeviceState *mptimer var in a9mp_priv_state was o

[Qemu-devel] [PATCH 0/3] SPARC: Misc Leon3 fixes

2013-02-19 Thread Fabien Chouteau
I'm resending these three patches from Ronald which were not applied last time. I don't remember any negative comment, they just fall off the radar. Regards, Ronald Hecht (3): Improve grlib-apbuart Added LEON MMU ASI mappings and corrected LEON3 MMU masks. SPARC LEON power-down support adde

Re: [Qemu-devel] [SeaBIOS] [edk2] (PAM stuff) reset doesn't work on OVMF + SeaBIOS CSM

2013-02-19 Thread David Woodhouse
On Mon, 2013-02-18 at 17:37 -0500, Kevin O'Connor wrote: > The ACPI v2 spec describes a "hard" reset register. SeaBIOS could > extract it from the FADT and then use it. Of course, we'd probably > want to update the QEMU ACPI tables to implement ACPI v2 then. This sounded great until I actually c

Re: [Qemu-devel] [PATCH v3] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set

2013-02-19 Thread Laszlo Ersek
On 02/19/13 13:46, Paolo Bonzini wrote: > Il 24/01/2013 10:31, Laszlo Ersek ha scritto: >> From : >> >> Traditional PCI config space access is achieved by writing a 32 bit >> value to io port 0xcf8 to identify the bus, device, function and config >> regi

Re: [Qemu-devel] [RFC PATCH 2/4] block: vhdx header for the QEMU support of VHDX images

2013-02-19 Thread Kevin Wolf
On Tue, Feb 19, 2013 at 08:11:48AM -0500, Jeff Cody wrote: > On Tue, Feb 19, 2013 at 10:02:51AM +0100, Stefan Hajnoczi wrote: > > On Mon, Feb 18, 2013 at 06:03:30PM -0500, Jeff Cody wrote: > > > +/* the guid is a 16 byte unique ID - the definition for this used by > > > + * Microsoft is not just 16

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-19 Thread Peter Maydell
On 19 February 2013 11:40, David Woodhouse wrote: > To do it properly, we need to distinguish between a 'hard' reset > triggered by the PIIX3 RCR register, which resets the PAM configuration, > and a 'soft' reset triggered for example by the keyboard controller, > which doesn't. > > This patch att

Re: [Qemu-devel] [RFC PATCH] Distinguish between reset types

2013-02-19 Thread Anthony Liguori
David Woodhouse writes: > As discussed at length already, one potential 'workaround' for KVM > brokenness in old kernels (<3.9) with old CPUs (without 'unrestricted > guest' support), is to properly reset the PAM registers in the chipset. > > I say 'workaround' but this would be a proper fix in i

[Qemu-devel] [PATCH 1/6] qcow2: flush refcount cache correctly in alloc_refcount_block()

2013-02-19 Thread Stefan Hajnoczi
update_refcount() affects the refcount cache, it does not write to disk. Therefore bdrv_flush(bs->file) does nothing. We need to flush the refcount cache in order to write out the refcount updates! Signed-off-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 2 +- 1 file changed, 1 insertion(+),

[Qemu-devel] [PATCH 6/6] qcow2: drop unnecessary flush in qcow2_update_snapshot_refcount()

2013-02-19 Thread Stefan Hajnoczi
We already flush when the function completes. There is no need to flush after every compressed cluster. Signed-off-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 4 1 file changed, 4 deletions(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 12d9065..9eb1aba 100644

[Qemu-devel] [PATCH 4/6] qcow2: flush in qcow2_update_snapshot_refcount()

2013-02-19 Thread Stefan Hajnoczi
Users of qcow2_update_snapshot_refcount() do not flush consistently. qcow2_snapshot_create() flushes but qcow2_snapshot_goto() and qcow2_snapshot_delete() do not. Solve this by moving the bdrv_flush() into qcow2_update_snapshot_refcount(). Signed-off-by: Stefan Hajnoczi --- block/qcow2-refcount

[Qemu-devel] [PATCH 5/6] qcow2: drop flush in update_cluster_refcount()

2013-02-19 Thread Stefan Hajnoczi
The update_cluster_refcount() function increments/decrements a cluster's refcount and then returns the new refcount value. There is no need to flush since both update_cluster_refcount() callers already take care of this: 1. qcow2_alloc_bytes() calls update_cluster_refcount() when compressed se

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 5/6] connection-setup code between client/server

2013-02-19 Thread Michael R. Hines
On 02/18/2013 03:24 AM, Orit Wasserman wrote: Hi Michael, The guest device state is quite small (~100K probably less) especially when compared to the guest memory and we already are pinning the guest memory for RDMA any way I was actually wondering about the memory pinning, do we pin all guest

  1   2   3   4   >