Re: [Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-03 Thread Amit Shah
On (Tue) 02 Apr 2013 [07:52:19], Anthony Liguori wrote: Amit Shah amit.s...@redhat.com writes: On (Mon) 01 Apr 2013 [09:02:46], Anthony Liguori wrote: Amit Shah amit.s...@redhat.com writes: Opening backends in non-blocking mode isn't necessary, we don't do anything while waiting

[Qemu-devel] [PATCH 0/2] New trace backend: ftrace

2013-04-03 Thread Eiichi Tsukata
This patchset introduces a new tracing backend ftrace. Currently, QEMU tracing backends do not support userspace tracing with ftrace. Collecting QEMU trace data and kernel trace data simultaniouly is useful for latency analysis and debugging especially when using KVM. With ftrace backend, you

[Qemu-devel] [PATCH 1/2] trace: Add ftrace tracing backend

2013-04-03 Thread Eiichi Tsukata
This patch adds a ftrace tracing backend which sends trace event to ftrace marker file. You can effectively compare qemu trace data and kernel(especially, kvm.ko when using KVM) trace data. The ftrace backend is restricted to Linux only. To try out the ftrace backend: $ ./configure

[Qemu-devel] [PATCH 2/2] trace: document frace backend

2013-04-03 Thread Eiichi Tsukata
Add documentation of ftrace backend. Signed-off-by: Eiichi Tsukata eiichi.tsukata...@hitachi.com --- docs/tracing.txt | 16 1 file changed, 16 insertions(+) diff --git a/docs/tracing.txt b/docs/tracing.txt index cf53c17..60ff9c5 100644 --- a/docs/tracing.txt +++

Re: [Qemu-devel] Virtio 9p live migration patches

2013-04-03 Thread Aneesh Kumar K.V
Benoît Canet benoit.ca...@irqsave.net writes: Thanks a lot, Do you have an idea of what is left to be done on it ? It has to rewritten with the new model with respect to migration. Also these is problem of how much time does it take to migrate the fid information ?. We also need to ensure

Re: [Qemu-devel] [RFC PATCH] main-loop: Unconditionally unlock iothread

2013-04-03 Thread Paolo Bonzini
--- Is it expected that this non-blocking condition implies lockup of the iothread? No. The idea was to make the loop cheaper when you had a qemu_notify_event() or bottom half, basically something that causes main_loop_wait() to wake up immediately multiple times. When that happens, it is

[Qemu-devel] qemu-kvm precopy based cloning

2013-04-03 Thread shashaankar reddy
Hi All, I'm very new to qemu code base and keenly interested in understanding how live VM migration works (pre-copy mechanism). So that I can work on contributing pre-copy based live VM cloning. Any inputs from current developers regarding pre-copy migration and specific hook points to implement

[Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-04-03 Thread Jens Freimann
Hi all, this is what our approach to CPU hotplug looks like. With respect to Igor's CPU hotplug series, how should we proceed? Should we change the interface to qemu_system_cpu_add_notifier/qemu_system_cpu_hotplug_request/cpu-add etc? Feedback regarding the non-API part is also highly welcome!

[Qemu-devel] [RFC/PATCH 1/1] s390: implement CPU hotplug

2013-04-03 Thread Jens Freimann
From: Thang Pham thang.p...@us.ibm.com This patch allows CPUs to be hotplugged to a running guest. The QEMU option (maxcpus) can be used to define the total number of standby and configured CPUs available at boot time, although it is not necessary because you can hotplug standby CPUs after boot

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-04-03 Thread Paolo Bonzini
Considering the following when the same seabios code snippet: pci_config_writeb(0x31): bdf: 0x pam: 0x005b is executed to mark an pc.ram area 0xc as readonly: Entering vhost_begin Entering vhost_region_del section: 0x7fd037a4bb60 offset_within_region: 0xc

Re: [Qemu-devel] [PATCH 1/2 V3] virtio-spec: dynamic network offloads configuration

2013-04-03 Thread Rusty Russell
Dmitry Fleytman dmi...@daynix.com writes: From: Dmitry Fleytman dfley...@redhat.com Virtio-net driver currently negotiates network offloads on startup via features mechanism and have no ability to change offloads state later. This patch introduced a new control command that allows to

Re: [Qemu-devel] [PATCH v4 1/7] virtio-serial: add the virtio-serial device.

2013-04-03 Thread Cornelia Huck
On Fri, 29 Mar 2013 10:02:38 +0100 fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com Create virtio-serial which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com --- hw/virtio-pci.c

Re: [Qemu-devel] [PATCH v1 1/4] m25p80: Fix debug messages.

2013-04-03 Thread Edgar E. Iglesias
On Wed, Apr 03, 2013 at 02:09:16PM +1000, Peter Crosthwaite wrote: Some dodgy casts were making a mess of these msgs. Hi Peter Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/m25p80.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v4 0/7] virtio-serial refactoring.

2013-04-03 Thread Cornelia Huck
On Fri, 29 Mar 2013 10:02:37 +0100 fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This is the next part of virtio-refactoring. Basically it creates virtio-serial device which extends virtio-device. Then a virtio-serial can be connected on a virtio-bus.

Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable

2013-04-03 Thread Paolo Bonzini
- Messaggio originale - Da: Wenchao Xia xiaw...@linux.vnet.ibm.com A: Kevin Wolf kw...@redhat.com Cc: pbonz...@redhat.com, qemu-devel@nongnu.org, diet...@proxmox.com, stefa...@gmail.com Inviato: Mercoledì, 3 aprile 2013 7:51:43 Oggetto: Re: [Qemu-devel] [PATCH 2/3] block: adjust

Re: [Qemu-devel] [PATCH v3] NVMe: Initial commit

2013-04-03 Thread Markus Armbruster
Stefan Hajnoczi stefa...@gmail.com writes: On Tue, Mar 19, 2013 at 01:41:53PM -0600, Keith Busch wrote: +static int nvme_init(PCIDevice *pci_dev) +{ +NvmeCtrl *n = NVME(pci_dev); +NvmeIdCtrl *id = n-id_ctrl; + +int i; +int64_t bs_size; +char serial[sizeof(id-sn)]; +

Re: [Qemu-devel] win32 qemu binaries

2013-04-03 Thread Wei-Ren Chen
Hi Michael, On Fri, Mar 29, 2013 at 07:53:47PM +0800, Michael W. Bombardieri wrote: Hi, Thanks for your work on Qemu! My friend Prashant Satish has provided Qemu binaries for 1.4.0 hosted here: http://www.omledom.com/ Currently there is no support for SDL in the build but more

Re: [Qemu-devel] [PATCH] usb-tablet: Don't claim wakeup capability for USB-2 version

2013-04-03 Thread Gerd Hoffmann
On 04/02/13 19:15, Hans de Goede wrote: Our ehci code does not implement wakeup support, so claiming support for it with usb-tablet in USB-2 mode causes all tablet events to get lost. Patch added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [v2 PATCH] acpi: initialize s4_val used in s4 shutdown

2013-04-03 Thread Gerd Hoffmann
On 04/02/13 20:41, Bruce Rogers wrote: While investigating why a 32 bit Windows 2003 guest wasn't able to successfully perform a shutdown /h, it was discovered that commit afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4 inadvertently dropped the initialization of the s4_val used to handle s4

Re: [Qemu-devel] [PATCH 0/6] migration: followups for writev patches

2013-04-03 Thread Orit Wasserman
On 03/27/2013 06:36 PM, Paolo Bonzini wrote: This series fixes a few small problems in Orit's writev patches: 1) socket_put_buffer is not needed anymore and can be dropped (patch 1); 2) sendmsg could do a partial write even for a blocking socket, in case it is interrupted by a signal. This

Re: [Qemu-devel] Regarding migration

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 07:11, Shehbaz Jaffer ha scritto: All of migration code can be found in migrate.c file. To understand migration, you can run qemu in gdb and place breakpoints in do_savevm() function on server side and do_loadvm() function on client side. Migration consists of the following

Re: [Qemu-devel] [PATCH] target-i386: Check for host features before filter_features_for_kvm()

2013-04-03 Thread Igor Mammedov
On Tue, 2 Apr 2013 17:48:12 -0300 Eduardo Habkost ehabk...@redhat.com wrote: commit 5ec01c2e96910e1588d1a0de8609b9dda7618c7f broke -cpu ..,enforce, as it has moved kvm_check_features_against_host() after the filter_features_for_kvm() call. filter_features_for_kvm() removes all features not

Re: [Qemu-devel] [Xen-devel] frequently ballooning results in qemu exit

2013-04-03 Thread Hanweidong
-Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: 2013年4月2日 21:28 To: Hanweidong Cc: Stefano Stabellini; Tim (Xen.org); George Dunlap; Andrew Cooper; Yanqiangjun; qemu-devel@nongnu.org; xen-de...@lists.xen.org; Gonglei (Arei); Anthony

Re: [Qemu-devel] [PATCH] xilinx_axienet: pump events as appropriate

2013-04-03 Thread Edgar E. Iglesias
On Wed, Apr 03, 2013 at 02:04:09PM +1000, Peter Crosthwaite wrote: When the conditions blocking receiving are cleared, check for buffered rx packets. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Acked-by: Edgar E. Iglesias edgar.igles...@gmail.com ---

Re: [Qemu-devel] [PATCH] Add configure clock_gettime() monotonic time test

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 00:52, Peter Maydell ha scritto: On 2 April 2013 17:45, Paolo Bonzini pbonz...@redhat.com wrote: Il 02/04/2013 17:42, Brad Smith ha scritto: Replace the hardcoded list of OS's utilizing clock_gettime() for monotonic time with a configure test. This is to fix the use of monotonic

Re: [Qemu-devel] [PATCH v4] Add option to mlock qemu and guest memory

2013-04-03 Thread Markus Armbruster
Seiji Aguchi seiji.agu...@hds.com writes: Anthony, Currently my company doesn't allow me to use git-send-email to send a email. So now I'm trying to find work around with IT. Satoru and I still talk if we can use git-send-email with my company IT. But, it seems to take a long time...

Re: [Qemu-devel] [PATCH v2 0/4] Monitor: make output buffer dynamic

2013-04-03 Thread Gerd Hoffmann
On 04/02/13 22:18, Luiz Capitulino wrote: This series does two things: it makes the Monitor's output buffer dynamic (so that we fix an assertion bug in the Monitor); and it also switches the human-monitor-command command to use that buffer instead of the Memory chardev driver, which is

Re: [Qemu-devel] [PATCH 1/5] configure: move TARGET_*_ALIGNMENT to target-*/cpu.h

2013-04-03 Thread Paolo Bonzini
Il 02/04/2013 19:47, Peter Maydell ha scritto: On 2 April 2013 18:26, Paolo Bonzini pbonz...@redhat.com wrote: I think a thing the size of a pointer should be abi_long/ulong. The pointer is not a CPU concept. Yeah. OTOH type alignment isn't a CPU concept either, so I'm a little suspicious

[Qemu-devel] [PATCH 0/4] kvm-unittests: add pci PORT IO and MMIO speed tests

2013-04-03 Thread Michael S. Tsirkin
These patches add a test device, useful to measure speed of MMIO versus PIO, in different configurations. As I didn't want to reserve a hardcoded range of memory, I added pci device for this instead. Used together with the kvm unittest patches I posted on kvm mailing list. To use, simply add the

[Qemu-devel] [PATCH 1/4] kvm: remove unused APIs

2013-04-03 Thread Michael S. Tsirkin
There are only used internally now, move them out of header and out of stub. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/sysemu/kvm.h | 4 -- kvm-all.c| 107 ++- kvm-stub.c | 10 - 3 files changed, 54

[Qemu-devel] [PATCH 2/4] kvm: support any size for pio eventfd

2013-04-03 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- kvm-all.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index ca9775d..589e37c 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -500,8 +500,8 @@ int kvm_check_extension(KVMState

[Qemu-devel] [PATCH 3/4] kvm: support non datamatch ioeventfd

2013-04-03 Thread Michael S. Tsirkin
Adding restrictions just adds code. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- kvm-all.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 589e37c..ce823f9 100644 --- a/kvm-all.c +++ b/kvm-all.c @@

[Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
This device is used for kvm unit tests, currently it supports testing performance of ioeventfd. Using updated kvm unittest, here's an example output: mmio-no-eventfd:pci-mem 8796 mmio-wildcard-eventfd:pci-mem 3609 mmio-datamatch-eventfd:pci-mem 3685

Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable

2013-04-03 Thread Wenchao Xia
No, if bdrv_snapshot_delete() can fail, you need to split it in two parts: one that can fail, and one that cannot. If you cannot, then there are two possibilities: - if the failures are minor and could be repaired with qemu-img check -r (e.g. lost clusters), then this is not optimal but can

Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-03 Thread Kevin Wolf
Am 03.04.2013 um 07:35 hat Wenchao Xia geschrieben: 于 2013-4-2 21:59, Kevin Wolf 写道: Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben: Last operaton should be cancelled first. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Should it? This commit message does little to convince

Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 11:02, Wenchao Xia ha scritto: Sorry I haven't state it clearly. What about bdrv_snapshot_create() operation? If it need to be rolled back, I think bdrv_snapshot_delete() will get called and it may fail. But in most case if bdrv_snapshot_create() succeed before, the

Re: [Qemu-devel] [PATCH v4 2/7] virtio-serial-pci: switch to the new API.

2013-04-03 Thread Amit Shah
On (Fri) 29 Mar 2013 [10:02:39], fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com Here the virtio-serial-pci is modified for the new API. The device virtio-serial-pci extends virtio-pci. It creates and connects a virtio-serial during the init. The properties

Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable

2013-04-03 Thread Kevin Wolf
Am 03.04.2013 um 11:02 hat Wenchao Xia geschrieben: No, if bdrv_snapshot_delete() can fail, you need to split it in two parts: one that can fail, and one that cannot. If you cannot, then there are two possibilities: - if the failures are minor and could be repaired with qemu-img check -r

Re: [Qemu-devel] [PATCH v4 2/7] virtio-serial-pci: switch to the new API.

2013-04-03 Thread Peter Maydell
On 29 March 2013 09:02, fred.kon...@greensocs.com wrote: - -/* backwards-compatibility with machines that were created with - DEV_NVECTORS_UNSPECIFIED */ -vdev-nvectors = proxy-nvectors == DEV_NVECTORS_UNSPECIFIED -?

[Qemu-devel] [PATCH] vhost: Add vhost_commit callback for SeaBIOS ROM region re-mapping

2013-04-03 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch follows MST's recommendation to move checks for vhost_verify_ring_mappings() - cpu_physical_memory_map() operations from MemoryListener-region_[add,del]() - vhost_set_memory() into final MemoryListener-commit() - vhost_commit() callback.

Re: [Qemu-devel] [PATCH v4 0/7] virtio-serial refactoring.

2013-04-03 Thread Amit Shah
On (Fri) 29 Mar 2013 [10:02:37], fred.kon...@greensocs.com wrote: From: KONRAD Frederic fred.kon...@greensocs.com This is the next part of virtio-refactoring. Basically it creates virtio-serial device which extends virtio-device. Then a virtio-serial can be connected on a virtio-bus.

Re: [Qemu-devel] [RFC PATCH v2 1/4] net: port tap onto glib

2013-04-03 Thread liu ping fan
On Thu, Mar 28, 2013 at 10:32 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Mar 28, 2013 at 03:55:52PM +0800, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com Bind each NetClientState with a GSource(ie,NetClientSource). Currently, these GSource attached with default

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 10:59, Michael S. Tsirkin ha scritto: This device is used for kvm unit tests, currently it supports testing performance of ioeventfd. Using updated kvm unittest, here's an example output: mmio-no-eventfd:pci-mem 8796 mmio-wildcard-eventfd:pci-mem 3609

[Qemu-devel] [PATCH 04/10] xhci: remove leftover debug printf

2013-04-03 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 9d06c51..382ac88 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1172,8 +1172,6 @@ static void

[Qemu-devel] [PULL 00/10] usb patch queue

2013-04-03 Thread Gerd Hoffmann
Hi, Here comes the usb patch queue. Nothing major, just a bunch of little bugfixes, some of them lingering in the queue _way_ too long already. please pull, Gerd The following changes since commit 162cbbd1736de2bca43fdefa7e98c54a361ee60d: Merge remote-tracking branch 'luiz/queue/qmp'

[Qemu-devel] [PATCH 02/10] usb-redir: Add flow control support

2013-04-03 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/redirect.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/hw/usb/redirect.c

[Qemu-devel] [PATCH 03/10] xhci: fix numintrs sanity checks

2013-04-03 Thread Gerd Hoffmann
Make sure numintrs is a power of two, msi requires this. https://bugzilla.redhat.com/show_bug.cgi?id=918035 Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 5aa342b..9d06c51

[Qemu-devel] [PATCH 08/10] usb-hub: report status changes only once

2013-04-03 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-hub.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c index a5f092b..0b71abd 100644 --- a/hw/usb/dev-hub.c +++ b/hw/usb/dev-hub.c @@ -33,6 +33,7 @@ typedef struct

[Qemu-devel] [PATCH 06/10] xhci: zap unused name field

2013-04-03 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c |1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 5ea1fe7..efd4b0d 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -452,7 +452,6 @@ struct XHCIState { MemoryRegion

[Qemu-devel] [PATCH 05/10] xhci: remove unimplemented printfs

2013-04-03 Thread Gerd Hoffmann
Replace them with a tracepoint, so they don't spam stderr by default. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-xhci.c | 22 +- trace-events |1 + 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/hw/usb/hcd-xhci.c

[Qemu-devel] [PATCH 09/10] usb: update docs for bus name change

2013-04-03 Thread Gerd Hoffmann
At some point the default usb bus name changed from 'usb.0' to 'usb-bus.0' (probably as part of the qom conversion). Update the usb documentation accordingly. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/usb2.txt | 20 ++-- 1 file changed, 10 insertions(+), 10

[Qemu-devel] [PATCH 01/10] usb-redir: Fix crash on migration with no client connected

2013-04-03 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com If no client is connected on the src side, then we won't receive a parser during migrate, in this case usbredir_post_load() should be a nop, rather then to try to derefefence the NULL dev-parser pointer. Signed-off-by: Hans de Goede hdego...@redhat.com

[Qemu-devel] [PATCH 10/10] usb-tablet: Don't claim wakeup capability for USB-2 version

2013-04-03 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com Our ehci code does not implement wakeup support, so claiming support for it with usb-tablet in USB-2 mode causes all tablet events to get lost. http://bugzilla.redhat.com/show_bug.cgi?id=929068 Signed-off-by: Hans de Goede hdego...@redhat.com

[Qemu-devel] [PATCH 07/10] usb-hub: limit chain length

2013-04-03 Thread Gerd Hoffmann
USB supports up to 5 hubs chained. Catch attempts to chain more. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb.h |1 + hw/usb/bus.c |2 ++ hw/usb/dev-hub.c |6 ++ 3 files changed, 9 insertions(+) diff --git a/hw/usb.h b/hw/usb.h index 1b10684..4d9d05e

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 11:28:55AM +0200, Paolo Bonzini wrote: Il 03/04/2013 10:59, Michael S. Tsirkin ha scritto: This device is used for kvm unit tests, currently it supports testing performance of ioeventfd. Using updated kvm unittest, here's an example output:

Re: [Qemu-devel] [PATCH] vmware_vga: do not cache depth and bypp

2013-04-03 Thread Gerd Hoffmann
On 03/29/13 17:28, Alex DAMIAN wrote: From: Alexandru DAMIAN alexandru.dam...@intel.com Do not cache depth and bypp information in the device state. This resolves a bug where Xorg video-vmare driver refuses to start up because the depth value read is the one cached from the device start

Re: [Qemu-devel] [PATCH] vhost: Add vhost_commit callback for SeaBIOS ROM region re-mapping

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 09:15:11AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch follows MST's recommendation to move checks for vhost_verify_ring_mappings() - cpu_physical_memory_map() operations from MemoryListener-region_[add,del]() -

Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device

2013-04-03 Thread Laszlo Ersek
On 04/02/13 16:34, Corey Bryant wrote: On 04/01/2013 08:11 PM, Kevin O'Connor wrote: On Mon, Apr 01, 2013 at 03:05:55PM -0400, Corey Bryant wrote: On 03/28/2013 05:03 AM, Paolo Bonzini wrote: There is work on moving ACPI tables to QEMU. Please work with the other developers (Kevin of

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 11:45, Michael S. Tsirkin ha scritto: On Wed, Apr 03, 2013 at 11:28:55AM +0200, Paolo Bonzini wrote: Il 03/04/2013 10:59, Michael S. Tsirkin ha scritto: This device is used for kvm unit tests, currently it supports testing performance of ioeventfd. Using updated kvm unittest,

[Qemu-devel] sparc 32-bit linux-user broken?

2013-04-03 Thread Paolo Bonzini
From linux-user-test-0.3, running on x86_64: $ ../sparc32plus-linux-user/qemu-sparc32plus -L ./gnemul/qemu-sparc sparc/ls $ ../sparc32plus-linux-user/qemu-sparc32plus -L ./gnemul/qemu-sparc sparc/ls dummyfile dummyfile $ ../sparc64-linux-user/qemu-sparc64 -L ./gnemul/qemu-sparc sparc64/ls

Re: [Qemu-devel] [PATCH] vhost: Add vhost_commit callback for SeaBIOS ROM region re-mapping

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 11:49, Michael S. Tsirkin ha scritto: On Wed, Apr 03, 2013 at 09:15:11AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch follows MST's recommendation to move checks for vhost_verify_ring_mappings() - cpu_physical_memory_map()

[Qemu-devel] [PATCH] vga.c: move debug printfs to trace events

2013-04-03 Thread Alex DAMIAN
From: Alexandru DAMIAN alexandru.dam...@intel.com Move all register read/write log events from DEBUG ifdefs to the tracing infrastructure. Signed-off-by: Alexandru DAMIAN alexandru.dam...@intel.com --- hw/vga.c | 45 +++-- trace-events |4

Re: [Qemu-devel] [PATCH] vmware_vga: do not cache depth and bypp

2013-04-03 Thread Damian, Alexandru
It fixes my test case, that is starting up with 32 bits depth console and then switching to 16 bits depth - since the depth is cached, xf64-video-vmware gets 565-weight but 32 bit depth, and refuses to start. There is another similar bug I'm tackling now - when the window resizes,

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 11:53:59AM +0200, Paolo Bonzini wrote: Il 03/04/2013 11:45, Michael S. Tsirkin ha scritto: On Wed, Apr 03, 2013 at 11:28:55AM +0200, Paolo Bonzini wrote: Il 03/04/2013 10:59, Michael S. Tsirkin ha scritto: This device is used for kvm unit tests, currently it

Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 11:54:57AM +0200, Laszlo Ersek wrote: On 04/02/13 16:34, Corey Bryant wrote: On 04/01/2013 08:11 PM, Kevin O'Connor wrote: On Mon, Apr 01, 2013 at 03:05:55PM -0400, Corey Bryant wrote: On 03/28/2013 05:03 AM, Paolo Bonzini wrote: There is work on moving ACPI

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Exactly. I prefer a flexible structure so I can change things host side. For example register multiple datamatches with same address and compare speed of access on first and last one. Similarly for address. Ok, this makes sense. (BTW, and unrelated to this, please use default-configs/ and

[Qemu-devel] [PATCH v2 06/10] elfload: only give abi_long/ulong the alignment specified by the target

2013-04-03 Thread Paolo Bonzini
Previously, this was done for target_long/ulong, and propagated to abi_long/ulong via a typedef. But target_long/ulong should not have any specific alignment, it is never used to access guest memory. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure| 9

[Qemu-devel] [PATCH v2 03/10] elfload: use tswapreg consistently in elf_core_copy_regs

2013-04-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- linux-user/elfload.c | 114 +-- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 9d5dbb8..bc2e9f1 100644 --- a/linux-user/elfload.c

[Qemu-devel] [PATCH v2 09/10] configure: move common libraries to config-host.mak

2013-04-03 Thread Paolo Bonzini
Move -lm to the end of the line, so that it can be picked up as a dependency by pixman. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile.target | 10 +- configure | 4 +++- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/Makefile.target

Re: [Qemu-devel] [PATCH] vhost: Add vhost_commit callback for SeaBIOS ROM region re-mapping

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 12:34, Michael S. Tsirkin ha scritto: Applied to the SCSI branch, thanks. Is the rest of vhost-scsi there now? No, but it will be shortly. :) Paolo

Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-03 Thread Wenchao Xia
于 2013-4-3 17:03, Kevin Wolf 写道: Am 03.04.2013 um 07:35 hat Wenchao Xia geschrieben: 于 2013-4-2 21:59, Kevin Wolf 写道: Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben: Last operaton should be cancelled first. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com Should it? This commit

[Qemu-devel] [PATCH v2 04/10] elfload: use abi_short/ushort instead of target_short/ushort

2013-04-03 Thread Paolo Bonzini
The alignment is a characteristic of the ABI, not the CPU. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure| 2 -- include/exec/cpu-defs.h | 2 -- include/exec/user/abitypes.h | 7 +++ linux-user/elfload.c | 6 +++--- 4 files changed, 10

[Qemu-devel] [PATCH v2 10/10] configure: CONFIG_NO_XEN is duplicated

2013-04-03 Thread Paolo Bonzini
We already define it in Makefile.target. But we need to avoid a curious double negation in order to eliminate it. Tested-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 3

[Qemu-devel] [PATCH v2 08/10] configure: move CONFIG_QEMU_LDST_OPTIMIZATION to config-host.mak

2013-04-03 Thread Paolo Bonzini
Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/configure b/configure index 10ea70e..7d83600 100755 --- a/configure +++ b/configure @@ -3481,6

[Qemu-devel] [PATCH v2 05/10] elfload: use abi_int/uint instead of target_int/uint

2013-04-03 Thread Paolo Bonzini
The alignment is a characteristic of the ABI, not the CPU. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure| 3 --- include/exec/cpu-defs.h | 2 -- include/exec/user/abitypes.h | 5 + linux-user/elfload.c | 14 +++---

Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable

2013-04-03 Thread Wenchao Xia
于 2013-4-3 17:02, Wenchao Xia 写道: No, if bdrv_snapshot_delete() can fail, you need to split it in two parts: one that can fail, and one that cannot. If you cannot, then there are two possibilities: - if the failures are minor and could be repaired with qemu-img check -r (e.g. lost clusters),

Re: [Qemu-devel] [PATCH] tpm: Fix several compiler warnings (redefined data types)

2013-04-03 Thread Stefan Berger
On 04/02/2013 04:14 PM, Stefan Weil wrote: What compiler and options did you use? Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: Stefan Berger stef...@linux.vnet.ibm.com --- tpm/tpm_int.h |9 ++--- tpm/tpm_tis.h |4 ++-- 2 files changed, 4 insertions(+), 9

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 12:34:24PM +0200, Paolo Bonzini wrote: Il 03/04/2013 12:33, Michael S. Tsirkin ha scritto: Because someone wasn't looking. :) The hw/ reorganization patches I've posted fix that. Still not sure how to merge this, if it goes in through my tree and that's the

Re: [Qemu-devel] [PATCH 20/35] hw: move ISA bridges and devices to hw/isa/, configure with default-configs/

2013-04-03 Thread Michael S. Tsirkin
On Tue, Apr 02, 2013 at 04:58:54PM +0200, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- default-configs/i386-softmmu.mak | 4 default-configs/x86_64-softmmu.mak | 4 hw/i386/Makefile.objs | 7 ++- hw/isa/Makefile.objs |

Re: [Qemu-devel] [PATCH 24/35] hw: move VFIO and ivshmem to hw/pci/

2013-04-03 Thread Michael S. Tsirkin
On Tue, Apr 02, 2013 at 04:58:58PM +0200, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/Makefile.objs | 10 -- hw/pci/Makefile.objs | 5 + hw/{ = pci}/ivshmem.c| 0 hw/{vfio_pci.c = pci/vfio.c} | 0 4 files

Re: [Qemu-devel] [PATCH 05/35] hw: move virtio devices to hw/ subdirectories

2013-04-03 Thread Michael S. Tsirkin
On Tue, Apr 02, 2013 at 04:58:39PM +0200, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/Makefile.objs | 5 - hw/block/Makefile.objs | 2 ++ hw/{ = block}/dataplane/Makefile.objs | 0 hw/{ = block}/dataplane/hostmem.c

[Qemu-devel] [PATCH] usb-storage: Forward serial number to scsi-disk

2013-04-03 Thread Kevin Wolf
usb-storage takes care to fetch the USB serial number from -drive options, but it neglected to pass its own 'serial' property to the scsi-disk it creates. With this patch, the 'serial' qdev property and the 'serial' option in -drive behave the same and correctly apply the serial number on both USB

Re: [Qemu-devel] [PATCH] vmware_vga: do not cache depth and bypp

2013-04-03 Thread Damian, Alexandru
Something like this, please comment, not ready to submit. From: Alexandru DAMIAN alexandru.dam...@intel.com Date: Wed, 3 Apr 2013 13:43:31 +0300 Subject: [PATCH] qemu console: Add depth preservation on allocation Since there are multiple bit depths supported for consoles, we must preserve the

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 1.4.1, freeze next Tuesday

2013-04-03 Thread Michael Tokarev
03.04.2013 02:04, Eric Blake wrote: On 04/02/2013 03:45 PM, Michael Roth wrote: Hi everyone, The following new patches are queued for QEMU stable v1.4.1: https://github.com/mdroth/qemu/commits/stable-1.4-staging The release is planned for 04-15-2013: http://wiki.qemu.org/Planning/1.4

Re: [Qemu-devel] [PATCH 20/35] hw: move ISA bridges and devices to hw/isa/, configure with default-configs/

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 01:42:19PM +0300, Michael S. Tsirkin wrote: On Tue, Apr 02, 2013 at 04:58:54PM +0200, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- default-configs/i386-softmmu.mak | 4 default-configs/x86_64-softmmu.mak | 4

Re: [Qemu-devel] [PATCH] vhost: Add vhost_commit callback for SeaBIOS ROM region re-mapping

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 12:06:14PM +0200, Paolo Bonzini wrote: Il 03/04/2013 11:49, Michael S. Tsirkin ha scritto: On Wed, Apr 03, 2013 at 09:15:11AM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch follows MST's recommendation to move checks

[Qemu-devel] [PATCH v2 07/10] elfload: use abi_llong/ullong instead of target_llong/ullong

2013-04-03 Thread Paolo Bonzini
The alignment is a characteristic of the ABI, not the CPU. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure| 4 include/exec/cpu-defs.h | 2 -- include/exec/user/abitypes.h | 5 + linux-user/elfload.c | 4 ++-- target-arm/cpu.h

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 12:33, Michael S. Tsirkin ha scritto: Because someone wasn't looking. :) The hw/ reorganization patches I've posted fix that. Still not sure how to merge this, if it goes in through my tree and that's the only comment, I'll just fix it silently ... Indeed. In fact,

[Qemu-devel] [PATCH v2 00/10] TARGET_*_ALIGNMENT cleanup, and config-target.mak trimming

2013-04-03 Thread Paolo Bonzini
This series expands on the one I sent yesterday, but also fixes some confusion between target (CPU) and ABI types in linux-user/elfload.c. target_short/int/llong and the corresponding unsigned types are renamed to abi_short/int/llong, and TARGET_*_ALIGNMENT is similarly renamed to

[Qemu-devel] [PATCH v2 01/10] elfload: fix size of ABI-dependent fields in core dumps

2013-04-03 Thread Paolo Bonzini
Some fields in core dumps are 32-bit in 32-or-64 environments (ppc64abi32, sparc32plus). Use abi_long/ulong for those. Also, the fields of target_elf_siginfo are ints. Use tswap32 to convert them. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- linux-user/elfload.c | 18

[Qemu-devel] [PATCH v2 02/10] elfload: fix size of registers for N32

2013-04-03 Thread Paolo Bonzini
Registers are 64-bit in size for the MIPS n32 ABI. Define target_elf_greg_t accordingly, and use the correct function to do endian swaps. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- linux-user/elfload.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff

Re: [Qemu-devel] [PATCH 1/2 V3] virtio-spec: dynamic network offloads configuration

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 11:50:19AM +1030, Rusty Russell wrote: Dmitry Fleytman dmi...@daynix.com writes: From: Dmitry Fleytman dfley...@redhat.com Virtio-net driver currently negotiates network offloads on startup via features mechanism and have no ability to change offloads state

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Michael S. Tsirkin
On Wed, Apr 03, 2013 at 12:25:02PM +0200, Paolo Bonzini wrote: Exactly. I prefer a flexible structure so I can change things host side. For example register multiple datamatches with same address and compare speed of access on first and last one. Similarly for address. Ok, this

Re: [Qemu-devel] [Xen-devel] frequently ballooning results in qemu exit

2013-04-03 Thread Stefano Stabellini
On Wed, 3 Apr 2013, Hanweidong wrote: -Original Message- From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] Sent: 2013年4月2日 21:28 To: Hanweidong Cc: Stefano Stabellini; Tim (Xen.org); George Dunlap; Andrew Cooper; Yanqiangjun; qemu-devel@nongnu.org;

Re: [Qemu-devel] [PATCH v4 3/6] KVM: Initialize irqfd from kvm_init().

2013-04-03 Thread Cornelia Huck
On Tue, 02 Apr 2013 20:40:53 -0400 Sasha Levin sasha.le...@oracle.com wrote: On 02/28/2013 04:22 AM, Cornelia Huck wrote: Currently, eventfd introduces module_init/module_exit functions to initialize/cleanup the irqfd workqueue. This only works, however, if no other module_init/module_exit

Re: [Qemu-devel] [PATCH 4/4] pci: add pci test device

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 12:38, Michael S. Tsirkin ha scritto: On Wed, Apr 03, 2013 at 12:34:24PM +0200, Paolo Bonzini wrote: Il 03/04/2013 12:33, Michael S. Tsirkin ha scritto: Because someone wasn't looking. :) The hw/ reorganization patches I've posted fix that. Still not sure how to merge this, if

Re: [Qemu-devel] [PATCH 05/35] hw: move virtio devices to hw/ subdirectories

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 12:47, Michael S. Tsirkin ha scritto: Won't this break if someone wants to write a scsi dataplane? I think we want to keep the generic bits in hw/dataplane ... Ok, will do. Paolo

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-04-03 Thread Gerd Hoffmann
Hi, No, it is not, and yes, this is where the inconsistency comes from. We read wred+wgreen+wblue directly from the surface whereas depth is cached in the vmware vga state struct. Patch attached. Not fully tested yet. Unfortunately, this doesn't change the picture (except for the

Re: [Qemu-devel] [PATCH 20/35] hw: move ISA bridges and devices to hw/isa/, configure with default-configs/

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 12:51, Michael S. Tsirkin ha scritto: default-configs/i386-softmmu.mak | 4 default-configs/x86_64-softmmu.mak | 4 hw/i386/Makefile.objs | 7 ++- hw/isa/Makefile.objs | 6 ++ hw/{ = isa}/debugexit.c | 0

Re: [Qemu-devel] [PATCH 24/35] hw: move VFIO and ivshmem to hw/pci/

2013-04-03 Thread Paolo Bonzini
Il 03/04/2013 12:43, Michael S. Tsirkin ha scritto: On Tue, Apr 02, 2013 at 04:58:58PM +0200, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/Makefile.objs | 10 -- hw/pci/Makefile.objs | 5 + hw/{ = pci}/ivshmem.c| 0

  1   2   3   >