[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2013-04-19 Thread Steve Rencontre
Just found this problem with Win7 guest, both 32 and 64-bit, using qemu- kvm 1.01. WinXP is absolutely fine. How can this /possibly/ not be a priority to fix? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net

Re: [Qemu-devel] [PATCH v2 17/23] instrument: Add commandline options to start with an instrumentation library

2013-04-19 Thread Lluís Vilanova
Eric Blake writes: > On 04/16/2013 07:51 AM, Lluís Vilanova wrote: >> Add commandline options to control initial loading of dynamic instrumentation >> library. >> >> Signed-off-by: Lluís Vilanova >> --- >> @@ -688,6 +690,15 @@ static void usage(void) >> #endif >> "-bsd type select emula

Re: [Qemu-devel] [PATCH v2 15/23] instrument: [qmp, qapi] Add control interface

2013-04-19 Thread Lluís Vilanova
Anything not commented inline has been changed according to your feedback. Eric Blake writes: [...] >> +## >> +# @instr-dynamic: >> +# >> +# Whether dynamic trace instrumentation is available. >> +# >> +# Since: 1.5 >> +## >> +{ 'command': 'instr-dynamic', >> + 'returns': 'bool' } > Perhaps nam

[Qemu-devel] [Bug 1094786] Re: static build with curses fails if requires -ltinfo

2013-04-19 Thread Stefan Hajnoczi
Please try qemu.git/master. If the error still occurs, please attach config.log. The problem may have to do with the way ./configure compile_prog and pkg_config interact with the --static option. The --static option is supposed to set up LDFLAGS -static and pkg-config --static. The curses probi

[Qemu-devel] Live Block Migration Strategy

2013-04-19 Thread Yaodong Yang
Hi all, Could someone share me with some information about the live block migration strategy in the current qemu-kvm. As I know, there are at least IO mirroring, dirty block tracking, snapshot, precopy or postcopy strategy exist for the block migration. I donot know which one is used in the cur

[Qemu-devel] Qemu RDMA patch

2013-04-19 Thread Jiuxing Liu
Hi, This is regarding the Qemu RDMA patch that I co-authored with Michael R Hines. Copyright belongs to IBM, and I approve using GPL2 and later. Jiuxing Liu - Forwarded by Bulent Abali/Watson/IBM on 04/18/2013 10:44 AM - From:"Michael S. Tsirkin" To:mrhi...@linux.vnet.

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-04-19 Thread Eduardo Habkost
On Fri, Apr 19, 2013 at 09:13:32PM +0200, Christian Borntraeger wrote: > On 19/04/13 15:16, Andreas Färber wrote: > [...] > >>> Background is that for x86 we currently have a flat CPU core/thread > >>> namespace but would need to deal with sockets, cores and threads to get > >>> topologies right. I

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-04-19 Thread Christian Borntraeger
On 19/04/13 15:16, Andreas Färber wrote: [...] >>> Background is that for x86 we currently have a flat CPU core/thread >>> namespace but would need to deal with sockets, cores and threads to get >>> topologies right. I assume there are no such issues on s390x, so that >>> the vCPU to CPUState mappi

Re: [Qemu-devel] [PATCH 09/10] target-ppc: emulate store doubleword pair instructions

2013-04-19 Thread Aurelien Jarno
On Wed, Apr 17, 2013 at 04:26:44PM +0200, Richard Henderson wrote: > On 2013-04-13 14:47, Aurelien Jarno wrote: > >+gen_qemu_st64(ctx, cpu_fpr[rD(ctx->opcode) + 1], EA); > > Actually, for both this and ldfp, don't you need to check for > odd rD and raise sigill or whatever? > This indeed

[Qemu-devel] [PATCH 3/3] doc: document the Pseudo-encoding of LED state

2013-04-19 Thread Lei Li
Signed-off-by: Lei Li --- docs/vnc-ledstate-Pseudo-encoding.txt | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) create mode 100644 docs/vnc-ledstate-Pseudo-encoding.txt diff --git a/docs/vnc-ledstate-Pseudo-encoding.txt b/docs/vnc-ledstate-Pseudo-enc

[Qemu-devel] [PATCH 1/3] vnc: Add SCROLL lock key to kbd_leds

2013-04-19 Thread Lei Li
Signed-off-by: Lei Li --- ui/vnc.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 8ee66b7..f574962 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1525,10 +1525,11 @@ static void press_key(VncState *vs, int keysym) static void kbd_leds(void *opaq

[Qemu-devel] [PATCH 0/3 RFC v2] Support for LED state extension to Qemu VNC server

2013-04-19 Thread Lei Li
Hi guys, This patch series tries to add support for LED state extension to Qemu VNC server. The proposal has been sent few days ago as link below: http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html Hi Anthony, This series has not been completely tested, it takes longer than expe

[Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension

2013-04-19 Thread Lei Li
Signed-off-by: Lei Li --- ui/vnc.c | 48 ui/vnc.h |4 +++- 2 files changed, 51 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index f574962..e22cca1 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1522,6 +1522,45 @@ static void pres

[Qemu-devel] [PATCH 2/2] block: move bdrv_dev_change_media_cb() to callers that really need it

2013-04-19 Thread Luiz Capitulino
Commit 9ca111544c64b5abed2e79cf52e19a8f227b347b moved the call to bdrv_dev_change_media_cb() outside the media check in bdrv_close(), this added a regression where spurious DEVICE_TRAY_MOVED events are emitted at shutdown. To fix that this commit moves the bdrv_dev_change_media_cb() calls to the c

[Qemu-devel] [PATCH 1/2] block: make bdrv_dev_change_media_cb() public

2013-04-19 Thread Luiz Capitulino
Next commit wants to use it. Signed-off-by: Luiz Capitulino --- block.c | 3 +-- include/block/block.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 4ad663d..90d0ed1 100644 --- a/block.c +++ b/block.c @@ -56,7 +56,6 @@ typedef enum {

[Qemu-devel] [PATCH 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown

2013-04-19 Thread Luiz Capitulino
Hi, This fixes a regression introduced by commit 9ca111544, as detailed in patch 2/2, by moving bdrv_dev_change_media_cb() calls to callers of bdrv_close() that need it, as suggested by Kevin. Luiz Capitulino (2): block: make bdrv_dev_change_media_cb() public block: move bdrv_dev_change_media

Re: [Qemu-devel] [PATCH] NVMe: Initial commit

2013-04-19 Thread Stefan Hajnoczi
On Tue, Apr 2, 2013 at 10:27 PM, Keith Busch wrote: > On Fri, 19 Apr 2013, Stefan Hajnoczi wrote: >> >> I don't see bdrv_aio_flush() in this patch. How does the guest ensure >> that data is safely on persistent storage (e.g. protected against data >> loss by power failure). > > > Great point! Thi

Re: [Qemu-devel] [PATCH v2 4/4] qemu-char: do not operate on sources from finalize callbacks

2013-04-19 Thread Sander Eikelenboom
Friday, April 19, 2013, 5:32:09 PM, you wrote: > Due to a glib bug, the finalize callback is called with the GMainContext > lock held. Thus, any operation on the context from the callback will > cause recursive locking and a deadlock. This happens, for example, > when a client disconnects from

Re: [Qemu-devel] xen-unstable qemu-upstream: libxl: error: libxl_qmp.c:440:qmp_next: timeout, libxl_qmp.c:705:libxl__qmp_initialize: Failed to connect to QMP

2013-04-19 Thread Sander Eikelenboom
Friday, April 19, 2013, 7:00:11 PM, you wrote: > Il 19/04/2013 18:53, Sander Eikelenboom ha scritto: >> >> Friday, April 19, 2013, 3:00:56 PM, you wrote: >> >>> Il 19/04/2013 14:56, Sander Eikelenboom ha scritto: Friday, April 19, 2013, 10:04:22 AM, you wrote: > Il 19/04/2013

Re: [Qemu-devel] xen-unstable qemu-upstream: libxl: error: libxl_qmp.c:440:qmp_next: timeout, libxl_qmp.c:705:libxl__qmp_initialize: Failed to connect to QMP

2013-04-19 Thread Paolo Bonzini
Il 19/04/2013 18:53, Sander Eikelenboom ha scritto: > > Friday, April 19, 2013, 3:00:56 PM, you wrote: > >> Il 19/04/2013 14:56, Sander Eikelenboom ha scritto: >>> >>> Friday, April 19, 2013, 10:04:22 AM, you wrote: >>> Il 19/04/2013 09:52, Sander Eikelenboom ha scritto: >>> What version

Re: [Qemu-devel] xen-unstable qemu-upstream: libxl: error: libxl_qmp.c:440:qmp_next: timeout, libxl_qmp.c:705:libxl__qmp_initialize: Failed to connect to QMP

2013-04-19 Thread Sander Eikelenboom
Friday, April 19, 2013, 3:00:56 PM, you wrote: > Il 19/04/2013 14:56, Sander Eikelenboom ha scritto: >> >> Friday, April 19, 2013, 10:04:22 AM, you wrote: >> >>> Il 19/04/2013 09:52, Sander Eikelenboom ha scritto: >> What version is glib on the host? Ah i knew i forgot to look somethin

Re: [Qemu-devel] [PATCH 00/10] target-ppc: emulate Power ISA 2.05 instructions

2013-04-19 Thread Alexander Graf
On 13.04.2013, at 14:47, Aurelien Jarno wrote: > qemu-system-ppc64 -M pseries clamis to emulate a POWER7 CPU, > corresponding to an ISA 2.06 compliant CPU, while QEMU emulates > something like an ISA 2.04 CPU. > > Given that glibc and GCC start to use some instructions like cmpb and > fcpsgn, th

[Qemu-devel] [PATCH v2 4/4] qemu-char: do not operate on sources from finalize callbacks

2013-04-19 Thread Paolo Bonzini
Due to a glib bug, the finalize callback is called with the GMainContext lock held. Thus, any operation on the context from the callback will cause recursive locking and a deadlock. This happens, for example, when a client disconnects from a socket chardev. The fix for this is somewhat ugly, bec

[Qemu-devel] [PATCH v2 0/4] another round of qemu-char fixes

2013-04-19 Thread Paolo Bonzini
These three patches fix the bugs that Gerd reported. The first patches try to make the code consistent (which should avoid that half of the drivers bark with CRITICAL messages from glib) and also fix detection of pty connections so that they do not go berserk with polling. This is likely the same

[Qemu-devel] [PATCH v2 1/4] qemu-char: use consistent idiom for removing sources

2013-04-19 Thread Paolo Bonzini
Always check that the source is active, and zero the tag afterwards. The occurrence in pty_chr_state will trigger with the next patch, the others are just theoretical. Signed-off-by: Paolo Bonzini --- qemu-char.c | 32 +++- 1 files changed, 23 insertions(+), 9 dele

[Qemu-devel] [PATCH v2 2/4] qemu-char: simplify pty polling

2013-04-19 Thread Paolo Bonzini
There is no need to use a timer and pty_chr_read to detect a connected pty. It is simpler to just call g_poll periodically and check for POLLHUP. It is done once per second, and only if the pty is disconnected, so it is cheap enough. Tested with "-monitor pty" and "-serial mon:pty", both of which

[Qemu-devel] [PATCH v2 3/4] qemu-char: correct return value from chr_read functions

2013-04-19 Thread Paolo Bonzini
Even if a CharDriverState's source is blocked by the front-end, it must not be dropped. The IOWatchPoll that wraps it will take care of adding and removing it to the main loop. Only remove the source when the channel is closed; and in that case, make sure that the wrapping IOWatchPoll is removed t

Re: [Qemu-devel] [Qemu-ppc] Is FW_CFG_PPC_CPUFREQ deprecated?

2013-04-19 Thread Alexander Graf
On 12.04.2013, at 14:29, Mark Cave-Ayland wrote: > Hi everyone, > > Has FW_CFG_PPC_CPUFREQ been removed from QEMU for some reason? I noticed that > the value always comes back as 0 in OpenBIOS, and it looks as if the > FW_CFG_PPC_CPUFREQ constant (FW_CFG_ARCH_LOCAL + 0x4) has been removed from

Re: [Qemu-devel] [PATCH] powerpc: correctly handle fpu exceptions.

2013-04-19 Thread Alexander Graf
On 09.04.2013, at 17:00, Fabien Chouteau wrote: > From: Tristan Gingold > > Raise the exception on the first occurence, do not wait for the next > floating point operation. > > Signed-off-by: Fabien Chouteau Thanks, applied to ppc-next. Alex > --- > target-ppc/fpu_helper.c | 23 +

[Qemu-devel] [PULL 0/4] target-arm queue

2013-04-19 Thread Peter Maydell
target-arm pullreq, containing a fix for a dumb SRS bug I introduced, and the update to migration to use vmstate (both of which have been on the list since before freeze). Please pull. thanks -- PMM The following changes since commit 09dada400328d75daf79e3eca1e48e024fec148d: configure: remove

Re: [Qemu-devel] [0/7] Pending pseries updates

2013-04-19 Thread Alexander Graf
On 08.04.2013, at 07:08, David Gibson wrote: > Hi Alex, > > Here's my latest batch of pending pseries updates. Mostly pretty > small bugfixes and extensions. Thanks, applied all to ppc-next. Alex

[Qemu-devel] [PATCH 3/4] target-arm: Add some missing CPU state fields to VMState

2013-04-19 Thread Peter Maydell
A number of CPU state fields were accidentally omitted from our migration state: some OMAP specific cp15 registers, and some related to state for load/store exclusive insns. Add them. Signed-off-by: Peter Maydell --- target-arm/machine.c | 13 ++--- 1 file changed, 10 insertions(+), 3

[Qemu-devel] [PATCH 1/4] target-arm: Reinsert missing return statement in ARM mode SRS decode

2013-04-19 Thread Peter Maydell
From: Peter Chubb Since patch 81465888c5306cd94abb9847e560796fd13d3c2f target-arm: factor out handling of SRS instruction the ARM mode SRS instruction has not worked in QEMU. The problem is a missing return directive that was removed in the refactoring, so after decoding the instruction, q

[Qemu-devel] [PATCH 2/4] target-arm: port ARM CPU save/load to use VMState

2013-04-19 Thread Peter Maydell
From: Juan Quintela Port the ARM CPU save/load code to use VMState. Some state is saved in a slightly different order to simplify things -- for example arrays are saved one after the other rather than 'striped', and we always save all 32 VFP registers even if the CPU happens to only have 16. Use

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-19 Thread Paolo Bonzini
Il 19/04/2013 11:52, Amos Kong ha scritto: > Libvirt doesn't have a stable way to know option support > detail. This patch introdued a new qmp command to query > configuration schema information. hmp command isn't added. Can you introspect QemuOpts instead? All new options are added there. Paolo

[Qemu-devel] [PATCH 06/11] versatile_pci: Put the host bridge PCI device at slot 29

2013-04-19 Thread Peter Maydell
On real hardware the host bridge appears as a PCI device in slot 29, so make QEMU put its host bridge in that slot too. Signed-off-by: Peter Maydell Acked-by: Paul Brook --- hw/pci-host/versatile.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci-host/versatile.c b/hw/pci-host/ve

[Qemu-devel] [PATCH 4/4] target-arm: Correctly restore FPSCR

2013-04-19 Thread Peter Maydell
Use the helper functions to save and restore the FPSCR, so that we correctly propagate rounding mode and flushing behaviour into the float_status fields. This also allows us to stop saving the vector length/stride fields separately. Signed-off-by: Peter Maydell --- target-arm/machine.c | 48 ++

[Qemu-devel] [PATCH 10/11] versatile_pci: Expose PCI memory space to system

2013-04-19 Thread Peter Maydell
The VersatilePB's PCI controller exposes the PCI memory space to the system via three regions controlled by the mapping control registers. Implement this so that guests can actually use MMIO-BAR PCI cards. Signed-off-by: Peter Maydell Acked-by: Paul Brook --- hw/arm/realview.c |3 ++

[Qemu-devel] [PATCH 07/11] versatile_pci: Implement the correct PCI IRQ mapping

2013-04-19 Thread Peter Maydell
Implement the correct IRQ mapping for the Versatile PCI controller; it differs between realview and versatile boards, but the previous QEMU implementation was correct only for the first PCI card on a versatile board, since we weren't swizzling IRQs based on the slot number. Since this change would

[Qemu-devel] [PATCH 04/11] versatile_pci: Change to subclassing TYPE_PCI_HOST_BRIDGE

2013-04-19 Thread Peter Maydell
Change versatile_pci to subclass TYPE_PCI_HOST_BRIDGE and generally handle PCI in a more QOM-like fashion. Signed-off-by: Peter Maydell Acked-by: Paul Brook --- hw/pci-host/versatile.c | 41 ++--- 1 file changed, 30 insertions(+), 11 deletions(-) diff --gi

[Qemu-devel] [PATCH 02/11] versatile_pci: Expose PCI I/O region on Versatile PB

2013-04-19 Thread Peter Maydell
Comments in the QEMU source code claim that the version of the PCI controller on the VersatilePB board doesn't support the PCI I/O region, but this is incorrect; expose that region, map it in the correct location, and drop the misleading comments. This change removes the only currently implemented

[Qemu-devel] [PATCH 03/11] versatile_pci: Update to realize and instance init functions

2013-04-19 Thread Peter Maydell
Update the Versatile PCI controller to use a realize function rather than SysBusDevice::init. To reflect the fact that the 'realview_pci' class is taking most of its implementation from 'versatile_pci' (and to make the QOM casts work) we make 'realview_pci' a subclass of 'versatile_pci'. Signed-of

[Qemu-devel] [PATCH 08/11] versatile_pci: Implement the PCI controller's control registers

2013-04-19 Thread Peter Maydell
The versatile_pci PCI controller has a set of control registers which handle the mapping between PCI and system address spaces. Implement these registers (though for now they have no effect since we don't implement mapping PCI space into system memory at all). The most natural order for our sysbus

[Qemu-devel] [PULL 00/11] arm-devs queue

2013-04-19 Thread Peter Maydell
arm-devs queue pullreq; this is just the versatile-pci cleanup (which has been on the list for some time now). Please pull. thanks -- PMM The following changes since commit 09dada400328d75daf79e3eca1e48e024fec148d: configure: remove duplicate test (2013-04-18 14:12:31 +0200) are available in

[Qemu-devel] [PATCH 05/11] versatile_pci: Use separate PCI I/O space rather than system I/O space

2013-04-19 Thread Peter Maydell
Rather than overloading the system I/O space (which doesn't even make any sense on ARM) for PCI I/O, create an memory region in the PCI controller and use that to represent the I/O space. Signed-off-by: Peter Maydell Acked-by: Paul Brook --- hw/pci-host/versatile.c | 17 + 1 f

[Qemu-devel] [PATCH 09/11] arm/realview: Fix mapping of PCI regions

2013-04-19 Thread Peter Maydell
Fix the mapping of the PCI regions for the realview board, which were all incorrect. (This was never noticed because the Linux kernel doesn't actually include a PCI driver for the realview boards.) Signed-off-by: Peter Maydell Acked-by: Paul Brook --- hw/arm/realview.c | 18 +-

[Qemu-devel] [PATCH 11/11] hw/versatile_pci: Drop unnecessary vpb_pci_config_addr()

2013-04-19 Thread Peter Maydell
Drop the vpb_pci_config_addr() function -- it is unnecessary since the size of the memory regions means the hwaddr is always within the 24 bit size. (This function was probably a leftover from when read/write functions were called with absolute addresses rather than relative ones.) Signed-off-by:

[Qemu-devel] [PATCH 01/11] versatile_pci: Fix hardcoded tabs

2013-04-19 Thread Peter Maydell
There is just one line in this source file with a hardcoded tab indent, so just fix it. Signed-off-by: Peter Maydell Acked-by: Paul Brook --- hw/pci-host/versatile.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c index d6

[Qemu-devel] [PATCH 7/9] vhost-scsi-pci: new device supporting the tcm_vhost Linux kernel module

2013-04-19 Thread Paolo Bonzini
From: Nicholas Bellinger Cc: Michael S. Tsirkin Signed-off-by: Nicholas Bellinger Signed-off-by: Asias He Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-pci.c | 60 ++ hw/virtio/virtio-pci.h | 18 +++ 2 files changed, 78 insertio

[Qemu-devel] [PATCH 2/2] i386: use CPUClass->write_elf* functions

2013-04-19 Thread Jens Freimann
Rework dump-guest-memory support to implement write_elfXX_note methods of CPUClass. Signed-off-by: Jens Freimann --- include/sysemu/dump.h | 1 - target-i386/arch_dump.c | 25 + target-i386/cpu-qom.h | 9 + target-i386/cpu.c | 7 +++ 4 files chang

[Qemu-devel] [PATCH 1/2] qom: Convert cpu_write_elfXX_note functions to CPUState

2013-04-19 Thread Jens Freimann
Convert cpu_write_elfXX_note functions to CPUClass methods and pass CPUState as argument Signed-off-by: "Jens Freimann next_cpu) { cpu = ENV_GET_CPU(env); id = cpu_index(cpu); -ret = cpu_write_elf64_note(fd_write_vmcore, env, id, s); +ret = cpu_write_elf64_note(fd

[Qemu-devel] [PATCH 0/2] qom: make cpu_write_elfXX_ functions part of CPUClass

2013-04-19 Thread Jens Freimann
Hi Andreas, I have two patches to make dump-guest-memory related cpu_write_elfxx_note functions members of CPUClass and pass CPUstate as an argument instead of CPUArchState. This is preparation for s390 patches which will follow on Monday. Jens Freimann (2): qom: Convert cpu_write_elfXX_note f

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-04-19 Thread Igor Mammedov
On Fri, 19 Apr 2013 15:16:36 +0200 Andreas Färber wrote: > Am 19.04.2013 09:51, schrieb Jens Freimann: > > On Wed, Apr 17, 2013 at 08:06:37PM +0200, Andreas Färber wrote: > >> Hi Jens, > >> > >> Am 03.04.2013 08:42, schrieb Jens Freimann: > >>> this is what our approach to CPU hotplug looks like.

[Qemu-devel] [PATCH resend 1.5] Add option to mlock qemu and guest memory

2013-04-19 Thread Paolo Bonzini
From: Satoru Moriya In certain scenario, latency induced by paging is significant and memory locking is needed. Also, in the scenario with untrusted guests, latency improvement due to mlock is desired. This patch introduces a following new option to mlock guest and qemu memory: -realtime mlock=

[Qemu-devel] [Bug 1163034] Re: linux-user mode can't handle guest setting RLIMIT_AS (hangs running gnutls28 configure check code)

2013-04-19 Thread Peter Maydell
** Summary changed: - gnutls28 fails to build from source in armhf + linux-user mode can't handle guest setting RLIMIT_AS (hangs running gnutls28 configure check code) ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- de

[Qemu-devel] [PATCH 3/3] nbd: set TCP_NODELAY

2013-04-19 Thread Paolo Bonzini
From: Stefan Hajnoczi Disable the Nagle algorithm to reduce latency. Note this means we must also use TCP_CORK when sending header followed by payload to avoid fragmenting lots of little packets. The previous patch took care of that. Suggested-by: Nick Thomas Tested-by: Nick Thomas Signed-of

[Qemu-devel] [PATCH 2/3] nbd: use TCP_CORK in nbd_co_send_request()

2013-04-19 Thread Paolo Bonzini
From: Stefan Hajnoczi Use TCP_CORK to defer packet transmission until both the header and the payload have been written. Suggested-by: Nick Thomas Signed-off-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- block/nbd.c | 22 -- 1 file changed, 16 insertions(+), 6 dele

[Qemu-devel] [PATCH 1/3] nbd: unlock mutex in nbd_co_send_request() error path

2013-04-19 Thread Paolo Bonzini
From: Stefan Hajnoczi Cc: qemu-sta...@nongnu.org Signed-off-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/nbd.c b/block/nbd.c index eff683c..662df16 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -339,7

[Qemu-devel] [PULL 0/3] NBD changes for 2013-04-19

2013-04-19 Thread Paolo Bonzini
The following changes since commit e2ec3f976803b360c70d9ae2ba13852fa5d11665: qjson: to_json() case QTYPE_QSTRING is buggy, rewrite (2013-04-13 19:40:25 +) are available in the git repository at: git://github.com/bonzini/qemu.git nbd-next for you to fetch changes up to 97ebbab0e324831df

[Qemu-devel] [PATCH 9/9] vhost-scsi-s390: new device supporting the tcm_vhost Linux kernel module

2013-04-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini Signed-off-by: Asias He Cc: Michael S. Tsirkin Signed-off-by: Nicholas Bellinger Signed-off-by: Paolo Bonzini --- hw/s390x/s390-virtio-bus.c | 49 ++ hw/s390x/s390-virtio-bus.h | 16 +++ 2 files changed, 65 i

[Qemu-devel] [PATCH 8/9] vhost-scsi-ccw: new device supporting the tcm_vhost Linux kernel module

2013-04-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/s390x/virtio-ccw.c | 51 +++ hw/s390x/virtio-ccw.h | 14 ++ 2 files changed, 65 insertions(+) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index 5232526..56539d3 100644 --- a/hw/s390x/vi

[Qemu-devel] [PATCH 6/9] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-04-19 Thread Paolo Bonzini
From: Nicholas Bellinger The WWPN specified in configfs is passed to "-device vhost-scsi-pci". The tgpt field of the SET_ENDPOINT ioctl is obsolete now, so it is not available from the QEMU command-line. Instead, I hardcode it to zero. Changes in Patch-v2: - Add vhost_scsi_get_features() in

[Qemu-devel] [PATCH 3/9] vhost: Add vhost_commit callback for SeaBIOS ROM region re-mapping

2013-04-19 Thread Paolo Bonzini
From: Nicholas Bellinger This patch follows MST's recommendation to move checks for vhost_verify_ring_mappings() -> cpu_physical_memory_map() operations from MemoryListener->region_[add,del]() -> vhost_set_memory() into final MemoryListener->commit() -> vhost_commit() callback. It addresses the

[Qemu-devel] [PATCH 4/9] virtio-scsi: create VirtIOSCSICommon

2013-04-19 Thread Paolo Bonzini
This patch refactors existing virtio-scsi code into VirtIOSCSICommon in order to allow virtio_scsi_init_common() to be used by both internal virtio_scsi_init() and external vhost-scsi-pci code. Cc: Michael S. Tsirkin Cc: Asias He Signed-off-by: Paolo Bonzini --- hw/s390x/s390-virtio-bus.c

[Qemu-devel] [PATCH 5/9] virtio: simplify Makefile conditionals

2013-04-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/Makefile.objs| 2 +- hw/virtio/Makefile.objs | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/Makefile.objs b/hw/Makefile.objs index b7a1613..0243d6a 100644 --- a/hw/Makefile.objs +++ b/hw/Makefile.objs @@ -24,7 +24,7 @@ d

[Qemu-devel] [PULL 0/9] SCSI updates for 2013-04-13

2013-04-19 Thread Paolo Bonzini
The following changes since commit 09dada400328d75daf79e3eca1e48e024fec148d: configure: remove duplicate test (2013-04-18 14:12:31 +0200) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes up to d6e51919a7e3250bbfb4bb0ad0f208ab6fd688

[Qemu-devel] [PATCH 1/9] scsi: avoid assertion failure on VERIFY command

2013-04-19 Thread Paolo Bonzini
A verify command is not an actual read (we do not implement compare mode) and thus does not have an AIOCB attached. Do not crash in scsi_dma_complete. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/hw

Re: [Qemu-devel] [PATCH] NVMe: Initial commit

2013-04-19 Thread Keith Busch
On Fri, 19 Apr 2013, Stefan Hajnoczi wrote: I don't see bdrv_aio_flush() in this patch. How does the guest ensure that data is safely on persistent storage (e.g. protected against data loss by power failure). Great point! This is to be consistent with the NVMe spec. This commit is the bare min

[Qemu-devel] [PATCH 3/3] linux-user: fix setgroups/getgroups for non-UID16 archs

2013-04-19 Thread riku . voipio
From: Andreas Schwab Don't assume target_id is a short. Signed-off-by: Andreas Schwab Signed-off-by: Riku Voipio --- linux-user/syscall.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 5a786f2..c705960 100644 ---

[Qemu-devel] [PATCH 2/3] linux-user: fix undefined shift in copy_to_user_fdset

2013-04-19 Thread riku . voipio
From: Andreas Schwab If TARGET_ABI_BITS is bigger than 32 we shift by more than the size of int. Signed-off-by: Andreas Schwab Reviewed-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/syscall.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/sysc

[Qemu-devel] [PATCH v4 7/8] virtio-rng: cleanup: remove qdev field.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic The qdev field is no longer needed, just drop it. Signed-off-by: KONRAD Frederic --- hw/virtio/virtio-rng.c | 2 -- include/hw/virtio/virtio-rng.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index 805dd18..

[Qemu-devel] [PULL] [PATCH 0/3] linux-user pending patches

2013-04-19 Thread riku . voipio
From: Riku Voipio The following changes since commit 09dada400328d75daf79e3eca1e48e024fec148d: configure: remove duplicate test (2013-04-18 14:12:31 +0200) are available in the git repository at: git://git.linaro.org/people/rikuvoipio/qemu.git linux-user-for-upstream for you to fetch chan

[Qemu-devel] [PATCH v4 4/8] virtio-rng-s390: switch to the new API.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Here the virtio-rng-s390 is modified for the new API. The device virtio-rng-s390 extends virtio-s390-device as before. It creates and connects a virtio-rng during the init. The properties are not modified. Signed-off-by: KONRAD Frederic --- hw/s390x/s390-virtio-bus.c | 38

[Qemu-devel] [PATCH 1/3] linux-user: change do_semop to return target errno when unsuccessful

2013-04-19 Thread riku . voipio
From: Petar Jovanovic do_semop() is called from two places, and one of these fails to convert return error to target errno when semop fails. This patch changes the function to always return target errno in case of an unsuccessful call. Signed-off-by: Petar Jovanovic Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH v4 6/8] virtio-rng: cleanup: init and exit functions.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic This remove old init and exit function as they are no longer needed. Signed-off-by: KONRAD Frederic --- hw/virtio/virtio-rng.c | 87 +++--- include/hw/virtio/virtio.h | 2 -- 2 files changed, 21 insertions(+), 68 deletions(-)

[Qemu-devel] [PATCH v4 8/8] virtio-rng: cleanup: use QOM casts.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic As the virtio-rng-pci, virtio-rng-s390 and virtio-rng-ccw are switched to the new API, we can use QOM casts. Signed-off-by: KONRAD Frederic Reviewed-by: Andreas Färber --- hw/virtio/virtio-rng.c | 27 +++ include/hw/virtio/virtio-rng.h |

[Qemu-devel] [PATCH v4 1/8] virtio-rng: don't use pointer for configuration.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic The configuration field must not be a pointer as it will be used for virtio-rng properties. So *conf is replaced by conf. Signed-off-by: KONRAD Frederic --- hw/virtio/virtio-rng.c | 12 ++-- include/hw/virtio/virtio-rng.h | 2 +- 2 files changed, 7 insert

[Qemu-devel] [PATCH v4 5/8] virtio-rng-ccw: switch to the new API.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Here the virtio-rng-ccw is modified for the new API. The device virtio-rng-pci extends virtio-pci. It creates and connects a virtio-rng-device during the init. The properties are not changed. Signed-off-by: KONRAD Frederic --- hw/s390x/virtio-ccw.c | 48 ++

[Qemu-devel] [PATCH v4 3/8] virtio-rng-pci: switch to the new API.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Here the virtio-rng-pci is modified for the new API. The device virtio-rng-pci extends virtio-pci. It creates and connects a virtio-rng-device during the init. The properties are not changed. The virtio_pci_reset function, is removed as no longer used. The virtio_pci_rst fu

[Qemu-devel] [PATCH v4 2/8] virtio-rng: add virtio-rng device.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Create virtio-rng-device which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/s390x/virtio-ccw.c | 3 +- hw/virtio/virtio-pci.c | 8 +-- hw/virtio/virtio-rng.c | 108 +

[Qemu-devel] [PATCH v4 0/8] virtio-rng refactoring.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Tested-by: Cornelia Huck Acked-by: Amit Shah This is the last backend of the refactoring (*and must be applied at last, because it would break virtio-9p*). Basically it creates virtio-rng-device which extends virtio-device. Then a virtio-rng-device can be connected on a

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-19 Thread Osier Yang
On 19/04/13 20:39, Eric Blake wrote: On 04/19/2013 03:52 AM, Amos Kong wrote: Libvirt doesn't have a stable way to know option support detail. This patch introdued a new qmp command to query configuration schema information. hmp command isn't added. Agreed; HMP is not needed: by the time you ca

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-19 Thread Osier Yang
On 19/04/13 20:02, Osier Yang wrote: On 19/04/13 17:52, Amos Kong wrote: Libvirt doesn't have a stable way to know option support Actually no way now. Libvirt swtiched to use qmp to collect the qemu capabilities for qemu newer than 1.2.0, thus there is no way to probe either if a option or a

[Qemu-devel] [PATCH RESEND v3 3/4] virtio-9p: cleanup: init function.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic This remove old init function as it is no longer needed. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p-device.c | 75 ++ 1 file changed, 23 insertions(+), 52 deletions(-) diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs

[Qemu-devel] [PATCH RESEND v3 4/4] virtio-9p: cleanup: QOM casts.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic As the virtio-9p-pci is switched to the new API, we can use QOM casts. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p-device.c | 11 +++ hw/9pfs/virtio-9p.c| 2 +- hw/9pfs/virtio-9p.h| 2 +- 3 files changed, 5 insertions(+), 10 deletions(-)

[Qemu-devel] [PATCH RESEND v3 2/4] virtio-9p-pci: switch to the new API.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Here the virtio-9p-pci is modified for the new API. The device virtio-9p-pci extends virtio-pci. It creates and connects a virtio-9p during the init. The properties are not changed. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p.h| 1 - hw/virtio/virtio-pci.c |

[Qemu-devel] [PATCH RESEND v3 1/4] virtio-9p: add the virtio-9p device.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic Create virtio-9p which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/9pfs/virtio-9p-device.c | 73 +- hw/9pfs/virtio-9p.h| 9 ++ hw/virtio/virtio-pci.c | 3 +

[Qemu-devel] [PATCH RESEND v3 0/4] virtio-9p refactoring.

2013-04-19 Thread fred . konrad
From: KONRAD Frederic This is the next part of virtio-refactoring: nothing changed, it's just rebased. Basically it creates virtio-9p-device backend which extends virtio-device. Then a virtio-9p-device can be connected on a virtio-bus. virtio-9p-pci is modified, extends virtio-pci and have a vir

Re: [Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-04-19 Thread Andreas Färber
Am 19.04.2013 09:51, schrieb Jens Freimann: > On Wed, Apr 17, 2013 at 08:06:37PM +0200, Andreas Färber wrote: >> Hi Jens, >> >> Am 03.04.2013 08:42, schrieb Jens Freimann: >>> this is what our approach to CPU hotplug looks like. >>> With respect to Igor's CPU hotplug series, how should we proceed?

Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command

2013-04-19 Thread Eric Blake
On 04/19/2013 02:37 AM, Markus Armbruster wrote: >> Question for the libvirt guys: Is it ok for libvirt to just extend the >> existing screendump command? Can libvirt figure there is a new >> (optional) parameter? See patch #5. > > Nope, QMP can't do that. I argued for such capabilities, but t

Re: [Qemu-devel] xen-unstable qemu-upstream: libxl: error: libxl_qmp.c:440:qmp_next: timeout, libxl_qmp.c:705:libxl__qmp_initialize: Failed to connect to QMP

2013-04-19 Thread Paolo Bonzini
Il 19/04/2013 14:56, Sander Eikelenboom ha scritto: > > Friday, April 19, 2013, 10:04:22 AM, you wrote: > >> Il 19/04/2013 09:52, Sander Eikelenboom ha scritto: > What version is glib on the host? >>> Ah i knew i forgot to look something up .. >>> >>> ii libglib2.0-0

Re: [Qemu-devel] xen-unstable qemu-upstream: libxl: error: libxl_qmp.c:440:qmp_next: timeout, libxl_qmp.c:705:libxl__qmp_initialize: Failed to connect to QMP

2013-04-19 Thread Sander Eikelenboom
Friday, April 19, 2013, 10:04:22 AM, you wrote: > Il 19/04/2013 09:52, Sander Eikelenboom ha scritto: >>> > What version is glib on the host? >> Ah i knew i forgot to look something up .. >> >> ii libglib2.0-0 >> 2.24.2-1

[Qemu-devel] [PULL 2/2] virtio-balloon: fix integer overflow in BALLOON_CHANGE QMP event

2013-04-19 Thread Luiz Capitulino
Because dev->actual is uint32_t, the expression 'dev->actual << VIRTIO_BALLOON_PFN_SHIFT' is truncated to 32 bits. This overflows when dev->actual >= 1048576. To reproduce: 1. Start a VM with a QMP socket and 5G of RAM 2. Connect to the QMP socket, negotiate capabilities and issue: { "execu

[Qemu-devel] [PULL 0/2] QMP queue

2013-04-19 Thread Luiz Capitulino
Two important fixes. The changes (since 09dada400328d75daf79e3eca1e48e024fec148d) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Amos Kong (1): monitor: fix the wrong order of releasing keys Luiz Capitulino (1): virtio-balloon: fix integer ov

[Qemu-devel] [PULL 1/2] monitor: fix the wrong order of releasing keys

2013-04-19 Thread Luiz Capitulino
From: Amos Kong (qemu) sendkey ctrl_r-scroll_lock-scroll_lock Executing this command could not let Windows guest panic, it caused by the wrong order of releasing keys. This problem was introduced by commit e4c8f004c55d9da3eae3e14df740238bf805b5d6. The right release order should be starting from

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-19 Thread Eric Blake
On 04/19/2013 03:52 AM, Amos Kong wrote: > Libvirt doesn't have a stable way to know option support > detail. This patch introdued a new qmp command to query > configuration schema information. hmp command isn't added. Agreed; HMP is not needed: by the time you can connect to a human monitor, you'

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-19 Thread Eric Blake
On 04/19/2013 06:02 AM, Osier Yang wrote: > On 19/04/13 17:52, Amos Kong wrote: >> Libvirt doesn't have a stable way to know option support > > Actually no way now. > >> + >> +## >> +# @ConfigSchemaInfo: >> +# >> +# Configration schema information. >> +# >> +# @option: option name >> +# >> +# @c

Re: [Qemu-devel] [PATCH v2 13/23] qapi: Add a primitive to include other files from a QAPI schema file

2013-04-19 Thread Lluís Vilanova
Eric Blake writes: > On 04/16/2013 07:51 AM, Lluís Vilanova wrote: >> Adds the "input(...)" primitive to the syntax of QAPI schema files. > Interesting idea, but isn't "include(...)" a more common name than > "input(...)"? Indeed it is. Thanks for the catch. Lluis -- "And it's much the same

Re: [Qemu-devel] [PATCH] tcg: Remove temp_buf

2013-04-19 Thread Andreas Färber
Am 19.04.2013 14:11, schrieb Andreas Färber: > Hi, > > Am 19.04.2013 10:27, schrieb Richard Henderson: >> All targets have been converted to allocating space for temporaries >> on the stack. No need to allocate space within the CPU_COMMON block. >> >> Signed-off-by: Richard Henderson >> --- >> T

Re: [Qemu-devel] [PATCH] tcg: Remove temp_buf

2013-04-19 Thread Andreas Färber
Hi, Am 19.04.2013 10:27, schrieb Richard Henderson: > All targets have been converted to allocating space for temporaries > on the stack. No need to allocate space within the CPU_COMMON block. > > Signed-off-by: Richard Henderson > --- > This depends on my tcg-arm patch set that's still outstan

  1   2   >