Re: [Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm

2013-04-24 Thread Wenchao Xia
+char buf[256]; I know this fixed-size buffer is just a copy-and-paste from other code that displays snapshot information, but I really hate it. On the other hand, I can tolerate if we have it as an intermediate step between two series that both land in the same release. If your serie

Re: [Qemu-devel] [PATCH] virtio-net: unbreak the minix guest

2013-04-24 Thread Michael S. Tsirkin
On Thu, Apr 25, 2013 at 02:19:53PM +0800, Jason Wang wrote: > Multiqueue patchset conditionally add control vq only when guest negotiate the > feature. Though the spec is not clear on this but it breaks the minix guest > since it will identify the ctrl vq even if it does not support it. Though this

Re: [Qemu-devel] Para-Virtualized Clock Usage

2013-04-24 Thread Gleb Natapov
On Thu, Apr 25, 2013 at 12:28:35AM +, Joji Mekkattuparamban (joji) wrote: > Thank you Gleb and Marcelo. I will migrate the API using gettimeofday. > > Is there any dependency on the QEMU or the Guest? If the host supports > pvclock and the guest invokes gettimeofday, would the pvclock be > a

Re: [Qemu-devel] [PATCH v2 03/12] savevm: update bdrv_snapshot_find() to find snapshot by id or name and add error parameter

2013-04-24 Thread Pavel Hrdina
On 25.4.2013 08:31, Wenchao Xia wrote: >> Finding snapshot by a name which could also be an id isn't best way >> how to do it. There will be rewrite of savevm, loadvm and delvm to >> improve the behavior of these commands. The savevm and loadvm will >> have their own patch series. >> >> Now bdrv_sn

[Qemu-devel] Git head build problem (popcountl vs. system headers)

2013-04-24 Thread Martin Husemann
I just tried building git HEAD on NetBSD-current and gcc chokes on a prototype mismatch for popcountl: util/hbitmap.c has: static inline int popcountl(unsigned long l) { return BITS_PER_LONG == 32 ? ctpop32(l) : ctpop64(l); } while NetBSD's strings.h uses: unsigned intpopcountl(unsi

Re: [Qemu-devel] [PATCH v2 03/12] savevm: update bdrv_snapshot_find() to find snapshot by id or name and add error parameter

2013-04-24 Thread Pavel Hrdina
On 24.4.2013 23:26, Eric Blake wrote: On 04/24/2013 09:32 AM, Pavel Hrdina wrote: Finding snapshot by a name which could also be an id isn't best way how to do it. There will be rewrite of savevm, loadvm and delvm to improve the behavior of these commands. The savevm and loadvm will have their o

[Qemu-devel] [PATCH] virtio-net: unbreak the minix guest

2013-04-24 Thread Jason Wang
Multiqueue patchset conditionally add control vq only when guest negotiate the feature. Though the spec is not clear on this but it breaks the minix guest since it will identify the ctrl vq even if it does not support it. Though this behavior seems a violation on the spec "If the VIRTIO_NET_F_CTRL_

Re: [Qemu-devel] [PATCH v2 03/12] savevm: update bdrv_snapshot_find() to find snapshot by id or name and add error parameter

2013-04-24 Thread Wenchao Xia
> Finding snapshot by a name which could also be an id isn't best way > how to do it. There will be rewrite of savevm, loadvm and delvm to > improve the behavior of these commands. The savevm and loadvm will > have their own patch series. > > Now bdrv_snapshot_find takes more parameters. The name

[Qemu-devel] [PATCH] virtio-net: count VIRTIO_NET_F_MAC when calculating config_len

2013-04-24 Thread Jason Wang
Commit 14f9b664 (hw/virtio-net.c: set config size using host features) tries to calculate config size based on the host features. But it forgets the VIRTIO_NET_F_MAC were always set for qemu later. This will lead a zero config len for virtio-net device when both VIRTIO_NET_F_STATUS and VIRTIO_NET_F

Re: [Qemu-devel] [PATCH V2 18/20] virtio-net: multiqueue support

2013-04-24 Thread Jason Wang
On 04/17/2013 04:42 PM, Aurelien Jarno wrote: > On Wed, Apr 17, 2013 at 04:27:13PM +0800, Jason Wang wrote: >> On 04/17/2013 03:20 PM, Aurelien Jarno wrote: >>> On Tue, Apr 16, 2013 at 11:08:59AM +0800, Jason Wang wrote: On 04/15/2013 04:28 PM, Aurelien Jarno wrote: > On Mon, Apr 15, 2013

Re: [Qemu-devel] [PATCH v20 4/7] pvpanic: pass configurable ioport to seabios

2013-04-24 Thread Hu Tao
On Wed, Apr 24, 2013 at 06:35:49PM +0200, Markus Armbruster wrote: > Hu Tao writes: > > > This lets seabios patch the corresponding SSDT entry. > > > > Signed-off-by: Hu Tao > > --- > > hw/misc/pvpanic.c | 14 ++ > > hw/nvram/fw_cfg.c | 8 +++- > > include/hw/nv

Re: [Qemu-devel] [PATCH v4] monitor: introduce query-command-line-options

2013-04-24 Thread Osier Yang
On 25/04/13 13:06, Amos Kong wrote: Libvirt has no way to probe if an option or property is supported, This patch introdues a new qmp command to query command line option information. hmp command isn't added because it's not needed. Signed-off-by: Amos Kong CC: Osier Yang CC: Anthony Liguori

[Qemu-devel] [PATCH 4/4] doc: document the Pseudo-encoding of LED state

2013-04-24 Thread Lei Li
Signed-off-by: Lei Li --- docs/vnc-ledstate-Pseudo-encoding.txt | 50 + 1 files changed, 50 insertions(+), 0 deletions(-) create mode 100644 docs/vnc-ledstate-Pseudo-encoding.txt diff --git a/docs/vnc-ledstate-Pseudo-encoding.txt b/docs/vnc-ledstate-Pseudo-enc

[Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-04-24 Thread Lei Li
Signed-off-by: Lei Li --- ui/vnc.c | 45 + ui/vnc.h |3 +++ 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index f574962..44189d7 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1522,6 +1522,42 @@ static void press_ke

[Qemu-devel] [PATCH 3/4] vnc: Adjust lock state sync logic with VNC_FEATURE_LED_STATE

2013-04-24 Thread Lei Li
Signed-off-by: Lei Li --- ui/vnc.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 44189d7..9ffa75b 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1613,7 +1613,11 @@ static void do_key_event(VncState *vs, int down, int keycode, int sym) b

[Qemu-devel] [PATCH 0/4 v4] Support for LED state extension to Qemu VNC server

2013-04-24 Thread Lei Li
Hi guys, This patch series tries to add support for LED state extension to Qemu VNC server. The proposal has been sent few days ago as link below: http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html The previous version as link: http://lists.nongnu.org/archive/html/qemu-devel/201

[Qemu-devel] [PATCH 1/4] vnc: Add SCROLL lock key to kbd_leds

2013-04-24 Thread Lei Li
Signed-off-by: Lei Li --- ui/vnc.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 8ee66b7..f574962 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1525,10 +1525,11 @@ static void press_key(VncState *vs, int keysym) static void kbd_leds(void *opaq

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command

2013-04-24 Thread Amos Kong
On Thu, Apr 25, 2013 at 12:27:16PM +0800, Osier Yang wrote: > On 25/04/13 11:52, Amos Kong wrote: > >On Wed, Apr 24, 2013 at 01:39:08PM -0600, Eric Blake wrote: > >>On 04/24/2013 12:20 PM, Luiz Capitulino wrote: > >>>On Thu, 25 Apr 2013 01:33:24 +0800 > >>>Amos Kong wrote: > >>> > Libvirt has

[Qemu-devel] [PATCH v4] monitor: introduce query-command-line-options

2013-04-24 Thread Amos Kong
Libvirt has no way to probe if an option or property is supported, This patch introdues a new qmp command to query command line option information. hmp command isn't added because it's not needed. Signed-off-by: Amos Kong CC: Osier Yang CC: Anthony Liguori --- V3: fix jaso schema and comments (

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command

2013-04-24 Thread Osier Yang
On 25/04/13 11:52, Amos Kong wrote: On Wed, Apr 24, 2013 at 01:39:08PM -0600, Eric Blake wrote: On 04/24/2013 12:20 PM, Luiz Capitulino wrote: On Thu, 25 Apr 2013 01:33:24 +0800 Amos Kong wrote: Libvirt has no way to probe if an option or property is supported, This patch introdues a new qmp

Re: [Qemu-devel] [PATCH v2] sheepdog: fix loadvm operation

2013-04-24 Thread Liu Yuan
On 04/25/2013 12:47 AM, Liu Yuan wrote: > - don't break old behavior if we boot up on the snapshot by using s->reverted >to indicate if we delete working VDI successfully If we implement 'boot from snapshot' == loadvm snapshot, we don't need s->reverted. What do you think, Kazutaka? With this

Re: [Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension

2013-04-24 Thread Lei Li
On 04/24/2013 07:44 PM, Gerd Hoffmann wrote: Hi, +case VNC_ENCODING_LED_STATE: +vs->features |= VNC_FEATURE_LED_STATE_MASK; +break; I think it with the client supporting the led state extension it is probably a good idea to turn off the lock state sync logic

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command

2013-04-24 Thread Amos Kong
On Wed, Apr 24, 2013 at 01:39:08PM -0600, Eric Blake wrote: > On 04/24/2013 12:20 PM, Luiz Capitulino wrote: > > On Thu, 25 Apr 2013 01:33:24 +0800 > > Amos Kong wrote: > > > >> Libvirt has no way to probe if an option or property is supported, > >> This patch introdues a new qmp command to query

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command

2013-04-24 Thread Osier Yang
On 25/04/13 09:14, Amos Kong wrote: On Wed, Apr 24, 2013 at 02:20:20PM -0400, Luiz Capitulino wrote: On Thu, 25 Apr 2013 01:33:24 +0800 Amos Kong wrote: Libvirt has no way to probe if an option or property is supported, This patch introdues a new qmp command to query configuration schema info

Re: [Qemu-devel] [PATCH v2 02/12] block: update error reporting for bdrv_snapshot_delete() and related functions

2013-04-24 Thread Wenchao Xia
bdrv_snapshot_delete() do not return error number now, and I checked original caller code, they used it only for error reporting, so it is safe to change. Reviewed-by: Wenchao Xia > Signed-off-by: Pavel Hrdina > --- > block.c | 21 + > block/qcow2-sna

Re: [Qemu-devel] [PATCH v2 01/12] qemu-img: introduce qemu_img_handle_error()

2013-04-24 Thread Eric Blake
On 04/24/2013 08:53 PM, Wenchao Xia wrote: >>> >>> +static int qemu_img_handle_error(Error *err) >>> +{ >>> +if (error_is_set(&err)) { >>> +error_report("%s", error_get_pretty(err)); >>> +error_free(err); >>> +return 1; >>> +} >>> +return 0; >> >> Maybe it's jus

Re: [Qemu-devel] [PATCH 3/3] doc: document the Pseudo-encoding of LED state

2013-04-24 Thread Eric Blake
On 04/24/2013 08:25 PM, Lei Li wrote: > On 04/24/2013 10:57 PM, Eric Blake wrote: >> On 04/24/2013 04:12 AM, Lei Li wrote: >>> Signed-off-by: Lei Li >>> --- >>> docs/vnc-ledstate-Pseudo-encoding.txt | 40 >>> + >>> 1 files changed, 40 insertions(+), 0 deletions

Re: [Qemu-devel] [PATCH v2 01/12] qemu-img: introduce qemu_img_handle_error()

2013-04-24 Thread Wenchao Xia
于 2013-4-25 0:44, Eric Blake 写道: On 04/24/2013 09:31 AM, Pavel Hrdina wrote: Later in the patch series we will use this function a few times. This will avoid duplicating the code. Signed-off-by: Pavel Hrdina --- qemu-img.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletion

Re: [Qemu-devel] [RFC PATCH] Throttle-down guest when live migration does not converge.

2013-04-24 Thread Eric Blake
On 04/24/2013 08:21 PM, Chegu Vinod wrote: > Would it be ok to pass in an additional argument to qemu as part of > trigerring the live migration i.e. to indicate if its ok to force > convergence when it fails to converge on its own after N # of tries > following the bulk transfer ? Add a new capa

Re: [Qemu-devel] [PATCH v20 4/7] pvpanic: pass configurable ioport to seabios

2013-04-24 Thread Hu Tao
On Wed, Apr 24, 2013 at 06:34:22PM +0200, Markus Armbruster wrote: > Hu Tao writes: > > > This lets seabios patch the corresponding SSDT entry. > > > > Signed-off-by: Hu Tao > > --- > > hw/misc/pvpanic.c | 14 ++ > > hw/nvram/fw_cfg.c | 8 +++- > > include/hw/nv

Re: [Qemu-devel] [PATCH v20 6/7] pvpanic: create pvpanic by default for machine 1.5

2013-04-24 Thread Hu Tao
On Wed, Apr 24, 2013 at 06:33:12PM +0200, Markus Armbruster wrote: > You forgot to suppress the pvpanic device with the really old machine > types using pc_init_pci_no_kvmclock(). Thanks for pointing it out! > > $ for i in `qemu-system-x86_64 -M help | awk '/^[a-z]/ { print $1 }'| grep -v > xen

Re: [Qemu-devel] [PATCH 3/3] doc: document the Pseudo-encoding of LED state

2013-04-24 Thread Lei Li
On 04/24/2013 10:57 PM, Eric Blake wrote: On 04/24/2013 04:12 AM, Lei Li wrote: Signed-off-by: Lei Li --- docs/vnc-ledstate-Pseudo-encoding.txt | 40 + 1 files changed, 40 insertions(+), 0 deletions(-) create mode 100644 docs/vnc-ledstate-Pseudo-encoding.t

Re: [Qemu-devel] [RFC PATCH] Throttle-down guest when live migration does not converge.

2013-04-24 Thread Chegu Vinod
On 4/24/2013 6:59 PM, Anthony Liguori wrote: On Wed, Apr 24, 2013 at 6:42 PM, Chegu Vinod > wrote: Busy enterprise workloads hosted on large sized VM's tend to dirty memory faster than the transfer rate achieved via live guest migration. Despite some go

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command

2013-04-24 Thread Luiz Capitulino
On Wed, 24 Apr 2013 19:44:37 -0600 Eric Blake wrote: > On 04/24/2013 07:35 PM, Luiz Capitulino wrote: > > >> case QEMU_OPT_SIZE: > >> > >> param_info->type = CONFIG_PARAM_TYPE_SIZE; > >>

Re: [Qemu-devel] [PATCH 0/3 v3] Support for LED state extension to Qemu VNC server

2013-04-24 Thread Lei Li
On 04/24/2013 10:54 PM, Eric Blake wrote: On 04/24/2013 04:12 AM, Lei Li wrote: Hi guys, This patch series tries to add support for LED state extension to Qemu VNC server. The proposal has been sent few days ago as link below: http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command

2013-04-24 Thread Amos Kong
On Wed, Apr 24, 2013 at 07:44:37PM -0600, Eric Blake wrote: > On 04/24/2013 07:35 PM, Luiz Capitulino wrote: > > >> case QEMU_OPT_SIZE: > >> > >> param_info->type = CONFIG_PARAM_TYPE_SIZE; >

Re: [Qemu-devel] [RFC PATCH] Throttle-down guest when live migration does not converge.

2013-04-24 Thread Anthony Liguori
On Wed, Apr 24, 2013 at 6:42 PM, Chegu Vinod wrote: > Busy enterprise workloads hosted on large sized VM's tend to dirty > memory faster than the transfer rate achieved via live guest migration. > Despite some good recent improvements (& using dedicated 10Gig NICs > between hosts) the live migrat

Re: [Qemu-devel] question about concurrent block job

2013-04-24 Thread Zhangleiqiang
Hi, Stefan: May be the "in_use" flag of "bs" at the "drive" unit is too large. Perhaps the "in_use" flag should just lock at the unit of one or some "image(s)" in the image chain, the "image(s)" needed to be locked are always the ones will be write during the job. E.g. "drive_mi

[Qemu-devel] [RFC PATCH] Throttle-down guest when live migration does not converge.

2013-04-24 Thread Chegu Vinod
Busy enterprise workloads hosted on large sized VM's tend to dirty memory faster than the transfer rate achieved via live guest migration. Despite some good recent improvements (& using dedicated 10Gig NICs between hosts) the live migration does NOT converge. A few options that were discussed/bein

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command

2013-04-24 Thread Eric Blake
On 04/24/2013 07:35 PM, Luiz Capitulino wrote: >> case QEMU_OPT_SIZE: >> >> param_info->type = CONFIG_PARAM_TYPE_SIZE; >> >> break; >>

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command

2013-04-24 Thread Eric Blake
On 04/24/2013 07:14 PM, Amos Kong wrote: >>> +## >>> +{'command': 'query-config-schema', 'data': {'*option': 'str'}, >> >> Please, let's not make option optional. It makes the code slightly more >> complex for no good reason. > > For the human, if they don't know the detail name of one option, the

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command

2013-04-24 Thread Luiz Capitulino
On Thu, 25 Apr 2013 09:14:51 +0800 Amos Kong wrote: > On Wed, Apr 24, 2013 at 02:20:20PM -0400, Luiz Capitulino wrote: > > On Thu, 25 Apr 2013 01:33:24 +0800 > > Amos Kong wrote: > > > > > Libvirt has no way to probe if an option or property is supported, > > > This patch introdues a new qmp co

Re: [Qemu-devel] question about concurrent block job

2013-04-24 Thread Zhangleiqiang
Hi, Stefan: Thanks for your relay. There are some jobs like drive-mirror, can keep running continuously (without --finish/--pivort option ). While the mirroring, we may need to run other block jobs, e.g. running block-commit or block-stream to decrease the length of the image ch

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command

2013-04-24 Thread Amos Kong
On Wed, Apr 24, 2013 at 02:20:20PM -0400, Luiz Capitulino wrote: > On Thu, 25 Apr 2013 01:33:24 +0800 > Amos Kong wrote: > > > Libvirt has no way to probe if an option or property is supported, > > This patch introdues a new qmp command to query configuration schema > > information. hmp command i

Re: [Qemu-devel] Para-Virtualized Clock Usage

2013-04-24 Thread Joji Mekkattuparamban (joji)
Thank you Gleb and Marcelo. I will migrate the API using gettimeofday. Is there any dependency on the QEMU or the Guest? If the host supports pvclock and the guest invokes gettimeofday, would the pvclock be automatically used? Or do I require a patch in either the Qemu or the guest kernel? Than

Re: [Qemu-devel] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets

2013-04-24 Thread li guang
在 2013-04-24三的 16:22 +0200,Andreas Färber写道: > Am 24.04.2013 09:40, schrieb li guang: > > 在 2013-04-24三的 08:36 +0100,Peter Maydell写道: > >> On 24 April 2013 08:32, li guang wrote: > >>> I think even others want to use something like you said, > >>> it should not 'cs_base', or, it's a bad name. > >>

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command

2013-04-24 Thread Eric Blake
On 04/24/2013 01:39 PM, Eric Blake wrote: > On 04/24/2013 12:20 PM, Luiz Capitulino wrote: >> On Thu, 25 Apr 2013 01:33:24 +0800 >> Amos Kong wrote: >> >>> Libvirt has no way to probe if an option or property is supported, >>> This patch introdues a new qmp command to query configuration schema >>

Re: [Qemu-devel] [PATCH v6 00/11] rdma: migration support

2013-04-24 Thread Michael R. Hines
On 04/24/2013 05:50 PM, Paolo Bonzini wrote: Il 24/04/2013 21:00, mrhi...@linux.vnet.ibm.com ha scritto: From: "Michael R. Hines" Changes since v5: - Removed max_size hook. The patches look good. I will not be very available in the next few days due to a public holiday here, but I believe t

Re: [Qemu-devel] [PATCH v2 04/12] qapi: Convert delvm

2013-04-24 Thread Eric Blake
On 04/24/2013 09:32 AM, Pavel Hrdina wrote: > QMP command vm-snapshot-delete takes two parameters: name and id. They are > optional, but one of the name or id must be provided. If both are provided > they > will match only the snapshot with the same name and id. The command returns > SnapshotInfo

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Eric Blake
On 04/24/2013 03:59 PM, Eric Blake wrote: > With full-blown command introspection, we would want to be asking for a > JSON representation more details about each parameter, in a struct that > looks something like { 'name':'str', 'type':'', > 'optional':'boolean', '*default':' default of any boolean

Re: [Qemu-devel] Para-Virtualized Clock Usage

2013-04-24 Thread Marcelo Tosatti
On Tue, Apr 23, 2013 at 08:52:16AM +0300, Gleb Natapov wrote: > On Mon, Apr 22, 2013 at 04:58:01PM +, Joji Mekkattuparamban (joji) wrote: > > Greetings, > > > > I have a SMP guest application, running on the 2.6.27 Linux kernel. The > > application, originally written for bare metal, makes ex

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Eric Blake
On 04/24/2013 03:29 PM, Luiz Capitulino wrote: >> -> { "execute": "query-command-capabilities" } >> <- { [ { "type": "drive-mirror", >> "data": [ "granularity", "buf-size" ] }, >>{ "type", ... } >> ] } >> >> And whether a '*command' argument should be optional for filtered >>

Re: [Qemu-devel] [PATCH v6 00/11] rdma: migration support

2013-04-24 Thread Paolo Bonzini
Il 24/04/2013 21:00, mrhi...@linux.vnet.ibm.com ha scritto: > From: "Michael R. Hines" > > Changes since v5: > > - Removed max_size hook. The patches look good. I will not be very available in the next few days due to a public holiday here, but I believe that it's okay for 1.5. It's clearly m

Re: [Qemu-devel] KVM call minutes for 2013-04-23

2013-04-24 Thread Eric Blake
On 04/23/2013 10:06 AM, Eric Blake wrote: >> >> we can change "drive_mirror" to use a new command to see if there >> are the new features. > > drive-mirror changed in 1.4 to add optional buf-size parameter; right > now, libvirt is forced to limit itself to 1.3 interface (no buf-size or > granu

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Luiz Capitulino
On Wed, 24 Apr 2013 23:24:37 +0200 Paolo Bonzini wrote: > Il 24/04/2013 22:36, Luiz Capitulino ha scritto: > > The drive-mirror command was extended in QEMU v1.3.0 with two new > > optional arguments 'granularity' and 'buf-size'. However, there's > > no way for libvirt to query for the existence

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Luiz Capitulino
On Wed, 24 Apr 2013 15:05:23 -0600 Eric Blake wrote: > On 04/24/2013 02:36 PM, Luiz Capitulino wrote: > > The drive-mirror command was extended in QEMU v1.3.0 with two new > > introduced in 1.3, extended in 1.4 > > > optional arguments 'granularity' and 'buf-size'. However, there's > > no way f

Re: [Qemu-devel] [PATCH v2 03/12] savevm: update bdrv_snapshot_find() to find snapshot by id or name and add error parameter

2013-04-24 Thread Eric Blake
On 04/24/2013 09:32 AM, Pavel Hrdina wrote: > Finding snapshot by a name which could also be an id isn't best way > how to do it. There will be rewrite of savevm, loadvm and delvm to > improve the behavior of these commands. The savevm and loadvm will > have their own patch series. > > Now bdrv_sn

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Paolo Bonzini
Il 24/04/2013 22:36, Luiz Capitulino ha scritto: > The drive-mirror command was extended in QEMU v1.3.0 with two new > optional arguments 'granularity' and 'buf-size'. However, there's > no way for libvirt to query for the existence of the new arguments. > > This commit solves this problem by addi

Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Eric Blake
On 04/24/2013 02:36 PM, Luiz Capitulino wrote: > The drive-mirror command was extended in QEMU v1.3.0 with two new introduced in 1.3, extended in 1.4 > optional arguments 'granularity' and 'buf-size'. However, there's > no way for libvirt to query for the existence of the new arguments. > > This

[Qemu-devel] [PATCH 1.5 v2 2/3] win32: add readv/writev emulation

2013-04-24 Thread Paolo Bonzini
Commit e9d8fbf (qemu-file: do not use stdio for qemu_fdopen, 2013-03-27) introduced a usage of writev, which mingw32 does not have. Even though qemu_fdopen itself is not used on mingw32, the future-proof solution is to add an implementation of it. This is simple and similar to how we emulate send

[Qemu-devel] [PATCH 1.5 v2 3/3] win32: generate console executable again

2013-04-24 Thread Paolo Bonzini
The -mwindows option is not anymore in LIBS at this point of the Makefile, it is only in libs_softmmu. Check the right variable. Signed-off-by: Paolo Bonzini --- Makefile.target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.target b/Makefile.target index 2636103..

[Qemu-devel] [PATCH 1.5 v2 1/3] add missing inclusions of config-host.h

2013-04-24 Thread Paolo Bonzini
The next patch will add a dependency of qemu/osdep.h on config-host.h. It could be nicer to use qemu-common.h, but I prefer to be safer this close to hard feature freeze. Signed-off-by: Paolo Bonzini --- qga/channel-posix.c | 1 + tests/libi2c-omap.c | 1 + tests/libqtest.c

[Qemu-devel] [PATCH 1.5 v2 0/3] fix win32 compilation

2013-04-24 Thread Paolo Bonzini
Here is a fix for the Win32 compilation problem that Blue reported, and another nit I found while testing. Paolo Bonzini (3): add missing inclusions of config-host.h win32: add readv/writev emulation win32: generate console executable again Makefile.target | 2 +- include/qemu

[Qemu-devel] [PATCH] KVM: PIC: Only commit irq routing when necessary

2013-04-24 Thread Alexander Graf
The current logic updates KVM's view of our interrupt map every time we change it. While this is nice and bullet proof, it slows things down badly for me. QEMU spends about 3 seconds on every start telling KVM what news it has on its routing maps. Instead, let's just synchronize the whole irq rout

[Qemu-devel] [PATCH] KVM: Don't assume that mpstate exists with in-kernel PIC always

2013-04-24 Thread Alexander Graf
On PPC, we don't support MP state. So far it's not necessary and I'm not convinced yet that we really need to support it ever. However, the current idle logic in QEMU assumes that an in-kernel PIC also means we support MP state. This assumption is not true anymore. Let's split up the two cases in

[Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities

2013-04-24 Thread Luiz Capitulino
The drive-mirror command was extended in QEMU v1.3.0 with two new optional arguments 'granularity' and 'buf-size'. However, there's no way for libvirt to query for the existence of the new arguments. This commit solves this problem by adding the query-drive-mirror-capabilities command, which repor

Re: [Qemu-devel] [PATCH 1/2] Split out dump-guest-memory memory mapping code

2013-04-24 Thread Ekaterina Tumanova
On 04/23/2013 07:41 PM, Eric Blake wrote: On 04/23/2013 09:30 AM, Jens Freimann wrote: Split out dump-guest-memory memory mapping code to allow dumping without memory mapping The qemu dump.c code currently requires CONFIG_HAVE_CORE_DUMP as well as CONFIG_HAVE_GET_MEMORY_MAPPING. This allows for

Re: [Qemu-devel] Virtualbox svga card in KVM

2013-04-24 Thread Veruca Salt
> Date: Mon, 15 Apr 2013 14:26:25 +0200 > From: kra...@redhat.com > To: peter.mayd...@linaro.org > CC: srira...@yahoo.com; stefa...@gmail.com; qemu-devel@nongnu.org; > k...@vger.kernel.org > Subject: Re: [Qemu-devel] Virtualbox svga card in KVM > > On 04/08

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2013-04-24 Thread Daniël van Eeden
This is an issue for me with Win7 SP1 64-bit guest on Ubuntu 12.10 (qemu-kvm 1.2.0+noroms) ** Also affects: qemu-kvm (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.la

Re: [Qemu-devel] [PATCH v2 02/12] block: update error reporting for bdrv_snapshot_delete() and related functions

2013-04-24 Thread Eric Blake
On 04/24/2013 09:32 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > block.c | 21 + > block/qcow2-snapshot.c| 19 +-- > block/qcow2.h | 4 +++- > block/rbd.c | 10 +++--- > block/sheepdog.c

Re: [Qemu-devel] [PATCH 06/21] target-i386: pc: update rtc_cmos on CPU hot-plug

2013-04-24 Thread Andreas Färber
Am 24.04.2013 19:03, schrieb Andreas Färber: > Am 23.04.2013 10:29, schrieb Igor Mammedov: >> it provides updated currently available CPUs count to BIOS on reboot >> >> Signed-off-by: Igor Mammedov >> --- >> v2: >> * reorder fields in rtc_cpu_hotplug_arg, make cpu_added_notifier first. >> * re

Re: [Qemu-devel] [PATCH 1/2] Split out dump-guest-memory memory mapping code

2013-04-24 Thread Eric Blake
On 04/24/2013 11:07 AM, Ekaterina Tumanova wrote: >> This raises an interesting question about introspection - how will >> management apps (such as libvirt) be able to determine whether the >> paging command is supported for a given architecture? Do we need to >> expand the 'MachineInfo' QMP datat

Re: [Qemu-devel] [PATCH 21/21] QMP: add cpu-add command

2013-04-24 Thread Eric Blake
On 04/23/2013 02:29 AM, Igor Mammedov wrote: > Adds "cpu-add id=xxx" QMP command. > > cpu-add's "id" argument is a CPU number in a range [0..max-cpus) > > Example QMP command: > -> { "execute": "cpu-add", "arguments": { "id": 2 } } > <- { "return": {} } > > Signed-off-by: Igor Mammedov > ---

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema command

2013-04-24 Thread Eric Blake
On 04/24/2013 12:20 PM, Luiz Capitulino wrote: > On Thu, 25 Apr 2013 01:33:24 +0800 > Amos Kong wrote: > >> Libvirt has no way to probe if an option or property is supported, >> This patch introdues a new qmp command to query configuration schema >> information. hmp command isn't added because it

[Qemu-devel] [PATCH 10/21 v8] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest

2013-04-24 Thread Igor Mammedov
* introduce processor status bitmask visible to guest at 0xaf00 addr, where ACPI asl code expects it * set bit corresponding to APIC ID in processor status bitmask on receiving CPU hot-plug notification * trigger CPU hot-plug SCI, to notify guest about CPU hot-plug event Signed-off-by: Igor Ma

[Qemu-devel] [PATCH v6 05/11] rdma: export qemu_fflush()

2013-04-24 Thread mrhines
From: "Michael R. Hines" RDMA uses this to flush the control channel before sending its own message to handle page registrations. Signed-off-by: Michael R. Hines --- include/migration/qemu-file.h |1 + savevm.c |2 +- 2 files changed, 2 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v6 09/11] rdma: introduce capability x-rdma-pin-all

2013-04-24 Thread mrhines
From: "Michael R. Hines" This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. For example, using an 8GB RAM virtual machine with all 8GB of memory in active use and the VM itself is completely idle using a 40 gbps infiniband link: 1.

Re: [Qemu-devel] Adding Disk-Level Introspection to QEMU

2013-04-24 Thread Wolfgang Richter
On Wed, Apr 24, 2013 at 1:37 AM, Stefan Hajnoczi wrote: > I think what you really want is a "tap" block driver which mirrors > writes to a target device (typically a NBD volume). You can model this > on blkverify or check out Benoit Canet's quorum patches. > > Stefan > An interesting thought, w

Re: [Qemu-devel] [PATCH 20/21] target-i386: implement machine->hot_add_cpu hook

2013-04-24 Thread Eduardo Habkost
On Wed, Apr 24, 2013 at 07:31:44PM +0200, Andreas Färber wrote: > > +static void do_cpu_hot_add(const int64_t id, Error **errp) > > +{ > > +int64_t apic_id = x86_cpu_apic_id_from_index(id); > > + > > +if (cpu_exists(apic_id)) { > > +error_setg(errp, "Unable to add CPU: %" PRIi64 > >

[Qemu-devel] [PATCH v6 07/11] rdma: introduce qemu_ram_foreach_block()

2013-04-24 Thread mrhines
From: "Michael R. Hines" This is used during RDMA initialization in order to transmit a description of all the RAM blocks to the peer for later dynamic chunk registration purposes. Signed-off-by: Michael R. Hines --- exec.c|9 + include/exec/cpu-common.h |5

[Qemu-devel] [PATCH v6 01/11] rdma: add documentation

2013-04-24 Thread mrhines
From: "Michael R. Hines" docs/rdma.txt contains full documentation, wiki links, github url and contact information. Signed-off-by: Michael R. Hines --- docs/rdma.txt | 404 + 1 file changed, 404 insertions(+) create mode 100644 docs/rdm

[Qemu-devel] [PATCH v6 11/11] rdma: send pc.ram

2013-04-24 Thread mrhines
From: "Michael R. Hines" This takes advantages of the previous patches: 1. use the new QEMUFileOps hook 'save_page' 2. call out to the right accessor methods to invoke the iteration hooks defined in QEMUFileOps Signed-off-by: Michael R. Hines --- arch_init.c | 35 +++

[Qemu-devel] [PATCH v6 06/11] rdma: introduce ram_handle_compressed()

2013-04-24 Thread mrhines
From: "Michael R. Hines" This gives RDMA shared access to madvise() on the destination side when an entire chunk is found to be zero. Signed-off-by: Michael R. Hines --- arch_init.c | 24 include/migration/migration.h |2 ++ 2 files changed, 18

[Qemu-devel] [PATCH v6 00/11] rdma: migration support

2013-04-24 Thread mrhines
From: "Michael R. Hines" Please pull. Changes since v5: - Removed max_size hook. - Waiting for Signed-Off bys Wiki: http://wiki.qemu.org/Features/RDMALiveMigration Github: g...@github.com:hinesmr/qemu.git Here is a brief summary of total migration time and downtime using RDMA: Using a 40

[Qemu-devel] [PATCH v6 03/11] rdma: export throughput w/ MigrationStats QMP

2013-04-24 Thread mrhines
From: "Michael R. Hines" This exposes throughput (in megabits/sec) through QMP. Signed-off-by: Michael R. Hines --- hmp.c |2 ++ include/migration/migration.h |1 + migration.c | 10 ++ qapi-schema.json |5 - 4 fi

[Qemu-devel] [PATCH v6 08/11] rdma: new QEMUFileOps hooks

2013-04-24 Thread mrhines
From: "Michael R. Hines" These are the prototypes and implementation of new hooks that RDMA takes advantage of to perform dynamic page registration. An optional hook is also introduced for a custom function to be able to override the default save_page function. Also included are the prototypes

[Qemu-devel] [PATCH v6 02/11] rdma: export yield_until_fd_readable()

2013-04-24 Thread mrhines
From: "Michael R. Hines" The RDMA event channel can be made non-blocking just like a TCP socket. Exporting this function allows us to yield so that the QEMU monitor remains available. Signed-off-by: Michael R. Hines --- include/block/coroutine.h |6 + qemu-coroutine-io.c | 23 + sa

[Qemu-devel] [PATCH v6 04/11] rdma: introduce qemu_file_mode_is_not_valid()

2013-04-24 Thread mrhines
From: "Michael R. Hines" QEMUFileRDMA also has read and write modes. This function is now shared to reduce code duplication. Signed-off-by: Michael R. Hines --- include/migration/qemu-file.h |1 + savevm.c | 20 +--- 2 files changed, 14 insertions(+),

Re: [Qemu-devel] [PATCH] ich9: kill cmos_s3

2013-04-24 Thread Andreas Färber
Am 24.04.2013 13:30, schrieb Paolo Bonzini: > Il 24/04/2013 12:37, Hu Tao ha scritto: >> Signed-off-by: Hu Tao > > I had exactly the same patch in my 1.6 queue. :) > > Reviewed-by: Paolo Bonzini The commit message fails to explain *why* we can drop updating whatever RTC memory value there thou

Re: [Qemu-devel] [PATCH v4 0/4] virtio-9p refactoring.

2013-04-24 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [RESEND PATCH 0/2] input: kbd handler list

2013-04-24 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3 0/4] virtio-9p refactoring.

2013-04-24 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH build-breakage] build: include config-{, all-}devices.mak after defining CONFIG_SOFTMMU and CONFIG_USER_ONLY

2013-04-24 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v4 0/8] virtio-rng refactoring.

2013-04-24 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] ui/gtk: Add Turkish translations

2013-04-24 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3] Move TPM passthrough specific command line options to backend structure

2013-04-24 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] ui/gtk: Use gtk_widget_get_window() to support both gtk2 and gtk3

2013-04-24 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] ich9: kill cmos_s3

2013-04-24 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] ui/gtk: Use gtk_widget_get_window() to support both gtk2 and gtk3

2013-04-24 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] block: Fix build with tracing enabled

2013-04-24 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

  1   2   3   >