Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze

2013-05-06 Thread Gerd Hoffmann
Hi, > And please remember to update the changelog. It's already a pretty > featureful release, but I have no idea about what's happening in VNC > land (LED extension and WebSockets?) Yea, those two, I'm not aware of anything else. > and what are the visible effects of > Gerd's console refacto

Re: [Qemu-devel] [PATCH] virtio-net: properly check the vhost status during status set

2013-05-06 Thread Jason Wang
On 04/28/2013 04:25 PM, Michael S. Tsirkin wrote: > On Sun, Apr 28, 2013 at 03:51:32PM +0800, Jason Wang wrote: >> On 04/28/2013 03:32 AM, Michael S. Tsirkin wrote: >>> On Sat, Apr 27, 2013 at 01:11:16PM +0800, Jason Wang wrote: On 04/26/2013 08:26 PM, Michael S. Tsirkin wrote: > On Fri, A

[Qemu-devel] [PATCH V2] virtio: properly validate address before accessing config

2013-05-06 Thread Jason Wang
There are several several issues in the current checking: - The check was based on the minus of unsigned values which can overflow - It was done after .{set|get}_config() which can lead crash when config_len is zero since vdev->config is NULL Fix this by: - Validate the address in virtio_pci_c

[Qemu-devel] [PATCH v1 13/14] slirp: handle race condition

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan Slirp and its peer can run on different context at the same time. Using lock to protect. Lock rule: no extra lock can be hold after slirp->lock. This will protect us from deadlock when calling to peer. As to coding style, they accord to the nearby code's style. Signed-off-by:

[Qemu-devel] [PATCH v1 14/14] slirp: use lock to protect the slirp_instances

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan slirps will run on dedicated thread, and dynamically join or disjoin this list, so need lock to protect the global list. Signed-off-by: Liu Ping Fan --- include/qemu/module.h |2 ++ slirp/slirp.c | 20 2 files changed, 22 insertions(+), 0 d

[Qemu-devel] [PATCH v1 11/14] slirp: make timeout local

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan Each slirp has its own time to caculate timeout. Signed-off-by: Liu Ping Fan --- slirp/slirp.c | 22 ++ slirp/slirp.h |3 +++ 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index bd9b7cb..08c6b26 10064

[Qemu-devel] [PATCH v1 10/14] net: make netclient re-entrant with refcnt

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan With refcnt, NetClientState's user can run agaist deleter. Signed-off-by: Liu Ping Fan --- hw/qdev-properties-system.c | 14 + include/net/net.h |3 ++ net/hub.c |3 ++ net/net.c | 46 +

[Qemu-devel] [PATCH v1 07/14] net: hub use lock to protect ports list

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan Hub ports will run on multi-threads, so use lock to protect them. Signed-off-by: Liu Ping Fan --- net/hub.c | 25 - 1 files changed, 24 insertions(+), 1 deletions(-) diff --git a/net/hub.c b/net/hub.c index df32074..812a6dc 100644 --- a/net/hub.c +

[Qemu-devel] [PATCH v1 12/14] slirp: make slirp event dispatch based on slirp instance, not global

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan Split slirp_pollfds_fill/_poll actions into each slirp, so that SlirpState can run on dedicated context. Each slirp socket will corresponds to a GPollFD, and its SlirpState stands for a GSource(EventsGSource). Finally different SlirpState can run on different context. The logi

[Qemu-devel] [PATCH v1 05/14] net: port tap onto GSource

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- net/tap.c | 64 +++- 1 files changed, 54 insertions(+), 10 deletions(-) diff --git a/net/tap.c b/net/tap.c index daab350..5f4d59f 100644 --- a/net/tap.c +++ b/net/tap.c @@ -41,6 +41,7 @

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/7] pci: add MPC105 PCI host bridge emulation

2013-05-06 Thread Hervé Poussineau
Andreas Färber a écrit : Am 06.05.2013 22:57, schrieb Hervé Poussineau: Alexander Graf a écrit : On 05/03/2013 07:57 AM, Hervé Poussineau wrote: Alexander Graf a écrit : Am 02.05.2013 um 22:08 schrieb Hervé Poussineau : Non-contiguous I/O is not implemented. There is also somewhere a bug i

[Qemu-devel] [PATCH v1 09/14] net: introduce lock to protect NetClientState's peer's access

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan Introduce nc->peer_lock to shield off the race of nc->peer's reader and deleter. With it, after deleter finish, no new qemu_send_packet_xx() will append packet to peer->send_queue, therefore no new reference from packet->sender to nc will exist in nc->peer->send_queue. Signed-

[Qemu-devel] [PATCH v1 04/14] net: port socket to GSource

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan Port NetSocketState onto NetClientSource. The only thing specail is that owning to the socket's state machine changes, we need to change the handler. We implement that by destroy the old NetClientSource and attach a new one with NetSocketState. Signed-off-by: Liu Ping Fan ---

[Qemu-devel] [PATCH v1 06/14] net: port tap-win32 onto GSource

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- net/tap-win32.c | 31 +-- 1 files changed, 29 insertions(+), 2 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 91e9e84..7a84195 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -635,13 +635,

[Qemu-devel] [PATCH v1 08/14] net: introduce lock to protect NetQueue

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan NetQueue will be accessed by nc and its peers at the same time, need lock to protect it. Signed-off-by: Liu Ping Fan --- net/queue.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/net/queue.c b/net/queue.c index 859d02a..2856c1d 100644 --

[Qemu-devel] [PATCH v1 02/14] net: introduce bind_ctx to NetClientInfo

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan Introduce bind_ctx interface for NetClientState. It will help to bind NetClientState with a GSource. Currently, these GSource attached with default context, but in future, after resolving all the race condition in network layer, NetClientStates can run on different threads Sig

[Qemu-devel] [PATCH v1 03/14] net: port vde onto GSource

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan Signed-off-by: Liu Ping Fan --- net/vde.c | 31 +-- 1 files changed, 29 insertions(+), 2 deletions(-) diff --git a/net/vde.c b/net/vde.c index 4dea32d..fe763dd 100644 --- a/net/vde.c +++ b/net/vde.c @@ -30,10 +30,12 @@ #include "qemu-common.h"

[Qemu-devel] [PATCH v1 01/14] util: introduce gsource event abstraction

2013-05-06 Thread Liu Ping Fan
From: Liu Ping Fan Introduce two structs EventGSource, EventsGSource EventGSource is used to abstract the event with single backend file. EventsGSource is used to abstract the event with dynamically changed backend file, ex, slirp. Signed-off-by: Liu Ping Fan --- util/Makefile.objs |1 +

[Qemu-devel] [PATCH v1 00/14] port network layer onto glib

2013-05-06 Thread Liu Ping Fan
summary: patch1: GSource event abstraction patch2~6: port network backend to glib patch7~10: make network core re-entrant patch11~14: port the slirp backend onto glib The slirp->lock's deadlock problem has been eliminated and works fine. And other components seems more stable, so I change

Re: [Qemu-devel] [PATCH 2/3] virtio-ccw: check config length before accessing it

2013-05-06 Thread Jason Wang
On 04/28/2013 04:40 PM, Jason Wang wrote: > On 04/28/2013 04:32 PM, Michael S. Tsirkin wrote: >> On Fri, Apr 26, 2013 at 04:34:03PM +0800, Jason Wang wrote: >>> virtio-rng-ccw has zero config length, so we need validate the config length >>> before trying to access it. Otherwise we may crash since

Re: [Qemu-devel] [PATCH V13 4/6] create some QemuOpts functons

2013-05-06 Thread Dong Xu Wang
On 2013/5/6 20:20, Markus Armbruster wrote: Dong Xu Wang writes: These functions will be used in next commit. qemu_opt_get_(*)_del functions are used to make sure we have the same behaviors as before: after get an option value, options++. I don't understand the last sentence. Signed-off-by

[Qemu-devel] [RFC PATCH v4] Throttle-down guest when live migration does not converge.

2013-05-06 Thread Chegu Vinod
Busy enterprise workloads hosted on large sized VM's tend to dirty memory faster than the transfer rate achieved via live guest migration. Despite some good recent improvements (& using dedicated 10Gig NICs between hosts) the live migration does NOT converge. If a user chooses to force convergence

Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze

2013-05-06 Thread Paolo Bonzini
Il 06/05/2013 23:07, Jordan Justen ha scritto: > On Mon, May 6, 2013 at 1:41 PM, Paolo Bonzini wrote: >> Il 06/05/2013 22:31, Anthony Liguori ha scritto: >>> Jordan Justen writes: >>> On Mon, May 6, 2013 at 7:42 AM, Anthony Liguori wrote: > I believe I have processed all of the ou

Re: [Qemu-devel] [Qemu-ppc] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-06 Thread David Gibson
On Mon, May 06, 2013 at 09:37:11AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 03:38, David Gibson ha scritto: > > This patch adds the necessary support for saving the state of the PAPR VIO > > virtual SCSI device. This turns out to be trivial, because the generiC > > SCSI code already quiesces th

Re: [Qemu-devel] [PATCH] [KVM] Needless to update msi route when only msi-x entry "control" section changed

2013-05-06 Thread Zhanghaoyu (A)
>> >> With regard to old version linux guest(e.g., rhel-5.5), in ISR >> >> processing, mask and unmask msi-x vector every time, which result in >> >> VMEXIT, then QEMU will invoke kvm_irqchip_update_msi_route() to ask KVM >> >> hypervisor to update the VM irq routing table. In KVM hypervisor, >

Re: [Qemu-devel] [PATCH v2 1/4] Add i.MX FEC Ethernet driver

2013-05-06 Thread Peter Crosthwaite
Hi Peter, Michael, On Mon, May 6, 2013 at 10:01 PM, Peter Maydell wrote: > On 6 May 2013 10:24, Michael S. Tsirkin wrote: >> On Mon, May 06, 2013 at 10:08:42AM +0100, Peter Maydell wrote: >>> On 6 May 2013 09:51, Michael S. Tsirkin wrote: >>> > On Sun, May 05, 2013 at 11:00:24PM +0100, Peter Ma

Re: [Qemu-devel] Incorrect handling of PPC64 rldcl insn

2013-05-06 Thread Aurelien Jarno
On Tue, May 07, 2013 at 12:14:47AM +0200, Alexander Graf wrote: > > On 06.05.2013, at 20:13, Torbjorn Granlund wrote: > > > Alexander Graf writes: > > > > Thanks a lot for the bug report and test case! Please CC qemu-ppc > > whenever you find issues or have patches for PPC. That makes filteri

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/7] pci: add MPC105 PCI host bridge emulation

2013-05-06 Thread Andreas Färber
Am 06.05.2013 22:57, schrieb Hervé Poussineau: > Alexander Graf a écrit : >> On 05/03/2013 07:57 AM, Hervé Poussineau wrote: >>> Alexander Graf a écrit : Am 02.05.2013 um 22:08 schrieb Hervé Poussineau : > Non-contiguous I/O is not implemented. > > There is also somewhere

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/7] pci: add MPC105 PCI host bridge emulation

2013-05-06 Thread Alexander Graf
On 06.05.2013, at 22:57, Hervé Poussineau wrote: > Alexander Graf a écrit : >> On 05/03/2013 07:57 AM, Hervé Poussineau wrote: >>> Alexander Graf a écrit : Am 02.05.2013 um 22:08 schrieb Hervé Poussineau : > Non-contiguous I/O is not implemented. > > There is also so

Re: [Qemu-devel] Incorrect handling of PPC64 rldcl insn

2013-05-06 Thread Alexander Graf
On 06.05.2013, at 20:13, Torbjorn Granlund wrote: > Alexander Graf writes: > > Thanks a lot for the bug report and test case! Please CC qemu-ppc > whenever you find issues or have patches for PPC. That makes filtering > for important mails a lot easier. > > Would that make my complaints be

Re: [Qemu-devel] Query regarding IO paths in QEMU

2013-05-06 Thread aayush gupta
Thanks for the reply. I am trying to use the tracing with qemu-io as suggested in docs/tracing.txt. I did the following steps: 1. Configure and make with simple backend 2. Create a set of events I am interested in (/tmp/events) 3. Now I am running the qemu-iotests by adding T= /tmp/events to test

Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze

2013-05-06 Thread Jordan Justen
On Mon, May 6, 2013 at 1:31 PM, Anthony Liguori wrote: > Jordan Justen writes: > >> On Mon, May 6, 2013 at 7:42 AM, Anthony Liguori wrote: >>> I believe I have processed all of the outstanding pull requests and >>> patches tagged for 1.5. If there are any other patches or pull requests >>> you

Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze

2013-05-06 Thread Jordan Justen
On Mon, May 6, 2013 at 1:41 PM, Paolo Bonzini wrote: > Il 06/05/2013 22:31, Anthony Liguori ha scritto: >> Jordan Justen writes: >> >>> On Mon, May 6, 2013 at 7:42 AM, Anthony Liguori wrote: I believe I have processed all of the outstanding pull requests and patches tagged for 1.5. If

[Qemu-devel] [PULL 04/11] target-i386: Introduce X86CPU::filtered_features field

2013-05-06 Thread Andreas Färber
From: Eduardo Habkost This field will contain the feature bits that were filtered out because of missing host support. Signed-off-by: Eduardo Habkost Reviewed-by: Eric Blake Signed-off-by: Andreas Färber --- target-i386/cpu-qom.h | 3 +++ target-i386/cpu.c | 9 ++--- 2 files changed,

Re: [Qemu-devel] [RFC][PATCH 10/15] memory: Rework sub-page handling

2013-05-06 Thread Peter Maydell
On 6 May 2013 15:26, Jan Kiszka wrote: > Simplify the sub-page handling by implementing it directly in the > dispatcher instead of using a redirection memory region. We extend the > phys_sections entries to optionally hold a pointer to the sub-section > table that used to reside in the subpage_t s

[Qemu-devel] [PULL 09/11] target-i386: Change CPUID model of 486 to 8

2013-05-06 Thread Andreas Färber
This changes the model number of 486 to 8 (DX4) which matches the feature set presented, and actually has the CPUID instruction. This adds a compatibility property, to keep model=0 on pc-*-1.4 and older. Signed-off-by: H. Peter Anvin [AF: Add compat_props entry] Tested-by: Eduardo Habkost Revie

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/7] pci: add MPC105 PCI host bridge emulation

2013-05-06 Thread Hervé Poussineau
Alexander Graf a écrit : On 05/03/2013 07:57 AM, Hervé Poussineau wrote: Alexander Graf a écrit : Am 02.05.2013 um 22:08 schrieb Hervé Poussineau : Non-contiguous I/O is not implemented. There is also somewhere a bug in the memory controller, which means that some real firmwares may not det

Re: [Qemu-devel] [PATCH for-1.5] virtio-pci: bugfix

2013-05-06 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > mask notifiers are never called without msix, > so devices with backend masking like vhost don't work. > Call mask notifiers explicitly at > startup/cleanup to make it work. > > Signed-off-by: Michael S. Tsirkin > Tested-by: Alexander Graf /home/aliguori/git/qemu

Re: [Qemu-devel] [PATCH v2] po/hu.po: Hungarian translation for the GTK+ interface

2013-05-06 Thread Andreas Färber
Am 06.05.2013 19:14, schrieb akoskov...@gmx.com: > From: Ákos Kovács > > Cc: Laszlo Ersek > Signed-off-by: Ákos Kovács > --- > Changes in v2: > * Fixed input release/grab translations > * Fixed inconsistency with the "leállítva"/"megállítva" words > > po/hu.po | 63 >

[Qemu-devel] [PULL 11/11] target-i386: n270 can MOVBE

2013-05-06 Thread Andreas Färber
From: Borislav Petkov The Atom core (cpu name "n270" in QEMU speak) supports MOVBE. This is needed when booting 3.8 and later linux kernels built with the MATOM target because we require MOVBE in order to boot properly now. Signed-off-by: Borislav Petkov [ehabkost: added compat code to disable

[Qemu-devel] [PULL 10/11] target-i386: Introduce generic CPUID feature compat function

2013-05-06 Thread Andreas Färber
From: Eduardo Habkost Introduce x86_cpu_compat_set_features(), that can be used to set/unset feature bits on specific CPU models for machine-type compatibility. Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- target-i386/cpu.c | 26 ++ target-i386/cpu.

[Qemu-devel] [PULL 06/11] qdev: Let qdev_prop_parse() pass through Error

2013-05-06 Thread Andreas Färber
Move error reporting to callers. Reviewed-by: Eduardo Habkost Signed-off-by: Andreas Färber --- hw/core/qdev-properties.c| 25 +++-- hw/core/qdev.c | 7 ++- include/hw/qdev-properties.h | 5 +++-- qdev-monitor.c | 6 +- 4 files chan

[Qemu-devel] [PULL 03/11] target-i386: Add "feature-words" property to X86CPU

2013-05-06 Thread Andreas Färber
From: Eduardo Habkost This property will be useful for libvirt, as libvirt already has logic based on low-level feature bits (not feature names), so it will be really easy to convert the current libvirt logic to something using the "feature-words" property. The property will have two main use ca

[Qemu-devel] [PULL 05/11] target-i386: Add "filtered-features" property to X86CPU

2013-05-06 Thread Andreas Färber
From: Eduardo Habkost This property will contain all the features that were removed from the CPU because they are not supported by the host. This way, libvirt or other management tools can emulate the check/enforce behavior by checking if filtered-properties is all zeroes, before starting the gu

[Qemu-devel] [PULL 08/11] target-i386: Emulate X86CPU subclasses for global properties

2013-05-06 Thread Andreas Färber
After initializing the object from its x86_def_t and before setting any additional -cpu arguments, set any global properties for the designated subclass -{i386,x86_64}-cpu. Reviewed-by: Eduardo Habkost Signed-off-by: Andreas Färber --- target-i386/cpu.c | 9 + 1 file changed, 9 insertio

Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze

2013-05-06 Thread Andreas Färber
Hi, Am 06.05.2013 16:42, schrieb Anthony Liguori: > > I believe I have processed all of the outstanding pull requests and > patches tagged for 1.5. If there are any other patches or pull requests > you would like to be considered, please respond to this note with a > pointer to the patch or make

[Qemu-devel] [PULL 07/11] qdev: Introduce qdev_prop_set_globals_for_type()

2013-05-06 Thread Andreas Färber
Reuse it in qdev_prop_set_globals(). Reviewed-by: Eduardo Habkost [AF: Renamed from qdev_prop_set_custom_globals()] Signed-off-by: Andreas Färber --- hw/core/qdev-properties.c| 36 +--- include/hw/qdev-properties.h | 2 ++ 2 files changed, 27 insertions(+),

[Qemu-devel] [PULL 02/11] target-i386: Use FeatureWord loop on filter_features_for_kvm()

2013-05-06 Thread Andreas Färber
From: Eduardo Habkost Instead of open-coding the filtering code for each feature word, change the existing code to use the feature_word_info array, that has exactly the same CPUID eax/ecx/register values for each feature word. Signed-off-by: Eduardo Habkost Reviewed-by: Eric Blake Signed-off-b

[Qemu-devel] [PULL for-1.5 00/11] QOM CPUState patch queue 2013-05-06

2013-05-06 Thread Andreas Färber
Hello, This is my current QOM CPU patch queue. Please pull. It includes: * x86 CPU feature-words and filtered-features properties for libvirt, * x86 CPU fixes and backwards compatibility support. Regards, Andreas Cc: Anthony Liguori Cc: Eduardo Habkost Cc: Igor Mammedov The following chan

[Qemu-devel] [PULL 01/11] target-i386: Add ECX information to FeatureWordInfo

2013-05-06 Thread Andreas Färber
From: Eduardo Habkost FEAT_7_0_EBX uses ECX as input, so we have to take that into account when reporting feature word values. Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- target-i386/cpu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/targ

Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze

2013-05-06 Thread Paolo Bonzini
Il 06/05/2013 22:31, Anthony Liguori ha scritto: > Jordan Justen writes: > >> On Mon, May 6, 2013 at 7:42 AM, Anthony Liguori wrote: >>> I believe I have processed all of the outstanding pull requests and >>> patches tagged for 1.5. If there are any other patches or pull requests >>> you would

[Qemu-devel] Compilation error with --enable-sparse

2013-05-06 Thread Eduardo Otubo
Hello all again, Same environment as the previous email (Ubuntu Server 13.04 on a x86_64 machine) root@vinagrete ~ # uname -a Linux vinagrete 3.8.0-19-generic #29-Ubuntu SMP Wed Apr 17 18:16:28 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux Compilation problem (log too big for email) http://pasteb

Re: [Qemu-devel] [RFC 5/7] target-i386: n270 can MOVBE

2013-05-06 Thread Andreas Färber
Am 25.04.2013 20:43, schrieb Eduardo Habkost: > From: Borislav Petkov > > The Atom core (cpu name "n270" in QEMU speak) supports MOVBE. This is > needed when booting 3.8 and later linux kernels built with the MATOM > target because we require MOVBE in order to boot properly now. > > Cc: "H. Pete

Re: [Qemu-devel] [RFC 1/7] target-i386: Introduce generic CPUID feature compat function

2013-05-06 Thread Andreas Färber
Am 25.04.2013 20:43, schrieb Eduardo Habkost: > Introduce x86_cpu_compat_set_features(), that can be used to set/unset > feature bits on specific CPU models for machine-type compatibility. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 26 ++ > target-i386

Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze

2013-05-06 Thread Anthony Liguori
Jordan Justen writes: > On Mon, May 6, 2013 at 7:42 AM, Anthony Liguori wrote: >> I believe I have processed all of the outstanding pull requests and >> patches tagged for 1.5. If there are any other patches or pull requests >> you would like to be considered, please respond to this note with a

Re: [Qemu-devel] Compilation error with --enable-cocoa

2013-05-06 Thread Peter Maydell
On 6 May 2013 21:23, Eduardo Otubo wrote: > I'm running an Ubuntu Server 13.04 on a x86_64 machine. Details follows: > > root@vinagrete ~ # uname -a > Linux vinagrete 3.8.0-19-generic #29-Ubuntu SMP Wed Apr 17 18:16:28 UTC 2013 > x86_64 x86_64 x86_64 GNU/Linux > > root@vinagrete ~/develop/qemu mas

Re: [Qemu-devel] [PATCH] PPC: Fix rldcl

2013-05-06 Thread Aurelien Jarno
On Mon, May 06, 2013 at 07:53:07PM +0200, Alexander Graf wrote: > The implementation for rldcl tried to always fetch its > parameters from the opcode, even though the opcode was > already passed in in decoded and different forms. > > Use the parameters instead, fixing rldcl. > > Reported-by: Torb

[Qemu-devel] Compilation error with --enable-cocoa

2013-05-06 Thread Eduardo Otubo
Hello all, I'm running an Ubuntu Server 13.04 on a x86_64 machine. Details follows: root@vinagrete ~ # uname -a Linux vinagrete 3.8.0-19-generic #29-Ubuntu SMP Wed Apr 17 18:16:28 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux root@vinagrete ~/develop/qemu master # ./configure --enable-debug-tcg --

Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze

2013-05-06 Thread Jordan Justen
On Mon, May 6, 2013 at 7:42 AM, Anthony Liguori wrote: > I believe I have processed all of the outstanding pull requests and > patches tagged for 1.5. If there are any other patches or pull requests > you would like to be considered, please respond to this note with a > pointer to the patch or ma

[Qemu-devel] [Bug 1175513] Re: Qemu 1.5-git gpu clock control doesn`t work after guest reboot

2013-05-06 Thread Alex Williamson
So the result is: HD6850 - works fully, host hang on guest poweroff GT210 - works fully, no host issues Is that correct? Are you attempting to rebind the HD6850 to host drivers after qemu is shutdown, or does the host hang happen prior to where that would be possible? What about killing qemu wi

Re: [Qemu-devel] [RFC][PATCH 10/15] memory: Rework sub-page handling

2013-05-06 Thread Paolo Bonzini
Il 06/05/2013 16:26, Jan Kiszka ha scritto: > Simplify the sub-page handling by implementing it directly in the > dispatcher instead of using a redirection memory region. We extend the > phys_sections entries to optionally hold a pointer to the sub-section > table that used to reside in the subpage

Re: [Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

2013-05-06 Thread Paolo Bonzini
Il 06/05/2013 20:35, mdroth ha scritto: > In the case of the former, I think a wrapper around GLib that we can > instantiate from the command-line line and query properties like TIDs > from is necessary for robust control over event loops and CPU resources. > We get this essentially for free with Q

Re: [Qemu-devel] [PATCH 4/4] mm: sys_remap_anon_pages

2013-05-06 Thread Andrea Arcangeli
On Mon, May 06, 2013 at 09:57:01PM +0200, Andrea Arcangeli wrote: > === > > static unsigned char *c, *tmp; > > void userfault_sighandler(int signum, siginfo_t *info, void *ctx) oops, the hash of the test program got cut... so I append it below which is nicer without leading whitespaces. === #de

[Qemu-devel] [PATCH 4/4] mm: sys_remap_anon_pages

2013-05-06 Thread Andrea Arcangeli
This new syscall will move anon pages across vmas, atomically and without touching the vmas. It only works on non shared anonymous pages because those can be relocated without generating non linear anon_vmas in the rmap code. It is the ideal mechanism to handle userspace page faults. Normally the

[Qemu-devel] [PATCH 0/4] madvise(MADV_USERFAULT) & sys_remap_anon_pages()

2013-05-06 Thread Andrea Arcangeli
Hello everyone, this is a patchset to implement two new kernel features: MADV_USERFAULT and remap_anon_pages. The combination of the two features are what I would propose to implement postcopy live migration, and in general demand paging of remote memory, hosted in different cloud nodes with KSM.

[Qemu-devel] [PATCH 1/4] mm: madvise MADV_USERFAULT

2013-05-06 Thread Andrea Arcangeli
MADV_USERFAULT is a new madvise flag that will set VM_USERFAULT in the vma flags. Whenever VM_USERFAULT is set in an anonymous vma, if userland touches a still unmapped virtual address, a sigbus signal is sent instead of allocating a new page. The sigbus signal handler will then resolve the page fa

[Qemu-devel] [PATCH 3/4] mm: swp_entry_swapcount

2013-05-06 Thread Andrea Arcangeli
Provide a new swapfile method for remap_anon_pages to verify the swap entry is mapped only in one vma before relocating the swap entry in a different virtual address. Otherwise if the swap entry is mapped in multiple vmas, when the page is swapped back in, it could get mapped in a non linear way in

[Qemu-devel] [PATCH 2/4] mm: rmap preparation for remap_anon_pages

2013-05-06 Thread Andrea Arcangeli
remap_anon_pages (unlike remap_file_pages) tries to be non intrusive in the rmap code. As far as the rmap code is concerned, rmap_anon_pages only alters the page->mapping and page->index. It does it while holding the page lock. However there are a few places that in presence of anon pages are allo

Re: [Qemu-devel] [PATCH v2] po/hu.po: Hungarian translation for the GTK+ interface

2013-05-06 Thread BALATON Zoltan
On Mon, 6 May 2013, akoskov...@gmx.com wrote: +#: ../ui/gtk.c:1312 +msgid "Grab On _Hover" +msgstr "Automatikus _elfogás" + +#: ../ui/gtk.c:1315 +msgid "_Grab Input" +msgstr "_Bemeneti eszközök megragadása" Sorry for nitpicking but for consistency your should use the same term for grab everywh

Re: [Qemu-devel] [PATCH 9/9] dataplane: use a QContext event loop in place of custom thread

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 09:54:03AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > virtio-blk dataplane currently creates/manages it's own thread to > > offload work to a separate event loop. > > > > This patch insteads allows us to specify a QContext-based event lo

[Qemu-devel] QEMU linking error with --enable-gprof

2013-05-06 Thread João Corrêa
Hi Everyone, I've been trying to compile QEMU with --enable-gprof on ubuntu, but I'm getting a linking error. /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/4.4.3/../../../../lib/gcrt1.o: relocation R_X86_64_32S against `__libc_csu_fini' can not be used when making a shared object; recompile with -fP

Re: [Qemu-devel] [PATCH 7/9] iohandler: associate with main event loop via a QSource

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 09:53:12AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > This introduces a GlibQContext wrapper around the main GMainContext > > event loop, and associates iohandlers with it via a QSource (which > > GlibQContext creates a GSource from so th

Re: [Qemu-devel] [PATCH 1/9] qom: add qom_init_completion

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 09:45:22AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > This is similar in concept to "realize", though semantics are a > > bit more open-ended: > > > > And object might in some cases need a number of properties to be > > specified before

Re: [Qemu-devel] [PATCH 2/9] qom: add object_property_add_unnamed_child

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 09:44:13AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > This interface allows us to add a child property without specifying a > > name. Instead, a unique name is created and passed back after adding > > the property. > > > > Signed-off-by:

Re: [Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 11:26:06AM +0800, liu ping fan wrote: > On Sat, May 4, 2013 at 12:03 AM, Michael Roth > wrote: > > These patches apply on top of qemu.git master, and can also be obtained > > from: > > git://github.com/mdroth/qemu.git qcontext > > > > OVERVIEW > > > > This series introduc

Re: [Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 07:25:24AM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 03/05/2013 18:03, Michael Roth ha scritto: > >> These patches apply on top of qemu.git master, and can also be obtained > >> from: > >> git://github.com/mdroth/qemu.git qcontext > >> > >> OVERVIEW

Re: [Qemu-devel] [PATCH v2] po/hu.po: Hungarian translation for the GTK+ interface

2013-05-06 Thread Laszlo Ersek
On 05/06/13 19:14, akoskov...@gmx.com wrote: > From: Ákos Kovács > > Cc: Laszlo Ersek > Signed-off-by: Ákos Kovács > --- > Changes in v2: > * Fixed input release/grab translations > * Fixed inconsistency with the "leállítva"/"megállítva" words > > po/hu.po | 63 >

Re: [Qemu-devel] [PULL 1.5 0/9] ppc patch queue 2013-05-06

2013-05-06 Thread Aurelien Jarno
On Mon, May 06, 2013 at 05:25:08PM +0200, Alexander Graf wrote: > Hi Blue / Aurelien, > > This is my current patch queue for ppc with last minute changes for 1.5. > > Please pull. > > > Alex > > > The following changes since commit 8e515b125d5f7849167dbee6cbe6ef61636607d4: > Peter Maydell (

Re: [Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compatibility properties

2013-05-06 Thread Andreas Färber
Am 01.05.2013 18:07, schrieb Andreas Färber: > Hello, > > It's easier adapting the infrastructure to our needs than working around it: > X86CPU already has QOM properties today. What's lacking is model subclasses, > and with the one X86CPU type its global properties are overwritten by models. > Bu

Re: [Qemu-devel] [PULL 1.5 0/6] s390 patch queue 2013-05-06

2013-05-06 Thread Aurelien Jarno
On Mon, May 06, 2013 at 05:30:18PM +0200, Alexander Graf wrote: > Hi Blue / Aurelien, > > This is my current patch queue for s390. Please pull. > > Alex > > > The following changes since commit 8e515b125d5f7849167dbee6cbe6ef61636607d4: > Peter Maydell (1): > configure: Check that "li

Re: [Qemu-devel] [RFC 0/9] QContext: QOM class to support multiple event loops

2013-05-06 Thread mdroth
On Mon, May 06, 2013 at 09:54:14AM +0200, Paolo Bonzini wrote: > Il 03/05/2013 18:03, Michael Roth ha scritto: > > These patches apply on top of qemu.git master, and can also be obtained > > from: > > git://github.com/mdroth/qemu.git qcontext > > > > OVERVIEW > > > > This series introduces a set

[Qemu-devel] [PATCH 9/9] spapr_llan: fix device reenabling

2013-05-06 Thread Alexander Graf
From: Alexey Kardashevskiy Normally, the "tap" device is polled by QEMU if a guest NIC can receive packets. If a guest NIC is stopped during transfer (rmmod or ifdown), it may still have packets in a queue which have to be send to the guest before QEMU enables polling of a "tap" interface via tap

Re: [Qemu-devel] Incorrect handling of PPC64 rldcl insn

2013-05-06 Thread Torbjorn Granlund
Alexander Graf writes: Thanks a lot for the bug report and test case! Please CC qemu-ppc whenever you find issues or have patches for PPC. That makes filtering for important mails a lot easier. Would that make my complaints be considered more or less important? :-) Does the patch bel

Re: [Qemu-devel] [PATCH v7 0/7] push mmio dispatch out of big lock

2013-05-06 Thread Paolo Bonzini
Il 06/05/2013 16:05, Jan Kiszka ha scritto: >> Also, memory_region_find cannot know if it's returning a valid result, >> and the callee cannot check it because the region may have disappeared >> already when it is returned. > > Again, we hold the address space lock while checking the conditions. I

[Qemu-devel] [PATCH 5/9] PPC: Add MMU type for 2.06 with AMR but no TB pages

2013-05-06 Thread Alexander Graf
When running -cpu on a POWER7 system with PR KVM, we mask out the 1TB MMU capability from the MMU type mask, but not the AMR bit. This leads to us having a new MMU type that we don't check for in our MMU management functions. Add the new type, so that we don't have to worry about breakage there.

[Qemu-devel] [RFC PATCH 1/8] memory: add ref/unref calls

2013-05-06 Thread Paolo Bonzini
Add ref/unref calls at the following places: - places where memory regions are stashed by a listener and used outside the BQL (including in Xen or KVM). - memory_region_find callsites Signed-off-by: Paolo Bonzini --- exec.c|6 +- hw/core/loader.c

Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze

2013-05-06 Thread Michael Tokarev
06.05.2013 18:42, Anthony Liguori wrote: > > Hi, > > I believe I have processed all of the outstanding pull requests and > patches tagged for 1.5. If there are any other patches or pull requests > you would like to be considered, please respond to this note with a > pointer to the patch or make

Re: [Qemu-devel] Last Call for 1.5 before Hard Freeze

2013-05-06 Thread Anthony Liguori
Paolo Bonzini writes: > Il 06/05/2013 16:42, Anthony Liguori ha scritto: >> >> Hi, >> >> I believe I have processed all of the outstanding pull requests and >> patches tagged for 1.5. If there are any other patches or pull requests >> you would like to be considered, please respond to this not

Re: [Qemu-devel] [RFC][PATCH 08/15] isa: implement isa_is_ioport_assigned via memory_region_find

2013-05-06 Thread Paolo Bonzini
Il 06/05/2013 16:55, Andreas Färber ha scritto: > Am 06.05.2013 16:26, schrieb Jan Kiszka: >> Move isa_is_ioport_assigned to the ISA core and implement it via a >> memory region lookup. As all IO ports are now directly or indirectly >> registered via the memory API, this becomes possible and will f

[Qemu-devel] [PATCH qom-cpu-next 3/3] target-i386: Add "filtered-features" property to X86CPU

2013-05-06 Thread Eduardo Habkost
This property will contain all the features that were removed from the CPU because they are not supported by the host. This way, libvirt or other management tools can emulate the check/enforce behavior by checking if filtered-properties is all zeroes, before starting the guest. Example output whe

[Qemu-devel] [PULL 1.5 0/6] s390 patch queue 2013-05-06

2013-05-06 Thread Alexander Graf
Hi Blue / Aurelien, This is my current patch queue for s390. Please pull. Alex The following changes since commit 8e515b125d5f7849167dbee6cbe6ef61636607d4: Peter Maydell (1): configure: Check that "libtool" is not the MacOSX one are available in the git repository at: git://githu

[Qemu-devel] [PATCH] memory: Rename readable flag to romd_mode

2013-05-06 Thread Jan Kiszka
"Readable" is a very unfortunate name for this flag because even a rom_device region will always be readable from the guest POV. What differs is the mapping, just like the comments had to explain already. Also, readable could currently be understood as being a generic region flag, but it only appli

[Qemu-devel] [PATCH] PPC: Fix rldcl

2013-05-06 Thread Alexander Graf
The implementation for rldcl tried to always fetch its parameters from the opcode, even though the opcode was already passed in in decoded and different forms. Use the parameters instead, fixing rldcl. Reported-by: Torbjorn Granlund Signed-off-by: Alexander Graf --- target-ppc/translate.c |

[Qemu-devel] [RFC][PATCH 12/15] vmware-vga: Accept unaligned I/O accesses

2013-05-06 Thread Jan Kiszka
Before switching to the memory core dispatcher, we need to make sure that this pv-device will continue to receive unaligned portio accesses. Signed-off-by: Jan Kiszka --- hw/display/vmware_vga.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/display/vmware_vga.c b

Re: [Qemu-devel] 1.4.1 won't build with --enable-debug-tcg (or --enable-debug)

2013-05-06 Thread Aurelien Jarno
Hi, On Sat, May 04, 2013 at 03:23:28PM +0100, Richard Sandiford wrote: > Juergen Lock writes: > > Hi! > > > > The failure is in the mips64-softmmu target: (at least) > > > > [...] > > CCmips64-softmmu/target-mips/translate.o > > ..qemu-1.4.1/target-mips/translate.c::2780:35 : error: > >

Re: [Qemu-devel] [PATCH qom-cpu for-1.5 2/4] qdev: Introduce qdev_prop_set_custom_globals()

2013-05-06 Thread Andreas Färber
Am 01.05.2013 18:07, schrieb Andreas Färber: > Reuse it in qdev_prop_set_globals(). > > Signed-off-by: Andreas Färber > --- > hw/core/qdev-properties.c| 35 --- > include/hw/qdev-properties.h | 2 ++ > 2 files changed, 26 insertions(+), 11 deletions(-) Igor

Re: [Qemu-devel] [PATCH] spapr_llan: fix device reenabling

2013-05-06 Thread Alexander Graf
On 05/03/2013 08:22 AM, Alexey Kardashevskiy wrote: Normally, the "tap" device is polled by QEMU if a guest NIC can receive packets. If a guest NIC is stopped during transfer (rmmod or ifdown), it may still have packets in a queue which have to be send to the guest before QEMU enables polling of

[Qemu-devel] [PATCH 1/9] pseries: Factor out check for out-of-bounds LIOBN

2013-05-06 Thread Alexander Graf
From: David Gibson PAPR defines LIOBNs (Logical IO Bus Numbers) to be 32-bit, and we check for values that aren't in the code for H_PUT_TCE. This patch factors the check into spapr_tce_find_by_liobn(), which already checks if a 32-bit LIOBN actually exists. This will become more important as fu

Re: [Qemu-devel] Incorrect handling of PPC64 rldcl insn

2013-05-06 Thread Alexander Graf
On 05/06/2013 07:00 PM, Torbjorn Granlund wrote: I could finally make Debian GNU/Linux install and run under qemu-system-ppc64. I used Debian 7.0.0 and qemu from the main git repo, updated a few days ago. While Debian runs well and not too slowly, GMP fails badly under all ABIs, and in many dif

Re: [Qemu-devel] [PATCH qom-cpu-next 0/3] X86CPU: "feature-words"/"filtered-features" properties (v12)

2013-05-06 Thread Andreas Färber
Am 06.05.2013 18:20, schrieb Eduardo Habkost: > Resubmitting after a rebase and a few trivial changes. > > Changes v11 -> v12: > * Remove unnecessary entries from .gitignore > * Fix indentation of x86_cpu_get_feature_words() declaration > * Rebase on top of qom-cpu-next >(commit bd87d2a - t

  1   2   3   >