[Qemu-devel] [PATCH] virtio-net: fix wrong size of vlan filter table

2013-06-04 Thread Amos Kong
The MAX_VLAN is 4096, currently the vlan filter table has 512 (4096 >> 3) entries, it's wrong. One entry in vlan filter table can indicate 32(1 << 5) vlans, so the table should have 128 (4096 >> 5) entries. Signed-off-by: Amos Kong --- btw, it would be simple to use an uint32 number to indicate

Re: [Qemu-devel] [snabb-devel:327] Re: snabbswitch integration with QEMU for userspace ethernet I/O

2013-06-04 Thread Luke Gorrie
On 4 June 2013 14:56, Michael S. Tsirkin wrote: > That would mean making snabb switch part of QEMU. > Just curious - not suggesting that this is practical - but what would that mean? Is the important thing to keep all device implementations in the same source tree so that QEMU developers can ta

Re: [Qemu-devel] broken incoming migration

2013-06-04 Thread Peter Lieven
Am 05.06.2013 um 05:37 schrieb Alexey Kardashevskiy : > On 06/05/2013 05:15 AM, Peter Lieven wrote: >> >> Am 04.06.2013 um 17:17 schrieb Paolo Bonzini : >> >>> Il 04/06/2013 16:48, Peter Lieven ha scritto: Still using 3.2, but strange enough the above example is also not increasing RS

Re: [Qemu-devel] [PATCH 11/39] msix: split msix_free from msix_uninit

2013-06-04 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 12:40:00AM +0200, Paolo Bonzini wrote: > Il 05/06/2013 00:03, Michael S. Tsirkin ha scritto: > >> > +if (dev->msix_table || dev->msix_pba || dev->msix_entry_used) { > >> > +msix_free(dev); > >> > +} > >> > + > >> > dev->msix_table = g_malloc0(table_size)

[Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-04 Thread Wanlong Gao
Add monitor command mem-nodes to show the huge mapped memory nodes locations. (qemu) info mem-nodes /proc/14132/fd/13: 2ac0-2aaaeac0: node0 /proc/14132/fd/13: 2aaaeac0-2aab2ac0: node1 /proc/14132/fd/14: 2aab2ac0-2aab2b00: node0 /proc/14132/fd/14:

[Qemu-devel] [PATCH 1/2] Add Linux libnuma detection

2013-06-04 Thread Wanlong Gao
Add detection of libnuma (mostly contained in the numactl package) to the configure script. Currently this is Linux only, but can be extended later should the need for other interfaces come up. Can be enabled or disabled on the command line, default is use if available. Original-signed-off-by: And

Re: [Qemu-devel] broken incoming migration

2013-06-04 Thread Alexey Kardashevskiy
On 06/05/2013 05:15 AM, Peter Lieven wrote: > > Am 04.06.2013 um 17:17 schrieb Paolo Bonzini : > >> Il 04/06/2013 16:48, Peter Lieven ha scritto: >>> Still using 3.2, but strange enough the above example is also not >>> increasing RSS size for me. >>> >>> Can you try the following: >>> qemu git m

Re: [Qemu-devel] [PATCH 04/13] pseries: savevm support for XICS interrupt controller

2013-06-04 Thread Alexey Kardashevskiy
On 06/04/2013 10:20 PM, Alexey Kardashevskiy wrote: > From: David Gibson > > From: David Gibson > > This patch adds the necessary VMStateDescription information to support > savevm/loadvm for the XICS interrupt controller used on the pseries > machine. > > [aik: added ics_resend() on post_load

Re: [Qemu-devel] VM can not boot after commit 235e898

2013-06-04 Thread Dunrong Huang
On Wed, Jun 5, 2013 at 1:03 AM, Jordan Justen wrote: > On Tue, Jun 4, 2013 at 1:26 AM, Dunrong Huang > wrote: > > On Tue, Jun 4, 2013 at 3:51 PM, Gleb Natapov wrote: > >> On Tue, Jun 04, 2013 at 03:47:47PM +0800, Dunrong Huang wrote: > >> > On Tue, Jun 4, 2013 at 2:47 PM, Paolo Bonzini > >> >

Re: [Qemu-devel] [PATCH] target-ppc kvm: save cr register

2013-06-04 Thread Alexey Kardashevskiy
On 06/04/2013 10:11 PM, David Gibson wrote: > On Thu, May 30, 2013 at 07:26:10PM +1000, Alexey Kardashevskiy wrote: >> This adds a missing code to save CR (condition register) via >> kvm_arch_put_registers(). kvm_arch_get_registers() already has it. >> >> Signed-off-by: Alexey Kardashevskiy > > H

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-04 Thread Luiz Capitulino
[CC'ing Amos this time] On Wed, 05 Jun 2013 09:29:19 +0800 Qiao Nuohan wrote: > > I haven't reviewed it yet, but we need introspection support before merging > > this. > > Hello Luiz, > > Is it possible to get this reviewed, or I am supposed to wait until > introspection support being settl

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-04 Thread Luiz Capitulino
On Wed, 05 Jun 2013 09:29:19 +0800 Qiao Nuohan wrote: > > I haven't reviewed it yet, but we need introspection support before merging > > this. > > Hello Luiz, > > Is it possible to get this reviewed, or I am supposed to wait until > introspection support being settled? I can review it until

Re: [Qemu-devel] [PATCH 2/2] tcg: Remove redundant tcg_target_init checks

2013-06-04 Thread li guang
Reviewed-by: liguang 在 2013-06-04二的 09:58 -0700,Richard Henderson写道: > We've got a compile-time check for the condition in exec/cpu-defs.h. > > Signed-off-by: Richard Henderson > --- > tcg/arm/tcg-target.c | 6 -- > tcg/i386/tcg-target.c | 6 -- > tcg/s390/tcg-target.c | 7 --- >

Re: [Qemu-devel] [PATCH 1/2] tcg: Use QEMU_BUILD_BUG_ON for CPU_TLB_ENTRY_BITS

2013-06-04 Thread li guang
Reviewed-by: liguang 在 2013-06-04二的 09:58 -0700,Richard Henderson写道: > Rather than a hand-coded version of the same thing. > > Signed-off-by: Richard Henderson > --- > include/exec/cpu-defs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/exec/cpu-defs.h b/in

Re: [Qemu-devel] [PATCH 00/13 v2] pseries: savevm / migration support

2013-06-04 Thread Alexey Kardashevskiy
On 06/04/2013 10:42 PM, Andreas Färber wrote: > Am 04.06.2013 14:20, schrieb Alexey Kardashevskiy: >> I still have to learn how to force git not to overwrite the original commit >> author :-/ >> Is there any way to tell the original creator in the commit message so it >> could live >> in a git fo

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-04 Thread li guang
Hi, Richard, 在 2013-05-24五的 14:20 -0700,Richard Henderson写道: > Allows unwinding past the code_gen_buffer. > > Signed-off-by: Richard Henderson > --- > tcg/arm/tcg-target.c | 91 > ++-- > 1 file changed, 82 insertions(+), 9 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-04 Thread Qiao Nuohan
> I haven't reviewed it yet, but we need introspection support before merging > this. Hello Luiz, Is it possible to get this reviewed, or I am supposed to wait until introspection support being settled? On 05/28/2013 10:50 AM, qiaonuo...@cn.fujitsu.com wrote: From: Qiao Nuohan Hi, all The la

Re: [Qemu-devel] [PATCH] target-ppc kvm: save cr register

2013-06-04 Thread David Gibson
On Thu, May 30, 2013 at 07:26:10PM +1000, Alexey Kardashevskiy wrote: > This adds a missing code to save CR (condition register) via > kvm_arch_put_registers(). kvm_arch_get_registers() already has it. > > Signed-off-by: Alexey Kardashevskiy Huh. I can't believe that's been broken for so long.

Re: [Qemu-devel] [PATCH 11/39] msix: split msix_free from msix_uninit

2013-06-04 Thread Paolo Bonzini
Il 05/06/2013 00:03, Michael S. Tsirkin ha scritto: >> > +if (dev->msix_table || dev->msix_pba || dev->msix_entry_used) { >> > +msix_free(dev); >> > +} >> > + >> > dev->msix_table = g_malloc0(table_size); >> > dev->msix_pba = g_malloc0(pba_size); >> > dev->msix_entry_

[Qemu-devel] [Bug 921208] Re: win7/x64 installer hangs on startup with 0x0000005d.

2013-06-04 Thread Serge Hallyn
** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** Changed in: qemu (Ubuntu) Status: New => Triaged ** Changed in: qemu (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of qemu- devel-ml, which is subscr

[Qemu-devel] [PATCH v6 4/4] i.MX: Add qtest support for I2C device emulation

2013-06-04 Thread Jean-Christophe DUBOIS
This is using a ds1338 RTC chip on the i2c bus. This RTC chip is not present on the real board. Signed-off-by: Jean-Christophe DUBOIS --- Changes since v1: * not present on v1 Changes since v2: * use a common header file for I2C regs definition Changes since v3: * rework GPL header

[Qemu-devel] [PATCH v6 2/4] i.MX: Add I2C contoller emulator

2013-06-04 Thread Jean-Christophe DUBOIS
The slave mode is not implemented. Signed-off-by: Jean-Christophe DUBOIS Reviewed-by: Peter Crosthwaite --- Changes since v1: * use QOM cast * run checkpatch on code * added restrictin on MemoryRegionOps * use DeviceClass::realise as init function Changes since v2: * use C

[Qemu-devel] [PATCH v6 1/4] i.MX: Add FEC Ethernet Emulator.

2013-06-04 Thread Jean-Christophe DUBOIS
This is based on the mcf_fec.c FEC implementation for ColdFire. * a generic phy was added (borrowed from lan9118). * The buffer management is also modified as buffers are slightly different between coldfire and i.MX. Signed-off-by: Jean-Christophe DUBOIS Reviewed-by: Peter Crosthwa

[Qemu-devel] [PATCH v6 3/4] i.MX: Add i.MX25 3DS evaluation board support.

2013-06-04 Thread Jean-Christophe DUBOIS
For now we support: * timers (GPT and EPIT) * serial ports * ethernet (through the newly added FEC emulator) * I2C (through the newly added I2C emulator) Signed-off-by: Jean-Christophe DUBOIS --- Changes since v1: * Added a ds1338 I2C device for qtest purpose. Changes since

[Qemu-devel] [PATCH v6 0/4] i.MX: Add i.MX25 support through the 3DS evaluation board.

2013-06-04 Thread Jean-Christophe DUBOIS
This series of patches add the support for the i.MX25 processor through the Freescale 3DS evaluation board. For now a limited set of devices are supported. * GPT timers (from i.MX31) * EPIT timers (from i.MX31) * Serial ports (from i.MX31) * Ethernet FEC port * I2C controller

Re: [Qemu-devel] [PATCH 11/39] msix: split msix_free from msix_uninit

2013-06-04 Thread Michael S. Tsirkin
On Tue, Jun 04, 2013 at 08:52:06PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini Please add a commit log with a bit more detail and documenting the motivation for change. > --- > hw/misc/vfio.c | 1 + > hw/net/vmxnet3.c | 3 +++ > hw/pci/msix.c | 26 +++

Re: [Qemu-devel] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block

2013-06-04 Thread Alon Levy
> On 06/04/2013 02:23 PM, Alon Levy wrote: > > Used by the followin patch. > > s/followin/following/ Thanks. > > > > > +int qemu_pipe_non_block(int pipefd[2]) > > +{ > > +int ret; > > + > > +ret = qemu_pipe(pipefd); > > qemu_pipe() already uses pipe2() when available; it seems like i

[Qemu-devel] [PATCH v4] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-06-04 Thread Michael Roth
When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET, and it was issued as a bottom-half: 86e94dea5b740dad65446c857f6959eae43e0ba6 Which we basically used to print out a greeting/prompt for the monitor. AFAICT the only reason this was ever done in a BH was because in some cases we'd

Re: [Qemu-devel] [PATCH 2/2] nbd: strip braces from literal IPv6 address in URI

2013-06-04 Thread Paolo Bonzini
Il 03/06/2013 17:54, Ján Tomko ha scritto: > Otherwise they would get passed to getaddrinfo and fail with: > address resolution failed for [::1]:1234: Name or service not known Hmm... Hai Huang found a similar problem: error: internal error unable to execute QEMU command 'nbd-server-start': addre

Re: [Qemu-devel] [PATCH 5/5] libcacard/vscclient.c: fix use of uninitialized variable

2013-06-04 Thread Peter Maydell
On 4 June 2013 21:23, Alon Levy wrote: > Found by Coverity. > > Signed-off-by: Alon Levy > --- > libcacard/vscclient.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c > index 5180d29..4275c23 100644 > --- a/libcacard/vscclien

Re: [Qemu-devel] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block

2013-06-04 Thread Eric Blake
On 06/04/2013 02:23 PM, Alon Levy wrote: > Used by the followin patch. s/followin/following/ > > +int qemu_pipe_non_block(int pipefd[2]) > +{ > +int ret; > + > +ret = qemu_pipe(pipefd); qemu_pipe() already uses pipe2() when available; it seems like it would be nicer to use pipe2's O_NO

Re: [Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block

2013-06-04 Thread Peter Maydell
On 4 June 2013 21:59, Alon Levy wrote: > shouldn't we be looping if EINTR? Don't open that can of worms if you value your sanity ;-) -- PMM

Re: [Qemu-devel] [PATCH 4/5] libcacard/vreader.c: fix possible NULL dereference

2013-06-04 Thread Peter Maydell
On 4 June 2013 21:23, Alon Levy wrote: > Reported by Coverity: > > Error: FORWARD_NULL (CWE-476): > qemu-1.5.0/libcacard/vreader.c:267: cond_false: Condition "card == NULL", > taking false branch > qemu-1.5.0/libcacard/vreader.c:269: if_end: End of if statement > qemu-1.5.0/libcacard/vreader.c:27

Re: [Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block

2013-06-04 Thread Alon Levy
> Il 04/06/2013 22:23, Alon Levy ha scritto: > > This fixes six instances of unchecked fcntl return status, spotted by > > Coverity. > > I think we're just assuming that they cannot fail... I don't think we > need the previous patch and this one, unless they help porting stuff to > Windows. This

Re: [Qemu-devel] [PATCH 3/5] libcacard/vscclient: fix leakage of socket on error paths

2013-06-04 Thread Peter Maydell
On 4 June 2013 21:23, Alon Levy wrote: > Spotted by Coverity. > > Signed-off-by: Alon Levy Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block

2013-06-04 Thread Alon Levy
> On 4 June 2013 21:23, Alon Levy wrote: > > --- a/hw/display/qxl.c > > +++ b/hw/display/qxl.c > > @@ -1797,15 +1797,11 @@ static void qxl_send_events(PCIQXLDevice *d, > > uint32_t events) > > > > static void init_pipe_signaling(PCIQXLDevice *d) > > { > > -if (pipe(d->pipe) < 0) { > > -

Re: [Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block

2013-06-04 Thread Peter Maydell
On 4 June 2013 21:23, Alon Levy wrote: > --- a/hw/display/qxl.c > +++ b/hw/display/qxl.c > @@ -1797,15 +1797,11 @@ static void qxl_send_events(PCIQXLDevice *d, uint32_t > events) > > static void init_pipe_signaling(PCIQXLDevice *d) > { > -if (pipe(d->pipe) < 0) { > -fprintf(stderr,

Re: [Qemu-devel] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block

2013-06-04 Thread Peter Maydell
On 4 June 2013 21:23, Alon Levy wrote: > > +int qemu_pipe_non_block(int pipefd[2]) > +{ > +int ret; > + > +ret = qemu_pipe(pipefd); > +if (ret) { > +return ret; > +} > +if (fcntl(card->pipe[0], F_SETFL, O_NONBLOCK) == -1) { > +return -errno; > +} > +if (

Re: [Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 22:23, Alon Levy ha scritto: > This fixes six instances of unchecked fcntl return status, spotted by > Coverity. I think we're just assuming that they cannot fail... I don't think we need the previous patch and this one, unless they help porting stuff to Windows. Paolo

[Qemu-devel] [PATCH 5/5] libcacard/vscclient.c: fix use of uninitialized variable

2013-06-04 Thread Alon Levy
Found by Coverity. Signed-off-by: Alon Levy --- libcacard/vscclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index 5180d29..4275c23 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -645,7 +645,7 @@ main(

[Qemu-devel] [PATCH 3/5] libcacard/vscclient: fix leakage of socket on error paths

2013-06-04 Thread Alon Levy
Spotted by Coverity. Signed-off-by: Alon Levy --- libcacard/vscclient.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index ac23647..5180d29 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -618,18 +618

[Qemu-devel] [PATCH 4/5] libcacard/vreader.c: fix possible NULL dereference

2013-06-04 Thread Alon Levy
Reported by Coverity: Error: FORWARD_NULL (CWE-476): qemu-1.5.0/libcacard/vreader.c:267: cond_false: Condition "card == NULL", taking false branch qemu-1.5.0/libcacard/vreader.c:269: if_end: End of if statement qemu-1.5.0/libcacard/vreader.c:272: cond_false: Condition "apdu == NULL", taking fals

[Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block

2013-06-04 Thread Alon Levy
This fixes six instances of unchecked fcntl return status, spotted by Coverity. Signed-off-by: Alon Levy --- hw/display/qxl.c| 10 +++--- hw/usb/ccid-card-emulated.c | 8 +++- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c

[Qemu-devel] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block

2013-06-04 Thread Alon Levy
Used by the followin patch. Signed-off-by: Alon Levy --- include/qemu-common.h | 1 + util/oslib-posix.c| 19 +++ 2 files changed, 20 insertions(+) diff --git a/include/qemu-common.h b/include/qemu-common.h index cb82ef3..c24d75c 100644 --- a/include/qemu-common.h +++ b/inc

Re: [Qemu-devel] [snabb-devel:326] Re: snabbswitch integration with QEMU for userspace ethernet I/O

2013-06-04 Thread Luke Gorrie
On 4 June 2013 14:49, Julian Stecklina wrote: > Yes. Btw, progress is being made. Albeit a bit slower than expected. I > will have to show something "soon". > Awesome! It's already about 9 months since I did my simple proof-of-concept integration (https://github.com/SnabbCo/QEMU/compare/master..

[Qemu-devel] [Bug 998435] Re: qemu-kvm-spice doesn't support spice/qxl installs

2013-06-04 Thread Michael Adam
Sorry, I meant to say: I was not yet able to confirm that it is fixed in raring. I am able to confirm that the bug persists in 12.04: kvm-spice won't work with any other graphics card than cirrus. Cheers - Michael -- You received this bug notification because you are a member of qemu- devel-ml,

[Qemu-devel] [Bug 998435] Re: qemu-kvm-spice doesn't support spice/qxl installs

2013-06-04 Thread Michael Adam
I was not able to confirm yet, but since 12.04 is a LTS release, are there any chances to get this fixed in 12.04? Our virt server is running 12.04, and we would not like to do do an upgrade before 14.04. Thanks - Michael -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-04 Thread Richard Henderson
Ping. r~ On 05/24/2013 02:20 PM, Richard Henderson wrote: > Allows unwinding past the code_gen_buffer. > > Signed-off-by: Richard Henderson > --- > tcg/arm/tcg-target.c | 91 > ++-- > 1 file changed, 82 insertions(+), 9 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH 1/3] virtio: add bus_plugged() callback to VirtioDeviceClass

2013-06-04 Thread Jesse Larrew
On 06/04/2013 12:35 PM, Andreas Färber wrote: > Hi, > Hi Andreas! Thanks for the review. :) > Am 04.06.2013 18:22, schrieb Jesse Larrew: >> Virtio devices are initialized prior to plugging them into a bus. However, >> other initializations (such as host_features) don't occur until after the >>

Re: [Qemu-devel] [GIT PULL] Xen fixes and cleanups 20130603

2013-06-04 Thread Anthony Liguori
Stefano Stabellini writes: > On Tue, 4 Jun 2013, Stefano Stabellini wrote: >> On Mon, 3 Jun 2013, Anthony Liguori wrote: >> >> Thanks for the link. Even though maybe partial, having a document >> that explains the process is great (I wish there was one for Linux too). >> >> The page hints at pa

[Qemu-devel] [Bug 1187529] [NEW] Devices on PCI bridge stop working when live-migrated

2013-06-04 Thread Don Koch
Public bug reported: qemu version: 1.4.50 (0ca5aa4f4c4a8bcc73988dd52a536241d35e5223) host: x86_64, Linux 3.6.10 (Fedora 17) client: x86_64 Centos 6.3 (doesn't matter, really) If a device, e.g. an lsi53c895a, is on a pci-bridge, after migration, the device stops working (e.g., commands like "powe

Re: [Qemu-devel] [PATCH 0/2] TPM NVRAM persistent storage

2013-06-04 Thread Eric Blake
On 06/04/2013 01:35 PM, Corey Bryant wrote: > > > On 06/04/2013 03:23 PM, Eric Blake wrote: >> On 06/04/2013 12:18 PM, Corey Bryant wrote: >>> This patch series provides persistent storage support that a TPM >> can use to store NVRAM data. It uses QEMU's block driver to store >>> data on a drive

Re: [Qemu-devel] [PATCH 0/2] TPM NVRAM persistent storage

2013-06-04 Thread Corey Bryant
On 06/04/2013 03:23 PM, Eric Blake wrote: On 06/04/2013 12:18 PM, Corey Bryant wrote: This patch series provides persistent storage support that a TPM can use to store NVRAM data. It uses QEMU's block driver to store data on a drive image. The libtpms TPM 1.2 backend will be the initial us

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-04 Thread Eric Blake
On 06/04/2013 01:24 PM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> Il 04/06/2013 18:37, Markus Armbruster ha scritto: >>> I figure the bit that can't be resolved now is letting the user switch >>> off "stop on error" safely before a drive_del. Even if we had a command >>> for that, th

Re: [Qemu-devel] [PATCH 0/2] TPM NVRAM persistent storage

2013-06-04 Thread Eric Blake
On 06/04/2013 12:18 PM, Corey Bryant wrote: > This patch series provides persistent storage support that a TPM > can use to store NVRAM data. It uses QEMU's block driver to store > data on a drive image. The libtpms TPM 1.2 backend will be the > initial user of this functionality to store data th

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-04 Thread Markus Armbruster
Paolo Bonzini writes: > Il 04/06/2013 18:37, Markus Armbruster ha scritto: >> I figure the bit that can't be resolved now is letting the user switch >> off "stop on error" safely before a drive_del. Even if we had a command >> for that, there'd still be a window between that command's execution

[Qemu-devel] [PATCH 07/39] serial: split exit and instance_finalize

2013-06-04 Thread Paolo Bonzini
Character devices are still detached at "unrealize" time. Signed-off-by: Paolo Bonzini --- hw/char/serial-pci.c | 24 1 file changed, 24 insertions(+) diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c index 6b6106b..8cdec94 100644 --- a/hw/char/serial-pci.c +++ b

[Qemu-devel] [PATCH 25/39] pci_bridge: split pci_bridge_free from pci_bridge_exitfn

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/pci-bridge/i82801b11.c | 1 + hw/pci-bridge/ioh3420.c| 2 ++ hw/pci-bridge/pci_bridge_dev.c | 2 ++ hw/pci-bridge/xio3130_downstream.c | 2 ++ hw/pci-bridge/xio3130_upstream.c | 2 ++ hw/pci/pci_bridge.c| 5 + incl

Re: [Qemu-devel] broken incoming migration

2013-06-04 Thread Peter Lieven
Am 04.06.2013 um 17:17 schrieb Paolo Bonzini : > Il 04/06/2013 16:48, Peter Lieven ha scritto: >> Still using 3.2, but strange enough the above example is also not >> increasing RSS size for me. >> >> Can you try the following: >> qemu git master with 1G of memory (hanging in bios with no boot d

[Qemu-devel] [PATCH 37/39] wdt_i6300esb: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/watchdog/wdt_i6300esb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c index 1407fba..b8cfc64 100644 --- a/hw/watchdog/wdt_i6300esb.c +++ b/hw/watchdog/wdt_i6300esb.c @@ -411,8 +4

[Qemu-devel] [PATCH 38/39] xen_pt: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/xen/xen_pt.c | 10 ++ hw/xen/xen_pt_config_init.c | 3 --- hw/xen/xen_pt_msi.c | 8 +++- 3 files changed, 17 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index be1fd52..f40e761 100644 --- a/hw/x

[Qemu-devel] [PATCH 36/39] virtio-pci: split exit and instance_finalize

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-pci.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index cbfec6b..61f4dcb 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -996,8 +996,14 @@ static v

[Qemu-devel] [PATCH 32/39] esp: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi/esp-pci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index 029789a..4fe3445 100644 --- a/hw/scsi/esp-pci.c +++ b/hw/scsi/esp-pci.c @@ -361,8 +361,9 @@ static int esp_pci_scsi_init(PCIDevic

Re: [Qemu-devel] [PATCH v2 06/17] sysbus: add sysbus_pass_mmio

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 19:47, Alex Williamson ha scritto: > We'll see about that ;) At the very least you broke the tie. :) > It's true that it's simply a mental model of > doing the required steps, then optimizing that makes vfio need a > sprinkling of set ownership calls. Paolo, your patch to move the

[Qemu-devel] [PATCH 26/39] pcie_aer: pcie_aer_exit really frees stuff

2013-06-04 Thread Paolo Bonzini
Rename it, and move its call towards the end to prepare for unrealize/instance_finalize split. Signed-off-by: Paolo Bonzini --- hw/pci-bridge/ioh3420.c| 2 +- hw/pci-bridge/xio3130_downstream.c | 2 +- hw/pci-bridge/xio3130_upstream.c | 2 +- hw/pci/pcie_aer.c | 3

[Qemu-devel] [PATCH 24/39] shpc: split shpc_free out of shpc_cleanup

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/pci-bridge/pci_bridge_dev.c | 2 ++ hw/pci/shpc.c | 8 +++- include/hw/pci/shpc.h | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c index 971b432..

[Qemu-devel] [PATCH 31/39] pcie: do not recreate mmcfg I/O region, use an alias instead

2013-06-04 Thread Paolo Bonzini
The MMIO regions should not be destroyed and recreated on the fly, because they might have I/O in progress. Instead, create an area that is as large as possible, and then map a window of it into system memory. This is possible because containers and aliases are never the destination of I/O and can

[Qemu-devel] [PATCH 21/39] pcnet: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/net/pcnet-pci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/net/pcnet-pci.c b/hw/net/pcnet-pci.c index 9df2b87..2cd2927 100644 --- a/hw/net/pcnet-pci.c +++ b/hw/net/pcnet-pci.c @@ -271,8 +271,9 @@ static void pci_pcnet_cleanup(Ne

[Qemu-devel] [PATCH 30/39] xio3130-upstream: split exit and instance_finalize

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/pci-bridge/xio3130_upstream.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/pci-bridge/xio3130_upstream.c b/hw/pci-bridge/xio3130_upstream.c index 9485f5e..f719496 100644 --- a/hw/pci-bridge/xio3130_upstream.c +++ b/hw/pci-bridge/xio3130_upstrea

[Qemu-devel] [PATCH 19/39] eepro100: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/net/eepro100.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index dc99ea6..5f95240 100644 --- a/hw/net/eepro100.c +++ b/hw/net/eepro100.c @@ -1840,8 +1840,9 @@ static void nic_cleanup(NetClientSt

[Qemu-devel] [PATCH 29/39] xio3130-downstream: split exit and instance_finalize

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/pci-bridge/xio3130_downstream.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/pci-bridge/xio3130_downstream.c b/hw/pci-bridge/xio3130_downstream.c index 6ff336f..477cb12 100644 --- a/hw/pci-bridge/xio3130_downstream.c +++ b/hw/pci-bridge/xio313

[Qemu-devel] [PATCH 39/39] tpm: move add/del_subregion to realize/unrealize

2013-06-04 Thread Paolo Bonzini
Only do init/destroy in instance_init/finalize. Signed-off-by: Paolo Bonzini --- hw/tpm/tpm_tis.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index d4d8152..303d778 100644 --- a/hw/tpm/tpm_tis.c +++ b/hw/tpm/tpm_tis.c @@

[Qemu-devel] [PATCH 15/39] ivshmem: split exit and instance_finalize

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/misc/ivshmem.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index a19a6d6..d4af440 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -772,13 +772,20 @@ static void pci_ivshmem_uninit

[Qemu-devel] [PATCH 27/39] pci_bridge: split exit and instance_finalize

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/pci-bridge/pci_bridge_dev.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c index c1aab15..3f06e56 100644 --- a/hw/pci-bridge/pci_bridge_dev.c +++ b/hw/pci-bridge/pci_

[Qemu-devel] [PATCH 14/39] ide/via: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/ide/via.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ide/via.c b/hw/ide/via.c index 5fe053c..58070df 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -190,8 +190,9 @@ static int vt82c686b_ide_initfn(PCIDevice *dev) return 0;

[Qemu-devel] [PATCH 23/39] vmxnet3: split exit and instance_finalize

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/net/vmxnet3.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 9de2586..5b1b9e0 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -1979,7 +1979,6 @@ vmxnet3_init_msix(VMXNET3State

[Qemu-devel] [PATCH 35/39] usb-uhci: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/usb/hcd-uhci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index c85b203..766e0fb 100644 --- a/hw/usb/hcd-uhci.c +++ b/hw/usb/hcd-uhci.c @@ -1282,8 +1282,9 @@ static int usb_uhci_vt82c686b_initf

[Qemu-devel] [PATCH 13/39] ide/piix: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/ide/piix.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index bf2856f..a0550c6 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -201,8 +201,9 @@ PCIDevice *pci_piix3_xen_ide_init(PCIBus *bus, DriveIn

[Qemu-devel] [PATCH 22/39] rtl8139: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/net/rtl8139.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index 7993f9f..c1c4921 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -3437,8 +3437,9 @@ static void rtl8139_cleanup(NetClientSta

[Qemu-devel] [PATCH 33/39] lsi: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi/lsi53c895a.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 22b8e98..53bbc01 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -2059,8 +2059,9 @@ static const VMState

[Qemu-devel] [PATCH 04/39] ac97: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/audio/ac97.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/audio/ac97.c b/hw/audio/ac97.c index baf138b..f53ca74 100644 --- a/hw/audio/ac97.c +++ b/hw/audio/ac97.c @@ -1388,8 +1388,9 @@ static int ac97_initfn (PCIDevice *dev)

[Qemu-devel] [PATCH 34/39] pvscsi: split exit and instance_finalize

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi/vmw_pvscsi.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index eb2270f..5e97555 100644 --- a/hw/scsi/vmw_pvscsi.c +++ b/hw/scsi/vmw_pvscsi.c @@ -1100,9 +1100,18 @@ pvscsi_unin

[Qemu-devel] [PATCH 28/39] ioh4320: split exit and instance_finalize

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/pci-bridge/ioh3420.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c index 0a3cbb7..50df259 100644 --- a/hw/pci-bridge/ioh3420.c +++ b/hw/pci-bridge/ioh3420.c @@ -157,6 +157,12 @@ static void ioh3420_

[Qemu-devel] [PATCH 11/39] msix: split msix_free from msix_uninit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/misc/vfio.c | 1 + hw/net/vmxnet3.c | 3 +++ hw/pci/msix.c | 26 -- hw/virtio/virtio-pci.c | 1 + include/hw/pci/msix.h | 1 + 5 files changed, 26 insertions(+), 6 deletions(-) diff --git a/hw/misc/vfio.c b/h

[Qemu-devel] [PATCH 09/39] pci-assign: split exit and instance_finalize

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/i386/kvm/pci-assign.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c index 4b1c2d9..6eb4c96 100644 --- a/hw/i386/kvm/pci-assign.c +++ b/hw/i386/kvm/pci-assign.c @@ -1837,6 +1837,13 @@ static void

[Qemu-devel] [PATCH 18/39] e1000: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/net/e1000.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index e6f46f0..cad4fd6 100644 --- a/hw/net/e1000.c +++ b/hw/net/e1000.c @@ -1294,8 +1294,9 @@ e1000_cleanup(NetClientState *nc) } static voi

[Qemu-devel] [PATCH 06/39] hda: split exit and instance_finalize

2013-06-04 Thread Paolo Bonzini
MSI is still terminated at unrealize time. Signed-off-by: Paolo Bonzini --- hw/audio/intel-hda.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index 1016af0..4f2dcf3 100644 --- a/hw/audio/intel-hda.c +++ b/hw/audio/intel-hda.c @@ -1148,6

[Qemu-devel] [PATCH 08/39] tpci200: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/char/tpci200.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/char/tpci200.c b/hw/char/tpci200.c index 0170602..18e199b 100644 --- a/hw/char/tpci200.c +++ b/hw/char/tpci200.c @@ -613,8 +613,9 @@ static int tpci200_initfn(PCIDevice *

[Qemu-devel] [PATCH 20/39] ne2000: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/net/ne2000.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c index 33ee03e..aded2da 100644 --- a/hw/net/ne2000.c +++ b/hw/net/ne2000.c @@ -745,8 +745,9 @@ static int pci_ne2000_init(PCIDevice *pci_dev)

[Qemu-devel] [PATCH 17/39] vfio: split exit and instance_finalize

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/misc/vfio.c | 51 +++ 1 file changed, 47 insertions(+), 4 deletions(-) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index 2bcef7a..c9c68fa 100644 --- a/hw/misc/vfio.c +++ b/hw/misc/vfio.c @@ -2167,6 +2167,12 @@ s

[Qemu-devel] [PATCH 10/39] ahci: split exit and instance_finalize

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/ide/ahci.c | 2 +- hw/ide/ahci.h | 2 +- hw/ide/ich.c | 13 + 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 6b87549..083e0f4 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1174,7 +1174,7 @

[Qemu-devel] [PATCH 05/39] es1370: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/audio/es1370.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/audio/es1370.c b/hw/audio/es1370.c index c1cd169..a89ee10 100644 --- a/hw/audio/es1370.c +++ b/hw/audio/es1370.c @@ -1044,8 +1044,9 @@ static int es1370_initfn (PCIDevice

[Qemu-devel] [PATCH 16/39] pci-testdev: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/misc/pci-testdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/misc/pci-testdev.c b/hw/misc/pci-testdev.c index 71ce5a3..731748a 100644 --- a/hw/misc/pci-testdev.c +++ b/hw/misc/pci-testdev.c @@ -272,8 +272,9 @@ static int pci_te

[Qemu-devel] [PATCH 03/39] pci: split exit and finalize

2013-06-04 Thread Paolo Bonzini
To properly support devices that do DMA out of the BQL, destruction needs to be done in two phases. First, the device is unrealized; at this point, pending memory accesses can still be completed, but no new accesses will be started. The second part is freeing the device, which happens only after

[Qemu-devel] [PATCH 01/39] scsi: keep device alive while it has requests

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index 53ea906..e443193 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -516,6 +516,8 @@ SCSIRequest *scsi_req_alloc(const SCSIReqOps *req

[Qemu-devel] [PATCH 12/39] cmd646: use instance_finalize instead of exit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/ide/cmd646.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index a73eb9a..296dee6 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -295,8 +295,9 @@ static int pci_cmd646_ide_initfn(PCIDevice *dev

[Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-04 Thread Paolo Bonzini
QOM splits the destruction of a device in two phases: - unrealize, also known as "exit" from qdev times, should isolate the device from the guest. After unrealize returns, the guest should not be able to issue new requests. - instance_finalize will reclaim the memory. This is only called

[Qemu-devel] [PATCH 02/39] dma: keep a device alive while it has SGLists

2013-06-04 Thread Paolo Bonzini
A QEMUSGList has a reference to a device's address space. Keep the device alive while the QEMUSGList exists. Signed-off-by: Paolo Bonzini --- dma-helpers.c | 6 +- hw/ide/ahci.c | 3 ++- hw/ide/macio.c| 4 ++-- hw/scsi/megasas.c | 4 ++-- hw/scsi/virtio-scsi.

Re: [Qemu-devel] [PATCH v5 4/4] Add qtest support for i.MX I2C device emulation.

2013-06-04 Thread Jean-Christophe DUBOIS
On 06/04/2013 05:24 AM, Peter Crosthwaite wrote: Hi Peter, On Tue, Jun 4, 2013 at 1:21 AM, Peter Maydell wrote: On 8 May 2013 09:28, Jean-Christophe DUBOIS wrote: This is using a ds1338 RTC chip on the i2c bus. This RTC chip is not present on the real board. Ideally this should work by the

Re: [Qemu-devel] VFIO and scheduled SR-IOV cards

2013-06-04 Thread Alex Williamson
On Tue, 2013-06-04 at 17:50 +0200, Benoît Canet wrote: > Hello, > > More informations on how the hardware works. > > -Each VF will have its own memory and MMR, etc. > That means the resources are not shared. I'm still not clear on MMR, what is that? Memory Mapped Registers (ie. registers access

  1   2   3   >