[Qemu-devel] [Bug 1187121] Re: segfault with -vga vmware and -display gtk

2013-09-01 Thread Michael Tokarev
This has been fixed in 1.6.0. ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1187121 Title: segfault with -vga vmware and -display gtk

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] slirp: Port redirection option behave differently on Linux and Windows

2013-09-01 Thread Jan Kiszka
On 2013-09-01 18:13, Stefan Weil wrote: > Am 01.09.2013 17:46, schrieb Michael Tokarev: >> 30.08.2013 15:04, Jan Kiszka wrote: >>> On 2013-08-15 21:25, Taimoor wrote: From: Taimoor Mirza port redirection code uses SO_REUSEADDR socket option before binding to host port. Behavior

Re: [Qemu-devel] [PATCH v3 2/3] qdev: interface for SysBusDevice to change property on requirement

2013-09-01 Thread liu ping fan
On Fri, Aug 30, 2013 at 8:32 PM, Andreas Färber wrote: > Am 30.08.2013 10:17, schrieb Paolo Bonzini: >> Il 30/08/2013 09:53, Liu Ping Fan ha scritto: >>> qdev's property can not be set after realized, but there is a >>> requirement of adjusting device's behavior on different mother >>> boards. So

[Qemu-devel] [Bug 1024248] Re: qemu -M isapc displays blank screen

2013-09-01 Thread Michael Tokarev
It looks like this issue is fixed in 1.6.0 version ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1024248 Title: qemu -M isapc displays

Re: [Qemu-devel] [PATCH v3 2/3] qdev: interface for SysBusDevice to change property on requirement

2013-09-01 Thread liu ping fan
On Fri, Aug 30, 2013 at 4:17 PM, Paolo Bonzini wrote: > Il 30/08/2013 09:53, Liu Ping Fan ha scritto: >> qdev's property can not be set after realized, but there is a >> requirement of adjusting device's behavior on different mother >> boards. So introducing a callback in sysbus_try_create_simple

[Qemu-devel] [PATCH v2] spapr-vscsi: Adding VSCSI capabilities

2013-09-01 Thread Nikunj A. Dadhania
This implements capabilities exchange between vscsi host and client. As at the moment no capability is supported, put zero flags everywhere and return. Signed-off-by: Nikunj A Dadhania --- hw/scsi/spapr_vscsi.c | 54 +++ 1 file changed, 54 insert

Re: [Qemu-devel] [Qemu-stable] [PATCH] qapi-types.py: Fix enum struct sizes on i686

2013-09-01 Thread Doug Goldstein
On Sat, Aug 31, 2013 at 9:07 PM, Eric Blake wrote: > On 08/31/2013 04:36 PM, Cole Robinson wrote: > > Unlike other list types, enum wasn't adding any padding, which caused > > a mismatch between the generated struct size and GenericList struct > > size. More details in a678e26cbe89f7a27cbce794c2c

Re: [Qemu-devel] [PATCH v3 2/3] qcow2: Implement bdrv_amend_options

2013-09-01 Thread Fam Zheng
On Fri, 08/30 12:27, Max Reitz wrote: > Implement bdrv_amend_options for compat, size, backing_file, backing_fmt > and lazy_refcounts. > > Downgrading images from compat=1.1 to compat=0.10 is achieved through > handling all incompatible flags accordingly, clearing all compatible and > autoclear fl

Re: [Qemu-devel] [PATCH V11 1/5] throttle: Add a new throttling API implementing continuous leaky bucket.

2013-09-01 Thread Fam Zheng
On Sun, 09/01 18:39, Benoît Canet wrote: > Implement the continuous leaky bucket algorithm devised on IRC as a separate > module. > > Signed-off-by: Benoit Canet > --- > include/qemu/throttle.h | 103 > util/Makefile.objs |1 + > util/throttle.c | 396 > +

Re: [Qemu-devel] [edk2] OVMF hung on qemu 1.6.0 with KVM

2013-09-01 Thread Gary Ching-Pang Lin
On Sat, Aug 31, 2013 at 12:16:21AM -0700, Jordan Justen wrote: > On Thu, Aug 29, 2013 at 8:28 PM, Gary Ching-Pang Lin wrote: > > On Fri, Aug 30, 2013 at 02:04:40AM +1000, Bruce Rogers wrote: > >> I tried this out, and I get the black screen as well when ept=n, but it > >> boots > >> successfully

Re: [Qemu-devel] [PATCH V11 4/5] block: Add support for throttling burst max in QMP and the command line.

2013-09-01 Thread Fam Zheng
On Sun, 09/01 18:39, Benoît Canet wrote: > The max parameter of the leaky bucket throttling algorithm can be used to > allow the guest to do bursts. > The max value is a pool of I/O that the guest can use without being throttled > at all. Throttling is triggered once this pool is empty. It would b

Re: [Qemu-devel] [PATCH V11 3/5] block: Enable the new throttling code in the block layer.

2013-09-01 Thread Fam Zheng
On Sun, 09/01 18:39, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block.c | 338 > + > block/qapi.c | 21 ++- > blockdev.c| 100 -- > include/block/block.h |1 - > incl

Re: [Qemu-devel] [PATCH V2 1/3] qemu-iotests: add unix socket help program

2013-09-01 Thread Wenchao Xia
于 2013-8-30 19:33, Luiz Capitulino 写道: On Fri, 30 Aug 2013 10:42:27 +0800 Wenchao Xia wrote: 于 2013-8-29 22:50, Luiz Capitulino 写道: On Tue, 27 Aug 2013 10:52:09 +0800 Wenchao Xia wrote: This program can do a sendmsg call to transfer fd with unix socket, which is not supported in python2.

Re: [Qemu-devel] [PATCH V7 0/8] add internal snapshot support at block device level

2013-09-01 Thread Wenchao Xia
于 2013-8-16 23:36, Stefan Hajnoczi 写道: On Wed, Aug 07, 2013 at 11:00:11AM +0800, Wenchao Xia wrote: v6: Address Stefan's comments: 2/8: macro STR_PRINT_CHAR was renamed as STR_OR_NULL, and moved into patch 5, since implement function in this patch do not printf snapshot id any more, as Kev

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] slirp: Port redirection option behave differently on Linux and Windows

2013-09-01 Thread Mirza, Taimoor
Hi Guys, Thanks for reviewing the patch. Only difference between v2 and v3 is that v2 had an extra character added at top of the file (socket.c). This was removed in v3. Regards, Taimoor From: Stefan Weil [s...@weilnetz.de] Sent: Sunday, September 01,

Re: [Qemu-devel] [RFC v2 4/5] hw/arm/digic: add UART support

2013-09-01 Thread Peter Crosthwaite
Hi Antony, On Mon, Sep 2, 2013 at 7:22 AM, Antony Pavlov wrote: > Signed-off-by: Antony Pavlov > --- > hw/arm/digic.c | 14 > hw/char/Makefile.objs | 1 + > hw/char/digic-uart.c | 197 > + > hw/char/digic-uart.h | 27 +++

Re: [Qemu-devel] [PATCH v2 2/2] milkymist-uart: use Device::realize instead of SysBusDevice::init

2013-09-01 Thread Peter Crosthwaite
On Sun, Sep 1, 2013 at 3:22 AM, Antony Pavlov wrote: > Use of SysBusDevice::init is deprecated. > Use Device::realize instead of SysBusDevice::init. > Check dma/pl330.c for an example of the pattern. > I think Andreas may have fixed in enqueue, but informal suggestion of change patterns arent rea

Re: [Qemu-devel] [PATCH v2 1/2] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write()

2013-09-01 Thread Peter Crosthwaite
On Sun, Sep 1, 2013 at 3:22 AM, Antony Pavlov wrote: > qemu_chr_fe_write() is capable of returning 0 > to indicate EAGAIN (and friends) and we don't > handle this. > > Just change it to qemu_chr_fe_write_all() to fix. > > Reported-by: Peter Crosthwaite Acked-by Peter Crosthwaite > Signed-off-b

Re: [Qemu-devel] [PATCH v2] kvm: warn if num cpus is greater than num recommended

2013-09-01 Thread Marcelo Tosatti
On Fri, Aug 23, 2013 at 03:24:37PM +0200, Andrew Jones wrote: > The comment in kvm_max_vcpus() states that it's using the recommended > procedure from the kernel API documentation to get the max number > of vcpus that kvm supports. It is, but by always returning the > maximum number supported. The

Re: [Qemu-devel] Fw: Max7310: confused about the method of reading output port register

2013-09-01 Thread andrzej zaborowski
Hi Yang, On 26 August 2013 03:47, Yang Ning wrote: > > Dear All: > > Firstly,I'm writing to express my thanks to Zaborowski for the source code > of Max7310 which have helped me so much. > But I'm still confused about the method of reading output port register. > code: >> >>case 0x01: /*

[Qemu-devel] [RFC v2 5/5] hw/arm/digic: add NOR ROM support

2013-09-01 Thread Antony Pavlov
Signed-off-by: Antony Pavlov --- hw/arm/digic_boards.c | 67 +++ 1 file changed, 67 insertions(+) diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c index 0b99227..7b7dc1c 100644 --- a/hw/arm/digic_boards.c +++ b/hw/arm/digic_boards.c @@ -1

[Qemu-devel] [RFC v2 4/5] hw/arm/digic: add UART support

2013-09-01 Thread Antony Pavlov
Signed-off-by: Antony Pavlov --- hw/arm/digic.c | 14 hw/char/Makefile.objs | 1 + hw/char/digic-uart.c | 197 + hw/char/digic-uart.h | 27 +++ include/hw/arm/digic.h | 4 + 5 files changed, 243 insertions(+) create mode

[Qemu-devel] [RFC v2 2/5] hw/arm/digic: prepare DIGIC-based boards support

2013-09-01 Thread Antony Pavlov
Also this patch adds initial support for Canon PowerShot A1100 IS compact camera. Signed-off-by: Antony Pavlov --- hw/arm/Makefile.objs | 2 +- hw/arm/digic_boards.c | 63 +++ 2 files changed, 64 insertions(+), 1 deletion(-) create mode 100644 h

[Qemu-devel] [RFC v2 3/5] hw/arm/digic: add timer support

2013-09-01 Thread Antony Pavlov
Signed-off-by: Antony Pavlov --- hw/arm/digic.c | 25 ++ hw/timer/Makefile.objs | 1 + hw/timer/digic-timer.c | 122 + hw/timer/digic-timer.h | 19 include/hw/arm/digic.h | 7 +++ 5 files changed, 174 insertions(+) cr

[Qemu-devel] [RFC v2 0/5] hw/arm: add initial support for Canon DIGIC SoC

2013-09-01 Thread Antony Pavlov
[RFC v2 1/5] hw/arm: add very initial support for Canon DIGIC SoC [RFC v2 2/5] hw/arm/digic: prepare DIGIC-based boards support [RFC v2 3/5] hw/arm/digic: add timer support [RFC v2 4/5] hw/arm/digic: add UART support [RFC v2 5/5] hw/arm/digic: add NOR ROM support Changes since v1: 0. drop the "ad

[Qemu-devel] [RFC v2 1/5] hw/arm: add very initial support for Canon DIGIC SoC

2013-09-01 Thread Antony Pavlov
DIGIC is Canon Inc.'s name for a family of SoC for digital cameras and camcorders. There is no publicly available specification for DIGIC chips. All information about DIGIC chip internals is based on reverse engineering efforts made by CHDK (http://chdk.wikia.com) and Magic Lantern (http://www.mag

[Qemu-devel] [PATCH] w32: Fix access to host devices (regression)

2013-09-01 Thread Stefan Weil
QEMU failed to open host devices like \\.\PhysicalDrive0 (first hard disk) since some time (commit 8a79380b8ef1b02d2abd705dd026a18863b09020?). Those devices use hdev_open which did not use the latest API for options. This resulted in a fatal runtime error: Block protocol 'host_device' doesn't s

Re: [Qemu-devel] [PATCH v2 2/2] milkymist-uart: use Device::realize instead of SysBusDevice::init

2013-09-01 Thread Antony Pavlov
On Sat, 31 Aug 2013 21:09:20 +0200 Andreas Färber wrote: > Am 31.08.2013 19:22, schrieb Antony Pavlov: > > Use of SysBusDevice::init is deprecated. > > Use Device::realize instead of SysBusDevice::init. > > Check dma/pl330.c for an example of the pattern. > > > > Also introduce TypeInfo::instanc

[Qemu-devel] [PATCH V11 5/5] block: Add iops_size to do the iops accounting for a given io size.

2013-09-01 Thread Benoît Canet
This feature can be used in case where users are avoiding the iops limit by doing jumbo I/Os hammering the storage backend. Signed-off-by: Benoit Canet Reviewed-by: Eric Blake --- block/qapi.c |3 +++ blockdev.c | 21 ++--- hmp.c|8 ++-- qapi-

[Qemu-devel] [PATCH V11 4/5] block: Add support for throttling burst max in QMP and the command line.

2013-09-01 Thread Benoît Canet
The max parameter of the leaky bucket throttling algorithm can be used to allow the guest to do bursts. The max value is a pool of I/O that the guest can use without being throttled at all. Throttling is triggered once this pool is empty. Signed-off-by: Benoit Canet Reviewed-by: Eric Blake ---

[Qemu-devel] [PATCH V11 3/5] block: Enable the new throttling code in the block layer.

2013-09-01 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block.c | 338 + block/qapi.c | 21 ++- blockdev.c| 100 -- include/block/block.h |1 - include/block/block_int.h | 32 + 5 files changed, 164 i

[Qemu-devel] [PATCH V11 1/5] throttle: Add a new throttling API implementing continuous leaky bucket.

2013-09-01 Thread Benoît Canet
Implement the continuous leaky bucket algorithm devised on IRC as a separate module. Signed-off-by: Benoit Canet --- include/qemu/throttle.h | 103 util/Makefile.objs |1 + util/throttle.c | 396 +++ 3 files changed, 500

[Qemu-devel] [PATCH V11 2/5] throttle: Add units tests

2013-09-01 Thread Benoît Canet
Signed-off-by: Benoit Canet --- tests/Makefile|2 + tests/test-throttle.c | 481 + 2 files changed, 483 insertions(+) create mode 100644 tests/test-throttle.c diff --git a/tests/Makefile b/tests/Makefile index b0200fd..6d2f3ad 100644

[Qemu-devel] [PATCH V11 0/5] Continuous Leaky Bucket Throttling

2013-09-01 Thread Benoît Canet
This patchset implement continous leaky bucket throttling. It use two requests queue to enable to do silly unbalanced throttling like block_set_io_throttle 0 0 0 0 6000 1 It use two timer to get the timer callbacks and the throttle.c code simple v11: Reapplied Eric's reviewed by (they are pre

[Qemu-devel] [PATCH V10 4/5] block: Add support for throttling burst max in QMP and the command line.

2013-09-01 Thread Benoît Canet
The max parameter of the leaky bucket throttling algorithm can be used to allow the guest to do bursts. The max value is a pool of I/O that the guest can use without being throttled at all. Throttling is triggered once this pool is empty. Signed-off-by: Benoit Canet --- block/qapi.c | 26 +

[Qemu-devel] [PATCH V10 5/5] block: Add iops_size to do the iops accounting for a given io size.

2013-09-01 Thread Benoît Canet
This feature can be used in case where users are avoiding the iops limit by doing jumbo I/Os hammering the storage backend. Signed-off-by: Benoit Canet --- block/qapi.c |3 +++ blockdev.c | 21 ++--- hmp.c|8 ++-- qapi-schema.json | 10 ++

[Qemu-devel] [PATCH V10 3/5] block: Enable the new throttling code in the block layer.

2013-09-01 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block.c | 338 + block/qapi.c | 21 ++- blockdev.c| 100 -- include/block/block.h |1 - include/block/block_int.h | 32 + 5 files changed, 164 i

[Qemu-devel] [PATCH V10 2/5] throttle: Add units tests

2013-09-01 Thread Benoît Canet
Signed-off-by: Benoit Canet --- tests/Makefile|2 + tests/test-throttle.c | 481 + 2 files changed, 483 insertions(+) create mode 100644 tests/test-throttle.c diff --git a/tests/Makefile b/tests/Makefile index b0200fd..6d2f3ad 100644

[Qemu-devel] [PATCH V10 1/5] throttle: Add a new throttling API implementing continuous leaky bucket.

2013-09-01 Thread Benoît Canet
Implement the continuous leaky bucket algorithm devised on IRC as a separate module. Signed-off-by: Benoit Canet --- include/qemu/throttle.h | 103 util/Makefile.objs |1 + util/throttle.c | 396 +++ 3 files changed, 500

[Qemu-devel] [PATCH V10 0/5] Continuous Leaky Bucket Throttling

2013-09-01 Thread Benoît Canet
This patchset implement continous leaky bucket throttling. It use two requests queue to enable to do silly unbalanced throttling like block_set_io_throttle 0 0 0 0 6000 1 It use two timer to get the timer callbacks and the throttle.c code simple in this version Rebased on top of Eric latest p

[Qemu-devel] [PATCH 08/14] tcg-ppc64: Look through a constant function descriptor

2013-09-01 Thread Richard Henderson
Especially in the user-only configurations, a direct branch into the executable may be in range. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.

[Qemu-devel] [PATCH 13/14] tcg-ppc64: Add _noaddr functions for emitting forward branches

2013-09-01 Thread Richard Henderson
... rather than open-coding this stuff through the file. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 61bb463..4b53560 100644 ---

Re: [Qemu-devel] [Qemu-trivial] [PATCH for-1.6] adlib: sort offsets in portio registration

2013-09-01 Thread Michael Tokarev
14.08.2013 13:49, Hervé Poussineau wrote: This fixes the following assert when -device adlib is used: ioport.c:240: portio_list_add: Assertion `pio->offset >= off_last' failed. Thanks, applied to the trivial-patches queue. /mjt

[Qemu-devel] [PATCH 12/14] tcg-ppc64: Streamline tcg_out_tlb_read

2013-09-01 Thread Richard Henderson
Less conditional compilation. Merge an add insn with the indexed memory load insn. Load the tlb addend earlier. Avoid the address update memory form. Fix a bug in not allowing large enough tlb offsets for some guests. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 194

[Qemu-devel] [PATCH 14/14] tcg-ppc64: Implement CONFIG_QEMU_LDST_OPTIMIZATION

2013-09-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- configure | 2 +- tcg/ppc64/tcg-target.c | 212 +++-- 2 files changed, 136 insertions(+), 78 deletions(-) diff --git a/configure b/configure index 0a55c20..4d627a9 100755 --- a/configure +++ b/configu

[Qemu-devel] [PATCH 11/14] tcg-ppc64: Implement tcg_register_jit

2013-09-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 96 ++ 1 file changed, 73 insertions(+), 23 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 07991a9..c833f62 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg

[Qemu-devel] [PATCH 09/14] tcg-ppc64: Tidy register allocation order

2013-09-01 Thread Richard Henderson
Remove conditionalization from tcg_target_reg_alloc_order, relying on reserved_regs to prevent register allocation that shouldn't happen. So R11 is now present in reg_alloc_order for __APPLE__, but also now reserved. Sort reg_alloc_order into call-saved, call-clobbered, and parameters. This reduce

[Qemu-devel] [PATCH 07/14] tcg-ppc64: Fold constant call address into descriptor load

2013-09-01 Thread Richard Henderson
Eliminates one insn per call: : lis r2,4165 -: ori r2,r2,59616 -: ld r0,0(r2) +: ld r0,-5920(r2) : mtctr r0 -: ld r2,8(r2) +: ld r2,-5912(r2) : bctrl Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 14 +++--- 1 file changed, 11 inse

[Qemu-devel] [PATCH 04/14] tcg-ppc64: Use tcg_out64

2013-09-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 8dd346a..da82411 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-target.c @@ -997,9 +997,6 @@ static v

[Qemu-devel] [PATCH 00/14] tcg-ppc64 improvements

2013-09-01 Thread Richard Henderson
A random collection of cleanups to the ppc64 backend, culminating in a conversion to out-of-line calls to the ldst helpers. The final conversion looks a lot like the ppc32 version. r~ Richard Henderson (14): tcg-ppc64: Reformat tcg-target.c tcg-ppc64: More use of TAI and SAI helper macros

[Qemu-devel] [PATCH 05/14] tcg-ppc64: Avoid code for nop move

2013-09-01 Thread Richard Henderson
While these are rare from code that's been through the optimizer, it's not uncommon within the tcg backend. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index da8

[Qemu-devel] [PATCH 03/14] tcg-ppc64: Use TCG_REG_Rn constants

2013-09-01 Thread Richard Henderson
Instead of bare N, for clarity. The only (intentional) exception made is for insns that encode R|0, i.e. when R0 encoded into the insn is interpreted as zero not the contents of the register. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 96 +-

[Qemu-devel] [PATCH 06/14] tcg-ppc64: Don't load the static chain from TCG

2013-09-01 Thread Richard Henderson
There are no helpers that require the static chain. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 8a43a14..e631991 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-target

[Qemu-devel] [PATCH 10/14] tcg-ppc64: Handle long offsets better

2013-09-01 Thread Richard Henderson
Previously we'd only handle 16-bit offsets from memory operand without falling back to indexed, but it's easy to use ADDIS to handle full 32-bit offsets. This also lets us unify code that existed inline in tcg_out_op for handling addition of large constants. The new R2 temporary was marked reserv

[Qemu-devel] [PATCH 01/14] tcg-ppc64: Reformat tcg-target.c

2013-09-01 Thread Richard Henderson
Whitespace and brace changes only. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 484 - 1 file changed, 242 insertions(+), 242 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index ec067e6..c0acaed 100644

[Qemu-devel] [PATCH 02/14] tcg-ppc64: More use of TAI and SAI helper macros

2013-09-01 Thread Richard Henderson
Finish conversion of all memory operations. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 41 - 1 file changed, 16 insertions(+), 25 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index c0acaed..78acf3c 100644 --

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] slirp: Port redirection option behave differently on Linux and Windows

2013-09-01 Thread Stefan Weil
Am 01.09.2013 17:46, schrieb Michael Tokarev: > 30.08.2013 15:04, Jan Kiszka wrote: >> On 2013-08-15 21:25, Taimoor wrote: >>> From: Taimoor Mirza >>> >>> port redirection code uses SO_REUSEADDR socket option before binding to >>> host port. Behavior of SO_REUSEADDR is different on Windows and Lin

[Qemu-devel] [PATCH 3/4] tcg-ppc: Convert to helper_ret_ld/st_mmu

2013-09-01 Thread Richard Henderson
Drop the ld/st_trampolines, loading the return address into a parameter register directly. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 4 +- tcg/ppc/tcg-target.c| 220 +++- 2 files changed, 86 insertions(+), 138 deletions(-) d

[Qemu-devel] [PATCH 4/4] tcg-ppc: Fix and cleanup tcg_out_tlb_check

2013-09-01 Thread Richard Henderson
The fix is that sparc has so many mmu modes that the last one overflowed the 16-bit signed offset we assumed would fit. Handle this, and check the new assumption at compile time. Load the tlb addend earlier for the fast path. Remove the explicit address + addend and make use of index addressing.

[Qemu-devel] [PATCH 0/4] tcg-ppc ldst improvements

2013-09-01 Thread Richard Henderson
The first patch allows me to build the ppc32 target on a ppc64 host. The rest of them update the ppc32 backend on top of the v2 "Further tcg ldst improvements" patch set. r~ Richard Henderson (4): configure: Allow command-line configure for ppc32 tcg-ppc: Avoid code for nop move tcg-ppc:

[Qemu-devel] [PATCH 1/4] configure: Allow command-line configure for ppc32

2013-09-01 Thread Richard Henderson
Similar to manually selecting i386 for an x86_64 host. Signed-off-by: Richard Henderson --- configure | 8 1 file changed, 8 insertions(+) diff --git a/configure b/configure index 0a55c20..07eaa3c 100755 --- a/configure +++ b/configure @@ -951,6 +951,14 @@ for opt do done case "$cp

[Qemu-devel] [PATCH 2/4] tcg-ppc: Avoid code for nop move

2013-09-01 Thread Richard Henderson
While these are rare from code that's been through the optimizer, it's not uncommon within the tcg backend. Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index 9a73d06..

Re: [Qemu-devel] [Qemu-trivial] [PATCHv2] aio / timers: use g_usleep() not sleep()

2013-09-01 Thread Michael Tokarev
30.08.2013 08:01, Stefan Weil wrote: Am 30.08.2013 00:32, schrieb Alex Bligh: sleep() apparently doesn't exist under mingw. Use g_usleep for portability. Thanks, applied to the trivial-patches queue. /mjt

[Qemu-devel] [PATCH] target-ppc: Fix include for qemu_notify_event

2013-09-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-ppc/kvm_ppc.c | 1 + 1 file changed, 1 insertion(+) The PowerPC target has been broken for more than a week. r~ diff --git a/target-ppc/kvm_ppc.c b/target-ppc/kvm_ppc.c index 9b83655..47e54a6 100644 --- a/target-ppc/kvm_ppc.c +++ b/target-ppc/kvm_p

Re: [Qemu-devel] [Qemu-trivial] [PATCHv2] qmp: fix integer usage in examples

2013-09-01 Thread Michael Tokarev
31.08.2013 00:44, Eric Blake wrote: Per the qapi schema, block_set_io_throttle takes most arguments as ints, not strings. * qmp-commands.hx (block_set_io_throttle): Use correct type. Fix whitespace and a copy-paste bug in the process. Thanks, applied to the trivial-patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] slirp: Port redirection option behave differently on Linux and Windows

2013-09-01 Thread Michael Tokarev
30.08.2013 15:04, Jan Kiszka wrote: On 2013-08-15 21:25, Taimoor wrote: From: Taimoor Mirza port redirection code uses SO_REUSEADDR socket option before binding to host port. Behavior of SO_REUSEADDR is different on Windows and Linux. Relaunching QEMU with same host and guest port redirection

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tci: Remove function tcg_out64 (fix broken build)

2013-09-01 Thread Michael Tokarev
28.08.2013 21:28, Stefan Weil wrote: Commit ac26eb69a311396668809eadbf7ff4e623447d4c added tcg_out64 to tcg/tcg.c. tcg/tci/tcg-target.c already had a nearly identical implementation which is now removed to fix a compiler error. Thanks, applied to the trivial-patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-arm: Report unimplemented opcodes (LOG_UNIMP)

2013-09-01 Thread Michael Tokarev
28.08.2013 08:39, Stefan Weil wrote: These unimplemented opcodes are handled like illegal opcodes, but they are used in existing code. We should at least report when they are executed. Thanks, applied to the trivial-patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] configure: Remove unneeded redirections of stderr (pkg-config --cflags, --libs)

2013-09-01 Thread Michael Tokarev
27.08.2013 23:09, Stefan Weil wrote: For existing libraries, pkg-config --cflags and pkg-config --libs won't print error messages to stderr, so redirecting stderr is not necessary. Signed-off-by: Stefan Weil Thanks, applied both to the trivial-patches queue. A little good cleanup. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH 3/3] qemu-char: add support for U-prefixed symbols

2013-09-01 Thread Michael Tokarev
27.08.2013 19:14, Jan Krupa wrote: This patch adds support for Unicode symbols in keymap files. This feature was already used in some keyboard layouts in QEMU generated from XKB (e.g. Arabic) but it wasn't implemented in QEMU source code. Signed-off-by: Jan Krupa --- ui/keymaps.c |3 +++

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] qemu-char: add Czech keymap file

2013-09-01 Thread Michael Tokarev
27.08.2013 19:14, Jan Krupa wrote: This patch adds Czech keyboard layout to available keymap files. Signed-off-by: Jan Krupa --- pc-bios/keymaps/cz | 94 1 files changed, 94 insertions(+), 0 deletions(-) create mode 100644 pc-bios/keym

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Don't write .pyc files by default (python -B)

2013-09-01 Thread Michael Tokarev
27.08.2013 17:12, Stefan Weil wrote: When a Python script is run, Python normally writes bytecode into a .pyc file. QEMU's build process uses several Python scripts which are called from configure or make. The generated .pyc files take disk space without being of much use, because those scripts

Re: [Qemu-devel] [Qemu-trivial] [PATCH] curl: qemu_bh_new() can never return NULL

2013-09-01 Thread Michael Tokarev
26.08.2013 15:38, Stefan Hajnoczi wrote: Drop error code path which cannot be taken since qemu_bh_new() does not return NULL. Thanks, applied to the trivial-patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp/arp_table.c: Avoid shifting into sign bit of signed integers

2013-09-01 Thread Michael Tokarev
23.08.2013 20:36, Peter Maydell wrote: "0xf << 28" shifts right into the sign bit, since 0xf is a signed integer. Use the 'U' suffix to force an unsigned shift to avoid this undefined behaviour and a clang sanitizer warning. Thanks, applied to the trivial-patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: disable clang -Wstring-plus-int warning

2013-09-01 Thread Michael Tokarev
05.08.2013 23:16, Peter Maydell wrote: Some versions of clang will warn about adding integers to strings: disas/i386.c:4753:23: error: adding 'char' to a string does not append to the string [-Werror,-Wstring-plus-int] oappend ("%es:" + intel_syntax); ~~~^~~

Re: [Qemu-devel] [Qemu-trivial] [PATCH] misc: Fix some typos in names and comments

2013-09-01 Thread Michael Tokarev
18.08.2013 21:40, Stefan Weil wrote: Most typos were found using a modified version of codespell: accross -> across issueing -> issuing TICNT_THRESHHOLD -> TICNT_THRESHOLD bandwith -> bandwidth VCARD_7816_PROPIETARY -> VCARD_7816_PROPRIETARY occured -> occurred gaurantee -> guarantee sofware ->

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] slirp: Port redirection option behave differently on Linux and Windows

2013-09-01 Thread Michael Tokarev
15.08.2013 22:13, Taimoor wrote: From: Taimoor Mirza port redirection code uses SO_REUSEADDR socket option before binding to host port. Behavior of SO_REUSEADDR is different on Windows and Linux. Relaunching QEMU with same host and guest port redirection values on Linux throws error but on Wind

Re: [Qemu-devel] [PATCH V2] qemu-xen: HVM domain S3 bugfix

2013-09-01 Thread Liu, Jinsong
> > Could you break this path into two? One which add the notifier list > and a second one with the Xen specific part? > Updated and sent out. Thanks, Jinsong

[Qemu-devel] [PATCH 2/2] qemu-xen: add qemu xen logic for HVM S3 resume

2013-09-01 Thread Liu, Jinsong
>From e7d4bd70eae8da131dc3ff2cec70cb2c7b6575a9 Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Mon, 2 Sep 2013 00:39:20 +0800 Subject: [PATCH 2/2] qemu-xen: add qemu xen logic for HVM S3 resume This patch is qemu-xen patch 2 to fix HVM S3 bug, adding qemu xen logic. When qemu wakeup, qemu xen lo

Re: [Qemu-devel] [PATCH v2] cpu: Move cpu state syncs up into cpu_dump_state()

2013-09-01 Thread Gleb Natapov
On Tue, Aug 27, 2013 at 12:19:10PM +0100, James Hogan wrote: > The x86 and ppc targets call cpu_synchronize_state() from their > *_cpu_dump_state() callbacks to ensure that up to date state is dumped > when KVM is enabled (for example when a KVM internal error occurs). > > Move this call up into t

[Qemu-devel] [PATCH 1/2] qem-xen: add later wakeup logic when qemu wakeup

2013-09-01 Thread Liu, Jinsong
>From 86ad3bb83a984ad7bbc00b81d6a0bfc1abc543ca Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Sun, 1 Sep 2013 23:39:14 +0800 Subject: [PATCH 1/2] qemu-xen: add later wakeup logic when qemu wakeup Currently HVM S3 has a bug coming from the difference between qemu-traditioanl and qemu-xen. For qe

Re: [Qemu-devel] [PATCH v2] kvm: warn if num cpus is greater than num recommended

2013-09-01 Thread Gleb Natapov
On Fri, Aug 23, 2013 at 03:24:37PM +0200, Andrew Jones wrote: > The comment in kvm_max_vcpus() states that it's using the recommended > procedure from the kernel API documentation to get the max number > of vcpus that kvm supports. It is, but by always returning the > maximum number supported. The

Re: [Qemu-devel] [PATCH] KVM: always use MADV_DONTFORK

2013-09-01 Thread Gleb Natapov
On Thu, Jul 25, 2013 at 12:11:15PM +0200, Andrea Arcangeli wrote: > MADV_DONTFORK prevents fork to fail with -ENOMEM if the default > overcommit heuristics decides there's too much anonymous virtual > memory allocated. If the KVM secondary MMU is synchronized with MMU > notifiers or not, doesn't ma

[Qemu-devel] Capture SIGSEGV to track pc.ram page access

2013-09-01 Thread Thomas Knauth
Dear all, I'm trying to use a signal handler to catch SIGSEGV's in qemu. I want(ed) to use them to track which memory pages are accessed by the guest (only accesses to the pc.ram). After some hours of fruitless mucking around, I've come to the conclusion that it is not as straightforward as with "

[Qemu-devel] [PATCH] virtio_pci: fix level interrupts with irqfd

2013-09-01 Thread Michael S. Tsirkin
commit 62c96360ae7f2c7a8b029277fbb7cb082fdef7fd virtio-pci: fix level interrupts only helps systems without irqfd: on systems with irqfd support we passed in flag requesting irqfd even when msix is disabled. As a result, for level interrupts we didn't install an fd handler so unmasking an fd h

[Qemu-devel] [PATCHv3] pc: reduce duplication, fix PIIX descriptions

2013-09-01 Thread Michael S. Tsirkin
We have a lot of code duplication between machine types, this increases with each new machine type and each new field. This has already introduced a minor bug: description for pc-1.3 says "Standard PC" while description for pc-1.4 is "Standard PC (i440FX + PIIX, 1996)" which makes you think 1.3 is