[Qemu-devel] [PATCH v2 4/4] ioapic: QOM'ify ioapic

2013-11-04 Thread xiaoqiang zhao
changes: 1. use type constant for kvm_ioapic and ioapic 2. convert 'init' to QOM's 'realize' for ioapic and kvm_ioapic For QOM'ify, I move variable 'ioapic_no' from static to global. Then we can drop the 'instance_no' argument. Now, it's child that increase 'ioapic_no' counter. --- hw/i386/kvm/ioa

[Qemu-devel] [PATCH v2 0/4] QOM'ify apic and ioapic

2013-11-04 Thread xiaoqiang zhao
This series of patch QOM'ify apic and ioapic. Just replace old 'init' with QOM's 'realize', the call logic is untouched. the first patch of each is a cleanup. the second patch complete the convertion. All patch have been compiled and tested successfully. Changes since v1: - separate cleanup patc

[Qemu-devel] [PATCH v2 1/4] apic: Cleanup for QOM'ify

2013-11-04 Thread xiaoqiang zhao
do some cleanup, includes: 1. remove DO_UPCAST() for APICCommonState 2. Change DeviceState pointers from 'd' to 'dev', better to understand 3. rename 'register_types' to specifically 'apic_common_register_types' --- hw/i386/kvm/apic.c|8 +++ hw/intc/apic.c| 42 +++

[Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-04 Thread xiaoqiang zhao
changes includes: 1. use type constant for apic and kvm_apic 2. convert function 'init' to QOM's 'realize' for apic/kvm_apic 3. for consistency, also QOM'ify apic's parent bus 'icc_bus' --- hw/cpu/icc_bus.c| 14 ++ hw/i386/kvm/apic.c | 10 +++--- hw

[Qemu-devel] [PATCH v2 3/4] ioapic: Cleanup for QOM'ify

2013-11-04 Thread xiaoqiang zhao
some cleanup: 1. ioapic_common.c: rename 'register_types' to 'ioapic_common_register_types' 2. change 'DEVICE(s)' to dev conversion by introducing local variable 'DeviceState *dev' --- hw/i386/kvm/ioapic.c|4 +++- hw/intc/ioapic.c|4 +++- hw/intc/ioapic_common.c |4 ++-- 3

Re: [Qemu-devel] [PATCH v2] iscsi: add error handling for qmp_query_uuid

2013-11-04 Thread Laszlo Ersek
On 11/05/13 01:33, Amos Kong wrote: > We can't assume that qmp_query_uuid() always returns available value. > > Signed-off-by: Amos Kong > --- > v2: free errp if it's set > --- > block/iscsi.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/block/iscsi.c b/block

Re: [Qemu-devel] [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS

2013-11-04 Thread Gleb Natapov
On Thu, Oct 17, 2013 at 04:47:52PM +0200, Paolo Bonzini wrote: > Only the first item of the array was ever looked at. No > practical effect, but still worth fixing. > > Signed-off-by: Paolo Bonzini Applied, thanks. > --- > target-i386/kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deleti

[Qemu-devel] [PATCH] net: fix qemu_flush_queued_packets() in presence of a hub

2013-11-04 Thread Sergey Fedorov
Do not return after net_hub_flush(). Always flush callee network client incoming queue. Signed-off-by: Sergey Fedorov --- net/net.c |1 - 1 file changed, 1 deletion(-) diff --git a/net/net.c b/net/net.c index c330c9a..aeb479b 100644 --- a/net/net.c +++ b/net/net.c @@ -442,7 +442,6 @@ void q

Re: [Qemu-devel] [PATCH v2] blockdev: fix cdrom read_only flag

2013-11-04 Thread Fam Zheng
Cc'ing qemu-stable. Fam On 10/15/2013 05:45 PM, Fam Zheng wrote: Since 0ebd24e0, cdrom doesn't have read-only on by default, which will error out when using an read only image. Fix it by setting the default value when parsing opts. Reported-by: Edivaldo de Araujo Pereira Signed-off-by: Fam Zh

Re: [Qemu-devel] [PATCH] RFC: powerpc: add PVR compatibility check

2013-11-04 Thread Alexander Graf
Am 05.11.2013 um 05:00 schrieb Paul Mackerras : > On Mon, Nov 04, 2013 at 10:05:58AM +0100, Alexander Graf wrote: >> >> Yeah, we really need to check that guest vpcu == host vcpu for HV KVM. > > In general I agree, but the one difficulty I see is that a check for > exact equality will interact

Re: [Qemu-devel] [PATCH v3] ppc: introduce CPUPPCState::cpu_dt_id

2013-11-04 Thread Alexander Graf
Am 05.11.2013 um 02:48 schrieb Scott Wood : > On Tue, 2013-11-05 at 12:26 +1100, Alexey Kardashevskiy wrote: >> On 11/05/2013 06:42 AM, Scott Wood wrote: >>> On Mon, 2013-11-04 at 10:41 +0100, Alexander Graf wrote: What we really have are 3 semantically separate entities: * QEMU

Re: [Qemu-devel] [PATCH 2/6] qapi: rename MonitorEvent to QEvent

2013-11-04 Thread Wenchao Xia
于 2013/11/5 10:51, Luiz Capitulino 写道: On Tue, 05 Nov 2013 10:17:28 +0800 Wenchao Xia wrote: 于 2013/11/4 21:33, Luiz Capitulino 写道: On Mon, 04 Nov 2013 09:59:50 +0800 Wenchao Xia wrote: 于 2013/11/1 22:02, Luiz Capitulino 写道: On Mon, 21 Oct 2013 10:16:01 +0800 Wenchao Xia wrote: Signed-

Re: [Qemu-devel] [PATCH v2] Fix pc migration from qemu <= 1.5

2013-11-04 Thread Alex Williamson
On Tue, 2013-10-08 at 15:35 -0400, Cole Robinson wrote: > The following commit introduced a migration incompatibility: > > commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe > Author: David Gibson > Date: Thu Jun 6 18:48:49 2013 +1000 > > pci: Replace pci_find_domain() with more general pci_r

Re: [Qemu-devel] [PATCH] RFC: powerpc: add PVR compatibility check

2013-11-04 Thread Paul Mackerras
On Mon, Nov 04, 2013 at 10:05:58AM +0100, Alexander Graf wrote: > > Yeah, we really need to check that guest vpcu == host vcpu for HV KVM. In general I agree, but the one difficulty I see is that a check for exact equality will interact badly with qemu's habit of picking a specific processor vers

[Qemu-devel] Running a custom function every cycle

2013-11-04 Thread Karim Yehia Elghamrawy
Hi, I am new to qemu and I was wondering if it is possible to have my own custom function to run every CPU cycle. Basically I am trying to invoke the pmemsave command (or the underlying function) each CPU cycle. I have been reading about the singlestep mode. It seems interesting because it raises a

Re: [Qemu-devel] [PATCH v2 1/2] block/drive-mirror: Check for NULL backing_hd

2013-11-04 Thread Fam Zheng
On 11/05/2013 08:35 AM, Max Reitz wrote: It should be possible to execute the QMP "drive-mirror" command in "none" sync mode and "absolute-paths" mode even for block devices lacking a backing file. "absolute-paths" does in fact not require a backing file to be present, as can be seen from the "

Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap

2013-11-04 Thread Fam Zheng
On 11/04/2013 10:38 PM, Benoît Canet wrote: Le Monday 04 Nov 2013 à 17:30:10 (+0800), Fam Zheng a écrit : Previously a BlockDriverState has only one dirty bitmap, so only one caller (e.g. a block job) can keep track of writing. This changes the dirty bitmap to a list and creates a BdrvDirtyBitm

Re: [Qemu-devel] [PATCH 2/6] qapi: rename MonitorEvent to QEvent

2013-11-04 Thread Luiz Capitulino
On Tue, 05 Nov 2013 10:17:28 +0800 Wenchao Xia wrote: > 于 2013/11/4 21:33, Luiz Capitulino 写道: > > On Mon, 04 Nov 2013 09:59:50 +0800 > > Wenchao Xia wrote: > > > >> 于 2013/11/1 22:02, Luiz Capitulino 写道: > >>> On Mon, 21 Oct 2013 10:16:01 +0800 > >>> Wenchao Xia wrote: > >>> > Signed-off-

Re: [Qemu-devel] [PATCH] migration: avoid starting a new migration task while the previous one still exist

2013-11-04 Thread Zhanghaoyu (A)
> > Avoid starting a new migration task while the previous one still > exist. > > Can you explain how to reproduce the problem? > When network disconnection between source and destination happened, the migration thread stuck at below stack, #0 0x7f07e96c8288 in writev () from /lib64/libc.so

Re: [Qemu-devel] [PATCH] spapr: add "compat" machine option

2013-11-04 Thread Alexey Kardashevskiy
On 10/01/2013 12:49 AM, Alexander Graf wrote: > On 09/30/2013 03:22 PM, Alexey Kardashevskiy wrote: >> On 30.09.2013 21:25, Alexander Graf wrote: >>> On 27.09.2013, at 10:06, Alexey Kardashevskiy wrote: I realized it has been a while since I got your response and did not answer :) Sorry for the d

Re: [Qemu-devel] [PATCH V4 2/6] qcow2: add error message in qcow2_write_snapshots()

2013-11-04 Thread Wenchao Xia
于 2013/11/5 3:46, Eric Blake 写道: On 11/03/2013 06:48 PM, Wenchao Xia wrote: On 14.10.2013 23:52, Wenchao Xia wrote: The function still returns int since qcow2_snapshot_delete() will return the number. @@ -227,24 +239,40 @@ static int qcow2_write_snapshots(BlockDriverState *bs)

Re: [Qemu-devel] [PATCH 2/6] qapi: rename MonitorEvent to QEvent

2013-11-04 Thread Wenchao Xia
于 2013/11/4 21:33, Luiz Capitulino 写道: On Mon, 04 Nov 2013 09:59:50 +0800 Wenchao Xia wrote: 于 2013/11/1 22:02, Luiz Capitulino 写道: On Mon, 21 Oct 2013 10:16:01 +0800 Wenchao Xia wrote: Signed-off-by: Wenchao Xia --- block.c|2 +- include/block/block_int.h |

Re: [Qemu-devel] [PATCH v3] ppc: introduce CPUPPCState::cpu_dt_id

2013-11-04 Thread Scott Wood
On Tue, 2013-11-05 at 12:26 +1100, Alexey Kardashevskiy wrote: > On 11/05/2013 06:42 AM, Scott Wood wrote: > > On Mon, 2013-11-04 at 10:41 +0100, Alexander Graf wrote: > >> What we really have are 3 semantically separate entities: > >> > >> * QEMU internal cpu id > >> * KVM internal cpu id > >>

Re: [Qemu-devel] [PATCH v3] ppc: introduce CPUPPCState::cpu_dt_id

2013-11-04 Thread Alexey Kardashevskiy
On 11/05/2013 06:42 AM, Scott Wood wrote: > On Mon, 2013-11-04 at 10:41 +0100, Alexander Graf wrote: >> What we really have are 3 semantically separate entities: >> >> * QEMU internal cpu id >> * KVM internal cpu id >> * DT exposed cpu id >> >> As you have noted, it's a good idea to keep the

Re: [Qemu-devel] [PATCH 1/2] kvm/apic: use QOM style

2013-11-04 Thread 赵小强
于 11/05/2013 01:23 AM, Andreas Färber 写道: Hi, Am 04.11.2013 07:41, schrieb 赵小强: 于 09/27/2013 01:30 PM, xiaoqiang zhao 写道: From: "xiaoqiang.zhao" Change apic and kvm/apic to use QOM interface. Includes: 1. APICCommonState now use QOM realizefn 2. Remove DO_UPCAST() for APICCommonState 3. Use

Re: [Qemu-devel] [PATCH] extend limit of physical sections number

2013-11-04 Thread Peter Maydell
On 27 September 2013 17:49, Amos Kong wrote: > # qemu -drive file=/disk0,if=none,id=v0,format=qcow2 \ > -device virtio-blk-pci,drive=v0,id=v00,multifunction=on,addr=0x04.0 > > > Launching guest with more than 32 virtio-blk disks, > qemu will crash, because there are too many BARs. > > This

[Qemu-devel] [PATCH v2 1/2] block/drive-mirror: Check for NULL backing_hd

2013-11-04 Thread Max Reitz
It should be possible to execute the QMP "drive-mirror" command in "none" sync mode and "absolute-paths" mode even for block devices lacking a backing file. "absolute-paths" does in fact not require a backing file to be present, as can be seen from the "top" sync mode code path. "top" basically st

[Qemu-devel] [PATCH v2 0/2] block/drive-mirror: Check for NULL backing_hd

2013-11-04 Thread Max Reitz
It should be possible to execute the QMP "drive-mirror" command in "none" sync mode and "absolute-paths" mode even for block devices lacking a backing file. "absolute-paths" does in fact not require a backing file to be present, as can be seen from the "top" sync mode code path. "top" basically st

[Qemu-devel] [PATCH v2 2/2] qemu-iotests: Add test for unbacked mirroring

2013-11-04 Thread Max Reitz
Add a new test for mirroring unbacked images in "absolute-paths" mode. This should work, if possible, but most importantly, qemu should never crash. Signed-off-by: Max Reitz --- tests/qemu-iotests/070 | 91 ++ tests/qemu-iotests/070.out | 33 ++

Re: [Qemu-devel] [PATCH 1/2] block/drive-mirror: Check for NULL backing_hd

2013-11-04 Thread Max Reitz
On 05.11.2013 01:30, Max Reitz wrote: > It should be possible to execute the QMP "drive-mirror" command in > "none" sync mode and "absolute-paths" mode even for block devices > lacking a backing file. > > "absolute-paths" does in fact not require a backing file to be present, > as can be seen from

[Qemu-devel] [PATCH v2] iscsi: add error handling for qmp_query_uuid

2013-11-04 Thread Amos Kong
We can't assume that qmp_query_uuid() always returns available value. Signed-off-by: Amos Kong --- v2: free errp if it's set --- block/iscsi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index a2a961e..4051bdd 100644 --- a/block/iscsi

[Qemu-devel] [PATCH 1/2] block/drive-mirror: Check for NULL backing_hd

2013-11-04 Thread Max Reitz
It should be possible to execute the QMP "drive-mirror" command in "none" sync mode and "absolute-paths" mode even for block devices lacking a backing file. "absolute-paths" does in fact not require a backing file to be present, as can be seen from the "top" sync mode code path. "top" basically st

Re: [Qemu-devel] [PATCH] extend limit of physical sections number

2013-11-04 Thread Amos Kong
On Fri, Sep 27, 2013 at 06:52:50PM +0200, Paolo Bonzini wrote: > Il 27/09/2013 18:49, Amos Kong ha scritto: > > # qemu -drive file=/disk0,if=none,id=v0,format=qcow2 \ > > -device virtio-blk-pci,drive=v0,id=v00,multifunction=on,addr=0x04.0 > > > > > > Launching guest with more than 32 virti

[Qemu-devel] [PATCH] iscsi: add error handling for qmp_query_uuid

2013-11-04 Thread Amos Kong
We can't assume that qmp_query_uuid() always returns available value. Signed-off-by: Amos Kong --- block/iscsi.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index a2a961e..1fc1da4 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1059

[Qemu-devel] [PATCH v3 06/10] raven: set a correct PCI memory region

2013-11-04 Thread Hervé Poussineau
PCI memory region is 0x3f00 bytes starting at 0xc000. However, keep compatibility with Open Hack'Ware expectations by adding a hack for Open Hack'Ware display. Signed-off-by: Hervé Poussineau --- hw/pci-host/prep.c |9 ++--- hw/ppc/prep.c |9 + 2 files changed,

[Qemu-devel] [PATCH v3 04/10] raven: rename intack region to pci_intack

2013-11-04 Thread Hervé Poussineau
Regions added in next patches will also have the pci_ prefix. Signed-off-by: Hervé Poussineau --- hw/pci-host/prep.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index 4dc5456..aaf5818 100644 --- a/hw/pci-host/prep.c +++ b/

[Qemu-devel] [PATCH v3 03/10] raven: move BIOS loading from board code to PCI host

2013-11-04 Thread Hervé Poussineau
Raven datasheet explains where firmware lives in system memory, so do it there instead of in board code. Other boards using the same PCI host will not have to copy the firmware loading code. However, add a specific hack for Open Hack'Ware, which provides only a 512KB blob to be loaded at 0xfff

[Qemu-devel] [PATCH v3 08/10] raven: implement non-contiguous I/O region

2013-11-04 Thread Hervé Poussineau
Remove now duplicated code from prep board. Signed-off-by: Hervé Poussineau --- hw/pci-host/prep.c | 82 + hw/ppc/prep.c | 94 ++-- 2 files changed, 85 insertions(+), 91 deletions(-) diff --git

[Qemu-devel] [PATCH v3 10/10] raven: use raven_ for all function prefixes

2013-11-04 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/pci-host/prep.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index 4eabe31..77cdfdd 100644 --- a/hw/pci-host/prep.c +++ b/hw/pci-host/prep.c @@ -69,7

[Qemu-devel] [PATCH v3 09/10] raven: fix PCI bus accesses with size > 1

2013-11-04 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/pci-host/prep.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index c11679a..4eabe31 100644 --- a/hw/pci-host/prep.c +++ b/hw/pci-host/prep.c @@ -222,12 +222,12 @@ static void raven_pci

[Qemu-devel] [PATCH v3 07/10] raven: add PCI bus mastering address space

2013-11-04 Thread Hervé Poussineau
This has been tested on Linux 2.4/PPC with the lsi53c895a SCSI adapter. Signed-off-by: Hervé Poussineau --- hw/pci-host/prep.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index 8ff58a9..cffb21e 100644 --- a/hw/pci-host/pr

[Qemu-devel] [PATCH v3 00/10] prep: improve Raven PCI host emulation

2013-11-04 Thread Hervé Poussineau
This patchset improves Raven PCI host emulation, found in some PPC platforms, like the QEMU 'prep' one, and for example the IBM RS/6000 40p. Some features added to raven emulation were already present in prep board (non contiguous I/O, firmware loading), while some other are new (PCI bus mastering

[Qemu-devel] [PATCH v3 05/10] raven: set a correct PCI I/O memory region

2013-11-04 Thread Hervé Poussineau
PCI I/O region is 0x3f80 bytes starting at 0x8000. Do not use global QEMU I/O region, which is only 64KB. Signed-off-by: Hervé Poussineau --- hw/pci-host/prep.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c i

[Qemu-devel] [PATCH v3 02/10] raven: use constant PCI_NUM_PINS instead of 4

2013-11-04 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/pci-host/prep.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index 0e71fdb..6ca9802 100644 --- a/hw/pci-host/prep.c +++ b/hw/pci-host/prep.c @@ -47,7 +47,7 @@ typedef struct PRePPCIState

[Qemu-devel] [PATCH v3 01/10] prep: kill get_system_io() usage

2013-11-04 Thread Hervé Poussineau
While ISA address space in prep machine is currently the one returned by get_system_io(), this depends of the implementation of i82378/raven devices, and this may not be the case forever. Use the right ISA address space when adding some more ports to it. We can use whatever ISA device on the right

Re: [Qemu-devel] [Bug 1245924] [NEW] mips64el magnum emulation broken

2013-11-04 Thread Hervé Poussineau
Darkstar a écrit : I'm trying to run the following: qemu-system-mips64el --machine magnum [...] The qemu binaries from (k)ubuntu work fine. "info version" shows 1.5.0 (Debian 1.5.0+dfsg-3ubuntu5) When I try qemu 1.6.1 (compiled from source .tar.bz2), however, qemu only shows a black screen when

Re: [Qemu-devel] [PATCH] spapr: make sure RMA is in first mode of first memory node

2013-11-04 Thread Benjamin Herrenschmidt
On Tue, 2013-11-05 at 00:11 +1100, Alexey Kardashevskiy wrote: > Question about english - is "the single RMA" equal to "the only RMA"? Yes. Ben.

[Qemu-devel] [PATCH] mips jazz: do not raise data bus exception when accessing invalid addresses

2013-11-04 Thread Hervé Poussineau
MIPS Jazz chipset doesn't seem to raise data bus exceptions on invalid accesses. However, there is no easy way to prevent them. Creating a big memory region for the whole address space doesn't prevent memory core to directly call unassigned_mem_read/write which in turn call cpu->do_unassigned_acces

Re: [Qemu-devel] [PATCH V4 1/6] snapshot: add parameter *errp in snapshot create

2013-11-04 Thread Max Reitz
On 04.11.2013 02:47, Wenchao Xia wrote: > 于 2013/11/2 20:39, Max Reitz 写道: >> On 14.10.2013 23:52, Wenchao Xia wrote: >>> The return value is only used for error report before this patch, >>> so change the function protype to return void. >>> >>> Signed-off-by: Wenchao Xia >>> --- >>> block/qcow

Re: [Qemu-devel] [PATCH] configure: Enable pie for powerpc and arm Linux

2013-11-04 Thread Paolo Bonzini
Il 04/11/2013 21:51, Richard Henderson ha scritto: >> > if test "$pie" = ""; then >> >case "$cpu-$targetos" in >> > -i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD) >> > + >> > i386-Linux|x86_64-Linux|x32-Linux|ppc*-Linux|arm*-Linux|aarch64*-Linux|i386-OpenBSD|x86_64-Ope

Re: [Qemu-devel] [PATCH v3] net: Adding netmap network backend

2013-11-04 Thread Anthony Liguori
On Mon, Nov 4, 2013 at 1:08 PM, Luigi Rizzo wrote: > > > > On Mon, Nov 4, 2013 at 12:54 PM, Anthony Liguori > wrote: >> >> On Mon, Nov 4, 2013 at 11:51 AM, Luigi Rizzo wrote: >> > On Mon, Nov 04, 2013 at 10:20:12AM -0800, Anthony Liguori wrote: >> >> On Mon, Nov 4, 2013 at 10:08 AM, Luigi Rizzo

Re: [Qemu-devel] [PATCH v3] net: Adding netmap network backend

2013-11-04 Thread Luigi Rizzo
On Mon, Nov 4, 2013 at 12:54 PM, Anthony Liguori wrote: > On Mon, Nov 4, 2013 at 11:51 AM, Luigi Rizzo wrote: > > On Mon, Nov 04, 2013 at 10:20:12AM -0800, Anthony Liguori wrote: > >> On Mon, Nov 4, 2013 at 10:08 AM, Luigi Rizzo > wrote: > > ... > >> >> On Tue, Oct 29, 2013 at 3:12 AM, Vincenzo

Re: [Qemu-devel] [PATCH] gtk: Fix compiler warnings with -Werror=sign-compare

2013-11-04 Thread Peter Maydell
On 4 November 2013 20:38, Laszlo Ersek wrote: > On 11/04/13 21:07, Peter Maydell wrote: >> If this warning is going to complain about entirely >> safe and idiomatic code like >> >>int i; >>static const int some_array[] = { >>0x2a, 0x36, 0x1d, 0x9d, 0x38, 0xb8, 0xdb, 0xdd, >>};

Re: [Qemu-devel] [PATCH v3] net: Adding netmap network backend

2013-11-04 Thread Anthony Liguori
On Mon, Nov 4, 2013 at 11:51 AM, Luigi Rizzo wrote: > On Mon, Nov 04, 2013 at 10:20:12AM -0800, Anthony Liguori wrote: >> On Mon, Nov 4, 2013 at 10:08 AM, Luigi Rizzo wrote: > ... >> >> On Tue, Oct 29, 2013 at 3:12 AM, Vincenzo Maffione >> >> wrote: >> >> > This patch adds support for a network

Re: [Qemu-devel] [PATCH] configure: Enable pie for powerpc and arm Linux

2013-11-04 Thread Richard Henderson
On 11/04/2013 10:19 PM, Dinar Valeev wrote: > From: Dinar Valeev > > This patch enables pie for PowerPC and ARM architectures > > Signed-off-by: Dinar Valeev > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 91372f9..0130e

Re: [Qemu-devel] [PATCH] gtk: Fix compiler warnings with -Werror=sign-compare

2013-11-04 Thread Laszlo Ersek
On 11/04/13 21:07, Peter Maydell wrote: > On 4 November 2013 19:51, Stefan Weil wrote: >> With -Werror=sign-compare (not enabled by default), gcc shows these errors: >> >> ui/gtk.c: In function ‘gtk_release_modifiers’: >> ui/gtk.c:288:19: error: >> comparison between signed and unsigned integer e

Re: [Qemu-devel] [PATCH] gtk: Fix compiler warnings with -Werror=sign-compare

2013-11-04 Thread Stefan Weil
Am 04.11.2013 21:07, schrieb Peter Maydell: > On 4 November 2013 19:51, Stefan Weil wrote: >> With -Werror=sign-compare (not enabled by default), gcc shows these errors: >> >> ui/gtk.c: In function ‘gtk_release_modifiers’: >> ui/gtk.c:288:19: error: >> comparison between signed and unsigned integ

Re: [Qemu-devel] [PATCH] gtk: Fix compiler warnings with -Werror=sign-compare

2013-11-04 Thread Peter Maydell
On 4 November 2013 19:51, Stefan Weil wrote: > With -Werror=sign-compare (not enabled by default), gcc shows these errors: > > ui/gtk.c: In function ‘gtk_release_modifiers’: > ui/gtk.c:288:19: error: > comparison between signed and unsigned integer expressions > [-Werror=sign-compare] > ui/gtk.c

Re: [Qemu-devel] [PATCH] pc: disable acpi info for isapc and old pc machine

2013-11-04 Thread Stefano Stabellini
On Mon, 4 Nov 2013, Michael S. Tsirkin wrote: > On Mon, Nov 04, 2013 at 03:13:50PM +0100, Paolo Bonzini wrote: > > Il 04/11/2013 11:46, Michael S. Tsirkin ha scritto: > > > Disable acpi build for isapc and no_kvmclock machine > > > types (used by xen), since acpi build currently expects pci. > > >

Re: [Qemu-devel] [PATCH] pc: disable acpi info for isapc and old pc machine

2013-11-04 Thread Stefano Stabellini
On Mon, 4 Nov 2013, Stefano Stabellini wrote: > On Mon, 4 Nov 2013, Paolo Bonzini wrote: > > Il 04/11/2013 11:46, Michael S. Tsirkin ha scritto: > > > Disable acpi build for isapc and no_kvmclock machine > > > types (used by xen), since acpi build currently expects pci. > > > > Xen is now using "-

Re: [Qemu-devel] [PATCH] pc: disable acpi info for isapc and old pc machine

2013-11-04 Thread Stefano Stabellini
On Mon, 4 Nov 2013, Paolo Bonzini wrote: > Il 04/11/2013 11:46, Michael S. Tsirkin ha scritto: > > Disable acpi build for isapc and no_kvmclock machine > > types (used by xen), since acpi build currently expects pci. > > Xen is now using "-M pc", so it's okay to remove it from the legacy "-M > xen

[Qemu-devel] [PATCH] gtk: Fix compiler warnings with -Werror=sign-compare

2013-11-04 Thread Stefan Weil
With -Werror=sign-compare (not enabled by default), gcc shows these errors: ui/gtk.c: In function ‘gtk_release_modifiers’: ui/gtk.c:288:19: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ui/gtk.c: In function ‘gd_key_event’: ui/gtk.c:746:19: error: comp

Re: [Qemu-devel] [PATCH v3] net: Adding netmap network backend

2013-11-04 Thread Luigi Rizzo
On Mon, Nov 04, 2013 at 10:20:12AM -0800, Anthony Liguori wrote: > On Mon, Nov 4, 2013 at 10:08 AM, Luigi Rizzo wrote: ... > >> On Tue, Oct 29, 2013 at 3:12 AM, Vincenzo Maffione > >> wrote: > >> > This patch adds support for a network backend based on netmap. > >> > netmap is a framework for hig

Re: [Qemu-devel] [PATCH V4 2/6] qcow2: add error message in qcow2_write_snapshots()

2013-11-04 Thread Eric Blake
On 11/03/2013 06:48 PM, Wenchao Xia wrote: >> On 14.10.2013 23:52, Wenchao Xia wrote: >>> The function still returns int since qcow2_snapshot_delete() will >>> return the number. >>> >>> @@ -227,24 +239,40 @@ static int >>> qcow2_write_snapshots(BlockDriverState *bs) >>> >>> ret = bdrv_

Re: [Qemu-devel] [PATCH v3] ppc: introduce CPUPPCState::cpu_dt_id

2013-11-04 Thread Scott Wood
On Mon, 2013-11-04 at 10:41 +0100, Alexander Graf wrote: > What we really have are 3 semantically separate entities: > > * QEMU internal cpu id > * KVM internal cpu id > * DT exposed cpu id > > As you have noted, it's a good idea to keep the QEMU internal cpu id > linear, thus completely se

Re: [Qemu-devel] [PATCH 1.7] vl: allow "cont" from panicked state

2013-11-04 Thread Eric Blake
On 11/04/2013 06:30 AM, Paolo Bonzini wrote: > After reporting the GUEST_PANICKED monitor event, QEMU stops the VM. > The reason for this is that events are edge-triggered, and can be lost if > management dies at the wrong time. Stopping a panicked VM lets management > know of a panic even if it h

Re: [Qemu-devel] [PATCH 1.7] pc: get rid of builtin pvpanic for "-M pc-1.5"

2013-11-04 Thread Eric Blake
On 11/04/2013 06:30 AM, Paolo Bonzini wrote: > This causes two slight backwards-incompatibilities between "-M pc-1.5" > and 1.5's "-M pc": > > (1) a fw_cfg file is removed with this patch. This is only a problem > if migration stops the virtual machine exactly during fw_cfg enumeration. > > (2)

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-04 Thread Peter Maydell
On 4 November 2013 18:55, Petar Jovanovic wrote: > I am not sure I understand your point. This used to be all in one file, now > it is divided in arch-specific files that can be later populated with other > target specific struct definitions. This was also suggested in the first > review a month a

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-04 Thread Petar Jovanovic
From: Alex Bennée [alex.ben...@linaro.org] Sent: Monday, November 04, 2013 5:46 PM To: Petar Jovanovic Cc: qemu-devel@nongnu.org; peter.mayd...@linaro.org; riku.voi...@linaro.org; Petar Jovanovic; aurel...@aurel32.net; afaer...@suse.de Subject: Re: [Qemu-d

Re: [Qemu-devel] [PATCH v3] net: Adding netmap network backend

2013-11-04 Thread Eric Blake
On 10/29/2013 04:12 AM, Vincenzo Maffione wrote: > This patch adds support for a network backend based on netmap. > netmap is a framework for high speed packet I/O. You can use it > to build extremely fast traffic generators, monitors, software > switches or network middleboxes. Its companion softw

Re: [Qemu-devel] [PATCH v3] net: Adding netmap network backend

2013-11-04 Thread Anthony Liguori
On Mon, Nov 4, 2013 at 10:08 AM, Luigi Rizzo wrote: > > > > On Mon, Nov 4, 2013 at 9:41 AM, Anthony Liguori > wrote: >> >> On Tue, Oct 29, 2013 at 3:12 AM, Vincenzo Maffione >> wrote: >> > This patch adds support for a network backend based on netmap. >> > netmap is a framework for high speed pa

Re: [Qemu-devel] [PATCH v3] net: Adding netmap network backend

2013-11-04 Thread Luigi Rizzo
On Mon, Nov 4, 2013 at 9:41 AM, Anthony Liguori wrote: > On Tue, Oct 29, 2013 at 3:12 AM, Vincenzo Maffione > wrote: > > This patch adds support for a network backend based on netmap. > > netmap is a framework for high speed packet I/O. You can use it > > to build extremely fast traffic generator

Re: [Qemu-devel] [PATCH] kvm: Add a new machine property kvm_type

2013-11-04 Thread Paolo Bonzini
Il 04/11/2013 18:41, Andreas Färber ha scritto: >> > I agree that we need some way to programmatically list all machine options. > I wonder if it would make sense to mirror all -machine options as > dynamic properties on /machine? :) > Their addition could still be driven by the declarative format.

Re: [Qemu-devel] [PATCH v3] net: Adding netmap network backend

2013-11-04 Thread Anthony Liguori
On Tue, Oct 29, 2013 at 3:12 AM, Vincenzo Maffione wrote: > This patch adds support for a network backend based on netmap. > netmap is a framework for high speed packet I/O. You can use it > to build extremely fast traffic generators, monitors, software > switches or network middleboxes. Its compa

Re: [Qemu-devel] [PATCH] kvm: Add a new machine property kvm_type

2013-11-04 Thread Andreas Färber
Hi, Am 04.11.2013 14:30, schrieb Alexander Graf: > I agree that we need some way to programmatically list all machine options. I wonder if it would make sense to mirror all -machine options as dynamic properties on /machine? :) Their addition could still be driven by the declarative format. We co

Re: [Qemu-devel] [PATCH 1/2] kvm/apic: use QOM style

2013-11-04 Thread Andreas Färber
Hi, Am 04.11.2013 07:41, schrieb 赵小强: > 于 09/27/2013 01:30 PM, xiaoqiang zhao 写道: >> From: "xiaoqiang.zhao" >> >> Change apic and kvm/apic to use QOM interface. >> >> Includes: >> 1. APICCommonState now use QOM realizefn >> 2. Remove DO_UPCAST() for APICCommonState >> 3. Use type constant >> 4. C

Re: [Qemu-devel] [patch] Fix FreeBSD compilation block/raw-posix.c

2013-11-04 Thread Stefan Hajnoczi
On Thu, Oct 31, 2013 at 10:41:46PM +0100, Andreas Tobler wrote: > Hi all, > > the below patch is needed to compile qemu trunk on FreeBSD with gcc48, > clang will fail ;). Host x84_64-freebsd. > > Installation will fail due to hardcoded /usr/bin/python in > scripts/acpi_extract.py > > Thanks,

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-04 Thread Alex Bennée
petar.jovano...@rt-rk.com writes: > From: Petar Jovanovic > > Creating target_structs header in linux-user/$arch/ and making > target_ipc_perm and target_shmid_ds its first inhabitants. > The struct defintions may/should be further fine-tuned by arch maintainers. > > Signed-off-by: Petar Jovanov

Re: [Qemu-devel] [PATCH v5 0/5] Fix UST backend for LTTng 2.x

2013-11-04 Thread Alex Bennée
mohamad.ge...@gmail.com writes: > Version 5 > > * Use pkg-config for lttng-ust and urcu-bp libraries in configure (hard-coded > libraries as a fallback) > * s/Qemu/QEMU in docs/tracing.txt > * Better dependencies for ust-generated files in trace/Makefile.obj Ping Stefan. Any more need doing

Re: [Qemu-devel] [PATCH v3] net: Adding netmap network backend

2013-11-04 Thread Stefan Hajnoczi
On Tue, Oct 29, 2013 at 11:12:25AM +0100, Vincenzo Maffione wrote: Looks pretty good, I think we can merge the next revision. > This patch only contains the simplest netmap backend for QEMU. > In particular, this backend implementation is still not > able to make use of batching on the TX side (f

Re: [Qemu-devel] [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS

2013-11-04 Thread Paolo Bonzini
Il 17/10/2013 16:47, Paolo Bonzini ha scritto: > Only the first item of the array was ever looked at. No > practical effect, but still worth fixing. > > Signed-off-by: Paolo Bonzini > --- > target-i386/kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target-i3

Re: [Qemu-devel] [Bug 1247796] [NEW] USB Passthrough not working for Windows 7 Embedded guest

2013-11-04 Thread Serge Hallyn
*** This bug is a duplicate of bug 685096 *** https://bugs.launchpad.net/bugs/685096 duplicate: 685096 ** This bug has been marked a duplicate of bug 685096 USB Passthrough not working for Windows 7 guest ** This bug has been marked a duplicate of bug 685096 USB Passthrough not worki

Re: [Qemu-devel] [PATCH 0/2 v2] pc: inform SeaBIOS where 64-bit PCI hole begins

2013-11-04 Thread Gerd Hoffmann
On Mo, 2013-11-04 at 15:35 +0100, Igor Mammedov wrote: > On Mon, 04 Nov 2013 13:48:03 +0100 > Gerd Hoffmann wrote: > > > Hi, > > > > > > So maybe design that with memory hotplug in mind? Such as adding a new > > > > qemu-specific type QEMU_RAM_HOTPLUG? Which seabios could use to reserve > >

Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap

2013-11-04 Thread Benoît Canet
Le Monday 04 Nov 2013 à 17:30:10 (+0800), Fam Zheng a écrit : > Previously a BlockDriverState has only one dirty bitmap, so only one > caller (e.g. a block job) can keep track of writing. This changes the > dirty bitmap to a list and creates a BdrvDirtyBitmap for each caller, the > lifecycle is man

Re: [Qemu-devel] [PATCH 0/2 v2] pc: inform SeaBIOS where 64-bit PCI hole begins

2013-11-04 Thread Igor Mammedov
On Mon, 04 Nov 2013 13:48:03 +0100 Gerd Hoffmann wrote: > Hi, > > > > So maybe design that with memory hotplug in mind? Such as adding a new > > > qemu-specific type QEMU_RAM_HOTPLUG? Which seabios could use to reserve > > > the memory (but not add it to the e820 table for the guest)? > > It

Re: [Qemu-devel] [PATCH] pc: disable acpi info for isapc and old pc machine

2013-11-04 Thread Michael S. Tsirkin
On Mon, Nov 04, 2013 at 03:13:50PM +0100, Paolo Bonzini wrote: > Il 04/11/2013 11:46, Michael S. Tsirkin ha scritto: > > Disable acpi build for isapc and no_kvmclock machine > > types (used by xen), since acpi build currently expects pci. > > > > Reported-by: Andreas Färber > > Signed-off-by: Mic

[Qemu-devel] [Bug 1247796] Re: USB Passthrough not working for Windows 7 Embedded guest

2013-11-04 Thread Jens Frederich
The bug occured on Ubuntu 13.04 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1247796 Title: USB Passthrough not working for Windows 7 Embedded guest Status in QEMU: New Bug description: USB

Re: [Qemu-devel] [PATCH] pc: disable acpi info for isapc and old pc machine

2013-11-04 Thread Paolo Bonzini
Il 04/11/2013 11:46, Michael S. Tsirkin ha scritto: > Disable acpi build for isapc and no_kvmclock machine > types (used by xen), since acpi build currently expects pci. > > Reported-by: Andreas Färber > Signed-off-by: Michael S. Tsirkin Wait, Xen is not using pc_init_pci_no_kvmclock. But that

Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out actual image size in 067

2013-11-04 Thread Stefan Hajnoczi
On Sat, Nov 02, 2013 at 02:52:11PM +0100, Max Reitz wrote: > The actual size of the image file may differ depending on the Linux > kernel currently running on the host. Filtering out this value makes > this test pass in such cases. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/067

[Qemu-devel] [PATCH] configure: Enable pie for powerpc and arm Linux

2013-11-04 Thread Dinar Valeev
From: Dinar Valeev This patch enables pie for PowerPC and ARM architectures Signed-off-by: Dinar Valeev --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 91372f9..0130e7e 100755 --- a/configure +++ b/configure @@ -1297,7 +1297,7 @@ fi

Re: [Qemu-devel] [PATCH] qemu: Broken -smb with latest SAMBA package. (Unsupported security=share option)

2013-11-04 Thread Jan Kiszka
On 2013-11-04 14:55, Michael Tokarev wrote: > 04.11.2013 00:06, Jan Kiszka wrote: >> On 2013-11-01 11:10, Michael Tokarev wrote: > [] >>> If Jan picks it up, that's fine. If not, I think it can go >>> to the trivial patches queue. >> >> Works fine, applied to queues/slirp. > > Okay, thank you Jan

[Qemu-devel] [Bug 1247796] [NEW] USB Passthrough not working for Windows 7 Embedded guest

2013-11-04 Thread Jens Frederich
Public bug reported: USB Passthrough from host to guest is not working for a 32-bit Windows 7 guest. The device appears in the device manager of Windows 7, but with "Error code 10: device cannot start". I have tried this with numerous USB thumbdrives and a USB wireless NIC, all with the same resu

Re: [Qemu-devel] [PATCH] migration: avoid starting a new migration task while the previous one still exist

2013-11-04 Thread Eric Blake
On 11/04/2013 04:26 AM, Zhanghaoyu (A) wrote: > Avoid starting a new migration task while the previous one still exist. > > Signed-off-by: Zeng Junliang > --- It's best to put comments here... > migration.c | 34 ++ > 1 files changed, 22 insertions(+), 12 dele

Re: [Qemu-devel] [PATCH] qemu: Broken -smb with latest SAMBA package. (Unsupported security=share option)

2013-11-04 Thread Michael Tokarev
04.11.2013 00:06, Jan Kiszka wrote: On 2013-11-01 11:10, Michael Tokarev wrote: [] If Jan picks it up, that's fine. If not, I think it can go to the trivial patches queue. Works fine, applied to queues/slirp. Okay, thank you Jan. But this is not a trivial patch as the fix is not obvious

Re: [Qemu-devel] [PATCH] kvm: Add a new machine property kvm_type

2013-11-04 Thread Alexander Graf
On 04.11.2013, at 14:32, Jan Kiszka wrote: > On 2013-11-04 14:30, Alexander Graf wrote: >> >> On 04.11.2013, at 14:28, Jan Kiszka wrote: >> >>> On 2013-10-07 18:53, Aneesh Kumar K.V wrote: From: "Aneesh Kumar K.V" Targets like ppc64 support different typed of KVM, one which u

Re: [Qemu-devel] How to introduce bs->node_name ?

2013-11-04 Thread Luiz Capitulino
On Mon, 4 Nov 2013 12:13:59 +0100 Kevin Wolf wrote: > Am 01.11.2013 um 16:12 hat Luiz Capitulino geschrieben: > > On Fri, 01 Nov 2013 08:59:20 -0600 > > Eric Blake wrote: > > > > > On 11/01/2013 08:51 AM, Luiz Capitulino wrote: > > > > On Wed, 30 Oct 2013 13:25:35 -0600 > > > > Eric Blake wrot

[Qemu-devel] [PULL 3/3] vl: allow "cont" from panicked state

2013-11-04 Thread Michael S. Tsirkin
From: Paolo Bonzini After reporting the GUEST_PANICKED monitor event, QEMU stops the VM. The reason for this is that events are edge-triggered, and can be lost if management dies at the wrong time. Stopping a panicked VM lets management know of a panic even if it has crashed; management can lear

[Qemu-devel] [PULL 1/3] pc: disable acpi info for isapc and old pc machine

2013-11-04 Thread Michael S. Tsirkin
Disable acpi build for isapc and no_kvmclock machine types (used by xen), since acpi build currently expects pci. Reported-by: Andreas Färber Signed-off-by: Michael S. Tsirkin Reviewed-by: Paolo Bonzini --- hw/i386/pc_piix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/pc_piix

[Qemu-devel] [PULL 2/3] exec: limit system memory size

2013-11-04 Thread Michael S. Tsirkin
The page table logic in exec.c assumes that memory addresses are at most TARGET_PHYS_ADDR_SPACE_BITS. But pci addresses are full 64 bit so if we try to render them ignoring the extra bits, we get strange effects with sections overlapping each other. To fix, simply limit the system memory size to

[Qemu-devel] savevm speed [was: Re: Qemu-devel Digest, Vol 128, Issue 24]

2013-11-04 Thread Eric Blake
On 11/03/2013 07:41 AM, 宫文超 wrote: > > Top-posted replies to an untrimmed digest message and with an irrelevant subject line are considered poor netiquette. > > > When i use the savevm command to create a online snapshot i found it's very > very slow,i found the online snapshot save four dev

  1   2   >