Re: [Qemu-devel] [PATCH v1 2/2] Revert error: Don't use error_report() for assertion msgs.

2014-01-30 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 15 January 2014 11:06, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: This reverts commit d32934c84c72f57e78d430c22974677b7bcabe5d. The original implementation before this patch makes abortive error messages much more friendly. The

Re: [Qemu-devel] [PATCHv7 1/5] block: add native support for NFS

2014-01-30 Thread Stefan Hajnoczi
On Wed, Jan 29, 2014 at 05:38:29PM +0100, Peter Lieven wrote: On 29.01.2014 17:19, Benoît Canet wrote: Le Wednesday 29 Jan 2014 à 09:50:21 (+0100), Peter Lieven a écrit : This patch adds native support for accessing images on NFS shares without the requirement to actually mount the entire NFS

Re: [Qemu-devel] printf in qemu

2014-01-30 Thread Stefan Hajnoczi
On Thu, Jan 30, 2014 at 12:16:26PM +0500, Ayaz Akram wrote: I observed that if i place printf in qemu at certain places like in hw./serial.c file, I can see the printing when my guest OS is running on qemu, while there are some other places like in pckbd.c (emulation of keyboard), where if

Re: [Qemu-devel] [PATCHv7 1/5] block: add native support for NFS

2014-01-30 Thread Peter Lieven
Am 30.01.2014 um 10:05 schrieb Stefan Hajnoczi stefa...@gmail.com: On Wed, Jan 29, 2014 at 05:38:29PM +0100, Peter Lieven wrote: On 29.01.2014 17:19, Benoît Canet wrote: Le Wednesday 29 Jan 2014 à 09:50:21 (+0100), Peter Lieven a écrit : This patch adds native support for accessing images on

Re: [Qemu-devel] [RFC PATCH v0 2/2] gluster: Remove unused defines and header include

2014-01-30 Thread Stefan Hajnoczi
On Wed, Jan 29, 2014 at 07:59:56PM +0530, Bharata B Rao wrote: Remove the definitions of GLUSTER_FD_WRITE and GLUSTER_FD_READ which are no longer used. Also sockets.h isn't needed any more. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- block/gluster.c | 4 1 file

Re: [Qemu-devel] [RFC PATCH v0 1/2] gluster: Change licence to GPLv2+

2014-01-30 Thread Stefan Hajnoczi
On Wed, Jan 29, 2014 at 07:59:55PM +0530, Bharata B Rao wrote: Pipe handling mechanism in gluster driver was based on similar implementation in RBD driver and hence had GPLv2 and associated copyright information. After changing gluster driver to coroutine based implementation, the pipe

Re: [Qemu-devel] [PATCH] block/vhdx: Error checking fixes

2014-01-30 Thread Stefan Hajnoczi
On Wed, Jan 29, 2014 at 06:05:08PM +0100, Markus Armbruster wrote: Errors are inadvertently ignored in a few places. Has always been broken. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com --- block/vhdx-log.c | 4 ++-- block/vhdx.c | 8 2 files

Re: [Qemu-devel] [PATCH v6 4/5] Update documentation for LTTng ust tracing

2014-01-30 Thread Alex Bennée
mohamad.ge...@gmail.com writes: Signed-off-by: Mohamad Gebai mohamad.ge...@polymtl.ca --- docs/tracing.txt | 36 1 file changed, 36 insertions(+) snip Reviewed-by: Alex Bennée alex.ben...@linaro.org -- Alex Bennée

[Qemu-devel] [PATCH v2 2/3] Add 'debug-threads' suboption to --name

2014-01-30 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com Add flag storage to qemu-thread-* to store the namethreads flag Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com --- include/qemu/thread.h| 1 + qemu-options.hx | 7 +-- util/qemu-thread-posix.c | 7 +++

[Qemu-devel] [PATCH v2 3/3] Add a 'name' parameter to qemu_thread_create

2014-01-30 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com If enabled, set the thread name at creation (on GNU systems with pthread_set_np) Fix up all the callers with a thread name Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com --- cpus.c | 25

[Qemu-devel] [PATCH v2 0/3] Name threads

2014-01-30 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com This series uses pthread_setname_np (when available) to set the names on threads that QEMU creates to make life easier when debugging. It's turned off by default (because there were worries that it might break tools that relied on process names)

[Qemu-devel] [PATCH v2 1/3] Rework --name to use QemuOpts

2014-01-30 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com Reviewed-by: Alex Bennée alex.ben...@linaro.org --- vl.c | 52 +++- 1 file changed, 39 insertions(+), 13 deletions(-) diff --git a/vl.c

Re: [Qemu-devel] [PATCH target-arm v4 1/1] target-arm: Implements the ARM PMCCNTR register

2014-01-30 Thread Peter Maydell
On 30 January 2014 07:00, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Wed, Jan 29, 2014 at 10:28 PM, Peter Maydell peter.mayd...@linaro.org wrote: This will break migration. You must provide a mechanism for the migration to do a read register on source end; write value to register

[Qemu-devel] [PATCH] qapi: Fix licensing of scripts

2014-01-30 Thread Markus Armbruster
The scripts carry this copyright notice: # This work is licensed under the terms of the GNU GPLv2. # See the COPYING.LIB file in the top-level directory. The sentences contradict each other, as COPYING.LIB contains the LGPL 2.1. Michael Roth says this was a simple pasto, and he meant to

Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event

2014-01-30 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 16/01/2014 03:50, Michael Roth ha scritto: If we go to that effort, it may make sense to try to re-license to GPLv2+ while we're at it, but either way I think this should be done as a separate patchset, and shouldn't hold up Wenchao's series. I can

Re: [Qemu-devel] [PATCH] qapi: Fix licensing of scripts

2014-01-30 Thread Peter Maydell
On 30 January 2014 10:34, Markus Armbruster arm...@redhat.com wrote: The scripts carry this copyright notice: # This work is licensed under the terms of the GNU GPLv2. # See the COPYING.LIB file in the top-level directory. The sentences contradict each other, as COPYING.LIB contains

Re: [Qemu-devel] [PATCH] qapi: Fix licensing of scripts

2014-01-30 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 30 January 2014 10:34, Markus Armbruster arm...@redhat.com wrote: The scripts carry this copyright notice: # This work is licensed under the terms of the GNU GPLv2. # See the COPYING.LIB file in the top-level directory. The

Re: [Qemu-devel] [PATCH v2 4/4] hw:piix4:acpi: reuse pcihp code for legacy PCI hotplug

2014-01-30 Thread Michael S. Tsirkin
On Mon, Jan 27, 2014 at 04:39:55PM +0100, Igor Mammedov wrote: reduces acpi PCI hotplug code duplication by ~150LOC, and makes pcihp less dependend on piix specific code. Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: - replace obsolete 'device_present' with 'up' field -

Re: [Qemu-devel] [PATCH v2 3/4] pcihp: make pci_read() mmio calback compatible with legacy ACPI hotplug

2014-01-30 Thread Michael S. Tsirkin
On Mon, Jan 27, 2014 at 04:39:54PM +0100, Igor Mammedov wrote: due to recent change introduced by: pcihp: reduce number of device check events 'up' field is cleared right after it's read. This is incompatible with legacy BIOS ACPI code where PCNF ACPI method reads this field 32 times. To

Re: [Qemu-devel] pxe boot problems

2014-01-30 Thread Laszlo Ersek
On 01/30/14 07:37, Dietmar Maurer wrote: Does it work with TCG? It simply hangs a bit later if I use TCG, without any output on the console. Strange. How recent qemu happens this with? The relevant emulation code (under ljmp Ev in target-i386/translate.c) has been changed as recently as

[Qemu-devel] [PATCH] exec: fix ram_list dirty map optimization

2014-01-30 Thread Alexey Kardashevskiy
The ae2810c4bb3b383176e8e1b33931b16c01483aab patch introduced optimization for ram_list.dirty_memory update. However it can only work correctly if hpratio is 1 as the @bitmap parameter stores 1 bits per system page size (may vary, 4K or 64K on PPC64) and ram_list.dirty_memory stores 1 bit per

Re: [Qemu-devel] [PATCH] Revert memory: syncronize kvm bitmap using bitmaps operations

2014-01-30 Thread Alexey Kardashevskiy
On 01/29/2014 09:03 PM, Paolo Bonzini wrote: Il 29/01/2014 09:12, Alexey Kardashevskiy ha scritto: On 01/29/2014 06:30 PM, Paolo Bonzini wrote: Il 29/01/2014 06:50, Alexey Kardashevskiy ha scritto: Since 64K system page size is quite popular configuration on PPC64, the original patch breaks

Re: [Qemu-devel] check trim/unmap

2014-01-30 Thread ching
My updated config is Gentoo x64 stable branch, kernel 3.10, libvirt 1.2.1, qemu 1.7.0, lvm2(non-thin) on ssd i attach a lvm (non-thin) partition to a vm disk type='block' device='disk' driver name='qemu' type='raw' cache='none' io='native' discard='unmap'/ source

[Qemu-devel] [PATCH v3 3/9] ide: Don't block-align IDEState member smart_selftest_data

2014-01-30 Thread Markus Armbruster
All uses are simple array subscripts. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index dcfd92d..6aaf6fa 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2164,8 +2164,7

[Qemu-devel] [PATCH v3 5/9] ide: Drop redundant IDEState geometry members

2014-01-30 Thread Markus Armbruster
Members cylinders, heads, sectors, chs_trans are copies of dev-conf.cyls, dev-conf.heads, dev-conf.secs, dev-chs_trans. Copies were needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copies (it only cleared the copy of bs). Begs the

[Qemu-devel] [PATCH v3 4/9] ide: Drop redundant IDEState member bs

2014-01-30 Thread Markus Armbruster
It's a copy of dev-conf.bs. The copy was needed for non-qdevified controllers, which lacked dev. Note how pci_piix3_xen_ide_unplug() cleared the copy. We'll get back to that in the next few commits. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/ahci.c | 11 +-

[Qemu-devel] [PATCH v3 6/9] ide: Drop redundant IDEState member version

2014-01-30 Thread Markus Armbruster
It's a copy of dev-version. The copy was needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copy (it only cleared the copy of bs). Begs the question whether stale data could have been used after unplug. As far as I can tell, the copy

[Qemu-devel] [PATCH v3 2/9] ide: Use IDEState member dev for device connected test

2014-01-30 Thread Markus Armbruster
Testing dev is more obvious than testing bs, in my opinion. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/ahci.c | 8 hw/ide/core.c | 56 - hw/ide/microdrive.c | 2 +- hw/ide/qdev.c | 2 +- 4 files

[Qemu-devel] [PATCH v3 8/9] ide: Drop redundant IDEState member model

2014-01-30 Thread Markus Armbruster
It's a copy of dev-serial. The copy was needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copy (it only cleared the copy of bs). Begs the question whether stale data could have been used after unplug. As far as I can tell, the copy

[Qemu-devel] [PATCH v3 7/9] ide: Drop redundant IDEState member drive_serial_str

2014-01-30 Thread Markus Armbruster
It's a copy of dev-serial. The copy was needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copy (it only cleared the copy of bs). Begs the question whether stale data could have been used after unplug. As far as I can tell, the copy

Re: [Qemu-devel] [PATCH v2 4/4] hw:piix4:acpi: reuse pcihp code for legacy PCI hotplug

2014-01-30 Thread Igor Mammedov
On Thu, 30 Jan 2014 13:25:39 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Jan 27, 2014 at 04:39:55PM +0100, Igor Mammedov wrote: reduces acpi PCI hotplug code duplication by ~150LOC, and makes pcihp less dependend on piix specific code. Signed-off-by: Igor Mammedov

[Qemu-devel] [PATCH v3 9/9] ide: Drop redundant IDEState member wwn

2014-01-30 Thread Markus Armbruster
It's a copy of dev-wwn. The copy was needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copy (it only cleared the copy of bs). Begs the question whether stale data could have been used after unplug. As far as I can tell, the copy was

[Qemu-devel] [PATCH v3 0/9] Clean up IDE after completion of qdevification

2014-01-30 Thread Markus Armbruster
Obvious cleanups possible since we no longer have the special case of a non-qdevified controller. Andreas liked v2 well enough, but felt it's more like a block topic. Kevin, Stefan, would you be willing to take this series through the block tree? v3: * Trivially rebased. v2: * Dropped PATCH 1/10

[Qemu-devel] [PATCH v3 1/9] ide: Move IDEDevice pointer from IDEBus to IDEState

2014-01-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/core.c | 2 +- hw/ide/internal.h | 3 +-- hw/ide/qdev.c | 12 +++- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 036cd4a..9087025 100644 --- a/hw/ide/core.c +++

[Qemu-devel] [PATCH] address_space_translate: do not cross page boundaries

2014-01-30 Thread Stefano Stabellini
The following commit: commit 149f54b53b7666a3facd45e86eece60ce7d3b114 Author: Paolo Bonzini pbonz...@redhat.com Date: Fri May 24 12:59:37 2013 +0200 memory: add address_space_translate breaks Xen support in QEMU, in particular the Xen mapcache. The effect is that one Windows XP

Re: [Qemu-devel] [BUG] BSoD on Windows XP installation

2014-01-30 Thread Stefano Stabellini
On Wed, 29 Jan 2014, Paolo Bonzini wrote: Il 29/01/2014 13:00, Stefano Stabellini ha scritto: Hi Paolo, we have been trying to fix a BSOD that would happen during the Windows XP installation, once every ten times on average. After many days of bisection, we found out that commit

Re: [Qemu-devel] [PATCH v3] virtio: Introduce virtio-testdev

2014-01-30 Thread Mike Day
Andrew Jones drjo...@redhat.com writes: This is a virtio version of hw/misc/debugexit and should evolve into a virtio version of pc-testdev. pc-testdev uses the PC's ISA bus, whereas this testdev can be plugged into a virtio-mmio transport, which is needed for kvm-unit-tests/arm.

Re: [Qemu-devel] [PATCH v3] virtio: Introduce virtio-testdev

2014-01-30 Thread Andrew Jones
On Thu, Jan 30, 2014 at 07:44:59AM -0500, Mike Day wrote: Andrew Jones drjo...@redhat.com writes: This is a virtio version of hw/misc/debugexit and should evolve into a virtio version of pc-testdev. pc-testdev uses the PC's ISA bus, whereas this testdev can be plugged into a virtio-mmio

Re: [Qemu-devel] [PATCH v2 0/3] Name threads

2014-01-30 Thread Eric Blake
On 01/30/2014 03:20 AM, Dr. David Alan Gilbert (git) wrote: The first patch converts --name to use QemuOpts, a side effect of this is that --name process=foo,bar no longer allows a process name of 'foo,bar', since ',' is a separator. Just to make sure I understand correctly, am I right that

Re: [Qemu-devel] [PATCH v2 0/3] Name threads

2014-01-30 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: On 01/30/2014 03:20 AM, Dr. David Alan Gilbert (git) wrote: The first patch converts --name to use QemuOpts, a side effect of this is that --name process=foo,bar no longer allows a process name of 'foo,bar', since ',' is a separator. Just to

[Qemu-devel] [PATCH] block: handle rechs translation option

2014-01-30 Thread Paolo Bonzini
The rechs translation option is so obscure that we support it but do not even attempt to parse it. Archeologists will surely be puzzled by this (assuming they care about QEMU and CHS translation), so fix it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- blockdev.c | 2 ++ vl.c |

[Qemu-devel] [PATCH 01/12] qapi: add size parser to StringInputVisitor

2014-01-30 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qapi/string-input-visitor.c | 24 1 file changed, 24 insertions(+) diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c index 8f1bc41..793548a 100644 --- a/qapi/string-input-visitor.c +++

[Qemu-devel] [PATCH 05/12] qdev: legacy properties are just strings

2014-01-30 Thread Paolo Bonzini
prop-info-legacy_name is still used by -device foo,?. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 7c1b732..482a978 100644 --- a/hw/core/qdev.c +++

Re: [Qemu-devel] [PATCH v2 4/4] hw:piix4:acpi: reuse pcihp code for legacy PCI hotplug

2014-01-30 Thread Michael S. Tsirkin
On Thu, Jan 30, 2014 at 01:20:12PM +0100, Igor Mammedov wrote: On Thu, 30 Jan 2014 13:25:39 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Jan 27, 2014 at 04:39:55PM +0100, Igor Mammedov wrote: reduces acpi PCI hotplug code duplication by ~150LOC, and makes pcihp less

[Qemu-devel] [PATCH 04/12] qdev: legacy properties are now read-only

2014-01-30 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev-properties.c | 10 +- hw/core/qdev.c| 30 ++ include/hw/qdev-core.h| 1 - 3 files changed, 3 insertions(+), 38 deletions(-) diff --git a/hw/core/qdev-properties.c

[Qemu-devel] [PATCH 00/12] qdev: cleanup legacy properties

2014-01-30 Thread Paolo Bonzini
The conversion of qdev to QOM brought with it legacy properties. Legacy properties are always have a string type (the accessors always call visit_type_str), and were used to support -device syntax while keeping QOM properties strongly typed. For example, an hex8 property is registered twice, once

[Qemu-devel] [PATCH 02/12] qdev: sizes are now parsed by StringInputVisitor

2014-01-30 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev-properties.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index b949f0e..da37710 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@

[Qemu-devel] [PATCH 12/12] qdev: use QAPI type names for properties

2014-01-30 Thread Paolo Bonzini
Use drive, chr, etc. only for legacy_name (which shows up in -device foo,? output). From the point of view of their type, these are just strings. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev-properties-system.c | 12 hw/core/qdev-properties.c| 18

[Qemu-devel] [PATCH 10/12] qdev: remove hex8/32/64 property types

2014-01-30 Thread Paolo Bonzini
Replace them with uint8/32/64. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/audio/adlib.c | 2 +- hw/audio/cs4231a.c | 2 +- hw/audio/gus.c | 2 +- hw/audio/pcspk.c | 2 +- hw/audio/sb16.c | 4 ++-- hw/block/fdc.c

[Qemu-devel] [PATCH 03/12] qdev: remove legacy parsers for hex8/32/64

2014-01-30 Thread Paolo Bonzini
The hexNN property types have not been accepting values not prefixed by 0x since QEMU 1.2. Parse those values as decimals now. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev-properties.c | 54 --- 1 file changed, 54 deletions(-)

[Qemu-devel] [PATCH 11/12] qdev: add enum property types to QAPI schema

2014-01-30 Thread Paolo Bonzini
Prepare for when QOM introspection will be able to piggyback on the QAPI schema for describing property types. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev-properties.c | 18 +++ hw/i386/kvm/i8254.c | 6 ++--- hw/timer/mc146818rtc.c| 14 ++--

[Qemu-devel] [PATCH 07/12] qapi: add human mode to StringOutputVisitor

2014-01-30 Thread Paolo Bonzini
This will be used by info qtree. For numbers it prints both the decimal and hex values. For sizes it rounds to the nearest power of 2^10. For strings, it puts quotes around the string and separates NULL and empty string. Signed-off-by: Paolo Bonzini pbonz...@redhat.com ---

Re: [Qemu-devel] [PATCH v2] qemu-upstream: add discard support for xen_disk

2014-01-30 Thread Stefano Stabellini
On Thu, 30 Jan 2014, Olaf Hering wrote: Implement discard support for xen_disk. It makes use of the existing discard code in qemu. The discard support is enabled unconditionally. The tool stack may provide a property discard_enable in the backend node to optionally disable discard support.

[Qemu-devel] [PATCH 08/12] qdev: use human mode in info qtree

2014-01-30 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qdev-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index f385fb3..b37778f 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -577,7 +577,7 @@ static void qdev_print_props(Monitor

Re: [Qemu-devel] [PATCH] address_space_translate: do not cross page boundaries

2014-01-30 Thread Paolo Bonzini
Il 30/01/2014 13:46, Stefano Stabellini ha scritto: The following commit: commit 149f54b53b7666a3facd45e86eece60ce7d3b114 Author: Paolo Bonzini pbonz...@redhat.com Date: Fri May 24 12:59:37 2013 +0200 memory: add address_space_translate breaks Xen support in QEMU, in particular the Xen

[Qemu-devel] [PATCH 06/12] qdev: inline qdev_prop_parse

2014-01-30 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev-properties.c| 8 +--- include/hw/qdev-properties.h | 2 -- qdev-monitor.c | 4 ++-- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index

Re: [Qemu-devel] [PATCH 01/12] qapi: add size parser to StringInputVisitor

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qapi/string-input-visitor.c | 24 1 file changed, 24 insertions(+) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266

Re: [Qemu-devel] [PATCH 02/12] qdev: sizes are now parsed by StringInputVisitor

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev-properties.c | 11 --- 1 file changed, 11 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [Qemu-devel] [PATCH 03/12] qdev: remove legacy parsers for hex8/32/64

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: The hexNN property types have not been accepting values not prefixed by 0x since QEMU 1.2. Parse those values as decimals now. It also adds parsing of hex prefixed with 0X - probably also worth mentioning in the commit message. Signed-off-by:

Re: [Qemu-devel] [PATCH 04/12] qdev: legacy properties are now read-only

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev-properties.c | 10 +- hw/core/qdev.c| 30 ++ include/hw/qdev-core.h| 1 - 3 files changed, 3 insertions(+), 38 deletions(-)

Re: [Qemu-devel] [PATCH 05/12] qdev: legacy properties are just strings

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: prop-info-legacy_name is still used by -device foo,?. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake

Re: [Qemu-devel] [PATCH 06/12] qdev: inline qdev_prop_parse

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev-properties.c| 8 +--- include/hw/qdev-properties.h | 2 -- qdev-monitor.c | 4 ++-- 3 files changed, 3 insertions(+), 11 deletions(-) Reviewed-by: Eric

[Qemu-devel] [PATCH 09/12] qdev: remove most legacy printers

2014-01-30 Thread Paolo Bonzini
Their functionality is either aesthetic only (e.g. on/off vs. true/false) or obtained by the human mode of StringOutputVisitor. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev-properties.c | 60 --- 1 file changed, 60 deletions(-)

[Qemu-devel] [PATCH] libcacard: Don't link with all libraries QEMU links to

2014-01-30 Thread Christophe Fergeau
As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 , libcacard currently links to all the libraries QEMU is linking to, including glusterfs libraries, libiscsi, ... libcacard does not need all of these. This patch ensures it's only linked with the libraries it needs.

Re: [Qemu-devel] [PATCH] TCG: Fix I64-on-32bit-host temporaries

2014-01-30 Thread Peter Maydell
On 19 January 2014 15:53, Alexander Graf ag...@suse.de wrote: We have cache pools of temporaries that we can reuse later when they've already been allocated before. These cache pools differenciate between the target TCG variable type they contain. So we have one pool for I32 and one pool for

Re: [Qemu-devel] [PATCH v6 0/5] Fix UST backend for LTTng 2.x

2014-01-30 Thread Stefan Hajnoczi
On Wed, Jan 29, 2014 at 10:47:53PM -0500, Mohamad Gebai wrote: Version 6 * Move ust specific code from tracetool/backend/events.py to tracetool/backend/ust.py Mohamad Gebai (5): Fix configure script for LTTng 2.x Modified the tracetool framework for LTTng 2.x Adapt Makefiles to

[Qemu-devel] Query Regarding Device Tree Support in QEMU

2014-01-30 Thread rajan pathak
Hello All, I have some Query regarding Device tree support in QEMU. I have gone through for OMAP qemu emulation and noticed a lots of effort has been gone for manually mapping the Register set and Hardware representaion into Device emulation. Inside include/hw/arm/omap.h lots of code is taken

[Qemu-devel] [PATCH] Use error_is_set() only when necessary

2014-01-30 Thread Markus Armbruster
error_is_set(var) is the same as var != NULL, but it takes whole-program analysis to figure that out. Unnecessarily hard for optimizers, static checkers, and human readers. Dumb it down to obvious. Gets rid of several dozen Coverity false positives. Note that the obvious form is already used

Re: [Qemu-devel] [PATCH 07/12] qapi: add human mode to StringOutputVisitor

2014-01-30 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 30/01/2014 15:09, Eric Blake ha scritto: | Also, I like how your int printout was both decimal and hex; but | here you are throwing away information (and the bigger the number, | the more we lose as to how much got rounded away). I'd rather see |

Re: [Qemu-devel] [PULL 0/3] xen-170114

2014-01-30 Thread Stefano Stabellini
ping? On Fri, 17 Jan 2014, Stefano Stabellini wrote: The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c: SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000) are available in the git repository at:

Re: [Qemu-devel] [PATCHv7 1/5] block: add native support for NFS

2014-01-30 Thread Stefan Hajnoczi
On Wed, Jan 29, 2014 at 05:19:59PM +0100, Benoît Canet wrote: Le Wednesday 29 Jan 2014 à 09:50:21 (+0100), Peter Lieven a écrit : Hi Peter, If I read your reply to Benoit correctly, you only addressed the questions about nfs_client_close(). Here are Benoits other comments and my thoughts on

Re: [Qemu-devel] [PATCH 07/12] qapi: add human mode to StringOutputVisitor

2014-01-30 Thread Eric Blake
On 01/30/2014 07:12 AM, Paolo Bonzini wrote: Il 30/01/2014 15:09, Eric Blake ha scritto: | Also, I like how your int printout was both decimal and hex; but | here you are throwing away information (and the bigger the number, | the more we lose as to how much got rounded away). I'd rather see

Re: [Qemu-devel] [PATCHv7 1/5] block: add native support for NFS

2014-01-30 Thread Stefan Hajnoczi
On Thu, Jan 30, 2014 at 10:12:35AM +0100, Peter Lieven wrote: Am 30.01.2014 um 10:05 schrieb Stefan Hajnoczi stefa...@gmail.com: On Wed, Jan 29, 2014 at 05:38:29PM +0100, Peter Lieven wrote: On 29.01.2014 17:19, Benoît Canet wrote: Le Wednesday 29 Jan 2014 à 09:50:21 (+0100), Peter

[Qemu-devel] [PULL 1/1] address_space_translate: do not cross page boundaries

2014-01-30 Thread Stefano Stabellini
From: Stefano Stabellini stefano.stabell...@eu.citrix.com The following commit: commit 149f54b53b7666a3facd45e86eece60ce7d3b114 Author: Paolo Bonzini pbonz...@redhat.com Date: Fri May 24 12:59:37 2013 +0200 memory: add address_space_translate breaks Xen support in QEMU, in particular the

[Qemu-devel] [PULL 0/1] xen-140130

2014-01-30 Thread Stefano Stabellini
The following changes since commit 0169c511554cb0014a00290b0d3d26c31a49818f: Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2014-01-24 15:52:44 -0800) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-140130 for you to fetch

Re: [Qemu-devel] OSX guest vs. kvm ioapic polarity

2014-01-30 Thread Gabriel L. Somlo
On Thu, Jan 30, 2014 at 12:18:17AM +0200, Michael S. Tsirkin wrote: OS X will boot fine with the one-liner KVM patch removing the statement: irq_level ^= entry.fields.polarity; regardless of how LNK*._PRS is configured, and will hang without the patch, also regardless of

Re: [Qemu-devel] [PATCH] block: handle rechs translation option

2014-01-30 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: The rechs translation option is so obscure that we support it but do Support is a rather strong word: $ git-grep -i rechs include/hw/block/block.h:#define BIOS_ATA_TRANSLATION_RECHS 4 not even attempt to parse it. Archeologists will surely

Re: [Qemu-devel] [PATCH] block: handle rechs translation option

2014-01-30 Thread Stefan Hajnoczi
On Thu, Jan 30, 2014 at 02:08:02PM +0100, Paolo Bonzini wrote: The rechs translation option is so obscure that we support it but do not even attempt to parse it. Archeologists will surely be puzzled by this (assuming they care about QEMU and CHS translation), so fix it. Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH 07/12] qapi: add human mode to StringOutputVisitor

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: This will be used by info qtree. For numbers it prints both the decimal and hex values. For sizes it rounds to the nearest power of 2^10. For strings, it puts quotes around the string and separates NULL and empty string. Nice idea! But needs a

Re: [Qemu-devel] [PATCH] block: handle rechs translation option

2014-01-30 Thread Paolo Bonzini
Il 30/01/2014 15:37, Markus Armbruster ha scritto: Paolo Bonzini pbonz...@redhat.com writes: The rechs translation option is so obscure that we support it but do Support is a rather strong word: $ git-grep -i rechs include/hw/block/block.h:#define BIOS_ATA_TRANSLATION_RECHS 4 As

Re: [Qemu-devel] [PULL 00/11] Trivial patches for 2014-01-16

2014-01-30 Thread Peter Maydell
On 16 January 2014 17:35, Michael Tokarev m...@tls.msk.ru wrote: There's nothing exciting in there, but we have some small bugfixes here and there, and a few cosmetic changes too. This is my first signed pull request too, based on my regular GnuPG key which I use to sign Debian packages.

[Qemu-devel] [PATCH RFC 1/5] hw/core: introduced qemu machine as QOM object

2014-01-30 Thread Marcel Apfelbaum
The main functionality change is to convert QEMUMachine into QemuMachineClass and QEMUMachineInitArgs into QemuMachineState, instance of QemuMachineClass. As a first step, in order to make possible an incremental developement, both QEMUMachine and QEMUMachineInitArgs are being embeded into the

[Qemu-devel] [PATCH RFC 0/5] qemu-machine as a QOM object

2014-01-30 Thread Marcel Apfelbaum
This is an early RFC, the work is in very early stages, I am interested to know if there is a consensus that this is the right path. The main benefit of QOMifying the qemu machine would be the possibility to have options per machine type and not global. However, there are other benefits as: -

[Qemu-devel] [PATCH RFC 4/5] hw/machine: add qemu machine opts as properties to QemuMachineState

2014-01-30 Thread Marcel Apfelbaum
It is cleaner to query current_machine's properties than accessing QemuOpts from the code. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/core/machine.c | 251 include/hw/boards.h | 15 2 files changed, 266 insertions(+)

[Qemu-devel] [PATCH RFC 2/5] vl: use qemu machine QOM class instead of global machines list

2014-01-30 Thread Marcel Apfelbaum
The machine registration flow is refactored to use the QOM functionality. Instead of linking the machines into a list, each machine has a type and the types can be traversed in the QOM way. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- vl.c | 75

[Qemu-devel] [PATCH RFC 3/5] hw/boards: converted current_machine to be an instance of QemuMachineCLass

2014-01-30 Thread Marcel Apfelbaum
In order to allow attaching machine options to a machine instance, current_machine is converted into QemuMachineState. As a first step of deprecating QEMUMachine, some of the functions were modified to return QemuMachineCLass. Signed-off-by: Marcel Apfelbaum marce...@redhat.com ---

[Qemu-devel] [PATCH RFC 5/5] vl.c: set current_machine's properties

2014-01-30 Thread Marcel Apfelbaum
Setting machine's properties provides a cleaner way to get the properties values than using QemuOpts. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- vl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/vl.c b/vl.c index 4f4722e..fcd56db 100644 --- a/vl.c +++ b/vl.c @@ -4307,6

Re: [Qemu-devel] [PATCH] libcacard: Don't link with all libraries QEMU links to

2014-01-30 Thread Alon Levy
On 01/30/2014 03:56 PM, Christophe Fergeau wrote: Acked-by: Alon Levy al...@redhat.com As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 , libcacard currently links to all the libraries QEMU is linking to, including glusterfs libraries, libiscsi, ... libcacard does not need

Re: [Qemu-devel] [PATCH 08/12] qdev: use human mode in info qtree

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qdev-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake ebl...@redhat.com -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization

[Qemu-devel] [PULL 1/1] libcacard: Don't link with all libraries QEMU links to

2014-01-30 Thread Alon Levy
From: Christophe Fergeau cferg...@redhat.com As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 , libcacard currently links to all the libraries QEMU is linking to, including glusterfs libraries, libiscsi, ... libcacard does not need all of these. This patch ensures it's only

[Qemu-devel] [PULL 0/1] libcacard glusterfs fix

2014-01-30 Thread Alon Levy
The following changes since commit 0706f7c85b3c0783f92d44b551f362884db0f4bd: Merge remote-tracking branch 'mjt/tags/trivial-patches-2014-01-16' into staging (2014-01-30 13:56:00 +) are available in the git repository at: git://people.freedesktop.org/~alon/qemu pull-libcacard.glusterfs

Re: [Qemu-devel] [PATCH 09/12] qdev: remove most legacy printers

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: Their functionality is either aesthetic only (e.g. on/off vs. true/false) or obtained by the human mode of StringOutputVisitor. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev-properties.c | 60

Re: [Qemu-devel] Query Regarding Device Tree Support in QEMU

2014-01-30 Thread Peter Maydell
On 30 January 2014 14:11, rajan pathak rajanpath...@gmail.com wrote: I have some Query regarding Device tree support in QEMU. I have gone through for OMAP qemu emulation and noticed a lots of effort has been gone for manually mapping the Register set and Hardware representaion into Device

Re: [Qemu-devel] [PATCH 10/12] qdev: remove hex8/32/64 property types

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: Replace them with uint8/32/64. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Reviewed-by: Eric Blake ebl...@redhat.com +++ b/hw/audio/pcspk.c @@ -181,7 +181,7 @@ static void pcspk_realizefn(DeviceState *dev, Error **errp) }

Re: [Qemu-devel] [PATCH] xen_disk: add discard support

2014-01-30 Thread Stefano Stabellini
On Thu, 30 Jan 2014, Olaf Hering wrote: Implement discard support for xen_disk. It makes use of the existing discard code in qemu. The discard support is enabled unconditionally. The tool stack may provide a property discard-enable in the backend node to optionally disable discard support.

Re: [Qemu-devel] [PATCH 11/12] qdev: add enum property types to QAPI schema

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: Prepare for when QOM introspection will be able to piggyback on the QAPI schema for describing property types. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev-properties.c | 18 +++ hw/i386/kvm/i8254.c | 6

Re: [Qemu-devel] [PATCH 12/12] qdev: use QAPI type names for properties

2014-01-30 Thread Eric Blake
On 01/30/2014 06:09 AM, Paolo Bonzini wrote: Use drive, chr, etc. only for legacy_name (which shows up in -device foo,? output). From the point of view of their type, these are just strings. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev-properties-system.c | 12

[Qemu-devel] [PATCH] dataplane: Comment fix

2014-01-30 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/block/dataplane/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 456d437..2237edb 100644 --- a/hw/block/dataplane/virtio-blk.c +++

Re: [Qemu-devel] [PATCH] Use error_is_set() only when necessary

2014-01-30 Thread Eric Blake
On 01/30/2014 07:07 AM, Markus Armbruster wrote: error_is_set(var) is the same as var != NULL, but it takes whole-program analysis to figure that out. Unnecessarily hard for optimizers, static checkers, and human readers. Dumb it down to obvious. Gets rid of several dozen Coverity false

Re: [Qemu-devel] [PATCH 5/6] Don't abort on out of memory when creating page cache

2014-01-30 Thread Dr. David Alan Gilbert
* Orit Wasserman (owass...@redhat.com) wrote: Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 16 ++-- page_cache.c | 18 ++ 2 files changed, 28 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index 5eff80b..806d096

  1   2   >