Re: [Qemu-devel] [PULL 0/3] Update seabios to 1.7.4

2014-02-04 Thread Gerd Hoffmann
On Di, 2014-02-04 at 11:39 +0400, Michael Tokarev wrote: 03.02.2014 18:45, Gerd Hoffmann wrote: Hi, Sorry for the delay folks, totally forgot that one. Here is the seabios update to 1.7.4 final. FWIW, we updated seabios in Debian testing (with qemu 1.7), and now there are several

Re: [Qemu-devel] [PULL 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-04 Thread Stefan Hajnoczi
On Mon, Feb 03, 2014 at 04:01:00PM +, Peter Maydell wrote: On 3 February 2014 15:20, Stefan Hajnoczi stefa...@redhat.com wrote: This pull request has been rebased onto qemu.git/master and retested. The series fixes init_socket() failures when reused PIDs cause temporary file name

Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-02-04 Thread Stefan Hajnoczi
On Tue, Feb 04, 2014 at 02:24:16PM +0900, Kazuya Saito wrote: (2014/01/31 6:00), Stefan Hajnoczi wrote: On Tue, Jan 28, 2014 at 01:35:20PM +0900, Kazuya Saito wrote: diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index 175df08..a0addb5 100644 ---

Re: [Qemu-devel] [PATCH v5 2/9] qdev: add to BusState hotplug-handler link

2014-02-04 Thread Igor Mammedov
On Mon, 03 Feb 2014 13:50:02 -0700 Eric Blake ebl...@redhat.com wrote: On 02/03/2014 01:38 PM, Igor Mammedov wrote: +static inline void qbus_set_hotplug_handler(BusState *bus, DeviceState *handler, +Error **errp) +{ +

Re: [Qemu-devel] Improving patch tracking - something like gerrit?

2014-02-04 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Mon, Feb 03, 2014 at 12:45:31PM +, Mark Cave-Ayland wrote: Hi all, It should be fairly evident to most people that the volume of patches flowing through the qemu-devel mailing list is continually increasing, and it is becoming

Re: [Qemu-devel] [PATCH] trace backend: introduce multi tracing backend

2014-02-04 Thread Stefan Hajnoczi
On Tue, Feb 04, 2014 at 02:26:13PM +0900, Kazuya Saito wrote: (2014/01/31 19:37), Stefan Hajnoczi wrote: On Tue, Jan 28, 2014 at 01:35:20PM +0900, Kazuya Saito wrote: I hope this change can be dropped in the next revision of the patch since the ust backend will no longer be different.

Re: [Qemu-devel] [PATCH] tests/Makefile: Run qom-test for every architecture

2014-02-04 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: Rather than requiring every new architecture to remember to add a line to the Makefile to say that qom-test will work on it, autogenerate the list of supported architectures by looking at the files in default-configs (as configure does), and add

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-02-04 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: On Wed, Jan 8, 2014 at 11:47 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 08/01/2014 14:40, Andreas Färber ha scritto: Either you fix info qtree to cope with your change to the device

Re: [Qemu-devel] [PATCH] configure: use glib in glib pkg-config check.

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 09:56:38AM +1100, Chris Johns wrote: On 3/02/2014 9:29 pm, Daniel P. Berrange wrote: On Mon, Feb 03, 2014 at 03:26:15PM +1100, Chris Johns wrote: Building against with a recent glib in a custom prefix fails because the gthread cflags in the pkg-config file do not have

Re: [Qemu-devel] [PULL 0/3] Update seabios to 1.7.4

2014-02-04 Thread Michael Tokarev
03.02.2014 18:45, Gerd Hoffmann wrote: are available in the git repository at: git://git.kraxel.org/qemu tags/pull-roms-1 Hmm. Did you forgot to push the tag? for you to fetch changes up to 41419b0f11d125ad792660638eb452c767eddc28: or the commits? Thanks, /mjt

Re: [Qemu-devel] [PATCH V6 5/8] block: Create authorizations mechanism for external snapshot and resize.

2014-02-04 Thread Kevin Wolf
Am 04.02.2014 um 01:15 hat Jeff Cody geschrieben: On Thu, Jan 23, 2014 at 09:31:36PM +0100, Benoît Canet wrote: From: Benoît Canet ben...@irqsave.net Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 65 ---

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-04 Thread Markus Armbruster
Actually [PATCH v3]. Alexander Graf ag...@suse.de writes: When we have 2 separate qdev devices that both create a qbus of the same type without specifying a bus name or device name, we end up with two buses of the same name, such as ide.0 on the Mac machines: dev: macio-ide, id bus:

Re: [Qemu-devel] [PATCH V14 00/13] Quorum block filter

2014-02-04 Thread Kevin Wolf
Am 03.02.2014 um 20:11 hat Benoît Canet geschrieben: v14: Use quorum_report_failure in early failure test suggested by Max [Benoît] v13: update copyright date and company legal status Benoît, please slow down a bit with pushing out new versions of this series. Five versions in one

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-04 Thread Paolo Bonzini
Il 04/02/2014 08:15, Alexey Kardashevskiy ha scritto: So. migration_thread() gets dirty pages number, tries to send them in a loop but every iteration resets the number of pages to 96 and we start again. After several tries we cross BUFFER_DELAY timeout and calculate new @max_size and if the

Re: [Qemu-devel] [PATCH] misc: Fix case Qemu - QEMU

2014-02-04 Thread Laszlo Ersek
On 02/04/14 06:43, Stefan Weil wrote: Signed-off-by: Stefan Weil s...@weilnetz.de --- scripts/switch-timer-api |2 +- tests/i440fx-test.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/switch-timer-api b/scripts/switch-timer-api index

[Qemu-devel] [PATCH] raw: Fix BlockLimits passthrough

2014-02-04 Thread Kevin Wolf
raw copies over the BlockLimits of bs-file during bdrv_open(). However, since commit d34682cd it is immediately overwritten during bdrv_refresh_limits(). This caused all fields except for opt_transfer_length and opt_mem_alignment (which happen to be correctly inherited in generic code) to be

Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-04 Thread Chen Gang
On 02/03/2014 06:39 PM, Chen Gang wrote: On 02/03/2014 06:34 PM, Daniel P. Berrange wrote: On Mon, Feb 03, 2014 at 06:00:42PM +0800, Chen Gang wrote: We can not assume 'path' + 'ctx-fs_root' must be less than MAX_PATH, so need use snprintf() instead of sprintf(). And also recommend to use

Re: [Qemu-devel] [PULL 0/3] Update seabios to 1.7.4

2014-02-04 Thread Gerd Hoffmann
On Di, 2014-02-04 at 14:21 +0400, Michael Tokarev wrote: 03.02.2014 18:45, Gerd Hoffmann wrote: are available in the git repository at: git://git.kraxel.org/qemu tags/pull-roms-1 Hmm. Did you forgot to push the tag? It's there: http://www.kraxel.org/cgit/qemu/tag/?id=pull-roms-1 It

Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 07:02:18PM +0800, Chen Gang wrote: On 02/03/2014 06:39 PM, Chen Gang wrote: On 02/03/2014 06:34 PM, Daniel P. Berrange wrote: On Mon, Feb 03, 2014 at 06:00:42PM +0800, Chen Gang wrote: We can not assume 'path' + 'ctx-fs_root' must be less than MAX_PATH, so need use

Re: [Qemu-devel] [PULL 0/3] Update seabios to 1.7.4

2014-02-04 Thread Michael Tokarev
04.02.2014 15:03, Gerd Hoffmann wrote: On Di, 2014-02-04 at 14:21 +0400, Michael Tokarev wrote: Hmm. Did you forgot to push the tag? It's there: http://www.kraxel.org/cgit/qemu/tag/?id=pull-roms-1 It is a signed tag not a branch though. git fetch --tags ? Interesting. I always used `git

Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-04 Thread Chen Gang
On 02/04/2014 07:06 PM, Daniel P. Berrange wrote: On Tue, Feb 04, 2014 at 07:02:18PM +0800, Chen Gang wrote: On 02/03/2014 06:39 PM, Chen Gang wrote: On 02/03/2014 06:34 PM, Daniel P. Berrange wrote: On Mon, Feb 03, 2014 at 06:00:42PM +0800, Chen Gang wrote: We can not assume 'path' +

Re: [Qemu-devel] [PATCH] raw: Fix BlockLimits passthrough

2014-02-04 Thread Laszlo Ersek
On 02/04/14 12:01, Kevin Wolf wrote: raw copies over the BlockLimits of bs-file during bdrv_open(). However, since commit d34682cd it is immediately overwritten during bdrv_refresh_limits(). This caused all fields except for opt_transfer_length and opt_mem_alignment (which happen to be

Re: [Qemu-devel] [PULL 0/3] Update seabios to 1.7.4

2014-02-04 Thread Michael Tokarev
04.02.2014 12:17, Gerd Hoffmann wrote: On Di, 2014-02-04 at 11:39 +0400, Michael Tokarev wrote: FWIW, we updated seabios in Debian testing (with qemu 1.7), and now there are several bugs filed in Debian BTS, at least: http://bugs.debian.org/737142 http://bugs.debian.org/736902 Dunno what

Re: [Qemu-devel] [PATCH v2 0/5] disas: add libvixl to support A64 disassembly

2014-02-04 Thread Laurent Desnogues
On Wed, Jan 29, 2014 at 9:51 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 29 January 2014 20:01, Laurent Desnogues laurent.desnog...@gmail.com wrote: On Tue, Jan 28, 2014 at 12:45 PM, Peter Maydell peter.mayd...@linaro.org wrote: Ping for review/testing/comments on this version,

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-04 Thread Paolo Bonzini
Il 04/02/2014 11:33, Markus Armbruster ha scritto: This breaks migration unless you change bus=ide.0 to bus=ide.1 on the destination. Should be mentioned in release notes. Do we have a place where we collect release notes as we go? Yes, http://wiki.qemu.org/ChangeLog/Next Paolo

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-04 Thread Alexey Kardashevskiy
On 02/04/2014 09:46 PM, Paolo Bonzini wrote: Il 04/02/2014 08:15, Alexey Kardashevskiy ha scritto: So. migration_thread() gets dirty pages number, tries to send them in a loop but every iteration resets the number of pages to 96 and we start again. After several tries we cross BUFFER_DELAY

Re: [Qemu-devel] [PATCH v2 0/5] disas: add libvixl to support A64 disassembly

2014-02-04 Thread Peter Maydell
On 4 February 2014 11:47, Laurent Desnogues laurent.desnog...@gmail.com wrote: On Wed, Jan 29, 2014 at 9:51 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 29 January 2014 20:01, Laurent Desnogues laurent.desnog...@gmail.com wrote: On Tue, Jan 28, 2014 at 12:45 PM, Peter Maydell

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-04 Thread Paolo Bonzini
Il 04/02/2014 12:59, Alexey Kardashevskiy ha scritto: With the default throttling of 32 MiB/s, bandwidth must be something like 33000 (expressed in bytes/ms) with the default settings, and then max_size should be 33000*3*10^9 / 10^6 = 600. Where is my computation wrong?

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-04 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 04/02/2014 11:33, Markus Armbruster ha scritto: This breaks migration unless you change bus=ide.0 to bus=ide.1 on the destination. Should be mentioned in release notes. Do we have a place where we collect release notes as we go? Yes,

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-04 Thread Alexey Kardashevskiy
On 02/04/2014 11:07 PM, Paolo Bonzini wrote: Il 04/02/2014 12:59, Alexey Kardashevskiy ha scritto: With the default throttling of 32 MiB/s, bandwidth must be something like 33000 (expressed in bytes/ms) with the default settings, and then max_size should be 33000*3*10^9 / 10^6 = 600.

Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-04 Thread Markus Armbruster
Chen Gang gang.chen.5...@gmail.com writes: On 02/03/2014 06:39 PM, Chen Gang wrote: On 02/03/2014 06:34 PM, Daniel P. Berrange wrote: On Mon, Feb 03, 2014 at 06:00:42PM +0800, Chen Gang wrote: We can not assume 'path' + 'ctx-fs_root' must be less than MAX_PATH, so need use snprintf() instead

[Qemu-devel] PC-BSD installer does not boot with 1.7.4 (bisected)

2014-02-04 Thread Michael Tokarev
We have a bugreport in debian, http://bugs.debian.org/737142, stating that PC-BSD does not work with seabios-1.7.4 anymore. I digged in, and found out that it fails only with -vga std (cirrus works fine). So I bisected the issue - only changing vgabios-stdvga.bin, and found this:

Re: [Qemu-devel] [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-04 Thread Michal Privoznik
On 03.02.2014 08:45, Stefan Hajnoczi wrote: KVM libvirt: you are welcome to join the QEMU umbrella organization like last year. I've updated wiki with a libvirt idea. But I can sense more to come later as I have some time to think about it :) Michal

Re: [Qemu-devel] [PATCH V15 01/13] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2014-02-04 Thread Kevin Wolf
Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: From: Benoît Canet ben...@irqsave.net Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Max Reitz mre...@redhat.com --- block/Makefile.objs | 1 + block/quorum.c | 54

Re: [Qemu-devel] [PATCH V6 8/8] block: Use graph node name as reference in bdrv_file_open().

2014-02-04 Thread Eric Blake
On 02/03/2014 02:43 AM, Kevin Wolf wrote: Yes, I think allowing bdrv_lookup_bs() to find both node names and device names makes sense. I would still use a common namespace and forbid using the same name for a device and a node. That makes sense for libvirt as well (libvirt has every

Re: [Qemu-devel] [PATCH V6 5/8] block: Create authorizations mechanism for external snapshot and resize.

2014-02-04 Thread Jeff Cody
On Tue, Feb 04, 2014 at 11:25:52AM +0100, Kevin Wolf wrote: Am 04.02.2014 um 01:15 hat Jeff Cody geschrieben: On Thu, Jan 23, 2014 at 09:31:36PM +0100, Benoît Canet wrote: From: Benoît Canet ben...@irqsave.net Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c

Re: [Qemu-devel] [PATCH V15 02/13] quorum: Create BDRVQuorumState and BlkDriver and do init.

2014-02-04 Thread Kevin Wolf
Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: From: Benoît Canet ben...@irqsave.net Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Max Reitz mre...@redhat.com --- block/quorum.c | 25 + 1 file changed, 25 insertions(+) diff --git

Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-04 Thread Eric Blake
On 02/04/2014 04:06 AM, Daniel P. Berrange wrote: v9fs need use mkdir, remove ... which have MAX_PATH limitation. So if the combined path is longer than MAX_PATH, before it passes to mkdir, remove ..., it has to be truncated just like what rpath() has done. I don't believe you are correct

Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-04 Thread Eric Blake
On 02/04/2014 05:25 AM, Markus Armbruster wrote: Second guessing when a pathname is too long for a system call is not a good idea. If it's too long, the system call will tell you. As Dan noted, PATH_MAX is *not* a hard limit. {PATH_MAX} Maximum number of bytes the

Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-02-04 Thread Chen Gang
On 02/04/2014 09:12 PM, Eric Blake wrote: On 02/04/2014 05:25 AM, Markus Armbruster wrote: Second guessing when a pathname is too long for a system call is not a good idea. If it's too long, the system call will tell you. As Dan noted, PATH_MAX is *not* a hard limit. {PATH_MAX}

Re: [Qemu-devel] KVM call agenda for 2014-02-04

2014-02-04 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please, send any topic that you are interested in covering. * Should we change anything to get more people to sign for the call? There hasn't been a call in quite a long time. Ideas? Any further discussion here? No topics for this week, so

Re: [Qemu-devel] [Qemu-ppc] standard test image not booting with qemu-system-ppc

2014-02-04 Thread Paolo Bonzini
Il 04/02/2014 08:55, Alexander Graf ha scritto: With this change, the memory system is now refusing to allow an access of size 2 through, because it's greater than the region length. So Ouch. Yes, for ioport reads/writes we definitely have to only cap the port range, not the length. We

Re: [Qemu-devel] [PATCH V15 03/13] quorum: Add quorum_aio_writev and its dependencies.

2014-02-04 Thread Kevin Wolf
Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: From: Benoît Canet ben...@irqsave.net Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 104 + 1 file changed, 104 insertions(+) Starting with writes before the

Re: [Qemu-devel] [PATCH v2 1/4] target-mips: add CPU definition for MIPS32R5

2014-02-04 Thread Petar Jovanovic
ping http://patchwork.ozlabs.org/patch/313937/ http://patchwork.ozlabs.org/patch/313938/ http://patchwork.ozlabs.org/patch/313944/ http://patchwork.ozlabs.org/patch/313936/ Regards, Petar From: Petar Jovanovic [petar.jovano...@rt-rk.com] Sent: Friday,

Re: [Qemu-devel] [PATCH V15 04/13] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2014-02-04 Thread Kevin Wolf
Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: From: Benoît Canet ben...@irqsave.net Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Max Reitz mre...@redhat.com --- block/blkverify.c | 108 +- include/qemu-common.h |

Re: [Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-02-04 Thread Andreas Färber
Am 03.02.2014 20:01, schrieb Eduardo Habkost: On Tue, Jan 21, 2014 at 05:13:50PM +0100, Paolo Bonzini wrote: Il 21/01/2014 16:51, Andreas Färber ha scritto: We already do that for other bits (e.g. XSAVE/OSXSAVE), Please point me to the commit, a search for xsave did not come up with a commit

Re: [Qemu-devel] [PATCH V15 05/13] quorum: Add quorum_aio_readv.

2014-02-04 Thread Kevin Wolf
Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: From: Benoît Canet ben...@irqsave.net Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Max Reitz mre...@redhat.com --- block/quorum.c | 38 ++ 1 file changed, 38 insertions(+) diff --git

Re: [Qemu-devel] Commit 9e047b982452c633882b486682966c1d97097015 (piix4: add acpi pci hotplug support) seems to break Xen pci-passthrough

2014-02-04 Thread Michael S. Tsirkin
On Tue, Feb 04, 2014 at 12:46:08AM +0100, Sander Eikelenboom wrote: Grmbll my fat fingers hit the send shortcut too soon by accident .. let's try again .. Hi Michael, A git bisect turned out that commit 9e047b982452c633882b486682966c1d97097015 breaks pci-passthrough on Xen. commit

Re: [Qemu-devel] [PATCH] misc: Fix case Qemu - QEMU

2014-02-04 Thread Andreas Färber
Am 04.02.2014 06:43, schrieb Stefan Weil: Signed-off-by: Stefan Weil s...@weilnetz.de --- scripts/switch-timer-api |2 +- tests/i440fx-test.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Andreas Färber afaer...@suse.de but that is the same spelling

Re: [Qemu-devel] [Qemu-ppc] standard test image not booting with qemu-system-ppc

2014-02-04 Thread Stefano Stabellini
On Tue, 4 Feb 2014, Paolo Bonzini wrote: Il 04/02/2014 08:55, Alexander Graf ha scritto: With this change, the memory system is now refusing to allow an access of size 2 through, because it's greater than the region length. So Ouch. Yes, for ioport reads/writes we definitely have to

Re: [Qemu-devel] migration: broken ram_save_pending

2014-02-04 Thread Paolo Bonzini
Il 04/02/2014 13:16, Alexey Kardashevskiy ha scritto: On 02/04/2014 11:07 PM, Paolo Bonzini wrote: Il 04/02/2014 12:59, Alexey Kardashevskiy ha scritto: With the default throttling of 32 MiB/s, bandwidth must be something like 33000 (expressed in bytes/ms) with the default settings, and then

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-04 Thread Peter Maydell
On 4 February 2014 14:57, Richard Henderson r...@twiddle.net wrote: I suppose I have no major objection to the feature, although frankly it's not especially exciting. I can't really imagine ever wanting to bulk trace all of the helpers. Tracing specific helpers on a target-by-target basis,

Re: [Qemu-devel] [PATCH 4/6] XBZRLE cache size should not be larger than guest memory size

2014-02-04 Thread Juan Quintela
Orit Wasserman owass...@redhat.com wrote: Signed-off-by: Orit Wasserman owass...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com

Re: [Qemu-devel] Commit 9e047b982452c633882b486682966c1d97097015 (piix4: add acpi pci hotplug support) seems to break Xen pci-passthrough

2014-02-04 Thread Sander Eikelenboom
Tuesday, February 4, 2014, 3:32:19 PM, you wrote: On Tue, Feb 04, 2014 at 12:46:08AM +0100, Sander Eikelenboom wrote: Grmbll my fat fingers hit the send shortcut too soon by accident .. let's try again .. Hi Michael, A git bisect turned out that commit

Re: [Qemu-devel] [PATCH] exec: fix ram_list dirty map optimization

2014-02-04 Thread Juan Quintela
Alexey Kardashevskiy a...@ozlabs.ru wrote: The ae2810c4bb3b383176e8e1b33931b16c01483aab patch introduced optimization for ram_list.dirty_memory update. However it can only work correctly if hpratio is 1 as the @bitmap parameter stores 1 bits per system page size (may vary, 4K or 64K on PPC64)

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-04 Thread Richard Henderson
On 01/31/2014 08:09 AM, Lluís Vilanova wrote: Adds the base ability to specify which events in the trace-events file may be used to trace guest activity in the TCG code (using the tcg event propery). Such events generate an extra set of tracing functions that can be called during TCG

Re: [Qemu-devel] Commit 9e047b982452c633882b486682966c1d97097015 (piix4: add acpi pci hotplug support) seems to break Xen pci-passthrough

2014-02-04 Thread Igor Mammedov
On Tue, 4 Feb 2014 16:07:08 +0100 Sander Eikelenboom li...@eikelenboom.it wrote: Tuesday, February 4, 2014, 3:32:19 PM, you wrote: On Tue, Feb 04, 2014 at 12:46:08AM +0100, Sander Eikelenboom wrote: Grmbll my fat fingers hit the send shortcut too soon by accident .. let's try again ..

Re: [Qemu-devel] [Xen-devel] [BUGFIX][PATCH v2] configure: Disable libtool if -fPIE does not work with it (bug #1257099)

2014-02-04 Thread Fabio Fantoni
Il 03/02/2014 12:59, Stefano Stabellini ha scritto: On Wed, 15 Jan 2014, Paolo Bonzini wrote: Il 03/01/2014 03:12, Don Slutz ha scritto: Adjust TMPO and added TMPB, TMPL, and TMPA. libtool needs the names to be fixed (TMPB). Add new functions do_libtool and libtool_prog. Add check for

Re: [Qemu-devel] [PATCH 6/6] Don't abort on memory allocation error

2014-02-04 Thread Juan Quintela
Orit Wasserman owass...@redhat.com wrote: It is better to fail migration in case of failure to allocate new cache item Signed-off-by: Orit Wasserman owass...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com

[Qemu-devel] [PATCH 8/8] exec: fix ram_list dirty map optimization

2014-02-04 Thread Juan Quintela
From: Alexey Kardashevskiy a...@ozlabs.ru The ae2810c4bb3b383176e8e1b33931b16c01483aab patch introduced optimization for ram_list.dirty_memory update. However it can only work correctly if hpratio is 1 as the @bitmap parameter stores 1 bits per system page size (may vary, 4K or 64K on PPC64) and

[Qemu-devel] [PATCH 4/8] migration:fix free XBZRLE decoded_buf wrong

2014-02-04 Thread Juan Quintela
From: Gonglei (Arei) arei.gong...@huawei.com When qemu do live migration with xbzrle, qemu malloc decoded_buf at destination end but free it at source end. It will crash qemu by double free error in some scenarios. Splitting the XBZRLE structure for clear logic distinguishing src/dst side.

Re: [Qemu-devel] osx pci vs. 99fd437dee468609de8218f0eb3b16621fb6a9c9

2014-02-04 Thread Michael S. Tsirkin
On Mon, Feb 03, 2014 at 04:23:34PM -0500, Gabriel L. Somlo wrote: Michael, Prior to commit 99fd437dee468609de8218f0eb3b16621fb6a9c9 (enable hotplug for pci bridges), PCI cards used to show up in the device tree of OS X (System Information). E.g., on MountainLion I have: Hardware - PCI

[Qemu-devel] [PATCH 3/8] Add check for cache size smaller than page size

2014-02-04 Thread Juan Quintela
From: Orit Wasserman owass...@redhat.com Signed-off-by: Orit Wasserman owass...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 4 migration.c | 10 +- 2 files changed, 13 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger than guest memory size

2014-02-04 Thread Juan Quintela
From: Orit Wasserman owass...@redhat.com Signed-off-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration.c b/migration.c index 46a7305..25add6f 100644 --- a/migration.c +++

Re: [Qemu-devel] [PATCH 12/12] trace: [all] Add guest_vmem event

2014-02-04 Thread Richard Henderson
On 01/31/2014 08:10 AM, Lluís Vilanova wrote: +#define ldub(p)({ trace_guest_vmem(p, 1, 0); ldub_raw(p);}) Are you sure you want to log these here? Uses of these macros are not restricted to the guest. Therefore you could wind up with e.g. PCI device accesses being attributed to the

[Qemu-devel] [PULL 0/8] migration queue

2014-02-04 Thread Juan Quintela
trampoline code for CRIS (2014-02-03 14:04:00 +) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20140204 for you to fetch changes up to 2c429c2e4540ff74f2396b41e34371bd97c9337f: exec: fix ram_list dirty map optimization (2014-02-04 15:52:31

[Qemu-devel] [PATCH 6/8] Don't abort on out of memory when creating page cache

2014-02-04 Thread Juan Quintela
From: Orit Wasserman owass...@redhat.com Signed-off-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 16 ++-- page_cache.c | 18 ++ 2 files changed, 28 insertions(+), 6 deletions(-) diff --git a/arch_init.c

Re: [Qemu-devel] [PATCH] xen_disk: add discard support

2014-02-04 Thread Stefano Stabellini
On Tue, 4 Feb 2014, Olaf Hering wrote: On Mon, Feb 03, Kevin Wolf wrote: Am 30.01.2014 um 16:02 hat Olaf Hering geschrieben: +++ b/hw/block/xen_disk.c +case BLKIF_OP_DISCARD: +{ +struct blkif_request_discard *discard_req = (void *)ioreq-req; +

Re: [Qemu-devel] [PATCH V15 12/13] quorum: Add quorum_open() and quorum_close().

2014-02-04 Thread Kevin Wolf
Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: From: Benoît Canet ben...@irqsave.net Example of command line: -drive if=virtio,file.driver=quorum,\ file.children.0.file.filename=1.raw,\ file.children.0.node-name=1.raw,\ file.children.0.driver=raw,\

Re: [Qemu-devel] [PULL v2 00/24] QOM devices patch queue 2013-12-24

2014-02-04 Thread Michael S. Tsirkin
On Tue, Feb 04, 2014 at 04:56:53PM +0100, Andreas Färber wrote: Michael, Am 24.12.2013 18:04, schrieb Andreas Färber: P.S. I reproducibly get a signal message: TEST: tests/acpi-test... (pid=6364) /i386/acpi/tcg: main-loop:

Re: [Qemu-devel] QEMU-Based Android Emulator

2014-02-04 Thread Andreas Färber
Hi, Am 03.02.2014 18:45, schrieb Marinos Tsantekidis: Hi to all! I'm looking to extract some info from QEMU used by Android Emulator. I want to add some printf s to the source code. How do I do that? How do I recompile the source in order for the changes to take effect? Please help!! Please

[Qemu-devel] [PATCH 2/8] Set xbzrle buffers to NULL after freeing them to avoid double free errors

2014-02-04 Thread Juan Quintela
From: Orit Wasserman owass...@redhat.com Signed-off-by: Orit Wasserman owass...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch_init.c b/arch_init.c index

[Qemu-devel] [PATCH 1/8] vmstate: Make VMSTATE_STRUCT_POINTER take type, not ptr-to-type

2014-02-04 Thread Juan Quintela
From: Peter Maydell peter.mayd...@linaro.org The VMSTATE_STRUCT_POINTER macros are a bit odd in that they must be passed an argument FooType * rather than just taking the FooType. They're only used in one place, so it's easy to tidy this up. This also lets us use the macro to replace the

Re: [Qemu-devel] [PATCH V15 13/13] quorum: Add unit test.

2014-02-04 Thread Kevin Wolf
Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/075 | 95 ++ tests/qemu-iotests/075.out | 34 +

[Qemu-devel] [PATCH 7/8] Don't abort on memory allocation error

2014-02-04 Thread Juan Quintela
From: Orit Wasserman owass...@redhat.com It is better to fail migration in case of failure to allocate new cache item Signed-off-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c| 4 +++- include/migration/page_cache.h |

Re: [Qemu-devel] [PATCH 0/2] Use g_new() friends where that makes obvious sense

2014-02-04 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 3 February 2014 08:40, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 31 January 2014 15:53, Markus Armbruster arm...@redhat.com wrote: 186 files changed, 376 insertions(+), 415 deletions(-) No

Re: [Qemu-devel] [BUGFIX][PATCH v2] configure: Disable libtool if -fPIE does not work with it (bug #1257099)

2014-02-04 Thread Stefano Stabellini
On Tue, 4 Feb 2014, Paolo Bonzini wrote: Il 03/02/2014 12:59, Stefano Stabellini ha scritto: I'm applying this to a configure branch on my github repository. Thanks! Paolo, did this patch ever make it upstream? If so, do you have a commit id? It's still in my branch, where it is

Re: [Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger than guest memory size

2014-02-04 Thread Eric Blake
On 02/04/2014 08:19 AM, Juan Quintela wrote: From: Orit Wasserman owass...@redhat.com Signed-off-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration.c b/migration.c

Re: [Qemu-devel] [BUGFIX][PATCH v2] configure: Disable libtool if -fPIE does not work with it (bug #1257099)

2014-02-04 Thread Paolo Bonzini
Il 03/02/2014 12:59, Stefano Stabellini ha scritto: I'm applying this to a configure branch on my github repository. Thanks! Paolo, did this patch ever make it upstream? If so, do you have a commit id? It's still in my branch, where it is commit fcfd805b. As soon as I get a go/no-go for

Re: [Qemu-devel] QEMU-Based Android Emulator

2014-02-04 Thread Marinos Tsantekidis
Maybe I'm not specific enough. I built Android from the source code and I know that the Android Emulator that comes with it, is based on QEMU. I don't want anything from Android. What I'm interested in is the underlying QEMU. I want to see how the program counter changes during translation. To my

Re: [Qemu-devel] [PATCH 0/2] Use g_new() friends where that makes obvious sense

2014-02-04 Thread Paolo Bonzini
Il 04/02/2014 17:52, Markus Armbruster ha scritto: Unfortunately, our use of macros confuses coccinelle sufficiently to miss quite a few instances of the patterns. Do we want this change anyway? Yes, we already use g_new anyway. Paolo

Re: [Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger than guest memory size

2014-02-04 Thread Orit Wasserman
On 02/04/2014 06:26 PM, Eric Blake wrote: On 02/04/2014 08:19 AM, Juan Quintela wrote: From: Orit Wasserman owass...@redhat.com Signed-off-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 7 +++ 1 file changed, 7 insertions(+)

Re: [Qemu-devel] [PULL v2 00/24] QOM devices patch queue 2013-12-24

2014-02-04 Thread Michael S. Tsirkin
On Tue, Feb 04, 2014 at 04:56:53PM +0100, Andreas Färber wrote: Michael, Am 24.12.2013 18:04, schrieb Andreas Färber: P.S. I reproducibly get a signal message: TEST: tests/acpi-test... (pid=6364) /i386/acpi/tcg: main-loop:

Re: [Qemu-devel] [PULL v2 00/24] QOM devices patch queue 2013-12-24

2014-02-04 Thread Andreas Färber
Michael, Am 24.12.2013 18:04, schrieb Andreas Färber: P.S. I reproducibly get a signal message: TEST: tests/acpi-test... (pid=6364) /i386/acpi/tcg: main-loop: WARNING: I/O thread spun for 1000 iterations qemu: terminating on signal 15

Re: [Qemu-devel] kvm control qemu-system-aarch64 state

2014-02-04 Thread Peter Maydell
On 4 February 2014 16:37, Claudio Fontana hw.clau...@gmail.com wrote: On 4 February 2014 16:39, Peter Maydell peter.mayd...@linaro.org wrote: On 4 February 2014 15:36, Claudio Fontana hw.clau...@gmail.com wrote: I just wanted to ask what is the current state of kvm control for

Re: [Qemu-devel] Commit 9e047b982452c633882b486682966c1d97097015 (piix4: add acpi pci hotplug support) seems to break Xen pci-passthrough

2014-02-04 Thread Igor Mammedov
On Tue, 4 Feb 2014 16:07:08 +0100 Sander Eikelenboom li...@eikelenboom.it wrote: Tuesday, February 4, 2014, 3:32:19 PM, you wrote: On Tue, Feb 04, 2014 at 12:46:08AM +0100, Sander Eikelenboom wrote: Grmbll my fat fingers hit the send shortcut too soon by accident .. let's try again ..

[Qemu-devel] [PATCH] qtest: don't report signals if qtest driver enabled

2014-02-04 Thread Michael S. Tsirkin
qtest driver always uses signals to kill qemu no need to report it, whatever the accelerator state. Add API to detect qtest driver, and suppress reporting signals in this case. Reported-by: Andreas Färber afaer...@suse.de Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [Qemu-devel] [PULL v2 00/24] QOM devices patch queue 2013-12-24

2014-02-04 Thread Michael S. Tsirkin
On Tue, Feb 04, 2014 at 04:56:53PM +0100, Andreas Färber wrote: Michael, Am 24.12.2013 18:04, schrieb Andreas Färber: P.S. I reproducibly get a signal message: TEST: tests/acpi-test... (pid=6364) /i386/acpi/tcg: main-loop:

Re: [Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on stderr

2014-02-04 Thread Michael Walle
Am 2014-02-03 23:59, schrieb Peter Maydell: On 3 February 2014 22:39, Michael Walle mich...@walle.cc wrote: Am 2014-02-01 21:31, schrieb Michael Walle: Am Samstag, 1. Februar 2014, 19:00:01 schrieb Peter Maydell: On 20 January 2014 19:34, Michael Walle mich...@walle.cc wrote: Do not use

Re: [Qemu-devel] [PULL 0/8] migration queue

2014-02-04 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi This includes: - Peter changes to make VMSTATE_STRUCT_POINTER more consistent - Fix migration with hpratio (ppc on ppc64 basically) - Orit/Arei cleanups/fixes to xbzrle Thanks, please apply. NACK myself. It has the wrong patch series from Orit.

Re: [Qemu-devel] [PATCH 7/8] Don't abort on memory allocation error

2014-02-04 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: From: Orit Wasserman owass...@redhat.com if (!it-it_data) { cache-num_items++; +it-it_data = g_try_malloc(cache-page_size); +if (!it-it_data) { +DPRINTF(Error allocating page\n); +return -1;

[Qemu-devel] [PATCH 7/8] Don't abort on out of memory when creating page cache

2014-02-04 Thread Juan Quintela
From: Orit Wasserman owass...@redhat.com Signed-off-by: Orit Wasserman owass...@redhat.com Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 18 -- page_cache.c | 18 ++ 2 files changed, 30

Re: [Qemu-devel] [PATCH V15 09/13] quorum: Add quorum_co_get_block_status.

2014-02-04 Thread Kevin Wolf
Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: From: Benoît Canet ben...@irqsave.net Signed-off-by: Benoit Canet ben...@irqsave.net Reviewed-by: Max Reitz mre...@redhat.com --- block/quorum.c | 51 +++ 1 file changed, 51 insertions(+)

[Qemu-devel] [PATCH 6/8] XBZRLE cache size should not be larger than guest memory size

2014-02-04 Thread Juan Quintela
From: Orit Wasserman owass...@redhat.com Signed-off-by: Orit Wasserman owass...@redhat.com Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration.c b/migration.c

Re: [Qemu-devel] [PATCH V15 06/13] quorum: Add quorum mechanism.

2014-02-04 Thread Kevin Wolf
Am 03.02.2014 um 22:51 hat Benoît Canet geschrieben: From: Benoît Canet ben...@irqsave.net Use gnutls's SHA-256 to compare versions. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/Makefile.objs | 2 +- block/quorum.c| 386

[Qemu-devel] [PATCH 1/8] vmstate: Make VMSTATE_STRUCT_POINTER take type, not ptr-to-type

2014-02-04 Thread Juan Quintela
From: Peter Maydell peter.mayd...@linaro.org The VMSTATE_STRUCT_POINTER macros are a bit odd in that they must be passed an argument FooType * rather than just taking the FooType. They're only used in one place, so it's easy to tidy this up. This also lets us use the macro to replace the

Re: [Qemu-devel] [PATCH] xen_disk: add discard support

2014-02-04 Thread Olaf Hering
On Tue, Feb 04, Olaf Hering wrote: On Tue, Feb 04, Kevin Wolf wrote: Now you call bdrv_acct_done() in the callback without having a matching bdrv_acct_start(). You need to make it conditional in the callback. Stefano, Is ioreq_runio_qemu_aio symetric in this regard anyway? In case of

Re: [Qemu-devel] [PULL] Update OpenBIOS images to r1246

2014-02-04 Thread Peter Maydell
Applied, thanks. -- PMM On 12 January 2014 15:25, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: Hi Anthony, Please pull the latest OpenBIOS binary images. In particular, these images fix the following two bugs in SPARC32: - Booting with OBP instead of OpenBIOS - Booting from

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-04 Thread Richard Henderson
On 02/04/2014 07:02 AM, Peter Maydell wrote: On 4 February 2014 14:57, Richard Henderson r...@twiddle.net wrote: I suppose I have no major objection to the feature, although frankly it's not especially exciting. I can't really imagine ever wanting to bulk trace all of the helpers. Tracing

[Qemu-devel] file_ram_alloc: unify mem-path, mem-prealloc error handling

2014-02-04 Thread Marcelo Tosatti
-mem-prealloc asks to preallocate memory residing on -mem-path path. Currently QEMU exits in case: - Memory file has been created but allocation via explicit write fails. And it fallbacks to malloc in case: - Querying huge page size fails. - Lack of sync MMU support. - Open fails. - mmap

  1   2   >