Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-27 Thread Stefan Hajnoczi
On Wed, Feb 26, 2014 at 05:01:52PM +0100, Peter Lieven wrote: > On 26.02.2014 16:41, Stefan Hajnoczi wrote: > >On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: > >>I was wondering if it would be a good idea to set the O_DIRECT mode for the > >>source > >>files of a qemu-img convert pr

Re: [Qemu-devel] Debugging aarch64 guest running on Foundationv8 model

2014-02-27 Thread Peter Maydell
On 27 February 2014 09:45, Jani Kokkonen wrote: > Hi, > > I would like to debug a Qemu guest linux kernel under Foundationv8 model and > I tried the following setup: > > 1. Foundationv8 model started with --network=nat and > --network-nat-ports=1234=1234 options > 2. In Foundationv8 model I star

Re: [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents

2014-02-27 Thread Stefan Hajnoczi
On Wed, Feb 26, 2014 at 06:17:31PM +0800, Fam Zheng wrote: > On Wed, 02/26 10:47, Peter Lieven wrote: > > Signed-off-by: Peter Lieven > > --- > > block/vmdk.c |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/block/vmdk.c b/block/vmdk.c > > index ff6f5ee..5fa29b0

[Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents

2014-02-27 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/vmdk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index ff6f5ee..5fa29b0 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1146,7 +1146,7 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriv

Re: [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents

2014-02-27 Thread Peter Lieven
Am 27.02.2014 11:06, schrieb Stefan Hajnoczi: > On Wed, Feb 26, 2014 at 06:17:31PM +0800, Fam Zheng wrote: >> On Wed, 02/26 10:47, Peter Lieven wrote: >>> Signed-off-by: Peter Lieven >>> --- >>> block/vmdk.c |2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/block/v

Re: [Qemu-devel] [PATCH 1/1] block: use /var/tmp instead of /tmp for -snapshot

2014-02-27 Thread Stefan Hajnoczi
On Wed, Feb 26, 2014 at 03:12:37PM +0530, Amit Shah wrote: > If TMPDIR is not specified, the default was to use /tmp for the working > copy of the block devices. Update this to /var/tmp instead, so systems > using tmp-on-tmpfs don't end up inadvertently using RAM for the block > device. > > Signe

Re: [Qemu-devel] [PATCH v2 1/2] iothread: stash thread ID away

2014-02-27 Thread Stefan Hajnoczi
On Tue, Feb 25, 2014 at 10:33:49AM -0700, Eric Blake wrote: > On 02/25/2014 10:19 AM, Stefan Hajnoczi wrote: > > Keep the thread ID around so we can report it via QMP. > > > > There's only one problem: qemu_get_thread_id() (gettid() wrapper on > > Linux) must be called from the thread itself. The

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-27 Thread Andreas Färber
Am 20.02.2014 14:58, schrieb Paolo Bonzini: > Il 20/02/2014 14:50, Alexey Kardashevskiy ha scritto: >> From: Paolo Bonzini >> >> This is a first step towards QOMifying /machine. >> >> Signed-off-by: Paolo Bonzini > > The patch was originally mine, so I could get it in if Andreas wants me > to ha

Re: [Qemu-devel] [RFC PATCH 7/7] target-arm: Hacky implementation of kvm_arch_reset_vcpu() for KVM ARM64

2014-02-27 Thread Pranavkumar Sawargaonkar
Hi Peter, On 27 February 2014 15:23, Peter Maydell wrote: > On 27 February 2014 06:51, Pranavkumar Sawargaonkar > wrote: >> We need to "Feed the kernel back its initial register state" using KVM >> ioctls for KVM ARM64 (just like KVM ARM). This means we need to save >> the "initial register stat

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-27 Thread Paolo Bonzini
Il 27/02/2014 11:34, Andreas Färber ha scritto: Am 20.02.2014 14:58, schrieb Paolo Bonzini: Il 20/02/2014 14:50, Alexey Kardashevskiy ha scritto: From: Paolo Bonzini This is a first step towards QOMifying /machine. Signed-off-by: Paolo Bonzini The patch was originally mine, so I could get

[Qemu-devel] [PATCH v3 0/2] dataplane: add query-iothreads QMP command

2014-02-27 Thread Stefan Hajnoczi
v3: * Loop until predicate is true to handle pthread_cond spurious wakeups [eblake] * Fix additional instances of "thread_id" [eblake] v2: * Use "thread-id" instead of "thread_id" in QAPI [eblake] * Avoid mutex unlock/destroy race between threads [pbonzini] This series applies on top of "[PAT

[Qemu-devel] [PATCH v3 1/2] iothread: stash thread ID away

2014-02-27 Thread Stefan Hajnoczi
Keep the thread ID around so we can report it via QMP. There's only one problem: qemu_get_thread_id() (gettid() wrapper on Linux) must be called from the thread itself. There is no way to get the thread ID outside the thread. This patch uses a condvar to wait for iothread_run() to populate the t

[Qemu-devel] [PATCH v3 2/2] qmp: add query-iothreads command

2014-02-27 Thread Stefan Hajnoczi
The "query-iothreads" command returns a list of information about iothreads. See the patch for API documentation. Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- iothread.c | 36 qapi-schema.json | 29 + qmp-comm

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-27 Thread Kevin Wolf
Am 27.02.2014 um 02:10 hat Fam Zheng geschrieben: > On Wed, 02/26 16:41, Stefan Hajnoczi wrote: > > On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: > > > I was wondering if it would be a good idea to set the O_DIRECT mode for > > > the source > > > files of a qemu-img convert process

[Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-02-27 Thread Wenchao Xia
This series address two issues: 1. support using enum as discriminator in union. For example, if we have following define in qapi schema: { 'enum': 'EnumOne', 'data': [ 'value1', 'value2', 'value3' ] } { 'type': 'UserDefBase0', 'data': { 'base-string0': 'str', 'base-enum0': 'EnumOne' } } Bef

[Qemu-devel] [PATCH V8 01/10] qapi script: remember explicitly defined enum values

2014-02-27 Thread Wenchao Xia
From: Wenchao Xia Later other scripts will need to check the enum values. Signed-off-by: Wenchao Xia Signed-off-by: Wenchao Xia --- scripts/qapi.py| 16 +++- tests/qapi-schema/comments.out |2 +- tests/qapi-schema/qapi-schema-test.out | 10 +

[Qemu-devel] [PATCH V8 03/10] qapi script: remember line number in schema parsing

2014-02-27 Thread Wenchao Xia
From: Wenchao Xia Before this patch, 'QAPISchemaError' scans whole input until 'pos' to get error line number. After this patch, the scan is avoided since line number is remembered in schema parsing. This patch also benefits other error report functions, which would be introduced later. Signed-o

[Qemu-devel] [PATCH V8 07/10] qapi script: support enum type as discriminator in union

2014-02-27 Thread Wenchao Xia
From: Wenchao Xia By default, any union will automatically generate a enum type as "[UnionName]Kind" in C code, and it is duplicated when the discriminator is specified as a pre-defined enum type in schema. After this patch, the pre-defined enum type will be really used as the switch case conditi

[Qemu-devel] [PATCH V8 04/10] qapi script: check correctness of union

2014-02-27 Thread Wenchao Xia
From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Wenchao Xia --- scripts/qapi.py| 106 +++- tests/Makefile |4 +- .../qapi-schema/flat-union-invalid-branch-key.err |1 + .../qapi-schema

[Qemu-devel] [PATCH V8 05/10] qapi script: code move for generate_enum_name()

2014-02-27 Thread Wenchao Xia
From: Wenchao Xia Later both qapi-types.py and qapi-visit.py need a common function for enum name generation. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Signed-off-by: Wenchao Xia --- scripts/qapi-types.py | 10 -- scripts/qapi.py | 10 ++ 2 files changed, 1

[Qemu-devel] [PATCH V8 06/10] qapi script: use same function to generate enum string

2014-02-27 Thread Wenchao Xia
From: Wenchao Xia Prior to this patch, qapi-visit.py used custom code to generate enum names used for handling a qapi union. Fix it to instead reuse common code, with identical generated results, and allowing future updates to generation to only need to touch one place. Signed-off-by: Wenchao Xi

[Qemu-devel] [PATCH V8 09/10] qapi script: do not allow string discriminator

2014-02-27 Thread Wenchao Xia
From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Wenchao Xia --- docs/qapi-code-gen.txt |5 + scripts/qapi.py|5 + tests/Makefile |3 ++- .../flat-union-string-dis

[Qemu-devel] [PATCH V8 10/10] qapi script: do not add "_" for every capitalized char in enum

2014-02-27 Thread Wenchao Xia
From: Wenchao Xia Now "enum AIOContext" will generate AIO_CONTEXT instead of A_I_O_CONTEXT, "X86CPU" will generate X86_CPU instead of X86_C_P_U. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Signed-off-by: Wenchao Xia --- include/qapi/qmp/qerror.h |2 +- scripts/qapi.py |

Re: [Qemu-devel] [RFC PATCH 7/7] target-arm: Hacky implementation of kvm_arch_reset_vcpu() for KVM ARM64

2014-02-27 Thread Peter Maydell
On 27 February 2014 10:35, Pranavkumar Sawargaonkar wrote: > Hi Peter, > > On 27 February 2014 15:23, Peter Maydell wrote: >> On 27 February 2014 06:51, Pranavkumar Sawargaonkar >> wrote: >>> We need to "Feed the kernel back its initial register state" using KVM >>> ioctls for KVM ARM64 (just li

[Qemu-devel] [PATCH V8 08/10] qapi: convert BlockdevOptions to use enum discriminator

2014-02-27 Thread Wenchao Xia
From: Wenchao Xia After this patch, hidden enum type BlockdevOptionsKind will not be generated, and other API can use enum BlockdevDriver. Signed-off-by: Wenchao Xia Signed-off-by: Wenchao Xia --- qapi-schema.json | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff

Re: [Qemu-devel] [PATCH 1/1] block: use /var/tmp instead of /tmp for -snapshot

2014-02-27 Thread Amit Shah
On (Thu) 27 Feb 2014 [11:18:15], Stefan Hajnoczi wrote: > On Wed, Feb 26, 2014 at 03:12:37PM +0530, Amit Shah wrote: > > If TMPDIR is not specified, the default was to use /tmp for the working > > copy of the block devices. Update this to /var/tmp instead, so systems > > using tmp-on-tmpfs don't e

Re: [Qemu-devel] [PULL 00/45] target-arm queue

2014-02-27 Thread Peter Maydell
On 26 February 2014 18:01, Peter Maydell wrote: > The following changes since commit d5001cf787ad0514839a81d0f2e771e01e076e21: > > xilinx: Delete hw/include/xilinx.h (2014-02-26 14:54:45 +1000) > > are available in the git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git >

[Qemu-devel] [PATCH V8 02/10] qapi script: add check for duplicated key

2014-02-27 Thread Wenchao Xia
From: Wenchao Xia It is bad that same key was specified twice, especially when a union have two branches with same condition. This patch can prevent it. Signed-off-by: Wenchao Xia Signed-off-by: Wenchao Xia --- scripts/qapi.py |2 ++ tests/Makefile

Re: [Qemu-devel] [PULL 0/4] vfio update and fix + pci-assign fix

2014-02-27 Thread Peter Maydell
On 26 February 2014 18:25, Alex Williamson wrote: > The following changes since commit d5001cf787ad0514839a81d0f2e771e01e076e21: > > xilinx: Delete hw/include/xilinx.h (2014-02-26 14:54:45 +1000) > > are available in the git repository at: > > git://github.com/awilliam/qemu-vfio.git tags/vfio-

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-27 Thread Alexey Kardashevskiy
On 02/27/2014 06:44 PM, Markus Armbruster wrote: > Alexey Kardashevskiy writes: > >> On 02/21/2014 09:30 PM, Paolo Bonzini wrote: >>> Il 21/02/2014 04:04, Alexey Kardashevskiy ha scritto: On 02/21/2014 12:50 AM, Alexey Kardashevskiy wrote: >> From: Paolo Bonzini >> >> This is a

Re: [Qemu-devel] [PATCH v15 03/14] block: Replace in_use with operation blocker

2014-02-27 Thread Markus Armbruster
Fam Zheng writes: > This drops BlockDriverState.in_use with op_blockers: > > - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1). > - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0). > - Check bdrv_op_is_blocked() in place of bdrv_in_use(bs). > The specific types are

Re: [Qemu-devel] [PATCH 0/5] xen: add Intel IGD passthrough support

2014-02-27 Thread Stefano Stabellini
On Thu, 27 Feb 2014, Zhang, Yang Z wrote: > Zhang, Yang Z wrote on 2014-02-21: > > From: Yang Zhang > > > > The following patches are ported from Xen Qemu-traditional branch > > which are adding Intel IGD passthrough supporting to Qemu upstream. > > > > To pass through IGD to guest, user need to

[Qemu-devel] [PATCH v3 0/2] acpi-test: issue errors instead of warnings when possible

2014-02-27 Thread Marcel Apfelbaum
v2->v3: Addressed Michael S. Tsirkin's comments: - got rid of a not needed if statement v1->v2: Addressed Michael S. Tsirkin's comments: - Split the path into 2 patches - First patch retains both asl and aml files on failure. - Second one "guesses" that iasl installatio

[Qemu-devel] [PATCH v3 1/2] acpi-test: retain both asl and aml files on failure

2014-02-27 Thread Marcel Apfelbaum
Updated the error message while at it. Signed-off-by: Marcel Apfelbaum --- tests/acpi-test.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/tests/acpi-test.c b/tests/acpi-test.c index 31f5359..2ce8c18 100644 --- a/tests/acpi-test.c +++ b/tests/acpi-test.c @@

[Qemu-devel] [PATCH v3 2/2] acpi-test: issue errors instead of warnings when possible

2014-02-27 Thread Marcel Apfelbaum
If the expected (offline) acpi tables loaded correctly, it is safe to assume the iasl installation is OK and issue an error if the actual tables differ from expected ones. Signed-off-by: Marcel Apfelbaum --- v2->v3: Addressed Michael S. Tsirkin's comments: - got rid of a not needed if sta

Re: [Qemu-devel] [PATCH v2 3/5] block: Change BlockDriverInfo.cluster_size to 64 bits

2014-02-27 Thread Stefan Hajnoczi
On Tue, Feb 11, 2014 at 11:28:37AM +0800, Fam Zheng wrote: > VMDK could have big cluster_size for monolithicFlat. It implements > .bdrv_get_info now, a 32 bit field is likely to overflow. > > Signed-off-by: Fam Zheng > --- > include/block/block.h | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support

2014-02-27 Thread Gerd Hoffmann
> I hate bouncing this pull request for a second time, but > this still contains stuff that's obviously not ready: > * patch which adds a 1000 line new file, then another >patch 2 commits later deletes 100 of those lines That is just a case of having forgotten to specify '-M' switch for git-f

Re: [Qemu-devel] Call for testing QEMU aarch64-linux-user emulation

2014-02-27 Thread Michael Matz
Hi, On Wed, 26 Feb 2014, Dann Frazier wrote: > I've narrowed down the changes that seem to prevent both types of > segfaults to the following changes that introduce a wrapper around > sigprocmask: > > https://github.com/susematz/qemu/commit/f1542ae9fe10d5a241fc2624ecaef5f0948e3472 > https://gith

Re: [Qemu-devel] Debugging aarch64 guest running on Foundationv8 model

2014-02-27 Thread Xuebing wang
Hi Jani, Is below video similar to what you want? This video shows cross-debug armv8 linux kernel (using armv8-gdb + armv8-qemu). http://www.youtube.com/watch?v=MLu5EzheHIM On 02/27/2014 05:52 PM, Peter Maydell wrote: On 27 February 2014 09:45, Jani Kokkonen wrote: Hi, I would like to de

Re: [Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support

2014-02-27 Thread Peter Maydell
On 27 February 2014 13:19, Gerd Hoffmann wrote: >> I hate bouncing this pull request for a second time, but >> this still contains stuff that's obviously not ready: >> * patch which adds a 1000 line new file, then another >>patch 2 commits later deletes 100 of those lines > > That is just a c

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-27 Thread Markus Armbruster
Alexey Kardashevskiy writes: > On 02/27/2014 06:44 PM, Markus Armbruster wrote: >> Alexey Kardashevskiy writes: >> >>> On 02/21/2014 09:30 PM, Paolo Bonzini wrote: Il 21/02/2014 04:04, Alexey Kardashevskiy ha scritto: > On 02/21/2014 12:50 AM, Alexey Kardashevskiy wrote: >>> From:

Re: [Qemu-devel] [PATCH 1/1] block: use /var/tmp instead of /tmp for -snapshot

2014-02-27 Thread Eric Blake
On 02/27/2014 04:33 AM, Amit Shah wrote: > On (Thu) 27 Feb 2014 [11:18:15], Stefan Hajnoczi wrote: >> On Wed, Feb 26, 2014 at 03:12:37PM +0530, Amit Shah wrote: >>> If TMPDIR is not specified, the default was to use /tmp for the working >>> copy of the block devices. Update this to /var/tmp instea

Re: [Qemu-devel] [PATCH V8 01/10] qapi script: remember explicitly defined enum values

2014-02-27 Thread Eric Blake
On 02/27/2014 04:09 AM, Wenchao Xia wrote: > From: Wenchao Xia > > Later other scripts will need to check the enum values. > > Signed-off-by: Wenchao Xia > Signed-off-by: Wenchao Xia Having two S-o-B by yourself looks awkward; is there one address we should be favoring? > --- > scripts/qapi

Re: [Qemu-devel] [PATCH] qemu_file: Fix mismerge of "use fwrite() correctly"

2014-02-27 Thread Eric Blake
On 02/27/2014 12:57 AM, Markus Armbruster wrote: > Reviewers accepted v2 of the patch, but what got committed was v1, > with the R-bys for v2. This is the v1->v2 followup fix. Ouch. > > Signed-off-by: Markus Armbruster > --- > qemu-file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

[Qemu-devel] [PULL 3/8] virtio-net: remove function calls from assert

2014-02-27 Thread Michael S. Tsirkin
From: Joel Stanley peer_{de,at}tach were called from inside assert(). We don't support building without NDEBUG but it's not tidy. Rearrange to attach peer outside assert calls. Signed-off-by: Joel Stanley Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/net/virtio-net

[Qemu-devel] [PULL 5/8] PCIE: fix regression with coldplugged multifunction device

2014-02-27 Thread Michael S. Tsirkin
From: Igor Mammedov PCIE is causing asserts each time a multifunction device is added on command line (coldplug). This is caused by commit a66e657e18cd9b70e9f57ae5512c07faf2bc508f pci/pcie: convert PCIE hotplug to use hotplug-handler API QEMU abort is caused by misplaced assertion, which sho

[Qemu-devel] [PULL 4/8] memory_region_present: return false if address is not found in child MemoryRegion

2014-02-27 Thread Michael S. Tsirkin
From: Igor Mammedov Windows XP shows COM2 port as non functional in "Device Manager" although no COM2 port backing device is present in QEMU. This regression is really due to 3bb28b7208b349e7a1b326e3c6ef9efac1d462bf? memory: Provide separate handling of unassigned io ports accesses That is

[Qemu-devel] [PULL 1/8] acpi-build: append description for non-hotplug

2014-02-27 Thread Michael S. Tsirkin
As reported in http://article.gmane.org/gmane.comp.emulators.qemu/253987 Mac OSX actually requires describing all occupied slots in ACPI - even if hotplug isn't enabled. I didn't expect this so I dropped description of all non hotpluggable slots from ACPI. As a result: before commit 99fd437dee4686

[Qemu-devel] [PULL 0/8] acpi,pc,pci,virtio,memory bug fixes

2014-02-27 Thread Michael S. Tsirkin
Gabriel, could you please confirm this works fine for you now? Thanks! The following changes since commit 417c45ab2f847c0a47b1232f611aa886df6a97d5: ACPI: Remove commented-out code from HPET._CRS (2014-02-10 11:09:33 +0200) are available in the git repository at: git://git.kernel.org/pub/scm

Re: [Qemu-devel] [PULL] qemu-sparc: CG3 framebuffer plus misc sun4m fixes

2014-02-27 Thread Mark Cave-Ayland
On 26/02/14 18:45, Peter Maydell wrote: On 25 February 2014 11:50, Mark Cave-Ayland wrote: Hi Peter, This branch contains updates for SPARC, particularly a new implementation of the CG3 framebuffer as reviewed on list, plus timer/hostid fixes from Olivier. Please pull. Hi. This fails to b

[Qemu-devel] [PULL 7/8] Add 'debug-threads' suboption to --name

2014-02-27 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Add flag storage to qemu-thread-* to store the namethreads flag Signed-off-by: Dr. David Alan Gilbert Acked-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek --- include/qemu/thread.h| 1 + util/qemu-thread-posix.c | 7 +++ util/qemu-thread-win32.c | 8 +

[Qemu-devel] [PULL 2/8] acpi-test-data: update expected files

2014-02-27 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/DSDT | Bin 4582 -> 4485 bytes tests/acpi-test-data/pc/SSDT | Bin 2200 -> 2275 bytes tests/acpi-test-data/q35/DSDT | Bin 7438 -> 7383 bytes tests/acpi-test-data/q35/SSDT | Bin 475 -> 564 bytes 4 files changed, 0 insertions(+), 0 d

[Qemu-devel] [PULL 6/8] Rework --name to use QemuOpts

2014-02-27 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Alex Bennée Acked-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek --- vl.c | 52 +++- 1 file changed, 39 insertions(+), 13 deletions(-) diff --git a/vl.c b/vl.c

Re: [Qemu-devel] [PATCH v3 0/2] dataplane: add query-iothreads QMP command

2014-02-27 Thread Eric Blake
On 02/27/2014 03:48 AM, Stefan Hajnoczi wrote: > v3: > * Loop until predicate is true to handle pthread_cond spurious wakeups > [eblake] > * Fix additional instances of "thread_id" [eblake] > > v2: > * Use "thread-id" instead of "thread_id" in QAPI [eblake] > * Avoid mutex unlock/destroy race

[Qemu-devel] [PULL 8/8] Add a 'name' parameter to qemu_thread_create

2014-02-27 Thread Michael S. Tsirkin
From: "Dr. David Alan Gilbert" If enabled, set the thread name at creation (on GNU systems with pthread_set_np) Fix up all the callers with a thread name Signed-off-by: Dr. David Alan Gilbert Acked-by: Michael S. Tsirkin Reviewed-by: Laszlo Ersek --- include/qemu/thread.h | 2 +-

Re: [Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support

2014-02-27 Thread Eric Blake
On 02/27/2014 06:19 AM, Gerd Hoffmann wrote: >> I hate bouncing this pull request for a second time, but >> this still contains stuff that's obviously not ready: >> * patch which adds a 1000 line new file, then another >>patch 2 commits later deletes 100 of those lines > > That is just a case

[Qemu-devel] [PULLv2] qemu-sparc: CG3 framebuffer plus misc sun4m fixes

2014-02-27 Thread Mark Cave-Ayland
Hi Peter, This revised pull request is exactly the same as the previous except that the correct type macros have been used in the two DPRINTF statements in cg3.c to ensure that it builds on all architectures. Please pull. ATB, Mark. The following changes since commit 6f6831f61a44fde832ee6fab0

Re: [Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support

2014-02-27 Thread Gerd Hoffmann
On Do, 2014-02-27 at 06:55 -0700, Eric Blake wrote: > git config diff.renames true Thanks. Gerd signature.asc Description: This is a digitally signed message part

Re: [Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support

2014-02-27 Thread Gerd Hoffmann
Hi, > If you need to fix up somebody else's patch because they've > dumped it on the list and run away without fixing review > issues, the right way to do this is: > * retain their email as the author > * retain their Signed-off-by line > * after that, include a brief summary in square bracke

[Qemu-devel] 【Question】About "Add an IPMI device to QEMU" patches

2014-02-27 Thread Weidong Huang
Hi, I am interesting in your patches about the IPMI device addition. When will you commit the next version? Best regards, -Huang WeiDong

[Qemu-devel] [PATCH v4 0/3] acpi-test: issue errors instead of warnings when possible

2014-02-27 Thread Marcel Apfelbaum
v3->v4: - Do not issue error on tables sync issues to not break git bisect - Rebased on mst's pci branch. Partially reverted a patch v2->v3: Addressed Michael S. Tsirkin's comments: - got rid of a not needed if statement Marcel Apfelbaum (3): acpi-build: Partially revert dac1e93

Re: [Qemu-devel] [snabb-devel] Re: Make virtio-net.c ring size configurable?

2014-02-27 Thread Stefan Hajnoczi
On Mon, Feb 24, 2014 at 05:14:04PM +0100, Luke Gorrie wrote: > On 24 February 2014 16:20, Stefan Hajnoczi wrote: > > > Do you want the 1:1 mapping to achieve best performance or just to > > simplify the coding? > > > > We want to keep the real-time constraints on the data plane comfortable. > >

[Qemu-devel] [PATCH v4 1/3] acpi-build: partially revert dac1e93093f9306c114f410785c99aa5261539b4

2014-02-27 Thread Marcel Apfelbaum
It touched the acpi test by mistake, removed that hunk. Signed-off-by: Marcel Apfelbaum --- tests/acpi-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/acpi-test.c b/tests/acpi-test.c index 613dda8..31f5359 100644 --- a/tests/acpi-test.c +++ b/tests/acpi-test.c @@

[Qemu-devel] [PATCH v4 2/3] acpi-test: retain both asl and aml files on failure

2014-02-27 Thread Marcel Apfelbaum
Updated the error message while at it. Signed-off-by: Marcel Apfelbaum --- tests/acpi-test.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/tests/acpi-test.c b/tests/acpi-test.c index 31f5359..2ce8c18 100644 --- a/tests/acpi-test.c +++ b/tests/acpi-test.c @@

[Qemu-devel] [PATCH v4 3/3] acpi-test: issue errors instead of warnings when possible

2014-02-27 Thread Marcel Apfelbaum
If the expected (offline) acpi tables loaded correctly, it is safe to assume the iasl installation is OK and issue an error if the actual tables failed to load. Signed-off-by: Marcel Apfelbaum --- v3->v4: - Do not issue error on tables sync issues to not break git bisect v2->v3: Addresse

[Qemu-devel] [Bug 1243287] Re: [KVM/QEMU][ARM][SAUCY] fails to boot cloud-image due to host kvm fail

2014-02-27 Thread Ben Howard
Manoj, the fix that Scott just put through should fix it. However, I've gone ahead and put in a fix for the cloud image build process. I would really like to see this fix though in dmidecode. ** Changed in: qemu Assignee: (unassigned) => Ben Howard (utlemming) ** Changed in: qemu Stat

[Qemu-devel] Debugging aarch64 guest running on Foundationv8 model

2014-02-27 Thread Jani Kokkonen
Hi, I would like to debug a Qemu guest linux kernel under Foundationv8 model and I tried the following setup: 1. Foundationv8 model started with --network=nat and --network-nat-ports=1234=1234 options 2. In Foundationv8 model I started qemu-system-aarch64 with the command line: ./qemu-system-a

Re: [Qemu-devel] [PATCH v5 RESEND 0/4] qemu-img: add preallocation=full

2014-02-27 Thread Stefan Hajnoczi
On Tue, Feb 11, 2014 at 03:07:06PM +0800, Hu Tao wrote: > This series implements full image preallocation to create a non-sparse image > file at creation time, both for raw and qcow2 format. The purpose is to avoid > performance deterioration of the guest cause by sparse image. > > v5: > - fix w

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-27 Thread Marcel Apfelbaum
On Thu, 2014-02-27 at 11:41 +0100, Paolo Bonzini wrote: > Il 27/02/2014 11:34, Andreas Färber ha scritto: > > Am 20.02.2014 14:58, schrieb Paolo Bonzini: > >> Il 20/02/2014 14:50, Alexey Kardashevskiy ha scritto: > >>> From: Paolo Bonzini > >>> > >>> This is a first step towards QOMifying /machine

Re: [Qemu-devel] [snabb-devel] Re: Make virtio-net.c ring size configurable?

2014-02-27 Thread Michael S. Tsirkin
On Thu, Feb 27, 2014 at 03:17:44PM +0100, Stefan Hajnoczi wrote: > On Mon, Feb 24, 2014 at 05:14:04PM +0100, Luke Gorrie wrote: > > On 24 February 2014 16:20, Stefan Hajnoczi wrote: > > > > > Do you want the 1:1 mapping to achieve best performance or just to > > > simplify the coding? > > > > >

Re: [Qemu-devel] [PULL 1/8] acpi-build: append description for non-hotplug

2014-02-27 Thread Gabriel L. Somlo
Michael, This seems to work great, on top of current master (git://git.qemu-project.org/qemu.git). Did you want me to test how this interacts with any other stuff (i.e. pull from your own git tree), or is this confirmation good enough ? Thanks again, --Gabriel On Thu, Feb 27, 2014 at 03:52:35PM

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-27 Thread Paolo Bonzini
Il 27/02/2014 15:39, Marcel Apfelbaum ha scritto: > > Each of them highlights one of the two aspects that, in my opinion, make > QOM interesting (respectively, unification of interfaces and the > containment tree). I was planning to tackle the replacement of the machine from a container to an ac

Re: [Qemu-devel] [PATCH v5 3/6] vl: allow customizing the class of /machine

2014-02-27 Thread Marcel Apfelbaum
On Thu, 2014-02-27 at 15:59 +0100, Paolo Bonzini wrote: > Il 27/02/2014 15:39, Marcel Apfelbaum ha scritto: > >> > > >> > Each of them highlights one of the two aspects that, in my opinion, make > >> > QOM interesting (respectively, unification of interfaces and the > >> > containment tree). > > I

Re: [Qemu-devel] [PULL 1/8] acpi-build: append description for non-hotplug

2014-02-27 Thread Michael S. Tsirkin
On Thu, Feb 27, 2014 at 09:57:10AM -0500, Gabriel L. Somlo wrote: > Michael, > > This seems to work great, on top of current master > (git://git.qemu-project.org/qemu.git). > > Did you want me to test how this interacts with any other stuff (i.e. > pull from your own git tree), or is this confirm

Re: [Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.

2014-02-27 Thread Stefan Hajnoczi
On Tue, Feb 25, 2014 at 10:24:30AM +0100, Romain Dolbeau wrote: > 2014-02-25 9:58 GMT+01:00 Romain Dolbeau : > > > 2014-02-25 9:01 GMT+01:00 Andreas Färber : > > > > > @@ -1572,6 +1572,9 @@ static const char * const pci_nic_models[] = { > >> > @@ -1584,6 +1587,9 @@ static const char * const pci_ni

Re: [Qemu-devel] [PATCH v2] discard rbd error output when not relevant in qemu-iotests

2014-02-27 Thread Stefan Hajnoczi
On Wed, Jan 08, 2014 at 09:05:38PM +0100, Loic Dachary wrote: > Suppress rbd progress messages with --no-progress so they are not > confused with an error output when comparing test results ( progress is > displayed on stderr ). > > Signed-off-by: Loic Dachary > --- > tests/qemu-iotests/common.r

Re: [Qemu-devel] Debugging aarch64 guest running on Foundationv8 model

2014-02-27 Thread Jani Kokkonen
Hi Xuebing, In that video the qemu seems use 32-bit ARM cpu model whereas I have need to use 64-bit ARM cpu model as I have specified by "-cpu host" qemu parameter in Foundationv8 model. -Jani 2014-02-27 14:21 GMT+01:00 Xuebing wang : > Hi Jani, > > Is below video similar to what you want? Thi

Re: [Qemu-devel] [PATCH v4 0/3] acpi-test: issue errors instead of warnings when possible

2014-02-27 Thread Michael S. Tsirkin
On Thu, Feb 27, 2014 at 04:17:29PM +0200, Marcel Apfelbaum wrote: > v3->v4: > - Do not issue error on tables sync issues to not break git bisect > - Rebased on mst's pci branch. Partially reverted a patch > > v2->v3: > Addressed Michael S. Tsirkin's comments: > - got rid of a not n

Re: [Qemu-devel] [PATCH] rdma: bug fixes

2014-02-27 Thread Michael Roth
Quoting mrhi...@linux.vnet.ibm.com (2014-02-17 20:34:06) > From: "Michael R. Hines" > > 1. Fix small memory leak in parsing inet address from command line in > data_init() > 2. Fix ibv_post_send() return value check and pass error code back up > correctly. > 3. Fix rdma_destroy_qp() segfault af

Re: [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents

2014-02-27 Thread Stefan Hajnoczi
On Wed, Feb 26, 2014 at 10:47:57AM +0100, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/vmdk.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan

Re: [Qemu-devel] [PATCH 9/9] w32: Replace Windows specific data types in common header files

2014-02-27 Thread Stefan Hajnoczi
On Sun, Feb 23, 2014 at 06:02:15PM +0100, Stefan Weil wrote: > These header files are used by most QEMU source files. If they > depend on windows.h, all those source files do so, too. > > All Windows specific data types which are replaced use identical > definitions for the 32 and 64 bit Windows A

Re: [Qemu-devel] [Qemu-stable] [PATCH 1/3] target-i386: Fix CC_OP_CLR vs PF

2014-02-27 Thread Michael Roth
Quoting Richard Henderson (2014-02-25 01:30:30) > Parity should be set for a zero result. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Richard Henderson Ping: last call for 1.7.1 (freeze today) > --- > target-i386/cc_helper.c | 2 +- > target-i386/translate.c | 2 +- > 2 files changed, 2 in

Re: [Qemu-devel] [PATCH v3 0/3] qapi: Allow modularization of QAPI schema files

2014-02-27 Thread Luiz Capitulino
On Tue, 11 Feb 2014 14:00:14 +0100 Lluís Vilanova wrote: > Adds the "include(...)" primitive to the syntax of QAPI schema files, allowing > these to be modularized into multiple per-topic files in the future. Markus, Eric, you commented/reviewed v2 of this series. Any comments against v3?

Re: [Qemu-devel] [PATCH V8 02/10] qapi script: add check for duplicated key

2014-02-27 Thread Eric Blake
On 02/27/2014 04:09 AM, Wenchao Xia wrote: > From: Wenchao Xia > > It is bad that same key was specified twice, especially when a union have s/have/has/ > two branches with same condition. This patch can prevent it. > > Signed-off-by: Wenchao Xia > Signed-off-by: Wenchao Xia Again, the doub

Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: bug fixes

2014-02-27 Thread Michael Roth
Quoting Wahlstrom, Pelle (2014-02-27 09:57:33) > I think that's correct. It doesn't meet cold filter criteria. Not sure I understand, what criteria are you referring to? > > Pelle > > -Original Message- > From: qemu-stable-bounces+pelle=netapp@nongnu.org > [mailto:qemu-stable-bounc

Re: [Qemu-devel] [PULL 0/1] Lonely uq/master patch for 2014-02-24

2014-02-27 Thread Peter Maydell
On 25 February 2014 10:44, Paolo Bonzini wrote: > Anthony, Peter, > > The following changes since commit 7c08db30e6a43f7083a881eb07bfbc878e001e08: > > target-i386: Move KVM default-vendor hack to instance_init (2014-02-03 > 17:33:55 +0100) > > are available in the git repository at: > git://g

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-27 Thread Peter Lieven
Am 27.02.2014 12:07, schrieb Kevin Wolf: > Am 27.02.2014 um 02:10 hat Fam Zheng geschrieben: >> On Wed, 02/26 16:41, Stefan Hajnoczi wrote: >>> On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: I was wondering if it would be a good idea to set the O_DIRECT mode for the source

Re: [Qemu-devel] [Qemu-stable] [PULL 1/1] KVM: Use return value for error print

2014-02-27 Thread Michael Roth
Quoting Paolo Bonzini (2014-02-25 04:44:56) > From: Alexander Graf > > Commit 94ccff13 introduced a more verbose failure message and retry > operations on KVM VM creation. However, it ended up using a variable > for its failure message that hasn't been initialized yet. > > Fix it to use the valu

Re: [Qemu-devel] best way to implement a "memclear" type instruction in TCG?

2014-02-27 Thread Peter Maydell
On 22 January 2014 19:06, Richard Henderson wrote: > On 01/22/2014 10:58 AM, Peter Maydell wrote: >> In theory we could just find the pointer to the memory QEMU is backing >> the guest RAM with and call memset on it... > > That's more or less what we do for the s390 insn XC. > See mem_helper.c, es

[Qemu-devel] [PULL 3/7] scsi-bus: Fix transfer length for VERIFY with BYTCHK=11b

2014-02-27 Thread Paolo Bonzini
From: Markus Armbruster The transfer length depends on field BYTCHK, which is encoded in byte 1, bits 1..2. However, the guard for for case BYTCHK=11b doesn't work, and we get case 01b instead. Fix it. Note that since emulated scsi-hd fails the command outright, it takes SCSI passthrough of a

[Qemu-devel] [PULL 0/7] SCSI patches for 2014-02-28

2014-02-27 Thread Paolo Bonzini
Anthony, Peter, The following changes since commit 6141f3bd6904df7cf9519c6444a14a608b9874c4: iotests: Mixed quorum child device specifications (2014-02-21 22:40:19 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes up to d973

[Qemu-devel] [PULL 1/7] scsi: Change scsi sense buf size to 252

2014-02-27 Thread Paolo Bonzini
From: Fam Zheng Current buffer size fails the assersion check in like hw/scsi/scsi-bus.c:1655:assert(req->sense_len <= sizeof(req->sense)); when backend (block/iscsi.c) returns more data then 96. Exercise the core dump path by booting an Gentoo ISO with scsi-generic device backed with

[Qemu-devel] [PULL 4/7] block/iscsi: fix deadlock on scsi check condition

2014-02-27 Thread Paolo Bonzini
From: Peter Lieven the retry logic was broken because the complete status of the task structure was not reset. this resulted in an infinite loop retrying the command over and over. CC: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- block/iscsi.c | 9 ++

[Qemu-devel] [PULL 2/7] scsi: report thin provisioning errors with werror=report

2014-02-27 Thread Paolo Bonzini
SCSI defines a status code for when a thin-provisioned LUNs would exceed the allocated space, map ENOSPC to it. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 5 + hw/scsi/scsi-disk.c| 3 +++ include/hw/scsi/scsi.h | 2 ++ 3 files changed, 10 inse

[Qemu-devel] [PULL 5/7] block/iscsi: query for supported VPD pages

2014-02-27 Thread Paolo Bonzini
From: Peter Lieven this patch ensures that we only query for block provisioning and block limits vpd pages if they are advertised. It also cleans up the inquiry code and eliminates some redundant code. Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- block/iscsi.c | 107 ++

[Qemu-devel] [PULL 6/7] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h

2014-02-27 Thread Paolo Bonzini
From: Roland Dreier To make a VM more convincing to my application, it's useful to be able to add a port WWN and relative target port index to the descriptors returned for VPD page 83h. Add device properties to allow setting these, and return them from INQUIRY commands. Signed-off-by: Roland Dr

[Qemu-devel] [PULL 7/7] block/iscsi: fix segfault if writesame fails

2014-02-27 Thread Paolo Bonzini
From: Peter Lieven commit fa6252b0 introduced a segfault because it tries to read iTask.task->sense after iTask.task has been freed. Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- block/iscsi.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a

[Qemu-devel] [Bug 1285508] Re: [ppa 2.0~git-20140225] mouse cursor invisible with Ubuntu live system

2014-02-27 Thread Serge Hallyn
** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1285508 Title: [ppa 2.0~git-20140225] mouse cursor invisible with Ubuntu live system

[Qemu-devel] [Bug 1285505] Re: [ppa 2.0~git-20140225] SIGABRT with -virtfs

2014-02-27 Thread Serge Hallyn
** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1285505 Title: [ppa 2.0~git-20140225] SIGABRT with -virtfs Status in QEMU: New Sta

[Qemu-devel] [Bug 1285708] [NEW] FreeBSD Guest crash on boot due to xsave instruction issue

2014-02-27 Thread Jesse Pretorius
Public bug reported: When trying to boot a working FreeBSD 9.1/9.2 guest on a kvm/qemu host with the following command: kvm -m 256 -cdrom FreeBSD-9.2-RELEASE-amd64-disc1.iso -drive file=FreeBSD-9.2-RELEASE-amd64.qcow2,if=virtio -net nic,model=virtio -net user -nographic -vnc :10 -enable-kvm -ball

  1   2   >