[Qemu-devel] [PATCH 60/97] vmstate: VMSTATE_ARRAY_OF_POINTER didn't used the version_id field

2014-04-07 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- include/migration/vmstate.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 5a26b6a..6d064de 100644 --- a/include/migration/vmstate.h +++

[Qemu-devel] [PATCH 47/97] vmstate: remove version from all variants of VMSTATE_STRUCT_POINTER*

2014-04-07 Thread Juan Quintela
There were no more users of them. Signed-off-by: Juan Quintela quint...@redhat.com --- include/migration/vmstate.h | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 3f2084b..61d677e 100644 ---

[Qemu-devel] [PATCH 43/97] vmstate: Remove unused VMSTATE_BUFFER_V

2014-04-07 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- include/migration/vmstate.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index e7ceb59..fbf7dbe 100644 --- a/include/migration/vmstate.h +++

[Qemu-devel] [PATCH 65/97] vmstate: Remove version parameter from VMSTATE_STATIC_BUFFER

2014-04-07 Thread Juan Quintela
No user for it. Signed-off-by: Juan Quintela quint...@redhat.com --- include/migration/vmstate.h | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index b9d5a28..95e4e17 100644 ---

[Qemu-devel] [PATCH 08/97] vmstate: Remove VMSTATE_UINTL_EQUAL_V

2014-04-07 Thread Juan Quintela
It was not used anywhere. Signed-off-by: Juan Quintela quint...@redhat.com --- include/hw/hw.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/include/hw/hw.h b/include/hw/hw.h index 33bdb92..2b68ac3 100644 --- a/include/hw/hw.h +++ b/include/hw/hw.h @@ -51,22

[Qemu-devel] [Bug 1062220] Re: qemu-system-arm crashed with SIGABRT in cpu_abort()

2014-04-07 Thread Apport retracing service
** Tags added: trusty -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1062220 Title: qemu-system-arm crashed with SIGABRT in cpu_abort() Status in QEMU: New Status in “qemu” package in Ubuntu:

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Gerd Hoffmann
On Do, 2014-04-03 at 11:42 +0200, Laszlo Ersek wrote: (a) Gerd's packages: http://www.kraxel.org/repos/ Under (a) you find some short instructions, and a set of RPMs that is automatically rebuilt twice a day (IIRC). It polls the git repos once per hour and kicks a build on new commits. So

Re: [Qemu-devel] [PATCH 08/35] qdev: hotplug for buss-less devices

2014-04-07 Thread Igor Mammedov
On Mon, 07 Apr 2014 12:26:23 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: On 04/05/2014 12:36 AM, Igor Mammedov wrote: Adds get_hotplug_handler() method to machine, and makes bus-less device to use it during hotplug as a means to discover hotplug handler controller. Returned

Re: [Qemu-devel] [PATCH 14/35] pc: exit QEMU if slots 256

2014-04-07 Thread Igor Mammedov
On Fri, 4 Apr 2014 14:14:04 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Fri, Apr 04, 2014 at 03:36:39PM +0200, Igor Mammedov wrote: ... which is current ACPI implementation limit. Signed-off-by: Igor Mammedov imamm...@redhat.com With this we will have yet another hardcoded

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Gerd Hoffmann
On Do, 2014-04-03 at 09:32 -0400, Gabriel L. Somlo wrote: For that, ideally, I'd like to clone a git repo (and pull once every few days to stay on top of things). Looks like the top-level upstream one doesn't have your smbios code, so would there be a mid-stream (for the lack of a better term)

Re: [Qemu-devel] [PATCH 30/35] pc: ACPI BIOS: name CPU hotplug ACPI0004 device

2014-04-07 Thread Igor Mammedov
On Sun, 6 Apr 2014 12:18:50 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Apr 04, 2014 at 03:36:55PM +0200, Igor Mammedov wrote: Following patches will add another ACPI0004 device to the same scope, and that will make Windows BSOD because it thinks that the second ACPI0004 device

Re: [Qemu-devel] [PATCH v5 23/24] usb: sanity check setup_index+setup_len in post_load

2014-04-07 Thread Gerd Hoffmann
On Do, 2014-04-03 at 19:52 +0300, Michael S. Tsirkin wrote: -if (dev-setup_index = sizeof(dev-data_buf) || +if (dev-setup_index 0 || +dev-setup_len 0 || +dev-setup_index = sizeof(dev-data_buf) || dev-setup_len = sizeof(dev-data_buf)) { return

Re: [Qemu-devel] [PATCH 31/35] pc: ACPI BIOS: implement memory hotplug interface

2014-04-07 Thread Igor Mammedov
On Sun, 6 Apr 2014 12:13:36 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Apr 04, 2014 at 03:36:56PM +0200, Igor Mammedov wrote: - provides static SSDT object for memory hotplug - SSDT template for memory devices and runtime generator of them in SSDT table. Signed-off-by:

Re: [Qemu-devel] [PATCH 00/35] pc: ACPI memory hotplug

2014-04-07 Thread Igor Mammedov
On Fri, 4 Apr 2014 17:57:28 +0100 Dr. David Alan Gilbert dgilb...@redhat.com wrote: * Igor Mammedov (imamm...@redhat.com) wrote: snip This series allows to hotplug 'arbitrary' DIMM devices specifying size, NUMA node mapping (guest side), slot and address where to map it, at runtime.

Re: [Qemu-devel] [PATCH for-2.0] dsdt: tweak ACPI ID for hotplug resource device

2014-04-07 Thread Igor Mammedov
On Sun, 6 Apr 2014 12:47:37 +0300 Michael S. Tsirkin m...@redhat.com wrote: ACPI0004 seems too new: Windows XP complains about an unrecognized device. This is a regression since 1.7. Use PNP0A06 instead - Generic Container Device. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Gerd Hoffmann
Hi, The only fly in this ointment may be that type 0 doesn't have a fixed length that could be edited in place, if you consider the various strings that get tacked on to the end of it. So you'd still have to slide the rest of the smbios payload left or right to shrink or enlarge the

Re: [Qemu-devel] [PATCH v3 01/26] tcg-aarch64: Properly detect SIGSEGV writes

2014-04-07 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: Since the kernel doesn't pass any info on the reason for the fault, disassemble the instruction to detect a store. Signed-off-by: Richard Henderson r...@twiddle.net --- user-exec.c | 29 +++-- 1 file changed, 23

Re: [Qemu-devel] [PATCH v2 1/2] usb-hid: Add high speed mouse configuration

2014-04-07 Thread Gerd Hoffmann
On Do, 2014-04-03 at 01:27 -0400, Ján Veselý wrote: ping2 is there anything I can do to help these patches get merged? Well, v2 is a step into the right direction but not complete yet. The usb_ver property hasn't any effect for mouse and keyboard. Also we'll need a compat property so older

Re: [Qemu-devel] [PATCH v3 11/26] tcg-aarch64: Reuse LR in translated code

2014-04-07 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: It's obviously call-clobbered, but is otherwise unused. Repurpose it as the TCG temporary. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/aarch64/tcg-target.c | 34 -- tcg/aarch64/tcg-target.h | 32

Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add Grab On Click option

2014-04-07 Thread Gerd Hoffmann
On Fr, 2014-04-04 at 12:41 +0200, Takashi Iwai wrote: I simply like it better, you don't? :) I still think we should make this simply depend on absolute/relative pointer mode instead of asking the user to switch it manually. I'll quickly go put patches 1-3 into a 2.0 pull request, so debating

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4] scripts: add sample model file for Coverity Scan

2014-04-07 Thread Dr. David Alan Gilbert
* Michael Tokarev (m...@tls.msk.ru) wrote: 26.03.2014 15:45, Paolo Bonzini wrote: This is the model file that is being used for the QEMU project's scans on scan.coverity.com. It fixed about 30 false positives (10% of the total) and exposed about 60 new memory leaks. The file is not

Re: [Qemu-devel] [PATCH 03/97] vmstate: return error in case of error

2014-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: If there is an error while loading a field, we should stop reading and not continue with the rest of fields. Signed-off-by: Juan Quintela quint...@redhat.com Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com --- vmstate.c | 3 +++ 1

Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add Grab On Click option

2014-04-07 Thread Takashi Iwai
At Mon, 07 Apr 2014 10:07:43 +0200, Gerd Hoffmann wrote: On Fr, 2014-04-04 at 12:41 +0200, Takashi Iwai wrote: I simply like it better, you don't? :) I still think we should make this simply depend on absolute/relative pointer mode instead of asking the user to switch it manually. Yes,

Re: [Qemu-devel] [PATCH 80/97] vmstate: Create VMSTATE_SYNTHETIC

2014-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: It is used for fields that don't exist on the State. They are generated on the fly for migration. While it's nicer than what's there before, I don't think this is the right fix for these fields, and I'd rather not encourage new uses like this. It

Re: [Qemu-devel] [Xen-devel] [PATCH 0/5] xen: add Intel IGD passthrough support

2014-04-07 Thread Ian Campbell
On Fri, 2014-04-04 at 18:46 -0400, Kevin O'Connor wrote: On Fri, Feb 21, 2014 at 02:44:08PM +0800, Yang Zhang wrote: From: Yang Zhang yang.z.zh...@intel.com The following patches are ported from Xen Qemu-traditional branch which are adding Intel IGD passthrough supporting to Qemu

Re: [Qemu-devel] [PATCH for-2.0] dsdt: tweak ACPI ID for hotplug resource device

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 09:46:34AM +0200, Igor Mammedov wrote: On Sun, 6 Apr 2014 12:47:37 +0300 Michael S. Tsirkin m...@redhat.com wrote: ACPI0004 seems too new: Windows XP complains about an unrecognized device. This is a regression since 1.7. Use PNP0A06 instead - Generic Container

Re: [Qemu-devel] [PATCH 96/97] vmstate: Rename VMS_VBUFFER to VMST_VBUFFER_INT32 for consintency

2014-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: Signed-off-by: Juan Quintela quint...@redhat.com --- include/migration/vmstate.h | 6 +++--- vmstate.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/migration/vmstate.h

[Qemu-devel] [PULL for-2.0 0/4] gtk: pointer fixes

2014-04-07 Thread Gerd Hoffmann
Hi, Last minute pointer fixes for gtk. And a MAINTAINERS update to help ui patches being picked up more timely in the future. please pull, Gerd The following changes since commit 466e6e9d13d56bbb6da1d2396d7d6347df483af0: target-i386: reorder fields in cpu/msr_hyperv_hypercall subsection

[Qemu-devel] [PULL 4/4] ui: Update MAINTAINERS entry.

2014-04-07 Thread Gerd Hoffmann
With Amazon eating Anthonys time status Maintained certainly isn't true any more. Update entry accordingly. Also add myself, so scripts/get_maintainer.pl will Cc: me, to reduce the chance ui patches fall through the cracks on our pretty loaded qemu-devel mailing list. Signed-off-by: Gerd

[Qemu-devel] [PULL 1/4] gtk: Use gtk generic event signal instead of motion-notify-event

2014-04-07 Thread Gerd Hoffmann
From: Takashi Iwai ti...@suse.de The GDK motion-notify-event isn't generated when the pointer goes out of the target window even if the pointer is grabbed, which essentially means to lose the pointer tracking in gtk-ui. Meanwhile the generic event signal is sent when the pointer is grabbed, so

[Qemu-devel] [PULL 2/4] gtk: Fix the relative pointer tracking mode

2014-04-07 Thread Gerd Hoffmann
From: Takashi Iwai ti...@suse.de The relative pointer tracking mode was still buggy even after the previous fix of the motion-notify-event since the events are filtered out when the pointer moves outside the drawing window due to the boundary check for the absolute mode. This patch fixes the

Re: [Qemu-devel] [PATCH for-2.0] dsdt: tweak ACPI ID for hotplug resource device

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 10:57:02AM +0200, Igor Mammedov wrote: On Sun, 6 Apr 2014 12:47:37 +0300 Michael S. Tsirkin m...@redhat.com wrote: ACPI0004 seems too new: Windows XP complains about an unrecognized device. This is a regression since 1.7. Use PNP0A06 instead - Generic Container

[Qemu-devel] [PULL 3/4] gtk: Remember the last grabbed pointer position

2014-04-07 Thread Gerd Hoffmann
From: Takashi Iwai ti...@suse.de It's pretty annoying that the pointer reappears at a random place once after grabbing and ungrabbing the input. Better to restore to the original position where the pointer was grabbed. Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587 Tested-by:

Re: [Qemu-devel] [PATCH for-2.0] dsdt: tweak ACPI ID for hotplug resource device

2014-04-07 Thread Igor Mammedov
On Sun, 6 Apr 2014 12:47:37 +0300 Michael S. Tsirkin m...@redhat.com wrote: ACPI0004 seems too new: Windows XP complains about an unrecognized device. This is a regression since 1.7. Use PNP0A06 instead - Generic Container Device. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4] scripts: add sample model file for Coverity Scan

2014-04-07 Thread Michael Tokarev
26.03.2014 15:45, Paolo Bonzini wrote: This is the model file that is being used for the QEMU project's scans on scan.coverity.com. It fixed about 30 false positives (10% of the total) and exposed about 60 new memory leaks. The file is not automatically used; changes to it must be

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Remove redundant message for -Werror

2014-04-07 Thread Michael Tokarev
15.03.2014 00:11, Stefan Weil wrote: The compiler flag -Werror is printed (or not printed) as any other compiler flag which is part of QEMU_CFLAGS. Therefore an extra output line for -Werror is redundant and can be removed. Applied - finally - to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH for 2.1 00/97] VMState simplification (massive)

2014-04-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: Hi Look at the diffstat. Almost all the additions are at test-vmstate.c. That is the reason why it is called a simplification. What this series does: - peter removal of version_minimum_id_old field when not needed (Peter) - cleanup: based

[Qemu-devel] [PATCH] doc: grammify allows to

2014-04-07 Thread Michael Tokarev
English language grammar does not allow usage of the word allows directly followed by an infinitive, declaring constructs like something allows to do somestuff un-grammatical. Often it is possible to just insert one between allows and to to make the construct grammatical, but usually it is better

Re: [Qemu-devel] [PATCH v3 11/26] tcg-aarch64: Reuse LR in translated code

2014-04-07 Thread Peter Maydell
On 7 April 2014 09:03, Claudio Fontana claudio.font...@huawei.com wrote: On 03.04.2014 21:56, Richard Henderson wrote: It's obviously call-clobbered, but is otherwise unused. Repurpose it as the TCG temporary. Giving one last chance to the ARM guys to speak up about repurposing LR. Can you

Re: [Qemu-devel] [PATCH 96/97] vmstate: Rename VMS_VBUFFER to VMST_VBUFFER_INT32 for consintency

2014-04-07 Thread Juan Quintela
Dr. David Alan Gilbert dgilb...@redhat.com wrote: * Juan Quintela (quint...@redhat.com) wrote: Signed-off-by: Juan Quintela quint...@redhat.com --- include/migration/vmstate.h | 6 +++--- vmstate.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 80/97] vmstate: Create VMSTATE_SYNTHETIC

2014-04-07 Thread Juan Quintela
Dr. David Alan Gilbert dgilb...@redhat.com wrote: * Juan Quintela (quint...@redhat.com) wrote: It is used for fields that don't exist on the State. They are generated on the fly for migration. While it's nicer than what's there before, I don't think this is the right fix for these fields,

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4] scripts: add sample model file for Coverity Scan

2014-04-07 Thread Markus Armbruster
Michael Tokarev m...@tls.msk.ru writes: 26.03.2014 15:45, Paolo Bonzini wrote: This is the model file that is being used for the QEMU project's scans on scan.coverity.com. It fixed about 30 false positives (10% of the total) and exposed about 60 new memory leaks. The file is not

Re: [Qemu-devel] [Xen-devel] Qemu 2.0 regression with xen: qemu crash on any domUs S.O. start

2014-04-07 Thread Fabio Fantoni
Il 03/04/2014 12:13, Fabio Fantoni ha scritto: Il 03/04/2014 10:45, Ian Campbell ha scritto: On Thu, 2014-04-03 at 10:15 +0200, Fabio Fantoni wrote: Seems that do segfault when I connect to vnc or spice, in the test of this backtrace after connect to vnc, spice and other things of my patches

[Qemu-devel] [PATCH trivial v2] doc: grammify allows to

2014-04-07 Thread Michael Tokarev
English language grammar does not allow usage of the word allows directly followed by an infinitive, declaring constructs like something allows to do somestuff un-grammatical. Often it is possible to just insert one between allows and to to make the construct grammatical, but usually it is better

Re: [Qemu-devel] [PATCH for 2.1 00/97] VMState simplification (massive)

2014-04-07 Thread Juan Quintela
Dr. David Alan Gilbert dgilb...@redhat.com wrote: * Juan Quintela (quint...@redhat.com) wrote: Hi Look at the diffstat. Almost all the additions are at test-vmstate.c. That is the reason why it is called a simplification. What this series does: - peter removal of

Re: [Qemu-devel] Bug#728876: qemu: smbd forked by qemu uses global directory /var/run/samba/ncalrpc

2014-04-07 Thread Michael Tokarev
05.02.2014 13:49, Michael Tokarev wrote: Ping? Again, more than 2 months passed since initial submission. Ping#2 ? Should it go to -trivial maybe? Thanks, /mjt 29.11.2013 00:15, Michael Tokarev wrote: Jan, there's one more samba-related fix for slirp, also from Michael Büsch. Add my

Re: [Qemu-devel] [Spice-devel] [Xen-devel] Qemu 2.0 regression with xen: qemu crash on any domUs S.O. start

2014-04-07 Thread Christophe Fergeau
On Mon, Apr 07, 2014 at 11:59:06AM +0200, Fabio Fantoni wrote: Today I did some tests also with hvm and spice and I found another segfault with different backtrace to solve: (gdb) c Continuing. *Program received signal SIGSEGV, Segmentation fault.** **0x55855d30 in

[Qemu-devel] [PULL 1/1] spice: monitors_config: check pointer before dereferencing

2014-04-07 Thread Gerd Hoffmann
Reported-by: Fabio Fantoni fabio.fant...@m2r.biz Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/spice-display.c | 4 1 file changed, 4 insertions(+) diff --git a/ui/spice-display.c b/ui/spice-display.c index e28698c..ce6b220 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@

[Qemu-devel] [PULL for-2.0 0/1] spice: monitors_config: check pointer before dereferencing

2014-04-07 Thread Gerd Hoffmann
Hi, Simple spice bugfix for 2.0. please pull, Gerd The following changes since commit 466e6e9d13d56bbb6da1d2396d7d6347df483af0: target-i386: reorder fields in cpu/msr_hyperv_hypercall subsection (2014-04-05 10:49:05 +0100) are available in the git repository at:

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Michael S. Tsirkin
On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: Notify PIIX4_PM/ICH9LPC device about hotplug event, so that it would send SCI to guest notifying about newly added memory. Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/i386/pc.c | 13 + 1 file changed,

[Qemu-devel] [PATCH] pass an inclusive address range to xc_domain_pin_memory_cacheattr

2014-04-07 Thread Stefano Stabellini
xc_domain_pin_memory_cacheattr expects an inclusive address range: adjust the parameters. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com diff --git a/xen-all.c b/xen-all.c index ba34739..027e7a8 100644 --- a/xen-all.c +++ b/xen-all.c @@ -323,7 +323,7 @@ go_physmap:

[Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
If a pci-2-pci bridge supports hot-plug functionality but there are no devices connected to it, reserve IO/mem in order to be able to attach devices later. Do not waste space, use minimum allowed. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- src/fw/pciinit.c | 3 +++ src/hw/pci.c

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Peter Maydell
On 7 April 2014 04:20, Juan Quintela quint...@redhat.com wrote: After previous Peter patch, they are redundant. This way we don't asign them except when needed. Once there, there were lots of case where the .fields indentation was wrong: .fields = (VMStateField []) { and .fields

Re: [Qemu-devel] [PATCH v3 11/26] tcg-aarch64: Reuse LR in translated code

2014-04-07 Thread Claudio Fontana
On 07.04.2014 11:49, Peter Maydell wrote: On 7 April 2014 09:03, Claudio Fontana claudio.font...@huawei.com wrote: On 03.04.2014 21:56, Richard Henderson wrote: It's obviously call-clobbered, but is otherwise unused. Repurpose it as the TCG temporary. Giving one last chance to the ARM guys

Re: [Qemu-devel] [PATCH v3 11/26] tcg-aarch64: Reuse LR in translated code

2014-04-07 Thread Peter Maydell
On 7 April 2014 12:11, Claudio Fontana claudio.font...@huawei.com wrote: [your mail client is generating very long lines] My doubt was about the AAPCS64 (Procedure Call standard for the ARM 64-bit Architecture), and what the platforms in our case dictate regarding FP and LR use. I think that

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Michael S. Tsirkin
On Fri, Apr 04, 2014 at 03:36:48PM +0200, Igor Mammedov wrote: ... and report error if plugged in device is not supported. Later generic callbacks will be used by memory hotplug. Signed-off-by: Igor Mammedov imamm...@redhat.com OK in that case, how about teaching all hotplug callbacks about

[Qemu-devel] LAST CALL for 2.0 patches/pulls

2014-04-07 Thread Peter Maydell
Hi; the release schedule for 2.0 is currently that we will tag an rc2 on Tuesday, and (assuming no critical issues found in testing it) that will then be tagged as the final 2.0 on Wednesday. So if you have any further pull requests for 2.0 please get them onto the list by the end of today

Re: [Qemu-devel] [PATCH v3 24/26] tcg-aarch64: Replace aarch64_ldst_op_data with AArch64LdstType

2014-04-07 Thread Claudio Fontana
On 03.04.2014 21:56, Richard Henderson wrote: The definition of op_type wasn't encoded for the proper shift for the field, making the implementations confusing. Signed-off-by: Richard Henderson r...@twiddle.net At the end of the day the magic values remain in the load/store instructions

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Juan Quintela
Peter Maydell peter.mayd...@linaro.org wrote: On 7 April 2014 04:20, Juan Quintela quint...@redhat.com wrote: After previous Peter patch, they are redundant. This way we don't asign them except when needed. Once there, there were lots of case where the .fields indentation was wrong:

Re: [Qemu-devel] [PULL for-2.0 0/4] gtk: pointer fixes

2014-04-07 Thread Peter Maydell
On 7 April 2014 09:56, Gerd Hoffmann kra...@redhat.com wrote: Hi, Last minute pointer fixes for gtk. And a MAINTAINERS update to help ui patches being picked up more timely in the future. please pull, Gerd The following changes since commit 466e6e9d13d56bbb6da1d2396d7d6347df483af0:

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Peter Maydell
On 7 April 2014 12:47, Juan Quintela quint...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org wrote: I'm really not a fan of this kind of single patch that touches a huge number of files at once. They're basically impossible to review and they introduce the possibility of conflicts

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Gerd Hoffmann
On Mo, 2014-04-07 at 13:59 +0300, Marcel Apfelbaum wrote: If a pci-2-pci bridge supports hot-plug functionality but there are no devices connected to it, reserve IO/mem in order to be able to attach devices later. Do not waste space, use minimum allowed. Makes sense. +u8 shpc_cap =

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 14:32:41 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Apr 04, 2014 at 03:36:48PM +0200, Igor Mammedov wrote: ... and report error if plugged in device is not supported. Later generic callbacks will be used by memory hotplug. Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PULL for-2.0 0/1] spice: monitors_config: check pointer before dereferencing

2014-04-07 Thread Peter Maydell
On 7 April 2014 11:21, Gerd Hoffmann kra...@redhat.com wrote: Hi, Simple spice bugfix for 2.0. please pull, Gerd The following changes since commit 466e6e9d13d56bbb6da1d2396d7d6347df483af0: target-i386: reorder fields in cpu/msr_hyperv_hypercall subsection (2014-04-05 10:49:05

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote: On Mon, 7 Apr 2014 14:32:41 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Apr 04, 2014 at 03:36:48PM +0200, Igor Mammedov wrote: ... and report error if plugged in device is not supported. Later generic callbacks

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 02:01:41PM +0200, Gerd Hoffmann wrote: On Mo, 2014-04-07 at 13:59 +0300, Marcel Apfelbaum wrote: If a pci-2-pci bridge supports hot-plug functionality but there are no devices connected to it, reserve IO/mem in order to be able to attach devices later. Do not

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 01:59:02PM +0300, Marcel Apfelbaum wrote: If a pci-2-pci bridge supports hot-plug functionality but there are no devices connected to it, reserve IO/mem in order to be able to attach devices later. Do not waste space, use minimum allowed. Signed-off-by: Marcel

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
On Mon, 2014-04-07 at 15:11 +0300, Michael S. Tsirkin wrote: On Mon, Apr 07, 2014 at 02:01:41PM +0200, Gerd Hoffmann wrote: On Mo, 2014-04-07 at 13:59 +0300, Marcel Apfelbaum wrote: If a pci-2-pci bridge supports hot-plug functionality but there are no devices connected to it, reserve

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 7 April 2014 12:47, Juan Quintela quint...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org wrote: I'm really not a fan of this kind of single patch that touches a huge number of files at once. They're basically impossible to review

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Peter Maydell
On 7 April 2014 13:21, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 7 April 2014 12:47, Juan Quintela quint...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org wrote: Like I said, one patch per maintained subsystem, one patch for the

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Gerd Hoffmann
Hi, +u8 shpc_cap = pci_find_capability(s-bus_dev, PCI_CAP_ID_SHPC); One thing I'd do is maybe check that the relevant memory type is enabled in the bridge (probably just by writing fff to base and reading it back). This will give hypervisors an option to avoid wasting resources:

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Juan Quintela
Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 7 April 2014 12:47, Juan Quintela quint...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org wrote: I'm really not a fan of this kind of single patch that touches a huge number of files at

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Juan Quintela
Peter Maydell peter.mayd...@linaro.org wrote: On 7 April 2014 13:21, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 7 April 2014 12:47, Juan Quintela quint...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org wrote: Like I said, one patch

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
On Mon, 2014-04-07 at 14:44 +0200, Gerd Hoffmann wrote: Hi, +u8 shpc_cap = pci_find_capability(s-bus_dev, PCI_CAP_ID_SHPC); One thing I'd do is maybe check that the relevant memory type is enabled in the bridge (probably just by writing fff to base and reading it back).

[Qemu-devel] [PATCH] spapr_pci: Fix number of returned vectors in ibm, change-msi

2014-04-07 Thread Alexey Kardashevskiy
Current guest kernels try allocating as many vectors as the quota is. For example, in the case of virtio-net (which has just 3 vectors) the guest requests 4 vectors (that is the quota in the test) and the existing ibm,change-msi handler returns 4. But before it returns, it calls msix_set_message()

[Qemu-devel] [SeaBIOS] [PATCH V2] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
If a pci-2-pci bridge supports hot-plug functionality but there are no devices connected to it, reserve IO/mem in order to be able to attach devices later. Do not waste space, use minimum allowed. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- - Thanks Gerd Hoffmann for the review. v1 -

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 15:07:15 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote: On Mon, 7 Apr 2014 14:32:41 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Apr 04, 2014 at 03:36:48PM +0200, Igor Mammedov wrote: ...

Re: [Qemu-devel] [PATCH for 2.1 00/97] VMState simplification (massive)

2014-04-07 Thread Marcel Apfelbaum
On Mon, 2014-04-07 at 05:20 +0200, Juan Quintela wrote: Hi Look at the diffstat. Almost all the additions are at test-vmstate.c. That is the reason why it is called a simplification. What this series does: - peter removal of version_minimum_id_old field when not needed (Peter) -

Re: [Qemu-devel] [Spice-devel] [Xen-devel] Qemu 2.0 regression with xen: qemu crash on any domUs S.O. start

2014-04-07 Thread Fabio Fantoni
Il 07/04/2014 12:20, Christophe Fergeau ha scritto: On Mon, Apr 07, 2014 at 11:59:06AM +0200, Fabio Fantoni wrote: Today I did some tests also with hvm and spice and I found another segfault with different backtrace to solve: (gdb) c Continuing. *Program received signal SIGSEGV, Segmentation

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 13:23:54 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: Notify PIIX4_PM/ICH9LPC device about hotplug event, so that it would send SCI to guest notifying about newly added memory. Signed-off-by: Igor

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 03:12:11PM +0200, Igor Mammedov wrote: On Mon, 7 Apr 2014 15:07:15 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote: On Mon, 7 Apr 2014 14:32:41 +0300 Michael S. Tsirkin m...@redhat.com wrote:

Re: [Qemu-devel] [PATCH for-2.0] Makefile: remove bashism

2014-04-07 Thread Peter Maydell
On 5 April 2014 15:25, Michael Tokarev m...@tls.msk.ru wrote: When installing modules (when --enable-modules is specified for ./configure), Makefile uses the following construct to replace all slashes with dashes in module name: ${s//\//-} This is a bash-specific substitution mechanism.

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 02:44:06PM +0200, Gerd Hoffmann wrote: Hi, +u8 shpc_cap = pci_find_capability(s-bus_dev, PCI_CAP_ID_SHPC); One thing I'd do is maybe check that the relevant memory type is enabled in the bridge (probably just by writing fff to base and reading it

Re: [Qemu-devel] [PATCH for-2.0 v2] fw-path-provider: Change GPL version to 2+

2014-04-07 Thread Andreas Färber
Am 26.03.2014 15:19, schrieb Alexey Kardashevskiy: On 03/27/2014 01:13 AM, Alexey Kardashevskiy wrote: Cc: Andreas Färber afaer...@suse.de Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Ah, this one is missing suggested-by. And Paolo's sob. Posting patches is tough :) ---

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
On Mon, 2014-04-07 at 16:34 +0300, Michael S. Tsirkin wrote: On Mon, Apr 07, 2014 at 02:44:06PM +0200, Gerd Hoffmann wrote: Hi, +u8 shpc_cap = pci_find_capability(s-bus_dev, PCI_CAP_ID_SHPC); One thing I'd do is maybe check that the relevant memory type is enabled in

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
On Mon, 2014-04-07 at 16:51 +0300, Marcel Apfelbaum wrote: On Mon, 2014-04-07 at 16:34 +0300, Michael S. Tsirkin wrote: On Mon, Apr 07, 2014 at 02:44:06PM +0200, Gerd Hoffmann wrote: Hi, +u8 shpc_cap = pci_find_capability(s-bus_dev, PCI_CAP_ID_SHPC); One

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Michael S. Tsirkin
On Mon, Apr 07, 2014 at 04:51:54PM +0300, Marcel Apfelbaum wrote: On Mon, 2014-04-07 at 16:34 +0300, Michael S. Tsirkin wrote: On Mon, Apr 07, 2014 at 02:44:06PM +0200, Gerd Hoffmann wrote: Hi, +u8 shpc_cap = pci_find_capability(s-bus_dev, PCI_CAP_ID_SHPC);

[Qemu-devel] [PATCH for-2.0 v2] tests: Don't run qom-test twice

2014-04-07 Thread Andreas Färber
Commit 3687d5325 accidentally resulted in running qom-test twice for x86_64, once directly via the wildcard, and once because x86_64 includes all the i386 qtests (which includes qom-test). Filter out x86_64 as well as microblazeel and xtensaeb to fix this. Cc: Peter Maydell

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Eduardo Habkost
On Mon, Apr 07, 2014 at 01:07:53PM +1000, Alexey Kardashevskiy wrote: On 04/05/2014 12:36 AM, Igor Mammedov wrote: Notify PIIX4_PM/ICH9LPC device about hotplug event, so that it would send SCI to guest notifying about newly added memory. Signed-off-by: Igor Mammedov imamm...@redhat.com

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Kevin O'Connor
On Mon, Apr 07, 2014 at 09:09:56AM +0200, Gerd Hoffmann wrote: The only fly in this ointment may be that type 0 doesn't have a fixed length that could be edited in place, if you consider the various strings that get tacked on to the end of it. So you'd still have to slide the rest of

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-07 Thread Marcel Apfelbaum
On Mon, 2014-04-07 at 17:09 +0300, Michael S. Tsirkin wrote: On Mon, Apr 07, 2014 at 04:51:54PM +0300, Marcel Apfelbaum wrote: [...] I don't think we'll need that for the SHPC bridge. Why not? Because has shpc = not an PCIe port. (as far as I know) Anyway, why have shpc capability

Re: [Qemu-devel] [PATCH v3 1/1] char/serial: Fix emptyness handling

2014-04-07 Thread Peter Maydell
On 4 April 2014 13:13, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Fri, Mar 28, 2014 at 10:10 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 28/03/2014 12:43, Don Slutz ha scritto: Ping. (Since this is a bug fix, I think it can go into 2.0) -Don Slutz I think the problem

Re: [Qemu-devel] [PATCH 23/35] acpi:piix4: make plug/unlug callbacks generic

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 16:25:30 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Apr 07, 2014 at 03:12:11PM +0200, Igor Mammedov wrote: On Mon, 7 Apr 2014 15:07:15 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Apr 07, 2014 at 02:00:37PM +0200, Igor Mammedov wrote: On

Re: [Qemu-devel] [Spice-devel] [Xen-devel] Qemu 2.0 regression with xen: qemu crash on any domUs S.O. start

2014-04-07 Thread Fabio Fantoni
Il 07/04/2014 15:19, Fabio Fantoni ha scritto: Il 07/04/2014 12:20, Christophe Fergeau ha scritto: On Mon, Apr 07, 2014 at 11:59:06AM +0200, Fabio Fantoni wrote: Today I did some tests also with hvm and spice and I found another segfault with different backtrace to solve: (gdb) c Continuing.

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] int128.h: Avoid undefined behaviours involving signed arithmetic

2014-04-07 Thread Richard Henderson
On 04/06/2014 08:27 AM, Peter Maydell wrote: (if C compilers had a behave like a sane 2s complement system for signed arithmetic option I'd be advocating for us using it...) -fwrapv. r~

Re: [Qemu-devel] [PATCH v3 24/26] tcg-aarch64: Replace aarch64_ldst_op_data with AArch64LdstType

2014-04-07 Thread Richard Henderson
On 04/07/2014 04:45 AM, Claudio Fontana wrote: On 03.04.2014 21:56, Richard Henderson wrote: The definition of op_type wasn't encoded for the proper shift for the field, making the implementations confusing. Signed-off-by: Richard Henderson r...@twiddle.net At the end of the day the magic

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 13:23:54 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Apr 04, 2014 at 03:36:53PM +0200, Igor Mammedov wrote: Notify PIIX4_PM/ICH9LPC device about hotplug event, so that it would send SCI to guest notifying about newly added memory. Signed-off-by: Igor

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-07 Thread Laszlo Ersek
On 04/07/14 16:14, Kevin O'Connor wrote: On Mon, Apr 07, 2014 at 09:09:56AM +0200, Gerd Hoffmann wrote: The only fly in this ointment may be that type 0 doesn't have a fixed length that could be edited in place, if you consider the various strings that get tacked on to the end of it. So you'd

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-07 Thread Igor Mammedov
On Mon, 7 Apr 2014 11:13:01 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Mon, Apr 07, 2014 at 01:07:53PM +1000, Alexey Kardashevskiy wrote: On 04/05/2014 12:36 AM, Igor Mammedov wrote: Notify PIIX4_PM/ICH9LPC device about hotplug event, so that it would send SCI to guest notifying

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/3] int128.h: Avoid undefined behaviours involving signed arithmetic

2014-04-07 Thread Peter Maydell
On 7 April 2014 15:25, Richard Henderson r...@twiddle.net wrote: On 04/06/2014 08:27 AM, Peter Maydell wrote: (if C compilers had a behave like a sane 2s complement system for signed arithmetic option I'd be advocating for us using it...) -fwrapv. Well, we should use that then :-) thanks

  1   2   >