[Qemu-devel] [PATCH v1 3/3] vl.c: Use qemu_get_boot_opts

2014-04-14 Thread Peter Crosthwaite
To simplfiy and make consistent with surrounding code using qemu_get_machine_opts(). Create a new local variable name boot_opts for consistency as well. Signed-off-by: Peter Crosthwaite --- vl.c | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-) dif

[Qemu-devel] [PATCH v1 2/3] vl.c: Add qemu_get_boot_opts()

2014-04-14 Thread Peter Crosthwaite
Same basic idea as qemu_get_machine_opts(). Signed-off-by: Peter Crosthwaite --- include/sysemu/sysemu.h | 1 + vl.c| 11 +++ 2 files changed, 12 insertions(+) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index ba5c7f8..d41748d 100644 --- a/includ

[Qemu-devel] [PATCH v1 1/3] vl.c: generalise qemu_get_machine_opts()

2014-04-14 Thread Peter Crosthwaite
This "nofail" (i.e. does not return NULL) mechanism driving qemu_get_machine_opts() does not need to be specific to machine opts - its applicable to other types of opts. Generalise and re-implement qemu_get_machine_opts() as a caller of the generalisation. Signed-off-by: Peter Crosthwaite --- v

[Qemu-devel] [PATCH v1 0/3] Introduce qemu_get_boot_opts()

2014-04-14 Thread Peter Crosthwaite
Hi Markus, This series introduces qemu_get_boot_opts(), in much the same way as was done for qemu_get_machine_opts(). As usual, I have out-of-scope and out-of-tree usages :) But P3 does clean up the one existing instance of the long-and-awkward form of this query and makes it consistent with an i

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-04-14 Thread Hu Tao
On Mon, Apr 14, 2014 at 06:44:42PM +0200, Igor Mammedov wrote: > On Mon, 14 Apr 2014 15:25:01 +0800 > Hu Tao wrote: > > > On Fri, Apr 04, 2014 at 03:36:58PM +0200, Igor Mammedov wrote: > > > Needed for Windows to use hotplugged memory device, otherwise > > > it complains that server is not config

Re: [Qemu-devel] [PATCH 1/2] ivshmem: check ivshmem_read() size argument

2014-04-14 Thread Gerd Hoffmann
> >> -static void ivshmem_read(void *opaque, const uint8_t * buf, int flags) > >> +static void ivshmem_read(void *opaque, const uint8_t * buf, int size) > >> { > >> IVShmemState *s = opaque; > >> int incoming_fd, tmp_fd; > >> int guest_max_eventfd; > >> long incoming_posn; > >>

[Qemu-devel] segfault while booting from saved snapshot

2014-04-14 Thread Shehbaz Jaffer
Hi, I am running a Ubuntu 12.04 guest VM that I created using vm-builder on a Ubuntu 12.04 Operating System. I am using qemu-2.0.0-rc0 version. I want to boot from a saved snapshot instance of the guest VM, so I created a snapshot using the Qemu Monitor as follows: stop savevm new cont quit I

[Qemu-devel] [PATCH] target-ppc: Remove PVR check from migration

2014-04-14 Thread Alexey Kardashevskiy
Currently migration fails if CPU version (PVR register) is different even a bit. This check is performed at the very end of migration when device states are sent. This is too late for management software and we need to provide a way for the user to make sure that migration will succeed if QEMU is s

Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res'

2014-04-14 Thread Chen Gang
On 04/15/2014 10:13 AM, Peter Crosthwaite wrote: > On Tue, Apr 8, 2014 at 10:02 PM, Chen Gang wrote: >> In function, if no additional resources to free before quit, commonly, >> need not use additional local variable 'res' to notice about it. So >> remove it to simplify code. >> > > Styling wise,

Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue'

2014-04-14 Thread Chen Gang
On 04/15/2014 10:11 AM, Peter Crosthwaite wrote: > On Tue, Apr 8, 2014 at 10:01 PM, Chen Gang wrote: >> > Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not >> > need additional useless 'continue'. >> > > Only in the case where the if-else is not followed by any code. Which >

[Qemu-devel] [ANNOUNCE] QEMU 2.0.0-rc3 is now available

2014-04-14 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 2.0 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.0.0-rc3.tar.bz2 You can help imp

Re: [Qemu-devel] [PATCH] exec: Limit translation limiting in address_space_translate to xen

2014-04-14 Thread Michael Roth
Quoting Alexey Kardashevskiy (2014-03-26 23:35:26) > The address_space_translate() function cuts the returned plen (page size) > to hardcoded TARGET_PAGE_SIZE. This function can be used on pages bigger > than that so this limiting should not be used on such pages. > > Since originally the limiting

Re: [Qemu-devel] [PATCH 0/2] ivshmem: validate incoming_posn value from server

2014-04-14 Thread Michael Roth
Quoting Stefan Hajnoczi (2014-03-31 02:08:09) > ivshmem can talk to a server over a UNIX domain socket on the host. We should > validate inputs from the server to prevent crashes or memory corruption. Cc'ing qemu-sta...@nongnu.org > > Stefan Hajnoczi (2): > ivshmem: check ivshmem_read() size

Re: [Qemu-devel] [RFC/RFT v1 0/2] NAND QOMification - Round 1

2014-04-14 Thread Peter Crosthwaite
Ping! Any opinions on this one? Regards, Peter On Wed, Feb 12, 2014 at 11:12 AM, Peter Crosthwaite wrote: > Or perhaps even round 0.5 ... > > Hi Andreas, > > I have a work-in-progress lengthy series that moves towards the full > QOMification and BUSification of NAND. This will allow a few thing

[Qemu-devel] [PATCH v4 1/4] util/fifo: Generalise naming scheme

2014-04-14 Thread Peter Crosthwaite
Generalise the names of the FIFO API to not include the "8". The exception is the push/pop functions for which we: s/fifo8_pop/fifo_pop8 s/fifo8_push/fifo_push8 This prepares support for generalising FIFO support to more integer widths. Most APIs will just share name and implementation. The push

[Qemu-devel] [PATCH v4 4/4] ssi: pl022: Convert to use FIFO

2014-04-14 Thread Peter Crosthwaite
Use the FIFO API to factor out the ring buffer implementation code. Cleans up the somewhat verbose VMS description as well (version bump required). Signed-off-by: Peter Crosthwaite --- hw/ssi/pl022.c | 101 - 1 file changed, 42 insertions(

[Qemu-devel] [PATCH v4 3/4] ssi: pl022: Send debug info to stderr

2014-04-14 Thread Peter Crosthwaite
To disentangle it from the monitor. Signed-off-by: Peter Crosthwaite --- hw/ssi/pl022.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ssi/pl022.c b/hw/ssi/pl022.c index fd479ef..84bf87a 100644 --- a/hw/ssi/pl022.c +++ b/hw/ssi/pl022.c @@ -14,7 +14,7 @@ #ifdef DEBUG_P

[Qemu-devel] [PATCH v4 0/4] Generalise FIFO to more integer types

2014-04-14 Thread Peter Crosthwaite
There is a utility helper for dealing with 8 bit fifos. This should be applicable to other integer widths as well. These two patches generalise this FIFO to work for 16, 32 and 64 bit ints. changed since v3: Initialised buffer_size (P2) (Beniamino review) changed since v2: Glueified hot paths to

[Qemu-devel] [PATCH v4 2/4] util/fifo: Generalise for common integer widths

2014-04-14 Thread Peter Crosthwaite
Add support for 16, 32 and 64 bit width FIFOs. The push and pop functions are replicated to accept all four different integer types. The element width of the FIFO is set at creation time. The backing storage for all element types is still uint8_t regardless of element width so some save-load logic

[Qemu-devel] qemu-kvm-1.0.1 cdrom device with iso hotplug issue

2014-04-14 Thread xuanmao_001
Hi, there: I found an issue that cdrom device hotplug iso image. 1. if I startup qemu with an iso image, then iso can easily be replaced and it worked. 2. but if I startup qemu with null image, when I change iso image use qemu monitor command "change", it told me with following message: '

[Qemu-devel] [PATCH v2] block: Handle error of bdrv_getlength in bdrv_create_dirty_bitmap

2014-04-14 Thread Fam Zheng
bdrv_getlength could fail, check the return value before using it. Signed-off-by: Fam Zheng --- v2: Make use of error_setg_errno and -errno. (Kevin) Signed-off-by: Fam Zheng --- block-migration.c | 28 block.c | 10 -- block/mirror.c

Re: [Qemu-devel] [PATCH v3 2/4] util/fifo: Generalise for common integer widths

2014-04-14 Thread Peter Crosthwaite
On Mon, Apr 14, 2014 at 7:56 AM, Beniamino Galvani wrote: > On Wed, Apr 09, 2014 at 11:42:31PM -0700, Peter Crosthwaite wrote: >> Add support for 16, 32 and 64 bit width FIFOs. The push and pop >> functions are replicated to accept all four different integer types. >> The element width of the FIFO

[Qemu-devel] [PATCH v1 3/3] arm: xilinx_zynq: Use Sysbus Memory device for RAMs

2014-04-14 Thread Peter Crosthwaite
For consistency with other devices and completeness of system device tree. Signed-off-by: Peter Crosthwaite --- hw/arm/xilinx_zynq.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index 9ee21e7..7a0c951 100644

[Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-14 Thread Peter Crosthwaite
So clients can set the top level id string. Signed-off-by: Peter Crosthwaite --- hw/core/qdev.c | 13 +++-- include/hw/qdev-core.h | 2 +- qdev-monitor.c | 3 ++- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 60f9

[Qemu-devel] [PATCH v1 2/3] memory: Add sysbus memory device

2014-04-14 Thread Peter Crosthwaite
Add a sysbus device consisting of a single ram. This allows for instantiation of RAM just like any other device. There are a number of good reasons to want to do this this: 1: Consistency. RAM is not that special where board level files should have to instantiate it with a completely different API

[Qemu-devel] [PATCH v1 0/3] Sysbus memory device

2014-04-14 Thread Peter Crosthwaite
This series adds support for a sysbus device for RAMs. Patch 2 is the main event. See commit message for full discussion. This is primarily prompted by the recent discussions around data driven machine creation. P1 is a nicety more than anything to preserve custom naming of devices (which oddly h

Re: [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res'

2014-04-14 Thread Peter Crosthwaite
On Tue, Apr 8, 2014 at 10:02 PM, Chen Gang wrote: > In function, if no additional resources to free before quit, commonly, > need not use additional local variable 'res' to notice about it. So > remove it to simplify code. > Styling wise, there is a school of thought that functions should only ha

Re: [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue'

2014-04-14 Thread Peter Crosthwaite
On Tue, Apr 8, 2014 at 10:01 PM, Chen Gang wrote: > Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not > need additional useless 'continue'. > Only in the case where the if-else is not followed by any code. Which is the case here. I found this sentance slightly confusing and

[Qemu-devel] report a suspect bug about arm gic

2014-04-14 Thread zhuxiaodong
Hi, I am a user of qemu. I found that in qemu2.0.0-rc0 the gic model was updated. However, it seems loss ability to bind irqs to any specified core when the board includes multiple cortex-a9 cores. The problematic codes maybe locate at hw/intc/arm_gic.c: 50 void gic_update(GICState *s)

Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device()

2014-04-14 Thread Chen Gang
May any member help to check them? And next, I shall try to find bug issues (not code style or document issues), and fix them. Hope I can succeed. Thanks. On 04/08/2014 08:00 PM, Chen Gang wrote: > In "vl.c", at least, we can simplify the code below, so can let readers > read professional C cod

Re: [Qemu-devel] [Qemu-trivial] [PATCH] arch_init.c: remove duplicate function

2014-04-14 Thread Michael R. Hines
On 04/14/2014 05:19 PM, Laszlo Ersek wrote: On 04/14/14 04:27, Amos Kong wrote: We already have a function buffer_is_zero() in util/cutils.c Signed-off-by: Amos Kong --- arch_init.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/arch_init.c b/arch_init.c index

Re: [Qemu-devel] Unresponsive linux guest once migrated

2014-04-14 Thread Marcus
Dang, I was hoping some ground was being made on this. On Wed, Apr 2, 2014 at 11:05 AM, Marcin Gibuła wrote: >>> Yes, that's where it gets weird. I've never seen this on fresh VM. >>> It needs to be idle for couple of hours at least. And even then it >>> doesn't always hang. >> >> >> So your OS i

Re: [Qemu-devel] [SeaBIOS v3 PATCH] SMBIOS: Check for full tables & entry point in fw_cfg

2014-04-14 Thread Kevin O'Connor
On Mon, Apr 14, 2014 at 03:30:14PM -0400, Gabriel L. Somlo wrote: > Check fw_cfg for the presence of a complete set of smbios > tables (etc/smbios/smbios-tables) and an entry point structure > (etc/smbios/smbios-anchor), and, if found, use them instead of > generating our own copies locally. > > W

[Qemu-devel] [QEMU v6 PATCH 17/17] SMBIOS: Update memory table types (16, 17, and 19) to smbios spec v2.8

2014-04-14 Thread Gabriel L. Somlo
This patch adds extended start/end address and extended size fields to each memory table type. Signed-off-by: Gabriel Somlo --- hw/i386/smbios.c | 52 include/hw/i386/smbios.h | 20 --- 2 files changed, 52 insertions(+), 20

[Qemu-devel] [QEMU v6 PATCH 14/17] SMBIOS: Use e820 memory map to generate type 19 tables

2014-04-14 Thread Gabriel L. Somlo
Build type 19 (memory array mapped address, a.k.a. memory area) tables by scanning the e820 map for E820_RAM entries. Since this supercedes below_4g and above_4g ram amounts, we no longer need them as arguments to smbios_set_defaults(). Signed-off-by: Gabriel Somlo --- hw/i386/pc.c |

[Qemu-devel] [QEMU v6 PATCH 15/17] SMBIOS: Update type 3 definition to smbios spec v2.7

2014-04-14 Thread Gabriel L. Somlo
Signed-off-by: Gabriel Somlo --- hw/i386/smbios.c | 8 +++- include/hw/i386/smbios.h | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index eb11095..25d2aa3 100644 --- a/hw/i386/smbios.c +++ b/hw/i386/smbios.c @@ -52,7 +52,7 @

[Qemu-devel] [QEMU v6 PATCH 16/17] SMBIOS: Update type 4 definition to smbios spec v2.6

2014-04-14 Thread Gabriel L. Somlo
With this update, we generate one type 4 (processor information) table per socket, calculated as "smp_cpus / (smp_cores * smp_threads)", which is in line with what happens on modern hardware. Signed-off-by: Gabriel Somlo --- hw/i386/smbios.c | 22 +- include/hw/i386/s

[Qemu-devel] [QEMU v6 PATCH 13/17] SMBIOS: Stop including type 20 tables

2014-04-14 Thread Gabriel L. Somlo
Table type 20 (memory device mapped address) is no longer required as of smbios spec v2.5. Leaving it out completely saves us from having to figure out how to connect type 17 devices to type 19 memory areas. Signed-off-by: Gabriel Somlo --- hw/i386/smbios.c | 99 +

[Qemu-devel] [QEMU v6 PATCH 07/17] SMBIOS: Build full type 3 table

2014-04-14 Thread Gabriel L. Somlo
Build smbios type 3 (system enclosure) table, and make it available to the bios via fw_cfg. For initial compatibility with SeaBIOS, use "Bochs" as the default manufacturer string, and leave version unset. Signed-off-by: Gabriel Somlo --- hw/i386/smbios.c | 67

[Qemu-devel] [QEMU v6 PATCH 12/17] SMBIOS: Remove SeaBIOS compatibility quirks

2014-04-14 Thread Gabriel L. Somlo
- Replace some arbitrarily hardcoded fields with proper "n/a" or "unknown" values; - Use QEMU-supplied default manufacturer and version strings; - Count CPUs starting with 0 instead of 1, to maintain uniformity with other multiple-instance items. Signed-off-by: Gabriel Somlo --- hw

[Qemu-devel] [QEMU v6 PATCH 10/17] SMBIOS: Build full tables for type 32 and 127

2014-04-14 Thread Gabriel L. Somlo
Build full smbios type 32 (system boot info) and 127 (end-of-table) tables, and make them available via fw_cfg. Signed-off-by: Gabriel Somlo --- hw/i386/smbios.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index 6510ff3..b1f1d46 10

[Qemu-devel] [QEMU v6 PATCH 08/17] SMBIOS: Build full type 4 tables

2014-04-14 Thread Gabriel L. Somlo
Build full smbios type 4 (processor information) tables, and make them available to the bios via fw_cfg. For initial compatibility with SeaBIOS, use "Bochs" as the default manufacturer string, and leave version unset. Signed-off-by: Gabriel Somlo --- hw/i386/pc.c | 3 ++ hw/i386/smb

[Qemu-devel] [QEMU v6 PATCH 05/17] SMBIOS: Build full tables for types 0 and 1

2014-04-14 Thread Gabriel L. Somlo
Build full tables for types 0 (bios information) and 1 (system information). Type 0 is optional, and a table will only be built if requested via the command line; the default is to leave type 0 tables up to the bios itself. Signed-off-by: Gabriel Somlo --- hw/i386/smbios.c | 63 +

[Qemu-devel] [QEMU v6 PATCH 11/17] SMBIOS: Generate aggregate smbios tables, including entry point

2014-04-14 Thread Gabriel L. Somlo
Build a complete set of smbios tables as a monolithic blob; Also, build an entry point structure, and insert both the set of tables and the entry point into distinct fw_cfg files. This patch expects a SeaBIOS version equal or later than commit X. An earlier version will work, but without t

[Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-14 Thread Gabriel L. Somlo
New in version 6 of the patch set: - down to 17 patches (squashed adding spec v2.4 fields in together with adding v2.8 fields further down). - switching to monolithic aggregate tables plus entry point in patch 11/17, right after accomplishing full SeaBIOS compatibility (in 10/17).

[Qemu-devel] [QEMU v6 PATCH 03/17] SMBIOS: Use bitmaps to check for smbios table collisions

2014-04-14 Thread Gabriel L. Somlo
Replace existing smbios_check_collision() functionality with a pair of bitmaps: have_binfile_bitmap and have_fields_bitmap. Bits corresponding to each smbios type are set by smbios_entry_add(), which also uses the bitmaps to ensure that binary blobs and field values are never accepted for the same

[Qemu-devel] [QEMU v6 PATCH 09/17] SMBIOS: Build full smbios memory tables (type 16, 17, 19, and 20)

2014-04-14 Thread Gabriel L. Somlo
Build full smbios tables representing the system RAM: - type 16 (physical memory array): represents the entire system RAM; - type 17 (memory device) tables: one per virtual DIMM; - type 19 (memory array mapped address): represent major RAM areas (currently one for below-4G memory, and, if

[Qemu-devel] [QEMU v6 PATCH 04/17] SMBIOS: Add code to build full smbios tables; build type 2 table

2014-04-14 Thread Gabriel L. Somlo
This patch adds a set of macros which build full smbios tables of a given type, including the logic to decide whether a given table type should be built or not. To illustrate this new functionality, we introduce and optionally build a table of type 2 (base board), which is required by some version

[Qemu-devel] [QEMU v6 PATCH 06/17] SMBIOS: Remove unused code for passing individual fields to bios

2014-04-14 Thread Gabriel L. Somlo
This patch removes smbios_add_field() and the old code to insert individual fields for types 0 and 1 into fw_cfg. Signed-off-by: Gabriel Somlo --- hw/i386/smbios.c | 80 1 file changed, 80 deletions(-) diff --git a/hw/i386/smbios.c b/hw/i

[Qemu-devel] [QEMU v6 PATCH 02/17] SMBIOS: Use macro to set smbios defaults

2014-04-14 Thread Gabriel L. Somlo
The function smbios_set_defaults() uses a repeating code pattern for each field. This patch replaces that pattern with a macro. Signed-off-by: Gabriel Somlo --- hw/i386/smbios.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/hw/i386/smbios.c b/hw/i386/smbio

[Qemu-devel] [QEMU v6 PATCH 01/17] SMBIOS: Rename smbios_set_type1_defaults() for more general use

2014-04-14 Thread Gabriel L. Somlo
Subsequent patches will utilize this function to set defaults for more smbios types than just type 1, so the function name should reflect this. Signed-off-by: Gabriel Somlo --- hw/i386/pc_piix.c| 12 ++-- hw/i386/pc_q35.c | 8 hw/i386/smbios.c | 4 ++--

[Qemu-devel] [Bug 1307656] Re: qemu segfault when starting virt-manager

2014-04-14 Thread Cole Robinson
Fix is already queued for qemu 2.0 GA commit 92b3eeadd9bc72f1f4e5ba1f62a289dc0190e88f Author: Cole Robinson Date: Thu Apr 10 14:47:38 2014 -0400 qom: Fix crash with qom-list and link properties ** Changed in: qemu Status: New => Incomplete ** Changed in: qemu Status: Incom

Re: [Qemu-devel] [Bug 1307656] [NEW] qemu segfault when starting virt-manager

2014-04-14 Thread Laszlo Ersek
On 04/14/14 20:47, Pieter Hollants wrote: > Public bug reported: > > libvirtd 1.2.3 > virt-manager 1.0.1 > qemu 1.7.92 (2.0.0-rc2) I think this should be fixed by Cole's patch, in rc3: commit 92b3eeadd9bc72f1f4e5ba1f62a289dc0190e88f Author: Cole Robinson Date: Thu Apr 10 14:47:38 2014 -0400

[Qemu-devel] [Bug 1307656] Re: qemu segfault when starting virt-manager

2014-04-14 Thread Peter Maydell
Judging by the backtrace this is the bug fixed by commit 92b3eeadd9bc, which is in current git master and will be in the imminent 2.0.0-rc3. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307656 Titl

[Qemu-devel] [Bug 1307656] Re: qemu segfault when starting virt-manager

2014-04-14 Thread Pieter Hollants
No crash BTW if virt-manager is started first and THEN "virsh start..." is executed. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307656 Title: qemu segfault when starting virt-manager Status in

[Qemu-devel] [Bug 1307656] [NEW] qemu segfault when starting virt-manager

2014-04-14 Thread Pieter Hollants
Public bug reported: libvirtd 1.2.3 virt-manager 1.0.1 qemu 1.7.92 (2.0.0-rc2) 1. Initially virt-manager is NOT running 2. I start a VM manually using "virsh start ...", causing a qemu instance to be run as /usr/bin/qemu-system-x86_64 -machine accel=kvm -name Zeus_Virtualized -S -machine pc-i44

[Qemu-devel] [Bug 1307656] Re: qemu segfault when starting virt-manager

2014-04-14 Thread Pieter Hollants
** Attachment added: "syslog excerpt related to VM starting / crash" https://bugs.launchpad.net/qemu/+bug/1307656/+attachment/4083720/+files/qemu-syslog -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bu

Re: [Qemu-devel] Qemu 1.7.1 - configure.log contains fatal errors

2014-04-14 Thread Peter Maydell
On 14 April 2014 21:06, New B wrote: > Hi, > > > Am I sending to the right forum/list? > > If not, I would appreciate if someone points me to the right one. No; you want qemu-devel@nongnu.org (cc'd). > I am new to qemu and have a few questions. > > Build Env Configuration: > mac os x machine run

[Qemu-devel] [SeaBIOS v3 PATCH] SMBIOS: Check for full tables & entry point in fw_cfg

2014-04-14 Thread Gabriel L. Somlo
Check fw_cfg for the presence of a complete set of smbios tables (etc/smbios/smbios-tables) and an entry point structure (etc/smbios/smbios-anchor), and, if found, use them instead of generating our own copies locally. We ensure the presence of a type 0 (bios information) structure by generating o

Re: [Qemu-devel] [PATCH 03/16] pci-assign: accept Error from monitor_handle_fd_param2()

2014-04-14 Thread Eric Blake
On 04/10/2014 02:24 AM, Laszlo Ersek wrote: > Propagate any errors in monitor fd handling up to get_real_device(), and > report them there. We'll continue the propagation upwards when > get_real_device() becomes a leaf itself (when none of its callees will > report errors internally any longer when

[Qemu-devel] [PULL 01/02] seccomp: add timerfd_create and timerfd_settime to the whitelist

2014-04-14 Thread Eduardo Otubo
From: Felix Geyer libusb calls timerfd_create() and timerfd_settime() when it's built with timerfd support. Command to reproduce: -device usb-host,hostbus=1,hostaddr=3,id=hostdev0 Log messages: audit(1390730418.924:135): auid=4294967295 uid=121 gid=103 ses=4294967295

Re: [Qemu-devel] [PATCH] Add remove_boot_device_path() function for hot-unplug device

2014-04-14 Thread Andreas Färber
Am 13.04.2014 15:24, schrieb Jun Li: > Add remove_boot_device_path() function to remove bootindex when hot-unplug > a device. This patch fixed virtio-blk/virtio-net/scsi-disk/scsi-generic > device. > So it has fixed bug1086603, ref: > https://bugzilla.redhat.com/show_bug.cgi?id=1086603 > > Signed

[Qemu-devel] [PULL 02/02] seccomp: add shmctl(), mlock(), and munlock() to the syscall whitelist

2014-04-14 Thread Eduardo Otubo
From: Paul Moore Additional testing reveals that PulseAudio requires shmctl() and the mlock()/munlock() syscalls on some systems/configurations. As before, on systems that do require these syscalls, the problem can be seen with the following command line: # qemu -monitor stdio -sandbox on \

[Qemu-devel] [PULL 00/02] seccomp: adding new syscalls to the whitelist

2014-04-14 Thread Eduardo Otubo
The following changes since commit 750036a848ea913ba6343718ffa70da98f7eef6b: Merge remote-tracking branch 'remotes/afaerber/tags/prep-for-upstream' into staging (2014-03-12 17:53:37 +) are available in the git repository at: git://github.com/otubo/qemu.git seccomp for you to fetch chan

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-14 Thread Igor Mammedov
On Mon, 14 Apr 2014 13:25:59 -0400 Paolo Bonzini wrote: > Il 11/04/2014 05:14, Igor Mammedov ha scritto: > > > > How about simply looking for a hotplug handler type device instead? > > > > We aren't likely to have many of these, are we? > >>> > > > >>> > > How about adding link to PCMa

[Qemu-devel] KVM call agenda for 2014-04-15

2014-04-14 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Thanks, Juan. Call details: 15:00 CEST 13:00 UTC 09:00 EDT Every two weeks If you need phone number details, contact me privately.

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-14 Thread Paolo Bonzini
Il 11/04/2014 05:14, Igor Mammedov ha scritto: > > > How about simply looking for a hotplug handler type device instead? > > > We aren't likely to have many of these, are we? > > > > How about adding link to PCMachine when it's created > > and use it instead of piix4_pm_find()/ich9_lpc_find() e

Re: [Qemu-devel] [PATCH v9 1/4] qapi: [trivial] Break long command lines

2014-04-14 Thread Lluís Vilanova
Eric Blake writes: > On 04/13/2014 01:07 PM, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova >> --- >> Makefile | 24 ++-- >> tests/Makefile | 20 >> 2 files changed, 34 insertions(+), 10 deletions(-) > Has this changed from v8? > https://

[Qemu-devel] Question on gdb breakpoint

2014-04-14 Thread MAdhavan Srinivasan
Hi team, I am trying to understand the gdb breakpoint support in qemu. i could see the arch_insert_sw_breakpoint adding a int3 opcode. But my question is, when the break is hit, how it is propagated to gdb server. I mean which routine or call is used from qemu to update the gdb server connected vi

Re: [Qemu-devel] Multi GPU passthrough via VFIO

2014-04-14 Thread Maik Broemme
Hi Alex, Maik Broemme wrote: > Hi Alex, > > Alex Williamson wrote: > > On Fri, 2014-02-14 at 01:01 +0100, Maik Broemme wrote: > > > Hi Alex, > > > > > > Maik Broemme wrote: > > > > Hi Alex, > > > > > > > > Alex Williamson wrote: > > > > > On Fri, 2014-02-07 at 01:22 +0100, Maik Broemme wrot

[Qemu-devel] [PATCH 0/1] ppc: use capabilities helper

2014-04-14 Thread Cornelia Huck
Hi Alex, here's my conversion of the existing ppc KVM_ENABLE_CAP users to the new helper functions, on top of my s390-next branch. Unfortunately, I have no environment to test this (and I haven't been able to setup a cross-build environment either). Also available on https://github.com/cohuck/q

[Qemu-devel] [PATCH 7/9] s390x/css: Don't save orb in subchannel.

2014-04-14 Thread Cornelia Huck
Current css code saves the operation request block (orb) in the subchannel structure for later consumption by the start function handler. This might make sense for asynchronous execution of the start function (which qemu doesn't support), but not in our case; it would even be wrong since orb contai

Re: [Qemu-devel] [PATCH v3 01/26] tcg-aarch64: Properly detect SIGSEGV writes

2014-04-14 Thread Richard Henderson
On 04/14/2014 04:32 AM, Claudio Fontana wrote: > the problem is not in the two nibbles you show, but in the third nibble: > 31 30 29 28 27 26 25 24 23 22 21 20 > size 1 1 1 v 0 0 opc 0 x > > the third nibble in your mask is 'E' and the expected result is 0, which > forces opc to be

[Qemu-devel] [PATCH 9/9] s390x/kvm: sync gbea and pp register

2014-04-14 Thread Cornelia Huck
From: Christian Borntraeger We also need to sync guest breaking event address and program parameter register for migration support. Signed-off-by: Christian Borntraeger Reviewed-by: Jason J. Herne Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- target-s390x/cpu.h |3 +++ targe

[Qemu-devel] [PATCH 6/9] s390x/virtio-ccw: Wire up irq routing and irqfds.

2014-04-14 Thread Cornelia Huck
Make use of the new s390 adapter irq routing support to enable real in-kernel irqfds for virtio-ccw with adapter interrupts. Note that s390 doesn't provide the common KVM_CAP_IRQCHIP capability, but rather needs KVM_CAP_S390_IRQCHIP to be enabled. This is to ensure backward compatibility. Reviewe

[Qemu-devel] [PATCH 1/1] ppc: use kvm_enable_cap_vcpu()

2014-04-14 Thread Cornelia Huck
Convert existing users of KVM_ENABLE_CAP to new helper. Signed-off-by: Cornelia Huck --- hw/intc/openpic_kvm.c |8 ++-- hw/intc/xics_kvm.c|8 ++-- target-ppc/kvm.c | 21 - 3 files changed, 8 insertions(+), 29 deletions(-) diff --git a/hw/intc/openp

[Qemu-devel] [PATCH 3/9] s390x: use kvm_enable_cap_vcpu()

2014-04-14 Thread Cornelia Huck
Make kvm_s390_enable_css_support() use new interface. Signed-off-by: Cornelia Huck --- target-s390x/kvm.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c index 56b9af7..fbdc1bb 100644 --- a/target-s390x/kvm.c +++ b/target-s390x/kv

[Qemu-devel] [PATCH 4/9] s390x: Add I/O adapter registration.

2014-04-14 Thread Cornelia Huck
Register an I/O adapter interrupt source for when virtio-ccw devices start using adapter interrupts. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- hw/intc/s390_flic.c | 59 + hw/s390x/css.c| 51 +++

[Qemu-devel] [PATCH 2/9] kvm: add kvm_enable_cap_{vm,vcpu}

2014-04-14 Thread Cornelia Huck
Provide helper functions for enabling capabilities (on a vcpu and on a vm). Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- include/sysemu/kvm.h |4 kvm-all.c| 33 - 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/i

[Qemu-devel] [PATCH 8/9] s390x/kvm: rework KVM synchronize to tracing for some ONEREGS

2014-04-14 Thread Cornelia Huck
From: Christian Borntraeger Some ONE_REGS on s390 are not protected by a capability. Older kernels might not provide those and return an error. Fortunately these registers are only critical for the migration path. There is no need to error out on reset and normal runtime. Furthermore, these kerne

[Qemu-devel] [PATCH 5/9] s390x/virtio-ccw: reference-counted indicators

2014-04-14 Thread Cornelia Huck
Make code using the same indicators point to a single allocated structure that is freed when the last user goes away. This will be used by the irqfd code to unmap addresses after the last user is gone. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- hw/s390x/virtio-ccw.c | 80 +

[Qemu-devel] [PATCH 1/9] linux-headers: update

2014-04-14 Thread Cornelia Huck
Base is 7cbb39d4d4d530dff12f2ff06ed6c85c504ba91a. Gets several new interfaces: Per-vm capability enablement, adapter interrupt sources, irq routing on s390. Signed-off-by: Cornelia Huck --- linux-headers/asm-s390/kvm.h | 24 linux-headers/linux/kvm.h| 17 +++

[Qemu-devel] [PATCH 0/9] s390x: pending patches

2014-04-14 Thread Cornelia Huck
Here's my current s390x patch queue, also available on https://github.com/cohuck/qemu.git s390-next - linux-headers update for registers, capabilites and irqfds - capability work; the helper functions are now flexible enough to provide an interface for adding arguments as well (will be used by

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-04-14 Thread Igor Mammedov
On Mon, 14 Apr 2014 15:25:01 +0800 Hu Tao wrote: > On Fri, Apr 04, 2014 at 03:36:58PM +0200, Igor Mammedov wrote: > > Needed for Windows to use hotplugged memory device, otherwise > > it complains that server is not configured for memory hotplug. > > Tests shows that aftewards it uses dynamically

Re: [Qemu-devel] [PATCH 09/35] qdev: expose DeviceState.hotplugged field as a property

2014-04-14 Thread Igor Mammedov
On Mon, 14 Apr 2014 18:02:32 +0200 Andreas Färber wrote: > Am 04.04.2014 15:36, schrieb Igor Mammedov: > > so that managment could detect via QOM interface if device was > > "management" Thanks, I'll fix it. > > > hotplugged > > > > Signed-off-by: Igor Mammedov > > --- > > hw/core/qdev.c |

Re: [Qemu-devel] [PATCH 2/2] ivshmem: validate incoming_posn value from server

2014-04-14 Thread Andreas Färber
Am 14.04.2014 16:26, schrieb Peter Maydell: > On 31 March 2014 08:08, Stefan Hajnoczi wrote: >> Check incoming_posn to avoid out-of-bounds array accesses if the ivshmem >> server on the host sends invalid values. >> >> Cc: Cam Macdonell >> Reported-by: Sebastian Krahmer >> Signed-off-by: Stefan

Re: [Qemu-devel] [Qemu-ppc] [RFC 00/12] target-ppc: Decimal Floating Point

2014-04-14 Thread Laurent Desnogues
Hi, sorry for being late into the discussion. Couldn't Intel Decimal Floating-Point Math Library be used? It seems to be using a BSD license. http://www.netlib.org/misc/intel/ Laurent

Re: [Qemu-devel] [PATCH] Add remove_boot_device_path() function for hot-unplug device

2014-04-14 Thread Markus Armbruster
lijun writes: > Hi Markus, > Really appreciate your review first. I almost a new participant. And > I read other's patches very little. So maybe this patch is duplicate > to one of Marcel's patch. But I really do not know. And I really don't > copying Marcel's. This is my own analysis. When I m

Re: [Qemu-devel] [PATCH 02/16] monitor: add Error-propagating monitor_handle_fd_param2()

2014-04-14 Thread Eric Blake
On 04/10/2014 02:24 AM, Laszlo Ersek wrote: > and rebase monitor_handle_fd_param() to it. (Note that this will slightly > change the behavior when the qemu_parse_fd() branch is selected and it > fails: we now report (and in case of QMP, set) the error immediately, > rather than allowing the caller

Re: [Qemu-devel] [PATCH v2 1/1] Disallow outward migration while awaiting incoming migration

2014-04-14 Thread Eric Blake
On 04/14/2014 10:03 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > QEMU will assert if you attempt to start an outgoing migration on > a QEMU that's sitting waiting for an incoming migration (started > with -incoming), so disallow it with a proper error. > > (This i

Re: [Qemu-devel] [PATCH v2 1/1] Disallow outward migration while awaiting incoming migration

2014-04-14 Thread Andreas Färber
Am 14.04.2014 18:03, schrieb Dr. David Alan Gilbert (git): > From: "Dr. David Alan Gilbert" > > QEMU will assert if you attempt to start an outgoing migration on > a QEMU that's sitting waiting for an incoming migration (started > with -incoming), so disallow it with a proper error. > > (This is

[Qemu-devel] [PATCH v2 1/1] Disallow outward migration while awaiting incoming migration

2014-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" QEMU will assert if you attempt to start an outgoing migration on a QEMU that's sitting waiting for an incoming migration (started with -incoming), so disallow it with a proper error. (This is a fix for https://bugzilla.redhat.com/show_bug.cgi?id=1086987 ) Signed-

Re: [Qemu-devel] [PATCH 09/35] qdev: expose DeviceState.hotplugged field as a property

2014-04-14 Thread Andreas Färber
Am 04.04.2014 15:36, schrieb Igor Mammedov: > so that managment could detect via QOM interface if device was "management" > hotplugged > > Signed-off-by: Igor Mammedov > --- > hw/core/qdev.c | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/hw/core/qdev.c b/hw/core/q

Re: [Qemu-devel] [PATCH 08/35] qdev: hotplug for buss-less devices

2014-04-14 Thread Andreas Färber
Am 07.04.2014 04:26, schrieb Alexey Kardashevskiy: > Why not to make a memory controller + bus instead? I thought this is the > preferred approach in qom'ed QEMU :) That's the historic approach of qdev, not QOM. See: http://www.linux-kvm.org/wiki/images/0/0b/Kvm-forum-2013-Modern-QEMU-devices.pd

Re: [Qemu-devel] '.' IDs and certain names breaks -global and -set

2014-04-14 Thread Andreas Färber
Am 14.04.2014 09:13, schrieb Markus Armbruster: > Alistair Francis writes: > >> On Wed, Apr 9, 2014 at 9:58 PM, Peter Crosthwaite >> wrote: >>> On Wed, Apr 9, 2014 at 7:56 PM, Markus Armbruster wrote: We have a number of device model names containing '.'. They're unusable with -globa

Re: [Qemu-devel] [PATCH 1/2] ivshmem: check ivshmem_read() size argument

2014-04-14 Thread Andreas Färber
Am 14.04.2014 17:33, schrieb Peter Maydell: > On 31 March 2014 08:08, Stefan Hajnoczi wrote: >> The third argument to the fd_read() callback implemented by >> ivshmem_read() is the number of bytes, not a flags field. Fix this and >> check we received enough bytes before accessing the buffer point

Re: [Qemu-devel] [PATCH 1/8] spapr-iommu: add a bus for spapr-iommu devices

2014-04-14 Thread Alexey Kardashevskiy
On 04/15/2014 01:16 AM, Andreas Färber wrote: > Am 10.04.2014 17:18, schrieb Alexey Kardashevskiy: >> On 04/11/2014 12:52 AM, Andreas Färber wrote: >>> Am 10.04.2014 16:40, schrieb Alexey Kardashevskiy: On 04/10/2014 10:40 PM, Alexander Graf wrote: > > Juan, is a different command line

Re: [Qemu-devel] [PATCH 1/1] Disallow outward migration while awaiting incoming migration

2014-04-14 Thread Andreas Färber
Am 14.04.2014 17:16, schrieb Dr. David Alan Gilbert (git): > From: "Dr. David Alan Gilbert" > > QEMU will assert if you attempt to start an outgoing migration on > a QEMU that's sitting waiting for an incoming migration (started > with -incoming), so disallow it with a proper error. > > (This is

Re: [Qemu-devel] [PATCH 1/2] ivshmem: check ivshmem_read() size argument

2014-04-14 Thread Peter Maydell
On 31 March 2014 08:08, Stefan Hajnoczi wrote: > The third argument to the fd_read() callback implemented by > ivshmem_read() is the number of bytes, not a flags field. Fix this and > check we received enough bytes before accessing the buffer pointer. > > Cc: Cam Macdonell > Reported-by: Sebasti

Re: [Qemu-devel] [Qemu-ppc] [RFC 00/12] target-ppc: Decimal Floating Point

2014-04-14 Thread Tom Musta
Thank you, Eric, for the clarification.

  1   2   3   >