Re: [Qemu-devel] [PATCH v1 10/22] target-arm: A64: Introduce arm64_banked_spsr_index()

On Fri, May 16, 2014 at 03:31:16PM +0100, Peter Maydell wrote: > On 6 May 2014 07:08, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Add arm64_banked_spsr_index(), used to map an Exception Level > > to an index in the baked_spsr array. > > > > Signed-off-by: Edgar E. Iglesias > >

Re: [Qemu-devel] [PATCH 8/9] spapr: Implement processor compatibility in ibm, client-architecture-support

On 05/17/2014 06:46 AM, Alexander Graf wrote: > > On 16.05.14 17:57, Alexey Kardashevskiy wrote: >> On 05/17/2014 12:16 AM, Alexander Graf wrote: >>> On 15.05.14 13:28, Alexey Kardashevskiy wrote: Modern Linux kernels support last POWERPC CPUs so when a kernel boots, in most cases it can

Re: [Qemu-devel] [PATCH v1 19/22] target-arm: Add storage for VBAR_EL2 and 3

On Fri, May 16, 2014 at 03:40:22PM +0100, Peter Maydell wrote: > On 6 May 2014 07:08, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/cpu.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/targe

Re: [Qemu-devel] [PATCH v1 05/22] target-arm: Add arm_el_to_mmu_idx()

On Sat, May 17, 2014 at 12:13:06AM +0200, Alexander Graf wrote: > > On 17.05.14 00:10, Edgar E. Iglesias wrote: > >On Fri, May 16, 2014 at 03:24:42PM +0100, Peter Maydell wrote: > >>On 6 May 2014 07:08, Edgar E. Iglesias wrote: > >>>From: "Edgar E. Iglesias" > >>> > >>>Maps a given EL to the cor

[Qemu-devel] [Bug 1320360] Re: usb passthrough not working anymore

Be sure to add the -usb option. What is your command line? See also http://git.qemu.org/?p=qemu.git;a=blob;f=docs/usb2.txt;h=c7a445afcd55fe1f12033d529d668a1306d5a9f4;hb=HEAD#l111 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:

Re: [Qemu-devel] [PATCH v1 02/22] target-arm: Make elr_el1 an array

On Fri, May 16, 2014 at 03:19:36PM +0100, Peter Maydell wrote: > On 8 May 2014 01:13, Edgar E. Iglesias wrote: > > On Wed, May 07, 2014 at 03:10:54PM +1000, Peter Crosthwaite wrote: > >> On Tue, May 6, 2014 at 4:08 PM, Edgar E. Iglesias > >> wrote: > >> > From: "Edgar E. Iglesias" > >> > > >> >

Re: [Qemu-devel] [PATCH v1 02/22] target-arm: Make elr_el1 an array

On Fri, May 16, 2014 at 03:22:40PM +0100, Peter Maydell wrote: > On 6 May 2014 07:08, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > No functional change. > > Prepares for future additions of the EL2 and 3 versions of this reg. > > > --- a/target-arm/machine.c > > +++ b/target-ar

Re: [Qemu-devel] [PATCH v1 05/22] target-arm: Add arm_el_to_mmu_idx()

On 17.05.14 00:10, Edgar E. Iglesias wrote: On Fri, May 16, 2014 at 03:24:42PM +0100, Peter Maydell wrote: On 6 May 2014 07:08, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Maps a given EL to the corresponding MMU index. Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h

Re: [Qemu-devel] [PATCH v1 05/22] target-arm: Add arm_el_to_mmu_idx()

On Fri, May 16, 2014 at 03:24:42PM +0100, Peter Maydell wrote: > On 6 May 2014 07:08, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Maps a given EL to the corresponding MMU index. > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/cpu.h | 21 +

[Qemu-devel] [Bug 1320360] [NEW] usb passthrough not working anymore

Public bug reported: Hi, I'm using qemu 2.0.0 with opensuse 13.1 x84_64 bit as host and window7 as guest. Til qemu version 1.6.2 USB passthrough works perfectly, but starting with qemu 2.0.0 passthrough stop working. I can still add the usb device but when I start the guest following message appe

Re: [Qemu-devel] [PATCH 4/9] target-ppc: Implement "compat" CPU option

On 16.05.14 17:17, Alexey Kardashevskiy wrote: On 05/17/2014 12:05 AM, Alexander Graf wrote: On 15.05.14 13:28, Alexey Kardashevskiy wrote: This adds basic support for the "compat" CPU option. By specifying the compat property, the user can manually switch guest CPU mode from "raw" to "archite

Re: [Qemu-devel] [PATCH 8/9] spapr: Implement processor compatibility in ibm, client-architecture-support

On 16.05.14 17:57, Alexey Kardashevskiy wrote: On 05/17/2014 12:16 AM, Alexander Graf wrote: On 15.05.14 13:28, Alexey Kardashevskiy wrote: Modern Linux kernels support last POWERPC CPUs so when a kernel boots, in most cases it can find a matching cpu_spec in the kernel's cpu_specs list. Howev

Re: [Qemu-devel] [PATCH v1 RFC 3/6] KVM: s390: use facilities and cpu_id per KVM

On 16.05.14 18:09, Michael Mueller wrote: On Fri, 16 May 2014 16:49:37 +0200 Alexander Graf wrote: On 16.05.14 16:46, Michael Mueller wrote: On Fri, 16 May 2014 13:55:41 +0200 Alexander Graf wrote: On 13.05.14 16:58, Michael Mueller wrote: The patch introduces facilities and cpu_ids per

Re: [Qemu-devel] [Qemu-ppc] macio ide question/bug report

On Fri, 16 May 2014, Mark Cave-Ayland wrote: Perhaps we need to assume for a non-IO DMA request that the result will only be a single ATAPI reply packet? Attached is another version of the patch for you to experiment with which makes your s->io_buffer_size change but also moves the logic into p

Re: [Qemu-devel] [PATCH v1 RFC 6/6] KVM: s390: add cpu model support

On 16.05.14 17:39, Michael Mueller wrote: On Fri, 16 May 2014 14:08:24 +0200 Alexander Graf wrote: On 13.05.14 16:58, Michael Mueller wrote: This patch enables cpu model support in kvm/s390 via the vm attribute interface. During KVM initialization, the host properties cpuid, IBC value and t

[Qemu-devel] [PATCH 2/3] target-i386: rework CPL checks during task switch, preparing for next patch

During task switch, all of CS.DPL, CS.RPL, SS.DPL must match (in addition to all the other requirements) and will be the new CPL. So far this worked by carefully setting the CS selector and flags before doing the task switch; but this will not work once we get the CPL from SS.DPL. Temporarily ass

[Qemu-devel] [PATCH 1/3] target-i386: fix segment flags for SMM, user-mode emulation and VM86 mode

With the next patch, these need to be correct or VM86 tasks have the wrong CPL. The flags are basically what the Intel VMX documentation say is mandatory for entry into a VM86 guest. The CPL also needs to be set before the user-mode segments in linux-user and bsd-user. For consistency, SMM ought

[Qemu-devel] [PATCH 3/3] target-i386: get CPL from SS.DPL

CS.RPL is not equal to the CPL in the few instructions between setting CR0.PE and reloading CS. We get this right in the common case, because writes to CR0 do not modify the CPL, but it would not be enough if an SMI comes exactly during that brief period. Were this to happen, the RSM instruction w

[Qemu-devel] [PATCH v2 0/3] target-i386: fix CPL computation

CS.RPL is not equal to the CPL in the few instructions between setting CR0.PE and reloading CS. We get this right in the common case, because writes to CR0 do not modify the CPL, but it would not be enough if an SMI comes exactly during that brief period. So this patch fixes the CPL to come from

Re: [Qemu-devel] [PATCH 1/4] machine: conversion of QEMUMachineInitArgs to MachineState

Am 16.05.2014 18:20, schrieb Igor Mammedov: > On Wed, 7 May 2014 17:42:57 +0300 > Marcel Apfelbaum wrote: > >> Total removal of QEMUMachineInitArgs struct. QEMUMachineInitArgs's fields >> are copied into MachineState. Removed duplicated fields from MachineState. >> >> All the other changes are o

[Qemu-devel] [PATCH 1/2] target-mips: pass CPUMIPSState to gen_mfc0/mtc0/dmfc0/dmtc0

From: Petar Jovanovic Add CPUMIPSState in gen_mfc0/mtc0/dmfc0/dmtc0, as it will be used in the next patch that implements UserLocal register and access to it. Signed-off-by: Petar Jovanovic --- target-mips/translate.c | 44 1 file changed, 24 inse

[Qemu-devel] [PATCH 0/2] implementation of UserLocal register for MIPS

This is a small series of two patches. One expands the number of arguments for gen_mfc0(), gen_mtc0(), gen_dmfc0(), and gen_dmtc0(), and the second patch actually implements the register and access to it. Regards, Petar Petar Jovanovic (2): target-mips: pass CPUMIPSState to gen_mfc0/mtc0/dmfc0/

[Qemu-devel] [PATCH 2/2] target-mips: implement UserLocal Register

From: Petar Jovanovic >From MIPS documentation (Volume III): UserLocal Register (CP0 Register 4, Select 2) Compliance Level: Recommended. The UserLocal register is a read-write register that is not interpreted by the hardware and conditionally readable via the RDHWR instruction. This register

Re: [Qemu-devel] [PATCH v5] glib: fix g_poll early timeout on windows

Am 16.05.2014 13:32, schrieb Paolo Bonzini: > Il 16/05/2014 07:00, Stefan Weil ha scritto: >> Hi, >> >> the patch breaks hard disk i/o: a 64 bit executable built with MinGW-w64 >> will no longer boot a ReactOS image (BIOS fails to detect a bootable >> disk). Booting a Linux CDROM seems to work and

[Qemu-devel] [qom-cpu PATCH v2 0/2] target-i386: Fixes for migratable/invtsc

This series contains two fixes for the qom-cpu branch: * Make the new "migratable" property actually work; * Avoid breaking setups where "-cpu host" needs to be migratable. (See discussion at http://marc.info/?l=qemu-devel&m=139838802220184&w=2 ) Cc: Andreas Färber Cc: Marcelo Tosatti Cc:

[Qemu-devel] [qom-cpu PATCH v2 1/2] target-i386: Use x86_cpu_get_supported_feature_word() for "-cpu host"

This will make "-cpu host" reuse the feature filtering logic used by x86_cpu_filter_features() (i.e. TCG support, and the new "migratable" flag). This doesn't add "-cpu host" support to TCG mode yet, but that may be possible eventually. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 7 +

[Qemu-devel] [qom-cpu PATCH v2 2/2] target-i386: Set migratable=yes by default on "host" CPU mooel

Having only migratable flags reported by default on the "host" CPU model is safer for the following reasons: * Existing users may expect "-cpu host" to be migration-safe, if they take care of always using compatible host CPUs, host kernels, and QEMU versions. * Users who don't care aboug m

Re: [Qemu-devel] [PATCH] target-arm: implement CPACR register logic

On 16 May 2014 11:01, Fabian Aggeler wrote: > From: Sergey Fedorov > > CPACR register allows to control access rights to coprocessor 0-13 > interfaces. Bits corresponding to unimplemented coprocessors should be > RAZ/WI. QEMU implements only VFP coprocessor on ARMv6+ targets. So only > cp10 & cp1

Re: [Qemu-devel] [PATCH v4 17/18] target-i386: block migration and savevm if invariant tsc is exposed

On Fri, May 16, 2014 at 12:36:49PM -0300, Eduardo Habkost wrote: [...] > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index f9ffa4b..7099a51 100644 > --- a/target-i386/kvm.c > +++ b/target-i386/kvm.c > @@ -710,8 +710,8 @@ int kvm_arch_init_vcpu(CPUState *cs) > c = cpuid_find_entry(&cpu

Re: [Qemu-devel] [PATCH v4 14/18] target-i386: Add "migratable" property to "host" CPU model

On Fri, May 16, 2014 at 06:29:36PM +0200, Andreas Färber wrote: > Am 16.05.2014 18:13, schrieb Eduardo Habkost: > > On Fri, May 16, 2014 at 12:12:18AM +0200, Andreas Färber wrote: > >> Am 15.05.2014 22:26, schrieb Eduardo Habkost: > >>> On Thu, May 15, 2014 at 09:44:49PM +0200, Andreas Färber wrote

Re: [Qemu-devel] [PATCH 1/5] block: Auto-generate node_names for each BDS entry

Am 16.05.2014 um 14:47 hat Eric Blake geschrieben: > On 05/16/2014 05:35 AM, Jeff Cody wrote: > > > > > How does libvirt assign node-names to all the backing images in a > > qcow2 chain, for example? > > We have the ability to do both command-line and QMP hotplug addition of > drives where you c

Re: [Qemu-devel] [PATCH] target-arm: implement CPACR register logic

On Fri, May 16, 2014 at 10:01 AM, Fabian Aggeler wrote: > From: Sergey Fedorov > > CPACR register allows to control access rights to coprocessor 0-13 > interfaces. Bits corresponding to unimplemented coprocessors should be > RAZ/WI. QEMU implements only VFP coprocessor on ARMv6+ targets. So only

Re: [Qemu-devel] [PATCH v1 2/3] memory: Add sysbus memory device

On Fri, May 16, 2014 at 3:22 PM, Andreas Färber wrote: > Peter, > > Am 15.04.2014 04:21, schrieb Peter Crosthwaite: >> Add a sysbus device consisting of a single ram. This allows for >> instantiation of RAM just like any other device. There are a number >> of good reasons to want to do this this:

Re: [Qemu-devel] [PATCH v4 14/18] target-i386: Add "migratable" property to "host" CPU model

Am 16.05.2014 18:13, schrieb Eduardo Habkost: > On Fri, May 16, 2014 at 12:12:18AM +0200, Andreas Färber wrote: >> Am 15.05.2014 22:26, schrieb Eduardo Habkost: >>> On Thu, May 15, 2014 at 09:44:49PM +0200, Andreas Färber wrote: Am 30.04.2014 18:48, schrieb Eduardo Habkost: > This flag wil

[Qemu-devel] [PULL 07/20] qapi-visit.py: Clean up a sloppy use of field prefix

From: Markus Armbruster generate_visit_struct_fields() generates the base type's struct member name both with and without the field prefix. Harmless, because the field prefix is always empty there: only unboxed complex members have a prefix, and those can't have a base type. Clean it up anyway.

[Qemu-devel] [PULL 02/20] qapi: Normalize marshalling's visitor initialization and cleanup

From: Markus Armbruster Input and output marshalling functions do it differently. Change them to work the same: initialize the I/O visitor, use it, clean it up, initialize the dealloc visitor, use it, clean it up. This delays dealloc visitor initialization in output marshalling functions, and i

[Qemu-devel] [PULL 00/20] QMP queue

The following changes since commit 16a9189921bdb9e351f2f9baec16b376f8d71cdf: Merge remote-tracking branch 'remotes/kraxel/tags/pull-roms-2' into staging (2014-05-15 18:32:16 +0100) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch ch

Re: [Qemu-devel] [PATCH 1/4] machine: conversion of QEMUMachineInitArgs to MachineState

On Wed, 7 May 2014 17:42:57 +0300 Marcel Apfelbaum wrote: > Total removal of QEMUMachineInitArgs struct. QEMUMachineInitArgs's fields > are copied into MachineState. Removed duplicated fields from MachineState. > > All the other changes are only mechanical refactoring, no semantic changes. > >

[Qemu-devel] [PULL 04/20] qapi: Replace start_optional()/end_optional() by optional()

From: Markus Armbruster Semantics of end_optional() differ subtly from the other end_FOO() callbacks: when start_FOO() succeeds, the matching end_FOO() gets called regardless of what happens in between. end_optional() gets called only when everything in between succeeds as well. Entirely undocu

[Qemu-devel] [PULL 10/20] hw: Don't call visit_end_struct() after visit_start_struct() fails

From: Markus Armbruster When visit_start_struct() fails, visit_end_struct() must not be called. rtc_get_date() and balloon_stats_all() call it anyway. As far as I can tell, they're only used with the string output visitor, which doesn't care. Fix them anyway. Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v4 14/18] target-i386: Add "migratable" property to "host" CPU model

On Fri, May 16, 2014 at 12:12:18AM +0200, Andreas Färber wrote: > Am 15.05.2014 22:26, schrieb Eduardo Habkost: > > On Thu, May 15, 2014 at 09:44:49PM +0200, Andreas Färber wrote: > >> Am 30.04.2014 18:48, schrieb Eduardo Habkost: > >>> This flag will allow the user to choose between two modes: > >

Re: [Qemu-devel] [PATCH v1 RFC 3/6] KVM: s390: use facilities and cpu_id per KVM

On Fri, 16 May 2014 16:49:37 +0200 Alexander Graf wrote: > > On 16.05.14 16:46, Michael Mueller wrote: > > On Fri, 16 May 2014 13:55:41 +0200 > > Alexander Graf wrote: > > > >> On 13.05.14 16:58, Michael Mueller wrote: > >>> The patch introduces facilities and cpu_ids per virtual machine. > >>>

[Qemu-devel] [PULL 06/20] qapi: Clean up shadowing of parameters and locals in inner scopes

From: Markus Armbruster By un-inlining the visit of nested complex types. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- scripts/qapi-visit.py | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/scripts/qapi-v

Re: [Qemu-devel] [PATCH 8/9] spapr: Implement processor compatibility in ibm, client-architecture-support

On 05/17/2014 12:16 AM, Alexander Graf wrote: > > On 15.05.14 13:28, Alexey Kardashevskiy wrote: >> Modern Linux kernels support last POWERPC CPUs so when a kernel boots, >> in most cases it can find a matching cpu_spec in the kernel's cpu_specs >> list. However if the kernel is quite old, it may

Re: [Qemu-devel] vfio - bind failure : user space recovery

[cc+ kvm] (kvm is the proper list for non-QEMU related vfio) On Fri, 2014-05-16 at 08:01 -0700, Saptarshi Sen wrote: > I am using a driver from user-space using vfio. > During intensive testing, when my application crashes. > I try to re-run the same, when I get a bind-failure. > Error code, is E

Re: [Qemu-devel] [PATCH 0/2] Two simple Coverity defect patches

Il 16/05/2014 17:44, Markus Armbruster ha scritto: Markus Armbruster (2): scsi: Document intentional fall through in scsi_req_length() virtio-scsi: Plug memory leak on virtio_scsi_push_event() error path hw/scsi/scsi-bus.c| 2 ++ hw/scsi/virtio-scsi.c | 3 ++- 2 files changed, 4 inserti

Re: [Qemu-devel] [PATCH 2/2] virtio-scsi: Plug memory leak on virtio_scsi_push_event() error path

Il 16/05/2014 17:44, Markus Armbruster ha scritto: Spotted by Coverity. Signed-off-by: Markus Armbruster --- hw/scsi/virtio-scsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 1752193..14261fb 100644 --- a/hw/scsi/vir

[Qemu-devel] [PULL 05/20] qapi-visit.py: Clean up confusing push_indent() / pop_indent() use

From: Markus Armbruster Changing implicit indentation in the middle of generating a block makes following the code being generated unnecessarily hard. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- scripts/qapi-visit.py | 32 ++

[Qemu-devel] [PATCH 2/2] virtio-scsi: Plug memory leak on virtio_scsi_push_event() error path

Spotted by Coverity. Signed-off-by: Markus Armbruster --- hw/scsi/virtio-scsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 1752193..14261fb 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -498,7 +498

[Qemu-devel] [PATCH 1/2] scsi: Document intentional fall through in scsi_req_length()

For clarity, and to hush up Coverity. Signed-off-by: Markus Armbruster --- hw/scsi/scsi-bus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index abe7302..06399fa 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -938,6 +938,7 @@ static i

[Qemu-devel] [PATCH 0/2] Two simple Coverity defect patches

Markus Armbruster (2): scsi: Document intentional fall through in scsi_req_length() virtio-scsi: Plug memory leak on virtio_scsi_push_event() error path hw/scsi/scsi-bus.c| 2 ++ hw/scsi/virtio-scsi.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) -- 1.8.1.4

[Qemu-devel] [PULL 17/20] monitor: Add set_link arguments completion.

From: Hani Benhabiles Make it possible to query all net clients without specifying an ID when calling qemu_find_net_clients_except(). This also adds the add_completion_option() function which is to be used for other commands completions as well. Signed-off-by: Hani Benhabiles Reviewed-by: Stef

[Qemu-devel] [PULL 03/20] qapi: Remove unused Visitor callbacks start_handle(), end_handle()

From: Markus Armbruster These have never been called or implemented by anything, and their intended use is undocumented, like all of the visitor API. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- include/qapi/visitor-impl.h | 3 --- qapi/qapi-vi

Re: [Qemu-devel] [PATCH v1 RFC 6/6] KVM: s390: add cpu model support

On Fri, 16 May 2014 14:08:24 +0200 Alexander Graf wrote: > > On 13.05.14 16:58, Michael Mueller wrote: > > This patch enables cpu model support in kvm/s390 via the vm attribute > > interface. > > > > During KVM initialization, the host properties cpuid, IBC value and the > > facility list are st

Re: [Qemu-devel] [PATCH v2] qmp: object-add: Validate class before creating object

Am 25.04.2014 21:16, schrieb Eduardo Habkost: > On Fri, Apr 25, 2014 at 08:42:59PM +0200, Andreas Färber wrote: >> Am 25.04.2014 20:02, schrieb Luiz Capitulino: >>> On Fri, 25 Apr 2014 17:57:12 +0200 >>> Andreas Färber wrote: Am 25.04.2014 17:12, schrieb Luiz Capitulino: > On Wed, 16 Apr

Re: [Qemu-devel] dump-guest-memory command?

On 05/16/14 15:01, Jun Koi wrote: > > > > On Fri, May 16, 2014 at 7:30 PM, Laszlo Ersek > wrote: > > On 05/16/14 11:59, Jun Koi wrote: > > > - is it true that dump-guest-memory just write down physical memory > > page, and does not consider the virtual-me

[Qemu-devel] [PULL 18/20] monitor: Add netdev_add type argument completion.

From: Hani Benhabiles Also update the command's documentation. Signed-off-by: Hani Benhabiles Reviewed-by: Stefan Hajnoczi Signed-off-by: Luiz Capitulino --- hmp-commands.hx | 3 ++- hmp.h | 1 + monitor.c | 15 +++ 3 files changed, 18 insertions(+), 1 deletion(

[Qemu-devel] [RFC PATCH v3 04/13] icount: introduce icount timer.

From: KONRAD Frederic This introduces a new timer based only on instruction counter and without any compensation. Signed-off-by: KONRAD Frederic --- cpus.c | 19 --- include/qemu/timer.h | 9 - qemu-timer.c | 8 +++- stubs/cpu-get-icoun

Re: [Qemu-devel] [PATCH v4 17/18] target-i386: block migration and savevm if invariant tsc is exposed

On Fri, May 16, 2014 at 11:05:28AM +0200, Andreas Färber wrote: > Am 15.05.2014 22:22, schrieb Andreas Färber: > > Am 30.04.2014 18:48, schrieb Eduardo Habkost: > >> From: Marcelo Tosatti > >> > >> Invariant TSC documentation mentions that "invariant TSC will run at a > >> constant rate in all ACP

[Qemu-devel] [PULL 19/20] monitor: Add netdev_del id argument completion.

From: Hani Benhabiles Signed-off-by: Hani Benhabiles Reviewed-by: Stefan Hajnoczi Signed-off-by: Luiz Capitulino --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 26 ++ 3 files changed, 28 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.

[Qemu-devel] [PULL 09/20] hmp: Call visit_end_struct() after visit_start_struct() succeeds

From: Markus Armbruster When visit_start_struct() succeeds, visit_end_struct() must be called. hmp_object_add() doesn't when a member visit fails. As far as I can tell, the opts visitor copes okay with the misuse. Fix it anyway. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed

[Qemu-devel] [PULL 15/20] monitor: Add chardev-remove command completion.

From: Hani Benhabiles Signed-off-by: Hani Benhabiles Signed-off-by: Luiz Capitulino --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 23 +++ 3 files changed, 25 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index b4b23c8..ba88e2a 100644

[Qemu-devel] [PULL 12/20] qapi: Replace uncommon use of the error API by the common one

From: Markus Armbruster We commonly use the error API like this: err = NULL; foo(..., &err); if (err) { goto out; } bar(..., &err); Every error source is checked separately. The second function is only called when the first one succeeds. Both functions are free to

[Qemu-devel] [PULL 16/20] monitor: Add chardev-add backend argument completion.

From: Hani Benhabiles Signed-off-by: Hani Benhabiles Signed-off-by: Luiz Capitulino --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 23 +++ 3 files changed, 25 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index ba88e2a..93fa534 100644

[Qemu-devel] [RFC PATCH v3 06/13] icount: make icount extra computed on icount clock as well.

From: KONRAD Frederic This takes icount clock in account for icount extra computation so icount clock's timers will be triggered at the exact time. Signed-off-by: KONRAD Frederic Reviewed-by: Paolo Bonzini --- cpus.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/cpus.c b/cpu

[Qemu-devel] [RFC PATCH v3 00/13] Reverse execution.

From: KONRAD Frederic Hi everybody, Sorry for the delay. This is the third version of this RFC (see the changes below). Those are the two first patch-set we have been worked on for reverse execution. The first series: icount: put icount variables into TimerState. migration: migrate icount

[Qemu-devel] [PULL 20/20] qapi: skip redundant includes

From: Benoît Canet The purpose of this change is to help create a json file containing common definitions; each bit of generated C code must be emitted only one time. A second history global to all QAPISchema instances has been added to detect when a file is included more than one time and skip

[Qemu-devel] [PULL 11/20] tests: Don't call visit_end_struct() after visit_start_struct() fails

From: Markus Armbruster When visit_start_struct() fails, visit_end_struct() must not be called. Three out of four visit_type_TestStruct() call it anyway. As far as I can tell, visit_start_struct() doesn't actually fail there. Fix them anyway. Signed-off-by: Markus Armbruster Reviewed-by: Eric

[Qemu-devel] [PULL 08/20] qapi: Un-inline visit of implicit struct

From: Markus Armbruster In preparation of error handling changes. Bonus: generates less duplicated code. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- scripts/qapi-visit.py | 48 ++-- 1 file changed, 3

[Qemu-devel] [PULL 14/20] monitor: Convert sendkey to use command_completion.

From: Hani Benhabiles Signed-off-by: Hani Benhabiles Signed-off-by: Luiz Capitulino --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 32 +++- 3 files changed, 25 insertions(+), 9 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index

[Qemu-devel] [PULL 13/20] qapi: Show qapi-commands.py invocation in qapi-code-gen.txt

From: Markus Armbruster While there, pare down the shell prompts. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qapi-code-gen.txt | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/docs/qapi-cod

[Qemu-devel] [PULL 01/20] qapi: Update qapi-code-gen.txt example to match current code

From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- docs/qapi-code-gen.txt | 146 ++--- 1 file changed, 90 insertions(+), 56 deletions(-) diff --git a/docs/qapi-code-gen.txt b/docs/qap

Re: [Qemu-devel] [PATCH v1 2/3] memory: Add sysbus memory device

Peter, Am 15.04.2014 04:21, schrieb Peter Crosthwaite: > Add a sysbus device consisting of a single ram. This allows for > instantiation of RAM just like any other device. There are a number > of good reasons to want to do this this: > > 1: Consistency. RAM is not that special where board level f

[Qemu-devel] [PATCH v2] kvmclock: Ensure time in migration never goes backward

When we migrate we ask the kernel about its current belief on what the guest time would be. However, I've seen cases where the kvmclock guest structure indicates a time more recent than the kvm returned time. To make sure we never go backwards, calculate what the guest would have seen as time at t

Re: [Qemu-devel] [PATCH v4 1/2] qdev: Implement named GPIOs

On 12 May 2014 02:03, Peter Crosthwaite wrote: > Implement named GPIOs on the Device layer. Listifies the existing GPIOs > stuff using string keys. Legacy un-named GPIOs are preserved by using > a NULL name string - they are just a single matchable element in the > name list. > > Signed-off-by: Pe

Re: [Qemu-devel] [PATCH 4/9] target-ppc: Implement "compat" CPU option

On 05/17/2014 12:05 AM, Alexander Graf wrote: > > On 15.05.14 13:28, Alexey Kardashevskiy wrote: >> This adds basic support for the "compat" CPU option. By specifying >> the compat property, the user can manually switch guest CPU mode from >> "raw" to "architected". >> >> Since the actual compatib

Re: [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

On Fri, May 16, 2014 at 04:52:21PM +0200, Igor Mammedov wrote: > On Thu, 15 May 2014 11:03:49 -0300 > Eduardo Habkost wrote: > > On Thu, May 15, 2014 at 03:48:16PM +0200, Igor Mammedov wrote: [...] > > > > > > Can't we add query-cpus QMP command or something like this to hide path > > > from user

Re: [Qemu-devel] hw/scsi/megasas.c: (sdev->id & 0xFF) >> 8

Ping? Markus Armbruster writes: > There are several instances of > > ((sdev->id & 0xFF) >> 8) | (sdev->lun & 0xFF) > > or similar. The left operand of | is always 0. Did you intend to shift > to the other right?

Re: [Qemu-devel] [PATCH 1/4] machine: conversion of QEMUMachineInitArgs to MachineState

On Wed, 7 May 2014 17:42:57 +0300 Marcel Apfelbaum wrote: > Total removal of QEMUMachineInitArgs struct. QEMUMachineInitArgs's fields > are copied into MachineState. Removed duplicated fields from MachineState. > > All the other changes are only mechanical refactoring, no semantic changes. > >

Re: [Qemu-devel] [PATCH 1/7] iotests: Allow out-of-tree run

On 16.05.2014 17:09, Eric Blake wrote: On 05/16/2014 08:43 AM, Max Reitz wrote: +source_iotests="$(cd "$(dirname "$(readlink "$0")")"; pwd)" This is potentially dangerous. If readlink or dirname fails, you can invoke cd "" (which on bash is stupidly a no-op instead of an error), and end up

Re: [Qemu-devel] [PATCH 1/7] iotests: Allow out-of-tree run

On 05/16/2014 08:43 AM, Max Reitz wrote: >>> +source_iotests="$(cd "$(dirname "$(readlink "$0")")"; pwd)" >> This is potentially dangerous. If readlink or dirname fails, you can >> invoke cd "" (which on bash is stupidly a no-op instead of an error), >> and end up calling pwd in the wrong dire

[Qemu-devel] [RFC PATCH v3 03/13] migration: make qemu_savevm_state public.

From: KONRAD Frederic This makes qemu_savevm_state public for reverse-execution. Signed-off-by: KONRAD Frederic --- include/sysemu/sysemu.h | 1 + savevm.c| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h ind

[Qemu-devel] [RFC PATCH v3 11/13] cpu-exec: trigger a debug request when rexec stops.

From: KONRAD Frederic This allows QEMU to trigger a debug exception when cexe_dbg_requested is set. Signed-off-by: KONRAD Frederic --- cpu-exec.c | 13 + 1 file changed, 13 insertions(+) diff --git a/cpu-exec.c b/cpu-exec.c index 0914d3c..851d101 100644 --- a/cpu-exec.c +++ b/cpu-

Re: [Qemu-devel] [RFC 0/5] virtio: use alias properties in transport devices

On 19/03/2014 16:48, Stefan Hajnoczi wrote: This RFC is just the beginning. The same problem exists for virtio-net and other devices. I am looking for feedback before I convert all of virtio. The virtio transport/device split is broken as follows: 1. The virtio-blk device is never finalized b

[Qemu-devel] [RFC PATCH v3 10/13] gdbstub: allow reverse execution in gdb stub.

From: KONRAD Frederic This allows gdb to reverse step QEMU: reverse-stepi and reverse-cont commands are allowed. When step_backward is called, QEMU restores a snapshot before the actual instruction and stops (with a debug exit) when the previous instruction is reached. Signed-off-by: KONRAD Fre

[Qemu-devel] [RFC PATCH v3 05/13] icount: check for icount clock deadline when cpu loop exits.

From: KONRAD Frederic Notify events on icount clock when CPU loop exits. Signed-off-by: KONRAD Frederic Reviewed-by: Paolo Bonzini --- cpus.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cpus.c b/cpus.c index e646bac..4dced24 100644 --- a/cpus.c +++ b/cpus.c @@ -992,6 +992,11 @@ s

[Qemu-devel] [RFC PATCH v3 08/13] trace-events: add reverse-execution events.

From: KONRAD Frederic This adds some trace-events for reverse execution. Signed-off-by: KONRAD Frederic --- trace-events | 6 ++ 1 file changed, 6 insertions(+) diff --git a/trace-events b/trace-events index 002c260..06aaf0b 100644 --- a/trace-events +++ b/trace-events @@ -1206,3 +1206,9

Re: [Qemu-devel] [PATCH v4] Let the C generated bits of QAPI be generated only once when identical includes are done

On Fri, 16 May 2014 12:51:55 +0200 Benoît Canet wrote: > in v4: > Document the feature [Eric, Luiz] > > Benoît Canet (1): > qapi: skip redundant includes Applied to the qmp branch, thanks. > > docs/qapi-code-gen.txt| 2 +- > scripts/qapi.py

[Qemu-devel] [RFC PATCH v3 07/13] timer: add cpu_icount_to_ns function.

From: KONRAD Frederic This adds cpu_icount_to_ns function which is needed for reverse execution. It returns the time for a specific instruction. Signed-off-by: KONRAD Frederic Reviewed-by: Paolo Bonzini --- cpus.c | 9 +++-- include/qemu/timer.h | 1 + 2 files changed, 8 in

[Qemu-devel] [RFC PATCH v3 01/13] icount: put icount variables into TimerState.

From: KONRAD Frederic This puts qemu_icount and qemu_icount_bias into TimerState structure to allow them to be migrated. Signed-off-by: KONRAD Frederic Reviewed-by: Paolo Bonzini --- cpus.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/cpu

[Qemu-devel] [RFC PATCH v3 13/13] cexe: allow to enable reverse execution.

From: KONRAD Frederic This creates QEMU options for reverse execution. Signed-off-by: KONRAD Frederic --- qemu-options.hx | 9 + vl.c| 16 2 files changed, 25 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index ee5437b..bd730f6 100644 --- a

Re: [Qemu-devel] [PATCH] doc: add "setup" to list of migration states

On 05/16/2014 08:40 AM, pe...@gridcentric.ca wrote: > From: Peter Feiner > > On a slow VM (e.g., nested), you see the "setup" state when you query the > migration status. > > Signed-off-by: Peter Feiner > --- > qapi-schema.json |2 +- > qmp-commands.hx |2 +- > 2 files changed, 2 inse

[Qemu-devel] [RFC PATCH v3 09/13] introduce reverse execution mechanism.

From: KONRAD Frederic This introduces the basic reverse-execution mechanism. Signed-off-by: KONRAD Frederic --- Makefile.target | 1 + cpus.c | 6 + include/reverse-execution.h | 41 ++ reverse-execution.c | 306

[Qemu-devel] [RFC PATCH v3 12/13] cexe: synchronize icount on the next event.

From: KONRAD Frederic We don't want to warp on host clock as it is not deterministic for replay. So this patch warp icount on the next QEMU_VIRTUAL_CLOCK event if reverse execution is enabled. The normal behaviour is kept when reverse execution is disabled. Signed-off-by: KONRAD Frederic ---

[Qemu-devel] [RFC PATCH v3 02/13] migration: migrate icount fields.

From: KONRAD Frederic This fixes a bug where qemu_icount and qemu_icount_bias are not migrated. It adds a subsection "timer/icount" to vmstate_timers so icount is migrated only when needed. Signed-off-by: KONRAD Frederic --- cpus.c | 28 1 file changed, 28 insertio

[Qemu-devel] vfio - bind failure : user space recovery

I am using a driver from user-space using vfio. During intensive testing, when my application crashes. I try to re-run the same, when I get a bind-failure. Error code, is E_BUSY. The point of error is when I try to open a group ret = open("/dev/vfio/xx",O_RDWR) I traced down what could be the rea

Re: [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

Am 15.05.2014 14:35, schrieb Igor Mammedov: > PS: > As side effect cpu/apic will disappear from "info qtree" HMP command output. Solutions are already on the list and in need of feedback: http://patchwork.ozlabs.org/patch/317224/ http://patchwork.ozlabs.org/patch/343136/ http://patchwork.ozlabs.o

Re: [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

On Thu, 15 May 2014 11:03:49 -0300 Eduardo Habkost wrote: > On Thu, May 15, 2014 at 03:48:16PM +0200, Igor Mammedov wrote: > > On Thu, 15 May 2014 10:07:51 -0300 > > Eduardo Habkost wrote: > > > > > On Thu, May 15, 2014 at 02:35:01PM +0200, Igor Mammedov wrote: > > > > On Tue, 06 May 2014 22:29

Re: [Qemu-devel] [PATCH 5/7] iotests: Use $PYTHON for Python scripts

On 16.05.2014 09:54, Fam Zheng wrote: On Fri, 05/16 00:26, Max Reitz wrote: diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index bd66630..9968db9 100755 --- a/tests/qemu-iotests/check +++ b/tests/qemu-iotests/check @@ -287,10 +287,17 @@ do start=`_wallclock`

Re: [Qemu-devel] [PATCH] target-i386: set CC_OP to CC_OP_EFLAGS in cpu_load_eflags

On 05/16/2014 02:36 AM, Paolo Bonzini wrote: > There is no reason to keep that out of the function. The comment refers > to the disassembler's cc_op state rather than the CPUState field. > > Signed-off-by: Paolo Bonzini > --- > target-i386/cpu.h| 5 - > target-i386/seg_helper.c | 2

  1   2   3   >