[Qemu-devel] [PULL 0/2] vfio updates

2014-08-05 Thread Alex Williamson
The following changes since commit 69f87f713069f1f70f86cb65883f7d43e3aa21de: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140804' into staging (2014-08-04 15:01:38 +0100) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/vfio-pci-

Re: [Qemu-devel] qemu live migration error from 2.0 to 2.1

2014-08-05 Thread William Dauchy
On Tue, Aug 5, 2014 at 8:57 PM, Dr. David Alan Gilbert wrote: > Can you confirm this is on the final 2.1 release (there was a fix that > went in just around rc5). for the receiver, I'm using 2.1 # qemu-system-x86_64 --version QEMU emulator version 2.1.0, Copyright (c) 2003-2008 Fabrice Bellar f

[Qemu-devel] org. cpuid passthru for qemu guest

2014-08-05 Thread Holger Unterbrink (hunterbr)
Hi, is there any cmdline switch to hide virtualization to the guest OS ? Afaik qemu intercepts the cupid instruction (EAX=0x1) and always sets Bit 31 in ECX for virtualization ? http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=1009458 For malware an

Re: [Qemu-devel] qemu live migration error from 2.0 to 2.1

2014-08-05 Thread Dr. David Alan Gilbert
(CC Paolo) * William Dauchy (wdau...@gmail.com) wrote: > Hello, > > For a qemu live migration from 2.0 to 2.1 I'm getting: > > qemu-system-x86_64: Length mismatch: /rom@etc/acpi/tables: 3000 in != 2 > qemu-system-x86_64: Unknown ramblock "/table-loader", cannot accept migration > qemu-system

[Qemu-devel] qemu live migration error from 2.0 to 2.1

2014-08-05 Thread William Dauchy
Hello, For a qemu live migration from 2.0 to 2.1 I'm getting: qemu-system-x86_64: Length mismatch: /rom@etc/acpi/tables: 3000 in != 2 qemu-system-x86_64: Unknown ramblock "/table-loader", cannot accept migration qemu-system-x86_64: Ack, bad migration stream! qemu-system-x86_64: Illegal RAM of

Re: [Qemu-devel] [PATCH] linux-aio: avoid deadlock in nested aio_poll() calls

2014-08-05 Thread Marcin Gibuła
W dniu 2014-08-04 17:56, Stefan Hajnoczi pisze: If two Linux AIO request completions are fetched in the same io_getevents() call, QEMU will deadlock if request A's callback waits for request B to complete using an aio_poll() loop. This was reported to happen with the mirror blockjob. This patch

Re: [Qemu-devel] About the VT-d features that q35 chipset supports

2014-08-05 Thread Jan Kiszka
On 2014-08-05 14:55, Le Tan wrote: > Hi, > I am now adding features to the VT-d emulation for q35 chipset. I > think it is good to know what features q35 chipset supports exactly. > However I can't find materials about this. Does anyone know this? Or > it will be fine if someone can tell me the val

Re: [Qemu-devel] [PATCH v2] vmdk: improve streamOptimized vmdk support

2014-08-05 Thread Milos Vyletel
On Tue, Aug 5, 2014 at 1:27 AM, Fam Zheng wrote: > On Mon, 08/04 13:10, Milos Vyletel wrote: >> VMDK's streamOptimized format is different from regular sparse format. >> L1(GD) and L2(GT) tables are not predefined but rather generated and >> written during image creation mainly because there is no

Re: [Qemu-devel] [PATCH v6 0/2] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-08-05 Thread Alex Bennée
Richard W.M. Jones writes: > Changes from v5: > > - Fixed warning/error about comparison of uint8_t and char literal. > > - Compile-tested on x86-64. > > - Compiled and re-tested on aarch64. > > Rich. You can add my: Reviewed-by: Alex Bennée -- Alex Bennée

Re: [Qemu-devel] [PATCH 2/2] ivshmem: convert option 'use64' to a bit instead of integer

2014-08-05 Thread Michael S. Tsirkin
On Mon, Aug 04, 2014 at 05:06:21PM +0200, Levente Kurusa wrote: > It was expecting an integer, however the sole usecase of it just > checked whether it was assigned to or not. Hence, remove integerness, > and add a new bitfield instead. > > Signed-off-by: Levente Kurusa This might break some exi

Re: [Qemu-devel] [PATCH v3 1/8] CODING_STYLE: Section about conditional statement

2014-08-05 Thread Michael S. Tsirkin
On Tue, Aug 05, 2014 at 04:48:18PM +0100, Alex Bennée wrote: > > Gonglei (Arei) writes: > > > Hi, > > > >> > Yoda conditions lack readability, and QEMU has a > >> > strict compiler configuration for checking a common > >> > mistake like "if (dev = NULL)". Make it a written rule. > > >> > >> I k

Re: [Qemu-devel] [PATCH v3 1/8] CODING_STYLE: Section about conditional statement

2014-08-05 Thread Alex Bennée
Gonglei (Arei) writes: > Hi, > >> > Yoda conditions lack readability, and QEMU has a >> > strict compiler configuration for checking a common >> > mistake like "if (dev = NULL)". Make it a written rule. >> >> I know this is my suggested text, but now that I'm re-reading it, I'd >> recommend s/0

[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2014-08-05 Thread Peter Maydell
Well, it won't make anything any worse, so it's your call based on how much it actually improves your failure rate I guess. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1350435 Title: tcg.c:1693:

[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2014-08-05 Thread Colin Watson
Right, I can absolutely understand that. The question would I suppose be whether you think this is a completely unreasonable thing to put in a distro patch; I think SUSE are doing so for basically the same reason we would be, that is, a setup such as PPAs where virtualisation isn't available direc

Re: [Qemu-devel] [PATCH] acpi: align RSDP

2014-08-05 Thread Laszlo Ersek
On 08/04/14 17:40, Michael S. Tsirkin wrote: > RSDP should be aligned at a 16-byte boundary. > This would by chance at the moment, fix up acpi build > to make it robust. > > Signed-off-by: Michael S. Tsirkin > --- > hw/i386/acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH v2 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock

2014-08-05 Thread Marcin Gibuła
On 15.07.2014 17:17, Paolo Bonzini wrote: Il 15/07/2014 16:44, Stefan Hajnoczi ha scritto: v2: * Leave BH scheduled so that the code can be simplified [Paolo] These patches convert thread-pool.c from EventNotifier to QEMUBH. They then solve the deadlock when nested aio_poll() calls are made.

Re: [Qemu-devel] [PATCH] linux-aio: avoid deadlock in nested aio_poll() calls

2014-08-05 Thread Marcin Gibuła
On 05.08.2014 16:26, Marcin Gibuła wrote: On 04.08.2014 17:56, Stefan Hajnoczi wrote: If two Linux AIO request completions are fetched in the same io_getevents() call, QEMU will deadlock if request A's callback waits for request B to complete using an aio_poll() loop. This was reported to happe

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-05 Thread Kevin Wolf
Am 05.08.2014 um 15:48 hat Stefan Hajnoczi geschrieben: > On Tue, Aug 05, 2014 at 06:00:22PM +0800, Ming Lei wrote: > > On Tue, Aug 5, 2014 at 5:48 PM, Kevin Wolf wrote: > > > Am 05.08.2014 um 05:33 hat Ming Lei geschrieben: > > >> Hi, > > >> > > >> These patches bring up below 4 changes: > > >>

Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards

2014-08-05 Thread Michael S. Tsirkin
On Tue, Jul 22, 2014 at 09:28:55AM +0200, Gerd Hoffmann wrote: > This way the tests run without sound hardware being present > on the build machine. Even with sound hardware it IMO isn't > very useful to use it in regression testing. Once the sound > card tests are advanced enougth that they try

Re: [Qemu-devel] [PATCH] linux-aio: avoid deadlock in nested aio_poll() calls

2014-08-05 Thread Marcin Gibuła
On 04.08.2014 17:56, Stefan Hajnoczi wrote: If two Linux AIO request completions are fetched in the same io_getevents() call, QEMU will deadlock if request A's callback waits for request B to complete using an aio_poll() loop. This was reported to happen with the mirror blockjob. This patch mov

Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards

2014-08-05 Thread Markus Armbruster
Ping? Markus Armbruster writes: > Gerd Hoffmann writes: > >> This way the tests run without sound hardware being present >> on the build machine. Even with sound hardware it IMO isn't >> very useful to use it in regression testing. Once the sound >> card tests are advanced enougth that they t

Re: [Qemu-devel] [PATCH v3 for-2.2 0/8] don't use Yoda conditions

2014-08-05 Thread Michael S. Tsirkin
On Fri, Aug 01, 2014 at 03:46:08PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > $WHATEVER: don't use 'Yoda conditions' > > 'Yoda conditions' are not part of idiomatic QEMU coding > style, so rewrite them in the more usual order. OK but why stop at these files? How about this inste

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-05 Thread Stefan Hajnoczi
On Tue, Aug 05, 2014 at 05:50:42PM +0800, Ming Lei wrote: > On Tue, Aug 5, 2014 at 5:38 PM, Stefan Hajnoczi wrote: > > On Tue, Aug 05, 2014 at 11:33:01AM +0800, Ming Lei wrote: > >> These patches bring up below 4 changes: > >> - introduce object allocation pool and apply it to > >>

Re: [Qemu-devel] [PATCH] linux-aio: avoid deadlock in nested aio_poll() calls

2014-08-05 Thread Stefan Hajnoczi
On Tue, Aug 05, 2014 at 06:44:25PM +0800, Ming Lei wrote: > On Mon, Aug 4, 2014 at 11:56 PM, Stefan Hajnoczi wrote: > > If two Linux AIO request completions are fetched in the same > > io_getevents() call, QEMU will deadlock if request A's callback waits > > for request B to complete using an aio_

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-05 Thread Stefan Hajnoczi
On Tue, Aug 05, 2014 at 06:00:22PM +0800, Ming Lei wrote: > On Tue, Aug 5, 2014 at 5:48 PM, Kevin Wolf wrote: > > Am 05.08.2014 um 05:33 hat Ming Lei geschrieben: > >> Hi, > >> > >> These patches bring up below 4 changes: > >> - introduce object allocation pool and apply it to > >>

Re: [Qemu-devel] [PATCH] linux-user: /proc/self/maps content

2014-08-05 Thread Mikhail Ilyin
Build /proc/self/maps doing a match against guest memory translation table. Output only that map records which are valid for guest memory layout. Signed-off-by: Mikhail Ilyin --- The previous patch won't compile with 32 bits compiler because of wrong casting type, replace uint64_t with uintptr_t

Re: [Qemu-devel] [PATCH v2 7/7] iotests: Expand test 061

2014-08-05 Thread Eric Blake
On 08/01/2014 05:49 PM, Max Reitz wrote: > Add some tests for progress output to 061. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/061 | 25 + > tests/qemu-iotests/061.out | 30 ++ > tests/qemu-iotests/group | 2 +- > 3 files

Re: [Qemu-devel] [PATCH v2 6/7] block/qcow2: Simplify shared L2 handling in amend

2014-08-05 Thread Eric Blake
On 08/01/2014 05:49 PM, Max Reitz wrote: > Currently, we have a bitmap for keeping track of which clusters have > been created during the zero cluster expansion process. This was > necessary because we need to properly increase the refcount for shared > L2 tables. > > However, now we can simply ta

Re: [Qemu-devel] Cc'ing emails [

2014-08-05 Thread Anthony Liguori
On Aug 5, 2014 2:42 AM, "Markus Armbruster" wrote: > > Michael Tokarev writes: > > > 05.08.2014 08:41, Chen Gang wrote: > >> > >> Every members have their own tastes, and one working flow may be not > >> suitable for all members. I can understand, and hope other members > >> understand too. > >>

Re: [Qemu-devel] [PATCH] linux-user: /proc/self/maps content

2014-08-05 Thread Mikhail Ilin
Thanks, I've tested the sample for Aarch64 myself and found that the approach should also work fine. Translation layout: $ qemu-aarch64 -strace /tmp/busybox-static cat /proc/self/maps startend size prot 0040-005ba000 001ba000 r-x

Re: [Qemu-devel] [PATCH v2 5/7] block/qcow2: Make get_refcount() global

2014-08-05 Thread Eric Blake
On 08/01/2014 05:49 PM, Max Reitz wrote: > Reading the refcount of a cluster is an operation which can be useful in > all of the qcow2 code, so make that function globally available. > > While touching this function, amend the comment describing the "addend" > parameter: It is (no longer, if it ev

Re: [Qemu-devel] [PATCH v2 4/7] block/qcow2: Implement status CB for amend

2014-08-05 Thread Eric Blake
On 08/01/2014 05:49 PM, Max Reitz wrote: > The only really time-consuming operation potentially performed by > qcow2_amend_options() is zero cluster expansion when downgrading qcow2 > images from compat=1.1 to compat=0.10, so report status of that > operation and that operation only through the sta

Re: [Qemu-devel] KVM call for agenda for 2014-08-05

2014-08-05 Thread Juan Quintela
Juan Quintela wrote: > Reset, this time with the right mailing lists. > > Thanks to Markus for noticing. > > Later, Juan. > > Juan Quintela wrote: No agenda, no call. Sorry for the late advice :-( Later, Juan.

Re: [Qemu-devel] [PATCH] block: add watermark event

2014-08-05 Thread Stefan Hajnoczi
On Tue, Aug 05, 2014 at 10:47:57AM +0200, Kevin Wolf wrote: > Am 01.08.2014 um 13:39 hat Stefan Hajnoczi geschrieben: > > On Tue, Jul 08, 2014 at 04:49:24PM +0200, Francesco Romani wrote: > > > @@ -5813,3 +5815,57 @@ void bdrv_flush_io_queue(BlockDriverState *bs) > > > bdrv_flush_io_queue(

Re: [Qemu-devel] [PATCH v2 2/7] qemu-img: Add progress output for amend

2014-08-05 Thread Eric Blake
On 08/01/2014 05:49 PM, Max Reitz wrote: > Now that bdrv_amend_options() supports a status callback, use it to > display a progress report. > > Signed-off-by: Max Reitz > --- > qemu-img-cmds.hx | 4 ++-- > qemu-img.c | 25 ++--- > qemu-img.texi| 2 +- > 3 files ch

Re: [Qemu-devel] [PATCH v2 1/7] block: Add status callback to bdrv_amend_options()

2014-08-05 Thread Eric Blake
On 08/01/2014 05:49 PM, Max Reitz wrote: > Depending on the changed options and the image format, > bdrv_amend_options() may take a significant amount of time. In these > cases, a way to be informed about the operation's status is desirable. > > Since the operation is rather complex and may fundam

Re: [Qemu-devel] [PATCH v4 0/8] don't use Yoda conditions

2014-08-05 Thread Eric Blake
On 08/04/2014 03:19 AM, arei.gong...@huawei.com wrote: > From: Gonglei > > $WHATEVER: don't use 'Yoda conditions' > > 'Yoda conditions' are not part of idiomatic QEMU coding > style, so rewrite them in the more usual order. > > v4: > - trivial typo for patch 1/8 suggested by Eric, thanks. Ser

[Qemu-devel] About the VT-d features that q35 chipset supports

2014-08-05 Thread Le Tan
Hi, I am now adding features to the VT-d emulation for q35 chipset. I think it is good to know what features q35 chipset supports exactly. However I can't find materials about this. Does anyone know this? Or it will be fine if someone can tell me the value of the Capability Register and Extended Ca

Re: [Qemu-devel] [PATCH v1 23/24] qapi: Add a script to filter qmp-commands-old.h to generate a subset of it.

2014-08-05 Thread Eric Blake
On 07/31/2014 11:27 PM, Benoît Canet wrote: > Since qmp-command-olds.h is generated from qmp-commands.hx we will sometime > want > to include only a subset of it. For example when linking qapi block commands > with qemu-nbd. > > Signed-off-by: Benoit Canet > --- > Makefile

Re: [Qemu-devel] [PATCH v1 01/17] qemu/obj_pool.h: introduce object allocation pool

2014-08-05 Thread Michael S. Tsirkin
On Tue, Aug 05, 2014 at 06:21:55AM -0600, Eric Blake wrote: > On 08/05/2014 06:05 AM, Michael S. Tsirkin wrote: > > On Tue, Aug 05, 2014 at 05:55:49AM -0600, Eric Blake wrote: > >> On 08/04/2014 09:33 PM, Ming Lei wrote: > >>> This patch introduces object allocation pool for speeding up > >>> objec

Re: [Qemu-devel] [PATCH v1 04/24] monitor: Make monitor_fprintf public before extracting it

2014-08-05 Thread Eric Blake
On 07/31/2014 11:27 PM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > disas.c | 10 -- > include/monitor/monitor.h | 2 ++ > monitor.c | 4 ++-- > 3 files changed, 4 insertions(+), 12 deletions(-) Reviewed-by: Eric Blake -- Eric Blake

Re: [Qemu-devel] [PATCH v1 03/24] monitor: Extract monitor-system.h header

2014-08-05 Thread Eric Blake
On 07/31/2014 11:27 PM, Benoît Canet wrote: > This header will allow to split monitor in two parts. s/allow to split monitor in/allow splitting the monitor into/ > > Signed-off-by: Benoit Canet > --- > include/monitor/monitor-system.h | 99 > > monitor

Re: [Qemu-devel] [PATCH v1 05/17] garbage collector: introduced for support of bypass coroutine

2014-08-05 Thread Eric Blake
On 08/04/2014 09:33 PM, Ming Lei wrote: > In case of bypass coroutine, some buffers in stack have to convert > to survive in the whole I/O submit & completion cycle. > > Garbase collector is one of the best data structure for this purpose, s/Garbase/A garbage/ > as I thought of. > > Signed-off-

Re: [Qemu-devel] [PATCH v1 02/24] monitor: Make some function public

2014-08-05 Thread Eric Blake
On 07/31/2014 11:27 PM, Benoît Canet wrote: > Next commits will split monitor.c in monitor.c and monitor-system.c. s/in/to/ > > Change some function from static to public in order to prepare this. s/function/functions/ s/this/for this/ > > Signed-off-by: Benoit Canet > --- > include/monitor

Re: [Qemu-devel] [PATCH v1 01/24] qmp: Extract system emulation related code from qmp.c into qmp-system.c

2014-08-05 Thread Eric Blake
On 07/31/2014 11:26 PM, Benoît Canet wrote: > This patch will allow to link qmp.o with utility binaries without dragging too s/allow to link/allow linking/ > much unrelated object files and externals dependencies. s/dragging too much/dragging in too many/ s/externals/external/ > > Signed-off-b

Re: [Qemu-devel] [PATCH v1 02/17] dataplane: use object pool to speed up allocation for virtio blk request

2014-08-05 Thread Eric Blake
On 08/04/2014 09:33 PM, Ming Lei wrote: > g_slice_new(VirtIOBlockReq), its free pair and access the instance Took me a while to read this. Maybe: Calling g_slice_new(VirtIOBlockReq) and its free pair, and accessing the instance, are a bit slow... > is a bit slow since sizeof(VirtIOBlockReq) tak

Re: [Qemu-devel] [PATCH v1 01/17] qemu/obj_pool.h: introduce object allocation pool

2014-08-05 Thread Eric Blake
On 08/05/2014 06:05 AM, Michael S. Tsirkin wrote: > On Tue, Aug 05, 2014 at 05:55:49AM -0600, Eric Blake wrote: >> On 08/04/2014 09:33 PM, Ming Lei wrote: >>> This patch introduces object allocation pool for speeding up >>> object allocation in fast path. >>> >>> Signed-off-by: Ming Lei >>> --- >>

Re: [Qemu-devel] Cc'ing emails [

2014-08-05 Thread Chen Gang
On 08/05/2014 04:07 PM, Peter Maydell wrote: > n 5 August 2014 08:08, Michael Tokarev wrote: >> 05.08.2014 08:41, Chen Gang wrote: >>> >>> Every members have their own tastes, and one working flow may be not >>> suitable for all members. I can understand, and hope other members >>> understand to

Re: [Qemu-devel] [RFC 3/3] QMP: extend BLOCK_IO_ERROR event with no-space indicator

2014-08-05 Thread Eric Blake
On 07/23/2014 07:17 AM, Luiz Capitulino wrote: > Management software, such as OpenStack and RHEV's vdsm, want to be able > to allocate disk space on demand. The basic use case is to start a VM > with a small disk and then the disk is enlarged when QEMU hits a ENOSPC > condition. I'd still like fee

Re: [Qemu-devel] [RFC 2/3] QMP: rate limit BLOCK_IO_ERROR

2014-08-05 Thread Eric Blake
On 07/23/2014 07:17 AM, Luiz Capitulino wrote: > This event has the same characteristics of the other rate-limited > events, mainly we can emit dozens of it. Rate limit it then. > > Signed-off-by: Luiz Capitulino > --- > monitor.c | 1 + > 1 file changed, 1 insertion(+) It's not guest-triggered

Re: [Qemu-devel] [RFC 1/3] qapi: block-core.json: improve query-block doc

2014-08-05 Thread Eric Blake
On 07/23/2014 07:17 AM, Luiz Capitulino wrote: > List device models supporting the io-status key. > > Signed-off-by: Luiz Capitulino > --- > qapi/block-core.json | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index e378653..1069679 100644

Re: [Qemu-devel] [PATCH v1 01/17] qemu/obj_pool.h: introduce object allocation pool

2014-08-05 Thread Michael S. Tsirkin
On Tue, Aug 05, 2014 at 05:55:49AM -0600, Eric Blake wrote: > On 08/04/2014 09:33 PM, Ming Lei wrote: > > This patch introduces object allocation pool for speeding up > > object allocation in fast path. > > > > Signed-off-by: Ming Lei > > --- > > include/qemu/obj_pool.h | 64 > > +

Re: [Qemu-devel] [PATCH v1 01/17] qemu/obj_pool.h: introduce object allocation pool

2014-08-05 Thread Eric Blake
On 08/04/2014 09:33 PM, Ming Lei wrote: > This patch introduces object allocation pool for speeding up > object allocation in fast path. > > Signed-off-by: Ming Lei > --- > include/qemu/obj_pool.h | 64 > +++ > 1 file changed, 64 insertions(+) > cr

[Qemu-devel] [Bug 498035] Re: qemu hangs on shutdown or reboot (XP guest)

2014-08-05 Thread Michael Tokarev
So, is this issue still relevant with current qemu (which happens to be 2.1.0? I remember seeing hangs on reboot/halt like this before too, but on my side they're long gone, I don't observe these hangs anymore. Maybe this bugreport can be closed finally? ** Changed in: qemu Status: Triaged

Re: [Qemu-devel] [PATCH] linux-user: /proc/self/maps content

2014-08-05 Thread Riku Voipio
Hi, On Tue, Aug 05, 2014 at 03:10:07PM +0400, Mikhail Ilyin wrote: > Build /proc/self/maps doing a match against guest memory translation table. > Output only that map records which are valid for guest memory layout. This is clear improvement, for most archs. But seems aarch64, openrisc still lea

Re: [Qemu-devel] [PATCH v4 1/6] memory: add memory_region_init_ram_may_fail() and memory_region_init_ram_ptr_may_fail()

2014-08-05 Thread Eric Blake
On 08/04/2014 11:56 PM, Hu Tao wrote: > These two are almost the same as memory_region_init_ram() and > memory_region_init_ram_ptr() except that they have an extra errp > parameter to let callers handle error. The purpose is to fix the bug > described below. > > We should have added errp directly

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-05 Thread Paolo Bonzini
Il 05/08/2014 12:00, Ming Lei ha scritto: >> > >> > I also think that the device emulation has no business in deciding >> > whether the bypass is used (it depends solely on conditions outside of >> > the device) and that leaking the fd number out of raw-posix is wrong. >> > Both of them are layerin

Re: [Qemu-devel] [PATCH 2/2] scsi-bus: Convert DeviceClass init to realize

2014-08-05 Thread Fam Zheng
On Tue, 08/05 17:11, Fam Zheng wrote: > Replace "init/destroy" with "realize/unrealize" in SCSIDeviceClass, > which has errp as a parameter. So all the implementations now uses s/uses/use/ > error_setg instead of error_report for reporting error. > > Also in lsi53c895a, report the error when ini

Re: [Qemu-devel] [PATCH v2 00/16] linux-user fixes & improvements

2014-08-05 Thread Riku Voipio
Hi Paul, On Fri, Jun 27, 2014 at 04:30:34PM +0300, Riku Voipio wrote: > On Sat, Jun 21, 2014 at 11:52:55PM +0100, Paul Burton wrote: > > From: Paul Burton > > > > This series fixes a number of bugs in QEMUs linux-user support, some > > specific to targetting the MIPS architecture but mostly gene

Re: [Qemu-devel] [PATCH 0/2] scsi: Change device init to realize

2014-08-05 Thread Paolo Bonzini
Il 05/08/2014 11:11, Fam Zheng ha scritto: > DeviceClass->init is the old interface, let's convert scsi devices to the new > ->realize API. > > A user visible change is the error message shown in qemu-iotests reference > output, but I don't know what's the best way to retain it. So please review i

[Qemu-devel] [PATCH] linux-user: /proc/self/maps content

2014-08-05 Thread Mikhail Ilyin
Build /proc/self/maps doing a match against guest memory translation table. Output only that map records which are valid for guest memory layout. Signed-off-by: Mikhail Ilyin --- include/exec/cpu-all.h | 2 ++ linux-user/syscall.c | 25 ++--- 2 files changed, 12 insertions

Re: [Qemu-devel] Are -cdrom/-hda (or -drive if=ide) supposed to work in q35?

2014-08-05 Thread Markus Armbruster
Michael Tokarev writes: > 05.08.2014 13:30, Kevin Wolf wrote: > [] >>> However, I don't think we should keep if=ide broken on Q35 just to >>> "motivate" such work. >> >> I agree for the moment. It only becomes a strict requirement once we >> attempt to change the default machine type. > > BTW, m

Re: [Qemu-devel] Are -cdrom/-hda (or -drive if=ide) supposed to work in q35?

2014-08-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 05.08.2014 um 11:13 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 01.08.2014 um 22:10 hat John Snow geschrieben: >> >> >> >> On 06/12/2014 05:03 AM, Markus Armbruster wrote: >> >> >Michael Tokarev writes: >> >> > >> >> >>10.06.2014 10:34, Paolo Bo

[Qemu-devel] [PATCH v2 1/2] hw/misc/arm_sp810: Create SP810 device

2014-08-05 Thread Fabian Aggeler
This adds a device model for the PrimeXsys System Controller (SP810) which is present in the Versatile Express motherboards. It is so far read-only but allows to set the SCCTRL register. Signed-off-by: Fabian Aggeler --- default-configs/arm-softmmu.mak | 1 + hw/misc/Makefile.objs |

[Qemu-devel] [PATCH v2 0/2] Add SP810 to Versatile Express boards

2014-08-05 Thread Fabian Aggeler
Hi, The Versatile Express emulation in QEMU currently does not have a model of the SP810 used in real hardware. The registers provided by this System Controller can be used to set the frequency of the SP804 timers. On newer releases of the board the SP804 is set to 32kHz by default and has to be i

[Qemu-devel] [PATCH v2 2/2] hw/arm/vexpress: add SP810 to the vexpress

2014-08-05 Thread Fabian Aggeler
The SP810, which is present in the Versatile Express motherboards, allows to set the timing reference to either REFCLK or TIMCLK. QEMU currently sets the SP804 timer to 1MHz by default. To reflect this, we set the TimerEn0Sel, TimerEn1Sel, TimerEn2Sel, and TimerEn3Sel of the system control register

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-05 Thread Ming Lei
On Tue, Aug 5, 2014 at 5:56 PM, Kevin Wolf wrote: > Am 05.08.2014 um 11:50 hat Ming Lei geschrieben: >> On Tue, Aug 5, 2014 at 5:38 PM, Stefan Hajnoczi wrote: >> > On Tue, Aug 05, 2014 at 11:33:01AM +0800, Ming Lei wrote: >> >> These patches bring up below 4 changes: >> >> - introduce obj

Re: [Qemu-devel] [PATCH] linux-aio: avoid deadlock in nested aio_poll() calls

2014-08-05 Thread Ming Lei
On Mon, Aug 4, 2014 at 11:56 PM, Stefan Hajnoczi wrote: > If two Linux AIO request completions are fetched in the same > io_getevents() call, QEMU will deadlock if request A's callback waits > for request B to complete using an aio_poll() loop. This was reported > to happen with the mirror blockj

[Qemu-devel] [PATCH v6 2/2] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-08-05 Thread Richard W.M. Jones
On aarch64 it is the bootloader's job to uncompress the kernel. UEFI and u-boot bootloaders do this automatically when the kernel is gzip-compressed. However the qemu -kernel option does not do this. The following command does not work: qemu-system-aarch64 [...] -kernel /boot/vmlinuz because

[Qemu-devel] [PATCH v6 1/2] loader: Add load_image_gzipped function.

2014-08-05 Thread Richard W.M. Jones
As the name suggests this lets you load a ROM/disk image that is gzipped. It is uncompressed before storing it in guest memory. Signed-off-by: Richard W.M. Jones --- hw/core/loader.c| 48 include/hw/loader.h | 1 + 2 files changed, 49 insert

[Qemu-devel] [PATCH v6 0/2] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-08-05 Thread Richard W.M. Jones
Changes from v5: - Fixed warning/error about comparison of uint8_t and char literal. - Compile-tested on x86-64. - Compiled and re-tested on aarch64. Rich.

Re: [Qemu-devel] [PATCH v5 1/2] loader: Add load_image_gzipped function.

2014-08-05 Thread Alex Bennée
Richard W.M. Jones writes: > As the name suggests this lets you load a ROM/disk image that is > gzipped. It is uncompressed before storing it in guest memory. > > Signed-off-by: Richard W.M. Jones > +/* Is it a gzip-compressed file? */ > +if (len < 2 || > +compressed_data[0] !=

Re: [Qemu-devel] [PATCH v5 1/2] loader: Add load_image_gzipped function.

2014-08-05 Thread Richard W.M. Jones
On Tue, Aug 05, 2014 at 10:57:26AM +0100, Alex Bennée wrote: > > Richard W.M. Jones writes: > > > As the name suggests this lets you load a ROM/disk image that is > > gzipped. It is uncompressed before storing it in guest memory. > > > > Signed-off-by: Richard W.M. Jones > > > +/* Is it a

Re: [Qemu-devel] [PATCH 4/4] ivshmem: check the value returned by fstat()

2014-08-05 Thread Michael S. Tsirkin
On Tue, Aug 05, 2014 at 10:00:41AM +0800, zhanghailiang wrote: > Hi Michael, > Thanks for your review of this patch! > > >On Mon, Aug 04, 2014 at 04:25:44PM +0800, zhanghailiang wrote: > >>The function fstat() may fail, so check its return value. > >> > >>Signed-off-by: zhanghailiang > >>--- > >>

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-05 Thread Ming Lei
On Tue, Aug 5, 2014 at 5:48 PM, Kevin Wolf wrote: > Am 05.08.2014 um 05:33 hat Ming Lei geschrieben: >> Hi, >> >> These patches bring up below 4 changes: >> - introduce object allocation pool and apply it to >> virtio-blk dataplane for improving its performance >> >> - intr

Re: [Qemu-devel] [PATCH v5 2/2] aarch64: Allow -kernel option to take a gzip-compressed kernel.

2014-08-05 Thread Alex Bennée
Richard W.M. Jones writes: > On aarch64 it is the bootloader's job to uncompress the kernel. UEFI > and u-boot bootloaders do this automatically when the kernel is > gzip-compressed. > > However the qemu -kernel option does not do this. The following > command does not work: > > qemu-system-a

Re: [Qemu-devel] [PATCH v4 0/2] a few simple trace fixes

2014-08-05 Thread Stefan Hajnoczi
On Fri, Aug 01, 2014 at 05:08:55PM +0100, Alex Bennée wrote: > As v3 posted earlier today but with a format string fix which didn't > show up in the ust build I tested it on > > Alex Bennée (2): > trace: teach lttng backend to use format strings > trace: add some tcg tracing support > >

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-05 Thread Kevin Wolf
Am 05.08.2014 um 11:50 hat Ming Lei geschrieben: > On Tue, Aug 5, 2014 at 5:38 PM, Stefan Hajnoczi wrote: > > On Tue, Aug 05, 2014 at 11:33:01AM +0800, Ming Lei wrote: > >> These patches bring up below 4 changes: > >> - introduce object allocation pool and apply it to > >> virtio-b

Re: [Qemu-devel] [PATCH v5 1/2] loader: Add load_image_gzipped function.

2014-08-05 Thread Alex Bennée
Richard W.M. Jones writes: > As the name suggests this lets you load a ROM/disk image that is > gzipped. It is uncompressed before storing it in guest memory. > > + > +/* Is it a gzip-compressed file? */ > +if (len < 2 || > +compressed_data[0] != '\x1f' || > +compressed_

[Qemu-devel] [Bug 1352555] Re: iproute2 incompatibility

2014-08-05 Thread Michael Tokarev
This is a Very Useful BugReport (NOT!). Qemu does not use neither ifupdown nor iproute. Instead, it runs a script, /etc/qemu-ifup by default, which should use whatever commands needed on the given operating system to do whatever configuration of the tap devices which is necessary. But qemu itsel

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-05 Thread Ming Lei
On Tue, Aug 5, 2014 at 5:38 PM, Stefan Hajnoczi wrote: > On Tue, Aug 05, 2014 at 11:33:01AM +0800, Ming Lei wrote: >> These patches bring up below 4 changes: >> - introduce object allocation pool and apply it to >> virtio-blk dataplane for improving its performance >> >> -

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-05 Thread Kevin Wolf
Am 05.08.2014 um 05:33 hat Ming Lei geschrieben: > Hi, > > These patches bring up below 4 changes: > - introduce object allocation pool and apply it to > virtio-blk dataplane for improving its performance > > - introduce selective coroutine bypass mechanism > for i

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.1.0 is now available

2014-08-05 Thread Michael S. Tsirkin
On Mon, Aug 04, 2014 at 06:33:08PM -0700, Nishank Trivedi wrote: > Hi Michael, > > I'm trying to send mail to qemu-devel, but it seems to be getting filtering > out as I dont see it come over mailing list. Is there a keyword needed in > subject for qemu-devel? > > I'm trying to report issue of x8

Re: [Qemu-devel] [PATCH v3 0/4] libqos: add a simple first-fit memory allocator

2014-08-05 Thread Stefan Hajnoczi
On Fri, Aug 01, 2014 at 11:38:55AM -0400, John Snow wrote: > This set collects two patches by Marc Marí already on the mailing list, > but goes further by adding a simple memory allocator that allows us to > track and debug freed memory, and optionally keep track of any leaks. > > For convenience:

[Qemu-devel] [Bug 1352555] Re: iproute2 incompatibility

2014-08-05 Thread Michael Tokarev
** Changed in: qemu Status: New => Incomplete ** Changed in: qemu Status: Incomplete => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1352555 Title: iproute2 incompatibility

Re: [Qemu-devel] Cc'ing emails [

2014-08-05 Thread Markus Armbruster
Michael Tokarev writes: > 05.08.2014 08:41, Chen Gang wrote: >> >> Every members have their own tastes, and one working flow may be not >> suitable for all members. I can understand, and hope other members >> understand too. >> >> At least for me, next, I shall send patch to the members which I

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-05 Thread Stefan Hajnoczi
On Tue, Aug 05, 2014 at 11:33:01AM +0800, Ming Lei wrote: > These patches bring up below 4 changes: > - introduce object allocation pool and apply it to > virtio-blk dataplane for improving its performance > > - introduce selective coroutine bypass mechanism > for i

Re: [Qemu-devel] Are -cdrom/-hda (or -drive if=ide) supposed to work in q35?

2014-08-05 Thread Michael Tokarev
05.08.2014 13:30, Kevin Wolf wrote: [] >> However, I don't think we should keep if=ide broken on Q35 just to >> "motivate" such work. > > I agree for the moment. It only becomes a strict requirement once we > attempt to change the default machine type. BTW, maybe, at the very least, produce a war

Re: [Qemu-devel] Are -cdrom/-hda (or -drive if=ide) supposed to work in q35?

2014-08-05 Thread Kevin Wolf
Am 05.08.2014 um 11:13 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 01.08.2014 um 22:10 hat John Snow geschrieben: > >> > >> On 06/12/2014 05:03 AM, Markus Armbruster wrote: > >> >Michael Tokarev writes: > >> > > >> >>10.06.2014 10:34, Paolo Bonzini wrote: > >> >>>Il 10/06/2

Re: [Qemu-devel] [PATCH v3 00/21] target-mips: add MIPS64R6 Instruction Set support

2014-08-05 Thread Leon Alrae
ping http://patchwork.ozlabs.org/patch/365066/ http://patchwork.ozlabs.org/patch/365042/ http://patchwork.ozlabs.org/patch/365046/ http://patchwork.ozlabs.org/patch/365056/ http://patchwork.ozlabs.org/patch/365059/ On 27/06/2014 16:21, Leon Alrae wrote: > The following patchset implements MIPS64

Re: [Qemu-devel] [PATCH 2/2] hw/arm/vexpress: add SP810 to the vexpress

2014-08-05 Thread Aggeler Fabian
On 17 Jul 2014, at 01:29, Peter Crosthwaite wrote: > On Thu, Jul 17, 2014 at 1:05 AM, Alex Bennée wrote: >> >> Fabian Aggeler writes: >> >>> The SP810, which is present in the Versatile Express motherboards, >>> allows to set the timing reference to either REFCLK or TIMCLK. >>> QEMU currentl

Re: [Qemu-devel] [RFC 0/3] QMP: extend BLOCK_IO_ERROR event

2014-08-05 Thread Kevin Wolf
Am 23.07.2014 um 15:17 hat Luiz Capitulino geschrieben: > > Management software, such as OpenStack and RHEV's vdsm, wants to be able > to allocate VM disk space on demand. The basic use case is to start a VM > with a small disk and then the disk is enlarged when QEMU hits a ENOSPC > condition. >

Re: [Qemu-devel] Are -cdrom/-hda (or -drive if=ide) supposed to work in q35?

2014-08-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 01.08.2014 um 22:10 hat John Snow geschrieben: >> >> On 06/12/2014 05:03 AM, Markus Armbruster wrote: >> >Michael Tokarev writes: >> > >> >>10.06.2014 10:34, Paolo Bonzini wrote: >> >>>Il 10/06/2014 08:30, Michael Tokarev ha scritto: >> Hello. >> >> The ques

[Qemu-devel] [PATCH 2/2] scsi-bus: Convert DeviceClass init to realize

2014-08-05 Thread Fam Zheng
Replace "init/destroy" with "realize/unrealize" in SCSIDeviceClass, which has errp as a parameter. So all the implementations now uses error_setg instead of error_report for reporting error. Also in lsi53c895a, report the error when initializing the if=scsi devices, before dropping it, because the

[Qemu-devel] [PATCH 0/2] scsi: Change device init to realize

2014-08-05 Thread Fam Zheng
DeviceClass->init is the old interface, let's convert scsi devices to the new ->realize API. A user visible change is the error message shown in qemu-iotests reference output, but I don't know what's the best way to retain it. So please review if and how this could be improved. Fam Fam Zheng (2)

[Qemu-devel] [PATCH 1/2] block: Pass errp in blkconf_geometry

2014-08-05 Thread Fam Zheng
This allows us to pass error information to caller. Signed-off-by: Fam Zheng --- hw/block/block.c | 18 +- hw/block/virtio-blk.c| 7 +++ hw/ide/qdev.c| 11 --- hw/scsi/scsi-disk.c | 11 --- include/hw/block/block.h | 6 -- 5

[Qemu-devel] [PATCH v4 10/10] target-arm: Add support for VIRQ and VFIQ

2014-08-05 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Acked-by: Greg Bellows Signed-off-by: Edgar E. Iglesias --- cpu-exec.c | 12 target-arm/cpu.c| 25 +++-- target-arm/cpu.h| 36 +--- target-arm/helper-a64.c | 2 ++ target-ar

[Qemu-devel] [PATCH v4 09/10] target-arm: Add IRQ and FIQ routing to EL2 and 3

2014-08-05 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Reviewed-by: Greg Bellows Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h| 12 target-arm/helper.c | 14 ++ 2 files changed, 26 insertions(+) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index f8e976d..6e1cb1f 100644 --- a/targe

[Qemu-devel] [PATCH v4 08/10] target-arm: A64: Emulate the SMC insn

2014-08-05 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h | 1 + target-arm/helper-a64.c| 1 + target-arm/helper.c| 6 ++ target-arm/helper.h| 1 + target-arm/internals.h | 6 ++ target-arm/op_helper.c | 31 +++

[Qemu-devel] [PATCH v4 07/10] target-arm: A64: Emulate the HVC insn

2014-08-05 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h | 1 + target-arm/helper-a64.c| 1 + target-arm/helper.c| 28 +++- target-arm/helper.h| 1 + target-arm/internals.h | 6 ++ target-arm/op_helper.c

<    1   2   3   >