Re: [Qemu-devel] [PATCH 3/5] target-ppc: Build error log

2014-08-26 Thread David Gibson
On Mon, Aug 25, 2014 at 07:15:35PM +0530, Aravinda Prasad wrote: Whenever there is a physical memory error due to bit flips, which cannot be corrected by hardware, the error is passed on to the kernel. If the memory address in error belongs to guest address space then guest kernel is

Re: [Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-26 Thread David Gibson
On Mon, Aug 25, 2014 at 07:15:16PM +0530, Aravinda Prasad wrote: Extend rtas-blob to accommodate error log. Error log structure is saved in rtas space upon a machine check exception. Hrm. Putting the reserved space into the actual firmware image file seems really clumsy to me. Wouldn't it be

Re: [Qemu-devel] [PATCH 2/5] target-ppc: Register and handle HCALL to receive updated RTAS region

2014-08-26 Thread David Gibson
On Mon, Aug 25, 2014 at 07:15:26PM +0530, Aravinda Prasad wrote: Receive updates from SLOF about the updated rtas-base. A separate patch for SLOF [1] adds functionality to invoke a a private HCALL whenever OS issues instantiate-rtas with a new rtas-base. This is required as qemu needs to

Re: [Qemu-devel] [PATCH 5/5] target-ppc: Handle cases when multi-processors get machine-check

2014-08-26 Thread David Gibson
On Mon, Aug 25, 2014 at 07:15:54PM +0530, Aravinda Prasad wrote: It is possible for multi-processors to experience machine check at or about the same time. As per PAPR, subsequent processors serialize waiting for the first processor to issue the ibm,nmi-interlock call. The second processor

Re: [Qemu-devel] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-08-26 Thread David Gibson
On Mon, Aug 25, 2014 at 07:15:45PM +0530, Aravinda Prasad wrote: This patch adds FWNMI support in qemu for powerKVM guests by handling the ibm,nmi-register rtas call. Whenever OS issues ibm,nmi-register RTAS call, the machine check notification address is saved and the machine check interrupt

Re: [Qemu-devel] reporting 9pfs init errors

2014-08-26 Thread Aneesh Kumar K.V
Michael Tokarev m...@tls.msk.ru writes: Hello. I've a bugreport against debian qemu package which basically states that 9pfs does not work. After some digging it turned out to be error reporting problem, plain and simple. The error message is: qemu-system-x86_64: -device

[Qemu-devel] [RFC PATCH v2 0/8] block: Asynchronous request cancellation

2014-08-26 Thread Fam Zheng
v2: Drop the unfinished scsi part, which was broken in v1. (Paolo) Add refcnt in BlockDriverAIOCB to maintain invariant of acb availability in bdrv_aio_cancel_async. (Paolo) Drop blkdebug change. (Stefan) This series adds a new block API: void bdrv_aio_cancel_async(BlockDriverAIOCB

[Qemu-devel] [RFC PATCH v2 1/8] block: Add refcnt in BlockDriverAIOCB

2014-08-26 Thread Fam Zheng
This will be useful in situations like asynchronous cancel emulation. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 12 +++- include/block/aio.h | 2 ++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index e9380f6..f8e342f 100644

[Qemu-devel] [RFC PATCH v2 2/8] block: Add bdrv_aio_cancel_async

2014-08-26 Thread Fam Zheng
This is the async version of bdrv_aio_cancel, which doesn't block the caller. It guarantees that the cb is called either before returning or some time later. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 26 ++ include/block/aio.h | 1 +

[Qemu-devel] [RFC PATCH v2 4/8] linux-aio: Implement .cancel_async

2014-08-26 Thread Fam Zheng
Just call io_cancel (2), if it fails, it means the request is not canceled, so the event loop will eventually call qemu_laio_process_completion. In qemu_laio_process_completion, change to call the cb unconditionally. It is required by .cancel_async, and also acceptable by .cancel. Signed-off-by:

[Qemu-devel] [RFC PATCH v2 3/8] tests: Add testing code for bdrv_aio_cancel_async

2014-08-26 Thread Fam Zheng
Before, done_cb is only called if the request is submitted by thread pool. Now in the async test, done_cb is always called. So update the test criteria accordingly. Signed-off-by: Fam Zheng f...@redhat.com --- tests/test-thread-pool.c | 39 +++ 1 file changed,

[Qemu-devel] [RFC PATCH v2 5/8] thread-pool: Implement .cancel_async

2014-08-26 Thread Fam Zheng
The .cancel_async reuses the first half of .cancel: try to steal the request if not submitted yet. In this case set the elem to a special status THREAD_CANCELED_ASYNC, which means thread_pool_completion_bh should call the cb with -ECANCELED. If the request is already submitted, do nothing, as we

[Qemu-devel] [RFC PATCH v2 6/8] dma: Implement .cancel_async

2014-08-26 Thread Fam Zheng
Just forward the request to bdrv_aio_cancel_async. Use a flag to fix the ret value in completion code. Also check memory address before calling dma_memory_unmap. Signed-off-by: Fam Zheng f...@redhat.com --- dma-helpers.c | 28 1 file changed, 28 insertions(+) diff

Re: [Qemu-devel] [PATCH] xhci: fix debug print compiling error

2014-08-26 Thread Gerd Hoffmann
On Do, 2014-08-21 at 20:48 +0800, arei.gong...@huawei.com wrote: after commit 003e15a180373048f0c1f4df0bfe303746eb2676 the DPRINTF will broke compiling, adjust its location. Added to usb queue. thanks, Gerd

[Qemu-devel] [RFC PATCH v2 8/8] iscsi: Implement .cancel_async in acb info

2014-08-26 Thread Fam Zheng
Factor out the cancellation submission part in iscsi_aio_cancel, which is all what is needed for .cancel_async. The cb passed to iscsi_task_mgmt_abort_task_async, iscsi_abort_task_cb, will be called later, so for iscsi_bh_cb. In iscsi_bh_cb, acb-canceled is not set if canceled by .cancel_async,

Re: [Qemu-devel] 9p mapped-* security model infos are architecture-specific

2014-08-26 Thread Aneesh Kumar K.V
Michael Tokarev m...@tls.msk.ru writes: I haven't noticed this email - which is almost a month old now - until today. So replying now... 30.07.2014 21:43, Aneesh Kumar K.V wrote: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com writes: Michael Tokarev m...@tls.msk.ru writes: Apparently

[Qemu-devel] [RFC PATCH v2 7/8] block: Implement bdrv_em_co_aiocb_info.cancel_async

2014-08-26 Thread Fam Zheng
Nothing to do here. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block.c b/block.c index f4c77ec..ac1cfb4 100644 --- a/block.c +++ b/block.c @@ -4746,9 +4746,16 @@ static void bdrv_aio_co_cancel_em(BlockDriverAIOCB *blockacb)

Re: [Qemu-devel] [PATCH 3/3] target-ppc: virtex-ml507 machine type should depend on CONFIG_XILINX

2014-08-26 Thread Peter Crosthwaite
On Tue, Aug 26, 2014 at 2:30 PM, David Gibson da...@gibson.dropbear.id.au wrote: The virtex-ml507 is a Xilinx CPU based system, and requires several sub devices which are only included with CONFIG_XILINX. Therefore, it should only be compiled if CONFIG_XILINX is set. Signed-off-by: David

Re: [Qemu-devel] Bug#758881: [bisected] VNC server can't get all sent chars correctly

2014-08-26 Thread Gerd Hoffmann
On Di, 2014-08-26 at 09:55 +0400, Michael Tokarev wrote: 26.08.2014 09:40, Gerd Hoffmann wrote: There should be a delay after every character. It can be pretty small. 10ms should be enough (you should set TCP_NODELAY though to make sure the key events are not buffered in the network

Re: [Qemu-devel] [PATCH 2/5] target-ppc: Register and handle HCALL to receive updated RTAS region

2014-08-26 Thread Benjamin Herrenschmidt
On Tue, 2014-08-26 at 15:39 +1000, David Gibson wrote: On Mon, Aug 25, 2014 at 07:15:26PM +0530, Aravinda Prasad wrote: Receive updates from SLOF about the updated rtas-base. A separate patch for SLOF [1] adds functionality to invoke a a private HCALL whenever OS issues instantiate-rtas

Re: [Qemu-devel] [libvirt] Mentors wanted for Outreach Program for Women October 2014

2014-08-26 Thread Marina Zhurakhinskaya
- Original Message - From: Stefan Hajnoczi stefa...@gmail.com To: Martin Kletzander mklet...@redhat.com Cc: qemu-devel qemu-devel@nongnu.org, libvir-l...@redhat.com, kvm k...@vger.kernel.org, Marina Zhurakhinskaya mari...@redhat.com Sent: Monday, August 25, 2014 12:29:27 PM

Re: [Qemu-devel] Bug#758881: [bisected] VNC server can't get all sent chars correctly

2014-08-26 Thread Marc
Hi, On August 25, 2014 at 3:40:01 AM, Gabriele Giacone (1o5g4...@gmail.com) wrote: IMO vncdotool should be fixed to add small delays between keyboard  events, as if a real person is typing, instead of sending the key events  at the maximum possible speed.  vncdotool does have a

[Qemu-devel] [PATCH] virtio-scsi: Report error if num_queues is 0 or too large

2014-08-26 Thread Fam Zheng
No cmd vq surprises guest (Linux panics in virtscsi_probe), too many queues abort qemu (in the following virtio_add_queue). Signed-off-by: Fam Zheng f...@redhat.com --- hw/scsi/virtio-scsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c

Re: [Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-26 Thread Aravinda Prasad
On Tuesday 26 August 2014 11:08 AM, David Gibson wrote: On Mon, Aug 25, 2014 at 07:15:16PM +0530, Aravinda Prasad wrote: Extend rtas-blob to accommodate error log. Error log structure is saved in rtas space upon a machine check exception. Hrm. Putting the reserved space into the actual

Re: [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take effect after rebooting

2014-08-26 Thread Gerd Hoffmann
The patchsets add one qmp interface, and add an fw_cfg_machine_reset() to achieve it. (qemu) set-bootindex ide0-0-1 1 The bootindex 1 has already been used What happened to the idea to use qom-set instead? I liked that suggestion. Solves the suffix issue in a nice way. cheers, Gerd

[Qemu-devel] [PATCH v2 1/2] device_tree.c: redirect load_device_tree err message to stderr

2014-08-26 Thread john.liuli
From: Li Liu john.li...@huawei.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Li Liu john.li...@huawei.com --- changes v1 - v2: 1) fix indent issue as peter suggested. 2) dump all err mesages with error_report. --- device_tree.c | 15 --- 1 file

Re: [Qemu-devel] [PATCH 3/5] target-ppc: Build error log

2014-08-26 Thread Aravinda Prasad
On Tuesday 26 August 2014 11:17 AM, David Gibson wrote: On Mon, Aug 25, 2014 at 07:15:35PM +0530, Aravinda Prasad wrote: Whenever there is a physical memory error due to bit flips, which cannot be corrected by hardware, the error is passed on to the kernel. If the memory address in error

[Qemu-devel] [PATCH v2 2/2] device_tree.c: dump all err mesages with error_report

2014-08-26 Thread john.liuli
From: Li Liu john.li...@huawei.com Signed-off-by: Li Liu john.li...@huawei.com --- device_tree.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/device_tree.c b/device_tree.c index 9d47195..df9eed9 100644 --- a/device_tree.c +++

Re: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards

2014-08-26 Thread Gerd Hoffmann
On Di, 2014-08-05 at 16:05 +0200, Markus Armbruster wrote: Ping? Back online. What is the state here? I've seen Stefan (Cc'ed) posted a different patch for the same issue? Anything merged meanwhile? cheers, Gerd Markus Armbruster arm...@redhat.com writes: Gerd Hoffmann

Re: [Qemu-devel] [RFC PATCH v2 06/13] spapr_iommu: Implement free_table() helper

2014-08-26 Thread David Gibson
On Fri, Aug 15, 2014 at 08:12:28PM +1000, Alexey Kardashevskiy wrote: Every sPAPRTCETable object holds an IOMMU memory region which holds a referenced to the sPAPRTCETable instance. So if we want to free an sPAPRTCETable instance, calling object_unref() will not be enough as embedded memory

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-08-26 Thread Benoît Canet
On Tue, Aug 26, 2014 at 12:42:04PM +0800, Fam Zheng wrote: On Mon, 08/25 12:12, Benoît Canet wrote: On Mon, Aug 25, 2014 at 05:37:37PM +0800, Fam Zheng wrote: On Mon, 08/25 09:06, Benoît Canet wrote: On Mon, Aug 25, 2014 at 02:04:24PM +0800, Fam Zheng wrote: On Fri, 08/22 18:11,

Re: [Qemu-devel] [PATCH v3 2/2] docs: update ivshmem device spec

2014-08-26 Thread David Marchand
Hello Stefan, On 08/08/2014 05:02 PM, Stefan Hajnoczi wrote: On Fri, Aug 08, 2014 at 10:55:18AM +0200, David Marchand wrote: +For each client (QEMU processes) that connects to the server: +- the server assigns an ID for this client and sends this ID to him as the first + message, +- the

[Qemu-devel] [PATCH] block: Always compile virtio-blk dataplane

2014-08-26 Thread Fam Zheng
Dataplane doesn't depend on linux-aio any more, so we don't need the compiling condition now. Configure options are kept but just print a message. Signed-off-by: Fam Zheng f...@redhat.com --- configure | 21 ++--- hw/block/Makefile.objs | 2 +-

Re: [Qemu-devel] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-08-26 Thread Aravinda Prasad
On Tuesday 26 August 2014 11:32 AM, David Gibson wrote: On Mon, Aug 25, 2014 at 07:15:45PM +0530, Aravinda Prasad wrote: This patch adds FWNMI support in qemu for powerKVM guests by handling the ibm,nmi-register rtas call. Whenever OS issues ibm,nmi-register RTAS call, the machine check

Re: [Qemu-devel] Using cache=writeback safely on qemu 1.4.0 and later

2014-08-26 Thread Paolo Bonzini
Il 25/08/2014 20:13, Andrew Martin ha scritto: Even if the python daemon or apache2 did not fsync the modified files, isn't there some action that the OS takes periodically to flush dirty pages to disk? This seems to be implied in the SuSE documentation:

Re: [Qemu-devel] [RFC PATCH v2 06/13] spapr_iommu: Implement free_table() helper

2014-08-26 Thread Alexey Kardashevskiy
On 08/26/2014 04:16 PM, David Gibson wrote: On Fri, Aug 15, 2014 at 08:12:28PM +1000, Alexey Kardashevskiy wrote: Every sPAPRTCETable object holds an IOMMU memory region which holds a referenced to the sPAPRTCETable instance. So if we want to free an sPAPRTCETable instance, calling

Re: [Qemu-devel] [PATCH 5/5] target-ppc: Handle cases when multi-processors get machine-check

2014-08-26 Thread Aravinda Prasad
On Tuesday 26 August 2014 11:34 AM, David Gibson wrote: On Mon, Aug 25, 2014 at 07:15:54PM +0530, Aravinda Prasad wrote: It is possible for multi-processors to experience machine check at or about the same time. As per PAPR, subsequent processors serialize waiting for the first processor to

Re: [Qemu-devel] [PATCH] spapr_pci: Fix config space corruption

2014-08-26 Thread Alexey Kardashevskiy
On 08/13/2014 05:20 PM, Alexey Kardashevskiy wrote: When disabling MSI/MSIX via ibm,change-msi RTAS call, no check was made if MSI or MSIX is actually supported and the MSI message was reset unconditionally. If this happened on a device which does not support MSI (but does support MSIX,

[Qemu-devel] [PATCH 02/12] pcspk: adding vmstate for save/restore

2014-08-26 Thread Pavel Dovgalyuk
VMState added by this patch preserves correct loading of the PC speaker device state. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/audio/pcspk.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c index

[Qemu-devel] [PATCH 04/12] parallel: adding vmstate for save/restore

2014-08-26 Thread Pavel Dovgalyuk
VMState added by this patch preserves correct loading of the parallel port controller state. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/char/parallel.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/hw/char/parallel.c

[Qemu-devel] [PATCH 00/12] Fixing hardware migration issues

2014-08-26 Thread Pavel Dovgalyuk
This set of patches is related to migration issues in hardware devices. Some of the devices had fields in their states that didn't saved and restored. These patches add missed fields to the new subsections of the vmstates. For several devices (like integratorcp) the patches add new vmstates, that

[Qemu-devel] [PATCH 01/12] integratorcp: adding vmstate for save/restore

2014-08-26 Thread Pavel Dovgalyuk
VMState added by this patch preserves correct loading of the integratorcp device state. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/arm/integratorcp.c | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-26 Thread Pavel Dovgalyuk
This patch adds virtual clock-dependent timers to VMState to allow correct saving and restoring the state of RTL8139 network controller. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/net/rtl8139.c | 50 -- 1 files changed, 48

[Qemu-devel] [PATCH 05/12] serial: fixing vmstate for save/restore

2014-08-26 Thread Pavel Dovgalyuk
Some fields were added to VMState by this patch to preserve correct loading of the serial port controller state. Updating FCR value while loading was also modified to disable generating an interrupt by loadvm. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/char/serial.c | 264

[Qemu-devel] [PATCH 07/12] hpet: fixing saving and loading process

2014-08-26 Thread Pavel Dovgalyuk
VM clock does not run while saving, so there is no need for saving the ticks in HPET. Also added saving of hpet_offset field. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/timer/hpet.c | 15 ++- 1 files changed, 2 insertions(+), 13 deletions(-) diff --git

[Qemu-devel] [PATCH 03/12] fdc: adding vmstate for save/restore

2014-08-26 Thread Pavel Dovgalyuk
VMState added by this patch preserves correct loading of the FDC device state. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/block/fdc.c | 81 1 files changed, 81 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-26 Thread Pavel Dovgalyuk
vapic state should not be synchronized with APIC while loading, because APIC state could be not loaded yet at that moment. We just save vapic_paddr in APIC VMState instead of synchronization. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/i386/kvmvapic.c | 22

[Qemu-devel] [PATCH] coroutine: Drop co_sleep_ns

2014-08-26 Thread Fam Zheng
block_job_sleep_ns is the only user. Since we are moving towards AioContext aware code, it's better to use the explict version and drop the old one. Signed-off-by: Fam Zheng f...@redhat.com --- blockjob.c| 2 +- include/block/coroutine.h | 8 qemu-coroutine-sleep.c

[Qemu-devel] [PATCH 08/12] pckbd: adding new fields to vmstate

2014-08-26 Thread Pavel Dovgalyuk
This patch adds outport to VMState to allow correct saving and restoring the state of PC keyboard controller. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/input/pckbd.c | 51 +++ 1 files changed, 51 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [RFC PATCH v2 09/13] spapr_pci_vfio: Call spapr_pci::reset on reset

2014-08-26 Thread David Gibson
On Fri, Aug 15, 2014 at 08:12:31PM +1000, Alexey Kardashevskiy wrote: This enables use of the parent class rest() callback in VFIO. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- I honestly do not remember why I did not do this when I added VFIO at the first place... This or

Re: [Qemu-devel] [RFC PATCH v2 08/13] spapr_pci: Enable DDW

2014-08-26 Thread David Gibson
On Fri, Aug 15, 2014 at 08:12:30PM +1000, Alexey Kardashevskiy wrote: This implements DDW for emulated PHB. This advertises DDW in device tree. Since QEMU does not implement any 64bit DMA capable device, this hack has been used to enable 64bit DMA on E1000: diff --git a/hw/net/e1000.c

[Qemu-devel] [PATCH 12/12] pl031: add missed field to vmstate

2014-08-26 Thread Pavel Dovgalyuk
This patch adds timer which uses virtual clock to the VMState. Such timers are required for saving because virtual clock is the part of the virtual machine state. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/timer/pl031.c |3 ++- 1 files changed, 2 insertions(+), 1

[Qemu-devel] [PATCH 10/12] piix: do not raise irq while loading vmstate

2014-08-26 Thread Pavel Dovgalyuk
This patch disables raising an irq while loading the state of PCI bridge. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/pci-host/piix.c | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index

Re: [Qemu-devel] [RFC PATCH v2 07/13] spapr_rtas: Add Dynamic DMA windows (DDW) RTAS calls support

2014-08-26 Thread David Gibson
On Fri, Aug 15, 2014 at 08:12:29PM +1000, Alexey Kardashevskiy wrote: This adds support for Dynamic DMA Windows (DDW) option defined by the SPAPR specification which allows to have additional DMA window(s) which can support page sizes other than 4K. The existing implementation of DDW in the

Re: [Qemu-devel] [RFC PATCH v2 12/13] vfio: Enable DDW ioctls to VFIO IOMMU driver

2014-08-26 Thread David Gibson
On Fri, Aug 15, 2014 at 08:12:34PM +1000, Alexey Kardashevskiy wrote: This enables DDW RTAS-related ioctls in VFIO. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru This should probably just be folded into the previous patch. It's broken without this change. -- David Gibson

[Qemu-devel] [PATCH 11/12] mc146818rtc: add missed field to vmstate

2014-08-26 Thread Pavel Dovgalyuk
This patch adds irq_reinject_on_ack_count field to VMState to allow correct saving/loading the state of MC146818 RTC. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/timer/mc146818rtc.c | 32 1 files changed, 32 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [RFC PATCH v2 11/13] spapr_pci_vfio: Enable DDW

2014-08-26 Thread David Gibson
On Fri, Aug 15, 2014 at 08:12:33PM +1000, Alexey Kardashevskiy wrote: This implements DDW for VFIO. Host kernel support is required for this. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- Changes: v2: * remove()/reset() callbacks use spapr_pci's ones --- hw/ppc/spapr_pci_vfio.c

Re: [Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-26 Thread David Gibson
On Tue, Aug 26, 2014 at 12:04:27PM +0530, Aravinda Prasad wrote: On Tuesday 26 August 2014 11:08 AM, David Gibson wrote: On Mon, Aug 25, 2014 at 07:15:16PM +0530, Aravinda Prasad wrote: Extend rtas-blob to accommodate error log. Error log structure is saved in rtas space upon a machine

Re: [Qemu-devel] [PATCH 2/5] target-ppc: Register and handle HCALL to receive updated RTAS region

2014-08-26 Thread David Gibson
On Tue, Aug 26, 2014 at 04:15:40PM +1000, Benjamin Herrenschmidt wrote: On Tue, 2014-08-26 at 15:39 +1000, David Gibson wrote: On Mon, Aug 25, 2014 at 07:15:26PM +0530, Aravinda Prasad wrote: Receive updates from SLOF about the updated rtas-base. A separate patch for SLOF [1] adds

Re: [Qemu-devel] [PATCH v6 0/3] linux-aio: introduce submit I/O asa batch

2014-08-26 Thread Zhang Haoyu
Hi, The commit 580b6b2aa2(dataplane: use the QEMU block layer for I/O) introduces ~40% throughput regression on virtio-blk dataplane, and one of causes is that submitting I/O as a batch is removed. This patchset trys to introduce this mechanism on block, at least, linux-aio can benefit

Re: [Qemu-devel] [PATCH v6 0/3] linux-aio: introduce submit I/O asa batch

2014-08-26 Thread Fam Zheng
On Tue, 08/26 15:31, Zhang Haoyu wrote: Can we use the queued io data as caches, io write will directly return and tell the guest the io is completed after the io is enqueued, better user experience for burst io, and io-read will firstly search the io queue, if matched data found, directly

Re: [Qemu-devel] [PATCH 01/12] spapr: populate DRC entries for root dt node

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: From: Nathan Fontenot nf...@linux.vnet.ibm.com This add entries to the root OF node to advertise our PHBs as being DR-capable in according with PAPR specification. Each PHB is given a name of PHBbus#, advertised as a PHB type, and associated

Re: [Qemu-devel] [PATCH v6 0/3] linux-aio: introduce submit I/O as a batch

2014-08-26 Thread Zhang Haoyu
Hi, The commit 580b6b2aa2(dataplane: use the QEMU block layer for I/O) introduces ~40% throughput regression on virtio-blk dataplane, and one of causes is that submitting I/O as a batch is removed. This patchset trys to introduce this mechanism on block, at least, linux-aio can benefit

Re: [Qemu-devel] [RFC PATCH v3 15/49] softmmu: fixing usage of cpu_st/ld* from helpers

2014-08-26 Thread Pavel Dovgaluk
From: Alex Bennée [mailto:alex.ben...@linaro.org] Pavel Dovgalyuk writes: MMU helper functions are called from generated code and other helper functions. In both cases they try to get function's return address for using it while restoring virtual CPU state. When MMU helper is called

[Qemu-devel] [PATCH V4] net: Forbid dealing with packets when VM is not running

2014-08-26 Thread zhanghailiang
For all NICs(except virtio-net) emulated by qemu, Such as e1000, rtl8139, pcnet and ne2k_pci, Qemu can still receive packets when VM is not running. If this happened in *migration's* last PAUSE VM stage, but before the end of the migration, the new receiving packets will possibly dirty parts of

Re: [Qemu-devel] [RFC PATCH v2 08/13] spapr_pci: Enable DDW

2014-08-26 Thread Alexey Kardashevskiy
On 08/26/2014 05:14 PM, David Gibson wrote: On Fri, Aug 15, 2014 at 08:12:30PM +1000, Alexey Kardashevskiy wrote: This implements DDW for emulated PHB. This advertises DDW in device tree. Since QEMU does not implement any 64bit DMA capable device, this hack has been used to enable 64bit DMA

Re: [Qemu-devel] [RFC PATCH v2 11/13] spapr_pci_vfio: Enable DDW

2014-08-26 Thread Alexey Kardashevskiy
On 08/26/2014 05:19 PM, David Gibson wrote: On Fri, Aug 15, 2014 at 08:12:33PM +1000, Alexey Kardashevskiy wrote: This implements DDW for VFIO. Host kernel support is required for this. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- Changes: v2: * remove()/reset() callbacks use

Re: [Qemu-devel] [RFC PATCH v2 12/13] vfio: Enable DDW ioctls to VFIO IOMMU driver

2014-08-26 Thread Alexey Kardashevskiy
On 08/26/2014 05:20 PM, David Gibson wrote: On Fri, Aug 15, 2014 at 08:12:34PM +1000, Alexey Kardashevskiy wrote: This enables DDW RTAS-related ioctls in VFIO. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru This should probably just be folded into the previous patch. It's broken

Re: [Qemu-devel] [PATCH 01/12] spapr: populate DRC entries for root dt node

2014-08-26 Thread Alexey Kardashevskiy
On 08/26/2014 05:55 PM, Alexey Kardashevskiy wrote: On 08/19/2014 10:21 AM, Michael Roth wrote: From: Nathan Fontenot nf...@linux.vnet.ibm.com This add entries to the root OF node to advertise our PHBs as being DR-capable in according with PAPR specification. Each PHB is given a name of

Re: [Qemu-devel] [PATCH 02/12] spapr_pci: populate DRC dt entries for PHBs

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: Reserve 32 entries of type PCI in each PHB's initial FDT. This advertises to guests that each PHB is DR-capable device with physical hotpluggable slots. This is necessary for allowing hotplugging of devices to it later via bus rescan or guest rpaphp

Re: [Qemu-devel] [0/3] target-ppc Fixes for some missing config dependencies

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 06:30, David Gibson ha scritto: These 3 patches fix some places where things ought to depend on an existing config variable, but don't. Which header provdides the #defines? Paolo

Re: [Qemu-devel] [PATCH v6 0/3] linux-aio: introduce submit I/O asabatch

2014-08-26 Thread Zhang Haoyu
Can we use the queued io data as caches, io write will directly return and tell the guest the io is completed after the io is enqueued, better user experience for burst io, and io-read will firstly search the io queue, if matched data found, directly get the data from the queue, if

Re: [Qemu-devel] [RFC PATCH v2 5/8] thread-pool: Implement .cancel_async

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 08:08, Fam Zheng ha scritto: +qemu_mutex_lock(pool-lock); +if (thread_pool_cancel_from_queue(elem)) { +elem-state = THREAD_CANCELED_ASYNC; +} Can you simply set it to THREAD_DONE (and set elem-ret to -ECANCELED)? Paolo

Re: [Qemu-devel] [RFC PATCH v2 6/8] dma: Implement .cancel_async

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 08:08, Fam Zheng ha scritto: +if (dbs-cancelled) { +ret = -ECANCELED; +} Why is dbs-cancelled necessary? dma_bdrv_unmap(dbs); if (dbs-common.cb) { dbs-common.cb(dbs-common.opaque, ret); @@ -141,6 +148,9 @@ static void dma_bdrv_cb(void

Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: This patch adds virtual clock-dependent timers to VMState to allow correct saving and restoring the state of RTL8139 network controller. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/net/rtl8139.c | 50

Re: [Qemu-devel] [PATCH 11/12] mc146818rtc: add missed field to vmstate

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: +static int rtc_pre_load(void *opaque) +{ +RTCState *s = (RTCState *)opaque; +s-irq_reinject_on_ack_count = 0; +return 0; +} + You found a real bug here, in that the field has to be cleared at reset time. But reinitializing

Re: [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take effect after rebooting

2014-08-26 Thread Gonglei (Arei)
Hi, Gerd Nice to meet you again in maillist. :) -Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Tuesday, August 26, 2014 2:36 PM Subject: Re: [PATCH v5 0/8] modify boot order of guest, and take effect after rebooting The patchsets add one qmp interface,

Re: [Qemu-devel] [PATCH 02/12] spapr_pci: populate DRC dt entries for PHBs

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: Reserve 32 entries of type PCI in each PHB's initial FDT. This advertises to guests that each PHB is DR-capable device with physical hotpluggable slots. This is necessary for allowing hotplugging of devices to it later via bus rescan or guest rpaphp

Re: [Qemu-devel] [PATCH 03/12] fdc: adding vmstate for save/restore

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:14, Pavel Dovgalyuk ha scritto: +static int fdc_pre_load(void *opaque) +{ +FDCtrl *s = opaque; +s-reset_sensei = 0; +timer_del(s-result_timer); +return 0; +} This should be in fdctrl_reset. Paolo

Re: [Qemu-devel] [PATCH 04/12] parallel: adding vmstate for save/restore

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:14, Pavel Dovgalyuk ha scritto: VMState added by this patch preserves correct loading of the parallel port controller state. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/char/parallel.c | 20 1 files changed, 20 insertions(+), 0

Re: [Qemu-devel] [PATCH 02/12] pcspk: adding vmstate for save/restore

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:14, Pavel Dovgalyuk ha scritto: VMState added by this patch preserves correct loading of the PC speaker device state. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/audio/pcspk.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH 08/12] pckbd: adding new fields to vmstate

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: This patch adds outport to VMState to allow correct saving and restoring the state of PC keyboard controller. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/input/pckbd.c | 51

Re: [Qemu-devel] [PATCH 07/12] spapr_pci: add ibm, configure-connector RTAS interface

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com I have totally no idea what this patch actually does :) When is this rtas call made? Once after the guest received the check exception interrupt? Is it all it does is fetching the copy of the device

Re: [Qemu-devel] [PATCH 08/12] pci: allow 0 address for PCI IO regions

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: Some kernels program a 0 address for io regions. PCI 3.0 spec section 6.2.5.1 doesn't seem to disallow this. I remember there was discussion about it but I forgot :) Why does it have to be a part of this patchset? Worth mentioning in the commit log I

Re: [Qemu-devel] [RFC PATCH v2 6/8] dma: Implement .cancel_async

2014-08-26 Thread Fam Zheng
On Tue, 08/26 10:46, Paolo Bonzini wrote: Il 26/08/2014 08:08, Fam Zheng ha scritto: +if (dbs-cancelled) { +ret = -ECANCELED; +} Why is dbs-cancelled necessary? Request may complete after bdrv_aio_cancel_async with other status, this flag is checked to fix the status to

Re: [Qemu-devel] [PATCH 10/12] piix: do not raise irq while loading vmstate

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: This patch disables raising an irq while loading the state of PCI bridge. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- hw/pci-host/piix.c | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH v3 00/12] spapr: add support for pci hotplug

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: These patches are based on ppc-next, and can also be obtained from: https://github.com/mdroth/qemu/commits/spapr-pci-hotplug-v3-ppc-next v3: * dropped emulation of firmware-managed BAR allocation. this will be introduced via a follow-up

Re: [Qemu-devel] [RFC PATCH v2 5/8] thread-pool: Implement .cancel_async

2014-08-26 Thread Fam Zheng
On Tue, 08/26 10:42, Paolo Bonzini wrote: Il 26/08/2014 08:08, Fam Zheng ha scritto: +qemu_mutex_lock(pool-lock); +if (thread_pool_cancel_from_queue(elem)) { +elem-state = THREAD_CANCELED_ASYNC; +} Can you simply set it to THREAD_DONE (and set elem-ret to

Re: [Qemu-devel] [PATCH 10/12] spapr_events: re-use EPOW event infrastructure for hotplug events

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: From: Nathan Fontenot nf...@linux.vnet.ibm.com This extends the data structures currently used to report EPOW events to gets via the check-exception RTAS interfaces to also include event types for hotplug/unplug events. This is currently

Re: [Qemu-devel] [PATCH 11/12] spapr_events: event-scan RTAS interface

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: From: Tyrel Datwyler tyr...@linux.vnet.ibm.com We don't actually rely on this interface to surface hotplug events, and instead rely on the similar-but-interrupt-driven check-exception RTAS interface used for EPOW events. However, the existence of

Re: [Qemu-devel] [question] e1000 interrupt storm happened becauseof its correspondingioapic-irr bit always set

2014-08-26 Thread Zhang Haoyu
Hi, all I use a qemu-1.4.1/qemu-2.0.0 to run win7 guest, and encounter e1000 NIC interrupt storm, because if (!ent-fields.mask (ioapic-irr (1 i))) is always true in __kvm_ioapic_update_eoi(). Any ideas? We meet this several times: search the autoneg patches for an example of

Re: [Qemu-devel] [PATCH v2 1/1] pc-dimm: Change PCDIMMDevice-node from UINT32 to INT32, and initialize it as -1.

2014-08-26 Thread tangchen
Hi , Would anybody help to review this patch ? Thanks. :) On 08/19/2014 09:55 AM, Tang Chen wrote: If user doesn't specify numa options, nb_numa_nodes will be 0. But PCDIMMDevice-node is also initialized to 0. As a result, the following check will fail: pc_dimm_realize() { ..

Re: [Qemu-devel] [libvirt] Mentors wanted for Outreach Program for Women October 2014

2014-08-26 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 5:40 PM, Marina Zhurakhinskaya mari...@redhat.com wrote: - Original Message - From: Stefan Hajnoczi stefa...@gmail.com To: Martin Kletzander mklet...@redhat.com Cc: qemu-devel qemu-devel@nongnu.org, libvir-l...@redhat.com, kvm k...@vger.kernel.org, Marina

Re: [Qemu-devel] [PATCH 12/12] spapr_pci: emit hotplug add/remove events during hotplug

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: From: Tyrel Datwyler tyr...@linux.vnet.ibm.com This uses extension of existing EPOW interrupt/event mechanism to notify userspace tools like librtas/drmgr to handle in-guest configuration/cleanup operations in response to device_add/device_del.

Re: [Qemu-devel] [libvirt] Mentors wanted for Outreach Program for Women October 2014

2014-08-26 Thread Martin Kletzander
On Tue, Aug 26, 2014 at 10:33:27AM +0100, Stefan Hajnoczi wrote: On Mon, Aug 25, 2014 at 5:40 PM, Marina Zhurakhinskaya mari...@redhat.com wrote: - Original Message - From: Stefan Hajnoczi stefa...@gmail.com To: Martin Kletzander mklet...@redhat.com Cc: qemu-devel

Re: [Qemu-devel] [PATCH 09/12] spapr_pci: enable basic hotplug operations

2014-08-26 Thread Alexey Kardashevskiy
On 08/19/2014 10:21 AM, Michael Roth wrote: This enables hotplug for PHB bridges. Upon hotplug we generate the OF-nodes required by PAPR specification and IEEE 1275-1994 PCI Bus Binding to Open Firmware for the device. We associate the corresponding FDT for these nodes with the DrcEntry

Re: [Qemu-devel] [RFC PATCH v2 6/8] dma: Implement .cancel_async

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 11:21, Fam Zheng ha scritto: On Tue, 08/26 10:46, Paolo Bonzini wrote: Il 26/08/2014 08:08, Fam Zheng ha scritto: +if (dbs-cancelled) { +ret = -ECANCELED; +} Why is dbs-cancelled necessary? Request may complete after bdrv_aio_cancel_async with other status,

Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate

2014-08-26 Thread Paolo Bonzini
Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: vapic state should not be synchronized with APIC while loading, because APIC state could be not loaded yet at that moment. We just save vapic_paddr in APIC VMState instead of synchronization. Can you use a vm_change_state_handler, or a

Re: [Qemu-devel] [PATCH v5 0/8] modify boot order of guest, and take effect after rebooting

2014-08-26 Thread Gerd Hoffmann
On Di, 2014-08-26 at 09:07 +, Gonglei (Arei) wrote: Hi, Gerd Nice to meet you again in maillist. :) -Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Tuesday, August 26, 2014 2:36 PM Subject: Re: [PATCH v5 0/8] modify boot order of guest, and take

Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports and downstream ports

2014-08-26 Thread Gonglei (Arei)
From: Michael S. Tsirkin [mailto:m...@redhat.com] Subject: Re: [PATCH v2 2/2] pci: add check for pcie root ports and downstream ports On Thu, Aug 21, 2014 at 05:47:46PM +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com If ARI Forwarding is disabled, according

  1   2   3   >