On 22.09.2014 21:06, Paolo Bonzini wrote:
Il 22/09/2014 11:43, Peter Lieven ha scritto:
This series aims not at touching default behaviour. The default for
max_transfer_length
is 0 (no limit). max_transfer_length is a limit that MUST be satisfied
otherwise the request
will fail. And Patch 2 ai
Provides HMP equivalent of QMP query-memory-devices command.
Signed-off-by: Zhu Guihua
---
Changes since v4:
- enclose ID in double quotes.
Changes since v3:
- optimize the time to print memory devices' information.
- change output format of di->addr and di->size.
Changes since v2:
- print addr
On Mon, 2014-09-22 at 22:38 +0200, Laszlo Ersek wrote:
> The first patch introduces a generic comparator. This comparator should
> cover all machine types at once that don't belong to machine type
> "families". Hence, for example, the output it produces for
>
> qemu-system-aarch64 -M \?
>
> is
On Mon, Sep 22, 2014 at 03:08:09PM +0200, Paolo Bonzini wrote:
> Of course, with every new feature we would most likely have yet another
> unfinished transition. In the lack of a clear user complaint (or even
> of a clear indication that human users ever used -device foo,help...)
> the tempation t
Dear all,
Many thanks for the fix. I am currently travelling but I will test it
early next week with vfio PCI & platform case. Also following Alex
advises, I will move [RFC] vfio: migration to trace points into a PATCH.
Best Regards
Eric
On 09/22/2014 07:35 PM, Lluís Vilanova wrote:
> Stefan H
On Mon, Sep 22, 2014 at 07:28:57PM +0200, Greg Kurz wrote:
> On Thu, 18 Sep 2014 21:54:58 +0300
> "Michael S. Tsirkin" wrote:
>
> > Current support for bus master (clearing OK bit)
> > together with the need to support guests which do not
> > enable PCI bus mastering, leads to extra state in
> >
> Subject: Re: [Qemu-devel] [PATCH 0/2] qom: add error handler for security
>
> On 09/22/2014 09:25 PM, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > The PATCH 2 is splited from another patch series, which has been
>
> s/splited/split/
>
> 'split' is one of those stupid English word
On 09/22/2014 09:25 PM, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> The PATCH 2 is splited from another patch series, which has been
s/splited/split/
'split' is one of those stupid English words whose past tense is spelled
identically to its present tense.
--
Eric Blake eblake redha
On Mon, Sep 22, 2014 at 05:54:02PM +0100, Alex Bligh wrote:
> However, that's not compatible with using PC_COMPAT as far as I
> know (unless there is some cunning way you can make a machine
> parameter change compat_props things).
Of course not, PC_COMPAT is the reverse: have machine type
influenc
On Mon, Sep 22, 2014 at 05:45:28PM +0200, Andreas Färber wrote:
> Am 22.09.2014 um 15:05 schrieb Alex Bligh:
> >>> Sadly that is not true. For instance on Ubuntu Precise
> >>> it's invoked as qemu-system-x86_64 by at least one
> >>> management application known to me.
> >>
> >> Well change it to ca
From: Gonglei
The PATCH 2 is splited from another patch series, which has been
reviewed by Paolo. PATCH 1 can avoid possible leaking memory.
Gonglei (2):
qom: add error handler for object_property_print()
qom: add error handler for object alias property
qom/object.c | 21 +
From: Gonglei
object_property_add_alias() is called at some
places at present. And its parameter errp may not NULL,
such as
object_property_add_alias(obj, "iothread", OBJECT(&dev->vdev),"iothread",
&error_abort);
This patch add error handler for security.
Cc: Stefa
From: Gonglei
Avoid the caller of object_property_print() leaking string
argument's memory, such as qdev_print_props() when
encounter errors.
Cc: Paolo Bonzini
Signed-off-by: Gonglei
---
qom/object.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/qom/object.
Hi,
> This doesn't change the fact that ObjectProperty is a generic struct,
> and adding alias-specific fields there is wrong.
> >>>
> >>> OK, Maybe I should find other ways to attach this purpose and
> >>> avoid layering violation. Thanks!
> >>
> >> Unfortunately I cannot think of any.
When we expand a number range, we just print "$id - unknown test,
ignored", this is convenient if we want to run a range of tests.
When we designate a test case number explicitly, we shouldn't just
ignore it if the case script doesn't exist.
Print an error and fail the test.
Signed-off-by: Fam Z
This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster
allocation).
$ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k'
write failed: Invalid argument
Reported-by: Mark Cave-Ayland
Reviewed-by: Max Reitz
Signed-off-by: Fam Zheng
---
v5: Fix group file and output refe
On Mon, 09/22 14:32, Max Reitz wrote:
> On 22.09.2014 09:15, Fam Zheng wrote:
> >This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster
> >allocation).
> >
> >$ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k'
> >write failed: Invalid argument
> >
> >Reported-by: Mark Cav
On Mon, 09/22 21:23, Zhang Haoyu wrote:
> >
> >Amit,
> >
> >It's related to the big number of ioeventfds used in virtio-serial-pci. With
> >virtio-serial-pci's ioeventfd=off, the performance is not affected no matter
> >if
> >guest initializes it or not.
> >
> >In my test, there are 12 fds to poll
On Mon, 2014-09-22 at 09:03 -0400, Luiz Capitulino wrote:
> On Mon, 22 Sep 2014 11:29:00 +0200
> Markus Armbruster wrote:
>
> > Igor Mammedov writes:
> >
> > > On Mon, 22 Sep 2014 09:59:06 +0200
> > > Markus Armbruster wrote:
> > >
> > >> zhugh writes:
> > >>
> > >> > On Fri, 2014-09-19 at 1
Quoting Alex Bligh (a...@alex.org.uk):
>
> On 22 Sep 2014, at 20:10, Paolo Bonzini wrote:
>
> > I'm arguing against special-casing pc-1.0. Just apply the patch to
> > Ubuntu downstream and call it a day.
> >
> > It's perfectly normal for machine types to be part of the downstream
> > (not so s
On 09/19/2014 05:53 AM, Markus Armbruster wrote:
John Snow writes:
This is an extremely rough/quick sketch of
a -cdrom/-hda desugaring fix for Q35/AHCI.
Before I spent any time on it, I wanted feedback
from Markus or anyone else who had concerns about
how this problem would get fixed.
This
On Tue, 2014-09-23 at 00:08 +0200, Alexander Graf wrote:
>
> On 22.09.14 22:47, Alex Williamson wrote:
> > On Fri, 2014-09-19 at 13:54 +0200, frank.blasc...@de.ibm.com wrote:
> >> This set of patches implements a vfio based solution for pci
> >> pass-through on the s390 platform. The kernel stuff
Il 22/09/2014 22:57, Richard Henderson ha scritto:
> +QEMU_BUILD_BUG_ON(TCG_TARGET_NB_REGS > 32);
> +QEMU_BUILD_BUG_ON(NB_MMU_MODES > 8);
> +
> typedef struct TCGLabelQemuLdst {
> -bool is_ld:1; /* qemu_ld: true, qemu_st: false */
> -TCGMemOp opc:4;
> -TCGReg addrlo_reg;
On 22.09.14 22:47, Alex Williamson wrote:
> On Fri, 2014-09-19 at 13:54 +0200, frank.blasc...@de.ibm.com wrote:
>> This set of patches implements a vfio based solution for pci
>> pass-through on the s390 platform. The kernel stuff is pretty
>> much straight forward, but qemu needs more work.
>>
>
The first patch introduces a generic comparator. This comparator should
cover all machine types at once that don't belong to machine type
"families". Hence, for example, the output it produces for
qemu-system-aarch64 -M \?
is meant to be final. (See examples in the patches.)
The second patch f
Il 22/09/2014 22:38, Laszlo Ersek ha scritto:
> The first patch introduces a generic comparator. This comparator should
> cover all machine types at once that don't belong to machine type
> "families". Hence, for example, the output it produces for
>
> qemu-system-aarch64 -M \?
>
> is meant to
Commit 261747f1 ("vl: Use MachineClass instead of global QEMUMachine
list") broke the ordering of the machine types in the user-visible output
of
qemu-system- -M \?
This occurred because registration was rebased from a manually maintained
linked list to GLib hash tables:
qemu_register_ma
Thanks John !! Let me try that
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1329956
Title:
multi-core FreeBSD guest hangs after warm reboot
Status in QEMU:
Incomplete
Bug description:
On som
I have the same issue :
KMV veriosn: 3.10.0-123.el7.x86_64 SMP mod_unload modversions
author: Qumranet
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1329956
Title:
multi-core FreeBSD guest
I am also experiencing this problem QNX 4.25 images that were created
under 1.0 no longer work when I've upgraded to 2.0 or 2.1 qemu.
The error message that I receive is the same. The problem is with the
virtual disk driver, it performs the initial boat loader, then when the
OS goes to load the f
For the benefit of the last commenter and anyone else who comes across
this ticket:
As determined on the mailing list in June, the bug appears to be with
KVM's apicv on processors that support the feature. I haven't heard
anything about a fix, but the best workaround is to disable apicv when
loadi
Instead of using structures, which imply some amount of overhead
on certain ABIs, use pointer types.
This actually reduces the size of the binaries vs a NON-debug
build on ppc64 and x86_64, due to a reduction in the number of
sign-extension insns.
Reviewed-by: Peter Maydell
Signed-off-by: Richar
The "old" qemu_ld opcode did not specify the size of the result,
and so we had to assume full register width. With the new opcodes,
we can narrow the result.
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c | 29 -
tcg/tcg-be-ldst.h| 1 +
2 file
The pre-v9 ADDX/SUBX insns were renamed ADDC/SUBC for v9.
Standardizing on the v9 name makes things less confusing.
Signed-off-by: Richard Henderson
---
disas/sparc.c | 32 +++-
tcg/sparc/tcg-target.c | 14 +++---
2 files changed, 18 insertions(+), 28
Having the count inside the enumeration makes gcc believe that we
want to be able to store values 0-2, and thus a 1-bit bitfield cannot
hold the enumeration. With the count as a define external to the enum,
gcc correctly sees that we only care about values 0-1.
Signed-off-by: Richard Henderson
-
Signed-off-by: Richard Henderson
---
disas/sparc.c | 1 +
tcg/sparc/tcg-target.c | 5 +
tcg/sparc/tcg-target.h | 2 +-
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/disas/sparc.c b/disas/sparc.c
index 22ceac3..8e755d1 100644
--- a/disas/sparc.c
+++ b/disas/sparc.c
@@
We failed to swap c1 and c2 correctly for NE c2 == 0.
Signed-off-by: Richard Henderson
---
tcg/sparc/tcg-target.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c
index 08ca482..3b232d6 100644
--- a/tcg/sparc/tcg-target.c
The combination of always_inline + artificial allows tiny inline
functions to be written that do not interfere with debugging.
In particular, gdb will not step into an artificial function.
The always_inline attribute was introduced in gcc 4.2,
and the artificial attribute was introduced in gcc 4.3
Use 1 32-bit word instead of 6.
Reviewed-by: Claudio Fontana
Signed-off-by: Richard Henderson
---
tcg/tcg-be-ldst.h | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/tcg/tcg-be-ldst.h b/tcg/tcg-be-ldst.h
index 49b3de6..904eeda 100644
--- a/tcg/tcg-be-ldst.
Signed-off-by: Richard Henderson
---
tcg/sparc/tcg-target.c | 72 +-
tcg/sparc/tcg-target.h | 4 +--
2 files changed, 67 insertions(+), 9 deletions(-)
diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c
index 40f2ec1..21981d8 100644
--- a
On T4 and newer Sparc chips we have an add-with-carry insn
that takes its input from %xcc instead of %icc.
Signed-off-by: Richard Henderson
---
disas/sparc.c | 3 +++
include/elf.h | 37 +
tcg/sparc/tcg-target.c | 28 +++-
Similar to the ADDC tricks we use in setcond_i32.
Signed-off-by: Richard Henderson
---
tcg/sparc/tcg-target.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c
index 3b232d6..d0bd08c 100644
--- a/tcg/sparc/tcg-target.c
+++ b/tc
Three pending tcg patch sets: sparc backend updates, aarch64 backend
updates, and the tcg typechecking patch set from last week.
Please pull.
r~
The following changes since commit 07e2863d0271ac6c05206d8ce9e4f4c39b25d3ea:
exec.c: fix setting 1-byte-long watchpoints (2014-09-19 17:42:16 +010
On 09/22/2014 02:36 PM, Corey Minyard wrote:
>> Hmm, thinking aloud here. What happens if 'reconnect' is provided with a
>> 'server':true socket? The documentation only specifies 'server':false
>> behavior. Should it be an error (incompatible options), or just be
>> silently ignored?
>
> I was
On Fri, 2014-09-19 at 13:54 +0200, frank.blasc...@de.ibm.com wrote:
> This set of patches implements a vfio based solution for pci
> pass-through on the s390 platform. The kernel stuff is pretty
> much straight forward, but qemu needs more work.
>
> Most interesting patch is:
> vfio: make vfio r
On 09/22/14 18:44, Paolo Bonzini wrote:
> Il 22/09/2014 00:43, Laszlo Ersek ha scritto:
>> // Bus 0, Device 1, Function 0 - PCI to ISA Bridge
>> //
>> PciWrite8 (PCI_LIB_ADDRESS (0, 1, 0, 0x3c), 0x00);
>> PciWrite8 (PCI_LIB_ADDRESS (0, 1, 0, 0x60), 0x0b); // LNKA routing target
>> PciWrit
With this patch applied, the output of -M \? is
> Supported machines are:
> pc Standard PC (i440FX + PIIX, 1996) (alias of
> pc-i440fx-2.2)
> pc-i440fx-2.2Standard PC (i440FX + PIIX, 1996) (default)
> pc-i440fx-2.1Standard PC (i440FX + PIIX, 1996)
> pc-i440fx-2.0
On 09/22/2014 03:24 PM, Eric Blake wrote:
> On 09/21/2014 05:04 PM, miny...@acm.org wrote:
>> From: Corey Minyard
>>
>> Adds a "reconnect" option to socket backends that gives a reconnect
>> timeout. This only applies to client sockets. If the other end
>> of a socket closes the connection, qemu
On 09/22/2014 10:59 AM, miny...@acm.org wrote:
> From: Corey Minyard
>
> Adds a "reconnect" option to socket backends that gives a reconnect
> timeout. This only applies to client sockets. If the other end
> of a socket closes the connection, qemu will attempt to reconnect
> after the given num
On 09/21/2014 05:04 PM, miny...@acm.org wrote:
> From: Corey Minyard
>
> Adds a "reconnect" option to socket backends that gives a reconnect
> timeout. This only applies to client sockets. If the other end
> of a socket closes the connection, qemu will attempt to reconnect
> after the given num
On 09/22/2014 12:20 PM, Peter Maydell wrote:
> On 22 September 2014 09:59, wrote:
>> From: Corey Minyard
>>
>> Signed-off-by: Corey Minyard
>> Reviewed-by: Paolo Bonzini
> Wouldn't it be better to just drop the max-size restriction
> by using g_strdup_printf (and then free when done) rather th
Add a machine parameter qemu-kvm-migration for live migrate compatibility
with qemu-kvm version 1.0. Usage:
-machine pc-1.0,qemu-kvm-migration=on
This has three effects:
1. cirrus-vga.vgamem_mb defaults to 16 rather than 8
2. A type 2 piix4_pm record is interpreted as being type 3
3. A type 2
This patch series adds inbound migrate capability from qemu-kvm version
1.0. The main ideas are those set out in Cole Robinson's patch here:
http://pkgs.fedoraproject.org/cgit/qemu.git/tree/0001-Fix-migration-from-qemu-kvm.patch?h=f20
however, rather than patching statically (and breaking inbound
m
On 22 Sep 2014, at 20:10, Paolo Bonzini wrote:
> I'm arguing against special-casing pc-1.0. Just apply the patch to
> Ubuntu downstream and call it a day.
>
> It's perfectly normal for machine types to be part of the downstream
> (not so secret) sauce.
Well, I've just sent through a version t
Il 22/09/2014 21:08, Chris Webb ha scritto:
> > Do you by chance have CONFIG_DEBUG_RODATA set? In that case, the fix is
> > simply not to set it.
>
> Absolutely right: my host and guest kernels do have CONFIG_DEBUG_RODATA set!
>
> Your patch to use alternatives for VMCALL vs VMMCALL definitely f
Il 22/09/2014 19:30, Alex Bligh ha scritto:
> Well, Ubuntu (Serge I think) said in the Ubuntu bug report he'd
> be quite willing to break migration of pc-1.0 machine types
> from 14.04 to 14.04 because that machine type isn't the default
> anyway on 14.04.
>
> But that isn't the point, as the patc
Paolo Bonzini wrote:
> Il 11/09/2014 19:03, Chris Webb ha scritto:
>> Paolo Bonzini wrote:
>>
>>> This is a hypercall that should have kicked VCPU 3 (see rcx).
>>>
>>> Can you please apply this patch and gather a trace of the host
>>> (using "trace-cmd -e kvm qemu-kvm ")?
>>
>> Sure, no probl
Il 22/09/2014 14:14, Pavel Dovgalyuk ha scritto:
> This patch fixes migration by extending do_vapic_enable function. This
> function
> called vapic_enable which read cpu number from the guest memory. When cpu
> number could not be read, vapic was not enabled while loading the VM state.
> This patc
Il 22/09/2014 11:43, Peter Lieven ha scritto:
> This series aims not at touching default behaviour. The default for
> max_transfer_length
> is 0 (no limit). max_transfer_length is a limit that MUST be satisfied
> otherwise the request
> will fail. And Patch 2 aims at catching this fail earlier in
in v2:
Added a base parameters [Kevin]
Remove multiple blockers [Kevin]
Addressed Kevin's comments except BLOCK_OP_TYPE_MIRROR_REPLACE relaxing
and "You need to unblock all of the BDSes that are going to be removed.
Aren't you unblocking more than that here?
This operation blocker is really specific to the mirroring code so its name
should reflect this.
Signed-off-by: Benoît Canet
---
block.c | 2 +-
include/block/block.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index bcd952a..9a9f8a0 100
Since the block layer code is starting to modify the BDS graph right in the
middle of BDS chains (block-mirror's replace parameter for example) QEMU needs
to properly block and unblock whole BDS subtrees; recursion is a neat way to
achieve this task.
An optional base arguments was added to the API
From: Max Reitz
Use the new function in case of a failed overlap check.
This changes output in case of corruption, so adapt iotest 060's
reference output accordingly.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Benoît Canet
Message-id: 1409926039-29044-4-git-send-email-mre.
As its comment states, raw_co_get_block_status() should unconditionally
return 0 and set *pnum to 0 for after EOF.
An assertion after lseek(..., SEEK_HOLE) tried to catch this case by
asserting that errno != -ENXIO (which would indicate a position after
the EOF); but it should be errno != ENXIO in
Max Reitz writes:
> On 16.09.2014 20:12, Markus Armbruster wrote:
>> Doesn't make a difference just yet, but it's the right thing to do.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> block/block-backend.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/block/
raw_co_get_block_status() should return 0 and set *pnum to 0 after the
EOF; currently it does this merely by accident, so implement it
directly.
While doing that, centralize the generation of
raw_co_get_block_status()'s return value along the way.
Max Reitz (2):
raw-posix: Fix raw_co_get_block
Stefan Hajnoczi writes:
> Use \w for properties and trace event names since they are both drawn
> from [a-zA-Z0-9_] character sets.
> The .* for matching properties was too aggressive and caused the
> following failure with foo(int rc) "(this is a test)":
> Traceback (most recent call last):
>
On 22 Sep 2014, at 16:44, Paolo Bonzini wrote:
> time, RHEL7 did it. Ubuntu didn't, and probably neither did Debian.
>
> This patch singles out pc-1.0 just because it used to be the default in
> Ubuntu 12.04. So basically it's making upstream carry the burden of a
> decision of the Ubuntu fol
On Thu, 18 Sep 2014 21:54:58 +0300
"Michael S. Tsirkin" wrote:
> Current support for bus master (clearing OK bit)
> together with the need to support guests which do not
> enable PCI bus mastering, leads to extra state in
> VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust
> in case of cross
Alex Bligh writes:
> On 22 Sep 2014, at 16:45, Andreas Färber wrote:
>
>> What about adding a bool property "qemu-kvm-compat" to the MachineClass?
>> Then a qemu-kvm shell script (like SUSE uses) can pass -global
>> machine.qemu-kvm-compat=on whereas qemu-system-x86_64 would run in the
No need
On 22 September 2014 09:59, wrote:
> From: Corey Minyard
>
> Signed-off-by: Corey Minyard
> Reviewed-by: Paolo Bonzini
Wouldn't it be better to just drop the max-size restriction
by using g_strdup_printf (and then free when done) rather than
snprintf into a fixed size buffer?
thanks
-- PMM
On Mon, Sep 22, 2014 at 05:32:16PM +0200, Markus Armbruster wrote:
> "Michael S. Tsirkin" writes:
>
> > On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
> >> Add a configure option --enable-pc-1-0-qemu-kvm and the
> >> corresponding --disable-pc-1-0-qemu-kvm, defaulting
> >> to disable
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
> Make the BlockBackend own the DriveInfo. Change blockdev_init() to
> return the BlockBackend instead of the DriveInfo.
>
> Signed-off-by: Markus Armbruster
> ---
> block.c | 2 --
> block/block-backend.c | 38 +++
From: Corey Minyard
Signed-off-by: Corey Minyard
Reviewed-by: Paolo Bonzini
---
qemu-char.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 2a3cb9f..39fb9e4 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -84,6 +84,7 @@
#def
On 09/22/2014 03:20 AM, Stefan Hajnoczi wrote:
> The blkdebug block driver is undocumented. Documenting it is worthwhile
> since it offers powerful error injection features that are used by
> qemu-iotests test cases.
>
> This document will make it easier for people to learn about and use
> blkdeb
From: Corey Minyard
Adds a "reconnect" option to socket backends that gives a reconnect
timeout. This only applies to client sockets. If the other end
of a socket closes the connection, qemu will attempt to reconnect
after the given number of seconds.
Signed-off-by: Corey Minyard
---
qapi-sc
From: Corey Minyard
It seems that it might be a good idea to know what is at the remote
end of a socket for tracking down issues. So add that to the
socket filename.
Signed-off-by: Corey Minyard
Reviewed-by: Paolo Bonzini
---
qemu-char.c | 27 ++-
1 file changed, 18 i
From: Corey Minyard
This keeps them from having to be passed around and makes them
available for later functions, like printing and reconnecting.
Signed-off-by: Corey Minyard
Reviewed-by: Paolo Bonzini
---
qemu-char.c | 65 -
1 file
From: Corey Minyard
This way we can tell if the socket is connected or not. It also splits
the string conversions out into separate functions to make this more
convenient.
Signed-off-by: Corey Minyard
Reviewed-by: Paolo Bonzini
---
qemu-char.c | 102 --
On Mon, Sep 22, 2014 at 06:44:26PM +0200, Paolo Bonzini wrote:
> Il 22/09/2014 00:43, Laszlo Ersek ha scritto:
> > I mentioned earlier that grepping OvmfPkg for PCI_LIB_ADDRESS would be
> > necessary. See PciInitialization() in
> > "OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c".
I remember that, b
From: Corey Minyard
Move all socket configuration to qmp_chardev_open_socket().
qemu_chr_open_socket_fd() just opens the socket. This is getting ready
for the reconnect code, which will call open_sock_fd() on a reconnect
attempt.
Signed-off-by: Corey Minyard
Reviewed-by: Paolo Bonzini
---
qe
I believe I have fixed all the issues Paulo pointed out and added
a Reviewed-by for all the patches except patch 5. Retested and it
looks good. Thanks.
-corey
On 22 Sep 2014, at 16:45, Andreas Färber wrote:
> What about adding a bool property "qemu-kvm-compat" to the MachineClass?
> Then a qemu-kvm shell script (like SUSE uses) can pass -global
> machine.qemu-kvm-compat=on whereas qemu-system-x86_64 would run in the
> default non-qemu-kvm mode (config
On 09/22/2014 06:37 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> === Union types ===
>>
>> +Usage: { 'union': 'str', 'data': 'dict', '*base': 'complex-type-name',
>> + '*discriminator': 'enum-type-name' }
>> +or:{ 'union': 'str', 'data': 'dict', 'discriminator': {} }
>> +
Il 22/09/2014 00:43, Laszlo Ersek ha scritto:
> // Bus 0, Device 1, Function 0 - PCI to ISA Bridge
> //
> PciWrite8 (PCI_LIB_ADDRESS (0, 1, 0, 0x3c), 0x00);
> PciWrite8 (PCI_LIB_ADDRESS (0, 1, 0, 0x60), 0x0b); // LNKA routing target
> PciWrite8 (PCI_LIB_ADDRESS (0, 1, 0, 0x61), 0x0b); //
Kevin Wolf writes:
> Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
>> The pointer from BlockBackend to BlockDriverState is a strong
>> reference, managed with bdrv_ref() / bdrv_unref(), the back-pointer is
>> a weak one.
>>
>> Convenience function blk_new_with_bs() creates a BlockBac
Am 12.09.2014 um 21:26 hat Markus Armbruster geschrieben:
> More random crap I ran into while iterating on BlockBackends.
>
> Markus Armbruster (4):
> blockdev: Disentangle BlockDriverState and DriveInfo creation
> block: Keep DriveInfo alive until BlockDriverState dies
> qemu-nbd: Destroy t
On Wed, Sep 03, 2014 at 05:52:06PM +0800, john.liuli wrote:
> From: Li Liu
>
> qtest_log_fp should be inited before qemu_chr_add_handlers.
> If not the log dumped from callback functions may be lost.
>
> easy to reproduce it by command:
> "QTEST_LOG=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system
Il 22/09/2014 18:06, Andreas Färber ha scritto:
> Am 22.09.2014 um 17:57 schrieb Paolo Bonzini:
>> Il 22/09/2014 15:15, Laszlo Ersek ha scritto:
>>> $ git grep -E '\' | wc -l
>>> 115
>>>
>>> Even if we just count the clusters, they're way too many:
>>>
>>> $ git grep -E '\' | wc -l
>>> 66
>>
>> The
On Fri, Sep 19, 2014 at 06:07:02PM +0200, Eric Auger wrote:
> Also as I mentionned in the commit message, I identified some parsing
> issues that forced me to change few format strings. I don't know if you
> have time or are willing to fix those - you may be more efficient doing
> those fixes than
Use \w for properties and trace event names since they are both drawn
from [a-zA-Z0-9_] character sets.
The .* for matching properties was too aggressive and caused the
following failure with foo(int rc) "(this is a test)":
Traceback (most recent call last):
File "scripts/tracetool.py", lin
On 09/22/14 17:57, Paolo Bonzini wrote:
> Il 22/09/2014 15:15, Laszlo Ersek ha scritto:
>> $ git grep -E '\' | wc -l
>> 115
>>
>> Even if we just count the clusters, they're way too many:
>>
>> $ git grep -E '\' | wc -l
>> 66
>
> There are just a couple of multi-machine clusters (well, three: pser
Am 22.09.2014 um 17:57 schrieb Paolo Bonzini:
> Il 22/09/2014 15:15, Laszlo Ersek ha scritto:
>> $ git grep -E '\' | wc -l
>> 115
>>
>> Even if we just count the clusters, they're way too many:
>>
>> $ git grep -E '\' | wc -l
>> 66
>
> There are just a couple of multi-machine clusters (well, three
Il 22/09/2014 15:15, Laszlo Ersek ha scritto:
> $ git grep -E '\' | wc -l
> 115
>
> Even if we just count the clusters, they're way too many:
>
> $ git grep -E '\' | wc -l
> 66
There are just a couple of multi-machine clusters (well, three: pseries,
pc, q35). So the default clusters can just de
Quoting Michael S. Tsirkin (m...@redhat.com):
> On Mon, Sep 22, 2014 at 05:24:55PM +0200, Markus Armbruster wrote:
> > "Daniel P. Berrange" writes:
> >
> > > On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote:
> > >> On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
> >
Am 22.09.2014 um 15:05 schrieb Alex Bligh:
>>> Sadly that is not true. For instance on Ubuntu Precise
>>> it's invoked as qemu-system-x86_64 by at least one
>>> management application known to me.
>>
>> Well change it to call qemu-kvm then :)
>> Also what happens if you install qemu as well?
>> Doe
"Daniel P. Berrange" writes:
> On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote:
>> On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
>> > Add a configure option --enable-pc-1-0-qemu-kvm and the
>> > corresponding --disable-pc-1-0-qemu-kvm, defaulting
>> > to disabled.
Stefan Hajnoczi writes:
> Over time a few unused trace events have been left behind in ./trace-events.
> Either the code that called them was deleted or the event was never called in
> the first place.
>
> This is a clear violation of the solider's motto "no man left behind". It's
> time to brin
Il 22/09/2014 17:24, Markus Armbruster ha scritto:
> You're right. However, this particular horse left the barn a long time
> ago: the pc-* machine types differ in qemu-kvm and upstream QEMU.
>
> Sure, when qemu-kvm was merged back into QEMU, its machine type variants
> were dropped. But they li
Instead of generating the full return value thrice in try_fiemap(),
try_seek_hole() and as a fall-back in raw_co_get_block_status() itself,
generate the value only in raw_co_get_block_status().
Suggested-by: Kevin Wolf
Signed-off-by: Max Reitz
---
block/raw-posix.c | 24
1 - 100 of 316 matches
Mail list logo
