On Fri, 09/19 11:29, Paolo Bonzini wrote:
Il 06/08/2014 07:35, Fam Zheng ha scritto:
+void virtio_scsi_dataplane_start(VirtIOSCSICommon *s)
+{
+int i;
+int rc;
+BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(s)));
+VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
+
Michael Tokarev m...@tls.msk.ru writes:
Applied to -trivial, thank you!
Makes my 'hmp: Remove info pcmcia' conflict. Either revert this one
before applying mine, or resolve the conflict and drop the paragraph
about the bug from my commit message.
Paolo Bonzini pbonz...@redhat.com writes:
Il 20/09/2014 02:11, Amos Kong ha scritto:
Conscan complains about g_malloc0() and malloc() return null.
s/Conscan/Coverity/, both here and in subject.
Error: NULL_RETURNS (CWE-476):
qemu-kvm/qom/object.c:239: returned_null: Function
Max Reitz mre...@redhat.com writes:
On 16.09.2014 20:12, Markus Armbruster wrote:
A block device consists of a frontend device model and a backend.
A block backend has a tree of block drivers doing the actual work.
The tree is managed by the block layer.
We currently use a single
On Fri, 09/19 13:52, Max Reitz wrote:
On 15.09.2014 04:32, Fam Zheng wrote:
This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster
allocation).
$ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k'
write failed: Invalid argument
Reported-by: Mark Cave-Ayland
Additional :
Running the same debian virtual machine under Linux host where AltGr+ in
order to get | on german keyboard seems to work properly, I get the following
result running sendkey in console :
Keycode 28 released;
Keycode 100 pressed;
Keycode 86 pressed;
Keycode 86 released;
Keycode 100
On Fri, 2014-09-19 at 11:34 -0400, Luiz Capitulino wrote:
On Fri, 19 Sep 2014 15:30:19 +0200
Igor Mammedov imamm...@redhat.com wrote:
On Thu, 18 Sep 2014 16:09:32 +0800
zhugh zhugh.f...@cn.fujitsu.com wrote:
Hi,
Could anyone help to review this patch?
If there was no
This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster
allocation).
$ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k'
write failed: Invalid argument
Reported-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk
Signed-off-by: Fam Zheng f...@redhat.com
---
v3: A new
On Mon, 09/22 15:13, Fam Zheng wrote:
+# Copyright (C) 1014 Red Hat, Inc.
Oops! Resending...
Fam
This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster
allocation).
$ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k'
write failed: Invalid argument
Reported-by: Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk
Signed-off-by: Fam Zheng f...@redhat.com
---
v4: Fix typo
Max Reitz mre...@redhat.com writes:
On 16.09.2014 20:12, Markus Armbruster wrote:
Make the BlockBackend own the DriveInfo. Change blockdev_init() to
return the BlockBackend instead of the DriveInfo.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
block.c | 2 --
22.09.2014 10:23, Markus Armbruster wrote:
Michael Tokarev m...@tls.msk.ru writes:
Applied to -trivial, thank you!
Makes my 'hmp: Remove info pcmcia' conflict. Either revert this one
before applying mine, or resolve the conflict and drop the paragraph
about the bug from my commit
Max Reitz mre...@redhat.com writes:
On 16.09.2014 20:12, Markus Armbruster wrote:
Commit 12c5674 turned it into a pointer to member blk.conf.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hw/block/virtio-blk.c | 28 ++--
On Fri, Sep 19, 2014 at 05:12:15PM +0200, Thomas Huth wrote:
Hi Frank,
On Fri, 19 Sep 2014 13:54:34 +0200
frank.blasc...@de.ibm.com wrote:
From: Frank Blaschka frank.blasc...@de.ibm.com
This patch implements the s390 pci instructions in qemu. This allows
to attach qemu pci
Max Reitz mre...@redhat.com writes:
On 16.09.2014 20:12, Markus Armbruster wrote:
Just four uses of BlockDriverState are left:
* The Xen paravirtual block device backend (xen_disk.c) opens images
itself when set up via xenbus, bypassing blockdev.c. I figure it
should go through
Il 22/09/2014 01:04, miny...@acm.org ha scritto:
From: Corey Minyard cminy...@mvista.com
Signed-off-by: Corey Minyard cminy...@mvista.com
---
qemu-char.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 2a3cb9f..39fb9e4
Il 22/09/2014 01:04, miny...@acm.org ha scritto:
From: Corey Minyard cminy...@mvista.com
This keeps them from having to be passed around and makes them
available for later functions, like printing and reconnecting.
Signed-off-by: Corey Minyard cminy...@mvista.com
---
qemu-char.c | 65
Marcel Apfelbaum marce...@redhat.com writes:
On Fri, 2014-09-19 at 11:39 +0200, Markus Armbruster wrote:
John Snow js...@redhat.com writes:
Signed-off-by: John Snow js...@redhat.com
[...]
@@ -1583,6 +1584,7 @@ static void machine_class_init(ObjectClass *oc, void
*data)
Am 20.09.2014 um 15:53 hat Michael Tokarev geschrieben:
18.09.2014 19:17, Adelina Tuvenie wrote:
When trying to create a fixed vhd image qemu-img will return the
following error:
qemu-img: test.vhdx: Could not create image: Cannot allocate memory
This happens because of a
zhugh zhugh.f...@cn.fujitsu.com writes:
On Fri, 2014-09-19 at 11:34 -0400, Luiz Capitulino wrote:
On Fri, 19 Sep 2014 15:30:19 +0200
Igor Mammedov imamm...@redhat.com wrote:
On Thu, 18 Sep 2014 16:09:32 +0800
zhugh zhugh.f...@cn.fujitsu.com wrote:
Hi,
Could anyone help to
xev log using ubuntu host and debian virtual machine for pressing altgr
+ key to obtain | using german layout :
KeyPress event, serial 43, synthetic NO, window 0x161,
root 0x43, subw 0x0, time 4278157, (165,-105), root:(446,164),
state 0x0, keycode 108 (keysym 0xfe03,
Il 22/09/2014 01:04, miny...@acm.org ha scritto:
From: Corey Minyard cminy...@mvista.com
Adds a reconnect option to socket backends that gives a reconnect
timeout. This only applies to client sockets. If the other end
of a socket closes the connection, qemu will attempt to reconnect
after
Il 22/09/2014 01:04, miny...@acm.org ha scritto:
From: Corey Minyard cminy...@mvista.com
It seems that it might be a good idea to know what is at the remote
end of a socket for tracking down issues. So add that to the
socket filename.
Signed-off-by: Corey Minyard cminy...@mvista.com
---
On Mon, 22 Sep 2014 09:59:06 +0200
Markus Armbruster arm...@redhat.com wrote:
zhugh zhugh.f...@cn.fujitsu.com writes:
On Fri, 2014-09-19 at 11:34 -0400, Luiz Capitulino wrote:
On Fri, 19 Sep 2014 15:30:19 +0200
Igor Mammedov imamm...@redhat.com wrote:
On Thu, 18 Sep 2014 16:09:32
Il 22/09/2014 01:04, miny...@acm.org ha scritto:
From: Corey Minyard cminy...@mvista.com
This way we can tell if the socket is connected or not. It also splits
the string conversions out into separate functions to make this more
convenient.
Signed-off-by: Corey Minyard
Il 22/09/2014 01:04, miny...@acm.org ha scritto:
From: Corey Minyard cminy...@mvista.com
Move all socket configuration to qmp_chardev_open_socket().
qemu_chr_open_socket_fd() just opens the socket. This is getting ready
for the reconnect code, which will call open_sock_fd() on a reconnect
Il 22/09/2014 07:56, Fam Zheng ha scritto:
Please add these to VirtIOSCSI rather than VirtIOSCSICommon. Same for
the new functions you declare below.
What's the rationale, please? Asking because especially the VirtIOSCSIVring
fields are the dataplane counterparts of VirtQueue fields, so
From: Adelina Tuvenie adelinatuve...@gmail.com
When trying to create a fixed vhd image qemu-img will return the
following error:
qemu-img: test.vhdx: Could not create image: Cannot allocate memory
This happens because of a incorrect check in vhdx.c. Specifficaly,
in vhdx_create_bat(), after
From: Li Liu john.li...@huawei.com
When more than one is used, the terminal settings aren't restored
correctly on exit. Fixable. However, such usage makes no sense,
because the users race for input, so outlaw it instead.
If you want to connect multiple things to stdio, use the mux
chardev.
From: Bastian Koppelmann kbast...@mail.uni-paderborn.de
Every QEMU_ARCH is now in (1 n) notation, instead of a mixture of decimal
and hexadecimal.
Signed-off-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
include/sysemu/arch_init.h |
Here's a next (small) batch of trivial stuff. Accumulated for over
2 weeks, but still quite small. Random tiny things here and there.
Please consider pulling/applying.
Thanks,
/mjt
The following changes since commit 07e2863d0271ac6c05206d8ce9e4f4c39b25d3ea:
exec.c: fix setting 1-byte-long
From: Gonglei arei.gong...@huawei.com
Make them consistent with the others.
Cc: qemu-triv...@nongnu.org
Signed-off-by: Gonglei arei.gong...@huawei.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
configure |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
From: zhanghailiang zhang.zhanghaili...@huawei.com
Since we have supported memory hotplug, VM's ram include pc.ram
and hotplug-memory.
Fix the confused description for rdma migration: pc.ram - VM's ram
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Michael Tokarev
From: Stefan Weil s...@weilnetz.de
This fixes a warning from smatch (static code analysis).
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/i386/pc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/pc.c
From: zhanghailiang zhang.zhanghaili...@huawei.com
formated - formatted
gaurantee - guarantee
shear - sheer
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/ppc/spapr.c |2 +-
libcacard/vcard_emul_nss.c |4 ++--
From: zhanghailiang zhang.zhanghaili...@huawei.com
In error message, maxmem is printed in Dec but ram_size in Hex.
It is better to print them in same format.
Also use error_report instead of fprintf.
Reviewed-By: Igor Mammedov imamm...@redhat.com
Signed-off-by: zhanghailiang
From: Chen Gang gang.chen.5...@gmail.com
When failure occurs, it need to use return -1 instead of exit(1), so
an upper layer has a chance to print failure information, too.
For simplicity, in xen_hvm_init(), also use '-1' instead of all
'-errno', since all related upper callers always exit(1) on
-Original Message-
From: Paolo Bonzini [mailto:pbonz...@redhat.com]
Sent: Friday, September 19, 2014 5:42 PM
To: Pavel Dovgaluk; qemu-devel@nongnu.org
Subject: Re: [PULL 13/21] apic_common: vapic_paddr synchronization fix
Il 19/09/2014 14:50, Pavel Dovgaluk ha scritto:
Hi, Paolo
-Original Message-
From: Gonglei (Arei)
Sent: Wednesday, September 17, 2014 10:32 AM
To: 'Paolo Bonzini'; Markus Armbruster
Cc: Huangweidong (C); aligu...@amazon.com; Michael S. Tsirkin;
ag...@suse.de; qemu-devel@nongnu.org; stefa...@redhat.com; Huangpeng
(Peter);
On Mon, Sep 15, 2014 at 10:44:36PM +0800, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
At present, people have no way to know they should
have a specific format for alias properties.
Example:
before output:
virtio-blk-pci.physical_block_size=uint16
On Mon, 09/22 10:09, Paolo Bonzini wrote:
Il 22/09/2014 07:56, Fam Zheng ha scritto:
Please add these to VirtIOSCSI rather than VirtIOSCSICommon. Same for
the new functions you declare below.
What's the rationale, please? Asking because especially the VirtIOSCSIVring
fields are the
On Mon, 22 Sep 2014 11:36:35 +0800
zhanghailiang zhang.zhanghaili...@huawei.com wrote:
Hi Igor,
Thanks for your reviewing...
On Mon, 15 Sep 2014 20:29:38 +0800
zhanghailiang zhang.zhanghaili...@huawei.com wrote:
When do memory balloon, it references the ram_size as the real ram size
From: Michael S. Tsirkin [mailto:m...@redhat.com]
Sent: Monday, September 22, 2014 4:34 PM
Subject: Re: [PATCH 0/3] Fix confused output for alias properties
On Mon, Sep 15, 2014 at 10:44:36PM +0800, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
At present, people
Hi Igor,
On 09/19/2014 08:26 PM, Igor Mammedov wrote:
On Wed, 17 Sep 2014 16:32:20 +0800
Hu Tao hu...@cn.fujitsu.com wrote:
On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote:
If we do not configure numa option, memory hotplug should work as well.
It should not depend on numa
ping
http://patchwork.ozlabs.org/patch/386918/
On 08.09.2014 17:28, m.i...@samsung.com wrote:
From: Mikhail Ilyin m.i...@samsung.com
The initial base address is miscalculated in walk_memory_regions().
It has to be shifted TARGET_PAGE_BITS more. Holder variables are
extended to target_ulong
Add documentation for page-ref, page-gref and event-channel.
Signed-off-by: Owen smith owen.sm...@citrix.com
---
xen/include/public/io/fbif.h | 25 +
1 file changed, 25 insertions(+)
diff --git a/xen/include/public/io/fbif.h b/xen/include/public/io/fbif.h
index
Add documentation for feature-abs-pointer, feature-no-abs-rescale,
feature-no-console, page-ref, page-gref and event-channel
Signed-off-by: Owen smith owen.sm...@citrix.com
---
xen/include/public/io/kbdif.h | 74 +++
1 file changed, 74 insertions(+)
diff
Add comments documenting the xenstore nodes used by the vfb and vkbd devices.
Documents changes in qemu patch series posted here
http://lists.gnu.org/archive/html/qemu-devel/2014-09/msg03472.html
Owen smith (2):
xenfb: Add comment documentation
xenfb: Add comment documentation
Il 22/09/2014 10:34, Michael S. Tsirkin ha scritto:
Basically this patch brings back historical HMP behaviour.
As far as I could tell, it wasn't changed intentionally.
It was changed intentionally. Or rather, the change was known at the
time Stefan made it.
So how about applying this first
Il 22/09/2014 10:21, Pavel Dovgaluk ha scritto:
-Original Message-
From: Paolo Bonzini [mailto:pbonz...@redhat.com]
Sent: Friday, September 19, 2014 5:42 PM
To: Pavel Dovgaluk; qemu-devel@nongnu.org
Subject: Re: [PULL 13/21] apic_common: vapic_paddr synchronization fix
Il
The blkdebug block driver is undocumented. Documenting it is worthwhile
since it offers powerful error injection features that are used by
qemu-iotests test cases.
This document will make it easier for people to learn about and use
blkdebug.
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
Igor Mammedov imamm...@redhat.com writes:
On Mon, 22 Sep 2014 09:59:06 +0200
Markus Armbruster arm...@redhat.com wrote:
zhugh zhugh.f...@cn.fujitsu.com writes:
On Fri, 2014-09-19 at 11:34 -0400, Luiz Capitulino wrote:
On Fri, 19 Sep 2014 15:30:19 +0200
Igor Mammedov
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Sep 15, 2014 at 10:44:36PM +0800, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
At present, people have no way to know they should
have a specific format for alias properties.
Example:
before output:
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
Bonzini
Sent: Monday, September 22, 2014 5:15 PM
To: Michael S. Tsirkin; Gonglei (Arei)
Cc: ag...@suse.de; Huangweidong (C); aligu...@amazon.com; Huangpeng
(Peter); qemu-devel@nongnu.org; stefa...@redhat.com;
On 19.09.2014 15:33, Paolo Bonzini wrote:
Il 19/09/2014 00:56, Peter Lieven ha scritto:
So I think if we treat it just as a hint for multiwrite, we can avoid
writing code to split oversized requests. They always worked so far, we
can certainly wait until we have a real bug fix.
I would not
On 2014/9/22 17:03, Tang Chen wrote:
Hi Igor,
On 09/19/2014 08:26 PM, Igor Mammedov wrote:
On Wed, 17 Sep 2014 16:32:20 +0800
Hu Tao hu...@cn.fujitsu.com wrote:
On Tue, Sep 16, 2014 at 06:39:15PM +0800, zhanghailiang wrote:
If we do not configure numa option, memory hotplug should work as
On Mon, Sep 22, 2014 at 03:15:44PM +0800, Fam Zheng wrote:
This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster
allocation).
$ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k'
write failed: Invalid argument
Reported-by: Mark Cave-Ayland
Il 22/09/2014 11:33, Gonglei (Arei) ha scritto:
Yes, I knew this issue which object A's property name may
is not the same with object B, so I had posted v2 to fix it.
This doesn't change the fact that ObjectProperty is a generic struct,
and adding alias-specific fields there is wrong.
Paolo
Il 22/09/2014 11:20, Stefan Hajnoczi ha scritto:
The blkdebug block driver is undocumented. Documenting it is worthwhile
since it offers powerful error injection features that are used by
qemu-iotests test cases.
This document will make it easier for people to learn about and use
blkdebug.
On Sat, Sep 20, 2014 at 09:32:35AM +, Gonglei (Arei) wrote:
@@ -315,10 +320,21 @@ static int read_config(BDRVBlkdebugState *s, const
char *filename,
d.s = s;
d.action = ACTION_INJECT_ERROR;
-qemu_opts_foreach(inject_error_opts, add_rule, d, 0);
+d.errp =
From: Stefan Hajnoczi [mailto:stefa...@redhat.com]
Sent: Monday, September 22, 2014 6:28 PM
Subject: Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event
names
On Sat, Sep 20, 2014 at 09:32:35AM +, Gonglei (Arei) wrote:
@@ -315,10 +320,21 @@ static int
Il 11/09/2014 19:03, Chris Webb ha scritto:
Paolo Bonzini pbonz...@redhat.com wrote:
This is a hypercall that should have kicked VCPU 3 (see rcx).
Can you please apply this patch and gather a trace of the host
(using trace-cmd -e kvm qemu-kvm arguments)?
Sure, no problem. I've built the
On Fri, Sep 19, 2014 at 02:37:46PM +0200, Igor Mammedov wrote:
On Tue, 16 Sep 2014 18:39:15 +0800
zhanghailiang zhang.zhanghaili...@huawei.com wrote:
If we do not configure numa option, memory hotplug should work as well.
It should not depend on numa option.
Steps to reproduce:
(1)
On Fri, Sep 19, 2014 at 04:42:59PM +0800, zhanghailiang wrote:
On 2014/9/19 15:34, zhanghailiang wrote:
On 2014/9/19 7:17, Andrew Jones wrote:
Replace all the fprintf(stderr, ...) calls with error_report.
Also make sure exit() consistently uses the error code 1. A few calls
used -1.
On Mon, Sep 15, 2014 at 06:40:05PM +0200, Andreas Färber wrote:
From: Stefan Hajnoczi stefa...@redhat.com
The third argument to the fd_read() callback implemented by
ivshmem_read() is the number of bytes, not a flags field. Fix this and
check we received enough bytes before accessing the
On Mon, Sep 15, 2014 at 06:40:06PM +0200, Andreas Färber wrote:
From: Stefan Hajnoczi stefa...@redhat.com
Check incoming_posn to avoid out-of-bounds array accesses if the ivshmem
server on the host sends invalid values.
Cc: Cam Macdonell c...@cs.ualberta.ca
Reported-by: Sebastian Krahmer
On Mon, Sep 15, 2014 at 06:40:07PM +0200, Andreas Färber wrote:
From: Sebastian Krahmer krah...@suse.de
Fix OOB access via malformed incoming_posn parameters
and check that requested memory is actually alloc'ed.
Signed-off-by: Sebastian Krahmer krah...@suse.de
[AF: Rebased, cleanups,
On Mon, Sep 15, 2014 at 06:40:08PM +0200, Andreas Färber wrote:
Reported-by: Stefan Hajnoczi stefa...@redhat.com
Cc: qemu-sta...@nongnu.org
Signed-off-by: Andreas Färber afaer...@suse.de
Reviewed-by: Michael S. Tsirkin m...@redhat.com
---
hw/misc/ivshmem.c | 1 +
1 file changed, 1
Am 20.09.2014 um 10:55 hat Stefan Hajnoczi geschrieben:
It is easy to typo a blkdebug configuration and waste a lot of time
figuring out why no rules are matching.
Push the Error** down into add_rule() so we can report an error when the
event name is invalid.
Signed-off-by: Stefan
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
Bonzini
Sent: Monday, September 22, 2014 6:04 PM
To: Gonglei (Arei); Michael S. Tsirkin
Cc: Huangweidong (C); aligu...@amazon.com; qemu-devel@nongnu.org;
ag...@suse.de; stefa...@redhat.com; Huangpeng (Peter);
Commit 261747f1 (vl: Use MachineClass instead of global QEMUMachine
list) broke the ordering of the machine types in the user-visible output
of
qemu-system- -M \?
This occurred because registration was rebased from a manually maintained
linked list to GLib hash tables:
Based on the registration order captured in the previous patch, we sort
the ad-hoc list printed for
qemu-system- -M \?
The GLib documentation is not overly clear if g_slist_sort() allocates a
new list or reorders the input list in place, but:
- it slightly suggests the latter,
- and there
The patch messages say it all.
Thanks,
Laszlo
Laszlo Ersek (2):
save registration order of machine types
machine_parse(): list supported machine types in their registration
order
include/hw/boards.h | 2 ++
include/sysemu/sysemu.h | 2 ++
hw/i386/pc.c| 2 ++
vl.c
On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
Add a configure option --enable-pc-1-0-qemu-kvm and the
corresponding --disable-pc-1-0-qemu-kvm, defaulting
to disabled.
Rename machine type pc-1.0 to pc-1.0-qemu-git.
Make pc-1.0 machine type an alias of either pc-1.0-qemu-kvm
On Fri, Sep 19, 2014 at 2:54 PM, Alistair Francis alistai...@gmail.com wrote:
This patch adds the stm32f205 timers: TIM2, TIM3, TIM4 and TIM5
to QEMU.
Signed-off-by: Alistair Francis alistai...@gmail.com
---
PUBLIC
V2:
- Reorder the Makefile config
- Fix up the debug printing
-
From: John Snow js...@redhat.com
When the command completion code in IDE and AHCI
was unified to put all command completion inside
of a callback, cmd_done, we neglected to
ensure that all AHCI/ATAPI command paths would
eventually register as finished. for the PCI
interface to IDE this is not a
From: Fam Zheng f...@redhat.com
Also drop the now unused -done pointer.
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block.c | 21 -
1 file changed, 21 deletions(-)
diff --git a/block.c b/block.c
index a9a48df..1ce7b99
From: Peter Maydell peter.mayd...@linaro.org
The parent_vhdx_guid variable is defined but never used, which provokes
complaints from newer versions of clang. Since the variable definition
is here acting as documentation of the image format, mark it with the
'unused' attribute to keep the compiler
v2:
* Replaced g_assert_false(...) with g_assert(!...) [Peter]
The following changes since commit 07e2863d0271ac6c05206d8ce9e4f4c39b25d3ea:
exec.c: fix setting 1-byte-long watchpoints (2014-09-19 17:42:16 +0100)
are available in the git repository at:
git://github.com/stefanha/qemu.git
From: Fam Zheng f...@redhat.com
Before, bdrv_aio_cancel will either complete the request (like normal)
and call CB with an actual return code, or skip calling the request (for
example when the IO req is not submitted by thread pool yet).
We will change bdrv_aio_cancel to do it differently:
From: Paolo Bonzini pbonz...@redhat.com
Always initialize it with the return value of aio_prepare.
Reported-by: TeLeMan gele...@gmail.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Reviewed-by: Fam Zheng f...@redhat.com
Signed-off-by: Stefan
From: Fam Zheng f...@redhat.com
This will be useful in synchronous cancel emulation with
bdrv_aio_cancel_async.
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block.c | 12 +++-
include/block/aio.h | 2 ++
2 files changed, 13
From: Fam Zheng f...@redhat.com
Also drop the now unused SheepdogAIOCB.finished field. Note that this
aio is internal to sheepdog driver and has NULL cb and opaque, and
should be unused at all.
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
From: Fam Zheng f...@redhat.com
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/block.c b/block.c
index 1ce7b99..45d3a5b 100644
--- a/block.c
+++ b/block.c
@@ -4681,18 +4681,8
From: Fam Zheng f...@redhat.com
This is the async version of bdrv_aio_cancel, which doesn't block the
caller. It guarantees that the cb is called either before returning or
some time later.
bdrv_aio_cancel can base on bdrv_aio_cancel_async, later we can convert
all .io_cancel implementations to
From: Fam Zheng f...@redhat.com
The cancelled flag is no longer useful. Later the request will complete
as before, and cb will be called.
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/archipelago.c | 17 +
1 file changed, 1
From: Fam Zheng f...@redhat.com
And also drop the now unused cancelled field.
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/rbd.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/block/rbd.c
On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote:
On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
Add a configure option --enable-pc-1-0-qemu-kvm and the
corresponding --disable-pc-1-0-qemu-kvm, defaulting
to disabled.
Rename machine type pc-1.0 to
From: Fam Zheng f...@redhat.com
Just forward the request to bdrv_aio_cancel_async.
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
dma-helpers.c | 20
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git
From: Fam Zheng f...@redhat.com
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/win32-aio.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/block/win32-aio.c b/block/win32-aio.c
index 5030e32..eed86f7 100644
---
From: Fam Zheng f...@redhat.com
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/blkdebug.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index 69b330e..08131b3 100644
From: Fam Zheng f...@redhat.com
The .cancel_async shares the same the first half with .cancel: try to
steal the request if not submitted yet. In this case set the elem to
THREAD_DONE status and ret to -ECANCELED, which means
thread_pool_completion_bh will call the cb with -ECANCELED.
If the
From: Fam Zheng f...@redhat.com
Also drop the unused field canceled.
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/iscsi.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
From: Paolo Bonzini pbonz...@redhat.com
If ret is WAIT_TIMEOUT and there was an event returned by select(),
we can write to a location after the end of the array. But in
that case we can retry the WaitForMultipleObjects call with the
same set of events, so just move the event[ret -
From: Fam Zheng f...@redhat.com
We know that either bh is scheduled or ide_issue_trim_cb will be called
again, so we just set i, j and ret to the right values. In both cases,
ide_trim_bh_cb will be called.
Also forward the cancellation to the iocb-aiocb which we get from
bdrv_aio_discard.
From: Fam Zheng f...@redhat.com
Just call io_cancel (2), if it fails, it means the request is not
canceled, so the event loop will eventually call
qemu_laio_process_completion.
In qemu_laio_process_completion, change to call the cb unconditionally.
It is required by bdrv_aio_cancel_async.
From: Fam Zheng f...@redhat.com
Before, we cancel all the child requests with bdrv_aio_cancel, then free
the acb..
Now we just kick off asynchronous cancellation of child requests and
return, we know quorum_aio_cb will be called later, so in the end
quorum_aio_finalize will take care of calling
From: Fam Zheng f...@redhat.com
This is an analogue to Linux null_blk. It can be used for testing or
benchmarking block device emulation and general block layer
functionalities such as coroutines and throttling, where disk IO is not
necessary or wanted.
Use null-aio:// for AIO version, and
From: Fam Zheng f...@redhat.com
Now that all the implementations are converted to asynchronous version
and we can emulate synchronous cancellation with it. Let's drop the
unused member.
Signed-off-by: Fam Zheng f...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block.c
From: Liu Yuan namei.u...@gmail.com
For a fifo read pattern, we only have one running aio (possible other cases that
has less number than num_children in the future), so we need to check if
.acb is NULL against bdrv_aio_cancel() to avoid segfault.
Cc: Eric Blake ebl...@redhat.com
Cc: Benoit
1 - 100 of 304 matches
Mail list logo
