Re: [Qemu-devel] [PATCH] virtio-scsi: fix use-after-free of VirtIOSCSIReq

2014-10-09 Thread Fam Zheng
On Wed, 10/08 11:37, Paolo Bonzini wrote: scsi_req_continue can complete the request and cause the VirtIOSCSIReq to be freed. Fetch req-sreq just once to avoid the bug. Reported-by: Richard Jones rjo...@redhat.com Tested-by: Richard Jones rjo...@redhat.com Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH v8 1/2] dump: Propagate errors into qmp_dump_guest_memory()

2014-10-09 Thread zhanghailiang
The code calls dump_error() on error, and even passes it a suitable message. However, the message is thrown away, and its callers pass up only success/failure. All qmp_dump_guest_memory() can do is set a generic error. Propagate the errors properly, so qmp_dump_guest_memory() can return a more

[Qemu-devel] [PATCH v8 0/2] Return error reasons to caller when calling qmp_dump_guest_memory

2014-10-09 Thread zhanghailiang
In original code, Function dump_error ignores its second parameter which contains error reason, it is better to return the error message to the caller. Here we use error_setg to return the error info to caller. And at the same time, we turn functions like write_elf64_note() to void, Because

[Qemu-devel] [PATCH v8 2/2] dump: Turn some functions to void to make code cleaner

2014-10-09 Thread zhanghailiang
Functions shouldn't return an error code and an Error object at the same time. Turn all these functions that returning Error object to void. We also judge if a function success or fail by reference to the local_err. Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH v2 37/36] qdev: device_del: search for to be unplugged device in 'peripheral' container

2014-10-09 Thread Markus Armbruster
Zhu Guihua zhugh.f...@cn.fujitsu.com writes: On Wed, 2014-10-08 at 10:01 +0200, Paolo Bonzini wrote: Il 08/10/2014 05:49, Zhu Guihua ha scritto: when device_add pc-dimm, only 'memdev' property is necessary, but the 'id' property is optional. So I execute the command as followings:

[Qemu-devel] [PATCH] linux-user: Let user specify random seed

2014-10-09 Thread Magnus Reftel
This patch introduces the -seed command line option and the QEMU_RAND_SEED environment variable for setting the random seed, which is used for the AT_RANDOM ELF aux entry. Signed-off-by: Magnus Reftel ref...@spotify.com --- linux-user/elfload.c | 1 - linux-user/main.c| 20

[Qemu-devel] [PATCH v2] linux-user: Let user specify random seed

2014-10-09 Thread Magnus Reftel
This patch introduces the -seed command line option and the QEMU_RAND_SEED environment variable for setting the random seed, which is used for the AT_RANDOM ELF aux entry. This is an updated version of the patch, addressing review comments from Eric Blake.

Re: [Qemu-devel] [PATCH][SPARC] LEON3: Add emulation of AMBA plugplay

2014-10-09 Thread Fabien Chouteau
On 10/08/2014 05:38 PM, Andreas Färber wrote: Hi, Hi Andreas, Am 08.10.2014 um 16:19 schrieb Fabien Chouteau: From: Jiri Gaisler j...@gaisler.se + +#define TYPE_GRLIB_APB_PNP grlib,apbpnp If you move the two TYPE_* constants to grlib.h, you can reuse them. Will do. +#define

Re: [Qemu-devel] [PATCH v1 7/8] throttle: Add throttle group support

2014-10-09 Thread Fam Zheng
On Wed, 10/08 11:05, Benoît Canet wrote: On Wed, Oct 08, 2014 at 02:53:38PM +0800, Fam Zheng wrote: Does this mean that after this series, all the throttle_states must be contained inside its own throttle group? If so, we could embed ThrottleGroup fields in ThrottleState. It's weird

Re: [Qemu-devel] [PATCH][SPARC] LEON3: Add emulation of AMBA plugplay

2014-10-09 Thread Fabien Chouteau
On 10/08/2014 09:43 PM, Jiri Gaisler wrote: On 10/08/2014 05:38 PM, Andreas Färber wrote: Hi, Am 08.10.2014 um 16:19 schrieb Fabien Chouteau: From: Jiri Gaisler j...@gaisler.se AMBA plugplay is used by kernels to probe available devices (Timers, UART, etc...). This is a static declaration

Re: [Qemu-devel] [PATCH v11 00/34] modify boot order of guest, and take effect after rebooting

2014-10-09 Thread Gerd Hoffmann
On Mi, 2014-10-08 at 19:00 +0800, Gonglei wrote: On 2014/10/7 16:00, Gonglei (Arei) wrote: From: Gonglei arei.gong...@huawei.com Changes since v10: 1. add handler for virtio-blk-pci/s390/ccw in PATCH 28. 2. add especial bootidnex setter/getter functions for usb-storage device

Re: [Qemu-devel] [PATCH] block/migration: Disable cache invalidate for incoming migration

2014-10-09 Thread Paolo Bonzini
Il 09/10/2014 04:50, Alexey Kardashevskiy ha scritto: When migrated using libvirt with --copy-storage-all, at the end of migration there is race between NBD mirroring task trying to do flush and migration completion, both end up invalidating cache. Since qcow2 driver does not handle this

Re: [Qemu-devel] [PATCH 3/3] qemu-sockets: Add error to non-blocking connect handler

2014-10-09 Thread Paolo Bonzini
Il 08/10/2014 14:11, miny...@acm.org ha scritto: From: Corey Minyard cminy...@mvista.com An error value here would be quite handy and more consistent with the rest of the code. Corey Minyard cminy...@mvista.com --- include/qemu/sockets.h | 2 +- migration-tcp.c| 4 ++--

[Qemu-devel] [PULL 00/28] Changes for 2014-10-09

2014-10-09 Thread Paolo Bonzini
The following changes since commit 1831e150606a221898bf46ffaf0453e9952cbbc4: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-09-30 16:45:35 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to

[Qemu-devel] [PULL 04/28] qemu-char: set socket filename to disconnected when not connected

2014-10-09 Thread Paolo Bonzini
From: Corey Minyard cminy...@mvista.com This way we can tell if the socket is connected or not. It also splits the string conversions out into separate functions to make this more convenient. Signed-off-by: Corey Minyard cminy...@mvista.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [PULL 01/28] qemu-char: Make the filename size for a chardev a #define

2014-10-09 Thread Paolo Bonzini
From: Corey Minyard cminy...@mvista.com Signed-off-by: Corey Minyard cminy...@mvista.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-char.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PULL 03/28] qemu-char: Move some items into TCPCharDriver

2014-10-09 Thread Paolo Bonzini
From: Corey Minyard cminy...@mvista.com This keeps them from having to be passed around and makes them available for later functions, like printing and reconnecting. Signed-off-by: Corey Minyard cminy...@mvista.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 02/28] qemu-char: Rework qemu_chr_open_socket() for reconnect

2014-10-09 Thread Paolo Bonzini
From: Corey Minyard cminy...@mvista.com Move all socket configuration to qmp_chardev_open_socket(). qemu_chr_open_socket_fd() just opens the socket. This is getting ready for the reconnect code, which will call open_sock_fd() on a reconnect attempt. Signed-off-by: Corey Minyard

Re: [Qemu-devel] [PATCH v3] pc-dimm/numa: Fix stat of memory size in node when hotplug memory

2014-10-09 Thread zhanghailiang
On 2014/10/8 20:16, Igor Mammedov wrote: On Wed, 8 Oct 2014 16:36:25 +0800 zhanghailiang zhang.zhanghaili...@huawei.com wrote: On 2014/10/8 15:28, zhanghailiang wrote: Hi Igor, On 2014/9/26 19:53, Igor Mammedov wrote: On Tue, 23 Sep 2014 16:11:25 +0800 zhanghailiang

[Qemu-devel] [PULL 06/28] qemu-char: Print the remote and local addresses for a socket

2014-10-09 Thread Paolo Bonzini
From: Corey Minyard cminy...@mvista.com It seems that it might be a good idea to know what is at the remote end of a socket for tracking down issues. So add that to the socket filename. Signed-off-by: Corey Minyard cminy...@mvista.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [PULL 05/28] qemu-char: Add reconnecting to client sockets

2014-10-09 Thread Paolo Bonzini
From: Corey Minyard cminy...@mvista.com Adds a reconnect option to socket backends that gives a reconnect timeout. This only applies to client sockets. If the other end of a socket closes the connection, qemu will attempt to reconnect after the given number of seconds. Signed-off-by: Corey

Re: [Qemu-devel] [PATCH v11 00/34] modify boot order of guest, and take effect after rebooting

2014-10-09 Thread Gonglei
On 2014/10/9 17:47, Gerd Hoffmann wrote: On Mi, 2014-10-08 at 19:00 +0800, Gonglei wrote: On 2014/10/7 16:00, Gonglei (Arei) wrote: From: Gonglei arei.gong...@huawei.com Changes since v10: 1. add handler for virtio-blk-pci/s390/ccw in PATCH 28. 2. add especial bootidnex setter/getter

[Qemu-devel] [PULL 19/28] accel: Move accel init/allowed code to separate function

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- accel.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/accel.c

[Qemu-devel] [PULL 18/28] accel: Remove tcg_available() function

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com As the function always return 1, it is not needed anymore. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- accel.c| 1 -

[Qemu-devel] [PULL 17/28] accel: Move qtest accel registration to qtest.c

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com As qtest_availble() returns 1 only when CONFIG_POSIX is set, keep setting AccelClass.available to keep current behavior (this is different from what we did for KVM and Xen). This also allows us to make qtest_init_accel() static. Reviewed-by: Paolo

[Qemu-devel] [PULL 27/28] qemu-sockets: Add error to non-blocking connect handler

2014-10-09 Thread Paolo Bonzini
From: Corey Minyard cminy...@mvista.com An error value here would be quite handy and more consistent with the rest of the code. Signed-off-by: Corey Minyard cminy...@mvista.com [Make sure SO_ERROR value is passed to error_setg_errno. - Paolo] Signed-off-by: Paolo Bonzini pbonz...@redhat.com ---

[Qemu-devel] [PULL 22/28] accel: Create accel object when initializing machine

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Create an actual TYPE_ACCEL object when initializing a machine. This will allow accelerator classes to implement some initialization on instance_init, and to save state on the TYPE_ACCEL object. Reviewed-by: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [PULL 21/28] accel: Pass MachineState object to accel init functions

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Most of the machine options and machine state information is in the MachineState object, not on the MachineClass. This will allow init functions to use the MachineState object directly instead of qemu_get_machine_opts() or the current_machine global.

[Qemu-devel] [PULL 20/28] accel: Rename 'init' method to 'init_machine'

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Today, all accelerator init functions affect some global state: * tcg_init() calls tcg_exec_init() and affects globals such as tcg_tcx, page size globals, and possibly others; * kvm_init() changes the kvm_state global, cpu_interrupt_handler, and

[Qemu-devel] [PULL 23/28] kvm: Make KVMState be the TYPE_KVM_ACCEL instance struct

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Now that we create an accel object before calling machine_init, we can simply use the accel object to save all KVMState data, instead of allocationg KVMState manually. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 26/28] qemu-error: Add error_vreport()

2014-10-09 Thread Paolo Bonzini
From: Corey Minyard cminy...@mvista.com Needed to nicely print socket error reports. Signed-off-by: Corey Minyard cminy...@mvista.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/qemu/error-report.h | 1 + util/qemu-error.c | 23 ++- 2 files

[Qemu-devel] [PULL 28/28] qemu-char: Fix reconnect socket error reporting

2014-10-09 Thread Paolo Bonzini
From: Corey Minyard cminy...@mvista.com If reconnect was set, errors wouldn't always be reported. Fix that and also only report a connect error once until a connection has been made. The primary purpose of this is to tell the user that a connection failed so they can know they need to figure out

[Qemu-devel] [PULL 24/28] linuxboot: compute initrd loading address

2014-10-09 Thread Paolo Bonzini
Even though hw/i386/pc.c tries to compute a valid loading address for the initrd, close to the top of RAM, this does not take into account other data that is malloced into that memory by SeaBIOS. Luckily we can easily look at the memory map to find out how much memory is used up there. This

[Qemu-devel] [PULL 16/28] accel: Move Xen registration code to xen-common.c

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Note that this has an user-visible side-effect: instead of reporting Xen is not supported for this target, QEMU binaries not supporting Xen will report xen accelerator does not exist. As xen_available() always return 1 when CONFIG_XEN is enabled, we

[Qemu-devel] [PULL 25/28] virtio-scsi: fix use-after-free of VirtIOSCSIReq

2014-10-09 Thread Paolo Bonzini
scsi_req_continue can complete the request and cause the VirtIOSCSIReq to be freed. Fetch req-sreq just once to avoid the bug. Reported-by: Richard Jones rjo...@redhat.com Tested-by: Richard Jones rjo...@redhat.com Reviewed-by: Fam Zheng f...@redhat.com Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 07/28] vl.c: Small coding style fix

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Just to make checkpatch.pl happy when moving the code. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PULL 15/28] accel: Move KVM accel registration to kvm-all.c

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Note that this has an user-visible side-effect: instead of reporting KVM is not supported for this target, QEMU binaries not supporting KVM will report kvm accelerator does not exist. As kvm_availble() always return 1 when CONFIG_KVM is enabled, we don't

[Qemu-devel] [PULL 10/28] accel: Simplify configure_accelerator() using AccelType *acc variable

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- accel.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/accel.c

[Qemu-devel] [PULL 11/28] accel: Move accel name lookup to separate function

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- accel.c | 57 + 1 file changed, 33

[Qemu-devel] [PULL 14/28] accel: Report unknown accelerator as not found instead of does not exist

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com As the accelerator classes won't be registered anymore if they are not enabled at compile time, saying does not exist may be misleading, as the accelerator may be simply disabled. Change the wording to just say not found. Suggested-by: Paolo Bonzini

[Qemu-devel] [PULL 09/28] accel: Create AccelType typedef

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- accel.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/accel.c b/accel.c

[Qemu-devel] [PULL 12/28] accel: Use QOM classes for accel types

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Instead of having a static AccelType array, register a class for each accelerator type, and use class name lookup to find accelerator information. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com

[Qemu-devel] [PULL 08/28] accel: Move accel code to accel.c

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile.objs | 1 + accel.c| 113

[Qemu-devel] [PULL 13/28] accel: Make AccelClass.available() optional

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com When we move accel classes outside accel.c, the available() function won't be necessary anymore, because the classes will be registered only if the accelerator code is really enabled at build time. Reviewed-by: Paolo Bonzini pbonz...@redhat.com

Re: [Qemu-devel] [PULL 00/28] Changes for 2014-10-09

2014-10-09 Thread Peter Maydell
On 9 October 2014 11:10, Paolo Bonzini pbonz...@redhat.com wrote: The following changes since commit 1831e150606a221898bf46ffaf0453e9952cbbc4: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-09-30 16:45:35 +0100) are available in the git repository at:

Re: [Qemu-devel] [PULL 00/28] Changes for 2014-10-09

2014-10-09 Thread Paolo Bonzini
Il 09/10/2014 12:55, Peter Maydell ha scritto: (No, I don't know why the gcc for w32 complains about repeat identical typedefs and none of my other gcc do.) Just an older version. It comes up at least half a month. Will send v2. Paolo

[Qemu-devel] [PATCH V2] LEON3: Add emulation of AMBA plugplay

2014-10-09 Thread Fabien Chouteau
From: Jiri Gaisler j...@gaisler.se AMBA plugplay is used by kernels to probe available devices (Timers, UART, etc...). This is a static declaration of devices implemented in QEMU. In the future, a more advanced version could compute those information directly from the device tree. Signed-off-by:

Re: [Qemu-devel] [PATCH v11 00/34] modify boot order of guest, and take effect after rebooting

2014-10-09 Thread Michael Mueller
On Thu, 09 Oct 2014 11:47:12 +0200 Gerd Hoffmann kra...@redhat.com wrote: On Mi, 2014-10-08 at 19:00 +0800, Gonglei wrote: On 2014/10/7 16:00, Gonglei (Arei) wrote: From: Gonglei arei.gong...@huawei.com Changes since v10: 1. add handler for virtio-blk-pci/s390/ccw in PATCH 28.

Re: [Qemu-devel] [PATCH v11 00/34] modify boot order of guest, and take effect after rebooting

2014-10-09 Thread Andreas Färber
Am 09.10.2014 um 12:09 schrieb Gonglei: On 2014/10/9 17:47, Gerd Hoffmann wrote: On Mi, 2014-10-08 at 19:00 +0800, Gonglei wrote: On 2014/10/7 16:00, Gonglei (Arei) wrote: From: Gonglei arei.gong...@huawei.com Changes since v10: 1. add handler for virtio-blk-pci/s390/ccw in PATCH 28.

Re: [Qemu-devel] [PATCH v11 04/34] fw_cfg: add fw_cfg_machine_reset function

2014-10-09 Thread Paolo Bonzini
Il 07/10/2014 10:00, arei.gong...@huawei.com ha scritto: From: Gonglei arei.gong...@huawei.com We must assure that the changed bootindex can take effect when guest is rebooted. So we introduce fw_cfg_machine_reset(), which change the fw_cfg file's bootindex data using the new global

Re: [Qemu-devel] [PATCH v11 07/34] bootindex: add a setter/getter functions wrapper for bootindex property

2014-10-09 Thread Paolo Bonzini
Il 07/10/2014 10:00, arei.gong...@huawei.com ha scritto: From: Gonglei arei.gong...@huawei.com when we remove bootindex form qdev.property to qom.property, we can use those functions set/get bootindex property for all correlative devices. Meanwhile set the initial value of bootindex to -1.

Re: [Qemu-devel] [PATCH v11 17/34] net: remove bootindex property from qdev to qom

2014-10-09 Thread Paolo Bonzini
Il 07/10/2014 10:00, arei.gong...@huawei.com ha scritto: From: Gonglei arei.gong...@huawei.com Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use qom features which are not supported by qdev property. Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH v11 00/34] modify boot order of guest, and take effect after rebooting

2014-10-09 Thread Paolo Bonzini
Il 09/10/2014 11:47, Gerd Hoffmann ha scritto: On Mi, 2014-10-08 at 19:00 +0800, Gonglei wrote: On 2014/10/7 16:00, Gonglei (Arei) wrote: From: Gonglei arei.gong...@huawei.com Changes since v10: 1. add handler for virtio-blk-pci/s390/ccw in PATCH 28. 2. add especial bootidnex

Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-10-09 Thread Markus Armbruster
Amit Shah amit.s...@redhat.com writes: Users of virtio-serial may want to know when a port becomes writable. A port can stop accepting writes if the guest port is open but not being read from. In this case, data gets queued up in the virtqueue, and after the vq is full, writes to the port

Re: [Qemu-devel] [PATCH 0/8] pending s390x patches for 2.2

2014-10-09 Thread Christian Borntraeger
Am 07.10.2014 12:58, schrieb Cornelia Huck: Here's what I currently have on git://github.com/cohuck/qemu s390-next A headers update, cpu state handling in qemu and migration, and a vhost-scsi-ccw bugfix. The gdb patch needs further discussion. I plan to send a pull request later this

[Qemu-devel] [question] is it posssible that big-endian l1 table offset referenced by other I/O while updating l1 table offset in qcow2_update_snapshot_refcount?

2014-10-09 Thread Zhang Haoyu
Hi, I encounter a problem that after deleting snaptshot, the qcow2 image size is very larger than that it should be displayed by ls command, but the virtual disk size is okay via qemu-img info. I suspect that during updating l1 table offset, other I/O job reference the big-endian l1 table

[Qemu-devel] [PULL v2 00/28] Changes for 2014-10-29

2014-10-09 Thread Paolo Bonzini
The following changes since commit 1831e150606a221898bf46ffaf0453e9952cbbc4: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-09-30 16:45:35 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to

[Qemu-devel] [PULL v2 21/28] accel: Pass MachineState object to accel init functions

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Most of the machine options and machine state information is in the MachineState object, not on the MachineClass. This will allow init functions to use the MachineState object directly instead of qemu_get_machine_opts() or the current_machine global.

Re: [Qemu-devel] [PATCH v5 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-10-09 Thread Gonglei
Andreas, ping? Best regards, -Gonglei -Original Message- From: qemu-devel-bounces+arei.gonglei=hotmail@nongnu.org [mailto:qemu-devel-bounces+arei.gonglei=hotmail@nongnu.org] On Behalf Of Gonglei Sent: Wednesday, October 08, 2014 6:46 PM To: Paolo Bonzini Cc: Huangweidong

Re: [Qemu-devel] [PATCH v11 17/34] net: remove bootindex property from qdev to qom

2014-10-09 Thread Gonglei
Subject: Re: [Qemu-devel] [PATCH v11 17/34] net: remove bootindex property from qdev to qom Il 07/10/2014 10:00, arei.gong...@huawei.com ha scritto: From: Gonglei arei.gong...@huawei.com Remove bootindex form qdev property to qom, things will continue to work just fine, and we can use

Re: [Qemu-devel] [PATCH v11 00/34] modify boot order of guest, and take effect after rebooting

2014-10-09 Thread Gonglei
Subject: Re: [Qemu-devel] [PATCH v11 00/34] modify boot order of guest, and take effect after rebooting On Thu, 09 Oct 2014 11:47:12 +0200 Gerd Hoffmann kra...@redhat.com wrote: On Mi, 2014-10-08 at 19:00 +0800, Gonglei wrote: On 2014/10/7 16:00, Gonglei (Arei) wrote: From:

Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-10-09 Thread Amit Shah
On (Thu) 09 Oct 2014 [13:18:16], Markus Armbruster wrote: Amit Shah amit.s...@redhat.com writes: Users of virtio-serial may want to know when a port becomes writable. A port can stop accepting writes if the guest port is open but not being read from. In this case, data gets queued up in

[Qemu-devel] [Bug 1354167] Re: On VM restart: Could not open 'poppy.qcow2': Could not read snapshots: File too large

2014-10-09 Thread Rob Schultz
I had the exact same issue with a VM after upgrading the host from 12.04 to 14.04. Thank you Todd for the workaround. It would have been more work than I cared for to reassemble that machine (even if it was just a test machine). I'm not sure what the status of this bug is? Is this something that

[Qemu-devel] [PATCH v4] pc-dimm/numa: Fix stat of memory size in node when hotplug memory

2014-10-09 Thread zhanghailiang
When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. For now, it mainly affects the result of hmp command info numa. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- v4: -

Re: [Qemu-devel] NBD TLS support in QEMU

2014-10-09 Thread Paolo Bonzini
Il 08/10/2014 20:16, Wouter Verhelst ha scritto: @@ -242,10 +242,13 @@ Option types * NBD_OPT_EXPORT_NAME (1) Choose the export which the client would like to use, and end option haggling. Data: name of the export, free-form UTF8 text (subject to limitations by server

[Qemu-devel] [PATCH] arm_gic: remove unused parameter.

2014-10-09 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This removes num_irq parameter from gic_init_irqs_and_distributor as it is not used. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com --- hw/intc/arm_gic.c | 4 ++-- hw/intc/armv7m_nvic.c | 2 +- hw/intc/gic_internal.h | 2 +- 3

Re: [Qemu-devel] [PATCH v2 1/1] virtio: serial: expose a 'guest_writable' callback for users

2014-10-09 Thread Peter Maydell
On 9 October 2014 13:17, Amit Shah amit.s...@redhat.com wrote: On (Thu) 09 Oct 2014 [13:18:16], Markus Armbruster wrote: The code should work, but whether it makes sense is hard to judge for virtio noobs like me without a user of guest_writable. The conditional guarding

Re: [Qemu-devel] [PULL v2 00/28] Changes for 2014-10-29

2014-10-09 Thread Peter Maydell
On 9 October 2014 12:40, Paolo Bonzini pbonz...@redhat.com wrote: The following changes since commit 1831e150606a221898bf46ffaf0453e9952cbbc4: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-09-30 16:45:35 +0100) are available in the git repository at:

[Qemu-devel] [PULL 2/8] s390x/kvm: introduce proper states for s390 cpus

2014-10-09 Thread Cornelia Huck
From: David Hildenbrand d...@linux.vnet.ibm.com Until now, when a s390 cpu was stopped or halted, the number of running CPUs was tracked in a global variable. This was problematic for migration, so Jason came up with a per-cpu running state. As it turns out, we want to track the full logical

[Qemu-devel] [PULL 6/8] s390x/kvm: synchronize the cpu state after SIGP (INITIAL) CPU RESET

2014-10-09 Thread Cornelia Huck
From: David Hildenbrand d...@linux.vnet.ibm.com We need to synchronize registers after a reset has been performed. The current code does that in qemu_system_reset(), load_normal_reset() and modified_clear_reset() for all vcpus. After SIGP (INITIAL) CPU RESET, this needs to be done for the

[Qemu-devel] [PULL 5/8] s390x/kvm: reuse kvm_s390_reset_vcpu() to get rid of ifdefs

2014-10-09 Thread Cornelia Huck
From: David Hildenbrand d...@linux.vnet.ibm.com This patch reuses kvm_s390_reset_vcpu() to get rid of some CONFIG_KVM and CONFIG_USER_ONLY ifdefs in cpu.c. In order to get rid of CONFIG_USER_ONLY, kvm_s390_reset_vcpu() has to provide a dummy implementation - the two definitions are moved to the

[Qemu-devel] [PULL 0/8] s390x patches for 2.2

2014-10-09 Thread Cornelia Huck
The following changes since commit b6011bd8a57c1eda81a857d21adeb9b66e58b1b0: Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20141006-2' into staging (2014-10-07 10:41:48 +0100) are available in the git repository at: git://github.com/cohuck/qemu.git tags/s390x-20141009

[Qemu-devel] [PULL 3/8] s390x/kvm: proper use of the cpu states OPERATING and STOPPED

2014-10-09 Thread Cornelia Huck
From: David Hildenbrand d...@linux.vnet.ibm.com This patch makes sure that halting a cpu and stopping a cpu are two different things. Stopping a cpu will also set the cpu halted - this is needed for common infrastructure to work (note that the stop and stopped flag cannot be used for our purpose

[Qemu-devel] [PULL 4/8] s390x/kvm: propagate s390 cpu state to kvm

2014-10-09 Thread Cornelia Huck
From: David Hildenbrand d...@linux.vnet.ibm.com Let QEMU propagate the cpu state to kvm. If kvm doesn't yet support it, it is silently ignored as kvm will still handle the cpu state itself in that case. The state is not synced back, thus kvm won't have a chance to actively modify the cpu state.

[Qemu-devel] [PULL 7/8] s390x/migration: migrate CPU state

2014-10-09 Thread Cornelia Huck
From: Thomas Huth th...@linux.vnet.ibm.com This patch provides the cpu save information for dumps and later life migration and enables migration of the CPU state. The code is based on earlier work from Christian Borntraeger and Jason Herne. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com

[Qemu-devel] [PULL 8/8] s390x/virtio-ccw: fix vhost-scsi intialization

2014-10-09 Thread Cornelia Huck
The vhost-scsi-ccw backend is of type VHostSCSICcw, not VirtIOSCSICcw. This fixes a segfault when invoking qemu-system-s390x -device vhost-scsi-ccw,? Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com Tested-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Cornelia Huck

[Qemu-devel] [PULL 1/8] linux-headers: update to 3.17-rc7

2014-10-09 Thread Cornelia Huck
From: Jens Freimann jf...@linux.vnet.ibm.com Sync headers with 3.17-rc7 Acked-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- linux-headers/asm-mips/kvm_para.h |6 +-

[Qemu-devel] [PULL v3 00/28] Changes for 2014-10-09

2014-10-09 Thread Paolo Bonzini
The following changes since commit 1831e150606a221898bf46ffaf0453e9952cbbc4: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2014-09-30 16:45:35 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to

[Qemu-devel] [PULL v3 22/28] accel: Create accel object when initializing machine

2014-10-09 Thread Paolo Bonzini
From: Eduardo Habkost ehabk...@redhat.com Create an actual TYPE_ACCEL object when initializing a machine. This will allow accelerator classes to implement some initialization on instance_init, and to save state on the TYPE_ACCEL object. Reviewed-by: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror'

2014-10-09 Thread Chen Gang
The related variables are useless, need be removed, or can not pass microblaze building, after fix it, can build microblaze, successfully. The related configuration: ./configure --target-list=arm-softmmu,microblazeel-softmmu --enable-fdt --disable-kvm The related compiling error: CXX

Re: [Qemu-devel] [PATCH] virtio-balloon: Tweak recent fix for integer overflow

2014-10-09 Thread Luiz Capitulino
On Wed, 1 Oct 2014 18:43:44 +0200 Markus Armbruster arm...@redhat.com wrote: Commit 1f9296b avoids other kinds of overflow by limiting the polling interval to UINT_MAX. The computations to protect are done in 64 bits. This is indeed safe when unsigned is 32 bits, as it commonly is. It

[Qemu-devel] [RFC][PATCH v2x prototype 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-09 Thread Don Slutz
This adds synchronisation of the 6 vcpu registers (only 32bits of them) that vmport.c needs between Xen and QEMU. This is to avoid a 2nd and 3rd exchange between QEMU and Xen to fetch and put these 6 vcpu registers used by the code in vmport.c and vmmouse.c Add new array to XenIOState that

Re: [Qemu-devel] [PATCH v8 0/2] Return error reasons to caller when calling qmp_dump_guest_memory

2014-10-09 Thread Luiz Capitulino
On Thu, 9 Oct 2014 14:13:09 +0800 zhanghailiang zhang.zhanghaili...@huawei.com wrote: In original code, Function dump_error ignores its second parameter which contains error reason, it is better to return the error message to the caller. Here we use error_setg to return the error info to

[Qemu-devel] [PATCH v5 4/7] target-arm: Handle SMC/HVC undef-if-no-ELx in pre_* helpers

2014-10-09 Thread Peter Maydell
SMC must UNDEF if EL3 is not implemented; similarly HVC UNDEFs if EL2 is not implemented. Move the handling of this from translate-a64.c into the pre_smc and pre_hvc helper functions. This is necessary because use of these instructions for PSCI takes precedence over this UNDEF case, and we can't

[Qemu-devel] [PATCH v5 0/7] ARM: add PSCI 0.2 support in TCG mode

2014-10-09 Thread Peter Maydell
This series adds PSCI support to ARM and AArch64 system emulation when running in TCG mode. It's an update of the patchsent Ard sent out earlier in September which in turn is based on work by Rob Herring. Changes v5-v6: * minor rebasing * redid the way that PSCI is plumbed into SMC/HVC

[Qemu-devel] [PATCH v5 1/7] target-arm: add powered off cpu state

2014-10-09 Thread Peter Maydell
From: Rob Herring rob.herr...@linaro.org Add tracking of cpu power state in order to support powering off of cores in system emuluation. The initial state is determined by the start-powered-off QOM property. Signed-off-by: Rob Herring rob.herr...@linaro.org Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH v5 7/7] arm/virt: enable PSCI emulation support for system emulation

2014-10-09 Thread Peter Maydell
From: Rob Herring rob.herr...@linaro.org Now that we have PSCI emulation, enable it for the virt platform. This simplifies the virt machine a bit now that PSCI no longer needs to be a KVM only feature. Signed-off-by: Rob Herring rob.herr...@linaro.org Signed-off-by: Ard Biesheuvel

[Qemu-devel] [PATCH v5 5/7] target-arm: Add support for A32 and T32 HVC and SMC insns

2014-10-09 Thread Peter Maydell
Add support for HVC and SMC instructions to the A32 and T32 decoder. Using these for real exceptions to EL2 or EL3 is currently not supported (the do_interrupt routine does not handle them) but we require the instruction support to implement PSCI. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH v5 6/7] target-arm: add emulation of PSCI calls for system emulation

2014-10-09 Thread Peter Maydell
From: Rob Herring rob.herr...@linaro.org Add support for handling PSCI calls in system emulation. Both version 0.1 and 0.2 of the PSCI spec are supported. Platforms can enable support by setting the psci-conduit QOM property on the cpus to SMC or HVC emulation and having a PSCI binding in their

[Qemu-devel] [PATCH v5 3/7] target-arm: add missing PSCI constants needed for PSCI emulation

2014-10-09 Thread Peter Maydell
From: Ard Biesheuvel ard.biesheu...@linaro.org This adds some PSCI function IDs and symbolic return codes that are needed to implement PSCI emulation in TCG mode. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org Signed-off-by: Peter

[Qemu-devel] [PATCH v5 2/7] target-arm: do not set do_interrupt handlers for ARM and AArch64 user modes

2014-10-09 Thread Peter Maydell
From: Rob Herring rob.herr...@linaro.org User mode emulation should never get interrupts and thus should not use the system emulation exception handler function. Remove the reference, and '#ifndef USER_MODE_ONLY' the function itself as well, so that we can add system mode only functionality to

Re: [Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror'

2014-10-09 Thread Peter Maydell
On 9 October 2014 15:00, Chen Gang gang.chen.5...@gmail.com wrote: The related variables are useless, need be removed, or can not pass microblaze building, after fix it, can build microblaze, successfully. The related configuration: ./configure --target-list=arm-softmmu,microblazeel-softmmu

Re: [Qemu-devel] [PATCH 1/1] hmp: Remove info pcmcia

2014-10-09 Thread Luiz Capitulino
On Wed, 01 Oct 2014 10:54:44 +0200 Markus Armbruster arm...@redhat.com wrote: Ping? Markus Armbruster arm...@redhat.com writes: This command lists PCMCIA sockets and cards. Only a few ARM boards have sockets (akita, borzoi, connex, mainstone, spitz, terrier, tosa, verdex, z2), the

Re: [Qemu-devel] [PATCH] hw/arm/virt: mark timer in fdt as v8-compatible

2014-10-09 Thread Claudio Fontana
Hello Peter, are you ok with this one? Thanks, Claudio On 26 September 2014 15:09, hw.clau...@gmail.com wrote: From: Claudio Fontana claudio.font...@huawei.com check if the first cpu is an armv8 cpu, and if so, put arm,armv8-timer in the compatible string list. Note that due to this

Re: [Qemu-devel] [PATCH 1/1] hmp: Remove info pcmcia

2014-10-09 Thread Andreas Färber
Am 09.10.2014 um 15:47 schrieb Luiz Capitulino: On Wed, 01 Oct 2014 10:54:44 +0200 Markus Armbruster arm...@redhat.com wrote: Ping? Markus Armbruster arm...@redhat.com writes: This command lists PCMCIA sockets and cards. Only a few ARM boards have sockets (akita, borzoi, connex,

Re: [Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror'

2014-10-09 Thread Eric Blake
On 10/09/2014 08:00 AM, Chen Gang wrote: That's a very long subject line. Try to keep subjects around 60 characters or so ('git shortlog -30' can give you an idea of reasonable subjects). Also, s/varialbe/variable/ in the subject. The related variables are useless, need be removed, or can not

Re: [Qemu-devel] [question] is it posssible that big-endian l1 table offset referenced by other I/O while updating l1 table offset in qcow2_update_snapshot_refcount?

2014-10-09 Thread Eric Blake
On 10/09/2014 05:17 AM, Zhang Haoyu wrote: Hi, I encounter a problem that after deleting snaptshot, the qcow2 image size is very larger than that it should be displayed by ls command, but the virtual disk size is okay via qemu-img info. I suspect that during updating l1 table offset, other

Re: [Qemu-devel] [PATCH 1/1] hmp: Remove info pcmcia

2014-10-09 Thread Peter Maydell
On 9 October 2014 15:41, Andreas Färber afaer...@suse.de wrote: Am 09.10.2014 um 15:47 schrieb Luiz Capitulino: On Wed, 01 Oct 2014 10:54:44 +0200 Markus Armbruster arm...@redhat.com wrote: Ping? Markus Armbruster arm...@redhat.com writes: This command lists PCMCIA sockets and cards.

Re: [Qemu-devel] [PATCH 1/1] hmp: Remove info pcmcia

2014-10-09 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 9 October 2014 15:41, Andreas Färber afaer...@suse.de wrote: Am 09.10.2014 um 15:47 schrieb Luiz Capitulino: On Wed, 01 Oct 2014 10:54:44 +0200 Markus Armbruster arm...@redhat.com wrote: Ping? Markus Armbruster arm...@redhat.com writes:

Re: [Qemu-devel] [PATCH] linux-user: Let user specify random seed

2014-10-09 Thread Eric Blake
On 10/09/2014 02:36 AM, Magnus Reftel wrote: This patch introduces the -seed command line option and the QEMU_RAND_SEED environment variable for setting the random seed, which is used for the AT_RANDOM ELF aux entry. Signed-off-by: Magnus Reftel ref...@spotify.com --- +static void

  1   2   >