Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/4] spice-qemu-char: fix check for in-parameter

2014-11-02 Thread Michael Tokarev
01.11.2014 04:50, zhanghailiang wrote: For qemu_chr_open_spice_vmc and qemu_chr_open_spice_port, the in-parameter never to be NULL, because the checks in qemu_chr_parse_spice_vmc and qemu_chr_parse_spice_port have ensured this. So we should check the length of the in-parameter. The same

Re: [Qemu-devel] [Qemu-trivial] [PATCH v6] numa: make 'info numa' take into account hotplugged memory

2014-11-02 Thread Michael Tokarev
30.10.2014 11:22, zhanghailiang wrote: Hi Michael, Can you help applying this patch to -trivial branch? It has been reviewed, and it mainly fix bug for hmp command of 'info numa'. Which i don't know if it should go qemu-stable, for this is not a blocker. Maybe go trivial branch is a

[Qemu-devel] the need for if=none for -drive?

2014-11-02 Thread Michael Tokarev
All modern 2-way drive/device specifications need to explicitly specify if=none for the drive for it to not be used in the default ide bus implicitly. But how about using some if=unspecified implicitly for all devices which don't specify if=, pick any devices from that list which are referenced

[Qemu-devel] [PATCH] tcg: dump op count to the same stream as other info

2014-11-02 Thread Max Filippov
Otherwise 'info jit' outputs half of the information to monitor and the rest to qemu log. Signed-off-by: Max Filippov jcmvb...@gmail.com --- tcg/tcg.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 7a84b87..15d29df 100644 --- a/tcg/tcg.c

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-11-02 Thread Michael S. Tsirkin
On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote: Add AVX512 feature bits, register definition and corresponding xsave/vmstate support. Signed-off-by: Chao Peng chao.p.p...@linux.intel.com Thanks! As this was first posted after soft freeze, please resubmit after 2.2 is out. See

Re: [Qemu-devel] [PATCH] vhost-user-test: revert changes to make 'make check' happy

2014-11-02 Thread Gonglei
Ping... Best regards, -Gonglei On 2014/10/26 15:46, Gonglei (Arei) wrote: From: Gonglei arei.gong...@huawei.com After commit 89b516d8, some logics is turbid. First, vhost-usr-test.c rely on glib-compat.h because of using G_TIME_SPAN_SECOND [glib 2.26] and g_get_monotonic_time(), but

Re: [Qemu-devel] [PATCH 00/11] pc: kvm: memory hotplug fixes

2014-11-02 Thread Michael S. Tsirkin
On Fri, Oct 31, 2014 at 04:38:31PM +, Igor Mammedov wrote: Series * fixes [1/11] QEMU crash when non aligned DIMM is used in KVM mode. * adds extra checks/enforcement to avoid non aligned DIMM address/sizes and prevents guest failures when it tries to deal with such DIMMs *

[Qemu-devel] [PATCH 1/4] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

2014-11-02 Thread Quan Xu
Signed-off-by: Quan Xu quan...@intel.com --- configure| 14 ++ hmp.c| 7 +++ qapi-schema.json | 17 +++-- qemu-options.hx | 13 +++-- tpm.c| 7 ++- 5 files changed, 53 insertions(+), 5 deletions(-) diff --git a/configure

[Qemu-devel] [PATCH 2/4] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2014-11-02 Thread Quan Xu
This drvier transfers any request/repond between TPM xenstubdoms driver and Xen vTPM stubdom, and facilitates communications between Xen vTPM stubdom domain and vTPM xenstubdoms driver Signed-off-by: Quan Xu quan...@intel.com --- hw/xen/Makefile.objs | 1 + hw/xen/xen_backend.c

[Qemu-devel] [PATCH 0/4] Qemu-Xen-vTPM: enable Xen stubdom vTPM for HVM virtual machine

2014-11-02 Thread Quan Xu
This patch series are only the Qemu part to enable Xen stubdom vTPM for HVM virtual machine. it will work w/ Xen patch series and seaBios patch series. .. Build it with --enable-tpm and --enable-xen options and link with Xen, or change QEMU_STUBDOM_VTPM compile option from 'n' to 'y' in

[Qemu-devel] [PATCH 3/4] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms driver.

2014-11-02 Thread Quan Xu
This driver provides vTPM initialization and sending data and TPM commends to a Xen stubdom vTPM domain. Signed-off-by: Quan Xu quan...@intel.com --- hw/tpm/Makefile.objs | 1 + hw/tpm/tpm_xenstubdoms.c | 238 +++ 2 files changed, 239

[Qemu-devel] [PATCH 4/4] Qemu-Xen-vTPM: QEMU machine class is initialized before tpm_init()

2014-11-02 Thread Quan Xu
make sure QEMU machine class is initialized and QEMU has registered Xen stubdom vTPM driver when call tpm_init() [vl.c] Signed-off-by: Quan Xu quan...@intel.com --- vl.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/vl.c b/vl.c index f6b3546..dd437e1

Re: [Qemu-devel] [PATCH 0/2] vga: demote cirrus

2014-11-02 Thread Michael S. Tsirkin
On Tue, Oct 28, 2014 at 10:09:10AM +0100, Gerd Hoffmann wrote: Hi, Time to flip the default to stdvga. Done for 2.2+ machine types only, for obvious compatibility reasons. https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/ Would you classify this a bugfix? If

Re: [Qemu-devel] [PATCH RFC 00/10] pci: Partial conversion to realize

2014-11-02 Thread Michael S. Tsirkin
On Tue, Oct 28, 2014 at 08:35:29AM +0100, Markus Armbruster wrote: While discussing Gonglei's [PATCH v2 00/19] usb: convert device init to realize, Paolo called the PCI conversion job Gargantuan. This series attempts to crack it into manageable jobs. The basic idea comes from qdev core:

[Qemu-devel] [PULL 00/23] Trivial patches for 2014-11-02

2014-11-02 Thread Michael Tokarev
Here's an almost 3-week trivial patches pull request. Lots of small things here and there, many small bugfixes too. This is also a first pull request for which a signature should finally be known to others. Please consider applying/pulling. /mjt The following changes since commit

[Qemu-devel] [PULL 01/23] tests: Add missing include to test-bitops.c

2014-11-02 Thread Michael Tokarev
From: Eduardo Habkost ehabk...@redhat.com The test code needs osdep.h for the ARRAY_SIZE macro. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- tests/test-bitops.c |1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-bitops.c

[Qemu-devel] [PULL 03/23] bitmap.h: Don't include qemu-common.h

2014-11-02 Thread Michael Tokarev
From: Eduardo Habkost ehabk...@redhat.com This will avoid unexpected circular header dependencies in the future. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- include/qemu/bitmap.h |6 +- 1 file changed, 5 insertions(+), 1

[Qemu-devel] [PULL 07/23] util: Improve os_mem_prealloc error message

2014-11-02 Thread Michael Tokarev
From: Michal Privoznik mpriv...@redhat.com Currently, when the preallocating guest memory process fails, a not so helpful error message is printed out: # virsh start migt10 error: Failed to start domain migt10 error: internal error: process exited while connecting to monitor:

[Qemu-devel] [PULL 04/23] target-xtensa: mark XtensaConfig structs as unused

2014-11-02 Thread Michael Tokarev
From: Peter Maydell peter.mayd...@linaro.org The XtensaConfig structs will be defined but not used if they are for the opposite endianness from that of the binary being built; keep the compiler from complaining about this by marking them with the 'unused' attribute. Signed-off-by: Peter Maydell

[Qemu-devel] [PULL 02/23] bitops.h: Don't include qemu-common.h

2014-11-02 Thread Michael Tokarev
From: Eduardo Habkost ehabk...@redhat.com This removes the following circular dependency: bitops.h - qemu-common.h - target-i386/cpu.h - target-i386/cpu-qom.h - qom/cpu.h - qdev-core.h - bitmap.h - bitops.h. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Michael Tokarev

[Qemu-devel] [PULL 12/23] virtio-9p-proxy: fix error return in proxy_init()

2014-11-02 Thread Michael Tokarev
proxy_init() does not check the return value of connect_namedsocket(), fix this by rearranging code a little bit. Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/9pfs/virtio-9p-proxy.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/virtio-9p-proxy.c

[Qemu-devel] [PULL 11/23] virtio-9p-proxy: Fix sockfd leak

2014-11-02 Thread Michael Tokarev
If connect() in connect_namedsocket() return false, the sockfd will leak. Plug it. Signed-off-by: Michael Tokarev m...@tls.msk.ru Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/9pfs/virtio-9p-proxy.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/9pfs/virtio-9p-proxy.c

[Qemu-devel] [PULL 17/23] pidfile: stop making pidfile error a special case

2014-11-02 Thread Michael Tokarev
In case of -daemonize, we write non-zero to the daemon pipe only if pidfile creation failed, so the parent will report error about pidfile problem. There's no need to make special case for this, since all other errors are reported by the child just fine. Let the parent report error and simplify

[Qemu-devel] [PULL 06/23] sparse: fix build

2014-11-02 Thread Michael Tokarev
From: Gerd Hoffmann kra...@redhat.com c++ compiler isn't wrapped with cgcc, resulting in gcc complaining about the sparse compiler flags which it doesn't know in case qemu is built with --enable-sparse. Signed-off-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru

[Qemu-devel] [PULL 05/23] target-arm: A64: remove redundant store

2014-11-02 Thread Michael Tokarev
From: Alex Bennée alex.ben...@linaro.org There is not much point storing the same value twice in a row. Reported-by: Laurent Desnogues laurent.desnog...@gmail.com Signed-off-by: Alex Bennée alex.ben...@linaro.org Reviewed-by: Laurent Desnogues laurent.desnog...@gmail.com Signed-off-by: Michael

[Qemu-devel] [PULL 15/23] os-posix: use global daemon_pipe instead of cryptic fds[1]

2014-11-02 Thread Michael Tokarev
When asked to -daemonize, we fork a child and setup a pipe between it and parent to pass exit status. os-posix.c used global fds[2] array for that, but actually only the writing side of the pipe is needed to be global, and this name is really too generic. Use just one interger for the writing

[Qemu-devel] [PULL 08/23] Revert os-posix: report error message when lock file failed

2014-11-02 Thread Michael Tokarev
This reverts commit e5048d15ce6addae869f23514b2a1f0d4466418a. qemu_create_pidfile() is only created from main(), and there, if that function returns failure, os_pidfile_error() function is called, to, guess that, report error (which is done differently whenever we're daemonizing or not).

[Qemu-devel] [PULL 23/23] vdi: wrapped uuid_unparse() in #ifdef

2014-11-02 Thread Michael Tokarev
From: SeokYeon Hwang syeon.hw...@samsung.com Wrapped uuid_unparse() in #ifdef to avoid -Wunused-function on clang 3.4 or later. Signed-off-by: SeokYeon Hwang syeon.hw...@samsung.com Reviewed-by: Stefan Weil s...@weilnetz.de Signed-off-by: Michael Tokarev m...@tls.msk.ru --- block/vdi.c |2

[Qemu-devel] [PULL 09/23] net/slirp: specify logbase for smbd

2014-11-02 Thread Michael Tokarev
It looks like smbd always logs to /var/log/samba/log.$progname even if config file specifies different logfile -- when it needs to log something before completing reading the config file. But if it can't open it for writing, it fails and exits. Tell smbd to use our temp dir as logbase (-l

[Qemu-devel] [PULL 18/23] os-posix: reorder parent notification for -daemonize

2014-11-02 Thread Michael Tokarev
Put success parent reporting in os_setup_post() to after all other initializers which may also fail, to the very end, so more possible failure cases are reported properly to the calling process. Signed-off-by: Michael Tokarev m...@tls.msk.ru Reviewed-by: Gonglei arei.gong...@huawei.com ---

[Qemu-devel] [PULL 20/23] target-i386: Remove unused model_features_t struct

2014-11-02 Thread Michael Tokarev
From: Eduardo Habkost ehabk...@redhat.com The struct is not used anymore and can be removed. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- target-i386/cpu.c |8 1 file changed, 8

[Qemu-devel] [PULL 22/23] tap: fix possible fd leak in net_init_tap

2014-11-02 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com In hotplugging scenario, taking those true branch, the file handler do not be closed. Let's close them before return. Signed-off-by: Gonglei arei.gong...@huawei.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- net/tap.c |3 +++ 1 file changed, 3

[Qemu-devel] [PULL 13/23] virtio-9p-proxy: improve error messages in connect_namedsocket()

2014-11-02 Thread Michael Tokarev
Signed-off-by: Michael Tokarev m...@tls.msk.ru Reviewed-by: Gonglei arei.gong...@huawei.com --- hw/9pfs/virtio-9p-proxy.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c index 2ec211b..59c7445 100644 ---

[Qemu-devel] [PULL 10/23] target-tricore: check return value before using it

2014-11-02 Thread Michael Tokarev
From: zhanghailiang zhang.zhanghaili...@huawei.com We reference the return value of cpu before checking whether it is NULL, The checking code is after that which violates code style. It makes no difference if the cpu is NULL, qemu process will terminate. But one will be 'Segmentation fault' and

[Qemu-devel] [PULL 21/23] tap: do not close(fd) in net_init_tap_one

2014-11-02 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com commit 5193e5fb (tap: factor out common tap initialization) introduce net_init_tap_one(). But it's inappropriate that we close fd in net_init_tap_one(), we should lay it in the caller, becuase some callers needn't to close it if we get the fd by

[Qemu-devel] [PULL 19/23] tap_int.h: remove repeating NETWORK_SCRIPT defines

2014-11-02 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com DEFAULT_NETWORK_SCRIPT and DEFAULT_NETWORK_DOWN_SCRIPT have been defined in net/net.h included in tap.c, which is the only C file that using those two macro. Let's remove the repeating macroinstruction. Signed-off-by: Gonglei arei.gong...@huawei.com

[Qemu-devel] [PULL 16/23] os-posix: replace goto again with a proper loop

2014-11-02 Thread Michael Tokarev
Eliminiate two fullwrite implementations with goto replacing them with a proper do..while loop. Signed-off-by: Michael Tokarev m...@tls.msk.ru Reviewed-by: Gonglei arei.gong...@huawei.com --- os-posix.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PULL 14/23] dump: Fix dump-guest-memory termination and use-after-close

2014-11-02 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com dump_iterate() dumps blocks in a loop. Eventually, get_next_block() returns no more. We then call dump_completed(). But we neglect to break the loop! Broken in commit 4c7e251a. Because of that, we dump the last block again. This attempts to write to

Re: [Qemu-devel] Help needed - LGPL Violation and Legal Threats

2014-11-02 Thread Stefan Weil
Am 02.11.2014 um 03:28 schrieb Tom Cain: G'day QEMU wizards, I've recently been made aware of an organization that seems to be pretty actively sending out nastygrams to people who redistribute their software which is a QEMU derivative. It was my understanding that current versions of QEMU

[Qemu-devel] [PATCH] [v2] inetd enabled qemu-nbd

2014-11-02 Thread Jun Sheng
run qemu-nbd as an inetd service has some benefits * more scriptable, such as serve multiple images to different clients on one ip/port * access control using tcpd simple usage: #!/bin/sh # qemu-nbd wrapper, select image file according to client ip address IMG_FILE=`sed -n s/$REMOTE_HOST //p

[Qemu-devel] [PATCH][v2] inetd enabled qemu-nbd

2014-11-02 Thread Jun Sheng
run qemu-nbd as an inetd service has some benefits * more scriptable, such as serve multiple images to different clients on one ip/port * access control using tcpd simple usage: #!/bin/sh # qemu-nbd wrapper, select image file according to client ip address IMG_FILE=`sed -n s/$REMOTE_HOST //p

Re: [Qemu-devel] vhost-user:Bad ram offset

2014-11-02 Thread Michael S. Tsirkin
On Sat, Nov 01, 2014 at 05:21:32PM +0800, Linhaifeng wrote: Hi,all VM use vhost-user backend cannot startup when memory bigger than 3.5G.The log print Bad ram offset 1 .Is this a bug? log: [2014-11-01T08:39:07.245324Z] virtio_set_status:524 virtio-net device status is 1 that

[Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-02 Thread Michael S. Tsirkin
tcp_get_fds API discards fds if there's more than 1 of these. It's tricky to fix this without API changes in the generic case. However, this API is only used by tests ATM, and tests know how many fds they expect. So let's not waste cycles trying to fix this properly: simply assume at most 16

[Qemu-devel] [Bug 1327800] Re: USB mouse is jumpy on y-axis (patch attached)

2014-11-02 Thread Christian Burger
fixed released long time ago ** Changed in: qemu Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1327800 Title: USB mouse is jumpy on y-axis (patch

[Qemu-devel] [PATCH] MAINTAINERS: add myself to lm32 and milkymist

2014-11-02 Thread Michael Walle
Add myself to lm32 and milkymist files. Signed-off-by: Michael Walle mich...@walle.cc --- MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 94366ef..584a174 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -98,8 +98,12 @@ LM32 M:

[Qemu-devel] [PATCH] qdev: modify func qdev_build_hotpluggable_device_list

2014-11-02 Thread Jun Li
Currently when *obj is not a TYPE_DEVICE, qemu will abort. This patch just fixed it. When *obj is not a TYPE_DEVICE, just do not add it to hotpluggable device list. This patch also fixed the following issue: 1, boot qemu using cli: virtio-scsi-pci,id=scsi0 -enable-kvm 2, device_del scsi0 via hmp

Re: [Qemu-devel] [PATCH v3 10/19] target-mips: add MSA I5 format instruction

2014-11-02 Thread Leon Alrae
Hi Yongbok, On 01/11/14 05:28, Yongbok Kim wrote: +TCGv_i32 timm = tcg_temp_new_i32(); +tcg_gen_movi_i32(timm, u5); + +switch (MASK_MSA_I5(ctx-opcode)) { +case OPC_ADDVI_df: +gen_helper_msa_addvi_df(cpu_env, tdf, twd, tws, timm); +break; +case

[Qemu-devel] [PATCH] vhost-user: fix mmap offset calculation

2014-11-02 Thread Michael S. Tsirkin
qemu_get_ram_block_host_ptr should get ram_addr_t, vhost-user passes in GPA. That's very wrong. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index

Re: [Qemu-devel] vhost-user:Bad ram offset

2014-11-02 Thread Michael S. Tsirkin
On Sat, Nov 01, 2014 at 05:21:32PM +0800, Linhaifeng wrote: Hi,all VM use vhost-user backend cannot startup when memory bigger than 3.5G.The log print Bad ram offset 1 .Is this a bug? log: [2014-11-01T08:39:07.245324Z] virtio_set_status:524 virtio-net device status is 1 that

[Qemu-devel] Input to serial device

2014-11-02 Thread Xin Tong
Hi I am emulating a UART serial device with QEMU. the guest OS can print to the serial port without a problem. but how can i write to the UART serial port. I tried to use the -serial pty backend and did not work. i.e. xintong1@fxilab139:$ echo 1 /dev/pts/21 does not raise an interrupt in the

Re: [Qemu-devel] [PATCH] tcg: dump op count to the same stream as other info

2014-11-02 Thread Richard Henderson
On 11/02/2014 01:07 AM, Max Filippov wrote: Otherwise 'info jit' outputs half of the information to monitor and the rest to qemu log. Signed-off-by: Max Filippov jcmvb...@gmail.com --- tcg/tcg.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Well, yes, but do you really

Re: [Qemu-devel] [PATCH] tcg: dump op count to the same stream as other info

2014-11-02 Thread Max Filippov
On Sun, Nov 2, 2014 at 10:53 PM, Richard Henderson r...@twiddle.net wrote: On 11/02/2014 01:07 AM, Max Filippov wrote: Otherwise 'info jit' outputs half of the information to monitor and the rest to qemu log. Signed-off-by: Max Filippov jcmvb...@gmail.com --- tcg/tcg.c | 7 --- 1 file

Re: [Qemu-devel] [PATCH] tcg: dump op count to the same stream as other info

2014-11-02 Thread Richard Henderson
On 11/02/2014 11:56 AM, Max Filippov wrote: Well, yes, but do you really want 60+ lines of per-opcode use counts on the monitor? I'm pretty sure I would never find that useful... Maybe that dump should be a part of another command then? I'd be happy with that. r~

Re: [Qemu-devel] [PATCH v3 19/19] target-mips: add MSA support to mips32r5-generic

2014-11-02 Thread Leon Alrae
On 01/11/14 05:28, Yongbok Kim wrote: add MSA support to mips32r5-generic core definition Signed-off-by: Yongbok Kim yongbok@imgtec.com --- target-mips/translate_init.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-mips/translate_init.c

Re: [Qemu-devel] [PATCH] vhost-user: fix mmap offset calculation

2014-11-02 Thread Nikolay Nikolaev
Hello, I can confirm the issue, and this patch fixes it for me. Thanks. regards, Nikolay Nikolaev Virtual Open Systems On Sun, Nov 2, 2014 at 8:01 PM, Michael S. Tsirkin m...@redhat.com wrote: qemu_get_ram_block_host_ptr should get ram_addr_t, vhost-user passes in GPA. That's very wrong.

[Qemu-devel] [PATCH] tcg: add separate monitor command to dump opcode counters

2014-11-02 Thread Max Filippov
Currently 'info jit' outputs half of the information to monitor and the rest to qemu log. Dumping opcode counts to monitor as a part of 'info jit' command doesn't sound useful. Add new monitor command 'info opcount' that only dumps opcode counters. Signed-off-by: Max Filippov jcmvb...@gmail.com

[Qemu-devel] [Bug 988125] Re: Generated smb.conf needs to declare state directory

2014-11-02 Thread Peter Wu
** Changed in: qemu Status: New = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/988125 Title: Generated smb.conf needs to declare state directory Status in QEMU: Fix

Re: [Qemu-devel] [PATCH 0/3 RFC] add PCI support for the s390 platform

2014-11-02 Thread Alexander Graf
On 22.10.14 17:11, Frank Blaschka wrote: This set of patches implemets PCI support for the s390 platform. Now it is possible to run virtio-net-pci and potentially all virtual pci devices conforming to s390 platform constrains. (In parallel I also post some changes to make vfio run on s390)

[Qemu-devel] [PULL 0/8] target-xtensa queue 2014-11-03

2014-11-02 Thread Max Filippov
Hi Peter, please pull my current target-xtensa patch queue. The following changes since commit 0a2923f8488498000eec54871456aa64a4391da4: tcg/mips: fix store softmmu slow path (2014-11-02 13:30:00 +0100) are available in the git repository at: git://github.com/OSLL/qemu-xtensa.git

Re: [Qemu-devel] [PATCH v3 00/19] target-mips: add MSA module

2014-11-02 Thread Leon Alrae
On 01/11/14 05:28, Yongbok Kim wrote: For 2.2 Release. The following patchset implements MIPS SIMD Architecture module. MSA adds new instructions to MIPS Architecture that allow efficient parallel processing of vector operations. For more information refer to: MIPS Architecture Reference

Re: [Qemu-devel] [PATCH v3 00/19] target-mips: add MSA module

2014-11-02 Thread Peter Maydell
On 2 November 2014 22:14, Leon Alrae leon.al...@imgtec.com wrote: On 01/11/14 05:28, Yongbok Kim wrote: For 2.2 Release. The following patchset implements MIPS SIMD Architecture module. MSA adds new instructions to MIPS Architecture that allow efficient parallel processing of vector

Re: [Qemu-devel] [PATCH v4 01/47] QEMUSizedBuffer based QEMUFile

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:07PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com * Please comment on separate thread for this QEMUSizedBuffer patch * This is based on Stefan and Joel's patch that creates a QEMUFile that goes to a memory buffer;

Re: [Qemu-devel] [PATCH] vhost-user: fix mmap offset calculation

2014-11-02 Thread Linhaifeng
good job!passed test bigger than 3.5G VM. On 2014/11/3 2:01, Michael S. Tsirkin wrote: qemu_get_ram_block_host_ptr should get ram_addr_t, vhost-user passes in GPA. That's very wrong. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio/vhost-user.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH v4 03/47] Start documenting how postcopy works.

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:09PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com Reviewed-by: David Gibson da...@gibson.dropbear.id.au -- David Gibson| I'll have my

Re: [Qemu-devel] [PATCH v4 02/47] Tests: QEMUSizedBuffer/QEMUBuffer

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:08PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com * Please comment on separate thread for this QEMUSziedBuffer patch * Modify some of tests/test-vmstate.c to use the in memory file based on QEMUSizedBuffer to

Re: [Qemu-devel] [PATCH 1/3] qmp: Add command 'blockdev-backup'

2014-11-02 Thread Fam Zheng
On Fri, 10/31 10:01, Kevin Wolf wrote: Am 11.09.2014 um 07:05 hat Fam Zheng geschrieben: Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add

[Qemu-devel] [PATCH v2 RESEND 0/4] qmp: Add blockdev-backup

2014-11-02 Thread Fam Zheng
v2: Address Markus' and Eric's comments: Fix qapi schema documentation. Fix versioning of transactions. Improve test case code by dropping inelegnet bool. The existing drive-backup command accepts a target file path, but that interface provides little flexibility on the properties of

[Qemu-devel] [PATCH v2 RESEND 3/4] qapi-schema: Add version info for transaction types

2014-11-02 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- qapi-schema.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index 1ddd395..48ba583 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -1256,6 +1256,8 @@ # @transaction. # # Since 1.1 +#

[Qemu-devel] [PATCH v2 RESEND 2/4] block: Add blockdev-backup to transaction

2014-11-02 Thread Fam Zheng
Signed-off-by: Fam Zheng f...@redhat.com --- blockdev.c | 48 qapi-schema.json | 4 qapi/block-core.json | 2 +- 3 files changed, 53 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index 5cbf93e..cf85e59

[Qemu-devel] [PATCH v2 RESEND 1/4] qmp: Add command 'blockdev-backup'

2014-11-02 Thread Fam Zheng
Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possible but is an illegal case with introduction

[Qemu-devel] [PATCH v2 RESEND 4/4] qemu-iotests: Test blockdev-backup in 055

2014-11-02 Thread Fam Zheng
This applies cases on drive-backup on blockdev-backup, except cases with target format and mode. Also add a case to check source == target. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/055 | 211 + tests/qemu-iotests/055.out |

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-11-02 Thread Chao Peng
On Sun, Nov 02, 2014 at 12:19:09PM +0200, Michael S. Tsirkin wrote: On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote: Add AVX512 feature bits, register definition and corresponding xsave/vmstate support. Signed-off-by: Chao Peng chao.p.p...@linux.intel.com Thanks! As this

Re: [Qemu-devel] [PATCH 3/4] qemu-char: convert some open functions to use Error API

2014-11-02 Thread zhanghailiang
On 2014/11/1 23:18, Eric Blake wrote: On 10/31/2014 07:50 PM, zhanghailiang wrote: Convert several Character backend open functions to use the Error API. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- qemu-char.c | 52 +++- 1

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/4] qemu-char: fix parameter check for qemu_chr_open_pipe

2014-11-02 Thread zhanghailiang
On 2014/11/2 13:18, Michael Tokarev wrote: 01.11.2014 04:50, zhanghailiang wrote: The filename parameter never to be NULL, because in qemu_chr_parse_pipe it is return value of g_strdup(device), where device will not be NULL. We should check its length. After this patch, when run command:

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/4] spice-qemu-char: fix check for in-parameter

2014-11-02 Thread zhanghailiang
On 2014/11/2 14:50, Michael Tokarev wrote: 01.11.2014 04:50, zhanghailiang wrote: For qemu_chr_open_spice_vmc and qemu_chr_open_spice_port, the in-parameter never to be NULL, because the checks in qemu_chr_parse_spice_vmc and qemu_chr_parse_spice_port have ensured this. So we should check the

Re: [Qemu-devel] [PATCH 1/2] migration: Implement a multiple compress threads feature to accelerate live migration

2014-11-02 Thread Li, Liang Z
This patch is a RFC version. -Original Message- From: Li, Liang Z Sent: Friday, October 31, 2014 1:40 PM To: qemu-devel@nongnu.org Cc: lcapitul...@redhat.com; ebl...@redhat.com; arm...@redhat.com; Li, Liang Z Subject: [PATCH 1/2] migration: Implement a multiple compress threads feature

Re: [Qemu-devel] [PATCH 2/2] docs: Add a document about multiple compression threads

2014-11-02 Thread Li, Liang Z
This is a RFC version. -Original Message- From: Li, Liang Z Sent: Friday, October 31, 2014 1:40 PM To: qemu-devel@nongnu.org Cc: lcapitul...@redhat.com; ebl...@redhat.com; arm...@redhat.com; Li, Liang Z Subject: [PATCH 2/2] docs: Add a document about multiple compression threads From:

Re: [Qemu-devel] [PATCH V6 0/8] cpu/acpi: convert cpu hot plug to hotplug_handler API

2014-11-02 Thread Gu Zheng
Hi Michael, Could you please have a look at this series? Thanks, Gu On 10/22/2014 11:24 AM, Gu Zheng wrote: Previously we use cpu_added_notifiers to register cpu hotplug notifier callback which is not able to pass/handle errors, so we switch it to unified hotplug handler API which allows to

Re: [Qemu-devel] [PATCH v4 06/47] Add qemu_get_counted_string to read a string prefixed by a count byte

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:12PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com and use it in loadvm_state. Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com --- include/migration/qemu-file.h | 2 ++ qemu-file.c |

Re: [Qemu-devel] [PATCH v4 04/47] qemu_ram_foreach_block: pass up error value, and down the ramblock name

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:10PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com check the return value of the function it calls and error if it's non-0 Fixup qemu_rdma_init_one_block that is the only current caller, and __qemu_rdma_add_block

Re: [Qemu-devel] [PATCH v4 07/47] Create MigrationIncomingState

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:13PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com There are currently lots of pieces of incoming migration state scattered around, and postcopy is adding more, and it seems better to try and keep it together.

Re: [Qemu-devel] [PATCH v4 11/47] Return path: socket_writev_buffer: Block even on non-blocking fd's

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:17PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com The return path uses a non-blocking fd so as not to block waiting for the (possibly broken) destination to finish returning a message, however we still want outbound

Re: [Qemu-devel] [PATCH v4 15/47] Return path: Send responses from destination to source

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:21PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Add migrate_send_rp_message to send a message from destination to source along the return path. (It uses a mutex to let it be called from multiple threads) Add

Re: [Qemu-devel] [PATCH v4 05/47] improve DPRINTF macros, add to savevm

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:11PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Improve the existing DPRINTF macros in migration.c and arch_init by: 1) Making them go to stderr rather than stdout (so you can run with -nographic and redirect

Re: [Qemu-devel] [PATCH v4 14/47] Return path: Control commands

2014-11-02 Thread David Gibson
On Thu, Oct 23, 2014 at 10:15:20PM +0200, Paolo Bonzini wrote: On 10/23/2014 06:23 PM, Dr. David Alan Gilbert wrote: * Paolo Bonzini (pbonz...@redhat.com) wrote: Il 03/10/2014 19:47, Dr. David Alan Gilbert (git) ha scritto: QEMU_VM_CMD_INVALID = 0, /* Must be 0 */ +

Re: [Qemu-devel] [PATCH v4 13/47] Migration commands

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:19PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Create QEMU_VM_COMMAND section type for sending commands from source to destination. These commands are not intended to convey guest state but to control the

Re: [Qemu-devel] [PATCH v4 12/47] Handle bi-directional communication for fd migration

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:18PM +0100, Dr. David Alan Gilbert (git) wrote: From: Cristian Klein cristian.kl...@cs.umu.se This patch really, really requires a rationale in the commit message. The reason it's necessary is certainly not obvious. Signed-off-by: Cristian Klein

Re: [Qemu-devel] [PATCH v4 10/47] Return path: Open a return path on QEMUFile for sockets

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:16PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Postcopy needs a method to send messages from the destination back to the source, this is the 'return path'. Wire it up for 'socket' QEMUFile's using a dup'd fd.

Re: [Qemu-devel] [PATCH v4 18/47] ram_debug_dump_bitmap: Dump a migration bitmap as text

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:24PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Misses out lines that are all the expected value so the output can be quite compact depending on the circumstance. Signed-off-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:22PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Open a return path, and handle messages that are received upon it. Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com [snip] @@ -414,6 +448,11 @@ static

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-11-02 Thread David Gibson
On Thu, Oct 16, 2014 at 04:26:55PM +0800, zhanghailiang wrote: On 2014/10/4 1:47, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com [snip] +case MIG_RPCOMM_ACK: +tmp32 = be32_to_cpup((uint32_t *)buf); +DPRINTF(RP: Received

Re: [Qemu-devel] [PATCH v4 17/47] qemu_loadvm errors and debug

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:23PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Flip many fprintf's to error_report Add lots of DPRINTF debug in qemu_loadvm* Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com Reviewed-by: David Gibson

Re: [Qemu-devel] [PATCH V6 0/8] cpu/acpi: convert cpu hot plug to hotplug_handler API

2014-11-02 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 11:20:31AM +0800, Gu Zheng wrote: Hi Michael, Could you please have a look at this series? Thanks, Gu On 10/22/2014 11:24 AM, Gu Zheng wrote: Applied in my tree already, will send upstream after a bit of testing. Thanks! Previously we use cpu_added_notifiers to

Re: [Qemu-devel] [PATCH v4 19/47] Rework loadvm path for subloops

2014-11-02 Thread David Gibson
On Fri, Oct 03, 2014 at 06:47:25PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Postcopy needs to have two migration streams loading concurrently; one from memory (with the device state) and the other from the fd with the memory transactions.

[Qemu-devel] [PATCH] icc_bus: rename ICC_BRIGDE to ICC_BRIDGE

2014-11-02 Thread Zhu Guihua
Rename ICC_BRIGDE for better readability. Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- hw/cpu/icc_bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/cpu/icc_bus.c b/hw/cpu/icc_bus.c index 9575fd6..6646ea2 100644 --- a/hw/cpu/icc_bus.c +++

Re: [Qemu-devel] [PATCH 0/2] vga: demote cirrus

2014-11-02 Thread Gerd Hoffmann
On So, 2014-11-02 at 13:14 +0200, Michael S. Tsirkin wrote: On Tue, Oct 28, 2014 at 10:09:10AM +0100, Gerd Hoffmann wrote: Hi, Time to flip the default to stdvga. Done for 2.2+ machine types only, for obvious compatibility reasons.

Re: [Qemu-devel] [PATCH RFC 00/10] pci: Partial conversion to realize

2014-11-02 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Tue, Oct 28, 2014 at 08:35:29AM +0100, Markus Armbruster wrote: While discussing Gonglei's [PATCH v2 00/19] usb: convert device init to realize, Paolo called the PCI conversion job Gargantuan. This series attempts to crack it into manageable

Re: [Qemu-devel] [PATCH] icc_bus: rename ICC_BRIGDE to ICC_BRIDGE

2014-11-02 Thread Markus Armbruster
Cc: qemu-trivial Zhu Guihua zhugh.f...@cn.fujitsu.com writes: Rename ICC_BRIGDE for better readability. Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com Reviewed-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-devel] [PATCH RFC 00/10] pci: Partial conversion to realize

2014-11-02 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Hi Markus, Am 28.10.2014 um 08:35 schrieb Markus Armbruster: While discussing Gonglei's [PATCH v2 00/19] usb: convert device init to realize, Paolo called the PCI conversion job Gargantuan. This series attempts to crack it into manageable jobs.

Re: [Qemu-devel] [PATCH 0/2] vga: demote cirrus

2014-11-02 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: On So, 2014-11-02 at 13:14 +0200, Michael S. Tsirkin wrote: On Tue, Oct 28, 2014 at 10:09:10AM +0100, Gerd Hoffmann wrote: Hi, Time to flip the default to stdvga. Done for 2.2+ machine types only, for obvious compatibility reasons.

  1   2   >