Re: [Qemu-devel] ui/gtk.c vs old gtk versions

2014-11-04 Thread Cornelia Huck
On Mon, 03 Nov 2014 17:27:39 -0500 Cole Robinson crobi...@redhat.com wrote: Indeed ui/gtk.c already has a number of similar workarounds. Untested fix below. Cornelia or Kevin, can you confirm? - Cole diff --git a/ui/gtk.c b/ui/gtk.c index de564cc..38bf463 100644 --- a/ui/gtk.c +++

Re: [Qemu-devel] [PATCH v2] smbios: changed for smbios_build_type_17_table() to take 'uint64_t'

2014-11-04 Thread Paolo Bonzini
On 04/11/2014 08:12, SeokYeon Hwang wrote: smbios_build_type_17_table() should take 'uint64_t' instead of 'ram_addr_t' because it should be able to handle (16ll * GiB). Otherwise, clang (= 3.4) produces compilation warning in smbios_get_tables(). Signed-off-by: SeokYeon Hwang

Re: [Qemu-devel] [PATCH v2 2/4] block: Add bdrv_get_node_name

2014-11-04 Thread Max Reitz
On 2014-10-31 at 04:32, Fam Zheng wrote: This returns the node name of a BDS. Remove the TODO comment and expect the callers to be explicit. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block.c | 5 + include/block/block.h | 1 + 2

Re: [Qemu-devel] [PATCH 03/11] pc: check if KVM has enough memory slots for DIMM devices

2014-11-04 Thread Paolo Bonzini
On 03/11/2014 20:11, Igor Mammedov wrote: Understood. But I think -m slots=too_much is not an important problem. What is problematic is filling those slots, which patch 1 will help with. From user's pov it's still error, i.e. he asked on CLI for one amount of hotpluggable slots and

Re: [Qemu-devel] [PATCH 4/4] qmp: Add optional switch query-nodes in query-blockstats

2014-11-04 Thread Max Reitz
On 2014-10-31 at 04:20, Fam Zheng wrote: On Wed, 10/29 10:11, Max Reitz wrote: On 2014-10-29 at 06:04, Fam Zheng wrote: This bool option will allow query all the node names. It iterates all the BDSes that are assigned a name, also in this case don't query up the backing chain. Signed-off-by:

Re: [Qemu-devel] ui/gtk.c vs old gtk versions

2014-11-04 Thread Kevin Wolf
Am 03.11.2014 um 23:27 hat Cole Robinson geschrieben: On 11/03/2014 08:32 AM, Daniel P. Berrange wrote: On Mon, Nov 03, 2014 at 02:11:35PM +0100, Kevin Wolf wrote: Am 03.11.2014 um 14:06 hat Cornelia Huck geschrieben: After the latest gtk updates, master fails to build for me on a SLES11SP3

Re: [Qemu-devel] [PATCH v2 4/4] qmp: Add optional switch query-nodes in query-blockstats

2014-11-04 Thread Max Reitz
On 2014-10-31 at 04:32, Fam Zheng wrote: This bool option will allow query all the node names. It iterates all the BDSes that are assigned a name, also in this case don't query up the backing chain. Signed-off-by: Fam Zheng f...@redhat.com --- block/qapi.c | 20 +---

Re: [Qemu-devel] [PATCH 5/5] target-arm/translate.c: Don't pass CPUARMState * to disas_arm_insn()

2014-11-04 Thread Claudio Fontana
Reviewed-by: Claudio Fontana claudio.font...@huawei.com On 28.10.2014 20:24, Peter Maydell wrote: Refactor to avoid passing a CPUARMState * to disas_arm_insn(). To do this we move the read insn from memory code to the callsite and pass the insn to the function instead. Signed-off-by: Peter

Re: [Qemu-devel] [PATCH 4/5] target-arm/translate.c: Don't pass CPUARMState around in the decoder

2014-11-04 Thread Claudio Fontana
Reviewed-by: Claudio Fontana claudio.font...@huawei.com On 28.10.2014 20:24, Peter Maydell wrote: Passing the CPUARMState around in the decoder is a recipe for bugs where we accidentally generate code that depends on CPU state which isn't reflected in the TB flags. Stop doing this and instead

Re: [Qemu-devel] [PATCH 3/5] target-arm/translate.c: Don't use IS_M()

2014-11-04 Thread Claudio Fontana
Reviewed-by: Claudio Fontana claudio.font...@huawei.com On 28.10.2014 20:24, Peter Maydell wrote: Instead of using IS_M(), use arm_dc_feature(s, ARM_FEATURE_M), so we don't need to pass CPUARMState pointers around the decoder. Signed-off-by: Peter Maydell peter.mayd...@linaro.org ---

Re: [Qemu-devel] [PATCH 2/5] target-arm/translate.c: Use arm_dc_feature() rather than arm_feature()

2014-11-04 Thread Claudio Fontana
Reviewed-by: Claudio Fontana claudio.font...@huawei.com On 28.10.2014 20:24, Peter Maydell wrote: Use arm_dc_feature() rather than arm_feature() to avoid using CPUARMState unnecessarily. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate.c | 140

Re: [Qemu-devel] [PATCH 1/5] target-arm/translate.c: Use arm_dc_feature() in ENABLE_ARCH_ macros

2014-11-04 Thread Claudio Fontana
On 28.10.2014 20:24, Peter Maydell wrote: All the places where we use the ENABLE_ARCH_* and ARCH() macros have a DisasContext* s, so switch them over to use arm_dc_feature() rather than arm_feature() so we don't need to pass the CPUARMState* env around too. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v6 01/10] qapi: Add optional field name to block dirty bitmap

2014-11-04 Thread Max Reitz
On 2014-10-30 at 04:22, Fam Zheng wrote: This field will be set for user created dirty bitmap. Also pass in an error pointer to bdrv_create_dirty_bitmap, so when a name is already taken on this BDS, it can report an error message. This is not global check, two BDSes can have dirty bitmap with a

[Qemu-devel] [PATCH 3/5] pci: move initialization of pci's conf_addr and conf_data to common place

2014-11-04 Thread Hu Tao
So that standard pci host device can share them. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/pci-host/piix.c | 20 hw/pci-host/q35.c | 7 --- hw/pci/pci_host.c | 32 3 files changed, 32 insertions(+), 27 deletions(-) diff --git

[Qemu-devel] [PATCH 5/5] pci: remove the limit parameter of pci_host_config_write_common

2014-11-04 Thread Hu Tao
Since the limit parameter is always set to the size of pci device's configuration space, and we can determine the size from the type of pci device. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/pci/pci_host.c | 13 ++--- hw/pci/pcie_host.c| 9 +

[Qemu-devel] [PATCH 4/5] pci: remove the limit parameter of pci_host_config_read_common

2014-11-04 Thread Hu Tao
Since the limit parameter is always set to the size of pci device's configuration space, and we can determine the size from the type of pci device. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/pci/pci_host.c | 15 +++ hw/pci/pcie_host.c| 9 +

[Qemu-devel] [PATCH 1/5] pci: introduce PC_PCI_CONFIG_ENABLED()

2014-11-04 Thread Hu Tao
This makes code more readable. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/mips/gt64xxx_pci.c | 4 ++-- hw/pci/pci_host.c | 5 +++-- include/hw/pci/pci.h | 2 ++ 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index

[Qemu-devel] [PATCH 0/5] Some PCI related cleanup patches

2014-11-04 Thread Hu Tao
Hi, This series includes 5 PCI clenaup patches. See each patch for the detail. Hu Tao (5): pci: introduce PC_PCI_CONFIG_ENABLED() pc: define PC_PCI_CONFIG_ADDR and PC_PCI_CONFIG_DATA pci: move initialization of pci's conf_addr and conf_data to common place pci: remove the limit

[Qemu-devel] [PATCH 2/5] pc: define PC_PCI_CONFIG_ADDR and PC_PCI_CONFIG_DATA

2014-11-04 Thread Hu Tao
PC_PCI_CONFIG_ADDR and PC_PCI_CONFIG_DATA are defined in PCI specification, so move them to common place. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/pci-host/piix.c| 8 hw/pci-host/q35.c | 8 include/hw/pci-host/q35.h | 3 --- include/hw/pci/pci.h

Re: [Qemu-devel] [PATCH v6 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2014-11-04 Thread Max Reitz
On 2014-10-30 at 04:22, Fam Zheng wrote: The new command pair is added to manage user created dirty bitmap. The dirty bitmap's name is mandatory and must be unique for the same device, but different devices can have bitmaps with the same names. Signed-off-by: Fam Zheng f...@redhat.com ---

Re: [Qemu-devel] [PATCH v2 0/4] block: Allow query stats for drive-mirror target

2014-11-04 Thread Max Reitz
On 2014-10-31 at 04:32, Fam Zheng wrote: v2: Add Max's and Eric's rev-by's for patch 1~3. Fix spelling, documentation and indentation on 4. Thanks, Max and Eric! This series adds an optional bool parameter query-nodes to query-blockstats. By default, if omitted, the behavior is

Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-11-04 Thread Markus Armbruster
Max Reitz mre...@redhat.com writes: On 2014-11-03 at 09:54, Markus Armbruster wrote: Kevin Wolf kw...@redhat.com writes: Am 31.10.2014 um 12:24 hat Stefan Hajnoczi geschrieben: On Thu, Oct 30, 2014 at 10:36:35AM +0100, Kevin Wolf wrote: Am 30.10.2014 um 10:27 hat Stefan Hajnoczi

[Qemu-devel] [RFC PATCH] virtio-mmio: support for multiple irqs

2014-11-04 Thread Shannon Zhao
As the current virtio-mmio only support single irq, so some advanced features such as vhost-net with irqfd are not supported. And the net performance is not the best without vhost-net and irqfd supporting. This patch support virtio-mmio to request multiple irqs like virtio-pci. With this patch

Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-11-04 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 31.10.2014 um 23:45 hat Eric Blake geschrieben: On 10/30/2014 06:49 AM, Markus Armbruster wrote: You either have to prevent *any* writing of the first 2048 bytes (the part that can be examined by a bdrv_probe() method, or your have to prevent

Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-11-04 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 30.10.2014 um 13:49 hat Markus Armbruster geschrieben: Kevin Wolf kw...@redhat.com writes: Am 29.10.2014 um 14:54 hat Markus Armbruster geschrieben: Kevin Wolf kw...@redhat.com writes: Instead, let me try once more to sell my old proposal [1] from

Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-11-04 Thread Markus Armbruster
Stefan Hajnoczi stefa...@redhat.com writes: On Mon, Nov 03, 2014 at 11:25:10AM +0100, Kevin Wolf wrote: Am 03.11.2014 um 09:54 hat Markus Armbruster geschrieben: Kevin Wolf kw...@redhat.com writes: Am 31.10.2014 um 12:24 hat Stefan Hajnoczi geschrieben: On Thu, Oct 30, 2014 at

Re: [Qemu-devel] [PATCH v6 03/10] block: Introduce bdrv_dirty_bitmap_granularity()

2014-11-04 Thread Max Reitz
On 2014-10-30 at 04:22, Fam Zheng wrote: This returns the granularity (in sectors) of dirty bitmap. Actually, it does not. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Benoit Canet ben...@irqsave.net --- block.c | 6 ++ include/block/block.h | 2 ++ 2 files

Re: [Qemu-devel] [PATCH v6 04/10] hbitmap: Add hbitmap_copy

2014-11-04 Thread Max Reitz
On 2014-10-30 at 04:22, Fam Zheng wrote: This makes a deep copy of an HBitmap. Signed-off-by: Fam Zheng f...@redhat.com --- include/qemu/hbitmap.h | 8 util/hbitmap.c | 16 2 files changed, 24 insertions(+) diff --git a/include/qemu/hbitmap.h

Re: [Qemu-devel] [PATCH v6 05/10] block: Add bdrv_copy_dirty_bitmap and bdrv_reset_dirty_bitmap

2014-11-04 Thread Max Reitz
On 2014-10-30 at 04:22, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 26 +- include/block/block.h | 4 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 1b12541..39381cd 100644 ---

Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-11-04 Thread Kevin Wolf
Am 03.11.2014 um 16:05 hat Stefan Hajnoczi geschrieben: On Mon, Nov 03, 2014 at 11:25:10AM +0100, Kevin Wolf wrote: Am 03.11.2014 um 09:54 hat Markus Armbruster geschrieben: Kevin Wolf kw...@redhat.com writes: Am 31.10.2014 um 12:24 hat Stefan Hajnoczi geschrieben: On Thu, Oct

Re: [Qemu-devel] [PATCH v6 06/10] qmp: Add block-dirty-bitmap-enable and block-dirty-bitmap-disable

2014-11-04 Thread Max Reitz
On 2014-10-30 at 04:22, Fam Zheng wrote: This allows to put the dirty bitmap into a disabled state where no more writes will be tracked. It will be used before backup or writing to persistent file. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 15 +++

Re: [Qemu-devel] [PATCH v4 22/47] QEMU_VM_CMD_PACKAGED: Send a packaged chunk of migration stream

2014-11-04 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: On Fri, Oct 03, 2014 at 06:47:28PM +0100, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com QEMU_VM_CMD_PACKAGED is a migration command that allows a chunk of migration stream to be sent in one go, and

Re: [Qemu-devel] [PATCH RFC 2/2] block: Warn on insecure format probing

2014-11-04 Thread Kevin Wolf
Am 04.11.2014 um 10:36 hat Markus Armbruster geschrieben: Kevin Wolf kw...@redhat.com writes: Am 31.10.2014 um 23:45 hat Eric Blake geschrieben: On 10/30/2014 06:49 AM, Markus Armbruster wrote: You either have to prevent *any* writing of the first 2048 bytes (the part that can be

Re: [Qemu-devel] [PATCH] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-04 Thread Stefano Stabellini
Feng, thanks for the email. I was assuming that one of the other maintainers would take care of the patch, but I am happy to submit a pull request for it too. Paolo, Michael? On Tue, 4 Nov 2014, Wu, Feng wrote: I still see this error in the latest QEMU. I find that this patch is not merged

[Qemu-devel] [PULL 0/5] gtk: fix fullscreen with gtk3, fix build with older gtk2 versions.

2014-11-04 Thread Gerd Hoffmann
949ca9e479c381a63ddb257adca1a6f0c44d898e: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2014-11-03 22:51:08 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-gtk-20141104-1 for you to fetch changes up to eb2380224ab743e5767aca7cee9cdb0016e03576

[Qemu-devel] [PULL 2/5] gtk: Install fullscreen accelerator on toplevel window

2014-11-04 Thread Gerd Hoffmann
From: Cole Robinson crobi...@redhat.com Instead of installing it on the menu. This will be needed to keep the fullscreen keyboard shortcut working when we hide the menu (in future patches). On gtk 3.8, this has the unfortunate side effect of no longer listing the key combo in the UI. We could

[Qemu-devel] [PULL 4/5] gtk: Hide the menubar when in fullscreen mode (lp 1294898)

2014-11-04 Thread Gerd Hoffmann
From: Cole Robinson crobi...@redhat.com In fullscreen mode, we attempt to shrink the menubar to 1 pixel in height, so it takes up as little room as possible while still allowing us to use the keyboard shortcuts for its various operations. However this shrinking is disregarded on gtk3, so the

[Qemu-devel] [PULL 1/5] gtk: Grab accel_group from GtkDisplayState

2014-11-04 Thread Gerd Hoffmann
From: Cole Robinson crobi...@redhat.com Rather than needlessly pass it around Signed-off-by: Cole Robinson crobi...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/ui/gtk.c

[Qemu-devel] [PULL 3/5] gtk: Install vc accelerators on parent window

2014-11-04 Thread Gerd Hoffmann
From: Cole Robinson crobi...@redhat.com So they are usable when we hide the menubar in upcoming patches. This has the accelerator text caveat as the fullscreen bit in the previous patch. Signed-off-by: Cole Robinson crobi...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c

[Qemu-devel] [PULL 5/5] gtk: add GDK_KEY_pause #define

2014-11-04 Thread Gerd Hoffmann
Add pause key to the list of compatibility defines. Fixes the build with older gtk versions. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/gtk.c b/ui/gtk.c index de564cc..2f3e716 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -128,6

[Qemu-devel] [PATCH v3 3/5] qemu-char: fix incorrect state in error message

2014-11-04 Thread zhanghailiang
It is either Failed _to_ do something, or something failed, but not failed something. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- qemu-char.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index

[Qemu-devel] [PATCH v3 0/5] Trivial patch about qemu-char

2014-11-04 Thread zhanghailiang
Patch 1 and 2 fix check about parameter in chr_parse_* functions. Patch 3 fix wrong english state in error message in windows part of the code. The last two patches convert some open functions to use Error API. In patch 4, i have tried to convert some codes which will be used in windows

[Qemu-devel] [PATCH v3 1/5] qemu-char: fix parameter check in some qemu_chr_parse_* functions

2014-11-04 Thread zhanghailiang
For some qemu_chr_parse_* functions, we just check whether the parameter is NULL or not, but do not check if it is empty. For example: qemu-system-x86_64 -chardev pipe,id=id,path= It will pass the check of NULL but will not find the error until trying to open it, while essentially missing and

[Qemu-devel] [PATCH v3 5/5] spice-qemu-char: convert some functions to use Error API

2014-11-04 Thread zhanghailiang
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- include/ui/qemu-spice.h | 2 +- qemu-char.c | 2 +- spice-qemu-char.c | 12 ++-- stubs/qemu-chr-open-spice.c | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH v3 4/5] qemu-char: convert some open functions to use Error API

2014-11-04 Thread zhanghailiang
Convert several Character backend open functions to use the Error API. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- qemu-char.c | 76 + 1 file changed, 41 insertions(+), 35 deletions(-) diff --git a/qemu-char.c

[Qemu-devel] [PATCH v3 2/5] spice-qemu-char: fix parameter checks in qemu_chr_parse_* functions

2014-11-04 Thread zhanghailiang
For functions qemu_chr_parse_spice_vmc and qemu_chr_parse_spice_port, we should also check if parameter name is empty, and it will help finding the wrong configure, such as 'qemu-system-x86_64 -chardev spiceport(or spiceport),id=id,name=' After check the parameter in parse function, we can remove

Re: [Qemu-devel] [PATCH v6 07/10] qmp: Add support of dirty-bitmap sync mode for drive-backup

2014-11-04 Thread Max Reitz
On 2014-10-30 at 04:22, Fam Zheng wrote: For dirty-bitmap sync mode, the block job will iterate through the given dirty bitmap to decide if a sector needs backup (backup all the dirty clusters and skip clean ones), just as allocation conditions of top sync mode. There are two bitmap use modes

Re: [Qemu-devel] [PATCH v6 08/10] qapi: Add transaction support to block-dirty-bitmap-{add, enable, disable}

2014-11-04 Thread Max Reitz
On 2014-10-30 at 04:22, Fam Zheng wrote: This adds three qmp commands to transactions. Users can stop a dirty bitmap, start backup of it, and start another dirty bitmap atomically, so that the dirty bitmap is tracked incrementally and we don't miss any write. Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH v6 09/10] qmp: Add dirty bitmap 'enabled' field in query-block

2014-11-04 Thread Max Reitz
On 2014-10-30 at 04:22, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 1 + qapi/block-core.json | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index e574faa..f4d145c 100644 --- a/block.c +++ b/block.c @@

Re: [Qemu-devel] [PATCH v6 10/10] qemu-iotests: Add tests for drive-backup sync=dirty-bitmap

2014-11-04 Thread Max Reitz
On 2014-10-30 at 04:22, Fam Zheng wrote: Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/056| 33 ++--- tests/qemu-iotests/056.out| 4 ++-- tests/qemu-iotests/iotests.py | 8 3 files changed, 40 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH] console: remove refresh timer when using spice QXL mode

2014-11-04 Thread Marc-André Lureau
There is no need for the display refresh timer when using Spice with QXL driver. The refresh is restored when entering VGA mode, or if any other display listener requires refresh. This saves a few wakeups per seconds. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=912763 Signed-off-by:

[Qemu-devel] [PATCH v7] numa: make 'info numa' take into account hotplugged memory

2014-11-04 Thread zhanghailiang
When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. It affects the result of hmp command info numa. Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- Hi Luiz, This patch

Re: [Qemu-devel] [PULL 5/5] gtk: add GDK_KEY_pause #define

2014-11-04 Thread Cornelia Huck
On Tue, 4 Nov 2014 11:41:11 +0100 Gerd Hoffmann kra...@redhat.com wrote: Add pause key to the list of compatibility defines. Fixes the build with older gtk versions. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Qemu-devel] [PATCH 1/5] target-arm/translate.c: Use arm_dc_feature() in ENABLE_ARCH_ macros

2014-11-04 Thread Peter Maydell
On 4 November 2014 09:04, Claudio Fontana claudio.font...@huawei.com wrote: On 28.10.2014 20:24, Peter Maydell wrote: nit: the line for ENABLE_ARCH_6K seems to be differently aligned than the rest. Reviewed-by: Claudio Fontana claudio.font...@huawei.com Thanks; I fixed the missing space.

Re: [Qemu-devel] Better Cortex-M support?

2014-11-04 Thread Fabien Chouteau
On 10/28/2014 11:43 AM, Liviu Ionescu wrote: Hi! I'm currently maintaining the GNU ARM Eclipse plug-ins (http://gnuarmeclipse.livius.net/blog/), and I'm considering, for the mid-term future, adding a new debugging plug-in to run certain tests under un emulator, and the first choice was

Re: [Qemu-devel] Better Cortex-M support?

2014-11-04 Thread Alistair Francis
On Tue, Nov 4, 2014 at 10:05 PM, Fabien Chouteau chout...@adacore.com wrote: On 10/28/2014 11:43 AM, Liviu Ionescu wrote: Hi! I'm currently maintaining the GNU ARM Eclipse plug-ins (http://gnuarmeclipse.livius.net/blog/), and I'm considering, for the mid-term future, adding a new debugging

[Qemu-devel] [PATCH 0/2] s390x: virtio-less ccw target enablement

2014-11-04 Thread Alexander Graf
Hi, With these two patches I'm able to boot a kernel with -M s390-ccw and TCG. So far the actual CCW instruction interpretation is missing, so it won't get any further than an initrd, but at least it's a start ;). Alex Alexander Graf (2): s390x: Fix sclp console input s390x: Ignore sam31

[Qemu-devel] [PATCH 2/2] s390x: Ignore sam31

2014-11-04 Thread Alexander Graf
The SAM31 instruction switches the memory model to 31bit. Linux uses it on bootup, so we have to implement it. We only really model the 64bit memory model though, so we can nop it, cross our fingers and hope for the guest to not rely on 32bit wrap semantics. Signed-off-by: Alexander Graf

[Qemu-devel] [PATCH 1/2] s390x: Fix sclp console input

2014-11-04 Thread Alexander Graf
When injecting an sclp console interrupt into the guest, we increase the PC by 4 for some reason. I have no idea why I put that code there, but it's clearly wrong. Remove the increment. This patch fixes sclp serial input for the ccw machine. Signed-off-by: Alexander Graf ag...@suse.de ---

[Qemu-devel] [PULL 2/7] target-arm/translate.c: Use arm_dc_feature() rather than arm_feature()

2014-11-04 Thread Peter Maydell
Use arm_dc_feature() rather than arm_feature() to avoid using CPUARMState unnecessarily. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Alex Bennée alex.ben...@linaro.org Message-id: 1414524244-20316-3-git-send-email-peter.mayd...@linaro.org Reviewed-by: Claudio Fontana

[Qemu-devel] [PULL 7/7] target-arm: Correct condition for taking VIRQ and VFIQ

2014-11-04 Thread Peter Maydell
The VIRQ and VFIQ exceptions are (as the comments say) only taken if the CPU is in Non-secure state and the IMO/FMO bits are set to enable virtualized interrupts. Correct the code to actually implement this. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Edgar E. Iglesias

[Qemu-devel] [PULL 4/7] target-arm/translate.c: Don't pass CPUARMState around in the decoder

2014-11-04 Thread Peter Maydell
Passing the CPUARMState around in the decoder is a recipe for bugs where we accidentally generate code that depends on CPU state which isn't reflected in the TB flags. Stop doing this and instead use DisasContext as a way to pass around those bits of CPU state which are known to be safe to use.

[Qemu-devel] [PULL 5/7] target-arm/translate.c: Don't pass CPUARMState * to disas_arm_insn()

2014-11-04 Thread Peter Maydell
Refactor to avoid passing a CPUARMState * to disas_arm_insn(). To do this we move the read insn from memory code to the callsite and pass the insn to the function instead. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Alex Bennée alex.ben...@linaro.org Message-id:

[Qemu-devel] [PULL 6/7] target-arm: Separate out M profile cpu_exec_interrupt handling

2014-11-04 Thread Peter Maydell
The M profile cpu_exec_interrupt handling is fairly simple but does include an M profile specific oddity (disabling interrupts for certain PC values). A/R profile handling on the other hand is getting rapidly more complicated with the support for EL2 and EL3. Split the M profile code out into its

[Qemu-devel] [PULL 1/7] target-arm/translate.c: Use arm_dc_feature() in ENABLE_ARCH_ macros

2014-11-04 Thread Peter Maydell
All the places where we use the ENABLE_ARCH_* and ARCH() macros have a DisasContext* s, so switch them over to use arm_dc_feature() rather than arm_feature() so we don't need to pass the CPUARMState* env around too. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Alex Bennée

[Qemu-devel] [PULL 3/7] target-arm/translate.c: Don't use IS_M()

2014-11-04 Thread Peter Maydell
Instead of using IS_M(), use arm_dc_feature(s, ARM_FEATURE_M), so we don't need to pass CPUARMState pointers around the decoder. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Alex Bennée alex.ben...@linaro.org Message-id:

[Qemu-devel] [PULL 0/7] target-arm queue

2014-11-04 Thread Peter Maydell
'remotes/mst/tags/for_upstream' into staging (2014-11-03 22:51:08 +) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20141104 for you to fetch changes up to 9fae24f55496ea178e9e8e351f82a02f34ddaf4d: target-arm: Correct

Re: [Qemu-devel] [PULL 00/34] target-mips queue

2014-11-04 Thread Peter Maydell
On 3 November 2014 16:11, Leon Alrae leon.al...@imgtec.com wrote: Hi, This pull request contains remaining MIPS patches which are on the mailing list for a long time. I think it is worth putting them into stable 2.2 version as these two significant MIPS features are already tested, moreover

Re: [Qemu-devel] [PATCH v2 4/4] qmp: Add optional switch query-nodes in query-blockstats

2014-11-04 Thread Fam Zheng
On Tue, 11/04 09:54, Max Reitz wrote: On 2014-10-31 at 04:32, Fam Zheng wrote: This bool option will allow query all the node names. It iterates all the BDSes that are assigned a name, also in this case don't query up the backing chain. Signed-off-by: Fam Zheng f...@redhat.com ---

[Qemu-devel] [PATCH 0/4] ioeventfd support for virtio-mmio

2014-11-04 Thread Shannon Zhao
Add host/guest notifiers support for virtio-mmio, so that qemu can enable vhost-net for kvm-arm. Refer to the patches from Ying-Shiuan Pan https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg00715.html As vhost-net can improve the net performance by about 30%, so I think it's necessary to

[Qemu-devel] [PATCH 2/4] virtio-mmio: introduce set_guest_notifiers

2014-11-04 Thread Shannon Zhao
Same as host notifier of virtio-mmio, most of codes came from virtio-pci. The kvm-arm does not yet support irqfd, need to fix the hard-coded part after kvm-arm gets irqfd support. Signed-off-by: Ying-Shiuan Pan yingshiuan@gmail.com Signed-off-by: Li Liu john.li...@huawei.com Signed-off-by:

[Qemu-devel] [PATCH 4/4] virtio-mmio: add a new property for ioeventfd

2014-11-04 Thread Shannon Zhao
Make ioeventfd could be enabled or disabled (default). Since ioeventfd is not yet ready in kvm-arm, without this option, qemu will get a problem if it attempts to initialize ioeventfd. Signed-off-by: Ying-Shiuan Pan yingshiuan@gmail.com Signed-off-by: Li Liu john.li...@huawei.com

[Qemu-devel] [PATCH 1/4] virtio-mmio: introduce set_host_notifier()

2014-11-04 Thread Shannon Zhao
set_host_notifier() is introduced into virtio-mmio now. Most of codes came from virtio-pci. Signed-off-by: Ying-Shiuan Pan yingshiuan@gmail.com Signed-off-by: Li Liu john.li...@huawei.com Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com --- hw/virtio/virtio-mmio.c | 70

[Qemu-devel] [PATCH 3/4] virtio-mmio: start ioeventfd when status gets DRIVER_OK

2014-11-04 Thread Shannon Zhao
Signed-off-by: Ying-Shiuan Pan yingshiuan@gmail.com Signed-off-by: Li Liu john.li...@huawei.com Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com --- hw/virtio/virtio-mmio.c | 45 + 1 files changed, 45 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PULL 0/5] gtk: fix fullscreen with gtk3, fix build with older gtk2 versions.

2014-11-04 Thread Peter Maydell
On 4 November 2014 10:41, Gerd Hoffmann kra...@redhat.com wrote: Hi, Here comes the gtk patch queue, featuring a buildfix for older gtk2 versions. And thanks to Cole we finally have the menu bar still being visible in fullscreen mode (fully in gtk3, thin line in gtk2) fixed. Yay! please

Re: [Qemu-devel] [PATCH v3 1/5] qemu-char: fix parameter check in some qemu_chr_parse_* functions

2014-11-04 Thread Alex Bennée
zhanghailiang zhang.zhanghaili...@huawei.com writes: For some qemu_chr_parse_* functions, we just check whether the parameter is NULL or not, but do not check if it is empty. For example: qemu-system-x86_64 -chardev pipe,id=id,path= It will pass the check of NULL but will not find the

Re: [Qemu-devel] [PATCH v3 2/5] spice-qemu-char: fix parameter checks in qemu_chr_parse_* functions

2014-11-04 Thread Alex Bennée
zhanghailiang zhang.zhanghaili...@huawei.com writes: For functions qemu_chr_parse_spice_vmc and qemu_chr_parse_spice_port, we should also check if parameter name is empty, and it will help finding the wrong configure, such as 'qemu-system-x86_64 -chardev spiceport(or spiceport),id=id,name='

Re: [Qemu-devel] [question] updating the base image for all clones which havebeen running for months

2014-11-04 Thread Eric Blake
On 11/03/2014 01:37 PM, Zhang Haoyu wrote: Hi, all I used base image A to clone so many vm, after running for months, each vm has its own private applications and data, which maybe different from each other. Now, I want to install some applications for all of the clones, what should I do?

Re: [Qemu-devel] [PATCH v3 3/5] qemu-char: fix incorrect state in error message

2014-11-04 Thread Alex Bennée
zhanghailiang zhang.zhanghaili...@huawei.com writes: It is either Failed _to_ do something, or something failed, but not failed something. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Semantically I'm fine to add: Reviewed-by: Alex Bennée alex.ben...@linaro.org I'll leave

Re: [Qemu-devel] [PATCH] qemu-doc.texi: fix typos for x509 examples

2014-11-04 Thread Eric Blake
On 11/03/2014 01:48 PM, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com Fix typos made people confuesd: Spelling: s/confuesd/confused/ Grammar: would read better as: Fix typos that caused confusion for some people: -- Eric Blake eblake redhat com+1-919-301-3266

Re: [Qemu-devel] [PULL 0/5] gtk: fix fullscreen with gtk3, fix build with older gtk2 versions.

2014-11-04 Thread Gerd Hoffmann
On Di, 2014-11-04 at 12:57 +, Peter Maydell wrote: On 4 November 2014 10:41, Gerd Hoffmann kra...@redhat.com wrote: Hi, Here comes the gtk patch queue, featuring a buildfix for older gtk2 versions. And thanks to Cole we finally have the menu bar still being visible in fullscreen

Re: [Qemu-devel] [PULL 5/5] gtk: add GDK_KEY_pause #define

2014-11-04 Thread Alexander Graf
On 04.11.14 12:51, Cornelia Huck wrote: On Tue, 4 Nov 2014 11:41:11 +0100 Gerd Hoffmann kra...@redhat.com wrote: Add pause key to the list of compatibility defines. Fixes the build with older gtk versions. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c | 1 + 1 file

Re: [Qemu-devel] [PATCH v3 4/5] qemu-char: convert some open functions to use Error API

2014-11-04 Thread Alex Bennée
zhanghailiang zhang.zhanghaili...@huawei.com writes: Convert several Character backend open functions to use the Error API. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com --- qemu-char.c | 76 + 1 file changed, 41

Re: [Qemu-devel] [PATCH v3 5/5] spice-qemu-char: convert some functions to use Error API

2014-11-04 Thread Alex Bennée
zhanghailiang zhang.zhanghaili...@huawei.com writes: Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com snip -CharDriverState *qemu_chr_open_spice_vmc(const char *type) +CharDriverState *qemu_chr_open_spice_vmc(const char *type, Error **errp) { snip diff --git

Re: [Qemu-devel] [PATCH 1/5] pci: introduce PC_PCI_CONFIG_ENABLED()

2014-11-04 Thread Marcel Apfelbaum
Hi, On Tue, 2014-11-04 at 17:12 +0800, Hu Tao wrote: This makes code more readable. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/mips/gt64xxx_pci.c | 4 ++-- hw/pci/pci_host.c | 5 +++-- include/hw/pci/pci.h | 2 ++ 3 files changed, 7 insertions(+), 4 deletions(-) diff

Re: [Qemu-devel] [PULL] OpenBIOS updates for 2.2

2014-11-04 Thread Peter Maydell
On 4 November 2014 00:42, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: Hi Peter, Apologies for the last minute nature of the pull request (I've been away), however this is an OpenBIOS update in preparation for the 2.2 release. Please pull. ATB, Mark. The following changes

Re: [Qemu-devel] [PATCH 2/5] pc: define PC_PCI_CONFIG_ADDR and PC_PCI_CONFIG_DATA

2014-11-04 Thread Marcel Apfelbaum
On Tue, 2014-11-04 at 17:12 +0800, Hu Tao wrote: PC_PCI_CONFIG_ADDR and PC_PCI_CONFIG_DATA are defined in PCI specification, so move them to common place. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/pci-host/piix.c| 8 hw/pci-host/q35.c | 8

[Qemu-devel] [PULL v2 0/5] gtk: fix fullscreen with gtk3, fix build with older gtk2 versions.

2014-11-04 Thread Gerd Hoffmann
commit 949ca9e479c381a63ddb257adca1a6f0c44d898e: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2014-11-03 22:51:08 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-gtk-20141104-2 for you to fetch changes up

[Qemu-devel] [PULL v2 2/5] gtk: Install fullscreen accelerator on toplevel window

2014-11-04 Thread Gerd Hoffmann
From: Cole Robinson crobi...@redhat.com Instead of installing it on the menu. This will be needed to keep the fullscreen keyboard shortcut working when we hide the menu (in future patches). On gtk 3.8, this has the unfortunate side effect of no longer listing the key combo in the UI. We could

[Qemu-devel] [PULL v2 4/5] gtk: Hide the menubar when in fullscreen mode (lp 1294898)

2014-11-04 Thread Gerd Hoffmann
From: Cole Robinson crobi...@redhat.com In fullscreen mode, we attempt to shrink the menubar to 1 pixel in height, so it takes up as little room as possible while still allowing us to use the keyboard shortcuts for its various operations. However this shrinking is disregarded on gtk3, so the

[Qemu-devel] [PULL v2 5/5] gtk: add GDK_KEY_pause #define

2014-11-04 Thread Gerd Hoffmann
Add pause key to the list of compatibility defines. Fixes the build with older gtk versions. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/gtk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/gtk.c b/ui/gtk.c index de564cc..38bf463 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -128,6

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-04 Thread Michael S. Tsirkin
On Tue, Nov 04, 2014 at 12:17:29AM +, Peter Maydell wrote: On 3 November 2014 16:35, Michael S. Tsirkin m...@redhat.com wrote: OK I backed that patch out and re-pushed. As other patches are unchanged, I don't want to re-do the pull request, it's just spam on list. Tag name is still

[Qemu-devel] [PATCH 0/3] Additional s390x fixes for 2.2

2014-11-04 Thread Cornelia Huck
Three further fixes going on top of what I sent in 1415025034-24918-1-git-send-email-cornelia.h...@de.ibm.com, this time dealing with the sclp consoles (line mode and ascii). I plan to send a pull request with all five patches tomorrow. Heinz Graalfs (3): s390x/sclpconsole-lm: truncate input

[Qemu-devel] [PATCH 2/3] s390x/sclpconsole-lm: Fix hanging SCLP line mode console

2014-11-04 Thread Cornelia Huck
From: Heinz Graalfs graa...@linux.vnet.ibm.com Trigger recalculating sets of file descriptors for the main loop's poll() in order to make sure a possibly removed FD 0 from the poll() file descriptor array is re-added. FD 0 is removed from the decriptor array when the console's can_read() callback

[Qemu-devel] [PATCH 1/3] s390x/sclpconsole-lm: truncate input if line is too long

2014-11-04 Thread Cornelia Huck
From: Heinz Graalfs graa...@linux.vnet.ibm.com As the SCLP line mode console input length is limited by the available SCCB buffer space, it might lock up if the input does not fit into the buffer. With this patch, characters that don't fit are 'eaten' up to the next CR/LF and the input line is

[Qemu-devel] [PATCH 3/3] s390x/sclpconsole: Avoid hanging SCLP ASCII console

2014-11-04 Thread Cornelia Huck
From: Heinz Graalfs graa...@linux.vnet.ibm.com Force recalculation of file descriptor sets for main loop's poll(), in order to be able to readd a possibly removed input file descriptor after can_read() returned 0 (zero). Signed-off-by: Heinz Graalfs graa...@linux.vnet.ibm.com Reviewed-by: David

Re: [Qemu-devel] [PATCH] pc: piix4_pm: init legacy PCI hotplug when running on Xen

2014-11-04 Thread Paolo Bonzini
On 04/11/2014 11:36, Stefano Stabellini wrote: Feng, thanks for the email. I was assuming that one of the other maintainers would take care of the patch, but I am happy to submit a pull request for it too. Paolo, Michael? I think this patch is not okay, because Xen does use fw_cfg when

Re: [Qemu-devel] [PATCH] console: remove refresh timer when using spice QXL mode

2014-11-04 Thread Gerd Hoffmann
On Di, 2014-11-04 at 12:23 +0100, Marc-André Lureau wrote: There is no need for the display refresh timer when using Spice with QXL driver. No, there is a need. Cursor updates (when running qxl with other ui than spice) are done from the refresh timer. Also we can already adjust the wakeup

[Qemu-devel] [PATCH 2/2] spice: reduce refresh rate in native mode

2014-11-04 Thread Gerd Hoffmann
Now that cursor updates are out of the way qxl needs the refresh timer only when when running in vga mode, for dirty bitmap checking. In native qxl mode the guest will notify us, so we don't need to poll and can use the idle interval (one refresh wakeup every few seconds). Cc: Marc-André Lureau

[Qemu-devel] [PATCH 1/2] spice: use bottom half instead of refresh timer for cursor updates

2014-11-04 Thread Gerd Hoffmann
Calling directly doesn't work due to the qxl-render code running in spice server thread context. Meanwhile bottom half scheduling is thread-safe though, so we can use that to kick a cursor update in main i/o thread context. Cc: Marc-André Lureau marcandre.lur...@gmail.com Signed-off-by: Gerd

  1   2   3   >