* Paolo Bonzini (pbonz...@redhat.com) wrote:
On 19/11/2014 15:26, Dr. David Alan Gilbert wrote:
* Paolo Bonzini (pbonz...@redhat.com) wrote:
On 19/11/2014 15:13, Dr. David Alan Gilbert wrote:
Since we've wondered off the actual ACPI table stuff into general
ROM sizing, I'd like to
On Wed, 19 Nov 2014 14:40:07 +
Peter Maydell peter.mayd...@linaro.org wrote:
On 19 November 2014 14:01, Ekaterina Tumanova
tuman...@linux.vnet.ibm.com wrote:
Signed-off-by: Ekaterina Tumanova tuman...@linux.vnet.ibm.com
Could you give the compiler error/warning message, please
(and
On 2014-10-29 17:03, Nikita Belov wrote:
Variable 'ram_lo' is allocated unconditionally, but used only in some
cases.
When it is unused pointer will be lost at function exit, resulting in
a
memory leak. Free memory in this case.
Valgrind output:
==16879== 240 bytes in 1 blocks are definitely
On Wed, Nov 19, 2014 at 01:58:54PM +, Peter Maydell wrote:
On 17 November 2014 20:08, Michael S. Tsirkin m...@redhat.com wrote:
Add API to manage on-device RAM.
This looks just like regular RAM from migration POV,
but has two special properties internally:
- it is never exposed
On 19 November 2014 15:05, Nikita Belov zod...@ispras.ru wrote:
ping
Not for 2.2, and I'm still not really convinced in
general that it's worthwhile at all.
thanks
-- PMM
On Wed, Nov 19, 2014 at 02:10:36PM +, Peter Maydell wrote:
On 19 November 2014 14:07, Juan Quintela quint...@redhat.com wrote:
My understanding is that it is a trick. We have internal memory for a
device that is needed for the emulation, but not showed to the guest.
And it is big
On Wed, 19 Nov 2014 12:32:46 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Mon, Nov 17, 2014 at 01:11:08PM +0800, zhanghailiang wrote:
The global parameter 'ram_size' does not take into account
the hotplugged memory.
In some codes, we use 'ram_size' as current VM's real RAM size,
On Wed, Nov 19, 2014 at 03:30:59PM +0100, Paolo Bonzini wrote:
On 19/11/2014 15:21, Peter Maydell wrote:
But in any case this is really just memory that is auto-resized on
migration. And it can work even if it is mapped in memory, as long as
your resize callback (or some post_load
Hi,
It seems the chardev stuff is in spice server since 0.9.
commit 7bbc2ba090788d844573e044041480ff6e3cba7b
Author: Gerd Hoffmann kra...@redhat.com
Date: Tue Dec 14 12:56:15 2010 +0100
move chardevs out of experimental
Also, in 0.10, 2 migration functions got moved to spice.h
commit
On Wed, Nov 19, 2014 at 03:41:23PM +0100, Paolo Bonzini wrote:
On 19/11/2014 14:52, Peter Maydell wrote:
It certainly seems pretty risky to introduce this change with
only two weeks to go til release; I wouldn't want to merge it
without a strong consensus from everybody involved that it
On Wed, Nov 19, 2014 at 02:59:12PM +, Dr. David Alan Gilbert wrote:
* Paolo Bonzini (pbonz...@redhat.com) wrote:
On 19/11/2014 15:26, Dr. David Alan Gilbert wrote:
* Paolo Bonzini (pbonz...@redhat.com) wrote:
On 19/11/2014 15:13, Dr. David Alan Gilbert wrote:
Since
On Wed, Nov 19, 2014 at 03:20:07PM +0100, Juan Quintela wrote:
Paolo Bonzini pbonz...@redhat.com wrote:
On 19/11/2014 15:03, Juan Quintela wrote:
Paolo Bonzini pbonz...@redhat.com wrote:
On 19/11/2014 14:49, Juan Quintela wrote:
Real hardware lets users update firmware and so should
Il 19/11/2014 15:56, Don Slutz ha scritto:
I think I know what is happening here. But you are pointing at the
wrong change.
commit 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
Is what I am guessing at this time is the issue. I think that
xen_enabled() is
returning false in pc_machine_initfn.
On 11/19/2014 07:54 AM, Paolo Bonzini wrote:
On 19/11/2014 13:07, Prof. Dr. Michael Schefczyk wrote:
Yes! My level of knowledge is that one uses the qcow2 format in order
to be able to create live snapshots/backups. Otherwise one would tend
to use the more efficient raw format. Is this not
On Wed, Nov 19, 2014 at 02:51:38PM +0100, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Nov 19, 2014 at 11:50:28AM +0100, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Nov 19, 2014 at 11:16:57AM +0100, Markus Armbruster wrote:
Michael S.
On 11/19/2014 08:13 AM, Luiz Capitulino wrote:
On Wed, 19 Nov 2014 12:32:46 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Mon, Nov 17, 2014 at 01:11:08PM +0800, zhanghailiang wrote:
The global parameter 'ram_size' does not take into account
the hotplugged memory.
In some codes, we
On Tue, Nov 18, 2014 at 03:12:12AM -0500, Francesco Romani wrote:
+static int coroutine_fn before_write_notify(NotifierWithReturn *notifier,
+void *opaque)
+{
+BdrvTrackedRequest *req = opaque;
+BlockDriverState *bs = req-bs;
+
On Wed, 19 Nov 2014, Fabio Fantoni wrote:
Il 19/11/2014 15:56, Don Slutz ha scritto:
I think I know what is happening here. But you are pointing at the wrong
change.
commit 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
Is what I am guessing at this time is the issue. I think that
* Michael S. Tsirkin (m...@redhat.com) wrote:
On Wed, Nov 19, 2014 at 02:59:12PM +, Dr. David Alan Gilbert wrote:
* Paolo Bonzini (pbonz...@redhat.com) wrote:
On 19/11/2014 15:26, Dr. David Alan Gilbert wrote:
* Paolo Bonzini (pbonz...@redhat.com) wrote:
On
Hi,
Vhost-net backend tap, implements read and write polls to listen for
packets in guest vrings (implemented through ioeventfds) and gives direct
access to the guest vrings.
While transmitting the packet up to VM, tap backend uses
qemu_send_packet_async/ NetClient APIs to transmit the packets
On Wed, Nov 19, 2014 at 02:52:43PM +0100, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Nov 19, 2014 at 01:52:35PM +0530, Amit Shah wrote:
On (Wed) 19 Nov 2014 [10:15:16], Michael S. Tsirkin wrote:
On Wed, Nov 19, 2014 at 01:01:14PM +0530, Amit Shah wrote:
On
On Wed, Nov 19, 2014 at 08:52:19AM -0700, Eric Blake wrote:
On 11/19/2014 08:13 AM, Luiz Capitulino wrote:
On Wed, 19 Nov 2014 12:32:46 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Mon, Nov 17, 2014 at 01:11:08PM +0800, zhanghailiang wrote:
The global parameter 'ram_size' does
On Wed, Nov 19, 2014 at 03:18:01PM +0100, Juan Quintela wrote:
Peter Maydell peter.mayd...@linaro.org wrote:
On 19 November 2014 14:07, Juan Quintela quint...@redhat.com wrote:
My understanding is that it is a trick. We have internal memory for a
device that is needed for the emulation,
On Wed, Nov 05, 2014 at 10:57:09AM +0800, Fam Zheng wrote:
+void qmp_blockdev_backup(const char *device, const char *target,
+ enum MirrorSyncMode sync,
+ bool has_speed, int64_t speed,
+ bool has_on_source_error,
+
On Wed, Nov 19, 2014 at 02:44:32PM +0100, Paolo Bonzini wrote:
So:
qemu-2.0 -M pc-2.0 - qemu-2.2 -M pc-2.0
uses 2.0 BIOS
qemu-2.2 -M pc-2.0 - qemu-2.0 -M pc-2.0
uses 2.2 BIOS
Both should work, in general. BIOS is rarely the reason for
incompatibilities. However, breakage
On 11/19/2014 09:06 AM, Michael S. Tsirkin wrote:
This affects QMP right?
I think later patches will tell how. CC'ing Eric.
As far as I can tell, this is just correcting a reporting issue; the
existing QMP commands/events for tracking balloon size will now properly
account for hotplugged
Paolo Bonzini pbonz...@redhat.com wrote:
On 19/11/2014 14:57, Juan Quintela wrote:
Shipping a separate BIOS for different machine types is unrealistic and
pointless. It would also be a good terrain for bug reports, unless you
also do things like forbid creating -device megasas-gen2 on 2.1
Paolo Bonzini pbonz...@redhat.com wrote:
On 19/11/2014 14:52, Peter Maydell wrote:
It certainly seems pretty risky to introduce this change with
only two weeks to go til release; I wouldn't want to merge it
without a strong consensus from everybody involved that it
really needed to go in for
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Nov 19, 2014 at 02:51:38PM +0100, Juan Quintela wrote:
Actually yes: devices that want this functionality need to call
the new API.
At the point where API is called, would be the best place to
put in an explanation why it should be
Paolo Bonzini pbonz...@redhat.com wrote:
On 19/11/2014 15:10, Peter Maydell wrote:
It does already, for example PPC uses it for its IOMMU tables.
But in any case this is really just memory that is auto-resized on
migration. And it can work even if it is mapped in memory, as long as
your
On 19/11/2014 17:39, Juan Quintela wrote:
Paolo Bonzini pbonz...@redhat.com wrote:
On 19/11/2014 14:57, Juan Quintela wrote:
Shipping a separate BIOS for different machine types is unrealistic and
pointless. It would also be a good terrain for bug reports, unless you
also do things like
On 19/11/2014 17:27, Kevin O'Connor wrote:
On Wed, Nov 19, 2014 at 02:44:32PM +0100, Paolo Bonzini wrote:
So:
qemu-2.0 -M pc-2.0 - qemu-2.2 -M pc-2.0
uses 2.0 BIOS
qemu-2.2 -M pc-2.0 - qemu-2.0 -M pc-2.0
uses 2.2 BIOS
Both should work, in general. BIOS is rarely the reason for
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Mon, Nov 03, 2014 at 01:22:45PM +, Dr. David Alan Gilbert wrote:
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:22PM +0100, Dr. David Alan Gilbert (git)
wrote:
From: Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Mon, Nov 03, 2014 at 03:53:03PM +0200, Cristian Klein wrote:
On 03 Nov 2014, at 5:12 , David Gibson da...@gibson.dropbear.id.au wrote:
On Fri, Oct 03, 2014 at 06:47:18PM +0100, Dr. David Alan Gilbert (git)
wrote:
From: Cristian
Make sure the address space is unconditionally wrapped on 32-bit
processors, that is ones that do not implement at least the MIPS III
ISA.
Also make MIPS16 SAVE and RESTORE instructions use address calculation
rather than plain arithmetic operations for stack pointer manipulation
so that
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does not return the correct value in
pc_machine_initfn() so add vmport=off to xenfv machine to correctly
turn
Dear Eric, dear all,
Again, thank you very much. I now gather that I took the wrong path towards
nightly backups of running VM. I remain surprised that I did work for a
relatively long time.
A major book on KVM in German language by Kofler Spenneberg recommends the
following approach for
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:24PM +0100, Dr. David Alan Gilbert (git) wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Misses out lines that are all the expected value so the output
can be quite compact depending on the
On 19/11/2014 18:30, Don Slutz wrote:
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does not return the correct value in
pc_machine_initfn() so
Hi Anshul,
On Wednesday, November 19, 2014, Anshul Makkar
anshul.mak...@profitbricks.com wrote:
I have implemented a usermode app that is using vhost-user backend and
gets direct access to the guest vrings. I am able to receive packets but
when I post directly to vring and issue kick,
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:25PM +0100, Dr. David Alan Gilbert (git) wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Postcopy needs to have two migration streams loading concurrently;
one from memory (with the device state)
I have posted the patch:
Subject: [BUGFIX][PATCH for 2.2 1/1] hw/i386/pc_piix.c: Also pass vmport=off
for xenfv machine
Date: Wed, 19 Nov 2014 12:30:57 -0500
Message-ID: 1416418257-10166-1-git-send-email-dsl...@verizon.com
Which fixes QEMU 2.2 for xenfv. However if you configure
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:30PM +0100, Dr. David Alan Gilbert (git) wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Use that to split the qemu_savevm_state_pending counts into postcopiable
and non-postcopiable amounts
On 11/19/14 12:35, Paolo Bonzini wrote:
On 19/11/2014 18:30, Don Slutz wrote:
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does not return the correct
On 19/11/2014 19:07, Don Slutz wrote:
-M pc -machine accel=xen should work and, if that's what you want,
disable the vmport device. I think this patch is wrong.
Paolo
Well, I also want -M pc -machine accel=xen,vmport=on to work.
Right. So let's start by deciding what the desired
On 11/19/2014 10:32 AM, Prof. Dr. Michael Schefczyk wrote:
Dear Eric, dear all,
Again, thank you very much. I now gather that I took the wrong path towards
nightly backups of running VM. I remain surprised that I did work for a
relatively long time.
[can you convince your mailer to wrap
On Wed, 19 Nov 2014, Don Slutz wrote:
I have posted the patch:
Subject: [BUGFIX][PATCH for 2.2 1/1] hw/i386/pc_piix.c: Also pass vmport=off
for xenfv machine
Date: Wed, 19 Nov 2014 12:30:57 -0500
Message-ID: 1416418257-10166-1-git-send-email-dsl...@verizon.com
Which fixes QEMU 2.2 for
On 19/11/2014 17:45, Juan Quintela wrote:
Absolutely. And that is why callers get a callback notifying them about
resize.
See? You are arriving at my design step by step :)
Then why we ever wonder about assingning the space on the 1st place?
Just got it from the migration stream?
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:35PM +0100, Dr. David Alan Gilbert (git) wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
The PMI holds the state of each page on the incoming side,
so that we can tell if the page is missing,
Hi Zhang,
On Fri, Oct 31, 2014 at 09:26:09AM +0800, zhanghailiang wrote:
On 2014/10/30 20:49, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
On 2014/10/30 1:46, Andrea Arcangeli wrote:
Hi Zhanghailiang,
On Mon, Oct 27, 2014 at 05:32:51PM +0800,
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:40PM +0100, Dr. David Alan Gilbert (git) wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
This could do with a bit more rationale in the commit message.
Also is there a reason not to fold this with
Hello,
I bump this set of patches to the top, to make sure they are not lost.
I would appreciate if someone could take a look at them and provide some
feedback.
Many thanks in advance.
Best regards,
Jaume
On Sat, Nov 15, 2014 at 12:30 PM, Jaume Marti Farriol
jaume.mar...@gmail.com wrote:
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:38PM +0100, Dr. David Alan Gilbert (git) wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com
---
include/migration/migration.h| 2 ++
On 11/19/14 13:08, Paolo Bonzini wrote:
On 19/11/2014 19:07, Don Slutz wrote:
-M pc -machine accel=xen should work and, if that's what you want,
disable the vmport device. I think this patch is wrong.
Paolo
Well, I also want -M pc -machine accel=xen,vmport=on to work.
Right. So let's
P.S. I think the title:
xen-common.c: If -machine vmport= is not specified turn vmport off
is better. Will send v2 of patch out soon.
-Don Slutz
On 11/19/14 14:08, Don Slutz wrote:
On 11/19/14 13:08, Paolo Bonzini wrote:
On 19/11/2014 19:07, Don Slutz wrote:
-M pc -machine accel=xen
On 11/19/14 13:18, Stefano Stabellini wrote:
On Wed, 19 Nov 2014, Don Slutz wrote:
I have posted the patch:
Subject: [BUGFIX][PATCH for 2.2 1/1] hw/i386/pc_piix.c: Also pass vmport=off
for xenfv machine
Date: Wed, 19 Nov 2014 12:30:57 -0500
Message-ID:
On Wed, Nov 19, 2014 at 02:08:08PM -0500, Don Slutz wrote:
On 11/19/14 13:08, Paolo Bonzini wrote:
On 19/11/2014 19:07, Don Slutz wrote:
-M pc -machine accel=xen should work and, if that's what you want,
disable the vmport device. I think this patch is wrong.
Paolo
Well, I also want -M pc
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Mon, Nov 17, 2014 at 07:07:33PM +, Dr. David Alan Gilbert wrote:
And maybe this one too - I would have expected the rb names to have
already been validated on the source machine at this stage.
No to both:
I've been trying to
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:51PM +0100, Dr. David Alan Gilbert (git) wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
The loading of a device state (during postcopy) may access guest
memory that's still on the source machine
On 11/18/14 2:28 PM, Dr. David Alan Gilbert wrote:
Do you have the libvirt commands you're using and ideally the logs
to show what qmp commands are being sent to qemu to see what's
actually doing the COR ?
From the libvirt log, here are all of the commands sent to move a small
VM. The debug
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:41PM +0100, Dr. David Alan Gilbert (git) wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Add MIG_RPCOMM_REQPAGES command on Return path for the postcopy
destination to request a page from the
On 11/19/14 14:30, Eduardo Habkost wrote:
On Wed, Nov 19, 2014 at 02:08:08PM -0500, Don Slutz wrote:
On 11/19/14 13:08, Paolo Bonzini wrote:
On 19/11/2014 19:07, Don Slutz wrote:
-M pc -machine accel=xen should work and, if that's what you want,
disable the vmport device. I think this patch
Ugh, I wish I could teach Thunderbird to understand how to reply to a
newsgroup.
Apologies to Paolo for the direct note.
On 11/19/14 4:19 AM, Paolo Bonzini wrote:
On 19/11/2014 10:35, Dr. David Alan Gilbert wrote:
* Paolo Bonzini (pbonz...@redhat.com) wrote:
On 18/11/2014 21:28, Dr.
On 11/07/2014 07:24 AM, Vladimir Sementsov-Ogievskiy wrote:
+if (!name || name[0] == '\0') {
Isn't is better to move name[0] == '\0' check to
bdrv_create_dirty_bitmap, near existed name checking?
Hm, OK, but then we still need to check for the presence of a name in
these functions, so
Thanks Luke..
Ok, so theoretically it should work.
That's useful suggestions. Let me debug virtio-net driver for possible
cause.
Thanks
Anshul Makkar
On Wed, Nov 19, 2014 at 6:39 PM, Luke Gorrie l...@snabb.co wrote:
Hi Anshul,
On Wednesday, November 19, 2014, Anshul Makkar
On Wed, Nov 19, 2014 at 06:59:38PM +, Dr. David Alan Gilbert wrote:
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:38PM +0100, Dr. David Alan Gilbert (git)
wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Signed-off-by: Dr. David Alan
On Wed, Nov 19, 2014 at 05:06:50PM +, Dr. David Alan Gilbert wrote:
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Mon, Nov 03, 2014 at 01:22:45PM +, Dr. David Alan Gilbert wrote:
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:22PM
A new sub-option was added to -semihosting-config to define the entire
semihosting command line (cmdline=string).
This string is passed down to armv7m.c; if not defined, for
compatibility reasons, the -kernel -append values are used.
The armv7m_init() and stellaris_init() interfaces were
On Wed, Nov 19, 2014 at 03:01:24PM -0500, Don Slutz wrote:
On 11/19/14 14:30, Eduardo Habkost wrote:
On Wed, Nov 19, 2014 at 02:08:08PM -0500, Don Slutz wrote:
On 11/19/14 13:08, Paolo Bonzini wrote:
On 19/11/2014 19:07, Don Slutz wrote:
-M pc -machine accel=xen should work and, if that's
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does not return the correct value in
pc_machine_initfn().
Changed vmport from a bool to an enum. Added the
On Wed, Nov 19, 2014 at 08:01:31PM +, Dr. David Alan Gilbert wrote:
* David Gibson (da...@gibson.dropbear.id.au) wrote:
On Fri, Oct 03, 2014 at 06:47:41PM +0100, Dr. David Alan Gilbert (git)
wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Add MIG_RPCOMM_REQPAGES command
On 11/19/14 19:24, Eduardo Habkost wrote:
On Wed, Nov 19, 2014 at 03:01:24PM -0500, Don Slutz wrote:
On 11/19/14 14:30, Eduardo Habkost wrote:
On Wed, Nov 19, 2014 at 02:08:08PM -0500, Don Slutz wrote:
On 11/19/14 13:08, Paolo Bonzini wrote:
On 19/11/2014 19:07, Don Slutz wrote:
-M pc
On Wed, Nov 19, 2014 at 07:38:10PM -0500, Don Slutz wrote:
[...]
@@ -234,9 +235,33 @@ static void pc_init1(MachineState *machine,
pc_vga_init(isa_bus, pci_enabled ? pci_bus : NULL);
+if (xen_enabled()) {
+switch (pc_machine-vmport) {
+case VMPORT_MAX:
+
On 2014/11/20 0:31, Eric Blake wrote:
On 11/19/2014 09:06 AM, Michael S. Tsirkin wrote:
This affects QMP right?
I think later patches will tell how. CC'ing Eric.
As far as I can tell, this is just correcting a reporting issue; the
existing QMP commands/events for tracking balloon size will
On 2014/11/19 18:32, Michael S. Tsirkin wrote:
On Mon, Nov 17, 2014 at 01:11:08PM +0800, zhanghailiang wrote:
The global parameter 'ram_size' does not take into account
the hotplugged memory.
In some codes, we use 'ram_size' as current VM's real RAM size,
which is not correct.
Add function
I find that it is because qemu not configured with --enable-mixemu. now i have
another two questions, please help me.
1. I run win7 as the guest, when i mute the speaker of media player, the
line_out_ctl(./audio/spiceaudio.c) function was not called? but
mute/unmute button in the right
On 2014/11/20 2:49, Andrea Arcangeli wrote:
Hi Zhang,
On Fri, Oct 31, 2014 at 09:26:09AM +0800, zhanghailiang wrote:
On 2014/10/30 20:49, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
On 2014/10/30 1:46, Andrea Arcangeli wrote:
Hi Zhanghailiang,
On
On 11/19/2014 05:38 PM, Don Slutz wrote:
c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4
or
c/s b154537ad07598377ebf98252fb7d2aff127983b
moved the testing of xen_enabled() from pc_init1() to
pc_machine_initfn().
xen_enabled() does not return the correct value in
pc_machine_initfn().
On (Wed) 19 Nov 2014 [11:08:46], Igor Mammedov wrote:
On Wed, 19 Nov 2014 12:51:00 +0530
Amit Shah amit.s...@redhat.com wrote:
-static void *acpi_add_rom_blob(AcpiBuildState *build_state, GArray
*blob, +static ram_addr_t acpi_add_rom_blob(AcpiBuildState
*build_state, GArray *blob,
From: Gonglei arei.gong...@huawei.com
Coverity spot:
Assigning: iov = struct iovec [3]({{buf, 12UL},
{(void *)dot1q_buf, 4UL},
{buf + 12, size - 12}})
(address of temporary variable of type struct iovec [3]).
out_of_scope: Temporary variable of
From: Gonglei arei.gong...@huawei.com
s-xmit_pos maybe assigned to a negative value (-1),
but in this branch variable s-xmit_pos as an index to
array s-buffer. Let's add a check for s-xmit_pos.
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/net/pcnet.c | 2 +-
1 file changed, 1
From: Gonglei arei.gong...@huawei.com
If is_connected parameter is false, the saddr
variable will no initialize. Coverity report:
uninit_use: Using uninitialized value saddr.sin_port.
We don't need add saddr information to nc-info_str
when is_connected is false.
Signed-off-by: Gonglei
From: Gonglei arei.gong...@huawei.com
Please see details in every patch.
Cc: Paolo Bonzini pbonz...@redhat.com
Cc: Stefan Hajnoczi stefa...@redhat.com
Gonglei (4):
net/slirp: fix memory leak
net/socket: fix Uninitialized scalar variable
pcnet: fix Negative array index read
rtl8139: fix
From: Gonglei arei.gong...@huawei.com
commit b412eb61 introduce 'cmd:' target for guestfwd,
and fwd don't be used in this scenario, and will leak
memory in true branch with 'cmd:'. Let's allocate memory
for fwd variable just in else statement.
Cc: Alexander Graf ag...@suse.de
Signed-off-by:
On 19/11/2014 20:08, Don Slutz wrote:
-M pc -machine accel=xen
pcms-vmport is false
I think this should be true. Any reason why not?
Paolo
-M pc -machine vmport=on,accel=xen
pcms-vmport is true
-M pc -machine vmport=off,accel=xen
pcms-vmport is false
On 20/11/2014 01:58, Eduardo Habkost wrote:
if (pc_machine-vmport == VMPORT_AUTO) {
no_vmport = xen_enabled();
} else {
no_vmport = (pc_machine-vmport == VMPORT_ON);
}
I'm still not sure why the configuration should differ for -M pc
depending on whether xen
On 11/11/2014 18:13, Paolo Bonzini wrote:
On 06/10/2014 16:56, Paolo Bonzini wrote:
In the emergency last-minute patches of QEMU 2.1 we did two things:
- fixed migration problems from 1.7 or 2.0 to 2.1 due to changes in
ACPI table sizes
- ensured that future versions will not break
On 11/11/2014 18:13, Paolo Bonzini wrote:
On 15/10/2014 09:45, Paolo Bonzini wrote:
This makes it simpler to keep the SSDT byte-for-byte identical for a
given machine type, which is a goal we want to have for 2.2 and newer
types.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
On 11/20/2014 01:57 PM, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
commit b412eb61 introduce 'cmd:' target for guestfwd,
and fwd don't be used in this scenario, and will leak
memory in true branch with 'cmd:'. Let's allocate memory
for fwd variable just in else
On 11/20/2014 01:57 PM, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
If is_connected parameter is false, the saddr
variable will no initialize. Coverity report:
uninit_use: Using uninitialized value saddr.sin_port.
We don't need add saddr information to nc-info_str
On 20/11/2014 06:57, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
Coverity spot:
Assigning: iov = struct iovec [3]({{buf, 12UL},
{(void *)dot1q_buf, 4UL},
{buf + 12, size - 12}})
(address of temporary variable of
On 11/20/2014 01:57 PM, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
s-xmit_pos maybe assigned to a negative value (-1),
but in this branch variable s-xmit_pos as an index to
array s-buffer. Let's add a check for s-xmit_pos.
Signed-off-by: Gonglei
On 20/11/2014 06:57, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
s-xmit_pos maybe assigned to a negative value (-1),
but in this branch variable s-xmit_pos as an index to
array s-buffer. Let's add a check for s-xmit_pos.
Signed-off-by: Gonglei
On 2014/11/20 14:36, Paolo Bonzini wrote:
On 20/11/2014 06:57, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
s-xmit_pos maybe assigned to a negative value (-1),
but in this branch variable s-xmit_pos as an index to
array s-buffer. Let's add a check for s-xmit_pos.
On 11/20/2014 02:29 PM, Paolo Bonzini wrote:
On 20/11/2014 06:57, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
Coverity spot:
Assigning: iov = struct iovec [3]({{buf, 12UL},
{(void *)dot1q_buf, 4UL},
{buf + 12, size -
On Thu, Nov 20, 2014 at 07:05:05AM +0100, Paolo Bonzini wrote:
On 11/11/2014 18:13, Paolo Bonzini wrote:
On 06/10/2014 16:56, Paolo Bonzini wrote:
In the emergency last-minute patches of QEMU 2.1 we did two things:
- fixed migration problems from 1.7 or 2.0 to 2.1 due to changes
On Thu, Nov 20, 2014 at 07:05:17AM +0100, Paolo Bonzini wrote:
On 11/11/2014 18:13, Paolo Bonzini wrote:
On 15/10/2014 09:45, Paolo Bonzini wrote:
This makes it simpler to keep the SSDT byte-for-byte identical for a
given machine type, which is a goal we want to have for 2.2 and newer
On 20/11/2014 07:44, Gonglei wrote:
Maybe not, since two branch are if and else if not if and else,
so this change make the below code segment's wide ...
bcnt = 4096 - GET_FIELD(tmd.length, TMDL, BCNT);
s-phys_mem_read(s-dma_opaque, PHYSADDR(s, tmd.tbadr),
On 20/11/2014 07:55, Michael S. Tsirkin wrote:
I thought we agreed we'll consider alternate approaches after 2.2?
I would prefer not to have yet another mode to support
if we can help it.
I agree, but:
1) looks like there is stronger opposition to your patch than I thought,
so a 2.2
On 2014/11/20 14:55, Jason Wang wrote:
On 11/20/2014 02:29 PM, Paolo Bonzini wrote:
On 20/11/2014 06:57, arei.gong...@huawei.com wrote:
From: Gonglei arei.gong...@huawei.com
Coverity spot:
Assigning: iov = struct iovec [3]({{buf, 12UL},
{(void *)dot1q_buf, 4UL},
101 - 200 of 203 matches
Mail list logo
