Re: [Qemu-devel] [PATCH 1/4] target-arm: Fix RVBAR_EL1 register encoding

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 14:59, Greg Bellows wrote: > > On Jan 23, 2015 8:56 AM, "Peter Maydell" wrote: >> I assume you checked that Linux still boots (ie we're not >> accidentally relying on this regdef for RMR_EL1). >> > Yeah, I booted linux on virt/a57 without issue. I'll double check the > reli

Re: [Qemu-devel] [PATCH] iotests: Lower 064's memory usage

2015-01-23 Thread Jeff Cody
On Fri, Jan 23, 2015 at 09:59:45AM -0500, Max Reitz wrote: > Test 064 reads a lot of data at once which currently results in qemu-io > having to allocate up to about 1 GB of memory (958 MB, to be exact). > This patch lowers that amount to 128 MB by making the test read smaller > chunks. > > Signed

Re: [Qemu-devel] [PATCH 3/4] target-arm: Change reset to highest available EL

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 14:49, Greg Bellows wrote: > Update to arm_cpu_reset() to reset into the highest available exception level > based on the set ARM features. > > Signed-off-by: Greg Bellows > --- > hw/arm/boot.c| 10 ++ > target-arm/cpu.c | 10 +- > 2 files changed, 19 in

Re: [Qemu-devel] [PATCH 2/4] target-arm: Add extended RVBAR support

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 14:49, Greg Bellows wrote: > Added RVBAR_EL2 and RVBAR_EL3 CP register support. All RVBAR_EL# registers > point to the same location and only the highest EL version exists at any one > time. > > Signed-off-by: Greg Bellows > if (arm_feature(env, ARM_FEATURE_EL2)) { >

[Qemu-devel] [PATCH] iotests: Lower 064's memory usage

2015-01-23 Thread Max Reitz
Test 064 reads a lot of data at once which currently results in qemu-io having to allocate up to about 1 GB of memory (958 MB, to be exact). This patch lowers that amount to 128 MB by making the test read smaller chunks. Signed-off-by: Max Reitz --- tests/qemu-iotests/064 | 19 ++

Re: [Qemu-devel] [PATCH 1/4] target-arm: Fix RVBAR_EL1 register encoding

2015-01-23 Thread Greg Bellows
On Jan 23, 2015 8:56 AM, "Peter Maydell" wrote: > > On 23 January 2015 at 14:49, Greg Bellows wrote: > > Fix the RVBAR_EL1 CP register opc2 encoding from 2 to 1 > > > > Signed-off-by: Greg Bellows > > --- > > target-arm/helper.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Revi

Re: [Qemu-devel] [PATCH 1/4] target-arm: Fix RVBAR_EL1 register encoding

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 14:49, Greg Bellows wrote: > Fix the RVBAR_EL1 CP register opc2 encoding from 2 to 1 > > Signed-off-by: Greg Bellows > --- > target-arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Peter Maydell I assume you checked that Linux still boots

[Qemu-devel] [PATCH 4/4] target-arm: Add missing SP_ELx register definition

2015-01-23 Thread Greg Bellows
Added CP register definitions for SP_EL1 and SP_EL2. Signed-off-by: Greg Bellows --- target-arm/helper.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index d5f0997..ae7394d 100644 --- a/target-arm/helper.c +++ b/tar

[Qemu-devel] [PATCH 1/4] target-arm: Fix RVBAR_EL1 register encoding

2015-01-23 Thread Greg Bellows
Fix the RVBAR_EL1 CP register opc2 encoding from 2 to 1 Signed-off-by: Greg Bellows --- target-arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 1a5e067..c9b1c08 100644 --- a/target-arm/helper.c +++ b/target-arm/helpe

[Qemu-devel] [PATCH 3/4] target-arm: Change reset to highest available EL

2015-01-23 Thread Greg Bellows
Update to arm_cpu_reset() to reset into the highest available exception level based on the set ARM features. Signed-off-by: Greg Bellows --- hw/arm/boot.c| 10 ++ target-arm/cpu.c | 10 +- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/hw/arm/boot.c b/hw/arm/b

[Qemu-devel] [PATCH 2/4] target-arm: Add extended RVBAR support

2015-01-23 Thread Greg Bellows
Added RVBAR_EL2 and RVBAR_EL3 CP register support. All RVBAR_EL# registers point to the same location and only the highest EL version exists at any one time. Signed-off-by: Greg Bellows --- target-arm/helper.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-

[Qemu-devel] [PATCH 0/4] target-arm: Initial ARMv8 extended EL support

2015-01-23 Thread Greg Bellows
These patches add extended EL support for ARMv8. Specifically the following changes were made: - Fix issue in RVBAR_EL1 CP register definition - Add missing RVBAR_ELx CP register definitions - Add missing SP_ELx CP register definitions - Add reset support to start in highest EL Greg Bellows (4):

Re: [Qemu-devel] [RfC PATCH] virtio-pci: place msix regions in modern virtio bar

2015-01-23 Thread Gerd Hoffmann
Hi, > > Also seabios wouldn't map the bar > > above 4G. > We can teach it to do that, and even if not, OS can do it on hotplug. Just to clarify: seabios can do it in the general case, it just wouldn't do it for xhci specifically because otherwise the seabios xhci driver wouldn't be able to re

Re: [Qemu-devel] [PATCH] block: vhdx - force FileOffsetMB field to '0' for certain block states

2015-01-23 Thread Max Reitz
On 2015-01-20 at 16:01, Jeff Cody wrote: The v1.0.0 spec calls out PAYLOAD_BLOCK_ZERO FileOffsetMB field as being 'reserved'. In practice, this means that Hyper-V will fail to read a disk image with PAYLOAD_BLOCK_ZERO block states with a FileOffsetMB value other than 0. The other states that in

Re: [Qemu-devel] [Spice-devel] screen freezed for 2-3 minutes on spice connect on xen windows 7 domU's with qxl after save/restore

2015-01-23 Thread Fabio Fantoni
Il 21/11/2014 15:43, Fabio Fantoni ha scritto: Il 21/11/2014 12:05, Fabio Fantoni ha scritto: Il 20/11/2014 12:21, Fabio Fantoni ha scritto: Il 13/11/2014 13:22, Fabio Fantoni ha scritto: Il 13/11/2014 11:14, Fabio Fantoni ha scritto: Il 19/09/2014 15:18, Fabio Fantoni ha scritto: Il 12/09/2

Re: [Qemu-devel] [question] incremental backup a running vm

2015-01-23 Thread Kashyap Chamarthy
On Wed, Jan 21, 2015 at 11:39:44AM +0100, Paolo Bonzini wrote: > > > On 21/01/2015 11:32, Zhang Haoyu wrote: > > Hi, > > > > Does drive_mirror support incremental backup a running vm? > > Or other mechanism does? > > > > incremental backup a running vm requirements: > > First time backup, all o

Re: [Qemu-devel] [PATCH V2] s390x/pci: avoid sign extension in stpcifc

2015-01-23 Thread Cornelia Huck
On Wed, 21 Jan 2015 16:50:29 +0100 Frank Blaschka wrote: > this patch avoids sign extension and fixes a data conversion > bug in stpcifc. Both issues where found by Coverity. > > Signed-off-by: Frank Blaschka > --- > hw/s390x/s390-pci-inst.c | 8 > 1 file changed, 4 insertions(+), 4 d

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-23 Thread Javier Celaya
Hello, this is the patch with the version check. Christophe, can you check that the version is the correct one? El Martes, 20 de enero de 2015 17:08:07 Christophe Fergeau escribió: > Hey, > > Version check seems good, we probably can raise spice-server version in > git preemptively so that you c

[Qemu-devel] Windows 2008 Guest BSODS with CLOCK_WATCHDOG_TIMEOUT on VM migration

2015-01-23 Thread Mikhail Sennikovskii
dbox off \ -M pc-1.0 \ -nodefaults \ -vga std \ -chardev socket,id=qmp_id_qmp1,path=/tmp/monitor-qmp1-20150123-112624-aFZmIkNT,server,nowait \ -mon chardev=qmp_id_qmp1,mode=control \ -chardev socket,id=serial_id_serial0,path=/tmp/serial-serial0-20150123-1126

Re: [Qemu-devel] [RfC PATCH] virtio-pci: place msix regions in modern virtio bar

2015-01-23 Thread Michael S. Tsirkin
On Fri, Jan 23, 2015 at 02:53:27PM +0100, Gerd Hoffmann wrote: > Hi, > > > I wanted to make the modern BAR prefetcheable, so it can > > be a full 64-bit one, > > It's not the case right now though, the two bars have identical > attributes, and there is plenty of unused space in the modern virti

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 14:01, Chen Gang S wrote: > What I shall do for tile qemu should obey the related license of qemu > (all the related code should belong to qemu upstream). If necessary to > follow some copyright working flow, please let me know, I shall follow. We don't have a copyright assi

Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-23 Thread Michael S. Tsirkin
On Fri, Jan 23, 2015 at 02:40:30PM +0100, Igor Mammedov wrote: > On Fri, 23 Jan 2015 15:24:24 +0200 > "Michael S. Tsirkin" wrote: > > > On Fri, Jan 23, 2015 at 11:35:29AM +0100, Igor Mammedov wrote: > > > On Fri, 23 Jan 2015 10:11:19 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu,

Re: [Qemu-devel] [PATCH v3] sheepdog: selectable object size support

2015-01-23 Thread Kevin Wolf
Am 23.01.2015 um 09:24 hat Teruaki Ishizaki geschrieben: > Previously, qemu block driver of sheepdog used hard-coded VDI object size. > This patch enables users to handle "block_size_shift" value for > calculating VDI object size. > > When you start qemu, you don't need to specify additional comma

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base

2015-01-23 Thread Chen Gang S
On 1/23/15 19:21, Peter Maydell wrote: > On 23 January 2015 at 10:57, Chen Gang S wrote: >> >> Thank you for all of your work. >> >> I plan to let qemu support tile architecture: "can let gcc run testsuite >> with qemu for tile". It is really hard to me, but I should try, it is my >> duty (I met i

Re: [Qemu-devel] [RfC PATCH] virtio-pci: place msix regions in modern virtio bar

2015-01-23 Thread Gerd Hoffmann
Hi, > I wanted to make the modern BAR prefetcheable, so it can > be a full 64-bit one, It's not the case right now though, the two bars have identical attributes, and there is plenty of unused space in the modern virtio bar ... > this is impossible with the MSI-X > BAR. What exactly is imposs

Re: [Qemu-devel] [v3 13/13] migration: Add command to query migration parameter

2015-01-23 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Add the qmp and hmp commands to query the parameters used in live > migration. Eric: I'm OK with this, but since it's interface stuff, I thought it best to let you check. Dave > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > hmp-comm

Re: [Qemu-devel] [v3 12/13] migration: Add command to set migration parameter

2015-01-23 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Add the qmp and hmp commands to tune the parameters used in live > migration. If I understand correctly on the destination side we need to set the number of decompression threads very early on an incoming migration - I'm not clear how early that needs to

Re: [Qemu-devel] [v3 11/13] migration: Add interface to control compression

2015-01-23 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > The multiple compression threads can be turned on/off through > qmp and hmp interface when doing live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > migration.c | 7 +-- > qapi-schema.json | 6 +- > 2 files chan

Re: [Qemu-devel] [PATCH v2 06/47] acpi: add acpi_name() & acpi_name_decl() term

2015-01-23 Thread Michael S. Tsirkin
On Fri, Jan 23, 2015 at 02:32:45PM +0100, Igor Mammedov wrote: > On Fri, 23 Jan 2015 10:59:48 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Jan 22, 2015 at 02:49:50PM +, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > > hw/acpi/acpi-build-utils.c | 24 +

Re: [Qemu-devel] [v3 10/13] migration: Add the core code of multi-thread decompression

2015-01-23 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > arch_init.c | 48 ++-- > 1 file changed, 46 insertions(+), 2 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index 14bc486..7103f4f 100644

Re: [Qemu-devel] [PULL 01/01] seccomp: add mlockall to whitelist

2015-01-23 Thread Amit Shah
On (Fri) 23 Jan 2015 [14:21:46], Eduardo Otubo wrote: > From: Paolo Bonzini > > This is used by "-realtime mlock=on". > > Signed-off-by: Eduardo Otubo Hm, that's not where a signed-off-by of the maintainer goes... > Signed-off-by: Paolo Bonzini > Reviewed-by: Amit Shah > Reviewed-by: Eduard

Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-23 Thread Igor Mammedov
On Fri, 23 Jan 2015 15:24:24 +0200 "Michael S. Tsirkin" wrote: > On Fri, Jan 23, 2015 at 11:35:29AM +0100, Igor Mammedov wrote: > > On Fri, 23 Jan 2015 10:11:19 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jan 22, 2015 at 02:49:45PM +, Igor Mammedov wrote: > > > > Adds for dynami

Re: [Qemu-devel] [v3 09/13] migration: Make compression co-work with xbzrle

2015-01-23 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Now, multiple thread compression can co-work with xbzrle. when > xbzrle is on, multiple thread compression will only work at the > first round of ram data sync. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > arch_init.c | 13 ++

Re: [Qemu-devel] [v3 08/13] migration: Add the core code of multi-thread compresion

2015-01-23 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > At this point, multiple thread compression can't co-work with xbzrle. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > arch_init.c | 164 > +--- > 1 file changed, 157 insertions(+)

Re: [Qemu-devel] [v3 07/13] migraion: Rewrite the function ram_save_page()

2015-01-23 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > We rewrite this function to reuse the code in it > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > arch_init.c | 107 > ++-- > 1 file changed, 61 insertions(+), 46 deletions(-) The

Re: [Qemu-devel] [v3 05/13] arch_init: alloc and free data struct in multi-thread compression

2015-01-23 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Define the data structure and varibles used when doing multiple > thread compression, and add the code to initialize and free them. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > arch_init.c | 34 +- > 1

Re: [Qemu-devel] [PATCH v3 0/6] Update filename string sizes in block layer

2015-01-23 Thread Kevin Wolf
Am 22.01.2015 um 14:03 hat Jeff Cody geschrieben: > The block layer uses a mixture of 'PATH_MAX' and '1024' string sizes > for filenames (and backing filenames). > > This series consolidates all that usage to 'PATH_MAX'. Since most platforms > (especially the most common platforms for QEMU) have

Re: [Qemu-devel] [PATCH v2 11/47] acpi: add acpi_arg0(), acpi_arg1(), acpi_arg2(), acpi_arg3() terms

2015-01-23 Thread Igor Mammedov
On Fri, 23 Jan 2015 10:32:57 +0200 Marcel Apfelbaum wrote: > On 01/22/2015 04:49 PM, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/acpi-build-utils.c | 32 > > include/hw/acpi/acpi-build-utils.h | 5 + > > 2 files chan

Re: [Qemu-devel] [RfC PATCH] virtio-pci: place msix regions in modern virtio bar

2015-01-23 Thread Michael S. Tsirkin
On Fri, Jan 23, 2015 at 01:29:43PM +0100, Gerd Hoffmann wrote: > Only for legacy-free virtio devices, to avoid unpleasent > surprises with old drivers. > > mtree snippet: > > fea0-fea7 (prio 1, RW): virtio-pci > fea0-fea00fff (prio 0, RW): vir

Re: [Qemu-devel] [PATCH v2 06/47] acpi: add acpi_name() & acpi_name_decl() term

2015-01-23 Thread Igor Mammedov
On Fri, 23 Jan 2015 10:59:48 +0200 "Michael S. Tsirkin" wrote: > On Thu, Jan 22, 2015 at 02:49:50PM +, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/acpi-build-utils.c | 24 > > include/hw/acpi/acpi-build-utils.h | 3 +++ > > 2 f

Re: [Qemu-devel] [PATCH] Bug fix: delete the reader entry after queueing an event, not before.

2015-01-23 Thread Paolo Bonzini
On 23/01/2015 14:27, Gerd Hoffmann wrote: > Hi, > >>> Reviewed-by: Marc-André Lureau >> >> Gerd, are you maintaining libcacard nowadays? If so, can you add an >> entry to MAINTAINERS? (And if not, perhaps Marc-André could maintain it...) > > Well, I know next to nothing about libcacard, an

Re: [Qemu-devel] [v3 04/13] qemu-file: Add tow function will be used in migration

2015-01-23 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > migrate_qemu_add_compression_data() compress the data > and put it to QEMUFile. migrate_qemu_flush() put the > data in the source QEMUFile to destination QEMUFile. > > The two function can help to do live migration. Typo in the title 'tow->two' - but per

Re: [Qemu-devel] [PATCH] Bug fix: delete the reader entry after queueing an event, not before.

2015-01-23 Thread Gerd Hoffmann
Hi, > > Reviewed-by: Marc-André Lureau > > Gerd, are you maintaining libcacard nowadays? If so, can you add an > entry to MAINTAINERS? (And if not, perhaps Marc-André could maintain it...) Well, I know next to nothing about libcacard, and I'd very much prefer if someone who knows this bette

Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-23 Thread Michael S. Tsirkin
On Fri, Jan 23, 2015 at 11:03:54AM +0100, Igor Mammedov wrote: > On Fri, 23 Jan 2015 10:03:03 +0200 > "Michael S. Tsirkin" wrote: > > > > +typedef enum { > > > +NON_BLOCK, > > > +PACKAGE, > > > +EXT_PACKAGE, > > > +BUFFER, > > > +RES_TEMPLATE, > > > +} AcpiBlockFlags; > > > >

Re: [Qemu-devel] [v3 03/13] migration: Add the framework of muti-thread decompression

2015-01-23 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > arch_init.c | 70 > +++ > include/migration/migration.h | 4 +++ > migration.c | 15 ++ > 3 files changed,

Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-23 Thread Michael S. Tsirkin
On Fri, Jan 23, 2015 at 11:35:29AM +0100, Igor Mammedov wrote: > On Fri, 23 Jan 2015 10:11:19 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Jan 22, 2015 at 02:49:45PM +, Igor Mammedov wrote: > > > Adds for dynamic AML creation, which will be used > > > for piecing ASL/AML primitives toget

Re: [Qemu-devel] [PULL 0/1] sb16: fix interrupt acknowledgement

2015-01-23 Thread Peter Maydell
On 22 January 2015 at 11:40, Gerd Hoffmann wrote: > Hi, > > Pretty short audio queue, with a single soundblaster bugfix. > > please pull, > Gerd > > The following changes since commit 699eae17b841e6784dc3864bf357e26bff1e9dfe: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-misc-

Re: [Qemu-devel] [v3 02/13] migration: Add the framework of multi-thread compression

2015-01-23 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > arch_init.c | 78 > ++- > include/migration/migration.h | 9 + > migration.c | 38 + > 3 fi

[Qemu-devel] [PULL 00/01] seccomp branch queue

2015-01-23 Thread Eduardo Otubo
ll-seccomp-20150123 for you to fetch changes up to 4b45b055491a319292beefb8080a81d96cf55cf6: seccomp: add mlockall to whitelist (2015-01-23 14:07:08 +0100) seccomp br

[Qemu-devel] [PULL 01/01] seccomp: add mlockall to whitelist

2015-01-23 Thread Eduardo Otubo
From: Paolo Bonzini This is used by "-realtime mlock=on". Signed-off-by: Eduardo Otubo Signed-off-by: Paolo Bonzini Reviewed-by: Amit Shah Reviewed-by: Eduardo Habkost Tested-by: Eduardo Habkost Acked-by: Eduardo Otubo --- qemu-seccomp.c | 1 + 1 file changed, 1 insertion(+) diff --git a

Re: [Qemu-devel] [v3 01/13] docs: Add a doc about multiple thread compression

2015-01-23 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Give some details about the multiple compression threads and > how to use it in live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang Reviewed-by: Dr. David Alan Gilbert > --- > docs/multi-thread-compression.txt | 141 > ++

Re: [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration

2015-01-23 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > This feature can help to reduce the data transferred about 60%, and the > migration time can also be reduced about 70%. > > Summary of changed from v2->v3 > > -Splited the patch to 13 parts instead of 2 > -Rewrote the core code to do comp

Re: [Qemu-devel] [RFC PATCH v1 06/13] spapr: CPU hotplug support

2015-01-23 Thread Igor Mammedov
On Thu, 8 Jan 2015 11:40:13 +0530 Bharata B Rao wrote: > Support CPU hotplug via device-add command. Use the exising EPOW event > infrastructure to send CPU hotplug notification to the guest. > > Signed-off-by: Bharata B Rao > --- > hw/ppc/spapr.c | 205 > +++

[Qemu-devel] [RfC PATCH] virtio-pci: place msix regions in modern virtio bar

2015-01-23 Thread Gerd Hoffmann
Only for legacy-free virtio devices, to avoid unpleasent surprises with old drivers. mtree snippet: fea0-fea7 (prio 1, RW): virtio-pci fea0-fea00fff (prio 0, RW): virtio-pci-common fea01000-fea01fff (prio 0, RW): virtio-p

[Qemu-devel] [PATCH v2] fix QEMU build on Xen/ARM

2015-01-23 Thread Stefano Stabellini
xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an unsigned long argument (in fact xen_pfn_t is defined as uint64_t on ARM). Also use xc_hvm_param_get instead of the deprecated xc_get_hvm_param. Signed-off-by: Stefano Stabellini --- Changes in v2: - properly handle return codes a

Re: [Qemu-devel] [PATCH v1 2/3] pc-dimm: Make pc_existing_dimms_capacity global

2015-01-23 Thread Igor Mammedov
On Fri, 23 Jan 2015 09:07:02 +0530 Bharata B Rao wrote: > Move pc_existing_dimms_capacity() to pc-dimm.c since it would be needed > by PowerPC memory hotplug code too. > > Signed-off-by: Bharata B Rao Reviewed-by: Igor Mammedov > --- > hw/i386/pc.c | 24

Re: [Qemu-devel] [PATCH 3/3] pc-dimm: Add Error argument to pc_existing_dimms_capacity

2015-01-23 Thread Igor Mammedov
On Fri, 23 Jan 2015 09:07:03 +0530 Bharata B Rao wrote: > Now that pc_existing_dimms_capacity() is an API, include Error pointer > as an argument and modify the caller appropriately. > > Suggested-by: Igor Mammedov > Signed-off-by: Bharata B Rao > --- > hw/i386/pc.c | 4 ++-- > h

Re: [Qemu-devel] [PATCH] fix QEMU build on Xen/ARM

2015-01-23 Thread Stefano Stabellini
On Thu, 22 Jan 2015, Don Slutz wrote: > On 01/22/15 13:46, Stefano Stabellini wrote: > > xen_get_vmport_regs_pfn should take a xen_pfn_t argument, not an > > unsigned long argument (in fact xen_pfn_t is defined as uint64_t on > > ARM). > > > > Also use xc_hvm_param_get instead of the deprecated xc

Re: [Qemu-devel] [PATCH RFC] coverity: Improve model for GLib memory allocation

2015-01-23 Thread Markus Armbruster
Paolo Bonzini writes: > On 22/01/2015 15:55, Markus Armbruster wrote: >> == Look like a bug == >> >> blockdev-nbd.c:35: leaked_handle: Handle variable "fd" going out of >> scope leaks the handle. > > It's a false positive. > > After nbd_client_new calls nbd_send_negotiate, either it returns or >

Re: [Qemu-devel] [PATCH RFC] coverity: Improve model for GLib memory allocation

2015-01-23 Thread Thomas Huth
On Thu, 22 Jan 2015 15:55:27 +0100 Markus Armbruster wrote: ... > > == Triaged / Bug == > > These are worrying. Something wrong with my new model? > > hw/s390x/s390-pci-bus.c:195: leaked_storage: Variable "sei_cont" going out of > scope leaks the storage it points to. Did you already include

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 10:57, Chen Gang S wrote: > > Thank you for all of your work. > > I plan to let qemu support tile architecture: "can let gcc run testsuite > with qemu for tile". It is really hard to me, but I should try, it is my > duty (I met it, and it's within my boarder, although no one

Re: [Qemu-devel] [question] incremental backup a running vm

2015-01-23 Thread Kashyap Chamarthy
On Wed, Jan 21, 2015 at 11:39:44AM +0100, Paolo Bonzini wrote: > > > On 21/01/2015 11:32, Zhang Haoyu wrote: > > Hi, > > > > Does drive_mirror support incremental backup a running vm? > > Or other mechanism does? > > > > incremental backup a running vm requirements: > > First time backup, all o

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base

2015-01-23 Thread Chen Gang S
Thank you for all of your work. I plan to let qemu support tile architecture: "can let gcc run testsuite with qemu for tile". It is really hard to me, but I should try, it is my duty (I met it, and it's within my boarder, although no one pay for me). :-) At present, I am just preparing: - Read

Re: [Qemu-devel] [PATCH v2 02/47] acpi: add acpi_scope() term

2015-01-23 Thread Igor Mammedov
On Fri, 23 Jan 2015 10:02:54 +0200 "Michael S. Tsirkin" wrote: > On Thu, Jan 22, 2015 at 02:49:46PM +, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/acpi-build-utils.c | 18 ++ > > include/hw/acpi/acpi-build-utils.h | 4 > > 2 files

Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-23 Thread Igor Mammedov
On Fri, 23 Jan 2015 10:11:19 +0200 "Michael S. Tsirkin" wrote: > On Thu, Jan 22, 2015 at 02:49:45PM +, Igor Mammedov wrote: > > Adds for dynamic AML creation, which will be used > > for piecing ASL/AML primitives together and hiding > > from user/caller details about how nested context > > sh

Re: [Qemu-devel] [PATCH] linux-user/main.c: Remove redundant end_exclusive()

2015-01-23 Thread Chen Gang S
On 1/23/15 18:20, Peter Maydell wrote: > On 23 January 2015 at 10:17, Chen Gang S wrote: >> start/end_exclusive() need be pairs, except the start_exclusive() in >> stop_all_tasks() which is only used by force_sig(), which will be abort. >> So at present, start_exclusive() in stop_all_task() need n

Re: [Qemu-devel] [PATCH v2 00/11] cpu: add i386 cpu hot remove support

2015-01-23 Thread Alexandre DERUMIER
Hello, I'm currently testing the new cpu unplug features, Works fine here with debian guests and kernel 3.14. But I have notice some small potential bugs, but I'm not sure I'm doing it right. 1)first, to unplug cpu, we need an id for cpu The problem is that the current qemu command line -smp 1

Re: [Qemu-devel] [PATCH] linux-user/main.c: Remove redundant end_exclusive()

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 10:17, Chen Gang S wrote: > start/end_exclusive() need be pairs, except the start_exclusive() in > stop_all_tasks() which is only used by force_sig(), which will be abort. > So at present, start_exclusive() in stop_all_task() need not be paired. > > So need remove end_exclusi

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Need call unlock_user() before go to failure return in default case

2015-01-23 Thread Chen Gang S
On 1/23/15 18:01, Peter Maydell wrote: > On 23 January 2015 at 08:53, Chen Gang S wrote: >> In abi_long do_ioctl_dm(), after calls lock_user(), it does not call >> unlock_user() before go to failure return in default case. >> >> Signed-off-by: Chen Gang >> --- >> linux-user/syscall.c | 1 + >> 1

[Qemu-devel] [PATCH] linux-user/main.c: Remove redundant end_exclusive()

2015-01-23 Thread Chen Gang S
start/end_exclusive() need be pairs, except the start_exclusive() in stop_all_tasks() which is only used by force_sig(), which will be abort. So at present, start_exclusive() in stop_all_task() need not be paired. So need remove end_exclusive() after queue_signal(). If could really return from que

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 10:07, Chen Gang S wrote: > It is only a typo issue, need use tswapal(target_vec[i].iov_len) for the > len. > > Signed-off-by: Chen Gang > --- > linux-user/syscall.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/syscall.c b/linux-user/s

Re: [Qemu-devel] [PATCH v2] linux-user/syscall.c: Free the vec[i] in failure processing code block

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 10:01, Chen Gang S wrote: > When failure occurs during allocating vec[i], also need free all > allocated vec[i] in failure processing code block before return. > > In unlock_user(), it will check vec[i].iov_base whether is NULL, so need > not check it again outside. > > If er

Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-23 Thread Igor Mammedov
On Fri, 23 Jan 2015 10:03:03 +0200 "Michael S. Tsirkin" wrote: > > +typedef enum { > > +NON_BLOCK, > > +PACKAGE, > > +EXT_PACKAGE, > > +BUFFER, > > +RES_TEMPLATE, > > +} AcpiBlockFlags; > > Please prefix values with ACPI_BUILD_ - don't pollute the > global namespace. Could we

[Qemu-devel] [PATCH] bugfix: cannot remove chardev after the vhost-user does hot add/del pci device

2015-01-23 Thread zhangkun
From: zhangkun step for vhost-user hotplug: 1.hot add chardev-add backend=socket,id=charnet0,path=/var/run/vhost-user/tap0 netdev_add type=vhost-user,id=hostnet0,chardev=charnet0 device_add virtio-net-pci,netdev=hostnet0,id=net0 2.hot del device_del net0 netdev_del hostnet0 chardev-

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Need call unlock_user() before go to failure return in default case

2015-01-23 Thread Peter Maydell
On 23 January 2015 at 08:53, Chen Gang S wrote: > In abi_long do_ioctl_dm(), after calls lock_user(), it does not call > unlock_user() before go to failure return in default case. > > Signed-off-by: Chen Gang > --- > linux-user/syscall.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/l

[Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base

2015-01-23 Thread Chen Gang S
It is only a typo issue, need use tswapal(target_vec[i].iov_len) for the len. Signed-off-by: Chen Gang --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a66c2ae..8260ed7 100644 --- a/linux-user/syscall.c

[Qemu-devel] [PATCH v2] linux-user/syscall.c: Free the vec[i] in failure processing code block

2015-01-23 Thread Chen Gang S
When failure occurs during allocating vec[i], also need free all allocated vec[i] in failure processing code block before return. In unlock_user(), it will check vec[i].iov_base whether is NULL, so need not check it again outside. If error is EFAULT when "i == 0", vec[i].iov_base is NULL, then ca

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Free the vec[i] in failure processing code block

2015-01-23 Thread Chen Gang S
On 1/23/15 17:36, Chen Gang S wrote: > When failure occurs during allocating vec[i], also need free all > allocated vec[i] in failure processing code block before return. > > If error is EFAULT when "i == 0", vec[i].iov_base is NULL, then can just > skip it, so can still use "while (--i >= 0)" for

[Qemu-devel] [PATCH] linux-user/syscall.c: Free the vec[i] in failure processing code block

2015-01-23 Thread Chen Gang S
When failure occurs during allocating vec[i], also need free all allocated vec[i] in failure processing code block before return. If error is EFAULT when "i == 0", vec[i].iov_base is NULL, then can just skip it, so can still use "while (--i >= 0)" for the free looping. Signed-off-by: Chen Gang -

Re: [Qemu-devel] [PATCH] target-i386: Disable HLE and RTM on Haswell & Broadwell

2015-01-23 Thread Paolo Bonzini
On 22/01/2015 20:22, Eduardo Habkost wrote: > All Haswell CPUs and some Broadwell CPUs were updated by Intel to have > the HLE and RTM features disabled. This will prevent > "-cpu Haswell,enforce" and "-cpu Broadwell,enforce" from running out of > the box on those CPUs. > > Disable those feature

Re: [Qemu-devel] [PATCH v2 11/47] acpi: add acpi_arg0(), acpi_arg1(), acpi_arg2(), acpi_arg3() terms

2015-01-23 Thread Michael S. Tsirkin
On Fri, Jan 23, 2015 at 10:32:57AM +0200, Marcel Apfelbaum wrote: > On 01/22/2015 04:49 PM, Igor Mammedov wrote: > >Signed-off-by: Igor Mammedov > >--- > > hw/acpi/acpi-build-utils.c | 32 > > include/hw/acpi/acpi-build-utils.h | 5 + > > 2 files chan

Re: [Qemu-devel] [PATCH 0/3] virtio-pci: 1.0 tweaks

2015-01-23 Thread Michael S. Tsirkin
On Fri, Jan 23, 2015 at 09:31:29AM +0100, Gerd Hoffmann wrote: > Hi, > > > Figured notification seems to not be adapted to virtio 1.0 yet: Apply > > this patchset, boot with -device virtio-net-pci,disable-legacy=on, watch > > qemu blow up in virtio_pci_set_host_notifier_internal, because it use

Re: [Qemu-devel] [PATCH RFC 10/17] hw/pci: removed 'rootbus nr is 0' assumption from qmp_pci_query

2015-01-23 Thread Michael S. Tsirkin
On Fri, Jan 23, 2015 at 10:28:39AM +0200, Marcel Apfelbaum wrote: > On 01/23/2015 09:57 AM, Michael S. Tsirkin wrote: > >On Thu, Jan 22, 2015 at 09:52:36PM +0200, Marcel Apfelbaum wrote: > >>From: Marcel Apfelbaum > >> > >>Use the newer pci_bus_num to correctly get the root bus number. > >> > >>Si

Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-23 Thread Michael S. Tsirkin
On Thu, Jan 22, 2015 at 02:49:45PM +, Igor Mammedov wrote: > Adds for dynamic AML creation, which will be used > for piecing ASL/AML primitives together and hiding > from user/caller details about how nested context > should be closed/packed leaving less space for > mistakes and necessity to kn

Re: [Qemu-devel] [PATCH v2 06/47] acpi: add acpi_name() & acpi_name_decl() term

2015-01-23 Thread Michael S. Tsirkin
On Thu, Jan 22, 2015 at 02:49:50PM +, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/acpi/acpi-build-utils.c | 24 > include/hw/acpi/acpi-build-utils.h | 3 +++ > 2 files changed, 27 insertions(+) > > diff --git a/hw/acpi/acpi-build-utils.c b

[Qemu-devel] [PATCH] linux-user/syscall.c: Need call unlock_user() before go to failure return in default case

2015-01-23 Thread Chen Gang S
In abi_long do_ioctl_dm(), after calls lock_user(), it does not call unlock_user() before go to failure return in default case. Signed-off-by: Chen Gang --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index aaac6a2..290fdea

Re: [Qemu-devel] [PATCH v2 11/47] acpi: add acpi_arg0(), acpi_arg1(), acpi_arg2(), acpi_arg3() terms

2015-01-23 Thread Marcel Apfelbaum
On 01/22/2015 04:49 PM, Igor Mammedov wrote: Signed-off-by: Igor Mammedov --- hw/acpi/acpi-build-utils.c | 32 include/hw/acpi/acpi-build-utils.h | 5 + 2 files changed, 37 insertions(+) diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-bui

Re: [Qemu-devel] [PATCH 0/3] virtio-pci: 1.0 tweaks

2015-01-23 Thread Gerd Hoffmann
Hi, > Figured notification seems to not be adapted to virtio 1.0 yet: Apply > this patchset, boot with -device virtio-net-pci,disable-legacy=on, watch > qemu blow up in virtio_pci_set_host_notifier_internal, because it uses > uninitialited proxy->bar without checking. Looked closer, seems the

Re: [Qemu-devel] [sheepdog] [PATCH v3] sheepdog: selectable object size support

2015-01-23 Thread Hitoshi Mitake
At Fri, 23 Jan 2015 17:24:00 +0900, Teruaki Ishizaki wrote: > > Previously, qemu block driver of sheepdog used hard-coded VDI object size. > This patch enables users to handle "block_size_shift" value for > calculating VDI object size. > > When you start qemu, you don't need to specify additional

Re: [Qemu-devel] [PATCH RFC 10/17] hw/pci: removed 'rootbus nr is 0' assumption from qmp_pci_query

2015-01-23 Thread Marcel Apfelbaum
On 01/23/2015 09:57 AM, Michael S. Tsirkin wrote: On Thu, Jan 22, 2015 at 09:52:36PM +0200, Marcel Apfelbaum wrote: From: Marcel Apfelbaum Use the newer pci_bus_num to correctly get the root bus number. Signed-off-by: Marcel Apfelbaum OK for now, but really bus numbers are a wrong thing t

[Qemu-devel] [PATCH v3] sheepdog: selectable object size support

2015-01-23 Thread Teruaki Ishizaki
Previously, qemu block driver of sheepdog used hard-coded VDI object size. This patch enables users to handle "block_size_shift" value for calculating VDI object size. When you start qemu, you don't need to specify additional command option. But when you create the VDI which doesn't have default

Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-23 Thread Michael S. Tsirkin
On Thu, Jan 22, 2015 at 02:49:45PM +, Igor Mammedov wrote: > Adds for dynamic AML creation, which will be used > for piecing ASL/AML primitives together and hiding > from user/caller details about how nested context > should be closed/packed leaving less space for > mistakes and necessity to kn

Re: [Qemu-devel] [PATCH v2 01/47] acpi: introduce AML composer aml_append()

2015-01-23 Thread Michael S. Tsirkin
On Thu, Jan 22, 2015 at 02:49:45PM +, Igor Mammedov wrote: > Adds for dynamic AML creation, which will be used > for piecing ASL/AML primitives together and hiding > from user/caller details about how nested context > should be closed/packed leaving less space for > mistakes and necessity to kn

Re: [Qemu-devel] [PATCH v2 02/47] acpi: add acpi_scope() term

2015-01-23 Thread Michael S. Tsirkin
On Thu, Jan 22, 2015 at 02:49:46PM +, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/acpi/acpi-build-utils.c | 18 ++ > include/hw/acpi/acpi-build-utils.h | 4 > 2 files changed, 22 insertions(+) > > diff --git a/hw/acpi/acpi-build-utils.c b/hw/a

<    1   2