Re: [Qemu-devel] [PATCH v3 4/4] bootdevice: update boot_order in MachineState

2015-02-12 Thread Gonglei
On 2015/2/12 18:21, Markus Armbruster wrote: arei.gong...@huawei.com writes: From: Dinar Valeev dval...@suse.com on sPAPR we need to update boot_order in MachineState in case it got changed on reset. Signed-off-by: Dinar Valeev dval...@suse.com Reviewed-by: Alexey Kardashevskiy

Re: [Qemu-devel] [PATCH] memory: Fix double unref of flatview

2015-02-12 Thread Matthew Rosato
On 02/12/2015 03:43 PM, Paolo Bonzini wrote: On 12/02/2015 20:32, Matthew Rosato wrote: Could it be that the order in which flatview_unref (and therefore memory_region_unref) vs object_unparent(mr) matters (ie, object_unparent should always happen last)? Prior to RCUification, seems like

[Qemu-devel] [PATCH v3 1/2] linux-headers: update KVM headers from KVM_DEV_ARM_VGIC_GRP_CTRL

2015-02-12 Thread Eric Auger
Add a new group/attribute in VGIC KVM device enabling to force vgic init: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT Update according to 3.19 headers. Signed-off-by: Eric Auger eric.au...@linaro.org --- linux-headers/asm-arm/kvm.h | 5 + linux-headers/asm-arm64/kvm.h | 5 +

[Qemu-devel] [PATCH v3 0/2] explicit VGIC initialization in finalize function

2015-02-12 Thread Eric Auger
With current implementation the vgic is initialized implicitly, on-demand. This patch forces the init in the vgic finalize function. At that point all the dimensioning parameters are known. A new group/attribute in VGIC KVM device is used for that:

[Qemu-devel] [PATCH v3 2/2] hw/intc/arm_gic: Initialize the vgic in the realize function

2015-02-12 Thread Eric Auger
This patch forces vgic initialization in the vgic realize function. It uses a new group/attribute that allows such operation. This earlier initialization allows, for example, to setup VFIO signaling and irqfd after vgic initialization, on a reset notifier. Signed-off-by: Eric Auger

[Qemu-devel] [PATCH v10 3/7] hw/vfio/platform: add irq assignment

2015-02-12 Thread Eric Auger
This patch adds the code requested to assign interrupts to a guest. The interrupts are mediated through user handled eventfds only. The mechanics to start the IRQ handling is not yet there through. Signed-off-by: Eric Auger eric.au...@linaro.org --- v8 - v9: - free irq related resources in

[Qemu-devel] [PATCH v10 2/7] hw/vfio/platform: vfio-platform skeleton

2015-02-12 Thread Eric Auger
Minimal VFIO platform implementation supporting register space user mapping but not IRQ assignment. Signed-off-by: Kim Phillips kim.phill...@linaro.org Signed-off-by: Eric Auger eric.au...@linaro.org --- v9 - v10: - vfio_populate_device no more called in common vfio_get_device but in

[Qemu-devel] [PATCH v10 0/7] KVM platform device passthrough

2015-02-12 Thread Eric Auger
This series aims at enabling KVM platform device passthrough. It implements a VFIO platform device, derived from VFIO PCI device. The VFIO platform device uses the host VFIO platform driver which must be bound to the assigned device prior to the QEMU system start. - the guest can directly access

[Qemu-devel] [PATCH v10 1/7] linux-headers: update VFIO header for VFIO platform drivers

2015-02-12 Thread Eric Auger
Update according to vfio.h header found in http://git.linaro.org/people/eric.auger/linux.git branch irqfd_integ_v9 Signed-off-by: Eric Auger eric.au...@linaro.org --- v9 - v10: - AMBA removed v8 - v9: - rewording of the commit message --- linux-headers/linux/vfio.h | 31

[Qemu-devel] [PULL 3/8] tcg: Move emit of INDEX_op_end into gen_tb_end

2015-02-12 Thread Richard Henderson
Reviewed-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/gen-icount.h | 2 ++ target-alpha/translate.c | 2 +- target-arm/translate-a64.c| 1 - target-arm/translate.c| 1 - target-cris/translate.c

[Qemu-devel] [PULL 5/8] tcg: Put opcodes in a linked list

2015-02-12 Thread Richard Henderson
The previous setup required ops and args to be completely sequential, and was error prone when it came to both iteration and optimization. Reviewed-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/gen-icount.h | 22 ++-

[Qemu-devel] [PULL 4/8] tcg: Introduce tcg_op_buf_count and tcg_op_buf_full

2015-02-12 Thread Richard Henderson
The method by which we count the number of ops emitted is going to change. Abstract that away into some inlines. Reviewed-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/translate.c | 14 +++---

[Qemu-devel] [PULL 7/8] tcg: Implement insert_op_before

2015-02-12 Thread Richard Henderson
Rather reserving space in the op stream for optimization, let the optimizer add ops as necessary. Reviewed-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 57 +++--

[Qemu-devel] [PULL 6/8] tcg: Remove opcodes instead of noping them out

2015-02-12 Thread Richard Henderson
With the linked list scheme we need not leave nops in the stream that we need to process later. Reviewed-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/optimize.c | 14 +++--- tcg/tcg.c | 28

[Qemu-devel] [PULL 8/8] tcg: Remove unused opcodes

2015-02-12 Thread Richard Henderson
We no longer need INDEX_op_end to terminate the list, nor do we need 5 forms of nop, since we just remove the TCGOp instead. Reviewed-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg-opc.h | 9 - tcg/tcg.c | 7

[Qemu-devel] [PULL 0/8] Linked list for tcg ops

2015-02-12 Thread Richard Henderson
-20150210.0' into staging (2015-02-11 05:14:41 +) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20150212 for you to fetch changes up to 15fc7daa770764cc795158cbb525569f156f3659: tcg: Remove unused opcodes (2015-02-12 21:21:38 -0800

[Qemu-devel] [PULL 2/8] tcg: Reduce ifdefs in tcg-op.c

2015-02-12 Thread Richard Henderson
Almost completely eliminates the ifdefs in this file, improving confidence in the lesser used 32-bit builds. Reviewed-by: Bastian Koppelmann kbast...@mail.uni-paderborn.de Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tcg-op.c | 449

[Qemu-devel] [PULL 11/12] target-arm: A64: Avoid left shifting negative integers in disas_pc_rel_addr

2015-02-12 Thread Peter Maydell
Shifting a negative integer left is undefined behaviour in C. Avoid it by assembling and shifting the offset fields as unsigned values and then sign extending as the final action. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id:

[Qemu-devel] [PULL 10/12] target-arm: A64: Fix handling of rotate in logic_imm_decode_wmask

2015-02-12 Thread Peter Maydell
The code in logic_imm_decode_wmask attempts to rotate a mask value within the bottom 'e' bits of the value with mask = (mask r) | (mask (e - r)); This has two issues: * if the element size is 64 then a rotate by zero results in a shift left by 64, which is undefined behaviour * if the

[Qemu-devel] [PULL 09/12] target-arm: A64: Fix shifts into sign bit

2015-02-12 Thread Peter Maydell
Fix attempts to shift into the sign bit of an int, which is undefined behaviour in C and warned about by the clang sanitizer. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id: 1423233250-15853-2-git-send-email-peter.mayd...@linaro.org --- target-arm/translate-a64.c | 6 +++--- 1

[Qemu-devel] [PULL 00/12] target-arm queue

2015-02-12 Thread Peter Maydell
The following changes since commit 449008f86418583a1f0fb946cf91ee7b4797317d: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20150210.0' into staging (2015-02-11 05:14:41 +) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Peter Maydell
On 13 February 2015 at 05:44, Chen Gang S gang.c...@sunrus.com.cn wrote: Which issue of correctness will occur? I can not enum it. If the Linux kernel does not implement these syscalls then QEMU must not either. Attempting them should fail, same as if you attempted them with the real kernel.

[Qemu-devel] QOM q1

2015-02-12 Thread boddu pavan
Hi, I have some question on using QOM, new to QEMU and will be great if i can put some answers for below question. 1) If QEMU is considered to be OOP, How is the relation between a Class and Object. I see in c++ we do not create a classobject there will be a object of a class. But here i see

Re: [Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes

2015-02-12 Thread Li, Liang Z
(Li special edition) Current migration code returns number of bytes transferred and from there we decide if we.have sent something or not. Problem, we need two results: number of pages written, and number of bytes written (depending on compression, zero pages, etc, it is not possible to

Re: [Qemu-devel] [PATCH v3 1/2] linux-headers: update KVM headers from KVM_DEV_ARM_VGIC_GRP_CTRL

2015-02-12 Thread Peter Maydell
On 13 February 2015 at 03:37, Eric Auger eric.au...@linaro.org wrote: Add a new group/attribute in VGIC KVM device enabling to force vgic init: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT Update according to 3.19 headers. Is this really a full header sync? I'd have expected it to

Re: [Qemu-devel] [PATCH v3 1/2] linux-headers: update KVM headers from KVM_DEV_ARM_VGIC_GRP_CTRL

2015-02-12 Thread Eric Auger
On 02/13/2015 04:42 AM, Peter Maydell wrote: On 13 February 2015 at 03:37, Eric Auger eric.au...@linaro.org wrote: Add a new group/attribute in VGIC KVM device enabling to force vgic init: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_VGIC_CTRL_INIT Update according to 3.19 headers. Is this really

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chen Gang S
On 2/13/15 06:32, Chris Metcalf wrote: On 2/11/2015 10:48 PM, Chen Gang S wrote: On 2/12/15 11:32, Chen Gang S wrote: +#define EM_TILE 191 /* Tile */ +#define EM_TILE_OLD 0x2597 /* Tile compat */ No need for EM_TILE_OLD - it never really got out into the wild. Also, 191 is

Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()

2015-02-12 Thread Liu Yuan
On Thu, Feb 12, 2015 at 02:49:50PM +0100, Markus Armbruster wrote: If do_sd_create() fails, it first reports the error returned, then reports a another one with strerror(errno). errno is meaningless at that point. Report just one error combining the valid information from both messages.

[Qemu-devel] [RFC 1/3] linux-headers: Update KVM header for KVM-VFIO FORWARD/UNFORWARD

2015-02-12 Thread Eric Auger
Integrate updated KVM-VFIO API related to forwarded IRQ Update according to header found in http://git.linaro.org/people/eric.auger/linux.git branch irqfd_integ_v9 Signed-off-by: Eric Auger eric.au...@linaro.org --- v8 - v9: use new kvm_vfio_dev_irq struct --- linux-headers/linux/kvm.h | 23

[Qemu-devel] [RFC 3/3] hw/vfio/platform: add forwarded irq support

2015-02-12 Thread Eric Auger
Tests whether the forwarded IRQ modality is available. In the positive device IRQs are forwarded. This control is achieved with KVM-VFIO device. with such a modality injection still is handled through irqfds. However end of interrupt is not trapped anymore. As soon as the guest completes its

[Qemu-devel] [RFC 0/3] VFIO Platform device featuring IRQ forwarding

2015-02-12 Thread Eric Auger
This series adds IRQ forwarding support in the VFIO platform device. The VFIO platform device uses the KVM-VFIO device to enable IRQ forwarding. Dependency List: - KVM platform device passthrough PATCH v10 and all its dependencies + following kernel dependencies: - [RFC PATCH 0/9] ARM:

[Qemu-devel] [RFC 2/3] hw/vfio/common: vfio_kvm_device_fd moved in the common header

2015-02-12 Thread Eric Auger
the device is now used in platform for forwarded IRQ setup Signed-off-by: Eric Auger eric.au...@linaro.org --- hw/vfio/common.c | 3 ++- include/hw/vfio/vfio-common.h | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index

Re: [Qemu-devel] [PATCH v4] sheepdog: selectable object size support

2015-02-12 Thread Teruaki Ishizaki
(2015/02/13 11:01), Liu Yuan wrote: On Fri, Feb 13, 2015 at 10:33:04AM +0900, Teruaki Ishizaki wrote: (2015/02/12 11:55), Liu Yuan wrote: On Thu, Feb 12, 2015 at 11:33:16AM +0900, Teruaki Ishizaki wrote: (2015/02/12 11:19), Liu Yuan wrote: On Thu, Feb 12, 2015 at 10:51:25AM +0900, Teruaki

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chen Gang S
On 2/13/15 12:56, Peter Maydell wrote: On 13 February 2015 at 04:43, Chen Gang S gang.c...@sunrus.com.cn wrote: Originally, I have tried to remove TARGET_NR_open and others, they can not pass building, and I also noticed about NR_openat. But at last, I still remain TARGET_NR_open and others

[Qemu-devel] [PULL 03/12] arm: Add PCIe host bridge in virt machine

2015-02-12 Thread Peter Maydell
From: Alexander Graf ag...@suse.de Now that we have a working generic PCIe host bridge driver, we can plug it into ARM's virt machine to always have PCIe available to normal ARM VMs. I've successfully managed to expose a Bochs VGA device, XHCI and an e1000 into an AArch64 VM with this and they

[Qemu-devel] [PULL 08/12] target-arm: Add AArch32 guest support to KVM64

2015-02-12 Thread Peter Maydell
From: Greg Bellows greg.bell...@linaro.org Add 32-bit to/from 64-bit register synchronization on register gets and puts. Set EL1_32BIT feature flag passed to KVM Signed-off-by: Greg Bellows greg.bell...@linaro.org Message-id: 1423736974-14254-5-git-send-email-greg.bell...@linaro.org

[Qemu-devel] [PULL 04/12] pci: Move PCI VGA to pci.mak

2015-02-12 Thread Peter Maydell
From: Alexander Graf ag...@suse.de Every platform that supports PCI can also spawn the Bochs VGA PCI adapter. Move it to pci.mak to enable it for everyone. Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- default-configs/alpha-softmmu.mak

[Qemu-devel] [PULL 05/12] target-arm: Add CPU property to disable AArch64

2015-02-12 Thread Peter Maydell
From: Greg Bellows greg.bell...@linaro.org Adds registration and get/set functions for enabling/disabling the AArch64 execution state on AArch64 CPUs. By default AArch64 execution state is enabled on AArch64 CPUs, setting the property to off, will disable the execution state. The below QEMU

[Qemu-devel] [PULL 01/12] pci: Allocate PCIe host bridge PCI ID

2015-02-12 Thread Peter Maydell
From: Alexander Graf ag...@suse.de We are going to introduce a PCIe host controller that doesn't exist that way in real hardware, but still needs to expose some PCIe root device which has PCI IDs. Allocate a PCI ID in the Red Hat space that we use for other devices of this kind. Signed-off-by:

[Qemu-devel] [PULL 06/12] target-arm: Add feature parsing to virt

2015-02-12 Thread Peter Maydell
From: Greg Bellows greg.bell...@linaro.org Added machvirt parsing of feature keywords added to the -cpu command line option. Parsing occurs during machine initialization. Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by: Peter Maydell peter.mayd...@linaro.org Message-id:

[Qemu-devel] [PULL 12/12] target-arm: A64: Avoid signed shifts in disas_ldst_pair()

2015-02-12 Thread Peter Maydell
Avoid shifting potentially negative signed offset values in disas_ldst_pair() by keeping the offset in a uint64_t rather than an int64_t. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Message-id: 1423233250-15853-5-git-send-email-peter.mayd...@linaro.org --- target-arm/translate-a64.c |

Re: [Qemu-devel] [PATCH 1/4] target-arm: A64: Fix shifts into sign bit

2015-02-12 Thread Greg Bellows
On Fri, Feb 6, 2015 at 8:34 AM, Peter Maydell peter.mayd...@linaro.org wrote: Fix attempts to shift into the sign bit of an int, which is undefined behaviour in C and warned about by the clang sanitizer. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/translate-a64.c |

Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-12 Thread Liu Yuan
On Fri, Feb 13, 2015 at 11:45:42AM +0800, Liu Yuan wrote: From: Liu Yuan liuy...@cmss.chinamobile.com These functions mix up -1 and -errno in return values and would might cause trouble error handling in the call chain. This patch let them return -errno and add some comments.

[Qemu-devel] [PATCH v10 6/7] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation

2015-02-12 Thread Eric Auger
vfio-calxeda-xgmac now can be instantiated using the -device option. The node creation function generates a very basic dt node composed of the compat, reg and interrupts properties Signed-off-by: Eric Auger eric.au...@linaro.org --- v8 - v9: - properly free resources in case of errors in

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Peter Maydell
On 13 February 2015 at 04:43, Chen Gang S gang.c...@sunrus.com.cn wrote: Originally, I have tried to remove TARGET_NR_open and others, they can not pass building, and I also noticed about NR_openat. But at last, I still remain TARGET_NR_open and others (with related comments): - Another

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Wen Congyang
On 02/12/2015 06:26 PM, f...@redhat.com wrote: On Thu, 02/12 18:11, Wen Congyang wrote: On 02/12/2015 05:44 PM, Fam Zheng wrote: On Thu, 02/12 17:33, Wen Congyang wrote: On 02/12/2015 04:44 PM, Fam Zheng wrote: On Thu, 02/12 15:40, Wen Congyang wrote: On 02/12/2015 03:21 PM, Fam Zheng wrote:

Re: [Qemu-devel] [PATCH v7 0/5] block: Add a qemu-iotests case for IO throttling

2015-02-12 Thread Fam Zheng
On Thu, 02/12 16:50, Stefan Hajnoczi wrote: On Fri, Jan 30, 2015 at 10:49:41AM +0800, Fam Zheng wrote: v7: Remove any {iops,bps}_max in 093 completely. (Max) v6: Less resource demanding patch 5. (Max) Add rev-by of Max to other patches. v5: Rebase and improve the test. Please

[Qemu-devel] [PATCH] sheepdog: fix confused return values

2015-02-12 Thread Liu Yuan
From: Liu Yuan liuy...@cmss.chinamobile.com These functions mix up -1 and -errno in return values and would might cause trouble error handling in the call chain. This patch let them return -errno and add some comments. Reported-by: Markus Armbruster arm...@redhat.com Signed-off-by: Liu Yuan

[Qemu-devel] [PATCH v10 7/7] hw/vfio/platform: add irqfd support

2015-02-12 Thread Eric Auger
This patch aims at optimizing IRQ handling using irqfd framework. Instead of handling the eventfds on user-side they are handled on kernel side using - the KVM irqfd framework, - the VFIO driver virqfd framework. the virtual IRQ completion is trapped at interrupt controller This removes the need

[Qemu-devel] [PATCH v10 4/7] hw/vfio/platform: add capability to start IRQ propagation

2015-02-12 Thread Eric Auger
Add a reset notify function that enables to start the propagation of interrupts to the guest. Signed-off-by: Eric Auger eric.au...@linaro.org --- v8 - v9: - handle failure in vfio_irq_starter --- hw/vfio/platform.c | 52 +

[Qemu-devel] [PATCH v10 5/7] hw/vfio: calxeda xgmac device

2015-02-12 Thread Eric Auger
The platform device class has become abstract. This patch introduces a calxeda xgmac device that can be be instantiated on command line using such option. -device vfio-calxeda-xgmac,host=fff51000.ethernet Signed-off-by: Eric Auger eric.au...@linaro.org --- v8 - v9: - renamed calxeda_xgmac.c

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chen Gang S
On 2/13/15 06:31, Chris Metcalf wrote: On 2/11/2015 10:32 PM, Chen Gang S wrote: And excuse me, my English is not quite well, I don't quite understand: fixing anything that breaks as a result. Could you provide more details? Thanks. So if you undefine TARGET_NR_open, etc, hopefully

[Qemu-devel] [PULL 07/12] target-arm: Add 32/64-bit register sync

2015-02-12 Thread Peter Maydell
From: Greg Bellows greg.bell...@linaro.org Add AArch32 to AArch64 register sychronization functions. Replace manual register synchronization with new functions in aarch64_cpu_do_interrupt() and HELPER(exception_return)(). Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by: Peter

[Qemu-devel] [PULL 02/12] pci: Add generic PCIe host bridge

2015-02-12 Thread Peter Maydell
From: Alexander Graf ag...@suse.de With simple exposure of MMFG, ioport window, mmio window and an IRQ line we can successfully create a workable PCIe host bridge that can be mapped anywhere and only needs to get described to the OS using whatever means it likes. This patch implements such a

Re: [Qemu-devel] qemu-2.2.0: Unknown savevm section type 5

2015-02-12 Thread Paolo Bonzini
Has this gone to qemu-stable? it should be in 2.2.1 if there will be such a Release?! It was not CCed, I'll forward it. Paolo

[Qemu-devel] [PATCH 0/5] tile: Can load elf64 tilegx binary successfully for linux-user

2015-02-12 Thread Chen Gang S
After load elf64 tilegx binary for linux-user, the working flow reaches 1st correct instruction __start. Next, we shall load all instructions for qemu using. This patch is based on Linux kernel tile architecture tilegx 64-bit implementation, and also based on tilegx architecture ABI reference.

Re: [Qemu-devel] [PATCH] cocoa.m: Adds console items to the view menu

2015-02-12 Thread Programmingkid
On Feb 11, 2015, at 10:39 PM, Peter Maydell wrote: On 24 January 2015 at 01:56, Programmingkid programmingk...@gmail.com wrote: This patch adds these consoles to the View menu: VGA QEMU Monitor Parallel Serial Signed-off-by: John Arbuckle programmingk...@gmail.com +/* Displays the

[Qemu-devel] [PATCH 0/6] migration: differentiate between pages and bytes

2015-02-12 Thread Juan Quintela
Hi (Li special edition) Current migration code returns number of bytes transferred and from there we decide if we.have sent something or not. Problem, we need two results: number of pages written, and number of bytes written (depending on compression, zero pages, etc, it is not possible to

Re: [Qemu-devel] [PULL 06/37] target-ppc: VXSQRT Should Not Be Set for NaNs

2015-02-12 Thread Maciej W. Rozycki
On Wed, 7 Jan 2015, Alexander Graf wrote: diff --git a/target-ppc/fpu_helper.c b/target-ppc/fpu_helper.c index 7f74466..81db60f 100644 --- a/target-ppc/fpu_helper.c +++ b/target-ppc/fpu_helper.c @@ -920,14 +923,16 @@ uint64_t helper_fsqrt(CPUPPCState *env, uint64_t arg) farg.ll =

Re: [Qemu-devel] [PATCH] bitops.h: sextract64() return type should be int64_t, not uint64_t

2015-02-12 Thread Richard Henderson
On 02/06/2015 06:02 AM, Peter Maydell wrote: The documentation for sextract64() claims that the return type is an int64_t, but the code itself disagrees. Fix the return type to conform to the documentation and to bring it into line with sextract32(), which returns int32_t. Signed-off-by:

Re: [Qemu-devel] [PATCH 0/3] hmp: Normalize HMP command handler names

2015-02-12 Thread Jason Wang
On Thu, Feb 12, 2015 at 6:52 PM, Markus Armbruster arm...@redhat.com wrote: When I can't guess a handler's name, I have to look it up in hmp-commands.hx. Happens often enough to annoy me. Let's make them more predictable. Touches several subsystems because HMP command handlers are still

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-02-12 Thread Fam Zheng
On Fri, 02/13 13:09, Wen Congyang wrote: What is image fleecing? It's the name of the feature which enables the built-in NBD server to exporting a thin point-in-time snapshot created via drive-backup sync=none. It's for host side data scanning tool to access a disk snapshot of running VM. The

Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.

2015-02-12 Thread Chen Gang S
On 2/13/15 13:43, Peter Maydell wrote: On 13 February 2015 at 05:44, Chen Gang S gang.c...@sunrus.com.cn wrote: Which issue of correctness will occur? I can not enum it. If the Linux kernel does not implement these syscalls then QEMU must not either. Attempting them should fail, same as if

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Mark Burton
Up top - thanks Peter, I think you may give us an idea ! On 12 Feb 2015, at 23:10, Lluís Vilanova vilan...@ac.upc.edu wrote: Mark Burton writes: On 12 Feb 2015, at 16:38, Alexander Graf ag...@suse.de wrote: On 12.02.15 15:58, Peter Maydell wrote: On 12 February 2015 at 14:45,

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Mark Burton
On 13 Feb 2015, at 08:24, Peter Maydell peter.mayd...@linaro.org wrote: On 13 February 2015 at 07:16, Mark Burton mark.bur...@greensocs.com wrote: If the kernel is doing this - then effectively - for X86, each CPU only flush’s it’s own TLB (from the perspective of Qemu) - correct? (in

[Qemu-devel] QOM q1

2015-02-12 Thread boddu pavan
Hi, I have some question on using QOM, new to QEMU and will be great if i can put some answers for below question. 1) If QEMU is considered to be OOP, How is the relation between a Class and Object. I see in c++ we do not create a classobject there will be a object of a class. But here i see

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Peter Maydell
On 13 February 2015 at 07:16, Mark Burton mark.bur...@greensocs.com wrote: If the kernel is doing this - then effectively - for X86, each CPU only flush’s it’s own TLB (from the perspective of Qemu) - correct? (in which case, for Qemu itself - for x86) - we dont need to implement a global

Re: [Qemu-devel] [PATCH v4 0/1] block: enforce minimal 4096 alignment in qemu_blockalign

2015-02-12 Thread Denis V. Lunev
On 06/02/15 20:37, Denis V. Lunev wrote: The following sequence int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644); for (i = 0; i 10; i++) write(fd, buf, 4096); iperforms 5% better if buf is aligned to 4096 bytes rather then to 512 bytes. I have used the

Re: [Qemu-devel] [PATCH 0/3] qemu guest agent: support guest-file-* command for Windows

2015-02-12 Thread Denis V. Lunev
On 06/02/15 20:59, Denis V. Lunev wrote: This was a part of patchset implemented guest-exec command. It was suggested to submit it separately by Michael. The set contains small refactoring to fix mingw 4.9.1 compilation and safe part of the rework of posix file interface plus main Windows file

Re: [Qemu-devel] [PATCH] cocoa.m: Adds console items to the view menu

2015-02-12 Thread Gerd Hoffmann
Hi, We're going to need to automatically create and update the menu entries based on which consoles get created if we want this to work properly, I think. Gerd, any suggestions? Is there a hook for list of active consoles has changed? No. consoles are not hotpluggable. What's the

Re: [Qemu-devel] [PATCH v6 0/5] Geometry and blocksize detection for backing devices.

2015-02-12 Thread Kevin Wolf
Am 12.02.2015 um 17:42 hat Christian Borntraeger geschrieben: Am 12.02.2015 um 16:46 schrieb Stefan Hajnoczi: On Mon, Jan 19, 2015 at 03:34:56PM +0100, Ekaterina Tumanova wrote: Updates v5 - v6: Minor Updates according the last review from Stefan Hajnoczi: 1. Do not change the flow of

[Qemu-devel] qemu-2.2.0: Unknown savevm section type 5

2015-02-12 Thread Peter Lieven
Hi, I have a Windows system which fails to migrate with this error almost reliably when migrating from one host to another (both qemu-2.2.0). The error seems to be gone in master, but I was unable to track the exact fix down yet. It seems that the error is related to the amount of memory. 4G

[Qemu-devel] [PATCH v2 02/10] error: Use error_report_err() where appropriate

2015-02-12 Thread Markus Armbruster
Coccinelle semantic patch: @@ expression E; @@ -error_report(%s, error_get_pretty(E)); -error_free(E); +error_report_err(E); @@ expression E, S; @@ -error_report(%s, error_get_pretty(E)); +error_report_err(E); ( exit(S);

[Qemu-devel] Several sheepdog functions mix up -1 and -errno in return values

2015-02-12 Thread Markus Armbruster
Two common conventions for functions returning int that may fail: 1. Return non-negative value on success, -1 value on failure. 2. Return non-negative value on success, a negative errno error code on failure. Both work. But mixing them in the same function is not a good idea. Suspicious

Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes

2015-02-12 Thread Igor Mammedov
On Mon, 9 Feb 2015 17:53:15 -0200 Eduardo Habkost ehabk...@redhat.com wrote: Each CPU can appear in only one NUMA node on the NUMA config. Reject configuration if a CPU appears in multiple nodes. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- numa.c | 27

Re: [Qemu-devel] [PATCH 3/3] virtio-scsi-dataplane: Use main thread BH to set BDS' aio context

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 06:21, Fam Zheng wrote: Before processing a request, virtio-scsi dataplane will check if the backend runs on the same context with it. If not, it has to be moved, with bdrv_set_aio_context. However this function is unsafe to be called from IOThread outside BQL. The reason is

Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 09:08, Pavel Dovgaluk wrote: This is wrong. You have different lifetimes for different modes. Please make a copy of the event in the implementation of record mode. What is the correct way for cloning the QAPI type? I should invent the cloning visitor or just create a

Re: [Qemu-devel] [PATCH 2/2] virtio: remove QEMU definition of VIRTIO_TRANSPORT_F_START/_END

2015-02-12 Thread Peter Maydell
On 12 February 2015 at 13:08, Jens Freimann jf...@linux.vnet.ibm.com wrote: We have defines for VIRTIO_TRANSPORT_F_START/_END in two places. In include/hw/virtio/virtio.h and in linux-headers/linux/virtio_config.h Since we already get virtio_config.h via update-linux-headers.sh, there's no

Re: [Qemu-devel] [PATCH RFC 0/1] qtest: Generic PCI device test

2015-02-12 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Hi Markus, Again thanks for digging into this. Am 29.01.2015 um 15:58 schrieb Markus Armbruster: This test does everything a number of existing tests currently do: ac97-test.c e1000-test.c es1370-test.c eepro100-test.c ne2000-test.c

Re: [Qemu-devel] Help on TLB Flush

2015-02-12 Thread Alexander Graf
On 12.02.2015, at 15:35, Mark Burton mark.bur...@greensocs.com wrote: TLB Flush: We have spent a few days on this issue, and still haven’t resolved the best path. Our solution seems to work, most of the time, but we still have some strange issues - so I want to check that what we

Re: [Qemu-devel] [PATCH v3] qga: add guest-set-user-password command

2015-02-12 Thread Daniel P. Berrange
On Thu, Feb 12, 2015 at 04:21:09PM +0300, Roman Kagan wrote: On Wed, Feb 11, 2015 at 11:26:12AM +, Daniel P. Berrange wrote: Add a new 'guest-set-user-password' command for changing the password of guest OS user accounts. This command is needed to enable OpenStack to support its API for

Re: [Qemu-devel] [PATCH v2] vpc: Implement bdrv_co_get_block_status()

2015-02-12 Thread Max Reitz
On 2015-02-12 at 04:46, Kevin Wolf wrote: This implements bdrv_co_get_block_status() for VHD images. This can significantly speed up qemu-img convert operation because only with this function implemented sparseness can be considered. (Before, converting a 1 TB empty image took several minutes

Re: [Qemu-devel] [PULL 0/4] coverity: Improve and extend model

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 10:11, Markus Armbruster wrote: Yes, the last patch seems to be the culprit. It failed immediately with the __coverity_mark_as_afm_freed__(ptr, g_free) model; Any diagnostics? None. It just says roughly the build had a temporary problem and will be rescheduled. The

Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 10:12, Pavel Dovgaluk wrote: Replay for audio adapter will be added in latter patches. Trying to record/replay machine with audio using current set of patches will break the replay. For this case you can try adding a mechanism similar to migration blockers

[Qemu-devel] Help on TLB Flush

2015-02-12 Thread Mark Burton
TLB Flush: We have spent a few days on this issue, and still haven’t resolved the best path. Our solution seems to work, most of the time, but we still have some strange issues - so I want to check that what we are proposing has a chance of working. Our plan is to allow all CPU’s to

[Qemu-devel] [PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err()

2015-02-12 Thread Markus Armbruster
Tree-wide cleanup, but the tree-wide changes are mechanical. If nobody objects, I'll route it through my own tree. Depends on my [PATCH] vhost-scsi: Improve error reporting for invalid vhostfd. PATCH 01 introduces a helper function, PATCH 02 puts it to use. Responsible for the bulk of the

[Qemu-devel] [PATCH v2 09/10] qemu-img: Avoid qerror_report_err() outside QMP command handlers

2015-02-12 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err(). Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- qemu-img.c | 3 +-- 1 file

[Qemu-devel] [PATCH v2 05/10] net: Avoid qerror_report_err() outside QMP command handlers

2015-02-12 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in HMP command handler hmp_host_net_add() and initial startup helpers net_init_client(), net_init_netdev(). Keep it in QMP

[Qemu-devel] [virtio] virtqueue request size

2015-02-12 Thread Vasile Catalin-B50542
I'm trying to work out virtqueue from the virtio API. I've been able to send a message from guest to qemu, but there is something strange that I don't understand. virtqueue_get_avail_bytes() returns 0 number of in bytes, but if I hard code iov_to_buf() to get 5 bytes, it actually gets my

[Qemu-devel] [PATCH 1/2] update-linux-headers.sh: also grap virtio_types.h

2015-02-12 Thread Jens Freimann
Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com --- scripts/update-linux-headers.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index c8e026d..0b2e117 100755 --- a/scripts/update-linux-headers.sh +++

Re: [Qemu-devel] qemu-2.2.0: Unknown savevm section type 5

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 14:20, Peter Lieven wrote: I have a Windows system which fails to migrate with this error almost reliably when migrating from one host to another (both qemu-2.2.0). The error seems to be gone in master, but I was unable to track the exact fix down yet. It seems that the

[Qemu-devel] [PATCH v2 03/10] monitor: Clean up around monitor_handle_fd_param()

2015-02-12 Thread Markus Armbruster
monitor_handle_fd_param() is a wrapper around monitor_handle_fd_param2() that feeds errors to qerror_report_err() instead of returning them. qerror_report_err() is inappropriate in many contexts. monitor_handle_fd_param() looks simpler than monitor_handle_fd_param2(), which tempts use. Remove

[Qemu-devel] [PATCH v2 10/10] qemu-char: Avoid qerror_report_err() outside QMP command handlers

2015-02-12 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in legacy chardev parser qemu_chr_parse_compat(). Legacy chardev syntax is not to be used in QMP. Signed-off-by: Markus

[Qemu-devel] [PATCH v2 07/10] tpm: Avoid qerror_report_err() outside QMP command handlers

2015-02-12 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in initial startup helper configure_tpm(). Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v2 06/10] numa: Avoid qerror_report_err() outside QMP command handlers

2015-02-12 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in initial startup helper numa_init_func() and board setup helper memory_region_allocate_system_memory(). Signed-off-by:

Re: [Qemu-devel] [PATCH v3] qga: add guest-set-user-password command

2015-02-12 Thread Roman Kagan
On Wed, Feb 11, 2015 at 11:26:12AM +, Daniel P. Berrange wrote: Add a new 'guest-set-user-password' command for changing the password of guest OS user accounts. This command is needed to enable OpenStack to support its API for changing the admin password of guests running on KVM/QEMU. It

Re: [Qemu-devel] [v5 09/12] migration: Make compression co-work with xbzrle

2015-02-12 Thread Juan Quintela
Li, Liang Z liang.z...@intel.com wrote: Liang Li liang.z...@intel.com wrote: Now, multiple thread compression can co-work with xbzrle. when xbzrle is on, multiple thread compression will only work at the first round of RAM data sync. Signed-off-by: Liang Li liang.z...@intel.com

[Qemu-devel] [PATCH/RFC 0/2] update-linux-headers.sh and virtio

2015-02-12 Thread Jens Freimann
Hi, currently when sync'ing linux-headers against kvm/next, qemu/master won't build because of two problems: 1. virtio_types.h needs to be copied to QEMU linux-headers, as it is now included by virtio_ring.h Patch 2 adds virtio_types.h two update-linux-headers.sh. 2. VIRTIO_TRANSPORT_F_END

[Qemu-devel] [PATCH 2/2] virtio: remove QEMU definition of VIRTIO_TRANSPORT_F_START/_END

2015-02-12 Thread Jens Freimann
We have defines for VIRTIO_TRANSPORT_F_START/_END in two places. In include/hw/virtio/virtio.h and in linux-headers/linux/virtio_config.h Since we already get virtio_config.h via update-linux-headers.sh, there's no need to have duplicate defines in QEMU headers files. Let's remove this define

[Qemu-devel] [PATCH v2 08/10] vl: Avoid qerror_report_err() outside QMP command handlers

2015-02-12 Thread Markus Armbruster
qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in initial startup helpers machine_set_property() and object_create(). Signed-off-by: Markus Armbruster arm...@redhat.com

<    1   2   3   >