On 18/02/2015 05:59, David Gibson wrote:
> As PCI devices, the i82801b11 and ioh3420 devices could theoretically exist
> on any platform with a PCI bus. However in practice, they're Intel
> specific devices,
They can be used as a generic PCIe root port and PCIe-to-PCI bridge,
they're not Intel-
On 18/02/2015 06:28, David Gibson wrote:
> Despite the name, "platform-bus" is used only by PPC E500 targets. This
> patch alters the default config to include it in the build only when E500
> is enabled.
>
> Signed-off-by: David Gibson
> ---
> hw/core/Makefile.objs | 2 +-
> 1 file changed,
On 17/02/2015 22:33, Max Reitz wrote:
> Concurrently modifying the bmap is not a good idea; this patch adds a
> lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what
> can go wrong without.
>
> Signed-off-by: Max Reitz
> ---
> block/vdi.c | 23 ---
> 1 file
> Am 18.02.2015 um 06:28 schrieb David Gibson :
>
> Despite the name, "platform-bus" is used only by PPC E500 targets. This
> patch alters the default config to include it in the build only when E500
> is enabled.
>
> Signed-off-by: David Gibson
It's not e500 specific though. I'm hoping to
On Wed, Feb 18, 2015 at 03:59:56PM +1100, David Gibson wrote:
> As PCI devices, the i82801b11 and ioh3420 devices could theoretically exist
> on any platform with a PCI bus. However in practice, they're Intel
> specific devices, that are very unlikely to appear on anything other than
> an x86. Th
On (Tue) 17 Feb 2015 [20:13:25], Dr. David Alan Gilbert wrote:
> * Eric Blake (ebl...@redhat.com) wrote:
> > On 02/17/2015 07:59 AM, Amit Shah wrote:
> > >>>
> > >>> So the only comment I have is with the 'pause' name.
> > >>>
> > >>> 'pause' to me means there's a time period for which a pause has
On (Tue) 17 Feb 2015 [09:14:27], Eric Blake wrote:
> On 02/17/2015 07:59 AM, Amit Shah wrote:
> >>>
> >>> So the only comment I have is with the 'pause' name.
> >>>
> >>> 'pause' to me means there's a time period for which a pause has to be
> >>> done; or pausing an activity which is already in pro
Despite the name, "platform-bus" is used only by PPC E500 targets. This
patch alters the default config to include it in the build only when E500
is enabled.
Signed-off-by: David Gibson
---
hw/core/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/Makefil
As PCI devices, the i82801b11 and ioh3420 devices could theoretically exist
on any platform with a PCI bus. However in practice, they're Intel
specific devices, that are very unlikely to appear on anything other than
an x86. Therefore this patch gives them their own config options, enabled
only f
A number of ARM embedded boards include EHCI USB host controllers which
appear as directly mapped devices, rather than sitting on a PCI bus.
At present code to emulate such devices is included whenever EHCI support
is included. This patch adjusts teh config options to only include them
in builds
This patch adds the Cortex-A9 ARM CPU to the A9MPCore.
The CPU is only created if the num-cpu property is set.
This patch allows the midr and reset-cbar properties to be set
Signed-off-by: Alistair Francis
---
V2:
- Rename num_cpus function to match QOM style
- Connect all CPUs to the GIC
Cha
This patch removes the initialisation of the ARM Cortex-A9
in Zynq and instead allows the a9mpcore device to init the
CPU. This also updates components that rely on the CPU
and GIC, as they are now initialised in a slightly different
way
Signed-off-by: Alistair Francis
---
V2:
- Reoder the qdev
From: Liu Yuan
These functions mix up -1 and -errno in return values and would might cause
trouble error handling in the call chain.
This patch let them return -errno and add some comments.
Cc: qemu-devel@nongnu.org
Cc: Markus Armbruster
Cc: Kevin Wolf
Cc: Stefan Hajnoczi
Reported-by: Markus
On Mon, Feb 16, 2015 at 12:56:04PM +0100, Kevin Wolf wrote:
> Am 13.02.2015 um 04:45 hat Liu Yuan geschrieben:
> > From: Liu Yuan
> >
> > These functions mix up -1 and -errno in return values and would might cause
> > trouble error handling in the call chain.
> >
> > This patch let them return -
On Tue, Feb 10, 2015 at 4:44 PM, Peter Crosthwaite
wrote:
> On Wed, Jan 21, 2015 at 5:06 PM, Alistair Francis
> wrote:
>> This patch adds the Cortex-A9 ARM CPU to the A9MPCore.
>>
>> The CPU is only created if the num-cpu property is set.
>>
>> This patch relies on Stefan Hajnoczi's v3 'virtio-bl
On Tue, Feb 10, 2015 at 4:45 PM, Peter Crosthwaite
wrote:
> On Wed, Jan 21, 2015 at 5:06 PM, Alistair Francis
> wrote:
>> This patch removes the initialisation of the ARM Cortex-A9
>> in Zynq and instead allows the a9mpcore device to init the
>> CPU. This also updates components that rely on the
On Tue, Feb 17, 2015 at 01:14:33PM +1100, Alexey Kardashevskiy wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 02/02/2015 06:04 PM, David Gibson wrote:
> > On Thu, Jan 29, 2015 at 08:27:20PM +1100, Alexey Kardashevskiy
> wrote:
[snip]
> >> +vfio_mem_unregister(container, vaddr,
On Tue, Feb 17, 2015 at 01:36:38PM +1100, Alexey Kardashevskiy wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 02/05/2015 03:49 PM, David Gibson wrote:
> > On Thu, Jan 29, 2015 at 08:27:30PM +1100, Alexey Kardashevskiy wrote:
> >> TCE hypercalls (H_PUT_TCE, H_PUT_TCE_INDIRECT, H_ST
On Tue, Feb 17, 2015 at 11:34:27AM +1100, Alexey Kardashevskiy wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 02/05/2015 03:19 PM, David Gibson wrote:
> > On Thu, Jan 29, 2015 at 08:27:27PM +1100, Alexey Kardashevskiy wrote:
> >> This enables multiple IOMMU groups in one VFIO cont
On 18 February 2015 at 04:33, Waldemar Brodkorb wrote:
> I am regulary using qemu with arm.
> Since Linux 3.19 my system no longer boots.
> I am using Qemu 2.2.0 on Linux/amd64.
>
> System is started via:
> qemu-system-arm -nographic -M vexpress-a9 -cpu cortex-a9 -net user
> -net nic,model=lan9118
On 02/17/2015 07:56 PM, Richard Henderson wrote:
On 02/11/2015 08:49 AM, Bastian Koppelmann wrote:
-OPC2_32_RRR2_MADD_U_32 = 0x68,
+OPC2_32_RRR2_MADD_U_64 = 0x68,
I guess this is a change to the spec, after the V1.0, 2012-05 edition that I
h
On 2/17/15 23:58, Richard Henderson wrote:
> On 02/16/2015 06:59 PM, Chen Gang S wrote:
>> I have the related documents, but I can not find pc register, and I
>> originally misunderstood lr can be treated as pc. After I know we can
>> not treat lr as pc, so I want to consult about it for confirmati
The following changes since commit cd2d5541271f1934345d8ca42f5fafff1744eee7:
Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150212' into
staging (2015-02-13 11:44:50 +)
are available in the git repository at:
git://github.com/mdroth/qemu.git tags/qga-pull-2015-02-16-v2-tag
From: zhanghailiang
We can change guest's online/offline state of memory blocks, by using
command 'guest-set-memory-blocks'.
Signed-off-by: zhanghailiang
Signed-off-by: Michael Roth
---
qga/commands-posix.c | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
From: Simon Zolin
Moved the code that sets non-blocking flag on fd into a separate function.
Signed-off-by: Simon Zolin
Reviewed-by: Roman Kagan
Signed-off-by: Denis V. Lunev
CC: Michael Roth
CC: Eric Blake
Signed-off-by: Michael Roth
---
qga/commands-posix.c | 31 +++-
From: zhanghailiang
This conveys general information about guest memory blocks. Currently,
just the memory block size.
The size of a memory block is architecture dependent, it represents the logical
unit upon which memory online/offline operations are to be performed.
Signed-off-by: zhanghailia
From: zhanghailiang
We can get guest's memory block information by using command
"guest-get-memory-blocks", the returned value contains a list of memory block
info, such as phys-index, online state, can-offline info.
Signed-off-by: zhanghailiang
*replaced guest-triggerable assertion with an er
From: zhanghailiang
Introduce three new guest commands:
guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size.
With these three commands, we can support online/offline guest's memory block
(logical memory hotplug/unplug) as required from host.
Signed-off-by: zhanghailian
From: Olga Krishtal
The following commands are implemented:
- guest_file_open
- guest_file_close
- guest_file_write
- guest_file_read
- guest_file_seek
- guest_file_flush
Motivation is quite simple: Windows guests should be supported with the
same set of features as Linux one. Also this patch is
From: Michal Privoznik
The command is not implemented correctly yet. The documentation allows
to not pass any value to set, in which case the time is re-read from
RTC. However, reading CMOS on Windows is not trivial to implement. So
instead of pretending we've set the correct time, fail explicitl
From: Olga Krishtal
The problem is that mingw 4.9.1 fails to compile the code with the
following warning:
/mingw/include/string.h:88:9: note: previous declaration of 'strtok_r'
was here
char *strtok_r(char * __restrict__ _Str,
const char * __restrict__ _Delim,
From: "Daniel P. Berrange"
Add a new 'guest-set-user-password' command for changing the password
of guest OS user accounts. This command is needed to enable OpenStack
to support its API for changing the admin password of guests running
on KVM/QEMU. It is not practical to provide a command at the
From: zhanghailiang
For memory block command, we only support for linux with sysfs.
Signed-off-by: zhanghailiang
Reviewed-by: Michael Roth
Signed-off-by: Michael Roth
---
qga/commands-posix.c | 4 +++-
qga/commands-win32.c | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a
Hi,
I am regulary using qemu with arm.
Since Linux 3.19 my system no longer boots.
I am using Qemu 2.2.0 on Linux/amd64.
System is started via:
qemu-system-arm -nographic -M vexpress-a9 -cpu cortex-a9 -net user
-net nic,model=lan9118 -kernel qemu-arm-initramfspiggyback-kernel
I have read, they c
Cc: qemu-stable
On 17/02/2015 22:33, Max Reitz wrote:
> Concurrently modifying the bmap is not a good idea; this patch adds a
> lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what
> can go wrong without.
>
> Signed-off-by: Max Reitz
> ---
> block/vdi.c | 23 +
On 2015-02-17 at 16:49, Paolo Bonzini wrote:
Cc: qemu-stable
Right, I forgot that. Thanks!
Max
On 17/02/2015 22:33, Max Reitz wrote:
Concurrently modifying the bmap is not a good idea; this patch adds a
lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what
can go wrong wit
Concurrently modifying the bmap is not a good idea; this patch adds a
lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what
can go wrong without.
Signed-off-by: Max Reitz
---
block/vdi.c | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a
Adding some locking in qemu's VDI implementation makes the bug
disappear, at least I can't reproduce it anymore. I'll send a patch.
Max
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1422307
Title:
* Eric Blake (ebl...@redhat.com) wrote:
> On 02/17/2015 07:59 AM, Amit Shah wrote:
> >>>
> >>> So the only comment I have is with the 'pause' name.
> >>>
> >>> 'pause' to me means there's a time period for which a pause has to be
> >>> done; or pausing an activity which is already in progress, both
On 02/11/2015 08:48 AM, Bastian Koppelmann wrote:
> Bastian Koppelmann (6):
> target-tricore: Fix RLC_ADDI, RLC_ADDIH using wrong microcode helper
> target-tricore: fix msub32_suov return wrong results
> target-tricore: Add instructions of RRR2 opcode format
> target-tricore: Add instructio
On 02/11/2015 08:49 AM, Bastian Koppelmann wrote:
> -OPC2_32_RRR2_MADD_U_32 = 0x68,
> +OPC2_32_RRR2_MADD_U_64 = 0x68,
I guess this is a change to the spec, after the V1.0, 2012-05 edition that I
have?
r~
On Mon, Feb 09, 2015 at 10:53:26AM +, Igor Mammedov wrote:
> it will be reused for adding a plain integer value into AML.
>
> Signed-off-by: Igor Mammedov
> ---
> hw/acpi/aml-build.c | 19 +++
> hw/i386/acpi-build.c | 6 +++---
> 2 files changed, 6 insertions(+), 19 deletio
On Mon, Feb 09, 2015 at 10:53:23AM +, Igor Mammedov wrote:
> Adds for dynamic AML creation, which will be used
> for piecing ASL/AML primitives together and hiding
> from user/caller details about how nested context
> should be closed/packed leaving less space for
> mistakes and necessity to kn
On Mon, Feb 09, 2015 at 10:53:43AM +, Igor Mammedov wrote:
> Replace AML template patching with direct composing
> of PCI device entries in C. It allows to simplify
> PCI tree generation further and saves us about 400LOC
> scattered through different files, confining tree
> generation to one C
I succeeded to reproduce the bug without NBD:
$ ./qemu-img create -f vdi test.vdi 2G
Formatting 'test.vdi', fmt=vdi size=2147483648 static=off
$ ./qemu-img create -f raw test.raw 2G
Formatting 'test.raw', fmt=raw size=2147483648
$ x86_64-softmmu/qemu-system-x86_64 -enable-kvm -drive
if=virtio,fil
On Tue, Feb 17, 2015 at 06:51:16PM +0100, Igor Mammedov wrote:
> On Tue, 17 Feb 2015 17:47:03 +0100
> "Michael S. Tsirkin" wrote:
>
> > This seems to change the contents of the tables in too many ways. So of
> > it needs changing since PCI are somewhat broken by your recent patch.
> In which way
On 02/17/2015 07:24 AM, Michael Mueller wrote:
> The option --probe allows to switch into probe mode also for machines
> different from none. If one or more accelerators are specified these
> accelerators are used to provide probable properties. If no accelerator
> is given a list of accellerators
On Tue, Feb 17, 2015 at 05:47:26PM +0100, Igor Mammedov wrote:
> On Tue, 17 Feb 2015 17:35:55 +0100
> "Michael S. Tsirkin" wrote:
>
> > On Mon, Feb 09, 2015 at 10:53:27AM +, Igor Mammedov wrote:
> > > Signed-off-by: Igor Mammedov
> > > ---
> > > hw/acpi/aml-build.c | 38
On 02/17/2015 11:45 AM, John Snow wrote:
>>>
>> Hmm.. No? bitmap is attached using bdrv_lookup_bs(name, name, errp),
>> which can find device with this name. qemu option -drive
>> file=...,id=disk creates blk named 'disk' and attached node with no name.
>>
>>
>
> Very good point -- We use the dev
On Tue, Feb 17, 2015 at 05:47:26PM +0100, Igor Mammedov wrote:
> On Tue, 17 Feb 2015 17:35:55 +0100
> "Michael S. Tsirkin" wrote:
>
> > On Mon, Feb 09, 2015 at 10:53:27AM +, Igor Mammedov wrote:
> > > Signed-off-by: Igor Mammedov
> > > ---
> > > hw/acpi/aml-build.c | 38
On Tue, Feb 17, 2015 at 06:50:11PM +0100, Igor Mammedov wrote:
> On Tue, 17 Feb 2015 17:26:16 +0100
> "Michael S. Tsirkin" wrote:
>
> > On Mon, Feb 09, 2015 at 10:53:23AM +, Igor Mammedov wrote:
> > > Adds for dynamic AML creation, which will be used
> > > for piecing ASL/AML primitives toget
On Tue, Feb 17, 2015 at 02:52:08PM +0100, Igor Mammedov wrote:
> On Tue, 17 Feb 2015 11:05:39 +0100
> "Michael S. Tsirkin" wrote:
>
> > This fixes multiple issues around ACPI RAM management:
> >
> > RSDP and linker RAM aren't currently marked dirty
> > on update, so they won't be migrated correc
On 02/17/2015 03:54 AM, Vladimir Sementsov-Ogievskiy wrote:
On 16.02.2015 21:18, John Snow wrote:
On 02/16/2015 07:06 AM, Vladimir Sementsov-Ogievskiy wrote:
On 13.02.2015 23:22, John Snow wrote:
On 02/13/2015 03:19 AM, Vladimir Sementsov-Ogievskiy wrote:
On 11.02.2015 00:33, John Snow
Quoting Michael Roth (2015-02-16 21:14:42)
> The following changes since commit cd2d5541271f1934345d8ca42f5fafff1744eee7:
Please disregard, will send a v2 shortly to address review new comments.
>
> Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150212' into
> staging (2015-02-13 1
First insight: Having the VDI image in tmpfs or using --cache=none for
qemu-nbd changes nothing, therefore the reason why dropping the caches
affects the result is probably Linux's cache for the NBD block device.
Second insight: Using blkverify makes it look very much like qemu's VDI
implementatio
On 02/17/2015 07:24 AM, Michael Mueller wrote:
> This patch implements the QMP command 'query-cpu-definitions' in the S390
> context. The command returns a in terms of machine release date descending
> sorted list of cpu model names in the current host context.
returns a list of cpu model names so
Quoting Eric Blake (2015-02-17 09:26:12)
> On 02/16/2015 08:14 PM, Michael Roth wrote:
> > From: zhanghailiang
> >
> > Introduce three new guest commands:
> > guest-get-memory-blocks, guest-set-memory-blocks,
> > guest-get-memory-block-size.
>
> Sorry for the late review, but I think guest-get-
On 17/02/15 20:56, Michael Roth wrote:
Quoting Denis V. Lunev (2015-02-17 10:06:49)
On 17/02/15 18:27, Eric Blake wrote:
On 02/16/2015 08:14 PM, Michael Roth wrote:
From: Simon Zolin
Moved the code that sets non-blocking flag on fd into a separate function.
Signed-off-by: Simon Zolin
Revie
On 02/17/2015 07:24 AM, Michael Mueller wrote:
> This patch implements a new QMP request named 'query-cpu-model'.
> It returns the cpu model of cpu 0 and its backing accelerator.
>
> request:
> {"execute" : "query-cpu-model" }
>
> answer:
> {"return" : {"name": "2827-ga2", "accelerator": "kvm
On 02/17/2015 10:56 AM, Michael Roth wrote:
> In any case, since I was actually the one who re-invented it,
> and this code just moves it to another function, I think we
> can address it as a seperate patch and leave the PULL
> intact (unless there are other objections).
Agree that a separate clea
Quoting Denis V. Lunev (2015-02-17 10:06:49)
> On 17/02/15 18:27, Eric Blake wrote:
> > On 02/16/2015 08:14 PM, Michael Roth wrote:
> >> From: Simon Zolin
> >>
> >> Moved the code that sets non-blocking flag on fd into a separate function.
> >>
> >> Signed-off-by: Simon Zolin
> >> Reviewed-by: Ro
On Tue, 17 Feb 2015 17:47:03 +0100
"Michael S. Tsirkin" wrote:
> This seems to change the contents of the tables in too many ways. So of
> it needs changing since PCI are somewhat broken by your recent patch.
In which way is it broken?
>
> So let's do this: please prepare a minimal patchset th
On Tue, 17 Feb 2015 17:26:16 +0100
"Michael S. Tsirkin" wrote:
> On Mon, Feb 09, 2015 at 10:53:23AM +, Igor Mammedov wrote:
> > Adds for dynamic AML creation, which will be used
> > for piecing ASL/AML primitives together and hiding
> > from user/caller details about how nested context
> > sh
For whatever reason, using an empty image now works for me, too:
$ ./qemu-img create -f vdi test.vdi 64M; ./qemu-nbd -c /dev/nbd0 test.vdi; dd
if=/dev/urandom of=/dev/nbd0 bs=1K count=16384; md5sum /dev/nbd0; sync; echo 1
> /proc/sys/vm/drop_caches; md5sum /dev/nbd0; ./qemu-nbd -d /dev/nbd0
Form
On 02/17/2015 09:53 AM, Daniel P. Berrange wrote:
> On Tue, Feb 17, 2015 at 05:40:45PM +0100, Michal Privoznik wrote:
>> So, imagine you've started a guest with ticketing enabled. You've set
>> some password to access your SPICE/VNC session. However, later you
>> want to give the access to somebody
Quoting David Gibson (2015-02-09 22:36:16)
> When the guest switches the interrupt endian mode, which essentially
> means a global machine endian switch, we want to change the VGA
> framebuffer endian mode as well in order to be backward compatible
> with existing guests who don't know about the ne
On 02/17/2015 03:19 AM, Kevin Wolf wrote:
>> if (num_fixed) {
>> ret = update_refcount(bs, i << s->cluster_bits, 1,
>> - refcount2 - refcount1,
>> + (int)refcount2 - (int)refcount1,
>>
On Tue, Feb 17, 2015 at 05:40:45PM +0100, Michal Privoznik wrote:
> So, imagine you've started a guest with ticketing enabled. You've set
> some password to access your SPICE/VNC session. However, later you
> want to give the access to somebody else's and therefore disable the
> ticketing. Come on,
On Tue, 17 Feb 2015 17:35:55 +0100
"Michael S. Tsirkin" wrote:
> On Mon, Feb 09, 2015 at 10:53:27AM +, Igor Mammedov wrote:
> > Signed-off-by: Igor Mammedov
> > ---
> > hw/acpi/aml-build.c | 38 ++
> > hw/i386/acpi-build.c| 4
> > in
On 02/16/2015 07:44 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> qtest.c | 11 ---
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt
This seems to change the contents of the tables in too many ways. So of
it needs changing since PCI are somewhat broken by your recent patch.
So let's do this: please prepare a minimal patchset that just generates
PCI description dynamically. Drop everything that's not necessary, and
verify that
On 02/16/2015 07:44 AM, Markus Armbruster wrote:
> Less code, same result.
>
> Signed-off-by: Markus Armbruster
> ---
> hw/i386/pc.c | 11 +++
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt vir
On 02/16/2015 07:44 AM, Markus Armbruster wrote:
> Don't convert numbers or bools to strings for use with qemu_opt_set(),
> simply use qemu_opt_set_number() or qemu_opt_set_bool() instead.
>
> Signed-off-by: Markus Armbruster
> ---
> util/qemu-sockets.c | 16 +++-
> 1 file changed, 7
On Mon, Feb 09, 2015 at 10:54:09AM +, Igor Mammedov wrote:
> It completes dynamic SSDT generation and makes it
> independed of IASL binary blobs. It also hides
> from user all pointer arithmetic when building
> SSDT which makes resulting code a bit cleaner
> and concentrating only on composing
On Mon, Feb 09, 2015 at 10:53:28AM +, Igor Mammedov wrote:
> it replaces prebuilt SSDT table header template copying/patching
> with AML API
>
> Signed-off-by: Igor Mammedov
I note that this changed the SSDT signature in random ways,
for example, it used to be named BXPCSSDT, now it's BXPC.
On 02/16/2015 07:44 AM, Markus Armbruster wrote:
> Don't convert numbers to strings for use with qemu_opt_set(), simply
> use qemu_opt_set_number() instead.
>
> Signed-off-by: Markus Armbruster
> ---
> blockdev.c | 4 +---
> vl.c | 13 ++---
> 2 files changed, 7 insertions(+), 10
This is quite easy. SPICE has a function to disable ticketing.
So, if no password was provided, call the function, and if a
password was provided, call another function to actually set it.
Signed-off-by: Michal Privoznik
---
ui/spice-core.c | 15 +--
1 file changed, 13 insertions(+),
On Mon, Feb 09, 2015 at 10:53:45AM +, Igor Mammedov wrote:
> QEMU doesn't implement/advertize PM1b_CNT_BLK
> register block so do not set/patch its \_Sx
> values to avoid confusion.
>
> Signed-off-by: Igor Mammedov
I doubt guests are confused.
I think you mean this confuses you, but I'd rath
Well, this is a bit difficult since VNC has many ways of
authentication. So, if no password was provided, the current
authentication method is held in a variable (oldauth) and the
method is set to VNC_AUTH_NONE to mark it explicitly that no
password is required. However, as soon as the password is
Currently, if the ticketing (password) is not set at the command
line, there's no way how to set it afterwards. Or vice versa -
disable previously set password. I think it's worth allowing
users to do that. The use case may be a teacher, who wants to
share a graphical session with students, but has
So, imagine you've started a guest with ticketing enabled. You've set
some password to access your SPICE/VNC session. However, later you
want to give the access to somebody else's and therefore disable the
ticketing. Come on, be imaginative! Currently, there's no way how to
achieve this. And while
On Feb 17, 2015, at 4:44 AM, Gerd Hoffmann wrote:
> Add a new function to get a nice label for a given QemuConsole.
> Drop the labeling code in gtk.c and use the new function instead.
>
> Signed-off-by: Gerd Hoffmann
> ---
> include/ui/console.h | 1 +
> ui/console.c | 15 ++
The alternative to removing existing comments.
Signed-off-by: Radim Krčmář
---
v2: new
hw/display/qxl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index 61df47726481..6e9079783e27 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -120,9 +1
Series contains two logical parts:
[1-2/4] fix a segfault after user misconfiguration (too big vgamem_mb),
[3-4/4] improve code that was modified by [2/4].
v2 summary:
- added [1/4] to explain the size bump in [2/4]
- modified Gerd's proposed solution as [2/4]
- added [3/4] to have at least one ni
On Mon, Feb 09, 2015 at 10:53:27AM +, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
> ---
> hw/acpi/aml-build.c | 38 ++
> hw/i386/acpi-build.c| 4
> include/hw/acpi/aml-build.h | 10 ++
> 3 files changed, 48 insertions(+
We already have pow2floor, mirror it and use instead of a function with
similar results (same in used domain), to clarify our intent.
Signed-off-by: Radim Krčmář
---
v2: new
hw/display/qxl.c | 23 +--
include/qemu-common.h | 3 +++
util/cutils.c | 14
Make the code a bit more obvious.
We don't have min/max, so a general helper for clamp probably isn't
acceptable either.
Signed-off-by: Radim Krčmář
---
v2: kept rounding and clamping (was [v1 1/2])
hw/display/vga.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
vga_common_init() doesn't allow more than 256 MiB vram size and silently
shrinks any larger value. qxl_dirty_surfaces() used the unshrinked size
via qxl->shadow_rom.surface0_area_size when accessing the memory, which
resulted in segfault.
Add a workaround for this case and an assert if it happens
On Mon, Feb 09, 2015 at 10:53:23AM +, Igor Mammedov wrote:
> Adds for dynamic AML creation, which will be used
> for piecing ASL/AML primitives together and hiding
> from user/caller details about how nested context
> should be closed/packed leaving less space for
> mistakes and necessity to kn
On 02/17/2015 07:59 AM, Amit Shah wrote:
>>>
>>> So the only comment I have is with the 'pause' name.
>>>
>>> 'pause' to me means there's a time period for which a pause has to be
>>> done; or pausing an activity which is already in progress, both of
>>> which are not true for this case.
>>
>> I th
On Tue, Feb 17, 2015 at 05:02:12PM +0900, Peter Maydell wrote:
> On 15 February 2015 at 02:44, Leon Alrae wrote:
> > Hi,
> >
> > Here is version 2 of target-mips pullreq - rebased and with signed tag.
>
> Just fyi, this hotel's wifi and my work VPN seem to disagree with
> each other, so probably
On 02/16/2015 06:59 PM, Chen Gang S wrote:
> I have the related documents, but I can not find pc register, and I
> originally misunderstood lr can be treated as pc. After I know we can
> not treat lr as pc, so I want to consult about it for confirmation.
Section 3.4 Program Counter, concisely desc
On 02/17/2015 07:39 AM, Stefan Hajnoczi wrote:
> The block.c file has grown to over 6000 lines. It is time to split this
> file so there are fewer conflicts and the code is easier to maintain.
>
> Extract I/O request processing code:
> * Read
> * Write
> * Zero writes and making the image empt
Am 17.02.2015 um 16:40 hat Stefan Hajnoczi geschrieben:
> On Tue, Feb 17, 2015 at 05:55:53PM +0800, Fam Zheng wrote:
> > Since commit 1dc936aa84 (virtio-blk: Use blk_aio_ioctl) we silently lose
> > the request if blk_aio_ioctl returns NULL (not implemented).
> >
> > Fix it by directly returning VI
On 17/02/15 18:27, Eric Blake wrote:
On 02/16/2015 08:14 PM, Michael Roth wrote:
From: Simon Zolin
Moved the code that sets non-blocking flag on fd into a separate function.
Signed-off-by: Simon Zolin
Reviewed-by: Roman Kagan
Signed-off-by: Denis V. Lunev
CC: Michael Roth
CC: Eric Blake
On Feb 17, 2015, at 4:57 AM, Kevin Wolf wrote:
> Am 17.02.2015 um 10:41 hat Peter Maydell geschrieben:
>> On 17 February 2015 at 18:07, Kevin Wolf wrote:
>>> The ID is user-defined, so no, no assumption about it is safe. If you
>>> like, you can name your floppy drive 'ide0-cd1', your virtio ha
On Tue, Feb 17, 2015 at 05:55:53PM +0800, Fam Zheng wrote:
> Since commit 1dc936aa84 (virtio-blk: Use blk_aio_ioctl) we silently lose
> the request if blk_aio_ioctl returns NULL (not implemented).
>
> Fix it by directly returning VIRTIO_BLK_S_UNSUPP as we used to do.
>
> Signed-off-by: Fam Zheng
On Tue, Feb 17, 2015 at 02:49:25PM +0100, Kevin Wolf wrote:
> The only user went away five years ago with commit a9420734 ('qcow2:
> Simplify image creation'). It's about time to remove it.
>
> Signed-off-by: Kevin Wolf
> ---
> block/qcow2.h | 11 ---
> 1 file changed, 11 deletions(-)
R
On 02/16/2015 08:14 PM, Michael Roth wrote:
> From: zhanghailiang
>
> Introduce three new guest commands:
> guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size.
Sorry for the late review, but I think guest-get-memory-block-size is
the wrong command to add.
> +##
> +#
On 02/16/2015 08:14 PM, Michael Roth wrote:
> From: Simon Zolin
>
> Moved the code that sets non-blocking flag on fd into a separate function.
>
> Signed-off-by: Simon Zolin
> Reviewed-by: Roman Kagan
> Signed-off-by: Denis V. Lunev
> CC: Michael Roth
> CC: Eric Blake
> Signed-off-by: Micha
1 - 100 of 220 matches
Mail list logo
