On 05/08/2015 11:21 AM, Kevin Wolf wrote:
Eventually we want to be able to change options at runtime. As a first
step towards that goal, separate some option handling code from the
general initialisation code in qcow2_open().
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/qcow2.c |
On 05/12/2015 10:09 AM, Daniel P. Berrange wrote:
The qemu-io tool does not check if the image is encrypted so
historically would silently corrupt the sectors by writing
plain text data into them instead of cipher text. The earlier
commit turns this mistake into a fatal abort, so check for
For larger pieces of data that won't need to be debugged and
viewing the hex nibbles is unlikely to be useful, we can encode
data using base64 instead of encoding each byte as %02x, which
leads to some space savings and faster reads/writes.
For now, the default is left as hex nibbles in
|| probably does not mean the same thing as |.
Additionally, allow users to submit a prd_size of 0
to indicate that they'd like to continue using the default.
Signed-off-by: John Snow js...@redhat.com
Reviewed-by: Kevin Wolf kw...@redhat.com
Message-id:
On 05/05/15 09:02, Eric Blake wrote:
On 04/30/2015 12:20 PM, Don Slutz wrote:
This adds one new inject command:
inject-vmport-action
And three guest info commands:
vmport-guestinfo-set
vmport-guestinfo-get
query-vmport-guestinfo
More details in qmp-commands.hx
Signed-off-by: Don
This is done by adding a new machine property vmware-port-ring3 that
needs to be enabled to have any effect. It only effects accel=tcg
mode. It is needed if you want to use VMware tools in accel=tcg
mode.
Signed-off-by: Don Slutz dsl...@verizon.com
(cherry picked from commit
On Tue, May 12, 2015 at 07:42:17PM +0200, Markus Armbruster wrote:
Eduardo Habkost ehabk...@redhat.com writes:
On Tue, May 12, 2015 at 05:38:37PM +0200, Markus Armbruster wrote:
[...]
@@ -699,8 +701,9 @@
#data is sent to the client, the guest may no longer be halted.
##
On 05/12/2015 10:09 AM, Daniel P. Berrange wrote:
Add a simple test case for qemu-iotests that covers read/write
with encrypted qcow2 files.
Signed-off-by: Daniel P. Berrange berra...@redhat.com
---
tests/qemu-iotests/131 | 69
++
Use blkdebug to inject an error on first flush, then attempt to flush
on the first guest. When the error halts the VM, migrate to the
second VM, and attempt to resume the command.
Signed-off-by: John Snow js...@redhat.com
Reviewed-by: Kevin Wolf kw...@redhat.com
Message-id:
On 05/12/2015 03:52 PM, Eric Blake wrote:
On 05/12/2015 01:06 PM, John Snow wrote:
tests/qemu-iotests/131 | 69
++
tests/qemu-iotests/131.out | 46
+++
Fam Zheng already has a patch on-list that uses test 131,
On 05/12/2015 04:06 PM, Eric Blake wrote:
On 05/12/2015 01:53 PM, John Snow wrote:
Bitmaps can be in a handful of different states with potentially
more to come as we tool around with migration and persistence
patches.
Instead of having a bunch of boolean fields, it was suggested
that
We're currently missing the laa and laag instructions in our emulation.
In fact, we're missing the complete interlocked-access facility 1 which
is part of zEC12. However, I really only needed the laa instruction for now.
Signed-off-by: Alexander Graf ag...@suse.de
---
This really should
On 05/12/2015 01:20 PM, Alexander Graf wrote:
+static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
+{
+/* XXX should reserve the address */
+in2_m2_32s(s, f, o);
+}
+#define SPEC_in2_m2_32s_atomic 0
+
+static void in2_m2_64_atomic(DisasContext *s,
On 05/12/2015 10:27 PM, Richard Henderson wrote:
On 05/12/2015 01:20 PM, Alexander Graf wrote:
+static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
+{
+/* XXX should reserve the address */
+in2_m2_32s(s, f, o);
+}
+#define SPEC_in2_m2_32s_atomic 0
+
+static void
Unlike machines, humans will be (mostly) appreciative on seeing
help output when a command fails due to incorrect syntax or input.
By default, print output of help_cmd() to the monitor in such cases.
The only exceptions are if a command does not exist or parsing
failed for some other reason.
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
With this commit, the handling of driver-specific options in
qcow2_open() is completely separated out into qcow2_update_options().
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/qcow2.c | 109
On 05/12/2015 01:46 PM, Alexander Graf wrote:
On 05/12/2015 10:27 PM, Richard Henderson wrote:
On 05/12/2015 01:20 PM, Alexander Graf wrote:
+static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
+{
+/* XXX should reserve the address */
+in2_m2_32s(s, f, o);
+}
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/qcow2.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization
We're currently missing all instructions defined by the interlocked-access
facility 1 which is part of zEC12. This patch implements all of them except
for LPD and LPDG.
Signed-off-by: Alexander Graf ag...@suse.de
---
v1 - v2:
- move atomic specific bits into load/store helpers, leave actual
On 05/12/2015 01:42 PM, Alexander Graf wrote:
But wouldn't it really be addr2? This is the address source for the second
argument after all.
Yes, but we already abuse the name.
r~
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
For updating the cache sizes or disabling lazy refcounts there is a bit
more to do than just changing the variables, but otherwise we're all set
for changing options during bdrv_reopen().
Just implement the missing pieces and hook the functions up in
On 05/12/2015 10:27 PM, Richard Henderson wrote:
On 05/12/2015 01:20 PM, Alexander Graf wrote:
+static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o)
+{
+/* XXX should reserve the address */
+in2_m2_32s(s, f, o);
+}
+#define SPEC_in2_m2_32s_atomic 0
+
+static void
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
On return, either all new options should be applied to BDRVQcowState (on
success), or all of the old setting should be preserved (on failure).
s/setting/settings/
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/qcow2.c | 52
On Tue, May 12, 2015 at 11:33:49AM +0200, Michael S. Tsirkin wrote:
On Mon, May 11, 2015 at 01:08:05PM -0700, Sean O. Stalley wrote:
On Mon, May 11, 2015 at 09:26:08PM +0200, Michael S. Tsirkin wrote:
On Mon, May 11, 2015 at 11:56:44AM -0700, Sean O. Stalley wrote:
PCI Enhanced
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
Before we can allow updating options at runtime with bdrv_reopen(), we
need to split the function into prepare/commit/abort parts.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/qcow2.c | 101
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
qcow2_update_options() only updates some variables in BDRVQcowState and
doesn't really depend on other parts of it being initialised yet, so it
can be moved so that it immediately follows the other half of option
handling code in qcow2_open().
I'm sorry, but I'm not clear at this point on the status of this bug. I
never received an answer to comments #32 and comment #35, and don't know
what, if anything, to apply in an SRU.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Previously forgotten, the kernel needs the software completion bit to
know that it needs to emulate software completion qualified insns.
Reported-by: Al Viro v...@zeniv.linux.org.uk
Signed-off-by: Richard Henderson r...@twiddle.net
---
target-alpha/fpu_helper.c | 8 +++-
1 file changed, 3
The extract signed single bitfield produces significantly
smaller code on x86_64.
Signed-off-by: Richard Henderson r...@twiddle.net
---
target-alpha/int_helper.c | 30 --
1 file changed, 12 insertions(+), 18 deletions(-)
diff --git a/target-alpha/int_helper.c
On 05/12/2015 02:50 PM, Alexander Graf wrote:
We're currently missing all instructions defined by the interlocked-access
facility 1 which is part of zEC12. This patch implements all of them except
for LPD and LPDG.
Signed-off-by: Alexander Graf ag...@suse.de
---
v1 - v2:
- move
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/isa/vt82c686.c | 47 ---
1 file changed, 32 insertions(+), 15 deletions(-)
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index b8197b1..bb6f6df 100644
---
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/i386/kvm/pci-assign.c | 39 +--
1 file changed, 21 insertions(+), 18 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/watchdog/wdt_i6300esb.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c
index 4ebdbb8..cfa2b1b 100644
---
From: Gonglei arei.gong...@huawei.com
Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/xen/xen_pt.c | 10 +-
hw/xen/xen_pt.h | 4
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/xen/xen_pt.c
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/pci-host/piix.c | 57 +-
1 file changed, 31 insertions(+), 26 deletions(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 723836f..f0fe4a1
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/isa/piix4.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index d9522b1..2c59e91 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -34,6
Hello!
I just pulled last git and git am-ed your patch on-top of my first 3 patches
and got
this error:
/home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c: In function
'fdt_add_gic_node':
/home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c:366:17: error:
'KVM_DEV_TYPE_ARM_VGIC_V3' undeclared
On 12/05/2015 03:05, Peter Crosthwaite wrote:
On Thu, May 7, 2015 at 2:34 AM, Michael Tokarev m...@tls.msk.ru wrote:
07.05.2015 09:47, Michael Tokarev wrote:
07.05.2015 09:12, Michael Tokarev wrote:
07.05.2015 04:11, G 3 wrote:
Did you boot Windows XP to the desktop? I have tested Windows
Il 11/05/2015 17:04, Fabio Fantoni ha scritto:
Il 21/04/2015 14:53, Stefano Stabellini ha scritto:
On Tue, 21 Apr 2015, Fabio Fantoni wrote:
Il 21/04/2015 12:49, Stefano Stabellini ha scritto:
On Mon, 20 Apr 2015, Fabio Fantoni wrote:
I updated xen and qemu from xen 4.5.0 with its upstream
On 05/07/2015 05:10 PM, Alexey Kardashevskiy wrote:
The changelog is:
version: update to 20150429
pci: Use QEMU created PCI device nodes
usb: support 64-bit pci bars
pci: Support 64-bit address translation
pci: program correct bridge limit registers during probe
scsi:
changes since commit 19fbe5084c1da6af95177c86e4cab64241d479a8:
Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into
staging (2015-05-12 10:40:31 +0100)
are available in the git repository at:
git://git.linaro.org/people/pmaydell/qemu-arm.git
tags/pull-target-arm-20150512
Welcome any other members' ideas, suggestions or completions for it.
If one of another members also suggests to drop all uint8_t and uint16_t,
I shall drop them (more explanations for dropping them will be better).
Thanks.
On 05/12/2015 08:43 AM, gchen gchen wrote:
For me, I still stick to
From: Gonglei arei.gong...@huawei.com
Hi,
These three patches just some cleanup work about DO_UPCAST().
Please review,
Thanks
Cc: Gerd Hoffmann kra...@redhat.com
Gonglei (3):
vga-pci: QOMify
cirrus_vga: QOMify
qxl: QOMify
hw/display/cirrus_vga.c | 8 ++--
hw/display/qxl.c
On 11 May 2015 at 14:15, Yongbok Kim yongbok@imgtec.com wrote:
The thing is that the fact misaligned accesses of MSA LD/ST should be allowed
in R5 cores
while all other instructions are not allowed.
Therefore it is required which types of instruction is triggering the
misaligned
On 12/05/15 13:01, Stefan Hajnoczi wrote:
On Mon, May 11, 2015 at 07:47:41PM +0300, Denis V. Lunev wrote:
On 11/05/15 19:07, Denis V. Lunev wrote:
On 11/05/15 18:08, Stefan Hajnoczi wrote:
On Mon, May 04, 2015 at 04:42:22PM +0300, Denis V. Lunev wrote:
The difference is quite reliable and
On 12/05/2015 12:19, Denis V. Lunev wrote:
hades /vol $ strace -f -e pwrite -e raw=write,pwrite qemu-io -n -c
write -P 0x11 0 64M ./1.img
Process 19326 attached
[pid 19326] pwrite(0x6, 0x7fac07fff200, 0x400, 0x5) = 0x400
1 GB Write from userspace
FWIW this is 64 MB
On 05/12/2015 07:08 PM, Peter Maydell wrote:
On 12 May 2015 at 11:56, Chen Gang xili_gchen_5...@hotmail.com wrote:
Welcome any other members' ideas, suggestions or completions for it.
If one of another members also suggests to drop all uint8_t and uint16_t,
I shall drop them (more
Hello!
We are not. Support for GICv2 vs v3 should be dealt with
by suitable machine properties
I don't remember whether i clearly wrote about it... First i added a property,
like -machine virt,gicv3=on. But then i decided to stick back to different
machine name because libvirt does not
And one more small note... I have noticed a typo.
--- cut ---
[VIRT_ITS_CONTROL] = { 0x0802, 0x1000 },
--- cut ---
The size should actually be 0x0001. It worked because we don't use ITS.
Please fix it
for the next merge attempt.
Kind regards,
Pavel Fedin
Expert Engineer
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/display/qxl.c | 44 ++--
hw/display/qxl.h | 3 +++
2 files changed, 29 insertions(+), 18 deletions(-)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index
From: Gonglei arei.gong...@huawei.com
Signed-off-by: Gonglei arei.gong...@huawei.com
---
hw/display/vga-pci.c | 48 ++--
1 file changed, 30 insertions(+), 18 deletions(-)
diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c
index aabfc23..ff5dfb2
On 11/05/2015 12:30, Yongbok Kim wrote:
@@ -391,6 +391,37 @@ hwaddr cpu_mips_translate_address(CPUMIPSState *env,
target_ulong address, int r
}
}
+bool cpu_mips_validate_msa_block_access(CPUMIPSState *env, target_ulong addr,
+int rw, int
Am 12.05.2015 um 07:47 hat Denis V. Lunev geschrieben:
The following sequence
int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644);
for (i = 0; i 10; i++)
write(fd, buf, 4096);
performs 5% better if buf is aligned to 4096 bytes.
The difference is quite
Am 12.05.2015 um 07:47 hat Denis V. Lunev geschrieben:
The patch introduces new concept: minimal memory alignment for bounce
buffers. Original so called optimal value is actually minimal required
value for aligment. It should be used for validation that the IOVec
is properly aligned and bounce
On 11 May 2015 at 16:26, Stefan Hajnoczi stefa...@redhat.com wrote:
The following changes since commit b951cda21d6b232f138ccf008e12bce8ddc95465:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
staging (2015-05-11 12:01:09 +0100)
are available in the git repository
On 11 May 2015 at 19:12, John Snow js...@redhat.com wrote:
The following changes since commit 9ad2c8cd41a086020e21aa6d616b73bd5e2a800b:
Merge remote-tracking branch
'remotes/mjt/tags/pull-trivial-patches-2015-05-09' into staging (2015-05-11
13:54:00 +0100)
are available in the git
On 12 May 2015 at 11:56, Chen Gang xili_gchen_5...@hotmail.com wrote:
Welcome any other members' ideas, suggestions or completions for it.
If one of another members also suggests to drop all uint8_t and uint16_t,
I shall drop them (more explanations for dropping them will be better).
I agree
-Original Message-
From: Pavel Fedin [mailto:p.fe...@samsung.com]
Sent: Tuesday, 12 May, 2015 12:06 PM
To: Shlomo Pongratz; qemu-devel@nongnu.org
Subject: RE: [PATCH v2] Add virt-v3 machine that uses GIC-500
Hello!
I just pulled last git and git am-ed your patch on-top of my
On Fri, May 08, 2015 at 04:09:01PM +0300, Pavel Fedin wrote:
I would like to offer this, slightly improved implementation. The key thing
is a new
kernel_irqchip_type member in Machine class. Currently it it used only by
virt machine for
its internal purposes, however in future it is to be
On 11 May 2015 at 14:17, Luiz Capitulino lcapitul...@redhat.com wrote:
On Mon, 11 May 2015 13:53:47 +0100
Peter Maydell peter.mayd...@linaro.org wrote:
On 8 May 2015 at 14:34, Luiz Capitulino lcapitul...@redhat.com wrote:
The following changes since commit
On 12 May 2015 at 10:20, Daniel P. Berrange berra...@redhat.com wrote:
On Fri, May 08, 2015 at 04:09:01PM +0300, Pavel Fedin wrote:
static void machvirt_machine_init(void)
{
type_register_static(machvirt_info);
+type_register_static(machvirtv3_info);
}
If we're going to start
Am 11.05.2015 um 14:54 hat Alberto Garcia geschrieben:
New version of the qcow2 cache patches:
v3:
- Removed a dead comment in patch #3
- New document explaining how to configure the cache sizes
v2: https://lists.nongnu.org/archive/html/qemu-devel/2015-05/msg00833.html
- Don't do pointer
Hi,
We *could* do it that way, but it wouldn't look pretty. Instead of having
these menu items:
VGA, Monitor, Serial, Parallel
We would have these menu items:
VGA
compat_monitor0
serial0
parallel0
They look very anti-pretty.
Those (except VGA) come from the chardev name.
As discussed during the QEMU 2.3 development freeze.
==
For convenience, this branch is available at:
https://github.com/jnsnow/qemu.git branch glib-version-fix
https://github.com/jnsnow/qemu/tree/glib-version-fix
This version is tagged glib-version-fix-v1:
This provides g_ptr_array_new_with_free_func, as well as a few
other functions that we've been hacking around in glib-compat.h.
Cleaning up the compatibility headers will come later.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: John Snow js...@redhat.com
---
configure | 7
[This Week]
- Investigate MOL device tree further
- Mark There is also an interesting dump of what seems to be a MOL tree
at http://josejx.net/mol/mol-stable/mollib/oftrees/oftree.nw.old (which
has a commented out entry for AAPL,debug set to -1). The interesting
parts I see
On 05/08/2015 11:21 AM, Kevin Wolf wrote:
The code already special-cased node-name, which is currently the only
option passed in the QDict that isn't driver-specific. Generalise the
code to take all general block layer options into consideration.
Signed-off-by: Kevin Wolf kw...@redhat.com
Hi all,
My name is Cormac O'Brien and I'm one of QEMU's student developers for Google
Summer of Code 2015. My project goal is to have Mac OS 9 running on both the
g3beige and mac99 machines by the end of the summer (it currently doesn't
boot on either). I'll be working with Alexander Graf and
From: Matthew Fortune matthew.fort...@imgtec.com
The BEV flag controls whether the boot exception vector is still
in place when starting a kernel. When cleared the exception vector
at EBASE (or hard coded address of 0x8000) is used instead.
The early stages of the linux kernel would benefit
Add UHI semihosting support for MIPS. QEMU run with -semihosting option
will alter the behaviour of SDBBP 1 instruction -- UHI operation will be
called instead of generating a debug exception.
Also tweak Malta's pseudo-bootloader. On CPU reset the $4 register is set
to -1 if semihosting arguments
On 05/12/15 15:50, Eric Blake wrote:
On 05/12/2015 01:03 PM, Don Slutz wrote:
This adds one new inject command:
inject-vmport-action
And three guest info commands:
vmport-guestinfo-set
vmport-guestinfo-get
query-vmport-guestinfo
vmport-guestinfo-get key=foo
More details in
Since we're bumping the version to 2.22+,
remove the now-stale compat functions.
Signed-off-by: John Snow js...@redhat.com
---
include/glib-compat.h | 35 ---
1 file changed, 35 deletions(-)
diff --git a/include/glib-compat.h b/include/glib-compat.h
index
Hi,
This patch series introduces the Unified Hosting Interface support to QEMU.
This is second version which uses new -semihosting-config arg and addresses
Matthew's review comments.
Regards,
Leon
v2:
* use new -semihosting arg option, thus it applies on top of
Convert only errno values which can be returned by system calls in
mips-semi.c and are not generic to all archs.
Signed-off-by: Leon Alrae leon.al...@imgtec.com
---
target-mips/mips-semi.c | 44 +---
1 file changed, 33 insertions(+), 11 deletions(-)
diff
Signed-off-by: Leon Alrae leon.al...@imgtec.com
---
target-mips/translate.c | 25 -
1 file changed, 4 insertions(+), 21 deletions(-)
diff --git a/target-mips/translate.c b/target-mips/translate.c
index a41fc98..94f17a9 100644
--- a/target-mips/translate.c
+++
This continues the IOMMU fix from 2.3, where we should not attempt
to remap the CLB or FIS RX buffers if the AHCI device is currently
running.
The same applies to migration: keep our mitts off these registers
unless the device is supposed to be on.
Does not impact backwards compatibility for the
This continues the IOMMU fix from 2.3, where we should not attempt
to remap the CLB or FIS RX buffers if the AHCI device is currently
running.
The same applies to migration: keep our mitts off these registers
unless the device is supposed to be on.
Does not impact backwards compatibility for the
From: Maciej W. Rozycki ma...@codesourcery.com
Correct addresses passed around in semihosting to use a data type suitable
for both 32-bit and 64-bit targets.
Signed-off-by: Maciej W. Rozycki ma...@codesourcery.com
Signed-off-by: Leon Alrae leon.al...@imgtec.com
---
include/exec/softmmu-semi.h |
This checks that the discard on mirror source that effectively zeroes
data is also reflected by the data of target.
Signed-off-by: Fam Zheng f...@redhat.com
Reviewed-by: John Snow js...@redhat.com
---
tests/qemu-iotests/131 | 59 ++
Markus Armbruster (15):
net: Improve error message for -net hubport a bit
net: Permit incremental conversion of init functions to Error
net: Improve -net nic error reporting
net/dump: Improve -net/host_net_add dump error reporting
tap: net_tap_fd_init() can't fail, drop dead error
When -net dump fails, it first reports a specific error, then a
generic one, like this:
$ qemu-system-x86_64 -net dump,id=foo,file=/eperm
qemu-system-x86_64: -net dump,id=foo,file=/eperm: -net dump: can't open
/eperm
qemu-system-x86_64: -net dump,id=foo,file=/eperm: Device 'dump'
When -net nic fails, it first reports a specific error, then a generic
one, like this:
$ qemu-system-x86_64 -net nic,netdev=nonexistant
qemu-system-x86_64: -net nic,netdev=nonexistant: netdev 'nonexistant' not
found
qemu-system-x86_64: -net nic,netdev=nonexistant: Device 'nic' could
Signed-off-by: Markus Armbruster arm...@redhat.com
---
net/tap.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/net/tap.c b/net/tap.c
index 8f06cb7..adb1022 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -536,7 +536,6 @@ int net_init_bridge(const NetClientOptions
Error reporting for netdev_add is broken: the net_client_init_fun[]
report the actual errors with (at best) error_report(), and their
caller net_client_init1() makes up a generic error on top.
For command line and HMP, this produces an mildly ugly error cascande.
In QMP, the actual errors go to
Fixes inappropriate use of syslog().
Not fixed: leaks on error paths, suspicious non-fatal errors. FIXMEs
added instead.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
net/tap-solaris.c | 59 ---
1 file changed, 30 insertions(+), 29
Convert the trivial ones immediately: tap-aix and tap-haiku.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
net/tap-aix.c | 4 ++--
net/tap-bsd.c | 6 --
net/tap-haiku.c | 4 ++--
net/tap-linux.c | 3 ++-
net/tap-solaris.c | 3 ++-
net/tap.c | 13
Fixes inappropriate use of stderr in monitor command handler.
While there, improve the messages some.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
net/tap.c | 40
1 file changed, 28 insertions(+), 12 deletions(-)
diff --git a/net/tap.c
QEMU has options to configure the size of the L2 and refcount
caches for the qcow2 format. However, choosing the right sizes for
a particular disk image is not a straightforward operation since
the ratio between the cache size and the allocated disk space is
not obvious and depends on the size of
Signed-off-by: Markus Armbruster arm...@redhat.com
---
net/tap.c | 70 ++-
1 file changed, 38 insertions(+), 32 deletions(-)
diff --git a/net/tap.c b/net/tap.c
index d54222d..d1f5644 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -600,11
libepoxy does the opengl extension handling for us.
It also is helpful for trouble-shooting as it prints nice error messages
instead of silently failing or segfaulting in case we do something
wrong, like using gl commands not supported by the current context.
Signed-off-by: Gerd Hoffmann
Signed-off-by: Fam Zheng f...@redhat.com
Reviewed-by: John Snow js...@redhat.com
---
tests/qemu-iotests/041| 66 ++-
tests/qemu-iotests/iotests.py | 28 ++
2 files changed, 43 insertions(+), 51 deletions(-)
diff --git
Signed-off-by: Markus Armbruster arm...@redhat.com
---
net/tap-aix.c | 3 +--
net/tap-bsd.c | 3 +--
net/tap-haiku.c | 3 +--
net/tap-linux.c | 6 ++
net/tap-solaris.c | 3 +--
net/tap.c | 4 +++-
net/tap_int.h | 2 +-
7 files changed, 10 insertions(+), 14 deletions(-)
When -netdev bridge fails, it first reports a specific error, then a
generic one, like this:
$ qemu-system-x86_64 -netdev bridge,id=foo
failed to launch bridge helper
qemu-system-x86_64: -netdev bridge,id=foo: Device 'bridge' could not be
initialized
The first message goes to
Type hubport is valid only with -netdev. Unfortunately, that's
detected late and the error message doesn't explain why:
$ qemu-system-i386 -net hubport,id=foo,hubid=0
qemu-system-i386: -net hubport,id=foo,hubid=0: Device 'hubport' could not
be initialized
Improve the error message to
Signed-off-by: Markus Armbruster arm...@redhat.com
---
net/tap-linux.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/net/tap-linux.c b/net/tap-linux.c
index be18382..6c3caef 100644
--- a/net/tap-linux.c
+++ b/net/tap-linux.c
@@ -39,7 +39,6 @@
int
When -netdev tap fails, it first reports a specific error, then a
generic one, like this:
$ qemu-system-x86_64 -netdev tap,id=foo
qemu-system-x86_64: -netdev tap,id=foo: could not configure /dev/net/tun:
Operation not permitted
qemu-system-x86_64: -netdev tap,id=foo: Device 'tap'
Kevin applied all other patches from this series, so this is the only
one left.
Thanks to Max for all the feedback.
v2:
- Add copyright notice
- Document refcount_bits and its effects
v1: https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01891.html
Regards,
Berto
Alberto Garcia (1):
On 12/05/15 13:27, Kevin Wolf wrote:
Am 12.05.2015 um 07:47 hat Denis V. Lunev geschrieben:
The following sequence
int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644);
for (i = 0; i 10; i++)
write(fd, buf, 4096);
performs 5% better if buf is aligned to 4096
On arm the original timerfd syscall was reused for the new timerfd_create
syscall.
Signed-off-by: Andreas Schwab sch...@suse.de
---
linux-user/arm/syscall_nr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/arm/syscall_nr.h b/linux-user/arm/syscall_nr.h
index
Am 12.05.2015 um 12:36 hat Denis V. Lunev geschrieben:
On 12/05/15 13:27, Kevin Wolf wrote:
Am 12.05.2015 um 07:47 hat Denis V. Lunev geschrieben:
The following sequence
int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644);
for (i = 0; i 10; i++)
write(fd,
101 - 200 of 291 matches
Mail list logo
