Re: [Qemu-devel] Runtime-modified DIMMs and live migration issue

2015-06-19 Thread Andrey Korolyov
On Fri, Jun 19, 2015 at 7:57 PM, Andrey Korolyov and...@xdel.ru wrote: I don`t think that it could be ACPI-related in any way, instead, it looks like race in vhost or simular mm-touching mechanism. The repeated hits you mentioned should be fixed as well indeed, but they can be barely the

Re: [Qemu-devel] [PATCH v5] mirror: correct buf_size

2015-06-19 Thread Jeff Cody
On Fri, May 15, 2015 at 03:51:36PM +0800, Wen Congyang wrote: If bus_size is less than 0, the command fails. If buf_size is 0, use DEFAULT_MIRROR_BUF_SIZE. If buf_size % granularity is not 0, mirror_free_init() will do dangerous things. Signed-off-by: Wen Congyang we...@cn.fujitsu.com

Re: [Qemu-devel] [PATCH 1/1] Add support for PCI Enhanced Allocation BARs

2015-06-19 Thread Stalley, Sean
Hi Michael, Have you had a chance to look at this? There's no hurry, im just curious. Thanks, Sean -Original Message- From: Sean O. Stalley [mailto:sean.stal...@intel.com] Sent: Monday, June 01, 2015 9:38 AM To: Michael S. Tsirkin Cc: qemu-devel@nongnu.org Subject: Re: [PATCH 1/1]

Re: [Qemu-devel] [PATCH 7/8] hmp: added io apic dump state

2015-06-19 Thread Pavel
On 19.06.2015 19:08, Peter Maydell wrote: On 19 June 2015 at 15:48, Denis V. Lunev d...@openvz.org wrote: From: Pavel Butsykin pbutsy...@virtuozzo.com Added the hmp command to query io apic state, may be usefull after guest crashes to understand IRQ routing in guest. Implementation is only

Re: [Qemu-devel] [PATCH 5/8] hmp: added local apic dump state

2015-06-19 Thread Pavel
On 19.06.2015 18:45, Andreas Färber wrote: Am 19.06.2015 um 16:48 schrieb Denis V. Lunev: From: Pavel Butsykin pbutsy...@virtuozzo.com Added the hmp command to query local apic registers state, may be usefull after guest crashes to understand IRQ routing in guest. For command name uses

Re: [Qemu-devel] [PATCH 7/8] hmp: added io apic dump state

2015-06-19 Thread Pavel
On 19.06.2015 18:53, Andreas Färber wrote: Am 19.06.2015 um 16:48 schrieb Denis V. Lunev: From: Pavel Butsykin pbutsy...@virtuozzo.com Added the hmp command to query io apic state, may be usefull after guest crashes to understand IRQ routing in guest. Implementation is only for kvm here.

[Qemu-devel] [PATCH 11/16] libqos/ahci: edit wait to be ncq aware

2015-06-19 Thread John Snow
The wait command should check to make sure SACT is clear as well as the Command Issue register. Signed-off-by: John Snow js...@redhat.com --- tests/libqos/ahci.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c index

[Qemu-devel] [PATCH 04/16] ahci: check for ncq prdtl overflow

2015-06-19 Thread John Snow
Don't attempt the NCQ transfer if the PRDT we were given is not big enough to perform the entire transfer. Signed-off-by: John Snow js...@redhat.com --- hw/ide/ahci.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index

[Qemu-devel] [PATCH 06/16] ahci: add ncq debug checks

2015-06-19 Thread John Snow
Most of the time, these bits can be safely ignored. For the purposes of debugging however, it's nice to know that they're not being used. Signed-off-by: John Snow js...@redhat.com --- hw/ide/ahci.c | 25 + 1 file changed, 25 insertions(+) diff --git a/hw/ide/ahci.c

[Qemu-devel] [PATCH 02/16] ahci: use shorter variables

2015-06-19 Thread John Snow
Trivial cleanup that I didn't want to tack-on to anything else. Signed-off-by: John Snow js...@redhat.com --- hw/ide/ahci.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 26df2ca..14eccb8 100644 --- a/hw/ide/ahci.c +++

[Qemu-devel] [PATCH 13/16] libqos/ahci: set the NCQ tag on command_commit

2015-06-19 Thread John Snow
NCQ commands have the concept of a TAG that they need to set, but in the AHCI world, it is mandated that the TAG always match the command slot that you executed the NCQ from. See AHCI 9.3.1.1.5.2 Native Queued Commands. Signed-off-by: John Snow js...@redhat.com --- tests/libqos/ahci.c | 5 +

[Qemu-devel] [PATCH 10/16] libqos/ahci: add NCQ frame support

2015-06-19 Thread John Snow
NCQ frames are generated a little differently than their non-NCQ cousins. Add support for them. Signed-off-by: John Snow js...@redhat.com --- tests/libqos/ahci.c | 44 +++- tests/libqos/ahci.h | 29 - 2 files changed, 63

[Qemu-devel] [PATCH 16/16] qtest/ahci: ncq migration test

2015-06-19 Thread John Snow
Signed-off-by: John Snow js...@redhat.com --- tests/ahci-test.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index 941e0dd..206e6bb 100644 --- a/tests/ahci-test.c +++ b/tests/ahci-test.c @@ -1140,9 +1140,9 @@ static

[Qemu-devel] [PATCH 14/16] libqos/ahci: Force all NCQ commands to be LBA48

2015-06-19 Thread John Snow
NCQ commands are LBA48 by definition. See SATA 3.2 13.6.4.1 READ FPDMA QUEUED, or SATA 3.2 13.6.5.1 WRITE FPDMA QUEUED. Signed-off-by: John Snow js...@redhat.com --- tests/libqos/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/ahci.c

[Qemu-devel] [PATCH 12/16] libqos/ahci: adjust expected NCQ interrupts

2015-06-19 Thread John Snow
NCQ commands will expect the SDBS interrupt, and in the normative case, do not expect to see a D2H Register FIS unless something went wrong. Signed-off-by: John Snow js...@redhat.com --- tests/libqos/ahci.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [Qemu-block] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target

2015-06-19 Thread Wen Congyang
At 2015/6/19 18:49, Stefan Hajnoczi Wrote: On Fri, Jun 19, 2015 at 08:54:56AM +0800, Wen Congyang wrote: On 06/19/2015 12:06 AM, Stefan Hajnoczi wrote: On Thu, Jun 18, 2015 at 10:36:39PM +0800, Wen Congyang wrote: At 2015/6/18 20:55, Stefan Hajnoczi Wrote: On Thu, Jun 18, 2015 at 04:49:12PM

Re: [Qemu-devel] [PATCH] configure: Add support for jemalloc

2015-06-19 Thread Alexandre DERUMIER
@cc Fam Zheng f...@redhat.com, as he's the author of tcmalloc support patch - Mail original - De: aderumier aderum...@odiso.com À: qemu-devel qemu-devel@nongnu.org Cc: aderumier aderum...@odiso.com Envoyé: Vendredi 19 Juin 2015 12:56:58 Objet: [PATCH] configure: Add support for jemalloc

[Qemu-devel] [PATCH 03/16] ahci: add ncq_err helper

2015-06-19 Thread John Snow
Set some appropriate error bits for NCQ for us. Signed-off-by: John Snow js...@redhat.com --- hw/ide/ahci.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 14eccb8..375aa44 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@

[Qemu-devel] [PATCH 00/16] ahci: ncq cleanup, part 1

2015-06-19 Thread John Snow
requires: 1434470575-21625-1-git-send-email-js...@redhat.com [PATCH v2 0/4] ahci: misc fixes/tests for 2.4 This series adds a couple of tests to exercise the NCQ pathways and establish a baseline for us. Most of these patches are fairly short and should be relatively trivial to review.

[Qemu-devel] [PATCH 09/16] libqos/ahci: fix cmd_sanity for ncq

2015-06-19 Thread John Snow
NCQ commands should not / do not update the byte count in the command header post command, so this field is meaningless for NCQ tests. Signed-off-by: John Snow js...@redhat.com --- tests/libqos/ahci.c | 46 -- tests/libqos/ahci.h | 3 +-- 2 files

[Qemu-devel] [PATCH 01/16] ahci: Rename NCQFIS structure fields

2015-06-19 Thread John Snow
Several fields of the NCQFIS structure are ambiguously named. This patch clarifies the intended (if unsupported) usage of the NCQ fields to aid in creating more meaningful debug messages through the NCQ codepaths. Signed-off-by: John Snow js...@redhat.com --- hw/ide/ahci.h | 35

Re: [Qemu-devel] [PATCH v2 0/3] m68k: fix ColdFire support

2015-06-19 Thread Greg Ungerer
Hi Laurent, On 20/06/15 05:39, Laurent Vivier wrote: Le 19/06/2015 15:43, g...@uclinux.org a écrit : Some small issues are causing problems with running modern versions of Linux on the m68k/ColdFire 5208 target. These 3 patches fix those problems. They are all due to use of more advanced

[Qemu-devel] [PATCH 05/16] ahci: separate prdtl from opts

2015-06-19 Thread John Snow
There's no real reason to have it bundled together, and this way is a little nicer to follow if you have the AHCI spec pulled up. Signed-off-by: John Snow js...@redhat.com --- hw/ide/ahci.c | 23 --- hw/ide/ahci.h | 3 ++- 2 files changed, 14 insertions(+), 12 deletions(-)

[Qemu-devel] [PATCH 15/16] qtest/ahci: simple ncq data test

2015-06-19 Thread John Snow
Test the NCQ pathways for a simple IO RW test. Also, test that libqos doesn't explode when running NCQ commands :) Signed-off-by: John Snow js...@redhat.com --- tests/ahci-test.c | 13 + tests/libqos/ahci.c | 46 +- tests/libqos/ahci.h |

[Qemu-devel] [PATCH 07/16] ahci: ncq sector count correction

2015-06-19 Thread John Snow
This value should not be size-corrected, 0 sectors does not imply 1 sector(s). This is just debug information, but it's misleading! Signed-off-by: John Snow js...@redhat.com --- hw/ide/ahci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c

[Qemu-devel] [PATCH 08/16] ahci: clear error register before NCQ cmd

2015-06-19 Thread John Snow
The legacy ide command execution layer will clear any errors outstanding before execution, but the NCQ layer doesn't. Even on success, this register will remain clogged. Clear it out before each NCQ command so the guest can tell if the error code produced after completion is meaningful or not.

[Qemu-devel] [RFC 2/2] hw/i386/pc: reflect an explicitly created, sole FDC in the CMOS

2015-06-19 Thread Laszlo Ersek
With the pc-q35-2.4 machine type, if the user creates an ISA FDC manually: -device isa-fdc,driveA=drive-fdc0-0-0 \ -drive file=...,if=none,id=drive-fdc0-0-0,format=raw then the board-default FDC will be skipped, and only the explicitly requested FDC will exist. qtree-wise, this is correct;

[Qemu-devel] [RFC 1/2] hw/i386/pc: factor out pc_cmos_init_floppy()

2015-06-19 Thread Laszlo Ersek
Extract the pc_cmos_init_floppy() function from pc_cmos_init(). The function sets two RTC registers: floppy drive types (0x10), overwriting the earlier value in there), and REG_EQUIPMENT_BYTE (0x14), setting bits in the prior value. Cc: Jan Tomko jto...@redhat.com Cc: John Snow js...@redhat.com

[Qemu-devel] [RFC 0/2] update CMOS for single hand-created ISA-FDC

2015-06-19 Thread Laszlo Ersek
This is for the other pc-q35-2.4 ISA-FDC problem reported by Jan. Jan, can you give it a try pls? Cc: Jan Tomko jto...@redhat.com Cc: John Snow js...@redhat.com Cc: Markus Armbruster arm...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com Laszlo Ersek (2): hw/i386/pc: factor out

Re: [Qemu-devel] [PATCH 16/16] qtest/ahci: ncq migration test

2015-06-19 Thread John Snow
On 06/19/2015 09:50 PM, John Snow wrote: Signed-off-by: John Snow js...@redhat.com --- tests/ahci-test.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index 941e0dd..206e6bb 100644 --- a/tests/ahci-test.c +++

Re: [Qemu-devel] m68k orphaned?

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 06:00, Greg Ungerer g...@uclinux.org wrote: Hi All, I see in the MAINTAINERS file that pretty much everything related to the m68k architecture is listed as Orphan. I have some patches that have been around for quite a while (posted here twice) to fix some issues with the

[Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-06-19 Thread Paolo Bonzini
1) Line lengths above 80 characters do exist. They are rare, but they happen from time to time. An ignored rule is worse than an exception to the rule, so do the latter. 2) Mixed declarations also do exist at the top of #ifdef blocks. Remark on this particular usage and suggest an alternative.

[Qemu-devel] [PATCH] tap: fix non-linux build

2015-06-19 Thread Michael S. Tsirkin
tap_fd_set_vnet_le/tap_fd_set_vnet_be was missing, fix it up. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- net/tap-aix.c | 10 ++ net/tap-bsd.c | 10 ++ net/tap-haiku.c | 10 ++ net/tap-solaris.c | 10 ++ net/tap-win32.c | 10 ++ 5

Re: [Qemu-devel] [RFC PATCH V3] Use atomic cmpxchg to atomically check the exclusive value in a STREX

2015-06-19 Thread Mark Burton
On 19 Jun 2015, at 09:42, Paolo Bonzini pbonz...@redhat.com wrote: On 19/06/2015 09:40, Mark Burton wrote: On 19/06/2015 09:29, Mark Burton wrote: Does anybody know if the current atomic_cmpxchg will support 64 bit on a (normal) 32 bit x86, or do we need to special case that with

Re: [Qemu-devel] [PATCH 1/3] m68k: implmenent more ColdFire 5208 interrupt controller functionality

2015-06-19 Thread Greg Ungerer
Hi Peter, On 19/06/15 15:24, Peter Crosthwaite wrote: On Mon, Aug 18, 2014 at 10:37 PM, g...@uclinux.org wrote: From: Greg Ungerer g...@uclinux.org Implement the SIMR and CIMR registers of the 5208 interrupt controller. These are used by modern versions of Linux running on ColdFire (not

Re: [Qemu-devel] [PATCH v7 3/6] spapr_pci: enumerate and add PCI device tree

2015-06-19 Thread David Gibson
On Wed, Jun 17, 2015 at 02:12:14PM +0530, Nikunj A Dadhania wrote: David Gibson da...@gibson.dropbear.id.au writes: On Thu, Jun 11, 2015 at 04:32:26PM +0530, Nikunj A Dadhania wrote: All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code

Re: [Qemu-devel] [PATCH 3/3] m68k: fix usp processing on interrupt entry and exception exit

2015-06-19 Thread Peter Crosthwaite
On Thu, Jun 18, 2015 at 11:49 PM, Greg Ungerer g...@uclinux.org wrote: Hi Peter, On 19/06/15 15:49, Peter Crosthwaite wrote: On Mon, Aug 18, 2014 at 10:37 PM, g...@uclinux.org wrote: From: Greg Ungerer g...@uclinux.org The action to potentially switch sp register is not occurring at the

Re: [Qemu-devel] [RFC PATCH V3] Use atomic cmpxchg to atomically check the exclusive value in a STREX

2015-06-19 Thread Paolo Bonzini
On 19/06/2015 09:40, Mark Burton wrote: On 19/06/2015 09:29, Mark Burton wrote: Does anybody know if the current atomic_cmpxchg will support 64 bit on a (normal) 32 bit x86, or do we need to special case that with cmpxchg8b ? (I get the impression that it will automatically use cmpxchg8b,

Re: [Qemu-devel] [RFC PATCH V3] Use atomic cmpxchg to atomically check the exclusive value in a STREX

2015-06-19 Thread Mark Burton
On 19 Jun 2015, at 09:31, Paolo Bonzini pbonz...@redhat.com wrote: On 19/06/2015 09:29, Mark Burton wrote: Does anybody know if the current atomic_cmpxchg will support 64 bit on a (normal) 32 bit x86, or do we need to special case that with cmpxchg8b ? (I get the impression that it

Re: [Qemu-devel] m68k orphaned?

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 08:17, Greg Ungerer g...@uclinux.org wrote: Hi Peter, On 19/06/15 17:12, Peter Maydell wrote: If you make the minor fixes Peter C has suggested, rebase them onto current master and resend with the relevant reviewed-by: tags in the commit messages, I'll apply them to

[Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp

2015-06-19 Thread Ting Wang
From: Lu Lina lina.lul...@huawei.com Signed-off-by: Lu Lina lina.lul...@huawei.com --- hw/block/nvme.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 4b6d5e6..c6a6a0e 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -154,6 +154,7 @@ static

Re: [Qemu-devel] [PATCH 3/3] m68k: fix usp processing on interrupt entry and exception exit

2015-06-19 Thread Greg Ungerer
Hi Peter, On 19/06/15 15:49, Peter Crosthwaite wrote: On Mon, Aug 18, 2014 at 10:37 PM, g...@uclinux.org wrote: From: Greg Ungerer g...@uclinux.org The action to potentially switch sp register is not occurring at the correct point in the interrupt entry or exception exit sequences. For

Re: [Qemu-devel] m68k orphaned?

2015-06-19 Thread Greg Ungerer
Hi Peter, On 19/06/15 17:12, Peter Maydell wrote: On 19 June 2015 at 06:00, Greg Ungerer g...@uclinux.org wrote: Hi All, I see in the MAINTAINERS file that pretty much everything related to the m68k architecture is listed as Orphan. I have some patches that have been around for quite a

Re: [Qemu-devel] [PATCH qemu v7 13/14] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2015-06-19 Thread Markus Armbruster
David Gibson da...@gibson.dropbear.id.au writes: On Thu, Jun 18, 2015 at 09:35:44PM +1000, Alexey Kardashevskiy wrote: On 05/05/2015 10:49 PM, David Gibson wrote: On Sat, Apr 25, 2015 at 10:24:43PM +1000, Alexey Kardashevskiy wrote: This adds support for Dynamic DMA Windows (DDW) option

Re: [Qemu-devel] [PATCH v3 00/11] implement dynamic endianness switching

2015-06-19 Thread Paolo Bonzini
On 18/06/2015 22:24, Peter Crosthwaite wrote: I'm pushing everything I have to tcg-arm-setend on my github repo. Already found that branch and have rebased it. It looks like since yesterday your merge base has changed but is not fully up to date. Yes, the one before was tested but

Re: [Qemu-devel] [PULL 00/10] virtio, pci fixes, enhancements

2015-06-19 Thread Michael S. Tsirkin
On Thu, Jun 18, 2015 at 05:29:23PM +0100, Peter Maydell wrote: On 18 June 2015 at 12:14, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jun 18, 2015 at 11:36:26AM +0100, Peter Maydell wrote: Hi. I'm afraid this fails to build for OSX: LINK arm-softmmu/qemu-system-arm Undefined

[Qemu-devel] [PULL 00/15] Timer, virtio-scsi-test, build, memory changes for 2015-06-19

2015-06-19 Thread Paolo Bonzini
The following changes since commit 93f6d1c16036aaf34055d16f54ea770fb8d6d280: Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20150615-1' into staging (2015-06-16 10:35:43 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you

[Qemu-devel] [PULL 09/15] libqos: Complete virtio device ID definition list

2015-06-19 Thread Paolo Bonzini
From: Fam Zheng f...@redhat.com Signed-off-by: Fam Zheng f...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- tests/libqos/virtio.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/libqos/virtio.h b/tests/libqos/virtio.h index 2449fee..0101278

Re: [Qemu-devel] [Qemu-block] RFC cdrom in own thread?

2015-06-19 Thread Peter Lieven
Am 18.06.2015 um 11:36 schrieb Stefan Hajnoczi: On Thu, Jun 18, 2015 at 10:29 AM, Peter Lieven p...@kamp.de wrote: Am 18.06.2015 um 10:42 schrieb Kevin Wolf: Am 18.06.2015 um 10:30 hat Peter Lieven geschrieben: Am 18.06.2015 um 09:45 schrieb Kevin Wolf: Am 18.06.2015 um 09:12 hat Peter Lieven

[Qemu-devel] [PULL 09/12] arm: xlnx-zynqmp: Add boot-cpu property

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Add a string property that specifies the primary boot cpu. All CPUs except the one selected will start-powered-off. This allows for elf boots on any CPU, which prepares support for booting R5 elfs directly on the R5 processors. Signed-off-by:

[Qemu-devel] [PULL 01/12] target-arm: Add the Cortex-M4 CPU

2015-06-19 Thread Peter Maydell
From: Aurelio C. Remonda aurelioremo...@gmail.com This patch adds the Cortex-M4 CPU. The M4 is basically the same as the M3, the main differences being the DSP instructions and an optional FPU. Only no-FPU cortex-M4 is implemented here, cortex-M4F is not because the core target-arm code doesn't

[Qemu-devel] [PULL 10/12] arm: xlnx-zynqmp: Add 2xCortexR5 CPUs

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Add the 2xCortexR5 CPUs to zynqmp board. They are powered off on reset (this is true of real hardware) by default or selectable as the boot processor. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Message-id:

[Qemu-devel] [PULL 00/12] target-arm queue

2015-06-19 Thread Peter Maydell
. Other than that I think we should be down to bugfix patches. -- PMM The following changes since commit ffdb1409a79c9cc91afd9f58df625fdca16bf8b9: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-cocoa-20150619-1' into staging (2015-06-19 12:54:08 +0100) are available in the git

[Qemu-devel] [PATCH v3 1/7] qdev: Deprecated qdev_init() is finally unused, drop

2015-06-19 Thread Markus Armbruster
qdev_init() is a wrapper around setting property realized to true, plus error handling that passes errors to qerror_report_err(). qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. All code has been

[Qemu-devel] [PULL 03/15] qemu-ga: debug printouts to help troubleshoot installation

2015-06-19 Thread Paolo Bonzini
From: Yossi Hindin yhin...@redhat.com Debug printouts extended, helps installation troubleshooting Signed-off-by: Yossi Hindin yhin...@redhat.com Message-Id: 1430913460-13174-3-git-send-email-yhin...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qga/channel-win32.c | 2 +-

[Qemu-devel] [PULL 12/15] qemu-timer: Call clock reset notifiers on forward jumps

2015-06-19 Thread Paolo Bonzini
From: Paul Donohue qemu-de...@paulsd.com Commit 691a0c9c introduced a mechanism by which QEMU_CLOCK_HOST can notify other parts of the emulator when the host clock has jumped backward. This is used to avoid stalling timers that were scheduled based on the host clock. However, if the host clock

Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-06-19 Thread Thomas Huth
On Fri, 19 Jun 2015 09:29:04 +0200 Paolo Bonzini pbonz...@redhat.com wrote: 1) Line lengths above 80 characters do exist. They are rare, but they happen from time to time. An ignored rule is worse than an exception to the rule, so do the latter. 2) Mixed declarations also do exist at the

Re: [Qemu-devel] [PATCH] CODING_STYLE: update line length and mixed declaration rules

2015-06-19 Thread Andreas Färber
Am 19.06.2015 um 09:29 schrieb Paolo Bonzini: 1) Line lengths above 80 characters do exist. They are rare, but they happen from time to time. An ignored rule is worse than an exception to the rule, so do the latter. 2) Mixed declarations also do exist at the top of #ifdef blocks. Remark

Re: [Qemu-devel] [PATCH] tap: fix non-linux build

2015-06-19 Thread Thomas Huth
On Fri, 19 Jun 2015 09:44:00 +0200 Michael S. Tsirkin m...@redhat.com wrote: tap_fd_set_vnet_le/tap_fd_set_vnet_be was missing, fix it up. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- net/tap-aix.c | 10 ++ net/tap-bsd.c | 10 ++ net/tap-haiku.c | 10

Re: [Qemu-devel] [PULL 00/10] virtio, pci fixes, enhancements

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 08:30, Michael S. Tsirkin m...@redhat.com wrote: They are trivial - a single patch on top that adds stubs for missing platforms. And I think breaking bisect on non-linux isn't a big deal. If you agree, please apply. I would prefer the fix folded in to the correct point in

[Qemu-devel] [PATCH v2 1/1] vvfat: add a label option

2015-06-19 Thread Wolfgang Bumiller
Until now the vvfat volume label was hardcoded to be QEMU VVFAT, now you can pass a file.label=labelname option to the -drive to change it. The FAT structure defines the volume label to be limited to 11 bytes and is filled up spaces when shorter than that. The trailing spaces however aren't

Re: [Qemu-devel] [PULL v2 07/12] vl: Create (most) objects before creating chardev backends

2015-06-19 Thread Paolo Bonzini
On 19/06/2015 12:03, Andreas Färber wrote: Am 27.05.2015 um 20:20 schrieb Andreas Färber: From: Daniel P. Berrange berra...@redhat.com Some types of object must be created before chardevs, other types of object must be created after chardevs. As such there is no option but to create

[Qemu-devel] [PATCH v3 0/5] target-mips: add UHI semihosting support

2015-06-19 Thread Leon Alrae
This series introduces the Unified Hosting Interface support to QEMU. Version 3 of this patchset contains just minor cleanup and corrections in mips-semi.c comparing to previous version. It has been on the mailing list for a while and given that command line option responsible for passing

Re: [Qemu-devel] [Qemu-block] [PATCH v7 00/11] Support streaming to an intermediate layer

2015-06-19 Thread Alberto Garcia
On Thu 18 Jun 2015 02:36:13 PM CEST, Eric Blake wrote: [Detecting support for intermediate block streaming] One possibility is to try to stream to an intermediate node and see if it fails. Example: in a chain like [A] - [B] - [C], streaming to [B] using [A] as the 'base' parameter is a

Re: [Qemu-devel] [PULL 00/10] virtio, pci fixes, enhancements

2015-06-19 Thread Michael S. Tsirkin
On Fri, Jun 19, 2015 at 09:32:48AM +0100, Peter Maydell wrote: On 19 June 2015 at 08:30, Michael S. Tsirkin m...@redhat.com wrote: They are trivial - a single patch on top that adds stubs for missing platforms. And I think breaking bisect on non-linux isn't a big deal. If you agree, please

[Qemu-devel] [RFC PATCH v4 5/5] spapr: Memory hotplug support

2015-06-19 Thread Bharata B Rao
Make use of pc-dimm infrastructure to support memory hotplug for PowerPC. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- hw/ppc/spapr.c| 126 ++ hw/ppc/spapr_events.c | 8 ++-- 2 files changed, 131 insertions(+), 3

Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V based guest crash data handling

2015-06-19 Thread Paolo Bonzini
On 19/06/2015 12:28, Andrey Smetanin wrote: On Wed, 2015-06-17 at 14:44 +0200, Paolo Bonzini wrote: On 11/06/2015 15:18, Denis V. Lunev wrote: From: Andrey Smetanin asmeta...@virtuozzo.com Windows 2012 guests can notify hypervisor about occurred guest crash (Windows bugcheck(BSOD)) by

Re: [Qemu-devel] [PATCH] nvme: Fix memleak in nvme_dma_read_prp

2015-06-19 Thread Stefan Hajnoczi
On Fri, Jun 19, 2015 at 02:27:34PM +0800, Ting Wang wrote: Please CC the maintainer of this source file: $ scripts/get_maintainer.pl -f hw/block/nvme.c Keith Busch keith.bu...@intel.com (supporter:nvme) Kevin Wolf kw...@redhat.com (supporter:Block layer core) qemu-bl...@nongnu.org (open

Re: [Qemu-devel] [PATCH v2 7/7] qdev-monitor: Propagate errors through qdev_device_add()

2015-06-19 Thread Andreas Färber
Am 13.06.2015 um 13:18 schrieb Markus Armbruster: Also polish an error message while I'm touching the line anyway, Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/monitor/qdev.h | 2 +- qdev-monitor.c | 36

Re: [Qemu-devel] [PATCH v2 2/7] qdev: Un-deprecate qdev_init_nofail()

2015-06-19 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 13.06.2015 um 13:18 schrieb Markus Armbruster: It's a perfectly sensible helper function. But only in the current state. Once/if we just set realized=true on /machine level, then no other helper functions will need to set it, as pointed out in the

Re: [Qemu-devel] [PATCH v2 1/7] qdev: Deprecated qdev_init() is finally unused, drop

2015-06-19 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Hi Markus, Could you please add a verbose rationale here like qdev_init() does not propagate the Error* and should be replaced by ...? What about: qdev_init() is a wrapper around setting property realized to true plus error handling, which

Re: [Qemu-devel] [PULL v2 43/60] i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted

2015-06-19 Thread Michael S. Tsirkin
On Fri, Jun 19, 2015 at 02:52:16PM +0200, Laszlo Ersek wrote: Your merge is closer to a rewrite than to conflict resolution, rendering my R-by totally meaningless. In the future, please either fully test such a merge, or ask the submitter / reviewers to review and test. Yes, please.

[Qemu-devel] [PULL 03/12] target-arm: Do not reset sysregs marked as ALIAS

2015-06-19 Thread Peter Maydell
From: Sergey Fedorov serge.f...@gmail.com cp_reg_reset() is called from g_hash_table_foreach() which does not define a specific ordering of the hash table iteration. Thus doing reset for registers marked as ALIAS would give an ambiguous result when resetvalue is different for original and alias

Re: [Qemu-devel] [PATCH v2 3/7] qdev-monitor: Stop error avalance in qbus_find_recursive()

2015-06-19 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Did you mean avalanche? Yes, fixing... Am 13.06.2015 um 13:18 schrieb Markus Armbruster: Reproducer: $ qemu-system-x86_64 -nodefaults -device virtio-rng-pci -device virtio-rng-pci -device virtio-rng-device,bus=virtio-bus

[Qemu-devel] [PATCH v2 2/3] m68k: implement move to/from usp register instruction

2015-06-19 Thread gerg
From: Greg Ungerer g...@uclinux.org Fill out the code support for the move to/from usp instructions. They are being decoded, but there is no code to support there actions. So add it. Current versions of Linux running on the ColdFire 5208 use these instructions. Signed-off-by: Greg Ungerer

[Qemu-devel] [PATCH v2 3/3] m68k: fix usp processing on interrupt entry and exception exit

2015-06-19 Thread gerg
From: Greg Ungerer g...@uclinux.org The action to potentially switch sp register is not occurring at the correct point in the interrupt entry or exception exit sequences. For the interrupt entry case the sp on entry is used to create the stack exception frame - but this may well be the user

[Qemu-devel] [PULL 07/12] target-arm: Add support for Cortex-R5

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Introduce a CPU model for the Cortex R5 processor. ARMv7 with MPU, and both thumb and ARM div instructions. Also implement dummy ATCM and BTCM. These CPs are defined for R5 but don't have a lot of meaning in QEMU yet. Raz them so the guest can

[Qemu-devel] [PULL 06/12] target-arm: Implement PMSAv7 MPU

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Unified MPU only. Uses ARM architecture major revision to switch between PMSAv5 and v7 when ARM_FEATURE_MPU is set. PMSA v6 remains unsupported and is asserted against. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Peter

[Qemu-devel] [PULL 02/12] hw/arm/sysbus-fdt: enable vfio-calxeda-xgmac dynamic instantiation

2015-06-19 Thread Peter Maydell
From: Eric Auger eric.au...@linaro.org This patch allows the instantiation of the vfio-calxeda-xgmac device from the QEMU command line (-device vfio-calxeda-xgmac,host=device). A specialized device tree node is created for the guest, containing compat, dma-coherent, reg and interrupts

[Qemu-devel] [PATCH v3 2/7] qdev: Un-deprecate qdev_init_nofail()

2015-06-19 Thread Markus Armbruster
It's a perfectly sensible helper function. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/hw/qdev-core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index

[Qemu-devel] [PATCH v3 6/7] qdev-monitor: Propagate errors through set_property()

2015-06-19 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Andreas Färber afaer...@suse.de --- qdev-monitor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index 12d8f6b..c7b00e0 100644 ---

Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Michael S. Tsirkin
On Fri, Jun 19, 2015 at 12:55:57PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Fri, Jun 19, 2015 at 11:13:40AM +0100, Peter Maydell wrote: On 19 June 2015 at 11:07, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Jun 19, 2015 at 12:00:53PM +0200, Greg

[Qemu-devel] [PATCH v2 0/3] m68k: fix ColdFire support

2015-06-19 Thread gerg
Some small issues are causing problems with running modern versions of Linux on the m68k/ColdFire 5208 target. These 3 patches fix those problems. They are all due to use of more advanced architecture features not used in older Linux kernels. Regards Greg v2: * rebased to current master head

[Qemu-devel] [PATCH v2 1/3] m68k: implement more ColdFire 5208 interrupt controller functionality

2015-06-19 Thread gerg
From: Greg Ungerer g...@uclinux.org Implement the SIMR and CIMR registers of the 5208 interrupt controller. These are used by modern versions of Linux running on ColdFire (not sure of the exact version they were introduced, but they have been in for quite a while now). Without this change when

[Qemu-devel] [PULL 08/12] arm: xlnx-zynqmp: Preface CPU variables with apu

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite peter.crosthwa...@xilinx.com The CPUs currently supported by zynqmp are the APU (application processing unit) CPUs. There are other CPUs in Zynqmp so unqualified cpus in ambiguous. Preface the variables with APU accordingly, to prepare support adding the RPU (realtime

[Qemu-devel] [PULL 04/12] target-arm/helper.c: define MPUIR register

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define the MPUIR register for MPU supporting ARMv6 and onwards. Currently we only support unified MPU. The size of the unified MPU is defined via the number of dregions. So just a single config is added to specify this size. (When split MPU is

[Qemu-devel] [PULL 05/12] target-arm: Add registers for PMSAv7

2015-06-19 Thread Peter Maydell
From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define the arm CP registers for PMSAv7 and their accessor functions. RGNR serves as a shared index that indexes into arrays storing the DRBAR, DRSR and DRACR registers. DRBAR and friends have to be VMSDd separately from the CP interface using a

Re: [Qemu-devel] [PATCH v3 3/8] qapi: change Netdev and NetLegacy into a flat union

2015-06-19 Thread Stefan Hajnoczi
On Thu, Jun 18, 2015 at 06:43:45PM +0200, Kővágó, Zoltán wrote: @@ -713,8 +710,6 @@ int net_init_tap(const NetClientOptions *opts, const char *name, const char *vhostfdname; char ifname[128]; -assert(opts-kind == NET_CLIENT_OPTIONS_KIND_TAP); -tap = opts-tap; ... @@

Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Michael S. Tsirkin
On Fri, Jun 19, 2015 at 04:00:05PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Fri, Jun 19, 2015 at 12:55:57PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Fri, Jun 19, 2015 at 11:13:40AM +0100, Peter Maydell wrote:

[Qemu-devel] [PATCH v3 0/7] qdev: Mostly wean off QError

2015-06-19 Thread Markus Armbruster
Only the calls in do_device_add() remain, because QMP's command handler interface requires them. They'll go away when I wean QMP off QError. Bonus: a few error reporting improvements. Casualty: some explanatory messages, see PATCH 5. v3: * Trivially rebased, R-bys retained * PATCH 1: Add

[Qemu-devel] [PATCH v3 5/7] qdev-monitor: Convert qbus_find() to Error

2015-06-19 Thread Markus Armbruster
As usual, the conversion breaks printing explanatory messages after the error: actual printing of the error gets delayed, so the explanations precede rather than follow it. Pity. Disable them for now. See also commit 7216ae3. While there, eliminate QERR_BUS_NOT_FOUND, and clean up unusual

[Qemu-devel] [PULL 12/12] semihosting: add --semihosting-config arg sub-argument

2015-06-19 Thread Peter Maydell
From: Leon Alrae leon.al...@imgtec.com Add new arg sub-argument to the --semihosting-config allowing the user to pass multiple input arguments separately. It is required for example by UHI semihosting to construct argc and argv. Also, update ARM semihosting to support new option (at the moment

Re: [Qemu-devel] [PATCH v2 7/7] qdev-monitor: Propagate errors through qdev_device_add()

2015-06-19 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 13.06.2015 um 13:18 schrieb Markus Armbruster: Also polish an error message while I'm touching the line anyway, Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- include/monitor/qdev.h | 2 +-

[Qemu-devel] [PULL 11/12] semihosting: create SemihostingConfig structure and semihost.h

2015-06-19 Thread Peter Maydell
From: Leon Alrae leon.al...@imgtec.com Remove semihosting_enabled and semihosting_target and replace them with SemihostingConfig structure containing equivalent fields. The structure is defined in vl.c where it is actually set. Also introduce separate header file include/exec/semihost.h allowing

Re: [Qemu-devel] [PATCH] vhost_net: fix misuse of assert()

2015-06-19 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Fri, Jun 19, 2015 at 12:55:57PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Fri, Jun 19, 2015 at 11:13:40AM +0100, Peter Maydell wrote: On 19 June 2015 at 11:07, Michael S. Tsirkin m...@redhat.com wrote: On

[Qemu-devel] [PATCH v3 3/7] qdev-monitor: Stop error avalanche in qbus_find_recursive()

2015-06-19 Thread Markus Armbruster
Reproducer: $ qemu-system-x86_64 -nodefaults -device virtio-rng-pci -device virtio-rng-pci -device virtio-rng-device,bus=virtio-bus qemu-system-x86_64: -device virtio-rng-device,bus=virtio-bus: Bus 'virtio-bus' is full qemu-system-x86_64: -device virtio-rng-device,bus=virtio-bus:

[Qemu-devel] [PATCH v3 7/7] qdev-monitor: Propagate errors through qdev_device_add()

2015-06-19 Thread Markus Armbruster
Also polish an error message while I'm touching the line anyway, Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Andreas Färber afaer...@suse.de --- include/monitor/qdev.h | 2 +- qdev-monitor.c | 36

[Qemu-devel] [PATCH v3 4/7] qdev-monitor: Fix check for full bus

2015-06-19 Thread Markus Armbruster
Property bus has always been too screwed up to be really usable for values other than plain bus IDs. This just fixes a bug that crept in in commit 1395af6 qdev: add a maximum device allowed field for the bus. It doesn't always fail when it should: $ qemu-system-x86_64 -nodefaults -device

Re: [Qemu-devel] [PULL 00/10] virtio, pci fixes, enhancements

2015-06-19 Thread Peter Maydell
On 19 June 2015 at 11:19, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Jun 19, 2015 at 09:32:48AM +0100, Peter Maydell wrote: On 19 June 2015 at 08:30, Michael S. Tsirkin m...@redhat.com wrote: They are trivial - a single patch on top that adds stubs for missing platforms. And I think

[Qemu-devel] [PATCH v2] vhost_net: fix misuse of assert()

2015-06-19 Thread Greg Kurz
From assert(3): assert() is implemented as a macro; if the expression tested has side-effects, program behavior will be different depending on whether NDEBUG is defined. Even if QEMU isn't compiled with NDEBUG, it is bad practice to put bits with a relevant functionnal meaning in assert(). This

  1   2   3   4   >