Re: [Qemu-devel] [PATCH for-2.4] virtio-net: Flush incoming queues when DRIVER_OK is being set

On 07/15/2015 11:02 AM, Fam Zheng wrote: > This patch fixes network hang after "stop" then "cont", while network > packets keep arriving. I think it also fixes network hand when the guest boots, while network packets keep arriving. Thanks Wen Congyang > > Tested both manually (tap, host pinging

Re: [Qemu-devel] [PATCH 1/2 v2] virtio-rng: Bump up quota value only when guest requests entropy

On (Tue) 14 Jul 2015 [13:03:09], Pankaj Gupta wrote: > This patch triggers timer only when guest requests for > entropy. As soon as first request from guest for entropy > comes we set the timer. Timer bumps up the quota value > when it gets triggered. > > Signed-off-by: Pankaj Gupta Reviewed-

Re: [Qemu-devel] [PATCH 2/2 v2] virtio-rng: Serve pending request if any after timer bumps up quota.

On (Tue) 14 Jul 2015 [13:03:10], Pankaj Gupta wrote: > We are arming timer when we get first request from guest. > Even if guest pulls all the data we will be serving guest > only when timer bumps up new quota. When timer expires > we check if we have a pending request from guest, we > serve it

[Qemu-devel] [PATCH] virtio-net: remove virtio queues if the guest doesn't support multiqueue

commit da51a335 adds all queues in .realize(). But if the guest doesn't support multiqueue, we forget to remove them. And we cannot handle the ctrl vq corretly. The guest will hang. Signed-off-by: Wen Congyang --- hw/net/virtio-net.c | 69 + 1

Re: [Qemu-devel] [PATCH for-2.4 06/12] etsec: Flush queue when rx buffer is consumed

On Wed, 07/15 13:10, Jason Wang wrote: > >> And can we do this without a bh? Otherwise, we may need to stop and > >> restart the bh during vm stop and start? > > A bh doesn't hurt when vm stop and restart (we get superfluous flush), > > The problem is qemu_flush_queued_packets() does not check run

[Qemu-devel] [v10][PATCH 10/10] xen, gfx passthrough: add opregion mapping

The OpRegion shouldn't be mapped 1:1 because the address in the host can't be used in the guest directly. This patch traps read and write access to the opregion of the Intel GPU config space (offset 0xfc). The original patch is from Jean Guyader Signed-off-by: Tiejun Chen Signed-off-by: Yang Z

[Qemu-devel] [v10][PATCH 08/10] xen, gfx passthrough: register a isa bridge

Currently we just register this isa bridge when we use IGD passthrough in Xen side. Signed-off-by: Tiejun Chen Acked-by: Stefano Stabellini --- v10: * Don't extern igd_passthrough_isa_bridge_create() in the include/hw/xen/xen.h file. Instead, move inside the include/hw/i386/pc.h file in pat

[Qemu-devel] [v10][PATCH 05/10] xen, gfx passthrough: basic graphics passthrough support

basic gfx passthrough support: - add a vga type for gfx passthrough - register/unregister legacy VGA I/O ports and MMIOs for passthrough GFX Signed-off-by: Tiejun Chen Signed-off-by: Yang Zhang Acked-by: Stefano Stabellini --- v10: * Nothing is changed. v9: * Just rebase on the latest. h

[Qemu-devel] [Bug 1384892] Re: RTL8168 NIC VFIO not working anymore since QEMU 2.1

Yes, thank you, that adapted patch looks good to me. It seems V2.4 based though, so it would need to be backported down to 2.3 through 2.1. Is there an established process for that kind of backporting need ? Do you confirm my 'not reached' hypothesis (which would explain why your patch #4 did not

[Qemu-devel] [v10][PATCH 03/10] piix: create host bridge to passthrough

Implement a pci host bridge specific to passthrough. Actually this just inherits the standard one. And we also just expose a minimal real host bridge pci configuration subset. Signed-off-by: Tiejun Chen Acked-by: Michael S. Tsirkin --- v10: * Nothing is changed. v9: * Just rebase on the lat

[Qemu-devel] [v10][PATCH 09/10] xen, gfx passthrough: register host bridge specific to passthrough

Just register that pci host bridge specific to passthrough. Signed-off-by: Tiejun Chen Acked-by: Stefano Stabellini --- v10: * Nothing is changed. v9: * Simplify pc_xen_hvm_init_pci() hw/i386/pc_piix.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/

[Qemu-devel] [v10][PATCH 04/10] hw/pci-assign: split pci-assign.c

We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. Signed-off-by: Tiejun Chen Acked-by: Michael S. Tsirkin --- v10: * Nothing is changed. v9: * Just rebase on the latest. hw/i386/Mak

[Qemu-devel] [v10][PATCH 07/10] igd gfx passthrough: create a isa bridge

Currently IGD drivers always need to access PCH by 1f.0. But we don't want to poke that directly to get ID, and although in real world different GPU should have different PCH. But actually the different PCH DIDs likely map to different PCH SKUs. We do the same thing for the GPU. For PCH, the differ

[Qemu-devel] [v10][PATCH 06/10] xen, gfx passthrough: retrieve VGA BIOS to work

Now we retrieve VGA bios like kvm stuff in qemu but we need to fix Device Identification in case if its not matched with the real IGD device since Seabios is always trying to compare this ID to work out VGA BIOS. Signed-off-by: Tiejun Chen Acked-by: Stefano Stabellini --- v10: * Nothing is cha

[Qemu-devel] [v10][PATCH 02/10] pc_init1: pass parameters just with types

Pass types to configure pc_init1(). Signed-off-by: Tiejun Chen Acked-by: Michael S. Tsirkin --- v10: * Nothing is changed. v9: * Just rebase on the latest. hw/i386/pc_piix.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_p

[Qemu-devel] [v10][PATCH 01/10] i440fx: make types configurable at run-time

From: "Michael S. Tsirkin" IGD passthrough wants to supply a different pci and host devices, inheriting i440fx devices. Make types configurable. Signed-off-by: Michael S. Tsirkin Signed-off-by: Tiejun Chen --- v10: * Nothing is changed. v9: * Just rebase on the latest. hw/i386/pc_piix.c

[Qemu-devel] [v10][PATCH 00/10] xen: add Intel IGD passthrough

v10: * Don't extern igd_passthrough_isa_bridge_create() in the include/hw/xen/xen.h file. Instead, move inside the include/hw/i386/pc.h file in patch #7 v9: * Rebase on the latest * Inside patch #8, move is_igd_vga_passthrough(dev)) from xen_igd_passthrough_isa_bridge_create() into xen_pt_

[Qemu-devel] [PATCH V2 5/5] virtio-blk: set VIRTIO_F_ANY_LAYOUT when 1.0 is supported

Chapter 6.3 of spec said " Transitional devices MUST offer, and if offered by the device transitional drivers MUST accept the following: VIRTIO_F_ANY_LAYOUT (27) " So this patch sets VIRTIO_F_ANY_LAYOUT when 1.0 is supported. Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: qemu-bl...@nongnu.org Signed

[Qemu-devel] [PATCH V2 1/5] virtio: get_features() can fail

Signed-off-by: Jason Wang --- hw/9pfs/virtio-9p-device.c | 3 ++- hw/block/virtio-blk.c | 3 ++- hw/char/virtio-serial-bus.c | 3 ++- hw/display/virtio-gpu.c | 3 ++- hw/input/virtio-input.c | 3 ++- hw/net/virtio-net.c | 3 ++- hw/scsi/vhost-scsi.c| 3 ++- hw/scsi/

[Qemu-devel] [PATCH V2 2/5] virtio-blk: advertise scsi only when scsi is set

Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: qemu-bl...@nongnu.org Signed-off-by: Jason Wang --- hw/block/virtio-blk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 4c27974..761d763 100644 --- a/hw/block/virtio-blk.c +++ b/h

[Qemu-devel] [PATCH V2 0/5] Set correct blk feature for virtio 1.0

Hi all: This series tries to set feature correctly for virtio-blk when virtio 1.0 is supported. Two isssues were addressed according to the spec: - scsi passthrough was not support in 1.0. This is done by, 1) disable scsi by defautl for 2.4 machine type and fail the initialization when both s

[Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default

Disable scsi passthrough by default since it was incompatible with virtio 1.0. For legacy machine types, keep this on by default. Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: qemu-bl...@nongnu.org Signed-off-by: Jason Wang --- hw/block/virtio-blk.c | 2 +- include/hw/compat.h | 6 +- 2 files c

[Qemu-devel] [PATCH V2 4/5] virtio-blk: fail the init when both 1.0 and scsi is set

Scsi passthrough was no longer supported in 1.0, so fail the initialization when user want both features. Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: qemu-bl...@nongnu.org Signed-off-by: Jason Wang --- hw/block/virtio-blk.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/block/virtio-blk

[Qemu-devel] [Bug 1054558] Re: 1366x768 resolution missing

Thanks you, I will test with virt-manager. I'm using a windows 8.1 installation. Seems like it need wqhl drivers, and The driver I found [1] did not work for this resolution. Maybe I should test compiling seabios as commented on that blog Thanks you [1] https://supervacuo.com/2014/sep/28/window

Re: [Qemu-devel] [PATCH for-2.4 06/12] etsec: Flush queue when rx buffer is consumed

On 07/14/2015 05:48 PM, Fam Zheng wrote: > On Tue, 07/14 17:33, Jason Wang wrote: >> >> On 07/14/2015 03:53 PM, Fam Zheng wrote: >>> The BH will be scheduled when etsec->rx_buffer_len is becoming 0, which >>> is the condition of queuing. >>> >>> Signed-off-by: Fam Zheng >> I suggest to squash th

Re: [Qemu-devel] [PULL v3 05/22] cpu: Convert cpu_index into a bitmap

On Tue, Jul 14, 2015 at 5:17 PM, Igor Mammedov wrote: > On Tue, 14 Jul 2015 16:08:54 +0530 > Bharata B Rao wrote: > >> On Thu, Jul 09, 2015 at 03:23:55PM +0200, Andreas Färber wrote: >> > From: Bharata B Rao >> > >> > Currently CPUState::cpu_index is monotonically increasing and a newly >> > cre

Re: [Qemu-devel] [PATCH v2] more check for replaced node

On 07/15/2015 11:05 AM, Fam Zheng wrote: > On Wed, 07/15 09:41, Wen Congyang wrote: >> We use mirror+replace to fix quorum's broken child. bs/s->common.bs >> is quorum, and to_replace is the broken child. The new child is target_bs. >> Without this patch, the replace node can be any node, and it ca

Re: [Qemu-devel] [PATCH v2] more check for replaced node

On Wed, 07/15 09:41, Wen Congyang wrote: > We use mirror+replace to fix quorum's broken child. bs/s->common.bs > is quorum, and to_replace is the broken child. The new child is target_bs. > Without this patch, the replace node can be any node, and it can be > top BDS with BB, or another quorum's ch

[Qemu-devel] [PATCH for-2.4] virtio-net: Flush incoming queues when DRIVER_OK is being set

This patch fixes network hang after "stop" then "cont", while network packets keep arriving. Tested both manually (tap, host pinging guest) and with Jason's qtest series (plus his "[PATCH 2.4] socket: pass correct size in net_socket_send()" fix). As virtio_net_set_status is called when guest driv

Re: [Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

On Tue, 07/14 15:42, Michael S. Tsirkin wrote: > On Tue, Jul 14, 2015 at 01:20:03PM +0100, Stefan Hajnoczi wrote: > > On Fri, Jul 10, 2015 at 05:03:22PM +0800, Fam Zheng wrote: > > > On Tue, 07/07 12:19, Michael S. Tsirkin wrote: > > > > On Tue, Jul 07, 2015 at 05:09:09PM +0800, Fam Zheng wrote: >

[Qemu-devel] [PULL for-2.4 5/5] block/curl: Don't lose original error when a connection fails.

From: "Richard W.M. Jones" Currently if qemu is connected to a curl source (eg. web server), and the web server fails / times out / dies, you always see a bogus EIO "Input/output error". For example, choose a large file located on any local webserver which you control: $ qemu-img convert -p h

[Qemu-devel] [PULL for-2.4 4/5] mirror: correct buf_size

From: Wen Congyang If bus_size is less than 0, the command fails. If buf_size is 0, use DEFAULT_MIRROR_BUF_SIZE. If buf_size % granularity is not 0, mirror_free_init() will do dangerous things. Signed-off-by: Wen Congyang Reviewed-by: Fam Zheng Message-id: a588.3080...@cn.fujitsu.com Signe

[Qemu-devel] [PULL for-2.4 2/5] blockdev: no need to drain in qmp_block_commit

From: Paolo Bonzini Draining is not necessary, I/O can happen as soon as the commit coroutine yields. Draining can be necessary before reopening the file for read/write, or while modifying the backing file chain, but that is done separately in bdrv_reopen_multiple or bdrv_close; this particular

[Qemu-devel] [PULL for-2.4 0/5] Block layer patches for 2.4.0-rc1

The following changes since commit 661725da09f47eb92d356fac10a4cf3b7ad1f61d: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20150714' into staging (2015-07-14 18:50:17 +0100) are available in the git repository at: g...@github.com:codyprime/qemu-kvm-jtc.git tags/jtc-fo

[Qemu-devel] [PULL for-2.4 3/5] block: keep bitmap if incremental backup job is cancelled

From: Stefan Hajnoczi Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret variable may be 0 when the job is cancelled so it's not enough to check ret < 0. Reviewed-by: John Snow Signed-off-by: Stefan Hajnoczi Message-id: 1434380534-7680-1-git-send-email-stefa...@

[Qemu-devel] [PULL for-2.4 1/5] block/mirror: Sleep periodically during bitmap scanning

From: Fam Zheng Before, we only yield after initializing dirty bitmap, where the QMP command would return. That may take very long, and guest IO will be blocked. Add sleep points like the later mirror iterations. Signed-off-by: Fam Zheng Reviewed-by: Wen Congyang Reviewed-by: Paolo Bonzini R

[Qemu-devel] [PATCH v2] more check for replaced node

We use mirror+replace to fix quorum's broken child. bs/s->common.bs is quorum, and to_replace is the broken child. The new child is target_bs. Without this patch, the replace node can be any node, and it can be top BDS with BB, or another quorum's child. We just check if the broken child is part of

Re: [Qemu-devel] [RFC PATCH qemu v2 1/5] vfio: Switch from TARGET_PAGE_MASK to qemu_real_host_page_mask

On 07/15/2015 08:28 AM, Alex Williamson wrote: On Tue, 2015-07-14 at 16:58 +1000, Alexey Kardashevskiy wrote: On 07/14/2015 05:13 AM, Alex Williamson wrote: On Tue, 2015-07-14 at 00:56 +1000, Alexey Kardashevskiy wrote: These started switching from TARGET_PAGE_MASK (hardcoded as 4K) to a real

[Qemu-devel] GSoC 2015 (Mac OS 9 support) report, week 11

[Done] - Update project log (6.17) - Debug OpenBIOS ADB issues since agraf's 26a9dfe patch - Install macbugs on hard disk image via MOL - Installed on the installation iso to move on for now ... - Patch: RTAS node - Patch has been sent in and is awaiting review. - We don't need

[Qemu-devel] TLB, cpu_mmu_index() and load/store vs ifetch

Hi Paolo, Alex ! I was looking at the patches for speeding up ppc and was trying to figure out if we could do things better, and reduce the number of modes and flushes associated with them. While trying to understand it all, I found something that might be a problem: How we handle the fact that we

Re: [Qemu-devel] [RFC PATCH qemu v2 1/5] vfio: Switch from TARGET_PAGE_MASK to qemu_real_host_page_mask

On Tue, 2015-07-14 at 16:58 +1000, Alexey Kardashevskiy wrote: > On 07/14/2015 05:13 AM, Alex Williamson wrote: > > On Tue, 2015-07-14 at 00:56 +1000, Alexey Kardashevskiy wrote: > >> These started switching from TARGET_PAGE_MASK (hardcoded as 4K) to > >> a real host page size: > >> 4e51361d7 "cpu-

Re: [Qemu-devel] [PATCH] target-mips: apply workaround for TCG optimizations for MFC1

On 2015-07-14 22:56, Paolo Bonzini wrote: > > > On 14/07/2015 20:37, Aurelien Jarno wrote: > >> > > >> > I certainly don't have a global view, so much that I didn't think at > >> > all of the optimizer... Instead, it looks to me like a bug in the > >> > register allocator. In particular this

Re: [Qemu-devel] [ARM SMBIOS RFC PATCH 0/5] SMBIOS Support for ARM

Cc'ing Ard. On 07/14/15 22:23, Wei Huang wrote: > SMBIOS tables present userful system hardware info to management > applications, such as DMI tools. Even though SMBIOS was originally > developed for Intel x86, it has been extended to both Itanium and > ARM (32bit & 64bit). More and more ARM serv

Re: [Qemu-devel] [PATCH] linux-user: add signalfd/signalfd4 syscalls

Thank you for your comments. I'm currently writing a v2 of this patch with what I've learned working on the netlink interface. I will fix it accordingly all your comments. [ Now, I can boot a PPC64 container with systemd on an x86_64 host: https://asciinema.org/a/7sgwvok72m34v7hg08hfspg4s ] Laur

Re: [Qemu-devel] [PATCH] target-mips: apply workaround for TCG optimizations for MFC1

On 14/07/2015 20:37, Aurelien Jarno wrote: >> > >> > I certainly don't have a global view, so much that I didn't think at >> > all of the optimizer... Instead, it looks to me like a bug in the >> > register allocator. In particular this code in tcg_reg_alloc_mov: > That's exactly my point whe

Re: [Qemu-devel] [PATCH] linux-user: add signalfd/signalfd4 syscalls

On 29 May 2015 at 23:50, Laurent Vivier wrote: > This patch introduces a system very similar to the one used in the kernel > to attach specific functions to a given file descriptor. > > In this case, we attach a specific "read()" to the fd returned by > signalfd() to be able to byte-swap the signa

Re: [Qemu-devel] [PATCH v2] ich9: initialise RCBA register through LPC interface

On Tue, 14 Jul 2015 15:55:24 +0200 Gerd Hoffmann wrote: > On Do, 2015-07-09 at 21:04 -0300, Paulo Alcantara wrote: > > This patch initialises root complex register block BAR in order to > > support TCO watchdog emulation features on QEMU. > > qemu patches are merged, committed this one too now.

Re: [Qemu-devel] [PATCH v2] thread-win32: fix GetThreadContext() permanently fails

On Tue, Jul 14, 2015 at 11:29 PM, Stefan Weil wrote: > I'll send a pull request for this patch after the release of QEMU 2.4. > Ok. Thanks.

Re: [Qemu-devel] [PATCH v2] thread-win32: fix GetThreadContext() permanently fails

Am 14.07.2015 um 21:44 schrieb Zavadovsky Yan: On Wed, Jul 1, 2015 at 9:00 PM, Stefan Weil > wrote: Fabien, you suggested "extensive tests". Do you think that patch v2 is fine, or are you still waiting for test results? On Mon, Jul 6, 2015 at 12:29 PM, Fabien Ch

[Qemu-devel] [ARM SMBIOS RFC PATCH 4/5] smbios: move smbios code into a common folder

To share smbios among different architectures, this patch moves SMBIOS code (smbios.c and smbios.h) from x86 specific folders into new hw/smbios directories. As a result, CONFIG_SMBIOS=y is defined in x86 default config files. Signed-off-by: Wei Huang --- arch_init.c|

[Qemu-devel] [ARM SMBIOS RFC PATCH 5/5] smbios: implement smbios support for mach-virt

This patch generates smbios tables for ARM mach-virt. Also add CONFIG_SMBIOS=y for ARM default config. Signed-off-by: Wei Huang --- default-configs/arm-softmmu.mak | 1 + hw/arm/virt.c| 24 include/hw/arm/virt-acpi-build.h | 1 + 3 files changed, 2

[Qemu-devel] [ARM SMBIOS RFC PATCH 1/5] smbios: extract x86 smbios building code into a function

This patch extracts out the procedure of buidling x86 SMBIOS tables into a dedicated function. Signed-off-by: Wei Huang --- hw/i386/pc.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 7661ea9..00e45f3

[Qemu-devel] [ARM SMBIOS RFC PATCH 2/5] smbios: remove dependency on x86 e820 tables

Current smbios builds type 19 table from e820, which is x86 specific. This patch removes smbios' dependency on e820 by passing an array of memory area to smbios_get_tables(). Signed-off-by: Wei Huang --- hw/i386/pc.c | 18 +- hw/i386/smbios.c | 14 +++-

[Qemu-devel] [ARM SMBIOS RFC PATCH 0/5] SMBIOS Support for ARM

SMBIOS tables present userful system hardware info to management applications, such as DMI tools. Even though SMBIOS was originally developed for Intel x86, it has been extended to both Itanium and ARM (32bit & 64bit). More and more ARM server releases, such as RHEL Server for ARM, start to integ

[Qemu-devel] [ARM SMBIOS RFC PATCH 3/5] smbios: pass ram size as a parameter to build smbios tables

This patch adds a new parameter, mem_size, to smbios_get_tables() function. This step is required to make smbios code architect-independent. Signed-off-by: Wei Huang --- hw/i386/pc.c | 2 +- hw/i386/smbios.c | 8 include/hw/i386/smbios.h | 2 ++ 3 files changed, 7 in

Re: [Qemu-devel] [PATCH v2] thread-win32: fix GetThreadContext() permanently fails

On Wed, Jul 1, 2015 at 9:00 PM, Stefan Weil wrote: > > Fabien, you suggested "extensive tests". Do you think that > patch v2 is fine, or are you still waiting for test results? On Mon, Jul 6, 2015 at 12:29 PM, Fabien Chouteau wrote: > That's good for me. > Ping... http://patchwork.ozlabs.org/

Re: [Qemu-devel] [PATCH] gdbstub: Implement Xfer:auxv:read

On 1 July 2015 at 12:00, Bhushan Attarde wrote: > Implementation of "Xfer:auxv:read" to provide auxiliary vector information > to clients which relies on it. > > For example: AT_ENTRY in auxiliary vector provides the entry point > information. > Client can use this information to compare it with

Re: [Qemu-devel] [Qemu-block] [PATCH 0/4] rbd cleanup and settings precedence fixes

On 07/14/2015 07:20 AM, Kevin Wolf wrote: Am 09.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben: On Tue, Jun 30, 2015 at 11:28:18AM -0700, Josh Durgin wrote: Ping On 06/10/2015 08:28 PM, Josh Durgin wrote: Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of cache options and c

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

On Tue, Jul 14, 2015 at 07:48:30PM +0100, Richard W.M. Jones wrote: > > > > /* read chunk of given fw_cfg blob (caller responsible for > > > > sanity-check) */ > > > > static inline void fw_cfg_read_blob(uint16_t select, > > > > void *buf, loff_t pos, size_t >

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

Hi, > > > /* read chunk of given fw_cfg blob (caller responsible for sanity-check) > > > */ > > > static inline void fw_cfg_read_blob(uint16_t select, > > >void *buf, loff_t pos, size_t count) > > > { > > > mutex_lock(&fw_cfg_dev_lock); > > > outw(select, FW_

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

On 14 July 2015 at 19:48, Richard W.M. Jones wrote: > A long time ago I wrote a memcpy and a "pseudo-DMA" interface for > fw_cfg, but they were both roundly rejected as you can find in the > archives. IIRC opinions have changed on the pseudo-DMA approach since then; last time it was suggested I t

Re: [Qemu-devel] [PULL for-2.4 0/2] Fixes for s390x

On 14 July 2015 at 18:26, Cornelia Huck wrote: > The following changes since commit 0030ff40472b9ebf0e0595afbc8d7e428218c5d7: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-20150714-1' into > staging (2015-07-14 14:52:45 +0100) > > are availa

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

On Tue, Jul 14, 2015 at 07:48:29PM +0100, Richard W.M. Jones wrote: > On aarch64 kernel loading is really slow because it can only transfer > (IIRC) 8 bytes at a time, and there are no string instructions we can > use to speed it up. I should note here I'm talking about AAVMF (ie. guest UEFI) whic

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

On Tue, Jul 14, 2015 at 02:23:14PM -0400, Gabriel L. Somlo wrote: > On Tue, Jul 14, 2015 at 10:43:46AM +0100, Richard W.M. Jones wrote: > > On Mon, Jul 13, 2015 at 04:09:37PM -0400, Gabriel L. Somlo wrote: > > > 3. I'm currently only handling x86 and I/O ports. I could drop the > > >fw_cfg_dmi_

Re: [Qemu-devel] vm internal snapshot deletes only delete first disk's snapshots

Looks like this is fixed in master. commit af957387547b05ed6dc4d84c10cca42700a7aeda Author: Zhang Haoyu Date: Mon Sep 29 16:38:02 2014 +0800 snapshot: fix referencing wrong variable in while loop in do_delvm The while loop variabal is "bs1", but "bs" is always passed to bdrv

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

On Tue, Jul 14, 2015 at 02:23:14PM -0400, Gabriel L. Somlo wrote: > On Tue, Jul 14, 2015 at 10:43:46AM +0100, Richard W.M. Jones wrote: > > On Mon, Jul 13, 2015 at 04:09:37PM -0400, Gabriel L. Somlo wrote: > > > 3. I'm currently only handling x86 and I/O ports. I could drop the > > >fw_cfg_dmi_

Re: [Qemu-devel] [PATCH] target-mips: apply workaround for TCG optimizations for MFC1

On 2015-07-14 20:20, Paolo Bonzini wrote: > > > On 14/07/2015 19:09, Aurelien Jarno wrote: > > On 2015-07-14 17:38, Leon Alrae wrote: > >> There seems to be an issue when trying to keep a pointer in bottom 32-bits > >> of a 64-bit floating point register. Load and store instructions accessing > >

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

On Tue, Jul 14, 2015 at 10:43:46AM +0100, Richard W.M. Jones wrote: > On Mon, Jul 13, 2015 at 04:09:37PM -0400, Gabriel L. Somlo wrote: > > 3. I'm currently only handling x86 and I/O ports. I could drop the > >fw_cfg_dmi_whitelist and just check the signature, using mmio where > >appropriat

Re: [Qemu-devel] [PATCH] target-mips: apply workaround for TCG optimizations for MFC1

On 14/07/2015 19:09, Aurelien Jarno wrote: > On 2015-07-14 17:38, Leon Alrae wrote: >> There seems to be an issue when trying to keep a pointer in bottom 32-bits >> of a 64-bit floating point register. Load and store instructions accessing >> this address for some reason use the whole 64-bit cont

Re: [Qemu-devel] [PULL 00/11] Block layer patches for 2.4.0-rc1

On 14 July 2015 at 16:39, Kevin Wolf wrote: > The following changes since commit f3a1b5068cea303a55e2a21a97e66d057eaae638: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2015-07-13 13:35:51 +0100) > > are available in the git repository at: > > > git://repo.o

Re: [Qemu-devel] [PATCH 6/6] ARM: enable PMSAv7-style MPU on Cortex-M3/M4

On 7 July 2015 at 19:25, Alex Zuepke wrote: A commit message that wasn't just the one-line summary would be nice. Sometimes a patch really is trivial enough that it's not worth describing in more than just a single line, but those situations are the exception rather than the rule. > Signed-off-b

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

On Mon, 13 Jul 2015 18:35:53 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 13, 2015 at 03:20:59PM +0200, Cornelia Huck wrote: > > On Mon, 13 Jul 2015 15:36:00 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Jul 13, 2015 at 02:30:24PM +0200, Cornelia Huck wrote: > > > > On Mon, 13 Jul

[Qemu-devel] [PULL for-2.4 0/2] Fixes for s390x

The following changes since commit 0030ff40472b9ebf0e0595afbc8d7e428218c5d7: Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-20150714-1' into staging (2015-07-14 14:52:45 +0100) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20150714

[Qemu-devel] [PULL for-2.4 2/2] s390/virtio-ccw: Fix migration

From: Christian Borntraeger commit 213941d73b ("virtio-ccw: migrate ->revision") broke migration: 2015-07-07T11:22:55.570968Z qemu-system-s390x: VQ 39 address 0x0 inconsistent with Host index 0x100 2015-07-07T11:22:55.571008Z qemu-system-s390x: error while loading state for instance 0x0 of If

[Qemu-devel] [PULL for-2.4 1/2] watchdog/diag288: correctly register for system reset requests

From: Xu Wang The diag288 watchdog is no sysbus device, therefore it doesn't get triggered on resets automatically using dc->reset. Let's register the reset handler manually, so we get correctly notified again when a system reset was requested. Also reset the watchdog on subsystem resets that do

Re: [Qemu-devel] [PATCH 4/6] ARM: Cortex-M3/M4: on exception, set basic bits in exhandling registers

On 7 July 2015 at 19:25, Alex Zuepke wrote: > > Signed-off-by: Alex Zuepke > --- > target-arm/helper.c |7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index 812204f..555bc5f 100644 > --- a/target-arm/helper.c > +++ b/

Re: [Qemu-devel] [PATCH 2/2] target-mips: simplify LWL/LDL mask generation

On 14/07/2015 18:45, Aurelien Jarno wrote: >>> > > >>> > > mask = 0x7fffull >> (t1 ^ 63) >>> > > >>> > > It's simpler to generate it by doing: >>> > > >>> > > mask = (1 << t1) - 1 >> > >> > Using ~(-1 << t1) may let you use an ANDN instruction, and is also the >> > same nu

Re: [Qemu-devel] [PATCH] target-mips: apply workaround for TCG optimizations for MFC1

On 2015-07-14 17:38, Leon Alrae wrote: > There seems to be an issue when trying to keep a pointer in bottom 32-bits > of a 64-bit floating point register. Load and store instructions accessing > this address for some reason use the whole 64-bit content of floating point > register rather than trunc

Re: [Qemu-devel] [PATCH 1/6] ARM: add Cortex-M3/M4 exception configuration and status registers

On 7 July 2015 at 19:25, Alex Zuepke wrote: > > Signed-off-by: Alex Zuepke > --- > target-arm/cpu.h | 51 > ++ > target-arm/machine.c |6 ++ > 2 files changed, 57 insertions(+) > > diff --git a/target-arm/cpu.h b/target-arm/cpu.h > i

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

On Mon, Jul 13, 2015 at 05:03:02PM -0600, Eric Blake wrote: > On 07/13/2015 02:09 PM, Gabriel L. Somlo wrote: > > 2. File names are listed in /sys/fs/fw_cfg/... with slashes replaced > >exclamation marks, e.g.: > > Instead of inventing yet another escaping mechanism, can you mimic an > already

Re: [Qemu-devel] [PATCH 3/6] ARM: Cortex-M3/M4: honor STKALIGN in CCR

On 7 July 2015 at 19:25, Alex Zuepke wrote: > > Signed-off-by: Alex Zuepke > --- > hw/intc/armv7m_nvic.c |2 +- > target-arm/helper.c |5 ++--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c > index e6ae047..369ef94 100

Re: [Qemu-devel] [PATCH 2/6] ARM: accessors to Cortex-M3/M4 exception configuration and status registers

On 7 July 2015 at 19:25, Alex Zuepke wrote: > > Signed-off-by: Alex Zuepke > --- > hw/intc/armv7m_nvic.c | 70 > ++--- > 1 file changed, 61 insertions(+), 9 deletions(-) > > diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c > index e13b729.

Re: [Qemu-devel] [PATCH 2/2] target-mips: simplify LWL/LDL mask generation

On 2015-07-14 18:17, Paolo Bonzini wrote: > > > On 14/07/2015 17:45, Aurelien Jarno wrote: > > The LWL/LDL instructions mask the GPR with a mask depending on the > > address alignement. It is currently computed by doing: > > > > mask = 0x7fffull >> (t1 ^ 63) > > > > It's simpler

[Qemu-devel] [PATCH] target-mips: apply workaround for TCG optimizations for MFC1

There seems to be an issue when trying to keep a pointer in bottom 32-bits of a 64-bit floating point register. Load and store instructions accessing this address for some reason use the whole 64-bit content of floating point register rather than truncated 32-bit value. The following load uses inco

Re: [Qemu-devel] [PATCH 1/6] ARM: add Cortex-M3/M4 exception configuration and status registers

On 7 July 2015 at 19:25, Alex Zuepke wrote: > > Signed-off-by: Alex Zuepke > --- > target-arm/cpu.h | 51 > ++ > target-arm/machine.c |6 ++ > 2 files changed, 57 insertions(+) > > diff --git a/target-arm/cpu.h b/target-arm/cpu.h > i

Re: [Qemu-devel] [PATCH] target-mips: fix logically dead code reported by Coverity

On 2015-07-14 17:22, Leon Alrae wrote: > On 14/07/2015 16:45, Aurelien Jarno wrote: > > By the way, is this debug code really useful? I think by looking at the > > TCG code (-d in_asm,op), it's easy to determine if an instruction is > > correctly disassembled or not. > > > > For me this debug cod

Re: [Qemu-devel] [PATCH] target-mips: fix logically dead code reported by Coverity

On 14/07/2015 16:45, Aurelien Jarno wrote: > By the way, is this debug code really useful? I think by looking at the > TCG code (-d in_asm,op), it's easy to determine if an instruction is > correctly disassembled or not. > For me this debug code doesn't seem to be useful at all and it only clutte

Re: [Qemu-devel] [PATCH 2/2] target-mips: simplify LWL/LDL mask generation

On 14/07/2015 17:45, Aurelien Jarno wrote: > The LWL/LDL instructions mask the GPR with a mask depending on the > address alignement. It is currently computed by doing: > > mask = 0x7fffull >> (t1 ^ 63) > > It's simpler to generate it by doing: > > mask = (1 << t1) - 1 Usi

[Qemu-devel] [PULL 06/11] block: Reorder cleanups in bdrv_close()

Block drivers may still want to access their child nodes in their .bdrv_close handler. If they unref and/or detach a child by themselves, this should not result in a double free. There is additional code for backing files, which are just a special case of child nodes. The same applies for them. S

[Qemu-devel] [PATCH 0/2] target-mips: fix Windows NT support

This patch set fix Windows NT support by correctly emulating the LWL/LWR/LDL/LDR instructions. The first patch is the actual fix and we might want to see it included in 2.4, though the problem is not new to 2.4. The second patch is a small improvement in the generated TCG code, so we probably want

Re: [Qemu-devel] [PATCH] ide: coverity touchups

On 07/14/2015 04:30 AM, Paolo Bonzini wrote: > > > On 13/07/2015 21:41, John Snow wrote: >> s->ports should never exceed 32, but coverity doesn't know that. >> ncq_tfs->sector_count should also never exceed 64K. Personally I tend to mark that kind of thing as a false posi

Re: [Qemu-devel] [PATCH 6/8] disas: sh4: QOMify target specific disas setup

On 2015-07-11 19:00, Peter Crosthwaite wrote: > From: Peter Crosthwaite > > Move the target_disas() sh4 specifics to the QOM disas_set_info hook > and delete the #ifdef specific code in disas.c. > > Cc: Aurelien Jarno > Signed-off-by: Peter Crosthwaite > --- > Testing: > $ ../../qemu/sh4-softm

Re: [Qemu-devel] [PATCH] target-mips: fix logically dead code reported by Coverity

On 2015-07-14 11:08, Leon Alrae wrote: > Make use of CMPOP in floating-point compare instructions. > > Signed-off-by: Leon Alrae > --- > target-mips/translate.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/target-mips/translate.c b/target-mips/translate.c > index 7302857..4a1ffdb

Re: [Qemu-devel] [PATCH] target-mips: correct DERET instruction

On 2015-07-14 11:08, Leon Alrae wrote: > Fix Debug Mode flag clearing, and when DERET is placed between LL and SC > do not make SC fail. > > Signed-off-by: Leon Alrae > --- > target-mips/op_helper.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target-mips/op_helper

[Qemu-devel] [PATCH for-2.4 1/2] target-mips: fix page fault address for LWL/LWR/LDL/LDR

When a LWL, LWR, LDL or LDR instruction triggers a page fault, QEMU currently reports the aligned address in CP0 BadVAddr, while the Windows NT kernel expects the unaligned address. This patch adds a byte access with the unaligned address at the beginning of the LWL/LWR/LDL/LDR instructions to pos

Re: [Qemu-devel] [PATCH] target-mips: fix resource leak reported by Coverity

On 2015-07-14 11:08, Leon Alrae wrote: > UHI assert and link operations call lock_user_string() twice to obtain two > strings pointed by gpr[4] and gpr[5]. If the second lock_user_string() > fails, then the first one won't get freed. Fix this by introducing another > macro responsible for obtaining

[Qemu-devel] [PATCH 2/2] target-mips: simplify LWL/LDL mask generation

The LWL/LDL instructions mask the GPR with a mask depending on the address alignement. It is currently computed by doing: mask = 0x7fffull >> (t1 ^ 63) It's simpler to generate it by doing: mask = (1 << t1) - 1 It uses the same number of TCG instructions, but it avoids a 32/

[Qemu-devel] [PULL 11/11] rbd: fix ceph settings precedence

From: Josh Durgin Apply the ceph settings from a config file before any ceph settings from the command line. Since the ceph config file location may be specified on the command line, parse it once to read the config file, and do a second pass to apply the rest of the command line ceph options. S

[Qemu-devel] [PULL 08/11] rbd: remove unused constants and fields

From: Josh Durgin RBDAIOCB.status was only used for cancel, which was removed in 7691e24dbebb46658e89b3f950fda6ec78bbb823. RBDAIOCB.sector_num was never used. RADOSCB.done and rcbid were never used. RBD_FD* are obsolete since the pipe was removed in e04fb07fd1676e9facd7f3f878c1bbe03bccd26b. S

[Qemu-devel] [PULL 07/11] block: Fix backing file child when modifying graph

This patch moves bdrv_attach_child() from the individual places that add a backing file to a BDS to bdrv_set_backing_hd(), which is called by all of them. It also adds bdrv_detach_child() there. For normal operation (starting with one backing file chain and not changing it until the topmost image

  1   2   3   >