[Qemu-devel] Information

2015-07-22 Thread ty narmz
If you do decide to give tutorials and emulate power pc components to a point where you can just install macintosh via qemu just need documentation on starting scrips like memory options kernel flags how to setup a virtualmachine for use mkdir ~/qemu_vms/ Download/copy Raspbian Wheezy to

[Qemu-devel] [PATCH 06/12] osdep.h: Move some OS header includes and fixups from qemu-common.h

2015-07-22 Thread Peter Maydell
qemu-common.h has some system header includes and fixups for things that might be missing. This is really an OS dependency and belongs in osdep.h, so move it across. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/qemu-common.h | 55

[Qemu-devel] [PATCH 12/12] throttle.h: Don't include qemu-common.h

2015-07-22 Thread Peter Maydell
Replace an include of qemu-common.h with osdep.h and qemu/typedefs.h. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/qemu/throttle.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h index 995b2d5..88dec1d

[Qemu-devel] [PULL for-2.4] qxl: build fix for 2.4

2015-07-22 Thread Marc-André Lureau
Hi This commit fixes the build with 0.12.6 or newer spice server. Gerd being on holiday, I am sending a pull request. Please apply, The following changes since commit a52b2cbf218d52f9e357961acb271a98a2bdff71: qxl: Fix new function name for spice-server library (2015-07-22 16:38:42 +0200)

[Qemu-devel] [PULL for-2.4] qxl: Fix new function name for spice-server library

2015-07-22 Thread Marc-André Lureau
From: Frediano Ziglio fzig...@redhat.com The new spice-server function to limit the number of monitors (0.12.6) changed while development from spice_qxl_set_monitors_config_limit to spice_qxl_max_monitors (accepted upstream). By mistake I post patch with former name. This patch fix the function

Re: [Qemu-devel] [PATCH v2] target-arm: kvm: Differentiate registers based on write-back levels

2015-07-22 Thread Claudio Fontana
On 22.07.2015 16:03, Peter Maydell wrote: On 22 July 2015 at 13:56, Claudio Fontana claudio.font...@huawei.com wrote: I can if you want check if this patch actually fixes the problem without the KVM workaround. Is this the version I am supposed to test, or should I wait for the next

Re: [Qemu-devel] [PATCH] scsi: fix buffer overflow in scsi_req_parse_cdb (CVE-2015-5158)

2015-07-22 Thread Paolo Bonzini
On 22/07/2015 16:27, Daniel P. Berrange wrote: On Wed, Jul 22, 2015 at 04:18:00PM +0200, Paolo Bonzini wrote: This is a guest-triggerable buffer overflow present in QEMU 2.2.0 and newer. scsi_cdb_length returns -1 as an error value, but the caller does not check it. Luckily, the

[Qemu-devel] [PATCH 11/12] event_notifier.h: Don't include qemu-common.h

2015-07-22 Thread Peter Maydell
Don't include qemu-common.h or windows.h in event_notifier.h; instead include osdep.h and typedefs.h, which is all we need. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/qemu/event_notifier.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] RFC/net: Add a net filter

2015-07-22 Thread Yang Hongyang
On 07/22/2015 07:06 PM, Daniel P. Berrange wrote: On Wed, Jul 22, 2015 at 06:55:36PM +0800, Yang Hongyang wrote: This patch add a net filter between network backend and NIC devices. All packets will pass by this filter. TODO: multiqueue support. plugin support.

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Michael S. Tsirkin
On Wed, Jul 22, 2015 at 01:40:25PM +0200, Paolo Bonzini wrote: On 22/07/2015 12:19, Michael S. Tsirkin wrote: SCSI passthrough was no longer supported in virtio 1.0, so this patch fail the get_features() when both 1.0 and scsi is set. And also only advertise VIRTIO_BLK_F_SCSI for

Re: [Qemu-devel] net: Next steps to deprecate -net

2015-07-22 Thread Michael S. Tsirkin
On Wed, Jul 22, 2015 at 03:40:55PM +0200, Markus Armbruster wrote: Copying Andreas just in case. Thomas Huth th...@redhat.com writes: On 07/17/2015 09:25 AM, Peter Maydell wrote: On 17 July 2015 at 07:53, Thomas Huth th...@redhat.com wrote: Ok, assuming that my Network traffic dumping

Re: [Qemu-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-22 Thread Jan Beulich
On 22.07.15 at 16:50, stefano.stabell...@eu.citrix.com wrote: On Wed, 22 Jul 2015, Jan Beulich wrote: --- a/xen-hvm.c +++ b/xen-hvm.c @@ -981,19 +981,30 @@ static void handle_ioreq(XenIOState *sta static int handle_buffered_iopage(XenIOState *state) { +buffered_iopage_t

[Qemu-devel] error building latest QEMU

2015-07-22 Thread Claudio Fontana
Hello, with the following configuration: ./configure --enable-fdt --disable-sdl --disable-vnc --enable-debug --disable-gtk --enable-kvm --target-list=aarch64-softmmu I get: vl.c:2064:12: error: unused variable `err' [-Werror=unused-variable] Error *err = NULL; ^ make: ***

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Michael S. Tsirkin
On Wed, Jul 22, 2015 at 06:11:16PM +0200, Cornelia Huck wrote: On Wed, 22 Jul 2015 17:53:47 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 22, 2015 at 12:55:22PM +0200, Cornelia Huck wrote: On Wed, 22 Jul 2015 13:44:14 +0300 Michael S. Tsirkin m...@redhat.com wrote:

[Qemu-devel] [PATCH 04/12] compiler.h: Use glue() in QEMU_BUILD_BUG_ON define

2015-07-22 Thread Peter Maydell
Rather than rolling custom concatenate-strings macros for the QEMU_BUILD_BUG_ON macro to use, use the glue() macro we already have (since it's now available to us in this header). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/qemu/compiler.h | 4 +--- 1 file changed, 1

[Qemu-devel] [PATCH 10/12] timer.h: Don't include qemu-common.h

2015-07-22 Thread Peter Maydell
Include the specific headers we need, rather than qemu-common.h. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/qemu/timer.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/qemu/timer.h b/include/qemu/timer.h index 9939246..6205024 100644 ---

Re: [Qemu-devel] [PATCH] RFC/net: Add a net filter

2015-07-22 Thread Yang Hongyang
On 07/22/2015 09:05 PM, Thomas Huth wrote: On 22/07/15 12:55, Yang Hongyang wrote: This patch add a net filter between network backend and NIC devices. All packets will pass by this filter. TODO: multiqueue support. plugin support. +--+ +-+

Re: [Qemu-devel] [PATCH V2 1/5] virtio: get_features() can fail

2015-07-22 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 15/07/2015 11:01, Cornelia Huck wrote: diff --git a/hw/virtio/virtio-bus.c b/hw/virtio/virtio-bus.c index 3926f7e..febda76 100644 --- a/hw/virtio/virtio-bus.c +++ b/hw/virtio/virtio-bus.c @@ -54,7 +54,8 @@ void

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Cornelia Huck
On Wed, 22 Jul 2015 17:53:47 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 22, 2015 at 12:55:22PM +0200, Cornelia Huck wrote: On Wed, 22 Jul 2015 13:44:14 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 22, 2015 at 12:38:40PM +0200, Cornelia Huck wrote: On

[Qemu-devel] [Bug 1353149] Re: qemu 2.1.0 fails to start if number of cores is greater than 1.

2015-07-22 Thread Andrey Korolyov
** Changed in: qemu Status: New = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1353149 Title: qemu 2.1.0 fails to start if number of cores is greater than 1. Status in QEMU:

Re: [Qemu-devel] [PATCH v2] PAM: make PAM emulation closer to documentation

2015-07-22 Thread Kevin O'Connor
On Mon, Jul 20, 2015 at 01:53:13PM +0300, Efimov Vasily wrote: This patch improves PAM emulation. PAM defines 4 memory access redirection modes. In mode 1 reads are directed to RAM and writes are directed to PCI. In mode 2 it is contrary. In mode 0 all access is directed to PCI. In mode 3 it

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Paolo Bonzini
On 22/07/2015 18:15, Michael S. Tsirkin wrote: No, the feature is not desirable in the future. There is no reason really not to use virtio-scsi passthrough instead, since virtio-scsi has been out for about 3 years now and is stable. Given the amount of work we are spending handling this

[Qemu-devel] [PATCH 01/12] qapi/qmp-event.c: Don't manually include os-win32.h/os-posix.h

2015-07-22 Thread Peter Maydell
qmp-event.c already includes qemu-common.h, so manually including os-win32.h/os-posix.h is unnecessary (and potentially fragile, since it's duplicating the #ifdef logic that chooses which of the two we need). Remove the unnecessary include logic. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 09/12] apic_internal.h: Include cpu.h directly

2015-07-22 Thread Peter Maydell
apic_internal.h relies on cpu.h having been included (for the X86CPU type); include it directly rather than relying on it being pulled in via one of the other includes like timer.h. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/hw/i386/apic_internal.h | 1 + 1 file changed, 1

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] block: vpc - prevent overflow if max_table_entries = 0x40000000

2015-07-22 Thread Max Reitz
On 22.07.2015 19:26, Jeff Cody wrote: On Wed, Jul 22, 2015 at 07:02:02PM +0200, Max Reitz wrote: On 21.07.2015 18:13, Jeff Cody wrote: When we allocate the pagetable based on max_table_entries, we multiply the max table entry value by 4 to accomodate a table of 32-bit integers. However,

Re: [Qemu-devel] [PATCH RFC v2 26/47] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-07-22 Thread Eric Blake
On 07/01/2015 02:22 PM, Markus Armbruster wrote: Fixes flat unions to get the base's base members. Test case is from commit 2fc0043, in qapi-schema-test.json: Flat union visitors remain broken. They'll be fixed next. Sadly, the generated files had a huge diffstat, making it very hard to

[Qemu-devel] [PATCH 08/12] qemu-common.h: Move muldiv64() to host-utils.h

2015-07-22 Thread Peter Maydell
Move the muldiv64() function from qemu-common.h to host-utils.h. This puts it together with all the other arithmetic functions where we provide a version with __int128_t and a fallback without, and allows headers which need muldiv64() to avoid including qemu-common.h. We don't include host-utils

Re: [Qemu-devel] User space vs kernel space instructions distribution.

2015-07-22 Thread Christopher Covington
On 07/14/2015 04:45 AM, Peter Maydell wrote: On 14 July 2015 at 09:32, Shlomo Pongratz shlomopongr...@gmail.com wrote: Hi, I'm running aarm64 QEMU and I'm counting the number of instructions which belong to user space vs kernel space. My measurements shows that 99 percent of instructions are

Re: [Qemu-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-22 Thread Stefano Stabellini
On Wed, 22 Jul 2015, Stefano Stabellini wrote: On Wed, 22 Jul 2015, Jan Beulich wrote: On 22.07.15 at 16:50, stefano.stabell...@eu.citrix.com wrote: On Wed, 22 Jul 2015, Jan Beulich wrote: --- a/xen-hvm.c +++ b/xen-hvm.c @@ -981,19 +981,30 @@ static void handle_ioreq(XenIOState

[Qemu-devel] [PULL 1/1] hostmem: Fix qemu_opt_get_bool() crash in host_memory_backend_init()

2015-07-22 Thread Eduardo Habkost
This fixes the following crash, introduced by commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6: $ gdb --args qemu-system-x86_64 -machine pc,mem-merge=off -object memory-backend-ram,id=ram-node0,size=1024 [...] Program received signal SIGABRT, Aborted. (gdb) bt #0 0x7253b8c7 in

Re: [Qemu-devel] -cpu host, enforce fail on amd processor (CPUID.80000001H:EDX)

2015-07-22 Thread Eduardo Habkost
On Wed, Jul 08, 2015 at 11:05:30AM +0200, Alexandre DERUMIER wrote: Hi, I'm currently testing -cpu host,enforce, and it's failing to start on amd processors (tested with opteron 61XX,opteron 63xx,FX-6300 and FX-9590) Is it expected ? It is not, and it should never happen (as the bits

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] block: vpc - prevent overflow if max_table_entries = 0x40000000

2015-07-22 Thread Jeff Cody
On Wed, Jul 22, 2015 at 07:29:47PM +0200, Max Reitz wrote: On 22.07.2015 19:26, Jeff Cody wrote: On Wed, Jul 22, 2015 at 07:02:02PM +0200, Max Reitz wrote: On 21.07.2015 18:13, Jeff Cody wrote: When we allocate the pagetable based on max_table_entries, we multiply the max table entry value by

Re: [Qemu-devel] User space vs kernel space instructions distribution.

2015-07-22 Thread Peter Maydell
On 22 July 2015 at 17:45, Christopher Covington c...@codeaurora.org wrote: On 07/14/2015 04:45 AM, Peter Maydell wrote: If your measurement instrumentation is intrusive and is significantly slowing down QEMU then you'll naturally find that the guest spends more time in timer interrupt

Re: [Qemu-devel] [PATCH] xen/HVM: atomically access pointers in bufioreq handling

2015-07-22 Thread Stefano Stabellini
On Wed, 22 Jul 2015, Jan Beulich wrote: On 22.07.15 at 16:50, stefano.stabell...@eu.citrix.com wrote: On Wed, 22 Jul 2015, Jan Beulich wrote: --- a/xen-hvm.c +++ b/xen-hvm.c @@ -981,19 +981,30 @@ static void handle_ioreq(XenIOState *sta static int

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] block: vpc - prevent overflow if max_table_entries = 0x40000000

2015-07-22 Thread Jeff Cody
On Wed, Jul 22, 2015 at 07:02:02PM +0200, Max Reitz wrote: On 21.07.2015 18:13, Jeff Cody wrote: When we allocate the pagetable based on max_table_entries, we multiply the max table entry value by 4 to accomodate a table of 32-bit integers. However, max_table_entries is a uint32_t, and the VPC

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] block: vpc - prevent overflow if max_table_entries = 0x40000000

2015-07-22 Thread Max Reitz
On 22.07.2015 19:40, Jeff Cody wrote: On Wed, Jul 22, 2015 at 07:29:47PM +0200, Max Reitz wrote: On 22.07.2015 19:26, Jeff Cody wrote: On Wed, Jul 22, 2015 at 07:02:02PM +0200, Max Reitz wrote: On 21.07.2015 18:13, Jeff Cody wrote: When we allocate the pagetable based on max_table_entries,

[Qemu-devel] [PULL 0/1] NUMA queue, 2015-07-22

2015-07-22 Thread Eduardo Habkost
The following changes since commit b69b30532e0a80e25449244c01b0cbed000c99a3: Update version for v2.4.0-rc2 release (2015-07-22 18:17:19 +0100) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/numa-pull-request for you to fetch changes up to

[Qemu-devel] [PATCH 03/12] osdep.h: Move some compiler-specific things to compiler.h

2015-07-22 Thread Peter Maydell
osdep.h has a few things which are really compiler specific; move them to compiler.h, and include compiler.h from osdep.h. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/qemu/compiler.h | 47 +++ include/qemu/osdep.h| 48

[Qemu-devel] [PATCH 07/12] osdep.h: Add header comment

2015-07-22 Thread Peter Maydell
Add a header comment to osdep.h, explaining what the header is for and some rules to avoid circular-include difficulties. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/qemu/osdep.h | 24 1 file changed, 24 insertions(+) diff --git

[Qemu-devel] [PATCH 02/12] osdep.h: Remove qemu_printf

2015-07-22 Thread Peter Maydell
qemu_printf is an ancient remnant which has been a simple #define to printf for over a decade, and is used in only a few places. Expand it out in those places and remove the #define. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/qemu/osdep.h | 2 -- monitor.c| 4

Re: [Qemu-devel] [PULL for-2.4] qxl: build fix for 2.4

2015-07-22 Thread Peter Maydell
On 22 July 2015 at 16:01, Marc-André Lureau marcandre.lur...@redhat.com wrote: Hi This commit fixes the build with 0.12.6 or newer spice server. Gerd being on holiday, I am sending a pull request. Please apply, The following changes since commit a52b2cbf218d52f9e357961acb271a98a2bdff71:

Re: [Qemu-devel] error building latest QEMU

2015-07-22 Thread Stefan Weil
Am 22.07.2015 um 18:01 schrieb Claudio Fontana: Hello, with the following configuration: ./configure --enable-fdt --disable-sdl --disable-vnc --enable-debug --disable-gtk --enable-kvm --target-list=aarch64-softmmu I get: vl.c:2064:12: error: unused variable `err' [-Werror=unused-variable]

[Qemu-devel] [PATCH 05/12] qemu-common.h: Move Win32 fixups into os-win32.h

2015-07-22 Thread Peter Maydell
qemu-common.h includes some fixups for things the Win32 headers don't define or define weirdly. These really belong in os-win32.h, so move them there. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- include/qemu-common.h | 17 - include/sysemu/os-win32.h | 18

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] block: vpc - prevent overflow if max_table_entries = 0x40000000

2015-07-22 Thread Max Reitz
On 21.07.2015 18:13, Jeff Cody wrote: When we allocate the pagetable based on max_table_entries, we multiply the max table entry value by 4 to accomodate a table of 32-bit integers. However, max_table_entries is a uint32_t, and the VPC driver accepts ranges for that entry over 0x4000. So

Re: [Qemu-devel] [RFC 2/7] fw_cfg dma interface

2015-07-22 Thread Kevin O'Connor
On Wed, Jul 22, 2015 at 10:31:12AM +0200, Marc Marí wrote: On Wed, 22 Jul 2015 00:24:34 -0400 Kevin O'Connor ke...@koconnor.net wrote: On Tue, Jul 21, 2015 at 06:03:41PM +0200, Marc Marí wrote: From: Gerd Hoffmann kra...@redhat.com First draft of a fw_cfg dma interface. Designed as

[Qemu-devel] [PATCH for-2.4] vl: Fix compiler warning for builds without VLC

2015-07-22 Thread Stefan Weil
This regression was caused by commit 70b94331. CCvl.o vl.c: In function ‘select_display’: vl.c:2064:12: error: unused variable ‘err’ [-Werror=unused-variable] Error *err = NULL; ^ Signed-off-by: Stefan Weil s...@weilnetz.de --- vl.c | 2 +- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH 3/4] vhost-user: add protocol feature negotiation

2015-07-22 Thread Marc-André Lureau
Hi On Fri, Jul 17, 2015 at 4:09 PM, Michael S. Tsirkin m...@redhat.com wrote: +#define VHOST_USER_F_PROTOCOL_FEATURES 30 +#define VHOST_USER_PROTOCOL_FEATURE_MASK 0x0ULL Since this flag is among the VHOST_GET_FEATURES, shouldn't it be part of linux-headers/linux/vhost.h ? (next to

Re: [Qemu-devel] [PATCH 00/12] qemu-common.h/osdep.h refactoring

2015-07-22 Thread Paolo Bonzini
On 22/07/2015 18:43, Peter Maydell wrote: The real question here I guess is whether people like the direction I'm trying to go with this. If so, we can further reduce the number of qemu-common.h includes without too much difficulty with further patches. I like it, and it nicely complements

[Qemu-devel] [Bug 1476800] [NEW] Instant runtime error (Host: Windows 8.1 VM: WinXP ISO)

2015-07-22 Thread Leo Nesfield
Public bug reported: I have Qemu Manager on my Windows 8.1 laptop and have a WXP iso and a blank disk image (from here http://www.mediafire.com/download/rtec86bwwmee00s/Blank_Disk.zip ) and as soon as I try to open it I get a Runtime Error ( http://i.gyazo.com/bfebf7e1e7a670f8e52cc95c5923a67e.png

[Qemu-devel] qemu-system-aarch64 error while booting kernel

2015-07-22 Thread Naman Govil
Hi, I am trying to boot off a kernel image on aarch64. I have the compiled image which I am running by using the command $qemu-system-aarch64 -machine type=virt -m 2048M-nographic -kernel ~/coreboot/build/coreboot.rom For debugging purposes, I tried to get qemu monitor working first. I was able

Re: [Qemu-devel] [PATCH RFC v2 26/47] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

2015-07-22 Thread Eric Blake
On 07/22/2015 11:34 AM, Eric Blake wrote: -typedef struct int32List { +typedef struct boolList boolList; + +struct boolList { I can understand the minor change in #ifdef name, and even the separation between typedef and struct declaration (even though the old approach of doing it all

[Qemu-devel] [PATCH 00/12] qemu-common.h/osdep.h refactoring

2015-07-22 Thread Peter Maydell
This series makes a start at cleaning up some of our headers to avoid the common problem of header files including qemu-common.h (which then in turn can lead to awkward circular includes). One common cause of this is that we don't have any header which will include the basic things most header

Re: [Qemu-devel] net: Next steps to deprecate -net

2015-07-22 Thread Thomas Huth
On 22/07/15 18:20, Michael S. Tsirkin wrote: On Wed, Jul 22, 2015 at 03:40:55PM +0200, Markus Armbruster wrote: ... Deprecating -net except for -net nic sounds like a fine step forward to me. -net dump is also useful, we'll need some solution for that if we want to deprecate vlans. *cough*

Re: [Qemu-devel] [PULL for-2.4 0/7] update ipxe roms, fix efi support

2015-07-22 Thread Laszlo Ersek
On 07/22/15 13:42, Stefan Hajnoczi wrote: On Wed, Jul 22, 2015 at 11:05 AM, Laszlo Ersek ler...@redhat.com wrote: On 07/22/15 11:05, Stefan Hajnoczi wrote: On Wed, Jul 22, 2015 at 12:58:59AM +0200, Laszlo Ersek wrote: On 07/21/15 18:10, Stefan Hajnoczi wrote: On Tue, Jul 21, 2015 at 3:28 PM,

Re: [Qemu-devel] [PULL for-2.4 0/7] update ipxe roms, fix efi support

2015-07-22 Thread Laszlo Ersek
On 07/22/15 22:06, Michael Brown wrote: On 21/07/15 23:58, Laszlo Ersek wrote: Instead of propagating that fix into QEMU, let's focus on ipxe upstream to solve the problem. How's this for focus: (1) [PATCH] efi_snp: improve compliance with the EFI_SIMPLE_NETWORK_PROTOCOL spec

[Qemu-devel] qemi-system-aarch64 error while booting kernel

2015-07-22 Thread Naman Govil
*Hi,* *I am trying to boot off a kernel image on *aarch64. I have the compiled image which I am running by using the command *$qemu-system-aarch64 -machine type=virt -m 2048M-nographic -kernel ~/coreboot/build/coreboot.rom* *For debugging purposes, I tried to get qemu monitor working

Re: [Qemu-devel] [PULL for-2.4 0/7] update ipxe roms, fix efi support

2015-07-22 Thread Michael Brown
On 21/07/15 23:58, Laszlo Ersek wrote: Instead of propagating that fix into QEMU, let's focus on ipxe upstream to solve the problem. How's this for focus: (1) [PATCH] efi_snp: improve compliance with the EFI_SIMPLE_NETWORK_PROTOCOL spec

Re: [Qemu-devel] [RFC] Virt machine memory map

2015-07-22 Thread Alexander Graf
Am 22.07.2015 um 08:52 schrieb Pavel Fedin p.fe...@samsung.com: Hello! I think the theory we discussed at the time of putting in the PCIe device was that if we wanted this we'd add support for the other PCIe memory window (which would then live at somewhere above 4GB). Alex, can you

Re: [Qemu-devel] [RFC 2/7] fw_cfg dma interface

2015-07-22 Thread Marc Marí
On Wed, 22 Jul 2015 00:24:34 -0400 Kevin O'Connor ke...@koconnor.net wrote: On Tue, Jul 21, 2015 at 06:03:41PM +0200, Marc Marí wrote: From: Gerd Hoffmann kra...@redhat.com First draft of a fw_cfg dma interface. Designed as add-on to the extisting fw_cfg interface, i.e. there is no

[Qemu-devel] [PATCH v6 6/6] Add gicversion option to virt machine

2015-07-22 Thread Pavel Fedin
Set kernel_irqchip_type according to value of the option and pass it around where necessary. Instantiate devices and fdt nodes according to the choice. mac_cpus for virt machine increased to 64. GICv2 compatibility check happens inside arm_gic_common_realize(). Signed-off-by: Pavel Fedin

[Qemu-devel] [PATCH v6 2/6] Implement GIC-500 base class

2015-07-22 Thread Pavel Fedin
From: Shlomo Pongratz shlomo.pongr...@huawei.com This class is to be used by both software and KVM implementations of GICv3 Signed-off-by: Shlomo Pongratz shlomo.pongr...@huawei.com Signed-off-by: Pavel Fedin p.fe...@samsung.com --- hw/intc/Makefile.objs | 1 +

[Qemu-devel] [PATCH v6 5/6] Initial implementation of vGICv3

2015-07-22 Thread Pavel Fedin
Get/put routines are missing, live migration is not possible. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- hw/intc/Makefile.objs | 3 + hw/intc/arm_gicv3_kvm.c | 155 2 files changed, 158 insertions(+) create mode 100644

[Qemu-devel] [PATCH v6 0/6] vGICv3 support

2015-07-22 Thread Pavel Fedin
This series introduces support for GICv3 by KVM. Software emulation is currently not supported. Differences from v5: - Fixed various checkpatch.pl style warnings - Removed TODO in gicv3_init_irqs_and_mmio(), relevant memory API patch included - gicv3_init_irqs_and_mmio() now takes 3 arguments

[Qemu-devel] [PATCH v6 4/6] Introduce irqchip type specification for KVM

2015-07-22 Thread Pavel Fedin
This patch introduces kernel_irqchip_type member in Machine class, which it passed to kvm_arch_irqchip_create. It allows machine models to specify correct GIC type during KVM capability verification. The variable is defined as int in order to be architecture-agnostic for potential future uses by

[Qemu-devel] [PATCH v6 1/6] Merge memory_region_init_reservation() into memory_region_init_io()

2015-07-22 Thread Pavel Fedin
Just speficying ops = NULL in some cases can be more convenient than having two functions. GICv3 code is going to use this. GICv2 code can be refactored in a similar way, killing some code duplication. Signed-off-by: Pavel Fedin p.fe...@samsung.com Acked-by: Paolo Bonzini pbonz...@redhat.com ---

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Cornelia Huck
On Wed, 22 Jul 2015 13:59:51 +0800 Jason Wang jasow...@redhat.com wrote: SCSI passthrough was no longer supported in virtio 1.0, so this patch fail the get_features() when both 1.0 and scsi is set. And also only advertise VIRTIO_BLK_F_SCSI for legacy virtio-blk device. Signed-off-by: Jason

Re: [Qemu-devel] [RFC 2/7] fw_cfg dma interface

2015-07-22 Thread Marc Marí
On Tue, 21 Jul 2015 21:44:49 +0200 Laszlo Ersek ler...@redhat.com wrote: On 07/21/15 18:03, Marc Marí wrote: From: Gerd Hoffmann kra...@redhat.com First draft of a fw_cfg dma interface. Designed as add-on to the extisting fw_cfg interface, i.e. there is no select register. There are

Re: [Qemu-devel] [RFC] Virt machine memory map

2015-07-22 Thread Pavel Fedin
Hello! At least on Seattle we do have several regions with that driver and I don't expect real hardware to provide a model as simple as ours. So yes, I would be very surprised if there were limitations about the split of regions. Thank you for pointing out, i will check. Kind regards,

[Qemu-devel] [PATCH for-2.4] vnc: fix memory leak

2015-07-22 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com If vnc's password is configured, it will leak memory which cipher variable pointed on every vnc connection. Cc: Daniel P. Berrange berra...@redhat.com Signed-off-by: Gonglei arei.gong...@huawei.com --- ui/vnc.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [Qemu-devel] [RFC] Virt machine memory map

2015-07-22 Thread Pavel Fedin
Hello! I think the theory we discussed at the time of putting in the PCIe device was that if we wanted this we'd add support for the other PCIe memory window (which would then live at somewhere above 4GB). Alex, can you remember what the idea was? Yes, pretty much. It would give us an

[Qemu-devel] [PATCH v6 3/6] Extract some reusable vGIC code

2015-07-22 Thread Pavel Fedin
These functions are useful also for vGICv3 implementation. Make them accessible from within other modules. Actually kvm_dist_get() and kvm_dist_put() could also be made reusable, but they would require two extra parameters (s-dev_fd and s-num_cpu) as well as lots of typecasts of 's' to

Re: [Qemu-devel] [RFC 5/7] fw_cfg file sort

2015-07-22 Thread Marc Marí
On Tue, 21 Jul 2015 21:53:06 +0200 Laszlo Ersek ler...@redhat.com wrote: On 07/21/15 18:18, Stefan Hajnoczi wrote: On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí mar...@redhat.com wrote: From: Gerd Hoffmann kra...@redhat.com This is what it takes to have a sorted fw_cfg file directory.

Re: [Qemu-devel] [RFC 7/7] fw_cfg DMA for x86

2015-07-22 Thread Marc Marí
On Tue, 21 Jul 2015 18:14:40 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 21 July 2015 at 17:03, Marc Marí mar...@redhat.com wrote: Enable fw_cfg for x86 machines. Create new machine to avoid incompatibilites. @@ -1391,7 +1399,14 @@ FWCfgState *pc_memory_init(MachineState

Re: [Qemu-devel] [PULL for-2.4 0/7] update ipxe roms, fix efi support

2015-07-22 Thread Stefan Hajnoczi
On Wed, Jul 22, 2015 at 12:58:59AM +0200, Laszlo Ersek wrote: On 07/21/15 18:10, Stefan Hajnoczi wrote: On Tue, Jul 21, 2015 at 3:28 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 21/07/2015 16:25, Peter Maydell wrote: or work with others to add upstream maintainers. When we can't get

Re: [Qemu-devel] [PATCH v7 26/42] postcopy: Incoming initialisation

2015-07-22 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:39], Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com Reviewed-by: David Gibson da...@gibson.dropbear.id.au Reviewed-by: Amit Shah amit.s...@redhat.com

[Qemu-devel] [PATCH V3 1/3] virtio: get_features() can fail

2015-07-22 Thread Jason Wang
Signed-off-by: Jason Wang jasow...@redhat.com --- hw/9pfs/virtio-9p-device.c | 3 ++- hw/block/virtio-blk.c | 3 ++- hw/char/virtio-serial-bus.c | 3 ++- hw/display/virtio-gpu.c | 3 ++- hw/input/virtio-input.c | 3 ++- hw/net/virtio-net.c | 3 ++- hw/scsi/vhost-scsi.c

[Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Jason Wang
SCSI passthrough was no longer supported in virtio 1.0, so this patch fail the get_features() when both 1.0 and scsi is set. And also only advertise VIRTIO_BLK_F_SCSI for legacy virtio-blk device. Signed-off-by: Jason Wang jasow...@redhat.com --- hw/block/virtio-blk.c | 9 - 1 file

[Qemu-devel] [PATCH V3 3/3] virtio-blk: set VIRTIO_F_ANY_LAYOUT when 1.0 is supported

2015-07-22 Thread Jason Wang
Chapter 6.3 of spec said Transitional devices MUST offer, and if offered by the device transitional drivers MUST accept the following: VIRTIO_F_ANY_LAYOUT (27) So this patch sets VIRTIO_F_ANY_LAYOUT when 1.0 is supported. Cc: Stefan Hajnoczi stefa...@redhat.com Cc: Kevin Wolf

[Qemu-devel] [PATCH V3 0/3] Set correct blk feature for virtio 1.0

2015-07-22 Thread Jason Wang
Hi all: This series tries to set feature correctly for virtio-blk when virtio 1.0 is supported. Two isssues were addressed according to the spec: - scsi passthrough was not support in 1.0. This is done through: 1) let get_features() can fail 2) fail the get_features() when both scsi and

Re: [Qemu-devel] [PATCH v2] cpu-exec: Do not invalidate original TB in cpu_exec_nocache()

2015-07-22 Thread Sergey Fedorov
ping. On 30.06.2015 12:35, Sergey Fedorov wrote: Instead of invalidating an original TB in cpu_exec_nocache() prematurely, just save a link to it in the temporary generated TB. If cpu_io_recompile() is raised subsequently from the temporary TB, invalidate the original one as well. That allows

Re: [Qemu-devel] [PULL for-2.4 0/1] qemu-ga: small documentation versioning fix-up

2015-07-22 Thread Peter Maydell
On 21 July 2015 at 20:51, Michael Roth mdr...@linux.vnet.ibm.com wrote: The following changes since commit 774ee4772b6838b78741ea52d4bf26b8922244c5: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150721' into staging (2015-07-21 12:21:08 +0100) are available in

[Qemu-devel] [PATCH RFC] virtio: set any_layout in virtio core

2015-07-22 Thread Michael S. Tsirkin
Virtio 1 requires this, and all devices are clean by now, so let's do it! Exceptions: - virtio-blk - compat machine types Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Untested - consider this pseudo-code - it just seems easier to write it in C than try to explain it.

Re: [Qemu-devel] [RFC 2/7] fw_cfg dma interface

2015-07-22 Thread Laszlo Ersek
On 07/22/15 10:19, Marc Marí wrote: On Tue, 21 Jul 2015 21:44:49 +0200 Laszlo Ersek ler...@redhat.com wrote: On 07/21/15 18:03, Marc Marí wrote: From: Gerd Hoffmann kra...@redhat.com First draft of a fw_cfg dma interface. Designed as add-on to the extisting fw_cfg interface, i.e. there

[Qemu-devel] [PATCH] virtio: hide legacy features from modern guests

2015-07-22 Thread Michael S. Tsirkin
NOTIFY_ON_EMPTY, ANY_LAYOUT and BAD are only valid on the legacy interface. Hide them from modern guests. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/virtio/virtio.h | 4 hw/virtio/virtio-pci.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH for-2.5] ppc/spapr: Use qemu_log_mask() for hcall_dprintf()

2015-07-22 Thread Thomas Huth
To see the output of the hcall_dprintf statements, you currently have to enable the DEBUG_SPAPR_HCALLS macro in include/hw/ppc/spapr.h. This is ugly because a) not every user who wants to debug guest problems can or wants to recompile QEMU to be able to see such issues, and b) since this macro is

Re: [Qemu-devel] [PATCH v4 0/6] AioContext: ctx-dispatching is dead, all hail ctx-notify_me

2015-07-22 Thread Stefan Hajnoczi
On Tue, Jul 21, 2015 at 04:07:47PM +0200, Paolo Bonzini wrote: This puts together all pending fixes in a single series. Paolo v1-v2 Split some changes to the tests to a separate patch Fix commit message [Laszlo] Clarify do...while loop in aio-win32.c [Kevin]

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Jason Wang
On 07/22/2015 05:31 PM, Daniel P. Berrange wrote: On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: SCSI passthrough was no longer supported in virtio 1.0, so this patch fail the get_features() when both 1.0 and scsi is set. And also only advertise VIRTIO_BLK_F_SCSI for legacy

Re: [Qemu-devel] [PULL for-2.4 0/7] update ipxe roms, fix efi support

2015-07-22 Thread Laszlo Ersek
On 07/22/15 11:05, Stefan Hajnoczi wrote: On Wed, Jul 22, 2015 at 12:58:59AM +0200, Laszlo Ersek wrote: On 07/21/15 18:10, Stefan Hajnoczi wrote: On Tue, Jul 21, 2015 at 3:28 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 21/07/2015 16:25, Peter Maydell wrote: or work with others to add

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Michael S. Tsirkin
On Wed, Jul 22, 2015 at 12:25:31PM +0200, Cornelia Huck wrote: On Wed, 22 Jul 2015 12:21:32 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 22, 2015 at 10:58:43AM +0200, Cornelia Huck wrote: On Wed, 22 Jul 2015 13:59:51 +0800 Jason Wang jasow...@redhat.com wrote:

Re: [Qemu-devel] [RFC 2/7] fw_cfg dma interface

2015-07-22 Thread Andrew Jones
On Tue, Jul 21, 2015 at 09:44:49PM +0200, Laszlo Ersek wrote: On 07/21/15 18:03, Marc Marí wrote: +static void fw_cfg_dma_transfer(FWCfgState *s) +{ +dma_addr_t len; +uint8_t *ptr; +uint32_t i; + +if (s-dma_ctl FW_CFG_DMA_CTL_ERROR) { +return; +} +

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Jason Wang
On 07/22/2015 04:58 PM, Cornelia Huck wrote: On Wed, 22 Jul 2015 13:59:51 +0800 Jason Wang jasow...@redhat.com wrote: SCSI passthrough was no longer supported in virtio 1.0, so this patch fail the get_features() when both 1.0 and scsi is set. And also only advertise VIRTIO_BLK_F_SCSI for

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Michael S. Tsirkin
On Wed, Jul 22, 2015 at 05:52:29PM +0800, Jason Wang wrote: On 07/22/2015 05:25 PM, Michael S. Tsirkin wrote: On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: SCSI passthrough was no longer supported in virtio 1.0, so this patch fail the get_features() when both 1.0 and scsi

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Michael S. Tsirkin
On Wed, Jul 22, 2015 at 01:12:45PM +0300, Michael S. Tsirkin wrote: On Wed, Jul 22, 2015 at 05:52:29PM +0800, Jason Wang wrote: On 07/22/2015 05:25 PM, Michael S. Tsirkin wrote: On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: SCSI passthrough was no longer supported in

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Cornelia Huck
On Wed, 22 Jul 2015 17:35:07 +0800 Jason Wang jasow...@redhat.com wrote: On 07/22/2015 04:58 PM, Cornelia Huck wrote: On Wed, 22 Jul 2015 13:59:51 +0800 Jason Wang jasow...@redhat.com wrote: SCSI passthrough was no longer supported in virtio 1.0, so this patch fail the

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Michael S. Tsirkin
On Wed, Jul 22, 2015 at 12:38:40PM +0200, Cornelia Huck wrote: On Wed, 22 Jul 2015 13:32:17 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 22, 2015 at 12:25:31PM +0200, Cornelia Huck wrote: On Wed, 22 Jul 2015 12:21:32 +0300 Michael S. Tsirkin m...@redhat.com wrote:

Re: [Qemu-devel] [PATCH for-2.4] vnc: fix memory leak

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 05:08:53PM +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com If vnc's password is configured, it will leak memory which cipher variable pointed on every vnc connection. Cc: Daniel P. Berrange berra...@redhat.com Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Michael S. Tsirkin
On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: SCSI passthrough was no longer supported in virtio 1.0, so this patch fail the get_features() when both 1.0 and scsi is set. And also only advertise VIRTIO_BLK_F_SCSI for legacy virtio-blk device. Signed-off-by: Jason Wang

Re: [Qemu-devel] [RFC 2/7] fw_cfg dma interface

2015-07-22 Thread Stefan Hajnoczi
On Wed, Jul 22, 2015 at 12:24:34AM -0400, Kevin O'Connor wrote: On Tue, Jul 21, 2015 at 06:03:41PM +0200, Marc Marí wrote: From: Gerd Hoffmann kra...@redhat.com First draft of a fw_cfg dma interface. Designed as add-on to the extisting fw_cfg interface, i.e. there is no select register.

Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: SCSI passthrough was no longer supported in virtio 1.0, so this patch fail the get_features() when both 1.0 and scsi is set. And also only advertise VIRTIO_BLK_F_SCSI for legacy virtio-blk device. Why is SCSI passthrough support not

Re: [Qemu-devel] [PATCH v4 0/6] AioContext: ctx-dispatching is dead, all hail ctx-notify_me

2015-07-22 Thread Richard W.M. Jones
On Tue, Jul 21, 2015 at 04:07:47PM +0200, Paolo Bonzini wrote: This puts together all pending fixes in a single series. Paolo v1-v2 Split some changes to the tests to a separate patch Fix commit message [Laszlo] Clarify do...while loop in aio-win32.c [Kevin]

  1   2   3   >