Re: [Qemu-devel] [PATCH v7 5/6] Initial implementation of vGICv3

2015-08-03 Thread Pavel Fedin
Hello! obj-$(CONFIG_APIC) += apic.o apic_common.o obj-$(CONFIG_ARM_GIC_KVM) += arm_gic_kvm.o +ifeq ($(ARCH), aarch64) # Only 64-bit KVM can use these +obj-$(CONFIG_ARM_GIC_KVM) += arm_gicv3_kvm.o Does it actually fail to compile in a 32-bit KVM config? I forgot to reply to this.

Re: [Qemu-devel] [PATCH v2] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on reinstall

2015-08-03 Thread Marc-André Lureau
Hi On Mon, Aug 3, 2015 at 4:33 PM, Leonid Bloch leo...@daynix.com wrote: I think the root of the problem is that the wxs doesn't follow the component rules: qemu_ga shouldn't contain various libs and executable. Instead, each file should have its own component. Then I think

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Laurent Vivier
On 03/08/2015 17:18, Paolo Bonzini wrote: On 03/08/2015 17:13, Laurent Vivier wrote: it says 33 MHz clock (30 ns clock ticks) which is contradictory. I found that the spec allows for any speed up to Hz (30 ns cycle), so both are okay. However, at least hw/net/rtl8139.c assumes

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-03 Thread Karel Gardas
On Mon, Aug 3, 2015 at 4:51 PM, Dennis Luehring dl.so...@gmx.net wrote: ok - NetBSD 6.5.1 SPARC64 is blasting fast compare to Debian 7.8.0 SPARC64 - i installed the complete system (without X) in a few minutes Debian needs 1h I had the same experience with OpenBSD for sparc64, also fast to

Re: [Qemu-devel] [PATCH for-2.4] configure: Drop vnc-ws feature from help text

2015-08-03 Thread Peter Maydell
On 24 July 2015 at 15:47, Andreas Färber afaer...@suse.de wrote: Commit 8e9b0d2 (ui: convert VNC websockets to use crypto APIs) dropped the --enable-vnc-ws option but forgot to update the help text. Fix this. Cc: Daniel P. Berrange berra...@redhat.com Cc: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [PATCH for-2.4 v3 1/3] migration: Fix global state with Xen.

2015-08-03 Thread Anthony PERARD
When doing migration via the QMP command xen_save_devices_state, the current runstate is not store into the global state section. Also the current runstate is not the one we want on the receiver side. During migration, the Xen toolstack paused QEMU before save the devices state. Also, the

Re: [Qemu-devel] [PATCH v2] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on reinstall

2015-08-03 Thread Leonid Bloch
Hi, On Mon, Aug 3, 2015 at 4:19 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: Hi On Mon, Aug 3, 2015 at 3:00 PM, Leonid Bloch leo...@daynix.com wrote: yes, but if you remove that RemoveExistingProducts too, then what fails? Only the manual call for RemoveExistingProducts is

[Qemu-devel] [PULL for-2.4 1/1] Fix release_drive on unplugged devices (pci_piix3_xen_ide_unplug)

2015-08-03 Thread Stefano Stabellini
pci_piix3_xen_ide_unplug should completely unhook the unplugged IDEDevice from the corresponding BlockBackend, otherwise the next call to release_drive will try to detach the drive again. Suggested-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com

Re: [Qemu-devel] [PATCH for-2.4 v3 2/3] migration: Add configuration section to vmstate with xen.

2015-08-03 Thread Stefano Stabellini
On Mon, 3 Aug 2015, Anthony PERARD wrote: This adds the configuration section in the vmstate saved by xen_save_devices_state. Signed-off-by: Anthony PERARD anthony.per...@citrix.com It doesn't seem to me that this patch is actually necessary to fix the issue, is that right? If that is the

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-03 Thread Dennis Luehring
Am 30.07.2015 um 10:55 schrieb Aurelien Jarno: Note that when you say SPARC64 here, it's actually only the kernel, you are using a 32-bit userland. ok - NetBSD 6.5.1 SPARC64 is blasting fast compare to Debian 7.8.0 SPARC64 - i installed the complete system (without X) in a few minutes Debian

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Laurent Vivier
On 03/08/2015 15:52, Laurent Vivier wrote: Originally, qemu_mod_timer() was using ticks to count time. And i6300esb was converting internal clock ticks (33 MHz) to QEMU timer ticks. The timer has been changed by a script to use nanoseconds: 7447545 change all other clock references

[Qemu-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Anthony PERARD
Hi, We've spotted several regression which prevent migration with Xen using the same version of QEMU or from a previous version of QEMU (tryied with 2.2). Regression have been introduce by at least: - df4b1024526cae3479da3492d6371fd4a7324a03 migration: create new section to store global state

[Qemu-devel] [PATCH for-2.4 v3 2/3] migration: Add configuration section to vmstate with xen.

2015-08-03 Thread Anthony PERARD
This adds the configuration section in the vmstate saved by xen_save_devices_state. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- migration/savevm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/migration/savevm.c b/migration/savevm.c index 6071215..b3f605c 100644 ---

[Qemu-devel] [PULL for-2.4 0/1] cve-2015-5166-tag

2015-08-03 Thread Stefano Stabellini
The following changes since commit 2a3612ccc1fa9cea77bd193afbfe21c77e7e91ef: Merge remote-tracking branch 'remotes/stefanha/tags/rtl8139-cplus-tx-input-validation-pull-request' into staging (2015-08-03 13:09:10 +0100) are available in the git repository at:

[Qemu-devel] [PATCH for-2.4 v3 3/3] migration: Fix regression for xenfv and pc, accel=xen machine.

2015-08-03 Thread Anthony PERARD
This fix migration from the same QEMU version and from previous QEMU version. From the global state section, we don't need runstate with Xen. Right now, the way the Xen toolstack knows when QEMU is ready is when QEMU reach running runstate. The configuration section and the section footers are

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Richard W.M. Jones
On Mon, Aug 03, 2015 at 04:28:14PM +0200, Laurent Vivier wrote: On 03/08/2015 15:52, Laurent Vivier wrote: Originally, qemu_mod_timer() was using ticks to count time. And i6300esb was converting internal clock ticks (33 MHz) to QEMU timer ticks. The timer has been changed by a

Re: [Qemu-devel] [PATCH for-2.4 v3 2/3] migration: Add configuration section to vmstate with xen.

2015-08-03 Thread Anthony PERARD
On Mon, Aug 03, 2015 at 03:48:18PM +0100, Stefano Stabellini wrote: On Mon, 3 Aug 2015, Anthony PERARD wrote: This adds the configuration section in the vmstate saved by xen_save_devices_state. Signed-off-by: Anthony PERARD anthony.per...@citrix.com It doesn't seem to me that this

Re: [Qemu-devel] [PATCH for-2.4 v3 1/3] migration: Fix global state with Xen.

2015-08-03 Thread Amit Shah
On (Mon) 03 Aug 2015 [15:53:57], Stefano Stabellini wrote: On Mon, 3 Aug 2015, Anthony PERARD wrote: When doing migration via the QMP command xen_save_devices_state, the current runstate is not store into the global state section. Also the current runstate is not the one we want on the

Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds

2015-08-03 Thread Paolo Bonzini
On 03/08/2015 17:35, Laurent Vivier wrote: I guess you mean tests/rtl8139-test.c What is the in_Timer() function ? There's some awful macro magic: #define PORT(name, len, val) \ static unsigned __attribute__((unused)) in_##name(void) \ { \ unsigned res = qpci_io_read##len(dev,

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 11/11] new: arm/barrier-test for memory barriers

2015-08-03 Thread Alex Bennée
alvise rigo a.r...@virtualopensystems.com writes: On Mon, Aug 3, 2015 at 12:30 PM, Alex Bennée alex.ben...@linaro.org wrote: alvise rigo a.r...@virtualopensystems.com writes: Hi Alex, Nice set of tests, they are proving to be helpful. One question below. snip Why are we calling these

Re: [Qemu-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Amit Shah
On (Mon) 03 Aug 2015 [15:29:18], Anthony PERARD wrote: Hi, We've spotted several regression which prevent migration with Xen using the same version of QEMU or from a previous version of QEMU (tryied with 2.2). Regression have been introduce by at least: -

Re: [Qemu-devel] [Xen-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Stefano Stabellini
On Mon, 3 Aug 2015, Amit Shah wrote: On (Mon) 03 Aug 2015 [15:29:18], Anthony PERARD wrote: Hi, We've spotted several regression which prevent migration with Xen using the same version of QEMU or from a previous version of QEMU (tryied with 2.2). Regression have been introduce by at

[Qemu-devel] [PULL for-2.4 0/2] Fix migration on Xen

2015-08-03 Thread Stefano Stabellini
The following changes since commit f60c87154ac722c528fd5582f7137914a93c5eec: configure: Drop vnc-ws feature from help text (2015-08-03 15:32:17 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-migration-2.4-tag for you to fetch

[Qemu-devel] [PULL for-2.4 2/2] migration: Fix regression for xenfv and pc, accel=xen machine.

2015-08-03 Thread Stefano Stabellini
From: Anthony PERARD anthony.per...@citrix.com This fix migration from the same QEMU version and from previous QEMU version. From the global state section, we don't need runstate with Xen. Right now, the way the Xen toolstack knows when QEMU is ready is when QEMU reach running runstate. The

[Qemu-devel] [PULL for-2.4 1/2] migration: Fix global state with Xen.

2015-08-03 Thread Stefano Stabellini
From: Anthony PERARD anthony.per...@citrix.com When doing migration via the QMP command xen_save_devices_state, the current runstate is not store into the global state section. Also the current runstate is not the one we want on the receiver side. During migration, the Xen toolstack paused QEMU

Re: [Qemu-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen.

2015-08-03 Thread Anthony PERARD
On Mon, Aug 03, 2015 at 09:37:07PM +0530, Amit Shah wrote: On (Mon) 03 Aug 2015 [15:29:18], Anthony PERARD wrote: Hi, We've spotted several regression which prevent migration with Xen using the same version of QEMU or from a previous version of QEMU (tryied with 2.2). Regression

Re: [Qemu-devel] [PATCH] kvm_ppc: remove kvmppc_timer_hack

2015-08-03 Thread Alexander Graf
On 27.07.15 13:46, Paolo Bonzini wrote: QEMU does have an I/O thread now, that can be interrupted at any time because the VCPU thread runs outside the iothread mutex. Therefore, the kvmppc_timer_hack is obsolete. Remove it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Thanks,

Re: [Qemu-devel] [PATCH v2 1/3] target-mips: Copy restrictions from ext/ins to dext/dins

2015-08-03 Thread Aurelien Jarno
On 2015-08-03 14:41, Richard Henderson wrote: On 08/03/2015 02:31 PM, Aurelien Jarno wrote: On 2015-08-03 12:35, Richard Henderson wrote: if (msb != 31) { -tcg_gen_andi_tl(t0, t0, (1 (msb + 1)) - 1); +tcg_gen_andi_tl(t0, t0, (1U (msb + 1)) - 1); Is this

Re: [Qemu-devel] [PATCH 2/3] target-mips: Stop translation after unconditional exceptions

2015-08-03 Thread Richard Henderson
On 08/03/2015 02:31 PM, Aurelien Jarno wrote: On 2015-08-03 11:49, Richard Henderson wrote: Since there are many more unconditional exceptions than conditional, introduce a new generate_exception_cond to mark conditionals. Also delete those few cases where we did attempt to stop translation

Re: [Qemu-devel] [RFC PATCH v0 4/5] spapr: Support hotplug by specifying DRC count

2015-08-03 Thread Michael Roth
Quoting Bharata B Rao (2015-08-03 02:53:02) On Mon, Aug 03, 2015 at 04:55:01PM +1000, David Gibson wrote: On Mon, Aug 03, 2015 at 11:05:42AM +0530, Bharata B Rao wrote: Support hotplug identifier type RTAS_LOG_V6_HP_ID_DRC_COUNT that allows hotplugging of DRCs by specifying the DRC count.

Re: [Qemu-devel] [PATCH v2 1/3] target-mips: Copy restrictions from ext/ins to dext/dins

2015-08-03 Thread Richard Henderson
On 08/03/2015 02:31 PM, Aurelien Jarno wrote: On 2015-08-03 12:35, Richard Henderson wrote: if (msb != 31) { -tcg_gen_andi_tl(t0, t0, (1 (msb + 1)) - 1); +tcg_gen_andi_tl(t0, t0, (1U (msb + 1)) - 1); Is this change really needed? msb == 30 means 1 31.

Re: [Qemu-devel] [RFC PATCH v0 4/5] spapr: Support hotplug by specifying DRC count

2015-08-03 Thread David Gibson
On Mon, Aug 03, 2015 at 05:32:43PM -0500, Michael Roth wrote: Quoting Bharata B Rao (2015-08-03 02:53:02) On Mon, Aug 03, 2015 at 04:55:01PM +1000, David Gibson wrote: On Mon, Aug 03, 2015 at 11:05:42AM +0530, Bharata B Rao wrote: Support hotplug identifier type

Re: [Qemu-devel] [PATCH RESEND v2 2/3] sPAPR: Support RTAS call ibm, {open, close}-errinjct

2015-08-03 Thread Alexey Kardashevskiy
On 08/03/2015 01:32 PM, Gavin Shan wrote: On Mon, Aug 03, 2015 at 12:51:09PM +1000, David Gibson wrote: On Mon, Aug 03, 2015 at 09:23:19AM +1000, Gavin Shan wrote: The patch supports RTAS calls ibm,{open,close}-errinjct to manupliate the token, which is passed to RTAS call ibm,errinjct to

Re: [Qemu-devel] [PATCH v3 10/12] netfilter: add a netbuffer filter

2015-08-03 Thread Jason Wang
On 08/03/2015 04:30 PM, Yang Hongyang wrote: This filter is to buffer/release packets, this feature can be used when using MicroCheckpointing, or other Remus like VM FT solutions, you can also use it to simulate the network delay. It has an interval option, if supplied, this filter will

Re: [Qemu-devel] [PATCH v7 35/42] Don't sync dirty bitmaps in postcopy

2015-08-03 Thread Amit Shah
On (Fri) 31 Jul 2015 [10:50:46], Dr. David Alan Gilbert wrote: * Amit Shah (amit.s...@redhat.com) wrote: On (Tue) 16 Jun 2015 [11:26:48], Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Once we're in postcopy the source processors are stopped and

Re: [Qemu-devel] [PATCH v3 04/12] net: add/remove filters from network backend

2015-08-03 Thread Jason Wang
On 08/03/2015 04:30 PM, Yang Hongyang wrote: add/remove filters from network backend Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com --- include/net/net.h | 8 net/filter.c | 4 ++-- net/net.c | 33 + 3 files changed, 43

Re: [Qemu-devel] [PATCH 0/3] rtl8139: cleanups

2015-08-03 Thread Jason Wang
On 08/03/2015 08:15 PM, Stefan Hajnoczi wrote: After addressing CVE-2015-5165 there were several additional rtl8139 cleanups that I'm sending separately since they are not security fixes. These patches eliminate duplicate eth.h structs/macros and fix unaligned memory accesses in tx

Re: [Qemu-devel] [PATCH v7 01/42] Start documenting how postcopy works.

2015-08-03 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:14], Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com Reviewed-by: Amit Shah amit.s...@redhat.com A few minor comments: --- docs/migration.txt | 167

Re: [Qemu-devel] [PATCH v3 04/12] net: add/remove filters from network backend

2015-08-03 Thread Yang Hongyang
On 08/04/2015 12:56 PM, Jason Wang wrote: On 08/03/2015 04:30 PM, Yang Hongyang wrote: add/remove filters from network backend Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com --- include/net/net.h | 8 net/filter.c | 4 ++-- net/net.c | 33

Re: [Qemu-devel] [PATCH v3 07/12] netfilter: add an API to pass the packet to next filter

2015-08-03 Thread Jason Wang
On 08/03/2015 04:30 PM, Yang Hongyang wrote: add an API qemu_netfilter_pass_to_next_iov() to pass the packet to next filter, and a wrapper qemu_netfilter_pass_to_next(). Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com --- include/net/filter.h | 12 include/net/net.h|

Re: [Qemu-devel] [PATCH v7 03/42] Init page sizes in qtest

2015-08-03 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:16], Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com One of my patches used a loop that was based on host page size; it dies in qtest since qtest hadn't bothered init'ing it. Signed-off-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH v3 04/12] net: add/remove filters from network backend

2015-08-03 Thread Jason Wang
On 08/04/2015 01:39 PM, Yang Hongyang wrote: On 08/04/2015 12:56 PM, Jason Wang wrote: On 08/03/2015 04:30 PM, Yang Hongyang wrote: add/remove filters from network backend Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com --- include/net/net.h | 8 net/filter.c | 4

Re: [Qemu-devel] [PATCH v7 19/42] MIG_CMD_PACKAGED: Send a packaged chunk of migration stream

2015-08-03 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:32], Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com MIG_CMD_PACKAGED is a migration command that wraps a chunk of migration stream inside a package whose length can be determined purely by reading its header. The destination

Re: [Qemu-devel] [PATCH v7 21/42] postcopy: OS support test

2015-08-03 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:34], Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Provide a check to see if the OS we're running on has all the bits needed for postcopy. Creates postcopy-ram.c which will get most of the other helpers we need.

Re: [Qemu-devel] [Bug 821078] Re: virtio-serial-bus: Unexpected port id

2015-08-03 Thread Amit Shah
On (Tue) 28 Jul 2015 [09:17:25], Quwj wrote: I met two bugs above.QEMU version is 2.1.3 and VM is Windows7. QEMU Log is: qemu-system-x86_64: virtio-serial-bus: Unexpected port id 15819934 for device virtio-serial0.0 (snip) Bug description: With qemu-kvm-0.15.0-rc1 virtio-serial-bus

Re: [Qemu-devel] [PATCH v3 07/12] netfilter: add an API to pass the packet to next filter

2015-08-03 Thread Yang Hongyang
On 08/04/2015 01:00 PM, Jason Wang wrote: On 08/03/2015 04:30 PM, Yang Hongyang wrote: add an API qemu_netfilter_pass_to_next_iov() to pass the packet to next filter, and a wrapper qemu_netfilter_pass_to_next(). Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com --- include/net/filter.h

Re: [Qemu-devel] [PATCH] target-mips: fix semihosting for microMIPS R6

2015-08-03 Thread Aurelien Jarno
On 2015-08-03 13:01, Leon Alrae wrote: In semihosting mode the SDBBP 1 instructions should trigger UHI syscall, but in QEMU this does not happen for recently added microMIPS R6. Consequently bare metal microMIPS R6 programs supporting UHI will not run. Signed-off-by: Leon Alrae

Re: [Qemu-devel] [PATCH 3/3] target-mips: Use CPU_LOG_INT for logging related to interrupts

2015-08-03 Thread Aurelien Jarno
On 2015-08-03 11:49, Richard Henderson wrote: There are now no unconditional uses of qemu_log in the subdirectory. Signed-off-by: Richard Henderson r...@twiddle.net --- target-mips/helper.c| 30 +++--- target-mips/op_helper.c | 3 ++- 2 files changed, 13

Re: [Qemu-devel] [PATCH 2/3] target-mips: Stop translation after unconditional exceptions

2015-08-03 Thread Aurelien Jarno
On 2015-08-03 11:49, Richard Henderson wrote: Since there are many more unconditional exceptions than conditional, introduce a new generate_exception_cond to mark conditionals. Also delete those few cases where we did attempt to stop translation after an exception, as these are now subsumed

Re: [Qemu-devel] [PATCH v2 1/3] target-mips: Copy restrictions from ext/ins to dext/dins

2015-08-03 Thread Aurelien Jarno
On 2015-08-03 12:35, Richard Henderson wrote: The checks in dins is required to avoid triggering an assertion in tcg_gen_deposit_tl. The check in dext is just for completeness. Fold the other D cases in via fallthru. In this case the errant dins appears to be data, not code, as translation

[Qemu-devel] [PATCH v4 04/11] qemu-log: Avoid function call for disabled qemu_log_mask logging

2015-08-03 Thread Alex Bennée
From: Peter Maydell peter.mayd...@linaro.org Make qemu_log_mask() a macro which only calls the function to do the actual work if the logging is enabled. This avoids making a function call in possible fast paths where logging is disabled. Signed-off-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] Debian 7.8.0 SPARC64 on qemu - anything i can do to speedup the emulation?

2015-08-03 Thread Aurelien Jarno
On 2015-08-03 10:31, Artyom Tarasenko wrote: Hi Aurelien, On Fri, Jul 31, 2015 at 5:43 PM, Aurelien Jarno aurel...@aurel32.net wrote: It uses a lot of integer functions based on CPU flags, so most of the time is spent computing them in helper_compute_psr. I wonder if this can be

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Daniel P. Berrange
On Mon, Aug 03, 2015 at 11:09:06AM +0800, Fam Zheng wrote: On Fri, 07/31 17:45, Marc Marí wrote: Hi everyone I propose improving the current modular driver system for QEMU so it can benefit everybody in speed and flexibility. I'm looking for other ideas, comments, critics, etc. -

[Qemu-devel] [PATCH v5 1/2] vhost user: add support of live migration

2015-08-03 Thread Thibaut Collet
Some vhost user backends are able to support live migration. To provide this service the following features must be added: 1. Add the VIRTIO_NET_F_GUEST_ANNOUNCE capability to vhost-net when netdev backend is vhost-user. 2. Provide a nop receive callback to vhost-user. This callback is used

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Marc Marí
On Mon, 03 Aug 2015 10:24:56 +0100 Alex Bennée alex.ben...@linaro.org wrote: Marc Marí mar...@redhat.com writes: On Mon, 3 Aug 2015 16:22:34 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 08/03 09:52, Marc Marí wrote: So any other ideas to reduce the library overhead are

Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region

2015-08-03 Thread Peter Maydell
On 3 August 2015 at 09:09, Pavel Fedin p.fe...@samsung.com wrote: Hi! What I thought you meant was that a non-LPAE kernel didn't work at all if we told it about the high-MMIO window (which would mean we'd need to *not* put that in the dtb if we wanted to avoid breaking non-LPAE guests that

Re: [Qemu-devel] Forbid to pass lun 0 to iscsi driver

2015-08-03 Thread Andrey Korolyov
On Mon, Aug 3, 2015 at 11:13 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 03/08/2015 09:47, Andrey Korolyov wrote: I`ve mistyped lun for tgtd upon volume hotplug, which resulted in an accidental crash, there is nothing but human factor. Until only LUN0 may possess such unusual properties,

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Alex Bennée
Marc Marí mar...@redhat.com writes: On Mon, 03 Aug 2015 10:24:56 +0100 Alex Bennée alex.ben...@linaro.org wrote: Marc Marí mar...@redhat.com writes: On Mon, 3 Aug 2015 16:22:34 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 08/03 09:52, Marc Marí wrote: So any other ideas to

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Marc Marí
On Mon, 3 Aug 2015 17:24:57 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 08/03 11:01, Marc Marí wrote: Some profiling: A QEMU with this configuration: ./configure --enable-sparse --enable-sdl --enable-gtk --enable-vte \ --enable-curses --enable-vnc

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 11/11] new: arm/barrier-test for memory barriers

2015-08-03 Thread alvise rigo
On Mon, Aug 3, 2015 at 12:30 PM, Alex Bennée alex.ben...@linaro.org wrote: alvise rigo a.r...@virtualopensystems.com writes: Hi Alex, Nice set of tests, they are proving to be helpful. One question below. On Fri, Jul 31, 2015 at 5:54 PM, Alex Bennée alex.ben...@linaro.org wrote: From:

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Fam Zheng
On Mon, 08/03 12:22, Marc Marí wrote: On Mon, 3 Aug 2015 17:24:57 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 08/03 11:01, Marc Marí wrote: Some profiling: A QEMU with this configuration: ./configure --enable-sparse --enable-sdl --enable-gtk --enable-vte \ --enable-curses

Re: [Qemu-devel] [PATCH v2 for-2.4] i.MX: Fix UART driver to work with unitialized chardev device

2015-08-03 Thread Markus Armbruster
Jean-Christophe DUBOIS j...@tribudubois.net writes: Le 01/08/2015 09:57, Markus Armbruster a écrit : Jean-Christophe Dubois j...@tribudubois.net writes: The chardev property initialization might have failed (for example because there are not enough chardevs provided by QEMU). The serial

Re: [Qemu-devel] [PATCH v7 6/6] Add gicversion option to virt machine

2015-08-03 Thread Peter Maydell
On 3 August 2015 at 08:19, Pavel Fedin p.fe...@samsung.com wrote: Hello! gicdev = qdev_create(NULL, gictype); -qdev_prop_set_uint32(gicdev, revision, 2); + +for (i = 0; i vbi-smp_cpus; i++) { +CPUState *cpu = qemu_get_cpu(i); +CPUARMState *env =

Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region

2015-08-03 Thread Pavel Fedin
Hi! What I thought you meant was that a non-LPAE kernel didn't work at all if we told it about the high-MMIO window (which would mean we'd need to *not* put that in the dtb if we wanted to avoid breaking non-LPAE guests that didn't care about the other window.) Current generic PCI driver

[Qemu-devel] [PATCH v3 05/12] net: delete netfilter object when delete netdev

2015-08-03 Thread Yang Hongyang
When we delete the netdev, we also delete the netfilter object attached to it, because if the netdev is removed, the filters which attached to it is useless. Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com --- include/net/filter.h | 1 + net/filter.c | 2 +- net/net.c|

[Qemu-devel] [PATCH v4 05/11] qemu-log: Improve the exec TB execution logging

2015-08-03 Thread Alex Bennée
From: Peter Maydell peter.mayd...@linaro.org Improve the TB execution logging so that it is easier to identify what is happening from trace logs: * move the Trace logging of executed TBs into cpu_tb_exec() so that it is emitted if and only if we actually execute a TB, and for consistency

[Qemu-devel] [PATCH v4 02/11] tcg: light re-factor and pass down TranslationBlock

2015-08-03 Thread Alex Bennée
My later debugging patches need access to the origin PC. At the same time we have a slightly clumsy pass-by-reference access to the size of the translated block again for debugging purposes. To simplify the code I have expanded the TranslationBlock structure to include a tc_size variable to

[Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu

2015-08-03 Thread Alex Bennée
This doesn't just dump CPU state on translation but on every block entrance. Signed-off-by: Alex Bennée alex.ben...@linaro.org Reviewed-by: Andreas Färber afaer...@suse.de --- v4 - add r-b tag --- qemu-log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-log.c

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Daniel P. Berrange
On Fri, Jul 31, 2015 at 05:45:42PM +0200, Marc Marí wrote: Hi everyone I propose improving the current modular driver system for QEMU so it can benefit everybody in speed and flexibility. I'm looking for other ideas, comments, critics, etc. - Background - In order to speed up QEMU, I'm

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Fam Zheng
On Mon, 08/03 11:01, Marc Marí wrote: Some profiling: A QEMU with this configuration: ./configure --enable-sparse --enable-sdl --enable-gtk --enable-vte \ --enable-curses --enable-vnc --enable-vnc-{jpeg,tls,sasl,png,ws} \ --enable-virtfs --enable-brlapi --enable-curl --enable-fdt \

[Qemu-devel] [PATCH v5 2/2] vhost user: add rarp sending after live migration for legacy guest

2015-08-03 Thread Thibaut Collet
A new vhost user message is added to allow QEMU to ask to vhost user backend to broadcast a fake RARP after live migration for guest without GUEST_ANNOUNCE capability. This new message is sent only if the backend supports the new VHOST_USER_PROTOCOL_F_RARP protocol feature. The payload of this

[Qemu-devel] [PATCH v5 0/2] vhost user: Add live migration

2015-08-03 Thread Thibaut Collet
v4-v5 1. The first patch is unchanged 2. The second patch is based on top of vhost-user: protocol updates series proposed earlier by Michael S. Tsirkin and vhost-user: add migration log support series proposed earlier by Marc Andre Lureau. The first patch provides limited live migration: -

Re: [Qemu-devel] [PATCH for-2.4 0/3] Migration regressions with Xen.

2015-08-03 Thread Stefano Stabellini
On Mon, 3 Aug 2015, Amit Shah wrote: On (Fri) 31 Jul 2015 [10:59:47], Stefano Stabellini wrote: On Thu, 30 Jul 2015, Stefano Stabellini wrote: On Thu, 30 Jul 2015, Juan Quintela wrote: Anthony PERARD anthony.per...@citrix.com wrote: This is a critical issue for Xen as migration

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Daniel P. Berrange
On Mon, Aug 03, 2015 at 10:24:56AM +0100, Alex Bennée wrote: Marc Marí mar...@redhat.com writes: On Mon, 3 Aug 2015 16:22:34 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 08/03 09:52, Marc Marí wrote: So any other ideas to reduce the library overhead are appreciated. It would

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Daniel P. Berrange
On Mon, Aug 03, 2015 at 10:58:41AM +0100, Alex Bennée wrote: Marc Marí mar...@redhat.com writes: On Mon, 03 Aug 2015 10:24:56 +0100 Alex Bennée alex.ben...@linaro.org wrote: Marc Marí mar...@redhat.com writes: On Mon, 3 Aug 2015 16:22:34 +0800 Fam Zheng f...@redhat.com

Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region

2015-08-03 Thread Pavel Fedin
Hello! In order to keep this guest working, we need a possibility to disable the new MMIO region in qemu. At least to omit it from the device tree. Yes, this is the workaround, which it sounds like we need. Ok. Just to avoid sending one more version which will be rejected. What

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 11/11] new: arm/barrier-test for memory barriers

2015-08-03 Thread Alex Bennée
alvise rigo a.r...@virtualopensystems.com writes: Hi Alex, Nice set of tests, they are proving to be helpful. One question below. On Fri, Jul 31, 2015 at 5:54 PM, Alex Bennée alex.ben...@linaro.org wrote: From: Alex Bennée a...@bennee.com This test has been written mainly to stress

[Qemu-devel] [PATCH v2] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on reinstall

2015-08-03 Thread Leonid Bloch
Previously, running the .msi would unregister the QEMU GA VSS service if QEMU GA was already installed on the machine, and then register it only if QEMU GA was NOT previously installed. This behavior caused the service to be registered only after the INITIAL installation, and any subsequent run

[Qemu-devel] [PATCH v4 08/11] qemu-log: dfilter-ise exec, out_asm, and op_opt

2015-08-03 Thread Alex Bennée
This ensures the code generation debug code will honour -dfilter if set. For the exec tracing I've added a new inline macro for efficiency's sake. I've not touched CPU_LOG_TB_OP as this is buried in each individual target. Signed-off-by: Alex Bennée alex.ben...@linaro.org v2 -

[Qemu-devel] [PATCH v4 00/11] qemu-log, perfmap and other logging tweaks

2015-08-03 Thread Alex Bennée
Hi, This is mostly just a re-base to keep current with master. I've added a couple of outstanding s-o-b and r-b tags. There are also two new patches in this series which seemed to be worth keeping together: - a simple patch to dump invocation info in the log - the cputlb logging clean-up

[Qemu-devel] [PATCH v4 11/11] cputlb: modernise the debug support

2015-08-03 Thread Alex Bennée
To avoid cluttering the code with #ifdef legs we wrap up the print statements into a tlb_debug() macro. As access to the virtual TLB can get quite heavy defining DEBUG_TLB_LOG will ensure all the logs go to the qemu_log target of CPU_LOG_MMU instead of stderr. I've also removed DEBUG_TLB_CHECK

[Qemu-devel] [PATCH v4 07/11] qemu-log: new option -dfilter to limit output

2015-08-03 Thread Alex Bennée
When debugging big programs or system emulation sometimes you want both the verbosity of cpu,exec et all but don't want to generate lots of logs for unneeded stuff. This patch adds a new option -dfilter which allows you to specify interesting address ranges in the form: -dfilter

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Alex Bennée
Marc Marí mar...@redhat.com writes: On Mon, 3 Aug 2015 16:22:34 +0800 Fam Zheng f...@redhat.com wrote: On Mon, 08/03 09:52, Marc Marí wrote: So any other ideas to reduce the library overhead are appreciated. It would be interesting to see your profiling on the library loading overhead.

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Marc Marí
On Mon, 3 Aug 2015 10:23:37 +0100 Daniel P. Berrange berra...@redhat.com wrote: On Fri, Jul 31, 2015 at 05:45:42PM +0200, Marc Marí wrote: Hi everyone I propose improving the current modular driver system for QEMU so it can benefit everybody in speed and flexibility. I'm looking for

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 11/11] new: arm/barrier-test for memory barriers

2015-08-03 Thread alvise rigo
Hi Alex, Nice set of tests, they are proving to be helpful. One question below. On Fri, Jul 31, 2015 at 5:54 PM, Alex Bennée alex.ben...@linaro.org wrote: From: Alex Bennée a...@bennee.com This test has been written mainly to stress multi-threaded TCG behaviour but will demonstrate failure

Re: [Qemu-devel] [PULL for-2.4 0/2] Ide patches

2015-08-03 Thread Peter Maydell
On 31 July 2015 at 23:27, John Snow js...@redhat.com wrote: The following changes since commit cb48f67ad8c7b33c617d4f8144a27706e69fd688: bsd-user: Fix operand to cpu_x86_exec (2015-07-30 12:38:49 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git

Re: [Qemu-devel] [PATCH v2 6/9] vhost: use variable arguments for vhost_call()

2015-08-03 Thread Marc-André Lureau
Hi On Sat, Aug 1, 2015 at 4:47 AM, l...@dorileo.org wrote: diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c index 4d68a27..7255089 100644 --- a/hw/virtio/vhost-backend.c +++ b/hw/virtio/vhost-backend.c @@ -14,8 +14,8 @@ #include sys/ioctl.h -static int

[Qemu-devel] [PATCH v4 10/11] vl.c: log system invocation when enabled

2015-08-03 Thread Alex Bennée
This makes it a little easier to remember how you generated that 100Mb trace log you saved for a future date. Signed-off-by: Alex Bennée alex.ben...@linaro.org --- configure | 2 +- vl.c | 18 ++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/configure

[Qemu-devel] [PATCH v4 09/11] target-arm: dfilter support for in_asm, op, opt_op

2015-08-03 Thread Alex Bennée
Each individual architecture needs to use the qemu_log_in_addr_range() feature for enabling in_asm and marking blocks for op/opt_op output. Signed-off-by: Alex Bennée alex.ben...@linaro.org --- target-arm/translate-a64.c | 6 -- target-arm/translate.c | 6 -- 2 files changed, 8

[Qemu-devel] [PATCH v4 06/11] qemu-log: support simple pid substitution in logfile

2015-08-03 Thread Alex Bennée
When debugging stuff that occurs over several forks it would be useful not to keep overwriting the one logfile you've set-up. This allows a simple %d to be included once in the logfile parameter which is substituted with getpid(). Signed-off-by: Alex Bennée alex.ben...@linaro.org Reviewed-by:

[Qemu-devel] [PATCH v4 01/11] tcg: add ability to dump /tmp/perf-pid.map files

2015-08-03 Thread Alex Bennée
This allows the perf tool to map samples to each individual translation block. This could be expanded for user space but currently it gives enough information to find any hotblocks by other means. Signed-off-by: Alex Bennée alex.ben...@linaro.org --- v2: - hoist up into translate-all.c -

Re: [Qemu-devel] Modularizing QEMU RFC

2015-08-03 Thread Paolo Bonzini
On 03/08/2015 05:09, Fam Zheng wrote: bdrv_probe_all is harder. If we modularize a format driver, its .bdrv_probe code will be in the module. If we want to do the format detection, we need to load all format drivers. This means if the command line has an unspecified format, we'll still need

[Qemu-devel] [PATCH] sheepdog: remove back pointer to BlockDriverState

2015-08-03 Thread Paolo Bonzini
Since sheepdog does not implement a rebind callback, this back pointer is dangerous. Do not use it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/sheepdog.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index

[Qemu-devel] [PATCH v2] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on reinstall

2015-08-03 Thread Leonid Bloch
Contrary to the first version of this patch, this time the MajorUpgrade element is used both to handle the detection of previously installed versions for upgrade, and to prevent downgrading without manual un-installation of the older version. The property REINSTALLMODE had to be set to amus,

Re: [Qemu-devel] [PATCH v7 6/6] Add gicversion option to virt machine

2015-08-03 Thread Pavel Fedin
Hello! gicdev = qdev_create(NULL, gictype); -qdev_prop_set_uint32(gicdev, revision, 2); + +for (i = 0; i vbi-smp_cpus; i++) { +CPUState *cpu = qemu_get_cpu(i); +CPUARMState *env = cpu-env_ptr; +env-nvic = gicdev; +} We definitely need

Re: [Qemu-devel] [PATCH v3] hw/arm/virt: Add high MMIO PCI region

2015-08-03 Thread Peter Maydell
On 3 August 2015 at 08:03, Pavel Fedin p.fe...@samsung.com wrote: Hi! I have done an additional study... (1) We should confirm whether this really is a guest kernel bug (as opposed to the device tree QEMU emits not being in spec) (2) If it is a kernel bug, submit a patch to fix it It is

[Qemu-devel] [PULL 0/4] TCG MIPS and S390 fixes for 2.4

2015-08-03 Thread Aurelien Jarno
.net/qemu.git tags/pull-tcg-mips-s390-20150803 for you to fetch changes up to c99d69694af4ed15b33e3f7c2e3ef6972c14358d: tcg/mips: fix add2 (2015-08-01 09:39:50 +0200) TCG MIPS and S390 fixes for 2.4

[Qemu-devel] [PULL 1/4] tcg/mips: fix TLB loading for BE host with 32-bit guests

2015-08-03 Thread Aurelien Jarno
For 32-bit guest, we load a 32-bit address from the TLB, so there is no need to compensate for the low or high part. This fixes 32-bit guests on big-endian hosts. Cc: qemu-sta...@nongnu.org Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Aurelien Jarno aurel...@aurel32.net ---

[Qemu-devel] [PATCH v3 07/12] netfilter: add an API to pass the packet to next filter

2015-08-03 Thread Yang Hongyang
add an API qemu_netfilter_pass_to_next_iov() to pass the packet to next filter, and a wrapper qemu_netfilter_pass_to_next(). Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com --- include/net/filter.h | 12 include/net/net.h| 1 + net/filter.c | 31

[Qemu-devel] [PATCH v3 06/12] netfilter: hook packets before net queue send

2015-08-03 Thread Yang Hongyang
Capture packets that will be sent. Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com --- net/net.c | 69 ++- 1 file changed, 68 insertions(+), 1 deletion(-) diff --git a/net/net.c b/net/net.c index 7f84a6d..f774c39 100644 ---

  1   2   3   >