Re: [Qemu-devel] [PATCH 02/10] cpus: remove tcg_halt_cond global variable.

2015-08-29 Thread Paolo Bonzini
On 28/08/2015 16:36, Peter Maydell wrote: With this patch, code-wise tcg_halt_cond and tcg_cpu_thread are used in pretty much parallel ways (first call into qemu_tcg_init_vcpu() sets them up, all the rest just copy them into the CPU struct). The only difference is that one of them a static

[Qemu-devel] [PATCH] disas/microblaze: Remove unused code

2015-08-29 Thread Stefan Weil
Signed-off-by: Stefan Weil s...@weilnetz.de --- disas/microblaze.c | 150 - 1 file changed, 150 deletions(-) diff --git a/disas/microblaze.c b/disas/microblaze.c index c14ab89..3588235 100644 --- a/disas/microblaze.c +++ b/disas/microblaze.c @@

Re: [Qemu-devel] [PATCH 05/10] cpu-exec: elide more icount code if CONFIG_USER_ONLY

2015-08-29 Thread Paolo Bonzini
On 28/08/2015 16:56, Peter Maydell wrote: What's the rationale for this? Mostly we prefer not to add ifdefs in code if we can get away with compiling it for both cases, even if the resulting code isn't used. True. The rationale is three-fold: 1) It makes sense to abort if

Re: [Qemu-devel] [PATCH 03/10] replace spinlock by QemuMutex.

2015-08-29 Thread Paolo Bonzini
On 28/08/2015 16:53, Frederic Konrad wrote: After this commit it looks like we have no users of spinlock_t at all. It would be good to have a followup patch which deleted include/exec/spinlock.h. Seems Paolo forget to pick up the following patch from the mttcg tree: remove unused

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-08-29 Thread Paolo Bonzini
On 28/08/2015 01:47, Andreas Färber wrote: The argument order for the !CONFIG_SOFTMMU case was jumbled up since ffc6372851d8631a9f9fa56ec613b3244dc635b9 (tcg/aarch64: use 32-bit offset for 32-bit user-mode emulation), regressing from -rc2 to v2.4.0. Fix their order to avoid segfaults, e.g.,

Re: [Qemu-devel] [PATCH] monitor: allow object_del device_del to accept QOM paths

2015-08-29 Thread Paolo Bonzini
On 28/08/2015 14:53, Markus Armbruster wrote: I believe this makes sense no matter what we do about device IDs (see thread Should we auto-generate IDs?). I haven't read that huge thread yet, but I think it gives the user too much power. There are internal objects that are not supposed to be

[Qemu-devel] [PATCH] slirp: Fix type casts and format strings in debug code

2015-08-29 Thread Stefan Weil
Casting pointers to long won't work on 64 bit Windows. It is not needed with the right format strings. Signed-off-by: Stefan Weil s...@weilnetz.de --- slirp/bootp.c | 12 +--- slirp/if.c | 4 ++-- slirp/ip_icmp.c| 4 ++-- slirp/ip_input.c | 10 +-

Re: [Qemu-devel] [PATCH 06/10] tcg: code_bitmap is not used by user-mode emulation

2015-08-29 Thread Paolo Bonzini
On 28/08/2015 16:57, Peter Maydell wrote: More #ifdefs are not nice, but this clarifies why its usage is not protected by tb_lock. Does it? I thought the idea of this series was to add locking which we needed for adding multi-threading to softmmu, in which case presumably we need to

[Qemu-devel] [PATCH] linux-user: Fix warnings caused by missing 'static' attribute

2015-08-29 Thread Stefan Weil
Warnings from the Sparse static analysis tool: linux-user/main.c:40:12: warning: symbol 'filename' was not declared. Should it be static? linux-user/main.c:41:12: warning: symbol 'argv0' was not declared. Should it be static? linux-user/main.c:42:5: warning: symbol 'gdbstub_port' was not

Re: [Qemu-devel] [PATCH] monitor: allow object_del device_del to accept QOM paths

2015-08-29 Thread Gonglei
On 2015/8/29 14:49, Paolo Bonzini wrote: On 28/08/2015 14:53, Markus Armbruster wrote: I believe this makes sense no matter what we do about device IDs (see thread Should we auto-generate IDs?). I haven't read that huge thread yet, but I think it gives the user too much power. There

Re: [Qemu-devel] [PATCH 08/10] tcg: add memory barriers in page_find_alloc accesses

2015-08-29 Thread Paolo Bonzini
On 28/08/2015 17:40, Peter Maydell wrote: Don't we also need to use an atomic_rcu_read() for the load pd = *lp; (which is between hunk 1 and 2 in this patch) ? Yes. Paolo

Re: [Qemu-devel] [PATCH 07/10] tcg: comment on which functions have to be called with mmap_lock held

2015-08-29 Thread Paolo Bonzini
On 28/08/2015 17:33, Peter Maydell wrote: Some overall documentation on what the mmap_lock is protecting (and thus when it needs to be taken) would be nice. Otherwise Reviewed-by: Peter Maydell peter.mayd...@linaro.org I couldn't see where we take the mmap_lock when we call

Re: [Qemu-devel] [PATCH 04/10] exec-all: remove non-TCG stuff from exec-all.h header.

2015-08-29 Thread Paolo Bonzini
On 28/08/2015 16:53, Peter Maydell wrote: sysemu.h is a bit of a huge grab-bag of stuff, so it seems a shame to put qemu_in_vcpu_thread() into it, given that (a) that function is only used by a couple of files and (b) the files that do want that function don't want most of what's in

[Qemu-devel] [PATCH v2 1/2] arm: cpu: assert() on no-EL2 virt IRQ error condition.

2015-08-29 Thread Peter Crosthwaite
Replace the hw_error() for no-EL2 VIRQ with an assert. Signed-off-by: Peter Crosthwaite crosthwaite.pe...@gmail.com --- Changed since v1: Reimplement as assert --- target-arm/cpu.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/target-arm/cpu.c b/target-arm/cpu.c index

[Qemu-devel] [PATCH v2 2/2] arm: Remove hw_error() usages.

2015-08-29 Thread Peter Crosthwaite
All of these hw_errors are fatal and indicate something wrong with QEMU implementation. Convert to g_assert_not_reached. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Peter Crosthwaite crosthwaite.pe...@gmail.com --- Dropped the error messages as they are not hugely useful

[Qemu-devel] [PATCH v2 0/2] Remove hw_error from target-arm

2015-08-29 Thread Peter Crosthwaite
Hi Peter, This removes the last of the hw_errors from target-arm. Regards, Peter Changed since v1: Handle everything as an assert() Peter Crosthwaite (2): arm: cpu: assert() on no-EL2 virt IRQ error condition. arm: Remove hw_error() usages. target-arm/cpu.c| 9 +++--

Re: [Qemu-devel] [PATCH v2 0/2] Remove hw_error from target-arm

2015-08-29 Thread Peter Maydell
On 29 August 2015 at 11:06, Peter Crosthwaite crosthwaitepe...@gmail.com wrote: Hi Peter, This removes the last of the hw_errors from target-arm. Hi; can you remind me what the reason was for wanting to remove them? thanks -- PMM

Re: [Qemu-devel] [PATCH] linux-user: Fix warnings caused by missing 'static' attribute

2015-08-29 Thread Peter Maydell
On 29 August 2015 at 08:29, Stefan Weil s...@weilnetz.de wrote: Warnings from the Sparse static analysis tool: linux-user/main.c:40:12: warning: symbol 'filename' was not declared. Should it be static? linux-user/main.c:41:12: warning: symbol 'argv0' was not declared. Should it be static?

Re: [Qemu-devel] [PATCH v2 0/2] Remove hw_error from target-arm

2015-08-29 Thread Peter Crosthwaite
On Sat, Aug 29, 2015 at 3:08 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 29 August 2015 at 11:06, Peter Crosthwaite crosthwaitepe...@gmail.com wrote: Hi Peter, This removes the last of the hw_errors from target-arm. Hi; can you remind me what the reason was for wanting to remove

Re: [Qemu-devel] [PATCH v2] configure: factor out adding disas configure

2015-08-29 Thread Peter Maydell
On 29 August 2015 at 11:33, Peter Crosthwaite crosthwaitepe...@gmail.com wrote: Every arch adds its disas configury to both its own config as well config_disas_all. Make a small function do to both at once. Signed-off-by: Peter Crosthwaite crosthwaite.pe...@gmail.com --- Changed since v1:

[Qemu-devel] [PATCH v2] configure: factor out adding disas configure

2015-08-29 Thread Peter Crosthwaite
Every arch adds its disas configury to both its own config as well config_disas_all. Make a small function do to both at once. Signed-off-by: Peter Crosthwaite crosthwaite.pe...@gmail.com --- Changed since v1: Factor out everything except just the arch name. Prepares support for multi-arch where

Re: [Qemu-devel] [PATCH] configure: factor out adding disas configure

2015-08-29 Thread Peter Crosthwaite
On Sat, Jul 18, 2015 at 2:09 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 18 July 2015 at 07:25, Peter Crosthwaite crosthwaitepe...@gmail.com wrote: Every arch adds its disas configury to both its own config as well config_disas_all. Make a small function do to both at once.

[Qemu-devel] [PATCH] nsis: Add QEMU version information to Windows registry

2015-08-29 Thread Stefan Weil
The uninstall keys include an optional key DisplayVersion which we set now. By default the version value is read from file VERSION, but it is also possible to pass VERSION=#.#.# to make. Signed-off-by: Stefan Weil s...@weilnetz.de --- Makefile | 1 + qemu.nsi | 3 +++ 2 files changed, 4

Re: [Qemu-devel] [PATCH v14 00/33] TileGX basic instructions

2015-08-29 Thread Chen Gang
Is tilegx patches OK to qemu mater tree? Or shall I do anything for it? If I should do something for it, please let me know, I shall try. I almost finished analyzing one gcc bug (found root cause, got correct result with my patch), it was waiting review. If I needn't do anything for tilegx

Re: [Qemu-devel] [PATCH v14 12/33] target-tilegx: Generate SEGV properly

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: Signed-off-by: Richard Henderson r...@twiddle.net --- linux-user/main.c | 3 +++ target-tilegx/cpu.c | 5 - target-tilegx/cpu.h | 2 ++ 3 files changed, 9 insertions(+), 1 deletion(-) Reviewed-by: Peter Maydell

Re: [Qemu-devel] [Qemu-block] [PATCH V3] block/nfs: cache allocated filesize for read-only files

2015-08-29 Thread Max Reitz
On 27.08.2015 12:30, Peter Lieven wrote: If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang if block device info is queried and the NFS

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Max Reitz
On 29.08.2015 17:57, Programmingkid wrote: On Aug 29, 2015, at 11:40 AM, Max Reitz wrote: On 27.08.2015 03:05, G 3 wrote: I want to share files between my host and guest computer. A feature I want to add would be a new menu item in the Machine menu called Mount Image File When the

Re: [Qemu-devel] [PATCH v14 07/33] target-tilegx: Fix LDNA_ADD_IMM8_OPCODE_X1

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: An obvious typo in the mnemonic here. Signed-off-by: Richard Henderson r...@twiddle.net --- target-tilegx/opcode_tilegx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v14 06/33] target-tilegx: Modify _SPECIAL_ opcodes

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: Both ADDX_SPECIAL_0_OPCODE_Y1 and ADD_SPECIAL_0_OPCODE_Y1 do not appear to be special in any way, except that they don't follow the normal naming convention using _RRR_. Signed-off-by: Richard Henderson r...@twiddle.net

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Max Reitz
On 27.08.2015 03:05, G 3 wrote: I want to share files between my host and guest computer. A feature I want to add would be a new menu item in the Machine menu called Mount Image File When the user selects it, a file open dialog box displays. The user can then select the image file with the

Re: [Qemu-devel] Question about nbd

2015-08-29 Thread Max Reitz
On 27.08.2015 12:02, Wen Congyang wrote: We can start a nbd server in qemu, and the nbd client will connect to this server later. Each client has a export name, and the server will know the disk the client want to use according to the export name. If there are two clients that have the same

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Programmingkid
On Aug 29, 2015, at 11:40 AM, Max Reitz wrote: On 27.08.2015 03:05, G 3 wrote: I want to share files between my host and guest computer. A feature I want to add would be a new menu item in the Machine menu called Mount Image File When the user selects it, a file open dialog box

Re: [Qemu-devel] [PATCH] linux-user: fix host_to_target_cmsg in case of multiple headers

2015-08-29 Thread Jonathan Neuschäfer
On Thu, Aug 27, 2015 at 07:06:24PM +0100, Peter Maydell wrote: This definitely looks like a bug, but I don't think this is a sufficient fix, because if DEBUG_REMAP is defined then the locked-memory which the target_cmsghdr* is in is not a simple g2h() away from the host pointer. What you

Re: [Qemu-devel] [PATCH v14 10/33] target-tilegx: Add several helpers for instructions translation

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: From: Chen Gang xili_gchen_5...@hotmail.com The related instructions are exception, cntlz, cnttz, shufflebytes. Signed-off-by: Chen Gang gang.chen.5...@gmail.com Message-Id: blu436-smtp83f96fd8422be49afdc9dfb9...@phx.gbl

Re: [Qemu-devel] [PATCH v14 14/33] target-tilegx: Handle simple logical operations

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: Signed-off-by: Richard Henderson r...@twiddle.net --- target-tilegx/translate.c | 99 +-- 1 file changed, 96 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v14 16/33] target-tilegx: Handle most bit manipulation instructions

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: Omitting crc instructions. I'm not a fan of commit message bodies that rely on reading the subject line to make sense (partly because my mail client doesn't put the subject line very prominently when reading the email...)

Re: [Qemu-devel] [PATCH] linux-user: fix host_to_target_cmsg in case of multiple headers

2015-08-29 Thread Peter Maydell
On 29 August 2015 at 17:04, Jonathan Neuschäfer j.neuschae...@gmx.net wrote: On Thu, Aug 27, 2015 at 07:06:24PM +0100, Peter Maydell wrote: This definitely looks like a bug, but I don't think this is a sufficient fix, because if DEBUG_REMAP is defined then the locked-memory which the

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Max Reitz
On 29.08.2015 19:36, Programmingkid wrote: On Aug 29, 2015, at 12:39 PM, Max Reitz wrote: On 29.08.2015 17:57, Programmingkid wrote: On Aug 29, 2015, at 11:40 AM, Max Reitz wrote: On 27.08.2015 03:05, G 3 wrote: I want to share files between my host and guest computer. A feature I want

Re: [Qemu-devel] [PATCH v14 11/33] target-tilegx: Framework for decoding bundles

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: Signed-off-by: Richard Henderson r...@twiddle.net --- target-tilegx/translate.c | 1145 + 1 file changed, 1145 insertions(+) create mode 100644 target-tilegx/translate.c

Re: [Qemu-devel] [PATCH v14 15/33] target-tilegx: Handle arithmetic instructions

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: Signed-off-by: Richard Henderson r...@twiddle.net --- target-tilegx/translate.c | 95 --- 1 file changed, 89 insertions(+), 6 deletions(-) Reviewed-by: Peter Maydell

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Max Reitz
On 29.08.2015 20:34, MagicCat Software wrote: On Aug 29, 2015, at 2:01 PM, Max Reitz wrote: On 29.08.2015 19:36, Programmingkid wrote: On Aug 29, 2015, at 12:39 PM, Max Reitz wrote: [snip] If making QEMU more user-friendly is a crime, I plead guilty! Yes, in some people's eyes it is a

Re: [Qemu-devel] [PATCH 07/19] moxie: Remove ELF_MACHINE from cpu.h

2015-08-29 Thread Peter Crosthwaite
On Mon, Aug 17, 2015 at 8:48 PM, Richard Henderson r...@twiddle.net wrote: On 08/17/2015 08:36 PM, Peter Crosthwaite wrote: On Mon, Aug 17, 2015 at 11:39 AM, Richard Henderson r...@twiddle.net wrote: On 08/15/2015 04:28 PM, Peter Crosthwaite wrote: - ELF_MACHINE,

[Qemu-devel] [PATCH 0/2] elf+moxie: EM_MOXIE defintition

2015-08-29 Thread Peter Crosthwaite
Hi Richard, This adds EM_MOXIE as suggested. Patch one does some surrounding code style cleanup and P2 fixes Moxie. Regards, Peter Peter Crosthwaite (2): elf_ops: Fix coding style for EM alias case statement elf: Update EM_MOXIE definition hw/moxie/moxiesim.c | 1 + include/elf.h

[Qemu-devel] [PATCH 1/2] elf_ops: Fix coding style for EM alias case statement

2015-08-29 Thread Peter Crosthwaite
Fix the coding style for these cases as per CODING_STYLE. Reverse the Yoda conditions and add missing if braces. Signed-off-by: Peter Crosthwaite crosthwaite.pe...@gmail.com --- include/hw/elf_ops.h | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v14 21/33] target-tilegx: Handle comparison instructions

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: Signed-off-by: Richard Henderson r...@twiddle.net --- target-tilegx/translate.c | 39 +-- 1 file changed, 33 insertions(+), 6 deletions(-) Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v14 22/33] target-tilegx: Implement system and memory management instructions

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: Most of which are either nops or exceptions. Signed-off-by: Richard Henderson r...@twiddle.net --- target-tilegx/translate.c | 94 ++- 1 file changed, 68 insertions(+), 26

Re: [Qemu-devel] [PATCH v14 2/8] i.MX: KZM now uses the standalone i.MX31 SOC support

2015-08-29 Thread Peter Crosthwaite
Commit subject should lead with out a verb after the subsystem label(s). On Mon, Aug 10, 2015 at 3:02 PM, Jean-Christophe Dubois j...@tribudubois.net wrote: Tested by booting a minimal Linux system on the emulated platform Commit message should lead out with longer form of the main change. Make

Re: [Qemu-devel] [PATCH v14 3/8] i.MX: Add I2C controller emulator

2015-08-29 Thread Peter Crosthwaite
On Mon, Aug 10, 2015 at 3:02 PM, Jean-Christophe Dubois j...@tribudubois.net wrote: The slave mode is not implemented. Signed-off-by: Jean-Christophe Dubois j...@tribudubois.net Reviewed-by: Peter Crosthwaite crosthwaite.pe...@gmail.com Have you changed my email from the original RB? You

Re: [Qemu-devel] [PATCH v14 4/8] i.MX: Add FEC Ethernet Emulator

2015-08-29 Thread Peter Crosthwaite
On Mon, Aug 10, 2015 at 3:02 PM, Jean-Christophe Dubois j...@tribudubois.net wrote: This is based on mcf_fec.c FEC implementation for Coldfire * A generic PHY was added (borrowwed from LAN9118) * The buffer management is also modified as buffers are slightly different between Coldfire

Re: [Qemu-devel] [PATCH v14 5/8] i.MX: Add SOC support for i.MX25

2015-08-29 Thread Peter Crosthwaite
On Mon, Aug 10, 2015 at 3:02 PM, Jean-Christophe Dubois j...@tribudubois.net wrote: For now we support the following devices: * CPU: ARM926 * Interrupt Controller: AVIC * CCM * UART x 5 * EPIT x 2 * GPT x 4 * FEC * I2C x 3

Re: [Qemu-devel] [PATCH v14 6/8] i.MX: Add the i.MX25 PDK plateform

2015-08-29 Thread Peter Crosthwaite
platform On Mon, Aug 10, 2015 at 3:02 PM, Jean-Christophe Dubois j...@tribudubois.net wrote: Tested by booting a minimal Linux system on the emulated platform Tested by booting the Xvisor hyprvisor on the emulated platform hypervisor Signed-off-by: Jean-Christophe Dubois

Re: [Qemu-devel] [PATCH v14 7/8] i.MX: Add qtest support for I2C device emulator.

2015-08-29 Thread Peter Crosthwaite
On Mon, Aug 10, 2015 at 3:03 PM, Jean-Christophe Dubois j...@tribudubois.net wrote: This is using a ds1338 RTC chip on the I2C bus. This RTC chip is not present on the real 3DS PDK board. Signed-off-by: Jean-Christophe Dubois j...@tribudubois.net Not an expert, but looks ok. Acked-by: Peter

Re: [Qemu-devel] [PATCH v14 6/8] i.MX: Add the i.MX25 PDK plateform

2015-08-29 Thread Peter Maydell
On 29 August 2015 at 23:27, Peter Crosthwaite crosthwaitepe...@gmail.com wrote: platform On Mon, Aug 10, 2015 at 3:02 PM, Jean-Christophe Dubois j...@tribudubois.net wrote: Tested by booting a minimal Linux system on the emulated platform Tested by booting the Xvisor hyprvisor on the

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Eric Blake
On 08/29/2015 11:36 AM, Programmingkid wrote: Mac OS X is a second-class citizen in the QEMU world... Might have to do something with most (?) of it being non-free and Apple not caring enough about KVM. Fact, Apple has made an hypervisor API available as of Mac OS 10.10, so who knows.

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Programmingkid
On Aug 29, 2015, at 3:34 PM, Max Reitz wrote: On 29.08.2015 20:34, MagicCat Software wrote: On Aug 29, 2015, at 2:01 PM, Max Reitz wrote: On 29.08.2015 19:36, Programmingkid wrote: On Aug 29, 2015, at 12:39 PM, Max Reitz wrote: [snip] If making QEMU more user-friendly is a crime,

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Programmingkid
On Aug 29, 2015, at 3:52 PM, Max Reitz wrote: On 29.08.2015 20:34, MagicCat Software wrote: On Aug 29, 2015, at 2:01 PM, Max Reitz wrote: [snip] User-friendliness is always expensive, difficult to maintain, and a neverending source of complaints. Really? It has been months since

Re: [Qemu-devel] [PATCH v14 18/33] target-tilegx: Handle post-increment load and store instructions

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: Signed-off-by: Richard Henderson r...@twiddle.net --- target-tilegx/translate.c | 96 ++- 1 file changed, 87 insertions(+), 9 deletions(-) Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v14 19/33] target-tilegx: Handle unconditional jump instructions

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: Signed-off-by: Richard Henderson r...@twiddle.net --- target-tilegx/translate.c | 58 +-- 1 file changed, 41 insertions(+), 17 deletions(-) Reviewed-by: Peter Maydell

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Programmingkid
On Aug 29, 2015, at 12:39 PM, Max Reitz wrote: On 29.08.2015 17:57, Programmingkid wrote: On Aug 29, 2015, at 11:40 AM, Max Reitz wrote: On 27.08.2015 03:05, G 3 wrote: I want to share files between my host and guest computer. A feature I want to add would be a new menu item in the

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread MagicCat Software
On Aug 29, 2015, at 2:01 PM, Max Reitz wrote: On 29.08.2015 19:36, Programmingkid wrote: On Aug 29, 2015, at 12:39 PM, Max Reitz wrote: On 29.08.2015 17:57, Programmingkid wrote: On Aug 29, 2015, at 11:40 AM, Max Reitz wrote: On 27.08.2015 03:05, G 3 wrote: I want to share files

[Qemu-devel] [PATCH 2/2] elf: Update EM_MOXIE definition

2015-08-29 Thread Peter Crosthwaite
EM_MOXIE now has a proper assigned elf code. Use it. Register the old interim value as EM_MOXIE_OLD and accept either in elf loading. Cc: Anthony Green gr...@moxielogic.com Signed-off-by: Peter Crosthwaite crosthwaite.pe...@gmail.com --- hw/moxie/moxiesim.c | 1 + include/elf.h| 3 +++

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Max Reitz
On 29.08.2015 20:34, MagicCat Software wrote: On Aug 29, 2015, at 2:01 PM, Max Reitz wrote: [snip] User-friendliness is always expensive, difficult to maintain, and a neverending source of complaints. Really? It has been months since Peter Maydell implemented my GUI patches for the

Re: [Qemu-devel] [PATCH v14 17/33] target-tilegx: Handle basic load and store instructions

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: Signed-off-by: Richard Henderson r...@twiddle.net --- target-tilegx/translate.c | 131 -- 1 file changed, 116 insertions(+), 15 deletions(-) Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v14 20/33] target-tilegx: Handle conditional branch instructions

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: Signed-off-by: Richard Henderson r...@twiddle.net --- target-tilegx/translate.c | 51 +++ 1 file changed, 38 insertions(+), 13 deletions(-) Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH v14 11/33] target-tilegx: Framework for decoding bundles

2015-08-29 Thread Peter Maydell
On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: Signed-off-by: Richard Henderson r...@twiddle.net +if (dc-jmp.cond != TCG_COND_NEVER) { +if (dc-jmp.cond == TCG_COND_ALWAYS) { +tcg_gen_mov_i64(cpu_pc, dc-jmp.dest); +} else { +

Re: [Qemu-devel] [PATCH v14 00/33] TileGX basic instructions

2015-08-29 Thread Chen Gang
After download and merge the all related patches to my local qemu, for me:  - The refactor code is really very good to me! :-)  - It cause hello world test program segment fault. Do we need fix all related issues before merge the code?  - If I need fix them after finish merging the refactor

Re: [Qemu-devel] Subject: [PATCH 01/16] linux-user: tilegx: Firstly add architecture related features

2015-08-29 Thread gang . chen . 5i5j
At present, I can send mail through git client directly with my qq mail address, I reply this mail again to test whether our qemu mailing list can accept qq mail address or not. If it can accept qq mail address, I shall send mail through git client directly. OK, thanks. I guess I should send

Re: [Qemu-devel] Subject: [PATCH 01/16] linux-user: tilegx: Firstly add architecture related features

2015-08-29 Thread gang . chen . 5i5j
At present, I can send mail through git client directly with my qq mail address, I reply this mail again to test whether our qemu mailing list can accept qq mail address or not. If it can accept qq mail address, I shall send mail through git client directly. OK, thanks. I guess I should send

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Eric Blake
On 08/29/2015 01:34 PM, Max Reitz wrote: Erm, well, I think I won't reply to that other than *cough* virt-manager *cough*. Linux exclusive probably. Your point? You said applications on Linux are generally more difficult to use than comparable applications on OS X, by design. I said

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Eric Blake
On 08/29/2015 02:18 PM, Programmingkid wrote: (1) 'change' always uses 'raw' as the format, but the selector apparently offers you the full range of image formats (supportedImageFileTypes). So far it has worked out just fine. Doesn't QEMU detect the format itself? You DON'T want to rely

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Programmingkid
On Aug 29, 2015, at 7:12 PM, Eric Blake wrote: On 08/29/2015 02:18 PM, Programmingkid wrote: (1) 'change' always uses 'raw' as the format, but the selector apparently offers you the full range of image formats (supportedImageFileTypes). So far it has worked out just fine. Doesn't QEMU

Re: [Qemu-devel] [PATCH v14 11/33] target-tilegx: Framework for decoding bundles

2015-08-29 Thread Chen Gang
On 8/29/15 22:50, Peter Maydell wrote: On 24 August 2015 at 17:17, Richard Henderson r...@twiddle.net wrote: + qemu_log_mask(CPU_LOG_TB_IN_ASM, % PRIx64 : { , dc-pc); + if (get_Mode(bundle)) { + notice_excp(dc, bundle, y0, decode_y0(dc, bundle)); + qemu_log_mask(CPU_LOG_TB_IN_ASM, ; ); +

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread Programmingkid
On Aug 29, 2015, at 7:10 PM, Eric Blake wrote: On 08/29/2015 01:34 PM, Max Reitz wrote: Erm, well, I think I won't reply to that other than *cough* virt-manager *cough*. Linux exclusive probably. Your point? You said applications on Linux are generally more difficult to use than

Re: [Qemu-devel] Mount image file feature

2015-08-29 Thread MagicCat Software
On Aug 29, 2015, at 7:04 PM, Eric Blake wrote: On 08/29/2015 11:36 AM, Programmingkid wrote: Mac OS X is a second-class citizen in the QEMU world... Might have to do something with most (?) of it being non-free and Apple not caring enough about KVM. Fact, Apple has made an