Re: [Qemu-devel] [Bug 1488363] Re: qemu 2.4.0 hangs using vfio for pci passthrough of graphics card

2015-09-01 Thread Alexandre DERUMIER
Hi, proxmox users report same bug here with qemu 2.4: http://forum.proxmox.com/threads/23346-Proxmox-4b1-q35-machines-failing-to-reboot-problems-with-PCI-passthrough we are going to test with reverting the commit to see if it's help. - Mail original - De: "Peter Maloney" <1488...@bugs.

Re: [Qemu-devel] rfc: vhost user enhancements for vm2vm communication

2015-09-01 Thread Jan Kiszka
On 2015-08-31 16:11, Michael S. Tsirkin wrote: > Hello! > During the KVM forum, we discussed supporting virtio on top > of ivshmem. No, not on top of ivshmem. On top of shared memory. Our model is different from the simplistic ivshmem. > I have considered it, and came up with an alternative > tha

Re: [Qemu-devel] rfc: vhost user enhancements for vm2vm communication

2015-09-01 Thread Michael S. Tsirkin
On Tue, Sep 01, 2015 at 09:35:21AM +0200, Jan Kiszka wrote: > On 2015-08-31 16:11, Michael S. Tsirkin wrote: > > Hello! > > During the KVM forum, we discussed supporting virtio on top > > of ivshmem. > > No, not on top of ivshmem. On top of shared memory. Our model is > different from the simplist

Re: [Qemu-devel] [PATCH v6 3/8] scripts: Submit changes while updating linux headers

2015-09-01 Thread Peter Maydell
On 26 August 2015 at 00:46, Gavin Shan wrote: > Ok. I misunderstood your original comment. Yeah, the SOB line can be simply > dded by "-s" option to "git commit", which I just got from the manpage. I'll > use "-s" option in next revision. If you don't object, "FIXME" for user.name > and user.email

Re: [Qemu-devel] rfc: vhost user enhancements for vm2vm communication

2015-09-01 Thread Michael S. Tsirkin
On Mon, Aug 31, 2015 at 11:35:55AM -0700, Nakajima, Jun wrote: > On Mon, Aug 31, 2015 at 7:11 AM, Michael S. Tsirkin wrote: > > Hello! > > During the KVM forum, we discussed supporting virtio on top > > of ivshmem. I have considered it, and came up with an alternative > > that has several advantag

Re: [Qemu-devel] [PATCH v14 22/33] target-tilegx: Implement system and memory management instructions

2015-09-01 Thread Peter Maydell
On 1 September 2015 at 06:16, Richard Henderson wrote: > I'm not really sure what to do with reserved operand fields on this > architecture. Raising an exception is what Chen started with, but the > encoding for brk suggests that they're ignored. The ISA says "Implementations are permitted, but

Re: [Qemu-devel] rfc: vhost user enhancements for vm2vm communication

2015-09-01 Thread Michael S. Tsirkin
On Tue, Sep 01, 2015 at 03:03:12AM +, Varun Sethi wrote: > Hi Michael, > When you talk about VFIO in guest, is it with a purely emulated IOMMU in Qemu? This can use the emulated IOMMU in Qemu. That's probably fast enough if mappings are mostly static. We can also add a PV-IOMMU if necessary.

[Qemu-devel] [PATCH v5 0/5] QEMU ATAPI-SCSI bridge

2015-09-01 Thread Alexander Bezzubikov
This is my QEMU Google Summer of Code project. Here I introduce new device - ATAPI-SCSI bridge. Its purpose is to unify IDE ATAPI CD-ROM emulation with SCSI CD-ROM emulation to reduce code duplication and squash bugs. It's purpose is simple - it just forwards ATAPI commands to SCSI side for parsing

[Qemu-devel] [PATCH v5 5/5] ide: ATAPI-SCSI bridge transfer is treated as PIO

2015-09-01 Thread Alexander Bezzubikov
This patch is necessary because ATAPI-SCSI bridge transfer uses ide_transfer_start/stop and ide_data_read function check if PIO transfer is running, so bridge function should be added to this check Signed-off-by: Alexander Bezzubikov --- hw/ide/core.c | 4 +++- 1 file changed, 3 insertions(+), 1

[Qemu-devel] [PATCH v5 4/5] ATAPI-SCSI bridge functions created an can be used by bridge

2015-09-01 Thread Alexander Bezzubikov
ide: bridge functions created ide: Makefile corrected due to bridge creation scsi: added function to enable bridge send SCSI requests ide: bridge can now forward requests to SCSI ide: bridge functions assigned to SCSIBusInfo Signed-off-by: Alexander Bezzubikov --- hw/ide/Makefile.objs | 2 +-

[Qemu-devel] [PATCH v5 2/5] scsi: SCSIDiskReq declaration moved to header

2015-09-01 Thread Alexander Bezzubikov
Signed-off-by: Alexander Bezzubikov --- hw/scsi/scsi-disk.c| 12 include/hw/scsi/scsi.h | 13 + 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index bada9a7..68ff09a 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/

[Qemu-devel] [PATCH v5 3/5] ide: necessary checks corrected to treat ATAPI-SCSI bridge as CDROM

2015-09-01 Thread Alexander Bezzubikov
hw/ide/qdev.c: corrected to treat bridge as CDROM hw/ide/core.c: same corrections as in qdev.c hw/ide/ahci.c: same corrections as in qdev.c hw/ide/atapi.c: skip some CDROM checks because bridge has only fake drive Signed-off-by: Alexander Bezzubikov --- hw/ide/ahci.c | 6 -- hw/ide/atap

[Qemu-devel] [PATCH v5 1/5] ide: ATAPI-SCSI bridge TypeInfo and init function created

2015-09-01 Thread Alexander Bezzubikov
Signed-off-by: Alexander Bezzubikov --- hw/ide/bridge.h | 9 + hw/ide/internal.h | 4 +++- hw/ide/qdev.c | 41 + 3 files changed, 53 insertions(+), 1 deletion(-) create mode 100644 hw/ide/bridge.h diff --git a/hw/ide/bridge.h b/hw/ide/brid

Re: [Qemu-devel] [PATCH] monitor: allow object_del & device_del to accept QOM paths

2015-09-01 Thread Daniel P. Berrange
On Sat, Aug 29, 2015 at 08:49:58AM +0200, Paolo Bonzini wrote: > > > On 28/08/2015 14:53, Markus Armbruster wrote: > > I believe this makes sense no matter what we do about device IDs (see > > thread "Should we auto-generate IDs?"). > > I haven't read that huge thread yet, but I think it gives t

[Qemu-devel] [Bug 1490886] [NEW] spice-qemu-char.c Assert

2015-09-01 Thread Quwj
Public bug reported: spice-qemu-char.c:173: spice_chr_add_watch: Assertion `cond == G_IO_OUT' failed. I trace the code virtio-console.c: ret = qemu_chr_fe_write(vcon->chr, buf, len); trace_virtio_console_flush_buf(port->id, len, ret); if (ret < len) { VirtIOSerialPortClass *k = VI

[Qemu-devel] [Bug 1490886] Re: spice-qemu-char.c Assert

2015-09-01 Thread Quwj
called param is G_IO_OUT|G_IO_HUP,but assert (cond == G_IO_OUT) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1490886 Title: spice-qemu-char.c Assert Status in QEMU: New Bug description: spic

[Qemu-devel] [PATCH v9 04/10] netfilter: hook packets before net queue send

2015-09-01 Thread Yang Hongyang
Capture packets that will be sent. Signed-off-by: Yang Hongyang Reviewed-by: Thomas Huth --- v5: do not check ret against iov_size pass sent_cb to filters --- net/net.c | 66 +++ 1 file changed, 66 insertions(+) diff --git a/net/n

[Qemu-devel] [PATCH v9 03/10] netfilter: add netfilter_{add|del} commands

2015-09-01 Thread Yang Hongyang
add netfilter_{add|del} commands This is mostly the same with netdev_{add|del} commands. When we delete the netdev, we also delete the netfilter object attached to it, because if the netdev is removed, the filters which attached to it is useless. Note that the buffer filter will be implemented in

[Qemu-devel] [PATCH v9 06/10] netfilter: add an API to pass the packet to next filter

2015-09-01 Thread Yang Hongyang
add an API qemu_netfilter_pass_to_next() to pass the packet to next filter. Signed-off-by: Yang Hongyang Reviewed-by: Thomas Huth --- v9: fix a bug when curr filter chain is all v5: fold params to NetPacket struct --- include/net/filter.h | 3 +++ net/filter.c | 55

[Qemu-devel] [PATCH v9 08/10] net/queue: export qemu_net_queue_append_iov

2015-09-01 Thread Yang Hongyang
This will be used by buffer filter implementation later to queue packets. Signed-off-by: Yang Hongyang Reviewed-by: Thomas Huth --- include/net/queue.h | 7 +++ net/queue.c | 12 ++-- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/include/net/queue.h b/incl

[Qemu-devel] [PATCH v9 05/10] move out net queue structs define

2015-09-01 Thread Yang Hongyang
This will be used by the next patch in this series. Signed-off-by: Yang Hongyang Reviewed-by: Thomas Huth --- include/net/queue.h | 19 +++ net/queue.c | 19 --- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/include/net/queue.h b/includ

[Qemu-devel] [PATCH v9 07/10] netfilter: print filter info associate with the netdev

2015-09-01 Thread Yang Hongyang
From: Yang Hongyang When execute "info network", print filter info also. current info printed is simple, can add more info later. Signed-off-by: Yang Hongyang --- v9: tiny cleanup according to Tomas's comment. v7: initial patch --- include/net/filter.h | 1 + net/filter.c | 22 +++

[Qemu-devel] [PATCH v9 09/10] netfilter: add a netbuffer filter

2015-09-01 Thread Yang Hongyang
This filter is to buffer/release packets, this feature can be used when using MicroCheckpointing, or other Remus like VM FT solutions, you can also use it to simulate the network delay. It has an interval option, if supplied, this filter will release packets by interval. The dummy filter is replace

[Qemu-devel] [PATCH v9 02/10] init/cleanup of netfilter object

2015-09-01 Thread Yang Hongyang
QTAILQ_ENTRY global_list but used by filter layer, so that we can manage all filters together. QTAILQ_ENTRY next used by netdev, filter belongs to the specific netdev is in this queue. This is mostly the same with init/cleanup of netdev object. The dummy filter is to work around with the empty uni

[Qemu-devel] [PATCH v9 01/10] net: add a new object netfilter

2015-09-01 Thread Yang Hongyang
Add the framework for a new netfilter object and a new -netfilter CLI option as a basis for the following patches. Note that the new added document in qemu-options.hx indicate that there's a buffer filter. This type of filter will be implemented in the following patches. Signed-off-by: Yang Hongya

[Qemu-devel] [PATCH v9 00/10] Add a netfilter object and netbuffer filter

2015-09-01 Thread Yang Hongyang
This patch add a new object netfilter, capture all network packets. Also implement a netbuffer based on this object. the "buffer" netfilter could be used by VM FT solutions like MicroCheckpointing, to buffer/release packets. Or to simulate packet delay. You can also get the series from: https://gi

Re: [Qemu-devel] [PATCH] trace-events: Add hmp completion

2015-09-01 Thread Stefan Hajnoczi
On Fri, Aug 14, 2015 at 11:27:43AM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add completion for the trace event names in the hmp trace-event > command. > > Signed-off-by: Dr. David Alan Gilbert > --- > hmp-commands.hx | 1 + > hmp.h | 1 + > mo

[Qemu-devel] [PATCH v9 10/10] tests: add test cases for netfilter object

2015-09-01 Thread Yang Hongyang
Using qtest qmp interface to implement following cases: 1) add/remove netfilter 2) add a netfilter then delete the netdev 3) add/remove more than one netfilters 4) add more than one netfilters and then delete the netdev Signed-off-by: Yang Hongyang --- v9: qmp command change due to the qapi chang

Re: [Qemu-devel] rfc: vhost user enhancements for vm2vm communication

2015-09-01 Thread Jan Kiszka
On 2015-09-01 10:01, Michael S. Tsirkin wrote: > On Tue, Sep 01, 2015 at 09:35:21AM +0200, Jan Kiszka wrote: >> Leaving all the implementation and interface details aside, this >> discussion is first of all about two fundamentally different approaches: >> static shared memory windows vs. dynamicall

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

2015-09-01 Thread Stefan Hajnoczi
On Mon, Aug 31, 2015 at 02:23:43PM +0800, Xiao Guangrong wrote: > > Hi Stefan, > > On 08/28/2015 07:58 PM, Stefan Hajnoczi wrote: > > > > +goto do_unmap; > +} > + > +nvdimm->device_index = new_device_index(); > +sprintf(name, "NVDIMM-%d", nvdimm->device_in

Re: [Qemu-devel] [PATCH v6 1/2] vhost-user: add multi queue support

2015-09-01 Thread Yuanhan Liu
On Thu, Aug 13, 2015 at 12:18:38PM +0300, Michael S. Tsirkin wrote: > On Wed, Aug 12, 2015 at 02:25:41PM +0800, Ouyang Changchun wrote: > > Based on patch by Nikolay Nikolaev: > > Vhost-user will implement the multi queue support in a similar way > > to what vhost already has - a separate thread fo

Re: [Qemu-devel] [PATCH v6 2/2] vhost-user: new protocol feature for multi queue

2015-09-01 Thread Yuanhan Liu
On Thu, Aug 13, 2015 at 12:22:50PM +0300, Michael S. Tsirkin wrote: > On Wed, Aug 12, 2015 at 02:25:42PM +0800, Ouyang Changchun wrote: > > This patch is based on top of "vhost-user: protocol updates" series > > proposed earlier by Michael S. Tsirkin. > > > > Use new message VHOST_USER_SET_VRING_F

Re: [Qemu-devel] [PATCH] monitor: allow object_del & device_del to accept QOM paths

2015-09-01 Thread Daniel P. Berrange
On Tue, Sep 01, 2015 at 09:58:14AM +0100, Daniel P. Berrange wrote: > On Sat, Aug 29, 2015 at 08:49:58AM +0200, Paolo Bonzini wrote: > > > > > > On 28/08/2015 14:53, Markus Armbruster wrote: > > > I believe this makes sense no matter what we do about device IDs (see > > > thread "Should we auto-g

Re: [Qemu-devel] [PATCH v2 14/18] nvdimm: support NFIT_CMD_IMPLEMENTED function

2015-09-01 Thread Stefan Hajnoczi
On Mon, Aug 31, 2015 at 02:51:50PM +0800, Xiao Guangrong wrote: > > > On 08/28/2015 08:01 PM, Stefan Hajnoczi wrote: > >On Wed, Aug 26, 2015 at 06:46:35PM +0800, Xiao Guangrong wrote: > >>On 08/26/2015 12:23 AM, Stefan Hajnoczi wrote: > >>>On Fri, Aug 14, 2015 at 10:52:07PM +0800, Xiao Guangrong

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support

2015-09-01 Thread Yuanhan Liu
On Mon, Aug 31, 2015 at 02:30:06PM +0300, Michael S. Tsirkin wrote: [snip..] > > Then how about the other case: > > When startup the vhost backend, user specify 8 queues, like: > > Vhost-user ... -queues 8 # Y=8 > > When startup the guest, user specify 4 queues, like: > > Qemu-kvm ... -queue

Re: [Qemu-devel] rfc: vhost user enhancements for vm2vm communication

2015-09-01 Thread Michael S. Tsirkin
On Tue, Sep 01, 2015 at 11:11:52AM +0200, Jan Kiszka wrote: > On 2015-09-01 10:01, Michael S. Tsirkin wrote: > > On Tue, Sep 01, 2015 at 09:35:21AM +0200, Jan Kiszka wrote: > >> Leaving all the implementation and interface details aside, this > >> discussion is first of all about two fundamentally

Re: [Qemu-devel] [Patch for-2.5 v2 2/6] support nbd driver in blockdev-add

2015-09-01 Thread Wen Congyang
On 09/01/2015 01:19 AM, Eric Blake wrote: > On 08/11/2015 01:51 AM, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> Reviewed-by: Alberto Garcia >> --- >> qapi/block-core.json | 17 +++-- >> 1 file changed, 15 insertion

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support

2015-09-01 Thread Michael S. Tsirkin
On Tue, Sep 01, 2015 at 05:20:06PM +0800, Yuanhan Liu wrote: > On Mon, Aug 31, 2015 at 02:30:06PM +0300, Michael S. Tsirkin wrote: > [snip..] > > > Then how about the other case: > > > When startup the vhost backend, user specify 8 queues, like: > > > Vhost-user ... -queues 8 # Y=8 > > > Whe

[Qemu-devel] [PATCH v3] monitor: allow object_del & device_del to accept QOM paths

2015-09-01 Thread Daniel P. Berrange
Currently both object_del and device_del require that the client provide the object/device short ID. While user creatable objects require an ID to be provided at time of creation, qdev devices may be created without giving an ID. The only unique identifier they would then have is the QOM object pat

Re: [Qemu-devel] [PATCH v6 1/2] vhost-user: add multi queue support

2015-09-01 Thread Michael S. Tsirkin
On Tue, Sep 01, 2015 at 05:13:50PM +0800, Yuanhan Liu wrote: > On Thu, Aug 13, 2015 at 12:18:38PM +0300, Michael S. Tsirkin wrote: > > On Wed, Aug 12, 2015 at 02:25:41PM +0800, Ouyang Changchun wrote: > > > Based on patch by Nikolay Nikolaev: > > > Vhost-user will implement the multi queue support

Re: [Qemu-devel] [PATCH v6 2/2] vhost-user: new protocol feature for multi queue

2015-09-01 Thread Michael S. Tsirkin
On Tue, Sep 01, 2015 at 05:16:31PM +0800, Yuanhan Liu wrote: > On Thu, Aug 13, 2015 at 12:22:50PM +0300, Michael S. Tsirkin wrote: > > On Wed, Aug 12, 2015 at 02:25:42PM +0800, Ouyang Changchun wrote: > > > This patch is based on top of "vhost-user: protocol updates" series > > > proposed earlier b

Re: [Qemu-devel] [PATCH] sheepdog: discard the payload if the header is invalid

2015-09-01 Thread Liu Yuan
On Tue, Sep 01, 2015 at 10:05:38AM +0800, Liu Yuan wrote: > On Mon, Aug 31, 2015 at 09:51:00PM -0400, Jeff Cody wrote: > > On Tue, Sep 01, 2015 at 09:29:31AM +0800, Liu Yuan wrote: > > > From: Liu Yuan > > > > > > We need to discard the payload if we get a invalid header due to whatever > > > re

Re: [Qemu-devel] [PATCH v2 1/2] spapr: Add support for hwrng when available

2015-09-01 Thread Thomas Huth
On 01/09/15 02:38, David Gibson wrote: > On Mon, Aug 31, 2015 at 08:46:01PM +0200, Thomas Huth wrote: >> From: Michael Ellerman >> >> Some powerpc systems have support for a hardware random number generator >> (hwrng). If such a hwrng is present the host kernel can provide access >> to it via the

Re: [Qemu-devel] [PATCH v2 2/2] ppc/spapr_hcall: Implement H_RANDOM hypercall in QEMU

2015-09-01 Thread Thomas Huth
On 01/09/15 02:47, David Gibson wrote: > On Mon, Aug 31, 2015 at 08:46:02PM +0200, Thomas Huth wrote: >> The PAPR interface provides a hypercall to pass high-quality >> hardware generated random numbers to guests. So let's provide >> this call in QEMU, too, so that guests that do not support >> vir

Re: [Qemu-devel] [PATCH] linux-user: add name_to_handle_at/open_by_handle_at

2015-09-01 Thread Peter Maydell
On 27 August 2015 at 23:27, Laurent Vivier wrote: > This patch allows to run example given by open_by_handle_at(2): > > The following shell session demonstrates the use of these two programs: > >$ echo 'Can you please think about it?' > cecilia.txt >$ ./t_name_to_hand

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/4] target-ppc: Add FWNMI support in qemu for powerKVM guests

2015-09-01 Thread Aravinda Prasad
On Monday 10 August 2015 09:35 AM, Sam Bobroff wrote: > On Sun, Aug 09, 2015 at 03:53:02PM +0200, Alexander Graf wrote: >> >> >> On 07.08.15 05:37, Sam Bobroff wrote: >>> Hello Aravinda and all, >>> >>> On Wed, Jul 08, 2015 at 01:58:13PM +0530, Aravinda Prasad wrote: On Friday 03 July 2015 1

Re: [Qemu-devel] [PATCH v3 6/9] arm: clarify the use of muldiv64()

2015-09-01 Thread Peter Maydell
On 27 August 2015 at 20:33, Laurent Vivier wrote: > muldiv64() is used to convert microseconds into CPU ticks. > > But it is not clear and not commented. This patch uses macro > to clearly identify what is used: time, CPU frequency and ticks. > For an elapsed time and a given frequency, we compute

Re: [Qemu-devel] [PATCH v3 6/9] arm: clarify the use of muldiv64()

2015-09-01 Thread Laurent Vivier
On 01/09/2015 13:17, Peter Maydell wrote: > On 27 August 2015 at 20:33, Laurent Vivier wrote: >> muldiv64() is used to convert microseconds into CPU ticks. >> >> But it is not clear and not commented. This patch uses macro >> to clearly identify what is used: time, CPU frequency and ticks. >> Fo

Re: [Qemu-devel] [PATCH v3 2/2] rtl8139: correctly track full receive buffer in standard mode

2015-09-01 Thread Vlad Yasevich
On 08/31/2015 11:15 PM, Jason Wang wrote: > > > On 08/31/2015 10:24 PM, Vlad Yasevich wrote: >> On 08/31/2015 05:59 AM, Jason Wang wrote: >>> >>> On 08/28/2015 10:06 PM, Vladislav Yasevich wrote: In standard operation mode, when the receive ring buffer is full, the buffer actually appea

Re: [Qemu-devel] [PATCH v3 6/9] arm: clarify the use of muldiv64()

2015-09-01 Thread Peter Maydell
On 1 September 2015 at 12:23, Laurent Vivier wrote: > > > On 01/09/2015 13:17, Peter Maydell wrote: >> On 27 August 2015 at 20:33, Laurent Vivier wrote: >>> +#define ARM_CPU_FREQ 10 /* FIXME: 1 GHz, should be configurable */ >> >> LL suffix for large constants, please. > > In fact, I didn

Re: [Qemu-devel] [PATCH 1/1] block: Allow passing BlockdevOptions to blockdev-snapshot-sync

2015-09-01 Thread Kevin Wolf
Am 31.08.2015 um 22:05 hat Eric Blake geschrieben: > On 08/31/2015 01:53 PM, Max Reitz wrote: > > > Design question: Would it make sense to instead add a "reference" mode > > to blockdev-snapshot-sync where you can specify a BDS's node-name > > instead of snapshot-file to use an existing BDS as th

Re: [Qemu-devel] [PATCH 1/1] block: Allow passing BlockdevOptions to blockdev-snapshot-sync

2015-09-01 Thread Kevin Wolf
Am 31.08.2015 um 22:12 hat Max Reitz geschrieben: > On 31.08.2015 22:05, Eric Blake wrote: > > On 08/31/2015 01:53 PM, Max Reitz wrote: > > > >> Design question: Would it make sense to instead add a "reference" mode > >> to blockdev-snapshot-sync where you can specify a BDS's node-name > >> instea

Re: [Qemu-devel] [PATCH v6 2/2] vhost-user: new protocol feature for multi queue

2015-09-01 Thread Yuanhan Liu
On Tue, Sep 01, 2015 at 01:09:15PM +0300, Michael S. Tsirkin wrote: > On Tue, Sep 01, 2015 at 05:16:31PM +0800, Yuanhan Liu wrote: > > On Thu, Aug 13, 2015 at 12:22:50PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Aug 12, 2015 at 02:25:42PM +0800, Ouyang Changchun wrote: > > > > This patch is ba

Re: [Qemu-devel] ARM softmmu breakpoint misbehavior

2015-09-01 Thread Sergey Fedorov
28.08.2015 22:21, Peter Maydell wrote: I think what we need to do is have the translate-a64.c code be smarter, and actually generate the real code if we're not going to really hit the bp. Except that we don't really have all the info in the flags to know for sure about that. So we probably need t

[Qemu-devel] [PULL 0/1] virtio-serial: disable event throttling

2015-09-01 Thread Amit Shah
The following changes since commit 090d0bfd948343d522cd20bc634105b5cfe2483b: s390: fix softmmu compilation (2015-08-28 16:05:24 +0100) are available in the git repository at: https://git.kernel.org/pub/scm/qemu/amit/virtio-serial vser-for-2.5 for you to fetch changes up to 1717c47170ec8df29

[Qemu-devel] [PULL 1/1] monitor: remove QAPI_EVENT_VSERPORT_CHANGE throttle

2015-09-01 Thread Amit Shah
From: Marc-André Lureau QAPI_EVENT_VSERPORT_CHANGE reports changes of a virtio serial port state. However, the events may be for different ports, but the throttle mechanism may replace the event for a different port, since it only checks the event type. libvirt relies on a correct state to be re

Re: [Qemu-devel] [PATCH 1/2] atapi: abort transfers with 0 byte limits

2015-09-01 Thread Kevin Wolf
Am 25.08.2015 um 02:25 hat John Snow geschrieben: > > > On 07/13/2015 06:18 AM, Kevin Wolf wrote: > > Am 11.07.2015 um 03:05 hat John Snow geschrieben: > >> We're supposed to abort on transfers like this, unless we fill > >> Word 125 of our IDENTIFY data with a default transfer size, which > >> w

Re: [Qemu-devel] [PATCH v6 1/2] vhost-user: add multi queue support

2015-09-01 Thread Yuanhan Liu
On Tue, Sep 01, 2015 at 01:07:11PM +0300, Michael S. Tsirkin wrote: > On Tue, Sep 01, 2015 at 05:13:50PM +0800, Yuanhan Liu wrote: > > On Thu, Aug 13, 2015 at 12:18:38PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Aug 12, 2015 at 02:25:41PM +0800, Ouyang Changchun wrote: > > > > Based on patch b

Re: [Qemu-devel] [PULL 0/1] virtio-serial: disable event throttling

2015-09-01 Thread Peter Maydell
On 1 September 2015 at 13:04, Amit Shah wrote: > The following changes since commit 090d0bfd948343d522cd20bc634105b5cfe2483b: > > s390: fix softmmu compilation (2015-08-28 16:05:24 +0100) > > are available in the git repository at: > > https://git.kernel.org/pub/scm/qemu/amit/virtio-serial vse

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support

2015-09-01 Thread Yuanhan Liu
On Tue, Sep 01, 2015 at 12:41:49PM +0300, Michael S. Tsirkin wrote: > On Tue, Sep 01, 2015 at 05:20:06PM +0800, Yuanhan Liu wrote: > > On Mon, Aug 31, 2015 at 02:30:06PM +0300, Michael S. Tsirkin wrote: > > [snip..] > > > > Then how about the other case: > > > > When startup the vhost backend, use

Re: [Qemu-devel] [PULL 0/1] virtio-serial: disable event throttling

2015-09-01 Thread Marc-André Lureau
Hi Amit Out of curiosity, did you check the series "monitor: throttle VSERPORT_CHANGED by id"? That would fix the throttling instead of just removing it. This can be applied later, but reviews are always welcome :) thanks -- Marc-André Lureau

Re: [Qemu-devel] Should we auto-generate IDs?

2015-09-01 Thread Kevin Wolf
Am 27.08.2015 um 14:32 hat Jeff Cody geschrieben: > I'm not married to the ID generation scheme I proposed. > > What I am trying to do, however, is have a technical discussion on > generating an ID in a well-formed manner. And hopefully, in a way > that is useful to all interested subsystems, i

Re: [Qemu-devel] [PULL 0/1] virtio-serial: disable event throttling

2015-09-01 Thread Amit Shah
On (Tue) 01 Sep 2015 [13:13:56], Peter Maydell wrote: > On 1 September 2015 at 13:04, Amit Shah wrote: > > The following changes since commit 090d0bfd948343d522cd20bc634105b5cfe2483b: > > > > s390: fix softmmu compilation (2015-08-28 16:05:24 +0100) > > > > are available in the git repository at

Re: [Qemu-devel] [PATCH] target-i386: Disable cache info passthrough by default

2015-09-01 Thread Igor Mammedov
On Wed, 19 Aug 2015 10:08:22 -0700 Eduardo Habkost wrote: > The host cache information may not make sense for the guest if the VM > CPU topology doesn't match the host CPU topology. To make sure we won't > expose broken cache information to the guest, disable cache info > passthrough by default,

Re: [Qemu-devel] [PULL 0/1] virtio-serial: disable event throttling

2015-09-01 Thread Amit Shah
On (Tue) 01 Sep 2015 [14:27:48], Marc-André Lureau wrote: > Hi Amit > > Out of curiosity, did you check the series "monitor: throttle > VSERPORT_CHANGED by id"? That would fix the throttling instead of just > removing it. This can be applied later, but reviews are always welcome > :) So do you wa

Re: [Qemu-devel] [PULL 0/1] virtio-serial: disable event throttling

2015-09-01 Thread Marc-André Lureau
Hi On Tue, Sep 1, 2015 at 2:47 PM, Amit Shah wrote: > So do you want to wait for that series to be ready instead of pulling > this in now? I'm fine with either approach. I am fine with both too, I just wanted to point out that there is a already a follow-up. > Also: it helps to CC the people y

Re: [Qemu-devel] [PATCH RFC v3 30/32] qapi: New QMP command query-schema for QMP schema introspection

2015-09-01 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 08/04/2015 09:58 AM, Markus Armbruster wrote: [...] >>> +++ b/qapi/introspect.json >> >>> +{ 'struct': 'SchemaInfoObject', >>> + 'data': { 'members': [ 'SchemaInfoObjectMember' ], >>> +'*tag': 'str', >>> +'*variants'

Re: [Qemu-devel] [PATCH v3] monitor: allow object_del & device_del to accept QOM paths

2015-09-01 Thread Gonglei
On 2015/9/1 17:50, Daniel P. Berrange wrote: > Currently both object_del and device_del require that the > client provide the object/device short ID. While user > creatable objects require an ID to be provided at time of > creation, qdev devices may be created without giving an > ID. The only uniqu

Re: [Qemu-devel] [PATCH v3] monitor: allow object_del & device_del to accept QOM paths

2015-09-01 Thread Andreas Färber
Am 01.09.2015 um 11:50 schrieb Daniel P. Berrange: > Currently both object_del and device_del require that the > client provide the object/device short ID. While user > creatable objects require an ID to be provided at time of > creation, qdev devices may be created without giving an > ID. The only

Re: [Qemu-devel] [PATCH v3] monitor: allow object_del & device_del to accept QOM paths

2015-09-01 Thread Daniel P. Berrange
On Tue, Sep 01, 2015 at 03:17:29PM +0200, Andreas Färber wrote: > Am 01.09.2015 um 11:50 schrieb Daniel P. Berrange: > > Currently both object_del and device_del require that the > > client provide the object/device short ID. While user > > creatable objects require an ID to be provided at time of

Re: [Qemu-devel] [PATCH v8] hw/arm/virt: Add high MMIO PCI region, 512G in size

2015-09-01 Thread Shannon Zhao
On 2015/8/24 15:31, Pavel Fedin wrote: This large region is necessary for some devices like ivshmem and video cards 32-bit kernels can be built without LPAE support. In this case such a kernel will not be able to use PCI controller which has windows in high addresses. In order to work around th

[Qemu-devel] [Bug 1490886] Re: spice-qemu-char.c Assert

2015-09-01 Thread Cole Robinson
I think this is fixed by: commit f7a8beb5e6a13dc924895244777d9ef08b23b367 Author: Marc-André Lureau Date: Thu May 28 15:04:58 2015 +0200 spice: fix spice_chr_add_watch() pre-condition Since e02bc6de30c44fd668dc0d6e1cd1804f2eed3ed3, add_watch() is called with G_IO_HUP. Even if

Re: [Qemu-devel] [PATCH 0/2] elf+moxie: EM_MOXIE defintition

2015-09-01 Thread Richard Henderson
On 08/29/2015 12:40 PM, Peter Crosthwaite wrote: Hi Richard, This adds EM_MOXIE as suggested. Patch one does some surrounding code style cleanup and P2 fixes Moxie. Regards, Peter Peter Crosthwaite (2): elf_ops: Fix coding style for EM alias case statement elf: Update EM_MOXIE definition

[Qemu-devel] [PATCH] ide/atapi: make PIO read requests async

2015-09-01 Thread Peter Lieven
PIO read requests on the ATAPI interface used to be sync blk requests. This has to siginificant drawbacks. First the main loop hangs util an I/O request is completed and secondly if the I/O request does not complete (e.g. due to an unresponsive storage) Qemu hangs completely. Signed-off-by: Peter

Re: [Qemu-devel] [PATCH v2] virtio dataplane: adapt dataplane for virtio Version 1

2015-09-01 Thread Stefan Hajnoczi
On Wed, Aug 26, 2015 at 03:24:42PM +0200, Pierre Morel wrote: > diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c > index 07fd69c..ad86be5 100644 > --- a/hw/virtio/dataplane/vring.c > +++ b/hw/virtio/dataplane/vring.c > @@ -65,24 +65,34 @@ static void vring_unmap(void *buffer,

Re: [Qemu-devel] function to execute qmp commands

2015-09-01 Thread Programmingkid
On Sep 1, 2015, at 2:19 AM, Markus Armbruster wrote: > Programmingkid writes: > >> Is there a function that can execute a qmp command in QEMU? > > Sure you want to do that, and not call the C interface instead? Let me > explain how QMP works: > > * QMP core: receive JSON, parse, find handler

Re: [Qemu-devel] [PATCH v6 1/2] vhost-user: add multi queue support

2015-09-01 Thread Michael S. Tsirkin
On Tue, Sep 01, 2015 at 08:15:15PM +0800, Yuanhan Liu wrote: > On Tue, Sep 01, 2015 at 01:07:11PM +0300, Michael S. Tsirkin wrote: > > On Tue, Sep 01, 2015 at 05:13:50PM +0800, Yuanhan Liu wrote: > > > On Thu, Aug 13, 2015 at 12:18:38PM +0300, Michael S. Tsirkin wrote: > > > > On Wed, Aug 12, 2015

Re: [Qemu-devel] rfc: vhost user enhancements for vm2vm communication

2015-09-01 Thread Jan Kiszka
On 2015-09-01 11:24, Michael S. Tsirkin wrote: > On Tue, Sep 01, 2015 at 11:11:52AM +0200, Jan Kiszka wrote: >> On 2015-09-01 10:01, Michael S. Tsirkin wrote: >>> On Tue, Sep 01, 2015 at 09:35:21AM +0200, Jan Kiszka wrote: Leaving all the implementation and interface details aside, this d

Re: [Qemu-devel] Should we auto-generate IDs?

2015-09-01 Thread Programmingkid
On Sep 1, 2015, at 8:34 AM, Kevin Wolf wrote: > Am 27.08.2015 um 14:32 hat Jeff Cody geschrieben: >> I'm not married to the ID generation scheme I proposed. >> >> What I am trying to do, however, is have a technical discussion on >> generating an ID in a well-formed manner. And hopefully, in

Re: [Qemu-devel] [PATCH 1/1] block: Allow passing BlockdevOptions to blockdev-snapshot-sync

2015-09-01 Thread Alberto Garcia
On Tue 01 Sep 2015 01:31:11 PM CEST, Kevin Wolf wrote: >> > Design question: Would it make sense to instead add a "reference" >> > mode to blockdev-snapshot-sync where you can specify a BDS's >> > node-name instead of snapshot-file to use an existing BDS as the >> > new top layer, ideally an empt

Re: [Qemu-devel] [PATCH] linux-user: remove MAX_ARG_PAGES limit

2015-09-01 Thread Peter Maydell
On 27 August 2015 at 20:35, Stefan Brüns wrote: > Instead of creating a temporary copy for the whole environment and > the arguments, directly copy everything to the target stack. > For this to work, we have to change the order of stack creation and > copying the arguments. > > v2: fixed scratch

Re: [Qemu-devel] rfc: vhost user enhancements for vm2vm communication

2015-09-01 Thread Michael S. Tsirkin
On Tue, Sep 01, 2015 at 04:09:44PM +0200, Jan Kiszka wrote: > On 2015-09-01 11:24, Michael S. Tsirkin wrote: > > On Tue, Sep 01, 2015 at 11:11:52AM +0200, Jan Kiszka wrote: > >> On 2015-09-01 10:01, Michael S. Tsirkin wrote: > >>> On Tue, Sep 01, 2015 at 09:35:21AM +0200, Jan Kiszka wrote: > L

Re: [Qemu-devel] [PATCH v9 01/10] net: add a new object netfilter

2015-09-01 Thread Stefan Hajnoczi
On Tue, Sep 01, 2015 at 05:06:14PM +0800, Yang Hongyang wrote: > Add the framework for a new netfilter object and a new > -netfilter CLI option as a basis for the following patches. > Note that the new added document in qemu-options.hx indicate that > there's a buffer filter. This type of filter wi

Re: [Qemu-devel] [PATCH v9 03/10] netfilter: add netfilter_{add|del} commands

2015-09-01 Thread Stefan Hajnoczi
On Tue, Sep 01, 2015 at 05:06:16PM +0800, Yang Hongyang wrote: > add netfilter_{add|del} commands > This is mostly the same with netdev_{add|del} commands. The QOM equivalent here is object-add/object-del. > When we delete the netdev, we also delete the netfilter object > attached to it, because

Re: [Qemu-devel] [PATCH 1/1] block: Allow passing BlockdevOptions to blockdev-snapshot-sync

2015-09-01 Thread Kevin Wolf
Am 01.09.2015 um 16:22 hat Alberto Garcia geschrieben: > On Tue 01 Sep 2015 01:31:11 PM CEST, Kevin Wolf wrote: > > >> > Design question: Would it make sense to instead add a "reference" > >> > mode to blockdev-snapshot-sync where you can specify a BDS's > >> > node-name instead of snapshot-file

Re: [Qemu-devel] [PATCH v9 05/10] move out net queue structs define

2015-09-01 Thread Stefan Hajnoczi
On Tue, Sep 01, 2015 at 05:06:18PM +0800, Yang Hongyang wrote: > This will be used by the next patch in this series. > > Signed-off-by: Yang Hongyang > Reviewed-by: Thomas Huth > --- > include/net/queue.h | 19 +++ > net/queue.c | 19 --- > 2 files change

Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface

2015-09-01 Thread Jason J. Herne
On 08/01/2015 05:40 AM, Paolo Bonzini wrote: On 31/07/2015 20:11, Jason J. Herne wrote: Doh! Yep :). This problem is an artifact of moving the timer_mod from cpu_throttle_thread into cpu_throttle_timer_tick. I'll have to go back to the review comments and look at why that was done. So, we

Re: [Qemu-devel] Should we auto-generate IDs?

2015-09-01 Thread Kevin Wolf
Am 01.09.2015 um 16:18 hat Programmingkid geschrieben: > > On Sep 1, 2015, at 8:34 AM, Kevin Wolf wrote: > > > Am 27.08.2015 um 14:32 hat Jeff Cody geschrieben: > >> I'm not married to the ID generation scheme I proposed. > >> > >> What I am trying to do, however, is have a technical discussio

[Qemu-devel] [PATCH v5 4/5] qmp/hmp: Add throttle ratio to query-migrate and info migrate

2015-09-01 Thread Jason J. Herne
Report throttle percentage in info migrate and query-migrate responses when cpu throttling is active. Signed-off-by: Jason J. Herne Reviewed-by: Dr. David Alan Gilbert --- hmp.c | 5 + migration/migration.c | 5 + qapi-schema.json | 7 ++- 3 files changed, 16 in

[Qemu-devel] [PATCH v5 5/5] migration: Disambiguate MAX_THROTTLE

2015-09-01 Thread Jason J. Herne
Migration has a define for MAX_THROTTLE. Update comment to clarify that this is used for throttling transfer speed. Hopefully this will prevent it from being confused with a guest cpu throttling entity. Signed-off-by: Jason J. Herne Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c

[Qemu-devel] [PATCH v5 0/5] migration: Dynamic cpu throttling for auto-converge

2015-09-01 Thread Jason J. Herne
This patch set provides a new method for throttling a vcpu and makes use of said method to dynamically increase cpu throttling during an autoconverge migration until the migration completes. This work is related to the following discussion: https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg

[Qemu-devel] [PATCH v5 2/5] migration: Parameters for auto-converge cpu throttling

2015-09-01 Thread Jason J. Herne
Add migration parameters to allow the user to adjust the parameters that control cpu throttling when auto-converge is in effect. The added parameters are as follows: x-cpu-throttle-initial : Initial percantage of time guest cpus are throttled when migration auto-converge is activated. x-cpu-throt

[Qemu-devel] [PATCH v5 3/5] migration: Dynamic cpu throttling for auto-converge

2015-09-01 Thread Jason J. Herne
Remove traditional auto-converge static 30ms throttling code and replace it with a dynamic throttling algorithm. Additionally, be more aggressive when deciding when to start throttling. Previously we waited until four unproductive memory passes. Now we begin throttling after only two unproductive

Re: [Qemu-devel] [PATCH v3 5/8] s390x: Dump-skeys hmp support

2015-09-01 Thread Cornelia Huck
On Mon, 31 Aug 2015 14:57:51 -0400 "Jason J. Herne" wrote: > On 08/31/2015 12:30 PM, Eric Blake wrote: > > On 08/31/2015 05:00 AM, Cornelia Huck wrote: > >> From: "Jason J. Herne" > >> > >> Add dump-skeys command to the human monitor. > >> > >> Reviewed-by: Thomas Huth > >> Reviewed-by: David H

[Qemu-devel] [PATCH v5 1/5] cpu: Provide vcpu throttling interface

2015-09-01 Thread Jason J. Herne
Provide a method to throttle guest cpu execution. CPUState is augmented with timeout controls and throttle start/stop functions. To throttle the guest cpu the caller simply has to call the throttle set function and provide a percentage of throttle time. Signed-off-by: Jason J. Herne Reviewed-by:

Re: [Qemu-devel] [PATCH v5 9/9] ui: convert VNC server to use QCryptoTLSSession

2015-09-01 Thread Eric Blake
On 08/26/2015 09:05 AM, Daniel P. Berrange wrote: > Switch VNC server over to using the QCryptoTLSSession object > for the TLS session. This removes the direct use of gnutls > from the VNC server code. It also removes most knowledge > about TLS certificate handling from the VNC server code. > This

Re: [Qemu-devel] [PATCH v4 13/13] qga: start a man page

2015-09-01 Thread Eric Blake
On 08/31/2015 05:28 PM, Michael Roth wrote: >> Overall, fairly clean. > > Thanks for the review. Since these are grammatical fixes I've gone ahead and > squashed these changes in, the only exception being suggestions regarding > 'path' (the POSIX interpretation seems to make much more sense than

[Qemu-devel] [PATCH v4 2/2] rtl8139: Do not consume the packet during overflow in standard mode.

2015-09-01 Thread Vladislav Yasevich
When operation in standard mode, we currently return the size of packet during buffer overflow. This consumes the overflow packet. Return 0 instead so we can re-process the overflow packet when we have room. This fixes issues with lost/dropped fragments of large messages. Signed-off-by: Vladisl

[Qemu-devel] [PATCH v4 0/2] rtl8139: Fix buffer overflow in standard mode

2015-09-01 Thread Vladislav Yasevich
When rtl8139 card is running in standard mode, it is very easy to overlflow and the receive buffer and get into a siutation where all packets are dropped. Simply reproduction case is to ping the guest from the host with 6500 byte packets. There are actually 2 problems here. 1) When the rtl8129

[Qemu-devel] [PATCH v4 1/2] rtl8139: Fix receive buffer overflow check

2015-09-01 Thread Vladislav Yasevich
rtl8139_do_receive() tries to check for the overflow condition by making sure that packet_size + 8 does not exceed the available buffer space. The issue here is that RxBuffAddr, used to calculate available buffer space, is aligned to a a 4 byte boundry after every update. So it is possible that e

  1   2   3   4   >