Re: [Qemu-devel] [PATCH 5/7] memory: Allow replay of IOMMU mapping notifications

2015-09-25 Thread David Gibson
On Fri, Sep 25, 2015 at 02:04:14PM +0200, Paolo Bonzini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > > > On 25/09/2015 13:33, David Gibson wrote: > > 1) Is there a case where using the no-replay functions makes > > sense? > > > > I'm not sure. I think vfio is the only user so

[Qemu-devel] [PATCH v4 0/1] intel_iommu: Add support for translation for devices behind bridges

2015-09-25 Thread Knut Omang
This patch set has been completely reimplemented according to ideas from the discussion of v2. It still solves the same problem, but does so only within the Intel IOMMU code and Q35, without changing the IOMMU interface. This eliminates the need for any separate interface change patch. This is t

[Qemu-devel] [PATCH v4 1/1] intel_iommu: Add support for translation for devices behind bridges

2015-09-25 Thread Knut Omang
- Use a hash table indexed on bus pointers to store information about buses instead of using the bus numbers. Bus pointers are stored in a new VTDBus struct together with the vector of device address space pointers indexed by devfn. - The bus number is still used for lookup for selective SID

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add real CDROM menu item

2015-09-25 Thread Namsun Ch'o
> Add a menu item to the Machine menu called "Use Real CDROM". It gives the > user the ability to use a real CDROM with QEMU by simply selecting a menu > item. > NSASCIIStringEncoding]; > +qmp_change_blockdev(device, "/dev/cdrom", "raw", &err); > +handleAnyDeviceErrors(err); Not all syste

Re: [Qemu-devel] [PATCH v2] Add argument filters to the seccomp sandbox

2015-09-25 Thread Namsun Ch'o
> I've suggested this in the past but to my knowledge no has done any work in > this direction, including myself. Despite the lack of progress, I still > think this is a very worthwhile idea. Which is exactly why I think a configuration file would be the best option instead of --enable-syscalls=fo

[Qemu-devel] [PATCH] tilegx: Generate ill related instructions according to Linux kernel

2015-09-25 Thread gang . chen . 5i5j
From: Chen Gang At present, tilegx qemu will abort for "setup_frame: not implemented", when meet raise instruction. Signed-off-by: Chen Gang --- linux-user/main.c | 14 target-tilegx/cpu.h | 3 ++ target-tilegx/translate.c | 89 +++---

Re: [Qemu-devel] [PATCH v3 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-25 Thread Prasanna Kalever
> On Tue, Sep 22, 2015 at 04:06:54 -0400, Prasanna Kalever wrote: > > > > > On 09/21/2015 05:24 AM, Prasanna Kumar Kalever wrote: > > > > This patch adds a way to specify multiple backup volfile servers to the > > > > gluster > > > > block backend of QEMU with tcp|rdma transport types and their po

[Qemu-devel] [PATCH] linux-user/syscall_defs.h: Sync the latest si_code from Linux kernel

2015-09-25 Thread gang . chen . 5i5j
From: Chen Gang They content several new macro members, also contents TARGET_N*. Signed-off-by: Chen Gang --- linux-user/syscall_defs.h | 44 ++-- 1 file changed, 30 insertions(+), 14 deletions(-) diff --git a/linux-user/syscall_defs.h b/linux-user/sysc

[Qemu-devel] [PATCH] ui/cocoa.m: Add real CDROM menu item

2015-09-25 Thread Programmingkid
Add a menu item to the Machine menu called "Use Real CDROM". It gives the user the ability to use a real CDROM disc with QEMU by simply selecting a menu item. Signed-off-by: John Arbuckle --- ui/cocoa.m | 87 1 files changed, 87 ins

Re: [Qemu-devel] [PATCH] No FreeWriterMetadata() after GatherWriterMetadata() in requester.cpp

2015-09-25 Thread Guangmu Zhu
Correct patch format. Signed-off-by: Guangmu Zhu --- qga/vss-win32/requester.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 9b3e310..337f722 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/reques

Re: [Qemu-devel] [PATCH] handle_aiocb_rw() can't distinguish between an error and 0 bytes transferred

2015-09-25 Thread Guangmu Zhu
Correct patch format. Signed-off-by: Guangmu Zhu --- block/raw-win32.c | 48 ++-- 1 file changed, 30 insertions(+), 18 deletions(-) diff --git a/block/raw-win32.c b/block/raw-win32.c index 68f2338..569dda2 100644 --- a/block/raw-win32.c +++ b/block/

[Qemu-devel] [PATCH] No FreeWriterMetadata() after GatherWriterMetadata() in requester.cpp

2015-09-25 Thread Guangmu Zhu
FreeWriterMetadata() should be called if GatherWriterMetadata() succeeded. diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 9b3e310..337f722 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -47,6 +47,7 @@ static struct QGAVSSContext {

[Qemu-devel] [PATCH] target-tilegx: Let x1 pipe process bpt instruction only

2015-09-25 Thread gang . chen . 5i5j
From: Chen Gang According to the related document, bpt can be only in x1 pipe. Signed-off-by: Chen Gang --- target-tilegx/translate.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index a9fc4ce..6622aeb 100644 -

[Qemu-devel] [PATCH] handle_aiocb_rw() can't distinguish between an error and 0 bytes transferred

2015-09-25 Thread Guangmu Zhu
The handle_aiocb_rw() can't distinguish between an error and 0 bytes transferred. diff --git a/block/raw-win32.c b/block/raw-win32.c index 68f2338..569dda2 100644 --- a/block/raw-win32.c +++ b/block/raw-win32.c @@ -60,11 +60,13 @@ typedef struct BDRVRawState { * Returns the number of bytes han

Re: [Qemu-devel] [PATCH v3 20/25] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-25 Thread Richard Henderson
On 09/25/2015 02:10 PM, Aurelien Jarno wrote: >> +if (more) >> + byte |= 0x80; > > You are missing braces here. Gah. I thought I fixed that... > Given we save both the host and the guest PC in this structure, one > obvious optimization would be to skip saving data for host inst

[Qemu-devel] [Bug 1469342] Re: qemu-i386 pentium3/athlon incorrect instruction set

2015-09-25 Thread PeteVine
I think I may have found the culprit - athlon is defined as 'PPRO_FEATURES + some additional features'. If PPRO_FEATURES is what I think it is (pentium pro) why does it have SSE and SSE2 defined? It should end with MMX. -- You received this bug notification because you are a member of qemu- dev

Re: [Qemu-devel] [PATCH v5 05/46] qapi: Test use of 'number' within alternates

2015-09-25 Thread Eric Blake
On 09/24/2015 10:29 AM, Markus Armbruster wrote: >>> Any particular reason for adding the initializer? >>> v = visitor_input_test_init(data, "42"); -visit_type_UserDefAlternate(v, &tmp, NULL, &err); -g_assert(err == NULL); +visit_type_UserDefAlternate

[Qemu-devel] [Bug 1499908] [NEW] hda sound capture broken with VNC

2015-09-25 Thread Francois Gouget
Public bug reported: QEmu is being used to run the Wine conformance tests in Windows virtual machines. Wine's conformance tests check the behavior of various Windows APIs and verify that they behave as expected. One of the tests checks the behavior of the mmdevapi sound capture APIs. This test wor

[Qemu-devel] [PATCH] ui/cocoa.m: addRemovableDevicesMenuItems() warning fix

2015-09-25 Thread Programmingkid
Eliminate this warning associated with the addRemovableDevicesMenuItems() function: ui/cocoa.m:1344:13: warning: function declaration isn't a prototype [-Wstrict-prototypes] static void addRemovableDevicesMenuItems() ^ ui/cocoa.m: In function 'addRemovableDevicesMenuItems': ui/cocoa.

[Qemu-devel] [PATCH] ui/cocoa.m: eliminate normalWindow warning

2015-09-25 Thread Programmingkid
Eliminate this warning associated with the setting of the normalWindow's title: ui/cocoa.m: In function '-[QemuCocoaAppController init]': ui/cocoa.m:888:9: warning: format not a string literal and no format arguments [-Wformat-security] [normalWindow setTitle:[NSString stringWithFormat:@

Re: [Qemu-devel] [PATCH v5 05/46] qapi: Test use of 'number' within alternates

2015-09-25 Thread Eric Blake
On 09/24/2015 10:29 AM, Markus Armbruster wrote: + +/* FIXME: Order of alternate should not affect semantics */ >>> >>> Inhowfar does it affect semantics? Or asked differently: what exactly >>> is wrong with this test now? >>> +v = visitor_input_test_init(data, "42");

[Qemu-devel] [Bug 902413] Re: qemu-i386-user on ARM host: wine hangs/spins when trying to run anything

2015-09-25 Thread Peter Maydell
We're actively working on improving QEMU's support for multithreaded guest programs in linux-user, but those changes are not yet complete. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/902413 Title:

[Qemu-devel] [Bug 902413] Re: qemu-i386-user on ARM host: wine hangs/spins when trying to run anything

2015-09-25 Thread Nathan Shearer
I just tried running x86 windows program, on x86 wine, on qemu-i386, all on an arm host. I am also experiencing a hung wine and wineserver. Was this bug ever fixed? ** Also affects: wine (Gentoo Linux) Importance: Undecided Status: New -- You received this bug notification because you

[Qemu-devel] [PULL 1/3] ui/cocoa.m: verify with user before quitting QEMU

2015-09-25 Thread Peter Maydell
From: John Arbuckle This patch prevents the user from accidentally quitting QEMU by pushing Command-Q or by pushing the close button on the main window. When the user does one of these two things, a dialog box appears verifying with the user if he or she wants to quit QEMU. Signed-off-by: John A

[Qemu-devel] [PULL 0/3] cocoa queue

2015-09-25 Thread Peter Maydell
e/pmaydell/qemu-arm.git tags/pull-cocoa-20150925-1 for you to fetch changes up to 365d7f3c7aacc789ead96b8eeb5ba5b0a8d93d48: ui/cocoa.m: remove open dialog code (2015-09-25 23:14:00 +0100) cocoa queue: * fix stuck-key bug if keys

[Qemu-devel] [PULL 2/3] ui/cocoa.m: prevent stuck key situation

2015-09-25 Thread Peter Maydell
From: John Arbuckle When the user puts QEMU in the background while holding down a key, QEMU will not receive the keyup event when the user lets go of the key. When the user goes back to QEMU, QEMU will think the key is still down causing stuck key symptoms. This patch fixes this problem by relea

[Qemu-devel] [PULL 3/3] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Peter Maydell
From: John Arbuckle Removes the open dialog code that runs when no arguments are supplied with QEMU. Not everyone needs a hard drive or cdrom to boot their target. A user might only need to use their target's bios to do work. With that said, this patch removes the unneeded open dialog code. Sign

Re: [Qemu-devel] [PULL v2 00/52] Misc changes for 2015-09-25

2015-09-25 Thread Peter Maydell
On 25 September 2015 at 09:51, Paolo Bonzini wrote: > The following changes since commit 8a47d575dfac0f6675e2ac56c5921cc520d021a6: > > Merge remote-tracking branch 'remotes/weil/tags/pull-wxx-20150924' into > staging (2015-09-24 22:09:41 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Programmingkid
On Sep 25, 2015, at 6:00 PM, Peter Maydell wrote: > On 25 September 2015 at 14:00, Programmingkid > wrote: >> Removes the open dialog code that runs when no arguments are supplied with >> QEMU. >> Not everyone needs a hard drive or cdrom to boot their target. A user might >> only >> need to u

Re: [Qemu-devel] [PATCH] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Peter Maydell
On 25 September 2015 at 14:00, Programmingkid wrote: > Removes the open dialog code that runs when no arguments are supplied with > QEMU. > Not everyone needs a hard drive or cdrom to boot their target. A user might > only > need to use their target's bios to do work. With that said, this patch

Re: [Qemu-devel] [PATCH] target-arm: Add missing 'static' attribute

2015-09-25 Thread Peter Maydell
On 25 September 2015 at 13:42, Stefan Weil wrote: > Signed-off-by: Stefan Weil > --- > target-arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index 8367997..584f6df 100644 > --- a/target-arm/helper.c > +++ b/target

Re: [Qemu-devel] [PATCH] hw/arm/digic: Fix memory leak reported by Coverity

2015-09-25 Thread Peter Maydell
On 25 September 2015 at 12:55, Stefan Weil wrote: > Am 14.03.2015 um 11:19 schrieb Stefan Weil: >> Signed-off-by: Stefan Weil >> --- >> hw/arm/digic_boards.c |1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c >> index 7114c36..ad70f7b 100

Re: [Qemu-devel] [PATCH 2/3] Hw: timer: Remove unnecessary variable

2015-09-25 Thread Peter Maydell
On 25 September 2015 at 01:37, Shraddha Barke wrote: > Compress lines and remove the variable ret. > > Change made using Coccinelle script > diff --git a/hw/timer/tusb6010.c b/hw/timer/tusb6010.c > index 459c748..ba01050 100644 > --- a/hw/timer/tusb6010.c > +++ b/hw/timer/tusb6010.c > @@ -321,7 +

[Qemu-devel] [PATCH 1/2] Hw: char: Remove unnecessary variable

2015-09-25 Thread Shraddha Barke
Compress lines and remove the variable. Change made using Coccinelle script @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by: Shra

[Qemu-devel] [PATCH 3/3] Target-ppc: Remove unnecessary variable

2015-09-25 Thread Shraddha Barke
Compress lines and remove the variable. Change made using Coccinelle script @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by: Shra

[Qemu-devel] [PATCH 2/3] Hw: timer: Remove unnecessary variable

2015-09-25 Thread Shraddha Barke
Compress lines and remove the variable ret. Change made using Coccinelle script @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by:

Re: [Qemu-devel] [PATCH] Makefile: fix build when VPATH is outside GIT tree

2015-09-25 Thread Steve Ellcey
On Fri, 2015-09-18 at 13:40 +0200, Paolo Bonzini wrote: > > The problem is due to the fact that some sub directory deps > > were listed against SOFTMMU_SUBDIR_RULES instead of SUBDIR_RULES, > > so were only processed for system emulators, not user emalutors. > > > > Signed-off-by: Daniel P. Berra

[Qemu-devel] [PATCH 1/3] Target-microblaze: Remove unnecessary variable

2015-09-25 Thread Shraddha Barke
Compress lines and remove the variable . Change made using Coccinelle script @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by: Shr

[Qemu-devel] [PATCH 2/2] Hw: timer: Remove unnecessary variable

2015-09-25 Thread Shraddha Barke
Compress lines and remove the variable. Change made using Coccinelle script @@ expression ret; @@ - if (ret) return ret; - return 0; + return ret; @@ local idexpression ret; expression e; @@ - ret = e; - return ret; + return e; @@ type T; identifier i; @@ - T i; ... when != i Signed-off-by: Shra

Re: [Qemu-devel] [PATCH v3 21/25] tcg: Remove gen_intermediate_code_pc

2015-09-25 Thread Aurelien Jarno
On 2015-09-22 13:25, Richard Henderson wrote: > It is no longer used, so tidy up everything reached by it. > This includes the gen_opc_* arrays, the search_pc parameter > and the inline gen_intermediate_code_internal functions. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson >

Re: [Qemu-devel] [PATCH v3 22/25] tcg: Remove tcg_gen_code_search_pc

2015-09-25 Thread Aurelien Jarno
On 2015-09-22 13:25, Richard Henderson wrote: > It's no longer used, so tidy up everything reached by it. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 59 +++ > tcg/tcg.h | 2 -- > 2 files changed,

Re: [Qemu-devel] [PATCH v3 20/25] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-25 Thread Aurelien Jarno
On 2015-09-22 13:25, Richard Henderson wrote: > We can now restore state without retranslation. > > Signed-off-by: Richard Henderson > --- > include/exec/exec-all.h | 1 + > tcg/tcg.c | 40 - > tcg/tcg.h | 4 +- > translate-all.c | 149 >

[Qemu-devel] [PATCH] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Programmingkid
Removes the open dialog code that runs when no arguments are supplied with QEMU. Not everyone needs a hard drive or cdrom to boot their target. A user might only need to use their target's bios to do work. With that said, this patch removes the unneeded open dialog code. Signed-off-by: John Arbuc

Re: [Qemu-devel] [PULL 0/1] VFIO - fix glib 2.22 compat

2015-09-25 Thread Peter Maydell
On 25 September 2015 at 10:06, Alex Williamson wrote: > Hi Peter, > > I'll likely have another pull next week, but I don't want to sit on > this trivial fix for glib 2.22 compatability. Thanks, > > Alex > > The following changes since commit fefa4b128de06cec6d513f00ee61e8208aed4a87: > > Merge r

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Peter Maydell
On 25 September 2015 at 13:38, Programmingkid wrote: > > On Sep 25, 2015, at 4:14 PM, Peter Maydell wrote: >> Yes, but I was hoping for it in a format that works with >> our patch-handling tools... > > What needs to be changed to make it work with the patch-handling tools? Single email, plain-tex

[Qemu-devel] [PATCH] disas/cris: Fix typo in comment

2015-09-25 Thread Stefan Weil
Signed-off-by: Stefan Weil --- disas/cris.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/cris.c b/disas/cris.c index 1b76a09..4482a41 100644 --- a/disas/cris.c +++ b/disas/cris.c @@ -2492,7 +2492,7 @@ print_with_operands (const struct cris_opcode *opcodep, =

[Qemu-devel] [PATCH] target-arm: Add missing 'static' attribute

2015-09-25 Thread Stefan Weil
Signed-off-by: Stefan Weil --- target-arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 8367997..584f6df 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -5194,7 +5194,7 @@ void switch_mode(CPUARMState *en

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Programmingkid
On Sep 25, 2015, at 4:14 PM, Peter Maydell wrote: > On 25 September 2015 at 12:58, Programmingkid > wrote: >> >> On Sep 25, 2015, at 2:53 PM, Peter Maydell wrote: >> >>> On 25 September 2015 at 11:24, Programmingkid >>> wrote: >>> I don't think Mac OS X adds the -psn argument anymore.

[Qemu-devel] [PATCH] MAINTAINERS: Add NSIS file for W32, W64 hosts

2015-09-25 Thread Stefan Weil
The NSIS installer configuration is maintained by me. Signed-off-by: Stefan Weil --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7aff162..1ed349d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -262,6 +262,7 @@ L: qemu-devel@nongnu.org M: Stefan

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Peter Maydell
On 25 September 2015 at 12:58, Programmingkid wrote: > > On Sep 25, 2015, at 2:53 PM, Peter Maydell wrote: > >> On 25 September 2015 at 11:24, Programmingkid >> wrote: >> >>> I don't think Mac OS X adds the -psn argument anymore. It might have >>> in the past, but I don't see any sign of it on M

[Qemu-devel] [PATCH] trace/simple: Fix warning and wrong trace file name for MinGW

2015-09-25 Thread Stefan Weil
On Windows, getpid() always returns an int value, but pid_t (which is expected by the format string) is either a 32 bit or a 64 bit value. Without a type cast (or a modified format string), the compiler prints a warning when building for 64 bit Windows and the resulting trace_file_name will includ

Re: [Qemu-devel] [PATCH] linux-user: Remove type casts to union type

2015-09-25 Thread Stefan Weil
Am 10.02.2015 um 20:51 schrieb Michael Tokarev: > 08.02.2015 17:40, Stefan Weil wrote: >> Casting to a union type is a gcc (and clang) extension. Other compilers >> might not support it. This is not a problem today, but the type casts >> can be removed easily. Smatch now no longer complains like be

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Programmingkid
On Sep 25, 2015, at 2:53 PM, Peter Maydell wrote: > On 25 September 2015 at 11:24, Programmingkid > wrote: > >> I don't think Mac OS X adds the -psn argument anymore. It might have >> in the past, but I don't see any sign of it on Mac OS 10.6. I made >> a test program and launched it from both

Re: [Qemu-devel] [PATCH] hw/arm/digic: Fix memory leak reported by Coverity

2015-09-25 Thread Stefan Weil
Am 14.03.2015 um 11:19 schrieb Stefan Weil: > Signed-off-by: Stefan Weil > --- > hw/arm/digic_boards.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c > index 7114c36..ad70f7b 100644 > --- a/hw/arm/digic_boards.c > +++ b/hw/arm/digic_boar

Re: [Qemu-devel] [PATCH] slirp: Fix type casts and format strings in debug code

2015-09-25 Thread Stefan Weil
Am 29.08.2015 um 09:12 schrieb Stefan Weil: > Casting pointers to long won't work on 64 bit Windows. > It is not needed with the right format strings. > > Signed-off-by: Stefan Weil > --- > slirp/bootp.c | 12 +--- > slirp/if.c | 4 ++-- > slirp/ip_icmp.c| 4 ++-- > sl

Re: [Qemu-devel] [RFC 6/6] docs: Document QMP event rate limiting

2015-09-25 Thread Eric Blake
On 09/25/2015 08:00 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > docs/qmp/qmp-events.txt | 12 > docs/qmp/qmp-spec.txt | 5 + > 2 files changed, 17 insertions(+) Obvious rebase implied if your other patch to s,docs/qmp/,docs/, goes through. > > di

Re: [Qemu-devel] [PATCH] iotests: Fix test 128 for password-less sudo

2015-09-25 Thread Eric Blake
On 09/25/2015 11:19 AM, Max Reitz wrote: > As of 934659c460d46c948cf348822fda1d38556ed9a4, $QEMU_IO is generally no > longer a program name, and therefore "sudo -n $QEMU_IO" will no longer > work. > > Fix this by copying the qemu-io invocation function from common.config, > making it use $sudo for

Re: [Qemu-devel] [RFC 5/6] monitor: Throttle event VSERPORT_CHANGE separately by "id"

2015-09-25 Thread Eric Blake
On 09/25/2015 08:00 AM, Markus Armbruster wrote: > VSERPORT_CHANGE is emitted when the guest opens or closes a > virtio-serial port. The event's member "id" identifies the port. > > When several events arrive quickly, throttling drops all but the last > of them. Because of that, a QMP client mus

Re: [Qemu-devel] ide-test fails on PPC64 big-endian host

2015-09-25 Thread John Snow
On 09/25/2015 03:20 PM, Peter Maydell wrote: > Hi. I was looking at adding ppc64be to the set of machines I do build > tests on before merging patches, but right now "make check" fails on > this host. > > ERROR:/home/pm215/qemu/tests/ide-test.c:721:cdrom_pio_impl: assertion > failed ((data) & (D

Re: [Qemu-devel] [RFC 4/6] monitor: Turn monitor_qapi_event_state[] into a hash table

2015-09-25 Thread Eric Blake
On 09/25/2015 08:00 AM, Markus Armbruster wrote: > In preparation of finer grained throttling. > > Signed-off-by: Markus Armbruster > --- > monitor.c | 55 ++- > 1 file changed, 38 insertions(+), 17 deletions(-) > > @@ -512,6 +518,14 @@ monit

Re: [Qemu-devel] [PULL 0/7] Block patches

2015-09-25 Thread Peter Maydell
On 25 September 2015 at 08:50, Jeff Cody wrote: > The following changes since commit eb9d0ea063fc7bdfab76b84085602a9e48d13ec7: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20150924' into staging (2015-09-24 > 01:32:11 +0100) > > are available in the git repository

[Qemu-devel] ide-test fails on PPC64 big-endian host

2015-09-25 Thread Peter Maydell
Hi. I was looking at adding ppc64be to the set of machines I do build tests on before merging patches, but right now "make check" fails on this host. ERROR:/home/pm215/qemu/tests/ide-test.c:721:cdrom_pio_impl: assertion failed ((data) & (DRQ | DRDY) == (DRQ | DRDY)): (0x0040 == 0x0048) GTe

Re: [Qemu-devel] [RFC 3/6] monitor: Split MonitorQAPIEventConf off MonitorQAPIEventState

2015-09-25 Thread Eric Blake
On 09/25/2015 08:00 AM, Markus Armbruster wrote: > In preparation of turning monitor_qapi_event_state[] into a hash table > for finer grained throttling. > > Signed-off-by: Markus Armbruster > --- > monitor.c | 79 > ++- > 1 file chang

Re: [Qemu-devel] [PATCH v5 09/46] qapi: Use consistent generated code patterns

2015-09-25 Thread Eric Blake
On 09/25/2015 10:54 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We had some pointless differences in the generated code for visit, >> command marshalling, and events; unifying them makes it easier for >> future patches to consolidate to common helper functions. >> - Consistently name t

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Peter Maydell
On 25 September 2015 at 11:24, Programmingkid wrote: > I don't think Mac OS X adds the -psn argument anymore. It might have > in the past, but I don't see any sign of it on Mac OS 10.6. I made > a test program and launched it from both the terminal and the Finder. > I didn't see the -psn argument

[Qemu-devel] [PATCH V2] vnc: destroy server surface if no client is connected

2015-09-25 Thread Peter Lieven
if no client is connected there is no need to keep the server surface. Throw it away to save memory. Signed-off-by: Peter Lieven --- v1->v2: don't create a dummy surface just set vd->server = NULL [Gerd] ui/vnc.c | 38 +- 1 file changed, 33 insertions(+), 5 d

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Programmingkid
On Sep 25, 2015, at 12:21 PM, Peter Maydell wrote: > On 25 September 2015 at 09:12, Programmingkid > wrote: >> >> On Sep 25, 2015, at 12:09 PM, Peter Maydell wrote: >>> (Also, isn't a simple test on gArgc going to cause us to put up >>> the dialog box even if qemu was started from the command

Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices

2015-09-25 Thread Thomas Huth
On 25/09/15 16:17, Markus Armbruster wrote: > Thomas Huth writes: > >> On 24/09/15 20:57, Markus Armbruster wrote: >>> Several devices don't survive object_unref(object_new(T)): they crash >>> or hang during cleanup, or they leave dangling pointers behind. >>> >>> This breaks at least device-list

[Qemu-devel] [PATCH v3] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Programmingkid
Removes the open dialog code that runs when no arguments are supplied with QEMU. Not everyone needs a hard drive or cdrom to boot their target. A user might only need to use their target's bios to do work. With that said, this patch removes the unneeded open dialog code. Signed-off-by: John Arbuck

Re: [Qemu-devel] [PULL 0/9] muldiv64 queue

2015-09-25 Thread Peter Maydell
ble in the git repository at: > > g...@github.com:vivier/qemu.git tags/pull-muldiv64-20150925 > > for you to fetch changes up to ab60b7485cece312ad9c21327ee678f0f9898fb5: > > net: remove muldiv64() (2015-09-25 14:56:38 +0200) > >

[Qemu-devel] [PATCH] iotests: Fix test 128 for password-less sudo

2015-09-25 Thread Max Reitz
As of 934659c460d46c948cf348822fda1d38556ed9a4, $QEMU_IO is generally no longer a program name, and therefore "sudo -n $QEMU_IO" will no longer work. Fix this by copying the qemu-io invocation function from common.config, making it use $sudo for invoking $QEMU_IO_PROG, and then use that function i

[Qemu-devel] [PULL 0/1] VFIO - fix glib 2.22 compat

2015-09-25 Thread Alex Williamson
Hi Peter, I'll likely have another pull next week, but I don't want to sit on this trivial fix for glib 2.22 compatability. Thanks, Alex The following changes since commit fefa4b128de06cec6d513f00ee61e8208aed4a87: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20150923.0' i

[Qemu-devel] [PULL 1/1] vfio/pci: Remove use of g_malloc0_n() from quirks

2015-09-25 Thread Alex Williamson
For compatibility with glib 2.22. Reported-by: Wen Congyang Signed-off-by: Alex Williamson --- hw/vfio/pci-quirks.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c index 2bdaef1..c675d1b 100644 --- a/hw/vfio/pci-

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: Add Mount image file menu item

2015-09-25 Thread Programmingkid
On Sep 25, 2015, at 11:42 AM, Markus Armbruster wrote: > Programmingkid writes: > >> On Sep 24, 2015, at 2:57 AM, Markus Armbruster wrote: >> >>> Programmingkid writes: >>> On Sep 23, 2015, at 4:35 PM, Peter Maydell wrote: > On 17 September 2015 at 21:17, Programmingkid >

Re: [Qemu-devel] [PATCH v2] Add argument filters to the seccomp sandbox

2015-09-25 Thread Paul Moore
On Friday, September 25, 2015 12:53:04 AM Namsun Ch'o wrote: > Another idea which would fit in with the security model is to have a dynamic > sandbox which enables syscalls and syscall filters based on what command > line or config parameters are passed to QEMU on its first start. I've suggested t

Re: [Qemu-devel] [PATCH v5 09/46] qapi: Use consistent generated code patterns

2015-09-25 Thread Markus Armbruster
Eric Blake writes: > We had some pointless differences in the generated code for visit, > command marshalling, and events; unifying them makes it easier for > future patches to consolidate to common helper functions. > - Consistently name the error variable 'err' Before the patch, qapi-event.py

Re: [Qemu-devel] [PATCH 00/36] post-Eric's fixes, QAPI improvements

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > I have grown a qapi branch during the past 2 months that was > post-poned for review until the introspection and other fixes got > merged or ready. For other reviewer's convenience, it looks like th

[Qemu-devel] [PATCH V7 2/2] sdhci: Split sdhci.h for public and internal device usage

2015-09-25 Thread Sai Pavan Boddu
Split sdhci.h into pubilc version (i.e include/hw/sd/sdhci.h) and internal version (i.e hw/sd/sdhci-interna.h) based on register declarations and object declaration. Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- Changes for V7: Fix Commit me

[Qemu-devel] [PATCH V7 0/2] Move sdhci.h to include/hw/sd

2015-09-25 Thread Sai Pavan Boddu
Move sdhci.h splitting it into common and internal. Create a new directory for sd in include/hw/. Correct paths of sd.h in at every instance of #include. Sai Pavan Boddu (2): sd.h: Move sd.h to include/hw/sd/ sdhci: Split sdhci.h for public and internal device usage hw/sd/milkymist-memcard.c

Re: [Qemu-devel] [PULL v3] virtio,pc features, fixes

2015-09-25 Thread Peter Maydell
On 24 September 2015 at 23:41, Michael S. Tsirkin wrote: > Dropped the offending iommu patch. > > The following changes since commit fefa4b128de06cec6d513f00ee61e8208aed4a87: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20150923.0' > into staging (2015-09-23 21:39:46 +010

Re: [Qemu-devel] [PATCH 00/10] target-i386 addressing cleanups

2015-09-25 Thread Peter Maydell
On 23 September 2015 at 21:10, Richard Henderson wrote: > Ping. Just a note that I feel like I've done a lot of tcg related review recently so I'm hoping somebody else can take up the slack with reviewing this set... thanks -- PMM > > On 07/09/2015 12:15 AM, Richard Henderson wrote: >> >> This

[Qemu-devel] [PULL 51/52] docs: describe the QEMU build system structure / design

2015-09-25 Thread Paolo Bonzini
From: "Daniel P. Berrange" Developers who are new to QEMU, or have a background familiarity with GNU autotools, can have trouble getting their head around the home-grown QEMU build system. This document attempts to explain the structure / design of the configure script and the various Makefile pi

[Qemu-devel] [PATCH V7 1/2] sd.h: Move sd.h to include/hw/sd/

2015-09-25 Thread Sai Pavan Boddu
Create a sd directory under include/hw/ and move sd.h to same. Signed-off-by: Sai Pavan Boddu Reviewed-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- Changes for V7: None Changes for V6: Fix commit message. Changes for V5: None Changes for V4: Fix commit message. Change

[Qemu-devel] [PULL 25/52] hmp: added io apic dump state

2015-09-25 Thread Paolo Bonzini
From: Pavel Butsykin Added the hmp command to query io apic state, may be usefull after guest crashes to understand IRQ routing in guest. Implementation is only for kvm here. The dump will look like (qemu) info ioapic ioapic id=0x00 sel=0x26 (redir[11]) pin 0 0x0001 dest=0 vec=0 a

[Qemu-devel] [PULL 50/52] typedef: add typedef for QemuOpts

2015-09-25 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch moves typedefs for QemuOpts and related types to qemu/typedefs.h file. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk Message-Id: <20150917162501.8676.85435.st...@pasha-isp.def.inno> Signed-off-by: Paolo Bonzini --- include/qemu/option.h | 5 +--

[Qemu-devel] [PULL 48/52] i386: partial revert of interrupt poll fix

2015-09-25 Thread Paolo Bonzini
From: Pavel Dovgalyuk Processing CPU_INTERRUPT_POLL requests in cpu_has_work functions break the determinism of cpu_exec. This patch is required to make interrupts processing deterministic. Signed-off-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk Message-Id: <20150917162331.8676.15286.st..

[Qemu-devel] [PULL 52/52] doc: Refresh URLs in the qemu-tech documentation

2015-09-25 Thread Paolo Bonzini
From: Thomas Huth The TwoOStwo and Willows page seem to have disappeared completely, and also some of the other links were not pointing to the right locations anymore. Signed-off-by: Thomas Huth Message-Id: <1443173916-8895-1-git-send-email-th...@redhat.com> Signed-off-by: Paolo Bonzini --- q

[Qemu-devel] [PULL v2 00/52] Misc changes for 2015-09-25

2015-09-25 Thread Paolo Bonzini
The following changes since commit 8a47d575dfac0f6675e2ac56c5921cc520d021a6: Merge remote-tracking branch 'remotes/weil/tags/pull-wxx-20150924' into staging (2015-09-24 22:09:41 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fe

[Qemu-devel] [PULL 49/52] i386: interrupt poll processing

2015-09-25 Thread Paolo Bonzini
From: Pavel Dovgalyuk This patch updates x86_cpu_exec_interrupt function. It can process two interrupt request at a time (poll and another one). This makes its execution non-deterministic. Determinism is requred for recorded icount execution. Signed-off-by: Pavel Dovgalyuk Message-Id: <20150917

Re: [Qemu-devel] [PATCH v5 08/46] qapi: Reuse code for flat union base validation

2015-09-25 Thread Markus Armbruster
Eric Blake writes: > Rather than open-code the check for a valid base type, we > should reuse the common functionality. This allows for > consistent error messages, and also makes it easier for a > later patch to turn on support for inline anonymous base > structures. > > Test flat-union-inline i

Re: [Qemu-devel] [PATCH v5 45/46] net: Complete qapi-fication of netdev_add

2015-09-25 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 23/09/2015 18:37, Eric Blake wrote: >>> >>> Is this still type-unsafe like the old netdev_add (e.g. accepts >>> a string for an integer)? > I did not address that yet; it still needs further patches to > accept an integer as a port number. I ca

Re: [Qemu-devel] [RFC 2/6] monitor: Simplify event throttling

2015-09-25 Thread Eric Blake
On 09/25/2015 08:00 AM, Markus Armbruster wrote: > The event throttling state machine is hard to understand. I'm not > sure it's entirely correct. Rewrite it in a more straightforward > manner: > > State 1: No event sent recently (less than evconf->rate ns ago) > > Invariant: evstate->timer

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: prevent stuck key situation

2015-09-25 Thread Peter Maydell
On 23 September 2015 at 18:21, Programmingkid wrote: > When the user puts QEMU in the background while holding > down a key, QEMU will not receive the keyup event when > the user lets go of the key. When the user goes back to > QEMU, QEMU will think the key is still down causing > stuck key sympto

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: verify with user before quitting QEMU

2015-09-25 Thread Peter Maydell
On 23 September 2015 at 17:57, Programmingkid wrote: > This patch prevents the user from accidentally quitting QEMU by pushing > Command-Q or by pushing the close button on the main window. When > the user does one of these two things, a dialog box appears verifying > with the user if he or she wa

Re: [Qemu-devel] [PATCH] s/cpu_get_real_ticks/cpu_get_host_ticks/

2015-09-25 Thread Paolo Bonzini
On 25/09/2015 16:42, Christopher Covington wrote: > This should help clarify the purpose of the function that returns > the host system's CPU cycle count. > > Signed-off-by: Christopher Covington Acked-by: Paolo Bonzini Good idea! Paolo > --- > bsd-user/main.c | 2 +- > cpus.c

Re: [Qemu-devel] [RFC 1/6] monitor: Reduce casting of QAPI event QDict

2015-09-25 Thread Eric Blake
On 09/25/2015 08:00 AM, Markus Armbruster wrote: > Make the variables holding the event QDict instead of QObject. > > Signed-off-by: Markus Armbruster > --- > monitor.c | 38 +++--- > 1 file changed, 19 insertions(+), 19 deletions(-) > > diff --git a/monitor.c b/

Re: [Qemu-devel] [PATCH 08/36] qapi: add qapi2texi script

2015-09-25 Thread Eric Blake
On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > As the name suggests, the qapi2texi script converts JSON QAPI > description into a standalone texi file suitable for different target > formats. > > It parses the following kind of blocks with some little va

Re: [Qemu-devel] [PATCH 00/36] post-Eric's fixes, QAPI improvements

2015-09-25 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Hi, > > I have grown a qapi branch during the past 2 months that was > post-poned for review until the introspection and other fixes got > merged or ready. > > It could be splitted roughly in 3 parts, but since they depend on each

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: remove open dialog code

2015-09-25 Thread Peter Maydell
On 25 September 2015 at 09:12, Programmingkid wrote: > > On Sep 25, 2015, at 12:09 PM, Peter Maydell wrote: >> (Also, isn't a simple test on gArgc going to cause us to put up >> the dialog box even if qemu was started from the command line with >> no arguments?) > > I suppose you are right. Will m

[Qemu-devel] [PULL 2/7] block/nfs: cache allocated filesize for read-only files

2015-09-25 Thread Jeff Cody
From: Peter Lieven If the file is readonly its not expected to grow so save the blocking call to nfs_fstat_async and use the value saved at connection time. Also important the monitor (and thus the main loop) will not hang if block device info is queried and the NFS share is unresponsive. Signed

  1   2   3   >