Re: [Qemu-devel] [Qemu-arm] [PATCH] ARM: ACPI: Fix MPIDR value in ACPI table

On 3 November 2015 at 04:33, Peter Crosthwaite wrote: > So, I think this is just another case of the MPIDR information flow > going the wrong way. It should go from board to all of CPU, DT and now > this. I guess we can just fix this incrementally when we fix the >

Re: [Qemu-devel] [PATCH] target-arm: Fix arm_debug_excp_handler() for singlestep enabled

On 02.11.2015 21:28, Peter Maydell wrote: > On 2 November 2015 at 17:51, Sergey Fedorov wrote: >> CPU singlestep is done by generating a debug internal exception. Do not >> raise a real CPU exception in case of singlestepping. >> >> Signed-off-by: Sergey Fedorov

Re: [Qemu-devel] [PATCH v2 2/2] block: test 'blockdev-snapshot' using a file BDS as the overlay

On Mon 02 Nov 2015 06:29:14 PM CET, Eric Blake wrote: >>> @@ -103,7 +103,8 @@ function add_snapshot_image() >>> { 'options': >>> { 'driver': 'qcow2', 'node-name': 'snap_"${1}"', >>> "${extra_params}" >>> 'file': >>> - {

Re: [Qemu-devel] qemu-2.2 using trace event

On Tue, Nov 3, 2015 at 9:13 AM, 浩樊啊 wrote: Please keep qemu-devel@nongnu.org on CC so the discussion stays on the mailing list where others can participate. > you mean that qemu-system-x86_64 . is a command to start a vm? > can I just start a vm by a xml file and

Re: [Qemu-devel] SMM error in 2.4 changelog

On 02/11/2015 23:26, William Dauchy wrote: > Hello, > > I think there might be a mistake in the 2.4 changelog: > http://wiki.qemu.org/ChangeLog/2.4 > "Support for system management mode (requires Linux 4.1)." > > But I believe it's included in Linux v4.2 see > https://lwn.net/Articles/648995/

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: _CCA attribute is compulsary

On 2015/11/3 16:31, Graeme Gregory wrote: > > > On Tue, 3 Nov 2015, at 02:25 AM, Shannon Zhao wrote: >> Hi Graeme, >> >> On 2015/11/2 18:39, Graeme Gregory wrote: >>> According to ACPI specification 6.2.17 _CCA (Cache Coherency Attribute) >>> this attribute is compulsary on ARM systems. Add

Re: [Qemu-devel] [PATCH] target-arm: Clean up DISAS_UPDATE usage in AArch32 translation code

On 02.11.2015 21:29, Peter Maydell wrote: > On 2 November 2015 at 18:16, Sergey Fedorov wrote: >> AArch32 translation code does not distinguish between DISAS_UPDATE and >> DISAS_JUMP. Thus, we cannot use any of them without first updating PC in >> CPU state. Furthermore, it

Re: [Qemu-devel] [RFC PATCH 0/5] Introduce Intel 82574 GbE Controller Emulation (e1000e)

> On 3 Nov 2015, at 07:44 AM, Jason Wang wrote: > > > > On 11/02/2015 03:49 PM, Dmitry Fleytman wrote: >> >>> On 2 Nov 2015, at 05:35 AM, Jason Wang >> >>> >>

Re: [Qemu-devel] [PATCH v2] taget-ppc: Fix read access to IBAT registers higher than IBAT3

Ping :) Le mer. 14 oct. 2015 19:43, Julio Guerra a écrit : > Fix the index used to read the IBAT's vector which results in IBAT0..3 > instead > of IBAT4..N. > > The bug appeared by saving/restoring contexts including IBATs values. > > Signed-off-by: Julio Guerra

Re: [Qemu-devel] [PATCH 00/19] buffer/vnc: improve vnc buffer hsndling

> >buffer: allow a buffer to shrink gracefully > > The last Patch isn't the latest version. I have one with improved comments > here: > > https://github.com/plieven/qemu/commit/e599748ab1ef381d4b1c88bf1ea1454dd89353fb > > I also had another improvement: > >

Re: [Qemu-devel] [PATCH v3 00/11] vl.c: Error message rework

Eduardo Habkost writes: > On Fri, Oct 30, 2015 at 05:23:27PM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > Changes v2 -> v3: >> > * Removed patch: "vl.c: Convert error sentences to simpler phrases" >> > * Removed patch: "vl.c:

Re: [Qemu-devel] [PATCH 00/19] buffer/vnc: improve vnc buffer hsndling

Am 03.11.2015 um 09:23 schrieb Gerd Hoffmann: buffer: allow a buffer to shrink gracefully The last Patch isn't the latest version. I have one with improved comments here: https://github.com/plieven/qemu/commit/e599748ab1ef381d4b1c88bf1ea1454dd89353fb I also had another improvement:

[Qemu-devel] [PATCH 1/2] io/buffer: allow a buffer to shrink gracefully

the idea behind this patch is to allow the buffer to shrink, but make this a seldom operation. The buffers average size is measured exponentionally smoothed with am alpha of 1/128. Signed-off-by: Peter Lieven --- include/io/buffer.h | 1 + io/buffer.c | 42

[Qemu-devel] [PATCH 2/2] io/buffer: avoid memmove at each qio_buffer_advance

memmove isn't exactly cheap at it involves temporary buffers if the memory areas are overlapping. So make qio_buffer_advance basically a pointer adjustment, but still keep the wasted memory in reasonable limits. Signed-off-by: Peter Lieven --- include/io/buffer.h | 2 ++

[Qemu-devel] [PATCH 0/2] vnc buffer enhancements for 2.5

These are 2 patches on top of Gerds improve buffer handling series. Patch 1 is an updated version of the patch included in Gerds series and Patch 2 is a further optimization open for discussion. Peter Peter Lieven (2): io/buffer: allow a buffer to shrink gracefully io/buffer: avoid memmove

Re: [Qemu-devel] [PATCH] target-arm: Fix arm_debug_excp_handler() for singlestep enabled

On 3 November 2015 at 09:02, Sergey Fedorov wrote: > On 02.11.2015 21:28, Peter Maydell wrote: >> On 2 November 2015 at 17:51, Sergey Fedorov wrote: >>> CPU singlestep is done by generating a debug internal exception. Do not >>> raise a real CPU

Re: [Qemu-devel] [PATCH v3 2/5] fw_cfg: amend callback behavior spec to once per select

On 11/03/15 01:35, Gabriel L. Somlo wrote: > Currently, the fw_cfg internal API specifies that if an item was set up > with a read callback, the callback must be run each time a byte is read > from the item. This behavior is both wasteful (most items do not have a > read callback set), and

Re: [Qemu-devel] [PATCH 01/13] PPC: Allow Rc bit to be set on mtspr

On 23/10/15 15:56, Mark Cave-Ayland wrote: > From: Alexander Graf > > According to the ISA setting the Rc bit on mtspr is undefined behavior. > Real 750 hardware simply ignores the bit and doesn't touch cr0 though. According to PowerISA 2.07, chapter 1.1.3: "Reserved fields in

Re: [Qemu-devel] [PATCH v7 03/35] acpi: add aml_create_field

On 11/03/2015 02:14 PM, Shannon Zhao wrote: On 2015/11/2 17:13, Xiao Guangrong wrote: Implement CreateField term which is used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 13 +

Re: [Qemu-devel] [PATCH v3 2/3] block: Remove inner quotation marks in iotest 085

On 11/03/2015 03:32 AM, Alberto Garcia wrote: > This patch removes the inner quotation marks in all cases like this: > >cmd=" ... "${variable}" ... " > > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/085 | 16 > 1 file changed, 8 insertions(+),

Re: [Qemu-devel] RFC: libyajl for JSON

Luiz Capitulino writes: > On Tue, 3 Nov 2015 14:53:59 +0100 > Paolo Bonzini wrote: > >> On 03/11/2015 14:46, Luiz Capitulino wrote: >> >> > Can you explain why that would make sense? :) (Especially since there >> >> > is another

Re: [Qemu-devel] [PATCH v3 3/3] block: test 'blockdev-snapshot' using a file BDS as the overlay

On 11/03/2015 03:32 AM, Alberto Garcia wrote: > This test checks that it is not possible to create a snapshot if the > requested overlay node is a BDS which does not support backing images. > > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/085 | 12 +++-

Re: [Qemu-devel] [PATCH v3 1/3] block: Disallow snapshots if the overlay doesn't support backing files

On 11/03/2015 03:32 AM, Alberto Garcia wrote: > This addresses scenarios like this one: > > { 'execute': 'blockdev-add', 'arguments': > { 'options': { 'driver': 'qcow2', >'node-name': 'new0', >'file': { 'driver': 'file', >

Re: [Qemu-devel] [PATCH v10 12/14] block: add transactional properties

On Fri, Oct 23, 2015 at 07:56:50PM -0400, John Snow wrote: > @@ -1732,6 +1757,10 @@ static void > block_dirty_bitmap_add_prepare(BlkActionState *common, > BlockDirtyBitmapState *state = DO_UPCAST(BlockDirtyBitmapState, > common, common); > > +

[Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option

This patch extends the functionality of the max-ram-below-4g option to also allow increasing lowmem. While being at it also rework the lowmem calculation logic and add a longish comment describing how it works and what the compatibility constrains are. Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH v8.5 1/4] qapi: Drop all_members parameter from check()

Eric Blake writes: > The implementation of QAPISchemaObjectTypeMember.check() always > adds the member currently being checked to both the all_members > and seen parameters. QAPISchemaObjectTypeMember.check() does four things: 1. Compute self.type Precondition: all types

[Qemu-devel] [PATCH v11 12/12] Add a new API to start/stop replication, do checkpoint to all BDSes

Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block.c | 83 +++ include/block/block.h | 4 +++ 2 files changed, 87

[Qemu-devel] [PATCH v4 0/7] e1000: Various fixes and registers' implementation

This series fixes issues with packet/octet counting in e1000's Statistic registers, fixes a bug in the packet address filtering procedure, and implements many MAC registers that were absent before, some Statistic counters among them. Besides this, the series introduces a parameter which, if set

[Qemu-devel] [PATCH v4 5/7] e1000: Fixing the received/transmitted octets' counters

Previously, these 64-bit registers did not stick at their maximal values when (and if) they reached them, as they should do, according to the specs. This patch introduces a function that takes care of such registers, avoiding code duplication, making the relevant parts more compatible with the

[Qemu-devel] [PATCH v4 3/7] e1000: Trivial implementation of various MAC registers

These registers appear in Intel's specs, but were not implemented. These registers are now implemented trivially, i.e. they are initiated with zero values, and if they are RW, they can be written or read by the driver, or read only if they are R (essentially retaining their zero values). For these

[Qemu-devel] [PATCH COLO-Frame v10 20/38] COLO: Implement failover work for Primary VM

For PVM, if there is failover request from users. The colo thread will exit the loop while the failover BH does the cleanup work and resumes VM. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- v10: Call migration_end() in

Re: [Qemu-devel] [PATCH v2 1/4] ui: Use g_new() & friends where that makes obvious sense

29.10.2015 18:55, Markus Armbruster wrote: > g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, > for two reasons. One, it catches multiplication overflowing size_t. > Two, it returns T * rather than void *, which lets the compiler catch > more type errors. > > This commit

[Qemu-devel] [PATCH COLO-Frame v10 36/38] netfilter: Introduce an API to delete all the automatically added netfilters

We add a new property 'auto' for netfilter to distinguish if netfilter is added by user or automatically added. Signed-off-by: zhanghailiang Cc: Jason Wang --- v10: new patch --- include/net/filter.h | 2 ++ net/filter-buffer.c | 17

Re: [Qemu-devel] [PATCH] target-alpha: fix uninitialized variable

22.10.2015 02:15, Richard Henderson wrote: > On 10/19/2015 04:08 AM, Paolo Bonzini wrote: >> I am not sure why the compiler does not catch it. There is no >> semantic change since gen_excp returns EXIT_NORETURN, but the >> old code is wrong. >> >> Reported by Coverity. >> >> Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH] configure: remove help string for 'vnc-tls' option

03.11.2015 14:34, Daniel P. Berrange wrote: > The '--enable-vnc-tls' option to configure was removed in Applies to -trivial, thank you! /mjt

[Qemu-devel] [PATCH COLO-Frame v10 24/38] COLO failover: Shutdown related socket fd when do failover

If the net connection between COLO's two sides is broken while colo/colo incoming thread is blocked in 'read'/'write' socket fd. It will not detect this error until connect timeout. It will be a long time. Here we shutdown all the related socket file descriptors to wake up the blocking

[Qemu-devel] [PATCH COLO-Frame v10 33/38] netfilter: Introduce an API to delete the timer of all buffer-filters

Signed-off-by: zhanghailiang Cc: Jason Wang --- v10: new patch --- include/net/filter.h | 1 + net/filter-buffer.c | 17 + 2 files changed, 18 insertions(+) diff --git a/include/net/filter.h b/include/net/filter.h index

Re: [Qemu-devel] [v2 RESEND 0/4] Fix long vm downtime during live migration

On (Mon) 02 Nov 2015 [15:36:59], Liang Li wrote: > The patch 3ea3b7fa9af067982f34b of kvm introduces a lazy collapsing > of small sptes into large sptes mechanism, which intend to solve the > performance drop issue if live migration fails or is canceled. The > rmap will be scanned in the

Re: [Qemu-devel] [PATCH v2] taget-ppc: Fix read access to IBAT registers higher than IBAT3

03.11.2015 11:00, Julio Guerra wrote: > Ping :) Well, I'm not sure what can I do with this. I've no idea what is IBAT to start with, so while technically the patch is a one-liner, I've no idea what it does and how trivial it is :) Maybe you can include some context which teaches me what it is

[Qemu-devel] safety of migration_bitmap_extend

Hi, I'm trying to understand why migration_bitmap_extend is correct/safe; If I understand correctly, you're arguing that: 1) the migration_bitmap_mutex around the extend, stops any sync's happening and so no new bits will be set during the extend. 2) If migration sends a page and

[Qemu-devel] Safety of killing qemu when it is doing an fstrim

I wrote a tool called virt-sparsify which runs fstrim on disks via qemu. My colleague asked me a good question: Is this safe if qemu is killed (^C)? Could it corrupt the guest? Using 'virt-sparsify --inplace disk.img' is essentially equivalent to doing: qemu-kvm \ -kernel \ -drive

Re: [Qemu-devel] [PATCH v7 06/35] acpi: add aml_method_serialized

On Mon, 2 Nov 2015 17:13:08 +0800 Xiao Guangrong wrote: > It avoid explicit Mutex and will be used by NVDIMM ACPI > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/aml-build.c | 26 -- >

Re: [Qemu-devel] [v2 RESEND 4/4] migration: code clean up

Liang Li wrote: > Just clean up code, no behavior change. > > Signed-off-by: Liang Li Reviewed-by: Juan Quintela Applied the whole series

Re: [Qemu-devel] [v2 RESEND 0/4] Fix long vm downtime during live migration

Paolo Bonzini wrote: > On 02/11/2015 08:36, Liang Li wrote: >> The patch 3ea3b7fa9af067982f34b of kvm introduces a lazy collapsing >> of small sptes into large sptes mechanism, which intend to solve the >> performance drop issue if live migration fails or is canceled. The >>

Re: [Qemu-devel] safety of migration_bitmap_extend

"Dr. David Alan Gilbert" wrote: > Hi, > I'm trying to understand why migration_bitmap_extend is correct/safe; > If I understand correctly, you're arguing that: > > 1) the migration_bitmap_mutex around the extend, stops any sync's happening > and so no new bits will

[Qemu-devel] [PATCH] Fixed KVM problems with old DOS programs. Compatibility can be forced by module parameter.

Signed-off-by: Gerhard Wiesinger --- arch/x86/kvm/svm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 2f9ed1f..e0b00fc 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -198,6 +198,10 @@ static bool

Re: [Qemu-devel] [PATCH COLO-Frame v10 33/38] netfilter: Introduce an API to delete the timer of all buffer-filters

Hi, On 2015/11/3 20:41, Yang Hongyang wrote: Can you explain why this is needed? Seems that this api hasn't been used in this series. We will call it in colo_init_filter_buffers() which is introduced in patch 37, We should remove the timers of filter-buffers which are configured by users. Or

[Qemu-devel] [PATCH] log disasm insns when nochain + in_asm enabled

When 'nochain' and 'in_asm' debug options are enabled, QEMU does not print records about every executed translation block (TB). For loop-containing programs it could be suitable to log every executed TB. This patch includes a mapping between TBs and disassembled instructions for this task to be

[Qemu-devel] [PATCH] log disasm insns when nochain + in_asm enabled

When 'nochain' and 'in_asm' debug options are enabled, disassembled forms of all executed translation blocks (TB) are printed to log. For this task a mapping between disassembled instructions and executed TBs is created and used. Signed-off-by: Sergey Smolov --- cpu-exec.c

Re: [Qemu-devel] [PATCH COLO-Frame v10 33/38] netfilter: Introduce an API to delete the timer of all buffer-filters

Can you explain why this is needed? Seems that this api hasn't been used in this series. On 2015年11月03日 19:56, zhanghailiang wrote: Signed-off-by: zhanghailiang Cc: Jason Wang --- v10: new patch --- include/net/filter.h | 1 +

Re: [Qemu-devel] [PATCH COLO-Frame v10 32/38] netfilter: Add a public API to release all the buffered packets

On 2015年11月03日 19:56, zhanghailiang wrote: For COLO or MC FT, We need a function to release all the buffered packets actively. Signed-off-by: zhanghailiang Cc: Jason Wang --- v10: new patch --- include/net/filter.h | 1 +

Re: [Qemu-devel] RFC: libyajl for JSON

On Tue, 03 Nov 2015 08:17:58 +0100 Markus Armbruster wrote: > > So at this point, I want to see if lloyd makes any progress towards an > > actual yajl release and/or adding a co-maintainer, before even trying to > > get formal upstream support for single quoting. We could

Re: [Qemu-devel] [PATCH v8.5 1/4] qapi: Drop all_members parameter from check()

On 11/03/2015 04:06 AM, Markus Armbruster wrote: > Eric Blake writes: > >> The implementation of QAPISchemaObjectTypeMember.check() always >> adds the member currently being checked to both the all_members >> and seen parameters. > > QAPISchemaObjectTypeMember.check() does

[Qemu-devel] [PATCH v11 05/12] Allow creating backup jobs when opening BDS

When opening BDS, we need to create backup jobs for image-fleecing. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Stefan Hajnoczi Reviewed-by:

[Qemu-devel] [PATCH v11 11/12] support replication driver in blockdev-add

Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Eric Blake --- qapi/block-core.json | 21 ++--- 1 file changed, 18 insertions(+), 3

[Qemu-devel] [PATCH v11 04/12] Backup: clear all bitmap when doing block checkpoint

Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Jeff Cody --- block/backup.c | 14 ++ blockjob.c | 11 +++

[Qemu-devel] [PATCH v11 06/12] block: make bdrv_put_ref_bh_schedule() as a public API

Signed-off-by: Wen Congyang --- block.c | 25 + blockdev.c| 37 ++--- include/block/block.h | 1 + 3 files changed, 32 insertions(+), 31 deletions(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH v11 01/12] unblock backup operations in backing file

Signed-off-by: Wen Congyang --- block.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block.c b/block.c index 9a2ab68..1d6c115 100644 --- a/block.c +++ b/block.c @@ -1161,6 +1161,24 @@ void bdrv_set_backing_hd(BlockDriverState *bs,

[Qemu-devel] [PATCH v4 4/7] e1000: Fixing the received/transmitted packets' counters

According to Intel's specs, these counters (as the other Statistic registers) stick at 0x when this maximal value is reached. Previously, they would reset after the max. value. Signed-off-by: Leonid Bloch Signed-off-by: Dmitry Fleytman

[Qemu-devel] [PATCH v4 1/7] e1000: Cosmetic and alignment fixes

This fixes some alignment and cosmetic issues. The changes are made in order that the following patches in this series will look like integral parts of the code surrounding them, while conforming to the coding style. Although some changes in unrelated areas are also made. Signed-off-by: Leonid

Re: [Qemu-devel] [PULL 0/6] ui patch queue

-qapi-2015-11-02' > into staging (2015-11-02 11:11:39 +) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-ui-20151103-1 > > for you to fetch changes up to 4d77b1f23877b579b94421d0cab2bebc79f4e171: > > vnc: fix

[Qemu-devel] [PATCH COLO-Frame v10 38/38] COLO: Add block replication into colo process

Make sure master start block replication after slave's block replication started. Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Li Zhijian --- migration/colo.c | 62

[Qemu-devel] [PATCH COLO-Frame v10 29/38] savevm: Split load vm state function qemu_loadvm_state

qemu_loadvm_state is too long, and we can simplify it by splitting up with three helper functions. Signed-off-by: zhanghailiang --- migration/savevm.c | 165 +++-- 1 file changed, 96 insertions(+), 69 deletions(-)

Re: [Qemu-devel] [PATCH] target-alpha: fix uninitialized variable

On 03/11/2015 13:01, Michael Tokarev wrote: > 22.10.2015 02:15, Richard Henderson wrote: >> On 10/19/2015 04:08 AM, Paolo Bonzini wrote: >>> I am not sure why the compiler does not catch it. There is no >>> semantic change since gen_excp returns EXIT_NORETURN, but the >>> old code is wrong. >>>

Re: [Qemu-devel] [PATCH v2 0/9] block: Fixes for bdrv_drain

Am 29.10.2015 um 03:14 hat Fam Zheng geschrieben: > v2: Add Kevin's reviewed-by in patches 1, 2, 5-7, 9. > Address Kevin's reviewing comments which are: > - Explicit "ret = 0" before out label in patch 3. > - Add missing qemu_aio_unref() in patch 4. > - Recurse into all children in

Re: [Qemu-devel] [PATCH v2 0/4] ui audio qxl usb: Use g_new() & friends where that makes obvious sense

29.10.2015 18:55, Markus Armbruster wrote: > v2: > * Trivially rebased > > Markus Armbruster (4): > ui: Use g_new() & friends where that makes obvious sense > audio: Use g_new() & friends where that makes obvious sense > qxl: Use g_new() & friends where that makes obvious sense > usb: Use

Re: [Qemu-devel] [PATCH] pci-assign: do not test path with access() before opening

02.11.2015 17:17, Paolo Bonzini wrote: > Using access() is a time-of-check/time-of-use race condition. It is > okay to use them to provide better error messages, but that is pretty > much it. > > In this case we can get the same error from fopen(), so just use > strerror and errno there---which

Re: [Qemu-devel] [v2 RESEND 1/4] migration: defer migration_end & blk_mig_cleanup

Liang Li wrote: > Because of the patch 3ea3b7fa9af067982f34b of kvm, which introduces a > lazy collapsing of small sptes into large sptes mechanism, now > migration_end() is a time consuming operation because it calls > memroy_global_dirty_log_stop(), which will trigger the

Re: [Qemu-devel] [v2 RESEND 2/4] migration: rename qemu_savevm_state_cancel

Liang Li wrote: > The function qemu_savevm_state_cancel is called after the migration > in migration_thread, it seems strange to 'cancel' it after completion, > rename it to qemu_savevm_state_cleanup looks better. > > Signed-off-by: Liang Li

Re: [Qemu-devel] [v2 RESEND 3/4] migration: rename cancel to cleanup in SaveVMHandles

Liang Li wrote: > 'cleanup' seems more appropriate than 'cancel'. > > Signed-off-by: Liang Li Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH] exec: avoid unnecessary cacheline bounce on ram_list.mru_block

22.10.2015 14:51, Paolo Bonzini write: > Whenever the MRU cache hits for the list of RAM blocks, qemu_get_ram_block > does an unnecessary write that causes a processor cache line to bounce > from one core to another. This causes a performance hit. Applied to -trivial. A good one! :) /mjt

[Qemu-devel] [vhost-user BUG ?] QEMU process segfault when shutdown or reboot with vhost-user

Hi, We catch a segfault in our project. Qemu version is 2.3.0 The Stack backtrace is: (gdb) bt #0 0x in ?? () #1 0x7f7ad9280b2f in qemu_deliver_packet (sender=, flags=, data=, size=100, opaque= 0x7f7ad9d6db10) at net/net.c:510 #2 0x7f7ad92831fa in

Re: [Qemu-devel] [PATCH v7 27/35] nvdimm acpi: build ACPI nvdimm devices

On Mon, 2 Nov 2015 17:13:29 +0800 Xiao Guangrong wrote: > NVDIMM devices is defined in ACPI 6.0 9.20 NVDIMM Devices > > There is a root device under \_SB and specified NVDIMM devices are under the > root device. Each NVDIMM device has _ADR which returns its

Re: [Qemu-devel] QEMU+Aarch64: in_asm log skips instructions of loop-programs

Hi Christopher, I've send my patch to the mailing list. Sorry for the great delay in answers. 18.09.2015 18:26, Christopher Covington пишет: On 09/18/2015 04:15 AM, Sergey Smolov wrote: Hi Christopher, 18.09.2015 02:02, Christopher Covington пишет: Hi Sergey, On 09/04/2015 12:38 PM,

Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev

On 2015/11/3 20:57, Yang Hongyang wrote: On 2015年11月03日 19:56, zhanghailiang wrote: Signed-off-by: zhanghailiang Cc: Jason Wang --- v10: new patch --- include/net/filter.h | 1 + include/net/net.h| 3 ++ net/filter-buffer.c |

Re: [Qemu-devel] [PATCH v4 0/3] aio: Use epoll in aio_poll()

On Fri, Oct 30, 2015 at 12:06:26PM +0800, Fam Zheng wrote: > v4: Rebase onto master (with aio_disable_external): > Don't use epoll if aio_external_disabled(ctx); > Change assert on epoll_ctl return code to disable epoll; > Rerun benchmark; > > v3: Remove the redundant check in

Re: [Qemu-devel] [PATCH COLO-Frame v10 32/38] netfilter: Add a public API to release all the buffered packets

On 2015/11/3 20:39, Yang Hongyang wrote: On 2015年11月03日 19:56, zhanghailiang wrote: For COLO or MC FT, We need a function to release all the buffered packets actively. Signed-off-by: zhanghailiang Cc: Jason Wang --- v10: new patch ---

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: _CCA attribute is compulsary

On 3 November 2015 at 09:08, Shannon Zhao wrote: > > > On 2015/11/3 16:31, Graeme Gregory wrote: >> >> >> On Tue, 3 Nov 2015, at 02:25 AM, Shannon Zhao wrote: >>> Hi Graeme, >>> >>> On 2015/11/2 18:39, Graeme Gregory wrote: According to ACPI specification 6.2.17 _CCA

Re: [Qemu-devel] [PATCH v8 07/17] qapi: Rework collision assertions

On 11/03/2015 12:56 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 11/02/2015 08:37 AM, Markus Armbruster wrote: >> >>> >>> Not checked: variant's members don't collide with non-variant members. >>> I think this check got lost when we simplified >>>

[Qemu-devel] [PATCH COLO-Frame v10 13/38] COLO: Load PVM's dirty pages into SVM's RAM cache temporarily

We should not load PVM's state directly into SVM, because there maybe some errors happen when SVM is receving data, which will break SVM. We need to ensure receving all data before load the state into SVM. We use an extra memory to cache these data (PVM's ram). The ram cache in secondary side is

[Qemu-devel] [PATCH COLO-Frame v10 34/38] filter-buffer: Accept zero interval

Signed-off-by: zhanghailiang Cc: Jason Wang --- v10: new patch --- net/filter-buffer.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/net/filter-buffer.c b/net/filter-buffer.c index 5f0ea70..05313de 100644 ---

[Qemu-devel] [PATCH COLO-Frame v10 21/38] COLO: Implement failover work for Secondary VM

If users require SVM to takeover work, colo incoming thread should exit from loop while failover BH helps backing to migration incoming coroutine. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian --- migration/colo.c | 41

[Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev

Signed-off-by: zhanghailiang Cc: Jason Wang --- v10: new patch --- include/net/filter.h | 1 + include/net/net.h| 3 ++ net/filter-buffer.c | 84 net/net.c| 20

Re: [Qemu-devel] [PATCH] ivshmem-server: fix possible OVERRUN

Applied to -trivial, thanks! /mjt

[Qemu-devel] [PATCH COLO-Frame v10 14/38] COLO: Load VMState into qsb before restore it

We should not destroy the state of SVM (Secondary VM) until we receive the whole state from the PVM (Primary VM), in case the primary fails in the middle of sending the state, so, here we cache the device state in Secondary before restore it. Besides, we should call qemu_system_reset() before

Re: [Qemu-devel] [PATCH 2/2] io/buffer: avoid memmove at each qio_buffer_advance

Am 03.11.2015 um 11:52 schrieb Gerd Hoffmann: diff --git a/include/io/buffer.h b/include/io/buffer.h index f63869e..43688cc 100644 --- a/include/io/buffer.h +++ b/include/io/buffer.h @@ -39,6 +39,8 @@ struct QIOBuffer { size_t offset; uint64_t avg_size; uint8_t *buffer; +

[Qemu-devel] [PATCH COLO-Frame v10 37/38] colo: Use the netfilter to buffer and release packets

Signed-off-by: zhanghailiang --- v10: Use the new API --- migration/colo.c | 29 + 1 file changed, 29 insertions(+) diff --git a/migration/colo.c b/migration/colo.c index 36f737a..25335db 100644 --- a/migration/colo.c +++

Re: [Qemu-devel] [PATCH 0/2] Fix the reopening of images in 'block-commit'

Am 28.10.2015 um 14:43 hat Alberto Garcia geschrieben: > This series fixes a bug in the 'block-commit' operation under the > following scenario: > >[A] <- [B] <- [C] <- [D] > > If we do block-commit top=B base=A, the contents of [B] will be > written into [A] resulting in this chain: > >

[Qemu-devel] [PATCH] set_memory_options: remove code that make no sense

Signed-off-by: Cao jin --- vl.c | 9 - 1 file changed, 9 deletions(-) diff --git a/vl.c b/vl.c index f5f7c3f..13f2c8b 100644 --- a/vl.c +++ b/vl.c @@ -2860,11 +2860,6 @@ static void set_memory_options(uint64_t *ram_slots, ram_addr_t *maxram_size, sz = 0;

Re: [Qemu-devel] [PATCH v7 09/35] exec: allow file_ram_alloc to work on file

On Mon, 2 Nov 2015 17:13:11 +0800 Xiao Guangrong wrote: > Currently, file_ram_alloc() only works on directory - it creates a file > under @path and do mmap on it > > This patch tries to allow it to work on file directly, if @path is a > directory it works as

Re: [Qemu-devel] [PATCH] set_memory_options: remove code that make no sense

03.11.2015 15:30, Cao jin wrote: > Signed-off-by: Cao jin > --- > vl.c | 9 - > 1 file changed, 9 deletions(-) > > diff --git a/vl.c b/vl.c > index f5f7c3f..13f2c8b 100644 > --- a/vl.c > +++ b/vl.c > @@ -2860,11 +2860,6 @@ static void

Re: [Qemu-devel] [PATCH COLO-Frame v10 35/38] netfilter: Introduce a API to automatically add filter-buffer for each netdev

On 2015年11月03日 19:56, zhanghailiang wrote: Signed-off-by: zhanghailiang Cc: Jason Wang --- v10: new patch --- include/net/filter.h | 1 + include/net/net.h| 3 ++ net/filter-buffer.c | 84

Re: [Qemu-devel] [PATCH COLO-Frame v10 36/38] netfilter: Introduce an API to delete all the automatically added netfilters

On 2015年11月03日 19:56, zhanghailiang wrote: We add a new property 'auto' for netfilter to distinguish if netfilter is added by user or automatically added. Signed-off-by: zhanghailiang Cc: Jason Wang --- v10: new patch ---

Re: [Qemu-devel] Safety of killing qemu when it is doing an fstrim

On 03/11/2015 13:12, Richard W.M. Jones wrote: > > I wrote a tool called virt-sparsify which runs fstrim on disks via > qemu. My colleague asked me a good question: Is this safe if qemu is > killed (^C)? Could it corrupt the guest? > > Using 'virt-sparsify --inplace disk.img' is essentially

Re: [Qemu-devel] [PATCH COLO-Frame v10 34/38] filter-buffer: Accept zero interval

Some commit message would be better. On 2015年11月03日 19:56, zhanghailiang wrote: Signed-off-by: zhanghailiang Cc: Jason Wang Reviewed-by: Yang Hongyang --- v10: new patch --- net/filter-buffer.c | 10

Re: [Qemu-devel] [PATCH v3 9/9] kvm/x86: Hyper-V kvm exit

On 22/10/2015 18:10, Andrey Smetanin wrote: > A new vcpu exit is introduced to notify the userspace of the > changes in Hyper-V SynIC configuration triggered by guest writing to the > corresponding MSRs. > > Changes v3: > * added KVM_EXIT_HYPERV types and structs notes into docs > >

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Add GICC ACPI subtable for GICv3

On 29 October 2015 at 15:16, Shannon Zhao wrote: > When booting VM with GICv3, the kernel needs GICC ACPI subtable to > initialize the CPUs, e.g. MPIDR information. This adds GICC ACPI > subtable for GICv3, but set GICC base address only when gic_version == 2 > since it

Re: [Qemu-devel] [PATCH] ARM: ACPI: Fix MPIDR value in ACPI table

On 31 October 2015 at 09:50, Shannon Zhao wrote: > From: Shannon Zhao > > Use mp_affinity of ARMCPU as the CPU MPIDR instead of the CPU index. > > Signed-off-by: Shannon Zhao > --- > This patch is based on below patch.

Re: [Qemu-devel] [PATCH 2/2] io/buffer: avoid memmove at each qio_buffer_advance

> diff --git a/include/io/buffer.h b/include/io/buffer.h > index f63869e..43688cc 100644 > --- a/include/io/buffer.h > +++ b/include/io/buffer.h > @@ -39,6 +39,8 @@ struct QIOBuffer { > size_t offset; > uint64_t avg_size; > uint8_t *buffer; > +size_t base_offs; > +uint8_t

[Qemu-devel] [PATCH v11 08/12] Add new block driver interfaces to control block replication

Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Cc: Luiz Capitulino Cc: Michael Roth Reviewed-by: Paolo Bonzini

  1   2   3   4   >