Re: [Qemu-devel] [PATCH v4 00/17] Add an IPMI device to QEMU

2015-11-16 Thread Benjamin Herrenschmidt
On Thu, 2015-11-12 at 13:02 -0600, miny...@acm.org wrote: > This is a long delayed patch set, but I think I have things reworked > to make Igor happy with the way ACPI and SMBIOS work.  This is more > consistent with the way most other things work, anyway.  It did > require adding stubs for

Re: [Qemu-devel] [PATCH] iotests: fix race in 030

2015-11-16 Thread Fam Zheng
On Wed, 11/11 15:27, John Snow wrote: > the stop_test case tests that we can resume a block-stream > command after it has stopped/paused due to error. We cannot > always reliably query it before it finishes after resume, though, > so make this a conditional. > > The important thing is that we are

Re: [Qemu-devel] [PULL 25/57] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages.

2015-11-16 Thread Dr. David Alan Gilbert
* Stefan Weil (s...@weilnetz.de) wrote: > Am 10.11.2015 um 15:25 schrieb Juan Quintela: > > From: "Dr. David Alan Gilbert" > > > > The state of the postcopy process is managed via a series of messages; > >* Add wrappers and handlers for sending/receiving these messages >

[Qemu-devel] [PATCH v2] vhost-user: update spec description

2015-11-16 Thread Michael S. Tsirkin
Clarify logging setup to make sure all clients comply in a way that is future-proof. Document how rings are started/stopped. Signed-off-by: Michael S. Tsirkin --- Changes from v1: document recommended behaviour upon RESET_OWNER. docs/specs/vhost-user.txt | 64

Re: [Qemu-devel] [PULL 42/57] Page request: Consume pages off the post-copy queue

2015-11-16 Thread Andreas Färber
Am 12.11.2015 um 14:36 schrieb Markus Armbruster: > Peter Maydell writes: > >> [...] it's usually painful to get a >> backtrace out of this kind of qtest, because it's clearly starting >> a whole pile of QEMUs and there's no way I know of to say "only >> run a few of

Re: [Qemu-devel] [PATCH v2] target-arm: Clean up DISAS_UPDATE usage in AArch32 translation code

2015-11-16 Thread Peter Maydell
On 15 November 2015 at 20:30, Sergey Fedorov wrote: > On 14.11.2015 22:45, Peter Maydell wrote: >> On 13 November 2015 at 21:13, Sergey Fedorov wrote: >>> Thank you a lot for your explanation! It was really helpful for >>> understanding the code :) One

[Qemu-devel] [PATCH 5/5] qmp: create QMP implementation of loadvm command

2015-11-16 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- migration/savevm.c | 5 + qapi-schema.json | 13 + qmp-commands.hx|

[Qemu-devel] [PATCH for-2.5?] hw/ppc/ppc405_boards: Fix infinite recursion by converting taihu_cpld from old_mmio

2015-11-16 Thread Peter Maydell
The taihu_cpld_writel() function had an obvious typo that meant that if it was ever called it would go into an infinite recursion. Newer versions of clang will detect and warn about this: hw/ppc/ppc405_boards.c:481:1: warning: all paths through this function will call itself

[Qemu-devel] [PATCH v2 00/19] Add support for multiple address spaces per CPU and use it for ARM TrustZone

2015-11-16 Thread Peter Maydell
This patch series adds support to QEMU's core exec/memory code for CPUs which have more than one address space, and uses it for ARM TrustZone. In particular, a TZ CPU will have two physical address spaces (Secure and Non-secure), and the patchset allows a board model to create these both

Re: [Qemu-devel] [PATCH 0/3] fix clang negative signed bit shift warning

2015-11-16 Thread Peter Maydell
On 16 November 2015 at 14:23, Peter Maydell wrote: > My clang-3.7 build (it's part of fbinfer) also complains about: > > /Users/pm215/src/qemu/hw/audio/fmopl.c:1085:39: warning: shifting a > negative signed value is undefined [-Wshift-negative-value] >

Re: [Qemu-devel] [PATCH V5] block/nfs: add support for setting debug level

2015-11-16 Thread Stefan Hajnoczi
On Fri, Nov 13, 2015 at 10:52:49AM +0100, Peter Lieven wrote: > Am 13.11.2015 um 10:45 schrieb Stefan Hajnoczi: > > On Mon, Nov 09, 2015 at 08:09:33AM +0100, Peter Lieven wrote: > >> recent libnfs versions support logging debug messages. Add > >> support for it in qemu through an URL parameter. >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 17/77] ppc: Add PPC_64H instruction flag to POWER7 and POWER8

2015-11-16 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:30AM +1100, Benjamin Herrenschmidt wrote: > This will enable decoding of hrfid > > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson > --- > target-ppc/translate_init.c | 4 ++-- > 1 file

Re: [Qemu-devel] [PATCH for 2.5 v7 0/10] dataplane snapshot fixes

2015-11-16 Thread Stefan Hajnoczi
On Tue, Nov 10, 2015 at 05:25:25PM +0300, Denis V. Lunev wrote: > with test > while /bin/true ; do > virsh snapshot-create rhel7 > sleep 10 > virsh snapshot-delete rhel7 --current > done > with enabled iothreads on a running VM leads to a lot of troubles: hangs, >

Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add a subsection for migrating vcpu's TSC rate

2015-11-16 Thread Haozhong Zhang
On 11/13/15 13:21, Eduardo Habkost wrote: > On Fri, Nov 13, 2015 at 10:23:54AM +0800, Haozhong Zhang wrote: > > On 11/11/15 22:27, Haozhong Zhang wrote: > > > On 11/11/15 12:16, Eduardo Habkost wrote: > > [...] > > > > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > > > > > index

Re: [Qemu-devel] [Qemu-ppc] [PATCH 11/77] ppc: Create cpu_ppc_set_papr() helper

2015-11-16 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:24AM +1100, Benjamin Herrenschmidt wrote: > And move the code adjusting the MSR mask and calling kvmppc_set_papr() > to it. This allows us to add a few more things such as disabling setting > of MSR:HV and appropriate LPCR bits which will be used when fixing > the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 04/77] target-ppc: Use sensible POWER8/POWER8E versions

2015-11-16 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:17AM +1100, Benjamin Herrenschmidt wrote: > We never released anything older than POWER8 DD2.0 and POWER8E DD2.1, > so let's use these versions, without that some firmware or Linux code > might fail to use some HW features that were non functional in earlier >

Re: [Qemu-devel] [PATCH] vhost-user: update spec description

2015-11-16 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 11:36:47AM +0200, Victor Kaplansky wrote: > On Sun, Nov 15, 2015 at 09:29:59PM +0200, Michael S. Tsirkin wrote: > > Clarify logging setup to make sure all clients comply in a way that is > > future-proof. Document how rings are started/stopped. > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH] vhost: Fix aborting if KVM does not support eventfds

2015-11-16 Thread Pavel Fedin
Hello! > > If you happen to have a stock kernel of old version, like 3.x, and you > > attempt to enable vhost by setting vhost=on, qemu aborts with error: > > > > kvm_mem_ioeventfd_add: error adding ioeventfd: Function not implemented > > > > This patch adds capability check, so that vhost gets

Re: [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-16 Thread Denis V. Lunev
On 11/16/2015 12:31 PM, Stefan Hajnoczi wrote: On Tue, Nov 10, 2015 at 05:25:30PM +0300, Denis V. Lunev wrote: +int bdrv_all_find_snapshot(const char *name, bool read_only, + BlockDriverState **first_bad_bs) +{ +QEMUSnapshotInfo sn; +int err = 0; +

Re: [Qemu-devel] [PATCH v2] virtio-blk: Fix double completion for werror=stop

2015-11-16 Thread Laurent Vivier
On 16/11/2015 07:10, Fam Zheng wrote: > When a request R is absorbed by request M, it is appended to the > "mr_next" queue led by M, and is completed together with the completion > of M, in virtio_blk_rw_complete. > > With error policy equals stop, if M has an I/O error, now R also gets >

[Qemu-devel] [PATCH v8 2/5] acpi: support specified oem table id for build_header

2015-11-16 Thread Xiao Guangrong
Let build_header() support specified OEM table id so that we can build multiple SSDT later If the oem table id is not specified (aka, NULL), we use the default id instead as the previous behavior Signed-off-by: Xiao Guangrong --- hw/acpi/aml-build.c | 15

Re: [Qemu-devel] [PULL 00/03] seccomp branch queue

2015-11-16 Thread Peter Maydell
ository at: > > git://github.com/otubo/qemu.git tags/pull-seccomp-20151116 > > for you to fetch changes up to ba060c53d585d186ff0ac6b181f4b2a867acc210: > > seccomp: loosen library version dependency (2015-11-16 09:49:47 +0100) > > --

Re: [Qemu-devel] [PATCH v4 1/2] target-i386: fallback vcpu's TSC rate to value returned by KVM

2015-11-16 Thread Eduardo Habkost
On Mon, Nov 16, 2015 at 04:04:07PM +0800, Haozhong Zhang wrote: > If no user-specified TSC rate is present, we will try to set > env->tsc_khz to the value returned by KVM_GET_TSC_KHZ. > > Signed-off-by: Haozhong Zhang > --- > target-i386/kvm.c | 25

[Qemu-devel] [PATCH v2 19/19] HACK: rearrange the virt memory map to suit OP-TEE

2015-11-16 Thread Peter Maydell
The current OP-TEE codebase expects the secure UART to be at 0x0901 and irq 2 (it is based on an old non-upstream patch to add a second uart, and upstream used that memory map area for something else). When the TZ support is upstream in QEMU we can move OP-TEE on to a proper upstream QEMU and

[Qemu-devel] [PATCH v2 04/19] include/qom/cpu.h: Add new get_phys_page_attrs_debug method

2015-11-16 Thread Peter Maydell
Add a new optional method get_phys_page_attrs_debug to CPUClass. This is like the existing get_phys_page_debug, but also returns the memory transaction attributes to use for the access. This will be necessary for CPUs which have multiple address spaces and use the attributes to select the correct

[Qemu-devel] [PATCH v8 5/5] nvdimm: add maintain info

2015-11-16 Thread Xiao Guangrong
Add NVDIMM maintainer Signed-off-by: Xiao Guangrong --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9e1fa72..da58bf4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -932,6 +932,13 @@ M: Jiri Pirko

Re: [Qemu-devel] [PULL for-2.5 0/2] qemu-ga patch queue for 2.5

2015-11-16 Thread Peter Maydell
On 13 November 2015 at 22:40, Michael Roth wrote: > The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: > > Update version for v2.5.0-rc0 release (2015-11-13 17:10:36 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values

2015-11-16 Thread Markus Armbruster
Eric Blake writes: > On 11/13/2015 11:13 AM, Markus Armbruster wrote: > >> We need c_name() to protect ticklish identifiers only when its result is >> used as identifier. Not when it's *part* of an identifier, >> e.g. prefixed with qapi_, or camel_to_upper(type_name) + '_'.

[Qemu-devel] [PATCH 4/5] migration: improve error reporting for hmp_loadvm

2015-11-16 Thread Denis V. Lunev
The patch adds Error ** parameter to load_vmstate call and fills error inside. The caller after that properly reports error either through monitor or via local stderr facility during VM start. This helper will be usefull too for qmp_load_vmstate implementation. Signed-off-by: Denis V. Lunev

[Qemu-devel] [PATCH v2 15/19] target-arm: Implement cpu_get_phys_page_attrs_debug

2015-11-16 Thread Peter Maydell
Implement cpu_get_phys_page_attrs_debug instead of cpu_get_phys_page_debug. Signed-off-by: Peter Maydell --- target-arm/cpu-qom.h | 3 ++- target-arm/cpu.c | 2 +- target-arm/helper.c | 7 +++ 3 files changed, 6 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH 03/10] snapshot: create bdrv_all_delete_snapshot helper

2015-11-16 Thread Denis V. Lunev
to delete snapshots from all loaded block drivers. The patch also ensures proper locking. Signed-off-by: Denis V. Lunev Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi CC: Juan Quintela CC: Kevin Wolf

[Qemu-devel] [PATCH 3/3] scsi-disk: Implement 'REPORT TARGET PORT GROUPS'

2015-11-16 Thread Hannes Reinecke
Implement support for REPORT TARGET PORT GROUPS scsi command. Note that target port groups are referenced per SCSI wwn , which might be connected to different hosts. So we need to walk the entire qtree to find all eligible SCSI devices. Signed-off-by: Hannes Reinecke ---

[Qemu-devel] [PATCH 3/5] qmp: create qmp_delvm command

2015-11-16 Thread Denis V. Lunev
Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Amit Shah CC: Markus Armbruster CC: Eric Blake --- migration/savevm.c | 27 ++- qapi-schema.json | 13 +

[Qemu-devel] [PATCH for-2.5] default-configs/aarch64-linux-user.mak: Remove unused define

2015-11-16 Thread Peter Maydell
The uses of the CONFIG_GDBSTUB_XML define were removed in commit b77abd95a9484c, but the define in aarch64-linux-user.mak somehow escaped the cull (the patchset probably crossed in the mail with the patches adding aarch64 support). Remove the stray define. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH v2 17/19] hw/arm/virt: Wire up memory region to CPUs explicitly

2015-11-16 Thread Peter Maydell
Wire up the system memory region to the CPUs explicitly by setting the QOM property. This doesn't change anything over letting it default, but will be needed for adding a secure memory region later. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias

[Qemu-devel] [PATCH 0/1] vhost-user: Adapt payload of SET_LOG_BASE regarding support of VHOST_USER_PROTOCOL_F_LOG_SHMFD

2015-11-16 Thread Thibaut Collet
For compatibility with old vhost backend (as vapp) payload of SET_LOG_BASE can not be modified. New payload (log size and offset) of this message is sent only for vhost backend that supports the VHOST_USER_PROTOCOL_F_LOG_SHMFD protocol feature. Thibaut Collet (1): vhost-user: modify

[Qemu-devel] [PATCH v2 12/19] qom/cpu: Add MemoryRegion property

2015-11-16 Thread Peter Maydell
From: Peter Crosthwaite Add a MemoryRegion property, which if set is used to construct the CPU's initial (default) AddressSpace. Signed-off-by: Peter Crosthwaite [PMM: code is moved from qom/cpu.c to exec.c to avoid having to make

Re: [Qemu-devel] [PATCH V2 0/4] hw/pcie: Multi-root support for Q35

2015-11-16 Thread Marcel Apfelbaum
On 11/16/2015 10:40 AM, Paolo Bonzini wrote: On 15/11/2015 16:39, Marcel Apfelbaum wrote: Addressed Gerd Hoffmann comments: - Added x-enable-internal-bridge compat property to keep the PCI bridge for older machine to avoid breaking migration. This will break PXB command lines

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/77] ppc: Add number of threads per core to the processor definition

2015-11-16 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:21AM +1100, Benjamin Herrenschmidt wrote: > Also use it to clamp the max SMT mode and ensure that the cpu_dt_id > are offset by that value in order to preserve consistency with the > HW implementations. > > Signed-off-by: Benjamin Herrenschmidt

Re: [Qemu-devel] [PATCH v7 03/24] block: Release dirty bitmaps in bdrv_close()

2015-11-16 Thread Fam Zheng
On Fri, 11/13 17:49, John Snow wrote: > > > On 11/12/2015 01:23 AM, Fam Zheng wrote: > > On Mon, 11/09 23:39, Max Reitz wrote: > >> bdrv_delete() is not very happy about deleting BlockDriverStates with > >> dirty bitmaps still attached to them. In the past, we got around that > >> very easily by

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-16 Thread Thomas Huth
On 12/11/15 19:49, Aravinda Prasad wrote: > > On Thursday 12 November 2015 03:10 PM, Thomas Huth wrote: ... >> Also LoPAPR talks about 'subsequent processors report "fatal error >> previously reported"', so maybe the other processors should report that >> condition in this case? > > I feel guest

Re: [Qemu-devel] [Qemu-ppc] [PATCH 04/77] target-ppc: Use sensible POWER8/POWER8E versions

2015-11-16 Thread Benjamin Herrenschmidt
On Mon, 2015-11-16 at 16:01 +1100, David Gibson wrote: > On Wed, Nov 11, 2015 at 11:27:17AM +1100, Benjamin Herrenschmidt wrote: > > We never released anything older than POWER8 DD2.0 and POWER8E DD2.1, > > so let's use these versions, without that some firmware or Linux code > > might fail to use

Re: [Qemu-devel] [PULL v2 5/7] aio: Introduce aio-epoll.c

2015-11-16 Thread Fam Zheng
On Fri, 11/13 18:09, Paolo Bonzini wrote: > > +static void aio_epoll_update(AioContext *ctx, AioHandler *node, bool > > is_new) > > +{ > > +struct epoll_event event; > > +int r; > > + > > +if (!ctx->epoll_enabled) { > > +return; > > +} > > +if (!node->pfd.events) { >

Re: [Qemu-devel] [PATCH for-2.5] block: Call external_snapshot_clean after blockdev-snapshot

2015-11-16 Thread Fam Zheng
On Fri, 11/13 15:00, Alberto Garcia wrote: > Otherwise the AioContext will never be released. > > Signed-off-by: Alberto Garcia > --- > blockdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/blockdev.c b/blockdev.c > index fc85128..4dcc510 100644 > ---

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-16 Thread David Gibson
On Fri, Nov 13, 2015 at 08:03:51AM +0100, Thomas Huth wrote: > On 13/11/15 02:57, David Gibson wrote: > > On Thu, Nov 12, 2015 at 10:40:11AM +0100, Thomas Huth wrote: > >> On 12/11/15 09:09, Thomas Huth wrote: > >>> On 11/11/15 18:16, Aravinda Prasad wrote: > [...] > +

[Qemu-devel] [PATCH v4 1/2] target-i386: fallback vcpu's TSC rate to value returned by KVM

2015-11-16 Thread Haozhong Zhang
If no user-specified TSC rate is present, we will try to set env->tsc_khz to the value returned by KVM_GET_TSC_KHZ. Signed-off-by: Haozhong Zhang --- target-i386/kvm.c | 25 + 1 file changed, 25 insertions(+) diff --git a/target-i386/kvm.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/77] ppc: Do some batching of TCG tlb flushes

2015-11-16 Thread Benjamin Herrenschmidt
On Mon, 2015-11-16 at 16:00 +1100, David Gibson wrote: >  > >  //#define DEBUG_MMU > >  //#define DEBUG_BATS > > @@ -1940,6 +1941,7 @@ void ppc_tlb_invalidate_all(CPUPPCState *env) > >  case POWERPC_MMU_2_03: > >  case POWERPC_MMU_2_06: > >  case POWERPC_MMU_2_07: > > +

[Qemu-devel] [PATCH] vhost-user-test: don't rely on RESET_OWNER

2015-11-16 Thread Michael S. Tsirkin
vhost-user-test is broken now: it assumes QEMU sends RESET_OWNER, and we stopped doing that. Wait for ENABLE_RING with 0 instead. Signed-off-by: Michael S. Tsirkin --- tests/vhost-user-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v8 1/5] nvdimm: implement NVDIMM device abstract

2015-11-16 Thread Xiao Guangrong
Introduce "nvdimm" device which is based on pc-dimm device type Currently, nothing is specific for nvdimm but hotplug is disabled Signed-off-by: Xiao Guangrong --- default-configs/i386-softmmu.mak | 1 + default-configs/x86_64-softmmu.mak | 1 +

Re: [Qemu-devel] block/vpc: Fix vhd extra sectors issue

2015-11-16 Thread Kevin Wolf
Am 13.11.2015 um 16:32 hat Lucian Petrut geschrieben: > > At the moment, qemu-img extends new image virtual sizes based > on the CHS algorithm provided by the VHD specs in order to > ensure that the disk geometry (and payload as seen by some > guests which use the CHS value) can fit in the

[Qemu-devel] [PATCH v8 0/5] implement vNVDIMM

2015-11-16 Thread Xiao Guangrong
This patchset can be found at: https://github.com/xiaogr/qemu.git nvdimm-v8 It is based on pci branch on Michael's tree and the top commit is: commit e3a4e177d9 (migration/ram: fix build on 32 bit hosts). Changelog in v8: We split the long patch series into the small parts, as you see now,

[Qemu-devel] [PATCH v3 2/8] hw/arm/virt-acpi-build: Add GPIO controller in ACPI DSDT table

2015-11-16 Thread shannon . zhao
From: Shannon Zhao Add GPIO controller in ACPI DSDT table. It can be used for gpio event. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Tested-by: Wei Huang --- hw/arm/virt-acpi-build.c |

[Qemu-devel] [PATCH] vhost-user: print original request on error

2015-11-16 Thread Michael S. Tsirkin
When we get an unexpected response, print out the original request. Helps debug protocol errors tremendously. Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost-user.c

[Qemu-devel] [PULL 02/03] configure: arm/aarch64: allow enable-seccomp

2015-11-16 Thread Eduardo Otubo
From: Andrew Jones This is a revert of ae6e8ef11e6cb, but with a bit of refactoring, and also specifically adding arm/aarch64, rather than all architectures. Currently, libseccomp code appears to also support mips, ppc, and s390. We could therefore allow qemu to enable

Re: [Qemu-devel] [PATCH v4 6/7] qom: replace object property list with GHashTable

2015-11-16 Thread Pavel Fedin
Hello! > My idea, which I wanted to investigate after the weekend, is iterating > through the hashtable to create a list of prop->release functions and > call them only after finishing the iteration. That might not work > either, so we may need to loop over the releasing to allow for released >

Re: [Qemu-devel] [PATCH V2 0/4] hw/pcie: Multi-root support for Q35

2015-11-16 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 12:34:11PM +0200, Marcel Apfelbaum wrote: > On 11/16/2015 12:11 PM, Paolo Bonzini wrote: > > > > > >On 16/11/2015 11:10, Marcel Apfelbaum wrote: > >>>What would you lose? Hotplug? > >> > >>Without the bridge? Yes. However the user can add it manually the > >>pci-bridge and

Re: [Qemu-devel] [PATCH v2 04/19] include/qom/cpu.h: Add new get_phys_page_attrs_debug method

2015-11-16 Thread Andreas Färber
Am 16.11.2015 um 15:07 schrieb Andreas Färber: > Am 16.11.2015 um 15:05 schrieb Peter Maydell: >> Add a new optional method get_phys_page_attrs_debug to CPUClass. >> This is like the existing get_phys_page_debug, but also returns >> the memory transaction attributes to use for the access. >> This

[Qemu-devel] [PATCH v2 06/19] cputlb.c: Use correct address space when looking up MemoryRegionSection

2015-11-16 Thread Peter Maydell
When looking up the MemoryRegionSection for the new TLB entry in tlb_set_page_with_attrs(), use cpu_asidx_from_attrs() to determine the correct address space index for the lookup, and pass it into address_space_translate_for_iotlb(). Signed-off-by: Peter Maydell ---

[Qemu-devel] [PATCH 09/10] migration: implement bdrv_all_find_vmstate_bs helper

2015-11-16 Thread Denis V. Lunev
The patch also ensures proper locking for the operation. Signed-off-by: Denis V. Lunev Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi CC: Juan Quintela CC: Kevin Wolf --- block/snapshot.c

Re: [Qemu-devel] [PATCH] vhost-user-test: don't rely on RESET_OWNER

2015-11-16 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 01:57:45PM +0200, Michael S. Tsirkin wrote: > vhost-user-test is broken now: it assumes > QEMU sends RESET_OWNER, and we stopped doing that. > Wait for ENABLE_RING with 0 instead. > > Signed-off-by: Michael S. Tsirkin Sorry wrong patch. Pls ignore. >

Re: [Qemu-devel] [PATCH v7 19/24] block: Add list of all BlockDriverStates

2015-11-16 Thread Max Reitz
On 12.11.2015 08:12, Fam Zheng wrote: > On Mon, 11/09 23:39, Max Reitz wrote: >> We need this list so that bdrv_close_all() can keep track of which BDSs >> are still open after having removed the BDSs from all of the BBs and >> having released all monitor BDS references. >> >> Signed-off-by: Max

[Qemu-devel] [PATCH v3 7/8] hw/arm/virt: Add QEMU powerdown notifier and hook it to GPIO Pin 3

2015-11-16 Thread shannon . zhao
From: Shannon Zhao Currently mach-virt model doesn't support powerdown request. Guest VM doesn't react to system_powerdown from monitor console (or QMP) because there is no communication mechanism for such requests. This patch registers GPIO Pin 3 with powerdown

Re: [Qemu-devel] [PATCH v13 09/13] add check reset mechanism when hotplug vfio device

2015-11-16 Thread Alex Williamson
On Mon, 2015-11-16 at 18:18 +0800, Chen Fan wrote: > Hi Alex, > >Thanks for your detailed explanation. >during my test, I found that maybe there was another problem in vfio > driver, > I use a dual-port NIC which address are: 06:00.0 and 06:00.1 two functions. > then I use aer-inject to

Re: [Qemu-devel] [PATCH v4 2/2] target-i386: add support to migrate vcpu's TSC rate

2015-11-16 Thread Haozhong Zhang
On 11/16/15 11:43, Eduardo Habkost wrote: > On Mon, Nov 16, 2015 at 04:04:08PM +0800, Haozhong Zhang wrote: > > This patch enables migrating vcpu's TSC rate. If KVM on the destination > > machine supports TSC scaling, guest programs will observe a consistent > > TSC rate across the migration. > >

Re: [Qemu-devel] [PATCH v7 22/24] block: Rewrite bdrv_close_all()

2015-11-16 Thread Max Reitz
On 12.11.2015 08:34, Fam Zheng wrote: > On Mon, 11/09 23:39, Max Reitz wrote: >> This patch rewrites bdrv_close_all(): Until now, all root BDSs have been >> force-closed. This is bad because it can lead to cached data not being >> flushed to disk. >> >> Instead, try to make all reference holders

[Qemu-devel] [PATCH] hw/audio/fmopl.c: Avoid clang warning about shifting negative number

2015-11-16 Thread Peter Maydell
Newer versions of clang warn: hw/audio/fmopl.c:1085:39: warning: shifting a negative signed value is undefined [-Wshift-negative-value] data = Limit( outd[0] , OPL_MAXOUT, OPL_MINOUT ); ^~ hw/audio/fmopl.c:75:28: note:

Re: [Qemu-devel] QEMU versus Facebook's Infer static analysis tool

2015-11-16 Thread Paolo Bonzini
On 14/11/2015 22:53, Peter Maydell wrote: > That's a shame, because it would have been nice to include another > kind of static analysis in what we run on QEMU (especially since > the coverity tests are "only runs every so often when we do a build"), > and the ability to do incremental analysis

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-16 Thread Paul Mackerras
On Thu, Nov 12, 2015 at 09:09:59AM +0100, Thomas Huth wrote: > > Shouldn't you also check MSR_ME here first and enter checkstop when > machine checks are disabled? MSR_ME is a hypervisor resource and is not able to be controlled by HV KVM guests, or in fact by the OS running on the pseries

Re: [Qemu-devel] [PATCH V2 0/4] hw/pcie: Multi-root support for Q35

2015-11-16 Thread Paolo Bonzini
On 16/11/2015 11:02, Marcel Apfelbaum wrote: > Actually the command line would work. The devices will be placed on the > root bus > instead of the pci bridge bus. The trick here is that we name the bus > the devices > will be attached to by the pxb id. > - When we have the bridge -> the pxb id

Re: [Qemu-devel] [Qemu-ppc] [PATCH 02/77] ppc: Use split I/D mmu modes to avoid flushes on interrupts

2015-11-16 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:15AM +1100, Benjamin Herrenschmidt wrote: > We rework the way the MMU indices are calculated, providing separate > indices for I and D side based on MSR:IR and MSR:DR respectively, > and thus no longer need to flush the TLB on context changes. This also > adds correct

Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/77] ppc: Do some batching of TCG tlb flushes

2015-11-16 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:16AM +1100, Benjamin Herrenschmidt wrote: > On ppc64 especially, we flush the tlb on any slbie or tlbie instruction. > > However, those instructions often come in bursts of 3 or more (context > switch will favor a series of slbie's for example to an slbia if the >

[Qemu-devel] [PULL 03/03] seccomp: loosen library version dependency

2015-11-16 Thread Eduardo Otubo
From: dann frazier Drop the libseccomp required version back to 2.1.0, restoring the ability to build w/ --enable-seccomp on Ubuntu 14.04. Commit 4cc47f8b3cc4f32586ba2f7fce1dc267da774a69 tightened the dependency on libseccomp from version 2.1.0 to 2.1.1. This broke

Re: [Qemu-devel] [PATCH V4 0/6] ide: avoid main-loop hang on CDROM/NFS failure

2015-11-16 Thread Peter Lieven
Am 16.11.2015 um 07:17 schrieb Fam Zheng: On Fri, 11/13 17:44, John Snow wrote: On 11/12/2015 11:30 AM, Peter Lieven wrote: This series aims at avoiding a hanging main-loop if a vserver has a CDROM image mounted from a NFS share and that NFS share goes down. Typical situation is that users

Re: [Qemu-devel] [PATCH V2 0/4] hw/pcie: Multi-root support for Q35

2015-11-16 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 12:39:45PM +0200, Marcel Apfelbaum wrote: > On 11/16/2015 12:37 PM, Michael S. Tsirkin wrote: > >On Mon, Nov 16, 2015 at 12:34:11PM +0200, Marcel Apfelbaum wrote: > >>On 11/16/2015 12:11 PM, Paolo Bonzini wrote: > >>> > >>> > >>>On 16/11/2015 11:10, Marcel Apfelbaum wrote:

Re: [Qemu-devel] [PULL 0/6] Ide patches

2015-11-16 Thread Peter Maydell
On 13 November 2015 at 20:16, John Snow wrote: > The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: > > Update version for v2.5.0-rc0 release (2015-11-13 17:10:36 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-16 Thread Aravinda Prasad
On Monday 16 November 2015 04:11 PM, Thomas Huth wrote: > On 16/11/15 11:07, Aravinda Prasad wrote: >> >> >> On Monday 16 November 2015 01:22 PM, Thomas Huth wrote: >>> On 12/11/15 19:49, Aravinda Prasad wrote: On Thursday 12 November 2015 03:10 PM, Thomas Huth wrote: >>> ... >

[Qemu-devel] [PATCH v4 0/2] target-i386: save/restore vcpu's TSC rate during migration

2015-11-16 Thread Haozhong Zhang
This patchset enables QEMU to save/restore vcpu's TSC rate during the migration on machine types pc-*-2.5 or newer. On the source machine: * If the vcpu's TSC rate is specified by the cpu option 'tsc-freq', then this user-specified TSC rate will be migrated. * Otherwise, the TSC rate

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-16 Thread Thomas Huth
On 16/11/15 11:07, Aravinda Prasad wrote: > > > On Monday 16 November 2015 01:22 PM, Thomas Huth wrote: >> On 12/11/15 19:49, Aravinda Prasad wrote: >>> >>> On Thursday 12 November 2015 03:10 PM, Thomas Huth wrote: >> ... Also LoPAPR talks about 'subsequent processors report "fatal error

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-16 Thread Aravinda Prasad
On Monday 16 November 2015 02:31 PM, Thomas Huth wrote: > On 16/11/15 04:50, Paul Mackerras wrote: >> On Thu, Nov 12, 2015 at 09:09:59AM +0100, Thomas Huth wrote: >>> >>> Shouldn't you also check MSR_ME here first and enter checkstop when >>> machine checks are disabled? >> >> MSR_ME is a

Re: [Qemu-devel] [QEMU PATCH] target-i386: Disable rdtscp on Opteron_G* CPU models

2015-11-16 Thread Eduardo Habkost
On Mon, Nov 16, 2015 at 10:44:59AM +0100, Paolo Bonzini wrote: > > > On 13/11/2015 20:07, Eduardo Habkost wrote: > > KVM can't virtualize rdtscp on AMD CPUs yet, so there's no point > > in enabling it by default on AMD CPU models, as all we are > > getting are confused users because of the "host

Re: [Qemu-devel] [PATCH COLO-Frame v10 16/38] COLO: Flush PVM's cached RAM into SVM's memory

2015-11-16 Thread zhanghailiang
On 2015/11/14 0:38, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: During the time of VM's running, PVM may dirty some pages, we will transfer PVM's dirty pages to SVM and store them into SVM's RAM cache at next checkpoint time. So, the content of SVM's

Re: [Qemu-devel] [PATCH] vhost-user-test: support VHOST_USER_SET_VRING_ENABLE

2015-11-16 Thread Marc-André Lureau
Hi - Original Message - > Hi > > That patch doesn't work, vhost-user-test fails: > > ERROR:tests/vhost-user-test.c:491:test_migrate_source_check: assertion > failed: (!overlap) Actually, with "vhost: let SET_VRING_ENABLE message depends on protocol feature" it works ack after that

[Qemu-devel] [PATCH v3 1/8] hw/arm/virt: Add a GPIO controller

2015-11-16 Thread shannon . zhao
From: Shannon Zhao ACPI 5.0 supports GPIO-signaled ACPI Events. This can be used for powerdown, hotplug evnets. Add a GPIO controller in machine virt, to support powerdown, maybe can be used for cpu hotplug. And here we use pl061. Signed-off-by: Shannon Zhao

[Qemu-devel] [PATCH v3 6/8] hw/arm/virt-acpi-build: Add _E03 for Power Button

2015-11-16 Thread shannon . zhao
From: Shannon Zhao Here GPIO pin 3 is used for Power Button, add _E03 in ACPI DSDT table. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao Tested-by: Wei Huang --- hw/arm/virt-acpi-build.c |

[Qemu-devel] [PATCH v2 07/19] exec.c: Pass MemTxAttrs to iotlb_to_region so it uses the right AS

2015-11-16 Thread Peter Maydell
Pass the MemTxAttrs for the memory access to iotlb_to_region(); this allows it to determine the correct AddressSpace to use for the lookup. Signed-off-by: Peter Maydell --- cputlb.c| 6 -- exec.c | 5 +++-- include/exec/exec-all.h |

[Qemu-devel] [PATCH v2 14/19] target-arm: Implement asidx_from_attrs

2015-11-16 Thread Peter Maydell
Implement the asidx_from_attrs CPU method to return the Secure or NonSecure address space as appropriate. (The function is inline so we can use it directly in target-arm code to be added in later patches.) Signed-off-by: Peter Maydell --- target-arm/cpu.c | 1 +

[Qemu-devel] [PATCH v8 4/5] nvdimm acpi: build ACPI nvdimm devices

2015-11-16 Thread Xiao Guangrong
NVDIMM devices is defined in ACPI 6.0 9.20 NVDIMM Devices There is a root device under \_SB and specified NVDIMM devices are under the root device. Each NVDIMM device has _ADR which returns its handle used to associate MEMDEV structure in NFIT Currently, we do not support any function on _DSM,

Re: [Qemu-devel] [PATCH v4 1/2] target-i386: fallback vcpu's TSC rate to value returned by KVM

2015-11-16 Thread Haozhong Zhang
On 11/16/15 11:39, Eduardo Habkost wrote: > On Mon, Nov 16, 2015 at 04:04:07PM +0800, Haozhong Zhang wrote: > > If no user-specified TSC rate is present, we will try to set > > env->tsc_khz to the value returned by KVM_GET_TSC_KHZ. > > > > Signed-off-by: Haozhong Zhang

[Qemu-devel] [PATCH v2 05/19] include/qom/cpu.h: Add new asidx_from_attrs method

2015-11-16 Thread Peter Maydell
Add a new method to CPUClass which the memory system core can use to obtain the correct address space index to use for a memory access with a given set of transaction attributes, together with the wrapper function cpu_asidx_from_attrs() which implements the default behaviour ("always use asidx 0")

[Qemu-devel] [PATCH 01/10] snapshot: create helper to test that block drivers supports snapshots

2015-11-16 Thread Denis V. Lunev
The patch enforces proper locking for this operation. Signed-off-by: Denis V. Lunev Reviewed-by: Greg Kurz Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi CC: Juan Quintela CC: Kevin

Re: [Qemu-devel] [PATCH] vhost-user-test: support VHOST_USER_SET_VRING_ENABLE

2015-11-16 Thread Marc-André Lureau
Hi That patch doesn't work, vhost-user-test fails: ERROR:tests/vhost-user-test.c:491:test_migrate_source_check: assertion failed: (!overlap) - Original Message - > vhost-user-test is broken now: it assumes > QEMU sends RESET_OWNER, and we stopped doing that. > Wait for ENABLE_RING

[Qemu-devel] [PATCH] target-mips: Fix exceptions while UX=0

2015-11-16 Thread James Hogan
Commit 01f728857941 ("target-mips: Status.UX/SX/KX enable 32-bit address wrapping") added a new hflag MIPS_HFLAG_AWRAP, which indicates that 64-bit addressing is disallowed in the current mode, so hflag users don't need to worry about the complexities of working that out, for example checking both

Re: [Qemu-devel] [PULL 0/6] Ide patches

2015-11-16 Thread John Snow
On 11/16/2015 06:32 AM, Peter Maydell wrote: > On 16 November 2015 at 11:07, Peter Maydell wrote: >> On 13 November 2015 at 20:16, John Snow wrote: >>> The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: >>> >>> Update

Re: [Qemu-devel] [QEMU PATCH] target-i386: Disable rdtscp on Opteron_G* CPU models

2015-11-16 Thread Paolo Bonzini
On 13/11/2015 20:07, Eduardo Habkost wrote: > KVM can't virtualize rdtscp on AMD CPUs yet, so there's no point > in enabling it by default on AMD CPU models, as all we are > getting are confused users because of the "host doesn't support > requested feature" warnings. > > Disable rdtscp on

Re: [Qemu-devel] [Qemu-ppc] [PATCH 13/77] ppc: tlbie, tlbia and tlbisync are HV only

2015-11-16 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:26AM +1100, Benjamin Herrenschmidt wrote: > Not that anything remotely recent supports tlbia but ... > > Signed-off-by: Benjamin Herrenschmidt > --- > target-ppc/translate.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >

Re: [Qemu-devel] [PATCH for-2.5 v2] tests: Ignore recent test binaries

2015-11-16 Thread Stefan Hajnoczi
On Thu, Nov 12, 2015 at 08:47:03PM -0700, Eric Blake wrote: > Commits 6c6f312d and bd797fc1 added new tests (test-blockjob-txn > and test-timed-average, respectively), but did not mark them for > exclusion in .gitignore. > > Signed-off-by: Eric Blake > --- > > v2: retitle;

[Qemu-devel] Bug with GDB from commit ca3e40e

2015-11-16 Thread Marc Marí
Hi I was trying to debug some stuff in the bootloader and the optionrom, and I found a bug with QEMU and GDB. In commit ca3e40e (a pull request from Michael), I get this: x86_64-softmmu/qemu-system-x86_64 --enable-kvm \ -kernel /boot/vmlinuz-4.1.7-200.fc22.x86_64 -s -S

Re: [Qemu-devel] [PATCH] vhost: Fix aborting if KVM does not support eventfds

2015-11-16 Thread Pavel Fedin
Hello! > OK so it's a misconfigured kernel. > Fine but I'm not happy with silently using userspace instead. It's not silent. You get two warnings in the log: --- cut --- 2015-11-13T08:43:51.146802Z qemu-system-aarch64: KVM does not support MMIO eventfds 2015-11-13T08:43:51.146915Z

Re: [Qemu-devel] [Qemu-ppc] [PATCH 02/77] ppc: Use split I/D mmu modes to avoid flushes on interrupts

2015-11-16 Thread Benjamin Herrenschmidt
Thanks for reviewing ! On Mon, 2015-11-16 at 15:49 +1100, David Gibson wrote: > >  static inline void hreg_compute_mem_idx(CPUPPCState *env) > >  { > > -/* Precompute MMU index */ > > -if (msr_pr == 0 && msr_hv != 0) { > > -env->mmu_idx = 2; > > +/* This is our encoding for

Re: [Qemu-devel] [PATCH] virtio-blk: Fix double completion for werror=stop

2015-11-16 Thread Fam Zheng
On Fri, 11/13 14:17, Paolo Bonzini wrote: > > > On 13/11/2015 10:32, Fam Zheng wrote: > > When a request R is absorbed by request M, it is appended to the > > "mr_next" queue led by M, and is completed together with the completion > > of M, in virtio_blk_rw_complete. > > > > With error policy

  1   2   3   4   >