Re: [Qemu-devel] [PULL for-2.5 0/4] QOM devices patch queue 2015-12-03

Peter Maydell writes: > On 3 December 2015 at 19:45, Andreas Färber wrote: >> Hello Peter, >> >> This is my QOM (devices) patch queue for 2.5. Please pull. >> >> Regards, >> Andreas >> >> Cc: Peter Maydell >> Cc: Markus Armbruster >> Cc: Marc-André Lureau >> >> The following changes since com

[Qemu-devel] [PATCH for-2.6 2/2] Modify callers of msi_init()

Because definition of msi_init() has been changed for the purpose: convert to realize(). There are 11 callers for now. Signed-off-by: Cao jin --- hw/audio/intel-hda.c | 7 ++- hw/ide/ich.c | 2 +- hw/net/vmxnet3.c | 3 ++- hw/pci-bridge/i

[Qemu-devel] [PATCH for-2.6 1/2] Add param Error** to msi_init()

msi_init() is a supporting function in PCI device initialization, in order to convert .init() to .realize(), it should be modified first. Bonus: add more comment. Signed-off-by: Cao jin --- hw/pci/msi.c | 17 + include/hw/pci/msi.h | 4 ++-- 2 files changed, 15 insertion

[Qemu-devel] [PATCH for-2.6 0/2] Preparation for PCI devices convert to realize()

Hi, As you know, there are many PCI devices still using .init() as its initialization function, I am planning to do the "convert to realize()" work, and PCI bridge devices are chosen first. The supporting functions should be modified first. msi_init() a supporting function for P

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

Peter Maydell writes: > On 7 September 2015 at 17:57, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 7 September 2015 at 17:40, Markus Armbruster wrote: Peter Maydell writes: > Convert the pxa2xx_mmci device to be a sysbus device. >>> > +static Property pxa2xx_m

[Qemu-devel] [PULL 8/9] typedefs: Put them back into alphabetical order

From: Markus Armbruster "Please keep this list in alphabetical order" has been more honoured in the breach than in the observance. Clean up. While there, drop a redundant struct declaration. Signed-off-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Eric Blake Signed-

[Qemu-devel] [PULL 4/9] crypto: avoid two coverity false positive error reports

From: "Daniel P. Berrange" In qcrypto_tls_creds_get_path() coverity complains that we are checking '*creds' for NULL, despite having dereferenced it previously. This is harmless bug due to fact that the trace call was too early. Moving it after the cleanup gets the desired semantics. In qcrypto_

[Qemu-devel] [PULL 3/9] configure: Diagnose broken linkers directly

From: Peter Maydell Currently if the user's compiler works for creating .o files but their linker is broken such that compiling an executable from a C file does not work, we will report a misleading error message about the compiler not supporting __thread (since that happens to be the first test

[Qemu-devel] [PULL 2/9] bt: avoid unintended sign extension

From: Paolo Bonzini In the case of a 4-byte length, shifting a value by 24 may cause an unintended sign extension when converting from int to size_t. Use a uint32_t variable instead. Signed-off-by: Paolo Bonzini Reviewed-by: Markus Armbruster Signed-off-by: Michael Tokarev --- hw/bt/sdp.c |

Re: [Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

2015-12-04 14:58 GMT+08:00 阎淼 : > 2015-12-03 23:59 GMT+08:00 Eric Blake : >> On 12/02/2015 10:08 PM, Miao Yan wrote: >>> Macro MAC_FMT and MAC_ARG are not defined, but used in vmxnet3_net_init(). >>> This will cause build error when debug level is raised in >>> vmxnet3_debug.h (enable all VMXNET3_D

[Qemu-devel] [PULL 6/9] gt64xxx: fix decoding of ISD register

From: Paolo Bonzini The GT64xxx's internal registers can be placed above the first 4 GiB in the address space, but not above the first 64 GiB. Correctly cast the register to a 64-bit integer, and mask away bits above bit 35. Datasheet at http://pdf.datasheetarchive.com/datasheetsmain/Datasheet

[Qemu-devel] [PULL for-2.5 0/9] Trivial patches for 2015-12-04

Hello. During the freeze period, let me please add my trivial pull request too ;) There are just 9 patches this time, which are either (small) bugfixes, or just prettifying one or another part of code to look nicely in the release tarball. Here are all of them: aniel P. Berrange (1): cryp

[Qemu-devel] [PULL 1/9] util/id: fully allocate names table

From: John Snow Trivial: this array should be allocated to have ID_MAX entries always. Otherwise if someone were to forget to expand this table, the assertion in the id generator won't actually trigger; it will read junk data. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Jeff

[Qemu-devel] [PULL 7/9] scsi: remove scsi_req_free prototype

From: Hervé Poussineau Function has been deleted in ad2d30f79d3b0812f02c741be2189796b788d6d7. Signed-off-by: Hervé Poussineau Reviewed-by: Fam Zheng Signed-off-by: Michael Tokarev --- include/hw/scsi/scsi.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/scsi/scsi.h b/include/h

[Qemu-devel] [PULL 5/9] configure: use appropriate code fragment for -fstack-protector checks

From: Rodrigo Rebello The check for stack-protector support consisted in compiling and linking the test program below (output by function write_c_skeleton()) with the compiler flag -fstack-protector-strong first and then with -fstack-protector-all if the first one failed to work: int main(void

[Qemu-devel] [PULL 9/9] bt: check struct sizes

From: Paolo Bonzini See http://permalink.gmane.org/gmane.linux.bluez.kernel/36505. For historical reasons these do not use sizeof, and Coverity caught a mistake in EVT_ENCRYPT_CHANGE_SIZE. In addition: - remove status from create_conn_cancel_cp; the "status" field is only in rp structs. Note

[Qemu-devel] [PULL 1/3] spapr_drc: Handle visitor errors properly

From: Markus Armbruster Since prop_get_fdt() is only used with QmpOutputVisitor, errors shouldn't actually happen, so this is only a latent bug. Signed-off-by: Markus Armbruster Signed-off-by: David Gibson --- hw/ppc/spapr_drc.c | 32 ++-- 1 file changed, 26 insert

Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}

On Thu, Dec 03, 2015 at 07:41:59PM -0700, Eric Blake wrote: > On 12/03/2015 04:54 PM, David Gibson wrote: > > On Thu, Dec 03, 2015 at 05:37:39PM +0100, Markus Armbruster wrote: > >> prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't > >> visit anything. object_property_get_qobjec

[Qemu-devel] [PULL 2/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device

From: Markus Armbruster It should only be created via spapr_dr_connector_new(). Attempting to create it with -device crashes. Signed-off-by: Markus Armbruster Signed-off-by: David Gibson --- hw/ppc/spapr_drc.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/ppc/spapr_drc.c b/hw/pp

[Qemu-devel] [PULL 3/3] spapr_drc: Change value of property "fdt" from null back to {}

From: Markus Armbruster prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't visit anything. object_property_get_qobject() happily object_property_get_qobject(). Amazingly, the latter survives the misuse. Turns out we've papered over it long before prop_get_fdt() existed, in co

[Qemu-devel] [PULL 0/3] ppc-for-2.5 queue 20151204

The following changes since commit 4c65fed8bdf96780735dbdb92a8bd0d6b6526cc3: ui: vnc: avoid floating point exception (2015-12-03 13:34:50 +) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.5-20151204 for you to fetch changes up to ab8bf1d735133df

Re: [Qemu-devel] [RFC PATCH V2 00/10] Qemu: Add live migration support for SRIOV NIC

On 12/2/2015 10:31 PM, Michael S. Tsirkin wrote: >We hope >to find a better way to make SRIOV NIC work in these cases and this is >worth to do since SRIOV NIC provides better network performance compared >with PV NIC. If this is a performance optimization as the above implies, you need to inclu

[Qemu-devel] [PATCH for 2.6 v3 1/1] qemu-char: append opt to stop truncation of serial file

From: Olga Krishtal Our QA team wants to preserve serial output of the guest in between QEMU runs to perform post-analysis. By default this behavior is off (file is truncated each time QEMU is started or device is plugged). Signed-off-by: Olga Krishtal Signed-off-by: Denis V. Lunev CC: Eric B

Re: [Qemu-devel] Question about nonblocking stderr and lost logs

On Mon, Nov 30, 2015 at 04:34:47PM +1100, Sam Bobroff wrote: > Hi QEMU programmers, > > While doing some experimental work on QEMU that has involved adding a lot of > new log messages (using qemu_log_mask()), I've discovered that under some > conditions a lot of my log messages go missing. > > I'

Re: [Qemu-devel] scripts/gdb: Fix a python exception in mtree.py

On Wed, Dec 02, 2015 at 03:56:24PM +0800, Yang Wei wrote: > The following exception is threw: > Python Exception name 'long' is not defined: > Error occurred in Python command: name 'long' is not defined > > In python3, long is rename to int > > Signed-off-by: Yang Wei > --- > scripts/qemugdb/

Re: [Qemu-devel] [PATCH] vhost: drop dead code

02.12.2015 14:50, Michael S. Tsirkin wrote: > We dropped the implementation of vhost_dev_query, > drop it from the header file as well. Applied to -trivial with a commit message fix suggested by Eric. Thanks! /mjt

[Qemu-devel] [PATCH] report a error message if -net socket can not connect to server

From: Li Zhijian -netdev socket,connect=xx:xx now is asynchronous to connect listening server, if we don't start listening server before connecting, no error is detected but we can connect to listening server forever. Just report a error message in this case? Signed-off-by: Li Zhijian --- net

[Qemu-devel] [PATCH 8/8] raspi: add raspberry pi 2 machine

bcm2835/Pi1 requires more peripherals, and will be added in a later patch series. Signed-off-by: Andrew Baumann --- hw/arm/Makefile.objs | 2 +- hw/arm/raspi.c | 179 +++ 2 files changed, 180 insertions(+), 1 deletion(-) create mode 100644

[Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes

This adds the system mailboxes which are used to communicate with a number of GPU peripherals on Pi/Pi2. Signed-off-by: Andrew Baumann --- default-configs/arm-softmmu.mak | 1 + hw/misc/Makefile.objs| 1 + hw/misc/bcm2835_sbm.c| 280

[Qemu-devel] [PATCH 7/8] bcm2836: add bcm2836 soc device

This is the SoC for Raspberry Pi 2. Signed-off-by: Andrew Baumann --- hw/arm/Makefile.objs | 2 +- hw/arm/bcm2836.c | 135 +++ include/hw/arm/bcm2836.h | 33 3 files changed, 169 insertions(+), 1 deletion(-) create mode 100

[Qemu-devel] [PATCH 5/8] bcm2835_peripherals: add rollup device for bcm2835 peripherals

This device maintains all the non-CPU peripherals on bcm2835 (Pi1) which are also present on bcm2836 (Pi2). It also implements the private address space used for DMA. Signed-off-by: Andrew Baumann --- hw/arm/Makefile.objs | 1 + hw/arm/bcm2835_peripherals.c | 185 ++

[Qemu-devel] [PATCH 2/8] bcm2835_property: add bcm2835 property channel

This sits behind the mailbox interface, and implements request/response queries for system properties. The framebuffer-related properties will be added in a later patch. Signed-off-by: Andrew Baumann --- hw/misc/Makefile.objs | 1 + hw/misc/bcm2835_property.c | 262 +++

[Qemu-devel] [PATCH 4/8] bcm2835_emmc: add bcm2835 MMC/SD controller

Signed-off-by: Andrew Baumann --- hw/sd/Makefile.objs | 1 + hw/sd/bcm2835_emmc.c | 800 +++ include/hw/sd/bcm2835_emmc.h | 56 +++ 3 files changed, 857 insertions(+) create mode 100644 hw/sd/bcm2835_emmc.c create mode 100644 include/h

[Qemu-devel] [PATCH 6/8] bcm2836_control: add bcm2836 ARM control logic

This module is specific to the bcm2836 (Pi2). It implements the top level interrupt controller, and mailboxes used for inter-processor synchronisation. Signed-off-by: Andrew Baumann --- hw/intc/Makefile.objs | 2 +- hw/intc/bcm2836_control.c | 344 ++

[Qemu-devel] [PATCH 3/8] bcm2835_ic: add bcm2835 interrupt controller

Signed-off-by: Andrew Baumann --- hw/intc/Makefile.objs| 1 + hw/intc/bcm2835_ic.c | 234 +++ include/hw/intc/bcm2835_ic.h | 26 + 3 files changed, 261 insertions(+) create mode 100644 hw/intc/bcm2835_ic.c create mode 100644 include

[Qemu-devel] [PATCH 1/2] qemu-file: fix flaws of qemu_put_compression_data

There are some flaws in qemu_put_compression_data, this patch tries to fix it. Now it can be used by other code. Signed-off-by: Liang Li --- migration/qemu-file.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 0bb

[Qemu-devel] [PATCH 0/2] fix the flaws of qemu_put_compression_data

This patch fixed the flaws in qemu_put_compression_data function. and cleanup the code based on the change. Liang Li (2): qemu-file: fix flaws of qemu_put_compression_data migration: code clean up. migration/qemu-file.c | 10 +- migration/ram.c | 20 2 file

[Qemu-devel] [PATCH 2/2] migration: code clean up.

Use qemu_put_compression_data to do the compression directly instead of using do_compress_ram_page, avoid some data copy. very small improvement, but the code looks better. Signed-off-by: Liang Li --- migration/ram.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) di

[Qemu-devel] [PATCH 1/2] qemu-file: fix flaws of qemu_put_compression_data

There are some flaws in qemu_put_compression_data, this patch tries to fix it. Now it can be used by other code. Signed-off-by: Liang Li --- migration/qemu-file.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 0bb

[Qemu-devel] [PATCH 2/2] migration: code clean up.

Use qemu_put_compression_data to do the compression directly instead of using do_compress_ram_page, avoid some data copy. very small improvement, but the code looks better. Signed-off-by: Liang Li --- migration/ram.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) di

[Qemu-devel] [PATCH 0/2] fix the flaws of qemu_put_compression_data

This patch fixed the flaws in qemu_put_compression_data function. and cleanup the code based on the change. Liang Li (2): qemu-file: fix flaws of qemu_put_compression_data migration: code clean up. migration/qemu-file.c | 10 +- migration/ram.c | 20 2 file

[Qemu-devel] [PATCH] ivshmem: Store file descriptor for vhost-user negotiation

If virtio-net driver allocates memory in vishmem shared memory, vhost-net will work correctly, but vhost-user will not work because a fd of shared memory will not be sent to vhost-user backend. This patch fixes ivshmem to store file descriptor of shared memory. It will be used when vhost-user negot

Re: [Qemu-devel] [RFC PATCH 7/9] net/colo-proxy: add packet enqueue and handle function

Hi,Dave On 12/03/2015 05:09 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: Hi,Dave On 12/02/2015 12:12 AM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: From: zhangchen Add common packet handle function and enqueue

Re: [Qemu-devel] net: vmxnet3: memory leakage issue

On 12/03/2015 03:17 PM, Dmitry Fleytman wrote: > Hello Prasad, > > The patch is good. > Jason, would you apply is from attachment or should it be resent by > "git send-email”? Better with "git send-email". And I've a question for this patch which needs to be answered before merging this. What i

Re: [Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

On 12/03/2015 03:24 PM, Dmitry Fleytman wrote: > Acked-by: Dmitry Fleytman mailto:dmi...@daynix.com>> Applied in my -net for 2.5. Thanks > >> On 3 Dec 2015, at 07:08 AM, Miao Yan > > wrote: >> >> Macro MAC_FMT and MAC_ARG are not defined, but used in >> vmxnet3_ne

Re: [Qemu-devel] [PATCH v6 05/23] qmp: Fix reference-counting of qnull on empty output visit

On 12/03/2015 10:50 AM, Markus Armbruster wrote: >>> So, how does this contraption work? >>> >>> A visitor cab encounter NULL only when it visits pointers (d'oh!). >>> Searching qapi-visit-core.c for **obj finds start_struct(), >>> start_implicit_struct(), type_str(), type_any(). >>> >>> As far as

Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}

On 12/03/2015 04:54 PM, David Gibson wrote: > On Thu, Dec 03, 2015 at 05:37:39PM +0100, Markus Armbruster wrote: >> prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't >> visit anything. object_property_get_qobject() happily >> object_property_get_qobject(). Amazingly, the latter

Re: [Qemu-devel] net: vmxnet3: memory leakage issue

On 12/02/2015 08:17 PM, P J P wrote: > Hello Dmitry, all > > A memory leakage issue was reported by Mr Qinghao Tang, CC'd here. > > In that, the Qemu VMXNET3 paravirtual device emulator does not check > if the device is already active, before activating it. This leads to > host memory leakage v

Re: [Qemu-devel] [PATCH] vhost: drop dead code

On 12/02/2015 07:50 PM, Michael S. Tsirkin wrote: > We dropped the implementation of vhost_dev_query, > drop it from the header file as well. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/virtio/vhost.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/hw/virtio/vhost.h

Re: [Qemu-devel] [2.5 issue] virtio-1 in virtio-net and old vhost

On 12/02/2015 06:11 PM, Cornelia Huck wrote: > On Wed, 2 Dec 2015 13:54:09 +0800 > Jason Wang wrote: > >> I wonder instead of rolling back in post_plugged(), maybe we could just >> delay the region setups to post_plugged(). > If this is the saner thing to do for pci, sure. > >> Or just call tra

Re: [Qemu-devel] [TCG only][Migration Bug? ] Occasionally, the content of VM's memory is inconsistent between Source and Destination of migration

> > Thanks for describing how to reproduce the bug. > If some pages are not transferred to destination then it is a bug, so we need > to know what the problem is, notice that the problem can be that TCG is not > marking dirty some page, that Migration code "forgets" about that page, or > anything

[Qemu-devel] Fwd: scripts/gdb: Fix a python exception in mtree.py

Ping. Add Peter Maydell. Thanks Wei -- Forwarded message -- From: Yang Wei Date: 2015-12-02 15:56 GMT+08:00 Subject: [Qemu-devel] scripts/gdb: Fix a python exception in mtree.py To: blauwir...@gmail.com, stefa...@redhat.com, a...@redhat.com Cc: qemu-devel@nongnu.org The followi

[Qemu-devel] Bug#807006: qemu: FTBFS on sparc64 due to incompatible linker parameters

Package: qemu Version: 1:2.4+dfsg-5 Severity: normal User: debian-sp...@lists.debian.org Usertags: sparc64 Hello! qemu currently fails to build from source on sparc64 because it sets both the linker parameters "-r" and "--relax": cc -nostdlib -Wl,-r -o block/iscsi.mo block/iscsi.o /usr/bin/ld: -

Re: [Qemu-devel] [PATCH 0/8] Raspberry Pi 2 support

> This patch series adds initial support for Raspberry Pi 2 > (bcm2836). It is heavily based on the original (out of tree) work of > Gregory Estrade, Stefan Weil and others to support Raspberry Pi 1. Apologies for the silence on this thread. My outbound SMTP server seems to be rejecting the patch

Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}

On Thu, Dec 03, 2015 at 05:37:39PM +0100, Markus Armbruster wrote: > prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't > visit anything. object_property_get_qobject() happily > object_property_get_qobject(). Amazingly, the latter survives the > misuse. Turns out we've papered

Re: [Qemu-devel] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device

On Thu, Dec 03, 2015 at 05:37:40PM +0100, Markus Armbruster wrote: > It should only be created via spapr_dr_connector_new(). Attempting to > create it with -device crashes. > > Signed-off-by: Markus Armbruster Acked-by: David Gibson > --- > hw/ppc/spapr_drc.c | 4 > 1 file changed, 4 in

Re: [Qemu-devel] Posible regressions around spapr-dr-connector property drc-connector[]

On Thu, Dec 03, 2015 at 04:30:31PM +0100, Markus Armbruster wrote: > 1. Before commit 94649d4 "spapr: Don't use QOM [*] syntax for DR >connectors", the indexes were small integers: > >(qemu) info qom-tree >/machine (pseries-2.4-machine) > /unattached (container) >

Re: [Qemu-devel] [PATCH for-2.5 0/3] spapr_drc: Last minute bug fixes

On Thu, Dec 03, 2015 at 07:15:15PM +0100, Markus Armbruster wrote: > Markus Armbruster writes: > > > I hope we can get these reviewed and applied in time. > > Peter, can you apply directly with 2/3's commit message fixed? Let me > know if you'd prefer a pull request. I've applied 1 & 3 to my p

Re: [Qemu-devel] Networking documentation for a Mac OS X guest

On 3 December 2015 at 23:24, Programmingkid wrote: > I would like to make a little tutorial on how to make networking > work for a Mac OS X guest. Where would you suggest I put such > documentation? The qemu-doc file is what I was thinking about using. Hmm. I think for "doing stuff for a particul

[Qemu-devel] [PATCH 0/8] Raspberry Pi 2 support

This patch series adds initial support for Raspberry Pi 2 (bcm2836). It is heavily based on the original (out of tree) work of Gregory Estrade, Stefan Weil and others to support Raspberry Pi 1. At the end of this series, it is possible to boot a recent raspbian kernel to a serial console using an

Re: [Qemu-devel] -device spapr-dr-connector crashes

On Thu, Dec 03, 2015 at 03:22:09PM +0100, Markus Armbruster wrote: > Watch this: > > $ qemu-system-ppc64 -nodefaults -S -display none -device > spapr-dr-connector > ** > ERROR:/home/armbru/work/qemu/hw/ppc/spapr_drc.c:45:get_type_shift: > assertion failed: (is_power_of_2(type)) >

Re: [Qemu-devel] [PATCH for-2.5 1/3] spapr_drc: Handle visitor errors properly

On Thu, Dec 03, 2015 at 05:37:38PM +0100, Markus Armbruster wrote: > Since prop_get_fdt() is only used with QmpOutputVisitor, errors > shouldn't actually happen, so this is only a latent bug. > > Signed-off-by: Markus Armbruster Acked-by: David Gibson > --- > hw/ppc/spapr_drc.c | 32 +

[Qemu-devel] Networking documentation for a Mac OS X guest

I would like to make a little tutorial on how to make networking work for a Mac OS X guest. Where would you suggest I put such documentation? The qemu-doc file is what I was thinking about using. The bulk of the information would be to add "-usb -net none -netdev user,id=mynet0 -device usb-net

Re: [Qemu-devel] [Qemu-ppc] [PATCH 41/77] ppc/pnv: Add LPC controller and hook it up with a UART and RTC

On Thu, 2015-12-03 at 12:45 +1100, David Gibson wrote: > > There are several different cases here and I'm not sure which you're > thinking about. > > 1) Guest has different number of threads-per-core than the host > > This one is just fine - PAPR defines how the guest should get the > number of

Re: [Qemu-devel] [Qemu-ppc] [PATCH 41/77] ppc/pnv: Add LPC controller and hook it up with a UART and RTC

On Thu, 2015-12-03 at 12:04 +1100, Alexey Kardashevskiy wrote: > On 12/02/2015 04:29 PM, Benjamin Herrenschmidt wrote: > > On Wed, 2015-12-02 at 13:24 +1100, Alexey Kardashevskiy wrote: > > > > But on the whole I agree with you, since the LPC is part of the P8 > > > > chip, I think it makes sense t

[Qemu-devel] [PATCH v2 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

Convert the pxa2xx_mmci device to be a sysbus device. Signed-off-by: Peter Maydell --- hw/sd/pxa2xx_mmci.c | 89 +++-- 1 file changed, 72 insertions(+), 17 deletions(-) diff --git a/hw/sd/pxa2xx_mmci.c b/hw/sd/pxa2xx_mmci.c index b217080..39ca309

[Qemu-devel] [PATCH v2 3/3] hw/sd/pxa2xx_mmci: Add reset function

Add a reset function to the pxa2xx_mmci device; previously it had no handling for system reset at all. Signed-off-by: Peter Maydell --- hw/sd/pxa2xx_mmci.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/hw/sd/pxa2xx_mmci.c b/hw/sd/pxa2xx_mmci.c index fd76ffe.

[Qemu-devel] [PATCH v2 0/3] hw/sd/pxa2xx_mmci: convert to sysbus and vmstate

This patchset updates the ancient pxa2xx_mmci device to something resembling modern standards for devices. In particular it makes it a proper sysbus device and switches to VMStateDescription structs. The only change here (apart from a trivial rebase) is that since I sent the first version, commit

[Qemu-devel] [PATCH v2 2/3] hw/sd/pxa2xx_mmci: Convert to VMStateDescription

Convert the pxa2xx_mmci device from manual save/load functions to a VMStateDescription structure. This is a migration compatibility break. Signed-off-by: Peter Maydell --- hw/sd/pxa2xx_mmci.c | 149 1 file changed, 57 insertions(+), 92 deleti

Re: [Qemu-devel] [PATCH] target-arm: raise exception on misaligned LDREX operands

On 3 December 2015 at 21:21, Richard Henderson wrote: > On 12/03/2015 07:08 AM, Peter Maydell wrote: >> On 3 December 2015 at 14:58, Laurent Desnogues >> wrote: >>> After quickly looking at the code in softmmu_template.h, I wonder if >>> MO_ALIGN would correcly handle the ldrexd pair case which r

Re: [Qemu-devel] [PATCH 1/3] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

On 7 September 2015 at 17:57, Markus Armbruster wrote: > Peter Maydell writes: > >> On 7 September 2015 at 17:40, Markus Armbruster wrote: >>> Peter Maydell writes: >>> Convert the pxa2xx_mmci device to be a sysbus device. >> +static Property pxa2xx_mmci_properties[] = { +/*

Re: [Qemu-devel] [PATCH] target-arm: raise exception on misaligned LDREX operands

On 12/03/2015 07:08 AM, Peter Maydell wrote: > On 3 December 2015 at 14:58, Laurent Desnogues > wrote: >> On Thu, Dec 3, 2015 at 3:36 PM, Peter Maydell >> wrote: >>> On 30 November 2015 at 22:23, Andrew Baumann >>> wrote: Qemu does not generally perform alignment checks. However, the ARM A

Re: [Qemu-devel] [PULL for-2.5 0/4] QOM devices patch queue 2015-12-03

On 3 December 2015 at 19:45, Andreas Färber wrote: > Hello Peter, > > This is my QOM (devices) patch queue for 2.5. Please pull. > > Regards, > Andreas > > Cc: Peter Maydell > Cc: Markus Armbruster > Cc: Marc-André Lureau > > The following changes since commit 4c65fed8bdf96780735dbdb92a8bd0d6b6

Re: [Qemu-devel] [RFC 01/12] vfio: Start improving VFIO/EEH interface

On Thu, 2015-12-03 at 15:22 +1100, David Gibson wrote: > On Wed, Dec 02, 2015 at 01:09:34PM -0700, Alex Williamson wrote: > > On Tue, 2015-12-01 at 13:23 +1100, David Gibson wrote: > > > On Mon, Nov 23, 2015 at 02:58:11PM -0700, Alex Williamson wrote: > > > > On Thu, 2015-11-19 at 15:29 +1100, Davi

Re: [Qemu-devel] [PATCH v2 6/6] target-arm: dump-guest-memory: add fpregset notes

On 3 December 2015 at 19:00, Andrew Jones wrote: > On Thu, Dec 03, 2015 at 12:27:34PM +, Peter Maydell wrote: >> Do consumers care if we write out a dump with FP register >> state for a CPU which doesn't implement FP? (For AArch64 >> FP is always present, but for AArch32 it may not be.) > > I

Re: [Qemu-devel] [PATCH v2 5/6] target-arm: support QMP dump-guest-memory

On 3 December 2015 at 18:55, Andrew Jones wrote: > On Thu, Dec 03, 2015 at 11:44:05AM +, Peter Maydell wrote: >> On 25 November 2015 at 00:37, Andrew Jones wrote: >> > Add the support needed for creating prstatus elf notes. This >> > allows us to use QMP dump-guest-memory. >> >> > + >> > +

[Qemu-devel] [PULL 3/4] tests: Use proper functions types instead of void (*fn)

From: Markus Armbruster We have several function parameters declared as void (*fn). This is just a stupid way to write void *, and the only purpose writing it like that could serve is obscuring the sin of bypassing the type system without need. The original sin is commit 49ee359: its qtest_add_

[Qemu-devel] [PULL 4/4] qom-test: Fix qmp() leaks

From: Marc-André Lureau Before this patch ASAN reported: SUMMARY: AddressSanitizer: 677165875 byte(s) leaked in 1272437 allocation(s) After this patch: SUMMARY: AddressSanitizer: 465 byte(s) leaked in 32 allocation(s) Signed-off-by: Marc-André Lureau Message-Id: <1448551895-871-1-git-send-emai

[Qemu-devel] [PULL 1/4] tests: Fix check-report-qtest-% target

Commit e253c28 ("tests: Fix how qom-test is run") introduced $(qtest-generic-y) and used it for check-qtest-% target, but did not update check-report-qtest-%. This causes check-report-qtest-aarch64.xml target to fail with a gtester usage error for lack of test arguments. Fix this by adding $(qtest

[Qemu-devel] [PULL for-2.5 0/4] QOM devices patch queue 2015-12-03

Hello Peter, This is my QOM (devices) patch queue for 2.5. Please pull. Regards, Andreas Cc: Peter Maydell Cc: Markus Armbruster Cc: Marc-André Lureau The following changes since commit 4c65fed8bdf96780735dbdb92a8bd0d6b6526cc3: ui: vnc: avoid floating point exception (2015-12-03 13:34:50

[Qemu-devel] [PULL 2/4] qom: Update documentation comment of struct Object

From: Cao jin It doesn't have "GSList *interfaces" anymore, drop the paragraph. Signed-off-by: Cao jin Signed-off-by: Andreas Färber --- include/qom/object.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index f172fea..4509166 100644 --- a/i

Re: [Qemu-devel] [PATCH for-2.5 2/2] qom-test: fix qmp() leaks

Am 02.12.2015 um 21:44 schrieb Eric Blake: > On 12/02/2015 01:20 PM, Markus Armbruster wrote: >> From: Marc-André Lureau >> >> Before this patch ASAN reported: >> SUMMARY: AddressSanitizer: 677165875 byte(s) leaked in 1272437 allocation(s) >> >> After this patch: >> SUMMARY: AddressSanitizer: 465

Re: [Qemu-devel] [PATCH] Trivial: update comment of struct Object

Am 29.11.2015 um 11:48 schrieb Michael Tokarev: > 05.11.2015 10:39, Cao jin wrote: >> it don`t has "GSList *interfaces" anymore > > Andreas, should this be applied? It's been on the list for long already, > and you said I shouldn't apply qom patches... I seem to have missed this for the last pul

Re: [Qemu-devel] [PATCH for-2.5 v2] tests: Fix check-report-qtest-% target

Am 03.12.2015 um 20:06 schrieb Markus Armbruster: > Andreas Färber writes: > >> Commit e253c28 ("tests: Fix how qom-test is run") introduced >> $(qtest-generic-y) and used it for check-qtest-% target, but did not >> update check-report-qtest-%. This causes check-report-qtest-aarch64.xml >> target

Re: [Qemu-devel] [PATCH for-2.5 v2] tests: Fix check-report-qtest-% target

Andreas Färber writes: > Commit e253c28 ("tests: Fix how qom-test is run") introduced > $(qtest-generic-y) and used it for check-qtest-% target, but did not > update check-report-qtest-%. This causes check-report-qtest-aarch64.xml > target to fail with a gtester usage error for lack of test argum

[Qemu-devel] [PATCH for-2.5 v2] tests: Fix check-report-qtest-% target

Commit e253c28 ("tests: Fix how qom-test is run") introduced $(qtest-generic-y) and used it for check-qtest-% target, but did not update check-report-qtest-%. This causes check-report-qtest-aarch64.xml target to fail with a gtester usage error for lack of test arguments. Fix this by adding $(qtest

Re: [Qemu-devel] [PATCH v2 6/6] target-arm: dump-guest-memory: add fpregset notes

On Thu, Dec 03, 2015 at 12:27:34PM +, Peter Maydell wrote: > On 25 November 2015 at 00:37, Andrew Jones wrote: > > Also refactors note init code to avoid code duplication. > > Can you squash those parts down into the preceding patch? Sure, but there wasn't any duplication of code in the firs

Re: [Qemu-devel] [PATCH v2 5/6] target-arm: support QMP dump-guest-memory

On Thu, Dec 03, 2015 at 11:44:05AM +, Peter Maydell wrote: > On 25 November 2015 at 00:37, Andrew Jones wrote: > > Add the support needed for creating prstatus elf notes. This > > allows us to use QMP dump-guest-memory. > > > + > > +if (is_a64(env)) { > > +for (i = 0; i < 31; ++i)

[Qemu-devel] [PATCH v2] target-arm: raise exception on misaligned LDREX operands

Qemu does not generally perform alignment checks. However, the ARM ARM requires implementation of alignment exceptions for a number of cases including LDREX, and Windows-on-ARM relies on this. This change adds plumbing to enable alignment checks on loads using MO_ALIGN, a do_unaligned_access hook

Re: [Qemu-devel] [RFC PATCH V2 00/10] Qemu: Add live migration support for SRIOV NIC

On Wed, Dec 2, 2015 at 6:08 AM, Lan, Tianyu wrote: > On 12/1/2015 11:02 PM, Michael S. Tsirkin wrote: >>> >>> But >>> it requires guest OS to do specific configurations inside and rely on >>> bonding driver which blocks it work on Windows. >>> From performance side, >>> putting VF and virtio NIC

Re: [Qemu-devel] [PATCH v2 0/2] target-i386: MMReg struct cleanup

On Wed, Dec 02, 2015 at 08:45:54AM -0800, Richard Henderson wrote: > On 12/02/2015 07:51 AM, Eduardo Habkost wrote: > >Changes v1 -> v2: > >* Other patches from v1 are already in x86-next branch > >* MMREG_UNION argument is now the number of bits > >* Removed [RFC] tag > > > >Eduardo Habkost (2): >

Re: [Qemu-devel] [PATCH for-2.5 0/3] spapr_drc: Last minute bug fixes

Markus Armbruster writes: > I hope we can get these reviewed and applied in time. Peter, can you apply directly with 2/3's commit message fixed? Let me know if you'd prefer a pull request.

Re: [Qemu-devel] [PATCH] vfio: Align iova also to IOMMU page size

On Thu, 2015-12-03 at 17:36 +, Peter Maydell wrote: > On 3 December 2015 at 17:19, Alex Williamson > wrote: > > On Thu, 2015-12-03 at 16:33 +, Peter Maydell wrote: > >> On 3 December 2015 at 16:26, Alex Williamson > >> wrote: > >> > I feel a lot more comfortable if we limit the scope to

Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}

Eric Blake writes: > On 12/03/2015 10:13 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 12/03/2015 09:37 AM, Markus Armbruster wrote: prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't visit anything. object_property_get_qobject() happily object_p

Re: [Qemu-devel] [PATCH v6 05/23] qmp: Fix reference-counting of qnull on empty output visit

Eric Blake writes: > On 11/27/2015 06:06 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Commit 6c2f9a15 ensured that we would not return NULL when the >>> caller used an output visitor but had nothing to visit. But >>> in doing so, it added a FIXME about a reference count leak >>> th

Re: [Qemu-devel] [PATCH] vfio: Align iova also to IOMMU page size

On 3 December 2015 at 17:19, Alex Williamson wrote: > On Thu, 2015-12-03 at 16:33 +, Peter Maydell wrote: >> On 3 December 2015 at 16:26, Alex Williamson >> wrote: >> > I feel a lot more comfortable if we limit the scope to MMIO regions of >> > PCI devices. The problems I brought up before

Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}

On 12/03/2015 10:13 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 12/03/2015 09:37 AM, Markus Armbruster wrote: >>> prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't >>> visit anything. object_property_get_qobject() happily >>> object_property_get_qobject(). Amazi

Re: [Qemu-devel] [PATCH 00/13] acpi: Make piix-specific and q35-specific code generic

On Thu, Dec 03, 2015 at 04:19:19PM +0100, Igor Mammedov wrote: > On Wed, 2 Dec 2015 20:22:45 -0200 > Eduardo Habkost wrote: > > > This series removes piix-specific and q35-specific code from > > acpi-build.c, making it generic and without direct dependencies > > to piix and q35 code. > we are co

Re: [Qemu-devel] [PATCH] vfio: Align iova also to IOMMU page size

On Thu, 2015-12-03 at 16:33 +, Peter Maydell wrote: > On 3 December 2015 at 16:26, Alex Williamson > wrote: > > I feel a lot more comfortable if we limit the scope to MMIO regions of > > PCI devices. The problems I brought up before about the device not > > being able to DMA to a target alig

Re: [Qemu-devel] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device

On 03/12/15 17:37, Markus Armbruster wrote: > It should only be created via spapr_dr_connector_new(). Attempting to > create it with -device crashes. > > Signed-off-by: Markus Armbruster > --- > hw/ppc/spapr_drc.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/hw/ppc/spapr_drc.c

  1   2   3   >