[Qemu-devel] [PATCH v2 1/1] i386: expose floppy-related objects in SSDT

2015-12-15 Thread Denis V. Lunev
From: Roman Kagan On x86-based systems Linux determines the presence and the type of floppy drives via a query of a CMOS field. So does SeaBIOS when populating the return data for int 0x13 function 0x08. Windows doesn't; instead, it requests this information from BIOS via int 0x13/0x08 or throu

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 1/2] Use error_fatal to simplify obvious fatal errors

2015-12-15 Thread Markus Armbruster
Peter Maydell writes: > On 14 December 2015 at 19:25, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >>> On Thu, Dec 10, 2015 at 05:29:14PM +0100, Markus Armbruster wrote: Done with this admittedly crude Coccinelle semantic patch: >>> >>> Reviewed-by: Eduardo Habkost >>> >>>

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Thomas Huth
On 15/12/15 19:08, Paolo Bonzini wrote: > > > On 15/12/2015 18:50, Thomas Huth wrote: >> On 15/12/15 18:31, Paolo Bonzini wrote: >>> >>> On 15/12/2015 18:15, Thomas Huth wrote: On 15/12/15 17:21, Paolo Bonzini wrote: >> [...] > For example you could print all DEVICE_CATEGORY_NETWORK devi

[Qemu-devel] RFC: Operation Blockers in QEMU Block Nodes

2015-12-15 Thread Jeff Cody
Background: Block jobs, and other QAPI operations, may modify and impact the BlockDriverState graph in QEMU. In order to support multiple operations safely, we need a mechanism to block and gate operations, We currently have op blockers, that are attached to each BDS. However, in pra

[Qemu-devel] [PATCH v2 3/4] target-ppc: Handle NMI guest exit

2015-12-15 Thread Aravinda Prasad
Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit reason set to KVM_EXIT_NMI in suc

[Qemu-devel] [PATCH v2 2/4] spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2015-12-15 Thread Aravinda Prasad
This patch adds support in QEMU to handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls. The machine check notification address is saved when the OS issues "ibm,nmi-register" RTAS call. This patch also handles the case when multiple processors experience machine check at or about the same

[Qemu-devel] [PATCH v2 4/4] spapr: Introduce FWNMI KVM capability

2015-12-15 Thread Aravinda Prasad
Introduce a new KVM capability to control how KVM behaves on machine check exception. Without this capability, KVM redirects machine check exceptions to guest's 0x200 vector if the address in error belongs to guest. With this capability KVM causes a guest exit with NMI exit reason. This is requir

[Qemu-devel] [PATCH v2 1/4] spapr: Register and handle HCALL to receive updated RTAS region

2015-12-15 Thread Aravinda Prasad
Receive updates from SLOF about the updated rtas-base. A separate patch for SLOF [1] adds functionality to invoke a private HCALL whenever OS issues instantiate-rtas with a new rtas-base. This is required as QEMU needs to know the updated rtas-base as it allocates error reporting structure in RTAS

[Qemu-devel] [PATCH v2 0/4] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2015-12-15 Thread Aravinda Prasad
This series of patches add support for FWNMI in PowerKVM guests. Memory error such as bit flips that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine check exception, if the address in error belongs to guest then

Re: [Qemu-devel] [PATCH COLO-Frame v12 26/38] COLO failover: Shutdown related socket fd when do failover

2015-12-15 Thread Hailiang Zhang
On 2015/12/15 18:23, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: If the net connection between COLO's two sides is broken while colo/colo incoming thread is blocked in 'read'/'write' socket fd. It will not detect this error until connect timeout. It wi

Re: [Qemu-devel] [PATCH COLO-Frame v12 05/38] migration: Add state records for migration incoming

2015-12-15 Thread Hailiang Zhang
On 2015/12/16 1:36, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: For migration destination, we also need to know its state, we will use it in COLO. Here we add a new member 'state' for MigrationIncomingState, and also use migrate_set_state() to modify it

Re: [Qemu-devel] [PATCH 3/6] Postcopy: Send events/change state on incoming side

2015-12-15 Thread Hailiang Zhang
On 2015/12/16 3:02, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" I missed the calls to send migration events on the destination side as we enter postcopy. Take care when adding them not to do it after state has been freed. Signed-off-by: Dr. David Alan Gilbert --- migr

[Qemu-devel] [PATCH] iscsi: fix readcapacity error message

2015-12-15 Thread Zhu Lingshan
fix:The error message for readcapacity 16 incorrectly mentioned a readcapacity 10 failure, fixed the error message. Signed-off-by: Zhu Lingshan --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index bd1f1bf..eb28ddc 100644 --- a/

Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: fix readcapacity error message

2015-12-15 Thread Zhu Lingshan
OK, thanks, I have sent the patch again and CC them On 12/16/2015 04:20 AM, John Snow wrote: CC qemu-trivial, I think this can go in through that tree. On 12/14/2015 10:33 PM, Zhu Lingshan wrote: fix:The error message for readcapacity 16 incorrectly mentioned a readcapacity 10 failure, fixed t

Re: [Qemu-devel] [Qemu-block] [PATCH] raw-posix: Make aio=native option binding

2015-12-15 Thread Stefan Hajnoczi
On Tue, Dec 15, 2015 at 11:42:23AM +0100, Kevin Wolf wrote: > Traditionally, aio=native was treated as an advice that could simply be > ignored if an error occurs while initialising Linux AIO or the feature > wasn't compiled in. This behaviour was deprecated in commit 96518254 > (qemu 2.3; error du

Re: [Qemu-devel] guest kernel in the host RAM

2015-12-15 Thread Stefan Hajnoczi
On Tue, Dec 15, 2015 at 02:27:14PM +0300, Denis V. Lunev wrote: > There is a plan or idea to improve current implementation > of Clear Containers for QEMU. Patches about NVDIMM > are floating in the list, you have proposed special > boot firmware for a case. By the way, Marc Mari is working on add

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add an entry for the net/slirp.c file

2015-12-15 Thread Jason Wang
On 12/15/2015 04:48 PM, Thomas Huth wrote: > The file net/slirp.c should be listed in the SLIRP section, too. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e8cee1e..a87b113 100644 > --- a/MAINTAINERS

Re: [Qemu-devel] [PATCH 6/6] multithread decompression: Avoid one copy

2015-12-15 Thread Li, Liang Z
> From: "Dr. David Alan Gilbert" > > qemu_get_buffer does a copy, we can avoid the memcpy, and we can then > remove the extra buffer. > > Signed-off-by: Dr. David Alan Gilbert > --- > migration/ram.c | 11 +++ > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/migratio

Re: [Qemu-devel] Question about nonblocking stderr and lost logs

2015-12-15 Thread Sam Bobroff
On Mon, Dec 14, 2015 at 03:29:49PM +0800, Stefan Hajnoczi wrote: > On Mon, Dec 14, 2015 at 04:19:50PM +1100, Sam Bobroff wrote: > > On Thu, Dec 10, 2015 at 04:37:22PM +0800, Stefan Hajnoczi wrote: > > > On Mon, Dec 07, 2015 at 02:22:18PM +1100, Sam Bobroff wrote: > > > > On Fri, Dec 04, 2015 at 02:

Re: [Qemu-devel] [RFC] qemu-system-arm: cortex-m gdb registers

2015-12-15 Thread Christopher Friedt
Just to update everyone, there is a thread on gdb-patches here [1] that is awaiting consensus before a patch is submitted that we may pull into qemu. [1] https://goo.gl/FyUvQu

[Qemu-devel] [PATCH v3 6/9] target-arm: support QMP dump-guest-memory

2015-12-15 Thread Andrew Jones
Add the support needed for creating prstatus elf notes. This allows us to use QMP dump-guest-memory. Signed-off-by: Andrew Jones --- target-arm/Makefile.objs | 3 +- target-arm/arch_dump.c | 230 +++ target-arm/cpu-qom.h | 5 ++ target-arm/cp

[Qemu-devel] [PATCH v3 8/9] elf: add arm note types

2015-12-15 Thread Andrew Jones
Signed-off-by: Andrew Jones --- include/elf.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/elf.h b/include/elf.h index 66add810df144..1098d217ec7ff 100644 --- a/include/elf.h +++ b/include/elf.h @@ -1471,6 +1471,11 @@ typedef struct elf64_shdr { #define NT_PPC_VMX 0x100

[Qemu-devel] [PATCH v3 9/9] target-arm: dump-guest-memory: add vfp notes for arm

2015-12-15 Thread Andrew Jones
gdb won't actually dump these with 'info all-registers' since it first tries to confirm that it should by checking the VFP hwcap in the .auxv note. Well, we don't generate an .auxv note. Signed-off-by: Andrew Jones --- target-arm/arch_dump.c | 49 ++---

[Qemu-devel] [PATCH v3 5/9] target-arm: introduce aarch64_compat_sp

2015-12-15 Thread Andrew Jones
Signed-off-by: Andrew Jones --- target-arm/cpu.h | 45 + 1 file changed, 45 insertions(+) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 815fef8a30663..9231a9ff3b9c2 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@ -863,6 +863,51 @@ enum

[Qemu-devel] [PATCH v3 4/9] dump: allow target to set the physical base

2015-12-15 Thread Andrew Jones
crash assumes the physical base in the kdump subheader of makedumpfile formatted dumps is correct. Zero is not correct for all architectures, so allow it to be changed. (No functional change.) Signed-off-by: Andrew Jones Reviewed-by: Peter Maydell --- dump.c | 4 ++-- inclu

[Qemu-devel] [PATCH v3 7/9] target-arm: dump-guest-memory: add prfpreg notes for aarch64

2015-12-15 Thread Andrew Jones
Signed-off-by: Andrew Jones --- target-arm/arch_dump.c | 79 +- 1 file changed, 71 insertions(+), 8 deletions(-) diff --git a/target-arm/arch_dump.c b/target-arm/arch_dump.c index dc32d98101004..6cbba92f3d014 100644 --- a/target-arm/arch_dump.c +++

[Qemu-devel] [PATCH v3 3/9] dump: allow target to set the page size

2015-12-15 Thread Andrew Jones
This is necessary for targets that don't have TARGET_PAGE_SIZE == real-target-page-size. The target should set the page size to the correct one, if known, or, if not known, to the maximum page size it supports. (No functional change.) Signed-off-by: Andrew Jones --- dump.c |

[Qemu-devel] [PATCH v3 1/9] qapi-schema: dump-guest-memory: Improve text

2015-12-15 Thread Andrew Jones
dump-guest-memory is supported by more than just x86, however the paging option is not. (No functional change.) Signed-off-by: Andrew Jones Reviewed-by: Eric Blake --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json i

[Qemu-devel] [PATCH v3 0/9] target-arm: enable qmp-dump-guest-memory

2015-12-15 Thread Andrew Jones
This series brings qmp-dump-guest-memory to arm and aarch64 targets. I've detailed my testing and the results in the following table. v3: - more changes thanks to Peter's review comments - fix 32-to-64 shoehorning to work better with EL2/EL3 - stole comment from Peter for best-effort at end

[Qemu-devel] [PATCH v3 2/9] dump: qemunotes aren't commonly needed

2015-12-15 Thread Andrew Jones
Only one of three architectures implementing qmp-dump-guest-memory write qemu notes. And, another architecture (arm/aarch64) is coming, which won't use them either. Make the common implementation truly common. (No functional change.) Signed-off-by: Andrew Jones Reviewed-by: Peter Maydell --- q

[Qemu-devel] [PATCH v2 1/3] virtio: cache used_idx in a VirtQueue field

2015-12-15 Thread Vincenzo Maffione
Accessing used_idx in the VQ requires an expensive access to guest physical memory. Before this patch, 3 accesses are normally done for each pop/push/notify call. However, since the used_idx is only written by us, we can track it in our internal data structure. Signed-off-by: Vincenzo Maffione --

[Qemu-devel] [PATCH v2 2/3] virtio: read avail_idx from VQ only when necessary

2015-12-15 Thread Vincenzo Maffione
The virtqueue_pop() implementation needs to check if the avail ring contains some pending buffers. To perform this check, it is not always necessary to fetch the avail_idx in the VQ memory, which is expensive. This patch introduces a shadow variable tracking avail_idx and modifies virtio_queue_empt

[Qemu-devel] [PATCH v2 3/3] virtio: combine write of an entry into used ring

2015-12-15 Thread Vincenzo Maffione
Fill in an element of the used ring with a single combined access to the guest physical memory, rather than using two separated accesses. This reduces the overhead due to expensive address translation. Signed-off-by: Vincenzo Maffione --- hw/virtio/virtio.c | 25 - 1 file

[Qemu-devel] [PATCH v2 0/3] virtio: proposal to optimize accesses to VQs

2015-12-15 Thread Vincenzo Maffione
Hi, I am doing performance experiments to test how QEMU behaves when the guest is transmitting (short) network packets at very high packet rates, say over 1Mpps. I run a netmap application in the guest to generate high packet rates, but this is not relevant to this discussion. The only important

Re: [Qemu-devel] [PATCH for-2.6 v2 01/10] fdc: move pick_geometry

2015-12-15 Thread John Snow
On 12/15/2015 04:51 PM, Hervé Poussineau wrote: > Le 08/12/2015 00:34, John Snow a écrit : >> Code motion: I want to refactor this function to work with FDrive >> directly, so shuffle it below that definition. >> >> Signed-off-by: John Snow >> --- >> hw/block/fdc.c | 90 >>

Re: [Qemu-devel] [PATCH v1 00/15] data-driven device registers

2015-12-15 Thread Peter Maydell
On 15 December 2015 at 20:52, Peter Crosthwaite wrote: > It needs to exist before it can be used so there is a bit of a chicken > and egg problem there. Right, but the hope would be that there's somebody who cares about device models who thinks it's worthwhile... if we really do only have three p

Re: [Qemu-devel] [PATCH for-2.6 v2 01/10] fdc: move pick_geometry

2015-12-15 Thread Hervé Poussineau
Le 08/12/2015 00:34, John Snow a écrit : Code motion: I want to refactor this function to work with FDrive directly, so shuffle it below that definition. Signed-off-by: John Snow --- hw/block/fdc.c | 90 +- 1 file changed, 45 insertions

Re: [Qemu-devel] [PATCH 4/6] Migration: Emit event at start of pass

2015-12-15 Thread Eric Blake
On 12/15/2015 12:02 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Emit an event each time we sync the dirty bitmap on the source; > this helps libvirt use postcopy by giving it a kick when it > might be a good idea to start the postcopy. > > Signed-off-by: Dr. Davi

Re: [Qemu-devel] [PATCH] target-*: Get rid of "PC advancement" trick

2015-12-15 Thread Sergey Fedorov
On 12/14/15 19:19, Richard Henderson wrote: On 12/12/2015 12:02 PM, Sergey Fedorov wrote: On 12/12/15 02:39, Richard Henderson wrote: On 12/10/2015 10:47 AM, Sergey Fedorov wrote: The "PC advancement" trick was used just after recognizing that a breakpoint exception was going to be generated.

Re: [Qemu-devel] [PATCH v1 00/15] data-driven device registers

2015-12-15 Thread Peter Crosthwaite
On Tue, Dec 15, 2015 at 11:46 AM, Peter Maydell wrote: > On 30 October 2015 at 08:06, Peter Maydell wrote: >> On 30 October 2015 at 06:52, Peter Crosthwaite >> wrote: >>> Ping^3 >>> >>> This has been on list for a very long time without 3rd party review. >>> Can I send a PULL? >> >> I would pref

Re: [Qemu-devel] [Qemu-block] [PATCH] iscsi: fix readcapacity error message

2015-12-15 Thread John Snow
CC qemu-trivial, I think this can go in through that tree. On 12/14/2015 10:33 PM, Zhu Lingshan wrote: > fix:The error message for readcapacity 16 incorrectly mentioned > a readcapacity 10 failure, fixed the error message. > > Signed-off-by: Zhu Lingshan > --- > block/iscsi.c | 2 +- > 1 file c

Re: [Qemu-devel] [PATCH for-2.6 v2 04/10] fdc: add default drive type option

2015-12-15 Thread Eric Blake
On 12/14/2015 01:05 PM, John Snow wrote: > I was actually contemplating re-spinning this for a v3: > > Instead of having a "typeA" and "typeB" properties of the FDC, I'll just > spin the properties in such a way that they write directly to > FDCtrl.drives[n].drive, which avoids the need for two n

Re: [Qemu-devel] [PATCH v10 0/6] QEMU support for KVM Guest Debug on arm64

2015-12-15 Thread Peter Maydell
On 8 December 2015 at 18:32, Alex Bennée wrote: > Hi, > > Here is the latest patch set to support debugging of KVM guests on > arm64. The main changes are fixing arm32 compiles (mostly with stubs > for the upcomming arm32 debug) and the usual bunch of minor tweaks and > clarifications following re

[Qemu-devel] [PATCH 5/6] Use qemu_get_buffer_in_place for xbzrle data

2015-12-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Avoid a data copy (if we're lucky) in the xbzrle code. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 102d1f2..994552c 100644 --- a/migrat

Re: [Qemu-devel] [RFC PATCH 0/6] decouple board headers from cpu.h

2015-12-15 Thread Peter Maydell
On 15 December 2015 at 14:28, Paolo Bonzini wrote: > These patches are perhaps the only somewhat controversial part. > Generally, we add opaque typedefs to typedefs.h in order to avoid > indirect header inclusions. However, this might not be desirable > for target specific types such as FooCPU.

Re: [Qemu-devel] [PATCH v5 01/10] acpi: support serialized method

2015-12-15 Thread Shannon Zhao
On 2015/12/16 0:54, Peter Maydell wrote: On 11 December 2015 at 03:21, Shannon Zhao wrote: >From: Xiao Guangrong > >Add serialized method support so that explicit Mutex can be >avoided > >Signed-off-by: Xiao Guangrong >Signed-off-by: Igor Mammedov >Reviewed-by: Shannon Zhao Shannon, this pat

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Paolo Bonzini
On 15/12/2015 18:15, Thomas Huth wrote: > On 15/12/15 17:21, Paolo Bonzini wrote: >> On 15/12/2015 17:01, Thomas Huth wrote: >>> Some options work with "-net", some only work with "-netdev", >>> and the ones that work with both often also behave slightly differently (see >>> [1] for example). >>

Re: [Qemu-devel] [PATCH v1 00/15] data-driven device registers

2015-12-15 Thread Peter Maydell
On 30 October 2015 at 08:06, Peter Maydell wrote: > On 30 October 2015 at 06:52, Peter Crosthwaite > wrote: >> Ping^3 >> >> This has been on list for a very long time without 3rd party review. >> Can I send a PULL? > > I would prefer not to take a new unreviewed feature > in softfreeze for 2.5...

Re: [Qemu-devel] [PATCH v5 02/10] acpi: extend aml_interrupt() to support multiple irqs

2015-12-15 Thread Peter Maydell
On 11 December 2015 at 03:21, Shannon Zhao wrote: > From: Igor Mammedov > > ASL Interrupt() macro translates to Extended Interrupt Descriptor > which supports variable number of IRQs. It will be used for > conversion of ASL code for pc/q35 machines that use it for > returning several IRQs in _PSR

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Thomas Huth
On 15/12/15 17:17, Peter Maydell wrote: > On 15 December 2015 at 12:51, Paolo Bonzini wrote: >> Honestly, I still do not believe that they will be removed. They are >> little more than syntactic sugar at this point. > > If they're just syntactic sugar, what is the new-style command > line mechan

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Thomas Huth
On 15/12/15 18:31, Paolo Bonzini wrote: > > On 15/12/2015 18:15, Thomas Huth wrote: >> On 15/12/15 17:21, Paolo Bonzini wrote: [...] >>> For example you could print all DEVICE_CATEGORY_NETWORK devices that >>> support device_add. >> >> I think that would not work since spapr-vlan is not hot-plugga

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Thomas Huth
On 15/12/15 13:51, Paolo Bonzini wrote: > > On 15/12/2015 12:46, Thomas Huth wrote: >> We likely don't want to maintain the legacy -net options forever, >> so let's start informing the users that this option will be >> removed in a future version. However, there are two cases where >> we should no

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Eric Blake
On 12/15/2015 09:21 AM, Paolo Bonzini wrote: > > In fact there isn't much shared code in the is_netdev=0 and is_netdev=1 > cases. Perhaps you could just make a shared function with just > > if (net_client_init_fun[opts->type](opts, name, peer, errp) < 0) { > /* FIXME drop when all i

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Thomas Huth
On 15/12/15 17:21, Paolo Bonzini wrote: > > > On 15/12/2015 17:01, Thomas Huth wrote: >> Some options work with "-net", some only work with "-netdev", >> and the ones that work with both often also behave slightly differently (see >> [1] for example). > > This example is about -net nic, which yo

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Peter Maydell
On 15 December 2015 at 12:51, Paolo Bonzini wrote: > Honestly, I still do not believe that they will be removed. They are > little more than syntactic sugar at this point. If they're just syntactic sugar, what is the new-style command line mechanism for configuring boards with embedded network c

[Qemu-devel] [PATCH 1/6] migration: Export migrate_set_state()

2015-12-15 Thread Dr. David Alan Gilbert (git)
From: zhanghailiang Fix the first parameter of migrate_set_state(), and export it. We will use it in later. Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 2 ++ migration/migration.c | 36 +--- 2 fi

[Qemu-devel] virtio console users wrong port (sometimes)

2015-12-15 Thread Neil McGill
Has anyone ever seen an issue with qemu where the consoles wind up mixed up ? i.e hvc0 appears on vserial3, hvc1 on vserial0 as a random example . I've managed to reproduce this on qemu 2.0 and 1.0 on ubuntu LTS 14/12 and it happens 1 in every 16 times or so. However, I build qemu from source (t

Re: [Qemu-devel] [PATCH v2 00/19] Add support for multiple address spaces per CPU and use it for ARM TrustZone

2015-12-15 Thread Peter Maydell
Ping for a review request now we're pretty nearly done with 2.5 ? thanks -- PMM On 16 November 2015 at 14:05, Peter Maydell wrote: > This patch series adds support to QEMU's core exec/memory code for > CPUs which have more than one address space, and uses it for > ARM TrustZone. In particular,

[Qemu-devel] [PATCH 0/6] Migration: Small fixes and improvements

2015-12-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This is a set of 4 small fixes and improvements I've been collecting during the 2.5 freeze; I've added in a couple of Zhanghailiang's patches that are easier to merge before rather than after. (Of which one I've added a small fix of my own, see the message) Jiri wa

Re: [Qemu-devel] [PATCH v4 3/5] xilinx_spips: Seperate the state struct into a header

2015-12-15 Thread Peter Maydell
On 23 November 2015 at 08:54, Alistair Francis wrote: > Seperate out the XilinxSPIPS struct into a seperate header > file. If you need to respin this series it would be nice to fix the typos here and in the subject: it is "separate". thanks -- PMM

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 1/2] Use error_fatal to simplify obvious fatal errors

2015-12-15 Thread Peter Maydell
On 14 December 2015 at 19:25, Markus Armbruster wrote: > Eduardo Habkost writes: > >> On Thu, Dec 10, 2015 at 05:29:14PM +0100, Markus Armbruster wrote: >>> Done with this admittedly crude Coccinelle semantic patch: >>> >> >> Reviewed-by: Eduardo Habkost >> >> You can rewrite the semantic patch

Re: [Qemu-devel] [PATCH] target-arm: Fix and improve AA32 singlestep translation completion code

2015-12-15 Thread Peter Maydell
On 25 November 2015 at 18:02, Sergey Fedorov wrote: > The AArch32 translation completion code for singlestep enabled/active > case was a way more confusing and too repetitive then it needs to be. > Probably that was the cause for a bug to be introduced into it at some > point. The bug was that SWI

[Qemu-devel] [PATCH 3/6] Postcopy: Send events/change state on incoming side

2015-12-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" I missed the calls to send migration events on the destination side as we enter postcopy. Take care when adding them not to do it after state has been freed. Signed-off-by: Dr. David Alan Gilbert --- migration/savevm.c | 22 +++--- 1 file changed,

[Qemu-devel] [PATCH 2/6] migration: Add state records for migration incoming

2015-12-15 Thread Dr. David Alan Gilbert (git)
From: zhanghailiang For migration destination, we also need to know its state, we will use it in COLO. Here we add a new member 'state' for MigrationIncomingState, and also use migrate_set_state() to modify its value. Signed-off-by: zhanghailiang dgilbert: Fixed early free of MigraitonIncomin

Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

2015-12-15 Thread Radim Krcmar
2015-12-15 05:43-0500, Paolo Bonzini: >> Hi Paolo, >> >> /* for KVM_GET/SET_VCPU_EVENTS */ >> struct kvm_vcpu_events { >> ... >> struct { >> __u8 injected; >> __u8 pending; >> __u8 masked; >> __u8 pad; >> } nmi; >> ... >> >> I found that

Re: [Qemu-devel] [PATCH v5 02/10] acpi: extend aml_interrupt() to support multiple irqs

2015-12-15 Thread Shannon Zhao
On 2015/12/16 0:55, Peter Maydell wrote: On 11 December 2015 at 03:21, Shannon Zhao wrote: >From: Igor Mammedov > >ASL Interrupt() macro translates to Extended Interrupt Descriptor >which supports variable number of IRQs. It will be used for >conversion of ASL code for pc/q35 machines that us

Re: [Qemu-devel] [PATCH v5 00/10] Add system_powerdown support on ARM for ACPI and DT

2015-12-15 Thread Peter Maydell
On 11 December 2015 at 03:21, Shannon Zhao wrote: > From: Shannon Zhao > > ACPI SPEC 5.0 defines GPIO-signaled ACPI Events for Hardware-reduced > platforms(like ARM). It uses GPIO pin to trigger an event to the guest. > For QEMU, here we add PL061 GPIO controller and use PIN 3 for > system_powerd

Re: [Qemu-devel] [PATCH COLO-Frame v12 05/38] migration: Add state records for migration incoming

2015-12-15 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > For migration destination, we also need to know its state, > we will use it in COLO. > > Here we add a new member 'state' for MigrationIncomingState, > and also use migrate_set_state() to modify its value. > > Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH v7 19/19] KVM: ARM64: Add a new kvm ARM PMU device

2015-12-15 Thread Andrew Jones
On Tue, Dec 15, 2015 at 03:59:31PM +, Marc Zyngier wrote: > On 15/12/15 15:50, Shannon Zhao wrote: > > > > > > On 2015/12/15 23:33, Marc Zyngier wrote: > >> On 15/12/15 08:49, Shannon Zhao wrote: > From: Shannon Zhao > > Add a new kvm device type KVM_DEV_TYPE_ARM_PMU_V3 for ARM

Re: [Qemu-devel] [RFC PATCH 0/6] decouple board headers from cpu.h

2015-12-15 Thread Paolo Bonzini
On 15/12/2015 17:06, Peter Maydell wrote: > > These patches are perhaps the only somewhat controversial part. > > Generally, we add opaque typedefs to typedefs.h in order to avoid > > indirect header inclusions. However, this might not be desirable > > for target specific types such as FooCPU.

[Qemu-devel] [PATCH 4/6] Migration: Emit event at start of pass

2015-12-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Emit an event each time we sync the dirty bitmap on the source; this helps libvirt use postcopy by giving it a kick when it might be a good idea to start the postcopy. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 4 qapi/event.json | 11 +

[Qemu-devel] [PATCH 6/6] multithread decompression: Avoid one copy

2015-12-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" qemu_get_buffer does a copy, we can avoid the memcpy, and we can then remove the extra buffer. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/migration/ram.c b/migration/ra

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Paolo Bonzini
On 15/12/2015 18:50, Thomas Huth wrote: > On 15/12/15 18:31, Paolo Bonzini wrote: >> >> On 15/12/2015 18:15, Thomas Huth wrote: >>> On 15/12/15 17:21, Paolo Bonzini wrote: > [...] For example you could print all DEVICE_CATEGORY_NETWORK devices that support device_add. >>> >>> I think th

Re: [Qemu-devel] [PATCH v4 4/5] xlnx-zynqmp: Connect the SPI devices

2015-12-15 Thread Peter Maydell
On 23 November 2015 at 08:54, Alistair Francis wrote: > Connect the Xilinx SPI devices to the ZynqMP model. > > Signed-off-by: Alistair Francis > +/* Rename each SPI bus after the SPI device to allow the board > + * to access all of the busses from the SoC. > + */ > +

Re: [Qemu-devel] [PATCH v2] target-arm: raise exception on misaligned LDREX operands

2015-12-15 Thread Peter Maydell
On 3 December 2015 at 18:36, Andrew Baumann wrote: > Qemu does not generally perform alignment checks. However, the ARM ARM > requires implementation of alignment exceptions for a number of cases > including LDREX, and Windows-on-ARM relies on this. > > This change adds plumbing to enable alignmen

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Peter Maydell
On 15 December 2015 at 16:33, Thomas Huth wrote: > On 15/12/15 17:17, Peter Maydell wrote: >> If they're just syntactic sugar, what is the new-style command >> line mechanism for configuring boards with embedded network >> controller devices? Last time I looked at this that was just >> impossible.

Re: [Qemu-devel] [PATCH v5 01/10] acpi: support serialized method

2015-12-15 Thread Peter Maydell
On 11 December 2015 at 03:21, Shannon Zhao wrote: > From: Xiao Guangrong > > Add serialized method support so that explicit Mutex can be > avoided > > Signed-off-by: Xiao Guangrong > Signed-off-by: Igor Mammedov > Reviewed-by: Shannon Zhao Shannon, this patch needs a Signed-off-by: line from

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Paolo Bonzini
On 15/12/2015 17:01, Thomas Huth wrote: > Some options work with "-net", some only work with "-netdev", > and the ones that work with both often also behave slightly differently (see > [1] for example). This example is about -net nic, which you're keeping. What are the options that differ betwe

Re: [Qemu-devel] [PATCH v4 RFC] spec: add qcow2-dirty-bitmaps specification

2015-12-15 Thread John Snow
On 12/14/2015 11:18 PM, Fam Zheng wrote: > On Mon, 12/14 21:05, Max Reitz wrote: >> On 14.12.2015 18:43, Vladimir Sementsov-Ogievskiy wrote: >>> The new feature for qcow2: storing dirty bitmaps. >>> >>> Only dirty bitmaps relative to this qcow2 image should be stored in it. >>> >>> Strings starte

Re: [Qemu-devel] [PATCH 1/6] arm: use "struct ARMCPU" in header files

2015-12-15 Thread Peter Maydell
On 15 December 2015 at 14:28, Paolo Bonzini wrote: > This removes a dependency on cpu.h. Since this is in most cases the > _only_ dependency on cpu.h, removing it now makes it easier to > disentangle qemu-common.h and cpu.h. > > Signed-off-by: Paolo Bonzini > --- > hw/arm/strongarm.h |

Re: [Qemu-devel] [PATCH] linux-headers: update from kvm/next

2015-12-15 Thread Peter Maydell
On 15 December 2015 at 15:01, Paolo Bonzini wrote: > The virgl feature name was changed after the previous sync This is why we should never sync against anything other than mainline kernels or maybe kvm-next... thanks -- PMM

Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU

2015-12-15 Thread Eduardo Habkost
On Mon, Dec 14, 2015 at 07:17:27PM -0500, Raj, Ashok wrote: > On Mon, Dec 14, 2015 at 11:37:16PM +0100, Borislav Petkov wrote: > > On Mon, Dec 14, 2015 at 02:11:46PM -0500, Raj, Ashok wrote: > > > This is mostly harmless.. since the MCG_CAP space is shared and has no > > > conflict between vendors.

Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState

2015-12-15 Thread Eduardo Habkost
On Tue, Dec 15, 2015 at 02:08:09PM +0530, Bharata B Rao wrote: > On Mon, Dec 14, 2015 at 03:29:49PM -0200, Eduardo Habkost wrote: [...] > > * Maybe make it a CPUClass* field instead of a string? > > In the current use case, this base cpu type string is being passed > to cpu_generic_init(const char

Re: [Qemu-devel] [RFC v6 06/14] configure: Use slow-path for atomic only when the softmmu is enabled

2015-12-15 Thread Laurent Vivier
On 15/12/2015 15:31, Paolo Bonzini wrote: > > > On 15/12/2015 15:23, alvise rigo wrote: >> Hi, >> >> On Mon, Dec 14, 2015 at 11:14 AM, Laurent Vivier wrote: >>> >>> >>> On 14/12/2015 09:41, Alvise Rigo wrote: Use the new slow path for atomic instruction translation when the softmmu i

[Qemu-devel] [PATCH] linux-headers: update from kvm/next

2015-12-15 Thread Paolo Bonzini
Update to 4.4 for Linux and 4.5 for KVM. The virgl feature name was changed after the previous sync; there is no other change to QEMU code. Signed-off-by: Paolo Bonzini --- hw/display/virtio-gpu.c| 4 +- include/standard-headers/asm-x86/hyperv.h | 12 + i

Re: [Qemu-devel] [PATCH v2 14/14] pc: Eliminate PcGuestInfo struct

2015-12-15 Thread Marcel Apfelbaum
On 12/11/2015 08:42 PM, Eduardo Habkost wrote: The struct is not used for anything, now. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 4 +--- include/hw/i386/pc.h | 7 +-- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 43a25

Re: [Qemu-devel] [PATCH v2 13/14] pc: Move APIC and NUMA data from PcGuestInfo to PCMachineState

2015-12-15 Thread Marcel Apfelbaum
On 12/11/2015 08:42 PM, Eduardo Habkost wrote: Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 22 +- hw/i386/pc.c | 20 ++-- include/hw/i386/pc.h | 14 +- 3 files changed, 28 insertions(+), 28 deletions(-) diff --git a/hw/i

Re: [Qemu-devel] [RFC v6 06/14] configure: Use slow-path for atomic only when the softmmu is enabled

2015-12-15 Thread Paolo Bonzini
On 15/12/2015 15:23, alvise rigo wrote: > Hi, > > On Mon, Dec 14, 2015 at 11:14 AM, Laurent Vivier wrote: >> >> >> On 14/12/2015 09:41, Alvise Rigo wrote: >>> Use the new slow path for atomic instruction translation when the >>> softmmu is enabled. >>> >>> Suggested-by: Jani Kokkonen >>> Sugge

Re: [Qemu-devel] [PATCH v2 12/14] pc: Move PcGuestInfo.fw_cfg to PCMachineState

2015-12-15 Thread Marcel Apfelbaum
On 12/11/2015 08:42 PM, Eduardo Habkost wrote: Signed-off-by: Eduardo Habkost --- hw/i386/acpi-build.c | 7 +++ hw/i386/pc.c | 10 -- include/hw/i386/pc.h | 2 +- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.

[Qemu-devel] [PATCH 1/6] arm: use "struct ARMCPU" in header files

2015-12-15 Thread Paolo Bonzini
This removes a dependency on cpu.h. Since this is in most cases the _only_ dependency on cpu.h, removing it now makes it easier to disentangle qemu-common.h and cpu.h. Signed-off-by: Paolo Bonzini --- hw/arm/strongarm.h | 2 +- include/hw/arm/arm.h| 12 +++- include/hw

[Qemu-devel] [PATCH 4/6] alpha: use AlphaCPU as an opaque type

2015-12-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/alpha/alpha_sys.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h index e11025b..8f67ed9 100644 --- a/hw/alpha/alpha_sys.h +++ b/hw/alpha/alpha_sys.h @@ -10,7 +10,8 @@ #include "hw/irq.h" -P

Re: [Qemu-devel] [PATCH v2 11/14] pc: Remove PcGuestInfo.isapc_ram_fw field

2015-12-15 Thread Marcel Apfelbaum
On 12/11/2015 08:42 PM, Eduardo Habkost wrote: The code can use the PCMachineClass.pci_enabled field directly. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 2 +- hw/i386/pc_piix.c| 5 + hw/i386/pc_q35.c | 4 +--- include/hw/i386/pc.h | 1 - 4 files changed, 3 inse

[Qemu-devel] [PATCH 3/6] ppc: use struct to avoid the need for cpu.h

2015-12-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/hw/ppc/ppc.h| 36 +--- include/hw/ppc/ppc4xx.h | 17 +++-- linux-user/main.c | 4 ++-- target-ppc/cpu.h| 10 -- 4 files changed, 38 insertions(+), 29 deletions(-) diff --git a/include/

[Qemu-devel] [PATCH 6/6] sh: use SuperHCPU struct to avoid cpu.h dependency

2015-12-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/hw/sh4/sh.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/hw/sh4/sh.h b/include/hw/sh4/sh.h index e61de9a..32f688c 100644 --- a/include/hw/sh4/sh.h +++ b/include/hw/sh4/sh.h @@ -8,10 +8,11 @@ #define P4ADDR(x) ((x) | 0xe000

[Qemu-devel] [PATCH 5/6] coldfire: use "struct M68kCPU" in header files

2015-12-15 Thread Paolo Bonzini
This removes a dependency on cpu.h. Since all dependencies on cpu.h come from mcf.h, using "struct M68kCPU" makes it easier to disentangle qemu-common.h and cpu.h. Signed-off-by: Paolo Bonzini --- include/hw/m68k/mcf.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/inc

Re: [Qemu-devel] [PATCH COLO-Frame v12 18/38] COLO: Flush PVM's cached RAM into SVM's memory

2015-12-15 Thread Changlong Xie
On 12/15/2015 04:22 PM, zhanghailiang wrote: During the time of VM's running, PVM may dirty some pages, we will transfer PVM's dirty pages to SVM and store them into SVM's RAM cache at next checkpoint time. So, the content of SVM's RAM cache will always be some with PVM's memory "some" => "same"

Re: [Qemu-devel] [Qemu-trivial][PATCH] trace: reflect the file name change

2015-12-15 Thread Qinghua Jin
Thanks for helping me, i'll use it next time. At 2015-12-15 11:03:12, "Stefan Hajnoczi" wrote: >On Fri, Dec 11, 2015 at 03:06:12PM +0800, Qinghua Jin wrote: >> Some functions was moved from block.c to block/io.c, so the trace-events >> file should reflect that change. >> >> >> Signed-of

[Qemu-devel] [PATCH 2/6] mips: use struct CPUMIPSState to avoid need for cpu.h

2015-12-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/hw/mips/cpudevs.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/hw/mips/cpudevs.h b/include/hw/mips/cpudevs.h index b2626f2..eb2f190 100644 --- a/include/hw/mips/cpudevs.h +++ b/include/hw/mips/cpudevs.h @@ -2,6 +2,8 @@

[Qemu-devel] [RFC PATCH 0/6] decouple board headers from cpu.h

2015-12-15 Thread Paolo Bonzini
Hi, a while ago I started removing cpu.h dependencies from several headers in QEMU. In particular, I wanted to put an end to qemu-common.h's including cpu.h and vice versa. This is useful for two reasons: 1) because both headers bring in a lot of dependencies and thus very small changes can caus

[Qemu-devel] [PATCH] iscsi: fix readcapacity error message

2015-12-15 Thread Zhu Lingshan
fix:The error message for readcapacity 16 incorrectly mentioned a readcapacity 10 failure, fixed the error message. Signed-off-by: Zhu Lingshan --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index bd1f1bf..eb28ddc 100644 --- a/

  1   2   3   >