Re: [Qemu-devel] [PATCH] Use macro instead of plain text

Sorry, it can`t pass compilation... I will give v2 soon. On 12/18/2015 03:57 PM, Cao jin wrote: There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems these two places are missed. Signed-off-by: Cao jin --- hw/i386/pc_q35.c | 2 +- qdev-monitor.c | 2

Re: [Qemu-devel] [PATCH v2 04/23] error: Use error_report_err() instead of ad hoc prints

Eric Blake writes: > On 12/17/2015 09:49 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> contrib/ivshmem-server/main.c | 4 +--- >> qdev-monitor.c| 3 +-- >> qemu-nbd.c| 3 +-- >> 3 files

[Qemu-devel] [PATCH v2] Use macro instead of plain text

There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems it is missed. Signed-off-by: Cao jin --- hw/i386/pc_q35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 9a12068..aa34a07 100644 ---

[Qemu-devel] [PATCH] Convert to realize()

for educational PCI device Signed-off-by: Cao jin --- hw/misc/edu.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/misc/edu.c b/hw/misc/edu.c index fe50b42..43d5b18 100644 --- a/hw/misc/edu.c +++ b/hw/misc/edu.c @@ -327,7 +327,7 @@ static

[Qemu-devel] [PATCH] hw/ppc/spapr_rtc: Remove bad class_size value

class_size = sizeof(XICSStateClass) does not make much sense in the RTC code and likely was just a copy-n-paste error. Let's simply remove it. Signed-off-by: Thomas Huth --- hw/ppc/spapr_rtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ppc/spapr_rtc.c

Re: [Qemu-devel] [PATCH 1/2] compat: Introduce HW_COMPAT_2_5

On Fri, 18 Dec 2015 09:30:02 +0200 Shmulik Ladkani wrote: > Introduce the place-holder for 2.5 back-compat properties, and the > accompanying PC_COMPAT_2_5, CCW_COMPAT_2_5, SPAPR_COMPAT_2_5. > > Signed-off-by: Shmulik Ladkani

Re: [Qemu-devel] [RESEND PATCH] q35: Remove old machine versions

On Do, 2015-12-17 at 15:27 -0200, Eduardo Habkost wrote: > Migration with q35 was not possible before commit > 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally > creates an ich9-ahci device, that was marked as unmigratable. So all q35 > machine classes before pc-q35-2.4 were

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Notice about lock bitmask translation for fcntl

Le 18/12/2015 07:51, Chen Gang a écrit : > > I found this issue during my working time, it is about sw_64 (almost the > same as alpha) host running i386 wine programs. > > I also found another issue, but I am not quite sure whether it is worth > enough for our upstream: The related fix patch

Re: [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error string arguments (again)

Eric Blake writes: > On 12/17/2015 09:49 AM, Markus Armbruster wrote: >> Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they >> keep coming back. Tracked down with the Coccinelle semantic patch >> from commit 312fd5f. > > Don't forget to rerun this to pick up

Re: [Qemu-devel] [PATCH v2 17/23] vmdk: Clean up control flow in vmdk_parse_extents() a bit

Eric Blake writes: > On 12/17/2015 09:49 AM, Markus Armbruster wrote: >> Cc: Fam Zheng >> Signed-off-by: Markus Armbruster >> --- >> block/vmdk.c | 28 +++- >> 1 file changed, 15 insertions(+), 13 deletions(-) > >

Re: [Qemu-devel] [PATCH v2 18/23] vmdk: Clean up "Invalid extent lines" error message

Fam Zheng writes: > On Thu, 12/17 17:49, Markus Armbruster wrote: >> vmdk_parse_extents() reports parse errors like this: >> >> error_setg(errp, "Invalid extent lines:\n%s", p); >> >> where p points to the beginning of the malformed line in the image >> descriptor. This

Re: [Qemu-devel] [PATCH v2 21/23] error: Clean up errors with embedded newlines (again)

Eric Blake writes: > On 12/17/2015 09:50 AM, Markus Armbruster wrote: >> The arguments of error_report() should yield a short error string >> without newlines. >> >> A few places try to print additional help after the error message by >> embedding newlines in the error

[Qemu-devel] [PATCH] misc: spelling

From: Marc-André Lureau --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index e7e7ae2..51ec4c3 100644 --- a/monitor.c +++ b/monitor.c @@ -311,7 +311,7 @@ static void monitor_flush_locked(Monitor *mon)

[Qemu-devel] [PATCH 2/7] target-ppc: rename and export maybe_bswap_register()

This helper will be used to support FP, Altivec and VSX registers when the guest is little-endian. Signed-off-by: Greg Kurz --- target-ppc/cpu.h |1 + target-ppc/gdbstub.c | 10 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH 0/7] target-ppc: endian fixes for KVM and gdbstub

Hi, This series is a sequel to Anton's tentative at bringing VSX support in our gdbstub: http://patchwork.ozlabs.org/patch/453758/ Indeed, FP, SPE and Altivec registers need to be copied to memory with the appropriate ordering, like we already do for core registers. This series reuses the

[Qemu-devel] [PATCH 3/7] target-ppc: gdbstub: fix float registers for little-endian guests

Let's reuse the ppc_maybe_bswap_register() helper, like we already do with the general registers. Signed-off-by: Greg Kurz --- target-ppc/translate_init.c |4 1 file changed, 4 insertions(+) diff --git a/target-ppc/translate_init.c

[Qemu-devel] [PATCH 1/7] target-ppc: kvm: fix floating point registers sync on little-endian hosts

On VSX capable CPUs, the 32 FP registers are mapped to the high-bits of the 32 first VSX registers. So if you have: VSR31 = (uint128) 0x0102030405060708090a0b0c0d0e0f00 then FPR31 = (uint64) 0x0102030405060708 The kernel stores the VSX registers in the fp_state struct following the host endian

[Qemu-devel] [PATCH 4/7] target-ppc: gdbstub: introduce avr_need_swap()

This helper will be used to support Altivec registers in little-endian guests. This patch does not change functionnality. Note: I had to put the helper some lines away from the gdb_*_avr_reg() routines to get a more readable patch. Signed-off-by: Greg Kurz ---

[Qemu-devel] [PATCH 6/7] target-ppc: gdbstub: fix spe registers for little-endian guests

Let's reuse the ppc_maybe_bswap_register() helper, like we already do with the general registers. Signed-off-by: Greg Kurz --- target-ppc/translate_init.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/target-ppc/translate_init.c

[Qemu-devel] [PATCH 5/7] target-ppc: gdbstub: fix altivec registers for little-endian guests

Altivec registers are 128-bit wide. They are stored in memory as two 64-bit values that must be byteswapped when the guest is little-endian. Let's reuse the ppc_maybe_bswap_register() helper for this. We also need to fix the ordering of the 64-bit elements according to the target endianness, for

[Qemu-devel] [PATCH 7/7] target-ppc: gdbstub: Add VSX support

From: Anton Blanchard Add the XML and functions to get and set VSX registers. Signed-off-by: Anton Blanchard (fixed little-endian guests) Signed-off-by: Greg Kurz --- configure |6 +++--- gdb-xml/power-vsx.xml

Re: [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint()

Eric Blake writes: > On 12/17/2015 12:00 PM, Markus Armbruster wrote: > >> @@ -128,6 +138,7 @@ ErrorClass error_get_class(const Error *err); >> * If @errp is anything else, *@errp must be NULL. >> * The new error's class is ERROR_CLASS_GENERIC_ERROR, and its

Re: [Qemu-devel] [PATCH v2 09/23] error: New error_prepend(), error_reportf_err()

Eric Blake writes: > On 12/17/2015 09:49 AM, Markus Armbruster wrote: >> Instead of simply propagating an error verbatim, we sometimes want to >> add to its message, like this: >> >> frobnicate(arg, ); >> error_setg(errp, "Can't frobnicate %s: %s", >>

Re: [Qemu-devel] [PATCH v2 11/23] error: Use error_reportf_err() where it makes obvious sense

Eric Blake writes: > On 12/17/2015 09:49 AM, Markus Armbruster wrote: >> Done with this Coccinelle semantic patch >> >> @@ >> expression FMT, E; >> expression list ARGS; >> @@ >> -error_report(FMT, ARGS, error_get_pretty(E)); >> +

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Notice about lock bitmask translation for fcntl

Le 18/12/2015 07:26, Chen Gang a écrit : > > For fcntl, it always needs to notice about it, just like do_fcntl() has > done, or it will cause issue (e.g. alpha host run i386 guest). > > Signed-off-by: Chen Gang > --- > linux-user/syscall.c | 18 -- >

[Qemu-devel] [PATCH] ccid: use libcacard.h from 2.5.1

From: Marc-André Lureau This cleans up a bit libcacard headers inclusion. Signed-off-by: Marc-André Lureau --- configure | 7 --- hw/usb/ccid-card-emulated.c | 5 + hw/usb/ccid-card-passthru.c | 2 +- 3 files

Re: [Qemu-devel] [PATCH 06/10] sdhci_sysbus: Create SD card device in users, not the device itself

On 18 December 2015 at 00:18, Alistair Francis wrote: > On Fri, Dec 11, 2015 at 8:37 AM, Peter Maydell > wrote: >> >> +/* Create and plug in the SD cards */ >> +for (i = 0; i < XLNX_ZYNQMP_NUM_SDHCI; i++) { >> +BusState

[Qemu-devel] [PATCH v4 1/7] mips/kvm: Remove a couple of noisy DPRINTFs

The DPRINTFs in cpu_mips_io_interrupts_pending() and kvm_arch_pre_run() are particularly noisy during normal execution, and also not particularly helpful. Remove them so that more important debug messages can be more easily seen. Signed-off-by: James Hogan Reviewed-by:

Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState

On Thu, 17 Dec 2015 16:09:23 -0200 Eduardo Habkost wrote: > On Wed, Dec 16, 2015 at 11:26:20PM +0100, Igor Mammedov wrote: > > On Wed, 16 Dec 2015 17:39:02 -0200 > > Eduardo Habkost wrote: > > > > > On Wed, Dec 16, 2015 at 05:54:25PM +0100, Igor

[Qemu-devel] [PATCH v4 4/7] mips/kvm: Support unsigned KVM registers

Add KVM register access functions for the uint32_t type. This is required for FP and MSA control registers, which are represented as unsigned 32-bit integers. Signed-off-by: James Hogan Cc: Paolo Bonzini Cc: Leon Alrae Cc:

[Qemu-devel] [PATCH v4 0/7] mips/kvm: Support FPU & SIMD (MSA) in MIPS KVM guests

Here's a v4 refresh of my FPU/MSA patchset for v2.6. Thanks to all who have taken the time to review it so far. This patchset primarily adds support for FPU and MIPS SIMD Architecture (MSA) in MIPS KVM guests to QEMU. It depends on Linux v4.1, specifically my KVM patchset to add the corresponding

[Qemu-devel] [PATCH v4 2/7] mips/kvm: Implement PRid CP0 register

Implement saving and restoring to KVM state of the Processor ID (PRid) CP0 register. This allows QEMU to control the PRid exposed to the guest instead of using the default set by KVM. Signed-off-by: James Hogan Reviewed-by: Leon Alrae Cc: Paolo

[Qemu-devel] [PATCH v4 6/7] mips/kvm: Support FPU in MIPS KVM guests

Support the new KVM_CAP_MIPS_FPU capability, which allows the host's FPU to be exposed to the KVM guest. The capability is enabled if the guest core has an FPU according to its Config1 register. Various config bits are now writeable so that KVM is aware of the configuration (Config1.FP) and so

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Notice about lock bitmask translation for fcntl

On 2015年12月18日 17:41, Laurent Vivier wrote: > > > Le 18/12/2015 07:51, Chen Gang a écrit : >> >> I found this issue during my working time, it is about sw_64 (almost the >> same as alpha) host running i386 wine programs. >> >> I also found another issue, but I am not quite sure whether it is

[Qemu-devel] [PATCH v4 5/7] mips/kvm: Support signed 64-bit KVM registers

Rename kvm_mips_{get,put}_one_reg64() to kvm_mips_{get,put}_one_ureg64() since they take an int64_t pointer, and add separate signed 64-bit accessors. These will be used for double precision floating point registers. Signed-off-by: James Hogan Cc: Paolo Bonzini

[Qemu-devel] [PATCH v4 3/7] mips/kvm: Implement Config CP0 registers

Implement saving and restoring to KVM state of the Config CP0 registers (namely Config, Config1, Config2, Config3, Config4, and Config5). These control the features available to a guest, and a few of the fields will soon be writeable by a guest so QEMU needs to know about them so as not to clobber

[Qemu-devel] [PATCH v4 7/7] mips/kvm: Support MSA in MIPS KVM guests

Support the new KVM_CAP_MIPS_MSA capability, which allows MIPS SIMD Architecture (MSA) to be exposed to the KVM guest. The capability is enabled if the guest core has MSA according to its Config3 register. Various config bits are now writeable so that KVM is aware of the configuration

Re: [Qemu-devel] [PATCH COLO-Frame v12 31/38] COLO: Separate the process of saving/loading ram and device state

* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > We separate the process of saving/loading ram and device state when do > checkpoint, > we add new helpers for save/load ram/device. With this change, we can directly > transfer ram from master to slave without using QEMUSizeBuffer as

[Qemu-devel] [PATCH 0/5] Convert to realize()

some simple case Cao jin (5): SH PCI Host: convert to realize() igd-passthrough-i440FX: convert to realize() PXB: convert to realize() gt64120: convert to realize() xen-pvdevice: convert to realize() hw/i386/xen/xen_pvdevice.c | 12 ++-- hw/mips/gt64xxx_pci.c

[Qemu-devel] [PATCH 2/5] igd-passthrough-i440FX: convert to realize()

Signed-off-by: Cao jin --- hw/pci-host/piix.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 715208b..e3840f0 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -761,7 +761,7 @@

[Qemu-devel] [PATCH 3/5] PXB: convert to realize()

Signed-off-by: Cao jin --- hw/pci-bridge/pci_expander_bridge.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expander_bridge.c index 57f8a37..cc975f6 100644 ---

[Qemu-devel] [PATCH 1/5] SH PCI Host: convert to realize()

Signed-off-by: Cao jin --- hw/sh4/sh_pci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/sh4/sh_pci.c b/hw/sh4/sh_pci.c index a2f6d9e..4509053 100644 --- a/hw/sh4/sh_pci.c +++ b/hw/sh4/sh_pci.c @@ -151,12 +151,11 @@ static int

[Qemu-devel] [PATCH 5/5] xen-pvdevice: convert to realize()

Signed-off-by: Cao jin --- hw/i386/xen/xen_pvdevice.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/i386/xen/xen_pvdevice.c b/hw/i386/xen/xen_pvdevice.c index c218947..a6c93d0 100644 --- a/hw/i386/xen/xen_pvdevice.c +++

[Qemu-devel] [PATCH 4/5] gt64120: convert to realize()

Signed-off-by: Cao jin --- hw/mips/gt64xxx_pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index f76a9fd..c1f3c9c 100644 --- a/hw/mips/gt64xxx_pci.c +++ b/hw/mips/gt64xxx_pci.c @@ -1193,7

Re: [Qemu-devel] [PATCH 0/5] Convert to realize()

forgot to CC to: Markus On 12/18/2015 07:03 PM, Cao jin wrote: some simple case Cao jin (5): SH PCI Host: convert to realize() igd-passthrough-i440FX: convert to realize() PXB: convert to realize() gt64120: convert to realize() xen-pvdevice: convert to realize()

Re: [Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

Am 10.09.2015 um 17:19 hat Alberto Garcia geschrieben: > The QEMU code is not internationalized and assumes that it runs under > the C locale, but if we use the GTK+ UI we'll end up importing the > locale settings from the environment. This can break things, such as > the JSON generator and iotest

Re: [Qemu-devel] [PATCH v2 0/2] Clean up the remainders of bdrv_swap

Am 18.12.2015 um 02:04 hat Fam Zheng geschrieben: > v2: Update comment in patch 2. [Kevin] > > > > Fam Zheng (2): > block: Remove prototype of bdrv_swap from header > iotests: Update comments for bdrv_swap() in 094 > > include/block/block.h | 1 - > tests/qemu-iotests/094 | 8 +--- >

Re: [Qemu-devel] [PATCH v3 8/9] elf: add arm note types

On 15 December 2015 at 22:51, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > include/elf.h | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v3 9/9] target-arm: dump-guest-memory: add vfp notes for arm

On 15 December 2015 at 22:51, Andrew Jones wrote: > gdb won't actually dump these with 'info all-registers' since > it first tries to confirm that it should by checking the VFP > hwcap in the .auxv note. Well, we don't generate an .auxv note. > > Signed-off-by: Andrew Jones

[Qemu-devel] [PULL v4 3/9] io: add QIOTask class for async operations

A number of I/O operations need to be performed asynchronously to avoid blocking the main loop. The caller of such APIs need to provide a callback to be invoked on completion/error and need access to the error, if any. The small QIOTask provides a simple framework for dealing with such probes. The

[Qemu-devel] [PULL v4 5/9] io: add QIOChannelFile class

Add a QIOChannel subclass that is capable of operating on things that are files, such as plain files, pipes, character/block devices, but notably not sockets. Signed-off-by: Daniel P. Berrange --- include/io/channel-file.h| 93 ++ io/Makefile.objs

[Qemu-devel] [PULL v4 4/9] io: add QIOChannelSocket class

Implement a QIOChannel subclass that supports sockets I/O. The implementation is able to manage a single socket file descriptor, whether a TCP/UNIX listener, TCP/UNIX connection, or a UDP datagram. It provides APIs which can listen and connect either asynchronously or synchronously. Since there is

[Qemu-devel] [PULL v4 1/9] io: add abstract QIOChannel classes

Start the new generic I/O channel framework by defining a QIOChannel abstract base class. This is designed to feel similar to GLib's GIOChannel, but with the addition of support for using iovecs, qemu error reporting, file descriptor passing, coroutine integration and use of the QOM framework for

[Qemu-devel] [PULL v4 9/9] io: add QIOChannelBuffer class

Add a QIOChannel subclass that is capable of performing I/O to/from a memory buffer. This implementation does not attempt to support concurrent readers & writers. It is designed for serialized access where by a single thread at a time may write data, seek and then read data back out.

[Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

There are frequently patches submitted for merge which use symbols only defined by newer glib versions that the max version currently permitted by QEMU (ie glib==2.22). The glib 2.32 release introduced GLIB_VERSION_MIN_REQUIRED and GLIB_VERSION_MAX_ALLOWED macros to allow apps to declare what they

Re: [Qemu-devel] [PATCH v3 6/9] target-arm: support QMP dump-guest-memory

On 15 December 2015 at 22:51, Andrew Jones wrote: > Add the support needed for creating prstatus elf notes. This > allows us to use QMP dump-guest-memory. > > Signed-off-by: Andrew Jones > +int arm_cpu_write_elf64_note(WriteCoreDumpFunction f, CPUState

[Qemu-devel] [PATCH] virtio-gpu: fix memory leak in error path

Found by Coverity Scan, buf not freed on error. Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu-3d.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c index 527ac90..bd88d45 100644 ---

Re: [Qemu-devel] [PATCH COLO-Frame v12 32/38] COLO: Split qemu_savevm_state_begin out of checkpoint process

* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > It is unnecessary to call qemu_savevm_state_begin() in every checkponit > process. > It mainly sets up devices and does the first device state pass. These data > will > not change during the later checkpoint process. So, we split it out

Re: [Qemu-devel] [PATCH v3 7/9] target-arm: dump-guest-memory: add prfpreg notes for aarch64

On 15 December 2015 at 22:51, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > target-arm/arch_dump.c | 79 > +- > 1 file changed, 71 insertions(+), 8 deletions(-) > +static int We don't usually

Re: [Qemu-devel] [PATCH] block: use drained section around bdrv_snapshot_delete

[ Cc: qemu-block ] Am 17.12.2015 um 02:55 hat Fam Zheng geschrieben: > On Wed, 12/16 19:33, Paolo Bonzini wrote: > > Do not use bdrv_drain, since by itself it does not guarantee > > anything. > > > > Signed-off-by: Paolo Bonzini Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v3 3/9] dump: allow target to set the page size

On 15 December 2015 at 22:51, Andrew Jones wrote: > This is necessary for targets that don't have TARGET_PAGE_SIZE == > real-target-page-size. The target should set the page size to the > correct one, if known, or, if not known, to the maximum page size > it supports. > > (No

Re: [Qemu-devel] [PATCH] block: fix bdrv_ioctl called from coroutine

[ Cc: qemu-block ] Am 16.12.2015 um 19:33 hat Paolo Bonzini geschrieben: > When called from a coroutine, bdrv_ioctl must be asynchronous just like > e.g. bdrv_flush. The code was incorrectly making it synchronous, fix > it. > > Signed-off-by: Paolo Bonzini Thanks, applied

[Qemu-devel] [PULL v4 6/9] io: add QIOChannelTLS class

Add a QIOChannel subclass that can run the TLS protocol over the top of another QIOChannel instance. The object provides a simplified API to perform the handshake when starting the TLS session. The layering of TLS over the underlying channel does not have to be setup immediately. It is possible to

[Qemu-devel] [PULL v4 0/9] Introduce I/O channels framework

The following changes since commit 6a6533213d78dea4407fe6933ad489796b582599: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2015-12-17 18:07:09 +) are available in the git repository at: git://github.com/berrange/qemu

[Qemu-devel] [PULL v4 2/9] io: add helper module for creating watches on FDs

A number of the channel implementations will require the ability to create watches on file descriptors / sockets. To avoid duplicating this code in each channel, provide a helper API for dealing with file descriptor watches. There are two watch implementations provided. The first is useful for

[Qemu-devel] [PULL v4 8/9] io: add QIOChannelCommand class

Add a QIOChannel subclass that is capable of performing I/O to/from a separate process, via a pair of pipes. The command can be used for unidirectional or bi-directional I/O. Signed-off-by: Daniel P. Berrange --- include/io/channel-command.h| 91 ++

[Qemu-devel] [PULL v4 7/9] io: add QIOChannelWebsock class

Add a QIOChannel subclass that can run the websocket protocol over the top of another QIOChannel instance. This initial implementation is only capable of acting as a websockets server. There is no support for acting as a websockets client yet. Signed-off-by: Daniel P. Berrange

[Qemu-devel] [Bug 1525682] Re: configure: fix POSIX compatibility issue

Note that mksh is virtually a superset of OpenBSD ksh and accepts this construct, for a quick fix. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1525682 Title: configure: fix POSIX compatibility

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On 18/12/2015 12:36, Daniel P. Berrange wrote: > diff --git a/scripts/Makefile b/scripts/Makefile > new file mode 100644 > index 000..162e7e9 > --- /dev/null > +++ b/scripts/Makefile > @@ -0,0 +1,24 @@ > +# > +# This makefile runs various style checks across the entire > +# source tree. > +#

Re: [Qemu-devel] [PATCH] ccid: use libcacard.h from 2.5.1

On 18/12/2015 10:49, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This cleans up a bit libcacard headers inclusion. > > Signed-off-by: Marc-André Lureau > --- > configure | 7 --- >

Re: [Qemu-devel] [PATCH] ccid: use libcacard.h from 2.5.1

Hi - Original Message - > > > On 18/12/2015 10:49, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This cleans up a bit libcacard headers inclusion. > > > > Signed-off-by: Marc-André Lureau > > --- > >

Re: [Qemu-devel] [PATCH v2] Use macro instead of plain text

Cao jin writes: > There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems it > is missed. > > Signed-off-by: Cao jin > --- > hw/i386/pc_q35.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/pc_q35.c

Re: [Qemu-devel] [PATCH] Convert to realize()

Copying qemu-trivial. Cao jin writes: > for educational PCI device > > Signed-off-by: Cao jin > --- > hw/misc/edu.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/misc/edu.c b/hw/misc/edu.c > index

[Qemu-devel] [PATCH] scripts/checkpatch.pl: Don't allow special cases of unspaced operators

The checkpatch.pl script has a special case to permit the following operators to have no spaces around them: << >> & ^ | + - * / % QEMU style prefers all operators to consistently have spacing around them, so remove this special case handling. This avoids reviewers having to manually

Re: [Qemu-devel] [PATCH] misc: spelling

Copying maintainer just for completeness. I'm sure Luiz won't at all mind this going through trivial ;) Let's clarify the commit message: monitor: Spelling fix With that: Reviewed-by: Markus Armbruster marcandre.lur...@redhat.com writes: > From: Marc-André Lureau

Re: [Qemu-devel] [PATCH 1/2] compat: Introduce HW_COMPAT_2_5

On 18/12/2015 10:37, Cornelia Huck wrote: > On Fri, 18 Dec 2015 09:30:02 +0200 > Shmulik Ladkani wrote: > >> Introduce the place-holder for 2.5 back-compat properties, and the >> accompanying PC_COMPAT_2_5, CCW_COMPAT_2_5, SPAPR_COMPAT_2_5. >> >>

Re: [Qemu-devel] [PATCH v2] Use macro instead of plain text

On 18 December 2015 at 12:52, Markus Armbruster wrote: > Cao jin writes: > >> There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems it >> is missed. > I suspect there are more instances of the same problem. > Not sure how interested we

Re: [Qemu-devel] [PATCH] scripts/checkpatch.pl: Don't allow special cases of unspaced operators

On 18/12/2015 13:59, Peter Maydell wrote: > The checkpatch.pl script has a special case to permit the following > operators to have no spaces around them: > << >> & ^ | + - * / % > > QEMU style prefers all operators to consistently have spacing around > them, so remove this special

Re: [Qemu-devel] [PATCH] ccid: use libcacard.h from 2.5.1

On 18/12/2015 13:50, Marc-André Lureau wrote: >>> > > configure | 7 --- >>> > > hw/usb/ccid-card-emulated.c | 5 + >>> > > hw/usb/ccid-card-passthru.c | 2 +- >>> > > 3 files changed, 6 insertions(+), 8 deletions(-) >> > >> > Are there any distros that have not

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On Fri, Dec 18, 2015 at 01:36:00PM +0100, Paolo Bonzini wrote: > > > On 18/12/2015 12:36, Daniel P. Berrange wrote: > > diff --git a/scripts/Makefile b/scripts/Makefile > > new file mode 100644 > > index 000..162e7e9 > > --- /dev/null > > +++ b/scripts/Makefile > > @@ -0,0 +1,24 @@ > > +# >

Re: [Qemu-devel] [PATCH] scripts/checkpatch.pl: Don't allow special cases of unspaced operators

Am 18.12.2015 um 13:59 schrieb Peter Maydell: > The checkpatch.pl script has a special case to permit the following > operators to have no spaces around them: > << >> & ^ | + - * / % > > QEMU style prefers all operators to consistently have spacing around > them, so remove this special

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On 18/12/2015 14:05, Daniel P. Berrange wrote: > > > + > > > +cs-glib-syms: > > > + @perl scripts/glib-syms.pl $(GLIB_SYMS_LIST) $(C_CODE_FILES) > > > > > > Does this need to be included, or could it be a separate Makefile > > invoked with e.g. make -f scripts/Makefile.style? > > Any

[Qemu-devel] Minutes from the "Stuttgart block Gipfele"

Kevin, Max and I used an opportunity to meet and discuss block layer matters. We examined two topics in some depth: BlockBackend, and block filters and dynamic reconfiguration. Not nearly enough people to call it a block summit. But the local dialect is known for its use of diminutives, and

Re: [Qemu-devel] [RFC v6 01/14] exec.c: Add new exclusive bitmap to ram_list

Alvise Rigo writes: > The purpose of this new bitmap is to flag the memory pages that are in > the middle of LL/SC operations (after a LL, before a SC) on a per-vCPU > basis. > For all these pages, the corresponding TLB entries will be generated > in such a way to

Re: [Qemu-devel] [PATCH] misc: spelling

On Fri, 18 Dec 2015 13:58:45 +0100 Markus Armbruster wrote: > Copying maintainer just for completeness. I'm sure Luiz won't at all > mind this going through trivial ;) > > Let's clarify the commit message: > > monitor: Spelling fix > > With that: > > Reviewed-by:

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On Fri, Dec 18, 2015 at 01:35:13PM +, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > > > > > On 18/12/2015 14:05, Daniel P. Berrange wrote: > > > > > + > > > > > +cs-glib-syms: > > > > > + @perl scripts/glib-syms.pl $(GLIB_SYMS_LIST) $(C_CODE_FILES) > >

Re: [Qemu-devel] [RFC v6 01/14] exec.c: Add new exclusive bitmap to ram_list

On Fri, Dec 18, 2015 at 2:18 PM, Alex Bennée wrote: > > Alvise Rigo writes: > >> The purpose of this new bitmap is to flag the memory pages that are in >> the middle of LL/SC operations (after a LL, before a SC) on a per-vCPU >> basis. >>

Re: [Qemu-devel] RFC: Operation Blockers in QEMU Block Nodes

Am 16.12.2015 um 07:25 hat Jeff Cody geschrieben: > Background: > > Block jobs, and other QAPI operations, may modify and impact the > BlockDriverState graph in QEMU. In order to support multiple > operations safely, we need a mechanism to block and gate operations, > > We currently

[Qemu-devel] [PATCH] gtk: fix utf8 strings in the ui

Commit "2cb5d2a gtk: use setlocale() for LC_MESSAGES only" restricts locate settings to LC_MESSAGES, to avoid bugs caused by locale-specific number printing (LC_NUMERIC) and possibly others. We need LC_CTYPE too to make messages with chars outside us-ascii work correctly. Add it. Reported-by:

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

On 12/18/2015 06:19 PM, Pavel Fedin wrote: Hello! I realize that it's perhaps too late, because patches are already on Linux-next, but i have one concern... May be it's not too late... I dislike implementing architecture-dependent exit code where we could implement an

[Qemu-devel] [PULL 37/48] block: Remove prototype of bdrv_swap from header

From: Fam Zheng The function has gone. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- include/block/block.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/block/block.h b/include/block/block.h index bce0d86..db8e096

Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState

On Fri, 18 Dec 2015 13:51:49 -0200 Eduardo Habkost wrote: > On Fri, Dec 18, 2015 at 11:46:05AM +0100, Igor Mammedov wrote: > > On Thu, 17 Dec 2015 16:09:23 -0200 > > Eduardo Habkost wrote: > > > > > On Wed, Dec 16, 2015 at 11:26:20PM +0100, Igor

Re: [Qemu-devel] [PATCH v3 11/24] error: Use error_reportf_err() where it makes obvious sense

On 12/18/2015 08:35 AM, Markus Armbruster wrote: > Done with this Coccinelle semantic patch > > @@ > expression FMT, E, S; > expression list ARGS; > @@ > -error_report(FMT, ARGS, error_get_pretty(E)); > +error_reportf_err(E, FMT/*@@@*/, ARGS); > ( > -

Re: [Qemu-devel] [PULL v4 0/9] Introduce I/O channels framework

On 18 December 2015 at 12:20, Daniel P. Berrange wrote: > The following changes since commit 6a6533213d78dea4407fe6933ad489796b582599: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2015-12-17 18:07:09 +) > > are available in the

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On 18 December 2015 at 13:41, Paolo Bonzini wrote: > > > On 18/12/2015 14:35, Dr. David Alan Gilbert wrote: >> > That would not be recursive make, but rather a completely separate >> > Makefile to be manually invoked with -f. >> >> Hmm but wouldn't this Makefile also be a

Re: [Qemu-devel] [PATCH 1/6] hw/vfio/platform: amd-xgbe device

On 17 December 2015 at 12:29, Eric Auger wrote: > This patch introduces the amd-xgbe VFIO platform device. It > allows the guest to do passthrough on a device exposing an > "amd,xgbe-seattle-v1a" compat string. > > Signed-off-by: Eric Auger >

[Qemu-devel] [PULL 46/48] block/qapi: explicitly warn if !has_full_backing_filename

From: John Snow Disambiguate "Backing filename and full backing filename are equivalent" from "full backing filename could not be determined." Signed-off-by: John Snow Message-id: 1450122916-4706-4-git-send-email-js...@redhat.com Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH] scripts: provide a script for checking glib symbol usage

On 18/12/2015 14:35, Dr. David Alan Gilbert wrote: > > That would not be recursive make, but rather a completely separate > > Makefile to be manually invoked with -f. > > Hmm but wouldn't this Makefile also be a good place for small-fast > style check scripts that could be included in make

Re: [Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

Am 18.12.2015 um 14:23 hat Gerd Hoffmann geschrieben: > On Fr, 2015-12-18 at 12:38 +0100, Kevin Wolf wrote: > > Am 10.09.2015 um 17:19 hat Alberto Garcia geschrieben: > > > The QEMU code is not internationalized and assumes that it runs under > > > the C locale, but if we use the GTK+ UI we'll end

Re: [Qemu-devel] [PATCH v3 05/24] error: Improve documentation

On 12/18/2015 08:35 AM, Markus Armbruster wrote: > While there, tighten error_append_hint()'s assertion. > > Signed-off-by: Markus Armbruster > --- > include/qapi/error.h | 20 ++-- > util/error.c | 2 +- > util/qemu-error.c| 8 > 3

  1   2   3   >