Re: [Qemu-devel] [PATCH 4/5] gt64120: convert to realize()

Cc: qemu-triv...@nongnu.org On 18/12/2015 12:03, Cao jin wrote: > Signed-off-by: Cao jin > --- > hw/mips/gt64xxx_pci.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c > index

[Qemu-devel] [PATCH v3 15/24] qemu-io qemu-nbd: Use error_report() etc. instead of fprintf()

Just three instances left. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qemu-io.c | 8 +++- qemu-nbd.c | 2 +- tests/qemu-iotests/059.out | 8 tests/qemu-iotests/060.out | 2 +-

[Qemu-devel] [PATCH v3 07/24] qemu-nbd: Clean up "Failed to load snapshot" error message

bdrv_snapshot_load_tmp() sets an error and returns -errno on failure. We report both even though the error message is self-contained. Drop the redundant strerror(). While there: setting errno right before exit() is pointless, so drop that, too. Signed-off-by: Markus Armbruster

[Qemu-devel] [PATCH v3 00/24] Error reporting cleanups and fixes

Two topics: 1. Avoid error_get_pretty() when all you want is extend an error message. Doing that with error_get_pretty() loses the error hint. Provide that don't lose it, and are more convenient to use. 2. Newlines in error messages. Jason Herne's "[PATCH v2] checkpatch: Detect newlines in

Re: [Qemu-devel] [PULL 0/2] xsa155

Michael, could you please backport these two patches? They should apply fine. On Fri, 18 Dec 2015, Stefano Stabellini wrote: > The following changes since commit 18f49881cf8359e89396aac12f5d3cf3f8a632ba: > > configure: Fix shell syntax to placate OpenBSD's pdksh (2015-12-18 13:32:49 > +)

Re: [Qemu-devel] [PATCH v2] checkpatch: Detect newlines in error_report and other error functions

Markus Armbruster writes: > "Jason J. Herne" writes: > >> On 12/14/2015 10:40 AM, Markus Armbruster wrote: >>> "Jason J. Herne" writes: >>> On 12/14/2015 07:47 AM, Markus Armbruster wrote: > "Jason J. Herne"

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

Hello! I realize that it's perhaps too late, because patches are already on Linux-next, but i have one concern... May be it's not too late... I dislike implementing architecture-dependent exit code where we could implement an architecture-independent one. As far as i understand this code,

[Qemu-devel] [PULL 17/48] blockdev: Set 'format' indicates non-empty drive

Creating an empty drive while specifying 'format' doesn't make sense. The specified format driver would simply be ignored. Make a set 'format' option an indication that a non-empty drive should be created. This makes 'format' consistent with 'driver' and allows using it with a block driver that

Re: [Qemu-devel] [PATCH COLO-Frame v12 21/38] COLO failover: Introduce a new command to trigger a failover

* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > We leave users to choose whatever heartbeat solution they want, if the > heartbeat > is lost, or other errors they detect, they can use experimental command > 'x_colo_lost_heartbeat' to tell COLO to do failover, COLO will do operations >

[Qemu-devel] [PULL 07/48] block: Allow references for backing files

For bs->file, using references to existing BDSes has been possible for a while already. This patch enables the same for bs->backing. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block.c | 48

[Qemu-devel] [PULL 13/48] block: reopen: Document option precedence and refactor accordingly

The interesting part of reopening an image is from which sources the effective options should be taken, i.e. which options take precedence over which other options. This patch documents the precedence that will be implemented in the following patches. It also refactors bdrv_reopen_queue(), so

[Qemu-devel] [PULL v1 4/5] crypto: add QCryptoSecret object class for password/key handling

Introduce a new QCryptoSecret object class which will be used for providing passwords and keys to other objects which need sensitive credentials. The new object can provide secret values directly as properties, or indirectly via a file. The latter includes support for file descriptor passing

Re: [Qemu-devel] [RFC PATCH 0/2] Add GIC ITS description in ACPI MADT table

On 29 November 2015 at 08:22, Shannon Zhao wrote: > From: Shannon Zhao > > These two patches add ITS description in ACPI MADT table. It bases on > Pavel Fedin's ITS series[1]. > >

Re: [Qemu-devel] [PATCH v3 04/11] fdc: add default drive type option

On 12/18/2015 10:54 AM, Markus Armbruster wrote: > John Snow writes: > >> This patch adds a new explicit Floppy Drive Type option. The existing >> behavior in QEMU is to automatically guess a drive type based on the >> media inserted, or if a diskette is not present,

Re: [Qemu-devel] [PATCH COLO-Frame v12 23/38] COLO: Implement failover work for Primary VM

* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > For PVM, if there is failover request from users. > The colo thread will exit the loop while the failover BH does the > cleanup work and resumes VM. > > Signed-off-by: zhanghailiang > Signed-off-by: Li

Re: [Qemu-devel] [PATCH v3 05/11] fdc: Add fallback option

On 12/18/2015 10:57 AM, Markus Armbruster wrote: > John Snow writes: > >> Add the fallback drive type as an option so we can control >> the behavior as a function of the QEMU machine version. > > What's a "fallback drive type", and what does (or will) it do? > I assume you

Re: [Qemu-devel] [PULL v1 0/5] Support for securely passing secrets to QEMU

On 18 December 2015 at 16:53, Daniel P. Berrange wrote: > The following changes since commit 18f49881cf8359e89396aac12f5d3cf3f8a632ba: > > configure: Fix shell syntax to placate OpenBSD's pdksh (2015-12-18 13:32:49 > +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH 1/5] SH PCI Host: convert to realize()

Cc: qemu-triv...@nongnu.org On 18/12/2015 12:03, Cao jin wrote: > Signed-off-by: Cao jin > --- > hw/sh4/sh_pci.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/sh4/sh_pci.c b/hw/sh4/sh_pci.c > index a2f6d9e..4509053 100644 > ---

Re: [Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

>> > We do however have translations for a few simple strings for the GTK+ >> > menu items, so in order to run QEMU using the C locale, and yet have a >> > translated UI let's use setlocale() for LC_MESSAGES only. >> > >> Not sure why I noticed it only now and if it's related to any recent >>

[Qemu-devel] [PULL 24/48] qemu-iotests: Test reopen with node-name/driver options

'node-name' and 'driver' should not be changed during a reopen operation. It is, however, valid to specify them with the same value as they already had. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- tests/qemu-iotests/133 | 90

[Qemu-devel] [PULL 29/48] qcow2: Split upgrade/downgrade paths for amend

From: Max Reitz If the image version should be upgraded, that is the first we should do; if it should be downgraded, that is the last we should do. So split the version change block into an upgrade part at the start and a downgrade part at the end. Signed-off-by: Max Reitz

[Qemu-devel] [PATCH 2/2] qdev: safely fail device_add if unable to allocate device

qdev_device_add() currently uses object_new() which will abort if there memory allocation for device instance fails. While it's fine it startup, it is not desirable diring hotplug. Try to allocate memory for object first and fail safely if allocation fails. Signed-off-by: Igor Mammedov

[Qemu-devel] [PULL 32/48] qcow2: Invoke refcount order amendment function

From: Max Reitz Make use of qcow2_change_refcount_order() to support changing the refcount order with qemu-img amend. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/qcow2.c | 44

[Qemu-devel] [PULL 15/48] block: Split out parse_json_protocol()

The next patch distinguishes options that were explicitly set and options that were derived. bdrv_fill_option() added options of both types: Options given by json: syntax should be counted as explicit, but the rest is derived. In preparation for the distinction, move json: parse to a separate

[Qemu-devel] [PATCH 2/2] vhdx: Simplify vhdx_set_shift_bits()

For values which are powers of two (and we do assume all of these to be), sizeof(x) * 8 - 1 - clz(x) == ctz(x). Therefore, use ctz(). Signed-off-by: Max Reitz --- block/vhdx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/vhdx.c

[Qemu-devel] [PATCH v3 09/24] error: New error_prepend(), error_reportf_err()

Instead of simply propagating an error verbatim, we sometimes want to add to its message, like this: frobnicate(arg, ); error_setg(errp, "Can't frobnicate %s: %s", arg, error_get_pretty(err)); error_free(err); This is suboptimal, because it loses err's hint (if

[Qemu-devel] [PATCH v3 03/24] error: Use error_report_err() instead of monitor_printf()

Both error_report_err() and monitor_printf() print to the same destination when monitor_printf() is used correctly, i.e. within an HMP monitor. Elsewhere, monitor_printf() does nothing, while error_report_err() reports to stderr. Most changed functions are HMP command handlers. These should

[Qemu-devel] [PATCH v3 05/24] error: Improve documentation

While there, tighten error_append_hint()'s assertion. Signed-off-by: Markus Armbruster --- include/qapi/error.h | 20 ++-- util/error.c | 2 +- util/qemu-error.c| 8 3 files changed, 23 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 2/2] qdev: safely fail device_add if unable to allocate device

On Fri, Dec 18, 2015 at 04:30:47PM +0100, Igor Mammedov wrote: > qdev_device_add() currently uses object_new() which > will abort if there memory allocation for device instance > fails. While it's fine it startup, it is not desirable > diring hotplug. > > Try to allocate memory for object first

Re: [Qemu-devel] [PATCH v4] linux-user: add signalfd/signalfd4 syscalls

Le 06/10/2015 10:16, Riku Voipio a écrit : > On perjantaina 2. lokakuuta 2015 15.48.09 EEST, Laurent Vivier wrote: >> This patch introduces a system very similar to the one used in the kernel >> to attach specific functions to a given file descriptor. > > Thanks, applied to linux-user When

[Qemu-devel] [PULL 2/2] xenfb: avoid reading twice the same fields from the shared page

Reading twice the same field could give the guest an attack of opportunity. In the case of event->type, gcc could compile the switch statement into a jump table, effectively ending up reading the type field multiple times. This is part of XSA-155. Signed-off-by: Stefano Stabellini

Re: [Qemu-devel] [PATCH] linux-user, sh4: fix signal retcode address

Ping ? Le 23/11/2015 11:38, Laurent Vivier a écrit : > To return from a signal, setup_frame() puts an instruction to > be executed in the stack. This sequence calls the syscall sigreturn(). > > The address of the instruction must be set in the PR register > to be executed. > > This patch fixes

Re: [Qemu-devel] [PATCH] fix MSI injection on Xen

On Wed, 2 Dec 2015, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2015 at 05:16:18PM +, Stefano Stabellini wrote: > > On Wed, 2 Dec 2015, Michael S. Tsirkin wrote: > > > On Wed, Dec 02, 2015 at 04:56:21PM +, Stefano Stabellini wrote: > > > > On Xen MSIs can be remapped into pirqs, which are

[Qemu-devel] [PULL v1 3/5] qga: convert to use error checked base64 decode

Switch from using g_base64_decode over to qbase64_decode in order to get error checking of the base64 input data. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qga/commands-posix.c | 11 +-- qga/commands-win32.c | 11 +--

[Qemu-devel] [PATCH 1/2] qom: add object_class_get_instance_size()

it will be used for allocating memory for a to be created new object in safe manner. Signed-off-by: Igor Mammedov --- include/qom/object.h | 8 qom/object.c | 5 + 2 files changed, 13 insertions(+) diff --git a/include/qom/object.h

[Qemu-devel] [PULL 1/2] xen/blkif: Avoid double access to src->nr_segments

src is stored in shared memory and src->nr_segments is dereferenced twice at the end of the function. If a compiler decides to compile this into two separate memory accesses then the size limitation could be bypassed. Fix it by removing the double access to src->nr_segments. This is part of

[Qemu-devel] [PULL 33/48] qcow2: Point to amend function in check

From: Max Reitz If a reference count is not representable with the current refcount order, the image check should point to qemu-img amend for increasing the refcount order. However, qemu-img amend needs write access to the image which cannot be provided if the image is marked

Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices

On Thu, Dec 17, 2015 at 3:12 AM, Paolo Bonzini wrote: > > > On 17/12/2015 12:11, Peter Maydell wrote: >> > It's a hack and I don't want it to become a sanctioned way to do it. >> > It's already messing around pretty heavily with qdev internals, see the >> > line right after

[Qemu-devel] [PATCH v3 23/24] s390/sclp: Simplify control flow in sclp_realize()

Suggested-by: David Hildenbrand Signed-off-by: Markus Armbruster Reviewed-by: David Hildenbrand Acked-by: Cornelia Huck Reviewed-by: Eric Blake --- hw/s390x/sclp.c | 9 +++--

[Qemu-devel] [PATCH v2] qga: Support enum names in guest-file-seek

Magic constants are a pain to use, especially when we run the risk that our choice of '1' for QGA_SEEK_CUR might differ from the host or guest's choice of SEEK_CUR. Better is to use an enum value, via a qapi alternate type for back-compatibility. With this, {"command":"guest-file-seek",

Re: [Qemu-devel] [PATCH v3 6/9] target-arm: support QMP dump-guest-memory

On Fri, Dec 18, 2015 at 04:31:13PM +, Peter Maydell wrote: > On 18 December 2015 at 16:05, Andrew Jones wrote: > > On Fri, Dec 18, 2015 at 11:59:39AM +, Peter Maydell wrote: > >> On 15 December 2015 at 22:51, Andrew Jones wrote: > >> > Add the

[Qemu-devel] [PATCH v3 16/24] error: Strip trailing '\n' from error string arguments (again)

Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they keep coming back. Tracked down with the Coccinelle semantic patch from commit 312fd5f. Cc: Fam Zheng Cc: Peter Crosthwaite Cc: Bharata B Rao Cc: Dominik

[Qemu-devel] [PULL 19/48] block: reopen: Extract QemuOpts for generic block layer options

This patch adds a QemuOpts for generic block layer options to bdrv_reopen_prepare(). The only two options that currently exist (node-name and driver) cannot be changed, so the only thing we do is putting them right back into the QDict so that we check at the end that they are indeed unchanged. We

Re: [Qemu-devel] [PATCH v6 1/2] mirror: Rewrite mirror_iteration

On 20.11.2015 11:12, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iteration to fix both flaws. > >

[Qemu-devel] [PATCH v3 22/24] hw/s390x: Rename local variables Error *l_err to just err

Let's follow established naming practice here as well. Cc: David Hildenbrand Signed-off-by: Markus Armbruster Acked-by: Cornelia Huck Reviewed-by: David Hildenbrand Reviewed-by: Eric Blake

[Qemu-devel] [PULL 06/48] mirror: Error out when a BDS would get two BBs

bdrv_replace_in_backing_chain() asserts that not both old and new BlockDdriverState have a BlockBackend attached to them because both would have to end up pointing to the new BDS and we don't support more than one BB per BDS yet. Before we can safely allow references to existing nodes as backing

[Qemu-devel] [PULL 36/48] raw-posix: Make aio=native option binding

Traditionally, aio=native was treated as an advice that could simply be ignored if an error occurs while initialising Linux AIO or the feature wasn't compiled in. This behaviour was deprecated in commit 96518254 (qemu 2.3; error during init) and commit 1501ecc1 (qemu 2.5; not compiled in). This

[Qemu-devel] [PULL 22/48] qemu-iotests: Try setting cache mode for children

This is a basic test for specifying cache modes for child nodes on the command line. It doesn't take much time and works without O_DIRECT support. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- tests/qemu-iotests/051 | 10 +++-

[Qemu-devel] [PULL 45/48] block/qapi: always report full_backing_filename

From: John Snow Always report full_backing_filename, even if it's the same as backing_filename. In the next patch, full_backing_filename may be omitted if it cannot be generated instead of allowing e.g. drive_query to abort if it runs into this scenario. The presence or

Re: [Qemu-devel] [PATCH 6/6] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation

On 17 December 2015 at 12:29, Eric Auger wrote: > This patch allows the instantiation of the vfio-amd-xgbe device > from the QEMU command line (-device vfio-amd-xgbe,host=""). > > The guest is exposed with a device tree node that combines the description > of both XGBE and

Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices

On 18/12/2015 18:17, Alistair Francis wrote: > Does anyone have any ideas on how we can do this? > > AFAIK there is no way to currently do this, so we need to add > something. What is the preferred way to expose the buses? For now, what you're doing is okay for me, just moving the funky code

Re: [Qemu-devel] [PATCH v3 01/11] fdc: move pick_geometry

On 12/16/2015 03:16 PM, John Snow wrote: > Code motion: I want to refactor this function to work with FDrive > directly, so shuffle it below that definition. > > Signed-off-by: John Snow > --- > hw/block/fdc.c | 90 > +-

Re: [Qemu-devel] [PATCH v3 6/9] target-arm: support QMP dump-guest-memory

On 18 December 2015 at 16:05, Andrew Jones wrote: > On Fri, Dec 18, 2015 at 11:59:39AM +, Peter Maydell wrote: >> On 15 December 2015 at 22:51, Andrew Jones wrote: >> > Add the support needed for creating prstatus elf notes. This >> > allows us to use

[Qemu-devel] [PULL 02/48] iotests: 124: move incremental failure test

From: John Snow Code motion only, in preparation for adjusting the setUp procedure for this test. Signed-off-by: John Snow Signed-off-by: Kevin Wolf --- tests/qemu-iotests/124 | 117 + 1

[Qemu-devel] [PATCH v3 06/24] block: Clean up "Could not create temporary overlay" error message

bdrv_create() sets an error and returns -errno on failure. When the latter is interesting, the error is created with error_setg_errno(). bdrv_append_temp_snapshot() uses the error's message to create a new one with error_setg_errno(). This adds a strerror() that is either uninteresting or

Re: [Qemu-devel] [PATCH 5/5] xen-pvdevice: convert to realize()

CCing Stefano, who is the maintainer. Paolo On 18/12/2015 12:03, Cao jin wrote: > Signed-off-by: Cao jin > --- > hw/i386/xen/xen_pvdevice.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/hw/i386/xen/xen_pvdevice.c

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

On Fri, Dec 18, 2015 at 8:01 AM, Paolo Bonzini wrote: > > > On 18/12/2015 16:19, Pavel Fedin wrote: >> As far as i understand this code, KVM_EXIT_HYPERV is called when one >> of three MSRs are accessed. But, shouldn't we have implemented >> instead something more generic,

Re: [Qemu-devel] [PATCH 10/10] iotests: 095: Use TEST_IMG override instead of "mv"

On 16.12.2015 10:54, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/095 | 12 ++-- > tests/qemu-iotests/095.out | 8 > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/tests/qemu-iotests/095

Re: [Qemu-devel] [PATCH 00/10] iotests: Clean up "mv $TEST_IMG $TEST_IMG.XXX"

On 16.12.2015 10:54, Fam Zheng wrote: > Commit 794d00f71d fixed two "mv" commands into the TEST_IMG override approach. > There are still more occasions of "mv", this series fixes them. > > The benefit is it drops the assumption that the created image is a single > file, > which is not true for

Re: [Qemu-devel] [PATCH] hw/q35: fix pc-q35-1.6 machine options

On Thu, Dec 17, 2015 at 07:34:07PM +0200, Marcel Apfelbaum wrote: > Following the convention each machine_options function should call > the next machine options first. > > Signed-off-by: Marcel Apfelbaum Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

On Fri, Dec 18, 2015 at 05:01:59PM +0100, Paolo Bonzini wrote: > On 18/12/2015 16:19, Pavel Fedin wrote: > > As far as i understand this code, KVM_EXIT_HYPERV is called when one > > of three MSRs are accessed. But, shouldn't we have implemented > > instead something more generic, like

[Qemu-devel] [PATCH v3 1/2] i386: expose floppy-related objects in SSDT

On x86-based systems Linux determines the presence and the type of floppy drives via a query of a CMOS field. So does SeaBIOS when populating the return data for int 0x13 function 0x08. Windows doesn't; instead, it requests this information from BIOS via int 0x13/0x08 or through ACPI objects

Re: [Qemu-devel] [PATCH v2 07/14] acpi: Remove guest_info parameters from functions

On 12/18/2015 08:08 PM, Eduardo Habkost wrote: On Tue, Dec 15, 2015 at 02:36:10PM +0200, Marcel Apfelbaum wrote: On 12/11/2015 08:42 PM, Eduardo Habkost wrote: We can use PC_MACHINE(qdev_get_machine())->acpi_guest_info to get guest_info. Hi Eduardo, I like the idea of using

Re: [Qemu-devel] [PATCH v3 6/9] target-arm: support QMP dump-guest-memory

On Fri, Dec 18, 2015 at 06:46:14PM +, Peter Maydell wrote: > On 18 December 2015 at 18:05, Andrew Jones wrote: > > On Fri, Dec 18, 2015 at 04:31:13PM +, Peter Maydell wrote: > >> On 18 December 2015 at 16:05, Andrew Jones wrote: > >> > On Fri, Dec

[Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

Update the expected SSDTs to reflect the changes introduced in the previous patch. Signed-off-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin CC: Igor Mammedov CC: Paolo Bonzini

[Qemu-devel] [PATCH v3 0/2] i386: expose floppy-related objects in SSDT

Roman Kagan (2): i386: expose floppy-related objects in SSDT tests: update expected SSDT for floppy changes Signed-off-by: Roman Kagan Signed-off-by: Denis V. Lunev CC: Michael S. Tsirkin CC: Igor Mammedov CC:

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

On 18/12/2015 19:10, Peter Hornyack wrote: > On brief inspection of Andrey's patch (I have not been following > closely) it looks like the kvm_hyperv_exit struct that's returned to > userspace contains more data (control, evt_page, and msg_page fields) > than simply the value of the MSR, so

Re: [Qemu-devel] [PATCH v4 5/5] kvm/x86: Hyper-V kvm exit

On Fri, Dec 18, 2015 at 10:10:11AM -0800, Peter Hornyack wrote: > On Fri, Dec 18, 2015 at 8:01 AM, Paolo Bonzini wrote: > > On 18/12/2015 16:19, Pavel Fedin wrote: > >> As far as i understand this code, KVM_EXIT_HYPERV is called when one > >> of three MSRs are accessed. But,

Re: [Qemu-devel] [PATCH v3 06/11] fdc: do not call revalidate on eject

On 12/18/2015 11:11 AM, Markus Armbruster wrote: > John Snow writes: > >> Currently, fd_revalidate is called in two different places, with two >> different expectations of behavior: >> >> (1) On initialization, as a routine to help pick the drive type and >> initial

Re: [Qemu-devel] [PATCH 2/5] igd-passthrough-i440FX: convert to realize()

On Fri, Dec 18, 2015 at 07:03:49PM +0800, Cao jin wrote: > Signed-off-by: Cao jin > --- > hw/pci-host/piix.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c > index 715208b..e3840f0

Re: [Qemu-devel] [PATCH v3 6/9] target-arm: support QMP dump-guest-memory

On 18 December 2015 at 18:05, Andrew Jones wrote: > On Fri, Dec 18, 2015 at 04:31:13PM +, Peter Maydell wrote: >> On 18 December 2015 at 16:05, Andrew Jones wrote: >> > On Fri, Dec 18, 2015 at 11:59:39AM +, Peter Maydell wrote: >> >> I don't

[Qemu-devel] x-input-send-event marked as experimental

Gerd, commit df5b2adb7398d71016ee469f71e52075ed95e04e Author: Gerd Hoffmann Date: Tue Nov 25 14:54:17 2014 +0100 input: move input-send-event into experimental namespace Ongoing discussions on how we are going to specify the console, so tag the command as

Re: [Qemu-devel] [PATCH] gtk: use setlocale() for LC_MESSAGES only

Alberto Garcia writes: >>> > We do however have translations for a few simple strings for the GTK+ >>> > menu items, so in order to run QEMU using the C locale, and yet have a >>> > translated UI let's use setlocale() for LC_MESSAGES only. >>> > >>> Not sure why I noticed it

Re: [Qemu-devel] x-input-send-event marked as experimental

Marcelo Tosatti writes: > Gerd, > > commit df5b2adb7398d71016ee469f71e52075ed95e04e > Author: Gerd Hoffmann > Date: Tue Nov 25 14:54:17 2014 +0100 > > input: move input-send-event into experimental namespace > > Ongoing discussions on how

Re: [Qemu-devel] [PATCH 08/11] qjson: Simplify by using json-output-visitor

On 12/11/2015 04:10 AM, Paolo Bonzini wrote: > > > On 11/12/2015 00:53, Eric Blake wrote: >> Instead of rolling our own limited JSON outputter, we can just >> wrap the more full-featured JSON output Visitor. >> >> This slightly changes the output (different spacing), but the >> result is still

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

Hi Kevin & Paolo, Luckily, I reproduced this problem last night. And I got the below log when SeaBIOS is stuck. [BTW, the whole SeaBIOS log attached] [2015-12-18 10:38:10] >gonglei: enter smp_setup()... [2015-12-18 10:38:10] >gonglei: begine to enable local APIC... [2015-12-18

[Qemu-devel] ping Re: [PATCH v12] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

https://patchwork.ozlabs.org/patch/555945/ On Dec 11, 2015, at 10:27 PM, Programmingkid wrote: > Mac OS X can be picky when it comes to allowing the user > to use physical devices in QEMU. Most mounted volumes > appear to be off limits to QEMU. If an issue is detected, > a message is displayed

Re: [Qemu-devel] [PATCH 4/6] device_tree: qemu_fdt_getprop converted to use the error API

On 17 December 2015 at 12:29, Eric Auger wrote: > Current qemu_fdt_getprop exits if the property is not found. It is > sometimes needed to read an optional property, in which case we do > not wish to exit but simply returns a null value. > > This patch converts

[Qemu-devel] [PATCH v3 18/24] vmdk: Clean up "Invalid extent lines" error message

vmdk_parse_extents() reports parse errors like this: error_setg(errp, "Invalid extent lines:\n%s", p); where p points to the beginning of the malformed line in the image descriptor. This results in a multi-line error message Invalid extent lines: Error messages should not

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

On Fri, Dec 18, 2015 at 03:04:58AM +, Gonglei (Arei) wrote: > Hi Kevin & Paolo, > > Luckily, I reproduced this problem last night. And I got the below log when > SeaBIOS is stuck. [...] > [2015-12-18 10:38:10] gonglei: finish while [...] > <...>-31509 [035] 154753.180077: kvm_exit:

[Qemu-devel] [Bug 1527765] Re: sh4: ghc randomly segfaults on qemu-sh4-static

Thank you for the 611 MB tar The behavior is a little bit different on my system: root@Quad:~# ls ghc-7.8.4 ghc_7.8.4-9~bpo8+1.dsc ghc_7.8.4-9~bpo8+1.debian.tar.xz ghc_7.8.4.orig.tar.xz root@Quad:~# cd ghc-7.8.4/utils/ghc-p ghc-pkg/ ghc-pwd/ root@Quad:~# cd

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Notice about lock bitmask translation for fcntl

On 12/18/15 17:37, Laurent Vivier wrote: > > Le 18/12/2015 07:26, Chen Gang a écrit : >> >> For fcntl, it always needs to notice about it, just like do_fcntl() has >> done, or it will cause issue (e.g. alpha host run i386 guest). >> >> Signed-off-by: Chen Gang >> ---

[Qemu-devel] [Bug 1527765] [NEW] sh4: ghc randomly segfaults on qemu-sh4-static

Public bug reported: Hello! I am currently in the process of bootstrapping ghc for the Debian sh4 port and ran into a strange problem with qemu-sh4-static which randomly segfaults when running ghc to compile a Haskell source: root@jessie32:~/ghc-7.8.4/utils/ghc-pwd# ls Main.hi Main.hs

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Notice about lock bitmask translation for fcntl

On 12/19/15 06:15, Laurent Vivier wrote: > > Le 18/12/2015 23:12, Chen Gang a écrit : >> [...] >> >> OK, thank you very much. I shall config my email client again to notice >> about it. > > You should not use your email client to send patches, you should use > "git send-email": > >

Re: [Qemu-devel] [PATCH 2/2] qdev: safely fail device_add if unable to allocate device

Eric Blake writes: > On 12/18/2015 09:48 AM, Daniel P. Berrange wrote: >> On Fri, Dec 18, 2015 at 04:30:47PM +0100, Igor Mammedov wrote: >>> qdev_device_add() currently uses object_new() which >>> will abort if there memory allocation for device instance >>> fails. While it's

Re: [Qemu-devel] Jobs 2.0 QAPI [RFC]

On 12/18/2015 02:24 PM, John Snow wrote: >> To be subclassable, we need a flat union, and the discriminator must be >> non-optional within that union. Either 'options' is that flat union >> (and we have a layer of {} nesting in QMP}, or we directly make the >> 'data' of job-cancel be the flat

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Notice about lock bitmask translation for fcntl

Le 18/12/2015 22:40, Chen Gang a écrit : > > On 12/18/15 17:37, Laurent Vivier wrote: >> >> Le 18/12/2015 07:26, Chen Gang a écrit : >>> >>> For fcntl, it always needs to notice about it, just like do_fcntl() has >>> done, or it will cause issue (e.g. alpha host run i386 guest). >>> >>>

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: Reduce racy output in 028

On 12/11/2015 06:23 PM, John Snow wrote: > ping > > On 12/10/2015 10:27 PM, Eric Blake wrote: >> On my machine, './check -qcow2 028' was failing about 80% of the >> time, due to a race in how many times the repeated attempts >> to run 'info block-jobs' could occur before the job was done, >>

Re: [Qemu-devel] [PATCH 2/5] igd-passthrough-i440FX: convert to realize()

One short remark in addition to Eduardo's review. Eduardo Habkost writes: > On Fri, Dec 18, 2015 at 07:03:49PM +0800, Cao jin wrote: >> Signed-off-by: Cao jin >> --- >> hw/pci-host/piix.c | 16 +--- >> 1 file changed, 9 insertions(+),

Re: [Qemu-devel] Jobs 2.0 QAPI [RFC]

On 12/18/2015 01:07 PM, Eric Blake wrote: > On 12/16/2015 05:50 PM, John Snow wrote: >> In working through a prototype to enable multiple block jobs. A few >> problem spots in our API compatibility become apparent. >> > >> qmp_query_block_jobs >> > >> Let's consider using a new

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: Reduce racy output in 028

On 12/18/2015 03:46 PM, Eric Blake wrote: > On 12/11/2015 06:23 PM, John Snow wrote: >> > > ping > >> >> On 12/10/2015 10:27 PM, Eric Blake wrote: >>> On my machine, './check -qcow2 028' was failing about 80% of the >>> time, due to a race in how many times the repeated attempts >>> to run

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Notice about lock bitmask translation for fcntl

On 12/19/15 05:58, Laurent Vivier wrote: > > Le 18/12/2015 22:40, Chen Gang a écrit : >> [...] >> I did not get any script/checkpatch.pl complains, originally. >> >> Does my email client configuration is incorrect, then cause incorrect >> mail format? I guess not. The related reason is below.

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Notice about lock bitmask translation for fcntl

Le 18/12/2015 23:12, Chen Gang a écrit : > > On 12/19/15 05:58, Laurent Vivier wrote: >> >> Le 18/12/2015 22:40, Chen Gang a écrit : >>> > > [...] > >>> I did not get any script/checkpatch.pl complains, originally. >>> >>> Does my email client configuration is incorrect, then cause incorrect

[Qemu-devel] [Bug 1174654] Re: qemu-system-x86_64 takes 100% CPU after host machine resumed from suspend to ram

Same for me here, Ubuntu wily. I'm using vagrant-libvirt, and my hosts also very often run wild with 100% cpu usage after suspend. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1174654 Title:

Re: [Qemu-devel] RFC: Operation Blockers in QEMU Block Nodes

On Fri, Dec 18, 2015 at 03:19:25PM +0100, Kevin Wolf wrote: > Am 16.12.2015 um 07:25 hat Jeff Cody geschrieben: > > Background: > > > > Block jobs, and other QAPI operations, may modify and impact the > > BlockDriverState graph in QEMU. In order to support multiple > > operations

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

> > From: Kevin O'Connor [mailto:ke...@koconnor.net] > Sent: Saturday, December 19, 2015 7:13 AM > To: Gonglei (Arei) > Cc: Xulei (Stone); Paolo Bonzini; qemu-devel; seab...@seabios.org; > Huangweidong (C); k...@vger.kernel.org > Subject: Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure

<    1   2   3